[Qemu-devel] [PATCH 3/4] colo-compare: Fix comments

2017-10-12 Thread Mao Zhongyi
Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Signed-off-by: Mao Zhongyi Signed-off-by: Zhang Chen --- net/colo-compare.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index 5d2429b..ccdcba2 100644 --- a/net/colo-compare.c +

[Qemu-devel] [PATCH 0/4] Optimize COLO-compare performance

2017-10-12 Thread Mao Zhongyi
In this series, adjust the way that the packet are queued and compared to improve the colo net performence. Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Mao Zhongyi (4): colo-compare: Insert packet into the suitable position of packet queue directly colo-compare: compare the packet in

[Qemu-devel] [PATCH 4/4] colo: Consolidate the duplicate code chunk into a routine

2017-10-12 Thread Mao Zhongyi
Consolidate the code that extract the ip address(src,dst) and port number(src,dst) of the packet into a separate routine extract_ip_and_port() since the same chunk of code is called from two place. Cc: Zhang Chen Cc: Li Zhijian Cc: Jason Wang Signed-off-by: Mao Zhongyi --- net/colo.c | 18 +++

[Qemu-devel] [PATCH 1/4] colo-compare: Insert packet into the suitable position of packet queue directly

2017-10-12 Thread Mao Zhongyi
Currently, a packet from pri_dev or sec_dev is fristly pushed at the tail of the primary or secondary packet queue then sorted by the tcp sequence number. Now, this patch use g_queue_insert_sorted to insert the packet directly into the suitable position to avoid ordering all packets each time when

[Qemu-devel] [PATCH 2/4] colo-compare: compare the packet in a specified Connection

2017-10-12 Thread Mao Zhongyi
A package from pri_indev or sec_indev only belongs to a particular Connection, so we only need to compare the package in the specified Connection's primary_list and secondary_list, rather than for each the whole Connection list to compare. This is time-consuming and unnecessary. Less checkpoint mo

Re: [Qemu-devel] [PATCH v2] oslib-posix: Fix compiler warning and some data types

2017-10-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171013054842.32120-1...@weilnetz.de Subject: [Qemu-devel] [PATCH v2] oslib-posix: Fix compiler warning and some data types === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

[Qemu-devel] [PATCH v2] oslib-posix: Fix compiler warning and some data types

2017-10-12 Thread Stefan Weil
gcc warning: /qemu/util/oslib-posix.c:304:11: error: variable ‘addr’ might be clobbered by ‘longjmp’ or ‘vfork’ [-Werror=clobbered] Fix also some related data types: numpages, hpagesize are used as pointer offset. Always use size_t for them and for the derived numpages_per_thread. Avoid a typ

Re: [Qemu-devel] [RFC v2 10/33] migration: allow dst vm pause on postcopy

2017-10-12 Thread Peter Xu
On Thu, Oct 12, 2017 at 01:19:52PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Tue, Oct 10, 2017 at 01:30:18PM +0100, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > On Mon, Oct 09, 2017 at 07:58:13PM +0100, Dr. David Alan Gi

Re: [Qemu-devel] [PATCH v1 3/5] xlnx-zcu102: Specify the valid CPUs

2017-10-12 Thread Eduardo Habkost
On Thu, Oct 12, 2017 at 04:59:48PM -0700, Alistair Francis wrote: > On Tue, Oct 10, 2017 at 8:25 AM, Eduardo Habkost wrote: > > On Mon, Oct 09, 2017 at 09:12:29AM +0200, Igor Mammedov wrote: > >> On Fri, 6 Oct 2017 15:06:57 -0700 > >> Alistair Francis wrote: > >> > >> > On Fri, Oct 6, 2017 at 4:4

[Qemu-devel] [PATCH 2/2] MAINTAINERS: Drop Sun4v nonexistent file

2017-10-12 Thread Fam Zheng
Signed-off-by: Fam Zheng --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index da3c78df47..731c5c7ec2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -778,7 +778,6 @@ F: pc-bios/openbios-sparc64 Sun4v M: Artyom Tarasenko S: Maintained -F: hw/sparc64/

[Qemu-devel] [PATCH 1/2] MAINTAINERS: Fix scsi path

2017-10-12 Thread Fam Zheng
Signed-off-by: Fam Zheng --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 772ac209e1..da3c78df47 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -982,7 +982,7 @@ S: Supported F: include/hw/scsi/* F: include/scsi/* F: hw/scsi/* -F

[Qemu-devel] [PATCH 0/2] MAINTAINERS: Two small fixes

2017-10-12 Thread Fam Zheng
Fam Zheng (2): MAINTAINERS: Fix scsi path MAINTAINERS: Drop Sun4v nonexistent file MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.13.5

[Qemu-devel] [PATCH] docker: Don't allocate tty unless DEBUG=1

2017-10-12 Thread Fam Zheng
The existence of tty in the container seems to urge gcc into colorize the output, but the escape chars will clutter the report once turned into email replies on patchew. Move -t to debug mode. Reported-by: Eric Blake Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 4 ++-- 1 file ch

Re: [Qemu-devel] [PATCH] fixup! ppc: spapr: use cpu type name directly

2017-10-12 Thread David Gibson
On Thu, Oct 12, 2017 at 05:45:14PM +0200, Igor Mammedov wrote: > follow up commit that registers host-spapr-cpu-core type unconditionally > "ppc: spapr: register 'host' core type along with the rest of core types" > > makes 'non' machine crash > ppc64-softmmu/qemu-system-ppc64 -M none -device h

Re: [Qemu-devel] [RFC] e1000: Faulty tx checksum offload corrupts packets

2017-10-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1507852743-51639-1-git-send-email-eswi...@skyportsystems.com Subject: [Qemu-devel] [RFC] e1000: Faulty tx checksum offload corrupts packets === TEST SCRIPT BEGIN === #!/bin/b

[Qemu-devel] [PATCH v2 2/5] bcm2836: Use the Cortex-A7 instead of Cortex-A15

2017-10-12 Thread Alistair Francis
The BCM2836 uses a Cortex-A7 not a Cortex-A15. Update the device to use the correct CPU. https://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf Signed-off-by: Alistair Francis --- V2: - Fix the BCM2836 CPU hw/arm/bcm2836.c | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH v2 5/5] xilinx_zynq: : Specify the valid CPUs

2017-10-12 Thread Alistair Francis
List all possible valid CPU options. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- V2: - Fixup alignment hw/arm/xilinx_zynq.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/hw/arm/xilinx_zynq.c b/hw/arm/xilinx_zynq.c index 1836a4ed45..e169bf0a86 100644 ---

[Qemu-devel] [PATCH v2 1/5] netduino2: Specify the valid CPUs

2017-10-12 Thread Alistair Francis
List all possible valid CPU options. Although the board only ever has a Cortex-M3 we mark the Cortex-M4 as supported because the Netduino2 Plus supports the Cortex-M4 and the Netduino2 Plus is similar to the Netduino2. Signed-off-by: Alistair Francis Reviewed-by: Eduardo Habkost Reviewed-by: Ph

[Qemu-devel] [PATCH v2 0/5] Add a valid_cpu_types property

2017-10-12 Thread Alistair Francis
There are numorous QEMU machines that only have a single or a handful of valid CPU options. To simplyfy the management of specificying which CPU is/isn't valid let's create a property that can be set in the machine init. We can then check to see if the user supplied CPU is in that list or not. I h

[Qemu-devel] [PATCH v2 4/5] xlnx-zcu102: Specify the valid CPUs

2017-10-12 Thread Alistair Francis
List all possible valid CPU options. Signed-off-by: Alistair Francis --- An implementation for single CPU machines is still being discussed. A solution proposed by Eduardo is this: 1) Change the default on TYPE_MACHINE to: mc->valid_cpu_types = { TYPE_CPU, NULL }; This will keep the ex

[Qemu-devel] [PATCH v2 3/5] raspi: Specify the valid CPUs

2017-10-12 Thread Alistair Francis
List all possible valid CPU options. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- V2: - Fix the indentation hw/arm/raspi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/arm/raspi.c b/hw/arm/raspi.c index 5941c9f751..2a7e6a40bb 100644 --- a/hw/arm/ras

Re: [Qemu-devel] [RFC] e1000: Faulty tx checksum offload corrupts packets

2017-10-12 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 1507852743-51639-1-git-send-email-eswi...@skyportsystems.com Subject: [Qemu-devel] [RFC] e1000: Faulty tx checksum offload corrupts packets === TEST SCRIPT BEGIN === #!/bin/bash # Testing scr

Re: [Qemu-devel] [PATCH v1 3/5] xlnx-zcu102: Specify the valid CPUs

2017-10-12 Thread Alistair Francis
On Tue, Oct 10, 2017 at 8:25 AM, Eduardo Habkost wrote: > On Mon, Oct 09, 2017 at 09:12:29AM +0200, Igor Mammedov wrote: >> On Fri, 6 Oct 2017 15:06:57 -0700 >> Alistair Francis wrote: >> >> > On Fri, Oct 6, 2017 at 4:45 AM, Eduardo Habkost >> > wrote: >> > > On Fri, Oct 06, 2017 at 10:23:12AM

[Qemu-devel] [RFC] e1000: Faulty tx checksum offload corrupts packets

2017-10-12 Thread Ed Swierk via Qemu-devel
The transmit checksum offload implementation in QEMU's e1000 device is deficient and causes packet data corruption in some situations. According to the Intel 8254x software developer's manual[1], the device maintains two separate contexts: the TCP segmentation offload context includes parameters f

[Qemu-devel] [PATCH 3/4] multiboot: load elf sections and section headers

2017-10-12 Thread Anatol Pomozov
Multiboot may load section headers and all sections (even those that are not part of any segment) to target memory. Tested with an ELF application that uses data from strings table section. Signed-off-by: Anatol Pomozov --- hw/core/loader.c | 8 +-- hw/i386/multiboot.c

[Qemu-devel] [PATCH 2/4] multiboot: load any machine type of ELF

2017-10-12 Thread Anatol Pomozov
x86 is not the only architecture supported by multiboot. For example GRUB supports MIPS architecture as well. Signed-off-by: Anatol Pomozov --- hw/i386/multiboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c index c9254f313e..7dac

[Qemu-devel] [PATCH 4/4] multiboot: make tests work with clang

2017-10-12 Thread Anatol Pomozov
* clang 3.8 enables SSE even for 32bit code. Generate code for pentium CPU to make sure no new instructions are used. * add memset() implementation. Clang implements array zeroing in print_num() via memset() function call. --- tests/multiboot/Makefile| 2 +- tests/multiboot/libc.c

[Qemu-devel] (no subject)

2017-10-12 Thread Anatol Pomozov
It is V3 of multiboot improvements to Qemu Changes made sinse V2: - rebase on top of qemu master changes - make multiboot/sections test more reliable Add generate_sections_out.py script that generates ELF sections information - rename 'struct section_data' to 'struct SectionData' to mat

[Qemu-devel] [PATCH 1/4] multiboot: Change multiboot_info from array of bytes to a C struct

2017-10-12 Thread Anatol Pomozov
Using C structs makes the code more readable and prevents type conversion errors. Borrow multiboot1 header from GRUB project. Signed-off-by: Anatol Pomozov --- hw/i386/multiboot.c | 124 + hw/i386/multiboot_header.h | 254

Re: [Qemu-devel] [PATCH v2 18/24] fixup! ppc: spapr: use generic cpu_model parsing

2017-10-12 Thread David Gibson
On Thu, Oct 12, 2017 at 05:50:08PM +0200, Igor Mammedov wrote: > inot sure how it managed to compile locally and on travis Because target/ppc/kvm.c is only compiled on a ppc _host_. > but build fails with type mismatch on PPC host, fixup it > by casting to expected type I already hit this one an

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Pankaj Gupta
> > Dan, > > > > I have a query regarding below patch [*]. My assumption is its halted > > because of memory hotplug restructuring work? Anything I am missing > > here? > > > > [*] https://www.mail-archive.com/linux-nvdimm@lists.01.org/msg02978.html > > It's fallen to the back of my queue since t

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 3:52 PM, Pankaj Gupta wrote: > Dan, > > I have a query regarding below patch [*]. My assumption is its halted > because of memory hotplug restructuring work? Anything I am missing > here? > > [*] https://www.mail-archive.com/linux-nvdimm@lists.01.org/msg02978.html It's fal

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Pankaj Gupta
> > > wrote: > > > > > > > > > >   This patch adds virtio-pmem driver for KVM guest. > > > > > >   Guest reads the persistent memory range information > > > > > >   over virtio bus from Qemu and reserves the range > > > > > >   as persistent memory. Guest also allocates a block > > > > > >   devi

Re: [Qemu-devel] [PATCH v3 00/13] nbd minimal structured read

2017-10-12 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Minimally implement nbd structured read extension. > > v3: > > clone: tag up-nbd-minimal-structured-read-v3 from > https://src.openvz.org/scm/~vsementsov/qemu.git > online: > https://src.openvz.org/users/vsementsov/repos/qemu/browse?

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Pankaj Gupta
> > > > > > > > > >   This patch adds virtio-pmem driver for KVM guest. > > > > > >   Guest reads the persistent memory range information > > > > > >   over virtio bus from Qemu and reserves the range > > > > > >   as persistent memory. Guest also allocates a block > > > > > >   device correspondi

Re: [Qemu-devel] [PATCH v3 07/13] nbd-server: simplify reply transmission

2017-10-12 Thread Eric Blake
On 10/12/2017 05:27 PM, Eric Blake wrote: > On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: >> Send qiov via qio_channel_writev_all instead of calling nbd_write twice >> with a cork. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> nbd/server.c | 50

Re: [Qemu-devel] [PATCH v3 07/13] nbd-server: simplify reply transmission

2017-10-12 Thread Eric Blake
On 10/12/2017 05:27 PM, Eric Blake wrote: > On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: >> Send qiov via qio_channel_writev_all instead of calling nbd_write twice >> with a cork. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> --- >> nbd/server.c | 50

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Rik van Riel
On Thu, 2017-10-12 at 18:18 -0400, Pankaj Gupta wrote: > > > > On Thu, Oct 12, 2017 at 2:25 PM, Pankaj Gupta > > wrote: > > > > > > > >   This patch adds virtio-pmem driver for KVM guest. > > > > >   Guest reads the persistent memory range information > > > > >   over virtio bus from Qemu and re

Re: [Qemu-devel] [PATCH v3 07/13] nbd-server: simplify reply transmission

2017-10-12 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Send qiov via qio_channel_writev_all instead of calling nbd_write twice > with a cork. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 50 -- > 1 file changed, 24

Re: [Qemu-devel] [PATCH v3 06/13] nbd/server: refactor nbd_co_send_simple_reply parameters

2017-10-12 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Pass client and buffer (*data) parameters directly, to make the function > consistent with further structured reply sending functions. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 13 +++-- > 1 file c

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Pankaj Gupta
> > On Thu, Oct 12, 2017 at 2:25 PM, Pankaj Gupta wrote: > > > >> > This patch adds virtio-pmem driver for KVM guest. > >> > Guest reads the persistent memory range information > >> > over virtio bus from Qemu and reserves the range > >> > as persistent memory. Guest also allocates a blo

Re: [Qemu-devel] [PATCH v3 05/13] nbd/server: do not use NBDReply structure

2017-10-12 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > NBDReply structure will be upgraded in future patches to handle both > simple and structured replies and will be used only in the client > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 36 +++

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 2:25 PM, Pankaj Gupta wrote: > >> > This patch adds virtio-pmem driver for KVM guest. >> > Guest reads the persistent memory range information >> > over virtio bus from Qemu and reserves the range >> > as persistent memory. Guest also allocates a block >> > device

Re: [Qemu-devel] [PATCH v3 04/13] nbd/server: structurize simple reply header sending

2017-10-12 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Use packed structure instead of pointer arithmetics. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > include/block/nbd.h | 6 ++ > nbd/server.c| 36 ++-- > 2 files changed, 20 inser

Re: [Qemu-devel] [PATCH v3 04/13] nbd/server: structurize simple reply header sending

2017-10-12 Thread Eric Blake
On 10/12/2017 04:42 PM, Eric Blake wrote: > On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: >> Use packed structure instead of pointer arithmetics. > >> +set_be_simple_reply(&simple_reply, >> system_errno_to_nbd_errno(reply->error), >> +reply->handle); >>

Re: [Qemu-devel] [PATCH 2/2] target/i386: trap on instructions longer than >15 bytes

2017-10-12 Thread Paolo Bonzini
On 12/10/2017 21:30, Richard Henderson wrote: > On 10/12/2017 07:35 AM, Paolo Bonzini wrote: >> Besides being more correct, arbitrarily long instruction allow the >> generation of a translation block that spans three pages. This >> confuses the generator and even allows ring 3 code to poison the >

Re: [Qemu-devel] [PATCH v3 04/13] nbd/server: structurize simple reply header sending

2017-10-12 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Use packed structure instead of pointer arithmetics. English is fun! In the subject line, I'm fairly certain that "structurize" is not likely to be in any dictionary, yet it is a perfect word describing the patch, so I'm not touching i

Re: [Qemu-devel] [RFC 1/2] pmem: Move reusable code to base header files

2017-10-12 Thread Pankaj Gupta
> > On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > > This patch moves common code to base header files > > so that it can be used for both ACPI pmem and VIRTIO pmem > > drivers. More common code needs to be moved out in future > > based on functionality required for virtio_pmem drive

Re: [Qemu-devel] [PATCH v3 03/13] nbd: rename some simple-request related objects to be _simple_

2017-10-12 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > To be consistent when their _structured_analogs will be introduced. space before analogs > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/nbd-internal.h | 2 +- > nbd/client.c

Re: [Qemu-devel] [PATCH 5/5] openrisc: Only kick cpu on timeout, not on update

2017-10-12 Thread Richard Henderson
On 08/22/2017 10:57 PM, Stafford Horne wrote: > Previously we were kicking the cpu on every update. This caused > problems noticeable in SMP configurations where one CPU got pinned > continuously servicing timer exceptions. > > Signed-off-by: Stafford Horne > --- > hw/openrisc/cputimer.c | 2 +-

Re: [Qemu-devel] [PATCH 4/5] openrisc: Initial SMP support

2017-10-12 Thread Richard Henderson
On 08/22/2017 10:57 PM, Stafford Horne wrote: > Wire in ompic and add basic support for SMP. The OpenRISC is special in > that interrupts for devices are routed to each core's PIC. This is > achieved using the qemu_irq_split utility, but this currently limits > OpenRISC to 2 cores. > > This mode

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Pankaj Gupta
> > This patch adds virtio-pmem driver for KVM guest. > > Guest reads the persistent memory range information > > over virtio bus from Qemu and reserves the range > > as persistent memory. Guest also allocates a block > > device corresponding to the pmem range which later > > can be ac

Re: [Qemu-devel] [PATCH v3 01/13] block/nbd-client: assert qiov len once in nbd_co_request

2017-10-12 Thread Eric Blake
On 10/12/2017 04:53 AM, Vladimir Sementsov-Ogievskiy wrote: > Also improve the assertion: check that qiov is NULL for other commands > than CMD_READ and CMD_WRITE. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/nbd-client.c | 10 ++ > 1 file changed, 6 insertions(+), 4 del

Re: [Qemu-devel] [PATCH] tcg: Initialize cpu_env generically

2017-10-12 Thread Richard Henderson
On 10/12/2017 01:32 PM, Lluís Vilanova wrote: > Richard Henderson writes: > >> On 10/11/2017 11:43 PM, Lluís Vilanova wrote: /* Track which vCPU triggers events */ CPUState *cpu; /* *_trans */ -TCGv_env tcg_env; /* *_exec */ >>> >>> I woul

Re: [Qemu-devel] [Bug 1723161] Re: Migration failing in qemu-2.10.1 but working qemu-2.9.1 and earlier with same options

2017-10-12 Thread William Tambe
Hi David, Please let me know if you have preferred name. I am an AMD employee. Including my colleagues to this thread ... The only error on the source side is the migration failure reported on the source monitor when doing "info migration" . It was indeed something related to the pflash, becau

[Qemu-devel] QEMU without X11 support

2017-10-12 Thread hanji unit
Hello, is it possible to run (or rebuild modifying build flags) QEMU without support for X11 window system integration? I keep seeing XSync in libX11 being called, so i know QEMU is trying to talk to X. I am running QEMU using Xvfb since I still need the SDL rendering to work. Here is how i am runn

[Qemu-devel] [PULL 4/4] libvhost-user: Support VHOST_USER_SET_SLAVE_REQ_FD

2017-10-12 Thread Marc-André Lureau
From: "Dr. David Alan Gilbert" Allow the qemu to pass us a slave fd. We don't do anything with it yet. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20171002191521.15748-5-dgilb...@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Maxime Coquelin --- contrib/libvhost-user/libvhos

[Qemu-devel] [PULL 3/4] libvhost-user: Update and fix feature and request lists

2017-10-12 Thread Marc-André Lureau
From: "Dr. David Alan Gilbert" Update the ProtocolFeature and UserRequest lists to match hw/virtio/vhost-user.c. Fix the text labelling in libvhost-user.c to match the list. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20171002191521.15748-4-dgilb...@redhat.com> Reviewed-by: Marc-André Lu

[Qemu-devel] [PULL 0/4] vhost-user patches

2017-10-12 Thread Marc-André Lureau
The following changes since commit a0b261db8c030813e30a39eae47359ac2a37f7e2: Merge remote-tracking branch 'remotes/ehabkost/tags/python-next-pull-request' into staging (2017-10-12 10:02:09 +0100) are available in the Git repository at: https://github.com/elmarco/qemu.git tags/vu-pull-reques

[Qemu-devel] [PULL 1/4] libvhost-user: vu_queue_started

2017-10-12 Thread Marc-André Lureau
From: "Dr. David Alan Gilbert" Add a vu_queue_started method to complement vu_queue_enabled. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20171002191521.15748-2-dgilb...@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Maxime Coquelin --- contrib/libvhost-user/libvhost-user.h |

[Qemu-devel] [PULL 2/4] vhost-user-bridge: Only process received packets on started queues

2017-10-12 Thread Marc-André Lureau
From: "Dr. David Alan Gilbert" Only process received packets if the queue has been started. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Marc-André Lureau Message-Id: <20171002191521.15748-3-dgilb...@redhat.com> Reviewed-by: Maxime Coquelin --- tests/vhost-user-bridge.c | 1 + 1 file c

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > This patch adds virtio-pmem driver for KVM guest. > Guest reads the persistent memory range information > over virtio bus from Qemu and reserves the range > as persistent memory. Guest also allocates a block > device corresponding to

Re: [Qemu-devel] [PATCH 3/5] openrisc/cputimer: Perparation for Multicore

2017-10-12 Thread Richard Henderson
On 08/22/2017 10:57 PM, Stafford Horne wrote: > In order to support multicore system we move some of the previously > static state variables into the state of each core. > > On the other hand in order to allow timers to be synced between each > code the ttcr (tick timer count register) is moved ou

Re: [Qemu-devel] [PATCH 2/5] target/openrisc: Make coreid and numcores configurable in state

2017-10-12 Thread Richard Henderson
On 08/22/2017 10:57 PM, Stafford Horne wrote: > Previously coreid and numcores were hard coded as 0 and 1 respectively > as OpenRISC QEMU did not have multicore support. > > Multicore support is now being added so these registers need to have > configured values. > > Signed-off-by: Stafford Horne

Re: [Qemu-devel] [PATCH 1/5] openrisc/ompic: Add OpenRISC Multicore PIC (OMPIC)

2017-10-12 Thread Richard Henderson
On 08/22/2017 10:57 PM, Stafford Horne wrote: > Add OpenRISC Multicore PIC which handles inter processor interrupts > (IPI) between cores. In OpenRISC all device interrupts are routed to > each core enabling this device to be simple. > > Signed-off-by: Stafford Horne > --- > default-configs/or1

Re: [Qemu-devel] [RFC 1/2] pmem: Move reusable code to base header files

2017-10-12 Thread Dan Williams
On Thu, Oct 12, 2017 at 8:50 AM, Pankaj Gupta wrote: > This patch moves common code to base header files > so that it can be used for both ACPI pmem and VIRTIO pmem > drivers. More common code needs to be moved out in future > based on functionality required for virtio_pmem driver and > coupl

Re: [Qemu-devel] [PATCH] tcg: Initialize cpu_env generically

2017-10-12 Thread Lluís Vilanova
Richard Henderson writes: > On 10/11/2017 11:43 PM, Lluís Vilanova wrote: >>> /* Track which vCPU triggers events */ >>> CPUState *cpu; /* *_trans */ >>> -TCGv_env tcg_env; /* *_exec */ >> >> I would rather keep it here instead of making a new global va

Re: [Qemu-devel] [PATCH 2/2] target/i386: trap on instructions longer than >15 bytes

2017-10-12 Thread Richard Henderson
On 10/12/2017 07:35 AM, Paolo Bonzini wrote: > Besides being more correct, arbitrarily long instruction allow the > generation of a translation block that spans three pages. This > confuses the generator and even allows ring 3 code to poison the > translation block cache and inject code into other

[Qemu-devel] [Bug 1723161] Re: Migration failing in qemu-2.10.1 but working qemu-2.9.1 and earlier with same options

2017-10-12 Thread Dr. David Alan Gilbert
Interesting; As a test could you try removing the cdrom entry (I doubt that'll help but it's worth a go). Also, is it possible for you to try a bisection? If I was to guess, I'd bet it's something relating to the pflash, but I don't know; it's unfortunate the block migration doesn't say what it g

Re: [Qemu-devel] [PATCH 0/2] target/i386: trap on instructions longer than >15 bytes

2017-10-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171012143548.18581-1-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH 0/2] target/i386: trap on instructions longer than >15 bytes === TEST SCRIPT BEGIN === #!/bin/bash B

[Qemu-devel] [PATCH v4 18/20] vpc: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the vpc driver accordingly. Drop the now-unused get_sector_offset(). Signed-off-by: Eric Blake --- v4: rebase to interface tweak v3: rebase to master v2: drop get_sector_offset() [Kevin], rebase to mapping fl

[Qemu-devel] [PATCH v4 20/20] block: Drop unused .bdrv_co_get_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Now that all drivers have been updated to provide the byte-based .bdrv_co_block_status(), we can delete the sector-based interface. Signed-off-by: Eric Blake --- v4: rebase to interface tweak v3: no change v2: rebase

[Qemu-devel] [PATCH v4 16/20] vdi: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the vdi driver accordingly. Note that the TODO is already covered (the block layer guarantees bounds of its requests), and that we can remove the now-unused s->block_sectors. Signed-off-by: Eric Blake --- v4:

[Qemu-devel] [PATCH v4 17/20] vmdk: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the vmdk driver accordingly. Signed-off-by: Eric Blake --- v4: rebase to interface tweak v3: no change v2: rebase to mapping flag --- block/vmdk.c | 28 +--- 1 file changed, 13 inserti

[Qemu-devel] nvme: Add tracing v3

2017-10-12 Thread Doug Gale
>From c7f12a5949458fdd195b5e0b52f158e8f114f203 Mon Sep 17 00:00:00 2001 From: Doug Gale Date: Thu, 12 Oct 2017 14:29:07 -0400 Subject: [PATCH] nvme: Add tracing Add trace output for commands, errors, and undefined behavior. Add guest error log output for undefined behavior. Report and ignore inva

[Qemu-devel] [PATCH v4 13/20] raw: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the raw driver accordingly. Signed-off-by: Eric Blake --- v4: rebase to interface tweak v3: no change v2: rebase to mapping --- block/raw-format.c | 16 1 file changed, 8 insertions(+), 8 del

[Qemu-devel] [PATCH v4 15/20] vdi: Avoid bitrot of debugging code

2017-10-12 Thread Eric Blake
Rework the debug define so that we always get -Wformat checking, even when debugging is disabled. Signed-off-by: Eric Blake Reviewed-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé --- v2: no change --- block/vdi.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff -

[Qemu-devel] [PATCH v4 11/20] qcow2: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the qcow2 driver accordingly. For now, we are ignoring the 'want_zero' hint. However, it should be relatively straightforward to honor the hint as a way to return larger *pnum values when we have consecutive cl

[Qemu-devel] [PATCH v4 14/20] sheepdog: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the sheepdog driver accordingly. Signed-off-by: Eric Blake --- v4: update to interface tweak v3: no change v2: rebase to mapping flag --- block/sheepdog.c | 26 +- 1 file changed, 13 i

[Qemu-devel] [PATCH v4 19/20] vvfat: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the vvfat driver accordingly. Note that we can rely on the block driver having already clamped limits to our block size, and simplify accordingly. Signed-off-by: Eric Blake --- v4: rebase to interface tweak v

[Qemu-devel] [PATCH v4 09/20] parallels: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the parallels driver accordingly. Note that the internal function block_status() is still sector-based, because it is still in use by other sector-based functions; but that's okay because request_alignment is 51

[Qemu-devel] [PATCH v4 12/20] qed: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the qed driver accordingly, taking the opportunity to inline qed_is_allocated_cb() into its lone caller (the callback used to be important, until we switched qed to coroutines). There is no intent to optimize ba

[Qemu-devel] [PATCH v4 08/20] null: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the null driver accordingly. Signed-off-by: Eric Blake --- v4: rebase to interface tweak v3: no change v2: rebase to mapping parameter --- block/null.c | 23 --- 1 file changed, 12 inserti

[Qemu-devel] [PATCH v4 07/20] iscsi: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the iscsi driver accordingly. In this case, it is handy to teach iscsi_co_block_status() to handle a NULL map and file parameter, even though the block layer passes non-NULL values, because we also call the func

[Qemu-devel] [PATCH v4 05/20] iscsi: Switch cluster_sectors to byte-based

2017-10-12 Thread Eric Blake
We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert all uses of the cluster size in sectors, along with adding assertions that we are not dividing by zero. Signed-off-by: Eric Blake --- v2: no change --- block/iscsi.c | 56 +++

[Qemu-devel] [PATCH v4 10/20] qcow: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the qcow driver accordingly. There is no intent to optimize based on the want_zero flag for this format. Signed-off-by: Eric Blake --- v4: rebase to interface tweak v3: rebase to master v2: rebase to mapping

[Qemu-devel] [PATCH v4 03/20] file-posix: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the file protocol driver accordingly. In want_zero mode, we continue to report fine-grained hole information (the caller wants as much mapping detail as possible); but when not in that mode, the caller prefers l

[Qemu-devel] [PATCH v4 06/20] iscsi: Switch iscsi_allocmap_update() to byte-based

2017-10-12 Thread Eric Blake
We are gradually converting to byte-based interfaces, as they are easier to reason about than sector-based. Convert all uses of the allocmap (no semantic change). Callers that already had bytes available are simpler, and callers that now scale to bytes will be easier to switch to byte-based in th

[Qemu-devel] [PATCH v4 02/20] block: Switch passthrough drivers to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the generic helpers, and all passthrough clients (blkdebug, commit, mirror, throttle) accordingly. Signed-off-by: Eric Blake --- v4: rebase to interface tweak v3: rebase to addition of throttle driver v2: reba

[Qemu-devel] [PATCH v4 04/20] gluster: Switch to .bdrv_co_block_status()

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the gluster driver accordingly. In want_zero mode, we continue to report fine-grained hole information (the caller wants as much mapping detail as possible); but when not in that mode, the caller prefers larger

Re: [Qemu-devel] proposed schedule for 2.11 release

2017-10-12 Thread Peter Maydell
On 10 October 2017 at 17:26, Paolo Bonzini wrote: > On 10/10/2017 18:10, Daniel P. Berrange wrote: >> On Tue, Oct 10, 2017 at 03:07:26PM +0100, Peter Maydell wrote: >>> OK, here's a strawman proposal for the 2.11 release cycle, >>> based on aiming for a 5 Dec release date and working backwards >>>

[Qemu-devel] [PATCH v4 01/20] block: Add .bdrv_co_block_status() callback

2017-10-12 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Now that the block layer exposes byte-based allocation, it's time to tackle the drivers. Add a new callback that operates on as small as byte boundaries. Subsequent patches will then update individual drivers, then fina

[Qemu-devel] [PATCH v4 00/20] add byte-based block_status driver callbacks

2017-10-12 Thread Eric Blake
There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte granularity (even if the reporting will probably be naturally aligned to sectors or even much higher levels). I've therefore started the task of converting our block status code to report at a byt

Re: [Qemu-devel] [PATCH v3 0/8] Add the ZynqMP PMU and IPI

2017-10-12 Thread Edgar E. Iglesias
On Oct 10, 2017 7:59 PM, "Alistair Francis" wrote: On Tue, Oct 10, 2017 at 7:48 AM, Edgar E. Iglesias wrote: > On Mon, Oct 09, 2017 at 05:12:39PM -0700, Alistair Francis wrote: >> On Sun, Oct 8, 2017 at 3:20 PM, Edgar E. Iglesias >> wrote: >> > On Wed, Sep 20, 2017 at 03:01:31PM -0700, Alistair

Re: [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

2017-10-12 Thread Konrad Rzeszutek Wilk
On Thu, Oct 12, 2017 at 08:45:44PM +0800, Haozhong Zhang wrote: > On 10/10/17 12:05 -0400, Konrad Rzeszutek Wilk wrote: > > On Tue, Sep 12, 2017 at 11:15:09AM +0800, Haozhong Zhang wrote: > > > On 09/11/17 11:52 -0700, Stefano Stabellini wrote: > > > > CC'ing xen-devel, and the Xen tools and x86 ma

Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer

2017-10-12 Thread Stefano Stabellini
On Thu, 12 Oct 2017, Paul Durrant wrote: > > -Original Message- > > From: Gerd Hoffmann [mailto:kra...@redhat.com] > > Sent: 12 October 2017 10:26 > > To: Paul Durrant ; 'Stefano Stabellini' > > ; Anthony Perard > > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Owen Smith > >

Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values

2017-10-12 Thread Laurent Vivier
Le 12/10/2017 à 18:53, Peter Maydell a écrit : > On 12 October 2017 at 17:49, Laurent Vivier wrote: >> Le 12/10/2017 à 17:30, Peter Maydell a écrit : >>> +#if defined(TARGET_SPARC) || defined(TARGET_MIPS) >>> +typedef abi_long target_kernel_daddr_t; >>> +#else >>> +typedef abi_int target_kernel_da

Re: [Qemu-devel] [PATCH] xen: Log errno rather than return value

2017-10-12 Thread Paul Durrant
> -Original Message- > From: Qemu-devel [mailto:qemu-devel- > bounces+paul.durrant=citrix@nongnu.org] On Behalf Of Paul Durrant > Sent: 12 October 2017 10:47 > To: Ross Lagerwall ; qemu-devel@nongnu.org > Cc: Anthony Perard ; Ross Lagerwall > ; Stefano Stabellini > Subject: Re: [Qemu-d

Re: [Qemu-devel] [PATCH] tco: add trace events

2017-10-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1507816448-86665-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH] tco: add trace events === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log

Re: [Qemu-devel] [PATCH 2/2] linux-user: Fix TARGET_MTIOCTOP/MTIOCGET/MTIOCPOS values

2017-10-12 Thread Peter Maydell
On 12 October 2017 at 17:49, Laurent Vivier wrote: > Le 12/10/2017 à 17:30, Peter Maydell a écrit : >> +#if defined(TARGET_SPARC) || defined(TARGET_MIPS) >> +typedef abi_long target_kernel_daddr_t; >> +#else >> +typedef abi_int target_kernel_daddr_t; >> +#endif > > Perhaps you can add these ones i

  1   2   3   >