Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-19 Thread David Gibson
On Wed, Sep 20, 2017 at 12:10:48PM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wrote: > >> >> David Gibson write

Re: [Qemu-devel] [PATCH 0/2] macio patches

2017-09-19 Thread David Gibson
On Wed, Sep 20, 2017 at 07:19:59AM +0100, Mark Cave-Ayland wrote: > Here are the macio patches taken from my previous "ppc: more Mac-related > fixups" > patchset with the v2 pmac_ide_ops conversion changes as requested. > > Signed-off-by: Mark Cave-Ayland Applied to ppc-for-2.11, thanks. > >

Re: [Qemu-devel] [RFC PATCH v2 11/21] ppc/xive: push the EQ data in OS event queue

2017-09-19 Thread David Gibson
On Tue, Sep 19, 2017 at 09:36:08PM +0200, Cédric Le Goater wrote: > On 09/19/2017 09:45 AM, David Gibson wrote: > > On Mon, Sep 11, 2017 at 07:12:25PM +0200, Cédric Le Goater wrote: > >> If a triggered event is let through, the Event Queue data defined in > >> the associated IVE is pushed in the in

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/5] misc: add pca9552 LED blinker model

2017-09-19 Thread Cédric Le Goater
On 09/19/2017 03:27 PM, Philippe Mathieu-Daudé wrote: > On 09/19/2017 08:26 AM, Cédric Le Goater wrote: >> Specs are available here : >> >>    https://www.nxp.com/docs/en/data-sheet/PCA9552.pdf >> >> This is a simple model supporting the basic registers for led and GPIO >> mode. The device also sup

Re: [Qemu-devel] [RFC 07/15] monitor: unify global init

2017-09-19 Thread Peter Xu
On Tue, Sep 19, 2017 at 04:48:35PM -0500, Eric Blake wrote: > On 09/19/2017 04:35 PM, Eric Blake wrote: > > On 09/14/2017 02:50 AM, Peter Xu wrote: > >> There are many places for monitor init its globals, at least: > >> > > > Are we sure that this new function is called sooner than any access to >

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-19 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: >> >> >>> >> I think the current approach is the simplest and less intrusive, as we >>> >> are handling a case where user has not bothered to provide a detailed >>> >> topology, the best we can do is create single threaded cores equal to >>> >> number of cores. >>> > >>

[Qemu-devel] [PATCH v2] watchdog/aspeed: fix variable type to store reload value

2017-09-19 Thread Cédric Le Goater
Initially from Anton D. Kachalov" but the SoB was missing. Signed-off-by: Cédric Le Goater [clg: change commit log and subject replace UL suffix by ULL ] Signed-off-by: Cédric Le Goater --- hw/watchdog/wdt_aspeed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/h

Re: [Qemu-devel] [PATCH v3 3/5] virtio-ccw: use ccw data stream

2017-09-19 Thread Dong Jia Shi
* Halil Pasic [2017-09-19 20:27:43 +0200]: > Replace direct access which implicitly assumes no IDA > or MIDA with the new ccw data stream interface which should > cope with these transparently in the future. > > Signed-off-by: Halil Pasic > Reviewed-by: Pierre Morel > --- > hw/s390x/virtio-ccw

Re: [Qemu-devel] [PATCH v3 1/5] s390x/css: introduce css data stream

2017-09-19 Thread Dong Jia Shi
* Halil Pasic [2017-09-19 20:27:41 +0200]: [...] > diff --git a/include/hw/s390x/css.h b/include/hw/s390x/css.h > index 0653d3c9be..078356e94c 100644 > --- a/include/hw/s390x/css.h > +++ b/include/hw/s390x/css.h > @@ -75,6 +75,29 @@ typedef struct CMBE { > uint32_t reserved[7]; > } QEMU_PA

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-19 Thread Nikunj A Dadhania
David Gibson writes: > On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wrote: >> >> David Gibson writes: >> >> >> >> > On Fri, Sep 15, 2017 at 02:39:16PM +0530, Nikunj A Dadhania wro

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Dong Jia Shi
* Halil Pasic [2017-09-19 14:04:03 +0200]: I have no problem with the rest parts of the discussion in this thread. > > > On 09/19/2017 12:57 PM, Cornelia Huck wrote: > > +static inline int ida_read_next_idaw(CcwDataStream *cds) > > +{ > > +union {uint64_t fmt2; uint32_t fmt1; }

[Qemu-devel] [PATCH] linux_user: fix TARGET_SOL_SOCKET for sparc

2017-09-19 Thread Carlo Marcelo Arenas Belón
Signed-off-by: Carlo Marcelo Arenas Belón --- linux-user/socket.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/linux-user/socket.h b/linux-user/socket.h index 129f9b4713..1db1a184b9 100644 --- a/linux-user/socket.h +++ b/linux-user/socket.h @@ -229,7 +229,9 @@

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-19 Thread David Gibson
On Wed, Sep 20, 2017 at 10:43:19AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Fri, Sep 15, 2017 at 02:39:16PM +0530, Nikunj A Dadhania wrote: > >> >> David Gibson write

Re: [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio

2017-09-19 Thread Mark Cave-Ayland
On 20/09/17 07:00, David Gibson wrote: > On Wed, Sep 20, 2017 at 06:56:37AM +0100, Mark Cave-Ayland wrote: >> On 20/09/17 05:29, David Gibson wrote: >> >>> On Tue, Sep 19, 2017 at 09:02:54PM +0100, Mark Cave-Ayland wrote: Signed-off-by: Mark Cave-Ayland >>> >>> This didn't apply for me. Can

Re: [Qemu-devel] [PATCH v8 18/20] qcow2: Switch store_bitmap_data() to byte-based iteration

2017-09-19 Thread Kevin Wolf
Am 19.09.2017 um 21:42 hat Eric Blake geschrieben: > However... > > >> -sbc = limit >> BDRV_SECTOR_BITS; > >> assert(DIV_ROUND_UP(bm_size, limit) == tb_size); > >> > >> -while ((sector = bdrv_dirty_iter_next(dbi) >> BDRV_SECTOR_BITS) >= 0) > >> { > >> -uint64_t cluster = sect

[Qemu-devel] [PATCH 0/2] macio patches

2017-09-19 Thread Mark Cave-Ayland
Here are the macio patches taken from my previous "ppc: more Mac-related fixups" patchset with the v2 pmac_ide_ops conversion changes as requested. Signed-off-by: Mark Cave-Ayland Benjamin Herrenschmidt (1): ppc/ide/macio: Add missing registers Mark Cave-Ayland (1): macio: convert pmac_ide

Re: [Qemu-devel] [PATCH] watchdog/aspeed: fix variable type to store reload value

2017-09-19 Thread Cédric Le Goater
On 09/19/2017 07:15 PM, Richard Henderson wrote: > On 09/19/2017 06:17 AM, Cédric Le Goater wrote: >> +uint64_t reload; >> >> if (pclk) { >> reload = muldiv64(s->regs[WDT_RELOAD_VALUE], NANOSECONDS_PER_SECOND, >>s->pclk_freq); >> } else { >> -

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-19 Thread Michael Olbrich
On Tue, Sep 19, 2017 at 05:09:51PM -0700, Alistair Francis wrote: > On Tue, Sep 19, 2017 at 1:23 AM, Michael Olbrich > wrote: > > On Mon, Sep 18, 2017 at 02:28:26PM -0700, Alistair Francis wrote: > >> On Sat, Sep 16, 2017 at 3:35 AM, Michael Olbrich > >> wrote: > >> > hw/sd/sd.c | 12 ++-

[Qemu-devel] [PATCH 1/2] ppc/ide/macio: Add missing registers

2017-09-19 Thread Mark Cave-Ayland
From: Benjamin Herrenschmidt The timing register exists on all variants of MacIO IDE, we just store and return its value. The interrupts register only exists on KeyLargo but it doesn't hurt to have it. The lack of this register causes MacOS X to hangs under some circumstances. Both are 32-bit o

[Qemu-devel] [PATCH 2/2] macio: convert pmac_ide_ops from old_mmio

2017-09-19 Thread Mark Cave-Ayland
Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c | 181 +++- 1 file changed, 75 insertions(+), 106 deletions(-) diff --git a/hw/ide/macio.c b/hw/ide/macio.c index db5db39..18ae952 100644 --- a/hw/ide/macio.c +++ b/hw/ide/macio.c @@ -255,131

Re: [Qemu-devel] What is the best commit for record-replay?

2017-09-19 Thread Pavel Dovgalyuk
> From: Alex Bennée [mailto:alex.ben...@linaro.org] > > > >>> > > > > Hope you've already found the solution (as the last post was on 2 May) > > and it's just got missed the mailing list. > >>> > >>> As I know, RR is still broken in the current version. > >>> It was caused by the MTT

[Qemu-devel] [PATCH] virtio: fix descriptor counting in virtqueue_pop

2017-09-19 Thread Wolfgang Bumiller
While changing the s/g list allocation, commit 3b3b0628 also changed the descriptor counting to count iovec entries as split by cpu_physical_memory_map(). Previously only the actual descriptor entries were counted and the split into the iovec happened afterwards in virtqueue_map(). Count the entrie

Re: [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio

2017-09-19 Thread David Gibson
On Wed, Sep 20, 2017 at 06:56:37AM +0100, Mark Cave-Ayland wrote: > On 20/09/17 05:29, David Gibson wrote: > > > On Tue, Sep 19, 2017 at 09:02:54PM +0100, Mark Cave-Ayland wrote: > >> Signed-off-by: Mark Cave-Ayland > > > > This didn't apply for me. Can you rebase on top of ppc-for-2.11, please

Re: [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio

2017-09-19 Thread Mark Cave-Ayland
On 20/09/17 05:29, David Gibson wrote: > On Tue, Sep 19, 2017 at 09:02:54PM +0100, Mark Cave-Ayland wrote: >> Signed-off-by: Mark Cave-Ayland > > This didn't apply for me. Can you rebase on top of ppc-for-2.11, please. (goes and looks) Okay looks like the issue is that you're missing "[PATCH

Re: [Qemu-devel] [RFC 06/15] monitor: move the cur_mon hack deeper for QMP

2017-09-19 Thread Peter Xu
On Tue, Sep 19, 2017 at 04:05:48PM -0500, Eric Blake wrote: > On 09/14/2017 02:50 AM, Peter Xu wrote: > > In monitor_qmp_read(), we have the hack to temporarily replace the > > cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher > > routine since the Monitor pointer can be pass

Re: [Qemu-devel] [RFC 05/15] qjson: add "opaque" field to JSONMessageParser

2017-09-19 Thread Peter Xu
On Tue, Sep 19, 2017 at 03:55:41PM -0500, Eric Blake wrote: > On 09/14/2017 02:50 AM, Peter Xu wrote: > > It'll be passed to emit() as well when it happens. > > > > Signed-off-by: Peter Xu > > --- > > include/qapi/qmp/json-streamer.h | 8 ++-- > > monitor.c| 7 ---

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-19 Thread Nikunj A Dadhania
David Gibson writes: > On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Fri, Sep 15, 2017 at 02:39:16PM +0530, Nikunj A Dadhania wrote: >> >> David Gibson writes: >> >> >> >> > On Fri, Sep 15, 2017 at 01:53:15PM +0530, Nikunj A Dadhania wro

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-19 Thread David Gibson
On Wed, Sep 20, 2017 at 09:50:24AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > On Fri, Sep 15, 2017 at 02:39:16PM +0530, Nikunj A Dadhania wrote: > >> David Gibson writes: > >> > >> > On Fri, Sep 15, 2017 at 01:53:15PM +0530, Nikunj A Dadhania wrote: > >> >> David Gibson write

Re: [Qemu-devel] [RFC 02/15] qobject: allow NULL for qstring_get_str()

2017-09-19 Thread Peter Xu
On Tue, Sep 19, 2017 at 03:48:35PM -0500, Eric Blake wrote: > On 09/14/2017 02:50 AM, Peter Xu wrote: > > Then I can get NULL rather than crash when calling things like: > > > > qstring_get_str(qobject_to_qstring(object)); > > > > when key does not exist. > > Right now, qdict_get_str() is docu

Re: [Qemu-devel] [RFC PATCH v2 03/21] ppc/xive: define the XIVE internal tables

2017-09-19 Thread David Gibson
On Tue, Sep 19, 2017 at 03:46:20PM +0200, Cédric Le Goater wrote: > On 09/19/2017 04:39 AM, David Gibson wrote: > > On Mon, Sep 11, 2017 at 07:12:17PM +0200, Cédric Le Goater wrote: > >> The XIVE interrupt controller of the POWER9 uses a set of tables to > >> redirect exception from event sources t

Re: [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio

2017-09-19 Thread David Gibson
On Tue, Sep 19, 2017 at 09:02:54PM +0100, Mark Cave-Ayland wrote: > Signed-off-by: Mark Cave-Ayland This didn't apply for me. Can you rebase on top of ppc-for-2.11, please. > --- > hw/ide/macio.c | 181 > +++- > 1 file changed, 75 insertion

Re: [Qemu-devel] [PATCH v2 2/2] spapr_pci: make index property mandatory

2017-09-19 Thread David Gibson
On Tue, Sep 19, 2017 at 04:03:57PM +0200, Greg Kurz wrote: > On Tue, 19 Sep 2017 09:03:58 +1000 > David Gibson wrote: > > > On Thu, Sep 14, 2017 at 04:14:44PM +0200, Greg Kurz wrote: > > > Creating several PHBs without index property confuses the DRC code > > > and causes issues: > > > - only the

Re: [Qemu-devel] [RFC PATCH v2 06/21] ppc/xive: introduce handlers for interrupt sources

2017-09-19 Thread David Gibson
On Tue, Sep 19, 2017 at 05:08:21PM +0200, Cédric Le Goater wrote: > On 09/19/2017 04:48 AM, David Gibson wrote: > > On Mon, Sep 11, 2017 at 07:12:20PM +0200, Cédric Le Goater wrote: > >> These are very similar to the XICS handlers in a simpler form. They > >> make use of the ICSIRQState array of th

Re: [Qemu-devel] [RFC PATCH v2 05/21] ppc/xive: allocate IRQ numbers for the IPIs

2017-09-19 Thread David Gibson
On Tue, Sep 19, 2017 at 04:52:10PM +0200, Cédric Le Goater wrote: > On 09/19/2017 04:45 AM, David Gibson wrote: > > On Mon, Sep 11, 2017 at 07:12:19PM +0200, Cédric Le Goater wrote: > >> The number of IPIs is deduced from the max number of CPUs the guest > >> supports and the IRQ numbers for the IP

Re: [Qemu-devel] [RFC 01/15] char-io: fix possible race on IOWatchPoll

2017-09-19 Thread Peter Xu
On Tue, Sep 19, 2017 at 02:59:37PM -0500, Eric Blake wrote: > On 09/14/2017 02:50 AM, Peter Xu wrote: > > This is not a problem if we are only having one single loop thread like > > before. However, after per-monitor thread is introduced, this is not > > true any more, and the race can happen. > >

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-19 Thread Peter Xu
On Tue, Sep 19, 2017 at 10:19:21AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, Sep 18, 2017 at 06:09:29PM +0200, Marc-André Lureau wrote: > > > On Mon, Sep 18, 2017 at 1:26 PM, Dr. David Alan Gilbert > > > wrote: > > > > * Marc-André Lureau (marcandre.l

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-19 Thread Nikunj A Dadhania
David Gibson writes: > On Fri, Sep 15, 2017 at 02:39:16PM +0530, Nikunj A Dadhania wrote: >> David Gibson writes: >> >> > On Fri, Sep 15, 2017 at 01:53:15PM +0530, Nikunj A Dadhania wrote: >> >> David Gibson writes: >> >> >> >> >> >> >> >> I thought, I am doing the same here for PowerNV, num

Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-19 Thread Fam Zheng
On Tue, 09/19 19:00, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > vmstate_save is called in a few places, and vmstate_save_state is > called in lots of places. > > Route error returns from the easier cases back up; there are lots > of more complex cases where there o

[Qemu-devel] [RFC] Another Para-Virtualization page recycler. Empty Guest OS free pages every few seconds

2017-09-19 Thread XaviLi
PPR (Per Page Recycler) is a para virtualization driver currently available for KVM hosts and Linux/Windows guests. With PPR, every page freed to Guest OS can be recycled in seconds by hypervisor. Therefore, VMs can dynamical allocate/free pages from hypervisor according to application’s request

[Qemu-devel] [RFC] A multithread lockless deduplication engine

2017-09-19 Thread XaviLi
PageONE (Page Object Non-duplicate Engine) is a multithread kernel page deduplication engine. It is based on a lock-less tree algorithm we currently named as SD (Static and Dynamic) Tree. Normal operations such as insert/query/delete to this tree are block-less. Adding more CPU cores can linear

Re: [Qemu-devel] [PATCH 5/5] migration: Route more error paths

2017-09-19 Thread Peter Xu
On Tue, Sep 19, 2017 at 07:00:38PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > vmstate_save is called in a few places, and vmstate_save_state is > called in lots of places. > > Route error returns from the easier cases back up; there are lots > of more comple

[Qemu-devel] [PATCH v10 13/13] docker: Use archive-source.py

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Alex Bennée --- tests/docker/Makefile.include | 14 ++ tests/docker/run | 8 +--- 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index aa566aa223..7a

[Qemu-devel] [PATCH v10 12/13] tests: Add README for vm tests

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/vm/README | 89 + 1 file changed, 89 insertions(+) create mode 100644 tests/vm/README diff --git a/tests/vm/README b/tests/vm/README new file mode 100644 index 00..ae53dce6ee --- /dev/null +++ b/t

[Qemu-devel] [PATCH v10 08/13] tests: Add NetBSD image

2017-09-19 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski --- tests/vm/netbsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/netbsd diff --git a/tes

[Qemu-devel] [PATCH v10 11/13] MAINTAINERS: Add tests/vm entry

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 3d735979ef..0f8f1db332 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1901,6 +1901,7 @@ S: Maintained F: .travis.yml F: .shippable.yml F: t

[Qemu-devel] [PATCH v10 07/13] tests: Add FreeBSD image

2017-09-19 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/freebsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/freebsd diff --git a/tests/vm/freebsd b/tests/vm/free

[Qemu-devel] [PATCH v10 10/13] Makefile: Add rules to run vm tests

2017-09-19 Thread Fam Zheng
Reviewed-by: Alex Bennée Tested-by: Alex Bennée Signed-off-by: Fam Zheng --- Makefile | 2 ++ configure | 2 +- tests/vm/Makefile.include | 42 ++ 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 test

[Qemu-devel] [PATCH v10 05/13] tests: Add vm test lib

2017-09-19 Thread Fam Zheng
This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file to the guest. 4) SSH into the VM, untar the s

[Qemu-devel] [PATCH v10 09/13] tests: Add OpenBSD image

2017-09-19 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/openbsd | 43 +++ 1 file changed, 43 insertions(+) create mode 100755 tests/vm/openbsd diff --git a/tests/vm/openbsd b/tests/vm/ope

[Qemu-devel] [PATCH v10 06/13] tests: Add ubuntu.i386 image

2017-09-19 Thread Fam Zheng
This adds a 32bit guest. The official LTS cloud image is downloaded and initialized with cloud-init. Signed-off-by: Fam Zheng --- tests/vm/ubuntu.i386 | 89 1 file changed, 89 insertions(+) create mode 100755 tests/vm/ubuntu.i386 diff --git

[Qemu-devel] [PATCH v10 04/13] tests: Add a test key pair

2017-09-19 Thread Fam Zheng
This will be used by setup test user ssh. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- tests/keys/README | 6 ++ tests/keys/id_rsa | 27 +++ tests/keys/id_rsa.pub | 1 + 3 files changed, 34 insertions(+) create mode 100644 tests/keys/README create

[Qemu-devel] [PATCH v10 01/13] gitignore: Ignore vm test images

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- .gitignore | 1 + tests/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index cf65316863..40acfcb9e2 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,7 @@ /vscclient /vhost-user-scsi /fsdev/virtfs-proxy-helper +*.

[Qemu-devel] [PATCH v10 03/13] scripts: Add archive-source.sh

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng --- scripts/archive-source.sh | 51 +++ 1 file changed, 51 insertions(+) create mode 100755 scripts/archive-source.sh diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh new file mode 100755 index 00..81

[Qemu-devel] [PATCH v10 02/13] qemu.py: Add "wait()" method

2017-09-19 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Alex Bennée --- scripts/qemu.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 5e02dd8e78..2b5c2accb5 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -215,6 +215,13 @@ cl

[Qemu-devel] [PATCH v10 00/13] tests: Add VM based build tests (for non-x86_64 and/or non-Linux)

2017-09-19 Thread Fam Zheng
v10: Rebase - trivial conflict in docker Makefile.include. Specify bash in shebang. [Eric] Tweaks in README and pub key comment. [Eric] Clean up $1.list if tar failed. [Eric] Set locale in cloud-init for ubuntu image. v9: Don't use 'set -e' in archive-source.sh. [Eric] Add

Re: [Qemu-devel] [PATCH v9 04/13] tests: Add a test key pair

2017-09-19 Thread Fam Zheng
On Tue, 09/19 10:18, Eric Blake wrote: > On 09/19/2017 02:27 AM, Fam Zheng wrote: > > This will be used by setup test user ssh. > > > > Signed-off-by: Fam Zheng > > --- > > tests/keys/README | 6 ++ > > tests/keys/id_rsa | 27 +++ > > tests/keys/id_rsa.pub |

Re: [Qemu-devel] [PATCH v9 03/13] scripts: Add archive-source.sh

2017-09-19 Thread Fam Zheng
On Tue, 09/19 10:10, Eric Blake wrote: > On 09/19/2017 02:27 AM, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > scripts/archive-source.sh | 46 > > ++ > > 1 file changed, 46 insertions(+) > > create mode 100755 scripts/archive-source.sh > >

Re: [Qemu-devel] [PATCH v9 06/13] tests: Add ubuntu.i386 image

2017-09-19 Thread Fam Zheng
On Tue, 09/19 16:12, Alex Bennée wrote: > Could we also do something about locales in this setup. The build gives > a lot of noise like: > > perl: warning: Falling back to a fallback locale ("en_US.UTF-8"). > perl: warning: Setting locale failed. > perl: warning: Please check that your

Re: [Qemu-devel] [PATCH v4 0/3] x86_iommu: Fix segfault when starting on non-PCI machines

2017-09-19 Thread Peter Xu
On Mon, Sep 18, 2017 at 04:37:47PM +0200, Mohammed Gamal wrote: > Starting qemu with > qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu > leads to a segfault. The code assume PCI bus is present and > tries to access the bus structure without checking. > > The patch series moves the error c

Re: [Qemu-devel] [PATCH v2] spapr: introduce helpers to migrate HPT chunks and the end marker

2017-09-19 Thread David Gibson
On Tue, Sep 19, 2017 at 04:11:07PM +0200, Greg Kurz wrote: > This consolidates some duplicated code in a dedicated helpers. > > Signed-off-by: Greg Kurz Applied to ppc-for-2.11. > --- > v2: - open-code writes for the end marker > --- > hw/ppc/spapr.c | 38 +---

Re: [Qemu-devel] [PATCH v9 05/20] dirty-bitmap: Avoid size query failure during truncate

2017-09-19 Thread Fam Zheng
On Tue, 09/19 19:00, John Snow wrote: > > > On 09/19/2017 04:18 PM, Eric Blake wrote: > > We've previously fixed several places where we failed to account > > for possible errors from bdrv_nb_sectors(). Fix another one by > > making bdrv_dirty_bitmap_truncate() take the new size from the > > cal

Re: [Qemu-devel] [PATCH] ppc/pnv: Improve macro parenthesization

2017-09-19 Thread David Gibson
On Tue, Sep 19, 2017 at 09:16:03AM -0500, Eric Blake wrote: > Although none of the existing macro call-sites were broken, > it's always better to write macros that properly parenthesize > arguments that can be complex expressions, so that the intended > order of operations is not broken. > > Signe

Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA

2017-09-19 Thread Dong Jia Shi
* Halil Pasic [2017-09-19 20:05:48 +0200]: > > > On 09/19/2017 02:23 PM, Cornelia Huck wrote: > > +{ > > +union {uint64_t fmt2; uint32_t fmt1; } idaw; > ^ > Nit. > > >> Maybe checkpatch wanted it this way. My memori

Re: [Qemu-devel] [PATCH v2 3/4] virtio-ccw: use ccw data stream

2017-09-19 Thread Dong Jia Shi
* Halil Pasic [2017-09-19 15:30:29 +0200]: > > > On 09/19/2017 11:06 AM, Cornelia Huck wrote: > > On Tue, 19 Sep 2017 11:37:30 +0800 > > Dong Jia Shi wrote: > > > >> * Halil Pasic [2017-09-13 13:50:28 +0200]: > >> > >>> Replace direct access which implicitly assumes no IDA > >>> or MIDA with

[Qemu-devel] [PATCH 07/12] qcow2: move qcow2_store_persistent_dirty_bitmaps() before cache flushing

2017-09-19 Thread Michael Roth
From: Pavel Butsykin After calling qcow2_inactivate(), all qcow2 caches must be flushed, but this may not happen, because the last call qcow2_store_persistent_dirty_bitmaps() can lead to marking l2/refcont cache as dirty. Let's move qcow2_store_persistent_dirty_bitmaps() before the caсhe flushin

[Qemu-devel] [PATCH 04/12] virtfs: error out gracefully when mandatory suboptions are missing

2017-09-19 Thread Michael Roth
From: Greg Kurz We internally convert -virtfs to -fsdev/-device. If the user doesn't provide the path or security_model suboptions, and the fsdev backend requires them, we hit an assertion when populating the internal -fsdev option: util/qemu-option.c:547: opt_set: Assertion `opt->str' failed. A

[Qemu-devel] [PATCH 06/12] hw/arm/allwinner-a10: Mark the allwinner-a10 device with user_creatable = false

2017-09-19 Thread Michael Roth
From: Thomas Huth QEMU currently exits unexpectedly when the user accidentially tries to do something like this: $ aarch64-softmmu/qemu-system-aarch64 -S -M integratorcp -nographic QEMU 2.9.93 monitor - type 'help' for more information (qemu) device_add allwinner-a10 Unsupported NIC model: smc91

[Qemu-devel] [PATCH 02/12] s390-ccw: Fix alignment for CCW1

2017-09-19 Thread Michael Roth
From: Farhan Ali The commit 198c0d1f9df8c4 s390x/css: check ccw address validity exposes an alignment issue in ccw bios. According to PoP the CCW must be doubleword aligned. Let's fix this in the bios. Cc: qemu-sta...@nongnu.org Signed-off-by: Farhan Ali Reviewed-by: Halil Pasic Reviewed-by:

[Qemu-devel] [PATCH 11/12] libvhost-user: support resuming vq->last_avail_idx based on used_idx

2017-09-19 Thread Michael Roth
From: Marc-André Lureau This is the same workaround as commit 523b018dde3b765, which was lost with libvhost-user transition in commit e10e798c85c2331. Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry picked from commit 35480cbfcb73143a

[Qemu-devel] [PATCH 12/12] vhost-user-bridge: fix resume regression (since 2.9)

2017-09-19 Thread Michael Roth
From: Marc-André Lureau Commit e10e798c85c2331 switched to libvhost-user which lacked support for resuming the avail_idx based on used_idx. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1485867 Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsi

[Qemu-devel] [PATCH 08/12] vhost: Release memory references on cleanup

2017-09-19 Thread Michael Roth
From: Alex Williamson vhost registers a MemoryListener where it adds and removes references to MemoryRegions as the MemoryRegionSections pass through. The region_add callback is invoked for each existing section when the MemoryListener is registered, but unregistering the MemoryListener performs

[Qemu-devel] [PATCH 01/12] slirp: fix clearing ifq_so from pending packets

2017-09-19 Thread Michael Roth
From: Samuel Thibault The if_fastq and if_batchq contain not only packets, but queues of packets for the same socket. When sofree frees a socket, it thus has to clear ifq_so from all the packets from the queues, not only the first. Signed-off-by: Samuel Thibault Reviewed-by: Philippe Mathieu-Da

[Qemu-devel] [PATCH 00/12] Patch Round-up for stable 2.10.1, freeze on 2017-09-27

2017-09-19 Thread Michael Roth
Hi everyone, The following new patches are queued for QEMU stable v2.10.1: https://github.com/mdroth/qemu/commits/stable-2.10-staging The release is planned for 2017-10-02: https://wiki.qemu.org/Planning/2.10 Please respond here or CC qemu-sta...@nongnu.org on any patches you think should

[Qemu-devel] [PATCH 05/12] arm_gicv3_kvm: Fix compile warning

2017-09-19 Thread Michael Roth
From: Pranith Kumar Fix the following warning: /home/pranith/qemu/hw/intc/arm_gicv3_kvm.c:296:17: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] if (!c->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) { ^

[Qemu-devel] [PATCH 03/12] target/arm: Fix aa64 ldp register writeback

2017-09-19 Thread Michael Roth
From: Richard Henderson For "ldp x0, x1, [x0]", if the second load is on a second page and the second page is unmapped, the exception would be raised with x0 already modified. This means the instruction couldn't be restarted. Cc: qemu-...@nongnu.org Cc: qemu-sta...@nongnu.org Reported-by: Andre

[Qemu-devel] [PATCH 10/12] scsi-bus: correct responses for INQUIRY and REQUEST SENSE

2017-09-19 Thread Michael Roth
From: Hannes Reinecke According to SPC-3 INQUIRY and REQUEST SENSE should return GOOD even on unsupported LUNS. Signed-off-by: Hannes Reinecke Message-Id: <1503049022-14749-1-git-send-email-h...@suse.de> Reported-by: Laszlo Ersek Fixes: ded6ddc5a7b95217557fa360913d1213e12d4a6d Cc: qemu-sta...@

[Qemu-devel] [PATCH 09/12] mps2-an511: Fix wiring of UART overflow interrupt lines

2017-09-19 Thread Michael Roth
From: Peter Maydell Fix an error that meant we were wiring every UART's overflow interrupts into the same inputs 0 and 1 of the OR gate, rather than giving each its own input. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Fran

Re: [Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-19 Thread Alistair Francis
On Tue, Sep 19, 2017 at 1:23 AM, Michael Olbrich wrote: > On Mon, Sep 18, 2017 at 02:28:26PM -0700, Alistair Francis wrote: >> On Sat, Sep 16, 2017 at 3:35 AM, Michael Olbrich >> wrote: >> > The current code checks if the next block exceeds the size of the card. >> > This generates an error while

Re: [Qemu-devel] [PATCH] target/arm: Remove out of date ARM ARM section references in A64 decoder

2017-09-19 Thread Alistair Francis
On Fri, Sep 15, 2017 at 8:08 AM, Peter Maydell wrote: > In the A64 decoder, we have a lot of references to section numbers > from version A.a of the v8A ARM ARM (DDI0487). This version of the > document is now long obsolete (we are currently on revision B.a), > and various intervening versions ren

Re: [Qemu-devel] [PATCH v2 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro

2017-09-19 Thread Alistair Francis
On Fri, Sep 15, 2017 at 3:37 PM, Max Filippov wrote: > On Fri, Sep 15, 2017 at 2:56 PM, Alistair Francis > wrote: >> Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes >> let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead. >> >> This is technically a change of

[Qemu-devel] qmeu-arm SIGSEGV for self-modifying code

2017-09-19 Thread John Reiser
[Moving here from https://bugzilla.redhat.com/show_bug.cgi?id=1493304 ] qemu-arm from qemu-user-2.10.0-1.fc27.x86_64 (thus emulating 32-bit ARM on x86_64) generates SIGSEGV when code modifies a never-previously executed instruction that is on a writable page and is 848 bytes ahead of pc. A real

[Qemu-devel] [PATCH 3/3] linux-user: add SO_LINGER to getsockopt

2017-09-19 Thread Carlo Marcelo Arenas Belón
Signed-off-by: Carlo Marcelo Arenas Belón --- linux-user/syscall.c | 34 +- 1 file changed, 33 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index ad689dad50..91bd27c63a 100644 --- a/linux-user/syscall.c +++ b/linux-user/sys

[Qemu-devel] [PATCH 2/3] linux-user: add SO_LINGER to setsockopt

2017-09-19 Thread Carlo Marcelo Arenas Belón
Original implementation by Chen Gang; all bugs mine Signed-off-by: Chen Gang Signed-off-by: Carlo Marcelo Arenas Belón --- linux-user/syscall.c | 15 +++ linux-user/syscall_defs.h | 5 + 2 files changed, 20 insertions(+) diff --git a/linux-user/syscall.c b/linux-user/sysc

[Qemu-devel] [PATCH 1/3] linux-user: fix TARGET_SO_LINGER for sparc

2017-09-19 Thread Carlo Marcelo Arenas Belón
Signed-off-by: Carlo Marcelo Arenas Belón --- linux-user/socket.h | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/linux-user/socket.h b/linux-user/socket.h index 7051cd2cf4..129f9b4713 100644 --- a/linux-user/socket.h +++ b/linux-user/socket.h @@ -246,8 +246,12 @@ #d

Re: [Qemu-devel] [PATCH v9 05/20] dirty-bitmap: Avoid size query failure during truncate

2017-09-19 Thread John Snow
On 09/19/2017 04:18 PM, Eric Blake wrote: > We've previously fixed several places where we failed to account > for possible errors from bdrv_nb_sectors(). Fix another one by > making bdrv_dirty_bitmap_truncate() take the new size from the > caller instead of querying itself; then adjust the sole

Re: [Qemu-devel] [PATCH 2/2] hw/pcie: disable IO port fwd by default for pcie-root-port

2017-09-19 Thread Laszlo Ersek
Hi Marcel, On 09/06/17 16:26, Marcel Apfelbaum wrote: > For most cases the devices attached to PCIe Root Ports > do not need IO ports range, add an 'enable-io-fwd' property > making it false by default, but keeping it true for older machines. > > Signed-off-by: Marcel Apfelbaum > --- > hw/pci-b

Re: [Qemu-devel] [RFC 07/15] monitor: unify global init

2017-09-19 Thread Eric Blake
On 09/19/2017 04:35 PM, Eric Blake wrote: > On 09/14/2017 02:50 AM, Peter Xu wrote: >> There are many places for monitor init its globals, at least: >> > Are we sure that this new function is called sooner than any access to > monitor_lock, > >> -static void __attribute__((constructor)) monitor_l

Re: [Qemu-devel] [PATCH V8] qqq: module for synchronizing with a simulation

2017-09-19 Thread nutarojj
From: "James J. Nutaro" This revision of the patch fixes and error in which a callback is registered to act read the synchronization socket when qemu indicates it has data. This causes a deadlock and the callback was removed. James J. Nutaro (1): Synchronize the qemu clock with an external s

[Qemu-devel] [PATCH 1/2] ppc: remove unused CPU definitions

2017-09-19 Thread John Snow
Following commit aef77960, remove now-unused definitions from cpu-models.h. Signed-off-by: John Snow --- target/ppc/cpu-models.h | 32 1 file changed, 32 deletions(-) diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h index df31d7f..b34b512 100644 --

[Qemu-devel] [PATCH 0/2] ppc: remove dead definitions

2017-09-19 Thread John Snow
Following conversation from: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg05362.html Split into two patches: (1) Definitions that match Igor's cleanup precisely (2) Everything else I brazenly took a chainsaw to with little precision (Only lightly tested.) John Snow (2): ppc: remove

[Qemu-devel] [PATCH 2/2] ppc: remove all unused CPU definitions

2017-09-19 Thread John Snow
Remove *all* unused CPU definitions as indicated by compile-time `#if 0` constructs. Signed-off-by: John Snow --- target/ppc/cpu-models.h | 223 1 file changed, 223 deletions(-) diff --git a/target/ppc/cpu-models.h b/target/ppc/cpu-models.h index

Re: [Qemu-devel] [RFC 07/15] monitor: unify global init

2017-09-19 Thread Eric Blake
On 09/14/2017 02:50 AM, Peter Xu wrote: > There are many places for monitor init its globals, at least: > > - monitor_init_qmp_commands() at the very beginning > - single function to init monitor_lock > - in the first entry of monitor_init() using "is_first_init" > > Unify them a bit. > > Signed

Re: [Qemu-devel] [PATCH v2] softfloat: rename make_float[x80|128]_init to const_float[x80|128]

2017-09-19 Thread Eric Blake
On 09/19/2017 04:10 PM, Laurent Vivier wrote: > We already have const_float16(), const_float32() and const_float64(), > so rename make_floatx80_init() and make_float128_init() as s/as/to now be/ > const_floatx80() and const_float128(). s/\./, for consistency./ > > Redefine make_float16(), make

[Qemu-devel] [PATCH v2] softfloat: rename make_float[x80|128]_init to const_float[x80|128]

2017-09-19 Thread Laurent Vivier
We already have const_float16(), const_float32() and const_float64(), so rename make_floatx80_init() and make_float128_init() as const_floatx80() and const_float128(). Redefine make_float16(), make_float32() and make_float64() as make_floatx80() and make_float128() using a cast. Signed-off-by: La

Re: [Qemu-devel] [RFC 06/15] monitor: move the cur_mon hack deeper for QMP

2017-09-19 Thread Eric Blake
On 09/14/2017 02:50 AM, Peter Xu wrote: > In monitor_qmp_read(), we have the hack to temporarily replace the > cur_mon pointer. Now we move this hack deeper inside the QMP dispatcher > routine since the Monitor pointer can be passed in to that using the new > JSON Parser opaque field now. > > Thi

Re: [Qemu-devel] [RFC 05/15] qjson: add "opaque" field to JSONMessageParser

2017-09-19 Thread Eric Blake
On 09/14/2017 02:50 AM, Peter Xu wrote: > It'll be passed to emit() as well when it happens. > > Signed-off-by: Peter Xu > --- > include/qapi/qmp/json-streamer.h | 8 ++-- > monitor.c| 7 --- > qga/main.c | 5 +++-- > qobject/json-streamer.c

Re: [Qemu-devel] [RFC 02/15] qobject: allow NULL for qstring_get_str()

2017-09-19 Thread Eric Blake
On 09/14/2017 02:50 AM, Peter Xu wrote: > Then I can get NULL rather than crash when calling things like: > > qstring_get_str(qobject_to_qstring(object)); > > when key does not exist. Right now, qdict_get_str() is documented as: * This function assumes that 'key' exists and it stores a * QS

[Qemu-devel] [PATCH v9 15/20] mirror: Switch mirror_dirty_init() to byte-based iteration

2017-09-19 Thread Eric Blake
Now that we have adjusted the majority of the calls this function makes to be byte-based, it is easier to read the code if it makes passes over the image using bytes rather than sectors. Signed-off-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Kevin Wolf Reviewed-by: Fam Zheng --- v6: no

[Qemu-devel] [PATCH v9 14/20] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes

2017-09-19 Thread Eric Blake
Some of the callers were already scaling bytes to sectors; others can be easily converted to pass byte offsets, all in our shift towards a consistent byte interface everywhere. Making the change will also make it easier to write the hold-out callers to use byte rather than sectors for their iterat

Re: [Qemu-devel] [PATCH v7 1/4] hw/pci: introduce pcie-pci-bridge device

2017-09-19 Thread Eduardo Habkost
On Fri, Aug 18, 2017 at 02:36:47AM +0300, Aleksandr Bezzubikov wrote: > Introduce a new PCIExpress-to-PCI Bridge device, > which is a hot-pluggable PCI Express device and > supports devices hot-plug with SHPC. > > This device is intended to replace the DMI-to-PCI Bridge. > > Signed-off-by: Aleksa

  1   2   3   4   5   6   7   >