[Qemu-devel] [PATCH] 9pfs: fix name_to_path assertion in v9fs_complete_rename()

2017-09-16 Thread Jan Dakinevich
The third parameter of v9fs_co_name_to_path() must not contain `/' character. The issue is most likely related to 9p2000.u protocol only. Signed-off-by: Jan Dakinevich --- hw/9pfs/9p.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/hw/9pfs/9p.c b/hw

[Qemu-devel] [PATCH v2] 9pfs: check the size of transport buffer before marshaling

2017-09-16 Thread Jan Dakinevich
v9fs_do_readdir_with_stat() should check for a maximum buffer size before an attempt to marshal gathered data. Otherwise, buffers assumed as misconfigured and the transport would be broken. The patch brings v9fs_do_readdir_with_stat() in conformity with v9fs_do_readdir() behavior. Signed-off-by:

Re: [Qemu-devel] [PATCH] 9pfs: check the size of transport buffer before marshaling

2017-09-16 Thread Jan Dakinevich
Greg, I couldn't find a way to break transport with 9p2000.L. Do you have a reproducer for the latter ? You're right! The problem is related only to 9p2000.u protocol. In this protocol to list a directory folowing chain is used: TOPEN->TREAD. 9p2000.L uses for the same goal TLOPEN->TREADDIR.

[Qemu-devel] [Bug 1717708] [NEW] QEMU aarch64 can't run Windows ARM64 iso's

2017-09-16 Thread oscarbg
Public bug reported: Hi, recently Windows ARM64 ISOs have been posted on the internet.. just checked with latest QEMU 2.10 release from https://qemu.weilnetz.de/w64/qemu-w64-setup-20170830.exe "h:\qemu\qemu-system-aarch64.exe" -boot d -cdrom h:\iso\16353.1000.170825-1423.RS_PRERELEASE_CLIENTPRO

[Qemu-devel] [Bug 1717708] Re: QEMU aarch64 can't run Windows ARM64 iso's

2017-09-16 Thread oscarbg
I meant: "says guest has not initialized the display".. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1717708 Title: QEMU aarch64 can't run Windows ARM64 iso's Status in QEMU: New Bug descripti

Re: [Qemu-devel] [PATCH 04/10] disas: Support the Capstone disassembler library

2017-09-16 Thread Peter Maydell
On 14 September 2017 at 19:35, Richard Henderson wrote: > > +/* ??? Capstone requires that we copy the data into a host-addressable > + buffer first and has no call-back to read more. Therefore we need > + an estimate of buffer size. This will work for most RISC, but we'll > +

[Qemu-devel] [PATCH v5 6/6] tests: Add check-qobject for equality tests

2017-09-16 Thread Max Reitz
Add a new test file (check-qobject.c) for unit tests that concern QObjects as a whole. Its only purpose for now is to test the qobject_is_equal() function. Signed-off-by: Max Reitz --- tests/Makefile.include | 4 +- tests/check-qobject.c | 315

[Qemu-devel] [PATCH v5 4/6] block: qobject_is_equal() in bdrv_reopen_prepare()

2017-09-16 Thread Max Reitz
Currently, bdrv_reopen_prepare() assumes that all BDS options are strings. However, this is not the case if the BDS has been created through the json: pseudo-protocol or blockdev-add. Note that the user-invokable reopen command is an HMP command, so you can only specify strings there. Therefore, s

[Qemu-devel] [PATCH v5 0/6] block: Don't compare strings in bdrv_reopen_prepare()

2017-09-16 Thread Max Reitz
bdrv_reopen_prepare() assumes that all BDS options are strings, which is not necessarily correct. This series introduces a new qobject_is_equal() function which can be used to test whether any options have changed, independently of their type. v5: - Patch 1: Changes due to rebase - Patch 2: Added

[Qemu-devel] [PATCH v5 3/6] qapi: Add qobject_is_equal()

2017-09-16 Thread Max Reitz
This generic function (along with its implementations for different types) determines whether two QObjects are equal. Signed-off-by: Max Reitz --- include/qapi/qmp/qbool.h | 1 + include/qapi/qmp/qdict.h | 1 + include/qapi/qmp/qlist.h | 1 + include/qapi/qmp/qnull.h | 2 ++ include/

[Qemu-devel] [PATCH v5 1/6] qapi/qnull: Add own header

2017-09-16 Thread Max Reitz
Signed-off-by: Max Reitz --- include/qapi/qmp/qdict.h| 1 + include/qapi/qmp/qnull.h| 30 ++ include/qapi/qmp/qobject.h | 12 include/qapi/qmp/types.h| 1 + qapi/qapi-clone-visitor.c | 1 + qapi/string-input-visitor.c | 1 + qobject/qnul

[Qemu-devel] [PATCH v5 5/6] iotests: Add test for non-string option reopening

2017-09-16 Thread Max Reitz
Reviewed-by: Kevin Wolf Signed-off-by: Max Reitz --- tests/qemu-iotests/133 | 9 + tests/qemu-iotests/133.out | 5 + 2 files changed, 14 insertions(+) diff --git a/tests/qemu-iotests/133 b/tests/qemu-iotests/133 index 9d35a6a1ca..af6b3e1dd4 100755 --- a/tests/qemu-iotests/133 ++

[Qemu-devel] [PATCH v5 2/6] qapi/qlist: Add qlist_append_null() macro

2017-09-16 Thread Max Reitz
Signed-off-by: Max Reitz --- include/qapi/qmp/qlist.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/qapi/qmp/qlist.h b/include/qapi/qmp/qlist.h index c4b5fdad9b..59d209bbae 100644 --- a/include/qapi/qmp/qlist.h +++ b/include/qapi/qmp/qlist.h @@ -15,6 +15,7 @@ #include "qapi/qm

Re: [Qemu-devel] [PATCH 04/10] disas: Support the Capstone disassembler library

2017-09-16 Thread Peter Maydell
On 14 September 2017 at 19:35, Richard Henderson wrote: > If configured, prefer this over our rather dated copy of the > GPLv2-only binutils. This will be especially apparent with > the proposed vector extensions to TCG, as disas/i386.c does > not handle AVX. > > Signed-off-by: Richard Henderson

Re: [Qemu-devel] [PATCH v3 7/7] block: support passthrough of BDRV_REQ_FUA in crypto driver

2017-09-16 Thread Max Reitz
On 2017-09-12 13:28, Daniel P. Berrange wrote: > The BDRV_REQ_FUA flag can trivially be allowed in the crypt driver > as a passthrough to the underlying block driver. > > Signed-off-by: Daniel P. Berrange > --- > block/crypto.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) Revi

Re: [Qemu-devel] [PATCH v3 6/7] block: convert qcrypto_block_encrypt|decrypt to take bytes offset

2017-09-16 Thread Max Reitz
On 2017-09-12 13:28, Daniel P. Berrange wrote: > Instead of sector offset, take the bytes offset when encrypting > or decrypting data. > > Signed-off-by: Daniel P. Berrange > --- > block/crypto.c | 12 > block/qcow.c | 7 +-- > block/qcow2-cluster.c | 8 +++-

Re: [Qemu-devel] [PATCH v3 5/7] block: convert crypto driver to bdrv_co_preadv|pwritev

2017-09-16 Thread Max Reitz
On 2017-09-12 13:28, Daniel P. Berrange wrote: > Make the crypto driver implement the bdrv_co_preadv|pwritev > callbacks, and also use bdrv_co_preadv|pwritev for I/O > with the protocol driver beneath. > > Signed-off-by: Daniel P. Berrange > --- > block/crypto.c | 104 >

[Qemu-devel] [PATCH 1/6] hw/arm/palm.c: Don't use old_mmio for static_ops

2017-09-16 Thread Peter Maydell
Update the static_ops functions to use new-style mmio rather than the legacy old_mmio functions. Signed-off-by: Peter Maydell --- hw/arm/palm.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/hw/arm/palm.c b/hw/arm/palm.c index bf070a2..264f5b

[Qemu-devel] [PATCH 5/6] hw/i2c/omap_i2c.c: Don't use old_mmio

2017-09-16 Thread Peter Maydell
Don't use old_mmio in the memory region ops struct. Signed-off-by: Peter Maydell --- hw/i2c/omap_i2c.c | 44 1 file changed, 32 insertions(+), 12 deletions(-) diff --git a/hw/i2c/omap_i2c.c b/hw/i2c/omap_i2c.c index f6e80be..12264ee 100644 --- a/hw/i

[Qemu-devel] [PATCH 2/6] hw/gpio/omap_gpio.c: Don't use old_mmio

2017-09-16 Thread Peter Maydell
Drop the use of old_mmio in the omap2_gpio memory ops. Signed-off-by: Peter Maydell --- hw/gpio/omap_gpio.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/hw/gpio/omap_gpio.c b/hw/gpio/omap_gpio.c index 1df394e..17891e2 100644 --- a/hw/gpio/omap_

[Qemu-devel] [PATCH 6/6] hw/arm/omap2.c: Don't use old_mmio

2017-09-16 Thread Peter Maydell
Don't use old_mmio in the memory region ops struct. Signed-off-by: Peter Maydell --- hw/arm/omap2.c | 49 + 1 file changed, 37 insertions(+), 12 deletions(-) diff --git a/hw/arm/omap2.c b/hw/arm/omap2.c index ece25ae..f35d265 100644 --- a/hw/arm/o

[Qemu-devel] [PATCH 3/6] hw/timer/omap_synctimer.c: Don't use old_mmio

2017-09-16 Thread Peter Maydell
Don't use the old_mmio in the memory region ops struct. Signed-off-by: Peter Maydell --- hw/timer/omap_synctimer.c | 35 +-- 1 file changed, 21 insertions(+), 14 deletions(-) diff --git a/hw/timer/omap_synctimer.c b/hw/timer/omap_synctimer.c index 9ee6519..0d75a9

[Qemu-devel] [PATCH 0/6] convert some omap/palm devices from using old_mmio

2017-09-16 Thread Peter Maydell
This patchset converts a handful of old devices from the old_mmio fields in MemoryRegionOps. We don't have very many devices still using old_mmio, so it would be nice to get rid of the remainder and drop the field entirely at some point. (You could argue that really we should mark some of these ol

[Qemu-devel] [PATCH 4/6] hw/timer/omap_gptimer: Don't use old_mmio

2017-09-16 Thread Peter Maydell
Don't use the old_mmio struct in memory region ops. Signed-off-by: Peter Maydell --- hw/timer/omap_gptimer.c | 49 + 1 file changed, 37 insertions(+), 12 deletions(-) diff --git a/hw/timer/omap_gptimer.c b/hw/timer/omap_gptimer.c index 5e3e8a6..6d

Re: [Qemu-devel] [PATCH v3 2/7] crypto: expose encryption sector size in APIs

2017-09-16 Thread Max Reitz
On 2017-09-12 13:28, Daniel P. Berrange wrote: > While current encryption schemes all have a fixed sector size of > 512 bytes, this is not guaranteed to be the case in future. Expose > the sector size in the APIs so the block layer can remove assumptions > about fixed 512 byte sectors. > > Signed-

Re: [Qemu-devel] [PATCH v3 1/7] block: use 1 MB bounce buffers for crypto instead of 16KB

2017-09-16 Thread Max Reitz
On 2017-09-12 13:28, Daniel P. Berrange wrote: > Using 16KB bounce buffers creates a significant performance > penalty for I/O to encrypted volumes on storage which high > I/O latency (rotating rust & network drives), because it > triggers lots of fairly small I/O operations. > > On tests with rot

Re: [Qemu-devel] [PATCH v3 3/7] block: fix data type casting for crypto payload offset

2017-09-16 Thread Max Reitz
On 2017-09-12 13:28, Daniel P. Berrange wrote: > The crypto APIs report the offset of the data payload as an uint64_t > type, but the block driver is casting to size_t or ssize_t which will > potentially truncate. > > Most of the block APIs use int64_t for offsets meanwhile, so even if > using uin

Re: [Qemu-devel] [PATCH v3 4/7] block: don't use constant 512 as sector size in crypto driver

2017-09-16 Thread Max Reitz
On 2017-09-12 13:28, Daniel P. Berrange wrote: > Use the qcrypto_block_get_sector_size() value in the block > crypto driver instead of hardcoding 512 as the sector size. > > Signed-off-by: Daniel P. Berrange > --- > block/crypto.c | 34 ++ > 1 file changed, 18 ins

Re: [Qemu-devel] [PATCH v7 1/4] qemu-img: add --shrink flag for resize

2017-09-16 Thread Max Reitz
On 2017-08-17 11:15, Pavel Butsykin wrote: > The flag is additional precaution against data loss. Perhaps in the future the > operation shrink without this flag will be blocked for all formats, but for > now > we need to maintain compatibility with raw. > > Signed-off-by: Pavel Butsykin > Review

Re: [Qemu-devel] [PATCH v7 3/4] qcow2: add shrink image support

2017-09-16 Thread Max Reitz
On 2017-08-17 11:15, Pavel Butsykin wrote: > This patch add shrinking of the image file for qcow2. As a result, this allows > us to reduce the virtual image size and free up space on the disk without > copying the image. Image can be fragmented and shrink is done by punching > holes > in the image

Re: [Qemu-devel] [PATCH v7 2/4] qcow2: add qcow2_cache_discard

2017-09-16 Thread Max Reitz
On 2017-08-17 11:15, Pavel Butsykin wrote: > Whenever l2/refcount table clusters are discarded from the file we can > automatically drop unnecessary content of the cache tables. This reduces > the chance of eviction useful cache data and eliminates inconsistent data > in the cache with the data in

Re: [Qemu-devel] [PATCH v7 0/4] Add shrink image for qcow2

2017-09-16 Thread Max Reitz
On 2017-08-22 01:31, John Snow wrote: > > > On 08/17/2017 05:15 AM, Pavel Butsykin wrote: >> This patch add shrinking of the image file for qcow2. As a result, this >> allows >> us to reduce the virtual image size and free up space on the disk without >> copying the image. Image can be fragmente

Re: [Qemu-devel] [PULL 00/11] Ide patches

2017-09-16 Thread Peter Maydell
On 16 September 2017 at 02:03, John Snow wrote: > The following changes since commit 5faf2d376af3cb4eb92da44c2580e08d39832caa: > > Merge remote-tracking branch 'remotes/huth/tags/check-20170915' into > staging (2017-09-15 20:29:44 +0100) > > are available in the git repository at: > > https:/

Re: [Qemu-devel] [PULL 00/15] Python queue, 2017-09-15

2017-09-16 Thread Peter Maydell
On 16 September 2017 at 00:37, Eduardo Habkost wrote: > I have been queueing some patches for Python modules and scripts, > recently, and submitted a MAINTAINERS patch to include Cleber and > me as maintainers. > > However, I don't want to delay this pull request to avoid > conflicts if people sen

[Qemu-devel] [PATCH v2 1/4] ohci: Allow sysbus version to be used as a companion

2017-09-16 Thread BALATON Zoltan
Some PPC SoCs have an EHCI with OHCI companion USB controller. To emulate this allow the sysbus version of OHCI to be used as a companion. Signed-off-by: BALATON Zoltan Reviewed-by: David Gibson Reviewed-by: Gerd Hoffmann --- v2: Added R-b from http://lists.nongnu.org/archive/html/qemu-ppc/201

[Qemu-devel] [PATCH v2 0/4] Sam460ex emulation

2017-09-16 Thread BALATON Zoltan
Resending those patches that were reviewed and did not need any changes or only rebasing to latest master so these could go in now. I'll get back to the other patches that need more changes later. BALATON Zoltan (4): ohci: Allow sysbus version to be used as a companion ehci: Add ppc4xx-ehci fo

[Qemu-devel] [PATCH v2 2/4] ehci: Add ppc4xx-ehci for the USB 2.0 controller in embedded PPC SoCs

2017-09-16 Thread BALATON Zoltan
Some PPC SoCs have an EHCI with OHCI companion USB controller. Add a new type for this similar to types used for other embedded SoCs. Signed-off-by: BALATON Zoltan Reviewed-by: David Gibson Reviewed-by: Gerd Hoffmann --- v2: Added R-b from: http://lists.nongnu.org/archive/html/qemu-ppc/2017-08

[Qemu-devel] [PATCH v2 4/4] ppc: Add 460EX embedded CPU

2017-09-16 Thread BALATON Zoltan
Despite its name it is a 440 core CPU Signed-off-by: BALATON Zoltan Reviewed-by: David Gibson --- v2: Rebased to latest changes on master target/ppc/cpu-models.c | 3 +++ target/ppc/cpu-models.h | 1 + target/ppc/translate_init.c | 38 ++ 3 files c

[Qemu-devel] [PATCH v2 3/4] ppc4xx: Add more PLB registers

2017-09-16 Thread BALATON Zoltan
These registers are present in 440 SoCs (and maybe in others too) and U-Boot accesses them when printing register info. We don't emulate these but add them to avoid crashing when they are read or written. Signed-off-by: BALATON Zoltan --- v2: No change, discussed in: http://lists.nongnu.org/arch

Re: [Qemu-devel] [PATCH 00/18] block/mirror: Add active-sync mirroring

2017-09-16 Thread Max Reitz
On 2017-09-14 17:42, Stefan Hajnoczi wrote: > On Wed, Sep 13, 2017 at 08:18:52PM +0200, Max Reitz wrote: >> There may be a couple of things to do on top of this series: >> - Allow switching between active and passive mode at runtime: This >> should not be too difficult to implement, the main ques

Re: [Qemu-devel] [PATCH 15/18] block/mirror: Add active mirroring

2017-09-16 Thread Max Reitz
On 2017-09-14 17:57, Stefan Hajnoczi wrote: > On Wed, Sep 13, 2017 at 08:19:07PM +0200, Max Reitz wrote: >> This patch implements active synchronous mirroring. In active mode, the >> passive mechanism will still be in place and is used to copy all >> initially dirty clusters off the source disk; b

Re: [Qemu-devel] [PULL 0/1] Tracing patches

2017-09-16 Thread Peter Maydell
On 15 September 2017 at 18:39, Stefan Hajnoczi wrote: > The following changes since commit 3dabde1128b671f36ac6cb36b97b273139964420: > > Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170914' into > staging (2017-09-14 16:33:02 +0100) > > are available in the git repository at:

Re: [Qemu-devel] [PULL 00/06] seccomp branch queue

2017-09-16 Thread Peter Maydell
On 15 September 2017 at 09:41, Eduardo Otubo wrote: > The following changes since commit 3dabde1128b671f36ac6cb36b97b273139964420: > > Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170914' into > staging (2017-09-14 16:33:02 +0100) > > are available in the git repository at: >

[Qemu-devel] [PATCH v2] hw/sd: fix out-of-bounds check for multi block reads

2017-09-16 Thread Michael Olbrich
The current code checks if the next block exceeds the size of the card. This generates an error while reading the last block of the card. Do the out-of-bounds check when starting to read a new block to fix this. This issue became visible with increased error checking in Linux 4.13. Signed-off-by:

Re: [Qemu-devel] [PATCH] hw/sd: fix out-of-bounds check for multi block reads

2017-09-16 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [PATCH] hw/sd: fix out-of-bounds check for multi block reads Type: series Message-id: 20170916091611.10241-1-m.olbr...@pengutronix.de === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will

[Qemu-devel] [PATCH] hw/sd: fix out-of-bounds check for multi block reads

2017-09-16 Thread Michael Olbrich
The current code checks if the next block exceeds the size of the card. This generates an error while reading the last block of the card. Do the out-of-bounds check when starting to read a new block to fix this. This issue became visible with increased error checking in Linux 4.13. Signed-off-by:

Re: [Qemu-devel] [PATCH] dma/i82374: avoid double creation of i82374 device

2017-09-16 Thread Paolo Bonzini
- Original Message - > From: "Eduardo Habkost" > To: "Paolo Bonzini" > Cc: "Eduardo Otubo" , qemu-devel@nongnu.org, > qemu-triv...@nongnu.org, "Michael Tokarev" > , "Markus Armbruster" , "Alexander Graf" > > Sent: Saturday, September 16, 2017 12:21:13 AM > Subject: Re: [PATCH] dma/i8