Re: [Qemu-devel] [PATCH 1/3] migration: Allow ram_save_cleanup to be called with empty state

2017-09-14 Thread Peter Xu
On Fri, Sep 15, 2017 at 02:49:07PM +0800, Fam Zheng wrote: > On Fri, 09/15 14:41, Peter Xu wrote: > > On Fri, Sep 15, 2017 at 01:44:02PM +0800, Fam Zheng wrote: > > > So that we can do cleanup unconditionally at the end of main(). > > > > > > Signed-off-by: Fam Zheng > > > --- > > > migration/ra

Re: [Qemu-devel] [PULL v3 00/38] Test and build patches

2017-09-14 Thread Fam Zheng
On Fri, 09/15 14:45, Fam Zheng wrote: > The following changes since commit 04ef33052c205170c92df21ca0b4be4f3b102188: > > tcg/tci: do not use ldst label (never implemented) (2017-09-11 19:24:05 > +0100) > > are available in the git repository at: > > git://github.com/famz/qemu.git tags/test-

[Qemu-devel] [PULL v3 18/38] MAINTAINERS: Add tests/vm entry

2017-09-14 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Message-Id: <20170913030119.3957-12-f...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36eeb42d19..42f5454311 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1891,6 +1891,7 @@ S

[Qemu-devel] [PULL v3 19/38] tests: Add README for vm tests

2017-09-14 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-13-f...@redhat.com> --- tests/vm/README | 63 + 1 file changed, 63 insertions(+) create mode 100644 tests/vm/README diff --git a/tests/vm/README b/tests/vm/README new file mode 1006

[Qemu-devel] [PULL v3 15/38] tests: Add NetBSD image

2017-09-14 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski Message-Id: <20170913030119.3957-9-f...@redhat.com> --- tests/vm/netbsd | 42 ++ 1 file changed, 42 insertions(+)

Re: [Qemu-devel] [PATCH 1/3] migration: Allow ram_save_cleanup to be called with empty state

2017-09-14 Thread Fam Zheng
On Fri, 09/15 14:41, Peter Xu wrote: > On Fri, Sep 15, 2017 at 01:44:02PM +0800, Fam Zheng wrote: > > So that we can do cleanup unconditionally at the end of main(). > > > > Signed-off-by: Fam Zheng > > --- > > migration/ram.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/mi

[Qemu-devel] [PULL v3 12/38] tests: Add vm test lib

2017-09-14 Thread Fam Zheng
This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file to the guest. 4) SSH into the VM, untar the s

[Qemu-devel] [PULL v3 20/38] docker: Use archive-source.py

2017-09-14 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-14-f...@redhat.com> --- tests/docker/Makefile.include | 15 ++- tests/docker/run | 8 +--- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.

[Qemu-devel] [PULL v3 17/38] Makefile: Add rules to run vm tests

2017-09-14 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-11-f...@redhat.com> --- Makefile | 2 ++ configure | 2 +- tests/vm/Makefile.include | 42 ++ 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 t

[Qemu-devel] [PULL v3 09/38] qemu.py: Add "wait()" method

2017-09-14 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Alex Bennée Message-Id: <20170913030119.3957-3-f...@redhat.com> --- scripts/qemu.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 4d8ee10943..99963053a5 100644 --- a/scripts/q

[Qemu-devel] [PULL v3 16/38] tests: Add OpenBSD image

2017-09-14 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-10-f...@redhat.com> --- tests/vm/openbsd | 43 +++ 1 file changed, 43 insertions(+) create mode 100755 tests/vm/

[Qemu-devel] [PULL v3 13/38] tests: Add ubuntu.i386 image

2017-09-14 Thread Fam Zheng
This adds a 32bit guest. The official LTS cloud image is downloaded and initialized with cloud-init. Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-7-f...@redhat.com> --- tests/vm/ubuntu.i386 | 88 1 file changed, 88 insertions(+)

[Qemu-devel] [PULL v3 11/38] tests: Add a test key pair

2017-09-14 Thread Fam Zheng
This will be used by setup test user ssh. Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-5-f...@redhat.com> --- tests/keys/id_rsa | 27 +++ tests/keys/id_rsa.pub | 1 + 2 files changed, 28 insertions(+) create mode 100644 tests/keys/id_rsa create mode 10

[Qemu-devel] [PULL v3 14/38] tests: Add FreeBSD image

2017-09-14 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-8-f...@redhat.com> --- tests/vm/freebsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/fr

[Qemu-devel] [PULL v3 08/38] gitignore: Ignore vm test images

2017-09-14 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-2-f...@redhat.com> --- .gitignore | 1 + tests/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index cf65316863..40acfcb9e2 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,7 @@ /vscclie

[Qemu-devel] [PULL v3 10/38] scripts: Add archive-source.sh

2017-09-14 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170913030119.3957-4-f...@redhat.com> --- scripts/archive-source.sh | 33 + 1 file changed, 33 insertions(+) create mode 100755 scripts/archive-source.sh diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh new

[Qemu-devel] [PULL v3 00/38] Test and build patches

2017-09-14 Thread Fam Zheng
The following changes since commit 04ef33052c205170c92df21ca0b4be4f3b102188: tcg/tci: do not use ldst label (never implemented) (2017-09-11 19:24:05 +0100) are available in the git repository at: git://github.com/famz/qemu.git tags/test-and-build-pull-request for you to fetch changes up to

Re: [Qemu-devel] [PATCH 1/3] migration: Allow ram_save_cleanup to be called with empty state

2017-09-14 Thread Peter Xu
On Fri, Sep 15, 2017 at 01:44:02PM +0800, Fam Zheng wrote: > So that we can do cleanup unconditionally at the end of main(). > > Signed-off-by: Fam Zheng > --- > migration/ram.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/migration/ram.c b/migration/ram.c > index e18b3e2d4f..37e

[Qemu-devel] [PATCH qemu v2] pci: Initialize pci_dev->name before use

2017-09-14 Thread Alexey Kardashevskiy
This moves pci_dev->name initialization earlier so pci_dev->bus_master_as could get a name instead of an empty string. Signed-off-by: Alexey Kardashevskiy Reviewed-by: Philippe Mathieu-Daudé --- Changes: v2: * fixed mistype in the commit log * added "rb" --- hw/pci/pci.c | 2 +- 1 file changed,

Re: [Qemu-devel] [Qemu devel v8 PATCH 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit

2017-09-14 Thread sundeep subbaraya
Hi Peter, On Thu, Sep 14, 2017 at 10:44 PM, Peter Maydell wrote: > On 7 September 2017 at 20:24, Subbaraya Sundeep > wrote: > > Emulated Emcraft's Smartfusion2 System On Module starter > > kit. > > +static void emcraft_sf2_machine_init(MachineClass *mc) > > +{ > > +mc->desc = "SmartFusion2

Re: [Qemu-devel] [PATCH v7 03/13] scripts: Add archive-source.sh

2017-09-14 Thread Fam Zheng
On Wed, 09/13 11:55, Peter Maydell wrote: > On 13 September 2017 at 04:01, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > scripts/archive-source.sh | 33 + > > 1 file changed, 33 insertions(+) > > create mode 100755 scripts/archive-source.sh > > > > di

[Qemu-devel] [PATCH] iotests: Print full path of bad output if mismatch

2017-09-14 Thread Fam Zheng
So it is easier to copy paste the path. Signed-off-by: Fam Zheng --- tests/qemu-iotests/check | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index d504b6e455..4583a0c269 100755 --- a/tests/qemu-iotests/check +++ b/tests/qem

[Qemu-devel] [PATCH 3/3] iotests: Add "quit during block migration" case 195

2017-09-14 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/195 | 97 ++ tests/qemu-iotests/195.out | 19 + tests/qemu-iotests/group | 1 + 3 files changed, 117 insertions(+) create mode 100755 tests/qemu-iotests/195 create mode 100644 tests/qemu-i

[Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-14 Thread Fam Zheng
bdrv_close_all() would abort() due to op blockers added by BMDS, clean up migration states when main loop quits to avoid that. Signed-off-by: Fam Zheng --- include/migration/misc.h | 1 + migration/migration.c| 7 ++- vl.c | 3 +++ 3 files changed, 10 insertions(+), 1

[Qemu-devel] [PATCH 0/3] migration: Fix crash by cleaning up before quit

2017-09-14 Thread Fam Zheng
Quit command causes asssertion failure in block layer due to op blockers added by BMDS, if there is an active block migration. Fixing this by calling migration cleaning up functions at the end of main() before bdrv_close_all() is called. Fam Zheng (3): migration: Allow ram_save_cleanup to be ca

[Qemu-devel] [PATCH 1/3] migration: Allow ram_save_cleanup to be called with empty state

2017-09-14 Thread Fam Zheng
So that we can do cleanup unconditionally at the end of main(). Signed-off-by: Fam Zheng --- migration/ram.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index e18b3e2d4f..37e6a71241 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1365,6 +1365,9

Re: [Qemu-devel] [PATCH 2/3] kvm: check KVM_CAP_NR_VCPUS with kvm_vm_check_extension()

2017-09-14 Thread Thomas Huth
On 14.09.2017 21:25, Greg Kurz wrote: > On a modern server-class ppc host with the following CPU topology: > > Architecture: ppc64le > Byte Order:Little Endian > CPU(s):32 > On-line CPU(s) list: 0,8,16,24 > Off-line CPU(s) list: 1-7,9-15,17-23,25-31 > Thread

Re: [Qemu-devel] [PATCH 1/3] kvm: check KVM_CAP_SYNC_MMU with kvm_vm_check_extension()

2017-09-14 Thread Thomas Huth
On 14.09.2017 21:25, Greg Kurz wrote: > On a server-class ppc host, this capability depends on the KVM type, > ie, HV or PR. If both KVM are present in the kernel, we will always > get the HV specific value, even if we explicitely requested PR on > the command line. > > This can have an impact if

Re: [Qemu-devel] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension()

2017-09-14 Thread Thomas Huth
On 14.09.2017 21:25, Greg Kurz wrote: > The following capabilities are VM specific: > - KVM_CAP_PPC_SMT_POSSIBLE > - KVM_CAP_PPC_HTAB_FD BTW, looks like kvmppc_has_cap_htab_fd() is dead code ... should we either remove it or check it somewhere? > - KVM_CAP_PPC_ALLOC_HTAB > > If both KVM HV and K

Re: [Qemu-devel] [PULL 00/18] ppc-for-2.11 queue 20170915

2017-09-14 Thread David Gibson
On Thu, Sep 14, 2017 at 09:26:49PM -0700, no-re...@patchew.org wrote: > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PULL 00/18] ppc-for-2.11 queue 20170915 > Message-id: 20170915035130.8354-1-da...@gibson.dropbe

Re: [Qemu-devel] [PATCH 00/10] Support the Capstone disassembler

2017-09-14 Thread Philippe Mathieu-Daudé
On 09/14/2017 03:35 PM, Richard Henderson wrote: As occasionally discussed on this list, due to licensing conflicts, we are restricted to a version of libopcodes that pre-dates its upstream re-licensing to gplv3. That makes our copy rather old and dated. I've already seen this as problematic fo

Re: [Qemu-devel] [PATCH 04/10] disas: Support the Capstone disassembler library

2017-09-14 Thread Philippe Mathieu-Daudé
Hi Richard, see inlined comments. On 09/14/2017 03:35 PM, Richard Henderson wrote: If configured, prefer this over our rather dated copy of the GPLv2-only binutils. This will be especially apparent with the proposed vector extensions to TCG, as disas/i386.c does not handle AVX. Signed-off-by:

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-14 Thread Peter Xu
On Thu, Sep 14, 2017 at 07:53:15PM +0100, Dr. David Alan Gilbert wrote: > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > > Hi > > > > On Thu, Sep 14, 2017 at 9:50 AM, Peter Xu wrote: > > > This series was born from this one: > > > > > > https://lists.gnu.org/archive/html/qemu-devel/2

Re: [Qemu-devel] [PULL 00/18] ppc-for-2.11 queue 20170915

2017-09-14 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/18] ppc-for-2.11 queue 20170915 Message-id: 20170915035130.8354-1-da...@gibson.dropbear.id.au Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(

[Qemu-devel] [PULL 12/18] xics: fix several error leaks

2017-09-14 Thread David Gibson
From: Greg Kurz If object_property_get_link() fails then it allocates an error, which must be freed before returning. The error_get_pretty() function is merely an accessor to the error message and doesn't free anything. The error.h header indicates how to do it right: * Pass an existing error

[Qemu-devel] [PULL 13/18] spapr_cpu_core: fail gracefully with non-pseries machine types

2017-09-14 Thread David Gibson
From: Greg Kurz Since commit 7cca3e466eb0 ("ppc: spapr: Move VCPU ID calculation into sPAPR"), QEMU aborts when started with a *-spapr-cpu-core device and a non-pseries machine. Let's rely on the already existing call to object_dynamic_cast() instead of using the SPAPR_MACHINE() macro. Signed-o

[Qemu-devel] [PULL 17/18] spapr_events: use QTAILQ_FOREACH_SAFE() in spapr_clear_pending_events()

2017-09-14 Thread David Gibson
From: Greg Kurz QTAILQ_FOREACH_SAFE() must be used when removing the current element inside the loop block. This fixes a user-after-free error introduced by commit 56258174238eb and reported by Coverity (CID 1381017). Signed-off-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr_even

[Qemu-devel] [PULL 10/18] spapr_pci: handle FDT creation errors with _FDT()

2017-09-14 Thread David Gibson
From: Greg Kurz libfdt failures when creating the FDT should cause QEMU to terminate. Let's use the _FDT() macro which does just that instead of propagating the error to the caller. spapr_populate_pci_child_dt() no longer needs to return a value in this case. Note that, on the way, this get rid

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-14 Thread Peter Xu
On Thu, Sep 14, 2017 at 07:56:04PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > This series was born from this one: > > > > https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04310.html > > Are patches 1..6 separable and mergable without the rest ? Yes

[Qemu-devel] [PULL 15/18] spapr_pci: don't create 64-bit MMIO window if we don't need to

2017-09-14 Thread David Gibson
From: Greg Kurz When running a pseries-2.2 or older machine type, we get the following lines in info mtree: address-space: memory ... - (prio 0, i/o): alias pci@8002000.mmio64-alias @p...@8002000.mmio - address-s

[Qemu-devel] [PULL 09/18] spapr_pci: use the common _FDT() helper

2017-09-14 Thread David Gibson
From: Greg Kurz All other users in hw/ppc already consider an error when building the FDT to be fatal, even on hotplug paths. There's no valid reason for spapr_pci to behave differently. So let's used the common _FDT() helper which terminates QEMU when libfdt fails. Signed-off-by: Greg Kurz Sig

[Qemu-devel] [PULL 16/18] spapr_cpu_core: cleaning up qdev_get_machine() calls

2017-09-14 Thread David Gibson
From: Greg Kurz This patch removes the qdev_get_machine() calls that are made in spapr_cpu_core.c in situations where we can get an existing pointer for the MachineState by either passing it as an argument to the function or by using other already available pointers. Credits to Daniel Henrique B

[Qemu-devel] [PULL 07/18] ppc/xive: fix OV5_XIVE_EXPLOIT bits

2017-09-14 Thread David Gibson
From: Cédric Le Goater On POWER9, the Client Architecture Support (CAS) negotiation process determines whether the guest operates in XIVE Legacy compatibility or in XIVE exploitation mode. Now that we have initial guest support for the XIVE interrupt controller, let's fix the bits definition whic

[Qemu-devel] [PULL 01/18] net: Add SunGEM device emulation as found on Apple UniNorth

2017-09-14 Thread David Gibson
From: Benjamin Herrenschmidt This adds a simplistic emulation of the Sun GEM ethernet controller found in Apple ASICs. Currently we only support the Apple UniNorth 1.x variant, but the other Apple or Sun variants should mostly be a matter of adding PCI IDs options. We have a very primitive emul

[Qemu-devel] [PULL 18/18] ppc/kvm: use kvm_vm_check_extension() in kvmppc_is_pr()

2017-09-14 Thread David Gibson
From: Greg Kurz If the host has both KVM PR and KVM HV loaded and we pass: -machine pseries,accel=kvm,kvm-type=PR the kvmppc_is_pr() returns false instead of true. Since the helper is mostly used as fallback, it doesn't have any real impact with recent kernels. A notable exception is th

[Qemu-devel] [PULL 14/18] spapr_pci: convert sprintf() to g_strdup_printf()

2017-09-14 Thread David Gibson
From: Greg Kurz In order to follow a QEMU common practice. Signed-off-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr_pci.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 75cd939223..7d84b9766

[Qemu-devel] [PULL 02/18] hw/ppc/spapr.c: cleaning up qdev_get_machine() calls

2017-09-14 Thread David Gibson
From: Daniel Henrique Barboza This patch removes the qdev_get_machine() calls that are made in spapr.c in situations where we can get an existing pointer for the MachineState by either passing it as an argument to the function or by using other already available pointers. The following changes w

[Qemu-devel] [PULL 05/18] spapr_pci: use g_strdup_printf()

2017-09-14 Thread David Gibson
From: Greg Kurz Building strings with g_strdup_printf() instead of snprintf() is a QEMU common practice. Signed-off-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr_pci.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/hw/ppc/spapr_pci.c b/hw

[Qemu-devel] [PULL 06/18] spapr: only update SDR1 once per-cpu during CAS

2017-09-14 Thread David Gibson
From: Greg Kurz Commit b55d295e3ec9 added the possibility to support HPT resizing with KVM. In the case of PR, we need to pass the userspace address of the HPT to KVM using the SDR1 slot. This is handled by kvmppc_update_sdr1() which uses CPU_FOREACH() to update all CPUs. It is hence not needed t

[Qemu-devel] [PULL 08/18] spapr: fix CAS-generated reset

2017-09-14 Thread David Gibson
From: Cédric Le Goater The OV5_MMU_RADIX_300 requires special handling in the CAS negotiation process. It is cleared from the option vector of the guest before evaluating the changes and re-added later. But, when testing for a possible CAS reset : spapr->cas_reboot = spapr_ovec_diff(ov5_upda

[Qemu-devel] [PULL 00/18] ppc-for-2.11 queue 20170915

2017-09-14 Thread David Gibson
The following changes since commit 3dabde1128b671f36ac6cb36b97b273139964420: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170914' into staging (2017-09-14 16:33:02 +0100) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.1

[Qemu-devel] [PULL 04/18] spapr_pci: drop useless check in spapr_populate_pci_child_dt()

2017-09-14 Thread David Gibson
From: Greg Kurz spapr_phb_get_loc_code() either returns a non-null pointer, or aborts if g_strdup_printf() failed to allocate memory. Signed-off-by: Greg Kurz [dwg: Grammatical fix to commit message] Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/ppc/spapr_pci.c | 6 +

[Qemu-devel] [PULL 03/18] spapr_pci: drop useless check in spapr_phb_vfio_get_loc_code()

2017-09-14 Thread David Gibson
From: Greg Kurz g_strdup_printf() either returns a non-null pointer, or aborts if it failed to allocate memory. Signed-off-by: Greg Kurz [dwg: Grammatical fix to commit message] Acked-by: Philippe Mathieu-Daudé Signed-off-by: David Gibson --- hw/ppc/spapr_pci.c | 4 ++-- 1 file changed, 2 in

[Qemu-devel] [PULL 11/18] vfio, spapr: Fix levels calculation

2017-09-14 Thread David Gibson
From: Alexey Kardashevskiy The existing tries to round up the number of pages but @pages is always calculated as the rounded up value minus one which makes ctz64() always return 0 and have create.levels always set 1. This removes wrong "-1" and allows having more than 1 levels. This becomes han

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-14 Thread Peter Xu
On Thu, Sep 14, 2017 at 04:19:11PM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 14, 2017 at 01:15:09PM +0200, Marc-André Lureau wrote: > > There should be a limit in the number of requests the thread can > > queue. Before the patch, the limit was enforced by system socket > > buffering I think. Now,

Re: [Qemu-devel] [PATCH 1/3] kvm: check KVM_CAP_SYNC_MMU with kvm_vm_check_extension()

2017-09-14 Thread David Gibson
On Thu, Sep 14, 2017 at 09:25:22PM +0200, Greg Kurz wrote: > On a server-class ppc host, this capability depends on the KVM type, > ie, HV or PR. If both KVM are present in the kernel, we will always > get the HV specific value, even if we explicitely requested PR on > the command line. > > This c

Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-14 Thread Peter Xu
On Thu, Sep 14, 2017 at 04:33:34PM +0100, Stefan Hajnoczi wrote: > On Thu, Sep 14, 2017 at 03:50:35PM +0800, Peter Xu wrote: > > diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt > > index 61fa167..47d16bb 100644 > > --- a/docs/devel/qapi-code-gen.txt > > +++ b/docs/devel/qap

Re: [Qemu-devel] [PATCH 2/3] kvm: check KVM_CAP_NR_VCPUS with kvm_vm_check_extension()

2017-09-14 Thread David Gibson
On Thu, Sep 14, 2017 at 09:25:32PM +0200, Greg Kurz wrote: 1;4803;0c> On a modern server-class ppc host with the following CPU topology: > > Architecture: ppc64le > Byte Order:Little Endian > CPU(s):32 > On-line CPU(s) list: 0,8,16,24 > Off-line CPU(s) list:

Re: [Qemu-devel] [PATCH 10/10] target/mips: Support Capstone in disas_set_info

2017-09-14 Thread Philippe Mathieu-Daudé
On 09/14/2017 03:35 PM, Richard Henderson wrote: Cc: Aurelien Jarno Cc: Yongbok Kim Signed-off-by: Richard Henderson --- target/mips/cpu.h| 2 ++ target/mips/cpu.c| 8 target/mips/translate_init.c | 36 3 files change

Re: [Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-14 Thread Peter Xu
On Thu, Sep 14, 2017 at 05:31:38PM -0300, Eduardo Habkost wrote: > On Thu, Sep 14, 2017 at 10:24:23PM +0200, Thomas Huth wrote: > > On 14.09.2017 22:18, Mohammed Gamal wrote: > > > Starting the following command line causes a segfault > > > qemu-system-x86_64 -S -machine isapc,accel=kvm -device amd

Re: [Qemu-devel] [RFC] Buffers/caches in VirtIO Balloon driver stats

2017-09-14 Thread Wei Wang
On 09/12/2017 10:29 PM, Tomáš Golembiovský wrote: On Tue, 29 Aug 2017 20:01:53 +0800 Wei Wang wrote: On 08/29/2017 05:57 PM, Stefan Hajnoczi wrote: On Sun, Aug 27, 2017 at 11:30:33PM +0200, Tomáš Golembiovský wrote: Hi, I have CCed the relevant mailing lists and people most recently involve

Re: [Qemu-devel] [PATCH] scsi-bus: correct responses for INQUIRY and REQUEST SENSE

2017-09-14 Thread Michael Roth
Quoting Paolo Bonzini (2017-08-22 08:20:23) > On 19/08/2017 00:55, Laszlo Ersek wrote: > > Reported-by: Laszlo Ersek > > Fixes: ded6ddc5a7b95217557fa360913d1213e12d4a6d > > And also: > > Cc: qemu-sta...@nongnu.org FYI patch freeze for v2.10.1 is Sep 25th. Hannes, were you planning to resend wit

Re: [Qemu-devel] [Qemu-stable] [PATCH v2 0/2] vhost-user-bridge reconnect regression

2017-09-14 Thread Michael Roth
Quoting Marc-André Lureau (2017-08-29 10:57:01) > Hi > > On Tue, Aug 29, 2017 at 5:34 PM, Michael S. Tsirkin wrote: > > On Tue, Aug 29, 2017 at 05:27:49PM +0200, Marc-André Lureau wrote: > >> Hi, > >> > >> libvhost-user doesn't support resuming with the same trick vubr had > >> since commit 523b0

Re: [Qemu-devel] [Qemu-block] [PATCH] rbd: Detect rbd image resizes and propagate them

2017-09-14 Thread Adam Wolfe Gordon via Qemu-devel
On Wed, Sep 13, 2017 at 6:47 PM, John Snow wrote: > On 09/13/2017 05:36 PM, Adam Wolfe Gordon via Qemu-devel wrote: >> On Wed, Sep 13, 2017 at 2:53 PM, John Snow wrote: >> We have a storage orchestration service that manages our ceph block >> storage clusters and doesn't interact directly with qe

Re: [Qemu-devel] [PATCH v2 5/5] arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly

2017-09-14 Thread Alistair Francis
On Thu, Sep 14, 2017 at 12:50 AM, Igor Mammedov wrote: > On Thu, 14 Sep 2017 00:47:20 -0300 > Philippe Mathieu-Daudé wrote: > >> Hi Igor, >> >> awesome clean refactor! > Thanks, > > there is more patches on this topic for other targets to post > but it's waiting on 1-3/5 to land in master so it w

[Qemu-devel] [Bug 1716767] Re: file(1) fails with "Invalid argument" on qemu-sh4-user

2017-09-14 Thread Thomas Huth
Please post patches to the qemu-devel mailing list for discussion instead of attaching them to the bugtracker. Thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1716767 Title: file(1) fails wit

Re: [Qemu-devel] [PATCH v2 3/6] aarch64-softmmu.mak: Use an ARM specific config

2017-09-14 Thread Alistair Francis
On Thu, Sep 14, 2017 at 5:50 AM, Peter Maydell wrote: > On 1 September 2017 at 22:00, Alistair Francis > wrote: >> In preperation for having an ARM and MicroBlaze ZynqMP machine let's >> split out the current ARM specific config options. >> >> Signed-off-by: Alistair Francis > > Acked-by: Peter

Re: [Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-14 Thread Eduardo Habkost
On Thu, Sep 14, 2017 at 10:24:23PM +0200, Thomas Huth wrote: > On 14.09.2017 22:18, Mohammed Gamal wrote: > > Starting the following command line causes a segfault > > qemu-system-x86_64 -S -machine isapc,accel=kvm -device amd-iommu > > > > This is due to the fact that the machine type 'isapc' doe

Re: [Qemu-devel] [PATCH] intel_iommu: Return error on machines with no PCI

2017-09-14 Thread Thomas Huth
On 14.09.2017 22:17, Mohammed Gamal wrote: > Starting the following command line causes a segfault > qemu-system-x86_64 -S -machine isapc,accel=kvm -device intel-iommu > > This is due to the fact that the machine type 'isapc' doesn't have > a PCI bus, while intel_iommu doesn't check if the machine

Re: [Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-14 Thread Thomas Huth
On 14.09.2017 22:18, Mohammed Gamal wrote: > Starting the following command line causes a segfault > qemu-system-x86_64 -S -machine isapc,accel=kvm -device amd-iommu > > This is due to the fact that the machine type 'isapc' doesn't have > a PCI bus, while amd_iommu doesn't check if the machine has

Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create

2017-09-14 Thread Amador Pahim
On Thu, Sep 14, 2017 at 10:18 PM, Eduardo Habkost wrote: > On Thu, Sep 14, 2017 at 10:05:50PM +0200, Amador Pahim wrote: >> On Thu, Sep 14, 2017 at 9:46 PM, Eduardo Habkost wrote: >> > On Thu, Sep 14, 2017 at 09:38:13PM +0200, Amador Pahim wrote: >> >> On Tue, Sep 5, 2017 at 5:18 AM, Fam Zheng w

[Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-14 Thread Mohammed Gamal
Starting the following command line causes a segfault qemu-system-x86_64 -S -machine isapc,accel=kvm -device amd-iommu This is due to the fact that the machine type 'isapc' doesn't have a PCI bus, while amd_iommu doesn't check if the machine has PCI support and subsequently does a null-pointer acc

Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create

2017-09-14 Thread Eduardo Habkost
On Thu, Sep 14, 2017 at 10:05:50PM +0200, Amador Pahim wrote: > On Thu, Sep 14, 2017 at 9:46 PM, Eduardo Habkost wrote: > > On Thu, Sep 14, 2017 at 09:38:13PM +0200, Amador Pahim wrote: > >> On Tue, Sep 5, 2017 at 5:18 AM, Fam Zheng wrote: > >> > On Fri, 09/01 13:28, Amador Pahim wrote: [...] > >

[Qemu-devel] [PATCH] amd_iommu: Return error on machines with no PCI

2017-09-14 Thread Mohammed Gamal
Starting the following command line causes a segfault qemu-system-x86_64 -S -machine isapc,accel=kvm -device amd-iommu This is due to the fact that the machine type 'isapc' doesn't have a PCI bus, while amd_iommu doesn't check if the machine has PCI support and subsequently does a null-pointer acc

[Qemu-devel] [PATCH] intel_iommu: Return error on machines with no PCI

2017-09-14 Thread Mohammed Gamal
Starting the following command line causes a segfault qemu-system-x86_64 -S -machine isapc,accel=kvm -device intel-iommu This is due to the fact that the machine type 'isapc' doesn't have a PCI bus, while intel_iommu doesn't check if the machine has PCI support and subsequently does a null-pointer

Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create

2017-09-14 Thread Amador Pahim
On Thu, Sep 14, 2017 at 9:46 PM, Eduardo Habkost wrote: > On Thu, Sep 14, 2017 at 09:38:13PM +0200, Amador Pahim wrote: >> On Tue, Sep 5, 2017 at 5:18 AM, Fam Zheng wrote: >> > On Fri, 09/01 13:28, Amador Pahim wrote: >> >> To launch a VM, we need to create basically two files: the monitor >> >>

Re: [Qemu-devel] [PATCH RESEND v7 0/3] Red Hat PCI bridge resource reserve capability

2017-09-14 Thread Kevin O'Connor
On Thu, Sep 14, 2017 at 11:15:43AM +0300, Aleksandr Bezzubikov wrote: > 2017-09-10 22:40 GMT+03:00 Marcel Apfelbaum : > > On 10/09/2017 21:34, Aleksandr Bezzubikov wrote: > >> And what about this series? The matching QEMU series has been applied, > >> that's why there should be no problems with pic

Re: [Qemu-devel] [PATCH v2 3/7] mips: split cpu_mips_realize_env() out of cpu_mips_init()

2017-09-14 Thread Eduardo Habkost
On Wed, Aug 30, 2017 at 07:52:21PM -0300, Philippe Mathieu-Daudé wrote: > so it can be used in mips_cpu_realizefn() in the next commit > > Signed-off-by: Philippe Mathieu-Daudé > Tested-by: Igor Mammedov > Tested-by: James Hogan Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create

2017-09-14 Thread Eduardo Habkost
On Thu, Sep 14, 2017 at 09:38:13PM +0200, Amador Pahim wrote: > On Tue, Sep 5, 2017 at 5:18 AM, Fam Zheng wrote: > > On Fri, 09/01 13:28, Amador Pahim wrote: > >> To launch a VM, we need to create basically two files: the monitor > >> socket (if it's a UNIX socket) and the qemu log file. > >> > >>

Re: [Qemu-devel] [PATCH v8 06/13] qemu.py: make sure we only remove files we create

2017-09-14 Thread Amador Pahim
On Tue, Sep 5, 2017 at 5:18 AM, Fam Zheng wrote: > On Fri, 09/01 13:28, Amador Pahim wrote: >> To launch a VM, we need to create basically two files: the monitor >> socket (if it's a UNIX socket) and the qemu log file. >> >> For the qemu log file, we currently just open the path, which will >> cre

Re: [Qemu-devel] [PATCH v2 0/3] hostmem-file: Add "discard-data" option

2017-09-14 Thread Eduardo Habkost
Series queued on machine-next. On Thu, Aug 24, 2017 at 04:23:12PM -0300, Eduardo Habkost wrote: > This series adds a new "discard-data" option to > memory-backend-file. The new option will be useful if somebody > is sharing RAM contents on a pre-existing file using share=on, > but don't need data

Re: [Qemu-devel] [PATCH v8 00/13] scripts/qemu.py fixes and cleanups

2017-09-14 Thread Eduardo Habkost
Patches 01-05 were queued on my python-next branch: https://github.com/ehabkost/qemu/commits/python-next Please use python-next as base for v9, as I plan to submit a pull request with the contents of python-next soon. On Fri, Sep 01, 2017 at 01:28:16PM +0200, Amador Pahim wrote: > Changes v1->v2

[Qemu-devel] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension()

2017-09-14 Thread Greg Kurz
The following capabilities are VM specific: - KVM_CAP_PPC_SMT_POSSIBLE - KVM_CAP_PPC_HTAB_FD - KVM_CAP_PPC_ALLOC_HTAB If both KVM HV and KVM PR are present, checking them always return the HV value, even if we explicitely requested to use PR. This has no visible effect for KVM_CAP_PPC_ALLOC_HTAB,

[Qemu-devel] [PATCH 1/3] kvm: check KVM_CAP_SYNC_MMU with kvm_vm_check_extension()

2017-09-14 Thread Greg Kurz
On a server-class ppc host, this capability depends on the KVM type, ie, HV or PR. If both KVM are present in the kernel, we will always get the HV specific value, even if we explicitely requested PR on the command line. This can have an impact if we're using hugepages or a balloon device. Since

[Qemu-devel] [PATCH 0/3] kvm: use kvm_vm_check_extension() with VM capabilities

2017-09-14 Thread Greg Kurz
Some VM capabilities are currently checked with kvm_check_extension(). This doesn't have any impact for most host architectures because they don't depend on the KVM type. However, this is a problem for server-class ppc hosts that can support the PR and HV KVM types. Both implementations can co-exis

[Qemu-devel] [PATCH 2/3] kvm: check KVM_CAP_NR_VCPUS with kvm_vm_check_extension()

2017-09-14 Thread Greg Kurz
On a modern server-class ppc host with the following CPU topology: Architecture: ppc64le Byte Order:Little Endian CPU(s):32 On-line CPU(s) list: 0,8,16,24 Off-line CPU(s) list: 1-7,9-15,17-23,25-31 Thread(s) per core:1 If both KVM PR and KVM HV loaded a

Re: [Qemu-devel] [PATCH v2] osdep: Fix ROUND_UP(64-bit, 32-bit)

2017-09-14 Thread Richard Henderson
On 09/14/2017 06:49 AM, Eric Blake wrote: > When using bit-wise operations that exploit the power-of-two > nature of the second argument of ROUND_UP(), we still need to > ensure that the mask is as wide as the first argument (done > by using a ternary to force proper arithmetic promotion). > Unpatc

Re: [Qemu-devel] [Bug 1716767] Re: file(1) fails with "Invalid argument" on qemu-sh4-user

2017-09-14 Thread John Paul Adrian Glaubitz
On 09/13/2017 08:37 PM, James Clarke wrote: > With the attached patch, qemu-sh4-static now works for file: I can also confirm that the patch fixes the problem for me. Would be great if it could get merged in one form or another. -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - gl

[Qemu-devel] [Bug 932490] Re: Qemu fails on -fda /dev/fd0 when no medium is present

2017-09-14 Thread Thomas Huth
** Changed in: qemu Status: Incomplete => Won't Fix -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/932490 Title: Qemu fails on -fda /dev/fd0 when no medium is present Status in QEMU: Won't

[Qemu-devel] [PATCH 3/4] tcg/sparc: Fully convert tcg_target_op_def

2017-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/sparc/tcg-target.inc.c | 239 ++--- 1 file changed, 137 insertions(+), 102 deletions(-) diff --git a/tcg/sparc/tcg-target.inc.c b/tcg/sparc/tcg-target.inc.c index 1da4debbaf..bc673bd8c6 100644 --- a/tcg/sparc/tcg-ta

[Qemu-devel] 087 failing without aio

2017-09-14 Thread Dr. David Alan Gilbert
Hi Kevin, 087 fails if you've not built with aio, do we have any easy tests that let us skip it? (I was building on a cleanly installed borrowed farm box for a different architecture and hadn't installed the full set). === aio=native without O_DIRECT === Testing: QMP_VERSION {"return": {}} {"e

[Qemu-devel] [PATCH 4/4] tcg/mips: Fully convert tcg_target_op_def

2017-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/mips/tcg-target.inc.c | 324 -- 1 file changed, 170 insertions(+), 154 deletions(-) diff --git a/tcg/mips/tcg-target.inc.c b/tcg/mips/tcg-target.inc.c index 1c09ec7d5b..ce4030602f 100644 --- a/tcg/mips/tcg-targe

[Qemu-devel] [PATCH 0/4] tcg: Fully convert tcg_target_op_def

2017-09-14 Thread Richard Henderson
The tcg/aarch64 version has already been posted as a part of my vector operations patch set. This is simply source code quality improvement, therefore I skip tcg/tci. But this takes care of all of the rest. r~ Richard Henderson (4): tcg/arm: Fully convert tcg_target_op_def tcg/ppc: Fully

[Qemu-devel] [PATCH 1/4] tcg/arm: Fully convert tcg_target_op_def

2017-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 186 +++ 1 file changed, 107 insertions(+), 79 deletions(-) diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c index 14599a8685..98a12535a5 100644 --- a/tcg/arm/tcg-target.in

[Qemu-devel] [PATCH 2/4] tcg/ppc: Fully convert tcg_target_op_def

2017-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.inc.c | 321 +-- 1 file changed, 168 insertions(+), 153 deletions(-) diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c index 8ffc7a7205..879885b68b 100644 --- a/tcg/ppc/tcg-target.i

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-14 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > This series was born from this one: > > https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04310.html Are patches 1..6 separable and mergable without the rest ? Dave > The design comes from Markus, and also the whole-bunch-of discussions > in prev

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-14 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Thu, Sep 14, 2017 at 9:50 AM, Peter Xu wrote: > > This series was born from this one: > > > > https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04310.html > > > > The design comes from Markus, and also the whole-bunch-of

[Qemu-devel] [PATCH 06/10] target/arm: Support Capstone in disas_set_info

2017-09-14 Thread Richard Henderson
Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson --- target/arm/cpu.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index a1acce3c7a..92159ca0b1 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -33,6 +

[Qemu-devel] [PATCH 05/10] target/i386: Support Capstone in disas_set_info

2017-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/i386/cpu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target/i386/cpu.c b/target/i386/cpu.c index b869a69c53..c3980b3864 100644 --- a/target/i386/cpu.c +++ b/target/i386/cpu.c @@ -51,6 +51,8 @@ #include "hw/i386/apic_internal.h" #endif

[Qemu-devel] [PATCH 03/10] disas: Remove unused flags arguments

2017-09-14 Thread Richard Henderson
Now that every target is using the disas_set_info hook, the flags argument is unused. Remove it. Signed-off-by: Richard Henderson --- include/disas/disas.h | 4 ++-- include/exec/log.h| 4 ++-- disas.c | 15 --- monitor.c

  1   2   3   4   >