Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc/spapr.c: cleaning up qdev_get_machine() calls

2017-09-08 Thread David Gibson
On Thu, Sep 07, 2017 at 05:21:23PM +0200, Greg Kurz wrote: > On Wed, 6 Sep 2017 15:43:05 -0300 > Daniel Henrique Barboza wrote: > > > This patch removes the qdev_get_machine() calls that are made in > > spapr.c in situations where we can get an existing pointer for > > the MachineState by either

Re: [Qemu-devel] [PATCHv2 1/1] net: Add SunGEM device emulation as found on Apple UniNorth

2017-09-08 Thread David Gibson
On Wed, Sep 06, 2017 at 07:19:55PM +0100, Mark Cave-Ayland wrote: > From: Benjamin Herrenschmidt > > This adds a simplistic emulation of the Sun GEM ethernet controller > found in Apple ASICs. > > Currently we only support the Apple UniNorth 1.x variant, but the > other Apple or Sun variants sho

[Qemu-devel] [PATCH v4] pci: Set err to errp directly rather than through error_propagate()

2017-09-08 Thread Mao Zhongyi
ioh3420_interrupts_init() pass error message to local_err, then propagate it to errp by error_propagate(), which is not necessary. So eliminate it and pass errp directly instead of local_err. Cc: "Michael S. Tsirkin" Cc: Marcel Apfelbaum Signed-off-by: Mao Zhongyi Reviewed-by: Eric Blake Revi

Re: [Qemu-devel] [PULL v2 00/37] Staging patches

2017-09-08 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL v2 00/37] Staging patches Message-id: 20170909054613.19148-1-f...@redhat.com Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $B

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/3] spapr: XIVE and CAS fixes

2017-09-08 Thread Cédric Le Goater
On 09/08/2017 04:33 PM, Cédric Le Goater wrote: > Hello, > > Here are a couple of fixes, one for the XIVE exploitation mode option > bit which is clearly specified now and for one for the CAS generated > resets. > > Last is a proposal to handle the rebuild of the device tree using a > reset when

[Qemu-devel] [PULL v2 35/37] buildsys: Move usb redir cflags/libs to per object

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-10-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- configure| 4 ++-- hw/usb/Makefile.objs | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/c

[Qemu-devel] [PULL v2 36/37] buildsys: Move brlapi libs to per object

2017-09-08 Thread Fam Zheng
baum.o already receives the sdl cflags in its per object variable, do the same for brlapi libs to avoid cluttering libs_softmmu. Signed-off-by: Fam Zheng Message-Id: <20170907084700.952-1-f...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau Signed-off-by: Fam Zhen

[Qemu-devel] [PULL v2 33/37] buildsys: Move libcacard cflags/libs to per object

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-8-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- configure| 4 ++-- hw/usb/Makefile.objs | 6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

[Qemu-devel] [PULL v2 32/37] buildsys: Move curese cflags/libs to per object

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-6-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- configure| 6 -- ui/Makefile.objs | 3 +++ 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/configu

[Qemu-devel] [PULL v2 37/37] buildsys: Move rdma libs to per object

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907084230.26493-1-f...@redhat.com> Reviewed-by: Juan Quintela Reviewed-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Fam Zheng --- configure | 2 +- migration/Makefile.objs | 1 + 2 files changed, 2 insertions(+), 1 de

[Qemu-devel] [PULL v2 31/37] buildsys: Move audio libs to per object

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-5-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- audio/Makefile.objs | 5 + configure | 15 ++- 2 files changed, 15 insertions(+), 5 deletions(-)

[Qemu-devel] [PULL v2 27/37] buildsys: Move vde libs to per object

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907083552.17725-3-f...@redhat.com> Reviewed-by: Jason Wang Signed-off-by: Fam Zheng --- configure | 3 +-- net/Makefile.objs | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 3918c47cd8..25c6ad6b

[Qemu-devel] [PULL v2 34/37] buildsys: Move libusb cflags/libs to per object

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-9-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- configure| 4 ++-- hw/usb/Makefile.objs | 5 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PULL v2 29/37] buildsys: Move sdl cflags/libs to per object

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-3-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- audio/Makefile.objs | 1 + configure | 2 +- ui/Makefile.objs| 1 + 3 files changed, 3 insertions(+), 1 deletio

[Qemu-devel] [PULL v2 28/37] buildsys: Move gtk/vte cflags/libs to per object

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-2-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- configure| 3 +-- ui/Makefile.objs | 4 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/configure

[Qemu-devel] [PULL v2 26/37] vl: Don't include vde header

2017-09-08 Thread Fam Zheng
Nothing in vl.c uses anything from the vde package, do remove the unnecessary include. Signed-off-by: Fam Zheng Message-Id: <20170907083552.17725-2-f...@redhat.com> Reviewed-by: Jason Wang Signed-off-by: Fam Zheng --- vl.c | 4 1 file changed, 4 deletions(-) diff --git a/vl.c b/vl.c inde

[Qemu-devel] [PULL v2 21/37] docker: Add test_fail and prep_fail

2017-09-08 Thread Fam Zheng
They both print a message and exit, but with different status code so distinguish real test errors from env preparation failures. Signed-off-by: Fam Zheng Message-Id: <20170905025614.579-3-f...@redhat.com> Reviewed-by: Stefan Hajnoczi Based-on: 20170905021201.25684-1-f...@redhat.com --- tests/d

[Qemu-devel] [PULL v2 22/37] docker: Use unconfined security profile

2017-09-08 Thread Fam Zheng
Some by default blocked syscalls are required to run tests for example userfaultfd. Reviewed-by: Kashyap Chamarthy Signed-off-by: Fam Zheng Message-Id: <20170905025614.579-4-f...@redhat.com> Reviewed-by: Stefan Hajnoczi Based-on: 20170905021201.25684-1-f...@redhat.com --- tests/docker/Makefile

[Qemu-devel] [PULL v2 30/37] buildsys: Move vnc cflags/libs to per object

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-4-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- configure| 14 -- ui/Makefile.objs | 21 - 2 files changed, 20 insertions(+), 15 dele

[Qemu-devel] [PULL v2 24/37] docker: Add test-block

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170905025614.579-6-f...@redhat.com> Reviewed-by: Stefan Hajnoczi Based-on: 20170905021201.25684-1-f...@redhat.com --- tests/docker/test-block | 21 + 1 file changed, 21 insertions(+) create mode 100755 tests/docker/test-block diff --g

[Qemu-devel] [PULL v2 25/37] docker: Drop 'set -e' from run script

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170905025614.579-7-f...@redhat.com> Reviewed-by: Stefan Hajnoczi Based-on: 20170905021201.25684-1-f...@redhat.com --- tests/docker/run | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/docker/run b/tests/docker/run index 52b

[Qemu-devel] [PULL v2 20/37] docker: Fix return code of build_qemu()

2017-09-08 Thread Fam Zheng
Without "set -e", the "&&" makes sure that the return code reflects the result status, and that make only runs if configure succeeds. Signed-off-by: Fam Zheng Message-Id: <20170905025614.579-2-f...@redhat.com> Reviewed-by: Stefan Hajnoczi Based-on: 20170905021201.25684-1-f...@redhat.com --- tes

[Qemu-devel] [PULL v2 19/37] docker: Use archive-source.py

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170905021201.25684-13-f...@redhat.com> --- tests/docker/Makefile.include | 15 ++- tests/docker/run | 8 +--- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile

[Qemu-devel] [PULL v2 16/37] Makefile: Add rules to run vm tests

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170905021201.25684-10-f...@redhat.com> --- Makefile | 2 ++ configure | 2 +- tests/vm/Makefile.include | 42 ++ 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644

[Qemu-devel] [PULL v2 23/37] docker: Add nettle-devel to fedora image

2017-09-08 Thread Fam Zheng
The LUKS cases in qemu-iotests requires this. Reviewed-by: Kashyap Chamarthy Signed-off-by: Fam Zheng Message-Id: <20170905025614.579-5-f...@redhat.com> Reviewed-by: Stefan Hajnoczi Based-on: 20170905021201.25684-1-f...@redhat.com --- tests/docker/dockerfiles/fedora.docker | 1 + 1 file change

[Qemu-devel] [PULL v2 17/37] MAINTAINERS: Add tests/vm entry

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Message-Id: <20170905021201.25684-11-f...@redhat.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 36eeb42d19..42f5454311 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1891,6 +1891,7 @@

[Qemu-devel] [PULL v2 18/37] tests: Add README for vm tests

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170905021201.25684-12-f...@redhat.com> --- tests/vm/README | 63 + 1 file changed, 63 insertions(+) create mode 100644 tests/vm/README diff --git a/tests/vm/README b/tests/vm/README new file mode 100

[Qemu-devel] [PULL v2 15/37] tests: Add OpenBSD image

2017-09-08 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Message-Id: <20170905021201.25684-9-f...@redhat.com> --- tests/vm/openbsd | 43 +++ 1 file changed, 43 insertions(+) create mode 100755 tests/vm/

[Qemu-devel] [PULL v2 14/37] tests: Add NetBSD image

2017-09-08 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski Message-Id: <20170905021201.25684-8-f...@redhat.com> --- tests/vm/netbsd | 42 ++ 1 file changed, 42 insertions(+)

[Qemu-devel] [PULL v2 12/37] tests: Add ubuntu.i386 image

2017-09-08 Thread Fam Zheng
This adds a 32bit guest. The official LTS cloud image is downloaded and initialized with cloud-init. Signed-off-by: Fam Zheng Message-Id: <20170905021201.25684-6-f...@redhat.com> --- tests/vm/ubuntu.i386 | 88 1 file changed, 88 insertions(+)

[Qemu-devel] [PULL v2 13/37] tests: Add FreeBSD image

2017-09-08 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Message-Id: <20170905021201.25684-7-f...@redhat.com> --- tests/vm/freebsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/f

[Qemu-devel] [PULL v2 05/37] docker: Update ubuntu image

2017-09-08 Thread Fam Zheng
Base on the newer ubuntu-lts (16.06) and include more packages for better build coverage. Signed-off-by: Fam Zheng Message-Id: <20170907141245.31946-2-f...@redhat.com> Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/ubuntu.docker | 11 --- 1 file changed, 8 insertions(+), 3 deleti

[Qemu-devel] [PULL v2 11/37] tests: Add vm test lib

2017-09-08 Thread Fam Zheng
This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file to the guest. 4) SSH into the VM, untar the s

[Qemu-devel] [PULL v2 10/37] scripts: Add archive-source.sh

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170905021201.25684-4-f...@redhat.com> --- scripts/archive-source.sh | 31 +++ 1 file changed, 31 insertions(+) create mode 100755 scripts/archive-source.sh diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh new

[Qemu-devel] [PULL v2 07/37] tests/docker: Clean up paths

2017-09-08 Thread Fam Zheng
The 'run' script already creats src, build and install directories under $TEST_DIR, use it in common.rc. Also the tests always run from $QEMU_SRC/tests/docker, so use a relative $CMD string. Message-Id: <20170817035721.11064-1-f...@redhat.com> Signed-off-by: Fam Zheng --- tests/docker/common.rc

[Qemu-devel] [PULL v2 06/37] docker: Enable features explicitly in test-full

2017-09-08 Thread Fam Zheng
Also avoid "set -e". Signed-off-by: Fam Zheng Message-Id: <20170907141245.31946-3-f...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Fam Zheng --- tests/docker/test-full | 82 ++ 1 file changed, 76 insertions(+), 6 deletions(-) diff --git a

[Qemu-devel] [PULL v2 09/37] qemu.py: Add "wait()" method

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Message-Id: <20170905021201.25684-3-f...@redhat.com> --- scripts/qemu.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 4d8ee10943..99963053a5 100644 --- a/scripts/qemu.py +++ b/scripts/qemu

[Qemu-devel] [PULL v2 08/37] gitignore: Ignore vm test images

2017-09-08 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170905021201.25684-2-f...@redhat.com> --- .gitignore | 1 + tests/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index cf65316863..40acfcb9e2 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,7 @@ /vsccli

[Qemu-devel] [PULL v2 04/37] docker: reduce noise when building travis.docker

2017-09-08 Thread Fam Zheng
From: Alex Bennée Set the DEBIAN_FRONTEND and locale env vars to stop apt complaining so much as we build the image. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20170725133425.436-7-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philipp

[Qemu-devel] [PULL v2 01/37] docker: ensure NOUSER for travis images

2017-09-08 Thread Fam Zheng
From: Alex Bennée While adding the current user is a useful default behaviour for creating new images it is not appropriate for Travis which already has a default user. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20170725133425

[Qemu-devel] [PULL v2 00/37] Staging patches

2017-09-08 Thread Fam Zheng
The following changes since commit fcea73709b966a7ded9efa7b106ea50c7fe9025c: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2017-09-08 16:04:42 +0100) are available in the git repository at: git://github.com/famz/qemu.git tags/staging-pull-request for you to fet

[Qemu-devel] [PULL v2 03/37] docker: don't install device-tree-compiler build-deps in travis.docker

2017-09-08 Thread Fam Zheng
From: Alex Bennée Installing the device-tree-compiler build-deps is a little extreme. We only actually need the binary so include it with the other packages. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20170725133425.436-6-alex.ben...@linaro.org> Reviewed-by: P

[Qemu-devel] [PULL v2 02/37] docker: docker.py make --no-cache skip checksum test

2017-09-08 Thread Fam Zheng
From: Alex Bennée If you invoke with NOCACHE=1 we pass --no-cache in the argv to docker.py but may still not force a rebuild if the dockerfile checksum hasn't changed. By testing for its presence we can force builds without having to manually remove the docker image. Signed-off-by: Alex Bennée

Re: [Qemu-devel] [PATCH v6 04/12] tests: Add vm test lib

2017-09-08 Thread Fam Zheng
On Fri, 09/08 22:25, Philippe Mathieu-Daudé wrote: > Hi Fam, Alex, > > > > > > > If this fails it's fairly cryptic: > > > > > > /home/alex/lsrc/qemu/qemu.git/tests/vm/openbsd --debug --image > > > "tests/vm/openbsd.img" --build-qemu /home/alex/lsrc/qemu/qemu.git > > > DEBUG:root:Creating arc

Re: [Qemu-devel] [PATCH v6 04/12] tests: Add vm test lib

2017-09-08 Thread Philippe Mathieu-Daudé
Hi Fam, Alex, If this fails it's fairly cryptic: /home/alex/lsrc/qemu/qemu.git/tests/vm/openbsd --debug --image "tests/vm/openbsd.img" --build-qemu /home/alex/lsrc/qemu/qemu.git DEBUG:root:Creating archive ./vm-test-fxejnB.tmp/data-2de24.tar for src_dir dir: /home/alex/lsrc/qemu/qemu.git

Re: [Qemu-devel] [PATCH] .dir-locals.el: Explicitly set indentation level

2017-09-08 Thread Thiago Jung Bauermann
Markus Armbruster writes: > Thiago Jung Bauermann writes: > >> At least in some configurations, setting c-file-style is not enough to >> conform to the QEMU coding style, so explicitly set c-basic-offset as well. >> >> Signed-off-by: Thiago Jung Bauermann >> --- >> >> My emacs was using indent

Re: [Qemu-devel] [PULL 00/38] Test and build system patches

2017-09-08 Thread Fam Zheng
On Fri, 09/08 14:44, Peter Maydell wrote: > On 8 September 2017 at 10:54, Fam Zheng wrote: > > Hi Peter, > > > > The following changes since commit cda4a338c4243fa3bff4498b935340ac7121cc76: > > > > tcg/tci: Add TCG_TARGET_DEFAULT_MO (2017-09-07 18:57:34 +0100) > > > > are available in the git re

Re: [Qemu-devel] [PATCH v6 04/12] tests: Add vm test lib

2017-09-08 Thread Fam Zheng
On Fri, 09/08 16:22, Alex Bennée wrote: > > Fam Zheng writes: > > > This is the common code to implement a "VM test" to > > > > 1) Download and initialize a pre-defined VM that has necessary > > dependencies to build QEMU and SSH access. > > > > 2) Archive $SRC_PATH to a .tar file. > > > >

Re: [Qemu-devel] [PATCH v6 03/12] scripts: Add archive-source.sh

2017-09-08 Thread Fam Zheng
On Fri, 09/08 15:42, Alex Bennée wrote: > > Fam Zheng writes: > > > Signed-off-by: Fam Zheng > > --- > > scripts/archive-source.sh | 31 +++ > > 1 file changed, 31 insertions(+) > > create mode 100755 scripts/archive-source.sh > > > > diff --git a/scripts/archive-s

Re: [Qemu-devel] [PATCH v6 03/12] scripts: Add archive-source.sh

2017-09-08 Thread Fam Zheng
On Fri, 09/08 15:56, Peter Maydell wrote: > On 5 September 2017 at 03:11, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > scripts/archive-source.sh | 31 +++ > > 1 file changed, 31 insertions(+) > > create mode 100755 scripts/archive-source.sh > > > > diff

Re: [Qemu-devel] [PATCH v6 01/12] gitignore: Ignore vm test images

2017-09-08 Thread Fam Zheng
On Fri, 09/08 15:12, Alex Bennée wrote: > > Fam Zheng writes: > > > Signed-off-by: Fam Zheng > > --- > > .gitignore | 1 + > > tests/.gitignore | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/.gitignore b/.gitignore > > index cf65316863..40acfcb9e2 100644 > > --- a/.giti

Re: [Qemu-devel] [PATCH v2 00/13] add support for Hypervisor.framework in QEMU

2017-09-08 Thread Sergio Andrés Gómez del Real
Guys, I'm almost done with the new version of the patchset (hopefully the definite one). What I am missing essentially are presenting a few tests as suggested by Stefan. Paolo and I only ran the eventinj test from the kvm suite. If I modify this boot-serial-test to include hvf, should I send these

[Qemu-devel] irqfd for QEMU NVMe

2017-09-08 Thread Huaicheng Li
Hi all, I'm writing to ask if it's possible to use irqfd mechanism in QEMU's NVMe virtual controller implementation. My search results show that back in 2015, there is a discussion on improving QEMU NVMe performance by utilizing eventfd for guest-to-host notification, thus i guess irqfd should als

[Qemu-devel] [Bug 1516446] Re: Migration always causes guest freeze in one direction.

2017-09-08 Thread Dr. David Alan Gilbert
Hi Magnus, I think there's a fair possibility you're hitting a kernel bug that we found in https://bugzilla.redhat.com/show_bug.cgi?id=1401767 which was also a failure migrating from a newer AMD to an older AMD processor. That was fixed by upstream kernel fix: commit 00c87e9a70a17b355b81c36

Re: [Qemu-devel] [PATCH] slirp: Add explanation for hostfwd parsing failure

2017-09-08 Thread Philippe Mathieu-Daudé
On 09/08/2017 03:36 PM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (f4...@amsat.org) wrote: On 09/08/2017 01:22 PM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (f4...@amsat.org) wrote: Hi David, On 09/08/2017 12:53 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. Dav

Re: [Qemu-devel] [PATCH] slirp: Add explanation for hostfwd parsing failure

2017-09-08 Thread Dr. David Alan Gilbert
* Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > On 09/08/2017 01:22 PM, Dr. David Alan Gilbert wrote: > > * Philippe Mathieu-Daudé (f4...@amsat.org) wrote: > > > Hi David, > > > > > > On 09/08/2017 12:53 PM, Dr. David Alan Gilbert (git) wrote: > > > > From: "Dr. David Alan Gilbert" > > > > >

Re: [Qemu-devel] [PATCH v2] Add myself as maintainer for TPM code

2017-09-08 Thread Markus Armbruster
Stefan Berger writes: > Also add backends/tpm.c to the list of files. > > Signed-off-by: Stefan Berger > --- > MAINTAINERS | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index caf7e8a..c434a09 100644 > --- a/MAINTAINERS > +++ b/MAINTAINER

Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully support the RFC

2017-09-08 Thread Eric Blake
On 09/08/2017 01:11 PM, Brandon Carpenter wrote: > My apologies. I read that document before submitting the patch, but > there was a lot to take in. Would you like me to resend the patch > without the references? Not a problem - we all had to submit our first patch at some point in time in the pas

Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully support the RFC

2017-09-08 Thread Brandon Carpenter
My apologies. I read that document before submitting the patch, but there was a lot to take in. Would you like me to resend the patch without the references? -- Brandon Carpenter | Software Engineer Cypherpath, Inc. 400 Columbia Point Drive Ste 101 | Richland, Washington USA Office: (650) 713-30

Re: [Qemu-devel] [PATCH] slirp: Add explanation for hostfwd parsing failure

2017-09-08 Thread Philippe Mathieu-Daudé
On 09/08/2017 01:22 PM, Dr. David Alan Gilbert wrote: * Philippe Mathieu-Daudé (f4...@amsat.org) wrote: Hi David, On 09/08/2017 12:53 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" e.g. ./x86_64-softmmu/qemu-system-x86_64 -nographic -netdev 'user,id=vnet,hostfwd=:555

Re: [Qemu-devel] [PATCH] target/arm: Avoid an extra temporary for store_exclusive

2017-09-08 Thread Alistair Francis
On Fri, Sep 8, 2017 at 9:38 AM, Richard Henderson wrote: > Instead of copying addr to a local temp, reuse the value (which we > have just compared as equal) already saved in cpu_exclusive_addr. > > Signed-off-by: Richard Henderson Reviewed-by: Alistair Francis Thanks, Alistair > --- > target

[Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully support the RFC

2017-09-08 Thread Brandon Carpenter
We've been experiencing issues where the qemu websocket server closes connections from noVNC clients for no apparent reason. Debugging shows that certain web browsers are injecting ping and pong frames when the connection becomes idle. Some browsers send those frames without a payload, which also i

Re: [Qemu-devel] [PATCH v3 4/7] block: remove legacy I/O throttling

2017-09-08 Thread Manos Pitsidianakis
On Fri, Sep 08, 2017 at 06:00:11PM +0200, Kevin Wolf wrote: Am 08.09.2017 um 17:44 hat Manos Pitsidianakis geschrieben: On Thu, Sep 07, 2017 at 03:26:11PM +0200, Kevin Wolf wrote: > We shouldn't really need any throttling code in > blk_root_drained_begin/end any more now because the throttle nod

Re: [Qemu-devel] [PATCH v2 0/6] Update websocket code to more fully support the RFC

2017-09-08 Thread Eric Blake
On 09/08/2017 12:37 PM, Brandon Carpenter wrote: > We've been experiencing issues where the qemu websocket server closes > connections from noVNC clients for no apparent reason. Debugging shows > that certain web browsers are injecting ping and pong frames when the > connection becomes idle. Some b

[Qemu-devel] [PATCH v2 5/6] io: Ignore websocket PING and PONG frames

2017-09-08 Thread Brandon Carpenter
Keep pings and gratuitous pongs generated by web browsers from killing websocket connections. Signed-off-by: Brandon Carpenter --- io/channel-websock.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/io/channel-websock.c b/io/channel-websock.c index 318

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-09-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Aug 25, 2017 at 10:06:27AM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Wed, Aug 23, 2017 at 06:44:12PM +0100, Dr. David Alan Gilbert wrote: > > > > > > [...] > > > > > > > > +Most of the commands require t

[Qemu-devel] [PATCH v2 2/6] io: Small updates in preparation for websocket changes

2017-09-08 Thread Brandon Carpenter
Gets rid of unnecessary bit shifting and performs proper EOF checking to avoid a large number of repeated calls to recvmsg() when a client abruptly terminates a connection (bug fix). Signed-off-by: Brandon Carpenter --- io/channel-websock.c | 62 +++---

[Qemu-devel] [PATCH v2 6/6] io: Reply to ping frames

2017-09-08 Thread Brandon Carpenter
Add an immediate ping reply (pong) to the outgoing stream when a ping is received. Unsolicited pongs are ignored. Signed-off-by: Brandon Carpenter --- io/channel-websock.c | 50 -- 1 file changed, 32 insertions(+), 18 deletions(-) diff --git a/io/

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-09-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Aug 25, 2017 at 10:14:12AM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Thu, Aug 24, 2017 at 07:37:32AM +0800, Fam Zheng wrote: > > > > On Wed, 08/23 18:44, Dr. David Alan Gilbert wrote: > > > > > * Peter Xu

[Qemu-devel] [PATCH v2 3/6] io: Add support for fragmented websocket binary frames

2017-09-08 Thread Brandon Carpenter
Allows fragmented binary frames by saving the previous opcode. Handles the case where an intermediary (i.e., web proxy) fragments frames originally sent unfragmented by the client. Signed-off-by: Brandon Carpenter --- include/io/channel-websock.h | 1 + io/channel-websock.c | 26 +++

[Qemu-devel] [PATCH v3 15/15] MAINTAINERS: update docs/interop/ entries

2017-09-08 Thread Philippe Mathieu-Daudé
moved in commit 7746cf8aab68 Signed-off-by: Philippe Mathieu-Daudé Acked-by: Fam Zheng Acked-by: John Snow --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index f8630561de..99f3681842 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @

[Qemu-devel] [PATCH v2 4/6] io: Allow empty websocket payload

2017-09-08 Thread Brandon Carpenter
Some browsers send pings/pongs with no payload, so allow empty payloads instead of closing the connection. Signed-off-by: Brandon Carpenter --- io/channel-websock.c | 62 +--- 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/io/chann

[Qemu-devel] [PATCH v3 13/15] MAINTAINERS: add missing Cryptography entry

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Daniel P. Berrange --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 8024a3880b..53891bd36e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1540,6 +1540,7 @@ S: Maintained F: crypto/ F: include/cry

[Qemu-devel] [PATCH v2 1/6] io: Always remove an old channel watch before adding a new one

2017-09-08 Thread Brandon Carpenter
Also set saved handle to zero when removing without adding a new watch. Signed-off-by: Brandon Carpenter Reviewed-by: Paolo Bonzini Reviewed-by: Daniel P. Berrange --- ui/vnc-auth-vencrypt.c | 3 +++ ui/vnc-ws.c| 6 ++ ui/vnc.c | 4 3 files changed, 13 insert

[Qemu-devel] [PATCH v3 14/15] MAINTAINERS: update docs/devel/ entries

2017-09-08 Thread Philippe Mathieu-Daudé
moved in commit ac06724a7158 Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 53891bd36e..f8630561de 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1419,7

[Qemu-devel] [PATCH v3 09/15] MAINTAINERS: add missing SSI entries

2017-09-08 Thread Philippe Mathieu-Daudé
Alistair Francis volunteered :) Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 69ad3aac29..517c8f95d7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -986,10 +986,13 @@ F: h

[Qemu-devel] [PATCH v3 11/15] MAINTAINERS: add missing AIO entry

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4e05831bda..98b7edc8b3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1224,6 +1224,7 @@ F: util/aio-*.c F:

[Qemu-devel] [PATCH v3 12/15] MAINTAINERS: add missing entry for Generic Loader

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alistair Francis --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 98b7edc8b3..8024a3880b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1163,6 +1163,7 @@ M: Alistair Francis S: Maintained F:

[Qemu-devel] [PATCH v3 07/15] MAINTAINERS: add missing USB entry

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 39ac5d132a..04cc35cc3a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1004,6 +1004,7 @@ F: docs/usb2.txt F: docs/usb-storage.txt F:

[Qemu-devel] [PATCH v3 10/15] MAINTAINERS: add missing entries for throttling infra

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 517c8f95d7..4e05831bda 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1574,8 +157

[Qemu-devel] [PATCH v3 06/15] MAINTAINERS: add missing qcow2 entry

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Kevin Wolf Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fa1620d8a8..39ac5d132a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1851,6 +1851,7 @@ M: Max Reitz L: q

[Qemu-devel] [PATCH v3 04/15] MAINTAINERS: add missing VMWare entry

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Dmitry Fleytman --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index afc0072a17..e0e5a8dc3f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1126,6 +1126,7 @@ M: Dmitry Fleyt

[Qemu-devel] [PATCH v3 08/15] MAINTAINERS: add missing PCI entries

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Marcel Apfelbaum Acked-by: Michael S. Tsirkin --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 04cc35cc3a..69ad3aac29 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -928,6 +928,8 @@ F: include

[Qemu-devel] [PATCH v3 05/15] MAINTAINERS: add missing Guest Agent entries

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael Roth --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e0e5a8dc3f..fa1620d8a8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1440,6 +1440,10 @@ QEMU Guest Agent M: Michael Roth S: Mai

Re: [Qemu-devel] [PATCH v7 03/22] migration: Teach it about G_SOURCE_REMOVE

2017-09-08 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > As this is defined on glib 2.32, add compatibility macros for older glibs. > > Signed-off-by: Juan Quintela > Reviewed-by: Daniel P. Berrange > Reviewed-by: Peter Xu I think 03 and 04 could both be merged to current qemu? I think you could remove

Re: [Qemu-devel] [PATCH 3/3] Unified Datagram Socket Transport - raw support

2017-09-08 Thread Anton Ivanov
On 24/07/17 05:03, Jason Wang wrote: > > > On 2017年07月22日 02:50, Anton Ivanov wrote: >> >> [snip] >> +"-netdev raw,id=str,ifname=ifname\n" +"configure a network backend with ID 'str' connected to\n" +"an Ethernet interface named ifname

Re: [Qemu-devel] [PATCH v7 13/22] migration: Split migration_fd_process_incoming

2017-09-08 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We need that on later patches. > > Signed-off-by: Juan Quintela > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Peter Xu > Reviewed-by: Daniel P. Berrange I think this could also go into current qemu? Dave > --- > migration/migration.c |

Re: [Qemu-devel] [PATCH v2 12/17] MAINTAINERS: add missing megasas test entry

2017-09-08 Thread Philippe Mathieu-Daudé
Let's try another SUSE domain On 09/08/2017 02:12 PM, Philippe Mathieu-Daudé wrote: I wonder if "megasas" is still maintained, I got: To: Hannes Reinecke Final-Recipient: rfc822; h...@suse.de Action: failed Status: 5.1.1 Remote-MTA: dns; mx2.suse.de. (195.135.220.15, the server for the domain

[Qemu-devel] [PATCH v3 00/15] add missing entries in MAINTAINERS

2017-09-08 Thread Philippe Mathieu-Daudé
Hi, I tried to have a more helpful ./scripts/get_maintainer.pl output, filling missing entries in MAINTAINERS. Regards, Phil. v3: - rebased, add R-b & A-b - squashed ARM patches (Thomas Huth) - remove 'megasas' patch, maintainer email not working v2: - add R-b & A-b - clean ARM entries (Thomas

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

2017-09-08 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Aug 25, 2017 at 10:30:42AM +0100, Dr. David Alan Gilbert wrote: > > [...] > > > > > c) As mentioned on irc there's fun to be had with cur_mon and error > > > > handling - in my local world I have cur_mon declared as __thread > > > > but

[Qemu-devel] [PATCH v3 03/15] MAINTAINERS: add missing entry for vhost

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Acked-by: Michael S. Tsirkin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fb93e4b554..afc0072a17 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1029,6 +1029,7 @@ vhost M: Michael S. Tsirkin S: Support

[Qemu-devel] [PATCH v3 02/15] MAINTAINERS: add missing STM32 entry

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Alistair Francis --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 35c8c9c752..fb93e4b554 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -552,6 +552,7 @@ F: hw/char/stm32

[Qemu-devel] [PATCH v3 01/15] MAINTAINERS: add missing ARM entries

2017-09-08 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth --- MAINTAINERS | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 36eeb42d19..35c8c9c752 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -380,6 +380,7 @@ M: Peter Maydell L: q

Re: [Qemu-devel] [PATCH v2 12/17] MAINTAINERS: add missing megasas test entry

2017-09-08 Thread Philippe Mathieu-Daudé
I wonder if "megasas" is still maintained, I got: To: Hannes Reinecke Final-Recipient: rfc822; h...@suse.de Action: failed Status: 5.1.1 Remote-MTA: dns; mx2.suse.de. (195.135.220.15, the server for the domain suse.de.) Diagnostic-Code: smtp; 550 5.1.1 : Recipient address rejected: User unknow

Re: [Qemu-devel] [PATCH 1/1] AArch64: Fix single stepping of ERET instruction

2017-09-08 Thread Richard Henderson
On 09/08/2017 04:02 AM, Jaroslaw Pelczar wrote: > Previously when single stepping through ERET instruction via GDB > would result in debugger entering the "next" PC after ERET instruction. > When debugging in kernel mode, this will also cause unintended behavior, > because debugger will try to acce

[Qemu-devel] [Bug 1178101] Re: Could not enable gtk UI on build for Windows target

2017-09-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1060928] Re: Error in launch virtual server port

2017-09-08 Thread Thomas Huth
Triaging old bug tickets... can you anyhow still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribe

[Qemu-devel] [Bug 1196426] Re: Setup virtual serial connection for Windows VMs FAILS

2017-09-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1135567] Re: QXL crashes a Windows 7 guest if host goes into screensaver

2017-09-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1061778] Re: signal mask not reset on exec

2017-09-08 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

  1   2   3   4   5   >