Re: [Qemu-devel] [PATCH v2] scsi-block: Add qdev error properties

2017-08-17 Thread Paolo Bonzini
On 18/08/2017 05:38, Fam Zheng wrote: > On Thu, 08/17 16:23, Paolo Bonzini wrote: >>> +if (scsi_sense_matches(r, SENSE_CODE(NO_MEDIUM))) { >>> +error = ENOMEDIUM; >>> +} else if (scsi_sense_matches(r, SENSE_CODE(TARGET_FAILURE))) { >>> +error = ENOMEM; >>> +

Re: [Qemu-devel] [PATCHv2 3/4] scsi: clarify sense codes for LUN0 emulation

2017-08-17 Thread Hannes Reinecke
On 08/18/2017 02:57 AM, Laszlo Ersek wrote: > On 08/18/17 02:16, Laszlo Ersek wrote: >> On 08/17/17 22:57, Laszlo Ersek wrote: >>> On 08/04/17 12:49, Paolo Bonzini wrote: On 04/08/2017 10:36, Hannes Reinecke wrote: > The LUN0 emulation is just that, an emulation for a non-existing > LU

[Qemu-devel] [PATCH v4 0/1] Exploit settable KVM_CAP_PPC_SMT

2017-08-17 Thread Sam Bobroff
Hello QEMU PPC people, This is v3, it is only a single patch now. My core objective with this patch is to provide a way for QEMU to configure the newly writeable KVM capability 'KVM_CAP_PPC_SMT', because without it Power 9 hosts can only run VMs with a single thread per core. (With this capabili

[Qemu-devel] [PATCH v4 1/1] PPC: KVM: Support machine option to set VSMT mode

2017-08-17 Thread Sam Bobroff
KVM now allows writing to KVM_CAP_PPC_SMT which has previously been read only. Doing so causes KVM to act, for that VM, as if the host's SMT mode was the given value. This is particularly important on Power 9 systems because their default value is 1, but they are able to support values up to 8. Th

[Qemu-devel] Memory use with >100 virtio devices

2017-08-17 Thread Alexey Kardashevskiy
Hi! We have received a report that qemu cannot handle hundreds of virtio devices and crashes. I tried qemu with 150 virtio-block devices, 1 CPU and and 2GB RAM (the exact command line is at the end) and found that it took more than 5.5GB resident and 9GB virtual memory. Bit weird, I tried valgrind

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-17 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 08/17/2017 02:55 PM, Alistair Francis wrote: On 15/08/2017 09:30, Markus Armbruster wrote: > The stupid fix is to repeat libraries until the link succeeds: > > test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a > > [...] >

Re: [Qemu-devel] [PATCH v3 1/1] PPC: KVM: Support machine option to set VSMT mode

2017-08-17 Thread Sam Bobroff
On Fri, Aug 18, 2017 at 12:35:36PM +1000, David Gibson wrote: > On Tue, Aug 15, 2017 at 02:42:21PM +1000, Sam Bobroff wrote: > > KVM now allows writing to KVM_CAP_PPC_SMT which has previously been > > read only. Doing so causes KVM to act, for that VM, as if the host's > > SMT mode was the given va

Re: [Qemu-devel] [RFC v2 PATCH 2/2] virtio-iommu: vfio integration with virtio-iommu

2017-08-17 Thread Bharat Bhushan
> -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Thursday, August 17, 2017 9:03 PM > To: Bharat Bhushan ; > eric.auger@gmail.com; peter.mayd...@linaro.org; > alex.william...@redhat.com; m...@redhat.com; qemu-...@nongnu.org; > qemu-devel@nongnu.org > Cc: w

Re: [Qemu-devel] Help with Windows NT 4.0

2017-08-17 Thread Programmingkid
> On Aug 15, 2017, at 6:27 PM, Paolo Bonzini wrote: > > On 15/08/2017 20:46, Programmingkid wrote: >> >>> On Aug 14, 2017, at 2:51 AM, Paolo Bonzini wrote: >>> >>> On 13/08/2017 21:13, Programmingkid wrote: Lately I found out that Windows NT 4.0 seems to work well with the 486 and p

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-17 Thread David Gibson
On Thu, Aug 17, 2017 at 06:31:28PM -0300, Daniel Henrique Barboza wrote: > > > On 08/17/2017 04:52 AM, David Gibson wrote: > > On Tue, Aug 15, 2017 at 05:28:46PM -0300, Daniel Henrique Barboza wrote: > > > This patch is a follow up on the discussions that started with > > > Laurent's patch series

Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files

2017-08-17 Thread Richard Henderson
On 08/17/2017 02:22 AM, David Hildenbrand wrote: > Let's do it just like the other architectures. Introduce kvm-stub.c > for stubs and kvm_s390x.h for the declarations. > > Add a fake declaration of struct kvm_s390_irq so we don't need other > ugly CONFIG_KVM checks. > > Change license to GPL2+ a

Re: [Qemu-devel] [PATCH for-2.11] intel_iommu: fix missing BQL in pt fast path

2017-08-17 Thread Peter Xu
On Thu, Aug 17, 2017 at 11:40:48AM +0200, Paolo Bonzini wrote: > On 17/08/2017 07:56, Peter Xu wrote: > > In vtd_switch_address_space() we did the memory region switch, however > > it's possible that the caller of it has not taken the BQL at all. Make > > sure we have it. > > > > CC: Paolo Bonzini

Re: [Qemu-devel] [PATCH v1 for-2.11 05/10] target/s390x: move get_per_in_range() to misc_helper.c

2017-08-17 Thread Richard Henderson
On 08/17/2017 02:22 AM, David Hildenbrand wrote: > Only used in that file. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h | 11 --- > target/s390x/misc_helper.c | 11 +++ > 2 files changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v1 for-2.11 04/10] target/s390x: move s390_do_cpu_reset() to diag.c

2017-08-17 Thread Richard Henderson
On 08/17/2017 02:22 AM, David Hildenbrand wrote: > Only used in that file. Also drop the comment, not really needed. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h | 7 --- > target/s390x/diag.c | 7 +++ > 2 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: R

Re: [Qemu-devel] [PATCH v1 for-2.11 03/10] target/s390x: move psw_key_valid() to mem_helper.c

2017-08-17 Thread Richard Henderson
On 08/17/2017 02:22 AM, David Hildenbrand wrote: > Only used in that file. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h| 11 --- > target/s390x/mem_helper.c | 11 +++ > 2 files changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v1 for-2.11 02/10] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c

2017-08-17 Thread Richard Henderson
On 08/17/2017 02:22 AM, David Hildenbrand wrote: > Only used in that file. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h | 14 -- > target/s390x/excp_helper.c | 14 ++ > 2 files changed, 14 insertions(+), 14 deletions(-) Reviewed-by: Richard Hen

Re: [Qemu-devel] [PATCH v1 for-2.11 01/10] target/s390x: move cc_name() to cc_helper.c

2017-08-17 Thread Richard Henderson
On 08/17/2017 02:22 AM, David Hildenbrand wrote: > +const char *cc_name(int cc_op) While we're changing things up a tich, enum cc_op? > +{ > +static const char *cc_names[] = { static const char * const cc_names[] Otherwise, Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2] scsi-block: Add qdev error properties

2017-08-17 Thread Fam Zheng
On Thu, 08/17 16:23, Paolo Bonzini wrote: > > +if (scsi_sense_matches(r, SENSE_CODE(NO_MEDIUM))) { > > +error = ENOMEDIUM; > > +} else if (scsi_sense_matches(r, SENSE_CODE(TARGET_FAILURE))) { > > +error = ENOMEM; > > +} else if (scsi_sense_matches(r,

[Qemu-devel] [PATCH v5 4/6] block: convert ThrottleGroup to object with QOM

2017-08-17 Thread Manos Pitsidianakis
ThrottleGroup is converted to an object. This will allow the future throttle block filter drive easy creation and configuration of throttle groups in QMP and cli. A new QAPI struct, ThrottleLimits, is introduced to provide a shared struct for all throttle configuration needs in QMP. ThrottleGroup

[Qemu-devel] [PATCH v5 1/6] block: move ThrottleGroup membership to ThrottleGroupMember

2017-08-17 Thread Manos Pitsidianakis
This commit eliminates the 1:1 relationship between BlockBackend and throttle group state. Users will be able to create multiple throttle nodes, each with its own throttle group state, in the future. The throttle group state cannot be per-BlockBackend anymore, it must be per-throttle node. This i

[Qemu-devel] [PATCH v5 2/6] block: add aio_context field in ThrottleGroupMember

2017-08-17 Thread Manos Pitsidianakis
timer_cb() needs to know about the current Aio context of the throttle request that is woken up. In order to make ThrottleGroupMember backend agnostic, this information is stored in an aio_context field instead of accessing it from BlockBackend. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Haj

[Qemu-devel] [PATCH v5 5/6] block: add throttle block filter driver

2017-08-17 Thread Manos Pitsidianakis
block/throttle.c uses existing I/O throttle infrastructure inside a block filter driver. I/O operations are intercepted in the filter's read/write coroutines, and referred to block/throttle-groups.c The driver can be used with the syntax -drive driver=throttle,file.filename=foo.qcow2, \ li

[Qemu-devel] [PATCH v5 3/6] block: tidy ThrottleGroupMember initializations

2017-08-17 Thread Manos Pitsidianakis
Move the CoMutex and CoQueue inits inside throttle_group_register_tgm() which is called whenever a ThrottleGroupMember is initialized. There's no need for them to be separate. Reviewed-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Manos Pitsidianakis --- block/block-backend.c

[Qemu-devel] [PATCH v5 0/6] add throttle block driver filter

2017-08-17 Thread Manos Pitsidianakis
This series adds a throttle block driver filter. Currently throttling is done at the BlockBackend level. Using block driver interfaces we can move the throttling to any point in the BDS graph using a throttle node which uses the existing throttling code. This allows for potentially more complex con

[Qemu-devel] [PATCH v5 6/6] block: add iotest 184 for the throttle filter driver

2017-08-17 Thread Manos Pitsidianakis
Signed-off-by: Manos Pitsidianakis --- tests/qemu-iotests/184 | 310 + tests/qemu-iotests/184.out | 422 + tests/qemu-iotests/group | 1 + 3 files changed, 733 insertions(+) create mode 100755 tests/qemu-iotests/

Re: [Qemu-devel] [PATCH v3 1/1] PPC: KVM: Support machine option to set VSMT mode

2017-08-17 Thread David Gibson
On Tue, Aug 15, 2017 at 02:42:21PM +1000, Sam Bobroff wrote: > KVM now allows writing to KVM_CAP_PPC_SMT which has previously been > read only. Doing so causes KVM to act, for that VM, as if the host's > SMT mode was the given value. This is particularly important on Power > 9 systems because their

Re: [Qemu-devel] [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-17 Thread Michael S. Tsirkin
On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: > Add a new vq to report hints of guest free pages to the host. > > Signed-off-by: Wei Wang > Signed-off-by: Liang Li > --- > drivers/virtio/virtio_balloon.c | 167 > +++- > include/uapi/linux/virtio_

Re: [Qemu-devel] [PATCH v14 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-08-17 Thread Michael S. Tsirkin
On Thu, Aug 17, 2017 at 11:26:54AM +0800, Wei Wang wrote: > Add a new feature, VIRTIO_BALLOON_F_SG, which enables the transfer > of balloon (i.e. inflated/deflated) pages using scatter-gather lists > to the host. > > The implementation of the previous virtio-balloon is not very > efficient, becaus

Re: [Qemu-devel] [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-17 Thread Michael S. Tsirkin
On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: > Add a new vq to report hints of guest free pages to the host. Please add some text here explaining the report_free_page_signal thing. I also really think we need some kind of ID in the buffer to do a handshake. whenever id changes you a

Re: [Qemu-devel] nVidia emulation in QEMU?

2017-08-17 Thread Philippe Mathieu-Daudé
Hi, On 08/17/2017 10:01 PM, Darius Goad wrote: Hello. I'm Melissa, a trans woman who is the main developer of the nVidia emulation code for 86Box. I'm interested in porting this code over to QEMU as QEMU has higher compatibility with newer operating systems, as well as expanding the developer ba

Re: [Qemu-devel] [RFC PATCH 09/12] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

2017-08-17 Thread David Gibson
On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: You know I'm going to say it, right: needs a commit message. What's a "plb-pcix", and what's an example of a 440 SoCs which has it. This is basically a new device, so I'm pretty willing to merge for 2.11 with minimal review once reb

Re: [Qemu-devel] [PATCH 2/6] tests: Add network filter tests to the check-qtest-s390x list

2017-08-17 Thread Zhang Chen
On 08/17/2017 10:02 PM, Thomas Huth wrote: On 17.08.2017 10:41, Cornelia Huck wrote: On Thu, 17 Aug 2017 08:25:09 +0200 Thomas Huth wrote: With some small modifications, we can also use the the netfilter, the fiter-mirror and the filter-redirector tests on s390x. s/fiter/filter/ OK ... co

Re: [Qemu-devel] [RFC PATCH 07/12] ppc4xx_i2c: Implement basic I2C functions

2017-08-17 Thread David Gibson
On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: > Enough to please U-Boot and make it able to detect SDRAM SPD EEPROMs > > Signed-off-by: François Revol > Signed-off-by: BALATON Zoltan I don't have the knowledge to review this deeply (or, rather, I don't have the time to refresh

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

2017-08-17 Thread David Gibson
On Thu, Aug 17, 2017 at 08:33:10PM +0200, Thomas Huth wrote: > QEMU currently crashes when trying to use a 'pc-dimm' on the pseries > machine without specifying its 'memdev' property. Let's add a sanity > check to the pre_plug handler to fix this issue. > > Signed-off-by: Thomas Huth Thanks for

Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-17 Thread Michael S. Tsirkin
On Thu, Aug 17, 2017 at 05:23:46PM +0100, Anthony PERARD wrote: > This means that the function will be call and the property > acpi-pcihp-bsel will be set even if ACPI build is disable. > > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > set, but this was done only when

[Qemu-devel] nVidia emulation in QEMU?

2017-08-17 Thread Darius Goad
Hello. I'm Melissa, a trans woman who is the main developer of the nVidia emulation code for 86Box. I'm interested in porting this code over to QEMU as QEMU has higher compatibility with newer operating systems, as well as expanding the developer base for nVidia graphics card emulation. The 86Box

Re: [Qemu-devel] [PATCHv2 3/4] scsi: clarify sense codes for LUN0 emulation

2017-08-17 Thread Laszlo Ersek
On 08/18/17 02:16, Laszlo Ersek wrote: > On 08/17/17 22:57, Laszlo Ersek wrote: >> On 08/04/17 12:49, Paolo Bonzini wrote: >>> On 04/08/2017 10:36, Hannes Reinecke wrote: The LUN0 emulation is just that, an emulation for a non-existing LUN0. So we should be returning LUN_NOT_SUPPORTED for

Re: [Qemu-devel] [PATCHv2 3/4] scsi: clarify sense codes for LUN0 emulation

2017-08-17 Thread Laszlo Ersek
On 08/17/17 22:57, Laszlo Ersek wrote: > On 08/04/17 12:49, Paolo Bonzini wrote: >> On 04/08/2017 10:36, Hannes Reinecke wrote: >>> The LUN0 emulation is just that, an emulation for a non-existing >>> LUN0. So we should be returning LUN_NOT_SUPPORTED for any request >>> coming from any other LUN. >

Re: [Qemu-devel] [PATCH 3/8] tcg: Add types for host vectors

2017-08-17 Thread Philippe Mathieu-Daudé
On 08/17/2017 08:01 PM, Richard Henderson wrote: Nothing uses or enables them yet. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- tcg/tcg.h | 5 + tcg/tcg.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index d

Re: [Qemu-devel] [PATCH 6/8] tcg: Add INDEX_op_invalid

2017-08-17 Thread Philippe Mathieu-Daudé
On 08/17/2017 08:01 PM, Richard Henderson wrote: Add with value 0 so that structure zero initialization can indicate that the field is not present. Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- tcg/tcg-opc.h | 2 ++ tcg/tcg.c | 3 +++ 2 files changed, 5 i

Re: [Qemu-devel] [PATCH 5/8] tcg: Add tcg_op_supported

2017-08-17 Thread Philippe Mathieu-Daudé
On 08/17/2017 08:01 PM, Richard Henderson wrote: Signed-off-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé --- tcg/tcg.h | 2 + tcg/tcg.c | 310 ++ 2 files changed, 312 insertions(+) diff --git a/tcg/tcg.h b/tcg/t

[Qemu-devel] [PATCH v7 3/4] hw/pci: add QEMU-specific PCI capability to the Generic PCI Express Root Port

2017-08-17 Thread Aleksandr Bezzubikov
To enable hotplugging of a newly created pcie-pci-bridge, we need to tell firmware (e.g. SeaBIOS) to reserve additional buses or IO/MEM/PREF space for pcie-root-port. Additional bus reservation allows us to hotplug pcie-pci-bridge into this root port. The number of buses and IO/MEM/PREF space to r

[Qemu-devel] [PATCH v7 4/4] docs: update documentation considering PCIE-PCI bridge

2017-08-17 Thread Aleksandr Bezzubikov
Signed-off-by: Aleksandr Bezzubikov Reviewed-by: Laszlo Ersek Reviewed-by: Marcel Apfelbaum --- docs/pcie.txt| 49 ++-- docs/pcie_pci_bridge.txt | 114 +++ 2 files changed, 140 insertions(+), 23 deletions(-) create mode 1

[Qemu-devel] [PATCH v7 2/4] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

2017-08-17 Thread Aleksandr Bezzubikov
On PCI init PCI bridges may need some extra info about bus number, IO, memory and prefetchable memory to reserve. QEMU can provide this with a special vendor-specific PCI capability. Signed-off-by: Aleksandr Bezzubikov Reviewed-by: Marcel Apfelbaum --- hw/pci/pci_bridge.c | 46 +

[Qemu-devel] [PATCH v7 0/4] Generic PCIE-PCI Bridge

2017-08-17 Thread Aleksandr Bezzubikov
This series introduces a new device - Generic PCI Express to PCI bridge, and also makes all necessary changes to enable hotplug of the bridge itself and any device into the bridge. Changes v6->v7: Change IO/MEM/PREF reservation properties type to SIZE. Changes v5->v6: 1. Fix indentation in the ca

[Qemu-devel] [PATCH v7 1/4] hw/pci: introduce pcie-pci-bridge device

2017-08-17 Thread Aleksandr Bezzubikov
Introduce a new PCIExpress-to-PCI Bridge device, which is a hot-pluggable PCI Express device and supports devices hot-plug with SHPC. This device is intended to replace the DMI-to-PCI Bridge. Signed-off-by: Aleksandr Bezzubikov Reviewed-by: Marcel Apfelbaum --- hw/pci-bridge/Makefile.objs

[Qemu-devel] [PATCH RESEND v7 2/3] pci: add QEMU-specific PCI capability structure

2017-08-17 Thread Aleksandr Bezzubikov
On PCI init PCI bridge devices may need some extra info about bus number to reserve, IO, memory and prefetchable memory limits. QEMU can provide this with special vendor-specific PCI capability. This capability is intended to be used only for Red Hat PCI bridges, i.e. QEMU cooperation. Signed-off

[Qemu-devel] [PATCH RESEND v7 1/3] pci: refactor pci_find_capapibilty to get bdf as the first argument instead of the whole pci_device

2017-08-17 Thread Aleksandr Bezzubikov
Refactor pci_find_capability function to get bdf instead of a whole pci_device* as the only necessary field for this function is still bdf. Signed-off-by: Aleksandr Bezzubikov Reviewed-by: Marcel Apfelbaum --- src/fw/pciinit.c| 4 ++-- src/hw/pci.c| 25 + sr

[Qemu-devel] [PATCH RESEND v7 0/3] Red Hat PCI bridge resource reserve capability

2017-08-17 Thread Aleksandr Bezzubikov
Now PCI bridges get a bus range number on a system init, basing on currently plugged devices. That's why when one wants to hotplug another bridge, it needs his child bus, which the parent is unable to provide (speaking about virtual device). The suggested workaround is to have vendor-specific cap

[Qemu-devel] [PATCH RESEND v7 3/3] pci: enable RedHat PCI bridges to reserve additional resources on PCI init

2017-08-17 Thread Aleksandr Bezzubikov
In case of Red Hat Generic PCIE Root Port reserve additional buses and/or IO/MEM/PREF space, which values are provided in a vendor-specific capability. Signed-off-by: Aleksandr Bezzubikov Reviewed-by: Marcel Apfelbaum --- src/fw/pciinit.c | 106 +

Re: [Qemu-devel] [PATCH 01/26] qapi: fix type_seen key error

2017-08-17 Thread Marc-André Lureau
On Tue, Aug 15, 2017 at 4:41 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > The type_seen member can be of a different type than the 'qtype' being > > checked, since a string create several conflicts. Lookup the real > > conflicting type in the conflict set, that one must be prese

[Qemu-devel] [PATCH v7 0/3] Red Hat PCI bridge resource reserve capability

2017-08-17 Thread Aleksandr Bezzubikov
Now PCI bridges get a bus range number on a system init, basing on currently plugged devices. That's why when one wants to hotplug another bridge, it needs his child bus, which the parent is unable to provide (speaking about virtual device). The suggested workaround is to have vendor-specific cap

[Qemu-devel] [PATCH v7 1/3] pci: refactor pci_find_capapibilty to get bdf as the first argument instead of the whole pci_device

2017-08-17 Thread Aleksandr Bezzubikov
Refactor pci_find_capability function to get bdf instead of a whole pci_device* as the only necessary field for this function is still bdf. Signed-off-by: Aleksandr Bezzubikov Reviewed-by: Marcel Apfelbaum --- src/fw/pciinit.c| 4 ++-- src/hw/pci.c| 25 + sr

[Qemu-devel] [PATCH v7 3/3] pci: enable RedHat PCI bridges to reserve additional resources on PCI init

2017-08-17 Thread Aleksandr Bezzubikov
In case of Red Hat Generic PCIE Root Port reserve additional buses and/or IO/MEM/PREF space, which values are provided in a vendor-specific capability. Signed-off-by: Aleksandr Bezzubikov Reviewed-by: Marcel Apfelbaum --- src/fw/pciinit.c | 106 +

[Qemu-devel] [PATCH v7 2/3] pci: add QEMU-specific PCI capability structure

2017-08-17 Thread Aleksandr Bezzubikov
On PCI init PCI bridge devices may need some extra info about bus number to reserve, IO, memory and prefetchable memory limits. QEMU can provide this with special vendor-specific PCI capability. This capability is intended to be used only for Red Hat PCI bridges, i.e. QEMU cooperation. Signed-off

[Qemu-devel] [PATCH 8/8] tcg/i386: Add vector operations

2017-08-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.h | 46 +- tcg/tcg-opc.h | 12 +- tcg/i386/tcg-target.inc.c | 382 ++ 3 files changed, 399 insertions(+), 41 deletions(-) diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-t

[Qemu-devel] [PATCH 7/8] tcg: Expand target vector ops with host vector ops

2017-08-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg-op-gvec.h | 4 + tcg/tcg.h | 6 +- tcg/tcg-op-gvec.c | 230 +++--- tcg/tcg.c | 8 +- 4 files changed, 197 insertions(+), 51 deletions(-) diff --git a/tcg/tcg-op-gvec.h b/tcg/tcg-op-

[Qemu-devel] [PATCH 6/8] tcg: Add INDEX_op_invalid

2017-08-17 Thread Richard Henderson
Add with value 0 so that structure zero initialization can indicate that the field is not present. Signed-off-by: Richard Henderson --- tcg/tcg-opc.h | 2 ++ tcg/tcg.c | 3 +++ 2 files changed, 5 insertions(+) diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h index 9162125fac..b1445a4c24 100644 --

[Qemu-devel] [PATCH 0/8] TCG vectorization and example conversion

2017-08-17 Thread Richard Henderson
When Alex and I started talking about this topic, this is the direction I was thinking. The primary difference from Alex's version is that the interface on the target/cpu/ side uses offsets and not a faux temp. The secondary difference is that, for smaller vector sizes at least, I will expand to

[Qemu-devel] [PATCH 5/8] tcg: Add tcg_op_supported

2017-08-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/tcg.h | 2 + tcg/tcg.c | 310 ++ 2 files changed, 312 insertions(+) diff --git a/tcg/tcg.h b/tcg/tcg.h index b9e15da13b..b443143b21 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -962,6 +962,8 @@ do

[Qemu-devel] [PATCH 1/8] tcg: Add generic vector infrastructure and ops for add/sub/logic

2017-08-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- Makefile.target| 5 +- tcg/tcg-op-gvec.h | 88 ++ tcg/tcg-runtime.h | 16 ++ tcg/tcg-op-gvec.c | 443 + tcg/tcg-runtime-gvec.c | 199 ++ 5 files changed, 749

[Qemu-devel] [PATCH 4/8] tcg: Add operations for host vectors

2017-08-17 Thread Richard Henderson
Nothing uses or implements them yet. Signed-off-by: Richard Henderson --- tcg/tcg-opc.h | 89 +++ tcg/tcg.h | 24 2 files changed, 113 insertions(+) diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h index 956fb1e9f3..9162125f

[Qemu-devel] [PATCH 3/8] tcg: Add types for host vectors

2017-08-17 Thread Richard Henderson
Nothing uses or enables them yet. Signed-off-by: Richard Henderson --- tcg/tcg.h | 5 + tcg/tcg.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/tcg/tcg.h b/tcg/tcg.h index dd97095af5..1277caed3d 100644 --- a/tcg/tcg.h +++ b/tcg/tcg.h @@ -256,6 +256,11 @@ typedef struc

[Qemu-devel] [PATCH 2/8] target/arm: Use generic vector infrastructure for aa64 add/sub/logic

2017-08-17 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 137 - 1 file changed, 87 insertions(+), 50 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 2200e25be0..025354f983 100644 --- a/target/arm/transla

[Qemu-devel] [PATCH 2/3] multiboot: load any machine type of ELF

2017-08-17 Thread Anatol Pomozov
x86 is not the only architecture supported by multiboot. For example GRUB supports MIPS architecture as well. Signed-off-by: Anatol Pomozov --- hw/i386/multiboot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/multiboot.c b/hw/i386/multiboot.c index 19113c0fce..a492

[Qemu-devel] [PATCH 3/3] multiboot: load elf sections and section headers

2017-08-17 Thread Anatol Pomozov
Multiboot may load section headers and all sections (even those that are not part of any segment) to target memory. Tested with an ELF application that uses data from strings table section. Signed-off-by: Anatol Pomozov --- hw/core/loader.c | 8 ++-- hw/i386/multiboot.c | 83 +++

[Qemu-devel] [PATCH 1/3] multiboot: Change multiboot_info from array of bytes to a C struct

2017-08-17 Thread Anatol Pomozov
Using C structs makes the code more readable and prevents type conversion errors. Borrow multiboot1 header from GRUB project. Signed-off-by: Anatol Pomozov --- hw/i386/multiboot.c| 124 +- hw/i386/multiboot_header.h | 254 +

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-17 Thread Daniel Henrique Barboza
On 08/17/2017 04:52 AM, David Gibson wrote: On Tue, Aug 15, 2017 at 05:28:46PM -0300, Daniel Henrique Barboza wrote: This patch is a follow up on the discussions that started with Laurent's patch series "spapr: disable hotplugging without OS" [1] and discussions made at patch "spapr: reset DRC

Re: [Qemu-devel] kvm_intel fails to load on Conroe CPUs running Linux 4.12

2017-08-17 Thread Gerhard Wiesinger
On 07.08.2017 19:50, Paolo Bonzini wrote: >Not much to say, unfortunately. It's pretty much the same capabilities >as a Prescott/Cedar Mill processor, except that it has MSR bitmaps. It >also lacks FlexPriority compared to the Conroe I had checked. > >It's not great that even the revert patch do

Re: [Qemu-devel] kvm_intel fails to load on Conroe CPUs running Linux 4.12

2017-08-17 Thread Gerhard Wiesinger
On 17.08.2017 22:58, Gerhard Wiesinger wrote: > > On 07.08.2017 19:50, Paolo Bonzini wrote: > > >Not much to say, unfortunately. It's pretty much the same capabilities > >as a Prescott/Cedar Mill processor, except that it has MSR bitmaps. It > >also lacks FlexPriority compared to the Conroe I had

Re: [Qemu-devel] [PATCHv2 3/4] scsi: clarify sense codes for LUN0 emulation

2017-08-17 Thread Laszlo Ersek
On 08/04/17 12:49, Paolo Bonzini wrote: > On 04/08/2017 10:36, Hannes Reinecke wrote: >> The LUN0 emulation is just that, an emulation for a non-existing >> LUN0. So we should be returning LUN_NOT_SUPPORTED for any request >> coming from any other LUN. >> And we should be aborting unhandled command

Re: [Qemu-devel] [Qemu-arm] [RFC v3 0/8] VIRTIO-IOMMU device

2017-08-17 Thread Linu Cherian
On Thu Aug 17, 2017 at 05:26:53PM +0200, Auger Eric wrote: > Hi Linu, Jean, > > On 17/08/2017 15:39, Jean-Philippe Brucker wrote: > > Hi Linu, > > > > On 17/08/17 12:26, Linu Cherian wrote: > >> Hi Eric, > >> > >> On Tue Aug 01, 2017 at 11:33:06AM +0200, Eric Auger wrote: > >>> This series implem

Re: [Qemu-devel] How to make ELF headers/symbol sections available for multiboot?

2017-08-17 Thread Anatol Pomozov
Hi On Tue, Aug 8, 2017 at 8:04 AM, Kevin Wolf wrote: > Am 04.08.2017 um 06:53 hat Anatol Pomozov geschrieben: >> Hi Kevin >> >> Thanks for the information. >> >> So I sounds like we do want multiboot to load all sections regardless >> of its segments info. To achieve it we need to read sections h

Re: [Qemu-devel] [RFC PATCH 9/9] target/arm/translate-a64: vectorise smull vD.4s, vN.[48]s, vM.h[]

2017-08-17 Thread Richard Henderson
On 08/17/2017 11:04 AM, Alex Bennée wrote: > +int32_t *rd = (int32_t *) d; > +int16_t *rn = (int16_t *) n; > +int16_t rm = (int16_t) m; > +int i; > + > +#pragma GCC ivdep > +for (i = 0; i < opr_elt; ++i) { > +rd[i] = rn[i + doff_elt] * rm; > +} You need to run t

Re: [Qemu-devel] [RFC PATCH 6/9] target/arm/translate-a64: regnames -> x_regnames

2017-08-17 Thread Richard Henderson
On 08/17/2017 11:04 AM, Alex Bennée wrote: > -static const char *regnames[] = { > +static const char *x_regnames[] = { > "x0", "x1", "x2", "x3", "x4", "x5", "x6", "x7", > "x8", "x9", "x10", "x11", "x12", "x13", "x14", "x15", > "x16", "x17", "x18", "x19", "x20", "x21", "x22", "x23",

Re: [Qemu-devel] [RFC PATCH 5/9] arm/cpu.h: align VFP registers

2017-08-17 Thread Richard Henderson
On 08/17/2017 11:04 AM, Alex Bennée wrote: > Signed-off-by: Alex Bennée > --- > target/arm/cpu.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [RFC PATCH 3/9] tcg: generate ptrs to vector registers

2017-08-17 Thread Richard Henderson
On 08/17/2017 11:03 AM, Alex Bennée wrote: > As we operate directly on the vectors in memory we pass around the > address for TCG_TYPE_VECTOR. Currently only helpers ever see these > values but if we were to generate simd backend instructions they would > load directly from the backing store. > >

Re: [Qemu-devel] [RFC PATCH 2/9] tcg: introduce the concepts of a TCGv_vec register type

2017-08-17 Thread Richard Henderson
On 08/17/2017 11:03 AM, Alex Bennée wrote: > Currently it only makes sense for globals - i.e. registers directly > mapped to CPUEnv. > --- > tcg/README | 1 + > tcg/tcg.h | 20 > 2 files changed, 21 insertions(+) I'm not keen on this. I know it makes for nicer intermediate

Re: [Qemu-devel] [RFC PATCH 1/9] tcg/README: listify the TCG types.

2017-08-17 Thread Richard Henderson
On 08/17/2017 11:03 AM, Alex Bennée wrote: > Although the other types are aliases lets make it clear what TCG types > are available. > > Signed-off-by: Alex Bennée > --- > tcg/README | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-17 Thread Philippe Mathieu-Daudé
On 08/17/2017 02:55 PM, Alistair Francis wrote: On 15/08/2017 09:30, Markus Armbruster wrote: The stupid fix is to repeat libraries until the link succeeds: test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a [...] Sticking '-Wp,-(' and '-Wp,-)' into the command line I get from

[Qemu-devel] [Bug 1706296] Re: Booting NT 4 disk causes /home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion failed: (!qemu_mutex_iothread_locked())

2017-08-17 Thread John Arbuckle
This workaround should help you avoid problems with Windows NT 4.0. Create the disk image for the hard drive that is 4GB or less in size: qemu-img create -f qcow2 .qcow2 4G Run QEMU booting from the CD-ROM. I assume you used the Windows NT 4.0 workstation CD. qemu-system-i386 -cpu pentium -vga

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-17 Thread Philippe Mathieu-Daudé
On 08/17/2017 02:02 PM, Markus Armbruster wrote: Paolo Bonzini writes: On 15/08/2017 09:30, Markus Armbruster wrote: The stupid fix is to repeat libraries until the link succeeds: test-util-obj-y = libqemuutil.a libqemustub.a libqemuutil.a You may have seen this with -lX11 if you're old

[Qemu-devel] [Bug 1706296] Re: Booting NT 4 disk causes /home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion failed: (!qemu_mutex_iothread_locked())

2017-08-17 Thread John Arbuckle
If you forget to add -cpu 486 or -cpu pentium your disk image will be corrupted and the display will display random characters. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1706296 Title: Booting

[Qemu-devel] [PATCH v1 5/5] xlnx-zcu102: Mark the EP108 machine as deprecated

2017-08-17 Thread Alistair Francis
The EP108 is the same as the ZCU102, mark it as deprecated as we don't need two machines. Signed-off-by: Alistair Francis --- hw/arm/xlnx-zcu102.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xlnx-zcu102.c b/hw/arm/xlnx-zcu102.c index 8a53221d0a..54207ba095 100644

[Qemu-devel] [PATCH v1 4/5] xlnx-zynqmp: Allow the secure prop to enable EL2

2017-08-17 Thread Alistair Francis
If the user sets the secure property to true we want to enalbe both EL2 and EL3. Signed-off-by: Alistair Francis --- hw/arm/xlnx-zynqmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c index 9eceadbdc8..d6ca5dcd4e 100644 --- a/hw/

[Qemu-devel] [PATCH v1 2/5] xlnx-zcu102: Manually create the machines

2017-08-17 Thread Alistair Francis
In preperation for future work let's manually create the Xilnx machines. This will allow us to set properties for the machines in the future. Signed-off-by: Alistair Francis --- hw/arm/xlnx-zcu102.c | 75 +++- 1 file changed, 68 insertions(+), 7 d

[Qemu-devel] [PATCH v1 0/5] Expose the secure property to the machine

2017-08-17 Thread Alistair Francis
The EL2 and EL3 work is working well now and interanlly we now have tests that expect to start in EL3 and transition through EL2 to EL1. To make this easy to run let's expose the secure property to the machine and then use that to enable EL2. This series also does some machine/name tidying up and

Re: [Qemu-devel] [RFC v4 08/13] ide: enumerate_slots implementation

2017-08-17 Thread John Snow
On 08/17/2017 12:54 AM, Markus Armbruster wrote: > John Snow writes: > >> On 08/14/2017 05:57 PM, Eduardo Habkost wrote: >>> Example output when using "-machine q35": >>> >>> { >>> "available": true, >>> "count": 1, >>> "device-types": [ >>> "ide-device" >>> ], >>> "

Re: [Qemu-devel] [PATCH v3] target-i386/cpu: Add new EPYC CPU model

2017-08-17 Thread Brijesh Singh
Hi Paolo, On 08/17/2017 11:45 AM, Paolo Bonzini wrote: On 15/08/2017 19:00, Brijesh Singh wrote: The following features bits have been added/removed compare to Opteron_G5 Added: monitor, movbe, rdrand, mmxext, ffxsr, rdtscp, cr8legacy, osvw, fsgsbase, bmi1, avx2, smep, bmi2, rdseed, a

[Qemu-devel] [PATCH] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

2017-08-17 Thread Thomas Huth
QEMU currently crashes when trying to use a 'pc-dimm' on the pseries machine without specifying its 'memdev' property. Let's add a sanity check to the pre_plug handler to fix this issue. Signed-off-by: Thomas Huth --- hw/ppc/spapr.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(

Re: [Qemu-devel] [RFC PATCH 0/9] TCG Vector types and example conversion

2017-08-17 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20170817180404.29334-1-alex.ben...@linaro.org Subject: [Qemu-devel] [RFC PATCH 0/9] TCG Vector types and example conversion === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n

Re: [Qemu-devel] [PATCH v5 01/10] qemu.py: Pylint/style fixes

2017-08-17 Thread Lukáš Doktor
Dne 17.8.2017 v 07:24 Markus Armbruster napsal(a): > Lukáš Doktor writes: > >> Dne 16.8.2017 v 18:58 Markus Armbruster napsal(a): >>> Lukáš Doktor writes: >>> Dne 15.8.2017 v 14:31 Markus Armbruster napsal(a): > Lukáš Doktor writes: > >> No actual code changes, just several pyl

[Qemu-devel] [RFC PATCH 6/9] target/arm/translate-a64: regnames -> x_regnames

2017-08-17 Thread Alex Bennée
These are the integer registers as will become clear when we start declaring the vector ones. Signed-off-by: Alex Bennée --- target/arm/translate-a64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 2200e25be0..80

[Qemu-devel] [RFC PATCH 9/9] target/arm/translate-a64: vectorise smull vD.4s, vN.[48]s, vM.h[]

2017-08-17 Thread Alex Bennée
These instructions show up in the ffmpeg profile from the ff_simple_idct_put_neon function. WARNING: this is experimental and essentially shortcuts to the vectorised helper for the one instruction that shows up a lot in the ffmpeg trace. Otherwise it falls through to the normal code generation. We

[Qemu-devel] [RFC PATCH 8/9] target/arm/helpers: introduce ADVSIMD flags

2017-08-17 Thread Alex Bennée
This is used to pass constant information to the helper. This includes immediate data and element counts/offsets. Signed-off-by: Alex Bennée --- target/arm/advsimd_helper_flags.h | 50 +++ target/arm/helper-a64.c | 1 + target/arm/translate-a64.c

[Qemu-devel] [RFC PATCH 5/9] arm/cpu.h: align VFP registers

2017-08-17 Thread Alex Bennée
Signed-off-by: Alex Bennée --- target/arm/cpu.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index b39d64aa0b..cdd47cb868 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -457,8 +457,8 @@ typedef struct CPUARMState {

[Qemu-devel] [RFC PATCH 3/9] tcg: generate ptrs to vector registers

2017-08-17 Thread Alex Bennée
As we operate directly on the vectors in memory we pass around the address for TCG_TYPE_VECTOR. Currently only helpers ever see these values but if we were to generate simd backend instructions they would load directly from the backing store. We also need to ensure when copying from one temp regis

[Qemu-devel] [RFC PATCH 0/9] TCG Vector types and example conversion

2017-08-17 Thread Alex Bennée
Hi, With upcoming work on SVE I've been looking at the way we implement vector registers in QEMU's TCG. The current orthodoxy is to decompose the vector into a series of TCG registers, often calling a helper function the calculation of each element. The result of the helper is then is then stored

[Qemu-devel] [RFC PATCH 7/9] target/arm/translate-a64: register global vectors

2017-08-17 Thread Alex Bennée
Register the vector registers with TCG. Signed-off-by: Alex Bennée --- target/arm/translate-a64.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 805af51900..b5f48605a7 100644 --- a/target/ar

[Qemu-devel] [RFC PATCH 4/9] helper-head: add support for vec type

2017-08-17 Thread Alex Bennée
--- include/exec/helper-head.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/exec/helper-head.h b/include/exec/helper-head.h index 1cfc43b9ff..3fb4c3fc39 100644 --- a/include/exec/helper-head.h +++ b/include/exec/helper-head.h @@ -23,6 +23,7 @@ #define GET_TCGV_i32 GET_TCGV_I32

  1   2   3   >