Re: [Qemu-devel] [PATCH v3 3/9] s390x: chsc nt2 events are pci-only

2017-07-25 Thread Thomas Huth
On 25.07.2017 17:33, Cornelia Huck wrote: > The nt2 event class is pci-only - don't look for events if pci is > not in the active cpu model. > > Signed-off-by: Cornelia Huck > --- > hw/s390x/s390-pci-bus.c | 4 ++-- > hw/s390x/s390-pci-bus.h | 4 ++-- > hw/s390x/s390-pci-stub.c | 4 ++-- >

Re: [Qemu-devel] [PATCH v3 1/9] kvm: remove hard dependency on pci

2017-07-25 Thread Thomas Huth
On 25.07.2017 17:33, Cornelia Huck wrote: > The msi routing code in kvm calls some pci functions: provide > some stubs to enable builds without pci. > > Fixes: e1d4fb2de ("kvm-irqchip: x86: add msi route notify fn") > Fixes: 767a554a0 ("kvm-all: Pass requester ID to MSI routing functions") > Signe

Re: [Qemu-devel] [RFC PATCH v2 0/4] Allow RedHat PCI bridges reserve more buses than necessary during init

2017-07-25 Thread Marcel Apfelbaum
On 25/07/2017 18:46, Laszlo Ersek wrote: On 07/23/17 00:11, Aleksandr Bezzubikov wrote: Now PCI bridges get a bus range number on a system init, basing on currently plugged devices. That's why when one wants to hotplug another bridge, it needs his child bus, which the parent is unable to provide

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

2017-07-25 Thread Marcel Apfelbaum
On 25/07/2017 11:53, 陈博 wrote: To accelerate data traversing between devices under the same PCIE Root Port or Switch. See https://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07209.html Hi, It may be possible, but maybe PCIe Switch assignment is not the only way to go. Adding Alex a

[Qemu-devel] Windows NT 4.0 for PowerPC

2017-07-25 Thread Programmingkid
Is there a way to install Windows NT 4.0 PowerPC in qemu-system-ppc? Has anyone succeeded? I have tried using the prep and 40p machines but they don’t boot the cd unfortunately.

[Qemu-devel] [PATCH v2 1/2] hmp: dump ids including socket-id, core-id and so on for 'info registers'

2017-07-25 Thread Yi Wang
This patch add output of CPUs' socket-id, core-id, thread-id and apic-id for 'info registers', which can be used for querying other hmp commands. Signed-off-by: Yi Wang Signed-off-by: Yun Liu --- target/i386/helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target/i386/helper

[Qemu-devel] [PATCH v2 0/2] hmp: support querying lapic through apic-id for 'info lapic'

2017-07-25 Thread Yi Wang
This series add support querying local apic through apic-id for 'info lapic'. As cpu_index will not be used afterwards, so extend 'info registers' firstly to get apic-id through monitor commands. v1 -> v2: * PATCH 01: Make the code simpler [Igor] * PATCH 02: use cpu_by_arch_id() to obtain CPU [E

[Qemu-devel] [PATCH v2 2/2] hmp: allow apic-id for "info lapic"

2017-07-25 Thread Yi Wang
Add [apic-id] support for hmp command "info lapic", which is useful when debugging ipi and so on. Current behavior is not changed when the parameter isn't specified. Signed-off-by: Yi Wang Signed-off-by: Yun Liu Signed-off-by: Eduardo Habkost --- hmp-commands-info.hx | 7 --- include/qom

Re: [Qemu-devel] [for-2.11 PATCH 19/26] spapr: populate PHB DRC entries for root DT node

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 08:02:03PM +0200, Greg Kurz wrote: > From: Nathan Fontenot > > This add entries to the root OF node to advertise our PHBs as being > DR-capable in accordance with PAPR specification. > > Signed-off-by: Nathan Fontenot > Signed-off-by: Michael Roth > Reviewed-by: David G

Re: [Qemu-devel] [for-2.11 PATCH 24/26] spapr: allow guest to update the XICS phandle

2017-07-25 Thread Alexey Kardashevskiy
On 26/07/17 04:03, Greg Kurz wrote: > The "phandle" property of the XICS node is referenced by the "interrupt-map" > property of each PHB node. This is used by the guest OS to setup IRQs for > all PCI devices. > > QEMU uses an arbitrary value (0x) for this phandle, but SLOF converts > this val

Re: [Qemu-devel] [for-2.11 PATCH 15/26] spapr: add pseries-2.11 machine type

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 08:01:12PM +0200, Greg Kurz wrote: > Signed-off-by: Greg Kurz Applied to ppc-for-2.11. Might as well get the new machine type template ready. > --- > hw/ppc/spapr.c | 22 -- > include/hw/compat.h |3 +++ > 2 files changed, 23 insertions(+)

Re: [Qemu-devel] [for-2.11 PATCH 13/26] qdev: store DeviceState's canonical path to use when unparenting

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 08:00:47PM +0200, Greg Kurz wrote: > From: Michael Roth > > device_unparent(dev, ...) is called when a device is unparented, > either directly, or as a result of a parent device being > finalized, and handles some final cleanup for the device. Part > of this includes emiti

Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port

2017-07-25 Thread Gerd Hoffmann
Hi, > > Gerd's suggestion was to set min(cap_value, children_found). From > > such  > > point of view 0 can be a valid value. > > > > I am lost now :) > How can we use the capability to reserve "more" buses since > children-found will be always the smaller value? > > I think you should use ma

Re: [Qemu-devel] [PATCH] vfio/pci-quirks: Set non-zero GMS memory size for IGD

2017-07-25 Thread Zhang, Xiong Y
Sorry, we indeed found Intel windows guest graphic driver couldn't be bind when GMS memory size is zero. And we have fixed it and the next intel windows driver release will contain this fix. So currently please use x-igd-gms in legacy mode to work around this. BTW, how did you know window drive

Re: [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression

2017-07-25 Thread Programmingkid
> On Jul 26, 2017, at 12:13 AM, Philippe Mathieu-Daudé wrote: > > Hi John, > > On 07/25/2017 07:55 PM, Programmingkid wrote: >> While compiling the mips64el-softmmu target I encountered these errors: >> CC hw/display/g364fb.o >> hw/core/loader-fit.c:105:41: error: expected expression >>

Re: [Qemu-devel] [PATCH v5 0/4] Convert to realize and fix error handling

2017-07-25 Thread Mao Zhongyi
On 07/26/2017 12:09 PM, Jason Wang wrote: On 2017年07月26日 11:45, Mao Zhongyi wrote: Hi, Jason This was posted over 2 months ago with two R-Bs(Markus & Philippe), did it get merged or dropped? Thanks, Mao Hi: Want to merge but it does not apply cleanly on HEAD. Could you please rebase an

Re: [Qemu-devel] [PATCH v2 09/10] qmp.py: Avoid overriding a builtin object

2017-07-25 Thread Lukáš Doktor
Dne 25.7.2017 v 21:34 Eduardo Habkost napsal(a): > On Tue, Jul 25, 2017 at 05:09:50PM +0200, Lukáš Doktor wrote: >> The "id" is a builtin method to get object's identity and should not be >> overridden. This might bring some issues in case someone was directly >> calling "cmd(..., id=id)" but I hav

Re: [Qemu-devel] [Qemu-ppc] [for-2.11 PATCH 16/26] spapr: enable PHB hotplug for pseries-2.11

2017-07-25 Thread Alexey Kardashevskiy
On 26/07/17 04:01, Greg Kurz wrote: > From: Michael Roth > > The 'dr_phb_enabled' field of that class can be set as > part of machine-specific init code, and is then propagated > to sPAPREnvironment to conditionally enable creation of DRC > objects and device-tree description to facilitate hotplu

Re: [Qemu-devel] [PATCH v2 05/10] qemu.py: Use custom exceptions rather than Exception

2017-07-25 Thread Lukáš Doktor
Dne 25.7.2017 v 18:06 Eduardo Habkost napsal(a): > On Tue, Jul 25, 2017 at 05:09:46PM +0200, Lukáš Doktor wrote: >> The naked Exception should not be widely used. It makes sense to be a >> bit more specific and use better-suited custom exceptions. As a benefit >> we can store the full reply in the

Re: [Qemu-devel] [Qemu-ppc] [for-2.11 PATCH 06/26] spapr_pci: parent the MSI memory region to the PHB

2017-07-25 Thread Alexey Kardashevskiy
On 26/07/17 03:59, Greg Kurz wrote: > This memory region should be owned by the PHB. This ensures the PHB > cannot be finalized as long as the the region is guest visible, or > used by a CPU or a device. Out of curiosity - does it really ensure this? Passing a parent to memory_region_init_io() add

Re: [Qemu-devel] [for-2.11 PATCH 09/26] spapr_drc: pass object ownership to parent/owner

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 07:59:56PM +0200, Greg Kurz wrote: > From: Michael Roth > > DRC objects attach themselves to an owner as a child > property. unref afterward to allow them to be finalized > when their owner is finalized. > > Signed-off-by: Michael Roth > Reviewed-by: Paolo Bonzini > Rev

Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port

2017-07-25 Thread Marcel Apfelbaum
On 25/07/2017 20:11, Alexander Bezzubikov wrote: вт, 25 июля 2017 г. в 19:10, Marcel Apfelbaum >: On 25/07/2017 17:09, Alexander Bezzubikov wrote: > 2017-07-25 16:53 GMT+03:00 Michael S. Tsirkin mailto:m...@redhat.com>>: >> On Tue, Jul 25, 2017 at 04:50:

Re: [Qemu-devel] [for-2.11 PATCH 10/26] spapr_iommu: pass object ownership to parent/owner

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 08:00:09PM +0200, Greg Kurz wrote: > From: Michael Roth > > TCE table objects attach themselves to an owner as a child > property. unref afterward to allow them to be finalized > when their owner is finalized. > > Signed-off-by: Michael Roth > Reviewed-by: Paolo Bonzini

Re: [Qemu-devel] [for-2.11 PATCH 05/26] spapr_iommu: convert TCE table object to realize()

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 07:59:06PM +0200, Greg Kurz wrote: > Signed-off-by: Greg Kurz Oh, wow, that was pretty messed up. Applied to ppc-for-2.11. > --- > hw/ppc/spapr_iommu.c |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr

Re: [Qemu-devel] [for-2.11 PATCH 06/26] spapr_pci: parent the MSI memory region to the PHB

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 07:59:18PM +0200, Greg Kurz wrote: > This memory region should be owned by the PHB. This ensures the PHB > cannot be finalized as long as the the region is guest visible, or > used by a CPU or a device. > > Signed-off-by: Greg Kurz Applied to ppc-for-2.11. > --- > hw/pp

Re: [Qemu-devel] [for-2.11 PATCH 08/26] spapr_drc: add unrealize method to physical DRC class

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 07:59:44PM +0200, Greg Kurz wrote: > When hot-unplugging a PHB, all its PCI DRC connectors get unrealized. This > patch adds an unrealize method to the physical DRC class, in order to undo > registrations performed in realize_physical(). > > Signed-off-by: Greg Kurz Appli

Re: [Qemu-devel] [for-2.11 PATCH 11/26] spapr_iommu: unregister vmstate at unrealize time

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 08:00:22PM +0200, Greg Kurz wrote: > Signed-off-by: Greg Kurz Applied to ppc-for-2.11. > --- > hw/ppc/spapr_iommu.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c > index 8ec4e7a40834..40a44c563824 100644 > ---

Re: [Qemu-devel] [for-2.11 PATCH 07/26] spapr_drc: fix realize and unrealize

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 07:59:31PM +0200, Greg Kurz wrote: > If object_property_add_alias() returns an error in realize(), we should > propagate it to the caller and certainly not unref the DRC. > > Same thing goes for unrealize(). Since object_property_del() is the last > call, we can even get ri

Re: [Qemu-devel] [PATCH v5 0/4] Convert to realize and fix error handling

2017-07-25 Thread Jason Wang
On 2017年07月26日 11:45, Mao Zhongyi wrote: Hi, Jason This was posted over 2 months ago with two R-Bs(Markus & Philippe), did it get merged or dropped? Thanks, Mao Hi: Want to merge but it does not apply cleanly on HEAD. Could you please rebase and post a V6? Thanks

Re: [Qemu-devel] [Qemu-ppc] [for-2.11 PATCH 05/26] spapr_iommu: convert TCE table object to realize()

2017-07-25 Thread Alexey Kardashevskiy
On 26/07/17 03:59, Greg Kurz wrote: > Signed-off-by: Greg Kurz Reviewed-by: Alexey Kardashevskiy > --- > hw/ppc/spapr_iommu.c |6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/ppc/spapr_iommu.c b/hw/ppc/spapr_iommu.c > index 740d42608b61..d4eca2a77225 100644

Re: [Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression

2017-07-25 Thread Philippe Mathieu-Daudé
Hi John, On 07/25/2017 07:55 PM, Programmingkid wrote: While compiling the mips64el-softmmu target I encountered these errors: CC hw/display/g364fb.o hw/core/loader-fit.c:105:41: error: expected expression *addr = fdt32_to_cpu(*(fdt32_t *)prop);

Re: [Qemu-devel] [Qemu-ppc] [for-2.11 PATCH 02/26] spapr_pci: use memory_region_add_subregion() with DMA windows

2017-07-25 Thread David Gibson
On Wed, Jul 26, 2017 at 01:33:04PM +1000, Alexey Kardashevskiy wrote: > On 26/07/17 03:58, Greg Kurz wrote: > > Passing a null priority to memory_region_add_subregion_overlap() is > > strictly equivalent to calling memory_region_add_subregion(). > > > > Signed-off-by: Greg Kurz > > Reviewed-by:

Re: [Qemu-devel] [for-2.11 PATCH 03/26] spapr_iommu: use g_strdup_printf() instead of snprintf()

2017-07-25 Thread David Gibson
On Wed, Jul 26, 2017 at 01:37:03PM +1000, Alexey Kardashevskiy wrote: > On 26/07/17 03:58, Greg Kurz wrote: > > Passing a stack allocated buffer of arbitrary length to snprintf() > > without checking the return value can cause the resultant strings > > to be silently truncated. > > The strings it

Re: [Qemu-devel] [Qemu-ppc] [for-2.11 PATCH 02/26] spapr_pci: use memory_region_add_subregion() with DMA windows

2017-07-25 Thread David Gibson
On Wed, Jul 26, 2017 at 01:33:04PM +1000, Alexey Kardashevskiy wrote: > On 26/07/17 03:58, Greg Kurz wrote: > > Passing a null priority to memory_region_add_subregion_overlap() is > > strictly equivalent to calling memory_region_add_subregion(). > > > > Signed-off-by: Greg Kurz > > Reviewed-by:

Re: [Qemu-devel] [for-2.11 PATCH 01/26] spapr: move spapr_create_phb() to core machine code

2017-07-25 Thread David Gibson
On Wed, Jul 26, 2017 at 01:32:41PM +1000, Alexey Kardashevskiy wrote: > On 26/07/17 03:58, Greg Kurz wrote: > > This function is only used when creating the default PHB. Let's rename > > it and move it to the core machine code for clarity. > > > > Signed-off-by: Greg Kurz > > --- > > hw/ppc/spap

Re: [Qemu-devel] [for-2.11 PATCH 04/26] spapr_drc: use g_strdup_printf() instead of snprintf()

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 07:58:53PM +0200, Greg Kurz wrote: > Passing a stack allocated buffer of arbitrary length to snprintf() > without checking the return value can cause the resultant strings > to be silently truncated. > > Signed-off-by: Greg Kurz Applied to ppc-for-2.11. > --- > hw/ppc/s

Re: [Qemu-devel] [PATCH qemu] Revert "elf-loader: warn about invalid endianness"

2017-07-25 Thread Alexey Kardashevskiy
On 21/07/17 18:05, Philippe Mathieu-Daudé wrote: > On 07/21/2017 04:30 AM, Alexey Kardashevskiy wrote: >> On 21/07/17 16:48, Philippe Mathieu-Daudé wrote: >>> I submitted this patch because I spent some time debugging while QEMU was >>> failing silently using a MIPS kernel image which used to work,

Re: [Qemu-devel] [PATCH v5 0/4] Convert to realize and fix error handling

2017-07-25 Thread Mao Zhongyi
Hi, Jason This was posted over 2 months ago with two R-Bs(Markus & Philippe), did it get merged or dropped? Thanks, Mao On 05/23/2017 12:04 PM, Mao Zhongyi wrote: v5: * Patch 1 removed the dead error handling that was previously missing. * Patch 2 and 3 has not changed. * Patch 4 is a new patc

Re: [Qemu-devel] [PATCH v12 5/8] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-07-25 Thread Wei Wang
On 07/23/2017 09:45 AM, Michael S. Tsirkin wrote: On Fri, Jul 14, 2017 at 03:12:43PM +0800, Wei Wang wrote: On 07/14/2017 04:19 AM, Michael S. Tsirkin wrote: On Thu, Jul 13, 2017 at 03:42:35PM +0800, Wei Wang wrote: On 07/12/2017 09:56 PM, Michael S. Tsirkin wrote: So the way I see it, there

Re: [Qemu-devel] [PATCH v6 8/8] tpm: Added support for TPM emulator

2017-07-25 Thread Amarnath Valluri
On Tue, 2017-07-25 at 20:18 -0400, Stefan Berger wrote: > On 07/18/2017 04:49 AM, Amarnath Valluri wrote: > > diff --git a/hw/tpm/Makefile.objs b/hw/tpm/Makefile.objs > > index 64cecc3..41f0b7a 100644 > > --- a/hw/tpm/Makefile.objs > > +++ b/hw/tpm/Makefile.objs > > @@ -1,2 +1,3 @@ > > common-obj

Re: [Qemu-devel] [for-2.11 PATCH 00/26] spapr: add support for PHB hotplug

2017-07-25 Thread Alexey Kardashevskiy
On 26/07/17 03:57, Greg Kurz wrote: > This series is based on patches from Michel Roth posted in 2015: > > https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg04246.html > > It addresses comments made during the RFC review, and also provides a bunch > of preliminary cleanup/fix patches. Sinc

Re: [Qemu-devel] [for-2.11 PATCH 03/26] spapr_iommu: use g_strdup_printf() instead of snprintf()

2017-07-25 Thread Alexey Kardashevskiy
On 26/07/17 03:58, Greg Kurz wrote: > Passing a stack allocated buffer of arbitrary length to snprintf() > without checking the return value can cause the resultant strings > to be silently truncated. The strings it is touching cannot be silently truncated as "tce-iommu-" are shorter than

Re: [Qemu-devel] [Qemu-ppc] [for-2.11 PATCH 02/26] spapr_pci: use memory_region_add_subregion() with DMA windows

2017-07-25 Thread Alexey Kardashevskiy
On 26/07/17 03:58, Greg Kurz wrote: > Passing a null priority to memory_region_add_subregion_overlap() is > strictly equivalent to calling memory_region_add_subregion(). > > Signed-off-by: Greg Kurz Reviewed-by: Alexey Kardashevskiy > --- > hw/ppc/spapr_pci.c |4 ++-- > 1 file changed, 2

Re: [Qemu-devel] [for-2.11 PATCH 01/26] spapr: move spapr_create_phb() to core machine code

2017-07-25 Thread Alexey Kardashevskiy
On 26/07/17 03:58, Greg Kurz wrote: > This function is only used when creating the default PHB. Let's rename > it and move it to the core machine code for clarity. > > Signed-off-by: Greg Kurz > --- > hw/ppc/spapr.c | 13 - > hw/ppc/spapr_pci.c | 11

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Philippe Mathieu-Daudé
As noticed by Michael Roth the ./configure entry for qemu-ga is missing the $(EXESUF) on purpose (see fafcaf1d). Patch dropped for 2.10 On 07/24/2017 10:15 PM, Philippe Mathieu-Daudé wrote: Reported-by: Sameeh Jubran Signed-off-by: Philippe Mathieu-Daudé --- original report from Sameeh Jubra

Re: [Qemu-devel] [PATCH 1/2] s390x/css: check ccw address validity

2017-07-25 Thread Dong Jia Shi
* Halil Pasic [2017-07-26 00:44:41 +0200]: > According to the PoP channel command words (CCW) must be doubleword > aligned and 31 bit addressable for format 1 and 24 bit addressable for > format 0 CCWs. > > If the channel subsystem encounters ccw address which does not satisfy > this alignment r

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Philippe Mathieu-Daudé
On 07/25/2017 11:56 PM, Michael Roth wrote: Quoting Michael Roth (2017-07-25 21:53:41) Quoting Philippe Mathieu-Daudé (2017-07-25 20:45:31) [...] That change was done explicitly via fafcaf1d so that `make qemu-ga` and `make` without --disable-tools specified to configure will generate the MSI

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Michael Roth
Quoting Michael Roth (2017-07-25 21:56:14) > Quoting Michael Roth (2017-07-25 21:53:41) > > Quoting Philippe Mathieu-Daudé (2017-07-25 20:45:31) > > > Hi Michael, > > > > > > On 07/25/2017 08:03 PM, Michael Roth wrote: > > > > Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30) > > > >> Reported-

Re: [Qemu-devel] [PATCH 2/2] s390x/css: fix bits must be zero check for TIC

2017-07-25 Thread Dong Jia Shi
Hello Halil, * Halil Pasic [2017-07-26 00:44:42 +0200]: > According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must > contain zeros. Bits 0-3 are already covered by cmd_code validity > checking, and bit 32 is covered by the CCW address checking. > > Bits 8-31 correspond to CCW1.

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Michael Roth
Quoting Michael Roth (2017-07-25 21:53:41) > Quoting Philippe Mathieu-Daudé (2017-07-25 20:45:31) > > Hi Michael, > > > > On 07/25/2017 08:03 PM, Michael Roth wrote: > > > Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30) > > >> Reported-by: Sameeh Jubran > > >> Signed-off-by: Philippe Mathieu

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Michael Roth
Quoting Philippe Mathieu-Daudé (2017-07-25 20:45:31) > Hi Michael, > > On 07/25/2017 08:03 PM, Michael Roth wrote: > > Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30) > >> Reported-by: Sameeh Jubran > >> Signed-off-by: Philippe Mathieu-Daudé > >> --- > >> original report from Sameeh Jubran:

Re: [Qemu-devel] [PATCH v12 6/8] mm: support reporting free page blocks

2017-07-25 Thread Wei Wang
On 07/25/2017 10:53 PM, Michal Hocko wrote: On Tue 25-07-17 14:47:16, Wang, Wei W wrote: On Tuesday, July 25, 2017 8:42 PM, hal Hocko wrote: On Tue 25-07-17 19:56:24, Wei Wang wrote: On 07/25/2017 07:25 PM, Michal Hocko wrote: On Tue 25-07-17 17:32:00, Wei Wang wrote: On 07/24/2017 05:00 PM,

Re: [Qemu-devel] [RFC PATCH 14/26] ppc/xive: add MMIO handlers to the XIVE interrupt presenter model

2017-07-25 Thread David Gibson
On Tue, Jul 25, 2017 at 05:01:48PM +0200, Cédric Le Goater wrote: > On 07/25/2017 03:21 PM, David Gibson wrote: > > On Tue, Jul 25, 2017 at 11:08:46AM +0200, Cédric Le Goater wrote: > >> On 07/25/2017 06:20 AM, David Gibson wrote: > >>> On Mon, Jul 24, 2017 at 04:44:00PM +0200, Cédric Le Goater wro

Re: [Qemu-devel] [PATCH v8 3/3] migration: add bitmap for received page

2017-07-25 Thread Peter Xu
On Thu, Jul 20, 2017 at 09:52:34AM +0300, Alexey Perevalov wrote: > This patch adds ability to track down already received > pages, it's necessary for calculation vCPU block time in > postcopy migration feature, maybe for restore after > postcopy migration failure. > Also it's necessary to solve sh

Re: [Qemu-devel] [PATCH 1/5] Makefile: clean: Clean exe files

2017-07-25 Thread Philippe Mathieu-Daudé
I purposed another fix for Sameeh's issue, see: http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg07597.html On 07/25/2017 08:10 PM, Michael Roth wrote: Quoting Peter Maydell (2017-07-23 15:03:56) On 5 July 2017 at 08:54, Sameeh Jubran wrote: From: Sameeh Jubran Clean exe files suc

[Qemu-devel] [PATCH for-2.10] qemu-img: Sort sub-command names in --help

2017-07-25 Thread Eric Blake
'amend' was the only sub-command not listed alphabetically; hoist it earlier, and separate the @end table block to make it easier to copy-and-paste the addition of future sub-commands. Signed-off-by: Eric Blake --- qemu-img-cmds.hx | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Philippe Mathieu-Daudé
Hi Michael, On 07/25/2017 08:03 PM, Michael Roth wrote: Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30) Reported-by: Sameeh Jubran Signed-off-by: Philippe Mathieu-Daudé --- original report from Sameeh Jubran: http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg00906.html AFAICT

[Qemu-devel] [PATCH 2/2] vhost-user-blk: introduce a vhost-user-blk sample application

2017-07-25 Thread Changpeng Liu
This commit introcudes a vhost-user-blk backend device, it uses UNIX domain socket to communicate with Qemu. The vhost-user-blk sample application should be used with Qemu vhost-user-blk-pci device. To use it, complie with: make vhost-user-blk and start like this: vhost-user-blk -b /dev/sdb -s /p

[Qemu-devel] [PATCH 1/2] vhost-user-blk: introduce a new vhost-user-blk host device

2017-07-25 Thread Changpeng Liu
This commit introduces a vhost-user device for block, it uses a chardev to connect to the backend, Same with virito_blk, Guest OS still uses the virtio_blk frontend driver. To use it, start Qemu with command line like this: qemu-system-x86_64 \ -chardev socket,id=char0,path=/path/vhost.socket

[Qemu-devel] [PATCH 0/2] Introduce a new vhost-user-blk device and sample application

2017-07-25 Thread Changpeng Liu
Since vhost-user-scsi device has been part of Qemu, many users are still using old virtio_blk device in Guest OS, compared with vhost-user-scsi, vhost-user-blk can get better performance, because eliminate one SCSI_MOD kernel module. This patch provides another option for uses to implement their ow

Re: [Qemu-devel] [PATCH 6/8] tcg/tci: disable MTTCG if TCI is enabled

2017-07-25 Thread Philippe Mathieu-Daudé
Hi Peter, I think this patch belongs to 2.10, as there is no time to fix TCI + MTTCG. Should I RESEND it alone with "for 2.10" subject? One other option might be disable TCI if MTTCG enabled, but there is no ./configure option for MTTCG while there is for TCI. Regards, Phil. On 06/28/2017

Re: [Qemu-devel] [PATCH 2/4] rtc-test: introduce more update tests

2017-07-25 Thread Philippe Mathieu-Daudé
On 07/25/2017 10:48 AM, Paolo Bonzini wrote: Test divider reset and UIP behavior. Signed-off-by: Paolo Bonzini --- tests/rtc-test.c | 82 +++- 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/tests/rtc-test.c b/tests/rtc-test.c

Re: [Qemu-devel] [PATCH V3] rtc: fix a infinite loop in windowsvmstartup

2017-07-25 Thread peng.hao2
>On 25/07/2017 11:29, peng.h...@zte.com.cn wrote: >>>On 25/07/2017 06:14, peng.h...@zte.com.cn wrote: >> > On 24/07/2017 20:35, Peng Hao wrote: >> When a windows vm starts, periodic timer of rtc will stop several times. >> windows kernel will check whether REG_A_UIP i

Re: [Qemu-devel] Improving QMP test coverage

2017-07-25 Thread Cleber Rosa
On 07/24/2017 02:56 AM, Markus Armbruster wrote: > Test code language is orthogonal to verification method (with code > vs. with diff). Except verifying with shell code would be obviously > nuts[*]. > > The existing iotests written in Python verify with code, and the ones > written in shell veri

Re: [Qemu-devel] [PATCH v6 8/8] tpm: Added support for TPM emulator

2017-07-25 Thread Stefan Berger
On 07/18/2017 04:49 AM, Amarnath Valluri wrote: diff --git a/hw/tpm/Makefile.objs b/hw/tpm/Makefile.objs index 64cecc3..41f0b7a 100644 --- a/hw/tpm/Makefile.objs +++ b/hw/tpm/Makefile.objs @@ -1,2 +1,3 @@ common-obj-$(CONFIG_TPM_TIS) += tpm_tis.o common-obj-$(CONFIG_TPM_PASSTHROUGH) += tpm_pa

Re: [Qemu-devel] [PATCH 3/5] qga-win: Add serial listener service

2017-07-25 Thread Michael Roth
Quoting Sameeh Jubran (2017-07-05 02:54:09) > From: Sameeh Jubran > > Currently on Windows whenever the qemu-ga's service doesn't find the > virtio-serial > it terminates. This commit addresses this issue by adding a new listener > service > which registers for notifications of the virtio-port-

Re: [Qemu-devel] [PATCH] configure: fix qemu-ga missing '.exe' extension on windows

2017-07-25 Thread Michael Roth
Quoting Philippe Mathieu-Daudé (2017-07-24 20:15:30) > Reported-by: Sameeh Jubran > Signed-off-by: Philippe Mathieu-Daudé > --- > original report from Sameeh Jubran: > http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg00906.html AFAICT the issue discussed in the context of that patch is

Re: [Qemu-devel] [PATCH 2/5] qga-win: service-win32: Add start_service and stop_service functions

2017-07-25 Thread Michael Roth
Quoting Sameeh Jubran (2017-07-05 02:54:08) > From: Sameeh Jubran > > This commits adds two functions which handle service's start and stop > process in Windows. > > Signed-off-by: Sameeh Jubran > --- > qga/service-win32.c | 52 > qga/servic

Re: [Qemu-devel] [PATCH 1/5] Makefile: clean: Clean exe files

2017-07-25 Thread Michael Roth
Quoting Peter Maydell (2017-07-23 15:03:56) > On 5 July 2017 at 08:54, Sameeh Jubran wrote: > > From: Sameeh Jubran > > > > Clean exe files such as qemu-ga.exe > > > > Signed-off-by: Sameeh Jubran > > --- > > Makefile | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Makefile b/Mak

Re: [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report())

2017-07-25 Thread Alistair Francis
On Tue, Jul 25, 2017 at 4:24 PM, Alistair Francis wrote: > On Tue, Jul 25, 2017 at 12:08 PM, Eduardo Habkost wrote: >> On Mon, Jul 24, 2017 at 09:30:06AM +0200, Paolo Bonzini wrote: >>> On 24/07/2017 08:30, Markus Armbruster wrote: >>> > Markus Armbruster writes: >>> > >>> >> Kevin Wolf writes:

Re: [Qemu-devel] Slow tests on "make check" (was Re: [PULL 6/9] Convert error_report() to warn_report())

2017-07-25 Thread Alistair Francis
On Tue, Jul 25, 2017 at 12:08 PM, Eduardo Habkost wrote: > On Mon, Jul 24, 2017 at 09:30:06AM +0200, Paolo Bonzini wrote: >> On 24/07/2017 08:30, Markus Armbruster wrote: >> > Markus Armbruster writes: >> > >> >> Kevin Wolf writes: >> >> >> >>> Am 13.07.2017 um 15:27 hat Markus Armbruster geschr

[Qemu-devel] hw/core/loader-fit.c:105:41: error: expected expression

2017-07-25 Thread Programmingkid
While compiling the mips64el-softmmu target I encountered these errors: CC hw/display/g364fb.o hw/core/loader-fit.c:105:41: error: expected expression *addr = fdt32_to_cpu(*(fdt32_t *)prop); ^ hw/core/loader-fit.c:105:32: error: use of undecla

[Qemu-devel] [PATCH 0/2] ccw interpretation AR compliance improvements

2017-07-25 Thread Halil Pasic
There were some missing checks. There might be some more missing. For details, see the individual patches. Regarding testing: did not do much more than a simple smoke test with virtio-ccw. Halil Pasic (2): s390x/css: check ccw address validity s390x/css: fix bits must be zero check for TIC

[Qemu-devel] [PATCH 1/2] s390x/css: check ccw address validity

2017-07-25 Thread Halil Pasic
According to the PoP channel command words (CCW) must be doubleword aligned and 31 bit addressable for format 1 and 24 bit addressable for format 0 CCWs. If the channel subsystem encounters ccw address which does not satisfy this alignment requirement a program-check condition is recognised. The

[Qemu-devel] [PATCH 2/2] s390x/css: fix bits must be zero check for TIC

2017-07-25 Thread Halil Pasic
According to the PoP bit positions 0-3 and 8-32 of the format-1 CCW must contain zeros. Bits 0-3 are already covered by cmd_code validity checking, and bit 32 is covered by the CCW address checking. Bits 8-31 correspond to CCW1.flags and CCW1.count. Currently we only check for the absence of cer

Re: [Qemu-devel] [SeaBIOS] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

2017-07-25 Thread Kevin O'Connor
On Tue, Jul 25, 2017 at 07:10:21PM +0200, Paolo Bonzini wrote: > On 25/07/2017 18:23, Paolo Bonzini wrote: > > On 25/07/2017 18:14, Laszlo Ersek wrote: > >> "No regressions became apparent in tests with a range of Windows > >>(XP-10)" > >> > >> In theory, w2k falls within that range. > > > >

Re: [Qemu-devel] [PATCH V5 10/10] block/qcow2: add compress info to image specific info

2017-07-25 Thread Eric Blake
On 07/25/2017 09:41 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/qcow2.c| 7 +++ > qapi/block-core.json | 6 +- > 2 files changed, 12 insertions(+), 1 deletion(-) > > +++ b/qapi/block-core.json > @@ -68,6 +68,9 @@ > # @encrypt: details about encryption par

Re: [Qemu-devel] Torn read/write possible on aarch64/x86-64 MTTCG?

2017-07-25 Thread Andrew Baumann via Qemu-devel
> From: Richard Henderson [mailto:rth7...@gmail.com] On Behalf Of Richard > Henderson > Sent: Monday, 24 July 2017 15:03 > > On 07/24/2017 02:23 PM, Emilio G. Cota wrote: > > (Adding some Cc's) > > > > On Mon, Jul 24, 2017 at 19:05:33 +, Andrew Baumann via Qemu-devel > wrote: > >> Hi all, > >>

Re: [Qemu-devel] [PATCH V5 09/10] block/qcow2: add lzo compress format

2017-07-25 Thread Eric Blake
On 07/25/2017 09:41 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > block/qcow2-cluster.c | 15 +++ > block/qcow2.c | 25 - > configure | 2 +- > docs/interop/qcow2.txt | 2 ++ > qapi/block-core.json | 15 ---

Re: [Qemu-devel] [PATCH 1/2] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented

2017-07-25 Thread Eric Blake
On 07/25/2017 04:28 PM, John Snow wrote: > > > On 07/21/2017 02:32 PM, Eric Blake wrote: >> We've been documenting the value in bytes since its introduction >> in commit b9a9b3a4 (v1.3), where it was actually reported in bytes. >> >> Commit e4654d2 (v2.0) then removed things from block/qapi.c, in

Re: [Qemu-devel] [PATCH V5 04/10] qemu-img: add documentation for compress settings

2017-07-25 Thread Eric Blake
On 07/25/2017 09:41 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > qemu-img.texi | 26 ++ > 1 file changed, 26 insertions(+) > > diff --git a/qemu-img.texi b/qemu-img.texi > index 72dabd6..3612c59 100644 > --- a/qemu-img.texi > +++ b/qemu-img.texi > @@ -676

Re: [Qemu-devel] Regarding Tracing of machine instructions in qemu

2017-07-25 Thread Peter Maydell
On 25 July 2017 at 21:38, Shantanu Agarwal wrote: > I was wondering how to gather the machine instructions that were issued to > a system through qemu. I tried using the simple backend tracing. But the > results were not satisfactory. So do I have to understand the whole code of > qemu and make ch

Re: [Qemu-devel] Commit 77af8a2b95b79699de650965d5228772743efe84 breaks Windows 2000 support

2017-07-25 Thread Phil Dennis-Jordan
Thanks for this, Paolo. Very interesting idea. I couldn't get things working initially, but with a few fixups on the SeaBIOS side I can boot both legacy and modern OSes. See comments inline below for details on changes required. Successfully booted (only a brief test): - Windows 2000 - Windows XP

Re: [Qemu-devel] [PATCH 1/2] dirty-bitmap: Report BlockDirtyInfo.count in bytes, as documented

2017-07-25 Thread John Snow
On 07/21/2017 02:32 PM, Eric Blake wrote: We've been documenting the value in bytes since its introduction in commit b9a9b3a4 (v1.3), where it was actually reported in bytes. Commit e4654d2 (v2.0) then removed things from block/qapi.c, in preparation for a rewrite to a list of dirty sectors in

Re: [Qemu-devel] [PATCH V5 02/10] qapi/block-core: add Qcow2Compress parameters

2017-07-25 Thread Eric Blake
On 07/25/2017 09:41 AM, Peter Lieven wrote: > Signed-off-by: Peter Lieven > --- > qapi/block-core.json | 40 > 1 file changed, 40 insertions(+) > > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 833c602..f652206 100644 > --- a/qapi/block

Re: [Qemu-devel] [PATCH V5 03/10] block/qcow2: parse compress create options

2017-07-25 Thread Eric Blake
On 07/25/2017 09:41 AM, Peter Lieven wrote: > this adds parsing and validation for the compress create > options. They are only validated but not yet used. > > Signed-off-by: Peter Lieven > --- > block/qcow2.c | 86 > +-- > include/block/b

[Qemu-devel] [PATCH v3 11/12] tests/libqtest: Clean up how we read the QMP greeting

2017-07-25 Thread Eric Blake
From: Markus Armbruster qtest_init() still uses the qtest_qmp_discard_response(s, "") hack to receive the greeting, even though we have qtest_qmp_receive() since commit 66e0c7b. Put it to use. Bonus: gets rid of an empty format string. A step towards compile-time format string checking without

Re: [Qemu-devel] [PATCH v5 6/6] qemu.py: include qemu command line and output on launch error

2017-07-25 Thread Eduardo Habkost
On Tue, Jul 25, 2017 at 07:10:14PM +0200, Amador Pahim wrote: > When launching a VM, if an exception happens and the VM is not > initiated, it is useful to see the qemu command line that was executed > and the output of that command. > > Signed-off-by: Amador Pahim > --- > scripts/qemu.py | 15 +

[Qemu-devel] [PATCH v3 10/12] tests: Clean up wait for event

2017-07-25 Thread Eric Blake
From: Markus Armbruster We still use hacks like qmp("") to wait for an event, even though we have qmp_eventwait() since commit 8fe941f, and qmp_eventwait_ref() since commit 7ffe312. Both commits neglected to convert all the existing hacks. Make up what they missed. Bonus: gets rid of empty for

[Qemu-devel] [PATCH v3 12/12] tests/libqtest: Enable compile-time format string checking

2017-07-25 Thread Eric Blake
From: Markus Armbruster qtest_qmp() & friends pass their format string and variable arguments to qobject_from_jsonv(). Unlike qobject_from_jsonv(), they aren't decorated with GCC_FMT_ATTR(). Fix that to get compile-time format string checking. Signed-off-by: Markus Armbruster Message-Id: <150

[Qemu-devel] [PATCH v3 03/12] qtest: Document calling conventions

2017-07-25 Thread Eric Blake
We have two flavors of vararg usage in qtest; make it clear that qmp() has different semantics than hmp(), and let the compiler enforce that hmp() is used correctly. However, qmp() (and friends) only accept a subset of printf flags look-alikes (namely, those that our JSON parser understands), and w

[Qemu-devel] [PATCH v3 07/12] qtest: Add a new helper qmp_cmd() and friends

2017-07-25 Thread Eric Blake
When interpolating a QMP command from the testsuite, we have a very common pattern that the command to be executed is a string constant, while the arguments may need to be crafted from qobject_from_jsonf() or even by hand. Make it easier to craft the arguments without having to save all the interp

[Qemu-devel] [PATCH v3 09/12] tests/libqos/pci: Clean up string interpolation into QMP input

2017-07-25 Thread Eric Blake
From: Markus Armbruster Leaving interpolation into JSON to qmp() is more robust than building QMP input manually, as explained in the commit before previous. The case in qpci_plug_device_test() is a bit complicated: it interpolates several JSON object members, not just a value. Clean it up by p

[Qemu-devel] Regarding Tracing of machine instructions in qemu

2017-07-25 Thread Shantanu Agarwal
Sir/Mam, I was wondering how to gather the machine instructions that were issued to a system through qemu. I tried using the simple backend tracing. But the results were not satisfactory. So do I have to understand the whole code of qemu and make changes to it. Or is there a provision to do so? -

[Qemu-devel] [PATCH v3 06/12] tests/libqos/usb: Clean up string interpolation into QMP input

2017-07-25 Thread Eric Blake
From: Markus Armbruster Leaving interpolation into JSON to qmp() is more robust than building QMP input manually, as explained in the previous commit. The case in usb_test_hotplug() is slightly more complicated: it interpolates *into* JSON values. Clean it up by building the values separately,

[Qemu-devel] [PATCH v3 01/12] qobject: Accept "%"PRId64 in qobject_from_jsonf()

2017-07-25 Thread Eric Blake
Commit 1792d7d0 was written because PRId64 expands to non-portable crap for some libc, and we had testsuite failures on Mac OS as a result. This in turn makes it difficult to rely on the obvious conversions of 64-bit values into JSON, requiring things such as casting int64_t to long long so we can

[Qemu-devel] [PATCH v3 04/12] tests: Pass literal format strings directly to qmp_FOO()

2017-07-25 Thread Eric Blake
From: Markus Armbruster The qmp_FOO() take a printf-like format string. In a few places, we assign a string literal to a variable and pass that instead of simply passing the literal. Clean that up. Bonus: gets rid of non-literal format strings. A step towards compile-time format string checki

[Qemu-devel] [PATCH v3 05/12] tests: Clean up string interpolation into QMP input (simple cases)

2017-07-25 Thread Eric Blake
From: Markus Armbruster When you build QMP input manually like this cmd = g_strdup_printf("{ 'execute': 'migrate'," "'arguments': { 'uri': '%s' } }", uri); rsp = qmp(cmd); g_free(cmd); you're responsible for escaping the interpolat

[Qemu-devel] [PATCH v3 08/12] qtests: convert tests to use qmp_cmd

2017-07-25 Thread Eric Blake
Now that we have the qmp_cmd() helper, we can further simplify some of the tests by using it. Signed-off-by: Eric Blake --- tests/device-introspect-test.c | 3 +-- tests/ide-test.c | 2 +- tests/libqos/libqos.c | 5 +++-- tests/libqos/pci-pc.c | 4 ++-- tests/

[Qemu-devel] [PATCH v3 00/12] Clean up around qmp() and hmp()

2017-07-25 Thread Eric Blake
I've merged the best aspects of Markus' and my previous posts on the topic. While it mostly touches test code (and thus could be considered 2.10 material at a stretch), it's a big enough series that it's probably safer to leave for 2.11. If you like the idea of qmp_cmd() taking a command name and

  1   2   3   4   5   >