Re: [Qemu-devel] [PATCH] target/ppc: Fix return value in tcg radix mmu fault handler

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] target/ppc: Fix return value in tcg radix mmu fault handler Message-id: 20170614064452.23167-1-

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-13 Thread Peter Xu
On Wed, Jun 14, 2017 at 09:39:53AM +0300, Alexey Perevalov wrote: > On 06/14/2017 08:12 AM, Peter Xu wrote: > >On Tue, Jun 13, 2017 at 12:36:33PM +0300, Alexey Perevalov wrote: > >>This patch adds ability to track down already copied > >>pages, it's necessary for calculation vCPU block time in > >>

[Qemu-devel] [Bug 1047576] Re: qemu unittest emulator failure on latest git master

2017-06-13 Thread Thomas Huth
Thanks for checking again! ** Changed in: qemu Status: Incomplete => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1047576 Title: qemu unittest emulator failure on latest git m

Re: [Qemu-devel] [PATCH qemu v8 0/2] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-06-13 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH qemu v8 0/2] memory/iommu: QOM'fy IOMMU MemoryRegion Message-id: 20170614063607.47863-1-...@ozlabs.ru Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 t

Re: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

2017-06-13 Thread Fam Zheng
On Tue, 06/13 07:59, no-re...@patchew.org wrote: > In file included from /tmp/qemu-test/src/hw/net/vmxnet3.c:30: > /tmp/qemu-test/src/include/migration/register.h:18: error: redefinition of > typedef ‘LoadStateHandler’ > /tmp/qemu-test/src/include/migration/vmstate.h:32: note: previous declaration

Re: [Qemu-devel] [PATCH qemu v8 0/2] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH qemu v8 0/2] memory/iommu: QOM'fy IOMMU MemoryRegion Message-id: 20170614063607.47863-1-...@ozla

Re: [Qemu-devel] [PATCH v7 0/9] qemu-img: add measure sub-command

2017-06-13 Thread Fam Zheng
On Tue, 06/13 07:24, no-re...@patchew.org wrote: > In file included from /tmp/qemu-test/src/hw/net/vmxnet3.c:30: > /tmp/qemu-test/src/include/migration/register.h:18: error: redefinition of > typedef ‘LoadStateHandler’ > /tmp/qemu-test/src/include/migration/vmstate.h:32: note: previous declaration

Re: [Qemu-devel] [PATCH v2] Add manpage for QEMU Backup Tool

2017-06-13 Thread Fam Zheng
On Tue, 06/13 08:27, no-re...@patchew.org wrote: > In file included from /tmp/qemu-test/src/hw/net/vmxnet3.c:30: > /tmp/qemu-test/src/include/migration/register.h:18: error: redefinition of > typedef ‘LoadStateHandler’ > /tmp/qemu-test/src/include/migration/vmstate.h:32: note: previous declaration

Re: [Qemu-devel] [PATCH v21 00/30] qcow2: persistent dirty bitmaps

2017-06-13 Thread Fam Zheng
On Tue, 06/13 18:08, Max Reitz wrote: > On 2017-06-13 17:03, Vladimir Sementsov-Ogievskiy wrote: > > Looks weird. > > I see the same reply to other series, so it very likely isn't your fault. It's on master, so all patches cannot compile. Please ignore this error for now. Fam

Re: [Qemu-devel] [PATCH] fix: avoid infinite loop when blockjob encountering failure

2017-06-13 Thread Fam Zheng
On Tue, 06/13 23:33, no-re...@patchew.org wrote: > In file included from /tmp/qemu-test/src/hw/net/vmxnet3.c:30: > /tmp/qemu-test/src/include/migration/register.h:18: error: redefinition of > typedef ‘LoadStateHandler’ > /tmp/qemu-test/src/include/migration/vmstate.h:32: note: previous declaration

[Qemu-devel] [PATCH] target/ppc: Fix return value in tcg radix mmu fault handler

2017-06-13 Thread Suraj Jitindar Singh
The mmu fault handler should return 0 if it was able to successfully handle the fault and a positive value otherwise. Currently the tcg radix mmu fault handler will return 1 after successfully handling a fault in virtual mode. This is incorrect so fix it so that it returns 0 in this case. The han

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-13 Thread Alexey Perevalov
On 06/14/2017 08:12 AM, Peter Xu wrote: On Tue, Jun 13, 2017 at 12:36:33PM +0300, Alexey Perevalov wrote: This patch adds ability to track down already copied pages, it's necessary for calculation vCPU block time in postcopy migration feature, maybe for restore after postcopy migration failure.

Re: [Qemu-devel] [PATCH v2] migration: Remove unneeded includes

2017-06-13 Thread Peter Xu
On Tue, Jun 13, 2017 at 11:52:51AM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > include/migration/colo.h | 3 --- > include/migration/misc.h | 2 ++ > migration/block.c | 6 -- > migration/colo-failover.c | 2 ++ > migration/colo.c | 2 -- > migration/

[Qemu-devel] [PATCH qemu v8 0/2] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-06-13 Thread Alexey Kardashevskiy
ranch 'remotes/pmaydell/tags/pull-target-arm-20170613' into staging". Please comment. Thanks. Changes: v8: * now 2 patches Alexey Kardashevskiy (2): memory/iommu: QOM'fy IOMMU MemoryRegion memory/iommu: introduce IOMMUMemoryRegionClass hw/i386/amd_iommu.h

Re: [Qemu-devel] [PATCH] usb: xhci: fix info leak when writing event to the guest

2017-06-13 Thread Li Qiang
2017-06-14 14:30 GMT+08:00 Gerd Hoffmann : > On Tue, 2017-06-13 at 20:39 -0700, Li Qiang wrote: > > From: Li Qiang > > > > In 'xhci_write_event' function, the 'ev_trb' is not full initialized. > > This will lead an info leak issue. This patch avoid this. > > I don't think so. Note that only the

[Qemu-devel] [PATCH qemu v8 2/2] memory/iommu: introduce IOMMUMemoryRegionClass

2017-06-13 Thread Alexey Kardashevskiy
This finishes QOM'fication of IOMMUMemoryRegion by introducing a IOMMUMemoryRegionClass. This also provides a fastpath analog for IOMMU_MEMORY_REGION_GET_CLASS(). Signed-off-by: Alexey Kardashevskiy --- hw/i386/amd_iommu.h | 3 --- include/exec/memory.h | 45 ++

[Qemu-devel] [PATCH qemu v8 1/2] memory/iommu: QOM'fy IOMMU MemoryRegion

2017-06-13 Thread Alexey Kardashevskiy
This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion as a parent. This moves IOMMU-related fields from MR to IOMMU MR. However to avoid dymanic QOM casting in fast path (address_space_translate, etc), this adds an @is_iommu boolean flag to MR and provides new helper to do simple cas

Re: [Qemu-devel] [PATCH] fix: avoid infinite loop when blockjob encountering failure

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] fix: avoid infinite loop when blockjob encountering failure Type: series Message-id: 1497421359

Re: [Qemu-devel] [PATCH] usb: xhci: fix info leak when writing event to the guest

2017-06-13 Thread Gerd Hoffmann
On Tue, 2017-06-13 at 20:39 -0700, Li Qiang wrote: > From: Li Qiang > > In 'xhci_write_event' function, the 'ev_trb' is not full initialized. > This will lead an info leak issue. This patch avoid this. I don't think so. Note that only the first 16 bytes (TRB_SIZE) and not the whole struct is co

[Qemu-devel] [PATCH] fix: avoid infinite loop when blockjob encountering failure

2017-06-13 Thread sochin.jiang
From: "sochin.jiang" img_commit could fall into infinite loop if it's blockjob fail encountering any I/O error. Try to fix it. Signed-off-by: sochin.jiang --- qemu-img.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qemu-img.c b/qemu-img.c index 0ad698d..6ba565d 1006

Re: [Qemu-devel] [PATCH] usb: xhci: fix info leak when writing event to the guest

2017-06-13 Thread Gerd Hoffmann
Hi, > > CC      hw/timer/a9gtimer.o > > In file included from /tmp/qemu-test/src/hw/net/vmxnet3.c:30: > > /tmp/qemu-test/src/include/migration/register.h:18: error: > > redefinition of typedef ‘LoadStateHandler’ > > /tmp/qemu-test/src/include/migration/vmstate.h:32: note: previous > > declaratio

Re: [Qemu-devel] [PATCH RFC v19 09/13] target-avr: adding instruction decoder

2017-06-13 Thread Michael Rolnik
we had this discussion previously. 1. I am not sure my generator will run on every machine as it requires some tools e.g. xsltproc 2. once AVR finds its way into master, I will try to generate files during the build. On Wed, Jun 14, 2017 at 8:14 AM, Thomas Huth wrote: > On 13.06.2017 22:29, Mich

[Qemu-devel] [Bug 1047576] Re: qemu unittest emulator failure on latest git master

2017-06-13 Thread Lucas Meneghel Rodrigues
This doesn't reproduce with the latest version of QEMU, you may close it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1047576 Title: qemu unittest emulator failure on latest git master Status in

Re: [Qemu-devel] [PULL 00/10] TCG queued patches

2017-06-13 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL 00/10] TCG queued patches Type: series Message-id: 20170614052311.13785-1-...@twiddle.net === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $B

Re: [Qemu-devel] [PULL 00/10] TCG queued patches

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PULL 00/10] TCG queued patches Type: series Message-id: 20170614052311.13785-1-...@twiddle.net === TES

[Qemu-devel] [PULL 08/10] tcg/arm: Use ldr (literal) for goto_tb

2017-06-13 Thread Richard Henderson
The new placement of the TB means that we can use one insn to load the goto_tb destination directly from the TB. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 23 ++- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/tcg/arm/tcg-target.inc.c b/t

[Qemu-devel] [PULL 06/10] tcg/arm: Remove limit on code buffer size

2017-06-13 Thread Richard Henderson
Since we're no longer using a direct branch, we have no limit on the branch distance. Signed-off-by: Richard Henderson --- translate-all.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/translate-all.c b/translate-all.c index 46c5592..d4f364d 100644 --- a/translate-all.c +++ b/translate-al

[Qemu-devel] [PULL 05/10] tcg/arm: Use indirect branch for goto_tb

2017-06-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/exec/exec-all.h | 5 + tcg/arm/tcg-target.inc.c | 17 ++--- 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 87ae10b..724ec73 100644 --- a/include/exec/exec-all.h

[Qemu-devel] [PULL 07/10] tcg/arm: Try pc-relative addresses for movi

2017-06-13 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.inc.c | 40 +++- 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/tcg/arm/tcg-target.inc.c b/tcg/arm/tcg-target.inc.c index fce382f..42370e5 100644 --- a/tcg/arm/tcg-target.inc.c +++ b/tcg/a

[Qemu-devel] [PULL 04/10] tcg/aarch64: Use ADR in tcg_out_movi

2017-06-13 Thread Richard Henderson
The new placement of the TB means that we can use one insn to load the return value for exit_tb returning the TB pointer. Tested-by: Emilio G. Cota Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.inc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tcg/aar

[Qemu-devel] [PULL 10/10] tcg: Remove tb_htable_lookup from helper_lookup_tb_ptr

2017-06-13 Thread Richard Henderson
This appears to induce lockups, or maybe livelocks, while booting an Alpha Linux kernel. The assumption is that there is a bug elsewhere within QEMU, but reverting the patch allows normal work to continue in the meantime. Signed-off-by: Richard Henderson --- tcg-runtime.c | 32 +

[Qemu-devel] [PULL 02/10] tcg: allocate TB structs before the corresponding translated code

2017-06-13 Thread Richard Henderson
From: "Emilio G. Cota" Allocating an arbitrarily-sized array of tbs results in either (a) a lot of memory wasted or (b) unnecessary flushes of the code cache when we run out of TB structs in the array. An obvious solution would be to just malloc a TB struct when needed, and keep the TB array as

[Qemu-devel] [PULL 01/10] util: add cacheinfo

2017-06-13 Thread Richard Henderson
From: "Emilio G. Cota" Add helpers to gather cache info from the host at init-time. For now, only export the host's I/D cache line sizes, which we will use to improve cache locality to avoid false sharing. Suggested-by: Richard Henderson Suggested-by: Geert Martin Ijewski Tested-by:Geert

[Qemu-devel] [PULL 09/10] Revert "target/aarch64: optimize indirect branches"

2017-06-13 Thread Richard Henderson
This reverts commit e75449a346bf558296966a44277bfd93412c6da6. This patch appears to induce lockups, or maybe livelocks, while booting a Linux kernel. The assumption is that there is a bug elsewhere within QEMU, but reverting the patch allows normal work to continue in the meantime. Signed-off-by

[Qemu-devel] [PULL 00/10] TCG queued patches

2017-06-13 Thread Richard Henderson
The patches from Emilio, plus the code reversions suggested by Alex. r~ The following changes since commit 3f0602927b120a480b35dcf58cf6f95435b3ae91: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170613' into staging (2017-06-13 15:49:07 +0100) are availa

[Qemu-devel] [PULL 03/10] translate-all: consolidate tb init in tb_gen_code

2017-06-13 Thread Richard Henderson
From: "Emilio G. Cota" We are partially initializing tb in tb_alloc. Instead, fully initialize it in tb_gen_code, which is tb_alloc's only caller. This saves an unnecessary write to tb->cflags. Signed-off-by: Emilio G. Cota Message-Id: <1497038122-26364-1-git-send-email-c...@braap.org> Signed-

Re: [Qemu-devel] [PATCH RFC v19 11/13] target-avr: Put all translation code into one compilation unit

2017-06-13 Thread Thomas Huth
On 13.06.2017 22:30, Michael Rolnik wrote: > please explain. There are two "From:" lines in the mail body - normally there should be only one "From:" line (if you're sending a patch that has originally been written by someone else), or none at all. If the patch has been changed by multiple persons

Re: [Qemu-devel] [PATCH RFC v19 01/13] target-avr: AVR cores support is added.

2017-06-13 Thread Thomas Huth
On 13.06.2017 22:32, Michael Rolnik wrote: > the last version of my patches were done by Richard. Now I just > reapplied them to the master. > Should I have to remove "signed-off-by Richard" ? OK, if Richard did change to your patches, you should likely keep the line. But I think you should remov

Re: [Qemu-devel] [PATCH RFC v19 09/13] target-avr: adding instruction decoder

2017-06-13 Thread Thomas Huth
On 13.06.2017 22:29, Michael Rolnik wrote: > this is generated code. Hmm, then it should likely not be included in a patch, but generated during built-time instead, I guess? Thomas

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-13 Thread Peter Xu
On Tue, Jun 13, 2017 at 12:36:33PM +0300, Alexey Perevalov wrote: > This patch adds ability to track down already copied > pages, it's necessary for calculation vCPU block time in > postcopy migration feature, maybe for restore after > postcopy migration failure. > Also it's necessary to solve shar

Re: [Qemu-devel] [PATCH 2/2] migration: remove duplicate typedef

2017-06-13 Thread Fam Zheng
On Tue, 06/13 15:30, Philippe Mathieu-Daudé wrote: > $ make docker-run-test-quick@centos6 > In file included from hw/net/vmxnet3.c:30: > include/migration/register.h:18: error: redefinition of typedef > ‘LoadStateHandler’ > include/migration/vmstate.h:32: note: previous declaration

Re: [Qemu-devel] [PATCH v1 2/2] migration: add bitmap for copied page

2017-06-13 Thread Peter Xu
On Tue, Jun 13, 2017 at 03:00:28PM +0300, Alexey Perevalov wrote: > On 06/13/2017 02:42 PM, Juan Quintela wrote: [...] > >>Bitmap is placed into RAMBlock as another postcopy/precopy > >>related bitmaps. > >Why are we not using the TARGET_PAGE_SIZE as units of the bitmap? > Page size per ram block

Re: [Qemu-devel] [PATCH v4 0/6] spapr/xics: fix migration of older machine types

2017-06-13 Thread Nikunj A Dadhania
David Gibson writes: > On Tue, Jun 13, 2017 at 01:59:29PM +0530, Nikunj A Dadhania wrote: >> Greg Kurz writes: >> >> > On Sun, 11 Jun 2017 17:38:42 +0800 >> > David Gibson wrote: >> > >> >> On Fri, Jun 09, 2017 at 05:09:13PM +0200, Greg Kurz wrote: >> >> > On Fri, 9 Jun 2017 20:28:32 +1000 >>

Re: [Qemu-devel] [PATCH] hw/pci-bridge/dec: Classify the DEC PCI bridge as bridge device

2017-06-13 Thread Fam Zheng
On Wed, 06/14 10:30, David Gibson wrote: > On Wed, Jun 14, 2017 at 05:19:18AM +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 13, 2017 at 12:58:13PM -0700, no-re...@patchew.org wrote: > > > In file included from /tmp/qemu-test/src/hw/net/vmxnet3.c:30: > > > /tmp/qemu-test/src/include/migration/reg

Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-13 Thread Richard Henderson
On 06/13/2017 03:53 PM, Emilio G. Cota wrote: The appended fixes it for me. Can you please test? [ apply with `git am --scissors' ] Thanks, Emilio 8< Commit e75449a3 ("target/aarch64: optimize indirect branches") causes a regression by which aarch64 guests freeze und

Re: [Qemu-devel] [PATCH v1 3/3] s390x/cpumodel: allow to enable MVCOS for qemu cpu model

2017-06-13 Thread Richard Henderson
On 06/13/2017 02:47 PM, David Hildenbrand wrote: +if (!s390_has_feat(S390_FEAT_MOVE_WITH_OPTIONAL_SPEC)) { +program_interrupt(env, PGM_OPERATION, 6); +} This is (supposed to be) done via the feature field of insn-data.def. Except that we do not yet enforce that; we haven't upda

Re: [Qemu-devel] [PATCH v1 2/3] target/s390x: implement mvcos instruction

2017-06-13 Thread Richard Henderson
On 06/13/2017 02:47 PM, David Hildenbrand wrote: +static inline bool psw_key_valid(CPUS390XState *env, uint8_t psw_key) +{ +uint16_t pkm = ((env->cregs[3] & CR3_PKM) >> 16); + +if (env->psw.mask & PSW_MASK_PSTATE) { +/* PSW key has range 0..15, it is valid if the bit is 1 in the P

Re: [Qemu-devel] [PATCH] hw/pci-bridge/dec: Classify the DEC PCI bridge as bridge device

2017-06-13 Thread David Gibson
On Wed, Jun 14, 2017 at 05:19:18AM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 13, 2017 at 12:58:13PM -0700, no-re...@patchew.org wrote: > > In file included from /tmp/qemu-test/src/hw/net/vmxnet3.c:30: > > /tmp/qemu-test/src/include/migration/register.h:18: error: redefinition of > > typedef ‘

[Qemu-devel] [Bug 1030666] Re: gdb can't proceed after a breakpoint

2017-06-13 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1030666 Title: gdb can't p

Re: [Qemu-devel] [PATCH] usb: xhci: fix info leak when writing event to the guest

2017-06-13 Thread Li Qiang
2017-06-14 11:47 GMT+08:00 : > Hi, > > This series failed automatic build test. Please find the testing commands > and > their output below. If you have docker installed, you can probably > reproduce it > locally. > > > > CC hw/timer/a9gtimer.o > In file included from /tmp/qemu-test/src/hw/

Re: [Qemu-devel] [PATCH 1/3] travis: install more library dependencies

2017-06-13 Thread Philippe Mathieu-Daudé
As you said, due to Travis using Ubuntu still not all libs get detected but at least the following: $ ./configure ${CONFIG} -VirtFS supportno +VirtFS supportyes -bluez supportno +bluez supportyes -xfsctl supportno +xfsctl supportyes -lzo support no +lzo support

Re: [Qemu-devel] [PATCH] usb: xhci: fix info leak when writing event to the guest

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 1497411544-80213-1-git-send-email-liqiang...@360.cn Subject: [Qemu-devel] [PATCH] usb: xhci: fix info

[Qemu-devel] [PATCH] usb: xhci: fix info leak when writing event to the guest

2017-06-13 Thread Li Qiang
From: Li Qiang In 'xhci_write_event' function, the 'ev_trb' is not full initialized. This will lead an info leak issue. This patch avoid this. Signed-off-by: Li Qiang --- hw/usb/hcd-xhci.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index a0c7960..

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: add Speed menu

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: d6faaabf-064d-49c0-b572-c73679f34...@gmail.com Subject: [Qemu-devel] [PATCH v3] ui/cocoa.m: add Speed

[Qemu-devel] About remove the TCG related code in hw/i386/kvmvapic.c!

2017-06-13 Thread Zhong Yang
Hello Paolo, About you below A20 fixed patch has been merged in QEMU latest release, commit bbfa326fc8028e275eddf8c9965c2a1b59405b2e target/i386: enable A20 automatically in system management mod I also disabled the kvmvapic rom with below patch and use qemu command to verify your patch #disa

[Qemu-devel] [PATCH v3] ui/cocoa.m: add Speed menu

2017-06-13 Thread Programmingkid
Programs running inside of QEMU can sometimes use more CPU time than is really needed. To solve this problem, we just need to throttle the virtual CPU. This feature will stop laptops from burning up. This patch adds a menu called Speed that has menu items from 100% to 1% that represent the speed

Re: [Qemu-devel] [PATCH v2 3/6] migration: move global_state.optional out

2017-06-13 Thread Peter Xu
On Tue, Jun 13, 2017 at 08:16:35AM -0300, Eduardo Habkost wrote: > On Tue, Jun 13, 2017 at 11:41:02AM +0800, Peter Xu wrote: > > On Mon, Jun 12, 2017 at 04:18:06PM +0800, Peter Xu wrote: > > > On Fri, Jun 09, 2017 at 10:40:10AM -0300, Eduardo Habkost wrote: > > > > On Fri, Jun 09, 2017 at 11:48:59A

Re: [Qemu-devel] [PATCH] hw/pci-bridge/dec: Classify the DEC PCI bridge as bridge device

2017-06-13 Thread Michael S. Tsirkin
On Tue, Jun 13, 2017 at 12:58:13PM -0700, no-re...@patchew.org wrote: > In file included from /tmp/qemu-test/src/hw/net/vmxnet3.c:30: > /tmp/qemu-test/src/include/migration/register.h:18: error: redefinition of > typedef ‘LoadStateHandler’ > /tmp/qemu-test/src/include/migration/vmstate.h:32: note:

Re: [Qemu-devel] [PATCH] hw/pci-bridge/dec: Classify the DEC PCI bridge as bridge device

2017-06-13 Thread David Gibson
On Tue, Jun 13, 2017 at 09:48:49PM +0200, Thomas Huth wrote: > This way the bridge shows up in the correct section of the > "-device help" text. > > Signed-off-by: Thomas Huth Reviewed-by: David Gibson > --- > hw/pci-bridge/dec.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/

Re: [Qemu-devel] [PATCH v3 5/5] spapr: fix migration of ICPState objects from/to older QEMU

2017-06-13 Thread David Gibson
On Tue, Jun 13, 2017 at 05:24:28PM +0200, Greg Kurz wrote: > On Tue, 13 Jun 2017 18:01:46 +0800 > David Gibson wrote: > > > On Tue, Jun 13, 2017 at 11:21:50AM +0200, Greg Kurz wrote: > > > On Tue, 13 Jun 2017 10:00:03 +0100 > > > "Dr. David Alan Gilbert" wrote: > > > > > > > * Greg Kurz (gr..

Re: [Qemu-devel] [PATCH v4 0/6] spapr/xics: fix migration of older machine types

2017-06-13 Thread David Gibson
On Tue, Jun 13, 2017 at 01:59:29PM +0530, Nikunj A Dadhania wrote: > Greg Kurz writes: > > > On Sun, 11 Jun 2017 17:38:42 +0800 > > David Gibson wrote: > > > >> On Fri, Jun 09, 2017 at 05:09:13PM +0200, Greg Kurz wrote: > >> > On Fri, 9 Jun 2017 20:28:32 +1000 > >> > David Gibson wrote: > >> >

Re: [Qemu-devel] [PATCH] target/ppc/excp_helper: Take BQL before calling cpu_interrupt()

2017-06-13 Thread David Gibson
On Tue, Jun 13, 2017 at 12:55:29PM +0200, Thomas Huth wrote: > Since the introduction of MTTCG, using the msgsnd instruction > abort()s if being called without holding the BQL. So let's protect > that part of the code now with qemu_mutex_lock_iothread(). > > Buglink: https://bugs.launchpad.net/qem

Re: [Qemu-devel] [Qemu-block] NVME: is there any plan to support SGL data transfer?

2017-06-13 Thread Qu Wenruo
At 06/12/2017 10:05 PM, Keith Busch wrote: On Fri, Jun 02, 2017 at 03:51:51PM +0200, Kevin Wolf wrote: Am 02.06.2017 um 03:47 hat Qu Wenruo geschrieben: When going through NVMe specification and hw/block/nvme.c, I found that it seems that NVMe qemu implementation only support PRP for sq entry

Re: [Qemu-devel] [PATCH] Remove restriction that prevents bootimg elf64 images

2017-06-13 Thread Anatol Pomozov
Hi Adam Do these arguments sound reasonable to apply the patch? On Thu, Jun 8, 2017 at 2:07 PM, Anatol Pomozov wrote: > +reply-all > > On Thu, Jun 8, 2017 at 1:41 PM, Adam Lackorzynski > wrote: >> >> On Tue Jun 06, 2017 at 21:41:48 -0700, Anatol Pomozov wrote: >>> It is possible to create a 64

Re: [Qemu-devel] [PATCH v3] usb-host: support devices with sparse/non-sequential USB interfaces

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170613234039.27201-1-sam.br...@accelerated.com Subject: [Qemu-devel] [PATCH v3] usb-host: support devices with

Re: [Qemu-devel] [PATCH] usb-host: support devices with sparse/non-sequential USB interfaces

2017-06-13 Thread Samuel Brian
Done. Had to V3 it to pass the formatting check. Sorry about that. Sam On 13/06/17 20:22, Gerd Hoffmann wrote: On Tue, 2017-06-13 at 14:17 +1000, Samuel Brian wrote: This change allows sparse USB interface numbering. Instead of only claiming the interfaces in the range reported by the USB devi

[Qemu-devel] [PATCH v3] usb-host: support devices with sparse/non-sequential USB interfaces

2017-06-13 Thread Samuel Brian
Some USB devices have sparse interface numbering which is not able to be passthroughed. For example, the Sierra Wireless MC7455/MC7430: # lsusb -D /dev/bus/usb/003/003 | egrep '1199|9071|bNumInterfaces|bInterfaceNumber' Device: ID 1199:9071 Sierra Wireless, Inc. idVendor 0x1199

Re: [Qemu-devel] [PATCH 0/3] device-crash-test: New mode for testing -object

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170613230627.17942-1-ehabk...@redhat.com Type: series Subject: [Qemu-devel] [PATCH 0/3] device-crash-test: New m

Re: [Qemu-devel] [PATCH RFC v19 11/13] target-avr: Put all translation code into one compilation unit

2017-06-13 Thread Anichang via Qemu-devel
Original Message Subject: Re: [Qemu-devel] [PATCH RFC v19 11/13] target-avr: Put all translation code into one compilation unit Local Time: June 13, 2017 10:07 PM UTC Time: June 13, 2017 8:07 PM From: th...@redhat.com To: Michael Rolnik , qemu-devel@nongnu.org Richard Henderson ,

Re: [Qemu-devel] [PATCH v2] usb-host: support devices with sparse/non-sequential USB interfaces

2017-06-13 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170613225900.1641-1-sam.br...@accelerated.com Type: series Subject: [Qemu-devel] [PATCH v2] usb-host: support devices with sparse/non-sequential USB interfaces === TEST SCRIPT BEGIN ==

Re: [Qemu-devel] [PATCH v2] usb-host: support devices with sparse/non-sequential USB interfaces

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v2] usb-host: support devices with sparse/non-sequential USB interfaces Type: series Message-id:

[Qemu-devel] [PATCH 0/3] device-crash-test: New mode for testing -object

2017-06-13 Thread Eduardo Habkost
This series extends the device-crash-test script so it can test backend objects, too. The new mode can be enabled using the "-O" option. The script already found a crash using the following command-line: $ qemu-system-x86_64 -S -machine none -object colo-compare,id=test-object (qemu-system-x

[Qemu-devel] [PATCH 1/3] scripts/qmp: Accept timeout parameter on accept()

2017-06-13 Thread Eduardo Habkost
Shorter timeouts will be useful for test code that needs to catch QEMU exiting before it connects to the QMP socket. Signed-off-by: Eduardo Habkost --- scripts/qmp/qmp.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/qmp/qmp.py b/scripts/qmp/qmp.py index 62d3651

[Qemu-devel] [PATCH 3/3] device-crash-test: Mode for testing -object

2017-06-13 Thread Eduardo Habkost
Extend the device-crash-test script so it can test backend objects, too. The new mode can be enabled using the "-O" option. The script already found a crash using the following command-line: $ qemu-system-x86_64 -S -machine none -object colo-compare,id=test-object (qemu-system-x86_64:3812): G

[Qemu-devel] [PATCH 2/3] scripts/qemu: Catch QEMU exit while waiting for QMP client

2017-06-13 Thread Eduardo Habkost
To avoid waiting for the full 15-second timeout for a connection, check if QEMU exited once in a while. Start with a very short timeout (15ms), and double it on each try. This will be helpful for scripts/device-crash-test, on cases where QEMU crashes or exits before connecting to the QMP socket.

Re: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR Type: series Message-id: 20170613225352.GA

[Qemu-devel] [PATCH v2] usb-host: support devices with sparse/non-sequential USB interfaces

2017-06-13 Thread Samuel Brian
Some USB devices have sparse interface numbering which is not able to be passthroughed. For example, the Sierra Wireless MC7455/MC7430: # lsusb -D /dev/bus/usb/003/003 | egrep '1199|9071|bNumInterfaces|bInterfaceNumber' Device: ID 1199:9071 Sierra Wireless, Inc. idVendor 0x1199

[Qemu-devel] [PATCH] target/aarch64: exit to main loop after handling MSR

2017-06-13 Thread Emilio G. Cota
The appended fixes it for me. Can you please test? [ apply with `git am --scissors' ] Thanks, Emilio 8< Commit e75449a3 ("target/aarch64: optimize indirect branches") causes a regression by which aarch64 guests freeze under TCG with -smp > 1, even with `-accel accel=tc

[Qemu-devel] [Bug 893208] Re: qemu on ARM hosts can't boot i386 image

2017-06-13 Thread PeteVine
Indeed, I had no problem booting the images this time around: https://asciinema.org/a/d2m42g5c0n3z2pnbskhirdv5j -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/893208 Title: qemu on ARM hosts can't

Re: [Qemu-devel] [PATCH v1 0/3] target/s390x: implement MVCOS and allow to enable it

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20170613214736.19963-1-da...@redhat.com Subject: [Qemu-devel] [PATCH v1 0/3] target/s390x: implement

[Qemu-devel] [PATCH v1 2/3] target/s390x: implement mvcos instruction

2017-06-13 Thread David Hildenbrand
This adds support for the MOVE WITH OPTIONAL SPECIFICATIONS (MVCOS) instruction (in a relatively slow way). But it is enough to boot a linux kernel that uses it for uacccess (primary <-> seconardy). We are missing (as for most other part) low address protection checks, PSW key / storage key checks

[Qemu-devel] [PATCH v1 1/3] target/s390x: change PSW_SHIFT_KEY

2017-06-13 Thread David Hildenbrand
Such shifts are usually used to easily extract the PSW KEY from the PSW mask, so let's avoid the confisuing offset of 4. Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 2 +- target/s390x/translate.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/s3

[Qemu-devel] [PATCH v1 3/3] s390x/cpumodel: allow to enable MVCOS for qemu cpu model

2017-06-13 Thread David Hildenbrand
This allows botting a recent linux kernel (e.g. compiled for z900) and using mvcos for uaccess: qemu-system-s390x ... -cpu qemu,mvcos=on ... While at it, correctly fake its abscence. Signed-off-by: David Hildenbrand --- target/s390x/cpu_models.c | 1 + target/s390x/mem_helper.c | 3 +++ 2 file

[Qemu-devel] [PATCH v1 0/3] target/s390x: implement MVCOS and allow to enable it

2017-06-13 Thread David Hildenbrand
This will not change the qemu model, we simply allow to enable the facility for the qemu model. A current upstream kernel (compiled for e.g. z900) can be tricked into using MVCOS for uaccess by simply enabling the facility. This will work even though the kernel is not compiled with z10+ support, a

Re: [Qemu-devel] [PATCH] spapr: manage hotplugged devices while the VM is not started

2017-06-13 Thread Michael Roth
Quoting Igor Mammedov (2017-06-09 03:27:33) > On Thu, 08 Jun 2017 15:00:53 -0500 > Michael Roth wrote: > > > Quoting David Gibson (2017-05-30 23:35:57) > > > On Tue, May 30, 2017 at 06:04:45PM +0200, Laurent Vivier wrote: > > > > For QEMU, a hotlugged device is a device added using the HMP/QMP

Re: [Qemu-devel] [PATCH] throttle: Update throttle-groups.c documentation

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Message-id: 20170613211612.9368-1-be...@igalia.com Subject: [Qemu-devel] [PATCH] throttle: Update throttle-groups

[Qemu-devel] [PATCH] throttle: Update throttle-groups.c documentation

2017-06-13 Thread Alberto Garcia
There used to be throttle_timers_{detach,attach}_aio_context() calls in bdrv_set_aio_context(), but since 7ca7f0f6db1fedd28d490795d778cf239 they are now in blk_set_aio_context(). Signed-off-by: Alberto Garcia --- block/throttle-groups.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH v2] block: Do not strcmp() with NULL uri->scheme

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170613205726.13544-1-mre...@redhat.com Subject: [Qemu-devel] [PATCH v2] block: Do not strcmp() with NULL uri->sc

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] block: Fix gcc 7 warnings

2017-06-13 Thread Alberto Garcia
On Tue 13 Jun 2017 07:20:04 PM CEST, Max Reitz wrote: > blkdebug and blkverify use snprintf() to generate a filename; however, > that may not fit into the target buffer (BDS.exact_filename). If so, > they generate a truncated and thus pretty much unusable filename. In > this case it's better to ju

[Qemu-devel] [PATCH v2] block: Do not strcmp() with NULL uri->scheme

2017-06-13 Thread Max Reitz
uri_parse(...)->scheme may be NULL. In fact, probably every field may be NULL, and the callers do test this for all of the other fields but not for scheme (except for block/gluster.c; block/vxhs.c does not access that field at all). We can easily fix this by using g_strcmp0() instead of strcmp().

Re: [Qemu-devel] [PULL 0/3] Queued s390x tcg patches

2017-06-13 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PULL 0/3] Queued s390x tcg patches Type: series Message-id: 20170613202659.1920-1-...@twiddle.net ===

Re: [Qemu-devel] [PATCH RFC v19 11/13] target-avr: Put all translation code into one compilation unit

2017-06-13 Thread Michael Rolnik
please explain. On Tue, Jun 13, 2017 at 11:07 PM, Thomas Huth wrote: > On 08.06.2017 21:38, Michael Rolnik wrote: > > From: Michael Rolnik > > > > From: Richard Henderson > > From whom is this patch? ... looks like there is something wrong with > the way you send the patches... > > Thomas >

[Qemu-devel] [PULL 2/3] target/s390x: rework PGM interrupt psw.addr handling

2017-06-13 Thread Richard Henderson
From: David Hildenbrand We can tell from the program interrupt code, whether a program interrupt has to forward the address in the PGM new PSW (suppressing/terminated/completed) to point at the next instruction, or if it is nullifying and the PSW address does not have to be incremented. So let's

[Qemu-devel] [PULL 0/3] Queued s390x tcg patches

2017-06-13 Thread Richard Henderson
Cleanups and fixes from David Hildenbrand. r~ The following changes since commit 3f0602927b120a480b35dcf58cf6f95435b3ae91: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170613' into staging (2017-06-13 15:49:07 +0100) are available in the git repository

[Qemu-devel] [PULL 1/3] target/s390x: correctly indicate PER nullification

2017-06-13 Thread Richard Henderson
From: David Hildenbrand Signed-off-by: David Hildenbrand Message-Id: <20170609142156.18767-2-da...@redhat.com> Signed-off-by: Richard Henderson --- target/s390x/misc_helper.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c index edcdf

[Qemu-devel] [PATCH v4 15/16] iotests: Add preallocated resize test for raw

2017-06-13 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/106 | 92 ++ tests/qemu-iotests/106.out | 50 + tests/qemu-iotests/group | 1 + 3 files changed, 143 insertions(+) create mode 100755 tests/qem

[Qemu-devel] [PATCH v4 13/16] block/qcow2: Rename "fail_block" to just "fail"

2017-06-13 Thread Max Reitz
Now alloc_refcount_block() only contains a single fail label, so it makes more sense to just name it "fail" instead of "fail_block". Signed-off-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH v4 16/16] iotests: Add preallocated growth test for qcow2

2017-06-13 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Stefan Hajnoczi --- tests/qemu-iotests/125 | 130 +++ tests/qemu-iotests/125.out | 386 + tests/qemu-iotests/group | 1 + 3 files changed, 517 insertions(+) create mode 100755 tests/qemu-iotest

[Qemu-devel] [PATCH v4 12/16] block/qcow2: Add qcow2_refcount_area()

2017-06-13 Thread Max Reitz
This function creates a collection of self-describing refcount structures (including a new refcount table) at the end of a qcow2 image file. Optionally, these structures can also describe a number of additional clusters beyond themselves; this will be important for preallocated truncation, which wi

Re: [Qemu-devel] [PATCH RFC v19 01/13] target-avr: AVR cores support is added.

2017-06-13 Thread Michael Rolnik
the last version of my patches were done by Richard. Now I just reapplied them to the master. Should I have to remove "signed-off-by Richard" ? On Tue, Jun 13, 2017 at 11:09 PM, Thomas Huth wrote: > On 08.06.2017 20:49, Michael Rolnik wrote: > > 1. basic CPU structure > > 2. registers >

  1   2   3   4   >