Re: [Qemu-devel] [PATCH V4 02/12] net/filter-mirror.c: Add new option to enable vnet support for filter-mirror

2017-05-14 Thread Zhang Chen
On 05/15/2017 11:26 AM, Jason Wang wrote: On 2017年05月12日 09:41, Zhang Chen wrote: We add the vnet_hdr option for filter-mirror, default is disable. If you use virtio-net-pci net driver, please enable it. You can use it for example: -object filter-mirror,id=m0,netdev=hn0,queue=tx,outdev=mirr

Re: [Qemu-devel] [PATCH V4 01/12] net: Add vnet_hdr_len related arguments in NetClientState

2017-05-14 Thread Zhang Chen
On 05/15/2017 11:24 AM, Jason Wang wrote: On 2017年05月14日 05:24, Philippe Mathieu-Daudé wrote: Hi Zhang On 05/11/2017 10:41 PM, Zhang Chen wrote: Add vnet_hdr_len and using_vnet_hdr arguments in NetClientState that make othermodule get real vnet_hdr_len easily. Signed-off-by: Zhang Chen -

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-14 Thread Markus Armbruster
Luiz Capitulino writes: > On Fri, 12 May 2017 09:37:50 +0200 > Markus Armbruster wrote: > >> Luiz, there's a lone question for you further down. Search for your >> name. > > I could not a question, can you paste it here? Uh, I actually spun it out into its own message, so you don't have to wad

[Qemu-devel] [PATCH RESEND V2 2/3] net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle

2017-05-14 Thread Zhang Chen
Because filter_mirror_receive_iov() and filter_redirector_receive_iov() both use the filter_mirror_send() to send packet, so I change filter_mirror_send() to filter_send() that looks more common. And fix some codestyle. Signed-off-by: Zhang Chen --- net/filter-mirror.c | 29 -

[Qemu-devel] [PATCH RESEND V2 0/3] Optimize filter-mirror and filter-rewriter

2017-05-14 Thread Zhang Chen
Fix some duplicate codes and remove unused codes. v2: Address Eric's comment on patch 3. Zhang Chen (3): net/filter-mirror.c: Remove duplicate check code. net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle net/filter-rewriter: Remove unused option in filter-rewriter net/fi

[Qemu-devel] [PATCH RESEND V2 1/3] net/filter-mirror.c: Remove duplicate check code.

2017-05-14 Thread Zhang Chen
The s->outdev have checked in filter_mirror_set_outdev(). Signed-off-by: Zhang Chen --- net/filter-mirror.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/net/filter-mirror.c b/net/filter-mirror.c index 72fa7c2..fd0322f 100644 --- a/net/filter-mirror.c +++ b/net/filter-mirror.c @@ -194

[Qemu-devel] [PATCH RESEND V2 3/3] net/filter-rewriter: Remove unused option in filter-rewriter

2017-05-14 Thread Zhang Chen
Signed-off-by: Zhang Chen --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index f806af9..cbec279 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4038,7 +4038,7 @@ Create a filter-redirector we need to differ outdev i

[Qemu-devel] [PATCH V2 2/3] net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle

2017-05-14 Thread Zhang Chen
Because filter_mirror_receive_iov() and filter_redirector_receive_iov() both use the filter_mirror_send() to send packet, so I change filter_mirror_send() to filter_send() that looks more common. And fix some codestyle. Signed-off-by: Zhang Chen --- net/filter-mirror.c | 29 -

[Qemu-devel] [PATCH V2 1/3] net/filter-mirror.c: Remove duplicate check code.

2017-05-14 Thread Zhang Chen
The s->outdev have checked in filter_mirror_set_outdev(). Signed-off-by: Zhang Chen --- net/filter-mirror.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/net/filter-mirror.c b/net/filter-mirror.c index 72fa7c2..fd0322f 100644 --- a/net/filter-mirror.c +++ b/net/filter-mirror.c @@ -194

[Qemu-devel] [PATCH V2 3/3] net/filter-rewriter: Remove unused option in filter-rewriter

2017-05-14 Thread Zhang Chen
Signed-off-by: Zhang Chen --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index f806af9..85cf0f5 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -4038,7 +4038,7 @@ Create a filter-redirector we need to differ outdev i

[Qemu-devel] [PATCH V2 0/3] Optimize filter-mirror and filter-rewriter

2017-05-14 Thread Zhang Chen
Fix some duplicate codes and remove unused codes. v2: Address Eric's comment on patch 3. Zhang Chen (3): net/filter-mirror.c: Remove duplicate check code. net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle net/filter-rewriter: Remove unused option in filter-rewriter net/fi

[Qemu-devel] [PATCH 5/6] hw/misc: add a TMP42{1,2,3} device model

2017-05-14 Thread Cédric Le Goater
Largely inspired by the TMP105 temperature sensor, here is a model for the TMP42{1,2,3} temperature sensors. Specs can be found here : http://www.ti.com/lit/gpn/tmp421 Signed-off-by: Cédric Le Goater --- Changes since initial version: - simplified tmp421_tx() as tmp421 does not need

[Qemu-devel] [PATCH 4/6] aspeed: add some I2C devices to the Aspeed machines

2017-05-14 Thread Cédric Le Goater
Let's add an RTC to the palmetto BMC and a LM75 temperature sensor to the AST2500 EVB to start with. Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index 283c03881493..e824ea87

[Qemu-devel] [PATCH 6/6] aspeed: add a temp sensor device on I2C bus 3

2017-05-14 Thread Cédric Le Goater
Temperatures can be changed from the monitor with : (qemu) qom-set /machine/unattached/device[2] temperature0 12000 Signed-off-by: Cédric Le Goater --- hw/arm/aspeed.c | 9 + 1 file changed, 9 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index e824ea87a9af..155e

[Qemu-devel] [PATCH 3/6] aspeed/i2c: introduce a state machine

2017-05-14 Thread Cédric Le Goater
The Aspeed I2C controller maintains a state machine in the command register, which is mostly used for debug. Let's start adding a few states to handle abnormal STOP commands. Today, the model uses the busy status of the bus as a condition to do so but it is not precise enough. Also remove the ABN

[Qemu-devel] [PATCH 1/6] aspeed/i2c: improve command handling

2017-05-14 Thread Cédric Le Goater
Multiple I2C commands can be fired simultaneously and the controller execute the commands following these priorities: (1) Master Start Command (2) Master Transmit Command (3) Slave Transmit Command or Master Receive Command (4) Master Stop Command The current code is incorrect with respec

[Qemu-devel] [PATCH 2/6] aspeed/i2c: handle LAST command under the RX command

2017-05-14 Thread Cédric Le Goater
Today, the LAST command is handled with the STOP command but this is incorrect. Also nack the I2C bus when a LAST is issued. Signed-off-by: Cédric Le Goater --- hw/i2c/aspeed_i2c.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/i2c/aspeed_i2c.c b/hw/i2c/aspeed_i2

[Qemu-devel] [PATCH 0/6] aspeed: I2C controller fixes

2017-05-14 Thread Cédric Le Goater
Hello, The new Linux driver for the Aspeed I2C controller revealed some serious limitations in the QEMU model. This series fixes these issues and also adds a couple of well-know I2C devices to the Aspeed machines. The QEMU model now supports the recent Linux driver and the older one. Thanks, C.

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

2017-05-14 Thread Jason Wang
On 2017年05月13日 08:02, Michael S. Tsirkin wrote: On Fri, May 12, 2017 at 04:21:58PM +0200, Maxime Coquelin wrote: On 05/11/2017 08:25 PM, Michael S. Tsirkin wrote: On Thu, May 11, 2017 at 02:32:46PM +0200, Maxime Coquelin wrote: This patch specifies and implements the master/slave communicat

Re: [Qemu-devel] [RFC PATCH 6/8] memory: introduce AddressSpaceOps

2017-05-14 Thread David Gibson
On Thu, May 11, 2017 at 01:04:26PM +0800, Peter Xu wrote: > On Wed, May 10, 2017 at 05:04:06PM +1000, David Gibson wrote: > > On Mon, May 08, 2017 at 03:32:17PM +0800, Peter Xu wrote: > > > On Mon, May 08, 2017 at 04:07:44PM +1000, David Gibson wrote: > > > > On Mon, May 08, 2017 at 01:48:14PM +080

Re: [Qemu-devel] [PATCH 3/3] net/filter-rewriter: Remove unused option in filter-rewirter

2017-05-14 Thread Zhang Chen
On 05/13/2017 01:43 AM, Eric Blake wrote: On 05/11/2017 08:35 PM, Zhang Chen wrote: Signed-off-by: Zhang Chen In the subject: s/rewirter/rewriter/ OK. --- qemu-options.hx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 70c0

Re: [Qemu-devel] [PATCH v4 5/6] target/ppc: optimize various functions using extract op

2017-05-14 Thread David Gibson
On Fri, May 12, 2017 at 08:38:42PM -0300, Philippe Mathieu-Daudé wrote: > Patch created mechanically using Coccinelle script via: > > $ spatch --macro-file scripts/cocci-macro-file.h --in-place \ > --sp-file scripts/coccinelle/tcg_gen_extract.cocci --dir target > > Signed-off-by: Phil

[Qemu-devel] [Bug 720657] Re: SVM intercept for VINTR exits too early

2017-05-14 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/720657 Title: SVM intercep

Re: [Qemu-devel] [PATCH V4 11/12] net/filter-rewriter.c: Add new option to enable vnet support for filter-rewriter

2017-05-14 Thread Jason Wang
On 2017年05月12日 09:41, Zhang Chen wrote: We add the vnet_hdr option for filter-rewriter, default is disable. If you use virtio-net-pci net driver, please enable it. You can use it for example: -object filter-rewriter,id=rew0,netdev=hn0,queue=all,vnet_hdr=on Signed-off-by: Zhang Chen As has b

Re: [Qemu-devel] [PATCH V4 10/12] net/colo-compare.c: Add vnet packet's tcp/udp/icmp compare

2017-05-14 Thread Jason Wang
On 2017年05月12日 09:41, Zhang Chen wrote: COLO-Proxy just focus on packet payload, So we skip vnet header. Signed-off-by: Zhang Chen --- net/colo-compare.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/net/colo-compare.c b/net/colo-compare.c index cb0b04e..

Re: [Qemu-devel] [PATCH V4 07/12] net/colo.c: Make vnet_hdr_len as packet property

2017-05-14 Thread Jason Wang
On 2017年05月12日 09:41, Zhang Chen wrote: We can use this property flush and send packet with vnet_hdr_len. Signed-off-by: Zhang Chen Then I think it's not necessary to store vnet_hdr_len in SocketReadState? Thanks --- net/colo-compare.c| 8 ++-- net/colo.c| 3 ++-

Re: [Qemu-devel] [PATCH V4 06/12] net/colo-compare.c: Add new option to enable vnet support for colo-compare

2017-05-14 Thread Jason Wang
On 2017年05月12日 09:41, Zhang Chen wrote: We add the vnet_hdr option for colo-compare, default is disable. If you use virtio-net-pci net driver, please enable it. You can use it for example: -object colo-compare,id=comp0,primary_in=compare0-0,secondary_in=compare1,outdev=compare_out0,vnet_hdr=on

Re: [Qemu-devel] [PATCH V4 05/12] net/net.c: Add vnet_hdr support in SocketReadState

2017-05-14 Thread Jason Wang
On 2017年05月12日 09:41, Zhang Chen wrote: Address Jason Wang's comments add vnet header length to SocketReadState. Better to use "Suggested-by" instead of this :). We add a flag to dicide whether net_fill_rstate() to read struct {int size; int vnet_hdr_len; const uint8_t buf[];} or not. Fe

Re: [Qemu-devel] [PATCH V4 04/12] net/filter-mirror.c: Add new option to enable vnet support for filter-redirector

2017-05-14 Thread Jason Wang
On 2017年05月12日 09:41, Zhang Chen wrote: We add the vnet_hdr option for filter-redirector, default is disable. If you use virtio-net-pci net driver, please enable it. We need a better commit log here to explain e.g why we need this option. Thanks You can use it for example: -object filter-r

Re: [Qemu-devel] [PATCH V4 03/12] net/filter-mirror.c: Make filter_mirror_send support vnet support.

2017-05-14 Thread Jason Wang
On 2017年05月12日 09:41, Zhang Chen wrote: In this patch, if vnet_hdr=on we change the send packet format from struct {int size; const uint8_t buf[];} to {int size; int vnet_hdr_len; const uint8_t buf[];}. make other module(like colo-compare) know how to parse net packet correctly. Signed-off-by

Re: [Qemu-devel] [PATCH V4 02/12] net/filter-mirror.c: Add new option to enable vnet support for filter-mirror

2017-05-14 Thread Jason Wang
On 2017年05月12日 09:41, Zhang Chen wrote: We add the vnet_hdr option for filter-mirror, default is disable. If you use virtio-net-pci net driver, please enable it. You can use it for example: -object filter-mirror,id=m0,netdev=hn0,queue=tx,outdev=mirror0,vnet_hdr=on Signed-off-by: Zhang Chen --

Re: [Qemu-devel] [PATCH V4 01/12] net: Add vnet_hdr_len related arguments in NetClientState

2017-05-14 Thread Jason Wang
On 2017年05月14日 05:24, Philippe Mathieu-Daudé wrote: Hi Zhang On 05/11/2017 10:41 PM, Zhang Chen wrote: Add vnet_hdr_len and using_vnet_hdr arguments in NetClientState that make othermodule get real vnet_hdr_len easily. Signed-off-by: Zhang Chen --- include/net/net.h | 2 ++ net/net.c

Re: [Qemu-devel] [PATCH 0/3] Optimize filter-mirror and filter-rewriter

2017-05-14 Thread Jason Wang
On 2017年05月12日 09:35, Zhang Chen wrote: Fix some duplicate codes and remove unused codes. Zhang Chen (3): net/filter-mirror.c: Remove duplicate check code. net/filter-mirror.c: Rename filter_mirror_send() and fix codestyle net/filter-rewriter: Remove unused option in filter-rewirter

[Qemu-devel] [PATCH v2] net/rocker: Convert pci device .init() to .realize()

2017-05-14 Thread Mao Zhongyi
Convert pci device .init() to .realize(). Also improve -device rocker error reporting. Because when -device rocker fails, it first reports a specific error, then a generic one, like this: $ x86_64-softmmu/qemu-system-x86_64 -device rocker,name=qemu-rocker rocker: name too long; please shor

Re: [Qemu-devel] [PATCH v7 09/13] vfio/ccw: get irqs info and set the eventfd fd

2017-05-14 Thread Dong Jia Shi
* Dong Jia Shi [2017-05-15 10:31:48 +0800]: > * Alex Williamson [2017-05-11 15:49:04 -0600]: > > Hi Alex, > > [...] > > > > diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c > > > index 7ddcfd7..6760cee 100644 > > > --- a/hw/vfio/ccw.c > > > +++ b/hw/vfio/ccw.c > > [...] > > > > +static void vfio_

Re: [Qemu-devel] [PATCH v7 09/13] vfio/ccw: get irqs info and set the eventfd fd

2017-05-14 Thread Dong Jia Shi
* Alex Williamson [2017-05-11 15:49:04 -0600]: Hi Alex, [...] > > diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c > > index 7ddcfd7..6760cee 100644 > > --- a/hw/vfio/ccw.c > > +++ b/hw/vfio/ccw.c [...] > > +static void vfio_ccw_register_io_notifier(VFIOCCWDevice *vcdev, Error > > **errp) > > +{ >

Re: [Qemu-devel] [PATCH v7 06/13] s390x/css: device support for s390-ccw passthrough

2017-05-14 Thread Dong Jia Shi
* Alex Williamson [2017-05-11 15:13:56 -0600]: [...] > > diff --git a/hw/s390x/s390-ccw.c b/hw/s390x/s390-ccw.c > > new file mode 100644 > > index 000..b1aadcd > > --- /dev/null > > +++ b/hw/s390x/s390-ccw.c > > @@ -0,0 +1,138 @@ > > +/* > > + * s390 CCW Assignment Support > > + * > > + * Co

Re: [Qemu-devel] [PATCH] hw/net/rocker/rocker: Convert pci device .init() to .realize()

2017-05-14 Thread Mao Zhongyi
Hi, Philippe On 05/14/2017 05:04 AM, Philippe Mathieu-Daudé wrote: Hi Mao, You can use shorter patch subject "net/rocker" instead of "hw/net/rocker/rocker". Thanks for your suggestion :)OK, will do the fix right away. On 05/12/2017 05:35 AM, Mao Zhongyi wrote: Convert pci device .init()

Re: [Qemu-devel] Installing Windows with virtio (was: QEMU, increase graphics memory)

2017-05-14 Thread Fam Zheng
On Sun, 05/14 19:39, jenia.ivlev wrote: > > I wanted to get more graphics memory on my QEMU Windows client. > > I decided to install **Virtio** drivers for QEMU to achieve that purpose. > > I create an *imagine_file* like this: > > > qemu-img create -f raw image_file 4G > > > Also, I ran

Re: [Qemu-devel] [virtio-dev] [PATCH v2 06/16] virtio: add inter-vm notification support

2017-05-14 Thread Wei Wang
On 05/12/2017 04:35 PM, Wei Wang wrote: This patch enables the assign of an already allocated eventfd to a notifier. In this case, QEMU creates a new eventfd for the notifier only when the notifier's fd equals to -1. Otherwise, it means that the notifier has been assigned a vaild fd. Signed-off-

[Qemu-devel] QEMU, increase graphics memory

2017-05-14 Thread jenia.ivlev
I wanted to get more graphics memory on my QEMU Windows client. I decided to install **Virtio** drivers for QEMU to achieve that purpose. I create an *imagine_file* like this: qemu-img create -f raw image_file 4G Also, I ran the windows-install like this: qemu-system-x86_64 -enable

Re: [Qemu-devel] [PATCH] tcg/i386: 'nop' instruction with 'lock' prefix is illegal

2017-05-14 Thread Richard Henderson
On 05/13/2017 08:58 AM, Pranith Kumar wrote: The instruction "lock nopl (%rax)" should raise an exception. However, we don't do that since we do not check for lock prefix for nop instructions. The following patch adds this check and makes the behavior similar to hardware. Signed-off-by: Pranith

Re: [Qemu-devel] [PATCH V4 02/12] net/filter-mirror.c: Add new option to enable vnet support for filter-mirror

2017-05-14 Thread Zhang Chen
On 05/13/2017 09:49 AM, Hailiang Zhang wrote: Hi, On 2017/5/12 9:41, Zhang Chen wrote: We add the vnet_hdr option for filter-mirror, default is disable. If you use virtio-net-pci net driver, please enable it. You can use it for example: -object filter-mirror,id=m0,netdev=hn0,queue=tx,outdev=

Re: [Qemu-devel] e1000e migration

2017-05-14 Thread Dmitry Fleytman
Hello Dave, We are trying to reproduce this issue on our systems but with no luck so far… From what you describe it looks like some bit in ICR is not being cleared by the driver. This usually means that this bit should never be set in that specific interrupt mode. Could you please check which

Re: [Qemu-devel] [PATCH v2 1/1] qga-win: fix installation on localized windows

2017-05-14 Thread Sameeh Jubran
Reviewed-by: Sameeh Jubran On Thu, Apr 27, 2017 at 4:21 PM, Daniel Rempel wrote: > Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1357789 > Replace hardcoded user and group names ("Administrators", "SYSTEM") with > the ones acquired from system. Windows uses localized strings for these > name