[Qemu-devel] bytes xfer

2017-04-28 Thread ali saeedi
Hi what does 'bytes_xfer' and 'xfer_limit' mean? I am new in qemu. thanks a lot

[Qemu-devel] [Bug 760976] Re: Nexenta 3.0.1 fails to install

2017-04-28 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/760976 Title: Nexenta 3.0.

[Qemu-devel] [Bug 1654826] Re: Holding key down using input-linux freezes guest

2017-04-28 Thread D J
I am getting the same issue where I can even hear the sound glitch out. I'm on Arch Linux. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1654826 Title: Holding key down using input-linux freezes gu

Re: [Qemu-devel] [PATCH v17 00/24] qcow2: persistent dirty bitmaps

2017-04-28 Thread Vladimir Sementsov-Ogievskiy
This is fixed by not fail on ! can_write() if there are no persistent BdrvDirtyBitmap's. But the problem is, what if we have readonly image with bitmaps? This should not fail. I'll have to add bool 'changed' field to BdrvDirtyBitmap to handle this. Or refactor all bool's to int flags Best regar

Re: [Qemu-devel] RFC: some problems with bdrv_get_block_status

2017-04-28 Thread Denis V. Lunev
On 04/28/2017 09:31 PM, Eric Blake wrote: > On 04/28/2017 11:17 AM, Denis V. Lunev wrote: >> Hello, All! >> >> Recently we have experienced problems with very slow >> bdrv_get_block_status call, which is massive called f.e. >> from mirror_run(). >> >> The problem was narrowed down to slow lseek64()

Re: [Qemu-devel] [RFC/BUG] xen-mapcache: buggy invalidate map cache?

2017-04-28 Thread Stefano Stabellini
On Thu, 13 Apr 2017, Herongguang (Stephen) wrote: > On 2017/4/13 7:51, Stefano Stabellini wrote: > > On Wed, 12 Apr 2017, Herongguang (Stephen) wrote: > > > On 2017/4/12 6:32, Stefano Stabellini wrote: > > > > On Tue, 11 Apr 2017, hrg wrote: > > > > > On Tue, Apr 11, 2017 at 3:50 AM, Stefano Stabel

Re: [Qemu-devel] [PATCH v5 4/4] RFC: shutdown: Expose full ShutdownCause across QMP

2017-04-28 Thread Eric Blake
[adding Dan in cc] On 04/27/2017 09:13 PM, Eric Blake wrote: > Since all reset/shutdown requests have been associated with a > reason, we can expose the full reason rather than a simple bool > to the guest. Document that any future additions to the enum > type will still use a 'host-' or 'guest-'

[Qemu-devel] replay help [was: [PATCH v5 3/4] shutdown: Add source information to SHUTDOWN and RESET]

2017-04-28 Thread Eric Blake
[trimming cc's] On 04/28/2017 10:01 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Libvirt would like to be able to distinguish between a SHUTDOWN >> event triggered solely by guest request and one triggered by a >> SIGTERM or other action on the host. While qemu_kill_report() is >> alr

Re: [Qemu-devel] [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-04-28 Thread Eric Blake
On 04/28/2017 09:42 AM, Markus Armbruster wrote: > Eric Blake writes: > >> We want to track why a guest was shutdown; in particular, being able >> to tell the difference between a guest request (such as ACPI request) >> and host request (such as SIGINT) will prove useful to libvirt. >> Since all

Re: [Qemu-devel] [PULL 14/34] iotests: Launch qemu-nbd with -e 42

2017-04-28 Thread Eric Blake
On 04/28/2017 03:33 PM, Kevin Wolf wrote: > From: Max Reitz > > There is no reason for the qemu-nbd server used for tests not to accept > an arbitrary number of clients. In fact, test 181 will require it to > accept two clients at the same time (and thus it fails before this > patch). Quick ques

Re: [Qemu-devel] [PATCH v10 09/17] qcow2: Optimize write zero of unaligned tail cluster

2017-04-28 Thread Eric Blake
On 04/28/2017 03:48 PM, Max Reitz wrote: > On 27.04.2017 03:46, Eric Blake wrote: >> We've already improved discards to operate efficiently on the tail >> of an unaligned qcow2 image; it's time to make a similar improvement >> to write zeroes. The special case is only valid at the tail >> cluster

Re: [Qemu-devel] [PATCH v5 + 2/2] target/aarch64: optimize indirect branches

2017-04-28 Thread Emilio G. Cota
On Fri, Apr 28, 2017 at 15:17:25 -0400, Emilio G. Cota wrote: > Measurements: (snip) > -SPECint06 (test set), x86_64-linux-user. Host: > Intel i7-4790K @ 4.00GHz (snip) > - SPECint06 (train set), x86_64-linux-user. Host: > Intel i7-4790K @ 4.0

Re: [Qemu-devel] [PATCH v3] qmp-shell: add persistent command history

2017-04-28 Thread Kashyap Chamarthy
On Thu, Apr 27, 2017 at 06:36:28PM -0400, John Snow wrote: > Use the existing readline history function we are utilizing > to provide persistent command history across instances of qmp-shell. > > This assists entering debug commands across sessions that may be > interrupted by QEMU sessions termin

Re: [Qemu-devel] RFC: some problems with bdrv_get_block_status

2017-04-28 Thread Denis V. Lunev
On 04/28/2017 09:31 PM, Eric Blake wrote: > On 04/28/2017 11:17 AM, Denis V. Lunev wrote: >> Hello, All! >> >> Recently we have experienced problems with very slow >> bdrv_get_block_status call, which is massive called f.e. >> from mirror_run(). >> >> The problem was narrowed down to slow lseek64()

[Qemu-devel] [PATCH] target/openrisc: Support non-busy idle state using PMR SPR

2017-04-28 Thread Stafford Horne
The OpenRISC architecture has the Power Management Register (PMR) special purpose register to manage cpu power states. The interesting modes are: * Doze Mode (DME) - Stop cpu except timer & pic - wake on interrupt * Sleep Mode (SME) - Stop cpu and all units - wake on interrupt * Suspend Model

Re: [Qemu-devel] RFC: some problems with bdrv_get_block_status

2017-04-28 Thread Denis V. Lunev
On 04/28/2017 10:35 PM, Denis V. Lunev wrote: > On 04/28/2017 09:31 PM, Eric Blake wrote: >> On 04/28/2017 11:17 AM, Denis V. Lunev wrote: >>> Hello, All! >>> >>> Recently we have experienced problems with very slow >>> bdrv_get_block_status call, which is massive called f.e. >>> from mirror_run().

Re: [Qemu-devel] [PATCH v10 07/17] qemu-io: Switch 'alloc' command to byte-based length

2017-04-28 Thread Max Reitz
On 28.04.2017 22:36, Eric Blake wrote: > On 04/28/2017 03:09 PM, Max Reitz wrote: >> On 28.04.2017 21:59, Eric Blake wrote: >>> On 04/28/2017 02:46 PM, Max Reitz wrote: On 27.04.2017 03:46, Eric Blake wrote: > For the 'alloc' command, accepting an offset in bytes but a length > in sect

Re: [Qemu-devel] [PATCH v10 09/17] qcow2: Optimize write zero of unaligned tail cluster

2017-04-28 Thread Max Reitz
On 27.04.2017 03:46, Eric Blake wrote: > We've already improved discards to operate efficiently on the tail > of an unaligned qcow2 image; it's time to make a similar improvement > to write zeroes. The special case is only valid at the tail > cluster of a file, where we must recognize that any sec

Re: [Qemu-devel] [PATCH v10 07/17] qemu-io: Switch 'alloc' command to byte-based length

2017-04-28 Thread Eric Blake
On 04/28/2017 03:09 PM, Max Reitz wrote: > On 28.04.2017 21:59, Eric Blake wrote: >> On 04/28/2017 02:46 PM, Max Reitz wrote: >>> On 27.04.2017 03:46, Eric Blake wrote: For the 'alloc' command, accepting an offset in bytes but a length in sectors, and reporting output in sectors, is confu

[Qemu-devel] [PULL 33/34] iotests: fix exclusion option

2017-04-28 Thread Kevin Wolf
From: John Snow If you are running out-of-tree, the -x option to exclude a certain iotest is broken. Replace porcelain usage of ls with a sturdier awk command. Reviewed-by: Fam Zheng Signed-off-by: John Snow Message-id: 20170427205100.9505-3-js...@redhat.com Reviewed-by: Eric Blake Signed-of

[Qemu-devel] [PULL 34/34] progress: Show current progress on SIGINFO

2017-04-28 Thread Kevin Wolf
From: Max Reitz Currently we only print progress information on retrieval of SIGUSR1. Some systems have a dedicated SIGINFO for this, however, so it should be handled appropriately if it is available. Buglink: https://bugs.launchpad.net/qemu/+bug/1662468 Signed-off-by: Max Reitz Message-id: 201

[Qemu-devel] [PULL 30/34] qemu-img: improve convert_iteration_sectors()

2017-04-28 Thread Kevin Wolf
From: Vladimir Sementsov-Ogievskiy Do not do extra call to _get_block_status() Signed-off-by: Vladimir Sementsov-Ogievskiy Message-id: 20170407113404.9351-1-vsement...@virtuozzo.com Reviewed-by: John Snow Signed-off-by: Max Reitz --- qemu-img.c | 32 ++-- 1 file c

[Qemu-devel] [PULL 31/34] qemu-img: use blk_co_pwrite_zeroes for zero sectors when compressed

2017-04-28 Thread Kevin Wolf
From: Lidong Chen When the buffer is zero, blk_co_pwrite_zeroes is more effective than blk_co_pwritev with BDRV_REQ_WRITE_COMPRESSED. This patch can reduce the time for converting qcow2 images with lots of zero data. Signed-off-by: Lidong Chen Message-id: 1493261907-18734-1-git-send-email-lidon

[Qemu-devel] [PULL 24/34] block: Add errp to b{lk,drv}_truncate()

2017-04-28 Thread Kevin Wolf
From: Max Reitz For one thing, this allows us to drop the error message generation from qemu-img.c and blockdev.c and instead have it unified in bdrv_truncate(). Signed-off-by: Max Reitz Message-id: 20170328205129.15138-3-mre...@redhat.com Reviewed-by: Stefan Hajnoczi Signed-off-by: Max Reitz

[Qemu-devel] [PULL 25/34] block: Add errp to BD.bdrv_truncate()

2017-04-28 Thread Kevin Wolf
From: Max Reitz Add an Error parameter to the block drivers' bdrv_truncate() interface. If a block driver does not set this in case of an error, the generic bdrv_truncate() implementation will do so. Where it is obvious, this patch also makes some block drivers set this value. Signed-off-by: Ma

[Qemu-devel] [PULL 27/34] qcow2: Allow discard of final unaligned cluster

2017-04-28 Thread Kevin Wolf
From: Eric Blake As mentioned in commit 0c1bd46, we ignored requests to discard the trailing cluster of an unaligned image. While discard is an advisory operation from the guest standpoint, (and we are therefore free to ignore any request), our qcow2 implementation exploits the fact that a disca

[Qemu-devel] [PULL 28/34] block: fix obvious coding style mistakes in block_int.h

2017-04-28 Thread Kevin Wolf
From: Klim Kireev Signed-off-by: Klim Kireev Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Max Reitz Message-id: 1491405505-31620-2-git-send-email-...@openvz.org Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- include/block/block_int.h | 6 +++--- 1 file changed, 3 insertions(+), 3

[Qemu-devel] [PULL 29/34] block: assert no image modification under BDRV_O_INACTIVE

2017-04-28 Thread Kevin Wolf
From: "Denis V. Lunev" As long as BDRV_O_INACTIVE is set, the image file is only opened so we have a file descriptor for it. We're definitely not supposed to modify the image, it's still owned by the migration source. This commit is an addition to 09e0c771 but the assert() is added to bdrv_trunc

[Qemu-devel] [PULL 26/34] block: Add .bdrv_truncate() error messages

2017-04-28 Thread Kevin Wolf
From: Max Reitz Add missing error messages for the block driver implementations of .bdrv_truncate(); drop the generic one from block.c's bdrv_truncate(). Since one of these changes touches a mis-indented block in block/file-posix.c, this patch fixes that coding style issue along the way. Signed

[Qemu-devel] [PULL 19/34] block: fix alignment calculations in bdrv_co_do_zero_pwritev

2017-04-28 Thread Kevin Wolf
From: "Denis V. Lunev" tail_padding_bytes is calculated wrong. F.e. for offset = 0 bytes = 2048 align = 512 we will have tail_padding_bytes = 512 which is definitely wrong. The patch fixes that arithmetics. Fortunately this problem is harmless, we will have 1 extra allocation and fre

[Qemu-devel] [PULL 07/34] qemu-iotests: Filter HMP readline escape characters

2017-04-28 Thread Kevin Wolf
The only thing the escape characters achieve is making the reference output unreadable and lines that are potentially so long that git doesn't want to put them into an email any more. Let's filter them out. Signed-off-by: Kevin Wolf Reviewed-by: Eric Blake --- tests/qemu-iotests/028.out |

[Qemu-devel] [PULL 32/34] iotests: clarify help text

2017-04-28 Thread Kevin Wolf
From: John Snow Split the help text to highlight the groups of options a little better, carving out a clear "format" and "protocols" section. Signed-off-by: John Snow Message-id: 20170427205100.9505-2-js...@redhat.com Reviewed-by: Eric Blake Signed-off-by: Max Reitz --- tests/qemu-iotests/co

[Qemu-devel] [PULL 17/34] iotests: 109: Filter out "len" of failed jobs

2017-04-28 Thread Kevin Wolf
From: Fam Zheng Mirror calculates job len from current I/O progress: s->common.len = s->common.offset + (cnt + s->sectors_in_flight) * BDRV_SECTOR_SIZE; The final "len" of a failed mirror job in iotests 109 depends on the subtle timing of the completion of read and write

[Qemu-devel] [PULL 15/34] Issue a deprecation warning if the user specifies the "-hdachs" option.

2017-04-28 Thread Kevin Wolf
From: Thomas Huth If the user needs to specify the disk geometry, the corresponding parameters of the "-device ide-hd" option should be used instead. "-hdachs" is considered as deprecated and might be removed soon. Signed-off-by: Thomas Huth Reviewed-by: Eric Blake Signed-off-by: Kevin Wolf -

[Qemu-devel] [PULL 21/34] qemu-img/convert: Move bs_n > 1 && -B check down

2017-04-28 Thread Kevin Wolf
From: Max Reitz It does not make much sense to use a backing image for the target when you concatenate multiple images (because then there is no correspondence between the source images' backing files and the target's); but it was still possible to give one by using -o backing_file=X instead of -

[Qemu-devel] [PULL 23/34] block/vhdx: Make vhdx_create() always set errp

2017-04-28 Thread Kevin Wolf
From: Max Reitz This patch makes vhdx_create() always set errp in case of an error. It also adds errp parameters to vhdx_create_bat() and vhdx_create_new_region_table() so we can pass on the error object generated by blk_truncate() as of a future commit. Signed-off-by: Max Reitz Reviewed-by: Ke

[Qemu-devel] [PULL 18/34] block: Do not unref bs->file on error in BD's open

2017-04-28 Thread Kevin Wolf
From: Max Reitz The block layer takes care of removing the bs->file child if the block driver's bdrv_open()/bdrv_file_open() implementation fails. The block driver therefore does not need to do so, and indeed should not unless it sets bs->file to NULL afterwards -- because if this is not done, th

[Qemu-devel] [PULL 12/34] qemu_iotests: Remove _readlink()

2017-04-28 Thread Kevin Wolf
It is unused. Suggested-by: Fam Zheng Signed-off-by: Kevin Wolf Reviewed-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Fam Zheng --- tests/qemu-iotests/common.config | 18 -- 1 file changed, 18 deletions(-) diff --git a/tests/qemu-iotests/common.config b/tests/qemu-iote

[Qemu-devel] [PULL 20/34] qemu-img/convert: Use @opts for one thing only

2017-04-28 Thread Kevin Wolf
From: Max Reitz After storing the creation options for the new image into @opts, we fetch some things for our own information, like the backing file name, or whether to use encryption or preallocation. With the -n parameter, there will not be any creation options; this is not too bad because thi

[Qemu-devel] [PULL 09/34] block: An empty filename counts as no filename

2017-04-28 Thread Kevin Wolf
From: Max Reitz Reproducer: $ ./qemu-img info '' qemu-img: ./block.c:1008: bdrv_open_driver: Assertion `!drv->bdrv_needs_filename || bs->filename[0]' failed. [1]26105 abort (core dumped) ./qemu-img info '' This patch fixes this to be: $ ./qemu-img info '' qemu-im

[Qemu-devel] [PULL 14/34] iotests: Launch qemu-nbd with -e 42

2017-04-28 Thread Kevin Wolf
From: Max Reitz There is no reason for the qemu-nbd server used for tests not to accept an arbitrary number of clients. In fact, test 181 will require it to accept two clients at the same time (and thus it fails before this patch). This patch updates common.rc to launch qemu-nbd with -e 42 which

[Qemu-devel] [PULL 22/34] qemu-img: Document backing options

2017-04-28 Thread Kevin Wolf
From: Max Reitz The create and convert subcommands have shorthands to set the backing_file and, in the case of create, the backing_fmt options for the new image. However, they have not been documented so far, which is remedied by this patch. Reported-by: Eric Blake Signed-off-by: Max Reitz Rev

[Qemu-devel] [PULL 13/34] block: Remove NULL check in bdrv_co_flush

2017-04-28 Thread Kevin Wolf
From: Fam Zheng Reported by Coverity. We already use bs in bdrv_inc_in_flight before checking for NULL. It is unnecessary as all callers pass non-NULL bs, so drop it. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- block/io.c | 2 +- 1 file changed, 1 insertion(

[Qemu-devel] [PULL 10/34] iotests/051: Add test for empty filename

2017-04-28 Thread Kevin Wolf
From: Max Reitz Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/051| 1 + tests/qemu-iotests/051.out| 3 +++ tests/qemu-iotests/051.pc.out | 3 +++ 3 files changed, 7 insertions(+) diff --git a/tests/qemu-i

[Qemu-devel] [PULL 16/34] iotests: Fix typo in 026

2017-04-28 Thread Kevin Wolf
From: Eric Blake s/refcout/refcount/ CC: qemu-triv...@nongnu.org Signed-off-by: Eric Blake Reviewed-by: Laurent Vivier Signed-off-by: Kevin Wolf --- tests/qemu-iotests/026 | 2 +- tests/qemu-iotests/026.out | 2 +- tests/qemu-iotests/026.out.nocache | 2 +- 3 files change

[Qemu-devel] [PULL 00/34] Block layer patches

2017-04-28 Thread Kevin Wolf
The following changes since commit 81b2d5ceb0cfb4cdc2163492e3169ed714b0cda9: Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20170426' into staging (2017-04-26 20:50:49 +0100) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetc

[Qemu-devel] [PULL 08/34] qemu-iotests: Test postcopy migration

2017-04-28 Thread Kevin Wolf
Signed-off-by: Kevin Wolf Reviewed-by: Dr. David Alan Gilbert --- tests/qemu-iotests/181 | 119 + tests/qemu-iotests/181.out | 38 +++ tests/qemu-iotests/group | 1 + 3 files changed, 158 insertions(+) create mode 100755 tests/qem

[Qemu-devel] [PULL 11/34] qemu-iotests: Remove PERL_PROG and BC_PROG

2017-04-28 Thread Kevin Wolf
We test for the presence of perl and bc and save their path in the variables PERL_PROG and BC_PROG, but never actually make use of them. Remove the checks and assignments so qemu-iotests can run even when bc isn't installed. Reported-by: Yash Mankad Signed-off-by: Kevin Wolf Reviewed-by: Eric Bl

[Qemu-devel] [PULL 01/34] block: Constify data passed by pointer to blk_name

2017-04-28 Thread Kevin Wolf
From: Krzysztof Kozlowski blk_name() is not modifying data passed to it through pointer and it returns also a pointer to const so the argument can be made const for code safeness. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Kevin Wolf --- block/block

[Qemu-devel] [PULL 06/34] migration: Call blk_resume_after_migration() for postcopy

2017-04-28 Thread Kevin Wolf
Commit d35ff5e6 ('block: Ignore guest dev permissions during incoming migration') added blk_resume_after_migration() to the precopy migration path, but neglected to add it to the duplicated code that is used for postcopy migration. This means that the guest device doesn't request the necessary perm

[Qemu-devel] [PULL 05/34] qemu-img: simplify img_convert

2017-04-28 Thread Kevin Wolf
From: Peter Lieven img_convert has been around before there was an ImgConvertState or a block backend, but it has never been modified to directly use these structs. Change this by parsing parameters directly into the ImgConvertState and directly use BlockBackend where possible. Furthermore variab

[Qemu-devel] [PULL 02/34] file-posix: Remove unnecessary includes

2017-04-28 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/file-posix.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/file-posix.c b/block/file-posix.c index 0c48968..ade71db 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -25,8 +25,6 @@ #include "qapi/error.h" #include "qemu/cutils.h" #incl

[Qemu-devel] [PULL 04/34] Revert "block/io: Comment out permission assertions"

2017-04-28 Thread Kevin Wolf
From: Max Reitz This reverts commit e3e0003a8f6570aba1421ef99a0b383a43371a74. This commit was necessary for the 2.9 release because we were unable to fix the underlying issue(s) in time. However, we will be for 2.10. Signed-off-by: Max Reitz Acked-by: Fam Zheng Signed-off-by: Kevin Wolf ---

[Qemu-devel] [PULL 03/34] file-win32: Remove unnecessary include

2017-04-28 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- block/file-win32.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/file-win32.c b/block/file-win32.c index 800fabd..e132ba1 100644 --- a/block/file-win32.c +++ b/block/file-win32.c @@ -24,7 +24,6 @@ #include "qemu/osdep.h" #include "qapi/error.h" #include

Re: [Qemu-devel] [PATCH v10 01/17] block: Update comments on BDRV_BLOCK_* meanings

2017-04-28 Thread Eric Blake
On 04/26/2017 08:46 PM, Eric Blake wrote: > We had some conflicting documentation: a nice 8-way table that > described all possible combinations of DATA, ZERO, and > OFFSET_VALID, couple with text that implied that OFFSET_VALID > always meant raw data could be read directly. As the 8-way > table i

Re: [Qemu-devel] [PATCH v10 07/17] qemu-io: Switch 'alloc' command to byte-based length

2017-04-28 Thread Max Reitz
On 28.04.2017 21:59, Eric Blake wrote: > On 04/28/2017 02:46 PM, Max Reitz wrote: >> On 27.04.2017 03:46, Eric Blake wrote: >>> For the 'alloc' command, accepting an offset in bytes but a length >>> in sectors, and reporting output in sectors, is confusing. Do >>> everything in bytes, and adjust t

Re: [Qemu-devel] [PATCH v10 08/17] qemu-io: Switch 'map' output to byte-based reporting

2017-04-28 Thread Eric Blake
On 04/28/2017 02:53 PM, Max Reitz wrote: > On 27.04.2017 03:46, Eric Blake wrote: >> Mixing byte offset and sector allocation counts is a bit >> confusing. Also, reporting n/m sectors, where m decreases >> according to the remaining size of the file, isn't really >> adding any useful information.

Re: [Qemu-devel] [PATCH v10 07/17] qemu-io: Switch 'alloc' command to byte-based length

2017-04-28 Thread Eric Blake
On 04/28/2017 02:46 PM, Max Reitz wrote: > On 27.04.2017 03:46, Eric Blake wrote: >> For the 'alloc' command, accepting an offset in bytes but a length >> in sectors, and reporting output in sectors, is confusing. Do >> everything in bytes, and adjust the expected output accordingly. >> >> Signed-

Re: [Qemu-devel] [PATCH v10 08/17] qemu-io: Switch 'map' output to byte-based reporting

2017-04-28 Thread Max Reitz
On 27.04.2017 03:46, Eric Blake wrote: > Mixing byte offset and sector allocation counts is a bit > confusing. Also, reporting n/m sectors, where m decreases > according to the remaining size of the file, isn't really > adding any useful information. Since this map doesn't leave out any range in

Re: [Qemu-devel] [PATCH v10 05/17] iotests: Add test 179 to cover write zeroes with unmap

2017-04-28 Thread Eric Blake
On 04/28/2017 02:28 PM, Max Reitz wrote: > On 27.04.2017 03:46, Eric Blake wrote: >> No tests were covering write zeroes with unmap. Additionally, >> I needed to prove that my previous patches for correct status >> reporting and write zeroes optimizations actually had an impact. >> >> The test wor

Re: [Qemu-devel] [PATCH v10 07/17] qemu-io: Switch 'alloc' command to byte-based length

2017-04-28 Thread Max Reitz
On 27.04.2017 03:46, Eric Blake wrote: > For the 'alloc' command, accepting an offset in bytes but a length > in sectors, and reporting output in sectors, is confusing. Do > everything in bytes, and adjust the expected output accordingly. > > Signed-off-by: Eric Blake > Reviewed-by: Philippe Mat

Re: [Qemu-devel] [PATCH v10 06/17] qemu-io: Don't open-code QEMU_IS_ALIGNED

2017-04-28 Thread Max Reitz
On 27.04.2017 03:46, Eric Blake wrote: > Manual comparison against 0x1ff is not as clean as using our > alignment macros from osdep.h. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Eric Blake > > --- > v10: new patch > --- > qemu-io-cmds.c | 10 +- > 1 file changed, 5 inser

Re: [Qemu-devel] [PATCH v10 05/17] iotests: Add test 179 to cover write zeroes with unmap

2017-04-28 Thread Max Reitz
On 27.04.2017 03:46, Eric Blake wrote: > No tests were covering write zeroes with unmap. Additionally, > I needed to prove that my previous patches for correct status > reporting and write zeroes optimizations actually had an impact. > > The test works for cluster_size between 8k and 2M (for smal

Re: [Qemu-devel] [PATCH v5 + 1/2] target/aarch64: optimize cross-page direct jumps in softmmu

2017-04-28 Thread Emilio G. Cota
On Fri, Apr 28, 2017 at 15:17:24 -0400, Emilio G. Cota wrote: > Perf numbers in next commit's log. > > Signed-off-by: Emilio G. Cota > --- > target/arm/translate-a64.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/arm/translate-a64.c b/target/arm/translate-a6

[Qemu-devel] [PATCH v5+] TCG cross-tb optimizations

2017-04-28 Thread Emilio G. Cota
While at it, we might want to include these two for aarch64. They apply on top Richard's tcg-next branch, which includes v5. Thanks, Emilio

[Qemu-devel] [PATCH v5 + 2/2] target/aarch64: optimize indirect branches

2017-04-28 Thread Emilio G. Cota
Measurements: [Baseline performance is that before applying this and the previous commit] -NBench, aarch64-softmmu. Host: Intel i7-4790K @ 4.00GHz 1.7x +-+--

[Qemu-devel] [PATCH v5 + 1/2] target/aarch64: optimize cross-page direct jumps in softmmu

2017-04-28 Thread Emilio G. Cota
Perf numbers in next commit's log. Signed-off-by: Emilio G. Cota --- target/arm/translate-a64.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 24de30d..5b691fc 100644 --- a/target/arm/translate-a64.c +++ b/targe

Re: [Qemu-devel] [PATCH v2] i386: Allow cpuid bit override

2017-04-28 Thread Eduardo Habkost
On Tue, Apr 18, 2017 at 04:19:10PM -0500, Eric Blake wrote: > On 04/18/2017 04:01 PM, Michael Roth wrote: > > >>> @@ -3706,8 +3707,17 @@ static void x86_cpu_get_bit_prop(Object *obj, > >>> Visitor *v, const char *name, > >>> X86CPU *cpu = X86_CPU(obj); > >>> BitProperty *fp = opaque; >

Re: [Qemu-devel] [PATCH v2 00/25] qmp: add async command type

2017-04-28 Thread Kevin Wolf
Am 28.04.2017 um 17:55 hat Marc-André Lureau geschrieben: > On Tue, Apr 25, 2017 at 2:23 PM Kevin Wolf wrote: > > > Am 24.04.2017 um 21:10 hat Markus Armbruster geschrieben: > > > With 2.9 out of the way, how can we make progress on this one? > > > > > > I can see two ways to get asynchronous QMP

Re: [Qemu-devel] [PATCH v10 04/17] qcow2: Optimize zero_single_l2() to minimize L2 churn

2017-04-28 Thread Eric Blake
On 04/28/2017 01:00 PM, Max Reitz wrote: > On 27.04.2017 03:46, Eric Blake wrote: >> Similar to discard_single_l2(), we should try to avoid dirtying >> the L2 cache when the cluster we are changing already has the >> right characteristics. >> >> -/* Update L2 entries */ >> +/* >> +

Re: [Qemu-devel] [PATCH v10 02/17] qcow2: Correctly report status of preallocated zero clusters

2017-04-28 Thread Eric Blake
On 04/28/2017 12:35 PM, Max Reitz wrote: > On 27.04.2017 03:46, Eric Blake wrote: >> We were throwing away the preallocation information associated with >> zero clusters. But we should be matching the well-defined semantics >> in bdrv_get_block_status(), where (BDRV_BLOCK_ZERO | >> BDRV_BLOCK_OFFS

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

2017-04-28 Thread Eric Blake
On 04/25/2017 05:30 AM, Juan Quintela wrote: > We have change in the previous patch to use migration capabilities for > it. Notice that we continue using the old command line flags from > migrate command from the time being. Remove the set_params method as > now it is empty. > > Signed-off-by: J

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add qemu-progress to the block layer

2017-04-28 Thread Eric Blake
On 04/28/2017 11:55 AM, Max Reitz wrote: > util/qemu-progress.c is currently unmaintained. The only user of its > functionality is qemu-img, so it effectively is part of the block layer. > > Suggested-by: Fam Zheng > Signed-off-by: Max Reitz > --- > MAINTAINERS | 1 + > 1 file changed, 1 insert

Re: [Qemu-devel] RFC: some problems with bdrv_get_block_status

2017-04-28 Thread Eric Blake
On 04/28/2017 11:17 AM, Denis V. Lunev wrote: > Hello, All! > > Recently we have experienced problems with very slow > bdrv_get_block_status call, which is massive called f.e. > from mirror_run(). > > The problem was narrowed down to slow lseek64() system > call, which can take 1-2-3 seconds. I'

Re: [Qemu-devel] [PATCH v15 20/21] file-posix: Add image locking to perm operations

2017-04-28 Thread Kevin Wolf
Am 28.04.2017 um 17:30 hat Fam Zheng geschrieben: > On Fri, 04/28 15:45, Kevin Wolf wrote: > > Am 26.04.2017 um 05:34 hat Fam Zheng geschrieben: > > > This extends the permission bits of op blocker API to external using > > > Linux OFD locks. > > > > > > Each permission in @perm and @shared_perm i

Re: [Qemu-devel] [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-04-28 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 04/28/2017 11:09 AM, Dr. David Alan Gilbert wrote: > > >>> At a higher level, using your tags, I'm not sure where a reset triggered > >>> by a fault detected by the hypervisor lives - e.g. an x86 triple fault > >>> where the guest screws up so badly tha

Re: [Qemu-devel] [PATCH v5 2/4] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-04-28 Thread Eric Blake
On 04/28/2017 11:09 AM, Dr. David Alan Gilbert wrote: >>> At a higher level, using your tags, I'm not sure where a reset triggered >>> by a fault detected by the hypervisor lives - e.g. an x86 triple fault >>> where the guest screws up so badly that it just gets reset. Is >>> that a guest-reset o

Re: [Qemu-devel] [PATCH v10 04/17] qcow2: Optimize zero_single_l2() to minimize L2 churn

2017-04-28 Thread Max Reitz
On 27.04.2017 03:46, Eric Blake wrote: > Similar to discard_single_l2(), we should try to avoid dirtying > the L2 cache when the cluster we are changing already has the > right characteristics. > > Note that by the time we get to zero_single_l2(), BDRV_REQ_MAY_UNMAP > is a requirement to unallocat

Re: [Qemu-devel] [PATCH v10 03/17] qcow2: Reuse preallocated zero clusters

2017-04-28 Thread Max Reitz
On 27.04.2017 03:46, Eric Blake wrote: > From: Max Reitz > > Instead of just freeing preallocated zero clusters and completely > allocating them from scratch, reuse them. > > We cannot do this in handle_copied(), however, since this is a COW > operation. Therefore, we have to add the new logic t

Re: [Qemu-devel] [PATCH v5 13/19] tb-hash: improve tb_jmp_cache hash function in user mode

2017-04-28 Thread Emilio G. Cota
On Fri, Apr 28, 2017 at 18:00:57 +0100, Alex Bennée wrote: > I'll note when I've plotted hit-rates against the cache we don't seem to > be making a good even use of the cache over time. But I suspect there is > more that could be done here. If you're talking about full-system mode here, then yes,

Re: [Qemu-devel] [PATCH v10 02/17] qcow2: Correctly report status of preallocated zero clusters

2017-04-28 Thread Max Reitz
On 27.04.2017 03:46, Eric Blake wrote: > We were throwing away the preallocation information associated with > zero clusters. But we should be matching the well-defined semantics > in bdrv_get_block_status(), where (BDRV_BLOCK_ZERO | > BDRV_BLOCK_OFFSET_VALID) informs the user which offset is rese

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/4] hw/ppc: setting spapr_drc_detach_cb in spapr_dr_connector_new

2017-04-28 Thread Daniel Henrique Barboza
On 04/26/2017 07:09 PM, Michael Roth wrote: Quoting Daniel Henrique Barboza (2017-04-26 16:31:21) The idea of moving the detach callback functions to the constructor of the dr_connector is to set them statically at init time, avoiding any post-load hooks to restore it (after a migration, for e

Re: [Qemu-devel] [PATCH 31/41] migration: Move postcopy stuff to postcopy-ram.c

2017-04-28 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Yes, we don't have a good place to put that stuff. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 25 - > migration/migration.c | 18 --

Re: [Qemu-devel] [PATCH v10 01/17] block: Update comments on BDRV_BLOCK_* meanings

2017-04-28 Thread Max Reitz
On 27.04.2017 03:46, Eric Blake wrote: > We had some conflicting documentation: a nice 8-way table that > described all possible combinations of DATA, ZERO, and > OFFSET_VALID, couple with text that implied that OFFSET_VALID > always meant raw data could be read directly. As the 8-way > table is t

Re: [Qemu-devel] [PATCH v5 14/19] target/alpha: Use tcg_gen_goto_ptr

2017-04-28 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > target/alpha/translate.c | 49 > +++- > 1 file changed, 36 insertions(+), 13 deletions(-) > > diff --git a/target/alpha/translate.c b/target/alpha/translate.c > index df5d695..c1a5

Re: [Qemu-devel] [PATCH v5 11/19] target/i386: optimize cross-page direct jumps in softmmu

2017-04-28 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > Instead of unconditionally exiting to the exec loop, use the > gen_jr helper to jump to the target if it is valid. > > Perf impact: see next commit's log. > > Reviewed-by: Richard Henderson > Signed-off-by: Emilio G. Cota > Message-Id: <1

Re: [Qemu-devel] [PATCH v5 13/19] tb-hash: improve tb_jmp_cache hash function in user mode

2017-04-28 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > Optimizations to cross-page chaining and indirect branches make > performance more sensitive to the hit rate of tb_jmp_cache. > The constraint of reserving some bits for the page number > lowers the achievable quality of the hashing functio

[Qemu-devel] [PATCH] MAINTAINERS: Add qemu-progress to the block layer

2017-04-28 Thread Max Reitz
util/qemu-progress.c is currently unmaintained. The only user of its functionality is qemu-img, so it effectively is part of the block layer. Suggested-by: Fam Zheng Signed-off-by: Max Reitz --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a1d2

Re: [Qemu-devel] [PATCH v5 12/19] target/i386: optimize indirect branches

2017-04-28 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > Speed up indirect branches by jumping to the target if it is valid. > > Softmmu measurements (see later commit for user-mode numbers): > > Note: baseline (i.e. speedup == 1x) is QEMU v2.9.0. > > - SPECint06 (test set), x86_

Re: [Qemu-devel] [PATCH 3/3] migration: Remove old MigrationParams

2017-04-28 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Not used anymore after moving block migration to use capabilities. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 10 ++ > include/migration/vmstate.h | 1 - > include/qemu/

[Qemu-devel] [Qemu-devel RFC v3 5/5] msf2: Add Emcraft's Smartfusion2 SOM kit.

2017-04-28 Thread Subbaraya Sundeep
Emulated Emcraft's Smartfusion2 System On Module starter kit. Signed-off-by: Subbaraya Sundeep --- hw/arm/Makefile.objs | 1 + hw/arm/msf2_som.c| 68 2 files changed, 69 insertions(+) create mode 100644 hw/arm/msf2_som.c diff --git a/hw

[Qemu-devel] [Qemu-devel RFC v3 4/5] msf2: Add Smartfusion2 SoC.

2017-04-28 Thread Subbaraya Sundeep
Smartfusion2 SoC has hardened Microcontroller subsystem and flash based FPGA fabric. This patch adds support for Microcontroller subsystem in the SoC. Signed-off-by: Subbaraya Sundeep --- default-configs/arm-softmmu.mak | 1 + hw/arm/Makefile.objs| 2 +- hw/arm/msf2_soc.c

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

2017-04-28 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > We have change in the previous patch to use migration capabilities for > it. Notice that we continue using the old command line flags from > migrate command from the time being. Remove the set_params method as > now it is empty. > > Signed-off-by: J

[Qemu-devel] [Qemu-devel RFC v3 3/5] msf2: Add Smartfusion2 SPI controller

2017-04-28 Thread Subbaraya Sundeep
Modelled Microsemi's Smartfusion2 SPI controller. Signed-off-by: Subbaraya Sundeep --- Hi Peter and Alistair, I created two SPI controllers as per SoC spec in hw/arm/msf2_soc.c. I am assuming there has to be two busses spi0 and spi1 one for each controller. In board file (hw/arm/msf2_som.c) att

[Qemu-devel] [Qemu-devel RFC v3 2/5] msf2: Microsemi Smartfusion2 System Register block.

2017-04-28 Thread Subbaraya Sundeep
Added Sytem register block of Smartfusion2. This block has PLL registers which are accessed by guest. Signed-off-by: Subbaraya Sundeep --- hw/misc/Makefile.objs | 1 + hw/misc/msf2_sysreg.c | 127 ++ include/hw/misc/msf2_sysreg.h | 77 ++

[Qemu-devel] [Qemu-devel RFC v3 0/5] Add support for Smartfusion2 SoC

2017-04-28 Thread Subbaraya Sundeep
Hi Qemu-devel, I am trying to add Smartfusion2 SoC. SoC is from Microsemi and System on Module(SOM) board is from Emcraft systems. Smartfusion2 has hardened Microcontroller(Cortex-M3)based Sub System and FPGA fabric. At the moment only system timer, sysreg and SPI controller are modelled. Testing

[Qemu-devel] [Qemu-devel RFC v3 1/5] msf2: Add Smartfusion2 System timer

2017-04-28 Thread Subbaraya Sundeep
Modelled System Timer in Microsemi's Smartfusion2 Soc. Timer has two 32bit down counters and two interrupts. Signed-off-by: Subbaraya Sundeep --- hw/timer/Makefile.objs| 1 + hw/timer/msf2_timer.c | 250 ++ include/hw/timer/msf2_timer.h |

Re: [Qemu-devel] [PATCH v5 10/19] target/i386: introduce gen_jr helper to generate lookup_and_goto_ptr

2017-04-28 Thread Alex Bennée
Richard Henderson writes: > From: "Emilio G. Cota" > > This helper will be used by subsequent changes. > > Signed-off-by: Emilio G. Cota > Message-Id: <1493263764-18657-9-git-send-email-c...@braap.org> > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > target/i386/transla

Re: [Qemu-devel] [PATCH] progress: Show current progress on SIGINFO

2017-04-28 Thread Max Reitz
On 08.02.2017 00:57, Max Reitz wrote: > Currently we only print progress information on retrieval of SIGUSR1. > Some systems have a dedicated SIGINFO for this, however, so it should be > handled appropriately if it is available. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1662468 > Signed-of

Re: [Qemu-devel] [PATCH 0/2] iotests: trivial fixups

2017-04-28 Thread Max Reitz
On 27.04.2017 22:50, John Snow wrote: > Excised from an old patchset from 2015, just a couple of touchups. > > John Snow (2): > iotests: clarify help text > iotests: fix exclusion option > > tests/qemu-iotests/common | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) Thanks

  1   2   3   >