Coroutine in block layer should always be waken up in bs->aio_context
rather than the "current" context where it is entered. They differ when
the main loop is doing QMP tasks.
Race conditions happen without this patch, because the wrong context is
acquired in co_schedule_bh_cb, while the entered c
On Fri, Apr 7, 2017 at 1:22 PM, 858585 jemmy wrote:
> the test result for this patch:
>
> the migration command :
> virsh migrate --live 165cf436-312f-47e7-90f2-f8aa63f34893
> --copy-storage-all qemu+ssh://10.59.163.38/system
>
> the qemu-img info on source host:
> qemu-img info
> /instanceimage/
Previously, before test_block_job_start returns, the job can already
complete, as a result, the transactional state of other jobs added to
the same txn later cannot be handled correctly.
Move the block_job_start() calls to callers after
block_job_txn_add_job() calls.
Signed-off-by: Fam Zheng
---
It should be moved to the same context as source, before inserting to the
graph.
Reviewed-by: Eric Blake
Reviewed-by: Kevin Wolf
Signed-off-by: Fam Zheng
---
block/mirror.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/mirror.c b/block/mirror.c
index 9e2fecc..e904fef 100644
--- a/b
Suggested-by: Kevin Wolf
Signed-off-by: Fam Zheng
---
block.c | 4
1 file changed, 4 insertions(+)
diff --git a/block.c b/block.c
index 927ba89..b8a3011 100644
--- a/block.c
+++ b/block.c
@@ -1752,6 +1752,9 @@ static void bdrv_replace_child_noperm(BdrvChild *child,
{
BlockDriverState
The fact that the bs->aio_context is changing can confuse the dataplane
iothread, because of the now fine granularity aio context lock.
bdrv_drain should rather be a bdrv_drained_begin/end pair, but since
bs->aio_context is changing, we can just use aio_disable_external and
block_job_pause.
Report
v2: - Drop patch 4 in v1. A second thought made me feel neither it nor Kevin's
suggestion to move the BH process to bdrv_drain_recurse/BDRV_POLL_WHILE
is a complete fix. So leave it for a separate patch.
- Add rev-by to patches 1, 3, 4.
- Split from patch 1 in v1 and add patch 2
bdrv_replace_child_noperm tries to hand over the quiesce_counter state
from old bs to the new one, but if they are not on the same aio context
this causes unbalance.
Fix this by setting the correct aio context before calling
bdrv_append().
Reported-by: Ed Swierk
Reviewed-by: Eric Blake
Signed-o
I can confirm this solves the boot-time kernel panic on macOS 10.12.4
guests. No apparent regressions for earlier OS versions I tested,
either. Code looks sane to me. I guess the only thing is I assume this
was backed by some kind of investigation into what the real hardware
does. If that investiga
Looks good to me.
Reviewed-by: Phil Dennis-Jordan
On Wed, Apr 5, 2017 at 5:01 AM, Gabriel L. Somlo wrote:
> Signed-off-by: Gabriel Somlo
> Reviewed-by: Alexander Graf
> Reviewed-by: Philippe Mathieu-Daudé
> ---
> hw/misc/applesmc.c | 98
> --
On 6 April 2017 at 19:58, G 3 wrote:
>
> On Apr 6, 2017, at 12:00 PM, qemu-devel-requ...@nongnu.org wrote:
>
> Dear QEMU developers,
>>
>> I need multiple ARM-based hardware emulation runing simultaneously in one
>> PC.
>> I wander if QEMU is capble to run two system emulation at the same time.
>
On 04/06/2017 11:53 PM, Benjamin Herrenschmidt wrote:
> On Thu, 2017-04-06 at 14:35 +0200, Cédric Le Goater wrote:
>> but real HW (2 sockets OpenPOWER systems, garrison and firestone)
>> does
>> not expose the LPC bus on the second chip, should we do so in qemu ?
>
> It's not so much HW as it it
On 04/06/2017 11:54 PM, Benjamin Herrenschmidt wrote:
> On Thu, 2017-04-06 at 14:44 +0200, Cédric Le Goater wrote:
>> May be we could move that under the LPC object even if it is not
>> strictly
>> correct from a HW pov ?
>
> I'm not fan of this. It's really not part of the LPC controller and
> i
Signed-off-by: Nikunj A Dadhania
---
target/ppc/translate.c | 8
1 file changed, 8 insertions(+)
diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 50b6d4d..4a1f24a 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -2971,6 +2971,7 @@ static void gen_sts
Emulating LL/SC with cmpxchg is not correct, since it can suffer from
the ABA problem. However, portable parallel code is written assuming
only cmpxchg which means that in practice this is a viable alternative.
Signed-off-by: Nikunj A Dadhania
---
target/ppc/translate.c | 29
The series enables Multi-Threaded TCG on PPC64
Patch 01: Use atomic_cmpxchg in store conditional
02: Handle first write to page during atomic operation
03: Generate memory barriers for sync/isync and load/store conditional
Patches are based on ppc-for-2.10
Changelog:
v1:
* Rewrote st
In case where the conditional write is the first write to the page,
TLB_NOTDIRTY will be set and stop_the_world is triggered. Handle this as
a special case and set the dirty bit. After that fall through to the
actual atomic instruction below.
Signed-off-by: Nikunj A Dadhania
Reviewed-by: Richard
On 04/07/2017 07:24 AM, Nikunj A Dadhania wrote:
> Cédric Le Goater writes:
>
>> Hello Nikunj,
>>
>> On 04/06/2017 12:22 PM, Nikunj A Dadhania wrote:
>>> The series enables Multi-Threaded TCG on PPC64
>>>
>>> Patch 01: Use atomic_cmpxchg in store conditional
>>> 02: Handle first write to pa
David Gibson writes:
> [ Unknown signature status ]
> On Thu, Apr 06, 2017 at 03:52:47PM +0530, Nikunj A Dadhania wrote:
>> Emulating LL/SC with cmpxchg is not correct, since it can suffer from
>> the ABA problem. However, portable parallel code is written assuming
>> only cmpxchg which means tha
On Thu, Apr 06, 2017 at 03:52:47PM +0530, Nikunj A Dadhania wrote:
> Emulating LL/SC with cmpxchg is not correct, since it can suffer from
> the ABA problem. However, portable parallel code is written assuming
> only cmpxchg which means that in practice this is a viable alternative.
>
> Signed-off
Cédric Le Goater writes:
> Hello Nikunj,
>
> On 04/06/2017 12:22 PM, Nikunj A Dadhania wrote:
>> The series enables Multi-Threaded TCG on PPC64
>>
>> Patch 01: Use atomic_cmpxchg in store conditional
>> 02: Handle first write to page during atomic operation
>> 03: Generate memory bar
the test result for this patch:
the migration command :
virsh migrate --live 165cf436-312f-47e7-90f2-f8aa63f34893
--copy-storage-all qemu+ssh://10.59.163.38/system
the qemu-img info on source host:
qemu-img info
/instanceimage/165cf436-312f-47e7-90f2-f8aa63f34893/165cf436-312f-47e7-90f2-f8aa63f3
Richard Henderson writes:
> On 04/06/2017 03:22 AM, Nikunj A Dadhania wrote:
>> @@ -3028,6 +3030,7 @@ static void gen_##name(DisasContext *ctx)
>> \
>> tcg_gen_qemu_ld_tl(gpr, t0, ctx->mem_idx, memop);\
>> tcg_gen_mov_tl(cpu_reserve, t0);
Richard Henderson writes:
> On 04/06/2017 03:22 AM, Nikunj A Dadhania wrote:
>> tcg_gen_trunc_tl_i32(cpu_crf[0], cpu_so);
>> l1 = gen_new_label();
>> tcg_gen_brcond_tl(TCG_COND_NE, EA, cpu_reserve, l1);
>> -tcg_gen_ori_i32(cpu_crf[0], cpu_crf[0], CRF_EQ);
>> -tcg_gen_qemu_s
Richard Henderson writes:
> On 04/06/2017 03:22 AM, Nikunj A Dadhania wrote:
>> +TCGv_i32 tmp = tcg_temp_local_new_i32();
>> +TCGv t0;
>>
>> +tcg_gen_movi_i32(tmp, 0);
>> tcg_gen_trunc_tl_i32(cpu_crf[0], cpu_so);
>> l1 = gen_new_label();
>> tcg_gen_brcond_tl(TCG_COND_NE
On Thu, Apr 06, 2017 at 07:46:47PM +0800, Peter Xu wrote:
> On Thu, Apr 06, 2017 at 12:52:19PM +0200, Auger Eric wrote:
> > Hi Peter,
> >
> > On 06/04/2017 09:08, Peter Xu wrote:
[...]
> > > +void memory_region_iommu_replay_all(MemoryRegion *mr)
> > > +{
> > > +IOMMUNotifier *notifier;
> > >
Hi Laszlo,
thanks.
On 2017/4/7 2:55, Laszlo Ersek wrote:
> On 04/06/17 14:35, gengdongjiu wrote:
>> Dear, Laszlo
>>Thanks for your detailed explanation.
>>
>> On 2017/3/29 19:58, Laszlo Ersek wrote:
>>> (This ought to be one of the longest address lists I've ever seen :)
>>> Thanks for the C
Hi i can help test it too on my two Be machine.
If some one help me to find where is the patch or where i can download the
commits
Thanks
Luigi
As mentioned in commit 0c1bd46, we ignored requests to
discard the trailing cluster of an unaligned image. While
discard is an advisory operation from the guest standpoint,
(and we are therefore free to ignore any request), our
qcow2 implementation exploits the fact that a discarded
cluster reads
On Thu, Apr 6, 2017 at 10:02 PM, Stefan Hajnoczi wrote:
> On Wed, Apr 05, 2017 at 05:27:58PM +0800, jemmy858...@gmail.com wrote:
>> From: Lidong Chen
>>
>> when migration with high speed, mig_save_device_bulk invoke
>> bdrv_is_allocated too frequently, and cause vnc reponse slowly.
>> this patch
On Thu, 04/06 17:17, Kevin Wolf wrote:
> Am 06.04.2017 um 16:25 hat Fam Zheng geschrieben:
> > The fact that the bs->aio_context is changing can confuse the dataplane
> > iothread, because of the now fine granularity aio context lock.
> > bdrv_drain should rather be a bdrv_drained_begin/end pair, b
On Thu, 04/06 16:36, Kevin Wolf wrote:
> Am 06.04.2017 um 16:25 hat Fam Zheng geschrieben:
> > bdrv_replace_child_noperm tries to hand over the quiesce_counter state
> > from old bs to the new one, but if they are not on the same aio context
> > this causes unbalance.
> >
> > Fix this by forcing c
The NVIDIA BAR5 quirk is targeting an ioport BAR. Some older devices
have a BAR5 which is not ioport and can induce a segfault here. Test
the BAR type to skip these devices.
Link: https://bugs.launchpad.net/qemu/+bug/1678466
Signed-off-by: Alex Williamson
---
hw/vfio/pci-quirks.c |2 +-
1
The following changes since commit 54d689988c847271d87b3eb113712147129fb811:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
staging (2017-04-06 09:27:49 +0100)
are available in the git repository at:
git://github.com/awilliam/qemu-vfio.git tags/vfio-updates-20170406.0
On Thu, 2017-04-06 at 14:44 +0200, Cédric Le Goater wrote:
> May be we could move that under the LPC object even if it is not
> strictly
> correct from a HW pov ?
I'm not fan of this. It's really not part of the LPC controller and
it's specific to a certain crop of P8 machines.
Cheers,
Ben.
On Thu, 2017-04-06 at 14:35 +0200, Cédric Le Goater wrote:
> but real HW (2 sockets OpenPOWER systems, garrison and firestone)
> does
> not expose the LPC bus on the second chip, should we do so in qemu ?
It's not so much HW as it it HostBoot. Not a huge deal.
Cheers,
Ben.
On Thu, Apr 06, 2017 at 04:23:19PM -0500, Eric Blake wrote:
> On 04/06/2017 04:15 PM, Richard W.M. Jones wrote:
>
> +++ b/block/io.c
> @@ -945,6 +945,8 @@ static int coroutine_fn
> bdrv_co_do_copy_on_readv(BdrvChild *child,
> size_t skip_bytes;
> int ret;
>
On 04/06/2017 04:15 PM, Richard W.M. Jones wrote:
+++ b/block/io.c
@@ -945,6 +945,8 @@ static int coroutine_fn
bdrv_co_do_copy_on_readv(BdrvChild *child,
size_t skip_bytes;
int ret;
+assert(child->perm & (BLK_PERM_WRITE_UNCHANGED | BLK_PERM_WRITE
Our current ACPI table generation code limits the placement of ACPI
tables to 32-bit addressable memory, in order to be able to emit the
root pointer (RSDP) and root table (RSDT) using table types from the
ACPI 1.0 days.
Since ARM was not supported by ACPI before version 5.0, it makes sense
to lif
On Thu, Apr 06, 2017 at 04:03:28PM -0500, Eric Blake wrote:
> On 04/06/2017 03:59 PM, Richard W.M. Jones wrote:
> > On Tue, Feb 28, 2017 at 09:36:42PM +0100, Kevin Wolf wrote:
> >> This adds assertions that ensure that the necessary write permissions
> >> have been granted before someone attempts t
qemu_kill_report() is already able to tell whether a shutdown
was triggered by guest action (no output) or by a host signal
(a message about termination is printed via error_report); but
this information is then lost. Libvirt would like to be able
to distinguish between a SHUTDOWN event triggered
On 04/06/2017 03:59 PM, Richard W.M. Jones wrote:
> On Tue, Feb 28, 2017 at 09:36:42PM +0100, Kevin Wolf wrote:
>> This adds assertions that ensure that the necessary write permissions
>> have been granted before someone attempts to write to a node.
>>
>> Signed-off-by: Kevin Wolf
>> Acked-by: Fam
On Tue, Feb 28, 2017 at 09:36:42PM +0100, Kevin Wolf wrote:
> This adds assertions that ensure that the necessary write permissions
> have been granted before someone attempts to write to a node.
>
> Signed-off-by: Kevin Wolf
> Acked-by: Fam Zheng
> Reviewed-by: Max Reitz
> ---
> block/io.c |
On Thu, Apr 06, 2017 at 10:45:54PM +0300, Yuval Shaia wrote:
> > Just add my 2 cents. You didn't answer on my question about other possible
> > implementations. It can be SoftRoCE loopback optimizations, special ULP,
> > RDMA transport, virtual driver with multiple VFs and single PF.
>
> Please s
On Thu, Apr 06, 2017 at 10:42:20PM +0300, Yuval Shaia wrote:
> > I'd rather see someone optimize the loopback path of soft roce than
> > see KDBR :)
>
> Can we assume that the optimized loopback path will be as fast as direct
> copy between one VM address space to another VM address space?
Well,
On Tue, Apr 04, 2017 at 08:33:49PM +0300, Leon Romanovsky wrote:
>
> I'm not going to repeat Jason's answer, I'm completely agree with him.
>
> Just add my 2 cents. You didn't answer on my question about other possible
> implementations. It can be SoftRoCE loopback optimizations, special ULP,
> R
On Tue, Apr 04, 2017 at 10:01:55AM -0600, Jason Gunthorpe wrote:
> On Tue, Apr 04, 2017 at 04:38:40PM +0300, Marcel Apfelbaum wrote:
>
> > Here are some thoughts regarding the Soft RoCE usage in our project.
> > We thought about using it as backend for QEMU pvrdma device
> > we didn't how it will
When a block device that is part of a throttle group is hot-unplugged,
we forgot to remove it from the throttle group. This leaves stale
memory around, and causes an easily reproducible crash:
$ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -nographic -qmp stdio \
-device virtio-scsi-pci,bus=pci
On Thu, Apr 06, 2017 at 07:59:53PM +0200, Kevin Wolf wrote:
> Usually guest devices don't like other writers to the same image, so
> they use blk_set_perm() to prevent this from happening. In the migration
> phase before the VM is actually running, though, they don't have a
> problem with writes to
On 04/03/2017 10:24 AM, Alberto Garcia wrote:
> On Mon, Apr 03, 2017 at 09:07:02AM -0500, Eric Blake wrote:
>
>> At this point, it looks like no one is calling
>> throttle_group_unregister_blk() as a result of the 'device_del',
>> which leaves stale memory around
>
> I see, I can also reproduce t
On 04/06/17 14:35, gengdongjiu wrote:
> Dear, Laszlo
>Thanks for your detailed explanation.
>
> On 2017/3/29 19:58, Laszlo Ersek wrote:
>> (This ought to be one of the longest address lists I've ever seen :)
>> Thanks for the CC. I'm glad Shannon is already on the CC list. For good
>> measure,
If KVM provides VAPIC, don't set up kvmvapic.
Signed-off-by: Anthony Xu
---
hw/intc/apic_common.c | 5 -
include/sysemu/kvm.h | 1 +
kvm-all.c | 5 +
3 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
index c3829e3..b
On Thu, Apr 06, 2017 at 07:26:15PM +0200, Kashyap Chamarthy wrote:
> On Tue, Apr 04, 2017 at 05:35:56PM +0200, Kevin Wolf wrote:
> > Usually guest devices don't like other writers to the same image, so
> > they use blk_set_perm() to prevent this from happening. In the migration
> > phase before the
On 6 April 2017 at 19:15, Rainer Müller wrote:
> A bit late to this thread, but the original problem was also reported
> for Mac OS X with --enable-curses in MacPorts. The build fails with the
> same symptoms as in the original report.
>
> https://trac.macports.org/ticket/53929
>
> As you identifi
Am 06.04.2017 um 19:45 hat Jeff Cody geschrieben:
> The documentation and help for qemu-img claims that 'qemu-img create'
> will take the '--image-opts' argument. This is not true, so this
> patch removes those claims.
>
> Signed-off-by: Jeff Cody
Thanks, applied to the block branch.
Kevin
> > --- a/kvm-all.c
> > +++ b/kvm-all.c
> > @@ -2232,6 +2232,10 @@ int kvm_has_sync_mmu(void)
> > return kvm_check_extension(kvm_state, KVM_CAP_SYNC_MMU);
> > }
> >
> > +int kvm_has_vapic(void){
> > +return !kvm_check_extension(kvm_state, KVM_CAP_VAPIC);
> > +}
> > +
>
> Is that function
On 2017-02-17 17:57, Peter Maydell wrote:
> On 17 February 2017 at 11:20, Paolo Bonzini wrote:
>>
>>
>> On 17/02/2017 11:18, Peter Maydell wrote:
>>> Defining _XOPEN_SOURCE is easy enough, and I think we should
>>> do it unconditionally. We should check what effect this has
>>> on the BSD hosts th
On 04/06/2017 12:45 PM, Jeff Cody wrote:
> The documentation and help for qemu-img claims that 'qemu-img create'
> will take the '--image-opts' argument. This is not true, so this
> patch removes those claims.
>
> Signed-off-by: Jeff Cody
> ---
> qemu-img-cmds.hx | 4 ++--
> 1 file changed, 2 i
On Apr 6, 2017, at 1:08 PM, luigi burdo wrote:
Hi i can help test it too on my two Be machine.
If some one help me to find where is the patch or where i can
download the commits
Thanks
Luigi
Here are the patches:
1/3 https://patchwork.ozlabs.org/patch/747691/
2/3 https://patch
Usually guest devices don't like other writers to the same image, so
they use blk_set_perm() to prevent this from happening. In the migration
phase before the VM is actually running, though, they don't have a
problem with writes to the image. On the other hand, storage migration
needs to be able to
On Apr 6, 2017, at 12:00 PM, qemu-devel-requ...@nongnu.org wrote:
Dear QEMU developers,
I need multiple ARM-based hardware emulation runing simultaneously
in one
PC.
I wander if QEMU is capble to run two system emulation at the same
time.
Or I have to use two QEMU for two system emulatio
Am 03.04.2017 um 19:51 hat Max Reitz geschrieben:
> And the exciting 2.9 ride continues!
>
> When mirroring from a BDS with no parents at all (such as those added
> with -blockdev or blockdev-add), we have a use-after-free in mirror's
> error path. The first patch of this series fixes that, the ot
The documentation and help for qemu-img claims that 'qemu-img create'
will take the '--image-opts' argument. This is not true, so this
patch removes those claims.
Signed-off-by: Jeff Cody
---
qemu-img-cmds.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-img-cmds.
On 6 April 2017 at 18:23, Wu, Michael Y [US] (MS) wrote:
> I changed my code to the following and added the appropriate read,write
> functions and a MemoryRegionOps.
> memory_region_init_io(reg_memory, NULL, ®_ops, reg,
> "reg_mem", 0x0040); //set to 64 bytes
>
On 04/06/2017 12:14 PM, Kevin Wolf wrote:
> Like in the mirror filter driver, we also need to set the image size for
> the commit filter driver. This is less likely to be a problem in
> practice than for the mirror because we're not at the active layer here,
> but attaching new parents to a node in
On 04/06/2017 12:14 PM, Kevin Wolf wrote:
> The filter driver that is inserted by the commit job needs to use the
> same AioContext as its parent and child nodes.
>
> Signed-off-by: Kevin Wolf
> ---
> block/commit.c | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Eric Blake
--
Eric
On Tue, Apr 04, 2017 at 05:35:56PM +0200, Kevin Wolf wrote:
> Usually guest devices don't like other writers to the same image, so
> they use blk_set_perm() to prevent this from happening. In the migration
> phase before the VM is actually running, though, they don't have a
> problem with writes to
Thank you Peter!
I changed my code to the following and added the appropriate read,write
functions and a MemoryRegionOps.
memory_region_init_io(reg_memory, NULL, ®_ops, reg,
"reg_mem", 0x0040); //set to 64 bytes
memory_region_add_subregion(sysmem, 0xFC00,
On Tue, Apr 04, 2017 at 05:35:56PM +0200, Kevin Wolf wrote:
> Usually guest devices don't like other writers to the same image, so
> they use blk_set_perm() to prevent this from happening. In the migration
> phase before the VM is actually running, though, they don't have a
> problem with writes to
The same problem that Fam's patch "mirror: Fix aio context of
mirror_top_bs" fixes for the mirror block job also exists for the
commit block job and the 'commit' HMP command. While comparing the
respective places in mirror.c and commit.c, I also noticed that
commit neglects to set an image size.
T
The filter driver that is inserted by the commit job needs to use the
same AioContext as its parent and child nodes.
Signed-off-by: Kevin Wolf
---
block/commit.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/commit.c b/block/commit.c
index 2832482..4c38220 100644
--- a/block/commit
Like in the mirror filter driver, we also need to set the image size for
the commit filter driver. This is less likely to be a problem in
practice than for the mirror because we're not at the active layer here,
but attaching new parents to a node in the middle of the chain is
possible, so the size
I'm running into this issue as well:
Arch Linux
Qemu 2.8.0
spice guest tools: 0.132
QXL driver version (as reported by Windows Device Manager): 10.0.0.15000
Everything else works great. It would save me a lot of rebooting if this could
get fixed.
If there is anything I can do or try, I'll be glad
On 04/06/2017 10:01 AM, Alberto Garcia wrote:
> Hi all,
>
> over the past couple of months I discussed with some of you the
> possibility to extend the qcow2 format in order to improve its
> performance and reduce its memory requirements (particularly with very
> large images).
>
> After some dis
On 04/06/2017 10:13 AM, Juan Quintela wrote:
Signed-off-by: Juan Quintela
Reviewed-by: Philippe Mathieu-Daudé
---
hw/core/qdev.c | 4 ++--
include/hw/qdev-core.h | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 1e7fb33..6f
On 6 April 2017 at 17:34, Philippe Mathieu-Daudé wrote:
> Hi Peter,
>
> excnames[] is only used in arm_log_exception(), can we move it there?
Seems like a good idea. I think this is historic, we used to use
it in separate functions in different files for the 32-bit and
64-bit exception entry code
On 6 April 2017 at 17:24, Philippe Mathieu-Daudé wrote:
> Hi Peter,
>
>
> On 04/06/2017 10:45 AM, Peter Maydell wrote:
>> default:
>> -hw_error("gptm_write: Bad offset 0x%x\n", (int)offset);
>> +qemu_log_mask(LOG_GUEST_ERROR,
>> + "GPTM: read at bad offset
Hi Peter,
excnames[] is only used in arm_log_exception(), can we move it there?
anyway:
Reviewed-by: Philippe Mathieu-Daudé
On 04/06/2017 10:45 AM, Peter Maydell wrote:
Recent changes have added new EXCP_ values to ARM but forgot
to update the excnames[] array which is used to provide
human-r
Hi Peter,
On 04/06/2017 10:45 AM, Peter Maydell wrote:
Current recommended style is to log a guest error on bad register
accesses, not kill the whole system with hw_error(). Change the
hw_error() calls to log as LOG_GUEST_ERROR or LOG_UNIMP or use
g_assert_not_reached() as appropriate.
Signed-
Am 06.04.2017 um 16:25 hat Fam Zheng geschrieben:
> Coroutine in block layer should always be waken up in bs->aio_context
> rather than the "current" context where it is entered. They differ when
> the main loop is doing QMP tasks.
This whole mechanism is complex stuff that I haven't quite caught
On 6 April 2017 at 16:47, Jiahuan Zhang wrote:
> I need multiple ARM-based hardware emulation runing simultaneously in one
> PC.
> I wander if QEMU is capble to run two system emulation at the same time.
> Or I have to use two QEMU for two system emulation
You need to run two copies of QEMU for t
On 04/06/2017 03:22 AM, Nikunj A Dadhania wrote:
@@ -3028,6 +3030,7 @@ static void gen_##name(DisasContext *ctx)
\
tcg_gen_qemu_ld_tl(gpr, t0, ctx->mem_idx, memop);\
tcg_gen_mov_tl(cpu_reserve, t0); \
tcg_g
On Wed, Apr 05, 2017 at 06:12:06PM +0300, Denis V. Lunev wrote:
> PRL_PREALLOC_MODE_TRUNCATE can be set only through command line. Remove
> the check that bdrv_truncate() is working on, this is almost always the
> case, while the check could lead to serious consequences during migration
> etc when
On 04/06/2017 10:49 AM, Eric Blake wrote:
> On 04/06/2017 10:41 AM, Dr. David Alan Gilbert (git) wrote:
>> From: "Dr. David Alan Gilbert"
>>
>> Gcc 7 (on Fedora 26) spotted odd use of integers instead of a
>> boolean; it's got a point.
>>
>> Signed-off-by: Dr. David Alan Gilbert
>> ---
>> tests/
On 04/06/2017 03:22 AM, Nikunj A Dadhania wrote:
In case where the conditional write is the first write to the page,
TLB_NOTDIRTY will be set and stop_the_world is triggered. Handle this as
a special case and set the dirty bit. After that fall through to the
actual atomic instruction below.
Sign
On 04/06/2017 03:22 AM, Nikunj A Dadhania wrote:
tcg_gen_trunc_tl_i32(cpu_crf[0], cpu_so);
l1 = gen_new_label();
tcg_gen_brcond_tl(TCG_COND_NE, EA, cpu_reserve, l1);
-tcg_gen_ori_i32(cpu_crf[0], cpu_crf[0], CRF_EQ);
-tcg_gen_qemu_st_tl(cpu_gpr[reg], EA, ctx->mem_idx, memop)
* Eric Blake (ebl...@redhat.com) wrote:
> On 04/06/2017 10:41 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Gcc 7 (on Fedora 26) spotted odd use of integers instead of a
> > boolean; it's got a point.
> >
> > Signed-off-by: Dr. David Alan Gilbert
> > ---
> >
On 04/06/2017 03:22 AM, Nikunj A Dadhania wrote:
+TCGv_i32 tmp = tcg_temp_local_new_i32();
+TCGv t0;
+tcg_gen_movi_i32(tmp, 0);
tcg_gen_trunc_tl_i32(cpu_crf[0], cpu_so);
l1 = gen_new_label();
tcg_gen_brcond_tl(TCG_COND_NE, EA, cpu_reserve, l1);
-tcg_gen_ori_i32(cpu
On 04/06/2017 10:41 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Gcc 7 (on Fedora 26) spotted odd use of integers instead of a
> boolean; it's got a point.
>
> Signed-off-by: Dr. David Alan Gilbert
> ---
> tests/check-qdict.c | 2 +-
> 1 file changed, 1 insertio
Dear QEMU developers,
I need multiple ARM-based hardware emulation runing simultaneously in one
PC.
I wander if QEMU is capble to run two system emulation at the same time.
Or I have to use two QEMU for two system emulation
If the former is possible, where can i find some docs about it? I have
se
From: "Dr. David Alan Gilbert"
Gcc 7 (on Fedora 26) spotted odd use of integers instead of a
boolean; it's got a point.
Signed-off-by: Dr. David Alan Gilbert
---
tests/check-qdict.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/check-qdict.c b/tests/check-qdict.c
in
Am 06.04.2017 um 16:25 hat Fam Zheng geschrieben:
> During block job completion, nothing is preventing
> block_job_defer_to_main_loop_bh from being called in a nested
> aio_poll(), which is a trouble, such as in this code path:
>
> qmp_block_commit
> commit_active_start
> bdrv_re
On Thu, 6 Apr 2017 16:53:44 +0800
Cao jin wrote:
> On 04/06/2017 06:36 AM, Michael S. Tsirkin wrote:
> > On Wed, Apr 05, 2017 at 04:19:10PM -0600, Alex Williamson wrote:
> >> On Thu, 6 Apr 2017 00:50:22 +0300
> >> "Michael S. Tsirkin" wrote:
> >>
> >>> On Wed, Apr 05, 2017 at 01:38:22PM -060
On 04/06/2017 09:25 AM, Fam Zheng wrote:
> Coroutine in block layer should always be waken up in bs->aio_context
s/waken up/awakened/
> rather than the "current" context where it is entered. They differ when
> the main loop is doing QMP tasks.
>
> Race conditions happen without this patch, becau
On Thu, 6 Apr 2017 16:49:35 +0800
Cao jin wrote:
> On 04/06/2017 05:56 AM, Michael S. Tsirkin wrote:
> > On Wed, Apr 05, 2017 at 04:54:33PM +0800, Cao jin wrote:
> >> Apparently, I don't have experience to induce non-fatal error, device
> >> error is more of a chance related with the environmen
On Thu, Apr 06, 2017 at 03:00:28PM +0300, Michael S. Tsirkin wrote:
> On Thu, Apr 06, 2017 at 03:08:35PM +0800, Peter Xu wrote:
> > This is v8 of vt-d vfio enablement series.
> >
> > v8
> > - remove patches 1-9 since merged already
> > - add David's r-b for all the patches
> > - add Aviv's s-o-b i
On Thu, Apr 06, 2017 at 02:53:46PM +0300, Michael S. Tsirkin wrote:
> On Thu, Apr 06, 2017 at 03:08:35PM +0800, Peter Xu wrote:
> > This is v8 of vt-d vfio enablement series.
> >
> > v8
> > - remove patches 1-9 since merged already
> > - add David's r-b for all the patches
> > - add Aviv's s-o-b i
On Wed, Apr 05, 2017 at 04:21:30PM -0700, Anthony Xu wrote:
> move xen-hvm.c to hw/i386/xen/
>
>
> Signed-off -by: Anthony Xu
>
>
>
> ---
> Makefile.target| 3 +--
> hw/i386/xen/Makefile.objs | 2 +-
> hw/i386/xen/trace-events | 11 +++
> xen-
On 04/06/2017 06:14 PM, Stefan Hajnoczi wrote:
> On Wed, Apr 05, 2017 at 06:12:05PM +0300, Denis V. Lunev wrote:
>> We should avoid to image file at migration end when BDRV_O_INACTIVE
> s/avoid to image/avoid writing to the image/ ?
yes
>> is set on the block driver state. All modifications shoul
On 04/06/2017 10:10 AM, Sahid Orentino Ferdjaoui wrote:
> On Wed, Apr 05, 2017 at 04:21:29PM -0700, Anthony Xu wrote:
>> move xen-common.c to hw/xen/
>>
>> Signed-off -by: Anthony Xu
>
> nit: s/Signed-off -by/Signed-off-by, not sure if it's really important
> or not.
Some of the automated toolin
1 - 100 of 322 matches
Mail list logo
