On Mar 3, 2017, at 4:59 AM, qemu-ppc-requ...@nongnu.org wrote:
>
> Current order of checking does not confirm with the spec
> (ISA 3.0: MultiplyAddDP page-469). Change the order and make them
> independent of each other.
>
> For example: a = infinity, b = zero, c = SNaN, this should set both
>
On 2017年03月03日 20:06, Peter Maydell wrote:
On 17 February 2017 at 03:04, Jason Wang wrote:
On 2017年02月16日 20:29, Dmitry Fleytman wrote:
This series fix a few issues related
to processing of RX packets with VLAN headers.
See commit messages of specific patches
for information regarding affe
On 03/01/2017 04:19 AM, Alessandro Di Federico wrote:
This series of patches is a follow-up to the "Preparing the build system
for libtcg" patch set.
The first six patches' aim is to decouple and factor out some components
so that introducing libtcg can be painless and smooth. The last patch
ins
On Sat, Mar 4, 2017 at 12:15 AM, Nir Soffer wrote:
> On Sat, Mar 4, 2017 at 12:02 AM, John Snow wrote:
>>
>>
>> On 03/03/2017 04:38 PM, Nir Soffer wrote:
>>> On Fri, Mar 3, 2017 at 3:51 PM, Stefan Hajnoczi wrote:
RFCv1:
* Publishing patch series with just raw support, no qcow2 ye
Hi,
This series failed build test on s390x host. Please find the details below.
Subject: [Qemu-devel] [PATCH for-2.9 0/6] disas: Fix various coverity nits
Message-id: 1488556233-31246-1-git-send-email-peter.mayd...@linaro.org
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script wi
On 03/03/2017 12:14 PM, Eric Blake wrote:
> On 03/03/2017 11:25 AM, Greg Kurz wrote:
>> We should pass O_NOFOLLOW otherwise openat() will follow symlinks and make
>> QEMU vulnerable.
>>
>> O_PATH was used as an optimization: the fd returned by openat_dir() is only
>> passed to openat() actually, so
In certain cases, such as PCI-passthrough with VFIO, we cannot offload
MMIO accesses to KVM unless the BAR alignment matches the host. This
patch, in conjunction with a separately submitted patch for SLOF
which allows for control of this via the device-tree, allows us to
set this alignment via QEMU
On 03/02/2017 05:08 AM, Li Qiang wrote:
> As the pci ahci can be hotplug and unplug, in the ahci unrealize
> function it should free all the resource once allocated in the
> realized function. This patchset first add cleanup function in
> core layer and then call it in the ahci unit.
>
> Li Qian
On Sat, Mar 4, 2017 at 12:02 AM, John Snow wrote:
>
>
> On 03/03/2017 04:38 PM, Nir Soffer wrote:
>> On Fri, Mar 3, 2017 at 3:51 PM, Stefan Hajnoczi wrote:
>>>
>>> RFCv1:
>>> * Publishing patch series with just raw support, no qcow2 yet. Please
>>> review
>>>the command-line interface and
On 03/03/2017 04:38 PM, Nir Soffer wrote:
> On Fri, Mar 3, 2017 at 3:51 PM, Stefan Hajnoczi wrote:
>>
>> RFCv1:
>> * Publishing patch series with just raw support, no qcow2 yet. Please
>> review
>>the command-line interface and let me know if you are happy with this
>>approach.
>>
>>
On Fri, Mar 3, 2017 at 3:51 PM, Stefan Hajnoczi wrote:
> The max-size subcommand calculates the maximum size required by a new
> image file. This can be used by users or management tools that need to
> allocate space on an LVM volume, SAN LUN, etc before creating or
> converting an image file.
>
Hi Jim,
I think Alex and Paolo worked on an mttcg/icount issue.
Not sure if its related or not.
Fred
On 03/03/2017 08:38 PM, Nutaro, James J. wrote:
> My original problem seems to stem from something that changed in the way that
> device emulation and instruction execution interact (I'm guessin
On Fri, Mar 3, 2017 at 3:51 PM, Stefan Hajnoczi wrote:
>
> RFCv1:
> * Publishing patch series with just raw support, no qcow2 yet. Please review
>the command-line interface and let me know if you are happy with this
>approach.
>
> Users and management tools sometimes need to know the siz
> > I would actually prefer to remove many of the latter
> > (‑‑enable‑vhost‑net, ‑‑enable‑vhost‑scsi, ‑‑enable‑vhost‑socket) and
> > just use default‑configs. We are already doing it for ivshmem for
> > example:
>
> Was there ever a conclusion here? The reason I ask is that I see that
> current
Aaron Lindsay writes:
> On Feb 27 14:39, Alex Bennée wrote:
>>
>> Laurent Desnogues writes:
>>
>> > Hello,
>> >
>> > On Fri, Feb 24, 2017 at 12:20 PM, Alex Bennée
>> > wrote:
>> >> From: Jan Kiszka
>> >>
>> >> This finally allows TCG to benefit from the iothread introduction: Drop
>> >> the
On 03/03/2017 02:22 PM, Suramya Shah wrote:
> Signed-off-by: Suramya Shah
Technically, this is v3 now (and your next submission will be v4).
Also, if you use 'git send-email -v4' to send your patch, it would
automatically put a space after the closing ] of the subject prefix (I
think 'git am' doe
On Feb 27 14:39, Alex Bennée wrote:
>
> Laurent Desnogues writes:
>
> > Hello,
> >
> > On Fri, Feb 24, 2017 at 12:20 PM, Alex Bennée
> > wrote:
> >> From: Jan Kiszka
> >>
> >> This finally allows TCG to benefit from the iothread introduction: Drop
> >> the global mutex while running pure TCG
On Fri, 3 Mar 2017, Peter Maydell wrote:
On 3 March 2017 at 01:03, BALATON Zoltan wrote:
Adding vmstate saving is not in this patch because the state structure
will be changed in further patches, then another patch will add
vmstate descriptor after those changes.
Signed-off-by: BALATON Zoltan
On 03/03/2017 08:51 AM, Stefan Hajnoczi wrote:
> RFCv1:
> * Publishing patch series with just raw support, no qcow2 yet. Please review
>the command-line interface and let me know if you are happy with this
>approach.
>
> Users and management tools sometimes need to know the size requir
On Fri, 3 Mar 2017, Stefano Stabellini wrote:
> On Fri, 3 Mar 2017, Paul Durrant wrote:
> > > -Original Message-
> > > From: Stefano Stabellini [mailto:sstabell...@kernel.org]
> > > Sent: 02 March 2017 22:50
> > > To: Paul Durrant
> > > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu
On Fri, 3 Mar 2017, Paul Durrant wrote:
> > -Original Message-
> > From: Stefano Stabellini [mailto:sstabell...@kernel.org]
> > Sent: 02 March 2017 22:50
> > To: Paul Durrant
> > Cc: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org; Stefano
> > Stabellini ; Anthony Perard
> >
> > Sub
>>> On 2/6/2017 at 4:57 AM, wrote:
> * Paolo Bonzini (pbonz...@redhat.com) wrote:
>>
>>
>> On 03/02/2017 07:00, Stefan Hajnoczi wrote:
>> > On Thu, Feb 02, 2017 at 07:05:30AM ‑0800, Paolo Bonzini wrote:
>> >> The replication feature is a small amount of code, does not
>> >> require any external
Signed-off-by: Suramya Shah
--- fix of typo in v1 that broke compilation
util/path.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util/path.c b/util/path.c
index 5479f76..7f9fc27 100644
--- a/util/path.c
+++ b/util/path.c
@@ -6,7 +6,6 @@
#include "qemu/osdep.h"
#include
#include
-#incl
On 03/02/2017 03:44 PM, Markus Armbruster wrote:
> This permits configuration with driver-specific options in addition to
> pseudo-filename parsed as URI. For instance,
>
> --drive driver=sheepdog,host=fido,vdi=dolly
>
> instead of
>
> --drive driver=sheepdog,file=sheepdog://fido/dolly
On Fri, 3 Mar 2017, Peter Maydell wrote:
On 3 March 2017 at 02:15, BALATON Zoltan wrote:
Maybe it's not correct but works for everything I could test better than the
original code (which was broken even for the SH images one can find) so I
think we could just go with this until someone complain
Eric Blake writes:
> On 03/02/2017 03:44 PM, Markus Armbruster wrote:
>> QAPI type SocketAddressFlat differs from SocketAddress pointlessly:
>> the discriminator value for variant InetSocketAddress is 'tcp' instead
>> of 'inet'. Rename.
>>
>> The type is far only used by the Gluster block drive
On 03/03/2017 01:50 PM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> On 03/03/2017 06:32 AM, Markus Armbruster wrote:
>>> Fix the design flaw demonstrated in the previous commit: new method
>>> check_list() lets input visitors report that unvisited input remains
>>> for a list, exactly like
On 03/03/2017 02:54 PM, Daniel P. Berrange wrote:
On Fri, Mar 03, 2017 at 06:52:42PM +0100, Greg Kurz wrote:
Coverity issue CID1371731
Signed-off-by: Greg Kurz
---
hw/9pfs/9p-local.c |1 +
1 file changed, 1 insertion(+)
diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index e31309a29
On 03/03/2017 03:03 PM, Greg Kurz wrote:
If we cannot open the given path, we can return right away instead of
passing -1 to fstatfs() and close(). This will make Coverity happy.
(Coverity issue CID1371729)
Signed-off-by: Greg Kurz
Reviewed-by: Philippe Mathieu-Daudé
---
hw/9pfs/9p-local
On 03/03/2017 01:45 PM, Markus Armbruster wrote:
>>> -rsp = qmp_dispatch(&qmp_commands, req);
>>> +qdict = qdict_get_qdict(qobject_to_qdict(rsp), "error");
>>> +if (qdict) {
>>> +if (mon->qmp.commands == &qmp_cap_negotiation_commands
>>> +&& !g_strcmp0(qdict_get_try
On 03/03/2017 09:32 AM, Markus Armbruster wrote:
qobject_input_start_struct() sets *list, except when it fails because
qobject_input_get_object() fails, i.e. the input object doesn't exist.
All the other input visitor start_struct(), start_list(),
start_alternate() always set *obj / *list.
Chan
Hi Markus,
On 03/03/2017 09:32 AM, Markus Armbruster wrote:
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
qapi/qmp-dispatch.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c
index 23b0528..578c6d8 1006
On 03/03/2017 01:37 PM, Markus Armbruster wrote:
> Eric Blake writes:
>
>> On 03/03/2017 06:32 AM, Markus Armbruster wrote:
>>> The command registry encapsulates a single command list. Give the
>>> functions using it a parameter instead. Define suitable command lists
>>> in monitor, guest agent
On 03/03/2017 09:03 PM, Alex Bennée wrote:
We *should* have retaddr == 0 for this case, which indicates that we
should not attempt to restore state. Are you seeing a non-zero value?
Actually looking at xtensa I see:
Attempt to resolve CPU state @ 0x0 while translating
So maybe I should che
Eric Blake writes:
> On 03/03/2017 06:32 AM, Markus Armbruster wrote:
>> Fix the design flaw demonstrated in the previous commit: new method
>> check_list() lets input visitors report that unvisited input remains
>> for a list, exactly like check_struct() lets them report that
>> unvisited input
On 03/03/2017 01:47 PM, Eric Blake wrote:
> On 03/03/2017 01:35 PM, Richard Henderson wrote:
>>
>> Which is exactly the point when you have a condition like (X > 0);
>> letting the compiler have the same information for the production build
>> that it would have gleaned from the debug build.
>>
>>
On 03/03/2017 01:35 PM, Richard Henderson wrote:
>
> Which is exactly the point when you have a condition like (X > 0);
> letting the compiler have the same information for the production build
> that it would have gleaned from the debug build.
>
> But that's not the same as dropping the assert,
I'm trying to clone clean and I'm getting the following when initing the
submodules updated:
jim@jim-VirtualBox:~/project/lg_4k_test/qemu_pristine$ ( git submodule
sync; git submodule update --init --recursive )
Submodule 'dtc' (http://git.qemu-project.org/git/dtc.git) registered for
path 'dtc'
Su
Eric Blake writes:
> On 03/03/2017 06:32 AM, Markus Armbruster wrote:
>> To enforce capability negotiation before normal operation,
>> handle_qmp_command() inspects every command before it's handed off to
>> qmp_dispatch(). This is a bit of a layering violation, and results in
>> duplicated code
On 03/02/2017 05:21 PM, Paolo Bonzini wrote:
>
>
> On 02/03/2017 16:55, Halil Pasic wrote:
> blk_set_aio_context(s->conf->conf.blk, qemu_get_aio_context());
>> I'm wondering if synchronization is needed for batch_notify_vqs. I think
>> the set_bit can be from the iothread, but the noti
On 03/03/2017 12:58 PM, Edgar E. Iglesias wrote:
On Fri, Mar 03, 2017 at 03:50:32PM +, Peter Maydell wrote:
In the cris disassembler we were using 'unsigned long' to calculate
addresses which are supposed to be 32 bits. This meant that we might
accidentally sign extend or calculate a value
On Mon, Feb 27, 2017 at 07:05:24PM +0100, Markus Armbruster wrote:
> Eduardo Habkost writes:
>
> > The "hotplugged" property is user visible, but it was never meant
> > to be set by the user. There are probably multiple ways to break
> > or crash device code by overriding the property. For exampl
Eric Blake writes:
> On 03/03/2017 06:32 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> scripts/qapi-introspect.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Reviewed-by: Eric Blake
>
> I'm guessing we haven't seen a use of a prefix that matters ye
On 03/03/2017 12:50 PM, Peter Maydell wrote:
Coverity complains (CID 1302705) that the "fr0" part of the ?: in
fput_fp_reg_r() is dead. This looks like cut-n-paste error from
fput_fp_reg(); delete the dead code.
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
---
disas/h
My original problem seems to stem from something that changed in the way that
device emulation and instruction execution interact (I'm guessing). To
reproduce the issue, I started a linux image with
qemu-system-i386 -rtc clock=vm -monitor none -icount 1,sleep=off jack.img
After booting, I run
Eric Blake writes:
> On 03/03/2017 06:32 AM, Markus Armbruster wrote:
>> The command registry encapsulates a single command list. Give the
>> functions using it a parameter instead. Define suitable command lists
>> in monitor, guest agent and test-qmp-commands.
>>
>> Signed-off-by: Markus Armb
On 03/03/2017 10:19 PM, Peter Maydell wrote:
On 3 March 2017 at 11:05, Alex Bennée wrote:
According to the commit that added it
(c552d6c038f7cf4058d1fd5987118ffd41e0e050) it is meant to be a hint to
the compiler. Reading the GCC notes however seems to contradict that.
FWIW I did test it in bot
On 03/03/2017 02:26 PM, Nir Soffer wrote:
> On Fri, Mar 3, 2017 at 8:54 PM, John Snow wrote:
>> Use the existing readline history function we are utilizing
>> to provide persistent command history across instances of qmp-shell.
>>
>> This assists entering debug commands across sessions that may
On Thu, Mar 02, 2017 at 07:53:28PM +, Alex Bennée wrote:
> This suppresses the incorrect warning when forcing MTTCG for x86
> guests on x86 hosts. A future patch will still warn when
> TARGET_SUPPORT_MTTCG hasn't been defined for the guest (which is still
> pending for x86).
>
> Reported-by: P
On Fri, Mar 3, 2017 at 8:54 PM, John Snow wrote:
> Use the existing readline history function we are utilizing
> to provide persistent command history across instances of qmp-shell.
>
> This assists entering debug commands across sessions that may be
> interrupted by QEMU sessions terminating, whe
[adding qemu-trivial in cc]
On 03/03/2017 01:18 PM, Suramya Shah wrote:
> Signed-off-by: Suramya Shah
> ---
It would have been nice to mention in the subject that this is v2 (v1
was here
https://lists.gnu.org/archive/html/qemu-devel/2017-03/msg00110.html),
and then mention here after the --- tha
On 03/04/2017 03:28 AM, Paolo Bonzini wrote:
These cause compilation failures on CentOS 6 or other operating
systems with older GCCs.
Cc: Richard Henderson
Cc: Peter Maydell
Signed-off-by: Paolo Bonzini
---
Peter, please consider applying this as a build fix, because
the cento
Signed-off-by: Suramya Shah
---
util/path.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/util/path.c b/util/path.c
index 5479f76..7f9fc27 100644
--- a/util/path.c
+++ b/util/path.c
@@ -6,7 +6,6 @@
#include "qemu/osdep.h"
#include
#include
-#include "qemu-common.h"
#include "qemu/cutil
On 03/03/2017 05:58 PM, Nikunj A Dadhania wrote:
+#define FPU_MADDSUB_UPDATE(name, tp)\
+static void name(CPUPPCState *env, float64 arg1,\
+ float64 arg2, float64 arg3,\
+ unsig
On 03/03/2017 06:32 AM, Markus Armbruster wrote:
> Fix the design flaw demonstrated in the previous commit: new method
> check_list() lets input visitors report that unvisited input remains
> for a list, exactly like check_struct() lets them report that
> unvisited input remains for a struct or uni
On 03/03/2017 05:58 PM, Nikunj A Dadhania wrote:
Current order of checking does not confirm with the spec
(ISA 3.0: MultiplyAddDP page-469). Change the order and make them
independent of each other.
For example: a = infinity, b = zero, c = SNaN, this should set both
VXIMZ and VXNAN
Signed-off-b
On Fri, Mar 03, 2017 at 12:44:59PM +, Peter Maydell wrote:
> On 2 March 2017 at 06:20, Michael S. Tsirkin wrote:
> > dtc | 2 +-
>
> I just noticed this erroneous submodule update in here, unfortunately
> after I pushed it to master :-(
>
> I'll fix up the
On Fri, 3 Mar 2017 12:14:10 -0600
Eric Blake wrote:
> On 03/03/2017 11:25 AM, Greg Kurz wrote:
> > We should pass O_NOFOLLOW otherwise openat() will follow symlinks and make
> > QEMU vulnerable.
> >
> > O_PATH was used as an optimization: the fd returned by openat_dir() is only
> > passed to ope
On Fri, 3 Mar 2017 17:54:35 +
Mark Cave-Ayland wrote:
> On 03/03/17 17:25, Greg Kurz wrote:
>
> > We should pass O_NOFOLLOW otherwise openat() will follow symlinks and make
> > QEMU vulnerable.
> >
> > O_PATH was used as an optimization: the fd returned by openat_dir() is only
> > passed to
Le 03/03/2017 à 16:50, Peter Maydell a écrit :
> In get_field(), we take an 'unsigned char' value and shift it left,
> which implicitly promotes it to 'signed int', before ORing it into an
> 'unsigned long' type. If 'unsigned long' is 64 bits then this will
> result in a sign extension and the top
Use the existing readline history function we are utilizing
to provide persistent command history across instances of qmp-shell.
This assists entering debug commands across sessions that may be
interrupted by QEMU sessions terminating, where the qmp-shell has
to be relaunched.
Signed-off-by: John
On 3 March 2017 at 18:37, Markus Armbruster wrote:
> Peter Maydell writes:
>> Did you find these by looking at our Coverity results, or
>> cross-reference them against Coverity? (Coverity definitely
>> found the gluster leaks, for instance.)
>
> Neither. I merely hacked myself a path through an
On 3 March 2017 at 02:15, BALATON Zoltan wrote:
> Maybe it's not correct but works for everything I could test better than the
> original code (which was broken even for the SH images one can find) so I
> think we could just go with this until someone complains and provides a test
> case. I've giv
On 03/03/2017 06:32 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> tests/test-qobject-input-visitor.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization lib
On 03/02/2017 03:44 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> qapi/block-core.json | 27 ---
> 1 file changed, 24 insertions(+), 3 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtual
On 03/03/2017 06:32 AM, Markus Armbruster wrote:
> To enforce capability negotiation before normal operation,
> handle_qmp_command() inspects every command before it's handed off to
> qmp_dispatch(). This is a bit of a layering violation, and results in
> duplicated code.
>
> Before capability ne
On 3 March 2017 at 01:03, BALATON Zoltan wrote:
> Adding vmstate saving is not in this patch because the state structure
> will be changed in further patches, then another patch will add
> vmstate descriptor after those changes.
>
> Signed-off-by: BALATON Zoltan
> +static void sm501_init(SM501St
On 03/02/2017 03:44 PM, Markus Armbruster wrote:
> QAPI type SocketAddressFlat differs from SocketAddress pointlessly:
> the discriminator value for variant InetSocketAddress is 'tcp' instead
> of 'inet'. Rename.
>
> The type is far only used by the Gluster block drivers. Take care to
> keep 'tc
On 13 December 2016 at 21:00, BALATON Zoltan wrote:
> This is not used by default on any emulated machine yet but it is
> still useful to have it compiled so it can be added from the command
> line for clients that can use it (e.g. MorphOS has no driver for any
> other emulated video cards but can
Peter Maydell writes:
> On 2 March 2017 at 21:43, Markus Armbruster wrote:
>> Bad error handling, memory leaks, and lack of blockdev-add support.
>>
>> Markus Armbruster (15):
>> sheepdog: Defuse time bomb in sd_open() error handling
>> sheepdog: Fix error handling in sd_snapshot_delete()
>>
On Tue, Feb 28, 2017 at 09:52:51AM +0100, Thomas Huth wrote:
> If the user currently tries to use the -kernel parameter, simply nothing
> happens, and the user might get confused that there is nothing loaded
> to memory, but also no error message has been issued. Since there is no
> real generic wa
On 25 February 2017 at 23:53, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan
> ---
>
> v3: Added local_mem_size_index to vmstate, add vmstate for sysbus version too
>
> hw/display/sm501.c | 100
> -
> 1 file changed, 99 insertions(+), 1
On 10 December 2016 at 02:05, BALATON Zoltan wrote:
> This is to allow clients to initialise these without failing as long
> as no 2D engine function is called that would use the written value.
> Saved values are not used yet (may get used when more of 2D engine is
> added sometimes) and clients n
On 03/03/2017 11:05 AM, Markus Armbruster wrote:
> Eric Blake writes:
>
>>> +# @SocketAddressFlatType:
>>> +#
>>> +# Available SocketAddressFlat types
>>> +#
>>> +# @tcp: Internet address
>>> +#
>>> +# @unix: Unix domain socket
>>> +#
>>> +# Since: 2.9
>>
>> I probably would have listed 'sinc
On 03/03/2017 06:32 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi-introspect.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Blake
I'm guessing we haven't seen a use of a prefix that matters yet, but
that an upcoming patch tri
On 03/03/2017 12:15 PM, Greg Kurz wrote:
>
> O_PATH | O_NOFOLLOW is a special case as described in the last paragraph
> of O_PATH in the man page:
>
> If pathname is a symbolic link and the O_NOFOLLOW flag is also
> specified, then the call returns a file descriptor
On 4 December 2016 at 18:01, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan
> ---
>
> v3: simplify return expression in get_bpp
In my review on v2 I asked for the commit message to
say clearly what the bugs being fixed here are. It's
a lot easier to review a patch if I know what it's supp
On 25 February 2017 at 18:31, BALATON Zoltan wrote:
> Only the display controller part is created automatically on PCI
>
> Signed-off-by: BALATON Zoltan
> ---
>
> v2: Split off removing dependency on base address to separate patch
> v3: Added reset function and PCI ID constant definitions in pci_
On 03/03/2017 06:32 AM, Markus Armbruster wrote:
> The command registry encapsulates a single command list. Give the
> functions using it a parameter instead. Define suitable command lists
> in monitor, guest agent and test-qmp-commands.
>
> Signed-off-by: Markus Armbruster
> ---
> include/qap
On 3 March 2017 at 01:03, BALATON Zoltan wrote:
> Adding vmstate saving is not in this patch because the state structure
> will be changed in further patches, then another patch will add
> vmstate descriptor after those changes.
>
> Signed-off-by: BALATON Zoltan
> ---
Reviewed-by: Peter Maydell
On 3 December 2016 at 15:32, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan
> ---
> hw/display/sm501.c | 8
> 1 file changed, 8 insertions(+)
Reviewed-by: Peter Maydell
thanks
-- PMM
On 3 March 2017 at 00:21, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan
> ---
>
> v3: Fix initial value of misc_control register as Peter Maydell suggested
> Also use M_BYTE constant from cutils.h
>
Reviewed-by: Peter Maydell
thanks
-- PMM
On 03/03/2017 12:03 PM, Greg Kurz wrote:
> If we cannot open the given path, we can return right away instead of
> passing -1 to fstatfs() and close(). This will make Coverity happy.
>
> (Coverity issue CID1371729)
>
> Signed-off-by: Greg Kurz
> ---
> hw/9pfs/9p-local.c |3 +++
> 1 file cha
On Fri, 3 Mar 2017 12:11:36 -0600
Eric Blake wrote:
> On 03/03/2017 10:43 AM, Greg Kurz wrote:
>
> >>> +#ifndef O_PATH
> >>> +#define O_PATH 0
> >>> +#endif
> >>
> >> Isn't the use of O_PATH required in order to fix the recent
> >> security vulnerability in 9p ? If so, then defining it
On 03/03/2017 11:25 AM, Greg Kurz wrote:
> We should pass O_NOFOLLOW otherwise openat() will follow symlinks and make
> QEMU vulnerable.
>
> O_PATH was used as an optimization: the fd returned by openat_dir() is only
> passed to openat() actually, so we don't really need to reach the underlying
>
On Fri, Mar 03, 2017 at 07:03:47PM +0100, Greg Kurz wrote:
> If we cannot open the given path, we can return right away instead of
> passing -1 to fstatfs() and close(). This will make Coverity happy.
>
> (Coverity issue CID1371729)
>
> Signed-off-by: Greg Kurz
> ---
> hw/9pfs/9p-local.c |3
On 03/03/2017 10:43 AM, Greg Kurz wrote:
>>> +#ifndef O_PATH
>>> +#define O_PATH 0
>>> +#endif
>>
>> Isn't the use of O_PATH required in order to fix the recent
>> security vulnerability in 9p ? If so, then defining it to
>> 0 means the QEMU is silently becoming vulnerable once again
>> whi
On 2 March 2017 at 19:53, Alex Bennée wrote:
> ..just like the rest of the displayed ESR register. Otherwise people
> might scratch their heads if a not obviously hex number is displayed
> for the EC field.
>
> Signed-off-by: Alex Bennée
> ---
> target/arm/helper.c | 2 +-
> 1 file changed, 1 in
On 2 March 2017 at 19:53, Alex Bennée wrote:
> While I was debugging the icount issues I realised a bunch of the
> messages look quite similar. I've fixed this by including __func__ in
> the debug print. At the same time I move the a modern if (GATE) style
> printf which ensures the compiler can c
On 3 March 2017 at 12:32, Andrew Jones wrote:
> The power state spec section 5.1.5 AFFINITY_INFO defines the
> affinity info return values as
>
> 0 ON
> 1 OFF
> 2 ON_PENDING
>
> I grepped QEMU for power_state to ensure that no assumptions
> of OFF=0 were being made.
>
> Signed-off-by: Andrew
If we cannot open the given path, we can return right away instead of
passing -1 to fstatfs() and close(). This will make Coverity happy.
(Coverity issue CID1371729)
Signed-off-by: Greg Kurz
---
hw/9pfs/9p-local.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/9pfs/9p-local.c b/hw
On 03/03/17 17:25, Greg Kurz wrote:
> We should pass O_NOFOLLOW otherwise openat() will follow symlinks and make
> QEMU vulnerable.
>
> O_PATH was used as an optimization: the fd returned by openat_dir() is only
> passed to openat() actually, so we don't really need to reach the underlying
> file
On Fri, Mar 03, 2017 at 06:52:42PM +0100, Greg Kurz wrote:
> Coverity issue CID1371731
>
> Signed-off-by: Greg Kurz
> ---
> hw/9pfs/9p-local.c |1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
> index e31309a29c58..fe930300445a 100644
> --- a/hw
Coverity issue CID1371731
Signed-off-by: Greg Kurz
---
hw/9pfs/9p-local.c |1 +
1 file changed, 1 insertion(+)
diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
index e31309a29c58..fe930300445a 100644
--- a/hw/9pfs/9p-local.c
+++ b/hw/9pfs/9p-local.c
@@ -435,6 +435,7 @@ static int local_
On Fri, 24 Feb 2017 10:26:56 +0100
Igor Mammedov wrote:
> Threads within a core shouldn't be on different
> NUMA nodes, so if user has misconfgured command
> line, fail QEMU at start up to force user fix it.
>
> For now use the first thread on the core as source
> of core's node-id. Later when c
Hi All,
I've a strangeness with the "drop iolock" patch.
It seems it has an impact on the MMIO execution patch-set I'm working
on:
Basically modifying the memory tree is causing a Bad Ram Address error.
I wonder if this can't happen with hotplug/unplug model as well.
I'll look into this.
Shoot i
On Fri, Mar 03, 2017 at 06:25:30PM +0100, Greg Kurz wrote:
> We should pass O_NOFOLLOW otherwise openat() will follow symlinks and make
> QEMU vulnerable.
>
> O_PATH was used as an optimization: the fd returned by openat_dir() is only
> passed to openat() actually, so we don't really need to reach
We should pass O_NOFOLLOW otherwise openat() will follow symlinks and make
QEMU vulnerable.
O_PATH was used as an optimization: the fd returned by openat_dir() is only
passed to openat() actually, so we don't really need to reach the underlying
filesystem.
O_NOFOLLOW | O_PATH isn't an option: if
On 03/03/2017 05:54 PM, Thomas Huth wrote:
> On 03.03.2017 15:49, Cédric Le Goater wrote:
>> On 03/03/2017 03:13 PM, Thomas Huth wrote:
>>> On 03.03.2017 14:37, Cédric Le Goater wrote:
Also use an 'Object *' under the sPAPR machine to hold the RTC
object.
>>>
>>> The change from TYPE_SYS_
On 03/02/2017 07:24 AM, Daniel P. Berrange wrote:
> The qmp-shell property parser currently rejects attempts to
> set string properties to the empty string eg
>
> (QEMU) migrate-set-parameters tls-hostname=
> Error while parsing command line: Expected a key=value pair, got
> 'tls-hostname=
1 - 100 of 320 matches
Mail list logo
