On 2017/2/25 11:32, Zhang Chen wrote:
Add offset args for colo_packet_compare_common, optimize
colo_packet_compare_icmp() and colo_packet_compare_udp()
just compare the IP payload.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 28 +---
1 file changed, 21 insertio
On 2017/2/25 11:32, Zhang Chen wrote:
Add offset args for colo_packet_compare_common, optimize
colo_packet_compare_icmp() and colo_packet_compare_udp()
just compare the IP payload.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 28 +---
1 file changed, 21 insertio
Hi,
On 2017/2/25 11:32, Zhang Chen wrote:
Add packet minimum size check in colo_packet_compare_udp()
and colo_packet_compare_udp() like colo_packet_compare_icmp(),
rename function colo_packet_compare() to colo_packet_compare_common()
that we will reuse it later.
Signed-off-by: Zhang Chen
---
Eric Blake writes:
> On 02/23/2017 03:45 PM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> qapi/qmp-dispatch.c | 14 --
>> 1 file changed, 8 insertions(+), 6 deletions(-)
>>
>
>> @@ -41,15 +41,17 @@ static QDict *qmp_dispatch_check_obj(const QObject
>> *re
Eric Blake writes:
> On 02/23/2017 03:45 PM, Markus Armbruster wrote:
>> qmp_check_input_obj() duplicates qmp_dispatch_check_obj(), except the
>> latter screws up an error message. handle_qmp_command() runs first
>> the former, then the latter via qmp_dispatch(), masking the screwup.
>>
>> qemu
Eric Blake writes:
> On 02/23/2017 03:45 PM, Markus Armbruster wrote:
>> To enforce capability negotiation before normal operation,
>> handle_qmp_command() inspects every command before it's handed off to
>> qmp_dispatch(). This is a bit of a layering violation, and results in
>> duplicated code
Eric Blake writes:
> On 02/24/2017 03:06 PM, Eric Blake wrote:
>
>> On 02/24/2017 02:18 PM, Markus Armbruster wrote:
I have a preference for option 1 in the long run, but as it seems to be
upwards compatible from option 2 for -blockdev in 2.9, I'm leaning
towards option 2 for this
On 23.02.2017 13:20, Cornelia Huck wrote:
> From: Farhan Ali
>
> Load the network boot image into guest RAM when the boot
> device selected is a network device. Use some of the reserved
> space in IplBlockCcw to store the start address of the netboot
> image.
>
> A user could also use 'chreipl'(
On 23.02.2017 13:20, Cornelia Huck wrote:
> From: Farhan Ali
>
> Add new field to S390IPLState to store the name of the network boot
> loader.
>
> Signed-off-by: Farhan Ali
> Reviewed-by: Christian Borntraeger
> Reviewed-by: Cornelia Huck
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/ipl.
On Thu, Feb 23, 2017 at 10:54:43AM -0500, G 3 wrote:
>
> On Feb 23, 2017, at 9:09 AM, Stafford Horne wrote:
>
> > On Mon, Feb 13, 2017 at 10:33:09PM -0500, Programmingkid wrote:
> > >
> > > On Feb 13, 2017, at 10:25 PM, Richard Henderson wrote:
> > >
> > > > On 02/10/2017 11:39 AM, Stafford Hor
On 23.02.2017 13:20, Cornelia Huck wrote:
> From: Farhan Ali
>
> The current QEMU ROM infrastructure rejects late loading of ROMs.
> And ELFs are currently loaded as ROM, this prevents delayed loading
> of ELFs. So when loading ELF, allow the user to specify if ELF should
> be loaded as ROM or no
On 25.02.2017 00:51, Richard Henderson wrote:
> On 02/25/2017 12:50 AM, Miroslav Benes wrote:
>> Linux arch/s390/kernel/head(64).S uses lpp instruction if it is
>> available in facilities list provided by stfl/stfle instruction. This is
>> the case of newer z/System generations and their qemu defin
On 24.02.2017 21:51, BALATON Zoltan wrote:
> On Fri, 24 Feb 2017, Peter Maydell wrote:
>> On 19 February 2017 at 16:35, BALATON Zoltan wrote:
>>> This is not used by default on any emulated machine yet but it is
>>> still useful to have it compiled so it can be added from the command
>>> line for
Sorry, This patch has been renamed.
please ignore this patch.
Thanks
Zhang Chen
On 02/25/2017 11:32 AM, Zhang Chen wrote:
Add packet size check in colo_packet_compare_udp()
and colo_packet_compare_udp(), rename function colo_packet_compare()
to colo_packet_compare_common() that we will reus
Add packet minimum size check in colo_packet_compare_udp()
and colo_packet_compare_udp() like colo_packet_compare_icmp(),
rename function colo_packet_compare() to colo_packet_compare_common()
that we will reuse it later.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 30 +
Add packet size check in colo_packet_compare_udp()
and colo_packet_compare_udp(), rename function colo_packet_compare()
to colo_packet_compare_common() that we will reuse it later.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 30 ++
1 file changed, 22 insertions
Add offset args for colo_packet_compare_common, optimize
colo_packet_compare_icmp() and colo_packet_compare_udp()
just compare the IP payload.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 28 +---
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/net/co
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 9853232..5ffc4a3 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -288,9 +288,13 @@ static int colo_pac
This series we will Optimize the code and fix some bug.
Patch1: Add packet minimum size check in compare tcp/udp like compare icmp.
Patch2: Optimize compare_common and increase compare performance.
Patch3: Fix debug info always print bug.
V1:
- init patch.
Zhang Chen (3):
COLO-compare: Add mi
We can call this qmp command to do checkpoint outside of qemu.
Xen colo will need this function.
Signed-off-by: Zhang Chen
Signed-off-by: Wen Congyang
Reviewed-by: Eric Blake
---
migration/colo.c | 23 +++
qapi-schema.json | 48 +
We can call this qmp command to start/stop replication outside of qemu.
Like Xen colo need this function.
Signed-off-by: Zhang Chen
Signed-off-by: Wen Congyang
Reviewed-by: Eric Blake
Reviewed-by: Stefano Stabellini
Reviewed-by: zhanghailiang
---
migration/colo.c | 26 ++
Xen COLO depend on qemu COLO replication function.
So, We need new qmp commands for Xen to use qemu replication.
Corresponding libxl patches already in xen.git.
Commit ID:
ed37ef1f91c20f0ab162ce60f8c38400b917fa64
COLO: introduce new API to prepare/start/do/get_error/stop replication
a0ddc0b35937
On 02/25/2017 01:24 AM, Eric Blake wrote:
On 02/24/2017 01:22 AM, Zhang Chen wrote:
Xen COLO depend on qemu COLO replication function.
So, We need new qmp commands for Xen to use qemu replication.
Corresponding libxl patches already in xen.git.
Commit ID:
ed37ef1f91c20f0ab162ce60f8c38400b917
On 02/25/2017 01:27 AM, Eric Blake wrote:
On 02/24/2017 01:22 AM, Zhang Chen wrote:
We can call this qmp command to do checkpoint outside of qemu.
Xen colo will need this function.
Signed-off-by: Zhang Chen
Signed-off-by: Wen Congyang
---
migration/colo.c | 23 +++
qa
On 02/24/2017 06:05 PM, Nikunj A Dadhania wrote:
Richard Henderson writes:
On 02/24/2017 01:58 PM, David Gibson wrote:
On Fri, Feb 24, 2017 at 06:18:22AM +0530, Nikunj A Dadhania wrote:
Richard Henderson writes:
On 02/24/2017 06:56 AM, Nikunj A Dadhania wrote:
Now get rid all the split o
On 2017/2/24 23:14, Paolo Bonzini wrote:
On 24/02/2017 16:10, Chris Friesen wrote:
On 02/23/2017 08:23 PM, Herongguang (Stephen) wrote:
On 2017/2/22 22:43, Paolo Bonzini wrote:
Hopefully Gaohuai and Rongguang can help with this too.
Paolo
Yes, we are looking into and testing this.
I
On 02/25/2017 12:44 AM, Michal Marek wrote:
+DEF_HELPER_1(stfl, void, env)
DEF_HELPER_FLAGS_1(stfl, TCG_CALL_NO_RWG, void, env)
since this touches no registers, and only writes to lomem which afaik cannot
fault in kernel mode.
+DEF_HELPER_3(stfle, i64, env, i64, i64)
Unfortunately, we ar
On 02/25/2017 12:50 AM, Miroslav Benes wrote:
Linux arch/s390/kernel/head(64).S uses lpp instruction if it is
available in facilities list provided by stfl/stfle instruction. This is
the case of newer z/System generations and their qemu definition.
Signed-off-by: Miroslav Benes
---
I can't fi
Thanks!
I hope the following is in line with what you suggested -
We will error out in case either of username, secret-id, or password
are missing.
Good case, passing password via a file -
$ ./qemu-io --trace enable=vxhs* --object
secret,id=xvxhspasswd,file=/tmp/some/file/path -c 'read 66000 12
On Fri, 17 Feb 2017 09:29:35 +0100
Dong Jia Shi wrote:
> Realize VFIO_DEVICE_GET_IRQ_INFO ioctl to retrieve
> VFIO_CCW_IO_IRQ information.
>
> Realize VFIO_DEVICE_SET_IRQS ioctl to set an eventfd fd for
> VFIO_CCW_IO_IRQ. Once a write operation to the ccw_io_region
> was performed, trigger a sig
On Fri, 17 Feb 2017 09:29:31 +0100
Dong Jia Shi wrote:
> To provide user-space a set of interfaces to:
> 1. pass in a ccw program to perform an I/O operation.
> 2. read back I/O results of the completed I/O operations.
> We introduce an MMIO region for the vfio-ccw device here.
>
> This region i
On 02/23/2017 03:45 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> qapi/qmp-dispatch.c | 14 --
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> @@ -41,15 +41,17 @@ static QDict *qmp_dispatch_check_obj(const QObject
> *request, Error **errp)
>
>
On 02/23/2017 03:45 PM, Markus Armbruster wrote:
> The QERR_ macros are leftovers from the days of "rich" error objects.
>
> QERR_QMP_BAD_INPUT_OBJECT, QERR_QMP_BAD_INPUT_OBJECT_MEMBER,
> QERR_QMP_EXTRA_MEMBER are used in just one place now, except for one
> use that has crept into qobject-input-v
On 02/23/2017 03:45 PM, Markus Armbruster wrote:
> qmp_check_input_obj() duplicates qmp_dispatch_check_obj(), except the
> latter screws up an error message. handle_qmp_command() runs first
> the former, then the latter via qmp_dispatch(), masking the screwup.
>
> qemu-ga also masks the screwup,
On Fri, 24 Feb 2017 17:17:30 +
Stefan Hajnoczi wrote:
[...]
> > > This function doesn't handle absolute paths? It ignores leading '/' and
> > > therefore treats all paths as relative paths.
> > >
> >
> > Yes because any path coming from the client is supposed (*) to be relative
> > to th
On Mon, 20 Feb 2017 15:40:45 +0100
Greg Kurz wrote:
> The local_lremovexattr() callback is vulnerable to symlink attacks because
> it calls lremovexattr() which follows symbolic links in all path elements but
> the rightmost one.
>
> This patch converts local_lremovexattr() to rely on opendir_no
On 02/23/2017 03:45 PM, Markus Armbruster wrote:
> To enforce capability negotiation before normal operation,
> handle_qmp_command() inspects every command before it's handed off to
> qmp_dispatch(). This is a bit of a layering violation, and results in
> duplicated code.
>
> Before capability ne
On Fri, 24 Feb 2017, BALATON Zoltan wrote:
On Fri, 24 Feb 2017, Peter Maydell wrote:
On 19 February 2017 at 16:35, BALATON Zoltan wrote:
Write only to allow clients to initialise these without failing
Signed-off-by: BALATON Zoltan
What's the point in write-only register values?
U-boot wr
On 02/24/2017 03:31 PM, John Snow wrote:
>>
>> But the Backup Server could instead connect to the NAS directly avoiding
>> load on the frontent LAN
>> and the Qemu Node.
>>
>
> In a live backup I don't see how you will be removing QEMU from the data
> transfer loop. QEMU is the only process that k
On 02/23/2017 09:27 AM, Peter Lieven wrote:
> Am 22.02.2017 um 13:32 schrieb Eric Blake:
>> On 02/22/2017 02:45 AM, Peter Lieven wrote:
A bit outdated now, but:
http://wiki.qemu-project.org/Features/IncrementalBackup
and also a summary I wrote not too far back (PDF):
http
On 02/24/2017 04:31 PM, Paolo Bonzini wrote:
>
> On 24/02/2017 15:46, Marc-André Lureau wrote:
+if (ret < 0 && errno != EAGAIN) {
+if (tcp_chr_read_poll(chr) <= 0) {
+tcp_chr_disconnect(chr);
+return len;
>>> This change b
On 02/24/2017 03:06 PM, Eric Blake wrote:
>
> Also for 2.9: turn on the deprecation warning for QemuOpts negative
> sugar, but leave positive sugar unchanged (it seems like positive sugar
> is probably more in use than negative sugar, other than chardev nowait).
Capturing the gist of an IRC conv
On 02/24/2017 01:54 PM, Peter Lieven wrote:
>
> Changing the compression level via environment or a QCOW2 parameter is not a
> big deal. However, it helps not that much regarding speed. What helps is
> increasing the window size, but this is an incompatible change. And if we go
> for an incompa
On 02/24/2017 02:18 PM, Markus Armbruster wrote:
>> I have a preference for option 1 in the long run, but as it seems to be
>> upwards compatible from option 2 for -blockdev in 2.9, I'm leaning
>> towards option 2 for this release.
>
> Let me rename the options:
>
> * "no sugar -blockdev": both "
On Fri, 24 Feb 2017, Peter Maydell wrote:
On 19 February 2017 at 16:35, BALATON Zoltan wrote:
This is not used by default on any emulated machine yet but it is
still useful to have it compiled so it can be added from the command
line for clients that can use it (e.g. MorphOS has no driver for a
On Fri, 24 Feb 2017, Peter Maydell wrote:
On 19 February 2017 at 16:35, BALATON Zoltan wrote:
Write only to allow clients to initialise these without failing
Signed-off-by: BALATON Zoltan
What's the point in write-only register values?
U-boot writes this register during setting up the dev
On Fri, 24 Feb 2017, Peter Maydell wrote:
On 19 February 2017 at 16:35, BALATON Zoltan wrote:
Signed-off-by: BALATON Zoltan
---
hw/display/sm501.c | 73 +++---
1 file changed, 37 insertions(+), 36 deletions(-)
diff --git a/hw/display/sm501.c b/
On Fri, 24 Feb 2017, Peter Maydell wrote:
On 19 February 2017 at 16:35, BALATON Zoltan wrote:
Signed-off-by: BALATON Zoltan
---
hw/display/sm501.c | 6 +++---
hw/display/sm501_template.h | 31 ++-
2 files changed, 21 insertions(+), 16 deletions(-)
diff -
Hi
On Sat, Feb 25, 2017 at 12:25 AM Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> Since commit b0a335e351103bf92f3f9d0bd5759311be8156ac, a socket write
> may trigger a disconnect events, calling vhost_user_stop() and clearing
> all the vhost_dev strutures holding data that vhost.c fun
On Fri, 24 Feb 2017, Peter Maydell wrote:
On 19 February 2017 at 16:35, BALATON Zoltan wrote:
Only the display controller part is created automatically on PCI
Signed-off-by: BALATON Zoltan
---
hw/display/sm501.c | 58 +
hw/display/sm501_te
On Fri, 24 Feb 2017, Peter Maydell wrote:
On 19 February 2017 at 16:35, BALATON Zoltan wrote:
Signed-off-by: BALATON Zoltan
---
hw/display/sm501.c | 133 +++
hw/sh4/r2d.c | 11 -
include/hw/devices.h | 5 --
3 files changed, 101
Since commit b0a335e351103bf92f3f9d0bd5759311be8156ac, a socket write
may trigger a disconnect events, calling vhost_user_stop() and clearing
all the vhost_dev strutures holding data that vhost.c functions expect
to remain valid. Delay the cleanup to keep the vhost_dev structure
valid during the vh
Eric Blake writes:
> On 02/23/2017 03:45 PM, Markus Armbruster wrote:
>> The way we get QMP commands registered is high tech:
>>
>> * qapi-commands.py generates qmp_init_marshal() that does the actual work
>>
>> * it also generates the magic to register it as a MODULE_INIT_QAPI
>> function, s
On Fri, 24 Feb 2017, Peter Maydell wrote:
On 19 February 2017 at 16:35, BALATON Zoltan wrote:
Signed-off-by: BALATON Zoltan
---
hw/display/sm501.c | 8
hw/display/sm501_template.h | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/display/sm501.c b/hw/
Eric Blake writes:
> On 02/24/2017 01:06 PM, Markus Armbruster wrote:
>
>>
>> The value of an implied key is not subject to key desugaring.
>
> And that's a good thing.
>
>>
>> Without an implied key, the "node" would desugar to "de=off".
>>
>>> How about:
>>>
>>> for 2.9: -blockdev has no mag
> Am 24.02.2017 um 16:02 schrieb Kevin Wolf :
>
> Am 21.02.2017 um 13:29 hat Peter Lieven geschrieben:
>> the convert process is currently completely implemented with sync operations.
>> That means it reads one buffer and then writes it. No parallelism and each
>> sync
>> request takes as long a
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote:
> Hi
>
> On Fri, Feb 24, 2017 at 11:54 PM Dr. David Alan Gilbert
> wrote:
>
> > Hi,
> > I'm seeing a hang+crash doing a make check that
> > looks like it's coming from vhost-user's chardev cleanup,
> > so I'm suspecting your e0b283e7c.
>
Hi
On Fri, Feb 24, 2017 at 11:54 PM Dr. David Alan Gilbert
wrote:
> Hi,
> I'm seeing a hang+crash doing a make check that
> looks like it's coming from vhost-user's chardev cleanup,
> so I'm suspecting your e0b283e7c.
> The synptom is that the make check hangs in the qtest
> part, and a dmesg
> Am 24.02.2017 um 12:36 schrieb Laszlo Ersek :
>
> On 02/24/17 10:33, Peter Lieven wrote:
>> Hi,
>>
>>
>> i have been experimenting with deflate compression paramters in the past and
>> found that the values chosen
>>
>> in QCOW2 are not that optimal. In fact creation of compressed QCOW2 is
Hi,
I'm seeing a hang+crash doing a make check that
looks like it's coming from vhost-user's chardev cleanup,
so I'm suspecting your e0b283e7c.
The synptom is that the make check hangs in the qtest
part, and a dmesg shows that a qemu crashed.
I got a backtrace that shows:
(gdb) where
#0 0x5
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1487886317-27400-1-git-send-email-arm...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH 00/21] qapi: QMP dispatch and input visitor work
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=
On Fri, 24 Feb 2017 17:22:19 +0100
Jann Horn wrote:
> [...]
> And unfortunately, that flags argument is not actually present in the
> real syscall.
> See this glibc code:
>
> int
> fchmodat (int fd, const char *file, mode_t mode, int flag)
> {
> if (flag & ~AT_SYMLINK_NOFOLLOW)
> return INL
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1487960230-18054-1-git-send-email-kw...@redhat.com
Type: series
Subject: [Qemu-devel] [PULL 00/19] Block layer patches
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log
On 02/23/2017 03:45 PM, Markus Armbruster wrote:
> The way we get QMP commands registered is high tech:
>
> * qapi-commands.py generates qmp_init_marshal() that does the actual work
>
> * it also generates the magic to register it as a MODULE_INIT_QAPI
> function, so it runs when someone calls
Paolo Bonzini writes:
[...]
> I'm leaving these three patches out of the pull request (and 2.9) while
> the discussion goes on.
Appreciated! Please remind me to come back to this discussion once the
freeze madness has died down.
On 02/24/2017 11:27 AM, Daniel P. Berrange wrote:
> When using a memory-backend object with prealloc turned on, QEMU
> will memset() the first byte in every memory page to zero. While
> this might have been acceptable for memory backends associated
> with RAM, this corrupts application data for NVD
From: "Dr. David Alan Gilbert"
Now we deal with normal size pages and huge pages we need
to tell the place handlers the size we're dealing with
and make sure the temporary page is large enough.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
Reviewed-by: Laurent Vivier
---
i
From: "Dr. David Alan Gilbert"
The kernel can't do UFFDIO_ZEROPAGE for huge pages, so we have
to allocate a temporary (always zero) page and use UFFDIO_COPYPAGE
on it.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
Reviewed-by: Laurent Vivier
---
include/migration/migration
From: "Dr. David Alan Gilbert"
Replace the host page-size in the 'advise' command by a pagesize
summary bitmap; if the VM is just using normal RAM then
this will be exactly the same as before, however if they're using
huge pages they'll be different, and thus:
a) Migration from/to old qemu's t
On 24.02.2017 15:21, Farhan Ali wrote:
>
>
> On 02/24/2017 05:44 AM, Thomas Huth wrote:
>> On 21.02.2017 11:23, Christian Borntraeger wrote:
>>> On 02/20/2017 04:33 PM, Thomas Huth wrote:
On 20.02.2017 15:19, Cornelia Huck wrote:
> From: Farhan Ali
>
> The current QEMU ROM infra
From: "Dr. David Alan Gilbert"
When using postcopy with hugepages, we require the source
and destination page sizes for any RAMBlock to match; note
that different RAMBlocks in the same VM can have different
page sizes.
Transmit them as part of the RAM information header and
fail if there's a dif
On 02/24/2017 01:06 PM, Markus Armbruster wrote:
>
> The value of an implied key is not subject to key desugaring.
And that's a good thing.
>
> Without an implied key, the "node" would desugar to "de=off".
>
>> How about:
>>
>> for 2.9: -blockdev has no magic at all (you HAVE to spell 'foo=of
blk_insert_bs() and block job related functions will soon require an
opened block node (permission calculations will involve the block
driver), so let our tests be consistent with the real users in this
respect.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
tests/test-blockjob-txn.c | 6
This is a function that doesn't do any option parsing, but just does
some basic BlockDriverState setup and calls the .bdrv_open() function of
the block driver.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block.c | 112 +---
1
This function allows to create more or less normal BlockDriverStates
even for BlockDrivers that aren't globally registered (e.g. helper
filters for block jobs).
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block.c | 30 +-
include/block/block.h
Eric Blake writes:
> On 02/24/2017 10:39 AM, Daniel P. Berrange wrote:
>> On Fri, Feb 24, 2017 at 05:04:34PM +0100, Markus Armbruster wrote:
>>> Markus Armbruster writes:
>>>
>>> [...]
=== Dotted keys ===
One sufficiently powerful syntax extension already exists: the dotted
k
This fixes the use of a parent-less BdrvChild in bdrv_open_inherit() by
converting it into a BlockBackend. Which is exactly what it should be,
image probing is an external, standalone user of a node. The requests
can't be considered to originate from the format driver node because
that one isn't ev
This is the part of bdrv_open_child() that opens a BDS with option
inheritance, but doesn't attach it as a child to the parent yet.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block.c | 61 +
1 file changed, 37 insertions(+),
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block.c| 3 ++-
block/blkdebug.c | 2 +-
block/block-backend.c | 2 +-
block/crypto.c | 2 +-
block/parallels.c | 8
block/qcow.c | 4 ++--
block/qcow2-refcount.c | 2 +-
block/qcow2.c
This is more consistent with the commit block job, and it moves the code
to a place where we already have the necessary BlockBackends to resize
the base image when bdrv_truncate() is changed to require a BdrvChild.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
---
block/mirror.c | 50 +++
Eric Blake writes:
> On 02/24/2017 01:58 AM, Markus Armbruster wrote:
>
>>> I hate the 'no$key' sugar, and would love to get rid of it. It makes
>>> things ambiguous (thus confusing) for precious little gain: 'novocaine'
>>> can mean 'novocaine=on' or 'vocaine=off'. QemuOpts picks the latter,
>
On 23 February 2017 at 19:32, Alex Williamson
wrote:
> The following changes since commit 796b288f7be875045670f963ce1b3c8e96ac:
>
> Merge remote-tracking branch 'remotes/cody/tags/block-pull-request' into
> staging (2017-02-21 15:48:22 +)
>
> are available in the git repository at:
>
>
From: Nir Soffer
Now that we are truncating the file in both PREALLOC_MODE_FULL and
PREALLOC_MODE_OFF, not truncating in PREALLOC_MODE_FALLOC looks odd.
Add a comment explaining why we do not truncate in this case.
Signed-off-by: Nir Soffer
Signed-off-by: Kevin Wolf
---
block/file-posix.c | 7
From: "Dr. David Alan Gilbert"
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
Reviewed-by: Laurent Vivier
---
docs/migration.txt | 13 +
1 file changed, 13 insertions(+)
diff --git a/docs/migration.txt b/docs/migration.txt
index 6503c17..b462ead 100644
--- a/doc
From: Nir Soffer
In a previous commit (qemu-img: Do not truncate before preallocation) we
moved truncate to the PREALLOC_MODE_OFF branch to avoid slowdown in
posix_fallocate().
However this change is not optimal when using PREALLOC_MODE_FULL, since
knowing the final size from the beginning could
From: "Dr. David Alan Gilbert"
Just the userfaultfd.h update from Paolo's header
update run;
* Drop this patch after Paolo's update goes in *
Signed-off-by: Dr. David Alan Gilbert
---
linux-headers/linux/userfaultfd.h | 67 +--
1 file changed, 58 insertions
From: Nir Soffer
When using file system that does not support fallocate() (e.g. NFS <
4.2), truncating the file only when preallocation=OFF speeds up creating
raw file.
Here is example run, tested on Fedora 24 machine, creating raw file on
NFS version 3 server.
$ time ./qemu-img-master create -
From: "Dr. David Alan Gilbert"
As an extra sanity check, make sure the region we're registering
can perform UFFDIO_COPY; the COPY will fail later but this
gives a cleaner failure.
Signed-off-by: Dr. David Alan Gilbert
---
migration/postcopy-ram.c | 4
1 file changed, 4 insertions(+)
dif
G 3 writes:
> Hi I was wondering if your MTTCG patches have been tested with a
> PowerPC guest yet.
You would have to talk to PPC guys about the current status of MTTCG for
the PowerPC architecture. You can force it to run with -accel
tcg,thread=multi but it will likely behave weirdly if the at
From: "Dr. David Alan Gilbert"
Allow huge pages in postcopy.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
Reviewed-by: Laurent Vivier
---
migration/postcopy-ram.c | 25 +
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/migration/postc
Paolo Bonzini writes:
> On 23/02/2017 20:48, Alex Bennée wrote:
>> Hope that helps the debugging ;-)
>
> Worst case we can just remove the test (it's only there for performance
> comparison, not a bug in actual QEMU code), but this seems to help here:
>
> diff --git a/tests/test-aio-multithread.
From: "Dr. David Alan Gilbert"
Currently the fault address received by userfault is rounded to
the host page boundary and a host page is requested from the source.
Use the current RAMBlock page size instead of the general host page
size so that for RAMBlocks backed by huge pages we request the wh
From: "Dr. David Alan Gilbert"
We need extra Linux kernel support (~4.11) to support userfaults
on hugetlbfs; check for them.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
Reviewed-by: Laurent Vivier
---
migration/postcopy-ram.c | 12 +++-
1 file changed, 11 insert
On 24 February 2017 at 18:15, Laurent Vivier wrote:
> Le 24/02/2017 à 18:35, Peter Maydell a écrit :
>> My motivation for all this, incidentally, is that I wanted to have
>> a go at resurrecting the x86 backend as a test case for how we
>> should support variable-length instruction sets.
>
> I thi
Hi Peter,
On 24/02/2017 18:57, Peter Maydell wrote:
> On 24 February 2017 at 17:53, Auger Eric wrote:
>> Hi,
>>
>> On 23/02/2017 12:51, vijay.kil...@gmail.com wrote:
>>> From: Vijaya Kumar K
>>>
>>> To Save and Restore ICC_SRE_EL1 register introduce vmstate
>>> subsection and load only if non-ze
From: "Dr. David Alan Gilbert"
The existing postcopy RAM load loop already ensures that it
glues together whole host-pages from the target page size chunks sent
over the wire. Modify the definition of host page that it uses
to be the RAM block page size and thus be huge pages where appropriate.
From: "Dr. David Alan Gilbert"
The RAM save code uses ram_save_host_page to send whole
host pages at a time; change this to use the host page size associated
with the RAM Block which may be a huge page.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
Reviewed-by: Laurent Vivi
From: "Dr. David Alan Gilbert"
Record the largest page size in use; we'll need it soon for allocating
temporary buffers.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
Reviewed-by: Laurent Vivier
---
exec.c| 13 +
include/exec/cpu-common.
We should not try to assign a not yet opened node as the backing file,
because as soon as the permission system is added it will fail. The
just added bdrv_new_open_driver() function is the right tool to open a
file with an internal driver, use it.
In case anyone wonders whether that magic fake ba
From: "Dr. David Alan Gilbert"
Unfortunately madvise DONTNEED doesn't work on hugepagetlb
so use fallocate(FALLOC_FL_PUNCH_HOLE)
qemu_fd_getpagesize only sets the page based off a file
if the file is from hugetlbfs.
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Juan Quintela
Reviewed-by:
1 - 100 of 423 matches
Mail list logo
