Re: [Qemu-devel] [PATCH 15/24] qcow2: add .bdrv_can_store_new_dirty_bitmap

2017-01-28 Thread Max Reitz
On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: > Realize .bdrv_can_store_new_dirty_bitmap interface. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 40 > block/qcow2.c| 1 + > block/qcow2.h| 4 ++

Re: [Qemu-devel] [PATCH 13/24] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2017-01-28 Thread Max Reitz
On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: > Realize block bitmap storing interface, to allow qcow2 images store > persistent bitmaps. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/qcow2-bitmap.c | 509 > +-- > block/

Re: [Qemu-devel] [PATCH 09/24] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-01-28 Thread Max Reitz
On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They > are loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Extra data in bitmaps is not supported for now. > > Signed-off-by

Re: [Qemu-devel] [PATCH 09/24] qcow2: add .bdrv_load_autoloading_dirty_bitmaps

2017-01-28 Thread Max Reitz
On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They > are loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Extra data in bitmaps is not supported for now. > > Signed-off-by

Re: [Qemu-devel] [PATCH 08/24] block: introduce auto-loading bitmaps

2017-01-28 Thread Max Reitz
On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps stored in the disk image, which should > be loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: John Sn

Re: [Qemu-devel] [PATCH 07/24] qcow2: add bitmaps extension

2017-01-28 Thread Max Reitz
On 23.01.2017 13:10, Vladimir Sementsov-Ogievskiy wrote: > Add bitmap extension as specified in docs/specs/qcow2.txt. > For now, just mirror extension header into Qcow2 state and check > constraints. > > For now, disable image resize if it has bitmaps. It will be fixed later. > > Signed-off-by: V

Re: [Qemu-devel] [PATCH v4 7/7] tests: Add coverage for recent block geometry fixes

2017-01-28 Thread Max Reitz
On 20.12.2016 20:15, Eric Blake wrote: > Use blkdebug's new geometry constraints to emulate setups that > have caused recent regression fixes: write zeroes asserting > when running through a loopback block device with max-transfer > smaller than cluster size, and discard rounding away portions > of

Re: [Qemu-devel] [PATCH v4 6/7] blkdebug: Add ability to override unmap geometries

2017-01-28 Thread Max Reitz
On 20.12.2016 20:15, Eric Blake wrote: > Make it easier to simulate various unusual hardware setups (for > example, recent commits 3482b9b and b8d0a98 affect the Dell > Equallogic iSCSI with its 15M preferred and maximum unmap and > write zero sizing, or b2f95fe deals with the Linux loopback > bloc

Re: [Qemu-devel] [PATCH v4 5/7] blkdebug: Simplify override logic

2017-01-28 Thread Max Reitz
On 20.12.2016 20:15, Eric Blake wrote: > Rather than store into a local variable, then copy to the struct > if the value is valid, then reporting errors otherwise, it is > simpler to just store into the struct and report errors if the > value is invalid. This however requires that the struct store

Re: [Qemu-devel] [PATCH v4 4/7] blkdebug: Add pass-through write_zero and discard support

2017-01-28 Thread Max Reitz
On 20.12.2016 20:15, Eric Blake wrote: > In order to test the effects of artificial geometry constraints > on operations like write zero or discard, we first need blkdebug > to manage these actions. It also allows us to inject errors on > those operations, just like we can for read/write/flush. >

Re: [Qemu-devel] [PATCH v4 2/7] qcow2: Discard/zero clusters by byte count

2017-01-28 Thread Max Reitz
On 20.12.2016 20:15, Eric Blake wrote: > Passing a byte offset, but sector count, when we ultimately > want to operate on cluster granularity, is madness. Clean up > the interfaces to take both offset and count as bytes, while > still keeping the assertion added previously that the caller > must a

Re: [Qemu-devel] [PATCH v4 1/7] qcow2: Assert that cluster operations are aligned

2017-01-28 Thread Max Reitz
On 20.12.2016 20:15, Eric Blake wrote: > qcow2_discard_clusters() is set up to silently ignore sub-cluster > head or tail on unaligned requests. However, it is easy to audit > the various callers: qcow2_snapshot_create() has always passed > aligned data since the call was introduced in 1ebf561; >

Re: [Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine "none"

2017-01-28 Thread Ashijeet Acharya
On Sun, Jan 29, 2017 at 12:11 AM, Greg Kurz wrote: > On Thu, 26 Jan 2017 14:46:52 +0530 > Ashijeet Acharya wrote: > >> Migration of a "none" machine with no RAM crashes abruptly as >> bitmap_new() fails and thus aborts. Instead, place a check for >> last_ram_offset() being '0' at the start of ram

Re: [Qemu-devel] [PATCH] migrate: Migration aborts abruptly for machine "none"

2017-01-28 Thread Greg Kurz
On Thu, 26 Jan 2017 14:46:52 +0530 Ashijeet Acharya wrote: > Migration of a "none" machine with no RAM crashes abruptly as > bitmap_new() fails and thus aborts. Instead, place a check for > last_ram_offset() being '0' at the start of ram_save_setup() and > error out with a meaningful error messag

Re: [Qemu-devel] [PATCH 1/1] block: add missed BDRV_O_NOCACHE when block device is opened without file

2017-01-28 Thread Max Reitz
On 25.01.2017 20:44, Denis V. Lunev wrote: > On 01/25/2017 08:59 PM, Max Reitz wrote: >> [CC-ing John] >> >> On 25.01.2017 17:42, Denis V. Lunev wrote: >>> Technically there is a problem when the guest DVD is created by libvirt >>> with AIO mode 'native' on Linux. Current QEMU is unable to start th

Re: [Qemu-devel] [Bug 1660035] [NEW] hw/timer/altera_timer.c:207: bad size in memset ?

2017-01-28 Thread Peter Maydell
On 28 January 2017 at 13:16, dcb <1660...@bugs.launchpad.net> wrote: > Public bug reported: > > hw/timer/altera_timer.c:207:5: warning: ‘memset’ used with length equal > to number of elements without multiplication by element size [-Wmemset- > elt-size] > > Source code is > > memset(t->regs, 0

[Qemu-devel] [Bug 1660035] [NEW] hw/timer/altera_timer.c:207: bad size in memset ?

2017-01-28 Thread dcb
Public bug reported: hw/timer/altera_timer.c:207:5: warning: ‘memset’ used with length equal to number of elements without multiplication by element size [-Wmemset- elt-size] Source code is memset(t->regs, 0, ARRAY_SIZE(t->regs)); Maybe better code memset(t->regs, 0, R_MAX * sizeof(

[Qemu-devel] [PATCH] linux-user: Add FICLONE and FICLONERANGE ioctls

2017-01-28 Thread Helge Deller
Add missing FICLONE and FICLONERANGE ioctls. Signed-off-by: Helge Deller diff --git a/linux-user/ioctls.h b/linux-user/ioctls.h index 2f6e85b..eb1421d 100644 --- a/linux-user/ioctls.h +++ b/linux-user/ioctls.h @@ -112,6 +112,11 @@ #ifdef FIBMAP IOCTL(FIBMAP, IOC_W | IOC_R, MK_PTR(TYPE_LON

Re: [Qemu-devel] [PATCH v1 3/6] qemu-img: add support for -n arg to dd command

2017-01-28 Thread Fam Zheng
On Thu, 01/26 13:27, Daniel P. Berrange wrote: > It would be trivial to rewrite this patch to add support for the "conv" > option, allowing the user to explicitly give 'qemu-img dd conv=nocreat' > instead of my 'qemu-img dd -n' syntax, without changing default semantics. OK, that would be an undeb

Re: [Qemu-devel] [Bug 1660010] [NEW] AArch64 system emulation cannot execute virt uefi in 2.7 or 2.8

2017-01-28 Thread Alex Bennée
Icenowy Zheng <1660...@bugs.launchpad.net> writes: > Public bug reported: > > The UEFI firmware file is retrieved from > http://snapshots.linaro.org/components/kernel/linaro- > edk2/latest/release/qemu64/QEMU_EFI.fd . > > The error is: > ``` > TODO /var/lib/abbs/build/tmp.p2dMBBlJ0D/qemu-2.7.0/tc

Re: [Qemu-devel] [PATCH v2 8/8] hw: Drop superfluous special checks for orphaned -drive

2017-01-28 Thread John Snow
On 01/27/2017 11:04 AM, Markus Armbruster wrote: > John Snow writes: > >> On 01/27/2017 06:51 AM, Markus Armbruster wrote: >>> John Snow writes: >>> On 01/26/2017 10:09 AM, Markus Armbruster wrote: > We've traditionally rejected orphans here and there, but not > systematically. F

[Qemu-devel] [PATCH] target/s390x: Fix broken user mode

2017-01-28 Thread Stefan Weil
Returning NULL from get_max_cpu_model results in a SIGSEGV runtime error. Signed-off-by: Stefan Weil --- This is also broken in Debian. In addition, there is no default CPU ("any"), so binfmt and related actions currently don't work. I hacked my local installation by duplicating the "qemu" cpu

[Qemu-devel] [PATCH] target/s390x: Fix typo

2017-01-28 Thread Stefan Weil
Signed-off-by: Stefan Weil --- target/s390x/cpu_models.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 5b66d33..2a894ee 100644 --- a/target/s390x/cpu_models.c +++ b/target/s390x/cpu_models.c @@ -671,7 +671,7 @@ sta