Re: [Qemu-devel] [PATCH RFC v3 0/2] block/qapi: refactor and optimize the qmp_query_blockstats()

2017-01-14 Thread Dou Liyang
Hi, Markus At 01/13/2017 06:46 PM, Markus Armbruster wrote: Dou Liyang writes: Change log v2 -> v3: 1. Remove the unnecessary code for the bdrv_next_node(). 2. Remove the change of the locking rules. Even if this change can improve the performance, but it may effect the consistency.

Re: [Qemu-devel] [PATCH RFC v3 2/2] block/qapi: reduce the execution time of qmp_query_blockstats

2017-01-14 Thread Dou Liyang
Hi, Markus At 01/13/2017 06:42 PM, Markus Armbruster wrote: Dou Liyang writes: In order to reduce the execution time, this patch optimize the qmp_query_blockstats(): Remove the next_query_bds function. Remove the bdrv_query_stats function. Remove some judgement sentence. The original qmp_que

Re: [Qemu-devel] Virtual Machine Generation ID

2017-01-14 Thread Ben Warren
Hi Michael, > On Dec 10, 2016, at 7:28 PM, Michael S. Tsirkin wrote: > > On Tue, Dec 06, 2016 at 06:15:34PM -0800, Ben Warren wrote: >> Hi Michael, >> >> I’m well on my way to implementing this, but I am really new to the QEMU >> code base and am struggling with some concepts. Please see belo

Re: [Qemu-devel] [PATCH RFC v3 1/2] block/qapi: reduce the coupling between the bdrv_query_stats and bdrv_query_bds_stats

2017-01-14 Thread Dou Liyang
Hi Eric, At 01/13/2017 11:00 PM, Eric Blake wrote: On 01/04/2017 12:58 AM, Dou Liyang wrote: the bdrv_query_stats and bdrv_query_bds_stats functions need to call each other, that increases the coupling. it also makes the program complicated and makes some unnecessary judgements. s/judgements/

Re: [Qemu-devel] [PATCH v4 6/6] hypertrace: Add guest-side Linux module

2017-01-14 Thread Lluís Vilanova
Stefan Hajnoczi writes: > On Mon, Dec 26, 2016 at 09:35:10PM +0100, Lluís Vilanova wrote: >> Provides guest Linux kernel module "qemu-hypertrace.ko" to abstract >> access to the hypertrace channel. >> >> Signed-off-by: Lluís Vilanova >> --- >> Makefile |

[Qemu-devel] [Bug 1578192] Re: GTK+ interface doesn't translate keycodes properly with Wayland backend

2017-01-14 Thread dhead
thanks wyzu for the patch, I can confirm it also affecting my system. qemu 2.8.0 gnome-shell 3.22.2 gtk3 3.22 wayland 1.12 libinput 1.5.3 I attached an updated patch based on wyzu's one that seems to work for me. ** Patch added: "wayland-keymap.patch" https://bugs.launchpad.net/qemu/+bug/157

Re: [Qemu-devel] [PATCH v7 2/7] trace: Make trace_get_vcpu_event_count() inlinable

2017-01-14 Thread Lluís Vilanova
Richard Henderson writes: > On 01/13/2017 12:48 PM, Lluís Vilanova wrote: >> uring and controlling the state of tracing events. >> * >> - * Copyright (C) 2011-2016 Lluís Vilanova >> + * Copyright (C) 2011-2017 Lluís Vilanova >> * >> * This work is licensed under the terms of the GNU GPL, version

Re: [Qemu-devel] [PULL 14/65] target-arm: Use new deposit and extract ops

2017-01-14 Thread Richard Henderson
On 01/14/2017 11:41 AM, Laszlo Ersek wrote: On 01/11/17 03:17, Richard Henderson wrote: Use the new primitives for UBFX and SBFX. Signed-off-by: Richard Henderson --- target/arm/translate-a64.c | 81 +- target/arm/translate.c | 37 +-

Re: [Qemu-devel] [PULL 14/65] target-arm: Use new deposit and extract ops

2017-01-14 Thread Laszlo Ersek
On 01/11/17 03:17, Richard Henderson wrote: > Use the new primitives for UBFX and SBFX. > > Signed-off-by: Richard Henderson > --- > target/arm/translate-a64.c | 81 > +- > target/arm/translate.c | 37 + > 2 files changed, 37 i

Re: [Qemu-devel] [PATCH v2 11/11] aspeed/smc: handle dummy bytes when doing fast reads in command mode

2017-01-14 Thread mar.krzeminski
W dniu 11.01.2017 o 19:55, Cédric Le Goater pisze: On 01/11/2017 07:20 PM, mar.krzeminski wrote: W dniu 09.01.2017 o 17:24, Cédric Le Goater pisze: When doing fast read, a certain amount of dummy bytes should be sent before the read. This number is configurable in the controler CE0 Control Re

Re: [Qemu-devel] [Nbd] [Qemu-block] How to online resize qemu disk with nbd protocol?

2017-01-14 Thread Alex Bligh
> On 14 Jan 2017, at 14:48, Wouter Verhelst wrote: > > On Thu, Jan 12, 2017 at 06:56:42PM +, Alex Bligh wrote: >> My preferred way to do this would be essentially to allow NBD_OPT_INFO >> to be sent (wrapped appropriately) during the main transmission phase. >> That would allow *any* INFO st

Re: [Qemu-devel] [Nbd] [Qemu-block] How to online resize qemu disk with nbd protocol?

2017-01-14 Thread Wouter Verhelst
On Thu, Jan 12, 2017 at 06:56:42PM +, Alex Bligh wrote: > My preferred way to do this would be essentially to allow NBD_OPT_INFO > to be sent (wrapped appropriately) during the main transmission phase. > That would allow *any* INFO stuff to be reread. Can you go into a bit more detail how you'

Re: [Qemu-devel] [Nbd] [Qemu-block] How to online resize qemu disk with nbd protocol?

2017-01-14 Thread Wouter Verhelst
Hi Eric, (side note: my mutt tells me that the signature on your message does not validate. Not sure what's going on, but something you might want to look into...) On Thu, Jan 12, 2017 at 12:45:56PM -0600, Eric Blake wrote: > For resize smaller, things are a lot trickier - how do you block access

Re: [Qemu-devel] [PATCH 0/6] ppc: add a IBM 40p machine (RS/6000, PReP)

2017-01-14 Thread Hervé Poussineau
Le 13/01/2017 à 13:23, Mark Cave-Ayland a écrit : OpenBIOS doesn't support PReP boot partitions (type 0x41) nor PReP kernels so this is a no-go yet. Just out of interest, is it just the PReP boot partition support that is missing from OpenBIOS? If so, that should be fairly easy to implement if

Re: [Qemu-devel] [PATCH] nvdimm: allow read/write zero-size namespace label

2017-01-14 Thread Li Qiang
Hello Guangrong, 2017-01-13 17:00 GMT+08:00 Xiao Guangrong : > > > On 01/13/2017 11:02 AM, Li Qiang wrote: > >> From: Li Qiang >> >> The spec doesn't say the namespace label can't be zero >> when read/write it. As this is no harmful, just allow >> it. >> >> > WHY? > > The spec said that the lab

Re: [Qemu-devel] [PATCH] hw/core/null-machine: Add the possibility to instantiate a CPU, RAM and kernel

2017-01-14 Thread Laurent Vivier
Le 14/01/2017 à 07:51, Thomas Huth a écrit : > Sometimes it is useful to have just a machine with CPU and RAM, without > any further hardware in it, e.g. if you just want to do some instruction > debugging for TCG with a remote GDB attached to QEMU, or run some embedded > code with the "-semihostin

[Qemu-devel] [PATCH] qtest: virtio: zeroed last VRingDesc after allocate

2017-01-14 Thread Longpeng(Mike)
As qvring_indirect_desc_setup() wouldn't initialize last VRingDesc, so it's filled with dirty data, this might cause virtio backend broken. For example, the last bit of this VRingDesc's flags might be 1, so virtqueue_read_next_desc() would report "Desc next is ***". This patch zeored the last VRi

[Qemu-devel] [PULL v2 2/9] target-m68k: Implement bitfield ops for memory

2017-01-14 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <1478699171-10637-6-git-send-email-...@twiddle.net> Signed-off-by: Laurent Vivier --- target/m68k/cpu.h | 1 + target/m68k/helper.h| 7 ++ target/m68k/op_helper.c | 185 ++

[Qemu-devel] [PULL v2 4/9] m68k: Remove PCI and USB from config file

2017-01-14 Thread Laurent Vivier
From: Thomas Huth None of the ColdFire boards that we currently support has a PCI or USB bus (and AFAIK the upcoming q800 machine does not support PCI and USB either), so we do not need these settings the config file. Signed-off-by: Thomas Huth Message-Id: <20170106083956.53d08923@thl530> Signe

[Qemu-devel] [PULL v2 9/9] target-m68k: increment/decrement with SP

2017-01-14 Thread Laurent Vivier
On 680x0 family only. Address Register indirect With postincrement: When using the stack pointer (A7) with byte size data, the register is incremented by two. Address Register indirect With predecrement: When using the stack pointer (A7) with byte size data, the register is decremented by two.

[Qemu-devel] [PULL v2 5/9] target-m68k: fix bit operation with immediate value

2017-01-14 Thread Laurent Vivier
M680x0 bit operations with an immediate value use 9 bits of the 16bit value, while coldfire ones use only 8 bits. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <1484332593-16782-2-git-send-email-laur...@vivier.eu> --- target/m68k/translate.c | 13 ++--- 1 file

[Qemu-devel] [PULL v2 7/9] target-m68k: manage pre-dec et post-inc in CAS

2017-01-14 Thread Laurent Vivier
In these cases we must update the address register after the operation. Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <1484332593-16782-4-git-send-email-laur...@vivier.eu> --- target/m68k/translate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target/

[Qemu-devel] [PULL v2 1/9] target-m68k: Implement bitfield ops for registers

2017-01-14 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <1478699171-10637-5-git-send-email-...@twiddle.net> Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 210 1 file changed, 210 insertions(+) diff --git a/target/m68k

[Qemu-devel] [PULL v2 6/9] target-m68k: fix gen_flush_flags()

2017-01-14 Thread Laurent Vivier
gen_flush_flags() is setting unconditionally cc_op_synced to 1 and s->cc_op to CC_OP_FLAGS, whereas env->cc_op can be set to something else by a previous tcg fragment. We fix that by not setting cc_op_synced to 1 (except for gen_helper_flush_flags() that updates env->cc_op) FIX: https://github.co

[Qemu-devel] [PULL v2 8/9] target-m68k: CAS doesn't need aligned access

2017-01-14 Thread Laurent Vivier
Signed-off-by: Laurent Vivier Reviewed-by: Richard Henderson Message-Id: <1484332593-16782-5-git-send-email-laur...@vivier.eu> --- target/m68k/translate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/target/m68k/translate.c b/target/m68k/translate.c index 23e2b06..cf5d8dd 100644 --- a/targ

[Qemu-devel] [PULL v2 0/9] M68k for 2.9 patches

2017-01-14 Thread Laurent Vivier
The following changes since commit b6af8ea60282df514f87d32e36afd1c9aeee28c8: Merge remote-tracking branch 'remotes/ehabkost/tags/x86-and-machine-pull-request' into staging (2017-01-13 14:38:21 +) are available in the git repository at: git://github.com/vivier/qemu-m68k.git tags/m68k-fo

[Qemu-devel] [PULL v2 3/9] target-m68k: Implement bfffo

2017-01-14 Thread Laurent Vivier
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <1479242669-25852-1-git-send-email-...@twiddle.net> Signed-off-by: Laurent Vivier --- target/m68k/helper.h| 3 +++ target/m68k/op_helper.c | 21 + target/m68k/translate.c | 39

[Qemu-devel] [Bug 1596160] Re: SIGSEGV in memory_region_access_valid on Sabre Lite board

2017-01-14 Thread Thomas Huth
** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1596160 Title: SIGSEGV in memory_region_access_valid on Sabre Lite board Status in QE

[Qemu-devel] [Bug 808737] Re: No option to load additional binary files from command line in QEMU

2017-01-14 Thread Thomas Huth
Released with version 2.8 ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/808737 Title: No option to load additional binary files fro

Re: [Qemu-devel] [PATCH] target-openrisc: Fix exception handling status registers

2017-01-14 Thread Stafford Horne
Hello, On Sat, Jan 14, 2017 at 12:29:32PM +0800, Jia Liu wrote: > Hi all, > > On Sat, Jan 14, 2017 at 6:02 AM, Stafford Horne wrote: > > Hello, > > > > Sorry for the duplicate. There was an issue with my copy to qemu-devel > > group. Resent to everyone with proper cc to qemu-devel. > > > > Plea