Re: [Qemu-devel] qemu-2.8-rc4 is broken

2016-12-19 Thread Pavel Dovgalyuk
It also fails much earlier when I enable logs with "-d int -D log". Here is backtrace for this failure: #0 0x76e79e52 in ntdll!EtwpCreateEtwThread () from /c/Windows/SYSTEM32/ntdll.dll #1 0x76e56965 in ntdll!EtwEventSetInformation () from /c/Windows/SYSTEM32/ntdll.dl

Re: [Qemu-devel] [virtio-dev] Re: [RESEND Patch v1 00/37] Implementation of vhost-pci for inter-vm commucation

2016-12-19 Thread Wei Wang
On 12/20/2016 12:32 PM, Wei Wang wrote: Hi Marc-André, thanks for the comments. On 12/20/2016 12:43 AM, Marc-André Lureau wrote: Another question, what are vpnet->rqs used for? This should be redundant, I will remove it. I think I should explain more about this: the rqs field is redundant i

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread Peter Xu
On Mon, Dec 19, 2016 at 09:52:52PM -0700, Alex Williamson wrote: [...] > > Yes, this patch just tried to move VT-d forward a bit, rather than do > > it once and for all. I think we can do better than this in the future, > > for example, one address space per guest IOMMU domain (as you have > > me

[Qemu-devel] [PATCHv5 for 2.9 5/6] pseries: Use smaller default hash page tables when guest can resize

2016-12-19 Thread David Gibson
We've now implemented a PAPR extension allowing PAPR guest to resize their hash page table (HPT) during runtime. This patch makes use of that facility to allocate smaller HPTs by default. Specifically when a guest is aware of the HPT resize facility, qemu sizes the HPT to the initial memory size,

[Qemu-devel] [PATCHv5 for 2.9 2/6] pseries: Stubs for HPT resizing

2016-12-19 Thread David Gibson
This introduces stub implementations of the H_RESIZE_HPT_PREPARE and H_RESIZE_HPT_COMMIT hypercalls which we hope to add in a PAPR extension to allow run time resizing of a guest's hash page table. It also adds a new machine property for controlling whether this new facility is available. For now

Re: [Qemu-devel] [PATCH v6 00/10] tcg mips64 and mips r6 improvements

2016-12-19 Thread Jin Guojie
ping http://patchwork.ozlabs.org/patch/704829/ Please give me any advice and comment for speeding up the review process. Thank you all! Jin Guojie -- Original -- From: "jinguojie";; Send time: Sunday, Dec 11, 2016 9:36 PM To: "qemu-devel"; Cc: "Aurelien Jarn

[Qemu-devel] [PATCHv5 for 2.9 6/6] pseries: Allow HPT resizing with KVM

2016-12-19 Thread David Gibson
So far, qemu implements the PAPR Hash Page Table (HPT) resizing extension with TCG. The same implementation will work with KVM PR, but we don't currently allow that. For KVM HV we can only implement resizing with the assistance of the host kernel, which needs a new capability and ioctl()s. This

[Qemu-devel] [PATCHv5 for 2.9 0/6] HPT resizing for pseries guests (qemu part)

2016-12-19 Thread David Gibson
This series implements the host side of the PAPR ACR to allow runtime resizing of the Hashed Page Table (HPT) for pseries guests. Exercising this feature requires a guest OS which is also aware of it. Patches to implement the guest side in Linux have just been submitted upstream: https://lists.ozl

[Qemu-devel] [PATCHv5 for 2.9 4/6] pseries: Enable HPT resizing for 2.9

2016-12-19 Thread David Gibson
We've now implemented a PAPR extensions which allows PAPR guests (i.e. "pseries" machine type) to resize their hash page table during runtime. However, that extension is only enabled if explicitly chosen on the command line. This patch enables it by default for spapr-2.9, but leaves it disabled (

[Qemu-devel] [PATCHv5 for 2.9 1/6] pseries: Add pseries-2.9 machine type

2016-12-19 Thread David Gibson
Signed-off-by: David Gibson Reviewed-by: Thomas Huth Reviewed-by: Laurent Vivier --- hw/ppc/spapr.c | 23 +-- include/hw/compat.h | 3 +++ 2 files changed, 24 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c index 31210b3..fcaa2a5 100644 ---

[Qemu-devel] [PATCHv5 for 2.9 3/6] pseries: Implement HPT resizing

2016-12-19 Thread David Gibson
This patch implements hypercalls allowing a PAPR guest to resize its own hash page table. This will eventually allow for more flexible memory hotplug. The implementation is partially asynchronous, handled in a special thread running the hpt_prepare_thread() function. The state of a pending resiz

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread Alex Williamson
On Tue, 20 Dec 2016 11:44:41 +0800 Peter Xu wrote: > On Mon, Dec 19, 2016 at 09:56:50AM -0700, Alex Williamson wrote: > > On Mon, 19 Dec 2016 22:41:26 +0800 > > Peter Xu wrote: > > > > > This is preparation work to finally enabled dynamic switching ON/OFF for > > > VT-d protection. The old VT

Re: [Qemu-devel] [RESEND Patch v1 00/37] Implementation of vhost-pci for inter-vm commucation

2016-12-19 Thread Wei Wang
Hi Marc-André, thanks for the comments. On 12/20/2016 12:43 AM, Marc-André Lureau wrote: Hi Wei, On Mon, Dec 19, 2016 at 7:00 AM Wei Wang > wrote: This patch series implements vhost-pci, which is a point-to-point based inter-vm communication solution.

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread Peter Xu
On Tue, Dec 20, 2016 at 10:30:12AM +1100, David Gibson wrote: [...] > > +static void vtd_switch_address_space(IntelIOMMUState *s, bool enabled) > > +{ > > +GHashTableIter iter; > > +VTDBus *vtd_bus; > > +VTDAddressSpace *as; > > +int i; > > + > > +g_hash_table_iter_init(&iter,

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread Peter Xu
On Mon, Dec 19, 2016 at 09:56:50AM -0700, Alex Williamson wrote: > On Mon, 19 Dec 2016 22:41:26 +0800 > Peter Xu wrote: > > > This is preparation work to finally enabled dynamic switching ON/OFF for > > VT-d protection. The old VT-d codes is using static IOMMU region, and > > that won't satisfy v

Re: [Qemu-devel] [PATCH for-2.9 V4 0/2] Add new qmp commands to suppurt Xen COLO

2016-12-19 Thread Zhang Chen
On 12/20/2016 08:56 AM, Stefano Stabellini wrote: I am OK with this, if the relevant maintainers (Migration, QMP) ack the patches. Can you add reviewed-by for this patch set? Thanks Zhang Chen On Fri, 16 Dec 2016, Zhang Chen wrote: Xen COLO depend on qemu COLO replication function. So, We

Re: [Qemu-devel] [PATCH] 9pfs: fix crash when fsdev is missing

2016-12-19 Thread Li Qiang
On 2016-12-19 22:28 GMT+08:00 Greg Kurz wrote: > If the user passes -device virtio-9p without the corresponding -fsdev, QEMU > dereferences a NULL pointer and crashes. > > This is a 2.8 regression introduced by commit 702dbcc274e2c. > > Signed-off-by: Greg Kurz > Reviewed-by: Li Qiang > ---

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread David Gibson
On Mon, Dec 19, 2016 at 10:41:26PM +0800, Peter Xu wrote: > This is preparation work to finally enabled dynamic switching ON/OFF for > VT-d protection. The old VT-d codes is using static IOMMU region, and > that won't satisfy vfio-pci device listeners. > > Let me explain. > > vfio-pci devices dep

Re: [Qemu-devel] [PATCH for-2.9 V4 0/2] Add new qmp commands to suppurt Xen COLO

2016-12-19 Thread Stefano Stabellini
I am OK with this, if the relevant maintainers (Migration, QMP) ack the patches. On Fri, 16 Dec 2016, Zhang Chen wrote: > Xen COLO depend on qemu COLO replication function. > So, We need new qmp commands for Xen to use qemu replication. > > Corresponding libxl patches already in xen.git. > Commit

Re: [Qemu-devel] [PATCH] mirror: prevent 'top' mode mirroring when no backing file specified on the destination

2016-12-19 Thread sochin.jiang
I got the idea, thanks, Max. Sochin.Jiang On 2016/12/19 23:31, Max Reitz wrote: > On 19.12.2016 23:38, sochin jiang wrote: >> Mirroring using 'top' mode without backing file specified on the target can >> be success, >> but end with a disaster. >> >> For example: >>Migration can be suc

Re: [Qemu-devel] [PATCH] mirror: prevent 'top' mode mirroring when no backing file specified on the destination

2016-12-19 Thread sochin.jiang
Well, that makes sense, I lose my consideration, thanks. Sochin Jiang On 2016/12/19 23:31, Eric Blake wrote: > On 12/19/2016 04:38 PM, sochin jiang wrote: >> Mirroring using 'top' mode without backing file specified on the target can >> be success, >> but end with a disaster. >> >> For ex

Re: [Qemu-devel] [PATCH 20/67] ahci: clear aiocb in ncq_cb

2016-12-19 Thread John Snow
Hi, some more considerations: e7bd708ec85e40fd51569bb90c52d6613ffd8f45 atapi: classify read_cd as conditionally returning data This fixes problems with certain operating systems being unable to read from the CDROM. 99868af3d0a75cf6a515a9aa81bf0d7bcb39eadb dma-helpers: explicitly pass alignment

[Qemu-devel] [PATCH 3/5] ACPI: Add Virtual Machine Generation ID support

2016-12-19 Thread ben
From: Ben Warren This implements the VM Generation ID feature by passing a 128-bit GUID to the guest via a fw_cfg blob. The user interface is a simple device with two parameters: - guid (string, must be in UUID format ----) - changed (boolean, signal to the g

[Qemu-devel] [PATCH 0/5] RFC: Add support for VM Generation ID

2016-12-19 Thread ben
From: Ben Warren This patch set adds support for passing a GUID to Windows guests. It is a re-implementation of previous patch sets written by Igor Mammedov et al, but this time passing the GUID data as a fw_cfg blob. This has been tested to work with Windows 2012 R2. I consider it RFC quality

[Qemu-devel] [PATCH 4/5] qmp/hmp: add query-vm-generation-id and 'info vm-generation-id' commands

2016-12-19 Thread ben
From: Igor Mammedov Add commands to query Virtual Machine Generation ID counter. QMP command example: { "execute": "query-vm-generation-id" } HMP command example: info vm-generation-id Signed-off-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Ben Warren --- hmp-commands-i

[Qemu-devel] [PATCH 2/5] ACPI: Add a function for building named qword entries

2016-12-19 Thread ben
From: Ben Warren Signed-off-by: Ben Warren --- hw/acpi/aml-build.c | 28 include/hw/acpi/aml-build.h | 4 2 files changed, 32 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index b2a1e40..dc4edc2 100644 --- a/hw/acpi/aml-build.c

[Qemu-devel] [PATCH 1/5] docs: vm generation id device's description

2016-12-19 Thread ben
From: Ben Warren Signed-off-by: Ben Warren Cc: Gal Hammer --- docs/specs/vmgenid.txt | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 docs/specs/vmgenid.txt diff --git a/docs/specs/vmgenid.txt b/docs/specs/vmgenid.txt new file mode 100644 inde

[Qemu-devel] [PATCH 5/5] qmp/hmp: add set-vm-generation-id commands

2016-12-19 Thread ben
From: Igor Mammedov Add set-vm-generation-id command to set Virtual Machine Generation ID counter. QMP command example: { "execute": "set-vm-generation-id", "arguments": { "changed": true, "guid": "324e6eaf-d1d1-4bf6-bf41-b9bb6c91fb87" } }

Re: [Qemu-devel] [PATCH 00/23] arm: Add virtualization to GICv3, and enable EL2 on 64-bit CPUs

2016-12-19 Thread Alistair Francis
On Tue, Dec 13, 2016 at 2:36 AM, Peter Maydell wrote: > This patchset adds support for the Virtualization extensions to QEMU's > GICv3 emulation. This was the last missing piece that was stopping > us from turning on the EL2 support in the CPU model, so the patchset > also adds support for enablin

Re: [Qemu-devel] [PATCH 22/23] target-arm: Enable EL2 feature bit on A53 and A57

2016-12-19 Thread Alistair Francis
On Tue, Dec 13, 2016 at 8:11 AM, Edgar E. Iglesias wrote: > On Tue, Dec 13, 2016 at 10:36:23AM +, Peter Maydell wrote: >> Enable the ARM_FEATURE_EL2 bit on Cortex-A52 and >> Cortex-A57, since this is all now sufficiently implemented >> to work with the GICv3. We provide the usual CPU property

Re: [Qemu-devel] [PATCH 07/54] char: use a feature bit for replay

2016-12-19 Thread Eric Blake
On 12/12/2016 04:42 PM, Marc-André Lureau wrote: > Use a feature flag rather than a structure field for "replay". > > Signed-off-by: Marc-André Lureau > --- > qemu-char.c | 33 - > include/sysemu/char.h | 3 ++- > 2 files changed, 22 insertions(+), 14 d

[Qemu-devel] [PATCH] target-arm/abi32: check for segfault in do_kernel_trap

2016-12-19 Thread Seraphime Kirkovski
Currently, the cmpxchg implementation tests whether the destination address is readable: - if it is, we read the value and continue with the comparison - if isn't, i.e. access to addr would segfault, we assume that src != dest rather than queuing a SIGSEGV. The same problem exists in the c

Re: [Qemu-devel] [PATCH 09/23] hw/intc/arm_gic: Add external IRQ lines for VIRQ and VFIQ

2016-12-19 Thread Alistair Francis
On Tue, Dec 13, 2016 at 2:36 AM, Peter Maydell wrote: > Augment the GIC's QOM device interface by adding two > new sets of sysbus IRQ lines, to signal VIRQ and VFIQ to > each CPU. > > We never use these, but it's helpful to keep the v2-and-earlier > GIC's external interface in line with that of th

Re: [Qemu-devel] [PATCH 01/23] target-arm: Log AArch64 exception returns

2016-12-19 Thread Alistair Francis
On Tue, Dec 13, 2016 at 2:36 AM, Peter Maydell wrote: > We already log exception entry; add logging of the AArch64 exception > return path as well. > > Signed-off-by: Peter Maydell > Reviewed-by: Edgar E. Iglesias Reviewed-by: Alistair Francis Thanks, Alistair > --- > target-arm/op_helper.

Re: [Qemu-devel] [PATCH 06/54] char: introduce generic qemu_chr_get_kind()

2016-12-19 Thread Eric Blake
On 12/12/2016 04:42 PM, Marc-André Lureau wrote: > This allows to remove the "is_mux" field from CharDriverState. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 2 +- > qemu-char.c | 21 ++--- > include/sysemu/char.h | 15 +-- > 3 file

Re: [Qemu-devel] [PATCHv4] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-19 Thread Eduardo Habkost
On Mon, Dec 19, 2016 at 11:41:47AM +0200, Vlad Lungu wrote: > get_opt_value() truncates the value at the first comma > Use memcpy() instead > Unescape the module filename and parameters with get_opt_value() > before calling mb_add_cmdline() > > Signed-off-by: Vlad Lungu Reviewed-by: Eduardo Habk

Re: [Qemu-devel] [PATCHv3] multiboot: copy the cmdline verbatim, unescape module strings

2016-12-19 Thread Eduardo Habkost
On Mon, Dec 19, 2016 at 11:35:34AM +0200, Vlad Lungu wrote: > On 12/18/2016 10:25 PM, Eduardo Habkost wrote: > > On Thu, Dec 15, 2016 at 02:32:04PM +0200, Vlad Lungu wrote: > >> get_opt_value() truncates the value at the first comma > >> Use memcpy() instead > >> Unescape the module filename and pa

Re: [Qemu-devel] Is block_save_iterate() dead code?

2016-12-19 Thread John Snow
On 12/19/2016 11:30 AM, Thomas Huth wrote: > On 16.12.2016 18:03, Dr. David Alan Gilbert wrote: >> * Thomas Huth (th...@redhat.com) wrote: >>> On 18.11.2016 09:13, Thomas Huth wrote: On 17.11.2016 04:45, David Gibson wrote: > On Mon, Nov 14, 2016 at 07:34:59PM +0100, Juan Quintela wrote:

Re: [Qemu-devel] [PATCH] smbios: stop ignoring command line options for TARGET_ARM

2016-12-19 Thread Leif Lindholm
So, in addition to the style issue I was automatically notified of, I also neglected to CC the appropriate people - adding them here. As for the style issue - is it more important to adhere to checkpatch.pl or to surrounding definitions? Regards, Leif On Fri, Dec 16, 2016 at 03:23:19PM +, L

[Qemu-devel] [Bug 1251470] Re: Guest not working in KVM mode but does in TCG mode

2016-12-19 Thread Thomas Huth
According to comment #3, this bug has been fixed, so I'm closing this ticket now. If you can still reproduce this issue with the latest version from QEMU, please feel free to open this ticket again. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification beca

[Qemu-devel] [Bug 697510] Re: Machine shut off after tons of lsi_scsi: error: MSG IN data too long

2016-12-19 Thread Thomas Huth
Triaging old bug tickets ... do you still have this problem with the latest version of QEMU, or could we close this bug nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. ht

[Qemu-devel] [Bug 682360] Re: Unaccessible memory

2016-12-19 Thread Thomas Huth
QEMU 0.13 is pretty much outdated nowadays ... can you still reproduce this issue with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.laun

Re: [Qemu-devel] any known virtio-net regressions in Qemu 2.7?

2016-12-19 Thread Stefan Priebe - Profihost AG
Am 19.12.2016 um 12:03 schrieb Stefan Hajnoczi: > On Fri, Dec 16, 2016 at 10:00:36PM +0100, Stefan Priebe - Profihost AG wrote: >> >> Am 15.12.2016 um 07:46 schrieb Alexandre DERUMIER: >>> does rollbacking the kernel to previous version fix the problem ? >> >> The culprit is the used tuned agent f

[Qemu-devel] [Bug 597575] Re: Hangs on HTTP errors when using the curl block driver

2016-12-19 Thread Thomas Huth
QEMU 0.11 / 0.12 are pretty much outdated nowadays ... can you still reproduce this issue with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://b

[Qemu-devel] [Bug 682326] Re: linux-user/mmap exhaustion

2016-12-19 Thread Thomas Huth
Triaging old bug tickets ... do you still have this issue with the latest version of QEMU? If so, could you please discuss the patch on the qemu-devel mailing list? (since we do not take patches from the bugtracker) ** Changed in: qemu Status: New => Incomplete -- You received this bug no

Re: [Qemu-devel] Lock contention in QEMU

2016-12-19 Thread Weiwei Jia
Got it. Thank you very much. Best, Weiwei Jia On Mon, Dec 19, 2016 at 5:58 AM, Stefan Hajnoczi wrote: > On Fri, Dec 16, 2016 at 04:42:54PM -0500, Weiwei Jia wrote: >> Has x-data-plane been used (or accepted) widely in systems. I have >> this concern since if it hasn't been widely accepted, it ma

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

2016-12-19 Thread Andrea Bolognani
On Wed, 2016-12-14 at 20:26 +0200, Marcel Apfelbaum wrote: > > > > > > Maybe I just don't quite get the relationship between Root > > > > > > Complexes and Root Buses, but I guess my question is: what > > > > > > is preventing us from simply doing whatever a > > > > > > spapr-pci-host-bridge is doi

Re: [Qemu-devel] Strange/wrong behavior with iSCSI Tape devices in QEMU 2.8.0-rc4

2016-12-19 Thread John Snow
On 12/19/2016 04:05 AM, Holger Schranz wrote: > # Strange/wrong behavior in QEMU 2.8.0-rc4 > > After update from QEMU 2.6.2 to 2.8.0-rc4 the tape devices > and the corresponding medium changer are no longer available > in the VM quest system. > > The tape devices and the media changer are decla

Re: [Qemu-devel] [PATCH v6 2/4] hw/intc/arm_gicv3_kvm: Implement get/put functions

2016-12-19 Thread Auger Eric
Hi Vijaya, On 23/11/2016 13:39, vijay.kil...@gmail.com wrote: > From: Vijaya Kumar K > > This actually implements pre_save and post_load methods for in-kernel > vGICv3. > > Signed-off-by: Pavel Fedin > Signed-off-by: Peter Maydell > [PMM: > * use decimal, not 0bnnn > * fixed typo in names o

Re: [Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread Alex Williamson
On Mon, 19 Dec 2016 22:41:26 +0800 Peter Xu wrote: > This is preparation work to finally enabled dynamic switching ON/OFF for > VT-d protection. The old VT-d codes is using static IOMMU region, and > that won't satisfy vfio-pci device listeners. > > Let me explain. > > vfio-pci devices depend o

[Qemu-devel] [PATCH v4 6/6] target-ppc: Implement bcdutrunc. instruction

2016-12-19 Thread Jose Ricardo Ziviani
bcdutrunc. Decimal unsigned truncate. Works like bcdtrunc. with unsigned BCD numbers. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 51 + target-ppc/translate/vmx-impl.inc.c | 4 +++

[Qemu-devel] [PATCH v4 5/6] target-ppc: Implement bcdtrunc. instruction

2016-12-19 Thread Jose Ricardo Ziviani
bcdtrunc.: Decimal integer truncate. Given a BCD number in vrb and the number of bytes to truncate in vra, the return register will have vrb with such bits truncated. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 37

[Qemu-devel] [PATCH v4 3/6] target-ppc: Implement bcdus. instruction

2016-12-19 Thread Jose Ricardo Ziviani
bcdus.: Decimal unsigned shift. This instruction works like bcds. but considers only unsigned BCDs (no sign in least meaning 4 bits). Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 41 +

[Qemu-devel] [PATCH v4 4/6] target-ppc: Implement bcdsr. instruction

2016-12-19 Thread Jose Ricardo Ziviani
bcdsr.: Decimal shift and round. This instruction works like bcds. however, when performing right shift, 1 will be added to the result if the last digit was >= 5. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 48

[Qemu-devel] [PATCH v4 1/6] target-ppc: Implement unsigned quadword left/right shift and unit tests

2016-12-19 Thread Jose Ricardo Ziviani
This commit implements functions to right and left shifts and the unittest for them. Such functions is needed due to instructions that requires them. Today, there is already a right shift implementation in int128.h but it's designed for signed numbers. Signed-off-by: Jose Ricardo Ziviani --- in

[Qemu-devel] [PATCH v4 2/6] target-ppc: Implement bcds. instruction

2016-12-19 Thread Jose Ricardo Ziviani
bcds.: Decimal shift. Given two registers vra and vrb, this instruction shift the vrb value by vra bits into the result register. Signed-off-by: Jose Ricardo Ziviani --- target-ppc/helper.h | 1 + target-ppc/int_helper.c | 40 + ta

[Qemu-devel] [PATCH v4 0/6] POWER9 TCG enablements - BCD functions - final part

2016-12-19 Thread Jose Ricardo Ziviani
v4: - improves functions to behave exactly like the target v3: - moves shift functions to host-utils.c and added config_int128 guard - changes Makefile to always compile host-utils.c - redesigns bcd[u]trunc to use bitwise operations - removes "target-ppc: Implement bcd_is_valid function" (mer

Re: [Qemu-devel] [RESEND Patch v1 00/37] Implementation of vhost-pci for inter-vm commucation

2016-12-19 Thread Marc-André Lureau
Hi Wei, On Mon, Dec 19, 2016 at 7:00 AM Wei Wang wrote: > This patch series implements vhost-pci, which is a point-to-point based > inter-vm > communication solution. The QEMU side implementation includes the > vhost-user > extension, vhost-pci device emulation and management. The current device

Re: [Qemu-devel] [PATCH RFC v2 0/4] block/qapi: refactor and optimize the qmp_query_blockstats()

2016-12-19 Thread Fam Zheng
On Mon, 12/19 15:02, Stefan Hajnoczi wrote: > On Mon, Dec 19, 2016 at 04:51:22PM +0800, Dou Liyang wrote: > > These patches aim to refactor the qmp_query_blockstats() and > > improve the performance by reducing the running time of it. > > > > qmp_query_blockstats() is used to monitor the blockstat

Re: [Qemu-devel] Is block_save_iterate() dead code?

2016-12-19 Thread Thomas Huth
On 16.12.2016 18:03, Dr. David Alan Gilbert wrote: > * Thomas Huth (th...@redhat.com) wrote: >> On 18.11.2016 09:13, Thomas Huth wrote: >>> On 17.11.2016 04:45, David Gibson wrote: On Mon, Nov 14, 2016 at 07:34:59PM +0100, Juan Quintela wrote: > Thomas Huth wrote: >> qemu_savevm_state

[Qemu-devel] [PATCH v5 4/4] hax: add Darwin support

2016-12-19 Thread Vincent Palatin
Re-add the MacOSX/Darwin support: Use the Intel HAX is kernel-based hardware acceleration module (similar to KVM on Linux). Based on the original "target-i386: Add Intel HAX to android emulator" patch from David Chou from emu-2.2-release branch in the external/qemu-android repository. Signed-of

[Qemu-devel] [PATCH v5 2/4] target-i386: Add Intel HAX files

2016-12-19 Thread Vincent Palatin
That's a forward port of the core HAX interface code from the emu-2.2-release branch in the external/qemu-android repository as used by the Android emulator. The original commit was "target-i386: Add Intel HAX to android emulator" saying: """ Backport of 2b3098ff27bab079caab9b46b58546b5036f5c0c

[Qemu-devel] [PATCH v5 1/4] kvm: move cpu synchronization code

2016-12-19 Thread Vincent Palatin
Move the generic cpu_synchronize_ functions to the common hw_accel.h header, in order to prepare for the addition of a second hardware accelerator. Signed-off-by: Stefan Weil Signed-off-by: Vincent Palatin --- cpus.c | 1 + gdbstub.c | 1 + hw/i386/kvm/a

[Qemu-devel] [PATCH v5 3/4] Plumb the HAXM-based hardware acceleration support

2016-12-19 Thread Vincent Palatin
Use the Intel HAX is kernel-based hardware acceleration module for Windows (similar to KVM on Linux). Based on the "target-i386: Add Intel HAX to android emulator" patch from David Chou Signed-off-by: Vincent Palatin --- Makefile.target | 1 + configure | 18

[Qemu-devel] [PATCH v5 0/4] Add HAX support

2016-12-19 Thread Vincent Palatin
I took a stab at trying to rebase/upstream the support for Intel HAXM. (Hardware Accelerated Execution Manager). Intel HAX is kernel-based hardware acceleration module for Windows and MacOSX. I have based my work on the last version of the source code I found: the emu-2.2-release branch in the ext

Re: [Qemu-devel] Can qemu reopen image files?

2016-12-19 Thread Christopher Pereira
Hi Eric, Thanks for your great answer. On 19-Dec-16 12:48, Eric Blake wrote: Then we do the rebase while the VM is suspended to make sure the image files are reopened. That part is where you are liable to break things. Qemu does NOT have a graceful way to reopen the backing chain, so rebas

Re: [Qemu-devel] [PATCH v1 0/2] Add Atmel I2C TPM AT97SC3204T emulated device

2016-12-19 Thread Corey Minyard
On 12/19/2016 09:31 AM, Peter Maydell wrote: On 19 December 2016 at 13:55, Corey Minyard wrote: On 12/18/2016 07:47 PM, Alastair D'Silva wrote: On Fri, 2016-12-16 at 17:35 +, Peter Maydell wrote: Our current API seems to envisage that the slave can return a negative value from I2CSlaveCla

[Qemu-devel] [Bug 1651167] [NEW] hw/ipmi/isa_ipmi_bt.c:283: suspect use of macro ?

2016-12-19 Thread dcb
Public bug reported: I just had a go at compiling qemu trunk with llvm trunk. It said: hw/ipmi/isa_ipmi_bt.c:283:31: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] Source code is IPMI_BT_SET_HBUSY(ib->control_reg,

Re: [Qemu-devel] [PATCH 13/21] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2016-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2016 18:34, Max Reitz wrote: On 19.12.2016 16:26, Vladimir Sementsov-Ogievskiy wrote: 19.12.2016 18:14, Max Reitz wrote: On 17.12.2016 15:58, Vladimir Sementsov-Ogievskiy wrote: 09.12.2016 20:05, Max Reitz wrote: On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: Realize block bi

Re: [Qemu-devel] Can qemu reopen image files?

2016-12-19 Thread Eric Blake
On 12/19/2016 09:03 AM, Christopher Pereira wrote: > Hi Fam, Stefan, > > Thanks for answering. > > We use "qemu-img convert" to convert a image in the middle of the chain, > not the active one. > Those images (and the previous ones in the chain) are read-only and > there should be no risk in conv

[Qemu-devel] [PATCH v2 1/1] virtio: fix vq->inuse recalc after migr

2016-12-19 Thread Halil Pasic
Correct recalculation of vq->inuse after migration for the corner case where the avail_idx has already wrapped but used_idx not yet. Also change the type of the VirtQueue.inuse to unsigned int. This is done to be consistent with other members representing sizes (VRing.num), and because C99 guarant

Re: [Qemu-devel] [PATCH 13/21] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2016-12-19 Thread Max Reitz
On 19.12.2016 16:26, Vladimir Sementsov-Ogievskiy wrote: > 19.12.2016 18:14, Max Reitz wrote: >> On 17.12.2016 15:58, Vladimir Sementsov-Ogievskiy wrote: >>> 09.12.2016 20:05, Max Reitz wrote: On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: > Realize block bitmap storing interface

Re: [Qemu-devel] [PATCH] mirror: prevent 'top' mode mirroring when no backing file specified on the destination

2016-12-19 Thread Max Reitz
On 19.12.2016 23:38, sochin jiang wrote: > Mirroring using 'top' mode without backing file specified on the target can > be success, > but end with a disaster. > > For example: >Migration can be success in this situation while the virtual machine on > the destination > is no longer usabl

Re: [Qemu-devel] [PATCH v1 0/2] Add Atmel I2C TPM AT97SC3204T emulated device

2016-12-19 Thread Peter Maydell
On 19 December 2016 at 13:55, Corey Minyard wrote: > On 12/18/2016 07:47 PM, Alastair D'Silva wrote: >> >> On Fri, 2016-12-16 at 17:35 +, Peter Maydell wrote: >>> Our current API seems to envisage that the slave can return a >>> negative value from I2CSlaveClass::recv instead of a data byte, >

Re: [Qemu-devel] [PATCH] mirror: prevent 'top' mode mirroring when no backing file specified on the destination

2016-12-19 Thread Eric Blake
On 12/19/2016 04:38 PM, sochin jiang wrote: > Mirroring using 'top' mode without backing file specified on the target can > be success, > but end with a disaster. > > For example: >Migration can be success in this situation while the virtual machine on > the destination > is no longer us

Re: [Qemu-devel] [PATCH 13/21] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2016-12-19 Thread Vladimir Sementsov-Ogievskiy
19.12.2016 18:14, Max Reitz wrote: On 17.12.2016 15:58, Vladimir Sementsov-Ogievskiy wrote: 09.12.2016 20:05, Max Reitz wrote: On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: Realize block bitmap storing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladim

Re: [Qemu-devel] [PATCH 13/21] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2016-12-19 Thread Max Reitz
On 17.12.2016 15:58, Vladimir Sementsov-Ogievskiy wrote: > 09.12.2016 20:05, Max Reitz wrote: >> On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: >>> Realize block bitmap storing interface, to allow qcow2 images store >>> persistent bitmaps. >>> >>> Signed-off-by: Vladimir Sementsov-Ogievsk

[Qemu-devel] [PATCH] mirror: prevent 'top' mode mirroring when no backing file specified on the destination

2016-12-19 Thread sochin jiang
Mirroring using 'top' mode without backing file specified on the target can be success, but end with a disaster. For example: Migration can be success in this situation while the virtual machine on the destination is no longer usable because of backing lost. Remind the user earlier and

Re: [Qemu-devel] [PATCH v7 08/11] x86, kvm/x86.c: support vcpu preempted check

2016-12-19 Thread Pan Xinhui
hi, Andrea thanks for your reply. :) 在 2016/12/19 19:42, Andrea Arcangeli 写道: Hello, On Wed, Nov 02, 2016 at 05:08:35AM -0400, Pan Xinhui wrote: Support the vcpu_is_preempted() functionality under KVM. This will enhance lock performance on overcommitted hosts (more runnable vcpus than

Re: [Qemu-devel] Can qemu reopen image files?

2016-12-19 Thread Christopher Pereira
Hi Fam, Stefan, Thanks for answering. We use "qemu-img convert" to convert a image in the middle of the chain, not the active one. Those images (and the previous ones in the chain) are read-only and there should be no risk in converting them: E.g.: for the following chain: base --> snap1

Re: [Qemu-devel] [PATCH RFC v2 0/4] block/qapi: refactor and optimize the qmp_query_blockstats()

2016-12-19 Thread Stefan Hajnoczi
On Mon, Dec 19, 2016 at 04:51:22PM +0800, Dou Liyang wrote: > These patches aim to refactor the qmp_query_blockstats() and > improve the performance by reducing the running time of it. > > qmp_query_blockstats() is used to monitor the blockstats, it > querys all the graph_bdrv_states or monitor_bl

Re: [Qemu-devel] [PATCH RFC v2 3/4] block/qapi: acquire a reference instead of a lock during querying blockstats

2016-12-19 Thread Stefan Hajnoczi
On Mon, Dec 19, 2016 at 04:51:25PM +0800, Dou Liyang wrote: > This patch works to improve the performance of the query requests. > > From the commit 13344f3a, it adds a lock to make query-blockstats > safe by the aio_context_acquire(). the qmp_query_blockstats func > requires/releases the AioConte

[Qemu-devel] [PATCH] intel_iommu: allow dynamic switch of IOMMU region

2016-12-19 Thread Peter Xu
This is preparation work to finally enabled dynamic switching ON/OFF for VT-d protection. The old VT-d codes is using static IOMMU region, and that won't satisfy vfio-pci device listeners. Let me explain. vfio-pci devices depend on the memory region listener and IOMMU replay mechanism to make sur

Re: [Qemu-devel] [PATCH v7 08/11] x86, kvm/x86.c: support vcpu preempted check

2016-12-19 Thread Paolo Bonzini
On 19/12/2016 14:56, Pan Xinhui wrote: > hi, Andrea > thanks for your reply. :) > > 在 2016/12/19 19:42, Andrea Arcangeli 写道: >> Hello, >> >> On Wed, Nov 02, 2016 at 05:08:35AM -0400, Pan Xinhui wrote: >>> Support the vcpu_is_preempted() functionality under KVM. This will >>> enhance lock per

[Qemu-devel] [PATCH] 9pfs: fix crash when fsdev is missing

2016-12-19 Thread Greg Kurz
If the user passes -device virtio-9p without the corresponding -fsdev, QEMU dereferences a NULL pointer and crashes. This is a 2.8 regression introduced by commit 702dbcc274e2c. Signed-off-by: Greg Kurz --- hw/9pfs/9p.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9

Re: [Qemu-devel] [PATCH RFC v2 1/4] block: refactor bdrv_next_node for readability

2016-12-19 Thread Stefan Hajnoczi
On Mon, Dec 19, 2016 at 04:51:23PM +0800, Dou Liyang wrote: > make the bdrv_next_node() clearly and add some comments. > > Signed-off-by: Dou Liyang > --- > block.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/block.c b/block.c > index 39ddea3..01c9

[Qemu-devel] [PATCH 0/2] memory: extend "info mtree" with flat view dump

2016-12-19 Thread Peter Xu
Each address space has its own flatview. It's another way to observe memory info besides the default memory region hierachy, for example, if we want to know which memory region will handle the write to specific address, a flatview will suite more here than the default hierachical dump. I used it t

[Qemu-devel] [PATCH 2/2] memory: hmp: dump flat view for 'info mtree'

2016-12-19 Thread Peter Xu
Dumping flat view will be useful to debug the memory rendering logic, also it'll be much easier with it to know what memory region is handling what address range. Signed-off-by: Peter Xu --- memory.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/memory.c b/

[Qemu-devel] [PATCH 1/2] memory: provide common macros for mtree_print_mr()

2016-12-19 Thread Peter Xu
mtree_print_mr() has some common codes. Generalize it. Signed-off-by: Peter Xu --- memory.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/memory.c b/memory.c index 33110e9..5dcc2e1 100644 --- a/memory.c +++ b/memory.c @@ -2450,6 +2450,13

Re: [Qemu-devel] [PATCH v4 2/4] target-i386: Add Intel HAX files

2016-12-19 Thread Vincent Palatin
On Mon, Dec 19, 2016 at 11:29 AM, Vincent Palatin wrote: > That's a forward port of the core HAX interface code from the > emu-2.2-release branch in the external/qemu-android repository as used by > the Android emulator. > > The original commit was "target-i386: Add Intel HAX to android emulator"

Re: [Qemu-devel] Can qemu reopen image files?

2016-12-19 Thread Stefan Hajnoczi
On Mon, Dec 19, 2016 at 09:07:43AM +0800, Fam Zheng wrote: > On Sun, 12/18 20:52, Christopher Pereira wrote: > > Hi, > > > > We are doing a "qemu-img convert" operation (qcow2, with compression) to > > shorten the backing-chain (in the middle of the backing-chain). > > In order to force qemu to re

Re: [Qemu-devel] [PATCH v1 0/2] Add Atmel I2C TPM AT97SC3204T emulated device

2016-12-19 Thread Corey Minyard
On 12/18/2016 07:47 PM, Alastair D'Silva wrote: On Fri, 2016-12-16 at 17:35 +, Peter Maydell wrote: (added a couple of people to cc who might have an opinion on the i2c protocol questions below) I'm certainly no expert, but I'll try :) I know a little bit and I've implemented some stuff,

Re: [Qemu-devel] [PATCH] virtio: fix vring->inuse recalc after migr

2016-12-19 Thread Stefan Hajnoczi
On Fri, Dec 16, 2016 at 05:43:29PM +0100, Halil Pasic wrote: > > > On 12/16/2016 05:12 PM, Stefan Hajnoczi wrote: > >> You are not the first one complaining, so the sentence is definitively > >> bad. What disturbs me regarding your formulation is that we do not use > >> uint16_t to represent neit

Re: [Qemu-devel] Is qemu-img amend an atomic operation?

2016-12-19 Thread Maor Lipchuk
On Mon, Dec 19, 2016 at 3:10 PM, Kevin Wolf wrote: > Am 19.12.2016 um 13:49 hat Maor Lipchuk geschrieben: > > > > On Mon, Dec 19, 2016 at 2:47 PM, Maor Lipchuk > wrote: > > > > Hi All, > > > > Does amend considered as an atomic operation or should we mark a > volume as > > ILLEGAL on

Re: [Qemu-devel] [PATCH v7 3/5] IOMMU: enable intel_iommu map and unmap notifiers

2016-12-19 Thread Peter Xu
On Mon, Dec 19, 2016 at 11:53:32AM +, Liu, Yi L wrote: [...] > > > Regards to the s->notifiers_list, I didn't see the init op to it. Does it > > > happen > > > in another patch? If so, it may be better to move it in this patch since > > > this > > > patch introduces both the definition and

[Qemu-devel] [PATCH v6 6/9] savevm: add public save_vmstate function

2016-12-19 Thread Pavel Dovgalyuk
This patch introduces save_vmstate function to allow saving and loading vmstates from the replay module. Signed-off-by: Pavel Dovgalyuk --- include/sysemu/sysemu.h |1 + migration/savevm.c | 33 ++--- 2 files changed, 23 insertions(+), 11 deletions(-) diff

[Qemu-devel] [PATCH v6 9/9] blkreplay: create temporary overlay for underlaying devices

2016-12-19 Thread Pavel Dovgalyuk
This patch allows using '-snapshot' behavior in record/replay mode. blkreplay layer creates temporary overlays on top of underlaying disk images. It is needed, because creating an overlay over blkreplay breaks the determinism. Signed-off-by: Pavel Dovgalyuk --- block/blkreplay.c | 76 +

[Qemu-devel] [PATCH v6 8/9] block: implement bdrv_snapshot_goto for blkreplay

2016-12-19 Thread Pavel Dovgalyuk
This patch enables making snapshots with blkreplay used in block devices. Signed-off-by: Pavel Dovgalyuk --- block/blkreplay.c |8 1 file changed, 8 insertions(+) diff --git a/block/blkreplay.c b/block/blkreplay.c index a741654..8a03d62 100644 --- a/block/blkreplay.c +++ b/block/bl

[Qemu-devel] [PATCH v6 5/9] integratorcp: adding vmstate for save/restore

2016-12-19 Thread Pavel Dovgalyuk
From: Pavel Dovgalyuk VMState added by this patch preserves correct loading of the integratorcp device state. Signed-off-by: Pavel Dovgalyuk --- hw/arm/integratorcp.c | 62 + 1 file changed, 62 insertions(+) diff --git a/hw/arm/integratorcp.c

[Qemu-devel] [PATCH v6 4/9] replay: don't use rtc clock on loadvm phase

2016-12-19 Thread Pavel Dovgalyuk
This patch disables the update of the periodic timer of mc146818rtc in record/replay mode. State of this timer is saved and therefore does not need to be updated in record/replay mode. Read of RTC breaks the replay because all rtc reads have to be the same as in record mode. Signed-off-by: Pavel D

  1   2   >