Re: [Qemu-devel] [PATCH 1/2] vmxnet3: Convert ring values to uint32_t's

2016-12-17 Thread Dmitry Fleytman
Acked-by: Dmitry Fleytman > On 15 Dec 2016, at 22:05 PM, Dr. David Alan Gilbert (git) > wrote: > > From: "Dr. David Alan Gilbert" > > The index's in the Vmxnet3Ring were migrated as 32bit ints > yet are declared as size_t's. They appear to be derived > from 32bit values loaded from guest m

Re: [Qemu-devel] [PATCH 2/2] vmxnet3: VMStatify rx/tx q_descr and int_state

2016-12-17 Thread Dmitry Fleytman
> > On 16 Dec 2016, at 14:19 PM, Dr. David Alan Gilbert > wrote: > > * Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: >> From: "Dr. David Alan Gilbert" >> >> Fairly simple mechanical conversion of all fields. >> >> TODO >> The problem is vmxnet3-ring size/cell_size/next are de

Re: [Qemu-devel] [PATCH 00/26] New hppa-linux-user target

2016-12-17 Thread Thomas Huth
On 16.12.2016 20:13, Richard Henderson wrote: > This is a linux-user only port, emulating a 32-bit only version of a > pa-2.0 cpu. This is good enough to do well with both the gcc and glibc > testsuites. Helge Deller has provided invaluable assistance testing > with a more complete debian chroot

[Qemu-devel] [Bug 786440] Re: qcow2 double free

2016-12-17 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/786440 Title: qcow2 double

Re: [Qemu-devel] [PATCH 01/26] Revert "Remove remainders of HPPA backend"

2016-12-17 Thread Richard Henderson
On 12/17/2016 03:59 AM, Peter Maydell wrote: On 16 December 2016 at 19:13, Richard Henderson wrote: This reverts commit d41f3c3cc7a5fb9de144cc4022da14a9ff010671. Missing signed-off-by. Oops. +elif check_define __hppa__ ; then + cpu="hppa" else cpu=$(uname -m) fi This if-ladder is

Re: [Qemu-devel] [PATCH 13/21] qcow2: add .bdrv_store_persistent_dirty_bitmaps()

2016-12-17 Thread Vladimir Sementsov-Ogievskiy
09.12.2016 20:05, Max Reitz wrote: On 22.11.2016 18:26, Vladimir Sementsov-Ogievskiy wrote: Realize block bitmap storing interface, to allow qcow2 images store persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-bitmap.c | 451 ++

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-17 Thread Li, Liang Z
> Subject: Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for > fast (de)inflating & fast live migration > > On Thu, Dec 15, 2016 at 05:40:45PM -0800, Dave Hansen wrote: > > On 12/15/2016 05:38 PM, Li, Liang Z wrote: > > > > > > Use 52 bits for 'pfn', 12 bits for 'length', when the 1

Re: [Qemu-devel] [PATCH 01/26] Revert "Remove remainders of HPPA backend"

2016-12-17 Thread Peter Maydell
On 16 December 2016 at 19:13, Richard Henderson wrote: > This reverts commit d41f3c3cc7a5fb9de144cc4022da14a9ff010671. Missing signed-off-by. > --- > configure |5 + > disas.c |2 + > disas/Makefile.objs |1 + > disas/hppa.c | 283

Re: [Qemu-devel] [PATCH kernel v5 0/5] Extend virtio-balloon for fast (de)inflating & fast live migration

2016-12-17 Thread Li, Liang Z
> On Fri, Dec 16, 2016 at 01:12:21AM +, Li, Liang Z wrote: > > There still exist the case if the MAX_ORDER is configured to a large > > value, e.g. 36 for a system with huge amount of memory, then there is only > 28 bits left for the pfn, which is not enough. > > Not related to the balloon but

Re: [Qemu-devel] [PATCH v1 00/37] Implementation of vhost-pci for inter-vm commucation

2016-12-17 Thread no-reply
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH v1 00/37] Implementation of vhost-pci for inter-vm commucation Message-id: 14819714

Re: [Qemu-devel] [PATCH v1 00/37] Implementation of vhost-pci for inter-vm commucation

2016-12-17 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v1 00/37] Implementation of vhost-pci for inter-vm commucation Message-id: 1481971427-11094-1-git-send-email-wei.w.w...@intel.com === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH v1 37/37] vl: enable vhost-pci-slave

2016-12-17 Thread Wei Wang
Enable vhost-pci-slave in vl.c Signed-off-by: Wei Wang --- vl.c | 20 1 file changed, 20 insertions(+) diff --git a/vl.c b/vl.c index 10d7f89..6959dba 100644 --- a/vl.c +++ b/vl.c @@ -123,6 +123,7 @@ int main(int argc, char **argv) #include "sysemu/replay.h" #include "qap

[Qemu-devel] [PATCH v1 34/37] vhost-pci-slave: add "peer_reset"

2016-12-17 Thread Wei Wang
Setting "peer_reset" flags that the peer device is about to be reset. This happens when the slave side device driver only accepts a subset of the feature bits offered by the peer device. The peer device is expected to have a second run of the vhost-user protocol for the re-setup. Signed-off-by: W

[Qemu-devel] [PATCH v1 36/37] vhost-user/msg: handling VHOST_USER_SET_FEATURES

2016-12-17 Thread Wei Wang
If the featuer bits sent by the slave are not equal to the ones that were sent by the master, perform a reset of the master device. Signed-off-by: Wei Wang --- hw/net/vhost_net.c | 2 ++ hw/virtio/vhost-user.c | 19 +++ hw/virtio/virtio-pci.c | 20

[Qemu-devel] [PATCH v1 35/37] vhost-pci-net: start the vhost-pci-net device

2016-12-17 Thread Wei Wang
If the peer device on the other side doesn't need to be reset, then start the device when DRIVER_OK is received. Signed-off-by: Wei Wang --- hw/net/vhost-pci-net.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/net/vhost-pci-net.c b/hw/net/vhost-pci-net.c index 6d4db6c..

[Qemu-devel] [PATCH v1 26/37] vhost-pci-slave/msg: VHOST_USER_GET_VRING_BASE

2016-12-17 Thread Wei Wang
Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c index 1957d3f..cdeb710 100644 --- a/hw/virtio/vhost-pci-slave.c +++ b/hw/virtio/vhost-pci-slave.c @@ -217,6 +217,1

[Qemu-devel] [PATCH v1 33/37] vhost-pci-net: send the negotiated feature bits to the master

2016-12-17 Thread Wei Wang
The slave actively sends the negotiated feature bits to the master. "need_send" is used to detect if the 64-bit feature bits are ready to be sent. Signed-off-by: Wei Wang --- hw/net/vhost-pci-net.c | 12 hw/virtio/vhost-pci-slave.c | 21 + in

[Qemu-devel] [PATCH v1 32/37] vhost-user: add asynchronous read for the vhost-user master

2016-12-17 Thread Wei Wang
Enable the vhost-user master to asynchronously receive messages from the slave. Signed-off-by: Wei Wang --- hw/virtio/vhost-user.c | 42 +- include/hw/virtio/vhost-user.h | 4 include/net/vhost-user.h | 4 net/vhost-user.c

[Qemu-devel] [PATCH v1 21/37] vhost-pci-slave/msg: VHOST_USER_SET_VRING_CALL

2016-12-17 Thread Wei Wang
Update the callfd to the head node in the list. This version of vhost-pci expects the master device to use polling to receive packets, so callfd is recorded here for tomorrow's implementation. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 18 ++ include/hw/vi

Re: [Qemu-devel] [PULL for-2.9 0/9] virtio, vhost, pc: fixes

2016-12-17 Thread Peter Maydell
On 16 December 2016 at 21:32, wrote: > Your series seems to have some coding style problems. See output below for > more information: > > Type: series > Subject: [Qemu-devel] [PULL for-2.9 0/9] virtio, vhost, pc: fixes > Message-id: 1481922841-4324-1-git-send-email-...@redhat.com > Checking PATC

[Qemu-devel] [PATCH v1 30/37] vhost-pci-slave/msg: VHOST_USER_SET_VHOST_PCI (stop)

2016-12-17 Thread Wei Wang
The slave removes the slave device when receiving the request with the stop command. In the case that the master side guest crashes, the crashed guest, typically, will be killed by the admin. This event will be captured via the close of the socket connection, so we can remove the vhost-pci device

[Qemu-devel] [PATCH v1 28/37] vhost-pci-net: pass the mem and vring info to the driver

2016-12-17 Thread Wei Wang
When DRIVER_OK, the device sends the mem and vring info to the driver via the controlq. Signed-off-by: Wei Wang --- hw/net/vhost-pci-net.c | 68 ++ include/standard-headers/linux/vhost_pci_net.h | 17 +++ 2 files changed, 85 insertions(+) diff

[Qemu-devel] [PATCH v1 31/37] vhost-user/msg: send VHOST_USER_SET_VHOST_PCI (start/stop)

2016-12-17 Thread Wei Wang
The master requests the slave to create or destroy a vhost-pci device. Signed-off-by: Wei Wang --- hw/net/vhost_net.c| 34 ++ hw/virtio/vhost-user.c| 17 + include/hw/virtio/vhost-backend.h | 2 ++ include/net/vhost_net

[Qemu-devel] [PATCH v1 27/37] vhost-pci-net: pass the info collected by vp_slave to the device

2016-12-17 Thread Wei Wang
When the device is realized, pass the vring info to the device from the slave maintained list. The device uses bar2 to hold the peer VM memory. Signed-off-by: Wei Wang --- hw/net/vhost-pci-net.c | 27 ++ hw/virtio/virtio-pci.c

[Qemu-devel] [PATCH v1 25/37] vhost-pci-slave/msg: VHOST_USER_SEND_RARP

2016-12-17 Thread Wei Wang
Not implemented in this version. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c index 4e99fd9..1957d3f 100644 --- a/hw/virtio/vhost-pci-slave.c +++ b/hw/virtio/vhost-pci-slave

[Qemu-devel] [PATCH v1 15/37] vhost-pci-slave/msg: VHOST_USER_SET_MEM_TABLE

2016-12-17 Thread Wei Wang
Map the peer memory in QEMU, and prepare the memory for the guest using MemoryRegion. The controlq message of the memory info is constructed here, and it will be sent to the guest when the guest controlq is ready. With the the peer memory info reveived in the message, the guest will be able to tra

[Qemu-devel] [PATCH v1 23/37] vhost-pci-slave/msg: VHOST_USER_SET_LOG_BASE

2016-12-17 Thread Wei Wang
Live migration is not supported in this version, so do nothing here. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c index 3e00e35..61299e4 100644 --- a/hw/virtio/vhost-pci-sla

[Qemu-devel] [PATCH v1 14/37] vhost-pci-slave/msg: VHOST_USER_SET_OWNER

2016-12-17 Thread Wei Wang
Do nothing currently. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c index 8e5ecf8..9b854b1 100644 --- a/hw/virtio/vhost-pci-slave.c +++ b/hw/virtio/vhost-pci-slave.c @@ -163,

[Qemu-devel] [PATCH v1 29/37] vhost-pci-slave/msg: VHOST_USER_SET_VHOST_PCI (start)

2016-12-17 Thread Wei Wang
The VHOST_USER_SET_VHOST_PCI msg is used to request the start or stop of the vhost-pci device. This patch handles the start commandin the slave. When receiving the SET_VHOST_PCI request with the start command, the slave creates a vhost-pci device based on the previously received virtio_id. Signed

[Qemu-devel] [PATCH v1 17/37] vhost-pci-slave/msg: VHOST_USER_SET_VRING_BASE

2016-12-17 Thread Wei Wang
Update last_avail_idx to the head node in the list. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 10 ++ include/hw/virtio/vhost-pci-slave.h | 1 + 2 files changed, 11 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c index 0deab2d

[Qemu-devel] [PATCH v1 24/37] vhost-pci-slave/msg: VHOST_USER_SET_LOG_FD

2016-12-17 Thread Wei Wang
Not implemented in this version. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c index 61299e4..4e99fd9 100644 --- a/hw/virtio/vhost-pci-slave.c +++ b/hw/virtio/vhost-pci-sla

[Qemu-devel] [PATCH v1 16/37] vhost-pci-slave/msg: VHOST_USER_SET_VRING_NUM

2016-12-17 Thread Wei Wang
The protocol doesn't have a message to tell the slave how many virtqueues that the master device has. So, the slave side implementation uses a list to manage the virtqueue info sent from the master. SET_VRING_NUM is the first virtqueue info passed from the master, so the slave allocates a node when

[Qemu-devel] [PATCH v1 10/37] vhost-pci-slave/msg: VHOST_USER_SET_PROTOCOL_FEATURES

2016-12-17 Thread Wei Wang
Not used currently. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c index ac9deae..ef2b66a 100644 --- a/hw/virtio/vhost-pci-slave.c +++ b/hw/virtio/vhost-pci-slave.c @@ -122,6

[Qemu-devel] [PATCH v1 19/37] vhost-pci-slave/msg: VHOST_USER_SET_VRING_ADDR

2016-12-17 Thread Wei Wang
Update the virtqueue addresses to the head node of the list. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 10 ++ include/hw/virtio/vhost-pci-slave.h | 3 +++ 2 files changed, 13 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c in

[Qemu-devel] [PATCH v1 18/37] vhost-user: send guest physical address of virtqueues to the slave

2016-12-17 Thread Wei Wang
In the vhost-pci case, the slave needs the master side guest physical address, rather than the qemu virtual address. Signed-off-by: Wei Wang --- hw/virtio/vhost.c | 61 --- include/hw/virtio/vhost.h | 2 ++ 2 files changed, 44 insertions(+), 1

[Qemu-devel] [PATCH v1 06/37] vhost-pci-slave: set up the fundamental handlers for the server socket

2016-12-17 Thread Wei Wang
Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 53 + 1 file changed, 53 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c index 5ff9a09..2278f63 100644 --- a/hw/virtio/vhost-pci-slave.c +++ b/hw/virtio/vhos

[Qemu-devel] [PATCH v1 22/37] vhost-pci-slave/msg: VHOST_USER_SET_VRING_ENABLE

2016-12-17 Thread Wei Wang
Enable/Disable the corresponding virtqueue pairs in the list. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 15 +++ include/hw/virtio/vhost-pci-slave.h | 1 + 2 files changed, 16 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.

[Qemu-devel] [PATCH v1 12/37] vhost-pci-slave/msg: VHOST_USER_SET_DEVICE_ID

2016-12-17 Thread Wei Wang
Initialize the feature bits according to the device type. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 17 + include/hw/virtio/vhost-pci-slave.h | 1 + 2 files changed, 18 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c

[Qemu-devel] [PATCH v1 13/37] vhost-pci-slave/msg: VHOST_USER_GET_QUEUE_NUM

2016-12-17 Thread Wei Wang
Send the max supported queue num according to the device type back to the master. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c index 9b00be4..8e5ecf8 1

[Qemu-devel] [PATCH v1 08/37] vhost-pci-slave/msg: VHOST_USER_SET_FEATURES

2016-12-17 Thread Wei Wang
Store the feature bits that have been negotiated between the master device and driver. The feature bits will be negotiated with the slave driver. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/

[Qemu-devel] [PATCH v1 20/37] vhost-pci-slave/msg: VHOST_USER_SET_VRING_KICK

2016-12-17 Thread Wei Wang
Update the kickfd to the head node in the list. This version of vhost-pci expects the driver to use polling to receive packets. So, other than storing the kickfd, we don't do anything more. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 19 +++ include/hw/virt

[Qemu-devel] [PATCH v1 04/37] vl: add the vhost-pci-slave command line option

2016-12-17 Thread Wei Wang
An example of the command line option to create a vhost-pci-slave is: -chardev socket,id=slave1,server,wait=off,path=/opt/vhost-pci-slave -vhost-pci-slave socket,chardev=slave1 Signed-off-by: Wei Wang --- qemu-options.hx | 4 vl.c| 21 + 2 files changed, 25

[Qemu-devel] [PATCH v1 05/37] vhost-pci-slave: start the implementation of vhost-pci-slave

2016-12-17 Thread Wei Wang
Vhost-pci-slave uses a QEMU socket to talk to the master. This patch associates the slave with the qemu sever socket. Signed-off-by: Wei Wang --- hw/virtio/Makefile.objs | 1 + hw/virtio/vhost-pci-slave.c | 53 + include/hw/virtio/vhost-pc

[Qemu-devel] [PATCH v1 01/37] vhost-pci-net: the fundamental vhost-pci-net device emulation

2016-12-17 Thread Wei Wang
This patch introduces the fundamental parts of the device emulation. Signed-off-by: Wei Wang --- hw/net/Makefile.objs | 2 +- hw/net/vhost-pci-net.c | 136 + include/hw/virtio/vhost-pci-net.h | 36 +++

[Qemu-devel] [PATCH v1 11/37] vhost-user/msg: VHOST_USER_PROTOCOL_F_SET_DEVICE_ID

2016-12-17 Thread Wei Wang
The feature, VHOST_USER_PROTOCOL_F_SET_DEVICE_ID, indicates that the slave side implementation supports different types of devices. The master tells the slave what type of device to create by sending the VHOST_USER_SET_DEVICE_ID message. Currently, only the net type is supported. Signed-off-by: We

[Qemu-devel] [PATCH v1 09/37] vhost-pci-slave/msg: VHOST_USER_GET_PROTOCOL_FEATURES

2016-12-17 Thread Wei Wang
Add a new protocol feature, VHOST_USER_PROTOCOL_F_VHOST_PCI. This feature indicates the support of the vhost-pci extension for inter-vm communiaction. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c| 14 ++ include/hw/virtio/vhost-user.h | 6 ++ 2 files changed, 20 i

[Qemu-devel] [PATCH v1 07/37] vhost-pci-slave/msg: VHOST_USER_GET_FEATURES

2016-12-17 Thread Wei Wang
Offer the initial feature bits, which haven't been negotiated with the slave driver, to the master. Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 42 + include/hw/virtio/vhost-pci-slave.h | 1 + 2 files changed, 43 insertions(+) diff --gi

[Qemu-devel] [PATCH v1 02/37] vhost-pci-net: the fundamental implementation of vhost-pci-net-pci

2016-12-17 Thread Wei Wang
Signed-off-by: Wei Wang --- hw/virtio/virtio-pci.c | 46 ++ hw/virtio/virtio-pci.h | 14 ++ include/hw/pci/pci.h | 1 + 3 files changed, 61 insertions(+) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index 21c2b9d..baf70b4

[Qemu-devel] [PATCH v1 03/37] vhost-user: share the vhost-user protocol related structures

2016-12-17 Thread Wei Wang
Put the vhost-user protocol related data structures into vhost-user.h, so that they can be used in other implementations (e.g. a slave implementation). Signed-off-by: Wei Wang --- hw/virtio/vhost-user.c | 87 +--- include/hw/virtio/vhost-user.h | 91 ++

[Qemu-devel] [PATCH v1 00/37] Implementation of vhost-pci for inter-vm commucation

2016-12-17 Thread Wei Wang
This patch series implements vhost-pci, which is a point-to-point based inter-vm communication solution. The QEMU side implementation includes the vhost-user extension, vhost-pci device emulation and management. The current device part implementation is based on virtio 1.0, but it can be easily upg

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2016-12-17 Thread Alex Bligh
> On 17 Dec 2016, at 08:34, Wouter Verhelst wrote: > > I've therefore removed that restriction as well as the "255 bytes max" > one that you added, since I don't think they make much sense. That > doesn't mean I can't be convinced otherwise by good arguments, but > they'd have to be very good on

Re: [Qemu-devel] [Nbd] [PATCH] Further tidy-up on block status

2016-12-17 Thread Wouter Verhelst
On Fri, Dec 16, 2016 at 04:25:27PM +, Alex Bligh wrote: > > > On 16 Dec 2016, at 15:52, Wouter Verhelst wrote: > > > > On Thu, Dec 15, 2016 at 05:34:48PM +, Alex Bligh wrote: > >> > >>> On 15 Dec 2016, at 16:49, Wouter Verhelst wrote: > >>> > Because the namespaces and leaf-names