Re: [Qemu-devel] [Qemu-trivial] [PATCH for-2.8] docs: Fix description of the sentence

On 02/12/2016 03:59, Zhang Chen wrote: > > > On 12/01/2016 10:57 PM, Eric Blake wrote: >> On 12/01/2016 12:55 AM, Zhang Chen wrote: >>> Say it in another way to make it easier to understand. >>> >>> Signed-off-by: Zhang Chen >>> Signed-off-by: Eric Blake >> I guess that's because I suggested

Re: [Qemu-devel] [PATCH v2 1/6] arm: Uniquely name imx25 I2C buses.

On 12/02/2016 12:34 AM, Alexey Kardashevskiy wrote: > On 01/12/16 23:31, Cédric Le Goater wrote: >> On 12/01/2016 01:42 AM, Alastair D'Silva wrote: >>> On Wed, 2016-11-30 at 09:18 +0100, Cédric Le Goater wrote: On 11/30/2016 06:36 AM, Alastair D'Silva wrote: > From: Alastair D'Silva >

[Qemu-devel] [PATCH v5 00/10] tcg mips64 and mips r6 improvements

I tested this patch set on MIPS EB. 1) MIPS r2: (HOST) (qemu-system) (Debian ISO) 64eb -> i386 -> i386 64eb -> x86_64 -> i386 64eb -> x86_64 -> amd64 n32eb-

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

On Fri, Dec 02, 2016 at 06:23:52AM +, Tian, Kevin wrote: [...] > > IIUC the vfio container is created in: > > > > vfio_realize > > vfio_get_group > > vfio_connect_container > > > > Along the way (for vfio_get_group()), we have: > > > > group = vfio_get_group(groupid, pci_device_iom

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

On Thu, Dec 01, 2016 at 02:44:14PM +0800, Lan Tianyu wrote: [...] > Hi: > I think there are still other gaps to enable passthough device with > vIOMMU's DMA translation support. > > 1. Since this patchset is to shadow guest IO page table to > pIOMMU(physical IOMMU) vfio_dma_map/umap(), there wil

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

> From: Peter Xu [mailto:pet...@redhat.com] > Sent: Friday, December 02, 2016 1:59 PM > > On Thu, Dec 01, 2016 at 04:21:38AM +, Tian, Kevin wrote: > > > From: Peter Xu > > > Sent: Wednesday, November 30, 2016 5:24 PM > > > > > > On Mon, Nov 28, 2016 at 05:51:50PM +0200, Aviv B.D wrote: > > > >

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

On Thu, Dec 01, 2016 at 08:42:04AM -0700, Alex Williamson wrote: > On Wed, 30 Nov 2016 17:23:59 +0800 > Peter Xu wrote: > > > On Mon, Nov 28, 2016 at 05:51:50PM +0200, Aviv B.D wrote: > > > * intel_iommu's replay op is not implemented yet (May come in different > > > patch > > > set). > > >

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

On Thu, Dec 01, 2016 at 04:27:52PM +0800, Lan Tianyu wrote: > On 2016年11月30日 17:23, Peter Xu wrote: > > On Mon, Nov 28, 2016 at 05:51:50PM +0200, Aviv B.D wrote: > >> * intel_iommu's replay op is not implemented yet (May come in different > >> patch > >> set). > >> The replay function is requ

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

On Thu, Dec 01, 2016 at 04:21:38AM +, Tian, Kevin wrote: > > From: Peter Xu > > Sent: Wednesday, November 30, 2016 5:24 PM > > > > On Mon, Nov 28, 2016 at 05:51:50PM +0200, Aviv B.D wrote: > > > * intel_iommu's replay op is not implemented yet (May come in different > > > patch > > > set).

[Qemu-devel] [PATCH v3 6/7] tests: Test all implemented RX8900 functionality

From: Alastair D'Silva Signed-off-by: Alastair D'Silva --- tests/Makefile.include | 2 + tests/rx8900-test.c| 882 + 2 files changed, 884 insertions(+) create mode 100644 tests/rx8900-test.c diff --git a/tests/Makefile.include b/tests/Make

[Qemu-devel] [PATCH v3 5/7] hw/timer: Add Epson RX8900 RTC support

From: Alastair D'Silva This patch adds support for the Epson RX8900 I2C RTC. The following chip features are implemented: - RTC (wallclock based, ptimer 10x oversampling to pick up wallclock transitions) - Time update interrupt (per second/minute, wallclock based) - Alarms (wallclock

[Qemu-devel] [PATCH v3 3/7] hw/i2c: Add a NULL check for i2c slave init callbacks

From: Alastair D'Silva Add a NULL check for i2c slave init callbacks, so that we no longer need to implement empty init functions. Signed-off-by: Alastair D'Silva --- hw/arm/pxa2xx.c | 7 --- hw/arm/tosa.c | 7 --- hw/arm/z2.c | 7 --- hw/i2c/core.c | 6 +- hw/

[Qemu-devel] [PATCH v3 4/7] qtest: Support named interrupts

From: Alastair D'Silva The QTest framework cannot work with named interrupts. This patch adds support for them, as well as the ability to manipulate them from within a test. Read actions are via callbacks, which allows for pulsed interrupts to be read (the polled method used for the unnamed inte

[Qemu-devel] [PATCH v3 7/7] arm: Add an RX8900 RTC to the ASpeed board

From: Alastair D'Silva Connect an RX8900 RTC to i2c12 of the AST2500 SOC at address 0x32 Signed-off-by: Alastair D'Silva Signed-off-by: Chris Smart --- hw/arm/aspeed.c | 58 +++-- 1 file changed, 56 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v3 0/7] Add support for the Epson RX8900 RTC to the aspeed board

From: Alastair D'Silva This patch series adds support for the Epson RX8900 RTC to the Aspeed board. The tests use the existing imx25 infrastructure, and some minor changes have been made to uniquely identify the I2C buses. A NULL check have been added to eliminate empty i2cslave init functions.

[Qemu-devel] [PATCH v3 1/7] arm: Uniquely name imx25 I2C buses.

From: Alastair D'Silva The imx25 chip provides 3 i2c buses, but they have all been named "i2c", which makes it difficult to predict which bus a device will be connected to when specified on the command line. This patch addresses the issue by naming the buses uniquely: i2c-bus.0 i2c-bus.1 i2c-b

[Qemu-devel] [PATCH v3 2/7] hw/arm: remove trailing whitespace

From: Alastair D'Silva Remove trailing whitespace in hw/arm/pxa2xx.c Signed-off-by: Alastair D'Silva --- hw/arm/pxa2xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/pxa2xx.c b/hw/arm/pxa2xx.c index 21ea1d6..8aa0f8a 100644 --- a/hw/arm/pxa2xx.c +++ b/hw/arm/pxa2xx

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

On Fri, 2016-12-02 at 15:18 +1100, David Gibson wrote: > But if you pass through multiple groups, things get weird.  On q35, > you'd generally expect physically separate (different slot) devices to > appear under separate root complexes.  Whereas on pseries they'll > appear as siblings on a virtual

Re: [Qemu-devel] [PATCH v2 4/6] hw/timer: Add Epson RX8900 RTC support

On Fri, 2016-12-02 at 15:07 +1100, Alexey Kardashevskiy wrote: > On 02/12/16 14:30, Alastair D'Silva wrote: > > On Fri, 2016-12-02 at 13:48 +1100, Alexey Kardashevskiy wrote: > > > On 02/12/16 11:19, Alastair D'Silva wrote: > > > > On Thu, 2016-12-01 at 16:53 +1100, Alexey Kardashevskiy wrote: > >

Re: [Qemu-devel] [PATCH 1/1] ppc: Fix MMU model values needed by PR KVM

Ping? On Thu, Jul 21, 2016 at 08:07:25AM +0100, Mark Cave-Ayland wrote: > On 21/07/16 06:55, Sam Bobroff wrote: > > > Commit 4322e8c "ppc: Fix 64K pages support in full emulation" added > > the POWERPC_MMU_64K flag to the POWERPC_MMU_2_06 and POWERPC_MMU_2_07 > > definitions but not to their "deg

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

On Fri, Nov 25, 2016 at 03:36:25PM +0100, Andrea Bolognani wrote: > On Wed, 2016-11-23 at 16:02 +1100, David Gibson wrote: > > > > The change from OHCI to XHCI only affected the *default* USB > > > > controller, which libvirt tries its best not to use anyway: > > > > instead, it will prefer to use

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH qemu] spapr_pci: Create PCI-express root bus by default

On Fri, Nov 25, 2016 at 02:46:21PM +0100, Andrea Bolognani wrote: > On Wed, 2016-11-23 at 16:00 +1100, David Gibson wrote: > > > Existing libvirt versions assume that pseries guests have > > > a legacy PCI root bus, and will base their PCI address > > > allocation / PCI topology decisions on that f

Re: [Qemu-devel] [PATCH v2 4/6] hw/timer: Add Epson RX8900 RTC support

On 02/12/16 14:30, Alastair D'Silva wrote: > On Fri, 2016-12-02 at 13:48 +1100, Alexey Kardashevskiy wrote: >> On 02/12/16 11:19, Alastair D'Silva wrote: >>> On Thu, 2016-12-01 at 16:53 +1100, Alexey Kardashevskiy wrote: >>> On 30/11/16 16:36, Alastair D'Silva wrote: > From: Alastair D'Sil

Re: [Qemu-devel] [PATCH 3/3] Add a new qmp command to do checkpoint, get replication error

On 12/01/2016 10:55 PM, Eric Blake wrote: On 12/01/2016 12:06 AM, Zhang Chen wrote: We can call this qmp command to do checkpoint outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- docs/qmp-commands.txt | 24 +++

Re: [Qemu-devel] [PATCH 2/3] Add a new qmp command to start/stop replication

On 12/01/2016 10:55 PM, Eric Blake wrote: On 12/01/2016 12:06 AM, Zhang Chen wrote: We can call this qmp command to start/stop replication outside of qemu. Like Xen colo need this function. Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --- +++ b/qapi-schema.json @@ -4676,6 +4676,24

Re: [Qemu-devel] [PATCH v2 4/6] hw/timer: Add Epson RX8900 RTC support

On Fri, 2016-12-02 at 13:48 +1100, Alexey Kardashevskiy wrote: > On 02/12/16 11:19, Alastair D'Silva wrote: > > On Thu, 2016-12-01 at 16:53 +1100, Alexey Kardashevskiy wrote: > > > > > On 30/11/16 16:36, Alastair D'Silva wrote: > > > > From: Alastair D'Silva > > > > > > > > This patch adds suppo

[Qemu-devel] Unable to add ram object with same ID after addition, migration and removal at the target

Hi, - Add ram object and dimm device at the source (qemu) object_add memory-backend-ram,id=ram0,size=128M (qemu) device_add pc-dimm,id=dimm0,memdev=ram0 - Migrate the VM and remove the dimm device and ram object at the target (qemu) device_del dimm0 (qemu) object_del ram0 - Adding the ram obje

Re: [Qemu-devel] [PATCH for-2.8] docs: Fix description of the sentence

On 12/01/2016 08:59 PM, Zhang Chen wrote: > > > On 12/01/2016 10:57 PM, Eric Blake wrote: >> On 12/01/2016 12:55 AM, Zhang Chen wrote: >>> Say it in another way to make it easier to understand. >>> >>> Signed-off-by: Zhang Chen >>> Signed-off-by: Eric Blake >> I guess that's because I suggested

Re: [Qemu-devel] [PATCH 00/14] block: Image locking series

On 31.10.2016 16:38, Fam Zheng wrote: > This is v9 of the image locking series. I redid the whole series, adopting the > "two locks" approach from Kevin and Max. > > Depends on "[Qemu-devel] [PATCH] raw-posix: Rename 'raw_s' to 'rs'" in Max's > block branch. > > Fam Zheng (14): > osdep: Add qem

Re: [Qemu-devel] [PATCH 1/3] Migration: Don't load vmdesc when xen is enabled

On 12/01/2016 10:54 PM, Eric Blake wrote: On 12/01/2016 12:06 AM, Zhang Chen wrote: Xen need't this. Huh? Did you mean: Xen doesn't need this. Yes, you get the point. I will fix this comments in next version. Thanks Zhang Chen Signed-off-by: Zhang Chen Signed-off-by: Wen Congyang --

Re: [Qemu-devel] [PATCH for-2.8] docs: Fix description of the sentence

On 12/01/2016 10:57 PM, Eric Blake wrote: On 12/01/2016 12:55 AM, Zhang Chen wrote: Say it in another way to make it easier to understand. Signed-off-by: Zhang Chen Signed-off-by: Eric Blake I guess that's because I suggested the replacement text to use, even though I didn't write the patc

Re: [Qemu-devel] [PATCH 13/14] raw-posix: Implement image locking

On 31.10.2016 16:38, Fam Zheng wrote: > This implements open flag sensible image locking for local file > and host device protocol. > > virtlockd in libvirt locks the first byte, so we start looking at the > file bytes from 1. > > Quoting what was proposed by Kevin Wolf , there are > four locking

Re: [Qemu-devel] [PATCH v2 4/6] hw/timer: Add Epson RX8900 RTC support

On 02/12/16 11:19, Alastair D'Silva wrote: > On Thu, 2016-12-01 at 16:53 +1100, Alexey Kardashevskiy wrote: > >> On 30/11/16 16:36, Alastair D'Silva wrote: >>> From: Alastair D'Silva >>> >>> This patch adds support for the Epson RX8900 I2C RTC. >>> >>> The following chip features are implemented:

Re: [Qemu-devel] [PATCH 06/14] block: Set "share-rw" flag for incoming migration

On 31.10.2016 16:38, Fam Zheng wrote: > In this way the source side QEMU is writing to the image. We need to > open it, so share-rw is required. > > Signed-off-by: Fam Zheng > --- > blockdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Should we make some effort to clear the fl

Re: [Qemu-devel] [PATCH 05/14] block: Set "share-rw" flag in drive-backup when sync=none

On 31.10.2016 16:38, Fam Zheng wrote: > In this case we may open the source's backing image chain multiple > times. Setting share flag means the new open won't try to acquire or > check any lock, once we implement image locking. > > Signed-off-by: Fam Zheng > > --- > > An alternative is reusing

Re: [Qemu-devel] [PATCH 04/14] qemu-img: Set "share-rw" flag in read-only commands

On 31.10.2016 16:38, Fam Zheng wrote: > Checking the status of an image when it is being used by guest is > usually useful, True for qemu-img info and maybe even qemu-img compare (and qemu-img map is just a debugging tool, so that's fine, too), but I don't think qemu-img check is very useful. You'

Re: [Qemu-devel] [PATCH 01/14] osdep: Add qemu_lock_fd and qemu_unlock_fd

On 31.10.2016 16:38, Fam Zheng wrote: > They are wrappers of POSIX fcntl "file private locking". > > Signed-off-by: Fam Zheng > --- > include/qemu/osdep.h | 2 ++ > util/osdep.c | 29 + > 2 files changed, 31 insertions(+) > > diff --git a/include/qemu/osdep.

Re: [Qemu-devel] [PATCH v2 4/6] hw/timer: Add Epson RX8900 RTC support

On Thu, 2016-12-01 at 16:53 +1100, Alexey Kardashevskiy wrote: > On 30/11/16 16:36, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > This patch adds support for the Epson RX8900 I2C RTC. > > > > The following chip features are implemented: > >  - RTC (wallclock based, ptimer 10x overs

Re: [Qemu-devel] [PATCH v3] doc: Add NBD_CMD_BLOCK_STATUS extension

Hi Alex, let me try my hand at clarifying some points... On 11/29/2016 07:57 AM, Alex Bligh wrote: > Vladimir, > > I went back to April to reread the previous train of conversation > then found you had helpfully summarised some if it. Comments > below. > > Rather than comment on many of the poin

Re: [Qemu-devel] [PATCH] qemu-img: Improve commit invalid base message

On 01.12.2016 03:36, Eric Blake wrote: > On 11/30/2016 08:05 PM, Max Reitz wrote: >> When trying to invoke qemu-img commit with a base image file name that >> is not part of the top image's backing chain, the user receives a rather >> plain "Base not found" error message. This is not really helpful

Re: [Qemu-devel] [PATCH v2 1/6] arm: Uniquely name imx25 I2C buses.

On 01/12/16 23:31, Cédric Le Goater wrote: > On 12/01/2016 01:42 AM, Alastair D'Silva wrote: >> On Wed, 2016-11-30 at 09:18 +0100, Cédric Le Goater wrote: >>> On 11/30/2016 06:36 AM, Alastair D'Silva wrote: From: Alastair D'Silva The imx25 chip provides 3 i2c buses, but they have al

Re: [Qemu-devel] [PATCH v2 1/6] arm: Uniquely name imx25 I2C buses.

On Thu, 2016-12-01 at 13:31 +0100, Cédric Le Goater wrote: > On 12/01/2016 01:42 AM, Alastair D'Silva wrote: > > On Wed, 2016-11-30 at 09:18 +0100, Cédric Le Goater wrote: > > > On 11/30/2016 06:36 AM, Alastair D'Silva wrote: > > > > diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c > > > > index

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 4/4] arm: pmu: Add CPI checking

On 01/12/16 21:12, Wei Huang wrote: Hi Wei, > On 12/01/2016 02:27 PM, Andre Przywara wrote: >> Hi, >> >> On 01/12/16 05:16, Wei Huang wrote: >>> From: Christopher Covington >>> >>> Calculate the numbers of cycles per instruction (CPI) implied by ARM >>> PMU cycle counter values. The code include

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 4/4] arm: pmu: Add CPI checking

On 01/12/16 21:18, Christopher Covington wrote: > On 12/01/2016 03:27 PM, Andre Przywara wrote: Hi, >>> + } >>> + avg = sum / NR_SAMPLES; >>> + printf(" sum=%"PRId64" avg=%"PRId64" avg_ipc=%"PRId64" " >>> + "avg_cpi=%"PRId64"\n", sum, avg, i /

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 4/4] arm: pmu: Add CPI checking

On 12/01/2016 03:27 PM, Andre Przywara wrote: > Hi, > > On 01/12/16 05:16, Wei Huang wrote: >> From: Christopher Covington >> >> Calculate the numbers of cycles per instruction (CPI) implied by ARM >> PMU cycle counter values. The code includes a strict checking facility >> intended for the -icou

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 4/4] arm: pmu: Add CPI checking

On 12/01/2016 02:27 PM, Andre Przywara wrote: > Hi, > > On 01/12/16 05:16, Wei Huang wrote: >> From: Christopher Covington >> >> Calculate the numbers of cycles per instruction (CPI) implied by ARM >> PMU cycle counter values. The code includes a strict checking facility >> intended for the -ic

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off

On Thu, Dec 01, 2016 at 09:42:58PM +0100, Laszlo Ersek wrote: > On 12/01/16 20:13, Eduardo Habkost wrote: > > On Thu, Dec 01, 2016 at 06:06:24PM +0100, Laszlo Ersek wrote: > >> For the time being, we cannot handle SMIs in OVMF if VCPUs can show up > >> after boot. Otherwise, advertise ICH9_LPC_SMI_

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off

On 12/01/16 20:13, Eduardo Habkost wrote: > On Thu, Dec 01, 2016 at 06:06:24PM +0100, Laszlo Ersek wrote: >> For the time being, we cannot handle SMIs in OVMF if VCPUs can show up >> after boot. Otherwise, advertise ICH9_LPC_SMI_F_BROADCAST. >> >> Implement this generally, by introducing a new PCMa

[Qemu-devel] [Bug 1646610] [NEW] "Assertion `!r->req.sg' failed." during live migration with VirtIO

Public bug reported: We've hit this issue twice so far, but don't have an obvious repro yet. It's pretty rare for us to hit it but I'm still trying so I can get a core and backtrace. The guest was Windows running a constant workload. We were using VirtIO SCSI drivers in both cases. In both cases

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 4/4] arm: pmu: Add CPI checking

Hi, On 01/12/16 05:16, Wei Huang wrote: > From: Christopher Covington > > Calculate the numbers of cycles per instruction (CPI) implied by ARM > PMU cycle counter values. The code includes a strict checking facility > intended for the -icount option in TCG mode in the configuration file. > > Si

Re: [Qemu-devel] Support for using TCG frontend as a library

> On 1 Dec 2016, at 21:13, Peter Maydell wrote: > > You need a QCOW2 disk to store the snapshots on, ... > Taking savevm snapshots doesn't need any cooperation > from the guest OS .. > I don't know whether anybody's tested this with M profile: does your Stellaris board support this? assuming I

[Qemu-devel] [PATCH v4 12/13] aio: self-tune polling time

This patch is based on the algorithm for the kvm.ko halt_poll_ns parameter in Linux. The initial polling time is zero. If the event loop is woken up within the maximum polling time it means polling could be effective, so grow polling time. If the event loop is woken up beyond the maximum polling

[Qemu-devel] [PATCH v4 11/13] virtio: disable virtqueue notifications during polling

This is a performance optimization to eliminate vmexits during polling. It also avoids spurious ioeventfd processing after polling ends. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/virtio/virtio.c b/hw/virtio/vi

[Qemu-devel] [PATCH v4 09/13] virtio: turn vq->notification into a nested counter

Polling should disable virtqueue notifications but that requires nested virtio_queue_set_notification() calls. Turn vq->notification into a counter so it is possible to do nesting. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 18 -- 1 file changed, 12 insertions(+), 6

[Qemu-devel] [PATCH v4 10/13] aio: add .io_poll_begin/end() callbacks

The begin and end callbacks can be used to prepare for the polling loop and clean up when polling stops. Note that they may only be called once for multiple aio_poll() calls if polling continues to succeed. Once polling fails the end callback is invoked before aio_poll() resumes file descriptor m

[Qemu-devel] [PATCH v4 13/13] iothread: add poll-grow and poll-shrink parameters

These parameters control the poll time self-tuning algorithm. They are optional and will default to sane values if omitted. Signed-off-by: Stefan Hajnoczi --- include/sysemu/iothread.h | 2 ++ iothread.c| 56 +-- 2 files changed, 47 i

[Qemu-devel] [PATCH v4 08/13] virtio-scsi: suppress virtqueue kick during processing

The guest does not need to kick the virtqueue while we are processing it. This reduces the number of vmexits during periods of heavy I/O. Signed-off-by: Stefan Hajnoczi --- hw/scsi/virtio-scsi.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff -

[Qemu-devel] [PATCH v4 04/13] virtio: poll virtqueues for new buffers

Add an AioContext poll handler to detect new virtqueue buffers without waiting for a guest->host notification. Signed-off-by: Stefan Hajnoczi --- hw/virtio/virtio.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index

[Qemu-devel] [PATCH v4 06/13] iothread: add polling parameters

Poll mode can be configured with -object iothread,poll-max-ns=NUM. Polling is disabled with a value of 0 nanoseconds. Signed-off-by: Stefan Hajnoczi --- include/sysemu/iothread.h | 3 +++ iothread.c| 50 +++ 2 files changed, 53 inserti

[Qemu-devel] [PATCH v4 05/13] linux-aio: poll ring for completions

The Linux AIO userspace ABI includes a ring that is shared with the kernel. This allows userspace programs to process completions without system calls. Add an AioContext poll handler to check for completions in the ring. Signed-off-by: Stefan Hajnoczi --- block/linux-aio.c | 17 +++

[Qemu-devel] [PATCH v4 03/13] aio: add polling mode to AioContext

The AioContext event loop uses ppoll(2) or epoll_wait(2) to monitor file descriptors or until a timer expires. In cases like virtqueues, Linux AIO, and ThreadPool it is technically possible to wait for events via polling (i.e. continuously checking for events without blocking). Polling can be fas

[Qemu-devel] [PATCH v4 00/13] aio: experimental virtio-blk polling mode

v4: * Added poll time self-tuning algorithm [Christian and Paolo] * Try a single iteration of polling to avoid non-blocking ppoll(2)/epoll_wait(2) [Paolo] * Reordered patches to make performance analysis easier - see below v3: * Avoid ppoll(2)/epoll_wait(2) if polling succeeded [Paolo] * Dis

[Qemu-devel] [PATCH v4 02/13] aio: add AioPollFn and io_poll() interface

The new AioPollFn io_poll() argument to aio_set_fd_handler() and aio_set_event_handler() is used in the next patch. Keep this code change separate due to the number of files it touches. Signed-off-by: Stefan Hajnoczi --- include/block/aio.h | 5 - aio-posix.c | 8 +

[Qemu-devel] [PATCH v4 01/13] aio: add flag to skip fds to aio_dispatch()

Polling mode will not call ppoll(2)/epoll_wait(2). Therefore we know there are no fds ready and should avoid looping over fd handlers in aio_dispatch(). Signed-off-by: Stefan Hajnoczi --- include/block/aio.h | 6 +- aio-posix.c | 14 ++ aio-win32.c | 6 --

[Qemu-devel] [PATCH v4 07/13] virtio-blk: suppress virtqueue kick during processing

The guest does not need to kick the virtqueue while we are processing it. This reduces the number of vmexits during periods of heavy I/O. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/block/vir

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

Hello Rafael, or anyone else affected, Accepted qemu into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/1:2.6.1+dfsg- 0ubuntu5.2 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See http

Re: [Qemu-devel] [PATCH v4 7/7] hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off

On Thu, Dec 01, 2016 at 06:06:24PM +0100, Laszlo Ersek wrote: > For the time being, we cannot handle SMIs in OVMF if VCPUs can show up > after boot. Otherwise, advertise ICH9_LPC_SMI_F_BROADCAST. > > Implement this generally, by introducing a new PCMachineClass method, > namely get_smi_host_featur

Re: [Qemu-devel] Support for using TCG frontend as a library

On 1 December 2016 at 18:39, Liviu Ionescu wrote: > as for snapshotting, I'm not sure how I can use this for bare > metal devices (hints highly appreciated). You need a QCOW2 disk to store the snapshots on, but it doesn't actually need to be accessible to the guest system, so it should work fine

[Qemu-devel] Call for volunteers: Google OSS-Fuzz for QEMU

Google has launched a new continuous fuzzing project. Similar to Coverity, we could participate to get notifications about bugs in QEMU. Does anyone want to be QEMU's OSS-Fuzz coordinator? https://github.com/google/oss-fuzz#accepting-new-projects You need to: 1. Be an active QEMU contributor 2.

Re: [Qemu-devel] [PATCH v4 41/64] tcg/aarch64: Handle ctz and clz opcodes

On 12/01/2016 10:36 AM, Alex Bennée wrote: > Did this sneak in again? This break the aarch64 build due to the missing > constant. Gah, it may have. I probably forgot to push the change from the rh pool machine that I had checked out. r~

Re: [Qemu-devel] Support for using TCG frontend as a library

> On 1 Dec 2016, at 16:38, Peter Maydell wrote: > ... network device backends ... is a fair bit of work. yes, that's a good point, and I also plan to add Ethernet support to some of my boards, but I need first to fix some issues that I consider more important, like Cortex-M system peripherals

Re: [Qemu-devel] [PATCH v4 41/64] tcg/aarch64: Handle ctz and clz opcodes

Richard Henderson writes: > Signed-off-by: Richard Henderson > --- > tcg/aarch64/tcg-target.h | 8 > tcg/aarch64/tcg-target.inc.c | 47 > > 2 files changed, 51 insertions(+), 4 deletions(-) > > diff --git a/tcg/aarch64/tcg-target.h b/

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 3/4] arm: pmu: Check cycle count increases

On 12/01/2016 05:27 AM, Andre Przywara wrote: > Hi, > > On 01/12/16 05:16, Wei Huang wrote: >> From: Christopher Covington >> >> Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, >> even for the smallest delta of two subsequent reads. >> >> Signed-off-by: Christopher Covington

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 3/4] arm: pmu: Check cycle count increases

On 12/01/2016 03:18 AM, Andrew Jones wrote: > On Wed, Nov 30, 2016 at 11:16:41PM -0600, Wei Huang wrote: >> From: Christopher Covington >> >> Ensure that reads of the PMCCNTR_EL0 are monotonically increasing, >> even for the smallest delta of two subsequent reads. >> >> Signed-off-by: Christophe

Re: [Qemu-devel] [PATCH v4 14/64] target-arm: Use new deposit and extract ops

Richard Henderson writes: > Use the new primitives for UBFX and SBFX. > > Signed-off-by: Richard Henderson > --- > target-arm/translate-a64.c | 79 > +++--- > target-arm/translate.c | 37 +- > 2 files changed, 34 insertions(+), 8

[Qemu-devel] [PATCH v4 7/7] hw/i386/pc_q35: advertise broadcast SMI if VCPU hotplug is turned off

For the time being, we cannot handle SMIs in OVMF if VCPUs can show up after boot. Otherwise, advertise ICH9_LPC_SMI_F_BROADCAST. Implement this generally, by introducing a new PCMachineClass method, namely get_smi_host_features(), and implement the above logic for pc-q35-2.9 and later. The idea i

[Qemu-devel] [PATCH v4 1/7] fw-cfg: support writeable blobs

From: "Michael S. Tsirkin" Useful to send guest data back to QEMU. Changes from Laszlo Ersek : - rebase the patch from Michael Tsirkin's original postings at [1] and [2] to the following patches: - loader: Allow a custom AddressSpace when loading ROMs - loader: Add AddressSpace loading sup

[Qemu-devel] [PATCH v4 2/7] fw-cfg: turn FW_CFG_FILE_SLOTS into a device property

We'd like to raise the value of FW_CFG_FILE_SLOTS. Doing it naively could lead to problems with backward migration: a more recent QEMU (running an older machine type) would allow the guest, in fw_cfg_select(), to select a high key value that is unavailable in the same machine type implemented by th

[Qemu-devel] [PATCH v4 6/7] hw/isa/lpc_ich9: add broadcast SMI feature

The generic edk2 SMM infrastructure prefers EFI_SMM_CONTROL2_PROTOCOL.Trigger() to inject an SMI on each processor. If Trigger() only brings the current processor into SMM, then edk2 handles it in the following ways: (1) If Trigger() is executed by the BSP (which is guaranteed before ExitBootS

[Qemu-devel] [PATCH v4 3/7] fw-cfg: expose "file_slots" parameter in fw_cfg_init_io_dma()

Accordingly, generalize the "file_slots" minimum calculation in fw_cfg_init_io_dma(), and move the constant FW_CFG_FILE_SLOTS_TRAD argument to the callers of fw_cfg_init_io_dma(). Cc: "Gabriel L. Somlo" Cc: "Michael S. Tsirkin" Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Paolo Bonzini Signed-off-

[Qemu-devel] [PATCH v4 5/7] hw/isa/lpc_ich9: add SMI feature negotiation via fw_cfg

Introduce the following fw_cfg files: - "etc/smi/host-features": a little endian uint64_t feature bitmap, presenting the features known by the host to the guest. Read-only for the guest. The content of this file is calculated by QEMU at startup (the calculation will be added later). The s

[Qemu-devel] [PATCH v4 4/7] hw/i386/pc: introduce 2.9 machine types with 0x20 fw_cfg file slots

Add "file_slots" compat properties for 2.8 and earlier machine types. Cc: "Michael S. Tsirkin" Cc: Eduardo Habkost Cc: Gerd Hoffmann Cc: Igor Mammedov Cc: Paolo Bonzini Signed-off-by: Laszlo Ersek --- include/hw/compat.h| 11 +++ include/hw/i386/pc.h | 3 +++

[Qemu-devel] [PATCH v4 0/7] q35: add negotiable broadcast SMI

* This is version 4 of the series; the last version was at . This version is practically a rewrite from scratch, seeking to address the v3 feedback. Here's what the individual patches do: - Patch #1 rebases and extends

Re: [Qemu-devel] [PATCH] monitor: fix object_del for command-line-created objects

Quoting Dr. David Alan Gilbert (2016-12-01 06:34:10) > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Nov 30, 2016 at 05:06:16PM -0600, Michael Roth wrote: > > > Currently objects specified on the command-line are only partially > > > cleaned up when 'object_del' is issued in either

Re: [Qemu-devel] [PATCH for-2.8] monitor: fix object_del for command-line-created objects

Quoting Eric Blake (2016-11-30 20:33:56) > On 11/30/2016 05:06 PM, Michael Roth wrote: > > Currently objects specified on the command-line are only partially > > cleaned up when 'object_del' is issued in either HMP or QMP: the > > object itself is fully finalized, but the QemuOpts are not removed.

Re: [Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements

On 12/01/2016 07:32 AM, James Hogan wrote: > On Wed, Nov 30, 2016 at 12:30:19PM -0800, Richard Henderson wrote: >> On 11/30/2016 10:39 AM, Jin Guojie wrote: >>> But even Su cannot provide an R6 machine. >> >> Ok, I guess we will just have to drop the R6 patches for now, until imgtec is >> able to p

Re: [Qemu-devel] [PATCH v5 00/10] tcg mips64 and mips r6 improvements

On 12/01/2016 05:51 AM, Jin Guojie wrote: > Changes in v5: > * Update against master(v2.8.0-rc2) > * Fix a bug: 64-bit big-endian guests hang on mips64 little-endian > hosts, and vice versa. This bug was first introduced in v2 patch, > due to obvious misuse of ret/arg registers in t

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 1/4] arm: Define macros for accessing system registers

On Thu, Dec 01, 2016 at 09:27:59AM -0600, Wei Huang wrote: > > > On 12/01/2016 02:59 AM, Andrew Jones wrote: > > > > Should this be From: Andre? > > > > On Wed, Nov 30, 2016 at 11:16:39PM -0600, Wei Huang wrote: > >> This patch defines four macros to assist creating system register > >> accesso

Re: [Qemu-devel] [PATCH v7 0/5] IOMMU: intel_iommu support map and unmap notifications

On Wed, 30 Nov 2016 17:23:59 +0800 Peter Xu wrote: > On Mon, Nov 28, 2016 at 05:51:50PM +0200, Aviv B.D wrote: > > * intel_iommu's replay op is not implemented yet (May come in different > > patch > > set). > > The replay function is required for hotplug vfio device and to move > > devices

Re: [Qemu-devel] [PATCH 06/10] aio-posix: remove walking_handlers, protecting AioHandler list with list_lock

On 30/11/2016 14:36, Paolo Bonzini wrote: > > > On 30/11/2016 14:31, Stefan Hajnoczi wrote: >> On Tue, Nov 29, 2016 at 12:47:03PM +0100, Paolo Bonzini wrote: >>> @@ -272,22 +275,32 @@ bool aio_prepare(AioContext *ctx) >>> bool aio_pending(AioContext *ctx) >>> { >>> AioHandler *node; >>>

Re: [Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements

On Wed, Nov 30, 2016 at 12:30:19PM -0800, Richard Henderson wrote: > On 11/30/2016 10:39 AM, Jin Guojie wrote: > > But even Su cannot provide an R6 machine. > > Ok, I guess we will just have to drop the R6 patches for now, until imgtec is > able to provide feedback on them. It booted a mips64r6 g

Re: [Qemu-devel] [kvm-unit-tests PATCH v13 1/4] arm: Define macros for accessing system registers

On 12/01/2016 02:59 AM, Andrew Jones wrote: > > Should this be From: Andre? > > On Wed, Nov 30, 2016 at 11:16:39PM -0600, Wei Huang wrote: >> This patch defines four macros to assist creating system register >> accessors under both ARMv7 and AArch64: >>* DEFINE_GET_SYSREG32(name, ...) >>

Re: [Qemu-devel] [PATCH 1/3] timer: fix misleading comment in timer.h

On 01/12/2016 14:50, Stefan Hajnoczi wrote: > On Wed, Nov 30, 2016 at 11:30:38PM -0500, Yaowei Bai wrote: >> It's timer to expire, not clock. >> >> Signed-off-by: Yaowei Bai >> --- >> include/qemu/timer.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > For the whole series: > > R

[Qemu-devel] [Bug 1626972] Re: QEMU memfd_create fallback mechanism change for security drivers

This bug was fixed in the package qemu - 1:2.6.1+dfsg-0ubuntu7~cloud0 --- qemu (1:2.6.1+dfsg-0ubuntu7~cloud0) xenial-ocata; urgency=medium . * New update for the Ubuntu Cloud Archive. . qemu (1:2.6.1+dfsg-0ubuntu7) zesty; urgency=medium . [ Rafael David Tinoco ] * Fixed w

Re: [Qemu-devel] [PATCH 1/3] Migration: Don't load vmdesc when xen is enabled

On 12/01/2016 12:06 AM, Zhang Chen wrote: > Xen need't this. Huh? Did you mean: Xen doesn't need this. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > migration/savevm.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/migration/savevm.c b/migration/savevm.c

Re: [Qemu-devel] [PATCH for-2.8] docs: Fix description of the sentence

On 12/01/2016 12:55 AM, Zhang Chen wrote: > Say it in another way to make it easier to understand. > > Signed-off-by: Zhang Chen > Signed-off-by: Eric Blake I guess that's because I suggested the replacement text to use, even though I didn't write the patch. At any rate, since this is doc-only

Re: [Qemu-devel] [PATCH 3/3] Add a new qmp command to do checkpoint, get replication error

On 12/01/2016 12:06 AM, Zhang Chen wrote: > We can call this qmp command to do checkpoint outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > docs/qmp-commands.txt | 24 > +++ b/qapi-schema.json > @@ -

Re: [Qemu-devel] [PATCH 2/3] Add a new qmp command to start/stop replication

On 12/01/2016 12:06 AM, Zhang Chen wrote: > We can call this qmp command to start/stop replication outside of qemu. > Like Xen colo need this function. > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > --- > +++ b/qapi-schema.json > @@ -4676,6 +4676,24 @@ > { 'command': 'xen-load-d

Re: [Qemu-devel] [PATCH v4 00/10] tcg mips64 and mips r6 improvements

On Thu, Dec 1, 2016 at 4:30 AM, Richard Henderson wrote: > On 11/30/2016 10:39 AM, Jin Guojie wrote: >> Yesterday I successfully got in touch with a Debian developer from imgtec. >> Welcome Su Yunqiang. >> V4 patch can be tested on mips64 be hosts now. >> The following guests on a mips64 >> big-

Re: [Qemu-devel] Support for using TCG frontend as a library

On 1 December 2016 at 13:33, Liviu Ionescu wrote: >> On 1 Dec 2016, at 14:38, Peter Maydell wrote: >> >> ... clean up QEMU's code so >> that it is less interdependent ... > > that's a good idea anyway, but this does not address the current issue. > > if I'd have a separate library with ARM TCG, f

  1   2   >