Re: [Qemu-devel] Confusion regarding temporaries with branch conditional

Peter Maydell writes: > On 30 November 2016 at 07:00, Nikunj A Dadhania > wrote: >> >> Hi, >> >> I was writing one instruction and hit following issue: >> >> [snip]/qemu/tcg/tcg.c:2039: tcg fatal error >> qemu-ppc64le: [snip]/qemu/translate-all.c:175: tb_lock: Assertion >> `!have_tb_lock' faile

Re: [Qemu-devel] qemu-system-sh4 vs qemu-system-arm/i386 default behavior

On 30.11.2016 02:01, Tom Rini wrote: > Hey all, > > I'm trying to make use of the r2d platform for U-Boot testing via QEMU. > After applying a series[1] I can use the kernel.org sh4 toolchain to get > a u-boot.bin that runs, mostly. I say mostly as first of all I have to > pass "-monitor null -se

Re: [Qemu-devel] Confusion regarding temporaries with branch conditional

On 30 November 2016 at 07:00, Nikunj A Dadhania wrote: > > Hi, > > I was writing one instruction and hit following issue: > > [snip]/qemu/tcg/tcg.c:2039: tcg fatal error > qemu-ppc64le: [snip]/qemu/translate-all.c:175: tb_lock: Assertion > `!have_tb_lock' failed. > Segmentation fault (core dumped

Re: [Qemu-devel] Linux kernel polling for QEMU

On 29 November 2016 at 19:38, Andrew Jones wrote: > Thanks for making me look, I was simply assuming we were in the while > loops above. > > I couldn't get the problem to reproduce with access to the monitor, > but by adding '-d exec' I was able to see cpu0 was on the wfe in > smp_boot_secondary.

[Qemu-devel] Confusion regarding temporaries with branch conditional

Hi, I was writing one instruction and hit following issue: [snip]/qemu/tcg/tcg.c:2039: tcg fatal error qemu-ppc64le: [snip]/qemu/translate-all.c:175: tb_lock: Assertion `!have_tb_lock' failed. Segmentation fault (core dumped) Debugging deeper found that its something to do with the variable ty

Re: [Qemu-devel] [PATCH v2 0/6] Add support for the Epson RX8900 RTC to the aspeed board

Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v2 0/6] Add support for the Epson RX8900 RTC to the aspeed board Type: series Message-id: 201611

Re: [Qemu-devel] [PATCH] virtio-scsi: introduce virtio_scsi_acquire/release

On Tue, 11/29 16:37, Paolo Bonzini wrote: > These will be used more as soon as the acquire/release is pushed down to > the ioeventfd handlers. > > Signed-off-by: Paolo Bonzini Looks sane. Reviewed-by: Fam Zheng

Re: [Qemu-devel] Linux kernel polling for QEMU

On Tue, 11/29 20:43, Stefan Hajnoczi wrote: > On Tue, Nov 29, 2016 at 1:24 PM, Fam Zheng wrote: > > On Tue, 11/29 12:17, Paolo Bonzini wrote: > >> On 29/11/2016 11:32, Fam Zheng wrote: > >> * it still needs a system call before polling is entered. Ideally, QEMU > >> could run without any system c

[Qemu-devel] [PATCH v2 4/6] hw/timer: Add Epson RX8900 RTC support

From: Alastair D'Silva This patch adds support for the Epson RX8900 I2C RTC. The following chip features are implemented: - RTC (wallclock based, ptimer 10x oversampling to pick up wallclock transitions) - Time update interrupt (per second/minute, wallclock based) - Alarms (wallclock

[Qemu-devel] [PATCH v2 1/6] arm: Uniquely name imx25 I2C buses.

From: Alastair D'Silva The imx25 chip provides 3 i2c buses, but they have all been named "i2c", which makes it difficult to predict which bus a device will be connected to when specified on the command line. This patch addresses the issue by naming the buses uniquely: i2c.0 i2c.1 i2c.2 Signed

[Qemu-devel] [PATCH v2 3/6] qtest: Support named interrupts

From: Alastair D'Silva The QTest framework cannot work with named interrupts. This patch adds support for them, as well as the ability to manipulate them from within a test. Read actions are via callbacks, which allows for pulsed interrupts to be read (the polled method used for the unnamed inte

[Qemu-devel] [PATCH v2 5/6] tests: Test all implemented RX8900 functionality

From: Alastair D'Silva Signed-off-by: Alastair D'Silva --- tests/Makefile.include | 2 + tests/rx8900-test.c| 881 + 2 files changed, 883 insertions(+) create mode 100644 tests/rx8900-test.c diff --git a/tests/Makefile.include b/tests/Make

[Qemu-devel] [PATCH v2 6/6] arm: Add an RX8900 RTC to the ASpeed board

From: Alastair D'Silva Connect an RX8900 RTC to i2c12 of the AST2500 SOC at address 0x32 Signed-off-by: Alastair D'Silva --- hw/arm/aspeed.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index c7206fd..8de95f2 100644 --- a/hw/arm/aspeed.c +

[Qemu-devel] [PATCH v2 2/6] hw/i2c: Add a NULL check for i2c slave init callbacks

From: Alastair D'Silva Add a NULL check for i2c slave init callbacks, so that we no longer need to implement empty init functions. Signed-off-by: Alastair D'Silva --- hw/arm/pxa2xx.c | 9 + hw/arm/tosa.c | 7 --- hw/arm/z2.c | 7 --- hw/i2c/core.c | 6 +- hw

[Qemu-devel] [PATCH v2 0/6] Add support for the Epson RX8900 RTC to the aspeed board

From: Alastair D'Silva This patch series adds support for the Epson RX8900 RTC to the Aspeed board. The tests use the existing imx25 infrastructure, and some minor changes have been made to uniquely identify the I2C buses. A NULL check have been added to eliminate empty i2cslave init functions.

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

Hello Stefan, > Why does the client have to know about failover if it's connected to >a server process on the same host? I thought the server process >manages networking issues (like the actual protocol to speak to other >VxHS nodes and for failover). Just to comment on this, the

[Qemu-devel] [ANNOUNCE] QEMU 2.8.0-rc2 is now available

Hello, On behalf of the QEMU Team, I'd like to announce the availability of the third release candidate for the QEMU 2.8 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.8.0-rc2.tar.bz2 You can help impr

[Qemu-devel] qemu-system-sh4 vs qemu-system-arm/i386 default behavior

Hey all, I'm trying to make use of the r2d platform for U-Boot testing via QEMU. After applying a series[1] I can use the kernel.org sh4 toolchain to get a u-boot.bin that runs, mostly. I say mostly as first of all I have to pass "-monitor null -serial null -serial stdio -nographic" to qemu-syste

Re: [Qemu-devel] [Bug 1574246] Re: Drunken keyboard in go32v2 programs

On Wed, May 04, 2016 at 10:38:09AM -, felix wrote: > I compiled the latest git snapshot (tag: v2.6.0-rc4, calling itself > 2.5.94; with GTK frontend) and could only half-reproduce the bug; keys > do not longer "jam", but arrow keys are still captured twice. I woudn't > make much of that differe

Re: [Qemu-devel] [PATCH for-2.9 28/30] aspeed: add a watchdog controller

On Tue, 2016-11-29 at 16:44 +0100, Cédric Le Goater wrote: > This enables reboot of a guest from U-Boot and Linux. > > Signed-off-by: Cédric Le Goater > Reviewed-by: Joel Stanley Reviewed-by: Andrew Jeffery > --- >  hw/arm/aspeed_soc.c | 13 + >  include/hw/arm/aspeed_soc.h

Re: [Qemu-devel] [PATCH v1 1/1] virtio crypto device specification: asymmetric crypto service

Hi Xin, Sorry for delay. :( > -Original Message- > From: Xin Zeng [mailto:xin.z...@intel.com] > Sent: Friday, October 28, 2016 10:52 AM > To: virtio-...@lists.oasis-open.org; qemu-devel@nongnu.org > Cc: m...@redhat.com; Gonglei (Arei); brian.a.keat...@intel.com; > john.grif...@intel.com;

[Qemu-devel] [PATCH v3 24/25] block/curl: Implement bdrv_refresh_filename()

Signed-off-by: Max Reitz --- block/curl.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/block/curl.c b/block/curl.c index 0777d5b..4725caf 100644 --- a/block/curl.c +++ b/block/curl.c @@ -872,6 +872,20 @@ static int64_t curl_getlength(BlockDriverState *bs) return s-

Re: [Qemu-devel] [PATCH] audio: ac97: add exit function

2016-11-30 8:47 GMT+08:00 Jonathan Neuschäfer : > On Tue, Nov 29, 2016 at 02:33:41AM -0800, Li Qiang wrote: > > From: Li Qiang > > > > Currently the ac97 device emulation doesn't have a exit function, > > hot unplug this device will leak some leak. Add a exit function to > > s/some leak/some memo

[Qemu-devel] [PATCH v3 25/25] block/null: Generate filename even with latency-ns

While we cannot represent the latency-ns option in a filename, it is not a significant option so not being able to should not stop us from generating a filename nonetheless. Signed-off-by: Max Reitz --- block/null.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/block/null

[Qemu-devel] [PATCH v3 22/25] block: Do not copy exact_filename from format file

If the a format BDS's file BDS is in turn a format BDS, we cannot simply use the same filename, because when opening a BDS tree based on a filename alone, qemu will create only one format node on top of one protocol node (disregarding a potential backing file). Signed-off-by: Max Reitz --- block

[Qemu-devel] [PATCH v3 23/25] block: Fix FIXME from "Add BDS.backing_overridden"

Said commit introduced a FIXME stating that bdrv_open_backing_file() should set bs->backing_overridden to true not only if the file.filename option was set, but if the "options" QDict contained any option that is significant for any node in the BDS tree emerging from the backing BDS. This behavior

[Qemu-devel] [PATCH v3 18/25] block: Add sgfnt_runtime_opts to BlockDriver

This new field can be set by block drivers to list the runtime options they accept that may influence the contents of the respective BDS. As of a follow-up patch, this list will be used by the common bdrv_refresh_filename() implementation to decide which options to put into BDS.full_open_options (a

[Qemu-devel] [PATCH v3 21/25] block: Purify .bdrv_refresh_filename()

Currently, BlockDriver.bdrv_refresh_filename() is supposed to both refresh the filename (BDS.exact_filename) and set BDS.full_open_options. Now that we have generic code in the central bdrv_refresh_filename() for creating BDS.full_open_options, we can drop the latter part from all BlockDriver.bdrv_

[Qemu-devel] [PATCH v3 20/25] block: Generically refresh runtime options

Instead of having every block driver which implements bdrv_refresh_filename() copy all of the significant runtime options over to bs->full_open_options, implement this process generically in bdrv_refresh_filename(). This patch only adds this new generic implementation, it does not remove the old f

[Qemu-devel] [PATCH v3 16/25] block: Add 'base-directory' BDS option

Using this option, one can directly override what bdrv_dirname() will return. This is useful if one uses e.g. qcow2 on top of quorum (with only protocol BDSs under the quorum BDS) and wants to be able to use relative backing filenames. Signed-off-by: Max Reitz --- block.c | 14

[Qemu-devel] [PATCH v3 14/25] block/nfs: Implement bdrv_dirname()

While the basic idea is obvious and could be handled by the default bdrv_dirname() implementation, we cannot generate a directory name if the gid or uid are set, so we have to explicitly return NULL in those cases. Signed-off-by: Max Reitz --- block/nfs.c | 14 ++ 1 file changed, 14

[Qemu-devel] [PATCH v3 19/25] block: Add BlockDriver.bdrv_gather_child_options

Some follow-up patches will rework the way bs->full_open_options is refreshed in bdrv_refresh_filename(). The new implementation will remove the need for the block drivers' bdrv_refresh_filename() implementations to set bs->full_open_options; instead, it will be generic and use static information f

[Qemu-devel] [PATCH v3 17/25] iotests: Add quorum case to test 110

Test 110 tests relative backing filenames for complex BDS trees. Add quorum as an example that can never work automatically (without special-casing if all child nodes have the same base directory), and an example on how to make it work manually (using the base-directory option). Signed-off-by: Max

[Qemu-devel] [PATCH v3 11/25] blkverify: Make bdrv_dirname() return NULL

blkverify's BDSs have a file BDS, but we do not want this to be preferred over the raw node. There is no way to decide between the two (and not really a reason to, either), so just return NULL in blkverify's implementation of bdrv_dirname(). Signed-off-by: Max Reitz --- block/blkverify.c | 10 ++

[Qemu-devel] [PATCH v3 08/25] block: Add bdrv_make_absolute_filename()

This is a general function for making a filename that is relative to a certain BDS absolute. It calls bdrv_get_full_backing_filename_from_filename() for now, but that will be changed in a follow-up patch. Signed-off-by: Max Reitz --- block.c | 15 +++ 1 file changed, 11 insertions(+

[Qemu-devel] [PATCH v3 12/25] quorum: Make bdrv_dirname() return NULL

While the common implementation for bdrv_dirname() should return NULL for quorum BDSs already (because they do not have a file node and their exact_filename field should be empty), there is no reason not to make that explicit. Signed-off-by: Max Reitz --- block/quorum.c | 11 +++ 1 file

[Qemu-devel] [PATCH v3 10/25] block: Add bdrv_dirname()

This function may be implemented by block drivers to derive a directory name from a BDS. Concatenating this g_free()-able string with a relative filename must result in a valid (not necessarily existing) filename, so this is a function that should generally be not implemented by format drivers, bec

[Qemu-devel] [PATCH v3 06/25] block: bdrv_get_full_backing_filename_from_...'s ret. val.

Make bdrv_get_full_backing_filename_from_filename() return an allocated string instead of placing the result in a caller-provided buffer. Signed-off-by: Max Reitz --- block.c | 32 +++- block/vmdk.c | 8 +++- include/block/block.h | 7 +++-

[Qemu-devel] [PATCH v3 09/25] block: Fix bdrv_find_backing_image()

bdrv_find_backing_image() should use bdrv_get_full_backing_filename() or bdrv_make_absolute_filename() instead of trying to do what those functions do by itself. path_combine_deprecated() can now be dropped, so let's do that. Signed-off-by: Max Reitz --- block.c | 28 +--

[Qemu-devel] [PATCH v3 15/25] block: Use bdrv_dirname() for relative filenames

bdrv_get_full_backing_filename_from_filename() breaks down when it comes to JSON filenames. Using bdrv_dirname() as the basis is better because since we have BDS, we can descend through the BDS tree to the protocol layer, which gives us a greater probability of finding a non-JSON name; also, bdrv_d

[Qemu-devel] [PATCH v3 04/25] block: Respect backing bs in bdrv_refresh_filename

Basically, bdrv_refresh_filename() should respect all children of a BlockDriverState. However, generally those children are driver-specific, so this function cannot handle the general case. On the other hand, there are only few drivers which use other children than @file and @backing (that being vm

[Qemu-devel] [PATCH v3 07/25] block: bdrv_get_full_backing_filename's ret. val.

Make bdrv_get_full_backing_filename() return an allocated string instead of placing the result in a caller-provided buffer. Signed-off-by: Max Reitz --- block.c | 26 +- block/qapi.c | 12 ++-- include/block/block.h | 3 +-- 3 files changed

[Qemu-devel] [PATCH v3 13/25] block/nbd: Implement bdrv_dirname()

The idea behind this implementation is that the export name might be interpreted as a path (which is the only apparent interpretation of relative filenames for NBD paths). The default implementation of bdrv_dirname() would handle that just fine for nbd+tcp, but not for nbd+unix, because in that ca

[Qemu-devel] [PATCH v3 03/25] block: Add BDS.backing_overridden

If the backing file is overridden, this most probably does change the guest-visible data of a BDS. Therefore, we will need to consider this in bdrv_refresh_filename(). Adding a new field to the BDS is not nice, but it is very simple and exactly keeps track of whether the backing file has been over

[Qemu-devel] [PATCH v3 05/25] block: Make path_combine() return the path

Besides being safe for arbitrary path lengths, after some follow-up patches all callers will want a freshly allocated buffer anyway. In the meantime, path_combine_deprecated() is added which has the same interface as path_combine() had before this patch. All callers to that function will be conver

[Qemu-devel] [PATCH v3 02/25] block: Use children list in bdrv_refresh_filename

bdrv_refresh_filename() should invoke itself recursively on all children, not just on file. With that change, we can remove the manual invocations in blkverify and quorum. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Alberto Garcia --- block.c | 9 + block/b

[Qemu-devel] [PATCH v3 01/25] block/mirror: Small absolute-paths simplification

When invoking drive-mirror in absolute-paths mode, the target's backing BDS is assigned to it in mirror_complete(). The current logic only does so if the target does not have that backing BDS already; but it actually cannot have a backing BDS at all (the BDS is opened with O_NO_BACKING in qmp_drive

[Qemu-devel] [PATCH v3 00/25] block: Fix some filename generation issues

And just a couple of days after v2, here's v3. (Because it feels better to review a fresh version rather than a version even the submitter knows to be broken.) Let me more or less repeat the cover letter from v2 first: There are some issues regarding filename generation right now: - You always

Re: [Qemu-devel] [PATCH] audio: ac97: add exit function

On Tue, Nov 29, 2016 at 02:33:41AM -0800, Li Qiang wrote: > From: Li Qiang > > Currently the ac97 device emulation doesn't have a exit function, > hot unplug this device will leak some leak. Add a exit function to s/some leak/some memory/ ? > avoid this. > > Signed-off-by: Li Qiang > --- > h

Re: [Qemu-devel] [PATCH v7 RFC] block/vxhs: Initial commit to add Veritas HyperScale VxHS block device support

+ Rakesh from Veritas On Mon, Nov 28, 2016 at 6:17 AM, Stefan Hajnoczi wrote: > On Mon, Nov 28, 2016 at 10:23:41AM +, Ketan Nilangekar wrote: >> >> >> On 11/25/16, 5:05 PM, "Stefan Hajnoczi" wrote: >> >> On Fri, Nov 25, 2016 at 08:27:26AM +, Ketan Nilangekar wrote: >> > On 11/24/

Re: [Qemu-devel] [PATCH v2 3/5] target-m68k: Inline shifts

Le 28/11/2016 à 15:54, Richard Henderson a écrit : > On 11/27/2016 11:35 AM, Laurent Vivier wrote: +tcg_gen_extr_i64_i32(QREG_CC_N, QREG_CC_C, t64); >> This does not extract correctly the C flag when the opsize is word or byte. >> I think we should use a shift instead: >> >> -t

Re: [Qemu-devel] [qemu patch V3 2/2] kvmclock: reduce kvmclock difference on migration

On Tue, Nov 29, 2016 at 10:34:05AM -0200, Eduardo Habkost wrote: > On Tue, Nov 29, 2016 at 08:56:00AM -0200, Marcelo Tosatti wrote: > > On Mon, Nov 28, 2016 at 03:12:01PM -0200, Eduardo Habkost wrote: > > > On Mon, Nov 28, 2016 at 02:45:24PM -0200, Marcelo Tosatti wrote: > > > > On Mon, Nov 28, 201

[Qemu-devel] vpc max table entries calculation error

i'm writing to discuss an issue in qemu's vpc creation. when creating a dynamic-type vpc image with qemu-img like so: $ qemu-img create -f vpc vhd.vhd 100M Formatting 'vhd.vhd', fmt=vpc size=104857600 and then inspecting the file (with a tool i wrote; it's also easy to see in a hex dump): $ vhd

Re: [Qemu-devel] Linux kernel polling for QEMU

On Tue, Nov 29, 2016 at 1:24 PM, Fam Zheng wrote: > On Tue, 11/29 12:17, Paolo Bonzini wrote: >> On 29/11/2016 11:32, Fam Zheng wrote: >> * it still needs a system call before polling is entered. Ideally, QEMU >> could run without any system call while in polling mode. >> >> Another possibility i

[Qemu-devel] [PATCH for-2.8 v2 2/2] loader: fix undefined behavior in rom_order_compare()

According to ISO C99 / N1256 (referenced in HACKING): > 6.5.8 Relational operators > > 4 For the purposes of these operators, a pointer to an object that is > not an element of an array behaves the same as a pointer to the first > element of an array of length one with the type of the object a

[Qemu-devel] [PATCH for-2.8 v2 1/2] loader: fix handling of custom address spaces when adding ROM blobs

* Commit 3e76099aacb4 ("loader: Allow a custom AddressSpace when loading ROMs") introduced the "Rom.as" field: (1) It modified the utility callers of rom_insert() to take "as" as a new parameter from *their* callers, and set "rom->as" from that parameter. The functions covered were

[Qemu-devel] [PATCH for-2.8 v2 0/2] loader fixes

Version 2 of , with the checkpatch error fixed. Thanks Laszlo Cc: "Michael S. Tsirkin" Cc: Alistair Francis Cc: Igor Mammedov Cc: Michael Walle Cc: Paolo Bonzini Cc: Peter Maydell Cc: Shannon Zhao Cc: qemu-...@nongnu.or

Re: [Qemu-devel] [PATCH] virtio-gpu: track and limit host memory allocations

- Original Message - > From: "Gerd Hoffmann" > To: qemu-devel@nongnu.org > Cc: "Gerd Hoffmann" , "Marc-André Lureau" > , "Dave Airlie" > , "李强" , "Michael S. Tsirkin" > > Sent: Tuesday, 29 November, 2016 10:42:36 PM > Subject: [PATCH] virtio-gpu: track and limit host memory allocation

Re: [Qemu-devel] Linux kernel polling for QEMU

On Tue, Nov 29, 2016 at 05:13:27PM +0100, Paolo Bonzini wrote: > > > On 29/11/2016 17:01, Andrew Jones wrote: > > OK, it may be due to scheduling then. Below is the test case (for AArch64) > > Also, I forgot to mention before that I can only see this with TCG, not > > KVM. If ppoll is allowed to

Re: [Qemu-devel] [PATCH 02/10] qemu-thread: introduce QemuLockCnt

On 11/29/2016 05:46 AM, Paolo Bonzini wrote: > A QemuLockCnt comprises a counter and a mutex, with primitives > to increment and decrement the counter, and to take and release the > mutex. It can be used to do lock-free visits to a data structure > whenever mutexes would be too heavy-weight and th

[Qemu-devel] [PATCH v1 1/2] i2c: Add flag to NACK I2C transfers when busy

Add a busy flag on the I2CSlave struct which the device could set to NACK I2C transfer requests during the execution of the event handling function. If the busy flag is set, i2c_start_transfer() shall return 1. Signed-off-by: Fabio Urquiza --- hw/i2c/core.c| 3 +++ include/hw/i2c/i2c.h |

[Qemu-devel] [PATCH v1 2/2] tpm: Add TPM I2C Atmel frontend

Add a new frontend to the TPM backend that emulate the Atmel I2C TPM AT97SC3204T device and make it available to use on ARM machines that have I2C Bus configured. Signed-off-by: Fabio Urquiza --- default-configs/aarch64-softmmu.mak | 1 + default-configs/arm-softmmu.mak | 1 + hw/tpm/Mak

[Qemu-devel] [PATCH v1 0/2] Add Atmel I2C TPM AT97SC3204T emulated device

### Overview ### The TPM passthrough feature allow a developer to test TPM functionalities, like Measure Boot, without the need to tamper with critical parts of the host machine, ie. bootloader. It has been implemented to the x86 architecture and have the same interface that is provided to PC mach

Re: [Qemu-devel] [PATCH for-2.9 30/30] wdt: aspeed: use scu to get clock freq

This is a duplicate also. Sorry for the noise. C. 11/29/2016 05:07 PM, Cédric Le Goater wrote: > Add a link to the object model and a helper routine to retrieve the > value instead of using a constant value. > > Signed-off-by: Cédric Le Goater > Reviewed-by: Joel Stanley > --- > hw/arm/aspe

Re: [Qemu-devel] [PATCH for-2.9 29/30] aspeed/scu: add a aspeed_scu_get_clk() helper

This is a duplicate resend. Our SMTP server had an issue and the message finaly went through ... On 11/29/2016 05:07 PM, Cédric Le Goater wrote: > The clock frequency is defined in the HW STRAP1 register of the SCU > device. > > Signed-off-by: Cédric Le Goater > Reviewed-by: Joel Stanley > ---

Re: [Qemu-devel] [PATCH v2 8/9] quorum: Inline quorum_fifo_aio_cb()

On 22/11/2016 13:24, Kevin Wolf wrote: > Inlining the function removes some boilerplace code and replaces > recursion by a simple loop, so the code becomes somewhat easier to > understand. > > Signed-off-by: Kevin Wolf > Reviewed-by: Alberto Garcia > Reviewed-by: Eric Blake > --- > block/quo

Re: [Qemu-devel] [PATCH for-2.8 0/2] loader fixes

On 11/29/16 17:27, Michael S. Tsirkin wrote: > On Tue, Nov 29, 2016 at 05:37:02AM -0800, no-re...@patchew.org wrote: >> Hi, >> >> Your series seems to have some coding style problems. See output below for >> more information: >> >> Subject: [Qemu-devel] [PATCH for-2.8 0/2] loader fixes >> Type: ser

Re: [Qemu-devel] [PATCH for-2.8 2/2] loader: fix undefined behavior in rom_order_compare()

On 11/29/16 17:29, Michael S. Tsirkin wrote: > On Mon, Nov 28, 2016 at 08:57:01PM +0100, Laszlo Ersek wrote: >> According to ISO C99 / N1256 (referenced in HACKING): >> >>> 6.5.8 Relational operators >>> >>> 4 For the purposes of these operators, a pointer to an object that is >>> not an element

[Qemu-devel] [PATCH for-2.9 30/30] wdt: aspeed: use scu to get clock freq

Add a link to the object model and a helper routine to retrieve the value instead of using a constant value. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley --- hw/arm/aspeed_soc.c | 2 ++ hw/watchdog/wdt_aspeed.c | 19 +++ include/hw/watchdog/wdt

[Qemu-devel] [PATCH for-2.9 29/30] aspeed/scu: add a aspeed_scu_get_clk() helper

The clock frequency is defined in the HW STRAP1 register of the SCU device. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley --- hw/misc/aspeed_scu.c | 12 include/hw/misc/aspeed_scu.h | 1 + 2 files changed, 13 insertions(+) diff --git a/hw/misc/aspeed_scu.c b/h

Re: [Qemu-devel] [PATCH for-2.9 25/30] block: add a model option for MTD devices

On 11/29/2016 04:44 PM, Cédric Le Goater wrote: > This could be used to define the flash model to use on some boards > definitions. As this patch was part of a larger set, I did not send the whole set to qemu-block@ list. Could you please take a look at the proposal ? Thanks, C. > Signed-off

Re: [Qemu-devel] [PATCH for-2.9 25/30] block: add a model option for MTD devices

Am 29.11.2016 um 18:30 hat Cédric Le Goater geschrieben: > On 11/29/2016 04:44 PM, Cédric Le Goater wrote: > > This could be used to define the flash model to use on some boards > > definitions. > > As this patch was part of a larger set, I did not send the whole > set to qemu-block@ list. Could

Re: [Qemu-devel] [RFC v2 00/20] qmp: Report bus information on 'query-machines'

On Fri, Nov 25, 2016 at 08:05:36PM -0200, Eduardo Habkost wrote: [...] > Example output > -- > > TODO: update it. I've forgot to update it. Here it is: { "return": [ { "cpu-max": 1, "hotpluggable-cpus": false, "name": "none"

Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules

On 29/11/2016 18:16, Stefan Hajnoczi wrote: > FWIW I applied the pull request with the broken -r fix. Then I applied > this patch on top (and added a note to the commit description explaining > this was a refinement). I've also merged your newest pull request for > -rc2. Ok, that pull request

[Qemu-devel] [RFC PATCH 1/4] net: add FTGMAC100 support

The FTGMAC100 device is an Ethernet controller configured and controlled via a set of registers available on AHB bus. Packets are transmitted and received using DMA ring buffers. There are a MAC and MII/GMII interfaces. The model is for the moment complete enough to satisfy the Linux kernel but th

[Qemu-devel] [RFC PATCH 4/4] slirp: add a fake NC-SI backend

NC-SI (Network Controller Sideband Interface) enables a BMC to manage a set of NICs on a system. This model takes the simplest approach and reverses the NC-SI packets to pretend a NIC is present and exercise the Linux driver. The NCSI header file comes from mainline Linux and was untabified. Sig

[Qemu-devel] [RFC PATCH 3/4] aspeed: add a FTGMAC100 nic

There is a second NIC but we do not use it for the moment. We use the 'aspeed' property to tune the definition of the end of ring buffer bit for the Aspeed SoCs. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley Reviewed-by: Andrew Jeffery --- hw/arm/aspeed_soc.c | 21 +

[Qemu-devel] [RFC PATCH 2/4] net/ftgmac100: add a 'aspeed' property

The Aspeed SoCs have a different definition of the end of the ring buffer bit. Add a property to specify which set of bits should be used by the NIC. Signed-off-by: Cédric Le Goater Reviewed-by: Andrew Jeffery --- hw/net/ftgmac100.c | 19 +++ include/hw/net/ftgmac100.h |

[Qemu-devel] [RFC PATCH 0/4] FTGMAC100 model for the Aspeed SoCs

Hi, The Aspeed SoCs AST2400 and AST2500 have two FTGMAC100 ethernet controllers. This serie proposes a model for this device and a way to customize the bit definitions which are slightly different from the Faraday definitions. The last patch adds a fake NC-SI (Network Controller Sideband Interfac

Re: [Qemu-devel] [PATCH for-2.9 25/30] block: add a model option for MTD devices

On 11/29/2016 04:44 PM, Cédric Le Goater wrote: > This could be used to define the flash model to use on some boards > definitions. As this patch was part of a larger set, I did not send the whole set to qemu-block@ list. Could you please take a look at the proposal ? Thanks, C. > Signed-off

[Qemu-devel] [PATCH for-2.9 29/30] aspeed/scu: add a aspeed_scu_get_clk() helper

The clock frequency is defined in the HW STRAP1 register of the SCU device. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley --- hw/misc/aspeed_scu.c | 12 include/hw/misc/aspeed_scu.h | 1 + 2 files changed, 13 insertions(+) diff --git a/hw/misc/aspeed_scu.c b/h

[Qemu-devel] [PATCH for-2.9 30/30] wdt: aspeed: use scu to get clock freq

Add a link to the object model and a helper routine to retrieve the value instead of using a constant value. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley --- hw/arm/aspeed_soc.c | 2 ++ hw/watchdog/wdt_aspeed.c | 19 +++ include/hw/watchdog/wdt

Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules

On Tue, Nov 29, 2016 at 05:57:04PM +0100, Paolo Bonzini wrote: > > > On 29/11/2016 17:22, Stefan Hajnoczi wrote: > > On Tue, Nov 29, 2016 at 04:37:20PM +0100, Paolo Bonzini wrote: > >> Building qemu fails in distributions where gcc enables PIE by default > >> (e.g. Debian unstable) with: > >> > >

Re: [Qemu-devel] [Qemu-block] [PULL 0/4] Block layer patches for 2.8.0-rc2

On Tue, Nov 29, 2016 at 05:17:03PM +0100, Kevin Wolf wrote: > The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: > > Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) > > are available in the git repository at: > > git://repo.or.cz/qemu/kevin.git tag

Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules

On 29/11/2016 17:22, Stefan Hajnoczi wrote: > On Tue, Nov 29, 2016 at 04:37:20PM +0100, Paolo Bonzini wrote: >> Building qemu fails in distributions where gcc enables PIE by default >> (e.g. Debian unstable) with: >> >> /usr/bin/ld: -r and -pie may not be used together >> >> You have to use -r in

[Qemu-devel] [PULL v2 0/5] More patches for QEMU 2.8-rc2

The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to f9f885b78a6d9d1f0619d250f

Re: [Qemu-devel] Support for using TCG frontend as a library

> On 29 Nov 2016, at 18:26, Paolo Bonzini wrote: > > ... It's pretty clean! ... if you manage to make the TCG frontend as a library, it would be great to check that it can also be used from C++. the current QEMU headers prevent this, by using C++ reserved words (like `class`), which is a re

Re: [Qemu-devel] [PATCH for-2.8 2/2] loader: fix undefined behavior in rom_order_compare()

On Mon, Nov 28, 2016 at 08:57:01PM +0100, Laszlo Ersek wrote: > According to ISO C99 / N1256 (referenced in HACKING): > > > 6.5.8 Relational operators > > > > 4 For the purposes of these operators, a pointer to an object that is > > not an element of an array behaves the same as a pointer to the

Re: [Qemu-devel] Support for using TCG frontend as a library

On 27/11/2016 20:32, Alessandro Di Federico wrote: > > I've been investigating the needs of the various projects that might be > interested in using it and they sum up to the following: > > * Be able to load in the same process multiple libtcg-$ARCH.so for > different architectures. > * Obtai

[Qemu-devel] [PULL 3/4] qcow2: Remove stale comment

From: Alberto Garcia We haven't been using CONFIG_MADVISE since 02d0e095031b7fda77de8b Signed-off-by: Alberto Garcia Signed-off-by: Kevin Wolf --- block/qcow2-cache.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/qcow2-cache.c b/block/qcow2-cache.c index ab8ee2d..1d25147 100644 ---

Re: [Qemu-devel] [PATCH] rules.mak: Also try -r to build modules

On Tue, Nov 29, 2016 at 04:37:20PM +0100, Paolo Bonzini wrote: > Building qemu fails in distributions where gcc enables PIE by default > (e.g. Debian unstable) with: > > /usr/bin/ld: -r and -pie may not be used together > > You have to use -r instead of -Wl,-r to avoid gcc passing -pie to the lin

[Qemu-devel] [PULL 4/4] docs: Specify that cache-clean-interval is only supported in Linux

From: Alberto Garcia Make it clear that having Linux is a hard requirement for this feature. Signed-off-by: Alberto Garcia Signed-off-by: Kevin Wolf --- docs/qcow2-cache.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/qcow2-cache.txt b/docs/qcow2-cache.txt in

Re: [Qemu-devel] [PATCH for-2.8 1/2] loader: fix handling of custom address spaces when adding ROM blobs

On Mon, Nov 28, 2016 at 08:57:00PM +0100, Laszlo Ersek wrote: > * Commit 3e76099aacb4 ("loader: Allow a custom AddressSpace when loading > ROMs") introduced the "Rom.as" field: > > (1) It modified the utility callers of rom_insert() to take "as" as a > new parameter from *their* callers,

[Qemu-devel] [PULL 1/4] qcow2: Make qcow2_cache_table_release() work only in Linux

From: Alberto Garcia We are using QEMU_MADV_DONTNEED to discard the memory of individual L2 cache tables. The problem with this is that those semantics are specific to the Linux madvise() system call. Other implementations of madvise() (including the very Linux implementation of posix_madvise())

Re: [Qemu-devel] [PATCH for-2.8 0/2] loader fixes

On Tue, Nov 29, 2016 at 05:37:02AM -0800, no-re...@patchew.org wrote: > Hi, > > Your series seems to have some coding style problems. See output below for > more information: > > Subject: [Qemu-devel] [PATCH for-2.8 0/2] loader fixes > Type: series > Message-id: 20161128195701.24912-1-ler...@redh

[Qemu-devel] [PULL 0/4] Block layer patches for 2.8.0-rc2

The following changes since commit 00227fefd2059464cd2f59aed29944874c630e2f: Update version for v2.8.0-rc1 release (2016-11-22 22:29:08 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fetch changes up to 8f57758311d816c66e88cfcfdc9

[Qemu-devel] [PATCH for-2.9 25/30] block: add a model option for MTD devices

This could be used to define the flash model to use on some boards definitions. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley --- blockdev.c| 12 include/sysemu/blockdev.h | 1 + qemu-options.hx | 4 +++- 3 files changed, 16 insertions(+), 1

[Qemu-devel] [PATCH for-2.9 26/30] aspeed/smc: use flash model option

so that we can change the flash model from the command line. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley --- hw/arm/aspeed.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index a92c2f1c362b..f4232ce42cd0 100644 --- a/hw/arm/aspeed.c +++ b/

Re: [Qemu-devel] Linux kernel polling for QEMU

On Tue, Nov 29, 2016 at 11:39:44PM +0800, Fam Zheng wrote: > On Tue, 11/29 16:24, Andrew Jones wrote: > > On Tue, Nov 29, 2016 at 10:17:46PM +0800, Fam Zheng wrote: > > > On Tue, 11/29 14:27, Paolo Bonzini wrote: > > > > > > > > > > > > On 29/11/2016 14:24, Fam Zheng wrote: > > > > > On Tue, 11/2

[Qemu-devel] [PATCH for-2.9 24/30] aspeed: use first SPI flash as a boot ROM

Fill a ROM region with the flash content to support U-Boot. This is a little hacky but until we can boot from a MMIO region, it seems difficult to do anything else. Signed-off-by: Cédric Le Goater Reviewed-by: Joel Stanley Reviewed-by: Andrew Jeffery --- hw/arm/aspeed.c | 41 ++

  1   2   3   >