Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features

2016-09-24 Thread Michael S. Tsirkin
On Sat, Sep 24, 2016 at 06:10:37PM +0200, Paolo Bonzini wrote: > > > On 24/09/2016 00:05, Michael S. Tsirkin wrote: > >> e events... > >> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU... > >> > ERROR: struct MemoryRegionIOMMUOps should normally be const > >> > #1527: FILE: hw/i386/amd_iomm

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Wouter Verhelst
On Sat, Sep 24, 2016 at 11:19:53PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 24.09.2016 21:24, Alex Bligh wrote: > > > On 24 Sep 2016, at 18:47, Vladimir Sementsov-Ogievskiy > > > wrote: > > > > > > I just wanted to say, that if we want a possibility of clearing the whole > > > disk in on

Re: [Qemu-devel] [Nbd] write_zeroes/trim on the whole disk

2016-09-24 Thread Wouter Verhelst
On Sat, Sep 24, 2016 at 11:31:25AM +0100, Alex Bligh wrote: > > > On 23 Sep 2016, at 22:21, Wouter Verhelst wrote: > > > > On Fri, Sep 23, 2016 at 02:00:06PM -0500, Eric Blake wrote: > >> My preference would be a new flag to the existing commands, with > >> explicit documentation that 0 offset a

Re: [Qemu-devel] [PATCH 15/16] tcg: Make tb_flush() thread safe

2016-09-24 Thread Richard Henderson
On 09/24/2016 04:51 AM, Paolo Bonzini wrote: - Original Message - From: "Richard Henderson" To: "Paolo Bonzini" , qemu-devel@nongnu.org Cc: "serge fdrv" , c...@braap.org, "alex bennee" , "sergey fedorov" Sent: Friday, September 23, 2016 8:06:09 PM Subject: Re: [Qemu-devel] [PATCH 15

Re: [Qemu-devel] [PATCH 16/16] cpus-common: lock-free fast path for cpu_exec_start/end

2016-09-24 Thread Richard Henderson
On 09/24/2016 04:52 AM, Paolo Bonzini wrote: - Original Message - From: "Richard Henderson" To: "Paolo Bonzini" , qemu-devel@nongnu.org Cc: "serge fdrv" , c...@braap.org, "alex bennee" , "sergey fedorov" Sent: Friday, September 23, 2016 8:23:46 PM Subject: Re: [Qemu-devel] [PATCH 16

Re: [Qemu-devel] [Nbd] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 23:14, Carl-Daniel Hailfinger wrote: On 24.09.2016 19:33, Vladimir Sementsov-Ogievskiy wrote: On 24.09.2016 20:13, Vladimir Sementsov-Ogievskiy wrote: I agree that requests larger than disk size are ugly.. But splitting request brings me again to idea of having separate command or

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 21:24, Alex Bligh wrote: On 24 Sep 2016, at 18:47, Vladimir Sementsov-Ogievskiy wrote: I just wanted to say, that if we want a possibility of clearing the whole disk in one request for qcow2 we have to take 512 as granularity for such requests (with X = 9). An this is too small

Re: [Qemu-devel] [Nbd] write_zeroes/trim on the whole disk

2016-09-24 Thread Carl-Daniel Hailfinger
On 24.09.2016 19:33, Vladimir Sementsov-Ogievskiy wrote: > On 24.09.2016 20:13, Vladimir Sementsov-Ogievskiy wrote: >> I agree that requests larger than disk size are ugly.. But splitting >> request brings me again to idea of having separate command or flag >> for clearing the whole disk without th

[Qemu-devel] [PATCH v8 8/8] MAINTAINERS: Add Alistair to the maintainers list

2016-09-24 Thread Alistair Francis
Add Alistair Francis as the maintainer for the Netduino 2 and SMM32F205 SoC. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- MAINTAINERS | 15 +++ 1 file changed, 15 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a3a2ad7..30b1155 100644 --- a/MAINTAI

[Qemu-devel] [PATCH v8 7/8] STM32F205: Connect the SPI devices

2016-09-24 Thread Alistair Francis
Connect the SPI devices to the STM32F205 SoC. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- V2: - Fix up the device/devices commit message hw/arm/stm32f205_soc.c | 22 ++ include/hw/arm/stm32f205_soc.h | 3 +++ 2 files changed, 25 insertions(+

[Qemu-devel] [PATCH v8 6/8] STM32F205: Connect the ADC devices

2016-09-24 Thread Alistair Francis
Connect the ADC devices to the STM32F205 SoC. Signed-off-by: Alistair Francis --- V7: - Create the new ADC device V5: - Use the new irq ORing function V4: - Connect all the interrupt lines correctly V2: - Fix up the device/devices commit message hw/arm/stm32f205_soc.c | 35 +

[Qemu-devel] [PATCH v8 4/8] STM32F2xx: Add the SPI device

2016-09-24 Thread Alistair Francis
Add the STM32F2xx SPI device. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- V4: - Add VMState - Small fixes V2: - Address Peter C's comments default-configs/arm-softmmu.mak | 1 + hw/ssi/Makefile.objs| 1 + hw/ssi/stm32f2xx_spi.c | 225 +

[Qemu-devel] [PATCH v8 3/8] STM32F2xx: Add the ADC device

2016-09-24 Thread Alistair Francis
Add the STM32F2xx ADC device. This device randomly generates values on each read. This also includes creating a hw/adc directory. Signed-off-by: Alistair Francis Reviewed-by: Peter Maydell --- V4: - Remove the rand() function - Add VMState - Small cleanups V2: - Address Peter C's comments

[Qemu-devel] [PATCH v8 5/8] irq: Add a new irq device that allows the ORing of lines

2016-09-24 Thread Alistair Francis
Signed-off-by: Alistair Francis --- As the migration framework is not included in user mode this needs to be a new file. V8: - Use the standard qdev_init_gpio_in() function V7: - Use the standard QEMU init/realise functions V6: - Make the OR IRQ device a TYPE_DEVICE - Add vmstate hw/core/Ma

[Qemu-devel] [PATCH v8 0/8] Update the Netduino 2 Machine

2016-09-24 Thread Alistair Francis
This patchset continues with the Netduino 2 and STM32F205 SoC work. This patch series makes a small change to the STM32F2xx SoC to tidy up the code. Next a feature is added to the STM32F2xx timer to display the PWM duty cycle, when debugging is enabled. Then the STM32F2xx SPI and ADC devices are

[Qemu-devel] [PATCH v8 1/8] STM32F205: Remove the individual device variables

2016-09-24 Thread Alistair Francis
Cleanup the individual DeviceState and SysBusDevice variables to re-use the same variable for each device. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- hw/arm/stm32f205_soc.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff

[Qemu-devel] [PATCH v8 2/8] STM32F2xx: Display PWM duty cycle from timer

2016-09-24 Thread Alistair Francis
If correctly configured allow the STM32F2xx timer to print out the PWM duty cycle information. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- V3: - Use OR instead of + for masking - Improve clarity of print statement V2: - Fix up if statement braces - Remove stm32f2xx_tim

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Alex Bligh
> On 24 Sep 2016, at 18:47, Vladimir Sementsov-Ogievskiy > wrote: > > I just wanted to say, that if we want a possibility of clearing the whole > disk in one request for qcow2 we have to take 512 as granularity for such > requests (with X = 9). An this is too small. 1tb will be the upper boun

Re: [Qemu-devel] [PATCH v2 4/9] virtio-blk: handle virtio_blk_handle_request() errors

2016-09-24 Thread Greg Kurz
On Fri, 23 Sep 2016 13:58:56 +0100 Stefan Hajnoczi wrote: > On Wed, Sep 21, 2016 at 06:57:20PM +0200, Greg Kurz wrote: > > @@ -586,13 +589,16 @@ void virtio_blk_handle_vq(VirtIOBlock *s, VirtQueue > > *vq) > > blk_io_plug(s->blk); > > > > while ((req = virtio_blk_get_request(s, vq)))

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 20:32, Alex Bligh wrote: On 24 Sep 2016, at 18:13, Vladimir Sementsov-Ogievskiy wrote: On 24.09.2016 19:49, Alex Bligh wrote: On 24 Sep 2016, at 17:42, Vladimir Sementsov-Ogievskiy wrote: On 24.09.2016 19:31, Alex Bligh wrote: On 24 Sep 2016, at 13:06, Vladimir Sementsov-Ogi

Re: [Qemu-devel] vhost-user-test failure

2016-09-24 Thread Maxime Coquelin
This time with Marc-André in cc:... On 09/23/2016 07:40 PM, Maxime Coquelin wrote: On 09/23/2016 05:41 PM, Michael S. Tsirkin wrote: On Fri, Sep 23, 2016 at 12:36:12PM -0300, Eduardo Habkost wrote: Hi, I hit a weird vhost-user-test failure on travis-ci recently, on a branch where I didn't t

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Alex Bligh
> On 24 Sep 2016, at 18:13, Vladimir Sementsov-Ogievskiy > wrote: > > On 24.09.2016 19:49, Alex Bligh wrote: >>> On 24 Sep 2016, at 17:42, Vladimir Sementsov-Ogievskiy >>> wrote: >>> >>> On 24.09.2016 19:31, Alex Bligh wrote: > On 24 Sep 2016, at 13:06, Vladimir Sementsov-Ogievskiy

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 20:13, Vladimir Sementsov-Ogievskiy wrote: On 24.09.2016 19:49, Alex Bligh wrote: On 24 Sep 2016, at 17:42, Vladimir Sementsov-Ogievskiy wrote: On 24.09.2016 19:31, Alex Bligh wrote: On 24 Sep 2016, at 13:06, Vladimir Sementsov-Ogievskiy wrote: Note: if disk size is not alig

Re: [Qemu-devel] [PATCH v7 5/8] irq: Add a new irq device that allows the ORing of lines

2016-09-24 Thread Alistair Francis
On Mon, Sep 19, 2016 at 7:03 AM, Peter Maydell wrote: > On 11 September 2016 at 15:54, Alistair Francis wrote: >> Signed-off-by: Alistair Francis >> --- >> As the migration framework is not included in user mode this needs to be a >> new file. >> >> V7: >> - Use the standard QEMU init/realise f

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 19:49, Alex Bligh wrote: On 24 Sep 2016, at 17:42, Vladimir Sementsov-Ogievskiy wrote: On 24.09.2016 19:31, Alex Bligh wrote: On 24 Sep 2016, at 13:06, Vladimir Sementsov-Ogievskiy wrote: Note: if disk size is not aligned to X we will have to send request larger than the dis

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Alex Bligh
> On 24 Sep 2016, at 17:52, Alex Bligh wrote: > > In *your* use-case holes may be desirable. However in the general case, you > cannot assume a server supports holes. Optional support for holes isn't even > in the mainline spec yet (AFAIR). You should also be aware that the minimum granularit

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Alex Bligh
> On 24 Sep 2016, at 17:48, Vladimir Sementsov-Ogievskiy > wrote: > >>> Use NBD_CMD_WRITE_ZEROES without NBD_CMD_FLAG_NO_HOLE and you can pretty >>> much assume that a server that supports holes will write holes. A server >>> that does not support holes will write zeroes. If you don't care wh

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Alex Bligh
> On 24 Sep 2016, at 17:42, Vladimir Sementsov-Ogievskiy > wrote: > > On 24.09.2016 19:31, Alex Bligh wrote: >>> On 24 Sep 2016, at 13:06, Vladimir Sementsov-Ogievskiy >>> wrote: >>> >>> Note: if disk size is not aligned to X we will have to send request larger >>> than the disk size to cle

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 19:44, Vladimir Sementsov-Ogievskiy wrote: On 24.09.2016 19:35, Alex Bligh wrote: On 24 Sep 2016, at 17:20, Vladimir Sementsov-Ogievskiy wrote: Also, accordingly to documentation, NBD_CMD_TRIM is not appropriate for disk clearing: * `NBD_CMD_TRIM` (4) A hint to the s

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 19:35, Alex Bligh wrote: On 24 Sep 2016, at 17:20, Vladimir Sementsov-Ogievskiy wrote: Also, accordingly to documentation, NBD_CMD_TRIM is not appropriate for disk clearing: * `NBD_CMD_TRIM` (4) A hint to the server that the data defined by len and offset is no l

[Qemu-devel] [PATCH v4] Add resolutions via the command-line

2016-09-24 Thread G 3
Add the ability to add resolutions from the command-line. This patch works by looking for a property called 'resolutions' in the QEMU,VGA node of OpenBIOS. If it is found all the resolutions are parsed and loaded. Example command-line: -prom-env resolutions=512x342,640x480,800x600,1024x600,1

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 19:31, Alex Bligh wrote: On 24 Sep 2016, at 13:06, Vladimir Sementsov-Ogievskiy wrote: Note: if disk size is not aligned to X we will have to send request larger than the disk size to clear the whole disk. If you look at the block size extension, the size of the disk must be an

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Alex Bligh
> On 24 Sep 2016, at 17:20, Vladimir Sementsov-Ogievskiy > wrote: > > Also, accordingly to documentation, NBD_CMD_TRIM is not appropriate for disk > clearing: > > * `NBD_CMD_TRIM` (4) > > A hint to the server that the data defined by len and offset is no > longer needed. A server

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Denis V. Lunev
On 09/24/2016 12:21 AM, Wouter Verhelst wrote: > On Fri, Sep 23, 2016 at 02:00:06PM -0500, Eric Blake wrote: >> My preference would be a new flag to the existing commands, with >> explicit documentation that 0 offset and 0 length must be used with that >> flag, when requesting a full-device wipe. >

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Alex Bligh
> On 24 Sep 2016, at 13:06, Vladimir Sementsov-Ogievskiy > wrote: > > Note: if disk size is not aligned to X we will have to send request larger > than the disk size to clear the whole disk. If you look at the block size extension, the size of the disk must be an exact multiple of the minimu

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 16:42, Vladimir Sementsov-Ogievskiy wrote: On 24.09.2016 15:06, Vladimir Sementsov-Ogievskiy wrote: On 24.09.2016 00:21, Wouter Verhelst wrote: On Fri, Sep 23, 2016 at 02:00:06PM -0500, Eric Blake wrote: My preference would be a new flag to the existing commands, with explicit do

Re: [Qemu-devel] [PULL 00/19] virtio, pc: fixes and features

2016-09-24 Thread Paolo Bonzini
On 24/09/2016 00:05, Michael S. Tsirkin wrote: >> e events... >> > Checking PATCH 18/19: hw/i386: Introduce AMD IOMMU... >> > ERROR: struct MemoryRegionIOMMUOps should normally be const >> > #1527: FILE: hw/i386/amd_iommu.h:280: >> > +MemoryRegionIOMMUOps iommu_ops; > > False positive. Not

Re: [Qemu-devel] [PULL 00/44] ppc-for-2.8 queue 20160922

2016-09-24 Thread Alex Bennée
David Gibson writes: > On Fri, Sep 23, 2016 at 08:42:22AM +0100, Alex Bennée wrote: >> >> David Gibson writes: >> >> > On Thu, Sep 22, 2016 at 03:03:50PM +0100, Peter Maydell wrote: >> >> On 22 September 2016 at 07:36, David Gibson >> >> wrote: >> >> > The following changes since commit >> >

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 15:06, Vladimir Sementsov-Ogievskiy wrote: On 24.09.2016 00:21, Wouter Verhelst wrote: On Fri, Sep 23, 2016 at 02:00:06PM -0500, Eric Blake wrote: My preference would be a new flag to the existing commands, with explicit documentation that 0 offset and 0 length must be used with

Re: [Qemu-devel] [PATCH 4/4] log: Add locking to large logging blocks

2016-09-24 Thread Paolo Bonzini
On 23/09/2016 17:29, Richard Henderson wrote: > Reuse the existing locking provided by stdio to keep in_asm, cpu, > op, op_opt, op_ind, and out_asm as contiguous blocks. > > While it isn't possible to interleave e.g. in_asm or op_opt logs > because of the TB lock protecting all code generation,

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 15:06, Vladimir Sementsov-Ogievskiy wrote: On 24.09.2016 00:21, Wouter Verhelst wrote: On Fri, Sep 23, 2016 at 02:00:06PM -0500, Eric Blake wrote: My preference would be a new flag to the existing commands, with explicit documentation that 0 offset and 0 length must be used with

Re: [Qemu-devel] write_zeroes/trim on the whole disk

2016-09-24 Thread Vladimir Sementsov-Ogievskiy
On 24.09.2016 00:21, Wouter Verhelst wrote: On Fri, Sep 23, 2016 at 02:00:06PM -0500, Eric Blake wrote: My preference would be a new flag to the existing commands, with explicit documentation that 0 offset and 0 length must be used with that flag, when requesting a full-device wipe. Alternative

Re: [Qemu-devel] [PATCH 16/16] cpus-common: lock-free fast path for cpu_exec_start/end

2016-09-24 Thread Paolo Bonzini
- Original Message - > From: "Richard Henderson" > To: "Paolo Bonzini" , qemu-devel@nongnu.org > Cc: "serge fdrv" , c...@braap.org, "alex bennee" > , "sergey fedorov" > > Sent: Friday, September 23, 2016 8:23:46 PM > Subject: Re: [Qemu-devel] [PATCH 16/16] cpus-common: lock-free fast p

Re: [Qemu-devel] [PATCH 15/16] tcg: Make tb_flush() thread safe

2016-09-24 Thread Paolo Bonzini
- Original Message - > From: "Richard Henderson" > To: "Paolo Bonzini" , qemu-devel@nongnu.org > Cc: "serge fdrv" , c...@braap.org, "alex bennee" > , "sergey fedorov" > > Sent: Friday, September 23, 2016 8:06:09 PM > Subject: Re: [Qemu-devel] [PATCH 15/16] tcg: Make tb_flush() thread s

Re: [Qemu-devel] [Nbd] write_zeroes/trim on the whole disk

2016-09-24 Thread Alex Bligh
> On 23 Sep 2016, at 22:21, Wouter Verhelst wrote: > > On Fri, Sep 23, 2016 at 02:00:06PM -0500, Eric Blake wrote: >> My preference would be a new flag to the existing commands, with >> explicit documentation that 0 offset and 0 length must be used with that >> flag, when requesting a full-devic

Re: [Qemu-devel] [PATCH v7 00/10] linux-user: Fix assorted Qemu user mode issues

2016-09-24 Thread Riku Voipio
On Thu, Sep 22, 2016 at 06:56:49PM +0200, Aleksandar Markovic wrote: > This series fixes certain Qemu user mode issues. The fixes mainly originate > from observation of LTP tests failures for execution in Qemu user mode on > various platforms. The series also contains a cleanup patch. Thanks, all

Re: [Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-24 Thread Riku Voipio
On Sat, Sep 24, 2016 at 10:05:28AM +, Riku Voipio wrote: > On Thu, Sep 22, 2016 at 07:24:36AM +0100, Leon Alrae wrote: > > > > Applied to target-mips queue, thanks. > > > > That's a bit unorthodox way but you have my acked-by then.. > > > Since these are mips-specific fixes I assumed it doe

Re: [Qemu-devel] [PATCH v7 0/7] linux-user: Fix miscellaneous Mips-specific issues

2016-09-24 Thread Riku Voipio
On Thu, Sep 22, 2016 at 07:24:36AM +0100, Leon Alrae wrote: > > > Applied to target-mips queue, thanks. > > That's a bit unorthodox way but you have my acked-by then.. > Since these are mips-specific fixes I assumed it doesn't really matter > whether it goes via your or my tree (I picked up a f

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/7] m25p80: add a m25p80_set_rom_storage() routine

2016-09-24 Thread Edgar E. Iglesias
On Sat, Sep 24, 2016 at 10:25:39AM +0200, Cédric Le Goater wrote: > On 09/23/2016 08:26 PM, mar.krzeminski wrote: > > Hi Cedric, > > > > W dniu 23.09.2016 o 10:28, Cédric Le Goater pisze: > >> On 09/23/2016 10:17 AM, Peter Maydell wrote: > >>> On 23 September 2016 at 08:19, Cédric Le Goater wrote

Re: [Qemu-devel] [PATCH 4/7] m25p80: add a m25p80_set_rom_storage() routine

2016-09-24 Thread Cédric Le Goater
On 09/23/2016 08:26 PM, mar.krzeminski wrote: > Hi Cedric, > > W dniu 23.09.2016 o 10:28, Cédric Le Goater pisze: >> On 09/23/2016 10:17 AM, Peter Maydell wrote: >>> On 23 September 2016 at 08:19, Cédric Le Goater wrote: But the goal is to boot from the device, so I added a memory region ali