[Qemu-devel] [Bug 1588328] Re: Qemu 2.6 Solaris 9 Sparc Segmentation Fault

2016-06-29 Thread Mark Cave-Ayland
Great news! FWIW with newer versions of QEMU, including 2.6.0, the framebuffer emulation is good enough to install and run Solaris (including X) without the -nographic/-serial options if you need it. I've also CCd the relevant patch to qemu-stable so it should appear in 2.6.1 also. Many thanks for

Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

2016-06-29 Thread Igor Mammedov
On Thu, 30 Jun 2016 07:12:08 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > On Wed, 29 Jun 2016 14:49:59 +0200 > > Markus Armbruster wrote: > > > >> Igor Mammedov writes: > >> > >> > replace mainly useless exit(1) on fatal error path with > >> > abort(), so that it would be

Re: [Qemu-devel] [PATCH 2/3] VFIO driver for mediated PCI device

2016-06-29 Thread Xiao Guangrong
On 06/21/2016 12:31 AM, Kirti Wankhede wrote: +static int mdev_dev_mmio_fault(struct vm_area_struct *vma, struct vm_fault *vmf) +{ + int ret; + struct vfio_mdev *vmdev = vma->vm_private_data; + struct mdev_device *mdev; + struct parent_device *parent; + u64 virta

Re: [Qemu-devel] [PATCH v2 22/23] vhost-user: wait until backend init is completed

2016-06-29 Thread Yuanhan Liu
On Fri, Jun 24, 2016 at 03:51:09PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > The chardev waits for an initial connection before starting qemu, > vhost-user wants the backend negotiation to be completed. vhost-user is > started in the net_vhost_user_event callback, wh

Re: [Qemu-devel] [PATCH 03/15] coroutine-ucontext: reduce stack size to 64kB

2016-06-29 Thread Peter Lieven
Am 28.06.2016 um 16:20 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 28.06.2016 um 13:35 schrieb Dr. David Alan Gilbert: * Peter Lieven (p...@kamp.de) wrote: Am 28.06.2016 um 12:57 schrieb Dr. David Alan Gilbert: * Paolo Bonzini (pbonz...@redhat.com) wrote: On 28/06

Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers

2016-06-29 Thread Markus Armbruster
John Snow writes: > On 06/28/2016 04:40 AM, Markus Armbruster wrote: >> Sascha Silbe writes: >> >>> Dear Paolo, >>> >>> Paolo Bonzini writes: >>> > After applying your series on top of f12103af and running "./configure" > in a clean working directory, I get the following errors for "ma

[Qemu-devel] [PATCH RFC] fixup! tests: New make target check-source

2016-06-29 Thread Markus Armbruster
--- tests/header-test-template.c | 16 1 file changed, 16 insertions(+) create mode 100644 tests/header-test-template.c diff --git a/tests/header-test-template.c b/tests/header-test-template.c new file mode 100644 index 000..b6f86f4 --- /dev/null +++ b/tests/header-test-temp

Re: [Qemu-devel] Default for phys-addr-bits? (was Re: [PATCH 4/5] x86: Allow physical address bits to be set)

2016-06-29 Thread Gerd Hoffmann
Hi, > Something somewhere in qemu/ kernel/ firmware is already reading the number > of physical bits to determine PCI mapping; if I do: > > ./x86_64-softmmu/qemu-system-x86_64 -m 4096,slots=16,maxmem=128T No, it's not the physbits. You add some memory hotplug slots here. Qemu will ask seabios

Re: [Qemu-devel] [PATCH 0/2] Clean up around the PCI holes

2016-06-29 Thread Markus Armbruster
Ping?

Re: [Qemu-devel] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code

2016-06-29 Thread David Gibson
On Wed, Jun 29, 2016 at 10:50:06PM +0200, Greg Kurz wrote: > This series is a sequel to the discussion on a patch from Ben's powernv > patchset: > > http://patchwork.ozlabs.org/patch/597153/ > > Indeed, since the DT is a machine abstraction, it should definitely sit > under hw/ppc and not

Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

2016-06-29 Thread Markus Armbruster
Igor Mammedov writes: > On Wed, 29 Jun 2016 14:49:59 +0200 > Markus Armbruster wrote: > >> Igor Mammedov writes: >> >> > replace mainly useless exit(1) on fatal error path with >> > abort(), so that it would be possible to generate core >> > dump, that could be used to analyse cause of problem

[Qemu-devel] [Bug 1588328] Re: Qemu 2.6 Solaris 9 Sparc Segmentation Fault

2016-06-29 Thread Zhen Ning Lim
Hi Mark, Thanks a lot. Got it working now. When formatting the label, there are 2 options, SMI and EFI. Once I format it with SMI, it seems to be able to find the disk. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.lau

Re: [Qemu-devel] [PATCH 3/8] spapr: drop duplicate variable in spapr_core_release()

2016-06-29 Thread Bharata B Rao
On Wed, Jun 29, 2016 at 10:50:45PM +0200, Greg Kurz wrote: > Signed-off-by: Greg Kurz > --- > hw/ppc/spapr_cpu_core.c |3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c > index 2615058da745..a15dc010626d 100644 > --- a/

Re: [Qemu-devel] [PATCH 2/8] spapr: do proper error propagation in spapr_cpu_core_realize_child()

2016-06-29 Thread Bharata B Rao
On Wed, Jun 29, 2016 at 10:50:32PM +0200, Greg Kurz wrote: > This patch changes spapr_cpu_core_realize_child() to have a local error > pointer and use error_propagate() as it is supposed to be done. > > Signed-off-by: Greg Kurz Reviewed-by: Bharata B Rao

Re: [Qemu-devel] [PATCH 1/8] spapr: drop reference on child object during core realization

2016-06-29 Thread Bharata B Rao
On Wed, Jun 29, 2016 at 10:50:20PM +0200, Greg Kurz wrote: > When a core is being realized, we create a child object for each thread > of the core. > > The child is first initialized with object_initialize() which sets its ref > count to 1, and then added to the core with object_property_add_child

Re: [Qemu-devel] [PATCH 0/2] convert device initialization functions

2016-06-29 Thread Wei, Jiangang
Ping These two patches seem to be forgotten ... On Tue, 2016-05-17 at 18:18 +0800, Wei Jiangang wrote: > The first had been reviewed. > The second had been posted last month, but no feedback. > They're similar, so resend them together. > > Wei Jiangang (2): > hw/pci-bridge: Convert pxb initiali

Re: [Qemu-devel] [PATCH v8 11/12] vfio: register aer resume notification handler for aer resume

2016-06-29 Thread Zhou Jie
Hi Alex, On 2016/6/30 2:22, Alex Williamson wrote: On Wed, 29 Jun 2016 16:54:05 +0800 Zhou Jie wrote: Hi Alex, And yet we have struct pci_dev.broken_intx_masking and we test for working DisINTx via pci_intx_mask_supported() rather than simply looking for a PCIe device. Some devices are bro

Re: [Qemu-devel] [PATCH v0] spapr: Restore support for 970MP and POWER8NVL CPU cores

2016-06-29 Thread David Gibson
On Wed, Jun 29, 2016 at 05:07:26PM +0530, Bharata B Rao wrote: > Introduction of core based CPU hotplug for PowerPC sPAPR didn't > add support for 970MP and POWER8NVL based core types. Add support for > the same. > > While we are here, add support for explicit specification of POWER5+_v2.1 > core

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: gen_pause for instructions: yield, mdoio, mdoom, miso

2016-06-29 Thread David Gibson
On Wed, Jun 29, 2016 at 10:00:57PM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2016-06-24 at 13:18 -0700, Aaron Larson wrote: > > Call gen_pause for all "or rx,rx,rx" encodings other nop.  This > > provides a reasonable implementation for yield, and a better > > approximation for mdoio, mdoom, a

Re: [Qemu-devel] Executed Host Instructions

2016-06-29 Thread Ayaz Akram
Hi all ! I hope you wouldn't mind a quick clarification regarding this question . If I do not take into account the exceptions and keep on adding number of translated instructions inside a TB (found through -d out_asm) for each time TB is seen in the exec trace (found through -d exec and nochaining

Re: [Qemu-devel] [PATCH] spec/qcow2: bitmaps: zero bitmap table offset

2016-06-29 Thread John Snow
On 06/29/2016 08:22 AM, Vladimir Sementsov-Ogievskiy wrote: > This allows effectively free in_use bitmap clusters including bitmap > table without loss of meaningful data. > > Now it is possible only to free end-point clusters and zero-out (not > free) bitmap table > Same comment as Max, the c

Re: [Qemu-devel] [PATCH RFC v2 0/5] Baby steps towards saner headers

2016-06-29 Thread John Snow
On 06/28/2016 04:40 AM, Markus Armbruster wrote: > Sascha Silbe writes: > >> Dear Paolo, >> >> Paolo Bonzini writes: >> After applying your series on top of f12103af and running "./configure" in a clean working directory, I get the following errors for "make check-source":

[Qemu-devel] [PATCH 1/1] spice: avoid .set_mm_time on >= 0.12.6

2016-06-29 Thread John Snow
Spice deprecated this callback in 0.12.6. It's not a problem yet, but it will cause Clang to fail in a -Werror build due to the deprecated tag. Signed-off-by: John Snow --- hw/display/qxl.c| 4 include/ui/qemu-spice.h | 3 +++ ui/spice-display.c | 4 3 files changed, 11 in

[Qemu-devel] [PATCH 0/1] spice: avoid .set_mm_time on >= 0.12.6

2016-06-29 Thread John Snow
As near as I can tell, Spice 0.12.6 will make absolutely no use of this callback, so my primitive understanding is that it should be safe to just compile out on newer spice versions. (Or at least, it will be functionally identical to what already happens in practice on such compilations.) The poi

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code

2016-06-29 Thread Greg Kurz
On Wed, 29 Jun 2016 22:50:06 +0200 Greg Kurz wrote: > This series is a sequel to the discussion on a patch from Ben's powernv > patchset: > > http://patchwork.ozlabs.org/patch/597153/ > > Indeed, since the DT is a machine abstraction, it should definitely sit > under hw/ppc and not in t

[Qemu-devel] [PATCH 7/8] cpu: add initialization helper without realize

2016-06-29 Thread Greg Kurz
This will allow PowerPC machines to compute the device-tree cpu id between initialization and realization of the cpu. Signed-off-by: Greg Kurz --- include/qom/cpu.h | 12 qom/cpu.c | 19 --- 2 files changed, 28 insertions(+), 3 deletions(-) diff --git a/

Re: [Qemu-devel] [PATCH 3/2] MAINTAINERS: Remove Blue Swirl leftovers

2016-06-29 Thread Ed Maste
On 29 June 2016 at 16:35, Ed Maste wrote: > > I agree with a large code drop being undesirable. Here's a little more information for reference. Sean's qemu-bsd-user branch is here: https://github.com/seanbruno/qemu-bsd-user The last upstream merge was from commit d6550e9e about a month ago. Dif

[Qemu-devel] [PATCH 8/8] hw/ppc: move DT cpu id generation to machine code

2016-06-29 Thread Greg Kurz
Now that cpu_index is computed at cpu initialization time, we can compute cpu_dt_id in the machine code. All the logic moves from ppc_cpu_realizefn() to a generic function in the machine code, that serves as the default for all machine types. A new ppc_cpu_init() helper is also added to be used i

[Qemu-devel] [PATCH 4/8] exec: add missing conditional compilation

2016-06-29 Thread Greg Kurz
Commit 741da0d38 "hw: cannot include hw/hw.h from user emulation" also switched off compilation of the vmstate bits in cpu_exec_init() for user mode. This patch does the same in cpu_exec_exit() because user mode shouldn't call vmstate_unregister() either. Signed-off-by: Greg Kurz --- exec.c |

[Qemu-devel] [PATCH 1/8] spapr: drop reference on child object during core realization

2016-06-29 Thread Greg Kurz
When a core is being realized, we create a child object for each thread of the core. The child is first initialized with object_initialize() which sets its ref count to 1, and then added to the core with object_property_add_child() which bumps the ref count to 2. When the core gets released, obje

[Qemu-devel] [PATCH 5/8] exec: move cpu_index init and exit to their own function

2016-06-29 Thread Greg Kurz
This patch splits the cpu_index bits from the rest of the cpu_exec init and exit code, so that they may be called separately. The goal is to be able to initialize cpu_index during cpu initialization and keep the rest for cpu realization. The cpu_exec_init() and cpu_exec_exit() functions are kept s

[Qemu-devel] [PATCH 6/8] ppc: move cpu index setup to instance_init/finalize

2016-06-29 Thread Greg Kurz
This patch moves cpu_index initialization to instance init: it will allow machine code to compute cpu_dt_id between cpu initialization and cpu realization. It also adds the related exit code to be called at instance finalize, for symmetry. This doesn't change behaviour when the cpu is setup with

[Qemu-devel] [PATCH 3/8] spapr: drop duplicate variable in spapr_core_release()

2016-06-29 Thread Greg Kurz
Signed-off-by: Greg Kurz --- hw/ppc/spapr_cpu_core.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c index 2615058da745..a15dc010626d 100644 --- a/hw/ppc/spapr_cpu_core.c +++ b/hw/ppc/spapr_cpu_core.c @@ -101,9 +101,8 @@ s

[Qemu-devel] [PATCH 2/8] spapr: do proper error propagation in spapr_cpu_core_realize_child()

2016-06-29 Thread Greg Kurz
This patch changes spapr_cpu_core_realize_child() to have a local error pointer and use error_propagate() as it is supposed to be done. Signed-off-by: Greg Kurz --- hw/ppc/spapr_cpu_core.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/ppc/spapr_cpu_core.c

[Qemu-devel] [PATCH 0/8] ppc: compute cpu_dt_id in the machine code

2016-06-29 Thread Greg Kurz
This series is a sequel to the discussion on a patch from Ben's powernv patchset: http://patchwork.ozlabs.org/patch/597153/ Indeed, since the DT is a machine abstraction, it should definitely sit under hw/ppc and not in the target code: - all machine types are forced to share the same num

[Qemu-devel] [Bug 1588328] Re: Qemu 2.6 Solaris 9 Sparc Segmentation Fault

2016-06-29 Thread Mark Cave-Ayland
I've just tried v2.6.0 with the recent ldstub patch applied and it looks from the output above that you're using an incorrect format to put down the disk label. I see the following: $ ./qemu-system-sparc -cdrom sol-9-905hw-ga-sparc-dvd.iso -hda /home/build/src/qemu/image/sparc32/sol9.qcow2 -boot

Re: [Qemu-devel] [PATCH 3/2] MAINTAINERS: Remove Blue Swirl leftovers

2016-06-29 Thread Ed Maste
On 29 June 2016 at 14:03, Peter Maydell wrote: > > I think from an upstream-maintainer viewpoint the question is > whether a code drop would be just a code drop, or whether > it gets us to a position where we have an active upstream > maintainer for the bsd-user code. I think the latter would > be

Re: [Qemu-devel] [PATCH 3/2] MAINTAINERS: Remove Blue Swirl leftovers

2016-06-29 Thread Alex Bennée
Paolo Bonzini writes: > On 29/06/2016 17:10, Peter Maydell wrote: >>> Honestly I'm wondering if a huge code drop could be the right solution >>> here. It's not how we usually do things, but rules exist to be broken... >> >> I can't say I'm really enthusiastic about doing that. > > Neither am I.

Re: [Qemu-devel] [PATCH v8 11/12] vfio: register aer resume notification handler for aer resume

2016-06-29 Thread Alex Williamson
On Wed, 29 Jun 2016 16:54:05 +0800 Zhou Jie wrote: > Hi Alex, > > > And yet we have struct pci_dev.broken_intx_masking and we test for > > working DisINTx via pci_intx_mask_supported() rather than simply > > looking for a PCIe device. Some devices are broken and some simply > > don't follow the

Re: [Qemu-devel] [PULL 00/10] Block patches

2016-06-29 Thread Peter Maydell
On 29 June 2016 at 04:10, Jeff Cody wrote: > The following changes since commit d7f30403576f04f1f3a5fb5a1d18cba8dfa7a6d2: > > cputlb: don't cpu_abort() if guest tries to execute outside RAM or RAM > (2016-06-28 18:50:53 +0100) > > are available in the git repository at: > > g...@github.com:co

Re: [Qemu-devel] [PATCH 3/2] MAINTAINERS: Remove Blue Swirl leftovers

2016-06-29 Thread Peter Maydell
On 29 June 2016 at 16:22, Paolo Bonzini wrote: > On 29/06/2016 17:10, Peter Maydell wrote: >>> Honestly I'm wondering if a huge code drop could be the right solution >>> here. It's not how we usually do things, but rules exist to be broken... >> >> I can't say I'm really enthusiastic about doing

Re: [Qemu-devel] [PATCH v4 3/3] tests: in IDE and AHCI tests perform DMA write before flushing

2016-06-29 Thread John Snow
On 06/28/2016 12:37 PM, John Snow wrote: > > > On 06/28/2016 05:21 AM, Evgeny Yakovlev wrote: >> >> On 28.06.2016 02:19, John Snow wrote: >>> >>> On 06/27/2016 10:47 AM, Denis V. Lunev wrote: From: Evgeny Yakovlev Due to changes in flush behaviour clean disks stopped generating

Re: [Qemu-devel] [PATCH] spec/qcow2: bitmaps: zero bitmap table offset

2016-06-29 Thread Max Reitz
On 29.06.2016 15:24, Vladimir Sementsov-Ogievskiy wrote: > On 29.06.2016 15:22, Vladimir Sementsov-Ogievskiy wrote: >> This allows effectively free in_use bitmap clusters including bitmap >> table without loss of meaningful data. I'm afraid I fail to understand this sentence. >> >> Now it is poss

Re: [Qemu-devel] scsi-bus: Add support for SCSI scanners

2016-06-29 Thread Jarkko Lavinen
On Tue, Jun 28, 2016 at 07:14:55PM +0200, Paolo Bonzini wrote: > This is wrong, because INQUIRY's byte 3 is defined to be part of the > length in modern SCSI standards. > This is wrong, because INQUIRY's byte 3 is defined to be part of the > length in modern SCSI standards. Ok. I was using outdate

Re: [Qemu-devel] [PATCH v2 02/15] blockjob: Decouple the ID from the device name in the BlockJob struct

2016-06-29 Thread Max Reitz
On 23.06.2016 14:47, Alberto Garcia wrote: > On Wed 22 Jun 2016 05:49:28 PM CEST, Kevin Wolf wrote: >>> I thought adding a new 'ID' field was simpler. The device name is >>> still a device name (where it makes sense). The default ID is >>> guaranteed to be valid and guaranteed not to clash with use

Re: [Qemu-devel] Default for phys-addr-bits? (was Re: [PATCH 4/5] x86: Allow physical address bits to be set)

2016-06-29 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > Hi, > > > > Well the crash of guest phys bits > host phys bits, should be easy to > > > reproduce by booting a 65GB guest on a 64GB RAM + 2GB swap host with > > > 36 host phys bits using the upstream qemu that forces the guest phys > > > bits to 40. >

Re: [Qemu-devel] [PATCH] virtio: abort on fatal error instead of just exiting

2016-06-29 Thread Igor Mammedov
On Wed, 29 Jun 2016 14:49:59 +0200 Markus Armbruster wrote: > Igor Mammedov writes: > > > replace mainly useless exit(1) on fatal error path with > > abort(), so that it would be possible to generate core > > dump, that could be used to analyse cause of problem. > > > > Signed-off-by: Igor Mamm

Re: [Qemu-devel] [RFC 6/8] linux-user: Support CPU work queue

2016-06-29 Thread Alex Bennée
Sergey Fedorov writes: > From: Sergey Fedorov > > Make CPU work core functions common between system and user-mode > emulation. User-mode does not have BQL, so flush_queued_work() is > protected by 'exclusive_lock'. > > Signed-off-by: Sergey Fedorov > Signed-off-by: Sergey Fedorov > --- > cp

Re: [Qemu-devel] [PATCH 1/1] mirror: fix request throttling in drive-mirror

2016-06-29 Thread Denis V. Lunev
On 06/29/2016 07:08 PM, Max Reitz wrote: On 22.06.2016 14:35, Denis V. Lunev wrote: There are 2 deficiencies here: - mirror_iteration could start several requests inside. Thus we could simply have more in_flight requests than MAX_IN_FLIGHT. - keeping this in mind throttling in mirror_run whic

Re: [Qemu-devel] [PATCH v2] xen: use native disk xenbus protocol if possible

2016-06-29 Thread Anthony PERARD
On Wed, Jun 29, 2016 at 05:50:48PM +0200, Juergen Gross wrote: > The qdisk implementation is using the native xenbus protocol only in > case of no protocol specified at all. As using the explicit 32- or > 64-bit protocol is slower than the native one due to copying requests > not by memcpy but elem

Re: [Qemu-devel] [RFC v3 19/19] cpu-exec: remove tb_lock from the hot-path

2016-06-29 Thread Alex Bennée
Sergey Fedorov writes: > On 29/06/16 17:47, Alex Bennée wrote: >> Sergey Fedorov writes: >> >>> On 03/06/16 23:40, Alex Bennée wrote: Lock contention in the hot path of moving between existing patched TranslationBlocks is the main drag on MTTCG performance. This patch pushes the

Re: [Qemu-devel] [PATCH 1/1] mirror: fix request throttling in drive-mirror

2016-06-29 Thread Max Reitz
On 22.06.2016 14:35, Denis V. Lunev wrote: > There are 2 deficiencies here: > - mirror_iteration could start several requests inside. Thus we could > simply have more in_flight requests than MAX_IN_FLIGHT. > - keeping this in mind throttling in mirror_run which is checking > s->in_flight == MAX

Re: [Qemu-devel] [RFC 7/8] cpu-exec-common: Introduce async_safe_run_on_cpu()

2016-06-29 Thread Alex Bennée
Sergey Fedorov writes: > On 27/06/16 12:36, Alex Bennée wrote: >> Sergey Fedorov writes: >> >>> From: Sergey Fedorov >>> > (snip) >>> diff --git a/cpus.c b/cpus.c >>> index 98f60f6f98f5..bb6bd8615cfc 100644 >>> --- a/cpus.c >>> +++ b/cpus.c >>> @@ -932,6 +932,18 @@ static void qemu_tcg_destroy

Re: [Qemu-devel] [PATCH 0/2] memory/intel_iommu: Generate error for incompatible usage

2016-06-29 Thread Paolo Bonzini
On 29/06/2016 17:56, Alex Williamson wrote: >>> > > Any comments on this series? I think we need Paolo's ack for the memory >>> > > changes and either of your ack for hw/i386/. I'm happy to pull this >>> > > through my tree with your approval though. Thanks, >> > >> > I think I already acke

[Qemu-devel] [PATCH 13/18] Clean up header guards that don't match their file name

2016-06-29 Thread Markus Armbruster
Header guard symbols should match their file name to make guard collisions less likely. Offenders found with scripts/clean-header-guards.pl -vn. Cleaned up with scripts/clean-header-guards.pl, followed by some renaming of new guard symbols picked by the script to better ones. Signed-off-by: Mark

[Qemu-devel] [PATCH 16/18] Clean up ill-advised or unusual header guards

2016-06-29 Thread Markus Armbruster
Cleaned up with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster --- contrib/ivshmem-client/ivshmem-client.h | 6 +++--- contrib/ivshmem-server/ivshmem-server.h | 6 +++--- crypto/block-luks.h | 6 +++--- crypto/block-qcow.h | 6 +++--- fsd

[Qemu-devel] [PATCH 11/18] spapr_pci: Include spapr.h instead of playing games with #error

2016-06-29 Thread Markus Armbruster
include/hw/pci-host/spapr.h needs hw/ppc/spapr.h. It checks whether its header guard is defined, and errors out if it isn't. Playing games with some other header's guard symbol is not a good idea. Just include the frackin' header already. Signed-off-by: Markus Armbruster --- include/hw/pci-ho

[Qemu-devel] [PATCH 14/18] libdecnumber: Don't fool around with guards to avoid #include

2016-06-29 Thread Markus Armbruster
Some libdecnumber headers avoid including decNumber.h or decContext.h again by checking their header guards. Don't. Including them multiple times is safe, and the compiler can do it efficiently. Signed-off-by: Markus Armbruster --- include/libdecnumber/decNumber.h | 4 +--- include/libdec

[Qemu-devel] [PATCH 05/18] linux-user: Clean up target_cpu.h header guards

2016-06-29 Thread Markus Armbruster
These headers all use TARGET_CPU_H as header guard symbol. Reuse of the same guard symbol in multiple headers is okay as long as they cannot be included together. Since we can avoid guard symbol reuse easily, do so: use guard symbol $target_TARGET_CPU_H for linux-user/$target/target_cpu.h. Signe

[Qemu-devel] [PATCH 15/18] libdecnumber: Don't error out on decNumberLocal.h re-inclusion

2016-06-29 Thread Markus Armbruster
decNumberLocal.h errors out when it's included with its header guard defined. This catches multiple inclusions. Drop that. Including it multiple times is safe, and the compiler can do it efficiently. Signed-off-by: Markus Armbruster --- include/libdecnumber/decNumberLocal.h | 2 -- 1 file cha

[Qemu-devel] [PATCH 17/18] Clean up decorations and whitespace around header guards

2016-06-29 Thread Markus Armbruster
Cleaned up with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster --- audio/audio.h | 3 ++- audio/audio_int.h | 3 ++- audio/audio_pt_int.h | 2 +- audio/mixeng.h| 3 ++- bsd-user/i386/target_syscall.h| 2 +-

[Qemu-devel] [PATCH 04/18] linux-user: Clean up target_syscall.h header guards

2016-06-29 Thread Markus Armbruster
Some of them use guard symbol TARGET_SYSCALL_H, but we also have CRIS_SYSCALL_H, MICROBLAZE_SYSCALLS_H, TILEGX_SYSCALLS_H and __UC32_SYSCALL_H__. They all upset scripts/clean-header-guards.pl. Reuse of the same guard symbol TARGET_SYSCALL_H in multiple headers is okay as long as they cannot be in

[Qemu-devel] [PATCH 07/18] linux-user: Clean up target_structs.h header guards

2016-06-29 Thread Markus Armbruster
These headers all use TARGET_STRUCTS_H as header guard symbol. Reuse of the same guard symbol in multiple headers is okay as long as they cannot be included together. Since we can avoid guard symbol reuse easily, do so: use guard symbol $target_TARGET_STRUCTS_H for linux-user/$target/target_struc

[Qemu-devel] [PATCH 06/18] linux-user: Clean up target_signal.h header guards

2016-06-29 Thread Markus Armbruster
These headers all use TARGET_SIGNAL_H as header guard symbol. Reuse of the same guard symbol in multiple headers is okay as long as they cannot be included together. Since we can avoid guard symbol reuse easily, do so: use guard symbol $target_TARGET_SIGNAL_H for linux-user/$target/target_signal.

[Qemu-devel] [PATCH 10/18] tcg: Clean up tcg-target.h header guards

2016-06-29 Thread Markus Armbruster
These use guard symbols like TCG_TARGET_$target. scripts/clean-header-guards.pl doesn't like them because they don't match their file name (they should, to make guard collisions less likely). Clean them up: use guard symbol $target_TCG_TARGET_H for tcg/$target/tcg-target.h. Signed-off-by: Markus

[Qemu-devel] [PATCH 01/18] Use #include "..." for our own headers, <...> for others

2016-06-29 Thread Markus Armbruster
Tracked down with an ugly, brittle and probably buggy Perl script. Also move includes converted to <...> up so they get included before ours where that's obviously okay. Signed-off-by: Markus Armbruster --- block/iscsi.c | 1 - crypto/pbkdf-gcrypt.c | 2 +- cry

[Qemu-devel] [PATCH 09/18] linux-user: Fix broken header guard in syscall_defs.h

2016-06-29 Thread Markus Armbruster
Found with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster --- linux-user/syscall_defs.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/linux-user/syscall_defs.h b/linux-user/syscall_defs.h index dce1bcc..b43966e 100644 --- a/linux-user/syscall_defs.h

[Qemu-devel] [PATCH 18/18] cris: Fix broken header guard in hw/cris/boot.h

2016-06-29 Thread Markus Armbruster
Found with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster --- hw/cris/boot.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/cris/boot.h b/hw/cris/boot.h index c4d3fa6..218854e 100644 --- a/hw/cris/boot.h +++ b/hw/cris/boot.h @@ -1,5 +1,5 @@ -#ifndef

[Qemu-devel] [PATCH 00/18] Clean up #include "..." vs "<...>" and header guards

2016-06-29 Thread Markus Armbruster
This series takes a good swing at two annoyances: * We sometimes use #include "..." even for system headers, and <...> for our own headers. Makes spotting the system headers harder, and can be confusing. PATCH 01 cleans this up. You've seen it before as "[PATCH RFC v2 1/5] Use #include ".

[Qemu-devel] [PATCH 12/18] Drop Emacs local variables lists redundant with .dir-locals.el

2016-06-29 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/pci-bridge/ioh3420.c| 9 - hw/pci-bridge/xio3130_downstream.c | 9 - hw/pci-bridge/xio3130_upstream.c | 10 -- include/qemu/acl.h | 8 monitor.c | 9 - util/

[Qemu-devel] [PATCH 02/18] scripts: New clean-header-guards.pl

2016-06-29 Thread Markus Armbruster
The conventional way to ensure a header can be included multiple times is to bracket it like this: #ifndef HEADER_NAME_H #define HEADER_NAME_H ... #endif where HEADER_NAME_H is a symbol unique to this header. The endif may be optionally decorated like this: #endif /* HEADER_

Re: [Qemu-devel] [PATCH 0/2] memory/intel_iommu: Generate error for incompatible usage

2016-06-29 Thread Alex Williamson
On Wed, 29 Jun 2016 12:53:39 +0200 Paolo Bonzini wrote: > On 28/06/2016 16:49, Alex Williamson wrote: > > Paolo & Michael, > > > > Any comments on this series? I think we need Paolo's ack for the memory > > changes and either of your ack for hw/i386/. I'm happy to pull this > > through my tree

Re: [Qemu-devel] [RFC PATCH] exec: Support non-direct memory writes in cpu_memory_rw_debug

2016-06-29 Thread Paolo Bonzini
On 28/06/2016 23:44, Andrey Smirnov wrote: > Add code to support writing to memory mapped peripherals via > cpu_memory_rw_debug(). The code of that function already supports > reading from such memory regions, so this commit makes that > functionality "symmetric". It's not entirely symmetric howev

[Qemu-devel] [PATCH 08/18] linux-user: Clean up hostdep.h header guards

2016-06-29 Thread Markus Armbruster
These headers all use QEMU_HOSTDEP_H as header guard symbol. Reuse of the same guard symbol in multiple headers is okay as long as they cannot be included together. Since we can avoid guard symbol reuse easily, do so: use guard symbol $target_HOSTDEP_H for linux-user/host/$target/hostdep.h. Sign

[Qemu-devel] [PATCH 03/18] target-*: Clean up cpu.h header guards

2016-06-29 Thread Markus Armbruster
Most of them use guard symbols like CPU_$target_H, but we also have __MIPS_CPU_H__ and __TRICORE_CPU_H__. They all upset scripts/clean-header-guards.pl. The script dislikes CPU_$target_H because they don't match their file name (they should, to make guard collisions less likely). The others are

[Qemu-devel] [PATCH v2] xen: use native disk xenbus protocol if possible

2016-06-29 Thread Juergen Gross
The qdisk implementation is using the native xenbus protocol only in case of no protocol specified at all. As using the explicit 32- or 64-bit protocol is slower than the native one due to copying requests not by memcpy but element for element, this is not optimal. Correct this by using the native

Re: [Qemu-devel] [PULL 32/35] vhost-user: disable chardev handlers on close

2016-06-29 Thread Paolo Bonzini
On 29/06/2016 17:31, Marc-André Lureau wrote: > Hi > > - Original Message - >> This otherwise causes a use-after-free if network backend cleanup >> is performed before character device cleanup. >> >> Cc: Marc-André Lureau >> Signed-off-by: Paolo Bonzini > > > > See also my previous

Re: [Qemu-devel] [PATCH] xen: use native disk xenbus protocol if possible

2016-06-29 Thread Juergen Gross
On 29/06/16 17:20, Anthony PERARD wrote: > On Fri, Jun 17, 2016 at 01:14:56PM +0200, Juergen Gross wrote: >> The qdisk implementation is using the native xenbus protocol only in >> case of no protocol specified at all. As using the explicit 32- or >> 64-bit protocol is slower than the native one du

[Qemu-devel] [PULL 32/35] vhost-user: disable chardev handlers on close

2016-06-29 Thread Paolo Bonzini
This otherwise causes a use-after-free if network backend cleanup is performed before character device cleanup. Cc: Marc-André Lureau Signed-off-by: Paolo Bonzini --- net/vhost-user.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/vhost-user.c b/net/vhost-user.c index 636899a..92f

Re: [Qemu-devel] [PATCH v2 12/17] block: Convert bdrv_write() to BdrvChild

2016-06-29 Thread Max Reitz
On 29.06.2016 17:33, Kevin Wolf wrote: > Am 29.06.2016 um 17:22 hat Max Reitz geschrieben: >> On 29.06.2016 14:11, Kevin Wolf wrote: >>> Signed-off-by: Kevin Wolf >>> Acked-by: Stefan Hajnoczi >>> --- >>> >>> This patch contains non-trivial fixes, so I think it's worth sending out a >>> v2 >>> f

Re: [Qemu-devel] [PATCH v2] target-ppc: Eliminate redundant and incorrect function booke206_page_size_to_tlb

2016-06-29 Thread Thomas Huth
On 29.06.2016 17:14, alar...@ddci.com wrote: > David Gibson wrote on 06/28/2016 08:42:01 > PM: > >> On Tue, Jun 28, 2016 at 06:50:05AM -0700, Aaron Larson wrote: >>> >>> Eliminate redundant and incorrect booke206_page_size_to_tlb function >>> from ppce500_spin.c in preference to previously exist

Re: [Qemu-devel] [PATCH v2 12/17] block: Convert bdrv_write() to BdrvChild

2016-06-29 Thread Kevin Wolf
Am 29.06.2016 um 17:22 hat Max Reitz geschrieben: > On 29.06.2016 14:11, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > Acked-by: Stefan Hajnoczi > > --- > > > > This patch contains non-trivial fixes, so I think it's worth sending out a > > v2 > > for it even though I already applied the s

Re: [Qemu-devel] [PULL 32/35] vhost-user: disable chardev handlers on close

2016-06-29 Thread Marc-André Lureau
Hi - Original Message - > This otherwise causes a use-after-free if network backend cleanup > is performed before character device cleanup. > > Cc: Marc-André Lureau > Signed-off-by: Paolo Bonzini See also my previous (still unreviewed) series: https://lists.gnu.org/archive/html/qemu

Re: [Qemu-devel] [PATCH v2 12/17] block: Convert bdrv_write() to BdrvChild

2016-06-29 Thread Max Reitz
On 29.06.2016 14:11, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > Acked-by: Stefan Hajnoczi > --- > > This patch contains non-trivial fixes, so I think it's worth sending out a v2 > for it even though I already applied the series. I added a coroutine entry > wrapper qcow(2)_write that can be

[Qemu-devel] [PULL 31/35] vhost-user-test: fix g_cond_wait_until compat implementation

2016-06-29 Thread Paolo Bonzini
This fixes compilation with glib versions up to 2.30, such as the one in CentOS 6. Signed-off-by: Paolo Bonzini --- include/glib-compat.h | 26 ++ tests/vhost-user-test.c | 17 ++--- 2 files changed, 28 insertions(+), 15 deletions(-) diff --git a/include/gl

[Qemu-devel] [PULL v2 00/35] Misc patches for QEMU soft freeze

2016-06-29 Thread Paolo Bonzini
The following changes since commit 1f3aba377d2a531453f018c70de2580a142c74c9: pc: acpi: drop intermediate PCMachineState.node_cpu (2016-06-24 08:34:47 +0300) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 74b6ce43e3

Re: [Qemu-devel] [PATCH 3/2] MAINTAINERS: Remove Blue Swirl leftovers

2016-06-29 Thread Paolo Bonzini
On 29/06/2016 17:10, Peter Maydell wrote: >> Honestly I'm wondering if a huge code drop could be the right solution >> here. It's not how we usually do things, but rules exist to be broken... > > I can't say I'm really enthusiastic about doing that. Neither am I. On the other hand, look at the

Re: [Qemu-devel] [PATCH] xen: use native disk xenbus protocol if possible

2016-06-29 Thread Anthony PERARD
On Fri, Jun 17, 2016 at 01:14:56PM +0200, Juergen Gross wrote: > The qdisk implementation is using the native xenbus protocol only in > case of no protocol specified at all. As using the explicit 32- or > 64-bit protocol is slower than the native one due to copying requests > not by memcpy but elem

Re: [Qemu-devel] [PATCH 3/2] MAINTAINERS: Remove Blue Swirl leftovers

2016-06-29 Thread Peter Maydell
On 29 June 2016 at 14:32, Paolo Bonzini wrote: > Honestly I'm wondering if a huge code drop could be the right solution > here. It's not how we usually do things, but rules exist to be broken... I can't say I'm really enthusiastic about doing that. thanks -- PMM

Re: [Qemu-devel] [PATCH v2] target-ppc: Eliminate redundant and incorrect function booke206_page_size_to_tlb

2016-06-29 Thread alarson
David Gibson wrote on 06/28/2016 08:42:01 PM: > On Tue, Jun 28, 2016 at 06:50:05AM -0700, Aaron Larson wrote: > > > > Eliminate redundant and incorrect booke206_page_size_to_tlb function > > from ppce500_spin.c in preference to previously existing but newly > > exported definition from e500.c >

Re: [Qemu-devel] [PULL v2 00/24] linux-user changes for v2.7

2016-06-29 Thread Peter Maydell
On 28 June 2016 at 20:12, wrote: > From: Riku Voipio > > The following changes since commit c7288767523f6510cf557707d3eb5e78e519b90d: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160623' > into staging (2016-06-23 11:53:14 +0100) > > are available in the git repository

Re: [Qemu-devel] [PATCH] virtio: Fix setting up host notifiers for vhost

2016-06-29 Thread Cornelia Huck
On Wed, 29 Jun 2016 16:52:40 +0200 Paolo Bonzini wrote: > On 29/06/2016 16:15, Cornelia Huck wrote: > > > > I can see that one of the qemus sits on event_notifier_test_and_clear > > when vhost tries to shut down. (I am thoroughly confused by all of > > that qtest setup, so I have no idea which q

Re: [Qemu-devel] [PULL 0/8] Tracing patches

2016-06-29 Thread Peter Maydell
On 28 June 2016 at 22:27, Stefan Hajnoczi wrote: > The following changes since commit d7f30403576f04f1f3a5fb5a1d18cba8dfa7a6d2: > > cputlb: don't cpu_abort() if guest tries to execute outside RAM or RAM > (2016-06-28 18:50:53 +0100) > > are available in the git repository at: > > git://github

Re: [Qemu-devel] [RFC 8/8] tcg: Make tb_flush() thread safe

2016-06-29 Thread Sergey Fedorov
On 28/06/16 19:18, Alex Bennée wrote: > Sergey Fedorov writes: > >> From: Sergey Fedorov >> >> Use async_safe_run_on_cpu() to make tb_flush() thread safe. >> >> Signed-off-by: Sergey Fedorov >> Signed-off-by: Sergey Fedorov >> --- >> translate-all.c | 12 >> 1 file changed, 8 inse

Re: [Qemu-devel] [RFC 7/8] cpu-exec-common: Introduce async_safe_run_on_cpu()

2016-06-29 Thread Sergey Fedorov
On 27/06/16 12:36, Alex Bennée wrote: > Sergey Fedorov writes: > >> From: Sergey Fedorov >> (snip) >> diff --git a/cpus.c b/cpus.c >> index 98f60f6f98f5..bb6bd8615cfc 100644 >> --- a/cpus.c >> +++ b/cpus.c >> @@ -932,6 +932,18 @@ static void qemu_tcg_destroy_vcpu(CPUState *cpu) >> { >> } >> >>

Re: [Qemu-devel] [RFC 6/8] linux-user: Support CPU work queue

2016-06-29 Thread Sergey Fedorov
On 27/06/16 12:31, Alex Bennée wrote: > Sergey Fedorov writes: > >> diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h >> index c1f59fa59d2c..23b4b50e0a45 100644 >> --- a/include/exec/exec-all.h >> +++ b/include/exec/exec-all.h >> @@ -407,4 +407,8 @@ extern int singlestep; >> extern C

Re: [Qemu-devel] [RFC 4/8] linux-user: Rework exclusive operation mechanism

2016-06-29 Thread Sergey Fedorov
On 27/06/16 12:02, Alex Bennée wrote: > Sergey Fedorov writes: > >> From: Sergey Fedorov >> (snip) >> diff --git a/linux-user/main.c b/linux-user/main.c >> index b9a4e0ea45ac..485336f78b8f 100644 >> --- a/linux-user/main.c >> +++ b/linux-user/main.c >> @@ -111,7 +111,8 @@ static pthread_mutex_t c

Re: [Qemu-devel] [PATCH] virtio: Fix setting up host notifiers for vhost

2016-06-29 Thread Paolo Bonzini
On 29/06/2016 16:15, Cornelia Huck wrote: > > I can see that one of the qemus sits on event_notifier_test_and_clear > when vhost tries to shut down. (I am thoroughly confused by all of > that qtest setup, so I have no idea which qemu instance this is...) Stupid question ahead---if you mean QEMU

Re: [Qemu-devel] [RFC v3 19/19] cpu-exec: remove tb_lock from the hot-path

2016-06-29 Thread Sergey Fedorov
On 29/06/16 17:47, Alex Bennée wrote: > Sergey Fedorov writes: > >> On 03/06/16 23:40, Alex Bennée wrote: >>> Lock contention in the hot path of moving between existing patched >>> TranslationBlocks is the main drag on MTTCG performance. This patch >>> pushes the tb_lock() usage down to the two pl

Re: [Qemu-devel] [RFC v3 19/19] cpu-exec: remove tb_lock from the hot-path

2016-06-29 Thread Alex Bennée
Sergey Fedorov writes: > On 03/06/16 23:40, Alex Bennée wrote: >> Lock contention in the hot path of moving between existing patched >> TranslationBlocks is the main drag on MTTCG performance. This patch >> pushes the tb_lock() usage down to the two places that really need it: >> >> - code gen

  1   2   >