Re: [Qemu-devel] [PATCH 0/1] vhost-user: Add a protocol extension for client responses to vhost commands.

2016-06-25 Thread Prerna Saxena
On 26/06/16 8:15 am, "Michael S. Tsirkin" wrote: >On Sat, Jun 25, 2016 at 03:13:54AM +, Prerna Saxena wrote: >> >> >> >> >> >> On 25/06/16 4:43 am, "Michael S. Tsirkin" wrote: >> >> >On Fri, Jun 24, 2016 at 05:39:31PM +, Prerna Saxena wrote: >> >> >> >> >> >> On 24/06/16 9:1

Re: [Qemu-devel] [PATCH 0/1] vhost-user: Add a protocol extension for client responses to vhost commands.

2016-06-25 Thread Michael S. Tsirkin
On Sun, Jun 26, 2016 at 02:48:09AM +, Prerna Saxena wrote: > > > > > > On 26/06/16 8:15 am, "Michael S. Tsirkin" wrote: > > >On Sat, Jun 25, 2016 at 03:13:54AM +, Prerna Saxena wrote: > >> > >> > >> > >> > >> > >> On 25/06/16 4:43 am, "Michael S. Tsirkin" wrote: > >> > >> >On

Re: [Qemu-devel] [PATCH 0/1] vhost-user: Add a protocol extension for client responses to vhost commands.

2016-06-25 Thread Michael S. Tsirkin
On Sat, Jun 25, 2016 at 03:13:54AM +, Prerna Saxena wrote: > > > > > > On 25/06/16 4:43 am, "Michael S. Tsirkin" wrote: > > >On Fri, Jun 24, 2016 at 05:39:31PM +, Prerna Saxena wrote: > >> > >> > >> On 24/06/16 9:15 pm, "Felipe Franciosi" wrote: > >> > >> >We talked to MST on IRC

Re: [Qemu-devel] [PATCH v10 16/26] intel_iommu: add support for split irqchip

2016-06-25 Thread Peter Xu
On Sat, Jun 25, 2016 at 05:18:40PM +0200, Jan Kiszka wrote: > On 2016-06-25 15:18, Peter Xu wrote: > > On Sat, Jun 25, 2016 at 10:08:10AM +0200, Jan Kiszka wrote: [...] > > I have a thought on how to implement the "sink" you have mentioned: > > > > First of all, in KVM, we provide a new KVM_IRQ_

[Qemu-devel] [PATCH v4 03/14] nbd: Limit nbdflags to 16 bits

2016-06-25 Thread Eric Blake
Rather than asserting that nbdflags is within range, just give it the correct type to begin with :) nbdflags corresponds to the per-export portion of NBD Protocol "transmission flags", which is 16 bits in response to NBD_OPT_EXPORT_NAME and NBD_OPT_GO. Furthermore, upstream NBD has never passed t

[Qemu-devel] [PATCH v4 13/14] nbd: Implement NBD_CMD_WRITE_ZEROES on server

2016-06-25 Thread Eric Blake
Upstream NBD protocol recently added the ability to efficiently write zeroes without having to send the zeroes over the wire, along with a flag to control whether the client wants a hole. Signed-off-by: Eric Blake --- v4: rebase, fix value for constant v3: abandon NBD_CMD_CLOSE extension, rebase

[Qemu-devel] [PATCH v4 04/14] nbd: Treat flags vs. command type as separate fields

2016-06-25 Thread Eric Blake
Current upstream NBD documents that requests have a 16-bit flags, followed by a 16-bit type integer; although older versions mentioned only a 32-bit field with masking to find flags. Since the protocol is in network order (big-endian over the wire), the ABI is unchanged; but dealing with the flags

[Qemu-devel] [PATCH v4 12/14] nbd: Improve server handling of shutdown requests

2016-06-25 Thread Eric Blake
NBD commit 6d34500b clarified how clients and servers are supposed to behave before closing a connection. It added NBD_REP_ERR_SHUTDOWN (for the server to announce it is about to go away during option haggling, so the client should quit sending NBD_OPT_* other than NBD_OPT_ABORT) and ESHUTDOWN (for

[Qemu-devel] [PATCH v4 06/14] nbd: Send message along with server NBD_REP_ERR errors

2016-06-25 Thread Eric Blake
The NBD Protocol allows us to send human-readable messages along with any NBD_REP_ERR error during option negotiation; make use of this fact for clients that know what to do with our message. Signed-off-by: Eric Blake --- v4: new patch --- nbd/server.c | 74 +

[Qemu-devel] [PATCH v4 02/14] nbd: Add qemu-nbd -D for human-readable description

2016-06-25 Thread Eric Blake
The NBD protocol allows servers to advertise a human-readable description alongside an export name during NBD_OPT_LIST. Add an option to pass through the user's string to the NBD client. Doing this also makes it easier to test commit 200650d4, which is the client counterpart of receiving the desc

[Qemu-devel] [PATCH v4 10/14] nbd: Less allocation during NBD_OPT_LIST

2016-06-25 Thread Eric Blake
Since we know that the maximum name we are willing to accept is small enough to stack-allocate, rework the iteration over NBD_OPT_LIST responses to reuse a stack buffer rather than allocating every time. Furthermore, we don't even have to allocate if we know the server's length doesn't match what

[Qemu-devel] [PATCH v4 11/14] nbd: Support shorter handshake

2016-06-25 Thread Eric Blake
The NBD Protocol allows the server and client to mutually agree on a shorter handshake (omit the 124 bytes of reserved 0), via the server advertising NBD_FLAG_NO_ZEROES and the client acknowledging with NBD_FLAG_C_NO_ZEROES (only possible in newstyle, whether or not it is fixed newstyle). It doesn

[Qemu-devel] [PATCH v4 08/14] nbd: Let server know when client gives up negotiation

2016-06-25 Thread Eric Blake
The NBD spec says that a client should send NBD_OPT_ABORT rather than just dropping the connection, if the client doesn't like something the server sent during option negotiation. This is a best-effort attempt only, and can only be done in places where we know the server is still in sync with what

[Qemu-devel] [PATCH v4 00/14] nbd: efficient write zeroes

2016-06-25 Thread Eric Blake
The upstream NBD protocol is proposing an extension for efficient write zeroes; having a qemu implementation will be one of the reasons to promote the proposal from experimental to standard: https://github.com/yoe/nbd/blob/extension-write-zeroes/doc/proto.md Some of these patches were previously p

[Qemu-devel] [PATCH v4 07/14] nbd: Share common option-sending code in client

2016-06-25 Thread Eric Blake
Rather than open-coding each option request, it's easier to have common helper functions do the work. That in turn requires having convenient packed types for handling option requests and replies. Signed-off-by: Eric Blake --- v4: rebase v3: rebase, tweak a debug message --- include/block/nbd.

[Qemu-devel] [PATCH v4 05/14] nbd: Share common reply-sending code in server

2016-06-25 Thread Eric Blake
Rather than open-coding NBD_REP_SERVER, reuse the code we already have by adding a length parameter. Additionally, the refactoring will make adding NBD_OPT_GO in a later patch easier. Signed-off-by: Eric Blake --- v4: no change v3: rebase to changes earlier in series --- nbd/server.c | 48

[Qemu-devel] [Bug 1596160] Re: SIGSEGV in memory_region_access_valid on Sabre Lite board

2016-06-25 Thread berte
This issue as same as when I build yocto sabrelite build. You can find detailed information as below: berte [ ~/playground/fsl-arm-yocto-bsp/hmi_test/tmp/deploy/images/imx6dlsabresd ]$ gdb --args ~/playground/qemu/debug/arm-softmmu/qemu-system-arm -smp 4 -M sabrelite -m 1024M -kernel u-boot.imx

[Qemu-devel] [PATCH v4 14/14] nbd: Implement NBD_CMD_WRITE_ZEROES on client

2016-06-25 Thread Eric Blake
Upstream NBD protocol recently added the ability to efficiently write zeroes without having to send the zeroes over the wire, along with a flag to control whether the client wants a hole. The generic block code takes care of falling back to the obvious write of lots of zeroes if we return -ENOTSUP

[Qemu-devel] [PATCH v4 09/14] nbd: Let client skip portions of server reply

2016-06-25 Thread Eric Blake
The server has a nice helper function nbd_negotiate_drop_sync() which lets it easily ignore fluff from the client (such as the payload to an unknown option request). We can't quite make it common, since it depends on nbd_negotiate_read() which handles coroutine magic, but we can copy the idea into

[Qemu-devel] [PATCH v4 01/14] nbd: Fix bad flag detection on server

2016-06-25 Thread Eric Blake
Commit ab7c548e added a check for invalid flags, but used an early return on error instead of properly going through the cleanup label. Signed-off-by: Eric Blake --- v4: new patch --- nbd/server.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/nbd/server.c b/nbd/server.c

[Qemu-devel] [Bug 1596160] Re: SIGSEGV in memory_region_access_valid on Sabre Lite board

2016-06-25 Thread berte
** Attachment added: "causing segfault uboot file" https://bugs.launchpad.net/qemu/+bug/1596160/+attachment/4690322/+files/u-boot.imx-sd -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1596160 Titl

[Qemu-devel] [Bug 1596204] [NEW] UART problem in raspi2

2016-06-25 Thread Hadi
Public bug reported: I was trying to run the raspberry pi uart example at https://github.com/dwelch67/raspberrypi/tree/master/uart01 using qemu 2.6.0, but it didn't work. The steps I took were: * Edit uart01/memmap and change origin to 0x1 (which is the address qemu starts executing), * make

Re: [Qemu-devel] [PATCH 10/17] block: Use BlockBackend for I/O in bdrv_commit()

2016-06-25 Thread Max Reitz
On 21.06.2016 11:21, Kevin Wolf wrote: > Just like block jobs, the HMP commit command should use its own > BlockBackend for doing I/O on BlockDriverStates. > > Signed-off-by: Kevin Wolf > --- > block/commit.c | 30 -- > 1 file changed, 20 insertions(+), 10 deletions(-

Re: [Qemu-devel] [PATCH 08/17] block: Convert bdrv_co_do_readv/writev to BdrvChild

2016-06-25 Thread Max Reitz
On 21.06.2016 11:21, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/io.c | 29 +++-- > 1 file changed, 15 insertions(+), 14 deletions(-) Reviewed-by: Max Reitz signature.asc Description: OpenPGP digital signature

Re: [Qemu-devel] [PATCH 07/17] block: Convert bdrv_aio_writev() to BdrvChild

2016-06-25 Thread Max Reitz
On 21.06.2016 11:21, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/blkdebug.c | 2 +- > block/blkverify.c | 4 ++-- > block/io.c| 6 +++--- > block/qed-table.c | 2 +- > block/qed.c | 6 +++--- > block/quorum.c| 4 ++-- > include/block/bloc

Re: [Qemu-devel] [PATCH v10 16/26] intel_iommu: add support for split irqchip

2016-06-25 Thread Jan Kiszka
On 2016-06-25 15:18, Peter Xu wrote: > On Sat, Jun 25, 2016 at 10:08:10AM +0200, Jan Kiszka wrote: > > [...] > >> For successful remappings, this is fine - it just caches the result in >> an interrupt route. But what will happen with invalid interrupts? >> >> My current understanding is that, bec

Re: [Qemu-devel] [PATCH 06/17] block: Convert bdrv_aio_readv() to BdrvChild

2016-06-25 Thread Max Reitz
On 21.06.2016 11:21, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/blkdebug.c | 2 +- > block/blkverify.c | 4 ++-- > block/io.c| 6 +++--- > block/qed-table.c | 2 +- > block/qed.c | 6 +++--- > block/quorum.c| 4 ++-- > include/block/bloc

Re: [Qemu-devel] [PATCH 05/17] block: Convert bdrv_co_writev() to BdrvChild

2016-06-25 Thread Max Reitz
On 21.06.2016 11:21, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/crypto.c| 2 +- > block/io.c| 6 +++--- > block/parallels.c | 2 +- > block/qcow.c | 2 +- > block/vhdx.c | 2 +- > include/block/block.h | 4 ++-- > 6 files changed, 9 inser

Re: [Qemu-devel] [PATCH 04/17] block: Convert bdrv_co_readv() to BdrvChild

2016-06-25 Thread Max Reitz
On 21.06.2016 11:21, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/crypto.c| 2 +- > block/io.c| 8 > block/parallels.c | 2 +- > block/qcow.c | 5 ++--- > block/raw_bsd.c | 2 +- > block/vhdx.c | 2 +- > include/block/block.h

[Qemu-devel] [Bug 1596160] Re: SIGSEGV in memory_region_access_valid on Sabre Lite board

2016-06-25 Thread 小太
Attached, though I've since recompiled it (with no further changes) so addresses might no longer match the ones in my original report. It still crashes, though ** Attachment added: "Crashing U-Boot" https://bugs.launchpad.net/qemu/+bug/1596160/+attachment/4690135/+files/u-boot -- You receive

Re: [Qemu-devel] [PATCH v2] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-06-25 Thread Dmitry Osipenko
On 25.06.2016 16:20, Mark Cave-Ayland wrote: > On 25/06/16 13:35, Dmitry Osipenko wrote: > >> Software should see timer counter wrap around only after IRQ being triggered. >> Change returned counter value to "1" for the expired timer and avoid >> returning >> wrapped around counter value in perio

[Qemu-devel] [Bug 1596160] Re: SIGSEGV in memory_region_access_valid on Sabre Lite board

2016-06-25 Thread Peter Maydell
We shouldn't really be segfaulting in QEMU no matter what the guest does. Can you put the guest binary somewhere where we can get it, please? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1596160 Tit

[Qemu-devel] [Bug 1596160] Re: SIGSEGV in memory_region_access_valid on Sabre Lite board

2016-06-25 Thread 小太
Registers at location of crash: (gdb) info reg r0 0x0 0 r1 0x1788 394264584 r2 0x178655e8 394679784 r3 0x0 0 r4 0xe880 -394264576 r5 0x17800338 394265400 r6 0x0 0 r7

[Qemu-devel] [Bug 1596160] [NEW] SIGSEGV in memory_region_access_valid on Sabre Lite board

2016-06-25 Thread 小太
Public bug reported: I'm trying to emulate a Sabre Lite board and booting U-Boot, but I'm encountering a SIGSEGV almost immediately after starting QEMU. QEMU version: 6f1d2d1c5ad20d464705b17318cb7ca495f8078a U-Boot version: mx6qsabrelite_defconfig 2016.05 (with http://git.denx.de/?p=u-boot.git;a

[Qemu-devel] [Bug 1596160] Re: SIGSEGV in memory_region_access_valid on Sabre Lite board

2016-06-25 Thread 小太
I've narrowed the crash to a stmia instruction in U-Boot's relocate_code: Breakpoint 3, relocate_code () at arch/arm/lib/relocate.S:81 81 subsr4, r0, r1 /* r4 <- relocation offset */ (gdb) disas Dump of assembler code for function relocate_code: 0x17802620 <+0>:

Re: [Qemu-devel] [PATCH v2] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-06-25 Thread Mark Cave-Ayland
On 25/06/16 13:35, Dmitry Osipenko wrote: Software should see timer counter wrap around only after IRQ being triggered. Change returned counter value to "1" for the expired timer and avoid returning wrapped around counter value in periodic mode for the timer that has bottom-half handler setup, a

Re: [Qemu-devel] [PATCH v10 16/26] intel_iommu: add support for split irqchip

2016-06-25 Thread Peter Xu
On Sat, Jun 25, 2016 at 10:08:10AM +0200, Jan Kiszka wrote: [...] > For successful remappings, this is fine - it just caches the result in > an interrupt route. But what will happen with invalid interrupts? > > My current understanding is that, because the translation happens on > activation of

[Qemu-devel] [Bug 1580459] Re: Windows (10?) guest freezes entire host on shutdown if using PCI passthrough

2016-06-25 Thread Chris McCarron
Thats good to know, I want to reenable my Nvidia sound card as well. Note: When you update the video card driver, it will disable the MSI interrupt so you will have to reenable it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. htt

Re: [Qemu-devel] [PATCH v2] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-06-25 Thread Dmitry Osipenko
V2: Patch applies cleanly to the QEMU master branch. -- Dmitry

[Qemu-devel] [PATCH v2] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-06-25 Thread Dmitry Osipenko
Software should see timer counter wrap around only after IRQ being triggered. Change returned counter value to "1" for the expired timer and avoid returning wrapped around counter value in periodic mode for the timer that has bottom-half handler setup, assuming it drives timer IRQ. This fixes regr

Re: [Qemu-devel] [PATCH] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-06-25 Thread Dmitry Osipenko
On 25.06.2016 13:04, Mark Cave-Ayland wrote: > On 24/06/16 21:29, Dmitry Osipenko wrote: > >> Software should see timer counter wrap around only after IRQ being triggered. >> Change returned counter value to "1" for the expired timer and avoid >> returning >> wrapped around counter value in perio

Re: [Qemu-devel] [PATCH] hw/ptimer: Don't wrap around counter for expired timer that uses tick handler

2016-06-25 Thread Mark Cave-Ayland
On 24/06/16 21:29, Dmitry Osipenko wrote: Software should see timer counter wrap around only after IRQ being triggered. Change returned counter value to "1" for the expired timer and avoid returning wrapped around counter value in periodic mode for the timer that has bottom-half handler setup, a

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2016-06-25 Thread Greg Kurz
** Changed in: qemu Status: Confirmed => In Progress -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1336794 Title: 9pfs does not honor open file handles on unlinked files Status in QEMU: I

[Qemu-devel] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2016-06-25 Thread Greg Kurz
** Changed in: qemu Status: New => Confirmed ** Changed in: qemu Assignee: (unassigned) => Greg Kurz (gkurz) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1336794 Title: 9pfs does not

[Qemu-devel] [Bug 1527322] Re: segfault in thread-pool.c:246:5:

2016-06-25 Thread Greg Kurz
This issue was fixed with the following upstream commit: http://git.qemu.org/?p=qemu.git;a=commit;h=4b3a4f2d458ca5a7c6c16ac36a8d9ac22cc253d6 Shipped in QEMU 2.5.1 and 2.6. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of

Re: [Qemu-devel] [PATCH v10 16/26] intel_iommu: add support for split irqchip

2016-06-25 Thread Jan Kiszka
On 2016-06-21 09:47, Peter Xu wrote: > In split irqchip mode, IOAPIC is working in user space, only update > kernel irq routes when entry changed. When IR is enabled, we directly > update the kernel with translated messages. It works just like a kernel > cache for the remapping entries. > > Since

Re: [Qemu-devel] [PATCH] target-ppc: ppce500_spin.c uses SPR_PIR, should use SPR_BOOKE_PIR

2016-06-25 Thread Thomas Huth
On 24.06.2016 04:27, David Gibson wrote: > On Thu, Jun 23, 2016 at 03:35:17PM -0700, Aaron Larson wrote: >> >> ppce500_spin.c uses SPR_PIR to initialize the spin table, however on >> Book E processors the correct SPR is SPR_BOOKE_PIR. >> >> Signed-off-by: Aaron Larson > > Applied to ppc-for-2.7,