Re: [Qemu-devel] [PATCH v3 19/22] block: Split bdrv_merge_limits() from bdrv_refresh_limits()

2016-06-23 Thread Fam Zheng
On Thu, 06/23 16:37, Eric Blake wrote: > During bdrv_merge_limits(), we were computing initial limits > based on another BDS in two places. At first glance, the two > computations are not identical (one is doing straight copying, > the other is doing merging towards or away from zero) - but > when

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

2016-06-23 Thread Claudio Fontana
Hi Paolo, On 23.06.2016 20:44, Paolo Bonzini wrote: > > > On 23/06/2016 10:32, Chao Peng wrote: >> The original usage model is to replace kvm-tool with QEMU for Clear >> Containers (https://clearlinux.org/features/clear-containers). It's not >> going to present the guest a real PC platform, but

Re: [Qemu-devel] [PATCH v3 18/22] block: Drop raw_refresh_limits()

2016-06-23 Thread Fam Zheng
On Thu, 06/23 16:37, Eric Blake wrote: > The raw block driver was blindly copying all limits from bs->file, > even though: 1. the main bdrv_refresh_limits() already does this > for many of the limits, and 2. blindly copying from the children > can weaken any stricter limits that were already inheri

Re: [Qemu-devel] [PATCH v3 17/22] block: Switch discard length bounds to byte-based

2016-06-23 Thread Fam Zheng
On Thu, 06/23 16:37, Eric Blake wrote: > Sector-based limits are awkward to think about; in our on-going > quest to move to byte-based interfaces, convert max_discard and > discard_alignment. Rename them, using 'pdiscard' as an aid to > track which remaining discard interfaces need conversion, and

Re: [Qemu-devel] [PULL 5/8] target-sparc: Use global registers for the register window

2016-06-23 Thread Paolo Bonzini
On 24/06/2016 05:57, Richard Henderson wrote: > > Whatever happens, it happens after 10GB of logs, which is simply too > much to sift through. I've tried to narrow it down, but the lack of a > hardware tlb refill means that we get hundreds of thousands of Data > Access Faults that are simply TL

Re: [Qemu-devel] [RFC 0/9] Introduce light weight PC platform pc-lite

2016-06-23 Thread Claudio Fontana
On 24.06.2016 14:39, Claudio Fontana wrote: > Hi Paolo, > > On 23.06.2016 20:44, Paolo Bonzini wrote: >> >> >> On 23/06/2016 10:32, Chao Peng wrote: >>> The original usage model is to replace kvm-tool with QEMU for Clear >>> Containers (https://clearlinux.org/features/clear-containers). It's not >

Re: [Qemu-devel] [PATCH v2 1/2] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread Igor Mammedov
On Thu, 23 Jun 2016 23:23:33 +0200 Peter Krempa wrote: > For management apps it's very useful to know whether the selected > machine type supports cpu hotplug via the new -device approach. Using > the presence of 'query-hotpluggable-cpus' alone is not enough as a > witness. > > Add a property to

Re: [Qemu-devel] [PATCH v3 15/22] block: Switch transfer length bounds to byte-based

2016-06-23 Thread Fam Zheng
On Thu, 06/23 16:37, Eric Blake wrote: > Sector-based limits are awkward to think about; in our on-going > quest to move to byte-based interfaces, convert max_transfer_length > and opt_transfer_length. Rename them (dropping the _length suffix) > so that the compiler will help us catch the change i

Re: [Qemu-devel] [PATCH 2/4] virtio: Always use aio path to set host handler

2016-06-23 Thread Paolo Bonzini
On 24/06/2016 07:12, Fam Zheng wrote: > Apart from the interface difference, the aio version works the same as > the non-aio one. The event notifier versus aio fd handler makes no > diffeerence, except the former led to an ugly patch in commit > ab27c3b5e7, which won't be necessary any more. > >

Re: [Qemu-devel] [PATCH v1 02/11] ppc/xics: Move SPAPR specific code to a separate file

2016-06-23 Thread David Gibson
On Fri, Jun 24, 2016 at 11:27:58AM +0530, Nikunj A Dadhania wrote: > David Gibson writes: > > > [ Unknown signature status ] > > On Thu, Jun 23, 2016 at 11:17:21PM +0530, Nikunj A Dadhania wrote: > >> From: Benjamin Herrenschmidt > >> > >> Leave the core ICP/ICS logic in xics.c and move the top

Re: [Qemu-devel] [PATCH v1 02/11] ppc/xics: Move SPAPR specific code to a separate file

2016-06-23 Thread Nikunj A Dadhania
David Gibson writes: > [ Unknown signature status ] > On Thu, Jun 23, 2016 at 11:17:21PM +0530, Nikunj A Dadhania wrote: >> From: Benjamin Herrenschmidt >> >> Leave the core ICP/ICS logic in xics.c and move the top level >> class wrapper, hypercall and RTAS handlers to xics_spapr.c >> >> Signe

[Qemu-devel] [PATCH v2 11/10] pc: acpi: update expected DSDT blobs with new CPU hotplug AML

2016-06-23 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/acpi-test-data/pc/DSDT | Bin 5503 -> 6008 bytes tests/acpi-test-data/pc/DSDT.bridge | Bin 7362 -> 7867 bytes tests/acpi-test-data/q35/DSDT| Bin 8265 -> 8770 bytes tests/acpi-test-data/q35/DSDT.bridge | Bin 8282 -> 8787 bytes 4 files chan

Re: [Qemu-devel] [RFC PATCH 3/3] filter-rewriter: rewrite tcp packet to keep secondary connection

2016-06-23 Thread Jason Wang
On 2016年06月23日 18:48, Zhang Chen wrote: On 06/22/2016 02:34 PM, Jason Wang wrote: On 2016年06月22日 11:12, Zhang Chen wrote: On 06/20/2016 08:14 PM, Dr. David Alan Gilbert wrote: * Jason Wang (jasow...@redhat.com) wrote: On 2016年06月14日 19:15, Zhang Chen wrote: We will rewrite tcp packe

[Qemu-devel] [PULL 33/34] virtio-mmio: convert to ioeventfd callbacks

2016-06-23 Thread Michael S. Tsirkin
From: Cornelia Huck Convert to the new interface. Signed-off-by: Cornelia Huck Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-mmio.c | 128 1 file ch

[Qemu-devel] [PULL 30/34] virtio-bus: have callers tolerate new host notifier api

2016-06-23 Thread Michael S. Tsirkin
From: Cornelia Huck Have vhost and dataplane use the new api for transports that have been converted. Signed-off-by: Cornelia Huck Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/block/dataplane/virtio-blk.c | 14

[Qemu-devel] [PATCH v2 12/10] pc: acpi: add expected DSDT/MADT blobs for CPU hotplug testscase

2016-06-23 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/acpi-test-data/pc/APIC.cphp | Bin 0 -> 160 bytes tests/acpi-test-data/pc/DSDT.cphp | Bin 0 -> 6435 bytes tests/acpi-test-data/q35/APIC.cphp | Bin 0 -> 160 bytes tests/acpi-test-data/q35/DSDT.cphp | Bin 0 -> 9197 bytes 4 files changed, 0 insertions(+),

Re: [Qemu-devel] [PATCH v2 09/10] tests: acpi: add CPU hotplug testcase

2016-06-23 Thread Igor Mammedov
On Fri, 24 Jun 2016 08:53:25 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 23, 2016 at 03:47:36PM +0200, Igor Mammedov wrote: > > On Thu, 23 Jun 2016 16:08:38 +0300 > > Marcel Apfelbaum wrote: > > > > > On 06/16/2016 07:55 PM, Igor Mammedov wrote: > > > > Test with: > > > > > > > > -smp

[Qemu-devel] [PULL 27/34] acpi-test-data: update expected

2016-06-23 Thread Michael S. Tsirkin
switched to new cpu hotplug interface, aml changed. Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/DSDT | Bin 5503 -> 6008 bytes tests/acpi-test-data/pc/DSDT.bridge | Bin 7362 -> 7867 bytes tests/acpi-test-data/pc/DSDT.ipmikcs | Bin 5575 -> 6080 bytes tests/acpi-test-d

[Qemu-devel] [PULL 31/34] virtio-ccw: convert to ioeventfd callbacks

2016-06-23 Thread Michael S. Tsirkin
From: Cornelia Huck Use the new interface. Signed-off-by: Cornelia Huck Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/s390x/virtio-ccw.c | 133 +- 1 file changed,

Re: [Qemu-devel] [PATCH v3 16/22] block: Wording tweaks to write zeroes limits

2016-06-23 Thread Fam Zheng
On Thu, 06/23 16:37, Eric Blake wrote: > Improve the documentation of the write zeroes limits, to mention > additional constraints that drivers should observe. Worth squashing > into commit cf081fca, if that hadn't been pushed already :) > > Signed-off-by: Eric Blake > > --- > v3: new patch, sp

[Qemu-devel] [PULL 34/34] virtio-bus: remove old set_host_notifier callback

2016-06-23 Thread Michael S. Tsirkin
From: Cornelia Huck All users have been converted to the new ioevent callbacks. Signed-off-by: Cornelia Huck Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-bus.h | 1 - hw/block/dataplane/

Re: [Qemu-devel] Default for phys-addr-bits? (was Re: [PATCH 4/5] x86: Allow physical address bits to be set)

2016-06-23 Thread Gerd Hoffmann
On Do, 2016-06-23 at 19:38 +0300, Michael S. Tsirkin wrote: > On Thu, Jun 23, 2016 at 10:40:03AM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > > Well the crash of guest phys bits > host phys bits, should be easy to > > > > reproduce by booting a 65GB guest on a 64GB RAM + 2GB swap host with > >

[Qemu-devel] [PULL 32/34] virtio-pci: convert to ioeventfd callbacks

2016-06-23 Thread Michael S. Tsirkin
From: Cornelia Huck Convert to new interface. Signed-off-by: Cornelia Huck Reviewed-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/virtio/virtio-pci.c | 124 - 1 file change

[Qemu-devel] [PULL 28/34] pc: acpi: drop intermediate PCMachineState.node_cpu

2016-06-23 Thread Michael S. Tsirkin
From: Igor Mammedov PCMachineState.node_cpu was used for mapping APIC ID to numa node id as CPU entries in SRAT used to be built on sparse APIC ID bitmap (up to apic_id_limit). However since commit 5803fce pc: acpi: SRAT: create only valid processor lapic entries CPU entries in SRAT aren't buil

[Qemu-devel] [PULL 29/34] virtio-bus: common ioeventfd infrastructure

2016-06-23 Thread Michael S. Tsirkin
From: Cornelia Huck Introduce a set of ioeventfd callbacks on the virtio-bus level that can be implemented by the individual transports. At the virtio-bus level, do common handling for host notifiers (which is actually most of it). Two things of note: - When setting the host notifier, we only sw

[Qemu-devel] [PULL 23/34] acpi: cpuhp: implement hot-add parts of CPU hotplug interface

2016-06-23 Thread Michael S. Tsirkin
From: Igor Mammedov it adds hw registers needed for handling CPU hot-add and corresponding AML methods to handle hot-add events on guest side. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/cpu.h | 5 +- hw/acpi/cpu.c

[Qemu-devel] [PULL 26/34] pc: use new CPU hotplug interface since 2.7 machine type

2016-06-23 Thread Michael S. Tsirkin
From: Igor Mammedov For compatibility reasons PC/Q35 will start with legacy CPU hotplug interface by default but with new CPU hotplug AML code since 2.7 machine type. That way legacy firmware that doesn't use QEMU generated ACPI tables will be able to continue using legacy CPU hotplug interface.

[Qemu-devel] [PULL 24/34] acpi: cpuhp: implement hot-remove parts of CPU hotplug interface

2016-06-23 Thread Michael S. Tsirkin
From: Igor Mammedov it adds hw registers needed for handling CPU hot-remove and corresponding AML methods to request and eject a CPU with necessary hotplug callbacks in pc,piix4,ich9 code. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- incl

[Qemu-devel] [PULL 25/34] acpi: cpuhp: add cpu._OST handling

2016-06-23 Thread Michael S. Tsirkin
From: Igor Mammedov it adds HW and AML parts for CPU_Device._OST method handling to allow OSPM reports status of hot-(un)plug operation. And extends QMP command query-acpi-ospm-status to report CPU's OST info along with already reported PC-DIMM devices. Signed-off-by: Igor Mammedov Reviewed-by:

[Qemu-devel] [PULL 16/34] nvdimm acpi: support Set Namespace Label Data function

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong Function 6 is used to set Namespace Label Data Reviewed-by: Stefan Hajnoczi Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 44 ++

[Qemu-devel] [PULL 20/34] pc: piix4/ich9: add 'cpu-hotplug-legacy' property

2016-06-23 Thread Michael S. Tsirkin
From: Igor Mammedov It will be used to select which hotplug call-back is called and for switching from legacy mode into new one. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/ich9.h | 1 + hw/acpi/ich9.c | 23 +

[Qemu-devel] [PULL 18/34] i386: pci-assign: Fix MSI-X table size

2016-06-23 Thread Michael S. Tsirkin
From: Ido Yariv The current code creates a whole page mmio region for the MSI-X table size. However, the page containing the MSI-X table may contain other registers not related to MSI-X. Creating an mmio region for the whole page masks such registers and may break drivers in the guest OS. Since

[Qemu-devel] [PULL 21/34] acpi: cpuhp: add CPU devices AML with _STA method

2016-06-23 Thread Michael S. Tsirkin
From: Igor Mammedov it adds CPU objects to DSDT with _STA method and QEMU side of CPU hotplug interface initialization with registers sufficient to handle _STA requests, including necessary hotplug callbacks in piix4,ich9 code. Hot-(un)plug hw/acpi parts will be added by corresponding follow up

[Qemu-devel] [PULL 13/34] nvdimm acpi: check revision

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong Currently only revision 1 is supported Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/acpi/nvdimm.c b/hw/acpi

[Qemu-devel] [PULL 17/34] docs: add NVDIMM ACPI documentation

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong It describes the basic concepts of NVDIMM ACPI and the interfaces between QEMU and the ACPI BIOS Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- docs/specs/acpi_nvdimm.txt | 132 +++

[Qemu-devel] [PULL 22/34] pc: acpi: introduce AcpiDeviceIfClass.madt_cpu hook

2016-06-23 Thread Michael S. Tsirkin
From: Igor Mammedov Add madt_cpu callback to AcpiDeviceIfClass and use it for generating LAPIC MADT entries for CPUs. Later it will be used for generating x2APIC entries in case of more than 255 CPUs and also would be reused by ARM target when ACPI CPU hotplug is introduced there. Signed-off-by

[Qemu-devel] [PULL 15/34] nvdimm acpi: support Get Namespace Label Data function

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong Function 5 is used to get Namespace Label Data Reviewed-by: Stefan Hajnoczi Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 83 ++

[Qemu-devel] [PULL 04/34] bios: Add tests for the IPMI ACPI and SMBIOS entries

2016-06-23 Thread Michael S. Tsirkin
From: Corey Minyard Signed-off-by: Corey Minyard Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/bios-tables-test.c | 60 --- tests/acpi-test-data/pc/DSDT.ipmikcs | Bin 0 -> 5575 bytes tests/acpi-test-data/q35/DSDT.ipmi

[Qemu-devel] [PULL 07/34] acpi: add aml_object_type

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong Implement ObjectType which is used by NVDIMM _DSM method in later patch Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 1 + hw/acpi/aml-build.c | 8 ++

[Qemu-devel] [PULL 14/34] nvdimm acpi: support Get Namespace Label Size function

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong Function 4 is used to get Namespace label size Reviewed-by: Stefan Hajnoczi Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 130 +

[Qemu-devel] [PULL 19/34] docs: update ACPI CPU hotplug spec with new protocol

2016-06-23 Thread Michael S. Tsirkin
From: Igor Mammedov Add description of new CPU hotplug interface. To switch from from legacy mode into new mode use fact that write accesses into CPU present bitmap were never used before and were ignored by QEMU. So use it to as a way to switch from legacy mode. That way pc/q35 machine starts i

[Qemu-devel] [PULL 05/34] pc-dimm: introduce get_vmstate_memory_region callback

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong This callback returns the MemoryRegion that is the memory of dimm should be kept during live migration nvdimm device is different with pc-dimm as its memory includes not only the MemoryRegion directly mapping to guest's address space but also the memory used as label data S

[Qemu-devel] [PULL 08/34] acpi: add aml_call5

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong It will be used by NVDIMM ACPI Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/aml-build.h | 2 ++ hw/acpi/aml-build.c | 14 ++ 2 files changed, 16 inse

[Qemu-devel] [PULL 11/34] nvdimm acpi: check UUID

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong Check arg0 which indicates UUID to see if it is valid Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 32 ++-- 1 file changed, 26 insertions(+

[Qemu-devel] [PULL 09/34] nvdimm acpi: set HDLE properly

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong Now we pass HDLE to Qemu properly, use 0 for root device and use the handle for nvdimm devices Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 22 --

Re: [Qemu-devel] [PATCH v1 01/11] ppc/xics: Rename existing xics to xics_spapr

2016-06-23 Thread Nikunj A Dadhania
David Gibson writes: > diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h >> index 9091054..452a978 100644 >> --- a/include/hw/ppc/xics.h >> +++ b/include/hw/ppc/xics.h >> @@ -32,20 +32,24 @@ >> #define TYPE_XICS_COMMON "xics-common" >> #define XICS_COMMON(obj) OBJECT_CHECK(XICSState, (

[Qemu-devel] [PULL 12/34] nvdimm acpi: abstract the operations for root & nvdimm devices

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong It separates the operations between root device and nvdimm devices in order to introducing label functions support for nvdimm device Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/

[Qemu-devel] [PULL 03/34] acpi: Add IPMI table entries

2016-06-23 Thread Michael S. Tsirkin
From: Corey Minyard Use the ACPI table construction tools to create an ACPI entry for IPMI. This adds a function called build_acpi_ipmi_devices to add an DSDT entry for IPMI if IPMI is compiled in and an IPMI device exists. It also adds a dummy function if IPMI is not compiled in. This conform

[Qemu-devel] [PULL 06/34] nvdimm: support nvdimm label

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong Introduce a parameter, 'label-size', which is the size of nvdimm label data area which is reserved at the end of backend memory. It is required at least 128k Two callbacks, read_label_data() and write_label_data(), are used to operate the label area Reviewed-by: Stefan Hajn

[Qemu-devel] [PULL 00/34] pc, pci, virtio: new features, cleanups, fixes

2016-06-23 Thread Michael S. Tsirkin
The following changes since commit c7288767523f6510cf557707d3eb5e78e519b90d: Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.7-20160623' into staging (2016-06-23 11:53:14 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qem

[Qemu-devel] [PULL 10/34] nvdimm acpi: save arg3 of _DSM method

2016-06-23 Thread Michael S. Tsirkin
From: Xiao Guangrong Check if the input Arg3 is valid then store it into ARG3 if it is needed Signed-off-by: Xiao Guangrong Reviewed-by: Stefan Hajnoczi Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/acpi/nvdimm.c | 20 1 file changed, 20 inser

[Qemu-devel] [PULL 02/34] ipmi: Add SMBIOS table entry

2016-06-23 Thread Michael S. Tsirkin
From: Corey Minyard Add an IPMI table entry to the SMBIOS. Signed-off-by: Corey Minyard Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/smbios/ipmi.h | 15 ++ hw/smbios/smbios.c | 2 + hw/smbios/smbios_type_38.c | 117

[Qemu-devel] [PULL 01/34] smbios: Move table build tools into an include file.

2016-06-23 Thread Michael S. Tsirkin
From: Corey Minyard This will let things in other files (like IPMI) build SMBIOS tables. Signed-off-by: Corey Minyard Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/smbios/smbios_build.h | 87 hw/smbios/smbios.c

Re: [Qemu-devel] [PATCH v2 09/10] tests: acpi: add CPU hotplug testcase

2016-06-23 Thread Michael S. Tsirkin
On Thu, Jun 23, 2016 at 03:47:36PM +0200, Igor Mammedov wrote: > On Thu, 23 Jun 2016 16:08:38 +0300 > Marcel Apfelbaum wrote: > > > On 06/16/2016 07:55 PM, Igor Mammedov wrote: > > > Test with: > > > > > > -smp 2,cores=3,sockets=2,maxcpus=6 > > > > > > to capture sparse APIC ID values that d

Re: [Qemu-devel] [PATCH 00/13] virtio migration: Flip outer layer to vmstate

2016-06-23 Thread Michael S. Tsirkin
On Tue, Jun 21, 2016 at 08:13:54PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This series converts the outer most layer of virtio to > use VMState macros; this is the easy bit, but I'm hoping that > having done that, the next trick is to nibble away a

Re: [Qemu-devel] [PATCH v4 0/4] enable iommu with -device

2016-06-23 Thread Michael S. Tsirkin
On Tue, Jun 14, 2016 at 10:19:32AM +0300, Marcel Apfelbaum wrote: > Create the iommu device with '-device intel-iommu' instead of > '-machine,iommu=on'. > > The device is part of the machine properties because we wanted > to ensure is created before any other PCI device. > > The alternative is t

Re: [Qemu-devel] Change of max-ram-below-4g initial value breaks Xen

2016-06-23 Thread Gerd Hoffmann
On Do, 2016-06-23 at 17:18 +0100, Anthony PERARD wrote: > On Thu, Jun 23, 2016 at 04:57:54PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > How could xen_ram_init() find out if the value of max-ram-below-4g is > > > the default or if a user have set it? Is there another way we could fix > > > thi

Re: [Qemu-devel] [PATCH v1 04/11] ppc/xics: Remove unused xics_set_irq_type()

2016-06-23 Thread David Gibson
On Thu, Jun 23, 2016 at 11:17:23PM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > Signed-off-by: Benjamin Herrenschmidt > Reviewed-by: David Gibson > Signed-off-by: Nikunj A Dadhania This stands on its own so I've applied it to ppc-for-2.7 (adjusting for context conflicts,

Re: [Qemu-devel] [PATCH v3 09/22] blkdebug: Set request_alignment during .bdrv_refresh_limits()

2016-06-23 Thread Fam Zheng
On Thu, 06/23 16:37, Eric Blake wrote: > We want to eventually stick request_alignment alongside other > BlockLimits, but first, we must ensure it is populated at the > same time as all other limits, rather than being a special case > that is set only when a block is first opened. > > Note that wh

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread Peter Krempa
On Fri, Jun 24, 2016 at 14:56:51 +1000, David Gibson wrote: [...] > > You are correct - query-commands says whether 'query-hotpluggable-cpus' > > exists as a command. But that is insufficient. See my review, or the > > v2 patch, where the above poor wording was corrected to say what was > > rea

Re: [Qemu-devel] [PATCH v2 0/2] qapi: Fix up cpu hotplug property names and add witness for cpu hotplug support

2016-06-23 Thread David Gibson
On Fri, 24 Jun 2016 07:31:39 +0200 Igor Mammedov wrote: > On Fri, 24 Jun 2016 13:00:56 +1000 > David Gibson wrote: > > > On Thu, 23 Jun 2016 23:23:32 +0200 > > Peter Krempa wrote: > > > > > Version 2: > > > - fix typos/incompetence/drowsiness based language errors in commit > > > message >

Re: [Qemu-devel] [PATCH v2 2/2] qapi: keep names in 'CpuInstanceProperties' in sync with struct CPUCore

2016-06-23 Thread Igor Mammedov
On Thu, 23 Jun 2016 23:23:34 +0200 Peter Krempa wrote: > struct CPUCore uses 'id' suffix in the property name. As docs for > query-hotpluggable-cpus state that the cpu core properties should be > passed back to device_add by management in case new members are added > and thus the names for the fi

Re: [Qemu-devel] [PATCH v2 0/2] qapi: Fix up cpu hotplug property names and add witness for cpu hotplug support

2016-06-23 Thread Igor Mammedov
On Fri, 24 Jun 2016 13:00:56 +1000 David Gibson wrote: > On Thu, 23 Jun 2016 23:23:32 +0200 > Peter Krempa wrote: > > > Version 2: > > - fix typos/incompetence/drowsiness based language errors in commit > > message > > - select version 1 as prefered way > > - add -id suffix to all members of Cp

Re: [Qemu-devel] [PATCH v3 08/22] block: Give nonzero result to blk_get_max_transfer_length()

2016-06-23 Thread Fam Zheng
On Thu, 06/23 16:37, Eric Blake wrote: > Making all callers special-case 0 as unlimited is awkward, > and we DO have a hard maximum of BDRV_REQUEST_MAX_SECTORS given > our current block layer API limits. > > In the case of scsi, this means that we now always advertise a > limit to the guest, even

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread Igor Mammedov
On Fri, 24 Jun 2016 14:56:51 +1000 David Gibson wrote: > On Thu, 23 Jun 2016 21:49:25 -0600 > Eric Blake wrote: > > > On 06/23/2016 08:56 PM, David Gibson wrote: > > > On Thu, 23 Jun 2016 22:23:23 +0200 > > > Peter Krempa wrote: > > > > > >> For management apps it's very useful to know whet

Re: [Qemu-devel] [PATCH 06/11] target-i386: add socket/core/thread properties to X86CPU

2016-06-23 Thread Igor Mammedov
On Thu, 23 Jun 2016 18:43:53 -0300 Eduardo Habkost wrote: > On Thu, Jun 23, 2016 at 10:46:36PM +0200, Igor Mammedov wrote: > > On Thu, 23 Jun 2016 17:18:46 -0300 > > Eduardo Habkost wrote: > [...] > > > > > > > > > > > > > > I suggest validating the properties, and setting them in case > > > >

Re: [Qemu-devel] [PATCH v1 02/11] ppc/xics: Move SPAPR specific code to a separate file

2016-06-23 Thread David Gibson
On Thu, Jun 23, 2016 at 11:17:21PM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > Leave the core ICP/ICS logic in xics.c and move the top level > class wrapper, hypercall and RTAS handlers to xics_spapr.c > > Signed-off-by: Benjamin Herrenschmidt > [add cpu.h in xics_spapr.c

Re: [Qemu-devel] [PATCH v3 07/22] scsi: Advertise limits by blocksize, not 512

2016-06-23 Thread Fam Zheng
On Thu, 06/23 16:37, Eric Blake wrote: > s->blocksize may be larger than 512, in which case our > tweaks to max_xfer_len and opt_xfer_len must be scaled > appropriately. > > Reported-by: Fam Zheng > Signed-off-by: Eric Blake > CC: qemu-sta...@nongnu.org > > --- > v3: new patch > --- > hw/scsi/

Re: [Qemu-devel] [PATCH v1 03/11] ppc/xics: Implement H_IPOLL using an accessor

2016-06-23 Thread David Gibson
On Thu, Jun 23, 2016 at 11:17:22PM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > None of the other presenter functions directly mucks with the > internal state, so don't do it there either. > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Nikunj A Dadhania Revie

Re: [Qemu-devel] [PATCH v1 01/11] ppc/xics: Rename existing xics to xics_spapr

2016-06-23 Thread David Gibson
On Thu, Jun 23, 2016 at 11:17:20PM +0530, Nikunj A Dadhania wrote: > From: Benjamin Herrenschmidt > > The common class doesn't change, the KVM one is sPAPR specific. Rename > variables and functions to xics_spapr. > > Retain the type name as "xics" to preserve migration for existing sPAPR > gues

[Qemu-devel] [PATCH 4/4] Revert "mirror: Workaround for unexpected iohandler events during completion"

2016-06-23 Thread Fam Zheng
This reverts commit ab27c3b5e7408693dde0b565f050aa55c4a1bcef. The virtio host notifiers are now covered by bdrv_drained_begin/end, so we don't need this hacky quiescing of the iohandler context anymore. Signed-off-by: Fam Zheng --- block/mirror.c | 9 - 1 file changed, 9 deletions(-) d

[Qemu-devel] [PATCH 2/4] virtio: Always use aio path to set host handler

2016-06-23 Thread Fam Zheng
Apart from the interface difference, the aio version works the same as the non-aio one. The event notifier versus aio fd handler makes no diffeerence, except the former led to an ugly patch in commit ab27c3b5e7, which won't be necessary any more. As the first step to unify them, all callers are sw

[Qemu-devel] [PATCH 3/4] virtio: Drop the unused virtio_queue_set_host_notifier_fd_handler code

2016-06-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/virtio/virtio.c | 24 include/hw/virtio/virtio.h | 2 -- 2 files changed, 26 deletions(-) diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c index 99cd0c0..7a375c1 100644 --- a/hw/virtio/virtio.c +++ b/hw/virtio/virtio.c @@ -181

[Qemu-devel] [PATCH 1/4] virtio: Add typedef for handle_output

2016-06-23 Thread Fam Zheng
The function pointer signature has been repeated a few times, using a typedef may make coding easier. Signed-off-by: Fam Zheng --- hw/virtio/virtio.c | 9 - include/hw/virtio/virtio.h | 5 +++-- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/virtio/virtio.c b/h

[Qemu-devel] [PATCH 0/4] virtio: Merge two host notifier handling paths

2016-06-23 Thread Fam Zheng
This series is based on top of Cornelia's [PATCH 0/6] virtio: refactor host notifiers The benifit is we don't use event_notifier_set_handler even in non-dataplane now, which in turn makes virtio-blk and virtio-scsi follow block layer aio context semantics. Specifically, I/O requests must come

[Qemu-devel] [PATCH v3 3/3] palmetto-bmc: Configure the SCU's hardware strapping register

2016-06-23 Thread Andrew Jeffery
The magic constant configures the following options: * 28:27: Configure DRAM size as 256MB * 26:24: DDR3 SDRAM with CL = 6, CWL = 5 * 23: Configure 24/48MHz CLKIN * 22: Disable GPIOE pass-through mode * 21: Disable GPIOD pass-through mode * 20: Enable LPC decode of SuperIO 0x2E/0x4E addresses * 19

[Qemu-devel] [PATCH v3 1/3] hw/misc: Add a model for the ASPEED System Control Unit

2016-06-23 Thread Andrew Jeffery
The SCU is a collection of chip-level control registers that manage the various functions supported by ASPEED SoCs. Typically the bits control interactions with clocks, external hardware or reset behaviour, and we can largly take a hands-off approach to reads and writes. Firmware makes heavy use o

[Qemu-devel] [PATCH v3 2/3] ast2400: Integrate the SCU model and set silicon revision

2016-06-23 Thread Andrew Jeffery
By specifying the silicon revision we select the appropriate reset values for the SoC. Additionally, expose hardware strapping properties aliasing those provided by the SCU for board-specific configuration. Signed-off-by: Andrew Jeffery Reviewed-by: Cédric Le Goater Reviewed-by: Peter Maydell

[Qemu-devel] [PATCH v3 0/3] Add ASPEED SCU device

2016-06-23 Thread Andrew Jeffery
Hi all, These are three patches implementing minimal functionality for the ASPEED System Control Unit device and integrating it into the AST2400 SoC model/palmetto-bmc machine. The device is critical for initialisation of u-boot and the kernel as it provides chip level control registers, influenci

Re: [Qemu-devel] Question about a qemu Aarch64 error when adding several SCSI disks

2016-06-23 Thread Kevin Zhao
Hi Peter, Follow your advice, I have complied the Qemu v2.6. stack@u202158:~$ kvm --version QEMU emulator version 2.6.50 (v2.6.0-1280-g6f1d2d1-dirty), Copyright (c) 2003-2008 Fabrice Bellard With this newest version, I use virt-manager to create the guest , the xml file is in the attachme

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread David Gibson
On Thu, 23 Jun 2016 21:49:25 -0600 Eric Blake wrote: > On 06/23/2016 08:56 PM, David Gibson wrote: > > On Thu, 23 Jun 2016 22:23:23 +0200 > > Peter Krempa wrote: > > > >> For management apps it's very useful to know whether the selected > >> machine type supports cpu hotplug via the new -devi

[Qemu-devel] [PATCH] target-sparc: Use overalignment flags for twinx and block asis

2016-06-23 Thread Richard Henderson
This allows us to enforce 16 and 64-byte alignment without any extra overhead. Signed-off-by: Richard Henderson --- This patch is dependent on by sparc improvements branch, along with Sergey's alignment improvement patch. A buildable tree is at git://github.com/rth7680/qemu.git tgt-sparc-tmp

Re: [Qemu-devel] [PATCH v4] Improve the alignment check infrastructure

2016-06-23 Thread Richard Henderson
On 06/23/2016 12:18 PM, Richard Henderson wrote: On 06/23/2016 11:16 AM, Sergey Sorokin wrote: +#if defined(CONFIG_SOFTMMU) +/** + * get_alignment_bits + * @memop: TCGMemOp value + * + * Extract the alignment size from the memop. + * + * Returns: 0 in case of byte access (which is always aligned

Re: [Qemu-devel] [PATCH 06/12] monitor: remove mhandler.cmd_new

2016-06-23 Thread Eric Blake
On 06/22/2016 06:08 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This is no longer necessary, now that middle mode has been removed. > > Signed-off-by: Marc-André Lureau > --- > docs/writing-qmp-commands.txt | 8 +- > hmp-commands-info.hx | 118 --

Re: [Qemu-devel] [PATCH 05/12] monitor: register the qapi generated commands

2016-06-23 Thread Eric Blake
On 06/22/2016 06:08 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Stop using the so-called 'middle' mode. Instead, use qmp_find_command() > from generated qapi commands registry. > > Note: this commit requires a 'make clean' prior to make, since the > generated files do no

Re: [Qemu-devel] [PATCH 04/12] monitor: remove usage of generated marshal functions

2016-06-23 Thread Eric Blake
On 06/22/2016 06:08 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Once the middle mode is removed, the generated marshal functions will no > longer be exported. > > Signed-off-by: Marc-André Lureau > --- > monitor.c | 10 +- > 1 file changed, 5 insertions(+), 5 d

Re: [Qemu-devel] Qemu and heavily increased RSS usage

2016-06-23 Thread Paolo Bonzini
> > If it's 10M nothing. If there is a 100M regression that is also caused > > by RCU, we have to give up on it for that data structure, or mmap/munmap > > the affected data structures. > > If it was only 10MB I would agree. But if I run the VM described earlier > in this thread it goes from ~35

[Qemu-devel] [PATCH 1/2] nbd: Convert to byte-based interface

2016-06-23 Thread Eric Blake
The NBD protocol doesn't have any notion of sectors, so it is a fairly easy convertion to use byte-based read and write. Signed-off-by: Eric Blake --- block/nbd-client.h | 8 include/block/nbd.h | 1 - block/nbd-client.c | 30 +- block/nbd.c | 12

Re: [Qemu-devel] [PATCH 03/12] monitor: register gen:false commands manually

2016-06-23 Thread Eric Blake
On 06/22/2016 06:08 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Since a few commands are using 'gen': false, they are not registered > automatically by the generator. Register manually instead. > > This is in preparation for removal of qapi 'middle' mode generation. > >

[Qemu-devel] [PATCH 0/2] Switch raw NBD to byte-based

2016-06-23 Thread Eric Blake
With these two patches, I'm finally able to run: ./qemu-nbd -f raw -x foo file ./qemu-io -f raw -t none nbd://localhost:10809/foo and get true byte-based access over the wire for operations such as 'r 1 1' or 'w 1 1', rather than RMW sector-aligned access. Depends on these series: v3 Byte-based

[Qemu-devel] [PATCH v3 5/9] tcg: Reorg TCGOp chaining

2016-06-23 Thread Richard Henderson
Instead of using -1 as end of chain, use 0, and link through the 0 entry as a fully circular double-linked list. Signed-off-by: Richard Henderson --- include/exec/gen-icount.h | 2 +- tcg/optimize.c| 8 ++-- tcg/tcg-op.c | 2 +- tcg/tcg.c | 32

[Qemu-devel] [PATCH 2/2] raw_bsd: Convert to byte-based interface

2016-06-23 Thread Eric Blake
Since the raw format driver is just passing things through, we can do byte-based read and write if the underlying protocol does likewise. There's one tricky part - if we probed the image format, we document that we restrict operations on the initial sector. Rather than trying to handle a read-mod

Re: [Qemu-devel] [PATCH 02/12] qapi-schema: add 'device_add'

2016-06-23 Thread Eric Blake
On 06/22/2016 06:07 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Even though device_add is not fully qapi'fied, we may add it to the json > schema with 'gen': false, so registration and documentation can be > generated. > > Signed-off-by: Marc-André Lureau > --- > qapi-

Re: [Qemu-devel] [PULL 5/8] target-sparc: Use global registers for the register window

2016-06-23 Thread Richard Henderson
On 06/16/2016 02:53 PM, Mark Cave-Ayland wrote: On 16/06/16 21:26, Richard Henderson wrote: On 06/14/2016 02:52 PM, Mark Cave-Ayland wrote: Following up the bug report at https://bugs.launchpad.net/qemu/+bug/1588328, I bisected the regression down to this particular commit. I can't see anythin

[Qemu-devel] [PATCH v3 9/9] tcg: Lower indirect registers in a separate pass

2016-06-23 Thread Richard Henderson
Rather than rely on recursion during the middle of register allocation, lower indirect registers to loads and stores off the indirect base into plain temps. For an x86_64 host, with sufficient registers, this results in identical code, modulo the actual register assignments. For an i686 host, wit

Re: [Qemu-devel] [PATCH 1/3] qapi: Report support for -device cpu hotplug in query-machines

2016-06-23 Thread Eric Blake
On 06/23/2016 08:56 PM, David Gibson wrote: > On Thu, 23 Jun 2016 22:23:23 +0200 > Peter Krempa wrote: > >> For management apps it's very useful to know whether the selected >> machine type supports cpu hotplug via the new -device approach. Using >> the presence of 'query-hotpluggable-cpus' is en

[Qemu-devel] [PATCH v3 6/9] tcg: Fold life data into TCGOp

2016-06-23 Thread Richard Henderson
Reduce the size of other bitfields to make room. This reduces the cache footprint of compilation. Signed-off-by: Richard Henderson --- tcg/tcg.c | 9 +++-- tcg/tcg.h | 26 ++ 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index

[Qemu-devel] [PATCH v3 4/9] tcg: Compress liveness data to 16 bits

2016-06-23 Thread Richard Henderson
This reduces both memory usage and per-insn cacheline usage during code generation. Signed-off-by: Richard Henderson --- tcg/tcg.c | 58 ++ tcg/tcg.h | 16 ++-- 2 files changed, 32 insertions(+), 42 deletions(-) diff --git a/tc

[Qemu-devel] [PATCH v3 2/9] tcg: Optimize spills of constants

2016-06-23 Thread Richard Henderson
While we can store constants via constrants on INDEX_op_st_i32 et al, we weren't able to spill constants to backing store. Add a new backend interface, tcg_out_sti, which may store the constant (and is allowed to fail). Rearrange the temp_* helpers so that we only attempt to directly store a cons

[Qemu-devel] [PATCH v3 0/9] Third try at fixing sparc register allocation

2016-06-23 Thread Richard Henderson
I was unhappy about the complexity of the second try. Better to convert to normal temps, allowing in rare occasions, spilling the "globals" to the stack in order to satisfy register allocation. I can no longer provoke an allocation failure on i686. Hopefully this fixes the OpenBSD case that Mark

  1   2   3   4   5   >