Re: [Qemu-devel] 'tcg fatal error' with qemu v2.6.0-rc3 (bisected)

2016-04-26 Thread Aurelien Jarno
On 2016-04-26 20:12, Guenter Roeck wrote: > Hi, > > when running qemu version 2.6.0-rc3, I get the following error message. > > /opt/buildbot/qemu/qemu/tcg/tcg.c:1769: tcg fatal error > > qemu command line is as follows. > > qemu-system-ppc64 -M mpc8544ds \ > -cpu e5500 \ > -m 1024

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-04-26 Thread Thomas Huth
On 26.04.2016 23:03, Michael Roth wrote: > Quoting Igor Mammedov (2016-04-26 02:52:36) >> On Tue, 26 Apr 2016 10:39:23 +0530 >> Bharata B Rao wrote: >> >>> On Mon, Apr 25, 2016 at 11:20:50AM +0200, Igor Mammedov wrote: On Wed, 16 Mar 2016 10:11:54 +0530 Bharata B Rao wrote:

Re: [Qemu-devel] [RFC for-2.7 01/11] qdt: IEEE1275-style device tree utility code

2016-04-26 Thread Markus Armbruster
David Gibson writes: > On Tue, Apr 26, 2016 at 01:00:06PM +0200, Thomas Huth wrote: >> On 20.04.2016 04:33, David Gibson wrote: >> ... >> > This patch introduces a new utility library "qdt" for runtime >> > manipulation of device trees. The intention is that machine type code >> > can use these

Re: [Qemu-devel] [PATCH qemu v15 14/17] spapr_iommu, vfio, memory: Notify IOMMU about starting/stopping being used by VFIO

2016-04-26 Thread David Gibson
On Thu, Apr 21, 2016 at 02:22:01PM +1000, Alexey Kardashevskiy wrote: > On 04/21/2016 01:59 PM, David Gibson wrote: > >On Wed, Apr 20, 2016 at 07:15:15PM +1000, Alexey Kardashevskiy wrote: > >>On 04/07/2016 10:40 AM, David Gibson wrote: > >>>On Mon, Apr 04, 2016 at 07:33:43PM +1000, Alexey Kardashe

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

2016-04-26 Thread Thomas Huth
On 26.04.2016 22:19, Programmingkid wrote: > > On Apr 26, 2016, at 4:12 PM, Thomas Huth wrote: > >> On 26.04.2016 21:25, Programmingkid wrote: >>> >>> On Apr 26, 2016, at 3:00 PM, Dr. David Alan Gilbert wrote: >>> * Programmingkid (programmingk...@gmail.com) wrote: > My three guest opera

Re: [Qemu-devel] [PATCH for 2.7 0/2] backup compression

2016-04-26 Thread Denis V. Lunev
On 04/26/2016 12:46 PM, Stefan Hajnoczi wrote: On Sat, Apr 23, 2016 at 11:41:51AM +0300, Denis V. Lunev wrote: The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. These patches add the a

Re: [Qemu-devel] [PATCH v14 13/19] qmp: Tighten output visitor rules

2016-04-26 Thread Markus Armbruster
Eric Blake writes: > On 04/15/2016 03:02 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Add a new qmp_output_visitor_reset(), which must be called before >>> reusing an exising QmpOutputVisitor on a new root object. Tighten >>> assertions to require that qmp_output_get_qobject() can

[Qemu-devel] [PATCH v2 3/3] qemu-iotests: test backup compression in 055

2016-04-26 Thread Denis V. Lunev
From: Pavel Butsykin Added cases to check the backup compression out of qcow2, raw in qcow2 on drive-backup and blockdev-backup. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake CC: John Snow --- tests/qemu-iotests/055|

[Qemu-devel] [PATCH for 2.7 v2 0/3] backup compression

2016-04-26 Thread Denis V. Lunev
The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. These patches add the ability to compress data during backup. This functionality is implemented by means of adding options to the qmp/hmp

[Qemu-devel] [PATCH v2 2/3] blockdev-backup: added support for data compression

2016-04-26 Thread Denis V. Lunev
From: Pavel Butsykin The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Jeff Cody CC: Markus Armbruster CC: Eric Blake

[Qemu-devel] [PATCH v2 1/3] drive-backup: added support for data compression

2016-04-26 Thread Denis V. Lunev
From: Pavel Butsykin The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. The patch adds a flag to the qmp/hmp drive-backup command which enables block compression. Compression should be i

Re: [Qemu-devel] [RFC for-2.7 08/11] pseries: Start using qdt library for building device tree

2016-04-26 Thread David Gibson
On Thu, Apr 21, 2016 at 02:04:16PM +1000, Alexey Kardashevskiy wrote: > On 04/20/2016 12:33 PM, David Gibson wrote: > >This starts the process of converting the pseries machine type to use > >the qdt library code to build the guest's device tree instead of > >working directly and awkwardly with the

Re: [Qemu-devel] [RFC for-2.7 11/11] pseries: Remove unused callbacks from sPAPR VIO bus state

2016-04-26 Thread David Gibson
On Thu, Apr 21, 2016 at 03:31:33PM +1000, Alexey Kardashevskiy wrote: > On 04/20/2016 12:33 PM, David Gibson wrote: > >The VIOsPAPRBus structure has some callback pointers in it which aren't > >used anywhere in the code. It's not clear exactly why they were there in > >the first place, but they ce

Re: [Qemu-devel] [RFC for-2.7 05/11] pseries: Build device tree only at reset time

2016-04-26 Thread David Gibson
On Tue, Apr 26, 2016 at 08:13:21PM +0200, Thomas Huth wrote: > On 20.04.2016 04:33, David Gibson wrote: > > Currently the pseries code builds a "skeleton" device tree at machine init > > time, then adds a bunch of stuff to it at reset. Over time, more and more > > logic has had to be moved from in

Re: [Qemu-devel] [RFC for-2.7 01/11] qdt: IEEE1275-style device tree utility code

2016-04-26 Thread David Gibson
On Tue, Apr 26, 2016 at 01:00:06PM +0200, Thomas Huth wrote: > On 20.04.2016 04:33, David Gibson wrote: > ... > > This patch introduces a new utility library "qdt" for runtime > > manipulation of device trees. The intention is that machine type code > > can use these routines to construct the devi

Re: [Qemu-devel] [PATCH] PPC/KVM: early validation of vcpu id

2016-04-26 Thread David Gibson
On Tue, Apr 26, 2016 at 03:41:04PM +0200, Greg Kurz wrote: > The KVM API restricts vcpu ids to be < KVM_CAP_MAX_VCPUS. On PowerPC > targets, depending on the number of threads per core in the host and > in the guest, some topologies do generate higher vcpu ids actually. > When this happens, QEMU ba

Re: [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap

2016-04-26 Thread Wei, Jiangang
On Wed, 2016-04-27 at 06:44 +0300, Max Filippov wrote: > Hi Wei, > > On Wed, Apr 27, 2016 at 03:27:47AM +, Wei, Jiangang wrote: > > On Wed, 2016-04-27 at 10:07 +0800, Zhou Jie wrote: > > > static void open_eth_start_xmit(OpenEthState *s, desc *tx) > > > { > > > -uint8_t buf[65536]; > > >

Re: [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap

2016-04-26 Thread Max Filippov
Hi Wei, On Wed, Apr 27, 2016 at 03:27:47AM +, Wei, Jiangang wrote: > On Wed, 2016-04-27 at 10:07 +0800, Zhou Jie wrote: > > static void open_eth_start_xmit(OpenEthState *s, desc *tx) > > { > > -uint8_t buf[65536]; > > +uint8_t *buf = NULL; > > +uint8_t buffer[0x600]; > Hi, > > I

Re: [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap

2016-04-26 Thread Wei, Jiangang
On Wed, 2016-04-27 at 10:07 +0800, Zhou Jie wrote: > open_eth_start_xmit has a huge stack usage of 65536 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Signed-off-by: Zhou Jie > --- > hw/net/opencores_eth.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(

[Qemu-devel] 'tcg fatal error' with qemu v2.6.0-rc3 (bisected)

2016-04-26 Thread Guenter Roeck
Hi, when running qemu version 2.6.0-rc3, I get the following error message. /opt/buildbot/qemu/qemu/tcg/tcg.c:1769: tcg fatal error qemu command line is as follows. qemu-system-ppc64 -M mpc8544ds \ -cpu e5500 \ -m 1024 -kernel arch/powerpc/boot/uImage -initrd busybox-ppc.cpio \

Re: [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap

2016-04-26 Thread Zhou Jie
On 2016/4/27 10:46, Max Filippov wrote: Hi Zhou, On Wed, Apr 27, 2016 at 10:18:56AM +0800, Zhou Jie wrote: When I committed another patch which named as "hw/net/virtio-net: Allocating Large sized arrays to heap" . Christian Borntraeger said that 16k is usually perfectly fine

Re: [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap

2016-04-26 Thread Max Filippov
Hi Zhou, On Wed, Apr 27, 2016 at 10:18:56AM +0800, Zhou Jie wrote: >When I committed another patch which named as >"hw/net/virtio-net: Allocating Large sized arrays to heap" . > >Christian Borntraeger said that 16k is usually perfectly fine >for a userspace stack and doing allocat

Re: [Qemu-devel] [PATCH v3 11/11] translate-all: add tb hash bucket info to 'info jit' dump

2016-04-26 Thread Emilio G. Cota
On Sun, Apr 24, 2016 at 18:06:51 -0400, Emilio G. Cota wrote: > On Sun, Apr 24, 2016 at 12:46:08 -0700, Richard Henderson wrote: > > On 04/22/2016 04:57 PM, Emilio G. Cota wrote: > > >On Fri, Apr 22, 2016 at 12:59:52 -0700, Richard Henderson wrote: > > >>FWIW, so that I could get an idea of how the

Re: [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap

2016-04-26 Thread Max Filippov
On Wed, Apr 27, 2016 at 10:07:48AM +0800, Zhou Jie wrote: > open_eth_start_xmit has a huge stack usage of 65536 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Signed-off-by: Zhou Jie > --- > hw/net/opencores_eth.c | 11 ++- > 1 file changed, 10 insertions(+), 1 de

Re: [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap

2016-04-26 Thread Zhou Jie
Hi Max, When I committed another patch which named as "hw/net/virtio-net: Allocating Large sized arrays to heap" . Christian Borntraeger said that 16k is usually perfectly fine for a userspace stack and doing allocations in a hot path might actually hurt performance. Although

[Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap

2016-04-26 Thread Zhou Jie
open_eth_start_xmit has a huge stack usage of 65536 bytes approx. Moving large arrays to heap to reduce stack usage. Signed-off-by: Zhou Jie --- hw/net/opencores_eth.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hw/net/opencores_eth.c b/hw/net/opencores_eth.c

Re: [Qemu-devel] [PATCH v2] vl: change runstate only if new state is different from current state

2016-04-26 Thread Li Zhijian
ping... Thanks Li Zhijian On 04/14/2016 11:25 AM, Li Zhijian wrote: Previously, qemu will abort at following scenario: (qemu) stop (qemu) system_reset (qemu) system_reset (qemu) 2016-04-13T20:54:38.979158Z qemu-system-x86_64: invalid runstate transition: 'prelaunch' -> 'prelaunch' Signed-off

Re: [Qemu-devel] [PATCH v14 13/19] qmp: Tighten output visitor rules

2016-04-26 Thread Eric Blake
On 04/15/2016 03:02 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Add a new qmp_output_visitor_reset(), which must be called before >> reusing an exising QmpOutputVisitor on a new root object. Tighten >> assertions to require that qmp_output_get_qobject() can only be >> called after pai

Re: [Qemu-devel] [PATCH] hw/net/opencores_eth: Allocating Large sized arrays to heap

2016-04-26 Thread Zhou Jie
On 2016/4/26 12:12, Max Filippov wrote: Hi Zhou, On Tue, Apr 26, 2016 at 6:35 AM, Zhou Jie wrote: open_eth_start_xmit has a huge stack usage of 65536 bytes approx. Moving large arrays to heap to reduce stack usage. It's an exception, not the rule when full 65536 byte long buffer might be ne

Re: [Qemu-devel] [PATCH] hw/net/virtio-net: Allocating Large sized arrays to heap

2016-04-26 Thread Zhou Jie
On 2016/4/26 20:42, Michael S. Tsirkin wrote: On Tue, Apr 26, 2016 at 04:05:24PM +0800, Zhou Jie wrote: virtio_net_flush_tx has a huge stack usage of 16392 bytes approx. Moving large arrays to heap to reduce stack usage. Signed-off-by: Zhou Jie I don't think it's appropriate for trivial. Als

Re: [Qemu-devel] [PATCH 02/19] block: Add BDS.backing_overridden

2016-04-26 Thread Eric Blake
On 04/26/2016 03:32 PM, Max Reitz wrote: > If the backing file is overridden, this most probably does change the > guest-visible data of a BDS. Therefore, we will need to consider this in > bdrv_refresh_filename(). > > Adding a new field to the BDS is not nice, but it is very simple and > exactly

Re: [Qemu-devel] [PATCH 01/19] block: Use children list in bdrv_refresh_filename

2016-04-26 Thread Eric Blake
On 04/26/2016 03:32 PM, Max Reitz wrote: > bdrv_refresh_filename() should invoke itself recursively on all > children, not just on file. > > With that change, we can remove the manual invocations in blkverify and > quorum. > > Signed-off-by: Max Reitz > --- > block.c | 9 + >

Re: [Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

2016-04-26 Thread Fam Zheng
On Tue, 04/26 10:42, Jason Dillaman wrote: > On Sun, Apr 24, 2016 at 7:42 PM, Fam Zheng wrote: > > On Fri, 04/22 21:57, Jason Dillaman wrote: > >> Since this cannot automatically recover from a crashed QEMU client with an > >> RBD image, perhaps this RBD locking should not default to enabled. > >>

Re: [Qemu-devel] Updating documentation at http://wiki.qemu.org/download/qemu-doc.html

2016-04-26 Thread Mark Cave-Ayland
On 26/04/16 13:37, Jeff Cody wrote: > On Tue, Apr 26, 2016 at 11:02:45AM +0100, Stefan Hajnoczi wrote: >> On Tue, Apr 26, 2016 at 07:50:31AM +0100, Mark Cave-Ayland wrote: >>> Does anyone know if it's possible to update the documentation at the >>> above URL? It appears as a link at http://wiki.qe

Re: [Qemu-devel] [PATCH v14 08/19] qapi: Document visitor interfaces, add assertions

2016-04-26 Thread Eric Blake
On 04/14/2016 09:22 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The visitor interface for mapping between QObject/QemuOpts/string >> and QAPI is scandalously under-documented, making changes to visitor >> core, individual visitors, and users of visitors difficult to >> coordinate. Amo

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix descriptor address masking in ARM address translation

2016-04-26 Thread Sergey Sorokin
26.04.2016, 19:35, "Tom Hanson" :On 03/21/2016 09:56 AM, Sergey Sorokin wrote: 17.03.2016, 18:24, "Peter Maydell" :   On 17 March 2016 at 15:21, Sergey Sorokin wrote:17.03.2016, 14:40, "Peter Maydell" :On 13 March 201

[Qemu-devel] [PATCH 19/19] iotests: Add quorum case to test 110

2016-04-26 Thread Max Reitz
Test 110 tests relative backing filenames for complex BDS trees. Add quorum as an example that can never work automatically (without special-casing if all child nodes have the same base directory), and an example on how to make it work manually (using the base-directory option). Signed-off-by: Max

[Qemu-devel] [PATCH 17/19] block: Use bdrv_dirname() for relative filenames

2016-04-26 Thread Max Reitz
bdrv_get_full_backing_filename_from_filename() breaks down when it comes to JSON filenames. Using bdrv_dirname() as the basis is better because since we have BDS, we can descend through the BDS tree to the protocol layer, which gives us a greater probability of finding a non-JSON name; also, bdrv_d

[Qemu-devel] [PATCH 14/19] blkverify: Make bdrv_dirname() return NULL

2016-04-26 Thread Max Reitz
blkverify's BDSs have a file BDS, but we do not want this to be preferred over the raw node. There is no way to decide between the two (and not really a reason to, either), so just return NULL in blkverify's implementation of bdrv_dirname(). Signed-off-by: Max Reitz --- block/blkverify.c | 10 ++

[Qemu-devel] [PATCH 12/19] block: Fix bdrv_find_backing_image()

2016-04-26 Thread Max Reitz
bdrv_find_backing_image() should use bdrv_get_full_backing_filename() or bdrv_make_absolute_filename() instead of trying to do what those functions do by itself. path_combine_deprecated() can now be dropped, so let's do that. Signed-off-by: Max Reitz --- block.c | 28 +--

[Qemu-devel] [PATCH 11/19] block: Add bdrv_make_absolute_filename()

2016-04-26 Thread Max Reitz
This is a general function for making a filename that is relative to a certain BDS absolute. It calls bdrv_get_full_backing_filename_from_filename() for now, but that will be changed in a follow-up patch. Signed-off-by: Max Reitz --- block.c | 15 +++ 1 file changed, 11 insertions(+

[Qemu-devel] [PATCH 18/19] block: Add 'base-directory' BDS option

2016-04-26 Thread Max Reitz
Using this option, one can directly override what bdrv_dirname() will return. This is useful if one uses e.g. qcow2 on top of quorum (with only protocol BDSs under the quorum BDS) and wants to be able to use relative backing filenames. Signed-off-by: Max Reitz --- block.c | 13

[Qemu-devel] [PATCH 08/19] block: Make path_combine() return the path

2016-04-26 Thread Max Reitz
Besides being safe for arbitrary path lengths, after some follow-up patches all callers will want a freshly allocated buffer anyway. In the meantime, path_combine_deprecated() is added which has the same interface as path_combine() had before this patch. All callers to that function will be conver

[Qemu-devel] [PATCH 15/19] quorum: Make bdrv_dirname() return NULL

2016-04-26 Thread Max Reitz
While the common implementation for bdrv_dirname() should return NULL for quorum BDSs already (because they do not have a file node and their exact_filename field should be empty), there is no reason not to make that explicit. Signed-off-by: Max Reitz --- block/quorum.c | 11 +++ 1 file

[Qemu-devel] [PATCH 07/19] qcow2: Implement bdrv_refresh_filename()

2016-04-26 Thread Max Reitz
Implement this function by invoking bdrv_default_refresh_format_filename(bs, false). None of the qcow2 runtime options change the guest-visible state of a BDS. Signed-off-by: Max Reitz --- block/qcow2.c | 8 1 file changed, 8 insertions(+) diff --git a/block/qcow2.c b/block/qcow2.c ind

[Qemu-devel] [PATCH 05/19] block: Add bdrv_default_refresh_protocol_filename

2016-04-26 Thread Max Reitz
Split off the default code for protocol BDS from bdrv_refresh_filename() into an own function, just as it has been done for format BDS. Signed-off-by: Max Reitz --- block.c | 58 +- 1 file changed, 33 insertions(+), 25 deletions(-) diff --

[Qemu-devel] [PATCH 16/19] block/nbd: Implement bdrv_dirname()

2016-04-26 Thread Max Reitz
The idea behind this implementation is that the export name might be interpreted as a path (which is the only apparent interpretation of relative filenames for NBD paths). The default implementation of bdrv_dirname() would handle that just fine for nbd+tcp, but not for nbd+unix, because in that ca

[Qemu-devel] [PATCH 13/19] block: Add bdrv_dirname()

2016-04-26 Thread Max Reitz
This function may be implemented by block drivers to derive a directory name from a BDS. Concatenating this g_free()-able string with a relative filename must result in a valid (not necessarily existing) filename, so this is a function that should generally be not implemented by format drivers, bec

[Qemu-devel] [PATCH 06/19] block: Make bdrv_default_refresh_format_filename public

2016-04-26 Thread Max Reitz
In order to allow block drivers to use that function, it needs to be public. In order to be useful, it needs to take a parameter which allows the caller to specify whether the runtime options allowed by the block driver are actually significant for the guest-visible BDS content. Signed-off-by: Max

[Qemu-devel] [PATCH 09/19] block: bdrv_get_full_backing_filename_from_...'s ret. val.

2016-04-26 Thread Max Reitz
Make bdrv_get_full_backing_filename_from_filename() return an allocated string instead of placing the result in a caller-provided buffer. Signed-off-by: Max Reitz --- block.c | 32 +++- block/vmdk.c | 8 +++- include/block/block.h | 7 +++-

[Qemu-devel] [PATCH 10/19] block: bdrv_get_full_backing_filename's ret. val.

2016-04-26 Thread Max Reitz
Make bdrv_get_full_backing_filename() return an allocated string instead of placing the result in a caller-provided buffer. Signed-off-by: Max Reitz --- block.c | 24 block/qapi.c | 12 ++-- include/block/block.h | 3 +-- 3 files changed,

[Qemu-devel] [PATCH 01/19] block: Use children list in bdrv_refresh_filename

2016-04-26 Thread Max Reitz
bdrv_refresh_filename() should invoke itself recursively on all children, not just on file. With that change, we can remove the manual invocations in blkverify and quorum. Signed-off-by: Max Reitz --- block.c | 9 + block/blkverify.c | 3 --- block/quorum.c| 1 - 3 files c

[Qemu-devel] [PATCH 00/19] block: Fix some filename generation issues

2016-04-26 Thread Max Reitz
(Fun fact: This series has been lying around on my disk since last November. I guess I forgot to send it because I still wanted to review it before sending it out, and that it what I forgot to do. Well, and now Berto noticed that we ought to fix something.) There are some issues regarding file

[Qemu-devel] [PATCH 04/19] block: Add bdrv_default_refresh_format_filename

2016-04-26 Thread Max Reitz
Split off the default code for format BDS from bdrv_refresh_filename() into an own function, first because it is nicer this way, and second because this will allow block drivers to reuse this function in their own specific implementation of bdrv_refresh_filename(). Signed-off-by: Max Reitz --- b

[Qemu-devel] [PATCH 02/19] block: Add BDS.backing_overridden

2016-04-26 Thread Max Reitz
If the backing file is overridden, this most probably does change the guest-visible data of a BDS. Therefore, we will need to consider this in bdrv_refresh_filename(). Adding a new field to the BDS is not nice, but it is very simple and exactly keeps track of whether the backing file has been over

[Qemu-devel] [PATCH 03/19] block: Respect backing bs in bdrv_refresh_filename

2016-04-26 Thread Max Reitz
Basically, bdrv_refresh_filename() should respect all children of a BlockDriverState. However, generally those children are driver-specific, so this function cannot handle the general case. On the other hand, there are only few drivers which use other children than @file and @backing (that being vm

Re: [Qemu-devel] [PATCH] usb-mtp: fix usb_mtp_get_device_info so that libmtp on the guest doesn't complain

2016-04-26 Thread Bandan Das
Stefan Hajnoczi writes: > On Sun, Apr 17, 2016 at 04:29:53AM -0700, Isaac Lozano wrote: >> If an application uses libmtp on the guest system, >> it will complain with the warning message: >> LIBMTP WARNING: VendorExtensionID: >> LIBMTP WARNING: VendorExtensionDesc: (null) >> LIBMTP WARNI

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-04-26 Thread Michael Roth
Quoting Igor Mammedov (2016-04-26 02:52:36) > On Tue, 26 Apr 2016 10:39:23 +0530 > Bharata B Rao wrote: > > > On Mon, Apr 25, 2016 at 11:20:50AM +0200, Igor Mammedov wrote: > > > On Wed, 16 Mar 2016 10:11:54 +0530 > > > Bharata B Rao wrote: > > > > > > > On Wed, Mar 16, 2016 at 12:36:05PM +11

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

2016-04-26 Thread Programmingkid
On Apr 26, 2016, at 4:12 PM, Thomas Huth wrote: > On 26.04.2016 21:25, Programmingkid wrote: >> >> On Apr 26, 2016, at 3:00 PM, Dr. David Alan Gilbert wrote: >> >>> * Programmingkid (programmingk...@gmail.com) wrote: My three guest operating systems can't load a web page. I think this is a

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

2016-04-26 Thread Thomas Huth
On 26.04.2016 21:25, Programmingkid wrote: > > On Apr 26, 2016, at 3:00 PM, Dr. David Alan Gilbert wrote: > >> * Programmingkid (programmingk...@gmail.com) wrote: >>> My three guest operating systems can't load a web page. I think this is a >>> bug with QEMU. Is there anyone who has the latest r

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

2016-04-26 Thread Programmingkid
On Apr 26, 2016, at 3:00 PM, Dr. David Alan Gilbert wrote: > * Programmingkid (programmingk...@gmail.com) wrote: >> My three guest operating systems can't load a web page. I think this is a >> bug with QEMU. Is there anyone who has the latest revision of QEMU that can >> access the web from a g

Re: [Qemu-devel] Is anyone able to load a web page from a guest operating system?

2016-04-26 Thread Dr. David Alan Gilbert
* Programmingkid (programmingk...@gmail.com) wrote: > My three guest operating systems can't load a web page. I think this is a bug > with QEMU. Is there anyone who has the latest revision of QEMU that can > access the web from a guest? Or are you experiencing the same problem? Works here. Now

Re: [Qemu-devel] [RFC for-2.7 05/11] pseries: Build device tree only at reset time

2016-04-26 Thread Thomas Huth
On 20.04.2016 04:33, David Gibson wrote: > Currently the pseries code builds a "skeleton" device tree at machine init > time, then adds a bunch of stuff to it at reset. Over time, more and more > logic has had to be moved from init to reset time, and there's really no > advantage to doing any of i

Re: [Qemu-devel] KVM Forum 2016: Call For Participation

2016-04-26 Thread Peter Maydell
On 10 March 2016 at 18:09, Paolo Bonzini wrote: > = > KVM Forum 2016: Call For Participation > August 24-26, 2016 - Westin Harbor Castle - Toronto, Canada > > (All submissions must be received before midnight May 1, 2016) > ==

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Jan Kiszka
On 2016-04-26 18:07, Radim Krčmář wrote: > 2016-04-26 17:28+0200, Jan Kiszka: >> On 2016-04-26 16:59, Radim Krčmář wrote: >>> 2016-04-26 16:24+0200, Jan Kiszka: On 2016-04-26 13:40, Peter Xu wrote: > Currently, all the interrupts will be translated into one MSI in > vtd_generate_msi_me

Re: [Qemu-devel] [RFC for-2.7 04/11] pseries: Make spapr_create_fdt_skel() get information from machine state

2016-04-26 Thread Thomas Huth
On 20.04.2016 04:33, David Gibson wrote: > Currently spapr_create_fdt_skel() takes a bunch of individual parameters > for various things it will put in the device tree. Some of these can > already be taken directly from sPAPRMachineState. This patch alters it so > that all of them can be taken fr

Re: [Qemu-devel] how to enable nvme device in Qemu?

2016-04-26 Thread Laszlo Ersek
On 04/26/16 11:18, Stefan Hajnoczi wrote: > On Tue, Apr 19, 2016 at 08:37:42AM +, Qingtao Sun wrote: >> I want to boot OS from NVMe device in qemu-2.5.1. But I didn't find >> the bootable NVMe device in guest BIOS. How to enable this feature? > > I don't see an NVMe driver so I guess

[Qemu-devel] Working on AF_VSOCK packet capture

2016-04-26 Thread Gerard
Hi all, My name is Gerard Garcia and I have been funded by GSOC16 to work on a device driver to allow capturing host/guest traffic through AF_VSOCK sockets: http://qemu-project.org/Features/VirtioVsock I'll mostly work on the Linux kernel codebase but the device driver is closely related to QEMU

Re: [Qemu-devel] [Qemu-arm] [PATCH] target-arm: Fix descriptor address masking in ARM address translation

2016-04-26 Thread Tom Hanson
On 03/21/2016 09:56 AM, Sergey Sorokin wrote: 17.03.2016, 18:24, "Peter Maydell" : On 17 March 2016 at 15:21, Sergey Sorokin wrote: 17.03.2016, 14:40, "Peter Maydell" : On 13 March 2016 at 18:28, Sergey Sorokin wrote: If you want to implement the AddressSize checks that's fine,

[Qemu-devel] Is anyone able to load a web page from a guest operating system?

2016-04-26 Thread Programmingkid
My three guest operating systems can't load a web page. I think this is a bug with QEMU. Is there anyone who has the latest revision of QEMU that can access the web from a guest? Or are you experiencing the same problem?

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Radim Krčmář
2016-04-26 17:28+0200, Jan Kiszka: > On 2016-04-26 16:59, Radim Krčmář wrote: >> 2016-04-26 16:24+0200, Jan Kiszka: >>> On 2016-04-26 13:40, Peter Xu wrote: Currently, all the interrupts will be translated into one MSI in vtd_generate_msi_message(), in which only 8 bits of dest_id is used

Re: [Qemu-devel] [PATCH for-2.7 v2 07/17] rbd: Implement image locking

2016-04-26 Thread Jason Dillaman
On Sun, Apr 24, 2016 at 7:42 PM, Fam Zheng wrote: > On Fri, 04/22 21:57, Jason Dillaman wrote: >> Since this cannot automatically recover from a crashed QEMU client with an >> RBD image, perhaps this RBD locking should not default to enabled. >> Additionally, this will conflict with the "exclusive

Re: [Qemu-devel] [RFC v3] translate-all: protect code_gen_buffer with RCU

2016-04-26 Thread Richard Henderson
On 04/25/2016 11:35 PM, Alex Bennée wrote: > > Richard Henderson writes: > >> On 04/25/2016 04:46 PM, Emilio G. Cota wrote: >>> +/* >>> + * write the prologue into buf2. This is safe because we'll later call >>> + * tcg_prologue_init on buf1, from which we'll start execution. >>> +

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Jan Kiszka
On 2016-04-26 16:59, Radim Krčmář wrote: > 2016-04-26 16:24+0200, Jan Kiszka: >> On 2016-04-26 13:40, Peter Xu wrote: >>> Currently, all the interrupts will be translated into one MSI in >>> vtd_generate_msi_message(), in which only 8 bits of dest_id is used >>> (msg.dest = irq->dest). We may possi

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Radim Krčmář
2016-04-26 16:24+0200, Jan Kiszka: > On 2016-04-26 13:40, Peter Xu wrote: >> Currently, all the interrupts will be translated into one MSI in >> vtd_generate_msi_message(), in which only 8 bits of dest_id is used >> (msg.dest = irq->dest). We may possibly need to use the high 32 bits >> of MSI addr

Re: [Qemu-devel] [patch v6 11/12] vfio: register aer resume notification handler for aer resume

2016-04-26 Thread Alex Williamson
On Tue, 26 Apr 2016 11:39:02 +0800 Chen Fan wrote: > On 04/14/2016 09:02 AM, Chen Fan wrote: > > > > On 04/12/2016 05:38 AM, Alex Williamson wrote: > >> On Tue, 5 Apr 2016 19:42:02 +0800 > >> Cao jin wrote: > >> > >>> From: Chen Fan > >>> > >>> for supporting aer recovery, host and guest wo

Re: [Qemu-devel] [PATCH] iotests: fix the redirection order in 083

2016-04-26 Thread Eric Blake
On 04/26/2016 04:13 AM, Wei Jiangang wrote: > It should redirect stdout to /dev/null first, > then redirect stderr to whatever stdout currently points at. > > Signed-off-by: Wei Jiangang > --- > tests/qemu-iotests/083 | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Eric

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Jan Kiszka
On 2016-04-26 13:40, Peter Xu wrote: > On Tue, Apr 26, 2016 at 12:51:44PM +0200, Jan Kiszka wrote: >> On 2016-04-26 12:38, Peter Xu wrote: >> Hi, Jan, >> >> The above issue should be caused by EOI missing of level-triggered >> interrupts. Before that, I was always using edge-trigger

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Radim Krčmář
2016-04-26 15:34+0800, Peter Xu: > Hi, Jan, > > The above issue should be caused by EOI missing of level-triggered > interrupts. Before that, I was always using edge-triggered > interrupts for test, so didn't encounter this one. Would you please > help try below patch? It can be applied directly o

Re: [Qemu-devel] Simultaneous vhostfds= and ifname= options

2016-04-26 Thread Michał Dubiel
Hi all, Any thoughts to share on that? Thanks, Michal On 15 April 2016 at 18:50, Michał Dubiel wrote: > Hi guys, > > Qemu does not allow currently to use vhostfds= and ifname= options of > -netdev tap... at the same time. In order to use vhostfds=, you have to > also use fds= instead. May ask

[Qemu-devel] [PATCH] PPC/KVM: early validation of vcpu id

2016-04-26 Thread Greg Kurz
The KVM API restricts vcpu ids to be < KVM_CAP_MAX_VCPUS. On PowerPC targets, depending on the number of threads per core in the host and in the guest, some topologies do generate higher vcpu ids actually. When this happens, QEMU bails out with the following error: kvm_init_vcpu failed: Invalid ar

Re: [Qemu-devel] [PATCH] hw/intc/arm_gic: add tracepoints

2016-04-26 Thread Stefan Hajnoczi
On Thu, Apr 21, 2016 at 08:24:41AM -0700, Hollis Blanchard wrote: > These are obviously critical to understanding interrupt delivery: > gic_enable_irq > gic_disable_irq > gic_set_irq (inbound irq from device models) > gic_update_set_irq (outbound irq to CPU) > gic_acknowledge_irq > > The only one

Re: [Qemu-devel] [RFC PATCH resend 00/11] Make CoMutex/CoQueue/CoRwlock thread-safe

2016-04-26 Thread Stefan Hajnoczi
On Fri, Apr 15, 2016 at 01:31:55PM +0200, Paolo Bonzini wrote: > [this time including the mailing list] > > This is yet another tiny bit of the multiqueue work, this time affecting > the synchronization infrastructure for coroutines. Currently, coroutines > synchronize between the main I/O thread

Re: [Qemu-devel] [PATCH v14 15/19] qapi-commands: Wrap argument visit in visit_start_struct

2016-04-26 Thread Eric Blake
On 04/15/2016 05:42 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The qmp-input visitor was playing rather fast and loose: when > > I guess (some of) its *users* are playing fast and loose, and the > visitor itself lets them. The patch's title suggests "some of its > users" == qapi-com

[Qemu-devel] how should a device implement an array of link(?) properties?

2016-04-26 Thread Peter Maydell
Hi; I have what seems like a fairly straightforward requirement for a QOM device but no idea how to implement it, so I'm looking for advice on the right "modern" way to do it... Specifically, this is the GICv3 device. It would like to have a pointer to every CPU object it needs to be connected to.

Re: [Qemu-devel] [PATCH] hw/net/virtio-net: Allocating Large sized arrays to heap

2016-04-26 Thread Michael S. Tsirkin
On Tue, Apr 26, 2016 at 04:05:24PM +0800, Zhou Jie wrote: > virtio_net_flush_tx has a huge stack usage of 16392 bytes approx. > Moving large arrays to heap to reduce stack usage. > > Signed-off-by: Zhou Jie I don't think it's appropriate for trivial. Also - what's the point, exactly? > --- > h

Re: [Qemu-devel] [RFC 00/13] Multiple fd migration support

2016-04-26 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> Hi > >> > >> This patch series is "an" initial implementation of multiple fd migration. > >> This is to get something out for others to comment, it is not finished

Re: [Qemu-devel] Updating documentation at http://wiki.qemu.org/download/qemu-doc.html

2016-04-26 Thread Jeff Cody
On Tue, Apr 26, 2016 at 11:02:45AM +0100, Stefan Hajnoczi wrote: > On Tue, Apr 26, 2016 at 07:50:31AM +0100, Mark Cave-Ayland wrote: > > Does anyone know if it's possible to update the documentation at the > > above URL? It appears as a link at http://wiki.qemu-project.org/Manual > > and seems to b

Re: [Qemu-devel] [Qemu-discuss] iolimits for virtio-9p

2016-04-26 Thread Alberto Garcia
On Tue 19 Apr 2016 02:09:24 PM CEST, Pradeep Kiruvale wrote: > We are planning to implement the io-limits for the virtio-9p driver > i.e for fsdev devices. > So, I am looking into the code base and how it has done for the block > io devices. > > I would like to know how difficult is this and is th

Re: [Qemu-devel] [PATCH v4 2/3] hw/arm/virt: Add PMU node for virt machine

2016-04-26 Thread Andrew Jones
On Tue, Apr 26, 2016 at 07:40:45PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Add a virtual PMU device for virt machine while use PPI 7 for PMU > overflow interrupt number. > > Signed-off-by: Shannon Zhao > --- > hw/arm/virt.c | 33 + > include/

[Qemu-devel] [PATCH v4 0/3] Add guest PMU in machine virt

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao KVM-ARM64 supports guest PMU now. This series add the support in machine virt so that guest could use PMU. The ACPI part is tested with below guest kernel patches. https://lkml.org/lkml/2016/4/12/755 Changes since v3: * if kvm_arm_pmu_create returns a failure, don't create pm

[Qemu-devel] [PATCH v4 1/3] target-arm: kvm64: set guest PMUv3 feature bit if supported

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao Check if kvm supports guest PMUv3. If so, set the corresponding feature bit for vcpu. Signed-off-by: Shannon Zhao Reviewed-by: Andrew Jones --- target-arm/cpu-qom.h | 2 ++ target-arm/kvm64.c | 5 + 2 files changed, 7 insertions(+) diff --git a/target-arm/cpu-qom.h b

[Qemu-devel] [PATCH v4 2/3] hw/arm/virt: Add PMU node for virt machine

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao Add a virtual PMU device for virt machine while use PPI 7 for PMU overflow interrupt number. Signed-off-by: Shannon Zhao --- hw/arm/virt.c | 33 + include/hw/arm/virt.h | 4 include/sysemu/kvm.h | 1 + stubs/kvm.c |

[Qemu-devel] [PATCH v4 3/3] hw/arm/virt-acpi-build: Add PMU IRQ number in ACPI table

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao Add PMU IRQ number in ACPI table, then we can use PMU in guest through ACPI. Signed-off-by: Shannon Zhao Reviewed-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c index f

Re: [Qemu-devel] [PATCH v4 00/16] IOMMU: Enable interrupt remapping for Intel IOMMU

2016-04-26 Thread Peter Xu
On Tue, Apr 26, 2016 at 12:51:44PM +0200, Jan Kiszka wrote: > On 2016-04-26 12:38, Peter Xu wrote: > Hi, Jan, > > The above issue should be caused by EOI missing of level-triggered > interrupts. Before that, I was always using edge-triggered > interrupts for test, so didn't

Re: [Qemu-devel] [PATCH v8 0/5] ARM: Add NUMA support for machine virt

2016-04-26 Thread Andrew Jones
On Tue, Apr 26, 2016 at 06:40:24PM +0800, Shannon Zhao wrote: > From: Shannon Zhao > > Add NUMA support for machine virt. Tested successfully running a guest > Linux kernel with the following patch applied: > > - [PATCH v16 0/6] arm64, numa: Add numa support for arm64 platforms > https://lkml.or

Re: [Qemu-devel] [PATCH v3 3/3] hw/arm/virt-acpi-build: Add PMU IRQ number in ACPI table

2016-04-26 Thread Andrew Jones
On Tue, Apr 26, 2016 at 07:08:25PM +0800, Shannon Zhao wrote: > > > On 2016/4/25 21:49, Shannon Zhao wrote: > > On 2016年04月25日 20:42, Andrew Jones wrote: > >> > On Mon, Apr 25, 2016 at 03:11:46PM +0800, Shannon Zhao wrote: > >> > From: Shannon Zhao > >> > > >> > Add PMU IRQ numbe

Re: [Qemu-devel] [PATCH v3 3/3] hw/arm/virt-acpi-build: Add PMU IRQ number in ACPI table

2016-04-26 Thread Shannon Zhao
On 2016/4/25 21:49, Shannon Zhao wrote: > On 2016年04月25日 20:42, Andrew Jones wrote: >> > On Mon, Apr 25, 2016 at 03:11:46PM +0800, Shannon Zhao wrote: >> > From: Shannon Zhao >> > >> > Add PMU IRQ number in ACPI table, then we can use PMU in guest through >> > ACPI. >>

[Qemu-devel] [PATCH v8 3/5] ACPI: Fix the definition of proximity in AcpiSratMemoryAffinity

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao ACPI spec says that Proximity Domain is an "Integer that represents the proximity domain to which the processor belongs". So define it as a uint32_t. Cc: Michael S. Tsirkin Cc: Igor Mammedov Signed-off-by: Shannon Zhao Reviewed-by: Andrew Jones --- hw/i386/acpi-build.c

[Qemu-devel] [PATCH v8 5/5] ACPI: Virt: Generate SRAT table

2016-04-26 Thread Shannon Zhao
From: Shannon Zhao To support NUMA, it needs to generate SRAT ACPI table. Signed-off-by: Shannon Zhao Reviewed-by: Andrew Jones --- hw/arm/virt-acpi-build.c | 52 1 file changed, 52 insertions(+) diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/

  1   2   >