Re: [Qemu-devel] [PATCH v3 12/12] i.MX: Add sabrelite i.MX6 emulation.

2016-03-15 Thread Peter Maydell
On 15 March 2016 at 21:40, Jean-Christophe DUBOIS wrote: > Well, each SPI controller has 4 possible CS lines to external devices and I > have 5 SPI controllers. > > This makes 20 externally facing IRQ lines (these are output lines) to add to > the i.MX6 soc object as properties (with a meaningful

Re: [Qemu-devel] [PATCH v3 12/13] .gitignore: Ignore temporary dockerfile

2016-03-15 Thread Fam Zheng
On Fri, 03/11 16:14, Alex Bennée wrote: > > Fam Zheng writes: > > > Docker build requires a "context" directory and we use the > > $QEMU_SRC/tests/docker/ directory, and the temoprary dockerfile has to be in > > the context. > > > > docker_build normally cleans up this file but let's add an entr

Re: [Qemu-devel] [PATCH 16/17] ppc: Add dummy CIABR SPR

2016-03-15 Thread Thomas Huth
On 16.03.2016 02:14, David Gibson wrote: > On Mon, Mar 14, 2016 at 05:56:39PM +0100, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> We should implement HW breakpoint/watchpoint, qemu supports them... >> >> Signed-off-by: Benjamin Herrenschmidt > > Reviewed-by: David Gibson > > B

Re: [Qemu-devel] [PATCH 15/17] ppc: Add dummy POWER8 MPPR register

2016-03-15 Thread Thomas Huth
On 16.03.2016 02:14, David Gibson wrote: > On Mon, Mar 14, 2016 at 05:56:38PM +0100, Cédric Le Goater wrote: >> From: Benjamin Herrenschmidt >> >> Controls the micropartition prefetch, this is pretty much meaningless >> in full emulation (used for priming the caches on real HW). >> >> Signed-off-b

Re: [Qemu-devel] [PATCH qemu] spapr/target-ppc/kvm: Only add hcall-instructions if KVM supports it

2016-03-15 Thread Thomas Huth
On 16.03.2016 03:43, Alexey Kardashevskiy wrote: > On 03/15/2016 10:32 PM, Thomas Huth wrote: >> On 15.03.2016 10:42, Alexey Kardashevskiy wrote: >>> On 03/15/2016 07:18 PM, Thomas Huth wrote: Hi Alexey, On 15.03.2016 06:51, Alexey Kardashevskiy wrote: > ePAPR defines "hc

Re: [Qemu-devel] [RFC v3 2/2] spapr: implement query-hotpluggable-cpus QMP command

2016-03-15 Thread David Gibson
On Wed, 16 Mar 2016 10:49:41 +0530 Bharata B Rao wrote: > On Tue, Mar 15, 2016 at 02:24:08PM +0100, Igor Mammedov wrote: > > it returns a list of present/possible to hotplug CPU > > objects with a list of properties to use with > > device_add. > > > > in spapr case returned list would looks like

Re: [Qemu-devel] [RFC PATCH v2 9/9] spapr: CPU hot unplug support

2016-03-15 Thread Bharata B Rao
On Wed, Mar 16, 2016 at 04:27:04PM +1100, David Gibson wrote: > On Fri, Mar 11, 2016 at 10:24:38AM +0530, Bharata B Rao wrote: > > Remove the CPU core device by removing the underlying CPU thread devices. > > Hot removal of CPU for sPAPR guests is achieved by sending the hot unplug > > notification

Re: [Qemu-devel] [RFC PATCH v2 9/9] spapr: CPU hot unplug support

2016-03-15 Thread David Gibson
On Fri, Mar 11, 2016 at 10:24:38AM +0530, Bharata B Rao wrote: > Remove the CPU core device by removing the underlying CPU thread devices. > Hot removal of CPU for sPAPR guests is achieved by sending the hot unplug > notification to the guest. Release the vCPU object after CPU hot unplug so > that

Re: [Qemu-devel] [RFC PATCH v2 7/9] spapr: CPU hotplug support

2016-03-15 Thread David Gibson
On Fri, Mar 11, 2016 at 10:24:36AM +0530, Bharata B Rao wrote: > Set up device tree entries for the hotplugged CPU core and use the > exising RTAS event logging infrastructure to send CPU hotplug notification > to the guest. > > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr.c

Re: [Qemu-devel] [PATCH 5/8] virtio-blk: fix "disabled data plane" mode

2016-03-15 Thread tu bo
On 03/15/2016 08:45 PM, Fam Zheng wrote: On Fri, 03/11 11:28, Paolo Bonzini wrote: On 10/03/2016 10:40, Christian Borntraeger wrote: On 03/10/2016 10:03 AM, Christian Borntraeger wrote: On 03/10/2016 02:51 AM, Fam Zheng wrote: [...] The aio_poll() inside "blk_set_aio_context(s->conf->conf

Re: [Qemu-devel] [RFC v3 2/2] spapr: implement query-hotpluggable-cpus QMP command

2016-03-15 Thread Bharata B Rao
On Tue, Mar 15, 2016 at 02:24:08PM +0100, Igor Mammedov wrote: > it returns a list of present/possible to hotplug CPU > objects with a list of properties to use with > device_add. > > in spapr case returned list would looks like: > -> { "execute": "query-hotpluggable-cpus" } > <- {"return": [ >

[Qemu-devel] [PULL 12/16] spapr_pci: Eliminate class callbacks

2016-03-15 Thread David Gibson
The EEH operations in the spapr-vfio-pci-host-bridge no longer rely on the special groupid field in sPAPRPHBVFIOState. So we can simplify, removing the class specific callbacks with direct calls based on a simple spapr_phb_eeh_enabled() helper. For now we implement that in terms of a boolean in t

[Qemu-devel] [PULL 06/16] target-ppc: Split out SREGS get/put functions

2016-03-15 Thread David Gibson
Currently the getting and setting of Power MMU registers (sregs) take up large inline chunks of the kvm_arch_get_registers() and kvm_arch_put_registers() functions. Especially since there are two variants (for Book-E and Book-S CPUs), only one of which will be used in practice, this is pretty hard

[Qemu-devel] [PULL 13/16] spapr_pci: Allow EEH on spapr-pci-host-bridge

2016-03-15 Thread David Gibson
Now that the EEH code is independent of the special spapr-vfio-pci-host-bridge device, we can allow it on all spapr PCI host bridges instead. We do this by changing spapr_phb_eeh_available() to be based on the vfio_eeh_as_ok() call instead of the host bridge class. Because the value of vfio_eeh_a

[Qemu-devel] [PULL 01/16] ppc: Define the PSPB register on POWER8

2016-03-15 Thread David Gibson
From: Thomas Huth POWER8 / PowerISA 2.07 has a new special purpose register called PSPB ("Problem State Priority Boost Register"). The contents of this register are currently lost during migration. To be able to migrate this register, too, we've got to define this SPR along with the other SPRs of

[Qemu-devel] [PULL 05/16] spapr_pci: fix multifunction hotplug

2016-03-15 Thread David Gibson
From: Michael Roth Since 3f1e147, QEMU has adopted a convention of supporting function hotplug by deferring hotplug events until func 0 is hotplugged. This is likely how management tools like libvirt would expose such support going forward. Since sPAPR guests rely on per-func events rather than

[Qemu-devel] [PULL 14/16] spapr_pci: (Mostly) remove spapr-pci-vfio-host-bridge

2016-03-15 Thread David Gibson
Now that the regular spapr-pci-host-bridge can handle EEH, there are only two things that spapr-pci-vfio-host-bridge does differently: 1. automatically sizes its DMA window to match the host IOMMU 2. checks if the attached VFIO container is backed by the VFIO_SPAPR_TCE_IOMMU type on

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-03-15 Thread David Gibson
On Wed, Mar 16, 2016 at 10:11:54AM +0530, Bharata B Rao wrote: > On Wed, Mar 16, 2016 at 12:36:05PM +1100, David Gibson wrote: > > On Tue, Mar 15, 2016 at 10:08:56AM +0530, Bharata B Rao wrote: > > > Add support to hot remove pc-dimm memory devices. > > > > > > Signed-off-by: Bharata B Rao > > >

[Qemu-devel] [PULL 08/16] target-ppc: Eliminate kvmppc_kern_htab global

2016-03-15 Thread David Gibson
fa48b43 "target-ppc: Remove hack for ppc_hash64_load_hpte*() with HV KVM" purports to remove a hack in the handling of hash page tables (HPTs) managed by KVM instead of qemu. However, it actually went in the wrong direction. That patch requires anything looking for an external HPT (that is one no

[Qemu-devel] [PULL 04/16] target-ppc: Add PVR for POWER8NVL processor

2016-03-15 Thread David Gibson
From: Alexey Kardashevskiy This adds a new POWER8+NVLink CPU PVR which core is identical to POWER8 but has a different PVR. The only available machine now has PVR pvr 004c 0100 so this defines "POWER8NVL" alias as v1.0. The corresponding kernel commit is https://github.com/torvalds/linux/commit/

[Qemu-devel] [PULL 00/16] ppc-for-2.6 queue 20160316

2016-03-15 Thread David Gibson
The following changes since commit a6cdb77f816961f929d7934643febd2852230135: Merge remote-tracking branch 'remotes/thibault/tags/samuel-thibault' into staging (2016-03-15 17:09:52 +) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.6-20160316 for

[Qemu-devel] [PULL 03/16] ppc: Add a few more P8 PMU SPRs

2016-03-15 Thread David Gibson
From: Benjamin Herrenschmidt Signed-off-by: Benjamin Herrenschmidt Signed-off-by: David Gibson --- target-ppc/cpu.h| 7 +++ target-ppc/translate_init.c | 28 2 files changed, 35 insertions(+) diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h index

[Qemu-devel] [PULL 07/16] target-ppc: Add helpers for updating a CPU's SDR1 and external HPT

2016-03-15 Thread David Gibson
When a Power cpu with 64-bit hash MMU has it's hash page table (HPT) pointer updated by a write to the SDR1 register we need to update some derived variables. Likewise, when the cpu is configured for an external HPT (one not in the guest memory space) some derived variables need to be updated. Cu

[Qemu-devel] [PULL 10/16] vfio: Start improving VFIO/EEH interface

2016-03-15 Thread David Gibson
At present the code handling IBM's Enhanced Error Handling (EEH) interface on VFIO devices operates by bypassing the usual VFIO logic with vfio_container_ioctl(). That's a poorly designed interface with unclear semantics about exactly what can be operated on. In particular it operates on a single

[Qemu-devel] [PULL 16/16] vfio: Eliminate vfio_container_ioctl()

2016-03-15 Thread David Gibson
vfio_container_ioctl() was a bad interface that bypassed abstraction boundaries, had semantics that sat uneasily with its name, and was unsafe in many realistic circumstances. Now that spapr-pci-vfio-host-bridge has been folded into spapr-pci-host-bridge, there are no more users, so remove it. Si

[Qemu-devel] [PULL 09/16] spapr_rng: fix race with main loop

2016-03-15 Thread David Gibson
From: Greg Kurz Since commit "60253ed1e6ec rng: add request queue support to rng-random", the use of a spapr_rng device may hang vCPU threads. The following path is taken without holding the lock to the main loop mutex: h_random() rng_backend_request_entropy() rng_random_request_entropy()

[Qemu-devel] [PULL 15/16] spapr_pci: Remove finish_realize hook

2016-03-15 Thread David Gibson
Now that spapr-pci-vfio-host-bridge is reduced to just a stub, there is only one implementation of the finish_realize hook in sPAPRPHBClass. So, we can fold that implementation into its (single) caller, and remove the hook. That's the last thing left in sPAPRPHBClass, so that can go away as well.

[Qemu-devel] [PULL 02/16] ppc: Fix migration of the TAR SPR

2016-03-15 Thread David Gibson
From: Thomas Huth The TAR special purpose register currently does not get migrated under KVM because it does not get synchronized with the kernel. Use spr_register_kvm() instead of spr_register() to fix this issue. Signed-off-by: Thomas Huth Signed-off-by: David Gibson --- target-ppc/translat

[Qemu-devel] [PULL 11/16] spapr_pci: Switch to vfio_eeh_as_op() interface

2016-03-15 Thread David Gibson
This switches all EEH on VFIO operations in spapr_pci_vfio.c from the broken vfio_container_ioctl() interface to the new vfio_as_eeh_op() interface. Signed-off-by: David Gibson Reviewed-by: Alexey Kardashevskiy --- hw/ppc/spapr_pci_vfio.c | 50 -

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-03-15 Thread Bharata B Rao
On Wed, Mar 16, 2016 at 12:36:05PM +1100, David Gibson wrote: > On Tue, Mar 15, 2016 at 10:08:56AM +0530, Bharata B Rao wrote: > > Add support to hot remove pc-dimm memory devices. > > > > Signed-off-by: Bharata B Rao > > Reviewed-by: David Gibson > > Looks correct, but again, needs to wait on

Re: [Qemu-devel] [PATCH V2] net/filter-mirror: Change filter_mirror_send interface

2016-03-15 Thread Jason Wang
On 03/15/2016 06:02 PM, Zhang Chen wrote: > Change filter_mirror_send interface to make it easier > to used by other filter > > Signed-off-by: Zhang Chen > Signed-off-by: Wen Congyang > Signed-off-by: Li Zhijian > --- > net/filter-mirror.c | 10 +- > 1 file changed, 5 insertions(+), 5

Re: [Qemu-devel] [PATCH V10 0/2] net/filter-mirror:add filter-mirror and unit test

2016-03-15 Thread Jason Wang
On 03/15/2016 03:41 PM, Zhang Chen wrote: > Filter-mirror is a netfilter plugin. > It gives qemu the ability to mirror > packets to a chardev. > > v10: > - add include "qemu/osdep.h" > > v9: > - add qmp("{ 'execute' : 'query-status'}") >before iov_send() and change pipe >to socket in te

Re: [Qemu-devel] [PATCH v3] block/gluster: add support for SEEK_DATA/SEEK_HOLE

2016-03-15 Thread Niels de Vos
On Tue, Mar 15, 2016 at 03:52:02PM -0400, Jeff Cody wrote: > On Tue, Mar 15, 2016 at 03:50:17PM -0400, Jeff Cody wrote: > > On Thu, Mar 10, 2016 at 07:38:00PM +0100, Niels de Vos wrote: > > > GlusterFS 3.8 contains support for SEEK_DATA and SEEK_HOLE. This makes > > > it possible to detect sparse a

Re: [Qemu-devel] [PATCH v3 00/13] tests: Introducing docker tests

2016-03-15 Thread Fam Zheng
On Fri, 03/11 16:16, Alex Bennée wrote: > > Fam Zheng writes: > > > v3 changes: > > I think we are almost there. There a just a few tweaks to be made to > help text and prompts. Can you ensure that all examples in commit > messages and help text actually do run as expected? OK, I'm fixing thes

Re: [Qemu-devel] [PATCH v3 10/13] docker: Add travis tool

2016-03-15 Thread Fam Zheng
On Fri, 03/11 16:14, Alex Bennée wrote: > > Fam Zheng writes: > > > The script is not named test-travis.sh so it won't run with "make > > docker-run", because it can take too long. > > > > Run it with "make docker-run-travis.sh@ubuntu". > > 16:08 alex@zen/x86_64 [qemu.git/review/docker-v3] >ma

Re: [Qemu-devel] [RFC PATCH v2 0/9] Core based CPU hotplug for PowerPC sPAPR

2016-03-15 Thread Bharata B Rao
On Mon, Mar 14, 2016 at 10:47:28AM +0100, Igor Mammedov wrote: > On Fri, 11 Mar 2016 10:24:29 +0530 > Bharata B Rao wrote: > > > Hi, > > > > This is the next version of "Core based CPU hotplug for PowerPC sPAPR" that > > was posted at > > https://lists.gnu.org/archive/html/qemu-ppc/2016-03/msg00

Re: [Qemu-devel] [PATCH v3 07/13] docker: Add full test

2016-03-15 Thread Fam Zheng
On Fri, 03/11 16:10, Alex Bennée wrote: > > Fam Zheng writes: > > > This builds all available targets. > > > > Signed-off-by: Fam Zheng > > --- > > tests/docker/test-full | 17 + > > 1 file changed, 17 insertions(+) > > create mode 100755 tests/docker/test-full > > > > diff --

Re: [Qemu-devel] [PATCH v3 05/13] docker: Add common.rc

2016-03-15 Thread Fam Zheng
On Fri, 03/11 16:06, Alex Bennée wrote: > > Fam Zheng writes: > > > "requires" checks the "FEATURE" environment for specified prerequisits, > > and skip the execution of test if not found. > > You also add a build_qemu function which you should mention. Will mention it. Thanks, Fam > > Othe

Re: [Qemu-devel] [PATCH v3 02/13] Makefile: Rules for docker testing

2016-03-15 Thread Fam Zheng
On Fri, 03/11 15:11, Alex Bennée wrote: > > Fam Zheng writes: > > > This adds a group of make targets to run docker tests, all are available > > in source tree without running ./configure. > > > > The usage is shown by "make docker". > > > > Besides the fixed ones, dynamic targets for building e

Re: [Qemu-devel] [PATCH v3 01/13] tests: Add utilities for docker testing

2016-03-15 Thread Fam Zheng
On Fri, 03/11 15:04, Alex Bennée wrote: > > Fam Zheng writes: > > > docker_run: A wrapper for "docker run" (or "sudo -n docker run" if > > necessary), which takes care of killing and removing the running > > container at SIGINT. > > > > docker_clean: A tool to tear down all the containers includ

Re: [Qemu-devel] [ Patch 1/2] virtio-net rsc: support coalescing ipv4 tcp traffic

2016-03-15 Thread Wei Xu
- Original Message - From: "Michael S. Tsirkin" To: w...@redhat.com Cc: vict...@redhat.com, jasow...@redhat.com, yvuge...@redhat.com, qemu-devel@nongnu.org, mar...@redhat.com, dfley...@redhat.com Sent: Tuesday, March 15, 2016 6:00:03 PM Subject: Re: [Qemu-devel] [ Patch 1/2] virtio-net

Re: [Qemu-devel] [ Patch 0/2] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

2016-03-15 Thread Wei Xu
- Original Message - From: "Michael S. Tsirkin" To: w...@redhat.com Cc: vict...@redhat.com, jasow...@redhat.com, yvuge...@redhat.com, qemu-devel@nongnu.org, mar...@redhat.com, dfley...@redhat.com Sent: Tuesday, March 15, 2016 6:01:12 PM Subject: Re: [Qemu-devel] [ Patch 0/2] Support Rec

Re: [Qemu-devel] [RFC PATCH v2 1/2] spapr: Add DRC count indexed hotplug identifier type

2016-03-15 Thread David Gibson
On Tue, Mar 15, 2016 at 10:08:55AM +0530, Bharata B Rao wrote: > Add support for DRC count indexed hotplug ID type which is primarily > needed for memory hot unplug. This type allows for specifying the > number of DRs that should be plugged/unplugged starting from a given > DRC index. > > NOTE: Th

Re: [Qemu-devel] [RFC PATCH v2 2/2] spapr: Memory hot-unplug support

2016-03-15 Thread David Gibson
On Tue, Mar 15, 2016 at 10:08:56AM +0530, Bharata B Rao wrote: > Add support to hot remove pc-dimm memory devices. > > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson Looks correct, but again, needs to wait on the PAPR change. Have you thought any further on the idea of sending an inde

[Qemu-devel] [PATCH v5 1/4] hw/timer: Add ASPEED timer device model

2016-03-15 Thread Andrew Jeffery
Implement basic ASPEED timer functionality for the AST2400 SoC[1]: Up to 8 timers can independently be configured, enabled, reset and disabled. Some hardware features are not implemented, namely clock value matching and pulse generation, but the implementation is enough to boot the Linux kernel con

[Qemu-devel] [PATCH v5 4/4] hw/arm: Add palmetto-bmc machine

2016-03-15 Thread Andrew Jeffery
The new machine is a thin layer over the AST2400 ARM926-based SoC[1]. Between the minimal machine and the current SoC implementation there is enough functionality to boot an aspeed_defconfig Linux kernel to userspace. Nothing yet is specific to the Palmetto's BMC (other than using an AST2400 SoC),

[Qemu-devel] [PATCH v5 0/4] Add ASPEED AST2400 SoC and Palmetto BMC machine

2016-03-15 Thread Andrew Jeffery
This patch series models enough of the ASPEED AST2400 ARM9 SoC[0] to boot an aspeed_defconfig Linux kernel[1][2]. Specifically, the series implements the ASPEED timer and VIC devices, integrates them into an AST2400 SoC and exposes it all through a new palmetto-bmc machine. The device model patches

[Qemu-devel] [PATCH v5 3/4] hw/arm: Add ASPEED AST2400 SoC model

2016-03-15 Thread Andrew Jeffery
While the ASPEED AST2400 SoC[1] has a broad range of capabilities this implementation is minimal, comprising an ARM926 processor, ASPEED VIC and timer devices, and a 8250 UART. [1] http://www.aspeedtech.com/products.php?fPath=20&rId=376 Signed-off-by: Andrew Jeffery --- Since v3: * Split the

[Qemu-devel] [PATCH v5 2/4] hw/intc: Add (new) ASPEED VIC device model

2016-03-15 Thread Andrew Jeffery
Implement a basic ASPEED VIC device model for the AST2400 SoC[1], with enough functionality to boot an aspeed_defconfig Linux kernel. The model implements the 'new' (revised) register set: While the hardware exposes both the new and legacy register sets, accesses to the model's legacy register set

Re: [Qemu-devel] [PATCH qemu] spapr/target-ppc/kvm: Only add hcall-instructions if KVM supports it

2016-03-15 Thread Alexey Kardashevskiy
On 03/15/2016 10:32 PM, Thomas Huth wrote: On 15.03.2016 10:42, Alexey Kardashevskiy wrote: On 03/15/2016 07:18 PM, Thomas Huth wrote: Hi Alexey, On 15.03.2016 06:51, Alexey Kardashevskiy wrote: ePAPR defines "hcall-instructions" device-tree property which contains code to call hypercalls

Re: [Qemu-devel] [PATCH 0/9] some QOM'ify work under hw/arm

2016-03-15 Thread zxq_yx_007
At 2016-03-07 15:05:41, "xiaoqiang zhao" wrote: >This patch set trying to QOM'ify code under hw/arm directory. >As previous patches to hw/timer/*, we use instance_init instead of >the SysBus's init function. > > >xiaoqiang zhao (9): > hw/arm: QOM'ify armv7m.c > hw/arm: QOM'ify highbank.c > hw

Re: [Qemu-devel] [PATCH v5 0/8] QOM'ify hw/timer/*

2016-03-15 Thread hitmoon
在 2016年03月03日 14:31, hitmoon 写道: On 25 February 2016 at 10:30, xiaoqiang zhao wrote: This patch series QOM'ify timer code under hw/timer directory. Main idea is to split the initfn's work, some to TypeInfo.instance_init and some is placed in DeviceClass::realize. Drop the use of SysBusDeviceC

Re: [Qemu-devel] [PATCH] sd: Fix "info qtree" on boards with SD cards

2016-03-15 Thread hitmoon
在 2016年03月16日 00:56, Peter Maydell 写道: The SD card object is not a SysBusDevice, so don't create it with qdev_create() if we're not assigning it to a specific bus; use object_new() instead. This was causing 'info qtree' to segfault on boards with SD cards, because qdev_create(NULL, TYPE_FOO) p

Re: [Qemu-devel] [Qemu-arm] [PATCH] sd: Fix "info qtree" on boards with SD cards

2016-03-15 Thread Thomas Hanson
The patch looks good. Would it also be good to update bus_add_child() so that it NULL-checks its "bus" parameter before dereferencing it? -Tom On 15 March 2016 at 10:56, Peter Maydell wrote: > The SD card object is not a SysBusDevice, so don't create it with > qdev_create() if we're not assigni

Re: [Qemu-devel] [PATCH v12 2/3] quorum: implement bdrv_add_child() and bdrv_del_child()

2016-03-15 Thread Wen Congyang
On 03/11/2016 08:21 PM, Alberto Garcia wrote: > On Thu 10 Mar 2016 03:49:40 AM CET, Changlong Xie wrote: >> @@ -81,6 +82,8 @@ typedef struct BDRVQuorumState { >> bool rewrite_corrupted;/* true if the driver must rewrite-on-read >> corrupted >> * block if Quorum is

Re: [Qemu-devel] [PATCH 15/17] ppc: Add dummy POWER8 MPPR register

2016-03-15 Thread David Gibson
On Mon, Mar 14, 2016 at 05:56:38PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Controls the micropartition prefetch, this is pretty much meaningless > in full emulation (used for priming the caches on real HW). > > Signed-off-by: Benjamin Herrenschmidt So, this is readabl

Re: [Qemu-devel] [RFC qemu 0/4] A PV solution for live migration optimization

2016-03-15 Thread Li, Liang Z
> > > > > > I'm just catching back up on this thread; so without > > > > > > reference to any particular previous mail in the thread. > > > > > > > > > > > > 1) How many of the free pages do we tell the host about? > > > > > > Your main change is telling the host about all the > > > > > >

Re: [Qemu-devel] [PATCH 03/17] ppc: Add a bunch of hypervisor SPRs to Book3s

2016-03-15 Thread David Gibson
On Tue, Mar 15, 2016 at 11:49:31AM +0100, Thomas Huth wrote: > On 15.03.2016 10:43, David Gibson wrote: > > > > On Mon, Mar 14, 2016 at 08:14:59PM +0100, Thomas Huth wrote: > >> On 14.03.2016 17:56, Cédric Le Goater wrote: > >>> From: Benjamin Herrenschmidt > >>> > >>> We don't give them a KVM re

Re: [Qemu-devel] [PATCH 16/17] ppc: Add dummy CIABR SPR

2016-03-15 Thread David Gibson
On Mon, Mar 14, 2016 at 05:56:39PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > We should implement HW breakpoint/watchpoint, qemu supports them... > > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson But I'm assuming 2.7, not 2.6. > --- > target-ppc/cpu

Re: [Qemu-devel] [PATCH 11/17] ppc: Initialize AMOR in PAPR mode

2016-03-15 Thread David Gibson
On Mon, Mar 14, 2016 at 05:56:34PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Make sure we give the guest full authorization > > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson I'm guessing this one is a fix that belongs in 2.6, but I'm not entirely cer

Re: [Qemu-devel] [PATCH 14/17] ppc: Add dummy write to VTB

2016-03-15 Thread David Gibson
On Mon, Mar 14, 2016 at 05:56:37PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > The Hypervisor can write it. We don't handle that properly yet but > at least let's not blow up when it is written. > > Signed-off-by: Benjamin Herrenschmidt AFAICT this should be for 2.7, not

Re: [Qemu-devel] [PATCH 07/17] ppc: Better figure out if processor has HV mode

2016-03-15 Thread David Gibson
On Mon, Mar 14, 2016 at 05:56:30PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > We use an env. flag which is set to the initial value of MSR_HVB in > the msr_mask. We also adjust the POWER8 mask to set SHV. > > Also use this to adjust ctx.hv so that it is *set* when the proc

Re: [Qemu-devel] [PATCH 17/17] ppc: A couple more dummy POWER8 Book4 regs

2016-03-15 Thread David Gibson
On Mon, Mar 14, 2016 at 05:56:40PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Signed-off-by: Benjamin Herrenschmidt > [clg: squashed in patch 'ppc: Add dummy ACOP SPR' ] > Signed-off-by: Cédric Le Goater Reviewed-by: David Gibson And this looks like a fix for 2.6 to me

Re: [Qemu-devel] [PATCH 10/17] ppc: Add dummy SPR_IC for POWER8

2016-03-15 Thread David Gibson
On Mon, Mar 14, 2016 at 05:56:33PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > It's supposed to be an instruction counter. For now make us not > crash when accessing it. > > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson But expecting this is for 2.7, n

Re: [Qemu-devel] [PATCH 00/17] ppc: preparing pnv landing

2016-03-15 Thread David Gibson
On Tue, Mar 15, 2016 at 09:11:31AM +0100, Cédric Le Goater wrote: > On 03/15/2016 01:39 AM, David Gibson wrote: > > On Mon, Mar 14, 2016 at 05:56:23PM +0100, Cédric Le Goater wrote: > >> Hello, > >> > >> This is a first mini-serie of patches adding support for new ppc SPRs. > >> They were taken fro

Re: [Qemu-devel] [PATCH 09/17] ppc: SPURR & PURR are HV writeable and privileged

2016-03-15 Thread David Gibson
On Mon, Mar 14, 2016 at 08:37:59PM +0100, Thomas Huth wrote: > On 14.03.2016 17:56, Cédric Le Goater wrote: > > From: Benjamin Herrenschmidt > > > > Those are HV writeable, so we provide a dummy write. We eventually need > > to provide a better emulation but for now this will get us going. > > >

Re: [Qemu-devel] [PATCH 08/17] ppc: Add placeholder SPRs for DPDES and DHDES on P8

2016-03-15 Thread David Gibson
On Mon, Mar 14, 2016 at 05:56:31PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > We still need to eventually implement doorbells but at least this > makes us not crash when the SPRs are accessed. > > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson But expe

Re: [Qemu-devel] [PATCH 09/17] ppc: SPURR & PURR are HV writeable and privileged

2016-03-15 Thread David Gibson
On Mon, Mar 14, 2016 at 05:56:32PM +0100, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > Those are HV writeable, so we provide a dummy write. We eventually need > to provide a better emulation but for now this will get us going. > > We also make them non-user readable as per the arch

Re: [Qemu-devel] [PATCH 04/17] ppc: Add number of threads per core to the processor definition

2016-03-15 Thread David Gibson
On Wed, Mar 16, 2016 at 08:11:48AM +1100, Benjamin Herrenschmidt wrote: > On Tue, 2016-03-15 at 20:45 +1100, David Gibson wrote: > > On Mon, Mar 14, 2016 at 05:56:27PM +0100, Cédric Le Goater wrote: > > > > > > From: Benjamin Herrenschmidt > > > > > > Also use it to clamp the max SMT mode and en

Re: [Qemu-devel] [PATCH qemu] vmstate: Define VARRAY with VMS_ALLOC

2016-03-15 Thread David Gibson
On Tue, Mar 15, 2016 at 12:01:04PM +, Dr. David Alan Gilbert wrote: > * Alexey Kardashevskiy (a...@ozlabs.ru) wrote: > > This allows dynamic allocation for migrating arrays. > > > > Already existing VMSTATE_VARRAY_UINT32 requires an array to be > > pre-allocated, however there are cases when t

Re: [Qemu-devel] [PATCH 0/3] target-ppc improvements

2016-03-15 Thread David Gibson
On Tue, Feb 23, 2016 at 05:18:33PM -0800, Richard Henderson wrote: > The ISEL patch was posted last year; I don't believe I ever > got around to posting these other two. I'm not entirely clear if these are just cleanups / optimizations, or if they also fix actual bugs. If the former, I'm inclined

[Qemu-devel] [PATCH] mac_newworld.c: add USB keyboard and mouse as default

2016-03-15 Thread Programmingkid
Add the USB keyboard and mouse by default to the mac99 target. This more closely represents what a real PowerMac3,1 would be using. Signed-off-by: John Arbuckle --- The USB keyboard and mouse work better than their ADB counterparts. I can right click on a Mac OS X guest with a USB mouse. The Key

Re: [Qemu-devel] [RFC PATCH v2 6/9] spapr: CPU core device

2016-03-15 Thread David Gibson
On Tue, Mar 15, 2016 at 02:46:37PM +0100, Igor Mammedov wrote: > On Tue, 15 Mar 2016 20:34:28 +1100 > David Gibson wrote: > > On Tue, Mar 15, 2016 at 02:44:01PM +0530, Bharata B Rao wrote: > > > On Mon, Mar 14, 2016 at 11:25:23AM +0100, Igor Mammedov wrote: > > > > On Fri, 11 Mar 2016 10:24:35 +

Re: [Qemu-devel] [PATCH v2 4/5] spapr: check if cpu core is already present

2016-03-15 Thread David Gibson
On Tue, Mar 15, 2016 at 12:05:06PM +0100, Igor Mammedov wrote: > On Tue, 15 Mar 2016 17:10:27 +1100 > David Gibson wrote: > > > On Thu, Mar 10, 2016 at 11:39:46AM +0100, Igor Mammedov wrote: > > > On Thu, 10 Mar 2016 11:32:44 +0530 > > > Bharata B Rao wrote: > > > > > > > On Thu, Mar 10, 2016

Re: [Qemu-devel] [PATCH 5/8] virtio-blk: fix "disabled data plane" mode

2016-03-15 Thread Fam Zheng
On Tue, 03/15 15:08, Paolo Bonzini wrote: > > > On 15/03/2016 14:18, Cornelia Huck wrote: > > On Tue, 15 Mar 2016 20:45:30 +0800 > > Fam Zheng wrote: > > > >> On Fri, 03/11 11:28, Paolo Bonzini wrote: > > > >>> But secondarily, I'm thinking of making the logic simpler to understand > >>> in t

Re: [Qemu-devel] [PATCH v4 0/4] Add ASPEED AST2400 SoC and OpenPower BMC machine

2016-03-15 Thread Andrew Jeffery
On Tue, 2016-03-15 at 11:25 +0100, Cédric Le Goater wrote: > On 03/15/2016 06:01 AM, Andrew Jeffery wrote: > > On Tue, 2016-03-15 at 12:34 +0800, Jeremy Kerr wrote: > > > Hi Andrew, > > > > > > > This patch series models enough of the ASPEED AST2400 ARM9 SoC[0] to > > > > boot an aspeed_defconfig

Re: [Qemu-devel] [PATCH v4 1/4] hw/timer: Add ASPEED timer device model

2016-03-15 Thread Andrew Jeffery
On Tue, 2016-03-15 at 14:14 +0100, Cédric Le Goater wrote: > On 03/14/2016 05:13 AM, Andrew Jeffery wrote: > > Implement basic ASPEED timer functionality for the AST2400 SoC[1]: Up to > > 8 timers can independently be configured, enabled, reset and disabled. > > Some hardware features are not imple

Re: [Qemu-devel] [PATCH v4 1/4] hw/timer: Add ASPEED timer device model

2016-03-15 Thread Andrew Jeffery
Hi Dmitry, On Tue, 2016-03-15 at 21:14 +0300, Dmitry Osipenko wrote: > Hello Andrew, > > 14.03.2016 07:13, Andrew Jeffery пишет: > > Implement basic ASPEED timer functionality for the AST2400 SoC[1]: Up to > > 8 timers can independently be configured, enabled, reset and disabled. > > Some hardwar

Re: [Qemu-devel] [PATCH v3 12/12] i.MX: Add sabrelite i.MX6 emulation.

2016-03-15 Thread Jean-Christophe DUBOIS
Le 11/03/2016 00:57, Peter Maydell a écrit : On 11 March 2016 at 02:24, Jean-Christophe DUBOIS wrote: Le 10/03/2016 11:38, Peter Maydell a écrit : On 2 March 2016 at 05:27, Jean-Christophe Dubois wrote: The sabrelite supports one SPI FLASH memory on SPI1 Signed-off-by: Jean-Christophe Duboi

[Qemu-devel] [PULL] acpi-test: update UID for GSI links

2016-03-15 Thread Michael S. Tsirkin
Update acpi test data to match commit 6a991e07bb8eeb7d7799a949c0528dffb84b2a98 ("hw/acpi: fix GSI links UID"). Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/q35/DSDT| Bin 8349 -> 8357 bytes tests/acpi-test-data/q35/DSDT.bridge | Bin 8366 -> 8374 bytes 2 files changed, 0 in

[Qemu-devel] [PULL] acpi: minor fix

2016-03-15 Thread Michael S. Tsirkin
The following changes since commit 6a991e07bb8eeb7d7799a949c0528dffb84b2a98: hw/acpi: fix GSI links UID (2016-03-15 16:16:57 +0200) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstream for you to fetch changes up to 3ba6a710e6ca1fb52cf

Re: [Qemu-devel] [PATCH 04/17] ppc: Add number of threads per core to the processor definition

2016-03-15 Thread Benjamin Herrenschmidt
On Tue, 2016-03-15 at 20:45 +1100, David Gibson wrote: > On Mon, Mar 14, 2016 at 05:56:27PM +0100, Cédric Le Goater wrote: > > > > From: Benjamin Herrenschmidt > > > > Also use it to clamp the max SMT mode and ensure that the cpu_dt_id > > are offset by that value in order to preserve consistenc

Re: [Qemu-devel] [PULL 00/11] slirp: Adding IPv6 support to Qemu -net user mode

2016-03-15 Thread Jan Kiszka
On 2016-03-15 18:55, Peter Maydell wrote: > On 15 March 2016 at 16:11, Samuel Thibault > wrote: >> The following changes since commit 618a5a8bc52ba0f2ecbb3dffd01e657f4d841f75: >> >> Merge remote-tracking branch 'remotes/stefanha/tags/tracing-pull-request' >> into staging (2016-03-14 16:22:17 +

Re: [Qemu-devel] [Qemu-arm] [PATCH] sd: Fix "info qtree" on boards with SD cards

2016-03-15 Thread Peter Maydell
On 15 March 2016 at 20:33, Peter Maydell wrote: > On 15 March 2016 at 20:28, Thomas Hanson wrote: >> The patch looks good. >> >> Would it also be good to update bus_add_child() so that it NULL-checks >> its "bus" parameter before dereferencing it? > > No, I think it's just a programming error to

Re: [Qemu-devel] [patch v3 7/9] vfio: vote the function 0 to do host bus reset when aer occurred

2016-03-15 Thread Alex Williamson
On Tue, 15 Mar 2016 09:35:47 +0800 Cao jin wrote: > From: Chen Fan > > Signed-off-by: Chen Fan > --- > hw/pci/pci.c | 2 ++ > hw/vfio/pci.c| 14 ++ > hw/vfio/pci.h| 1 + > include/hw/pci/pci_bus.h | 2 ++ > 4 files changed, 19 insertions(+) >

Re: [Qemu-devel] [Qemu-arm] [PATCH] sd: Fix "info qtree" on boards with SD cards

2016-03-15 Thread Peter Maydell
On 15 March 2016 at 20:28, Thomas Hanson wrote: > The patch looks good. > > Would it also be good to update bus_add_child() so that it NULL-checks > its "bus" parameter before dereferencing it? No, I think it's just a programming error to call qdev_set_parent_bus() with a NULL bus parameter, so c

Re: [Qemu-devel] [PATCH 01/22] block: Add two dirty bitmap getters

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
On 15.03.2016 23:04, Vladimir Sementsov-Ogievskiy wrote: From: Fam Zheng For dirty bitmap users to get the size and the name of a BdrvDirtyBitmap. Signed-off-by: Fam Zheng Reviewed-by: John Snow Signed-off-by: Vladimir Sementsov-Ogievskiy it's an accidental s.o.b., actually there are no c

[Qemu-devel] [PATCH 22/22] qcow2-dirty-bitmap: add EXTRA_DATA_COMPATIBLE flag

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
If this flag is unset and exta data present the bitmap should be read-only. For now just return error for this case. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 8 1 file changed, 8 insertions(+) diff --git a/block/qcow2-dirty-bitmap.c b/block/qcow2-dir

[Qemu-devel] [PATCH 19/22] iotests: add VM.test_launcn()

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
Test vm can launch and print output in case of fail. This function is needed for testing erroneous cases Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 20 1 file changed, 20 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/q

[Qemu-devel] [PATCH 21/22] qcow2-dirty-bitmap: add AUTO flag

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
The bitmap should be auto-loaded if auto flag is set. For now, actually, there are no methods to set it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/block/qcow2-dirty-bitmap.c b/block

[Qemu-devel] [PATCH 16/22] qemu: command line option for dirty bitmaps

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
The patch adds the following command line option: -dirty-bitmap [option1=val1][,option2=val2]... Avaliable options are: name The name of the bitmap. Should be unique per 'file'/'node' and per 'for_node'. node The node to load and bind the bitmap. It should be specified as 'id' suboption of one

[Qemu-devel] [PATCH 17/22] qcow2-dirty-bitmap: add IN_USE flag

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
This flag is set on bitmap load and unset on store. If it is already set when loading the bitmap, the bitmap should not be load (it is in use by other drive or it is inconsistent (was not successfully saved)) Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 45 +++

[Qemu-devel] [PATCH 18/22] qcow2-dirty-bitmaps: disallow stroing bitmap to other bs

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
Check, that bitmap is stored to the owning bs. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 12 block/qcow2-dirty-bitmap.c | 5 + include/block/dirty-bitmap.h | 2 ++ 3 files changed, 19 insertions(+) diff --git a/block/dirty-bitmap.c b/blo

[Qemu-devel] [PATCH 12/22] qcow2-dirty-bitmap: add qcow2_bitmap_load_check()

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
The function checks existing of the bitmap without loading it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 15 +++ block/qcow2-dirty-bitmap.c | 5 + block/qcow2.c| 1 + block/qcow2.h| 1 + include/block/block

[Qemu-devel] [PATCH 10/22] qcow2-dirty-bitmap: add qcow2_bitmap_store()

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
This function stores block dirty bitmap to qcow2. If the bitmap with the same name, size and granularity already exists, it will be rewritten, if the bitmap with the same name exists but granularity or size does not match, an error will be genrated. Signed-off-by: Vladimir Sementsov-Ogievskiy ---

[Qemu-devel] [PATCH 20/22] iotests: test internal persistent dirty bitmap

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
Add simple test cases for testing persistent dirty bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/160| 112 ++ tests/qemu-iotests/160.out| 21 tests/qemu-iotests/group | 1 + tests/qemu-iotests/iote

[Qemu-devel] [PATCH 14/22] block: add bdrv_load_dirty_bitmap()

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
The funcion loads dirty bitmap from file, using underlying driver function. Note: the function doesn't change BdrvDirtyBitmap.file field. This field is only used by bdrv_store_dirty_bitmap() function and is ONLY written by bdrv_dirty_bitmap_set_file() function. Signed-off-by: Vladimir Sementsov-O

[Qemu-devel] [PATCH 11/22] qcow2: add dirty bitmaps extension

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
Add dirty bitmap extension as specified in docs/specs/qcow2.txt. Load bitmap headers on open. Handle close and update_header. Handle resize: for now, just block resize if there are dirty bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2.c | 89 +++

[Qemu-devel] [PATCH 15/22] qcow2-dirty-bitmap: add autoclear bit

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
Add autoclear bit for handling rewriting image by old qemu version. If autoclear bit is not set, but bitmaps extension is found it would not be loaded and warning will be generated. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/qcow2-dirty-bitmap.c | 4 block/qcow2.c

[Qemu-devel] [PATCH 04/22] iotests: add default node-name

2016-03-15 Thread Vladimir Sementsov-Ogievskiy
When testing migration, auto-generated by qemu node-names differs in source and destination qemu and migration fails. After this patch, auto-generated by iotest nodenames will be the same. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 1 + 1 file changed, 1 inse

  1   2   3   4   5   >