Re: [Qemu-devel] [PATCH] ES1370: QOMify

2016-02-01 Thread Michael Tokarev
Applied to -trivial, thanks! /mjt

Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor

2016-02-01 Thread Markus Armbruster
Eric Blake writes: > On 02/01/2016 05:31 AM, Markus Armbruster wrote: > >>> |+visit_start_struct(v, NULL, NULL, "ACPI_DEVICE_OST", 0, &err); >>> | if (err) { >>> | goto out; >>> | } >>> | visit_type_ACPIOSTInfo(v, &info, "info", &err); >>> | if (err) { >>> |-go

Re: [Qemu-devel] Strange monitor/stdout issue on qemu-system-sparc/qemu-system-ppc

2016-02-01 Thread Mark Cave-Ayland
On 31/01/16 21:57, Paolo Bonzini wrote: > On 31/01/2016 18:54, Peter Maydell wrote: >> On 31 January 2016 at 17:19, Paolo Bonzini wrote: >>> On 31/01/2016 16:54, Mark Cave-Ayland wrote: I also notice that with the above commit I lose cycling through history in the GTK monitor - even wit

Re: [Qemu-devel] [iGVT-g] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-02-01 Thread Zhiyuan Lv
Hi Gerd/Alex, On Mon, Feb 01, 2016 at 02:44:55PM -0700, Alex Williamson wrote: > On Mon, 2016-02-01 at 14:10 +0100, Gerd Hoffmann wrote: > >   Hi, > >  > > > > Unfortunately it's not the only one. Another example is, device-model > > > > may want to write-protect a gfn (RAM). In case that this req

Re: [Qemu-devel] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-01 Thread Gerd Hoffmann
Hi, > +realloc: > +opregion = malloc_high(size * 1024); memalign_high(PAGE_SIZE, size * 1024); > > I'd have qemu copy the data on 0xfc write then, so things continue to > > work without updating seabios. So, the firmware has to allocate space, > > reserve it etc., and programming the 0xf

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-01 Thread Tian, Kevin
> From: Kirti Wankhede [mailto:kwankh...@nvidia.com] > Sent: Tuesday, February 02, 2016 9:48 AM > > Resending this mail again, somehow my previous mail didn't reached every > to everyone's inbox. > > On 2/2/2016 3:16 AM, Kirti Wankhede wrote: > > Design for vGPU Driver: > > Main purpose of vGPU d

Re: [Qemu-devel] [iGVT-g] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-02-01 Thread Gerd Hoffmann
Hi, > Alternatively can the vgpu > driver copy it to a private buffer and hardware can execute from that? Copying is an option, but given the size execbuffers can have this comes with a noticeable performance difference. cheers, Gerd

Re: [Qemu-devel] [PATCH 02/12] Added reset-pin emulation in model.

2016-02-01 Thread Krzeminski, Marcin (Nokia - PL/Wroclaw)
> -Original Message- > From: EXT Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Monday, February 01, 2016 7:29 PM > To: Krzeminski, Marcin (Nokia - PL/Wroclaw) > Cc: Peter Maydell; qemu-devel@nongnu.org Developers; Lenkow, Pawel > (Nokia - PL/Wroclaw) > Subject: Re: [Qemu-d

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-01 Thread Tian, Kevin
> From: Kay, Allen M > Sent: Saturday, January 30, 2016 5:58 AM > > First of all, I would like to clarify I'm talking about general IGD > passthrough case - not > specific to KVMGT. In IGD passthrough configuration, one of the following > will happen > when the driver accesses OpRegion: > > 1)

Re: [Qemu-devel] [PATCH 2/2] ARM: PL061: Misc cleaning fields for PL061 device state

2016-02-01 Thread Michael Tokarev
01.02.2016 21:01, Peter Maydell wrote: > On 1 February 2016 at 17:20, Wei Huang wrote: >> This patch removes float_high field of PL061State, which doesn't seem >> to be used anywhere. [] >> @@ -88,7 +87,6 @@ static const VMStateDescription vmstate_pl061 = { >> VMSTATE_UINT32(slr, PL061Sta

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-01 Thread Tian, Kevin
> From: Gerd Hoffmann > Sent: Monday, February 01, 2016 8:49 PM > > Hi, > > > Thanks for the tip that seabios allocated pages automatically become > > e820 reserved, that simplifies things a bit. > > It's common practice for all firmware. The e820 table from qemu is just > a starting point, i

Re: [Qemu-devel] [Xen-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-01 Thread Tian, Kevin
> From: Kay, Allen M > Sent: Tuesday, February 02, 2016 8:04 AM > > > > David notes in the latter commit above: > > > > "We should be able to successfully assign graphics devices to guests too, as > > long as the initial handling of stolen memory is reconfigured > > appropriately." > > > > What co

[Qemu-devel] [PATCH v9] spec: add qcow2 bitmaps extension specification

2016-02-01 Thread Vladimir Sementsov-Ogievskiy
The new feature for qcow2: storing bitmaps. This patch adds new header extension to qcow2 - Bitmaps Extension. It provides an ability to store virtual disk related bitmaps in a qcow2 image. For now there is only one type of such bitmaps: Dirty Tracking Bitmap, which just tracks virtual disk change

[Qemu-devel] [RFC PATCH] fw/pci: Add support for mapping Intel IGD OpRegion via QEMU

2016-02-01 Thread Alex Williamson
The proposed IGD OpRegion support in QEMU via vfio maps the host OpRegion into VM system memory at the address written to the ASL Storage register (0xFC). The OpRegion contains a 16-byte signature followed by a 4-byte size field. Therefore SeaBIOS can allocate a buffer of the typical size (8KB),

Re: [Qemu-devel] [PATCH v3 4/4] net/filter: Add a default filter to each netdev

2016-02-01 Thread Yang Hongyang
On 02/01/2016 08:01 PM, zhanghailiang wrote: We add each netdev a default buffer filter, and the default buffer filter is disabled, so it has no side effect for packets delivering in qemu net layer. The default buffer filter can be used by COLO or Micro-checkpoint, The reason we add the defaul

Re: [Qemu-devel] [PATCH v3 2/4] net/filter: Introduce a helper to add a filter to the netdev

2016-02-01 Thread Yang Hongyang
On 02/01/2016 08:01 PM, zhanghailiang wrote: We add a new helper function netdev_add_filter(), this function can help adding a filter object to a netdev. Besides, we add a is_default member for struct NetFilterState to indicate whether the filter is default or not. Signed-off-by: zhanghailiang

[Qemu-devel] [RFC PATCH 7/7] vfio/pci: Find and expose Intel IGD OpRegion

2016-02-01 Thread Alex Williamson
This is provided via a device specific region, look for it on Intel VGA class devices, initialize it, and tie it to the config space register at 0xFC. Note that on bare metal it seems that 0xFC only points to the memory reserved by the BIOS for the OpRegion, in the model used here, programming the

[Qemu-devel] [RFC PATCH 5/7] linux-headers/vfio: Update for proposed capabilities list

2016-02-01 Thread Alex Williamson
Signed-off-by: Alex Williamson --- linux-headers/linux/vfio.h | 98 +++- 1 file changed, 96 insertions(+), 2 deletions(-) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index aa276bc..7e955f1 100644 --- a/linux-headers/linux/vfio.h

[Qemu-devel] [RFC PATCH 3/7] vfio: Generalize region support

2016-02-01 Thread Alex Williamson
Both platform and PCI vfio drivers create a "slow", I/O memory region with one or more mmap memory regions overlayed when supported by the device. Generalize this to a set of common helpers in the core that pulls the region info from vfio, fills the region data, configures slow mapping, and adds he

[Qemu-devel] [RFC PATCH 2/7] vfio: Wrap VFIO_DEVICE_GET_REGION_INFO

2016-02-01 Thread Alex Williamson
In preparation for supporting capability chains on regions, wrap ioctl(VFIO_DEVICE_GET_REGION_INFO) so we don't duplicate the code for each caller. Signed-off-by: Alex Williamson --- hw/vfio/common.c | 18 + hw/vfio/pci.c | 81 +---

[Qemu-devel] [RFC PATCH 6/7] vfio: Enable sparse mmap capability

2016-02-01 Thread Alex Williamson
The sparse mmap capability in a vfio region info allows vfio to tell us which sub-areas of a region may be mmap'd. Thus rather than assuming a single mmap covers the entire region and later frobbing it ourselves for things like the PCI MSI-X vector table, we can read that directly from vfio. Sign

[Qemu-devel] [RFC PATCH 1/7] vfio: Add sysfsdev property for pci & platform

2016-02-01 Thread Alex Williamson
vfio-pci currently requires a host= parameter, which comes in the form of a PCI address in [domain:] notation. We expect to find a matching entry in sysfs for that under /sys/bus/pci/devices/. vfio-platform takes a similar approach, but defines the host= parameter to be a string, which can be mat

[Qemu-devel] [RFC PATCH 4/7] vfio/pci: Convert all MemoryRegion to dynamic alloc and consistent functions

2016-02-01 Thread Alex Williamson
Match common vfio code with setup, exit, and finalize functions for BAR, quirk, and VGA management. VGA is also changed to dynamic allocation to match the other MemoryRegions. Signed-off-by: Alex Williamson --- hw/vfio/pci-quirks.c | 38 - hw/vfio/pci.c| 114 +

[Qemu-devel] [RFC PATCH 0/7] vfio: capability chains, sparse mmap, device specific regions

2016-02-01 Thread Alex Williamson
This is the QEMU compliment to the vfio kernel capability chain series. This is RFC since it depends on those non-upstream kernel changes. Patch 1/ will be posted separately, it's somewhat unrelated, but is in my build tree so I include it here for anyone that wants to build this series. This se

Re: [Qemu-devel] [PATCH v3 0/4] Netfilter: Add each netdev a default filter

2016-02-01 Thread Yang Hongyang
If we have to add a default filter, then I have a suggestion only for this series: 1. Add a nop filter. filter-nop.c 2. Add a "default-filter=xxx" property to -netdev, if not specified, default to nop. On 02/01/2016 08:01 PM, zhanghailiang wrote: This series is a prerequisite for COLO, here w

[Qemu-devel] [PULL 17/17] net/filter: Fix the output information for command 'info network'

2016-02-01 Thread Jason Wang
From: zhanghailiang The properties of netfilter object could be changed by 'qom-set' command, but the output of 'info network' command is not updated, because it got the old information through nf->info_str, it will not be updated while we change the value of netfilter's property. Here we split

[Qemu-devel] [PULL 14/17] e1000: eliminate infinite loops on out-of-bounds transfer start

2016-02-01 Thread Jason Wang
From: Laszlo Ersek The start_xmit() and e1000_receive_iov() functions implement DMA transfers iterating over a set of descriptors that the guest's e1000 driver prepares: - the TDLEN and RDLEN registers store the total size of the descriptor area, - while the TDH and RDH registers store the of

[Qemu-devel] [PULL 16/17] net: always walk through filters in reverse if traffic is egress

2016-02-01 Thread Jason Wang
From: Li Zhijian Previously, if we attach more than one filters for a single netdev, both ingress and egress traffic will go through net filters in same order like: ingress: netdev ->filter1 ->filter2 ->...filter[n] ->emulated device egress: emulated device ->filter1 ->filter2 ->...filter[n] ->n

[Qemu-devel] [PULL 13/17] slirp: Adding family argument to tcp_fconnect()

2016-02-01 Thread Jason Wang
From: Guillaume Subiron This patch simply adds a sa_family_t argument to remove the hardcoded "AF_INET" in the call of qemu_socket(). This prepares for IPv6 support. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth Signed-off-by: Jason Wang --- slirp

[Qemu-devel] [PULL 15/17] net: netmap: use nm_open() to open netmap ports

2016-02-01 Thread Jason Wang
From: Vincenzo Maffione This patch simplifies the netmap backend code by means of the nm_open() helper function provided by netmap_user.h, which hides the details of open(), iotcl() and mmap() carried out on the netmap device. Moreover, the semantic of nm_open() makes it possible to open special

[Qemu-devel] [PULL 12/17] slirp: Make udp_attach IPv6 compatible

2016-02-01 Thread Jason Wang
From: Guillaume Subiron A sa_family_t is now passed in argument to udp_attach instead of using a hardcoded "AF_INET" to call qemu_socket(). This prepares for IPv6 support. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth Signed-off-by: Jason Wang ---

[Qemu-devel] [PULL 11/17] slirp: Add sockaddr_equal, make solookup family-agnostic

2016-02-01 Thread Jason Wang
From: Guillaume Subiron This patch makes solookup() compatible with varying address families, by using a new sockaddr_equal() function that compares two sockaddr_storage. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth

[Qemu-devel] [PULL 07/17] slirp: Adding address family switch for produced frames

2016-02-01 Thread Jason Wang
From: Guillaume Subiron In if_encap, a switch is added to prepare for the IPv6 case. Some code is factorized. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth --- slirp/slirp.c | 61 +

[Qemu-devel] [PULL 09/17] slirp: Factorizing address translation

2016-02-01 Thread Jason Wang
From: Guillaume Subiron This patch factorizes some duplicate code into a new function, sotranslate_out(). This function perform the address translation when a packet is transmitted to the host network. If the packet is destinated to the host, the loopback address is used, and if the packet is des

[Qemu-devel] [PULL 08/17] slirp: Make Socket structure IPv6 compatible

2016-02-01 Thread Jason Wang
From: Guillaume Subiron This patch replaces foreign and local address/port couples in Socket structure by 2 sockaddr_storage which can be casted in sockaddr_in. Direct access to address and port is still possible thanks to some \#define, so retrocompatibility of the existing code is assured. The

[Qemu-devel] [PULL 10/17] slirp: Factorizing and cleaning solookup()

2016-02-01 Thread Jason Wang
From: Guillaume Subiron solookup() was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Some optimization code is factorized inside the function (the function look at the last returned result before browsing the complete socket list). This prepare

[Qemu-devel] [PULL 05/17] slirp: goto bad in udp_input if sosendto fails

2016-02-01 Thread Jason Wang
From: Guillaume Subiron Before this patch, if sosendto fails, udp_input is executed as if the packet was sent, recording the packet for icmp errors, which does not makes sense since the packet was not actually sent, errors would be related to a previous packet. This patch adds a goto bad to cut

[Qemu-devel] [PULL 04/17] cadence_gem: fix buffer overflow

2016-02-01 Thread Jason Wang
From: "Michael S. Tsirkin" gem_transmit copies a packet from guest into an tx_packet[2048] array on stack, with size limited by descriptor length set by guest. If guest is malicious and specifies a descriptor length that is too large, and should packet size exceed array size, this results in a b

[Qemu-devel] [PULL 03/17] net: cadence_gem: check packet size in gem_recieve

2016-02-01 Thread Jason Wang
From: Prasad J Pandit While receiving packets in 'gem_receive' routine, if Frame Check Sequence(FCS) is enabled, it copies the packet into a local buffer without checking its size. Add check to validate packet length against the buffer size to avoid buffer overflow. Reported-by: Ling Liu Signed

[Qemu-devel] [PULL 06/17] slirp: Generalizing and neutralizing ARP code

2016-02-01 Thread Jason Wang
From: Guillaume Subiron Basically, this patch replaces "arp" by "resolution" every time "arp" means "mac resolution" and not specifically ARP. This prepares for IPv6 support. Signed-off-by: Guillaume Subiron Signed-off-by: Samuel Thibault Reviewed-by: Thomas Huth Signed-off-by: Jason Wang -

[Qemu-devel] [PULL 02/17] qemu-doc: Do not promote deprecated -smb and -redir options

2016-02-01 Thread Jason Wang
From: Thomas Huth Since -smb and -redir are deprecated options, we should not use them as examples in the documentation anymore. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- qemu-doc.texi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/qemu-doc.texi b/

[Qemu-devel] [PULL 01/17] net/slirp: Tell the users when they are using deprecated options

2016-02-01 Thread Jason Wang
From: Thomas Huth We don't want to support the legacy -tftp, -bootp, -smb and -net channel options forever. So let's start telling the users that they are deprecated and what option should be used instead. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- net/slirp.c | 3 +++ os-posix.

[Qemu-devel] [PULL 00/17] Net patches

2016-02-01 Thread Jason Wang
The following changes since commit 0430891ce162b986c6e02a7729a942ecd2a32ca4: hw: Clean up includes (2016-01-29 15:07:25 +) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to e8a7a1a574ed6728422959c8aa79ca584c

Re: [Qemu-devel] [PATCH 2/2] hw/vfio/platform: Add Qualcomm Technologies, Inc HiDMA device support

2016-02-01 Thread Shanker Donthineni
Hi Eric, On 02/01/2016 08:37 AM, Eric Auger wrote: Hi Shanker, Vikram, On 01/30/2016 12:00 AM, Shanker Donthineni wrote: From: Vikram Sethi This patch introduces a Qualcomm Technologies, Inc HiDMA device and allows the instantiation of the vfio-qcom-hidma device from the QEMU command line (-d

Re: [Qemu-devel] [PATCH] jobs: remove unused structure

2016-02-01 Thread Fam Zheng
On Mon, 02/01 17:18, John Snow wrote: > Signed-off-by: John Snow > --- > blockjob.c | 8 > 1 file changed, 8 deletions(-) > > diff --git a/blockjob.c b/blockjob.c > index 80adb9d..a692142 100644 > --- a/blockjob.c > +++ b/blockjob.c > @@ -278,14 +278,6 @@ void block_job_iostatus_reset(B

[Qemu-devel] [PATCH v4] blockjob: Fix hang in block_job_finish_sync

2016-02-01 Thread Fam Zheng
With a mirror job running on a virtio-blk dataplane disk, sending "q" to HMP will cause a dead loop in block_job_finish_sync. This is because the aio_poll() only processes the AIO context of bs which has no more work to do, while the main loop BH that is scheduled for setting the job->completed fl

Re: [Qemu-devel] [RFC PATCH v1 1/1] vGPU core driver : to provide common interface for vGPU.

2016-02-01 Thread Kirti Wankhede
Resending this mail again, somehow my previous mail didn't reached every to everyone's inbox. On 2/2/2016 3:16 AM, Kirti Wankhede wrote: Design for vGPU Driver: Main purpose of vGPU driver is to provide a common interface for vGPU management that can be used by differnt GPU drivers. This modul

[Qemu-devel] [PATCH v2 2/2] block: qemu-iotests - add test for snapshot, commit, snapshot bug

2016-02-01 Thread Jeff Cody
Signed-off-by: Jeff Cody --- tests/qemu-iotests/143 | 114 + tests/qemu-iotests/143.out | 24 ++ tests/qemu-iotests/group | 1 + 3 files changed, 139 insertions(+) create mode 100755 tests/qemu-iotests/143 create mode 100644 tests/qem

[Qemu-devel] [PATCH v2 1/2] block: set device_list.tqe_prev to NULL on BDS removal

2016-02-01 Thread Jeff Cody
This fixes a regression introduced with commit 3f09bfbc7. Multiple bugs arise in conjunction with live snapshots and mirroring operations (which include active layer commit). After a live snapshot occurs, the active layer and the base layer both have a non-NULL tqe_prev field in the device_list,

[Qemu-devel] [PATCH v2 0/2] Active commit regression fix

2016-02-01 Thread Jeff Cody
Changes from v1: * Rather than allow insertion when bs->device_listtqe_prev points to a NULL entry, make sure than we follow the block scheme of enforcing bs->device_list->tqe_prev is NULL upon deletion. (Thanks Max!) Bug #1300209 is a regression in 2.5, introduced during the change away fro

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: change parent backing link when *tqe_prev == NULL

2016-02-01 Thread Jeff Cody
On Mon, Feb 01, 2016 at 10:43:02PM +0100, Max Reitz wrote: > On 30.01.2016 06:17, Jeff Cody wrote: > > In change_parent_backing_link(), we only inserted the new > > BlockDriverState entry into the device_list if the tqe_prev pointer was > > NULL. However, we must also allow insertion when the BDS

Re: [Qemu-devel] [PATCH v10 0/2] mirror: Improve zero write and discard

2016-02-01 Thread Paolo Bonzini
On 22/01/2016 08:46, Fam Zheng wrote: > On Wed, 01/13 10:50, Fam Zheng wrote: >> > v10: Fix and simplify mirror_cow_align. [Max] > Jeff, are you happy to take these patches? Ping again. I have patches waiting for these to be accepted too. Paolo

Re: [Qemu-devel] [iGVT-g] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-01 Thread Kay, Allen M
> -Original Message- > From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Sunday, January 31, 2016 9:42 AM > To: Kay, Allen M; Gerd Hoffmann; David Woodhouse > Cc: igv...@ml01.01.org; xen-de...@lists.xensource.com; Eduardo Habkost; > Stefano Stabellini; qemu-devel@nongnu.or

Re: [Qemu-devel] [PATCH v9 23/37] qmp: Support explicit null during input visit

2016-02-01 Thread Eric Blake
On 01/22/2016 10:12 AM, Markus Armbruster wrote: > Eric Blake writes: > >> Implement the new type_null() callback for the qmp input visitor. >> While we don't yet have a use for this in qapi (the generator >> will need some tweaks first), one usage is already envisioned: >> when changing blockdev

Re: [Qemu-devel] [PATCH v1 1/1] qom: Correct object_property_get_int() description

2016-02-01 Thread Alistair Francis
On Sat, Jan 30, 2016 at 1:35 AM, Michael Tokarev wrote: > 18.01.2016 21:42, Alistair Francis wrote: >> The description of object_property_get_int() stated that on an error >> it returns NULL. This is not the case and the function will return -1 >> if an error occurs. Update the commented documenta

Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct

2016-02-01 Thread Eric Blake
On 02/01/2016 06:07 AM, Markus Armbruster wrote: > Eric Blake writes: > >> No backend was setting an error when ending an implicit struct, >> or when iterating a list. > > Perhaps "when ending the visit of a list or implicit struct, or when > moving to the next list node" would be more precise.

Re: [Qemu-devel] [PATCH v10 10/25] qapi: Improve generated event use of qapi visitor

2016-02-01 Thread Eric Blake
On 02/01/2016 05:31 AM, Markus Armbruster wrote: >> |+visit_start_struct(v, NULL, NULL, "ACPI_DEVICE_OST", 0, &err); >> | if (err) { >> | goto out; >> | } >> | visit_type_ACPIOSTInfo(v, &info, "info", &err); >> | if (err) { >> |-goto out; >> |+goto out_o

[Qemu-devel] [RFC] Programmable guest-to-QEMU hypercalls

2016-02-01 Thread Lluís Vilanova
Hi! I have in my trace instrumentation queue a series that adds a very simple but efficient way to trigger code in QEMU from guest code using guest-agnostic code. Blue Swirl showed some interest long ago in using it in the test suite (e.g., instruct QEMU to check the vCPU state after a series of i

Re: [Qemu-devel] [RFC PATCH 0/3] (Resend) TranslationBlock annotation mechanism

2016-02-01 Thread Lluís Vilanova
Lluís Vilanova writes: > Bastian Koppelmann writes: >> Hi Lluis, >> On 01/27/2016 07:54 PM, Lluís Vilanova wrote: [...] >>> >>> So, I'd say that such support is on the list of current developments (at >>> least >>> mine, specially now that I have a bit more time for it). But getting the >>> cor

Re: [Qemu-devel] [PATCH] jobs: remove unused structure

2016-02-01 Thread Eric Blake
On 02/01/2016 03:18 PM, John Snow wrote: > Signed-off-by: John Snow > --- > blockjob.c | 8 > 1 file changed, 8 deletions(-) Reviewed-by: Eric Blake > > diff --git a/blockjob.c b/blockjob.c > index 80adb9d..a692142 100644 > --- a/blockjob.c > +++ b/blockjob.c > @@ -278,14 +278,6 @@ v

[Qemu-devel] [PATCH] jobs: remove unused structure

2016-02-01 Thread John Snow
Signed-off-by: John Snow --- blockjob.c | 8 1 file changed, 8 deletions(-) diff --git a/blockjob.c b/blockjob.c index 80adb9d..a692142 100644 --- a/blockjob.c +++ b/blockjob.c @@ -278,14 +278,6 @@ void block_job_iostatus_reset(BlockJob *job) } } -struct BlockFinishData { -B

Re: [Qemu-devel] [vfio-users] [PATCH v3 00/11] igd passthrough chipset tweaks

2016-02-01 Thread Alex Williamson
On Mon, 2016-02-01 at 13:49 +0100, Gerd Hoffmann wrote: > > > Maybe we should define the interface as "guest writes 0xfc to pick > > > address, qemu takes care to place opregion there".  That gives us the > > > freedom to change the qemu implementation (either copy host opregion or > > > map the ho

[Qemu-devel] [PATCH v3 0/3] SD emulation fixes for Pi2 Tianocore EDK2 UEFI

2016-02-01 Thread Andrew Baumann
This series contains fixes to the SD card emulation that are needed to unblock Tianocore EDK2 UEFI (specifically, the bootloader for Windows on Raspberry Pi 2). Changes in v2, based on feedback from Peter Crosthwaite: * correct implementation of CMD23 to switch to transfer state on completion *

Re: [Qemu-devel] [PATCH v2 0/3] SD emulation fixes for Pi2 Tianocore EDK2 UEFI

2016-02-01 Thread Andrew Baumann
> From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Monday, 25 January 2016 10:37 > > On 25 January 2016 at 18:06, Andrew Baumann > wrote: > > This is the most recent version of the patch series. However, > > there was an unresolved question about migration compatibility > > for the v

[Qemu-devel] [PATCH v3 1/3] hw/sd: implement CMD23 (SET_BLOCK_COUNT) for MMC compatibility

2016-02-01 Thread Andrew Baumann
CMD23 is optional for SD but required for MMC, and the UEFI bootloader used for Windows on Raspberry Pi 2 issues it. Reviewed-by: Peter Crosthwaite Signed-off-by: Andrew Baumann --- hw/sd/sd.c | 37 + 1 file changed, 37 insertions(+) diff --git a/hw/sd/sd.c

[Qemu-devel] [PATCH v3 2/3] hw/sd: model a power-up delay, as a workaround for an EDK2 bug

2016-02-01 Thread Andrew Baumann
The SD spec for ACMD41 says that a zero argument is an "inquiry" ACMD41, which does not start initialisation and is used only for retrieving the OCR. However, Tianocore EDK2 (UEFI) has a bug [1]: it first sends an inquiry (zero) ACMD41. If that first request returns an OCR value with the power up b

[Qemu-devel] [PATCH v3 3/3] hw/sd: use guest error logging rather than fprintf to stderr

2016-02-01 Thread Andrew Baumann
Some of these errors may be harmless (e.g. probing unimplemented commands, or issuing CMD12 in the wrong state), and may also be quite frequent. Spamming the standard error output isn't desirable in such cases. Reviewed-by: Peter Crosthwaite Signed-off-by: Andrew Baumann --- It might also be des

Re: [Qemu-devel] [iGVT-g] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-02-01 Thread Alex Williamson
On Mon, 2016-02-01 at 14:10 +0100, Gerd Hoffmann wrote: >   Hi, >  > > > Unfortunately it's not the only one. Another example is, device-model > > > may want to write-protect a gfn (RAM). In case that this request goes > > > to VFIO .. how it is supposed to reach KVM MMU? > >  > > Well, let's work

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: change parent backing link when *tqe_prev == NULL

2016-02-01 Thread Max Reitz
On 30.01.2016 06:17, Jeff Cody wrote: > In change_parent_backing_link(), we only inserted the new > BlockDriverState entry into the device_list if the tqe_prev pointer was > NULL. However, we must also allow insertion when the BDS pointed > to by the tqe_prev pointer is NULL as well. > > This fi

Re: [Qemu-devel] [PATCH v8] spec: add qcow2 bitmaps extension specification

2016-02-01 Thread Max Reitz
On 27.01.2016 16:52, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one type of such bi

Re: [Qemu-devel] [PATCH] fdc: fix detection under Linux

2016-02-01 Thread Hervé Poussineau
Le 29/01/2016 23:35, John Snow a écrit : Accidentally, I removed a "feature" where empty drives had geometry values applied to them, which allows seek on empty drives to work "by accident," as QEMU actually tries to disallow that. Seeks on empty drives should work, though, but the easiest thing

[Qemu-devel] [PATCH V2 1/2] ARM: PL061: Clear PL061 device state after reset

2016-02-01 Thread Wei Huang
Current QEMU doesn't clear PL061 state after reset. This causes a weird issue with guest reboot via GPIO. Here is the device state description with two reboot requests: (PL061State fields) data old_in_data istate VM boot 0 0 0 After 1st ACPI

[Qemu-devel] [PATCH V2 2/2] ARM: PL061: Cleaning field of PL061 device state

2016-02-01 Thread Wei Huang
This patch removes the float_high field of PL061State, which doesn't seem to be used anywhere. Because this changes the device state, the version ID is also bumped up for the reason of compatiblity. Signed-off-by: Wei Huang --- hw/gpio/pl061.c | 6 ++ 1 file changed, 2 insertions(+), 4 delet

Re: [Qemu-devel] [PATCH 0/2] Active commit regression fix

2016-02-01 Thread Eric Blake
On 01/29/2016 10:17 PM, Jeff Cody wrote: > Bug #1300209 is a regression in 2.5, introduced during the > change away from bdrv_swap(). > > When we change the parent backing link (change_parent_backing_link), > we must also accomodate non-NULL tqe_prev pointers that point to a > NULL entry. Please

[Qemu-devel] [PATCH] kvm-all: trace: strerror fixup

2016-02-01 Thread Andrew Jones
Signed-off-by: Andrew Jones --- kvm-all.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 9148889921197..330f509a0da84 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -2362,7 +2362,7 @@ int kvm_set_one_reg(CPUState *cs, uint64_t id, void *source)

Re: [Qemu-devel] [Qemu-arm] Does QEMU support AArch64 Big Endian emulation on x86-64 host?

2016-02-01 Thread Peter Crosthwaite
On Mon, Feb 1, 2016 at 3:25 AM, Ruslan Bilovol wrote: > On Wed, Jan 27, 2016 at 7:39 PM, Peter Crosthwaite > wrote: >> On Tue, Jan 26, 2016 at 4:05 AM, Ruslan Bilovol >> wrote: >>> On Mon, Jan 25, 2016 at 6:07 PM, Peter Maydell >>> wrote: On 25 January 2016 at 13:51, Ruslan Bilovol

[Qemu-devel] [PATCH v3 2/2] build: [bsd-user] Rename "syscall.h" to "target_syscall.h" in target directories

2016-02-01 Thread Lluís Vilanova
This fixes double-definitions in bsd-user builds when using the UST tracing backend (which indirectly includes the system's "syscall.h"). Signed-off-by: Lluís Vilanova Reviewed-by: Peter Maydell --- bsd-user/i386/target_syscall.h|4 bsd-user/qemu.h |2 +- bsd-

[Qemu-devel] [PATCH v3 1/2] build: [linux-user] Rename "syscall.h" to "target_syscall.h" in target directories

2016-02-01 Thread Lluís Vilanova
This fixes double-definitions in linux-user builds when using the UST tracing backend (which indirectly includes the system's "syscall.h"). Signed-off-by: Lluís Vilanova --- linux-user/aarch64/target_syscall.h|5 + linux-user/alpha/target_syscall.h |5 + linux-user/arm/t

[Qemu-devel] [PATCH v3 0/2] build: Rename all "syscall.h" in target directories to "target_syscall.h"

2016-02-01 Thread Lluís Vilanova
This fixes double-definitions in *-user builds when using the UST tracing backend (which indirectly includes the system's "syscall.h"). Changes in v3 = * Fix stray new files in generic target code [Peter Maydell]. Changes in v2 = * Fix includes for bsd-user too [Peter

Re: [Qemu-devel] [PATCH v2 1/2] build: [linux-user] Rename all "syscall.h" in target directories to "target_syscall.h"

2016-02-01 Thread Lluís Vilanova
Peter Maydell writes: > On 1 February 2016 at 14:18, Lluís Vilanova wrote: >> This fixes double-definitions in linux-user builds when using the UST >> tracing backend (which indirectly includes the system's "syscall.h"). >> >> Signed-off-by: Lluís Vilanova >> --- >> linux-user/aarch64/target_sy

Re: [Qemu-devel] [PATCH 02/12] Added reset-pin emulation in model.

2016-02-01 Thread Peter Crosthwaite
On Mon, Dec 21, 2015 at 5:39 AM, Krzeminski, Marcin (Nokia - PL/Wroclaw) wrote: > > > W dniu 21.12.2015 o 12:04, Peter Crosthwaite pisze: >> On Wed, Dec 16, 2015 at 4:57 AM, wrote: >>> From: Marcin Krzeminski >>> >>> Signed-off-by: Marcin Krzeminski >>> --- >>> hw/block/m25p80.c | 38

Re: [Qemu-devel] [PATCH 2/2] ARM: PL061: Misc cleaning fields for PL061 device state

2016-02-01 Thread Peter Maydell
On 1 February 2016 at 17:20, Wei Huang wrote: > This patch removes float_high field of PL061State, which doesn't seem > to be used anywhere. > > Signed-off-by: Wei Huang > --- > hw/gpio/pl061.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/hw/gpio/pl061.c b/hw/gpio/pl061.c > index 34

Re: [Qemu-devel] [PATCH v5 0/4] Extend TPM support with a QEMU-external TPM

2016-02-01 Thread Stefan Berger
Stefan Berger/Watson/IBM wrote on 01/21/2016 07:31:10 AM: > > "Dr. David Alan Gilbert" wrote on 01/21/2016 > 06:40:35 AM: > > > > > > > > There is one issue in case of resume of a snapshot. If the > permanent state > > > of the TPM is modified during snapshotting, like ownership is > taken

Re: [Qemu-devel] [RFC PATCH] vfio: Add sysfsdev property for pci & platform

2016-02-01 Thread Eric Auger
On 01/26/2016 06:08 PM, Alex Williamson wrote: > On Tue, 2016-01-26 at 16:03 +0100, Eric Auger wrote: >> >> Hi Alex, >> >> I did a try with both legacy cmd line and new one and it works fine for >> vfio platform too: >> -device vfio-calxeda-xgmac,host="fff51000.ethernet" >> -device >> vfio-calxeda-

Re: [Qemu-devel] [PATCH 1/1] arm: virt: change GPIO trigger interrupt to pulse

2016-02-01 Thread Wei Huang
On 02/01/2016 04:17 AM, Igor Mammedov wrote: > On Fri, 29 Jan 2016 09:13:15 -0600 > Wei Huang wrote: > >> On 01/29/2016 08:50 AM, Peter Maydell wrote: >>> On 29 January 2016 at 14:46, Shannon Zhao wrote: On 2016/1/29 22:35, Wei Huang wrote: > On 01/29/2016 04:10 AM, Shannon Zhao w

Re: [Qemu-devel] [PATCH v10 23/25] qapi: Drop unused error argument for list and implicit struct

2016-02-01 Thread Eric Blake
On 02/01/2016 06:07 AM, Markus Armbruster wrote: > Eric Blake writes: > >> No backend was setting an error when ending an implicit struct, >> or when iterating a list. > > Perhaps "when ending the visit of a list or implicit struct, or when > moving to the next list node" would be more precise.

[Qemu-devel] [PATCH 1/2] ARM: PL061: Clear PL061 device state after reset

2016-02-01 Thread Wei Huang
Current QEMU doesn't clear PL061 state after reset. This causes a weird issue with guest reboot via GPIO. Here is the device state description with two reboot requests: (PL061State fields) data old_in_data istate VM boot 0 0 0 After 1st ACPI

[Qemu-devel] [PATCH 2/2] ARM: PL061: Misc cleaning fields for PL061 device state

2016-02-01 Thread Wei Huang
This patch removes float_high field of PL061State, which doesn't seem to be used anywhere. Signed-off-by: Wei Huang --- hw/gpio/pl061.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/gpio/pl061.c b/hw/gpio/pl061.c index 342a70d..2c08e88 100644 --- a/hw/gpio/pl061.c +++ b/hw/gpio/pl061.c

Re: [Qemu-devel] [PATCH 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver

2016-02-01 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Jan 29, 2016 at 5:23 PM, Markus Armbruster wrote: >> marcandre.lur...@redhat.com writes: >> >>> From: Marc-André Lureau >>> >>> Simplify the interrupt handling by having a single callback on irq&msi >>> cases. Remove usage of CharDriver, replace it wit

Re: [Qemu-devel] [PATCH v6 2/8] device_tree: introduce load_device_tree_from_sysfs

2016-02-01 Thread Rob Herring
On Mon, Feb 1, 2016 at 10:22 AM, Eric Auger wrote: > Hi Rob, > On 02/01/2016 05:15 PM, Rob Herring wrote: >> On Mon, Feb 1, 2016 at 7:51 AM, Eric Auger wrote: >>> This function returns the host device tree blob from sysfs >>> (/proc/device-tree). It uses a recursive function inspired >>> from dtc

Re: [Qemu-devel] [PATCH 6/8] ivshmem: generalize ivshmem_setup_interrupts

2016-02-01 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Jan 29, 2016 at 4:59 PM, Markus Armbruster wrote: >> marcandre.lur...@redhat.com writes: >> >>> From: Marc-André Lureau >>> >>> Call ivshmem_setup_interrupts() with or without MSI, always allocate >>> msi_vectors that is going to be used in all case in

Re: [Qemu-devel] [PATCH 4/8] libqos: remove some leaks

2016-02-01 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Jan 29, 2016 at 4:43 PM, Markus Armbruster wrote: >> The existing users pass a func that saves dev, and free the saved dev >> later. Works as long as we call func() at most once. If multiple >> devices match, all but the last one are leaked. Can this

[Qemu-devel] [PATCH v2 4/8] libqos: remove some leaks

2016-02-01 Thread marcandre . lureau
From: Marc-André Lureau qpci_device_find() returns allocated data, don't leak it. Signed-off-by: Marc-André Lureau --- tests/libqos/pci.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c index 4e630c2..80b1a21 100644 --- a/tests/libqos/pci.c +++ b/t

[Qemu-devel] [PATCH v2 7/8] ivshmem: use a single eventfd callback, get rid of CharDriver

2016-02-01 Thread marcandre . lureau
From: Marc-André Lureau Simplify the interrupt handling by having a single callback on irq&msi cases. Remove usage of CharDriver, replace it with qemu_set_fd_handler(). Use event_notifier_test_and_clear() to read the eventfd. Before this patch, ivshmem writes the first byte received to s->intrst

Re: [Qemu-devel] [PATCH v6 2/8] device_tree: introduce load_device_tree_from_sysfs

2016-02-01 Thread Eric Auger
On 02/01/2016 05:27 PM, Rob Herring wrote: > On Mon, Feb 1, 2016 at 10:22 AM, Eric Auger wrote: >> Hi Rob, >> On 02/01/2016 05:15 PM, Rob Herring wrote: >>> On Mon, Feb 1, 2016 at 7:51 AM, Eric Auger wrote: This function returns the host device tree blob from sysfs (/proc/device-tree).

[Qemu-devel] [PATCH v2 5/8] ivshmem-test: test both msi & irq cases

2016-02-01 Thread marcandre . lureau
From: Marc-André Lureau Recent commit 660c97ee introduced a regression in irq case, make sure this code path is also tested. Signed-off-by: Marc-André Lureau --- tests/ivshmem-test.c | 53 1 file changed, 37 insertions(+), 16 deletions(-) d

[Qemu-devel] [PATCH v2 0/8] ivshmem: test msi=off, fix regressions, remove CharDriver

2016-02-01 Thread marcandre . lureau
From: Marc-André Lureau This is a ivshmem series with various bits: - add a test for msi=off regression (the fix is included in the series but was sent separatly to cc -stable) - get rid of CharDriver usage for eventfd & fix regression introduced by d0d7708ba by Daniel Berrange - fix some tes

[Qemu-devel] [PATCH v2 8/8] char: remove qemu_chr_open_eventfd

2016-02-01 Thread marcandre . lureau
From: Marc-André Lureau Broken since d0d7708ba29cbc, since the backend is NULL. And now no longer needed by ivshmem. Signed-off-by: Marc-André Lureau --- include/sysemu/char.h | 3 --- qemu-char.c | 13 - 2 files changed, 16 deletions(-) diff --git a/include/sysemu/cha

Re: [Qemu-devel] [PATCH v6 2/8] device_tree: introduce load_device_tree_from_sysfs

2016-02-01 Thread Eric Auger
Hi Rob, On 02/01/2016 05:15 PM, Rob Herring wrote: > On Mon, Feb 1, 2016 at 7:51 AM, Eric Auger wrote: >> This function returns the host device tree blob from sysfs >> (/proc/device-tree). It uses a recursive function inspired >> from dtc read_fstree. >> >> Signed-off-by: Eric Auger >> >> --- >>

[Qemu-devel] [PATCH v2 3/8] ivshmem-test: leak fixes

2016-02-01 Thread marcandre . lureau
From: Marc-André Lureau Add a cleanup_vm() function to free QPCIDevice & QPCIBus when cleaning up the IVState. Signed-off-by: Marc-André Lureau --- tests/ivshmem-test.c | 28 +--- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/tests/ivshmem-test.c b/tes

  1   2   3   >