Re: [Qemu-devel] [PATCH v2 08/13] block: Support meta dirty bitmap

2016-01-25 Thread Vladimir Sementsov-Ogievskiy
On 26.01.2016 09:25, Fam Zheng wrote: On Fri, 01/22 15:05, Vladimir Sementsov-Ogievskiy wrote: In my migration series I need iterators, get granularity, and something like hbitmap_count for meta bitmaps. You can add them here if you want, or I can add them in my series. Okay, I can add that.

Re: [Qemu-devel] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-01-25 Thread Jike Song
On 01/26/2016 05:30 AM, Alex Williamson wrote: > [cc +Neo @Nvidia] > > Hi Jike, > > On Mon, 2016-01-25 at 19:34 +0800, Jike Song wrote: >> On 01/20/2016 05:05 PM, Tian, Kevin wrote: >>> I would expect we can spell out next level tasks toward above >>> direction, upon which Alex can easily judge w

[Qemu-devel] [PATCH v2 14/13] block: More operations for meta dirty bitmap

2016-01-25 Thread Fam Zheng
Callers can create an iterator of meta bitmap with bdrv_dirty_meta_iter_new(), then use the bdrv_dirty_iter_* operations on it. Meta iterators are also counted by bitmap->active_iterators. Also add a couple of functions to retrieve granularity and count. Signed-off-by: Fam Zheng --- Vladimir,

Re: [Qemu-devel] trace in arch/x86/kernel/apic/apic.c:1309 setup_local_APIC

2016-01-25 Thread Stefan Priebe - Profihost AG
Hi, Am 26.01.2016 um 02:46 schrieb Han, Huaitong: > What is the host kernel version and host dmesg information? And does > the problem exist when you use latest kernel and QEMU to replace old > binary file? Guest and Host is both 4.1.15. You mean the complete dmesg output from host? What do you

Re: [Qemu-devel] [PATCH] iotests: Limit supported formats for 118

2016-01-25 Thread Markus Armbruster
Max Reitz writes: > Image formats used in test 118 need to support image creation. > > Reported-by: Markus Armbruster > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/118 | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tests/qemu-iotests/118 b/tests/qemu-iotest

Re: [Qemu-devel] [PATCH 00/10] Clean up page size handling for ppc 64-bit hash MMUs with TCG

2016-01-25 Thread Alexander Graf
> Am 26.01.2016 um 06:41 schrieb David Gibson : > >> On Mon, Jan 25, 2016 at 09:36:40PM +0100, Alexander Graf wrote: >> >> >>> On 01/25/2016 12:10 PM, David Gibson wrote: On Mon, Jan 25, 2016 at 04:15:42PM +1100, David Gibson wrote: Encoding of page sizes on 64-bit hash MMUs for Powe

Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125

2016-01-25 Thread Alexander Graf
> Am 26.01.2016 um 06:37 schrieb David Gibson : > >> On Mon, Jan 25, 2016 at 02:38:15PM +, Peter Maydell wrote: >>> On 25 January 2016 at 14:00, David Gibson >>> wrote: On Mon, Jan 25, 2016 at 11:59:22AM +, Peter Maydell wrote: > On 25 January 2016 at 11:19, David Gibson >>>

Re: [Qemu-devel] [RFC 0/10] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

2016-01-25 Thread Fam Zheng
On Tue, 01/26 06:24, w...@redhat.com wrote: > Wei Xu (10): > 'Segment', 'Chain' and 'Status' enumeration. > Initilize & Cleanup. > Chain lookup and packets caching. > Tcp general data coalescing > The draining timer > IPv4 checksum. > TCP control packet handling > Sanity check & Mor

[Qemu-devel] [PATCH v2] net/filter: Fix the output information for command 'info network'

2016-01-25 Thread zhanghailiang
The properties of netfilter object could be changed by 'qom-set' command, but the output of 'info network' command is not updated, because it got the old information through nf->info_str, it will not be updated while we change the value of netfilter's property. Here we split a helper function that

Re: [Qemu-devel] [PATCH v2 08/13] block: Support meta dirty bitmap

2016-01-25 Thread Fam Zheng
On Fri, 01/22 15:05, Vladimir Sementsov-Ogievskiy wrote: > >In my migration series I need iterators, get granularity, and > >something like hbitmap_count for meta bitmaps. You can add them > >here if you want, or I can add them in my series. Okay, I can add that. I have one more question on the

Re: [Qemu-devel] [PATCH v4 4/8] bcm2835_peripherals: add rollup device for bcm2835 peripherals

2016-01-25 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Monday, 25 January 2016 22:14 > > On Fri, Jan 15, 2016 at 3:58 PM, Andrew Baumann > wrote: [...] > > +static void bcm2835_peripherals_init(Object *obj) > > +{ > > +BCM2835PeripheralState *s = BCM2835_PERIPHERALS(obj); > > +

Re: [Qemu-devel] [PATCH v3 01/10] ppc: add IPMI support

2016-01-25 Thread Cédric Le Goater
On 01/26/2016 06:46 AM, David Gibson wrote: > On Mon, Jan 25, 2016 at 03:07:26PM +0100, Cédric Le Goater wrote: >> Open PowerNV systems use a BT device to communicate with the BMC. >> Provide support for it. > > Given that there's quite a bit of work to be done to make PowerNV > machines work unde

Re: [Qemu-devel] [PATCH v4 4/8] bcm2835_peripherals: add rollup device for bcm2835 peripherals

2016-01-25 Thread Peter Crosthwaite
On Fri, Jan 15, 2016 at 3:58 PM, Andrew Baumann wrote: > This device maintains all the non-CPU peripherals on bcm2835 (Pi1) > which are also present on bcm2836 (Pi2). It also implements the > private address spaces used for DMA and mailboxes. > > Signed-off-by: Andrew Baumann > --- > > Notes: >

Re: [Qemu-devel] [PATCH v4 2/8] bcm2835_property: add bcm2835 property channel

2016-01-25 Thread Peter Crosthwaite
On Fri, Jan 15, 2016 at 3:58 PM, Andrew Baumann wrote: > This sits behind the mailbox interface, and implements > request/response queries for system properties. The > framebuffer-related properties will be added in a later patch. > > Signed-off-by: Andrew Baumann > --- > > Notes: > v4: >

Re: [Qemu-devel] [PATCH v4 1/8] bcm2835_mbox: add BCM2835 mailboxes

2016-01-25 Thread Peter Crosthwaite
On Fri, Jan 15, 2016 at 3:58 PM, Andrew Baumann wrote: > This adds the system mailboxes which are used to communicate with a > number of GPU peripherals on Pi/Pi2. > > Signed-off-by: Andrew Baumann > --- > > Notes: > v3: > * #define register offsets > * rename mbox_init -> mbox_rese

Re: [Qemu-devel] [Qemu-ppc] Migrating decrementer (was: Re: [PATCH 4/4] target-ppc: ensure we include the decrementer value during migration)

2016-01-25 Thread David Gibson
On Mon, Jan 25, 2016 at 06:20:21PM +0100, BALATON Zoltan wrote: > On Mon, 25 Jan 2016, David Gibson wrote: > >Remember, we only ever compute the guest timebase value at the moment > >the guest requests it - actually maintaining a current timebase value > >makes sense in hardware, but would be nuts

Re: [Qemu-devel] [PATCH 00/10] Clean up page size handling for ppc 64-bit hash MMUs with TCG

2016-01-25 Thread David Gibson
On Mon, Jan 25, 2016 at 09:36:40PM +0100, Alexander Graf wrote: > > > On 01/25/2016 12:10 PM, David Gibson wrote: > >On Mon, Jan 25, 2016 at 04:15:42PM +1100, David Gibson wrote: > >>Encoding of page sizes on 64-bit hash MMUs for Power is rather arcane, > >>involving control bits in both the SLB

Re: [Qemu-devel] [PATCH v3 01/10] ppc: add IPMI support

2016-01-25 Thread David Gibson
On Mon, Jan 25, 2016 at 03:07:26PM +0100, Cédric Le Goater wrote: > Open PowerNV systems use a BT device to communicate with the BMC. > Provide support for it. Given that there's quite a bit of work to be done to make PowerNV machines work under qemu, this seems a little premature. > > Signed-of

Re: [Qemu-devel] [PULL 00/28] ppc-for-2.6 queue 20160125

2016-01-25 Thread David Gibson
On Mon, Jan 25, 2016 at 02:38:15PM +, Peter Maydell wrote: > On 25 January 2016 at 14:00, David Gibson wrote: > > On Mon, Jan 25, 2016 at 11:59:22AM +, Peter Maydell wrote: > >> On 25 January 2016 at 11:19, David Gibson > >> wrote: > >> > I think I've fixed it, but it's a bit hard to tel

[Qemu-devel] [PATCH V3] net: always walk through filters in reverse if traffic is egress

2016-01-25 Thread Li Zhijian
Previously, if we attach more than filters for one netdev, IN/OUT traffic pass through filters in a same order. ingress: netdev ->filter1 ->filter2 ->...filter[n] ->emulated device egress: emulated device ->filter1 ->filter2 ->...filter[n] ->netdev. But some scenes, we hope filters handle the egre

Re: [Qemu-devel] [PATCH v2 08/13] block: Support meta dirty bitmap

2016-01-25 Thread Fam Zheng
On Fri, 01/22 14:34, Vladimir Sementsov-Ogievskiy wrote: > >+void bdrv_create_meta_dirty_bitmap(BdrvDirtyBitmap *bitmap, > >+ int granularity) > >+{ > >+assert(!bitmap->meta); > >+bitmap->meta = hbitmap_create_meta(bitmap->bitmap, > >+

Re: [Qemu-devel] [PATCH v2 09/13] block: Add two dirty bitmap getters

2016-01-25 Thread Fam Zheng
On Fri, 01/22 14:45, Vladimir Sementsov-Ogievskiy wrote: > On 20.01.2016 09:11, Fam Zheng wrote: > >For dirty bitmap users to get the size and the name of a > >BdrvDirtyBitmap. > > > >Signed-off-by: Fam Zheng > >Reviewed-by: John Snow > >--- > > block/dirty-bitmap.c | 10 ++ > >

Re: [Qemu-devel] [PATCH V2] net: awlays walk through filters reversely if traffic is outgress

2016-01-25 Thread Yang Hongyang
On 01/26/2016 11:46 AM, Li Zhijian wrote: Previously, if we attach more than filters for one netdev, IN/OUT traffic pass through filters in the a same order. ingress: netdev ->filter1 ->filter2 ->...filter[n] ->emulated device outgress: emulated device ->filter1 ->filter2 ->...filter[n] ->netdev.

[Qemu-devel] [PATCH v9 12/16] vmdk: Return extent's file in bdrv_get_block_status

2016-01-25 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/vmdk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 61ed207..f8f7fcf 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1287,12 +1287,12 @@ static int64_t coroutine_fn vmdk_co_get_block_status(BlockDriv

[Qemu-devel] [PATCH v9 05/16] iscsi: Assign bs to file in iscsi_co_get_block_status

2016-01-25 Thread Fam Zheng
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/iscsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index e182557..9fe76f4 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -625,6 +625,9 @@ out: if (iTask.task

[Qemu-devel] [PATCH v9 16/16] iotests: Add "qemu-img map" test for VMDK extents

2016-01-25 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/059 | 10 ++ tests/qemu-iotests/059.out | 25 + 2 files changed, 35 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 index 0ded0c3..0332bbb 100755 --- a/tests/qemu-iotests/059 +++ b/test

[Qemu-devel] [PATCH v9 15/16] qemu-img: Make MapEntry a QAPI struct

2016-01-25 Thread Fam Zheng
The "flags" bit mask is expanded to two booleans, "data" and "zero"; "bs" is replaced with "filename" string. Refactor the merge conditions in img_map() into entry_mergeable(). Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- qapi/block-core.json | 27

[Qemu-devel] [PATCH v9 04/16] raw: Assign bs to file in raw_co_get_block_status

2016-01-25 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/raw-posix.c | 1 + block/raw_bsd.c | 1 + 2 files changed, 2 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index 3ef9b25..8866121 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -1861,6 +1861,7 @@ static int64_t coroutine_fn raw_

[Qemu-devel] [PATCH v9 14/16] qemu-img: In "map", use the returned "file" from bdrv_get_block_status

2016-01-25 Thread Fam Zheng
Now all drivers should return a correct "file", we can make use of it, even with the recursion into backing chain above. Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b

[Qemu-devel] [PATCH v9 09/16] vdi: Assign bs->file->bs to file in vdi_co_get_block_status

2016-01-25 Thread Fam Zheng
Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/vdi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/vdi.c b/block/vdi.c index 294c438..b403243 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -551,6 +551,7 @@ static int64_t coroutine_fn vdi_co_get_block_status(BlockDriv

[Qemu-devel] [PATCH v9 03/16] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status

2016-01-25 Thread Fam Zheng
Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index d4ea6b4..8babecd 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1349,6 +1349,7 @@ static int64_t coroutine_fn qcow2_co_get_block_st

[Qemu-devel] [PATCH v9 08/16] sheepdog: Assign bs to file in sd_co_get_block_status

2016-01-25 Thread Fam Zheng
Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/sheepdog.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index 2ea05a6..a0098c1 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -2739,6 +2739,9 @@ sd_co_get_block_status(BlockDriv

[Qemu-devel] [PATCH v9 11/16] vmdk: Fix calculation of block status's offset

2016-01-25 Thread Fam Zheng
"offset" is the offset of cluster and sector_num doesn't necessarily refer to the start of it, it should add index_in_cluster. Signed-off-by: Fam Zheng --- block/vmdk.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index e1d3e27..61ed207 10

[Qemu-devel] [PATCH v9 13/16] block: Use returned *file in bdrv_co_get_block_status

2016-01-25 Thread Fam Zheng
Now that all drivers return the right "file" pointer, we can use it. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- block/io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/io.c b/block/io.c index ea040be..343ff1f 100644 --- a/block/io.c +++ b/block/io.c @@

[Qemu-devel] [PATCH v9 02/16] qcow: Assign bs->file->bs to file in qcow_co_get_block_status

2016-01-25 Thread Fam Zheng
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/qcow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow.c b/block/qcow.c index 4202797..251910c 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -510,6 +510,7 @@ static int64_t coroutine_fn qco

[Qemu-devel] [PATCH v9 10/16] vpc: Assign bs->file->bs to file in vpc_co_get_block_status

2016-01-25 Thread Fam Zheng
Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/vpc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/vpc.c b/block/vpc.c index a070307..f504536 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -589,6 +589,7 @@ static int64_t coroutine_fn vpc_co_get_block_status(BlockDr

[Qemu-devel] [PATCH v9 06/16] parallels: Assign bs->file->bs to file in parallels_co_get_block_status

2016-01-25 Thread Fam Zheng
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/parallels.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/parallels.c b/block/parallels.c index e2de308..645521d 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -274,6 +274,7 @@ static

[Qemu-devel] [PATCH v9 07/16] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status

2016-01-25 Thread Fam Zheng
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/qed.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/qed.c b/block/qed.c index 8f6f841..404be1e 100644 --- a/block/qed.c +++ b/block/qed.c @@ -693,6 +693,7 @@ typedef struct { uint64_t pos

[Qemu-devel] [PATCH v9 01/16] block: Add "file" output parameter to block status query functions

2016-01-25 Thread Fam Zheng
The added parameter can be used to return the BDS pointer which the valid offset is referring to. Its value should be ignored unless BDRV_BLOCK_OFFSET_VALID in ret is set. Until block drivers fill in the right value, let's clear it explicitly right before calling .bdrv_get_block_status. The "bs->

[Qemu-devel] [PATCH v9 00/16] qemu-img map: Allow driver to return file of the allocated block

2016-01-25 Thread Fam Zheng
v9: 01: Add comment for the new parameter, and remove the superfluous reset of 'file'. [Kevin] 04: bs => bs->file->bs. [Kevin] 11: Split the bugfix. [Kevin] 15: Don't corrupt 059.out. [Max] v8: Fix patch 15. [Max] Add Max's rev-by in patch 1. v7: Rebase, update patch 1 for tw

Re: [Qemu-devel] [PATCH V2] net: awlays walk through filters reversely if traffic is outgress

2016-01-25 Thread Eric Blake
On 01/25/2016 08:46 PM, Li Zhijian wrote: In the subject: s/awlays/always/ s/reversely/in reverse/ s/outgress/egress/ > Previously, if we attach more than filters for one netdev, IN/OUT traffic pass > through filters in the a same order. > ingress: netdev ->filter1 ->filter2 ->...filter[n] ->emu

[Qemu-devel] [PATCH V2] net: awlays walk through filters reversely if traffic is outgress

2016-01-25 Thread Li Zhijian
Previously, if we attach more than filters for one netdev, IN/OUT traffic pass through filters in the a same order. ingress: netdev ->filter1 ->filter2 ->...filter[n] ->emulated device outgress: emulated device ->filter1 ->filter2 ->...filter[n] ->netdev. But some scenes, we hope filters handle th

Re: [Qemu-devel] [PATCH v8 15/15] iotests: Add "qemu-img map" test for VMDK extents

2016-01-25 Thread Fam Zheng
On Mon, 01/25 15:11, Max Reitz wrote: > On 25.01.2016 03:44, Fam Zheng wrote: > > Signed-off-by: Fam Zheng > > --- > > tests/qemu-iotests/059 | 10 ++ > > tests/qemu-iotests/059.out | 26 ++ > > 2 files changed, 36 insertions(+) > > > > diff --git a/tests/qemu

Re: [Qemu-devel] [PATCH v8 11/15] vmdk: Return extent's file in bdrv_get_block_status

2016-01-25 Thread Fam Zheng
On Mon, 01/25 14:28, Kevin Wolf wrote: > Am 25.01.2016 um 03:44 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng > > Reviewed-by: Max Reitz > > --- > > block/vmdk.c | 10 ++ > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/block/vmdk.c b/block/vmdk.c > > i

Re: [Qemu-devel] [PATCH RFC 6/7] net/filter: Add a default filter to each netdev

2016-01-25 Thread Hailiang Zhang
On 2016/1/26 11:18, Jason Wang wrote: On 01/25/2016 03:22 PM, Hailiang Zhang wrote: On 2016/1/25 13:18, Jason Wang wrote: On 01/22/2016 04:36 PM, zhanghailiang wrote: We add each netdev a default buffer filter, which the name is 'nop', and the default buffer filter is disabled, so it has n

Re: [Qemu-devel] [PATCH v8 04/15] raw: Assign bs to file in raw_co_get_block_status

2016-01-25 Thread Fam Zheng
On Mon, 01/25 14:17, Kevin Wolf wrote: > Am 25.01.2016 um 03:44 hat Fam Zheng geschrieben: > > diff --git a/block/raw_bsd.c b/block/raw_bsd.c > > index 9a8933b..fd355d5 100644 > > --- a/block/raw_bsd.c > > +++ b/block/raw_bsd.c > > @@ -119,6 +119,7 @@ static int64_t coroutine_fn > > raw_co_get_blo

Re: [Qemu-devel] [PATCH v8 01/15] block: Add "file" output parameter to block status query functions

2016-01-25 Thread Fam Zheng
On Tue, 01/26 11:27, Fam Zheng wrote: > On Mon, 01/25 14:04, Kevin Wolf wrote: > > Am 25.01.2016 um 03:44 hat Fam Zheng geschrieben: > > > diff --git a/block/vvfat.c b/block/vvfat.c > > > index 2ea5a4a..b8d29e1 100644 > > > --- a/block/vvfat.c > > > +++ b/block/vvfat.c > > > @@ -2884,7 +2884,7 @@ s

Re: [Qemu-devel] [PATCH RFC 1/7] net/filter: Fix the output information for command 'info network'

2016-01-25 Thread Hailiang Zhang
On 2016/1/26 11:05, Jason Wang wrote: On 01/25/2016 01:58 PM, Hailiang Zhang wrote: On 2016/1/25 13:01, Jason Wang wrote: On 01/22/2016 04:36 PM, zhanghailiang wrote: The properties of netfilter object could be changed by 'qom-set' command, but the output of 'info network' command is not u

Re: [Qemu-devel] [PATCH] net/filter: Fix the output information for command 'info network'

2016-01-25 Thread Hailiang Zhang
On 2016/1/26 4:49, Eric Blake wrote: On 01/25/2016 02:12 AM, zhanghailiang wrote: The properties of netfilter object could be changed by 'qom-set' command, but the output of 'info network' command is not updated, because it got the old information through nf->info_str, it will not be updated whi

Re: [Qemu-devel] [PATCH v8 01/15] block: Add "file" output parameter to block status query functions

2016-01-25 Thread Fam Zheng
On Mon, 01/25 14:04, Kevin Wolf wrote: > Am 25.01.2016 um 03:44 hat Fam Zheng geschrieben: > > The added parameter can be used to return the BDS pointer which the > > valid offset is referring to. Its value should be ignored unless > > BDRV_BLOCK_OFFSET_VALID in ret is set. > > > > Until block dri

Re: [Qemu-devel] [PATCH RFC 6/7] net/filter: Add a default filter to each netdev

2016-01-25 Thread Jason Wang
On 01/25/2016 03:22 PM, Hailiang Zhang wrote: > On 2016/1/25 13:18, Jason Wang wrote: >> >> >> On 01/22/2016 04:36 PM, zhanghailiang wrote: >>> We add each netdev a default buffer filter, which the name is >>> 'nop', and the default buffer filter is disabled, so it has >>> no side effect for pack

Re: [Qemu-devel] [PATCH] vmdk: Fix converting to streamOptimized

2016-01-25 Thread Fam Zheng
On Mon, 01/25 12:16, Kevin Wolf wrote: > Am 25.01.2016 um 03:26 hat Fam Zheng geschrieben: > > Commit d62d9dc4b8 lifted streamOptimized images's version to 3, but we > > now refuse to open version 3 images read-write. We need to make > > streamOptimized an exception to allow converting to it. This

Re: [Qemu-devel] [PATCH] net: walk through filters reversely if traffic is outgress

2016-01-25 Thread Jason Wang
On 01/25/2016 02:27 PM, Li Zhijian wrote: > > > On 01/25/2016 12:58 PM, Jason Wang wrote: >> >> >> On 01/22/2016 04:11 PM, Li Zhijian wrote: >>> Previously, if the netdev has more than one filters, the ingress >>> or outgress traffic pass the filter in the same order. this patch >>> is to make th

Re: [Qemu-devel] [PATCH RFC 1/7] net/filter: Fix the output information for command 'info network'

2016-01-25 Thread Jason Wang
On 01/25/2016 01:58 PM, Hailiang Zhang wrote: > On 2016/1/25 13:01, Jason Wang wrote: >> >> >> On 01/22/2016 04:36 PM, zhanghailiang wrote: >>> The properties of netfilter object could be changed by 'qom-set' >>> command, but the output of 'info network' command is not updated, >>> because it got

Re: [Qemu-devel] [PATCH v2 1/3] linux-user/mmap.c: Set prot page flags for the correct region in mmap_frag()

2016-01-25 Thread Chen Gang
Firstly, thank you very much to still focus on this patch, which will be much helpful for my current work! And I modified some code, but did not send patches to upstream, e.g. sw_64 related code, use TARGET_PAGE_SIZE instead of HOST_PAGE_SIZE ...). I skipped MAP_SHARED with PROT_WRITE check t

Re: [Qemu-devel] [Questions] Several questions about incremental backup

2016-01-25 Thread Rudy Zhang
On 16/1/26 上午3:19, John Snow wrote: > > > On 01/25/2016 02:35 AM, Rudy Zhang wrote: >> I am reading and testing the function: incremental backup in qemu-2.5. >> But I have serveral questions about it. >> 1. If I want to start image backup, at first I need to start full mode backup >>and the

Re: [Qemu-devel] trace in arch/x86/kernel/apic/apic.c:1309 setup_local_APIC

2016-01-25 Thread Han, Huaitong
What is the host kernel version and host dmesg information? And does the problem exist when you use latest kernel and QEMU to replace old binary file? On Mon, 2016-01-25 at 14:51 +0100, Stefan Priebe - Profihost AG wrote: > Hi, > > while running qemu 2.4 on whestmere CPUs i'm pretty often getting

Re: [Qemu-devel] COLO: how to flip a secondary to a primary?

2016-01-25 Thread Li Zhijian
On 01/26/2016 04:20 AM, Dr. David Alan Gilbert wrote: * Li Zhijian (lizhij...@cn.fujitsu.com) wrote: On 01/25/2016 09:32 AM, Wen Congyang wrote: f) I've not thought about the colo-proxy that much yet - I guess that existing connections need to keep their sequence number offset bu

Re: [Qemu-devel] COLO: how to flip a secondary to a primary?

2016-01-25 Thread Wen Congyang
On 01/26/2016 02:59 AM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> On 01/23/2016 03:35 AM, Dr. David Alan Gilbert wrote: >>> Hi, >>> I've been looking at what's needed to add a new secondary after >>> a primary failed; from the block side it doesn't look as ha

[Qemu-devel] [RFC Patch 10/10] Statistics.

2016-01-25 Thread wexu
From: Wei Xu Signed-off-by: Wei Xu --- hw/net/virtio-net.c| 49 +++--- include/hw/virtio/virtio.h | 35 + 2 files changed, 81 insertions(+), 3 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c ind

[Qemu-devel] [RFC Patch 08/10] Sanity check & More bypass cases check.

2016-01-25 Thread wexu
1. IP options & IP fragment should be bypassed. 2. Sanity size check to prevent buffer overflow attack. Signed-off-by: Wei Xu --- hw/net/virtio-net.c | 44 1 file changed, 44 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index

[Qemu-devel] [RFC Patch 07/10] TCP control packet handling.

2016-01-25 Thread wexu
From: Wei Xu All the 'SYN' packets will be bypassed, and flag with 'FIN/RST' set will signal all the cached packets in the same connection to be purged, this is to avoid out of data on the line. Signed-off-by: Wei Xu --- hw/net/virtio-net.c | 66

[Qemu-devel] [RFC Patch 06/10] IPv4 checksum.

2016-01-25 Thread wexu
Signed-off-by: Wei Xu --- hw/net/virtio-net.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 8da2815..1ca3dd5 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -1630,6 +1630,18 @@ static int virtio_net_load_devi

[Qemu-devel] [RFC Patch 04/10] Tcp general data coalescing, the parameters is a little bit horrible, it's complicated to read, should can be optimized later.

2016-01-25 Thread wexu
Signed-off-by: Wei Xu --- hw/net/virtio-net.c | 125 +++- 1 file changed, 124 insertions(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 7a6cd4c..d005a56 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -

[Qemu-devel] [RFC Patch 03/10] Chain lookup and packets caching.

2016-01-25 Thread wexu
Looking up chain by protocol and invoke coalescing callback, cache the packet if can't handle it. Signed-off-by: Wei Xu --- hw/net/virtio-net.c | 171 +++- 1 file changed, 170 insertions(+), 1 deletion(-) diff --git a/hw/net/virtio-net.c b/hw/net/

[Qemu-devel] [RFC Patch 02/10] Initilize & Cleanup.

2016-01-25 Thread wexu
Signed-off-by: Wei Xu --- hw/net/virtio-net.c| 22 ++ include/hw/virtio/virtio-net.h | 1 + 2 files changed, 23 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index a877614..4e9458e 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c

[Qemu-devel] [RFC Patch 09/10] IPv6 support.

2016-01-25 Thread wexu
1. Callback for IPv6 2. Filter & Sanity Check. Signed-off-by: Wei Xu --- hw/net/virtio-net.c | 104 +++- 1 file changed, 102 insertions(+), 2 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index 55e8e99..362f304 100644 --- a/h

[Qemu-devel] [RFC Patch 01/10] 'Segment', 'Chain' and 'Status' enumeration data structure.

2016-01-25 Thread wexu
Signed-off-by: Wei Xu --- include/hw/virtio/virtio.h | 32 1 file changed, 32 insertions(+) diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h index 205fadf..1383220 100644 --- a/include/hw/virtio/virtio.h +++ b/include/hw/virtio/virtio.h @@ -12

[Qemu-devel] [RFC 0/10] Support Receive-Segment-Offload(RSC) for WHQL test of Window guest

2016-01-25 Thread wexu
From: Wei Xu This patch is to support WHQL test for Windows guest, while this feature also benifits other guest works as a kernel 'gro' like feature with userspace implementation. Feature information: http://msdn.microsoft.com/en-us/library/windows/hardware/jj853324 Both IPv4 and IPv6 are sup

[Qemu-devel] [RFC Patch 05/10] The draining timer, create a timer to purge the packets from the cached pool.

2016-01-25 Thread wexu
Signed-off-by: Wei Xu --- hw/net/virtio-net.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index d005a56..8da2815 100644 --- a/hw/net/virtio-net.c +++ b/hw/net/virtio-net.c @@ -48,12 +48,17 @@ #define MAX_

Re: [Qemu-devel] [PATCH v2 08/13] block: Support meta dirty bitmap

2016-01-25 Thread John Snow
On 01/20/2016 01:11 AM, Fam Zheng wrote: > The added group of operations enables tracking of the changed bits in > the dirty bitmap. > > Signed-off-by: Fam Zheng Reviewed-by: John Snow > --- > block/dirty-bitmap.c | 51 > > include/block

Re: [Qemu-devel] [PATCH v1 08/22] migration: convert post-copy to use QIOChannelBuffer

2016-01-25 Thread Daniel P. Berrange
On Mon, Jan 25, 2016 at 07:38:59PM +, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > The post-copy code does some I/O to/from an intermediate > > in-memory buffer rather than direct to the underlying > > I/O channel. Switch this code to use QIOChannelBuffe

Re: [Qemu-devel] [PATCH for v2.4.1] exec: fix a glitch in checking dma r/w access

2016-01-25 Thread Paolo Bonzini
On 25/01/2016 19:19, P J P wrote: > +-- On Mon, 25 Jan 2016, Paolo Bonzini wrote --+ > | > static inline bool memory_access_is_direct(MemoryRegion *mr, bool > is_write) > | > { > | > if (memory_region_is_ram(mr)) { > | > -return !(is_write && mr->readonly); > | > +return (

Re: [Qemu-devel] [RFC PATCH 2/4] configure: introduce --extra-libs

2016-01-25 Thread Paolo Bonzini
On 25/01/2016 19:15, Alex Bennée wrote: > > Paolo Bonzini writes: > >> On 25/01/2016 17:49, Alex Bennée wrote: >>> If for example you want to use the thread sanitizer you want to ensure all >>> binaries are linked with the library: >>> >>> ./configure ${TARGETS} --cc=gcc-5 --cxx=g++-5 \ >>>

Re: [Qemu-devel] [PATCH 00/13] cuda: misc fixes and cleanups

2016-01-25 Thread Hervé Poussineau
Hi, Le 25/01/2016 10:58, Alyssa Milburn a écrit : On Sat, Jan 23, 2016 at 09:39:57PM +0100, Hervé Poussineau wrote: Hi, This patchset cleans up a little bit the Apple CUDA emulation: - correctly reject unknown commands - correctly reject commands with wrong parameters - support changing the fr

Re: [Qemu-devel] [PATCH 1/8] nbd: client_close on error in nbd_co_client_start

2016-01-25 Thread Daniel P. Berrange
On Mon, Jan 25, 2016 at 07:41:08PM +0100, Max Reitz wrote: > Use client_close() if an error in nbd_co_client_start() occurs instead > of manually inlining parts of it. This fixes an assertion error on the > server side if nbd_negotiate() fails. > > Signed-off-by: Max Reitz > --- > nbd/server.c |

Re: [Qemu-devel] [RFC PATCH 3/4] include/qemu/atomic.h: default to __atomic functions

2016-01-25 Thread Paolo Bonzini
On 25/01/2016 19:23, Alex Bennée wrote: >>> +}) >>> + >>> +#define atomic_mb_set(ptr, i) ((void)atomic_xchg(ptr, i)) >>> +#define atomic_mb_read(ptr) \ >>> +({ \ >>> +typeof(*ptr) _val;

Re: [Qemu-devel] [PATCH v2 06/13] HBitmap: Introduce "meta" bitmap to track bit changes

2016-01-25 Thread John Snow
On 01/20/2016 01:11 AM, Fam Zheng wrote: > Upon each bit toggle, the corresponding bit in the meta bitmap will be > set. > > Signed-off-by: Fam Zheng Reviewed-by: John Snow > --- > include/qemu/hbitmap.h | 17 + > util/hbitmap.c | 66 > ++

Re: [Qemu-devel] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-01-25 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Tuesday, January 26, 2016 5:45 AM > > > > > - interacts with kvmgt.c > > > > > > > > > vgpu instance management > > > > > > { in i915 } > > > > > > - path, create/destroy > > > > > > > Yes, and since you're creating and destroying the vgpu

Re: [Qemu-devel] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-01-25 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Tuesday, January 26, 2016 5:30 AM > > [cc +Neo @Nvidia] > > Hi Jike, > > On Mon, 2016-01-25 at 19:34 +0800, Jike Song wrote: > > On 01/20/2016 05:05 PM, Tian, Kevin wrote: > > > I would expect we can spell out next level tasks t

Re: [Qemu-devel] VFIO based vGPU(was Re: [Announcement] 2015-Q3 release of XenGT - a Mediated ...)

2016-01-25 Thread Alex Williamson
[cc +Neo @Nvidia] Hi Jike, On Mon, 2016-01-25 at 19:34 +0800, Jike Song wrote: > On 01/20/2016 05:05 PM, Tian, Kevin wrote: > > I would expect we can spell out next level tasks toward above > > direction, upon which Alex can easily judge whether there are > > some common VFIO framework changes th

Re: [Qemu-devel] [PATCH] net/filter: Fix the output information for command 'info network'

2016-01-25 Thread Eric Blake
On 01/25/2016 02:12 AM, zhanghailiang wrote: > The properties of netfilter object could be changed by 'qom-set' > command, but the output of 'info network' command is not updated, > because it got the old information through nf->info_str, it will > not be updated while we change the value of netfil

Re: [Qemu-devel] [PATCH 5/8] iotests: Make _filter_nbd drop log lines

2016-01-25 Thread Eric Blake
On 01/25/2016 11:41 AM, Max Reitz wrote: > The NBD log lines ("/your/source/dir/nbd.c:function():line: error") This line doesn't match the pre- or post-patch sed pattern. Something that would match would be "/your/source/dir/nbd/file.c:function():line: error". Maybe you should tweak the commit m

Re: [Qemu-devel] [PATCH v2 02/13] typedefs: Add BdrvDirtyBitmap

2016-01-25 Thread John Snow
On 01/20/2016 01:11 AM, Fam Zheng wrote: > Following patches to refactor and move block dirty bitmap code could use > this. > > Signed-off-by: Fam Zheng > --- > include/block/block.h | 3 +-- > include/qemu/typedefs.h | 1 + > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git

Re: [Qemu-devel] [PATCH 00/10] Clean up page size handling for ppc 64-bit hash MMUs with TCG

2016-01-25 Thread Alexander Graf
On 01/25/2016 12:10 PM, David Gibson wrote: On Mon, Jan 25, 2016 at 04:15:42PM +1100, David Gibson wrote: Encoding of page sizes on 64-bit hash MMUs for Power is rather arcane, involving control bits in both the SLB and HPTE. At present we support a few of the options, but far fewer than real

Re: [Qemu-devel] [PATCH 8/8] iotests: Add test for a nonexistent NBD export

2016-01-25 Thread Eric Blake
On 01/25/2016 11:41 AM, Max Reitz wrote: > Trying to connect to a nonexistent NBD export should not crash the > server. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/143 | 73 > ++ > tests/qemu-iotests/143.out | 7 + > tests/qemu-io

Re: [Qemu-devel] [PATCH 4/8] iotests: Move _filter_nbd into common.filter

2016-01-25 Thread Eric Blake
On 01/25/2016 11:41 AM, Max Reitz wrote: > _filter_nbd can be useful for other NBD tests, too, therefore it should > reside in common.filter. > > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/083 | 12 > tests/qemu-iotests/common.filter | 12 > 2 files c

Re: [Qemu-devel] [PATCH 3/8] iotests: Change coding style of _filter_nbd in 083

2016-01-25 Thread Eric Blake
On 01/25/2016 11:41 AM, Max Reitz wrote: > In order to be able to move _filter_nbd to common.filter in the next > patch, its coding style needs to be adapted to that of common.filter. > That means, we have to convert tabs to four spaces, adjust the alignment > of the last line (done with spaces alr

Re: [Qemu-devel] [PATCH 1/8] nbd: client_close on error in nbd_co_client_start

2016-01-25 Thread Eric Blake
On 01/25/2016 11:41 AM, Max Reitz wrote: > Use client_close() if an error in nbd_co_client_start() occurs instead > of manually inlining parts of it. This fixes an assertion error on the > server side if nbd_negotiate() fails. > > Signed-off-by: Max Reitz > --- > nbd/server.c | 3 +-- > 1 file c

Re: [Qemu-devel] [PULL 01/28] target-ppc: Use sensible POWER8/POWER8E versions

2016-01-25 Thread Alexander Graf
On 01/25/2016 08:26 PM, Thomas Huth wrote: On 25.01.2016 20:14, Alexander Graf wrote: On 01/25/2016 02:15 AM, David Gibson wrote: From: Benjamin Herrenschmidt We never released anything older than POWER8 DD2.0 and POWER8E DD2.1, so let's use these versions, without that some firmware or Li

Re: [Qemu-devel] COLO: how to flip a secondary to a primary?

2016-01-25 Thread Dr. David Alan Gilbert
* Li Zhijian (lizhij...@cn.fujitsu.com) wrote: > > > On 01/25/2016 09:32 AM, Wen Congyang wrote: > >>>f) I've not thought about the colo-proxy that much yet - I guess that > >>> existing connections need to keep their sequence number offset but > > Strictly speaking, after failover, we

Re: [Qemu-devel] [PATCH 05/10] target-ppc: Use actual page size encodings from HPTE

2016-01-25 Thread Alexander Graf
On 01/25/2016 06:15 AM, David Gibson wrote: At present the 64-bit hash MMU code uses information from the SLB to determine the page size of a translation. We do need that information to correctly look up the hash table. However the MMU also allows a possibly larger page size to be encoded int

[Qemu-devel] [PULL 04/13] fdc: add drive type qapi enum

2016-01-25 Thread John Snow
Change the floppy drive type to a QAPI enum type, to allow us to specify the floppy drive type from the CLI in a forthcoming patch. Reviewed-by: Eric Blake Signed-off-by: John Snow Message-id: 1453495865-9649-4-git-send-email-js...@redhat.com --- hw/block/fdc.c | 80

[Qemu-devel] [PULL 05/13] fdc: add disk field

2016-01-25 Thread John Snow
Currently, 'drive' is used both to represent the current diskette type as well as the current drive type. This patch adds a 'disk' field that is updated explicitly to match the type of the disk. As of this patch, disk and drive are always the same, but forthcoming patches to change the behavior o

[Qemu-devel] [PULL 07/13] fdc: add pick_drive

2016-01-25 Thread John Snow
Split apart pick_geometry by creating a pick_drive routine that will only ever called during device bring-up instead of relying on pick_geometry to be used in both cases. With this change, the drive field is changed to be 'write once'. It is not altered after the initialization routines exit. med

[Qemu-devel] [PULL 12/13] qtest/fdc: Support for 2.88MB drives

2016-01-25 Thread John Snow
The old test assumes a 1.44MB drive. Assert that the QEMU default drive is now either 1.44 or 2.88. Reviewed-by: Eric Blake Signed-off-by: John Snow Message-id: 1453495865-9649-12-git-send-email-js...@redhat.com --- tests/fdc-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

[Qemu-devel] [PULL 03/13] fdc: reduce number of pick_geometry arguments

2016-01-25 Thread John Snow
Modify this function to operate directly on FDrive objects instead of unpacking and passing all of those parameters manually. Reduces the complexity in the caller and reduces the number of args to just one. Reviewed-by: Eric Blake Signed-off-by: John Snow Message-id: 1453495865-9649-3-git-send-e

Re: [Qemu-devel] [PATCH v11 2/7] hw/ptimer: Perform counter wrap around if timer already expired

2016-01-25 Thread Dmitry Osipenko
Hello Peter, 24.01.2016 08:29, Peter Crosthwaite пишет: [snip] +if (expired && (counter != 0)) { +/* Wrap around periodic counter. */ +counter = s->limit - counter % s->limit; +} Noticed another nit here. This should be: counter = s->

[Qemu-devel] [PULL 08/13] fdc: Add fallback option

2016-01-25 Thread John Snow
Currently, QEMU chooses a drive type automatically based on the inserted media. If there is no disk inserted, it chooses a 1.44MB drive type. Change this behavior to be configurable, but leave it defaulted to 1.44. This is not earnestly intended to be used by a user or a management library, but r

[Qemu-devel] [PULL 10/13] fdc: add physical disk sizes

2016-01-25 Thread John Snow
2.88MB capable drives can accept 1.44MB floppies, for instance. To rework the pick_geometry function, we need to know if our current drive can even accept the type of disks we're considering. NB: This allows us to distinguish between all of the "total sectors" collisions between 1.20MB and 1.44MB

  1   2   3   >