[Qemu-devel] [PATCH v4 5/7] vmxnet3: The vmxnet3 device is a PCIE endpoint

2015-12-23 Thread Shmulik Ladkani
Report the 'express endpoint' capability if on a PCIE bus. Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 53 - 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 14d4dcb..7ded287 1006

[Qemu-devel] [PATCH v4 6/7] vmxnet3: Introduce 'x-disable-pcie' back-compat property

2015-12-23 Thread Shmulik Ladkani
Following the previous patch which changed vmxnet3 to be a pci express device, this patch introduces a boolean property 'x-disable-pcie' whose default is false. Setting 'x-disable-pcie' to 'on' preserves the old 'pci device' (non express) behavior. This allows migration to older versions. Signed-

[Qemu-devel] [PATCH v4 4/7] vmxnet3: coding: Introduce VMXNET3Class

2015-12-23 Thread Shmulik Ladkani
Introduce a class type for vmxnet3, and the usual DEVICE_CLASS/DEVICE_GET_CLASS macros. No semantic change. Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index d1fe888..14d4dcb 100644 --- a

[Qemu-devel] [PATCH v4 7/7] vmxnet3: Report the Device Serial Number capability

2015-12-23 Thread Shmulik Ladkani
Report the DSN extended PCI capability at 0x100. DSN value is a transformation of device MAC address, as calculated by VMware virtual hardware. DSN is reported only if device is pcie. Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 28 ++-- 1 file changed, 26 inser

[Qemu-devel] [PATCH v4 3/7] vmxnet3: Introduce 'x-old-msi-offsets' back-compat property

2015-12-23 Thread Shmulik Ladkani
Following the previous patches, where vmxnet3's pci's msi/msix capability offsets and msix's PBA table offsets have been changed, this patch introduces a boolean property 'x-old-msi-offsets' to vmxnet3, whose default is false. Setting 'x-old-msi-offsets' to 'on' preserves the old offsets behavior,

[Qemu-devel] [PATCH v4 1/7] vmxnet3: Change offsets of msi/msix pci capabilities

2015-12-23 Thread Shmulik Ladkani
Place device reported PCI capabilities at the same offsets as placed by the VMware virtual hardware: MSI at [84], MSI-X at [9c]. Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/v

[Qemu-devel] [PATCH v4 2/7] vmxnet3: Change the offset of the MSIX PBA table

2015-12-23 Thread Shmulik Ladkani
Place the PBA table at 0x1000, as placed by VMware virtual hardware. Signed-off-by: Shmulik Ladkani --- hw/net/vmxnet3.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index d323895..97f0aea 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/

[Qemu-devel] [PATCH v4 0/7] vmxnet3: Fine-tune device capabilities

2015-12-23 Thread Shmulik Ladkani
Various fixes to what the vmxnet3 device reports in its PCI configuration space, in order to be aligned with VMware virtual hardware exposed by ESXi/Workstation. Since v3: Place back-compat flags into HW_COMPAT_2_5 Since v2: Introduce the compatability properties in separate patches, pe

Re: [Qemu-devel] [PATCH] change type of pci_bridge_initfn() to void

2015-12-23 Thread Michael S. Tsirkin
On Thu, Dec 24, 2015 at 11:39:00AM +0800, Cao jin wrote: > Hi mst > > On 12/23/2015 09:38 PM, Michael S. Tsirkin wrote: > >On Wed, Dec 23, 2015 at 04:53:21PM +0800, Cao jin wrote: > >>Hi mst > >>friendly ping again... > > > >This does not work since then this function can not be > >used as an init

Re: [Qemu-devel] [PATCH v3 2/2] tests: update expected SSDT for floppy changes

2015-12-23 Thread Michael S. Tsirkin
On Wed, Dec 23, 2015 at 08:51:45PM +0300, Roman Kagan wrote: > On Wed, Dec 23, 2015 at 06:47:16PM +0100, Igor Mammedov wrote: > > On Wed, 23 Dec 2015 20:20:54 +0300 > > Roman Kagan wrote: > > > > ... two 1.44M drives with bogus geometry for q35. > > > > > > This one is a bug in my patch, indeed:

[Qemu-devel] [PATCH v4 14/14] iotests: Add "qemu-img map" test for VMDK extents

2015-12-23 Thread Fam Zheng
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- tests/qemu-iotests/059 | 10 ++ tests/qemu-iotests/059.out | 38 ++ 2 files changed, 48 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 i

[Qemu-devel] [PATCH v4 11/14] vmdk: Return extent's file in bdrv_get_block_status

2015-12-23 Thread Fam Zheng
Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/vmdk.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index f5a56fd..b60a5af 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1265,6 +1265,7 @@ static int64_t coroutine_fn

[Qemu-devel] [PATCH v4 04/14] raw: Assign bs to file in raw_co_get_block_status

2015-12-23 Thread Fam Zheng
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/raw-posix.c | 1 + block/raw_bsd.c | 1 + 2 files changed, 2 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index 6fc0b71..344272f 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c

[Qemu-devel] [PATCH v4 09/14] vdi: Assign bs->file->bs to file in vdi_co_get_block_status

2015-12-23 Thread Fam Zheng
Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/vdi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/vdi.c b/block/vdi.c index 2199fd3..6b1a57b 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -550,6 +550,7 @@ static int64_t coroutine_fn vdi_co_get_block_status(BlockDriv

[Qemu-devel] [PATCH v4 13/14] qemu-img: Make MapEntry a QAPI struct

2015-12-23 Thread Fam Zheng
The "flags" bit mask is expanded to two booleans, "data" and "zero"; "bs" is replaced with "filename" string. Refactor the merge conditions in img_map() into entry_mergeable(). Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- qapi/block-core.json | 27

[Qemu-devel] [PATCH v4 01/14] block: Add "file" output parameter to block status query functions

2015-12-23 Thread Fam Zheng
The added parameter can be used to return the BDS pointer which the valid offset is referring to. It's value should be ignored unless BDRV_BLOCK_OFFSET_VALID in ret is set. Until block drivers fill in the right value, let's clear it explicitly right before calling .bdrv_get_block_status. Reviewed

[Qemu-devel] [PATCH v4 10/14] vpc: Assign bs->file->bs to file in vpc_co_get_block_status

2015-12-23 Thread Fam Zheng
Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/vpc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/vpc.c b/block/vpc.c index 912f5d0..412ff41 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -588,6 +588,7 @@ static int64_t coroutine_fn vpc_co_get_block_status(BlockDr

[Qemu-devel] [PATCH v4 08/14] sheepdog: Assign bs to file in sd_co_get_block_status

2015-12-23 Thread Fam Zheng
Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/sheepdog.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index 0f6789e..d5e7ff8 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -2740,6 +2740,9 @@ sd_co_get_block_status(BlockDriv

[Qemu-devel] [PATCH v4 07/14] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status

2015-12-23 Thread Fam Zheng
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/qed.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/qed.c b/block/qed.c index a6bbd8b..03af9c1 100644 --- a/block/qed.c +++ b/block/qed.c @@ -692,6 +692,7 @@ typedef struct { uint64_t pos

[Qemu-devel] [PATCH v4 12/14] qemu-img: In "map", use the returned "file" from bdrv_get_block_status

2015-12-23 Thread Fam Zheng
Now all drivers should return a correct "file", we can make use of it, even with the recursion into backing chain above. Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- qemu-img.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-img.c b

[Qemu-devel] [PATCH v4 02/14] qcow: Assign bs->file->bs to file in qcow_co_get_block_status

2015-12-23 Thread Fam Zheng
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/qcow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow.c b/block/qcow.c index 558f443..b59383f 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -509,6 +509,7 @@ static int64_t coroutine_fn qco

[Qemu-devel] [PATCH v4 06/14] parallels: Assign bs->file->bs to file in parallels_co_get_block_status

2015-12-23 Thread Fam Zheng
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/parallels.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/parallels.c b/block/parallels.c index d83246b..129668b 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -273,6 +273,7 @@ static

[Qemu-devel] [PATCH v4 03/14] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status

2015-12-23 Thread Fam Zheng
Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 7096a29..da74eb7 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1348,6 +1348,7 @@ static int64_t coroutine_fn qcow2_co_get_block_st

[Qemu-devel] [PATCH v4 05/14] iscsi: Assign bs to file in iscsi_co_get_block_status

2015-12-23 Thread Fam Zheng
Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi Signed-off-by: Fam Zheng --- block/iscsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 2d1e230..8c7f1b3 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -625,6 +625,9 @@ out: if (iTask.task

[Qemu-devel] [PATCH v4 00/14] qemu-img map: Allow driver to return file of the allocated block

2015-12-23 Thread Fam Zheng
v4: Rebase and resend, adding Eric's and Stefan's reviewed-by. Fix one typo in patch 13. Drop previous patch 14 for a later rework because it is not a hard requirement, but it is pending on Eric's QAPI-to-JSON visitor series: https://lists.gnu.org/archive/html/qemu-devel/2015-12/

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Denis V. Lunev
On 12/22/2015 07:46 PM, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this series adds locking to qcow2 that refuses to access the image read-write from two

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Denis V. Lunev
On 12/24/2015 08:41 AM, Denis V. Lunev wrote: On 12/24/2015 02:19 AM, Max Reitz wrote: On 23.12.2015 04:14, Fam Zheng wrote: On Tue, 12/22 17:46, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users does

Re: [Qemu-devel] [Qemu-block] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Denis V. Lunev
On 12/24/2015 02:19 AM, Max Reitz wrote: On 23.12.2015 04:14, Fam Zheng wrote: On Tue, 12/22 17:46, Kevin Wolf wrote: Enough innocent images have died because users called 'qemu-img snapshot' while the VM was still running. Educating the users doesn't seem to be a working strategy, so this seri

[Qemu-devel] [PATCH v4 4/5] qmp: Add blockdev-mirror command

2015-12-23 Thread Fam Zheng
This will start a mirror job from a named device to another named device, its relation with drive-mirror is similar with blockdev-backup to drive-backup. In blockdev-mirror, the target node should be prepared by blockdev-add, which will be responsible for assigning a name to the new node, so we do

[Qemu-devel] [PATCH v4 5/5] iotests: Add test cases for blockdev-mirror

2015-12-23 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/qemu-iotests/041 | 100 ++--- tests/qemu-iotests/041.out | 4 +- 2 files changed, 79 insertions(+), 25 deletions(-) diff --git a/tests/qemu-iotests/041 b/tests/qemu-iotests/041 index 05b5962.

[Qemu-devel] [PATCH v4 2/5] block: Extract blockdev part of qmp_drive_mirror

2015-12-23 Thread Fam Zheng
This is the part that will be reused by blockdev-mirror. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- blockdev.c | 146 + 1 file changed, 88 insertions(+), 58 deletions(-) diff --git a/blockdev.c b/blockdev.c index bd6f68e..22e

[Qemu-devel] [PATCH v4 3/5] block: Add check on mirror target

2015-12-23 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- blockdev.c| 3 +++ include/block/block.h | 1 + 2 files changed, 4 insertions(+) diff --git a/blockdev.c b/blockdev.c index 22e06ba..f42e171 100644 --- a/blockdev.c +++ b/blockdev.c @@ -3342,6 +3342,9 @@ static void blockdev_mirror

[Qemu-devel] [PATCH v4 0/5] qmp: Add blockdev-mirror

2015-12-23 Thread Fam Zheng
v4: 02: Add Max's rev-by. 04: buf_size -> buf-size. Add Markus' Ack-by. 05: 'node1' -> qmp_target. Fix double quotes. Add Max's Rev-by. v3: Rebase to master. v2: 01: Move bdrv_op_block_all down. [Max] 02, 04: Add Max's rev-by. 03: Check has_mode and fix "re

[Qemu-devel] [PATCH v4 1/5] block: Rename BLOCK_OP_TYPE_MIRROR to BLOCK_OP_TYPE_MIRROR_SOURCE

2015-12-23 Thread Fam Zheng
It's necessary to distinguish source and target before we can add blockdev-mirror, because we would want a concrete type of operation to check on target bs before starting. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- blockdev.c | 2 +- hw/block/dataplane/virtio-blk.

Re: [Qemu-devel] [PATCH] change type of pci_bridge_initfn() to void

2015-12-23 Thread Cao jin
Hi mst On 12/23/2015 09:38 PM, Michael S. Tsirkin wrote: On Wed, Dec 23, 2015 at 04:53:21PM +0800, Cao jin wrote: Hi mst friendly ping again... This does not work since then this function can not be used as an init callback, and this is how dec uses it. thanks very much for your time:) I w

Re: [Qemu-devel] [PATCH v3 4/5] qmp: Add blockdev-mirror command

2015-12-23 Thread Fam Zheng
On Thu, 12/24 01:53, Max Reitz wrote: > On 23.12.2015 06:59, Fam Zheng wrote: > > This will start a mirror job from a named device to another named > > device, its relation with drive-mirror is similar with blockdev-backup > > to drive-backup. > > > > In blockdev-mirror, the target node should be

Re: [Qemu-devel] [PATCH 2/4] net/dump: fix nfds->filename leak

2015-12-23 Thread Jason Wang
On 12/23/2015 03:43 PM, Li Zhijian wrote: > Cc: Jason Wang > Signed-off-by: Li Zhijian > --- > net/dump.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/net/dump.c b/net/dump.c > index ce16a4b..347b5ca 100644 > --- a/net/dump.c > +++ b/net/dump.c > @@ -329,6 +329,13 @@ static

Re: [Qemu-devel] [PATCH 1/4] net/filter: fix nf->netdev_id leak

2015-12-23 Thread Jason Wang
On 12/23/2015 03:43 PM, Li Zhijian wrote: > Cc: Jason Wang > Signed-off-by: Li Zhijian > --- > net/filter.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/net/filter.c b/net/filter.c > index 1365bad..f777ba2 100644 > --- a/net/filter.c > +++ b/net/filter.c > @@ -204,6 +204,7 @@ stati

[Qemu-devel] [PATCH v8 1/2] mirror: Rewrite mirror_iteration

2015-12-23 Thread Fam Zheng
The "pnum < nb_sectors" condition in deciding whether to actually copy data is unnecessarily strict, and the qiov initialization is unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. Rewrite mirror_iteration to fix both flaws. Signed-off-by: Fam Zheng --- block/mirror.c | 344 +++

[Qemu-devel] [PATCH v8 2/2] mirror: Add mirror_wait_for_io

2015-12-23 Thread Fam Zheng
The three lines are duplicated a number of times now, refactor a function. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- block/mirror.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index 0081c2e..07ad068 100

[Qemu-devel] [PATCH v8 0/2] mirror: Improve zero write and discard

2015-12-23 Thread Fam Zheng
v8: Rebase onto master (didn't pick up Max's rev-by due to non-trivial code change). The conflict is around removed lines about "max_iov" and "IOV_MAX" due to commit 3515727f3, but this also reveals this series forgot that check. So this revision adds it back: - Two new fields

Re: [Qemu-devel] [PATCH v3 0/5] qmp: Add blockdev-mirror

2015-12-23 Thread Fam Zheng
On Thu, 12/24 01:26, Max Reitz wrote: > On 23.12.2015 06:59, Fam Zheng wrote: > > v3: Rebase to master. > > Why did you drop patch 1? Because we already have 10f3cd15dd9913f8d959fbd061e6e00c45432093 Fam

Re: [Qemu-devel] [PATCH v3 0/5] correct some register return values for vxmnet3

2015-12-23 Thread Jason Wang
On 12/23/2015 02:29 PM, Dmitry Fleytman wrote: > Reviewed-by: Dmitry Fleytman > >> On 23 Dec 2015, at 08:06 AM, Miao Yan wrote: >> >> Qemu vmxnet3 emulation doesn't recognize VMXNET3_CMD_GET_DID_LO, >> VMXNET3_CMD_GET_DID_HI and VMXNET3_CMD_GET_DEV_EXTRA_INFO command and >> returns -1 on all of

Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration

2015-12-23 Thread Fam Zheng
On Thu, 12/24 01:21, Max Reitz wrote: > On 24.12.2015 01:15, Max Reitz wrote: > > On 23.12.2015 05:12, Fam Zheng wrote: > >> The "pnum < nb_sectors" condition in deciding whether to actually copy > >> data is unnecessarily strict, and the qiov initialization is > >> unnecessarily for bdrv_aio_write

Re: [Qemu-devel] [PATCH] Xen PCI passthrough: convert to realize()

2015-12-23 Thread Cao jin
On 12/23/2015 10:03 PM, Stefano Stabellini wrote: On Wed, 23 Dec 2015, Cao jin wrote: [...] The patch as is fails to build: qemu/hw/xen/xen_pt_config_init.c: In function ‘xen_pt_config_init’: qemu/hw/xen/xen_pt_config_init.c:2061:42: error: ‘rc’ may be used uninitialized in this func r

Re: [Qemu-devel] [RFC PATCH v0 0/9] Generic cpu-core device

2015-12-23 Thread Zhu Guihua
On 12/17/2015 05:58 AM, Igor Mammedov wrote: On Wed, 16 Dec 2015 16:46:37 +0100 Andreas Färber wrote: Am 10.12.2015 um 13:35 schrieb Igor Mammedov: wrt CLI can't we do something like this? -device some-cpu-model,socket=x[,core=y[,thread=z]] That's problematic and where my x86 remodeling go

Re: [Qemu-devel] [PATCH] linux-user/mmap.c: Use end instead of real_end in target_mmap

2015-12-23 Thread Chen Gang
Hello all: After this patch, the i386 wine notepad.exe can be bootup and run under sw_64 host. - The initialization is very very slow (about 10 minutes), it is mainly running in find_vma_reserved (consume more than 95% time resource). I guess, it can be optimized. - After initialization,

[Qemu-devel] [PATCH] linux-user/mmap.c: Use end instead of real_end in target_mmap

2015-12-23 Thread chengang
From: Chen Gang In this case, real_end is larger than end, which may cause mmap_frag process the incorrect memory region. Signed-off-by: Chen Gang --- linux-user/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/linux-user/mmap.c b/linux-user/mmap.c index 7b459d5..57b0

Re: [Qemu-devel] [PATCH v3 5/5] iotests: Add test cases for blockdev-mirror

2015-12-23 Thread Max Reitz
On 23.12.2015 06:59, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/041 | 100 > ++--- > tests/qemu-iotests/041.out | 4 +- > 2 files changed, 79 insertions(+), 25 deletions(-) Reviewed-by: Max Reitz Some comments below. >

qemu-devel@nongnu.org

2015-12-23 Thread Programmingkid
I'm having problems with the pci_dma_read() function. When using a Mac OS X guest, the data that this function returns is all zeros. After doing a lot of instruction tracing, I tracked the problem to a function called phys_page_find(). It always returns §ions[PHYS_SECTION_UNASSIGNED]. What I wo

Re: [Qemu-devel] [PATCH v3 4/5] qmp: Add blockdev-mirror command

2015-12-23 Thread Max Reitz
On 23.12.2015 06:59, Fam Zheng wrote: > This will start a mirror job from a named device to another named > device, its relation with drive-mirror is similar with blockdev-backup > to drive-backup. > > In blockdev-mirror, the target node should be prepared by blockdev-add, > which will be responsi

[Qemu-devel] arm64 qemu tests failing in linux-next since 'arm64: kernel: enforce pmuserenr_el0 initialization and restore'

2015-12-23 Thread Guenter Roeck
oblem and how to fix it (presumably in qemu) ? Bisect log is attached below. Reverting commit 60792ad349f3 on top of linux-next fixes the problem. Thanks, Guenter --- # bad: [80c75a0f1d81922bf322c0634d1e1a15825a89e6] Add linux-next specific files for 20151223 # good: [4ef7675344d687a0ef5b0d7c0ce

Re: [Qemu-devel] [PATCH v3 2/5] block: Extract blockdev part of qmp_drive_mirror

2015-12-23 Thread Max Reitz
On 23.12.2015 06:59, Fam Zheng wrote: > This is the part that will be reused by blockdev-mirror. > > Signed-off-by: Fam Zheng > --- > blockdev.c | 146 > + > 1 file changed, 88 insertions(+), 58 deletions(-) Reviewed-by: Max Reitz

[Qemu-devel] [PATCH v2 5/7] bcm2836_control: add bcm2836 ARM control logic

2015-12-23 Thread Andrew Baumann
This module is specific to the bcm2836 (Pi2). It implements the top level interrupt controller, and mailboxes used for inter-processor synchronisation. Signed-off-by: Andrew Baumann --- hw/intc/Makefile.objs | 2 +- hw/intc/bcm2836_control.c | 338 ++

Re: [Qemu-devel] [PATCH v3 0/5] qmp: Add blockdev-mirror

2015-12-23 Thread Max Reitz
On 23.12.2015 06:59, Fam Zheng wrote: > v3: Rebase to master. Why did you drop patch 1? Max > v2: 01: Move bdrv_op_block_all down. [Max] > 02, 04: Add Max's rev-by. > 03: Check has_mode and fix "return;". [Max] > 05: Check target->blk. > Drop superfluous whitespace. [Max] >

[Qemu-devel] [PATCH v2 3/7] bcm2835_ic: add bcm2835 interrupt controller

2015-12-23 Thread Andrew Baumann
Signed-off-by: Andrew Baumann --- Notes: v2 changes: * split inputs to named gpu_irq and arm_irq gpio inputs * use 64-bit gpu_irq and 8-bit arm_irq status rather than 3*32-bit bitfields * added defined names for register offsets * deleted nop realize method * other m

[Qemu-devel] [PATCH v2 4/7] bcm2835_peripherals: add rollup device for bcm2835 peripherals

2015-12-23 Thread Andrew Baumann
This device maintains all the non-CPU peripherals on bcm2835 (Pi1) which are also present on bcm2836 (Pi2). It also implements the private address space used for DMA. Signed-off-by: Andrew Baumann --- Notes: v2 changes: * adapted to use common SDHCI emulation hw/arm/Makefile.objs

[Qemu-devel] [PATCH v2 6/7] bcm2836: add bcm2836 soc device

2015-12-23 Thread Andrew Baumann
This is the SoC for Raspberry Pi 2. Signed-off-by: Andrew Baumann --- hw/arm/Makefile.objs | 2 +- hw/arm/bcm2836.c | 135 +++ include/hw/arm/bcm2836.h | 33 3 files changed, 169 insertions(+), 1 deletion(-) create mode 100

[Qemu-devel] [PATCH v2 2/7] bcm2835_property: add bcm2835 property channel

2015-12-23 Thread Andrew Baumann
This sits behind the mailbox interface, and implements request/response queries for system properties. The framebuffer-related properties will be added in a later patch. Signed-off-by: Andrew Baumann --- hw/misc/Makefile.objs | 1 + hw/misc/bcm2835_property.c | 277 +++

[Qemu-devel] [PATCH v2 0/7] Raspberry Pi 2 support

2015-12-23 Thread Andrew Baumann
This patch series adds initial support for Raspberry Pi 2 (bcm2836). It is heavily based on the original (out of tree) work of Gregory Estrade, Stefan Weil and others to support Raspberry Pi 1. At the end of this series, it is possible to boot a recent raspbian kernel to a serial console using an

[Qemu-devel] [PATCH v2 1/7] bcm2835_mbox: add BCM2835 mailboxes

2015-12-23 Thread Andrew Baumann
This adds the system mailboxes which are used to communicate with a number of GPU peripherals on Pi/Pi2. Signed-off-by: Andrew Baumann --- Notes: v2: * renamed bcm2835_sbm to bcm2835_mbox * dropped bcm2835_arm_control.h (needed defs moved to bcm2835_mbox.c) * documented use of

[Qemu-devel] [PATCH v2 7/7] raspi: add raspberry pi 2 machine

2015-12-23 Thread Andrew Baumann
bcm2835/Pi1 requires more peripherals, and will be added in a later patch series. Signed-off-by: Andrew Baumann --- hw/arm/Makefile.objs | 2 +- hw/arm/raspi.c | 179 +++ 2 files changed, 180 insertions(+), 1 deletion(-) create mode 100644

Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration

2015-12-23 Thread Max Reitz
On 24.12.2015 01:15, Max Reitz wrote: > On 23.12.2015 05:12, Fam Zheng wrote: >> The "pnum < nb_sectors" condition in deciding whether to actually copy >> data is unnecessarily strict, and the qiov initialization is >> unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. >> >> Rewrite mirr

Re: [Qemu-devel] [PATCH v7 1/2] mirror: Rewrite mirror_iteration

2015-12-23 Thread Max Reitz
On 23.12.2015 05:12, Fam Zheng wrote: > The "pnum < nb_sectors" condition in deciding whether to actually copy > data is unnecessarily strict, and the qiov initialization is > unnecessarily for bdrv_aio_write_zeroes and bdrv_aio_discard. > > Rewrite mirror_iteration to fix both flaws. > > Signed-

Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

2015-12-23 Thread Andrew Baumann
> From: Peter Crosthwaite [mailto:crosthwaitepe...@gmail.com] > Sent: Wednesday, 23 December 2015 15:59 > >>> Notice that this file comes from Linux. I know it's not pretty, but > > Where in Linux exactly? I am actually having trouble finding the > original source. Grepping around linux-next, ther

Re: [Qemu-devel] [PATCH 1/8] bcm2835_sbm: add BCM2835 mailboxes

2015-12-23 Thread Peter Crosthwaite
On Wed, Dec 23, 2015 at 12:32 PM, Paolo Bonzini wrote: > > > On 22/12/2015 00:33, Peter Crosthwaite wrote: >> >> case 0x80..0x8c >>> > >>> > Woah! Is that standard C? >>> > >> Yes, its probably one of the more recent language standards though. >> QEMU does use to more modern features lib

Re: [Qemu-devel] [PATCH 1/5] block: added lock image option and callback

2015-12-23 Thread Eric Blake
On 12/23/2015 12:46 AM, Denis V. Lunev wrote: > From: Olga Krishtal > > While opening the image we want to be sure that we are the > one who works with image, anf if it is not true - s/anf/and/ > opening the image for writing should fail. > > There are 2 ways at the moment: no lock at all and

Re: [Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification

2015-12-23 Thread Eric Blake
On 12/23/2015 10:49 AM, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one type of such

Re: [Qemu-devel] [PATCH v2 00/11] iotests: Clean up "mv $TEST_IMG $TEST_IMG.XXX"

2015-12-23 Thread Max Reitz
On 22.12.2015 03:49, Fam Zheng wrote: > v2: Add Max's rev-by in patches 1-9. > Fix quote bugs in patch 10 and split out _img_info filtering patch 11. > > Commit 794d00f71d fixed two "mv" commands into the TEST_IMG override approach. > There are still more occasions of "mv", this series fixes t

Re: [Qemu-devel] [PATCH] block/qapi: Clear err for further error

2015-12-23 Thread Max Reitz
On 22.12.2015 15:39, John Snow wrote: > > > On 12/22/2015 05:11 AM, Fam Zheng wrote: >> Since a5002d5 (block/qapi: allow best-effort query) we don't return at >> this error, however err must be cleared before passing to >> bdrv_query_snapshot_info_list below, as required by error API. >> >> Signe

[Qemu-devel] [Bug 1323758] Re: Mouse stops working when connected usb-storage-device

2015-12-23 Thread Maarten Jacobs
Magic! I'd been trying to figure out how to prevent my mouse from stopping at apparently random points... Works like magic! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1323758 Title: Mouse stops

Re: [Qemu-devel] [PATCH 00/10] qcow2: Implement image locking

2015-12-23 Thread Max Reitz
On 23.12.2015 04:14, Fam Zheng wrote: > On Tue, 12/22 17:46, Kevin Wolf wrote: >> Enough innocent images have died because users called 'qemu-img snapshot' >> while >> the VM was still running. Educating the users doesn't seem to be a working >> strategy, so this series adds locking to qcow2 that

Re: [Qemu-devel] [PATCH 5/5] qmp: create QMP implementation of loadvm command

2015-12-23 Thread Eric Blake
On 12/04/2015 07:44 AM, Denis V. Lunev wrote: > Unfortunately load_vmstate has a return code (int) and this code is checked > in the other places. Thus we could not just rename it to qmp_loadvm as > returns void. > > Signed-off-by: Denis V. Lunev > CC: Juan Quintela > CC: Amit Shah > CC: Markus

Re: [Qemu-devel] [PATCH v4 2/4] target-tilegx: Add single floating point implementation

2015-12-23 Thread Richard Henderson
On 12/23/2015 01:48 PM, cheng...@emindsoft.com.cn wrote: +static float32 sfmt_to_float32(uint64_t sfmt) +{ +uint32_t sign = get_fsingle_sign(sfmt); +uint32_t man = get_fsingle_man(sfmt); +uint32_t exp = get_fsingle_exp(sfmt); +float32 f; + +if (get_fsingle_calc(sfmt) == TILEGX

Re: [Qemu-devel] [PATCH v4 1/4] target-tilegx: Add floating point shared functions

2015-12-23 Thread Richard Henderson
On 12/23/2015 01:48 PM, cheng...@emindsoft.com.cn wrote: +extern float_status fp_status; No. Locally declared in e.g. main_calc. r~

Re: [Qemu-devel] [PATCH v6] spec: add qcow2 bitmaps extension specification

2015-12-23 Thread Max Reitz
On 23.12.2015 18:49, Vladimir Sementsov-Ogievskiy wrote: > The new feature for qcow2: storing bitmaps. > > This patch adds new header extension to qcow2 - Bitmaps Extension. It > provides an ability to store virtual disk related bitmaps in a qcow2 > image. For now there is only one type of such bi

Re: [Qemu-devel] [Qemu-block] [PATCH] block: use drained section in bdrv_close

2015-12-23 Thread Max Reitz
On 23.12.2015 22:55, Paolo Bonzini wrote: > >> On 23.12.2015 11:48, Paolo Bonzini wrote: >>> bdrv_close is used when ejecting a medium. >> >> Is it still? Other than it maybe being indirectly called through >> bdrv_delete(), it shouldn't be. > > Yes, through blk_remove_bs -> bdrv_unref -> bdrv_de

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: make check-block.sh work on out-of-tree builds

2015-12-23 Thread Max Reitz
On 23.12.2015 11:42, Paolo Bonzini wrote: > Since check-block.sh, the "check" script has learnt to find the source > path. On the other hand, it expects common.env to be in the build tree > (both changes made in commit 76c7560, "configure: Enable out-of-tree > iotests", 2014-05-24). So, it is wro

Re: [Qemu-devel] [PATCH 4/5] migration: improve error reporting for load_vmstate

2015-12-23 Thread Eric Blake
On 12/04/2015 07:44 AM, Denis V. Lunev wrote: > The patch adds Error ** parameter to load_vmstate call and fills error > inside. The caller after that properly reports error either through > monitor or via local stderr facility during VM start. > > This helper will be useful too for qmp_loadvm imp

Re: [Qemu-devel] [Qemu-block] [PATCH] block: use drained section in bdrv_close

2015-12-23 Thread Paolo Bonzini
> On 23.12.2015 11:48, Paolo Bonzini wrote: > > bdrv_close is used when ejecting a medium. > > Is it still? Other than it maybe being indirectly called through > bdrv_delete(), it shouldn't be. Yes, through blk_remove_bs -> bdrv_unref -> bdrv_delete. > >

[Qemu-devel] [PATCH v4 0/4] target-tilegx: Implement floating point instructions

2015-12-23 Thread chengang
From: Chen Gang These patches are the normal floating point implementation, instead of the original temporary one. It passes building, and gcc testsuite. Chen Gang (4): target-tilegx: Add floating point shared functions target-tilegx: Add single floating point implementation target-tilegx

Re: [Qemu-devel] [Qemu-block] [PATCH] iotests: 086: Add raw format

2015-12-23 Thread Max Reitz
On 23.12.2015 07:26, Fam Zheng wrote: > Raw is as qualified as qcow2 for this test case, add it for more > coverage. > > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/086 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to my block tree: https://github.com/XanClic/

[Qemu-devel] [PATCH v4 1/4] target-tilegx: Add floating point shared functions

2015-12-23 Thread chengang
From: Chen Gang They are used by fsingle and fdouble helpers. Signed-off-by: Chen Gang --- target-tilegx/helper-fshared.c | 22 + target-tilegx/helper-fshared.h | 55 ++ 2 files changed, 77 insertions(+) create mode 100644 target-tilegx/

[Qemu-devel] [PATCH v4 3/4] target-tilegx: Add double floating point implementation

2015-12-23 Thread chengang
From: Chen Gang Signed-off-by: Chen Gang --- target-tilegx/helper-fdouble.c | 382 + 1 file changed, 382 insertions(+) create mode 100644 target-tilegx/helper-fdouble.c diff --git a/target-tilegx/helper-fdouble.c b/target-tilegx/helper-fdouble.c new fil

[Qemu-devel] [PATCH v4 4/4] target-tilegx: Integrate floating pointer implementation

2015-12-23 Thread chengang
From: Chen Gang It passes normal building, and gcc testsuite. Signed-off-by: Chen Gang --- target-tilegx/Makefile.objs | 3 ++- target-tilegx/helper.h | 12 + target-tilegx/translate.c | 66 ++--- 3 files changed, 71 insertions(+), 10 del

[Qemu-devel] [PATCH v4 2/4] target-tilegx: Add single floating point implementation

2015-12-23 Thread chengang
From: Chen Gang Signed-off-by: Chen Gang --- target-tilegx/helper-fsingle.c | 211 + 1 file changed, 211 insertions(+) create mode 100644 target-tilegx/helper-fsingle.c diff --git a/target-tilegx/helper-fsingle.c b/target-tilegx/helper-fsingle.c new fil

Re: [Qemu-devel] [PATCH 3/5] qmp: create qmp_delvm command

2015-12-23 Thread Eric Blake
On 12/04/2015 07:44 AM, Denis V. Lunev wrote: > The patch also moves hmp_delvm implementation into hmp.c. This function > is just a simple wrapper now and does not have knowledge about > migration internals. > > Signed-off-by: Denis V. Lunev > CC: Juan Quintela > CC: Amit Shah > CC: Markus Armb

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-23 Thread Denis V. Lunev
On 12/24/2015 12:40 AM, Eric Blake wrote: On 12/04/2015 07:44 AM, Denis V. Lunev wrote: 'name' attribute is made mandatory in distinction with HMP command. The patch also moves hmp_savevm implementation into hmp.c. This function is just a simple wrapper now and does not have knowledge about mig

Re: [Qemu-devel] [PATCH 2/5] qmp: create qmp_savevm command

2015-12-23 Thread Eric Blake
On 12/04/2015 07:44 AM, Denis V. Lunev wrote: > 'name' attribute is made mandatory in distinction with HMP command. > > The patch also moves hmp_savevm implementation into hmp.c. This function > is just a simple wrapper now and does not have knowledge about > migration internals. > > Signed-off-b

Re: [Qemu-devel] [Qemu-block] [PATCH] block: use drained section in bdrv_close

2015-12-23 Thread Max Reitz
On 23.12.2015 11:48, Paolo Bonzini wrote: > bdrv_close is used when ejecting a medium. Is it still? Other than it maybe being indirectly called through bdrv_delete(), it shouldn't be. > Use a drained section to ensure > that all I/O goes to either the o

Re: [Qemu-devel] [PATCH 1/5] migration: split hmp_savevm to do_savevm and hmp_savevm wrapper

2015-12-23 Thread Eric Blake
On 12/04/2015 07:44 AM, Denis V. Lunev wrote: > This would be useful in the next step when QMP version of this call will > be introduced. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Juan Quintela > CC: Amit Shah > CC: Markus Armbruster > CC: Eric Blake > --- > migration/savevm.c | 38 ++

Re: [Qemu-devel] [PATCH v2 for 2.6 0/5] QMP wrappers for VM snapshot operations

2015-12-23 Thread Denis V. Lunev
On 12/18/2015 09:10 AM, Denis V. Lunev wrote: On 12/11/2015 12:33 PM, Denis V. Lunev wrote: On 12/04/2015 05:44 PM, Denis V. Lunev wrote: EFI based VM with pflash storage for NVRAM could not be snapshoted as libvirt configures storage as 'raw' and writable. OK, this is a libvirt problem. Anoth

Re: [Qemu-devel] [PATCH v2 00/14] Add qapi-to-JSON output visitor

2015-12-23 Thread Eric Blake
On 12/21/2015 05:30 PM, Eric Blake wrote: > Prerequisites: > + my qapi cleanups subset E v8: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html Also available as a tag at this location: git fetch git://repo.or.cz/qemu/ericb.git qapi-jsonv2 and part of my branch of pending qapi

[Qemu-devel] [PATCH v6 10/16] net: Use correct type for bool flag

2015-12-23 Thread Eric Blake
is_netdev is only used as a bool, so make it one. Signed-off-by: Eric Blake --- v6: rebase to latest context --- hw/usb/dev-network.c | 2 +- include/net/net.h| 2 +- net/net.c| 12 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/usb/dev-network.

[Qemu-devel] [PATCH v6 09/16] qapi: Change Netdev into a flat union

2015-12-23 Thread Eric Blake
From: Kővágó, Zoltán Except qapi-schema.json, this patch was generated by: find . -name .git -prune -o -type f \! -name '*~' -print0 | \ xargs -0 sed -i \ -e 's/NetClientOptionsKind/NetClientDriver/g' \ -e 's/NET_CLIENT_OPTIONS_KIND_/NET_CLIENT_DRIVER_/g' \ -e 's/netdev->opts/netde

[Qemu-devel] [PATCH v6 14/16] qapi: Use anonymous base in Netdev

2015-12-23 Thread Eric Blake
Now that the generator supports it, we might as well use an anonymous base rather than breaking out a single-use NetdevBase structure. Signed-off-by: Eric Blake --- v6: new patch --- qapi-schema.json | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/qapi-

Re: [Qemu-devel] [PATCH v6 00/16] qapi netdev_add introspection (post-introspection cleanups subset F)

2015-12-23 Thread Eric Blake
On 12/23/2015 01:55 PM, Eric Blake wrote: > Prerequisites: > + my qapi cleanups subset E v8: > https://lists.gnu.org/archive/html/qemu-devel/2015-12/msg03863.html Also available as a tag at this location: git fetch git://repo.or.cz/qemu/ericb.git qapi-cleanupv6f and part of my branch of pending q

[Qemu-devel] [PATCH v6 12/16] qapi: Allow anonymous base for flat union

2015-12-23 Thread Eric Blake
Rather than requiring all flat unions to explicitly create a separate base struct, we want to allow the qapi schema to specify the common fields via an inline dictionary. This is similar to how commands can specify inline types for the arguments. Now that the feature is legal, we can drop the form

[Qemu-devel] [PATCH v6 06/16] qapi: Plumb in 'box' to qapi generator lower levels

2015-12-23 Thread Eric Blake
A future patch will add support for passing a qapi union type as the 'data' of a command. But to do that, the user function for implementing the command, as called by the generated marshal command, must take the corresponding C struct as a single boxed pointer, rather than a breakdown into one par

[Qemu-devel] [PATCH v6 15/16] qapi: Use anonymous base in CpuInfo

2015-12-23 Thread Eric Blake
Now that the generator supports it, we might as well use an anonymous base rather than breaking out a single-use CpuInfoBase structure. Signed-off-by: Eric Blake --- v6: new patch --- qapi-schema.json | 20 ++-- scripts/qapi.py | 2 +- 2 files changed, 7 insertions(+), 15 dele

  1   2   3   >