Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-23 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Mon, Nov 23, 2015 at 09:05:30PM +0100, Lluís Vilanova wrote: >> Daniel P Berrange writes: >> [...] >> > I don't think this "Errors in user inputs" vs "Other errors" distinction >> > really makes sense. Whether an error raised in a piece of code is related >> > to

Re: [Qemu-devel] [PATCH v4 0/4] usb-mtp events support

2015-11-23 Thread Gerd Hoffmann
On Mo, 2015-11-23 at 16:37 -0500, Bandan Das wrote: > This series adds support for mtp events that are piggybacked on > top of the Linux provided inotify mechanism. It performs well with some > light unit testing in a linux guest. The mtp share is still read only, > but now the guest will notice up

Re: [Qemu-devel] [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target

2015-11-23 Thread Ming Lin
On Mon, 2015-11-23 at 15:14 +0100, Paolo Bonzini wrote: > > On 23/11/2015 09:17, Ming Lin wrote: > > On Sat, 2015-11-21 at 14:11 +0100, Paolo Bonzini wrote: > >> > >> On 20/11/2015 01:20, Ming Lin wrote: > >>> One improvment could be to use google's NVMe vendor extension that > >>> I send in anoth

Re: [Qemu-devel] [PATCH v5 0/6] fw_cfg: spec update, misc. cleanup, optimize read

2015-11-23 Thread Gerd Hoffmann
On Mo, 2015-11-23 at 09:18 -0500, Gabriel L. Somlo wrote: > Ping ? > > I can send out v6 and fix the commit blurb typo in patch 6/6 pointed > out by Laszlo (unless the series is already winding its way toward > eventually being applied). > > Please advise. We are in 2.5 hard-freeze, so this is f

Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-23 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Mon, Nov 23, 2015 at 07:41:24PM +0100, Lluís Vilanova wrote: >> Gives some general guidelines for reporting errors in QEMU. >> >> Signed-off-by: Lluís Vilanova >> --- >> HACKING | 31 +++ >> 1 file changed, 31 insertions(+) >> >>

Re: [Qemu-devel] [PATCH -qemu] nvme: support Google vendor extension

2015-11-23 Thread Ming Lin
On Sat, 2015-11-21 at 23:45 -0800, Ming Lin wrote: > On Sat, 2015-11-21 at 13:56 +0100, Paolo Bonzini wrote: > > > > On 21/11/2015 00:05, Ming Lin wrote: > > > [1.752129] Freeing unused kernel memory: 420K (880001b97000 - > > > 880001c0) > > > [1.986573] clocksource: tsc: mask

Re: [Qemu-devel] [Qemu-ppc] [PATCH 26/77] ppc/pnv: Add skeletton PowerNV platform

2015-11-23 Thread David Gibson
On Tue, Nov 24, 2015 at 12:45:48PM +1100, Benjamin Herrenschmidt wrote: > On Fri, 2015-11-20 at 19:21 +1100, David Gibson wrote: > > On Wed, Nov 11, 2015 at 11:27:39AM +1100, Benjamin Herrenschmidt > > wrote: > > > No devices yet, not even an interrupt controller, just to get > > > started. > > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 29/77] ppc/xics: Move SPAPR specific code to a separate file

2015-11-23 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:42AM +1100, Benjamin Herrenschmidt wrote: > Leave the core ICP/ICS logic in xics.c and move the top level > class wrapper, hypercall and RTAS handlers to xics_spapr.c > > Signed-off-by: Benjamin Herrenschmidt Concept looks fine. > --- > default-configs/ppc64-softm

Re: [Qemu-devel] [Qemu-ppc] [PATCH 28/77] ppc/xics: Rename existing XICS classe to XICS_SPAPR

2015-11-23 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:41AM +1100, Benjamin Herrenschmidt wrote: > The common class doesn't change, the KVM one is SPAPR specific, this > is a preliminary change to make it easier to support "native" XICS. > > Signed-off-by: Benjamin Herrenschmidt So changing the variable names is fine, b

Re: [Qemu-devel] [Qemu-ppc] [PATCH 27/77] ppc/pnv: Add XSCOM infrastructure

2015-11-23 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:40AM +1100, Benjamin Herrenschmidt wrote: > XSCOM is an interface to a sideband bus provided by the POWER8 chip > pervasive unit, which gives access to a number of facilities in the > chip that are needed by the OPAL firmware and to a lesser extent, > Linux. This is am

Re: [Qemu-devel] [Qemu-ppc] [PATCH 32/77] ppc/xics: Replace "icp" with "xics" in most places

2015-11-23 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:45AM +1100, Benjamin Herrenschmidt wrote: > The "ICP" is a different object than the "XICS". For historical reasons, > we have a number of places where we name a variable "icp" while it contains > a XICSState pointer. There *is* an ICPState structure too so this makes

Re: [Qemu-devel] [Qemu-ppc] [PATCH 31/77] ppc/xics: Remove unused xics_set_irq_type()

2015-11-23 Thread David Gibson
On Wed, Nov 11, 2015 at 11:27:44AM +1100, Benjamin Herrenschmidt wrote: > Signed-off-by: Benjamin Herrenschmidt Reviewed-by: David Gibson In fact, this is a sufficiently good clean up that I think I'll merge it shortly, regardless of what happens with the rest of the pnv series. > --- > hw/in

Re: [Qemu-devel] [PATCH for-2.6 12/14] qemu-img: In 'map', use QDict to generate JSON output

2015-11-23 Thread Fam Zheng
On Mon, 11/23 22:42, Eric Blake wrote: > On 11/23/2015 10:22 PM, Fam Zheng wrote: > > +++ b/tests/qemu-iotests/122.out > > @@ -49,12 +49,13 @@ read 65536/65536 bytes at offset 4194304 > > 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > > read 65536/65536 bytes at offset 8388608 > > 64

Re: [Qemu-devel] [PATCH for-2.5 0/2] Fix "make check" with mingw and Wine

2015-11-23 Thread Stefan Hajnoczi
On Mon, Nov 23, 2015 at 01:39:04PM +0100, Kevin Wolf wrote: > I tried to run "make check" on my mingw build and got two failures. Both of > them are bugs in the test suite rather than qemu proper. They are easy enough > to fix, so here are the fixes. > > Kevin Wolf (2): > tests/Makefile: Add mor

Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output parameter to block status query functions

2015-11-23 Thread Fam Zheng
On Mon, 11/23 22:30, Eric Blake wrote: > On 11/23/2015 10:21 PM, Fam Zheng wrote: > > The added parameter can be used to return the BDS pointer which the > > valid offset is refering to. It's value should be ignored unless > > s/refering/referring/ > > > BDRV_BLOCK_OFFSET_VALID in ret is set. > >

Re: [Qemu-devel] [PATCH for-2.6 12/14] qemu-img: In 'map', use QDict to generate JSON output

2015-11-23 Thread Eric Blake
On 11/23/2015 10:22 PM, Fam Zheng wrote: > Switch json output generation from hand-written to QDict encoder, so > that the coming str field will be properly escaped. > > Iotest 122 output is updated accordingly. > > Signed-off-by: Fam Zheng > --- > qemu-img.c | 30 +++---

Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

2015-11-23 Thread Jason Wang
On 11/23/2015 05:36 PM, Cornelia Huck wrote: > On Mon, 23 Nov 2015 15:41:11 +0800 > Jason Wang wrote: > >> Currently, all virtio devices bypass IOMMU completely. This is because >> address_space_memory is assumed and used during DMA emulation. This >> patch converts the virtio core API to use DM

Re: [Qemu-devel] [PATCH] nand: fix flash erase when oob is in memory

2015-11-23 Thread Rabin Vincent
(to: Kevin and cc: qemu-block) On Fri, Nov 13, 2015 at 02:17:28PM +0100, Ricard Wanderlöf wrote: > > For the "main area on file, oob in memory" case, fix the shifts so that > we erase the correct number of pages. > > Signed-off-by: Ricard Wanderlöf > --- > hw/block/nand.c |2 +- > 1 file c

Re: [Qemu-devel] [RFC] virtio: convert to use DMA api

2015-11-23 Thread Jason Wang
On 11/23/2015 04:06 PM, Michael S. Tsirkin wrote: > On Mon, Nov 23, 2015 at 03:41:11PM +0800, Jason Wang wrote: >> Currently, all virtio devices bypass IOMMU completely. This is because >> address_space_memory is assumed and used during DMA emulation. This >> patch converts the virtio core API to

[Qemu-devel] [PATCH v2 3/3] hbitmap: Drop "granularity"

2015-11-23 Thread Fam Zheng
Sometimes confused with the granularity with coarse levels in HBitmap, the granularity in the hbitmap_alloc is not an essential concept of a bitmap. Now that all callers except the test code use zero, it's possible to drop the parameter to make the interface cleaner and more intuitive. Test code

[Qemu-devel] [PATCH v2 1/3] backup: Use Bitmap to replace "s->bitmap"

2015-11-23 Thread Fam Zheng
"s->bitmap" tracks done sectors, we only check bit states without using any iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and more memory efficient. Meanwhile, rename it to done_bitmap, to reflect the intention. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- bloc

[Qemu-devel] [PATCH v2 2/3] block: Hide HBitmap in block dirty bitmap interface

2015-11-23 Thread Fam Zheng
HBitmap is an implementation detail of block dirty bitmap that should be hidden from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying HBitmapIter. A small difference in the interface is, before, an HBitmapIter is initialized in place, now the new BdrvDirtyBitmapIter must be dyn

[Qemu-devel] [PATCH v2 0/3] Bitmap clean-up patches for 2.6

2015-11-23 Thread Fam Zheng
v2: bitmap_set -> set_bit. [Congyang, Paolo, John] Add John Snow's rev-by with that change. This makes a cleaner base for more dirty bitmap work. "granularity" appearing with different representations have always been mind twisting, remove it from HBitmap to make the interface and implementati

Re: [Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output parameter to block status query functions

2015-11-23 Thread Eric Blake
On 11/23/2015 10:21 PM, Fam Zheng wrote: > The added parameter can be used to return the BDS pointer which the > valid offset is refering to. It's value should be ignored unless s/refering/referring/ > BDRV_BLOCK_OFFSET_VALID in ret is set. > > Until block drivers fill in the right value, let's

Re: [Qemu-devel] [OpenBIOS] [Qemu-ppc] CUDA has problems with Mac OS 10.4

2015-11-23 Thread Alfonso Gamboa
On Mon, Nov 23, 2015 at 7:28 PM, Programmingkid wrote: > > On Nov 23, 2015, at 4:00 PM, Mark Cave-Ayland wrote: > > > On 22/11/15 17:39, Programmingkid wrote: > > > > Hi Alfonso, > > > > Has there been any progress at all as to which extensions may be > causing > > the crashes? >

[Qemu-devel] [PATCH for-2.6 12/14] qemu-img: In 'map', use QDict to generate JSON output

2015-11-23 Thread Fam Zheng
Switch json output generation from hand-written to QDict encoder, so that the coming str field will be properly escaped. Iotest 122 output is updated accordingly. Signed-off-by: Fam Zheng --- qemu-img.c | 30 +++ tests/qemu-iotests/122.out | 96 ++

[Qemu-devel] [PATCH for-2.6 13/14] qemu-img: In "map" output, support external file name

2015-11-23 Thread Fam Zheng
The new "file" output parameter of bdrv_get_block_status tells which file the valid offset is referring to, we can use the information and output the filename. The iotest 122 reference output is updated accordingly. Signed-off-by: Fam Zheng --- qemu-img.c | 12 test

[Qemu-devel] [PATCH for-2.6 09/14] vdi: Assign bs->file->bs to file in vdi_co_get_block_status

2015-11-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/vdi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/vdi.c b/block/vdi.c index 2199fd3..6b1a57b 100644 --- a/block/vdi.c +++ b/block/vdi.c @@ -550,6 +550,7 @@ static int64_t coroutine_fn vdi_co_get_block_status(BlockDriverState *bs, offset = s->

[Qemu-devel] [PATCH for-2.6 10/14] vpc: Assign bs->file->bs to file in vpc_co_get_block_status

2015-11-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/vpc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/block/vpc.c b/block/vpc.c index 912f5d0..412ff41 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -588,6 +588,7 @@ static int64_t coroutine_fn vpc_co_get_block_status(BlockDriverState *bs, if (be32

[Qemu-devel] [PATCH for-2.6 11/14] vmdk: Return extent's file in bdrv_get_block_status

2015-11-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/vmdk.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index f5a56fd..b60a5af 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -1265,6 +1265,7 @@ static int64_t coroutine_fn vmdk_co_get_block_status(Blo

[Qemu-devel] [PATCH for-2.6 05/14] iscsi: Assign bs to file in iscsi_co_get_block_status

2015-11-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/iscsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 2d1e230..8c7f1b3 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -625,6 +625,9 @@ out: if (iTask.task != NULL) { scsi_free_scsi_task(iTask.task);

[Qemu-devel] [PATCH for-2.6 06/14] parallels: Assign bs->file->bs to file in parallels_co_get_block_status

2015-11-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/parallels.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/parallels.c b/block/parallels.c index 04f0e87..d1406b1 100644 --- a/block/parallels.c +++ b/block/parallels.c @@ -273,6 +273,7 @@ static int64_t coroutine_fn parallels_co_get_block_status(Blo

[Qemu-devel] [PATCH for-2.6 08/14] sheepdog: Assign bs to file in sd_co_get_block_status

2015-11-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/sheepdog.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/sheepdog.c b/block/sheepdog.c index 0f6789e..d5e7ff8 100644 --- a/block/sheepdog.c +++ b/block/sheepdog.c @@ -2740,6 +2740,9 @@ sd_co_get_block_status(BlockDriverState *bs, int64_t sector_n

[Qemu-devel] [PATCH for-2.6 04/14] raw: Assign bs to file in raw_co_get_block_status

2015-11-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/raw-posix.c | 1 + block/raw_bsd.c | 1 + 2 files changed, 2 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index 2cd7d68..9988aa4 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -1873,6 +1873,7 @@ static int64_t coroutine_fn raw_

[Qemu-devel] [PATCH for-2.6 03/14] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status

2015-11-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 836888c..7634c42 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -1302,6 +1302,7 @@ static int64_t coroutine_fn qcow2_co_get_block_status(BlockDriverState *bs,

[Qemu-devel] [PATCH for-2.6 07/14] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status

2015-11-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/qed.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/qed.c b/block/qed.c index a6bbd8b..03af9c1 100644 --- a/block/qed.c +++ b/block/qed.c @@ -692,6 +692,7 @@ typedef struct { uint64_t pos; int64_t status; int *pnum; +BlockDriver

[Qemu-devel] [PATCH for-2.6 14/14] iotests: Add "qemu-img map" test for VMDK extents

2015-11-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/qemu-iotests/059 | 10 ++ tests/qemu-iotests/059.out | 38 ++ 2 files changed, 48 insertions(+) diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 index 0ded0c3..261d8b0 100755 --- a/tests/qemu-iotests/0

[Qemu-devel] [PATCH for-2.6 02/14] qcow: Assign bs->file->bs to file in qcow_co_get_block_status

2015-11-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/qcow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow.c b/block/qcow.c index 558f443..b59383f 100644 --- a/block/qcow.c +++ b/block/qcow.c @@ -509,6 +509,7 @@ static int64_t coroutine_fn qcow_co_get_block_status(BlockDriverState *bs, re

[Qemu-devel] [PATCH for-2.6 01/14] block: Add "file" output parameter to block status query functions

2015-11-23 Thread Fam Zheng
The added parameter can be used to return the BDS pointer which the valid offset is refering to. It's value should be ignored unless BDRV_BLOCK_OFFSET_VALID in ret is set. Until block drivers fill in the right value, let's clear it explicitly right before calling .bdrv_get_block_status. Signed-of

[Qemu-devel] [PATCH for-2.6 00/14] qemu-img map: Allow driver to return file of the allocated block

2015-11-23 Thread Fam Zheng
I stumbled upon this when looking at external bitmap formats. Current "qemu-img map" command only displays filename if the data is allocated in bs (bs->file) itself, or in the backing chain. Otherwise, it displays an unfriendly error message: $ qemu-img create -f vmdk -o subformat=monolithicF

Re: [Qemu-devel] [OpenBIOS] [Qemu-ppc] CUDA has problems with Mac OS 10.4

2015-11-23 Thread Programmingkid
On Nov 23, 2015, at 4:00 PM, Mark Cave-Ayland wrote: > On 22/11/15 17:39, Programmingkid wrote: > > Hi Alfonso, > > Has there been any progress at all as to which extensions may be causing > the crashes? Remove these extensions from the Extensions folder and Mac OS 9

[Qemu-devel] [PATCH v1 1/1] xlnx-ep108: Add support for high DDR memory regions

2015-11-23 Thread Alistair Francis
The Xilinx EP108 supports three memory regions: - A 2GB region starting at 0 - A 32GB region starting at 32GB - A 256GB region starting at 768GB This patch adds support for the middle memory region, which is automatically created based on the size specified by the QEMU memory command line argum

[Qemu-devel] Highlighting changes in QEMU 2.5

2015-11-23 Thread Amit Shah
Hello, The 2.5 release is close - and I'm collecting a list of notable changes and features once more. The video made for the 2.4 release [1] was popular, and I'm volunteering to make one for 2.5 as well. In addition, we need more feature pages, and there's a template at [2] that you can use to

Re: [Qemu-devel] [PATCH for-2.5] block-migration: limit the memory usage

2015-11-23 Thread Stefan Hajnoczi
On Mon, Nov 23, 2015 at 05:31:33PM +0100, Juan Quintela wrote: > Wen Congyang wrote: > > If we set migration speed in a very large value, block-migration will try > > to read > > all data to the memory. Because > > (block_mig_state.submitted + block_mig_state.read_done) * BLOCK_SIZE > > will

Re: [Qemu-devel] [PATCH V5 8/8] arm: xlnx-zynqmp: Add xlnx-dp and xlnx-dpdma

2015-11-23 Thread Alistair Francis
On Mon, Nov 23, 2015 at 6:53 PM, KONRAD Frederic wrote: > > > Le 20/11/2015 13:21, Alistair Francis a écrit : >> >> On Fri, Oct 16, 2015 at 7:11 PM, wrote: >>> >>> From: KONRAD Frederic >>> >>> This adds the DP and the DPDMA to the Zynq MP platform. >>> >>> Signed-off-by: KONRAD Frederic >>> R

[Qemu-devel] [PATCH v6 1/3] target-i386: fallback vcpu's TSC rate to value returned by KVM

2015-11-23 Thread Haozhong Zhang
If no user-specified TSC rate is present, we will try to set env->tsc_khz to the value returned by KVM_GET_TSC_KHZ. This patch does not change the current functionality of QEMU and just prepares for later patches to enable migrating vcpu's TSC rate. Signed-off-by: Haozhong Zhang --- target-i386/

[Qemu-devel] [PATCH v6 0/3] target-i386: save/restore vcpu's TSC rate during migration

2015-11-23 Thread Haozhong Zhang
This patchset enables QEMU to save/restore vcpu's TSC rate during the migration on machine types pc-*-2.5 or newer. On the source machine: * If the vcpu's TSC rate is specified by the cpu option 'tsc-freq', then this user-specified TSC rate will be migrated. * Otherwise, the TSC rate returned

[Qemu-devel] [PATCH v6 3/3] target-i386: add support to migrate vcpu's TSC rate

2015-11-23 Thread Haozhong Zhang
This patch enables migrating vcpu's TSC rate. If KVM on the destination machine supports TSC scaling, guest programs will observe a consistent TSC rate across the migration. If TSC scaling is not supported on the destination machine, the migration will not be aborted and QEMU on the destination wi

[Qemu-devel] [PATCH v6 2/3] target-i386: reorganize TSC rate setting code

2015-11-23 Thread Haozhong Zhang
Following changes are made to the TSC rate setting code in kvm_arch_init_vcpu(): * The code is moved to a new function kvm_arch_set_tsc_khz(). * If kvm_arch_set_tsc_khz() fails, i.e. following two conditions are both satisfied: * KVM does not support the TSC scaling or it fails to set vcpu'

Re: [Qemu-devel] [OpenBIOS] [Qemu-ppc] CUDA has problems with Mac OS 10.4

2015-11-23 Thread Programmingkid
On Nov 23, 2015, at 4:00 PM, Mark Cave-Ayland wrote: > On 22/11/15 17:39, Programmingkid wrote: > > Hi Alfonso, > > Has there been any progress at all as to which extensions may be causing > the crashes? Remove these extensions from the Extensions folder and Mac OS 9

Re: [Qemu-devel] [PATCH V5 7/8] introduce xlnx-dp

2015-11-23 Thread Alistair Francis
On Mon, Nov 23, 2015 at 6:51 PM, KONRAD Frederic wrote: > > > Le 20/11/2015 11:06, Alistair Francis a écrit : >> >> On Fri, Oct 16, 2015 at 7:11 PM, wrote: >>> >>> From: KONRAD Frederic >>> >>> This is the implementation of the DisplayPort. >>> It has an aux-bus to access dpcd and edid. >>> >>>

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Prevent activation clicks from going to guest

2015-11-23 Thread Programmingkid
On Nov 23, 2015, at 11:06 AM, Peter Maydell wrote: > On 22 November 2015 at 01:43, Programmingkid > wrote: >> When QEMU is brought to the foreground, the click event that activates QEMU >> should not go to the guest. Accidents happen when they do go to the guest >> without giving the user a cha

Re: [Qemu-devel] [PATCH REPOST 0/2] Add basic "detach" support for dump-guest-memory

2015-11-23 Thread Fam Zheng
On Tue, 11/24 09:57, Peter Xu wrote: > On 11/24/2015 01:57 AM, Andrew Jones wrote: > > On Mon, Nov 23, 2015 at 05:22:29PM +0100, Laszlo Ersek wrote: > >> On 11/23/15 11:07, Peter Xu wrote: > >>> Currently, dump-guest-memory supports synchronous operation only. This > >>> patch > >>> sets are addin

Re: [Qemu-devel] [PATCH] migration: Add state records for migration incoming

2015-11-23 Thread zhanghailiang
On 2015/11/18 18:51, Juan Quintela wrote: zhanghailiang wrote: For migration destination, sometimes we need to know its state, and it is also useful for tracing migration incoming process. Here we add a new member 'state' for MigrationIncomingState, and also use migrate_set_state() to modify i

Re: [Qemu-devel] [PATCH REPOST 1/2] dump-guest-memory: add "detach" flag for QMP/HMP interfaces

2015-11-23 Thread Fam Zheng
On Mon, 11/23 09:10, Eric Blake wrote: > On 11/23/2015 03:07 AM, Peter Xu wrote: > > This patch only add the interfaces, but not implementing them. > > > > Signed-off-by: Peter Xu > > --- > > dump.c | 3 ++- > > hmp-commands.hx | 5 +++-- > > hmp.c| 3 ++- > > qapi-schema.

Re: [Qemu-devel] [virtio-dev] [RFC v1] virtio-crypto specification

2015-11-23 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Monday, November 23, 2015 11:14 PM > Subject: Re: [virtio-dev] [RFC v1] virtio-crypto specification > > On Fri, 20 Nov 2015 03:27:51 + > "Gonglei (Arei)" wrote: > > > Hi guys, > > > > After init

Re: [Qemu-devel] [Qemu-ppc] [PATCH 21/77] ppc: Rework generation of priv and inval interrupts

2015-11-23 Thread David Gibson
On Tue, Nov 24, 2015 at 11:44:36AM +1100, Benjamin Herrenschmidt wrote: > On Fri, 2015-11-20 at 18:45 +1100, David Gibson wrote: > >  > > So, I'm not 100% following the logic below, but it looks like the > > existing code used SPR_NOACCESS to mark things which generated a > > privilege exception co

Re: [Qemu-devel] [Qemu-ppc] [PATCH 21/77] ppc: Rework generation of priv and inval interrupts

2015-11-23 Thread David Gibson
On Tue, Nov 24, 2015 at 11:51:44AM +1100, Benjamin Herrenschmidt wrote: > On Fri, 2015-11-20 at 18:45 +1100, David Gibson wrote: > > snip] > > >  /* tlbiel */ > > >  static void gen_tlbiel(DisasContext *ctx) > > >  { > > >  #if defined(CONFIG_USER_ONLY) > > > -    gen_inval_exception(ctx, POWERPC_E

Re: [Qemu-devel] [PATCH for 2.6 2/3] block: Hide HBitmap in block dirty bitmap interface

2015-11-23 Thread Fam Zheng
On Mon, 11/23 16:34, John Snow wrote: > Hmm, what's the idea, here? > > This patch does a lot more than just hide hbitmap details from callers > of block_dirty_bitmap functions. > > So we're changing the backing hbitmap to always be one where g=0 and the > number of physical bits directly is (now

Re: [Qemu-devel] [PATCH REPOST 0/2] Add basic "detach" support for dump-guest-memory

2015-11-23 Thread Peter Xu
Hi, all, CC'ing all the reviewers. Sorry to not respond one by one, just trying to avoid spliting into several emails and people spend extra time reading them, especially if this patch is to be dropped. Please check bottom reply. On 11/24/2015 01:57 AM, Andrew Jones wrote: > On Mon, Nov 23, 201

Re: [Qemu-devel] [Qemu-ppc] [PATCH 26/77] ppc/pnv: Add skeletton PowerNV platform

2015-11-23 Thread Benjamin Herrenschmidt
On Fri, 2015-11-20 at 19:21 +1100, David Gibson wrote: > On Wed, Nov 11, 2015 at 11:27:39AM +1100, Benjamin Herrenschmidt > wrote: > > No devices yet, not even an interrupt controller, just to get > > started. > > > > Signed-off-by: Benjamin Herrenschmidt > > --- > >  default-configs/ppc64-softmm

Re: [Qemu-devel] [PATCH for-2.5] vhost-user: clarify start and enable

2015-11-23 Thread Yuanhan Liu
On Mon, Nov 23, 2015 at 12:54:56PM +0200, Michael S. Tsirkin wrote: > It seems that we currently have some duplication between > started and enabled states. > > The actual reason is that enable is not documented correctly: > what it does is connecting ring to the backend. > > This is important fo

Re: [Qemu-devel] [PATCH] virtio-blk: Move resetting of req->mr_next to virtio_blk_handle_rw_error

2015-11-23 Thread Stefan Hajnoczi
On Mon, Nov 23, 2015 at 08:41:20AM +0800, Fam Zheng wrote: > "werror=report" would free the req in virtio_blk_handle_rw_error, we > mustn't write to it in that case. > > Reported-by: Paolo Bonzini > Signed-off-by: Fam Zheng > --- > hw/block/virtio-blk.c | 7 +++ > 1 file changed, 3 insertio

Re: [Qemu-devel] [PATCH v2 06/21] block: Exclude nested options only for children in append_open_options()

2015-11-23 Thread Wen Congyang
On 11/23/2015 11:59 PM, Kevin Wolf wrote: > Some drivers have nested options (e.g. blkdebug rule arrays), which > don't belong to a child node and shouldn't be removed. Don't remove all > options with "." in their name, but check for the complete prefixes of > actually existing child nodes. > > Si

Re: [Qemu-devel] [Qemu-ppc] [PATCH 24/77] ppc: Move exception generation code out of line

2015-11-23 Thread Benjamin Herrenschmidt
On Fri, 2015-11-20 at 18:53 +1100, David Gibson wrote: > On Wed, Nov 11, 2015 at 11:27:37AM +1100, Benjamin Herrenschmidt > wrote: > > There's no point inlining this, if you hit the exception case you > > exit anyway, > > That doesn't quite seem relevant - IIUC this is affecting inlining in > the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 22/77] ppc: Add real mode CI load/store instructions for P7 and P8

2015-11-23 Thread Benjamin Herrenschmidt
On Fri, 2015-11-20 at 18:48 +1100, David Gibson wrote: > > > @@ -380,9 +380,11 @@ typedef struct opcode_t { > >  #if defined(CONFIG_USER_ONLY) > >  #define CHK_HV GEN_PRIV > >  #define CHK_SV GEN_PRIV > > +#define CHK_HVDR GEN_PRIV > > I'm guessing this is supposed to be CHK_HVRM as below. Indee

Re: [Qemu-devel] [Qemu-ppc] [PATCH 21/77] ppc: Rework generation of priv and inval interrupts

2015-11-23 Thread Benjamin Herrenschmidt
On Fri, 2015-11-20 at 18:45 +1100, David Gibson wrote: > snip] > >  /* tlbiel */ > >  static void gen_tlbiel(DisasContext *ctx) > >  { > >  #if defined(CONFIG_USER_ONLY) > > -    gen_inval_exception(ctx, POWERPC_EXCP_PRIV_OPC); > > +    GEN_PRIV; > >  #else > > -    if (unlikely(ctx->pr || !ctx->hv

Re: [Qemu-devel] [Patch v7 3/3] qmp: add monitor command to add/remove a child

2015-11-23 Thread Wen Congyang
On 11/24/2015 12:30 AM, Eric Blake wrote: > On 11/22/2015 11:23 PM, Wen Congyang wrote: >> The new QMP command name is x-blockdev-change. It justs for adding/removing > > s/It justs/It's just/ > >> quorum's child now, and don't support all kinds of children, all kinds of > > s/don't/doesn't/ >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 21/77] ppc: Rework generation of priv and inval interrupts

2015-11-23 Thread Benjamin Herrenschmidt
On Fri, 2015-11-20 at 18:45 +1100, David Gibson wrote: >  > So, I'm not 100% following the logic below, but it looks like the > existing code used SPR_NOACCESS to mark things which generated a > privilege exception compared to NULL for things which generated an > invalid instruction exception.  Usi

Re: [Qemu-devel] [PATCH for-2.5] hw/ppc/spapr: Remove duplicated "pseries" alias

2015-11-23 Thread David Gibson
On Mon, Nov 23, 2015 at 05:13:37PM +0100, Thomas Huth wrote: > The "pseries" alias is currently set twice, one time for the > pseries-2.4 machine and one time for the "pseries-2.5" machine. > To avoid confusion with the alias, let's remove the one from > the older machine class. And while we're at

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Andrew James
On 11/20/2015 01:18 PM, Marc-André Lureau wrote: > Hi > > - Original Message - Hash ivshmem been used in anger? If yes, how? >> >> Still the question to answer. > > I don't expect users to read this ML everyday (anybody actually). Personally, > I have no clue how widespread ivshmem

Re: [Qemu-devel] Build problem with qemu Makefile change

2015-11-23 Thread Michael Roth
Quoting Michael Roth (2015-11-23 12:35:57) > Quoting Steve Ellcey (2015-11-23 12:06:57) > > My qemu build has been failing since this checkin by Michael Roth: > > > > > > http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg03991.html > > > > which changed the top-level Makefile.

[Qemu-devel] Build problem with qemu Makefile change

2015-11-23 Thread Steve Ellcey
My qemu build has been failing since this checkin by Michael Roth: http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg03991.html which changed the top-level Makefile. Is anyone else seeing this? I am building a qemu for MIPS on an x86 linux box with: configure --prefix=/scratch

[Qemu-devel] [PATCH for-2.5] makefile: fix qemu-ga make install for --disable-tools

2015-11-23 Thread Michael Roth
ab59e3e introduced a fix for `make install` on w32 that involved filtering out qemu-ga from $TOOLS install recipe so that we could append $(EXESUF) to it before attempting to install the binary via install-prog function. install-prog takes a list of binaries to install to a particular directory. I

Re: [Qemu-devel] [RFC 01/12] vfio: Start improving VFIO/EEH interface

2015-11-23 Thread Alex Williamson
On Thu, 2015-11-19 at 15:29 +1100, David Gibson wrote: > At present the code handling IBM's Enhanced Error Handling (EEH) interface > on VFIO devices operates by bypassing the usual VFIO logic with > vfio_container_ioctl(). That's a poorly designed interface with unclear > semantics about exactly

[Qemu-devel] [PATCH v4 3/4] usb-mtp: Add support for inotify based file monitoring

2015-11-23 Thread Bandan Das
For now, we use inotify watches to track only a small number of events, namely, add, delete and modify. Note that for delete, the kernel already deactivates the watch for us and we just need to take care of modifying our internal state. inotify is a linux only mechanism. Suggested-by: Gerd Hoffma

[Qemu-devel] [PATCH v4 1/4] usb-mtp: use a list for keeping track of children

2015-11-23 Thread Bandan Das
To support adding/removal of objects, we will need to update the object cache hierarchy we have built internally. Convert to using a Qlist for easier management. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 56 trace-events | 1 +

[Qemu-devel] [PATCH v4 4/4] usb-mtp: add support for basic mtp events

2015-11-23 Thread Bandan Das
When the host polls for events, we check our events qlist and send one event at a time. Also, note that the event packet needs to be sent in one go, so I increased the max packet size to 64. Tested with a linux guest. Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 29 +

[Qemu-devel] [PATCH v4 0/4] usb-mtp events support

2015-11-23 Thread Bandan Das
This series adds support for mtp events that are piggybacked on top of the Linux provided inotify mechanism. It performs well with some light unit testing in a linux guest. The mtp share is still read only, but now the guest will notice updates to the share as long as the mtp client being used supp

[Qemu-devel] [PATCH v4 2/4] usb-mtp: free objects on a mtp reset

2015-11-23 Thread Bandan Das
On a reset, call usb_mtp_object_free on all objects and their children Signed-off-by: Bandan Das --- hw/usb/dev-mtp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/usb/dev-mtp.c b/hw/usb/dev-mtp.c index 10b657d..5b71691 100644 --- a/hw/usb/dev-mtp.c +++ b/hw/usb/dev-mtp.c @@ -908,6 +908

Re: [Qemu-devel] [PATCH for 2.6 2/3] block: Hide HBitmap in block dirty bitmap interface

2015-11-23 Thread John Snow
On 11/20/2015 04:59 AM, Fam Zheng wrote: > HBitmap is an implementation detail of block dirty bitmap that should be > hidden > from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying > HBitmapIter. > > A small difference in the interface is, before, an HBitmapIter is initializ

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -nographic when starting QEMU in 119 and 120

2015-11-23 Thread Max Reitz
On 23.11.2015 03:32, Fam Zheng wrote: > Otherwise, a window flashes on my desktop (built with SDL). Add this as > other cases have it. > > Signed-off-by: Fam Zheng > > --- > v2: Fix 119 too. [Max] > --- > tests/qemu-iotests/119 | 2 +- > tests/qemu-iotests/120 | 2 +- > 2 files changed, 2 inser

[Qemu-devel] [RFC post-2.5 PATCH 3/5] vfio/pci: Convert all MemoryRegion to dynamic alloc and consistent functions

2015-11-23 Thread Alex Williamson
Match common vfio code with setup, exit, and finalize functions for BAR, quirk, and VGA management. VGA is also changed to dynamic allocation to match the other MemoryRegions. Signed-off-by: Alex Williamson --- hw/vfio/pci-quirks.c | 38 - hw/vfio/pci.c| 114 +

[Qemu-devel] [RFC post-2.5 PATCH 1/5] vfio: Wrap VFIO_DEVICE_GET_REGION_INFO

2015-11-23 Thread Alex Williamson
In preparation for supporting capability chains on regions, wrap ioctl(VFIO_DEVICE_GET_REGION_INFO) so we don't duplicate the code for each caller. Signed-off-by: Alex Williamson --- hw/vfio/common.c | 18 + hw/vfio/pci.c | 81 +---

[Qemu-devel] [RFC post-2.5 PATCH 4/5] linux-headers/vfio: Update for proposed capabilities list

2015-11-23 Thread Alex Williamson
Signed-off-by: Alex Williamson --- linux-headers/linux/vfio.h | 53 +++- 1 file changed, 52 insertions(+), 1 deletion(-) diff --git a/linux-headers/linux/vfio.h b/linux-headers/linux/vfio.h index aa276bc..c3860f6 100644 --- a/linux-headers/linux/vfio.h +

[Qemu-devel] [RFC post-2.5 PATCH 2/5] vfio: Generalize region support

2015-11-23 Thread Alex Williamson
Both platform and PCI vfio drivers create a "slow", I/O memory region with one or more mmap memory regions overlayed when supported by the device. Generalize this to a set of common helpers in the core that pulls the region info from vfio, fills the region data, configures slow mapping, and adds he

[Qemu-devel] [RFC post-2.5 PATCH 5/5] vfio: Enable sparse mmap capability

2015-11-23 Thread Alex Williamson
The sparse mmap capability in a vfio region info allows vfio to tell us which sub-areas of a region may be mmap'd. Thus rather than assuming a single mmap covers the entire region and later frobbing it ourselves for things like the PCI MSI-X vector table, we can read that directly from vfio. Sign

[Qemu-devel] [RFC post-2.5 PATCH 0/5] VFIO: capability chains

2015-11-23 Thread Alex Williamson
This is the matching QEMU changes for the proposed kernel-side capability chains. Unfortunately there's also a lot of churn to get to consistent interfaces involved in this series, which allow us to generically handle multiple mmaps overlapping a region and making the actual step of consuming the

Re: [Qemu-devel] [OpenBIOS] [Qemu-ppc] CUDA has problems with Mac OS 10.4

2015-11-23 Thread Mark Cave-Ayland
On 22/11/15 17:39, Programmingkid wrote: Hi Alfonso, Has there been any progress at all as to which extensions may be causing the crashes? >>> >>> Remove these extensions from the Extensions folder and Mac OS 9 will boot >>> to the desktop: >>> >>> Apple Audio Extension >>> Ap

Re: [Qemu-devel] [PATCH for 2.6 1/3] backup: Use Bitmap to replace "s->bitmap"

2015-11-23 Thread John Snow
On 11/20/2015 04:59 AM, Fam Zheng wrote: > "s->bitmap" tracks done sectors, we only check bit states without using any > iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and > more memory efficient. > > Meanwhile, rename it to done_bitmap, to reflect the intention. > > Si

Re: [Qemu-devel] [PATCH v2 for-2.5? 0/4] qjson: save a lot of memory

2015-11-23 Thread Eric Blake
On 11/23/2015 10:44 AM, Paolo Bonzini wrote: > This patch from 2011 (!) saves about 96% of the allocation cost (down > from 500 MiB to 20 MiB) for check-qjson. > > Paolo > > Paolo Bonzini (4): > qjson: replace QString in JSONLexer with GString > qjson: do not save/restore contexts > qjson:

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Bruce Rogers
>>> On 11/20/2015 at 09:07 AM, Markus Armbruster wrote: > Everybody's favourite device model has "size" property. It's declared > as *string* > > DEFINE_PROP_STRING("size", IVShmemState, sizearg), > > which gets converted to a size manually in the realize method: > > } else if (s->siz

Re: [Qemu-devel] MCG_CAP ABI breakage (was Re: [PATCH] target-i386: Do not set MCG_SER_P by default)

2015-11-23 Thread Borislav Petkov
On Mon, Nov 23, 2015 at 05:42:08PM -0200, Eduardo Habkost wrote: > I will let the people working on the actual MCE emulation in KVM > answer that. I am assuming that KVM_MCE_CAP_SUPPORTED is set to > something that makes sense. Well, that should be, IMHO, the same like all those feature bits assig

Re: [Qemu-devel] [PATCH v5 0/5] add ACPI node for fw_cfg on pc and arm

2015-11-23 Thread Laszlo Ersek
On 11/23/15 21:28, Gabriel L. Somlo wrote: > On Mon, Nov 23, 2015 at 08:46:33PM +0100, Laszlo Ersek wrote: >> On 11/23/15 20:31, Gabriel L. Somlo wrote: >>> Couple of items: >>> >>> 1. Ping ? :) >>> >>> 2. Thank you markmb for your R-b ! >>> >>> 3. If anyone's had a chance to look over the correspo

Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-23 Thread Daniel P. Berrange
On Mon, Nov 23, 2015 at 09:05:30PM +0100, Lluís Vilanova wrote: > Daniel P Berrange writes: > [...] > > I don't think this "Errors in user inputs" vs "Other errors" distinction > > really makes sense. Whether an error raised in a piece of code is related > > to user input or not is almost impossibl

Re: [Qemu-devel] [PATCH v2 2/4] qjson: do not save/restore contexts

2015-11-23 Thread Laszlo Ersek
On 11/23/15 21:05, Eric Blake wrote: > On 11/23/2015 10:59 AM, Laszlo Ersek wrote: >> On 11/23/15 18:44, Paolo Bonzini wrote: >>> JSON is LL(1) and our parser indeed needs only 1 token lookahead. >>> Saving the parser context is mostly unnecessary; we can replace it >>> with peeking at the next tok

Re: [Qemu-devel] [PATCH v5 0/5] add ACPI node for fw_cfg on pc and arm

2015-11-23 Thread Gabriel L. Somlo
On Mon, Nov 23, 2015 at 08:46:33PM +0100, Laszlo Ersek wrote: > On 11/23/15 20:31, Gabriel L. Somlo wrote: > > Couple of items: > > > > 1. Ping ? :) > > > > 2. Thank you markmb for your R-b ! > > > > 3. If anyone's had a chance to look over the corresponding guest-side > >kernel sysfs driver

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Marc-André Lureau
Hi - Original Message - > On 11/23/2015 07:46 AM, Markus Armbruster wrote: > > >>> If it's not broken, please explain to me how the guest should find out > >>> whether its ivshmem device sports a doorbell. > >> > >> If you have received ID, you should be good to use the doorbell. > > > >

Re: [Qemu-devel] [PATCH v5 1/4] firmware: introduce sysfs driver for QEMU's fw_cfg device

2015-11-23 Thread kbuild test robot
Hi Gabriel, [auto build test WARNING on v4.4-rc2] [also build test WARNING on next-20151123] [cannot apply to robh/for-next] url: https://github.com/0day-ci/linux/commits/Gabriel-L-Somlo/SysFS-driver-for-QEMU-fw_cfg-device/20151124-000402 config: arm-allyesconfig (attached as .config

Re: [Qemu-devel] [PATCH v2 2/2] doc: Introduce coding style for errors

2015-11-23 Thread Lluís Vilanova
Daniel P Berrange writes: [...] > I don't think this "Errors in user inputs" vs "Other errors" distinction > really makes sense. Whether an error raised in a piece of code is related > to user input or not is almost impossible to determine in practice. So as > a rule to follow it is not practical.

  1   2   3   >