Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block

2015-11-19 Thread Stefan Weil
Am 20.11.2015 um 07:29 schrieb Qinghao Tang: > I think the patch can solve this vulnerability. > I confirm that the loop exist , the poc code can prove that. > > > #include > #include > #include > #include > #define PAGE_OFFSET 0x0C00 > MODULE_LICENSE("GPL"); > static int hello_init(void) >

[Qemu-devel] [PATCH for-2.5] eepro100: Prevent two endless loops

2015-11-19 Thread Stefan Weil
http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg04592.html shows an example how an endless loop in function action_command can be achieved. During my code review, I noticed a 2nd case which can result in an endless loop. Reported-by: Qinghao Tang Signed-off-by: Stefan Weil --- hw/ne

Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block

2015-11-19 Thread P J P
Hello Qinghao, +-- On Fri, 20 Nov 2015, Qinghao Tang wrote --+ | I think the patch can solve this vulnerability. | I confirm that the loop exist , the poc code can prove that. Great! Thank you so much for the confirmation and the POC code. I'll send an updated patch shortly. Thank you. -- P

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Tian, Kevin
> From: Alex Williamson [mailto:alex.william...@redhat.com] > Sent: Friday, November 20, 2015 4:03 AM > > > > > > > The proposal is therefore that GPU vendors can expose vGPUs to > > > userspace, and thus to QEMU, using the VFIO API. For instance, vfio > > > supports modular bus drivers and IOMMU

Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block

2015-11-19 Thread Qinghao Tang
I think the patch can solve this vulnerability. I confirm that the loop exist , the poc code can prove that. #include #include #include #include #define PAGE_OFFSET 0x0C00 MODULE_LICENSE("GPL"); static int hello_init(void) { void* pvirt; void* pphy; unsigned long* pdbal; unsigned

Re: [Qemu-devel] [PATCH] fixup! qapi: Tighten the regex on valid names

2015-11-19 Thread Markus Armbruster
Eric Blake writes: > On 11/19/2015 01:10 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> [Replace the old commit message with this:] >> >> Fixup patch squashed, commit message replaced. > > The version of the patch currently on qapi-next (id 22c38fe) missed the > addition of the new

Re: [Qemu-devel] [PATCH v2 4/4] json-streamer: Limit number of tokens in addition to total size

2015-11-19 Thread Markus Armbruster
Paolo Bonzini writes: > On 19/11/2015 16:29, Markus Armbruster wrote: >> Commit 29c75dd "json-streamer: limit the maximum recursion depth and >> maximum token count" attempts to guard against excessive heap usage by >> limiting total token size (it says "token count", but that's a lie). >> >> To

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Tian, Kevin
> From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, November 19, 2015 4:41 PM > > Hi, > > > > Another area of extension is how to expose a framebuffer to QEMU for > > > seamless integration into a SPICE/VNC channel. For this I believe we > > > could use a new region, much like w

Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block

2015-11-19 Thread P J P
Hello Qinghao, +-- On Fri, 20 Nov 2015, Qinghao Tang wrote --+ | Currently what problem do you have? Perhaps I could provide more support. Could you please confirm if the proposed patch here fixes the issue. Secondly there is uncertainty if the CB loop like Jason mentioned earlier is possi

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Tian, Kevin
> From: Song, Jike > Sent: Friday, November 20, 2015 1:52 PM > > On 11/20/2015 12:22 PM, Alex Williamson wrote: > > On Fri, 2015-11-20 at 10:58 +0800, Jike Song wrote: > >> On 11/19/2015 11:52 PM, Alex Williamson wrote: > >>> On Thu, 2015-11-19 at 15:32 +, Stefano Stabellini wrote: > On T

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Jike Song
On 11/20/2015 12:22 PM, Alex Williamson wrote: On Fri, 2015-11-20 at 10:58 +0800, Jike Song wrote: On 11/19/2015 11:52 PM, Alex Williamson wrote: On Thu, 2015-11-19 at 15:32 +, Stefano Stabellini wrote: On Thu, 19 Nov 2015, Jike Song wrote: Hi Alex, thanks for the discussion. In addition

Re: [Qemu-devel] [PATCH] vhost-user: set link down when the char device is closed

2015-11-19 Thread Wen Congyang
To Jason Wang: I think this patch should be for qemu-2.5 Thanks Wen Congyang On 11/11/2015 02:53 PM, Wen Congyang wrote: > Signed-off-by: Wen Congyang > --- > net/vhost-user.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/vhost-user.c b/net/vhost-user.c > index

Re: [Qemu-devel] [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target

2015-11-19 Thread Ming Lin
On Fri, 2015-11-20 at 06:16 +0100, Christoph Hellwig wrote: > Thanks Ming, > > from a first quick view this looks great. I'll look over it in a bit > more detail once I get a bit more time. Thanks to CC Nic :-) But funny, I double-checked bash history. I actually CCed Nic. Don't know why it's l

Re: [Qemu-devel] [RFC PATCH 4/9] nvmet: add a controller "start" hook

2015-11-19 Thread Ming Lin
On Fri, 2015-11-20 at 06:13 +0100, Christoph Hellwig wrote: > On Thu, Nov 19, 2015 at 04:21:03PM -0800, Ming Lin wrote: > > #define NVMET_SUBSYS_NAME_LEN 256 > > charsubsys_name[NVMET_SUBSYS_NAME_LEN]; > > + > > + void*opaque; > > + void

Re: [Qemu-devel] [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target

2015-11-19 Thread Christoph Hellwig
Thanks Ming, from a first quick view this looks great. I'll look over it in a bit more detail once I get a bit more time.

Re: [Qemu-devel] [RFC PATCH 4/9] nvmet: add a controller "start" hook

2015-11-19 Thread Christoph Hellwig
On Thu, Nov 19, 2015 at 04:21:03PM -0800, Ming Lin wrote: > #define NVMET_SUBSYS_NAME_LEN256 > charsubsys_name[NVMET_SUBSYS_NAME_LEN]; > + > + void*opaque; > + void(*start)(void *); > }; Why can't vhost use

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Alex Williamson
On Fri, 2015-11-20 at 10:58 +0800, Jike Song wrote: > On 11/19/2015 11:52 PM, Alex Williamson wrote: > > On Thu, 2015-11-19 at 15:32 +, Stefano Stabellini wrote: > >> On Thu, 19 Nov 2015, Jike Song wrote: > >>> Hi Alex, thanks for the discussion. > >>> > >>> In addition to Kevin's replies, I ha

Re: [Qemu-devel] [OpenBIOS] CUDA has problems with Mac OS 10.4

2015-11-19 Thread Segher Boessenkool
On Thu, Nov 12, 2015 at 07:45:40PM +0100, BALATON Zoltan wrote: > >Interesting. Did you use "-usb -device usb-keyboard" to enable usb > >support in QEMU when running Finnix? > > Yes (or more exactly I had a patch always adding usb keyboard instead of > adb one to match hardware) Some mac99/pmu9

[Qemu-devel] [RFC v1] virtio-crypto specification

2015-11-19 Thread Gonglei (Arei)
Hi guys, After initial discussion at this year's KVM forum, I post the RFC version of virtio-crypto device specification now. If you have any comments, please let me know, thanks. Regards, -Gonglei 1 Crypto Device The virtio crypto device is a virtual crypto device (ie. hardware crypt

[Qemu-devel] some confusion on qemu i/o pocess and the qcow2 format

2015-11-19 Thread ??????
1.what is the difference of bdrv_co_readv and bdrv_aio_readv?? 2.I am confused about the I/O pocess of qcow2, i find. Can anybody tell me the detail pocess? or arethere any useful tools to trace the pocess?

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Jike Song
On 11/19/2015 11:52 PM, Alex Williamson wrote: On Thu, 2015-11-19 at 15:32 +, Stefano Stabellini wrote: On Thu, 19 Nov 2015, Jike Song wrote: Hi Alex, thanks for the discussion. In addition to Kevin's replies, I have a high-level question: can VFIO be used by QEMU for both KVM and Xen? N

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Jike Song
On 11/19/2015 07:09 PM, Paolo Bonzini wrote: On 19/11/2015 09:40, Gerd Hoffmann wrote: But this code should be minor to be maintained in libvirt. As far I know libvirt only needs to discover those devices. If they look like sr/iov devices in sysfs this might work without any changes to libvirt

Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block

2015-11-19 Thread Qinghao Tang
Currently what problem do you have? Perhaps I could provide more support. And please give this vulnerability a cve id. Thanks! 2015-11-04 11:31 GMT+08:00 Jason Wang : > > > On 11/04/2015 02:49 AM, P J P wrote: > > +-- On Tue, 20 Oct 2015, Jason Wang wrote --+ > > | Can this survive if we had a c

Re: [Qemu-devel] [PATCH v2 1/9] cpus: Reclaim vCPU objects

2015-11-19 Thread Bharata B Rao
On Thu, Nov 19, 2015 at 10:10:06AM -0500, Matthew Rosato wrote: > From: Gu Zheng > > In order to deal well with the kvm vcpus (which can not be removed without any > protection), we do not close KVM vcpu fd, just record and mark it as stopped > into a list, so that we can reuse it for the appendi

Re: [Qemu-devel] [PATCH] SeaBios: Fix reset procedure reentrancy problem on qemu-kvm platform

2015-11-19 Thread Xulei (Stone)
>On Thu, Nov 19, 2015 at 12:42:50PM +, Xulei (Stone) wrote: >> Kevin, >> >> After deeply analyzing, i think there may be 3 possible reasons: >> 1)wrong CountCPUs value. It seems CountCPUs++ in handle_smp() has no >> lock to protect. So, sometimes, 2 or more vcpu may get the same >> current

Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/77] ppc: Add number of threads per core to the processor definition

2015-11-19 Thread Benjamin Herrenschmidt
On Mon, 2015-11-16 at 16:16 +1100, David Gibson wrote: > On Wed, Nov 11, 2015 at 11:27:21AM +1100, Benjamin Herrenschmidt > wrote: > > Also use it to clamp the max SMT mode and ensure that the cpu_dt_id > > are offset by that value in order to preserve consistency with the > > HW implementations. >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 09/77] ppc: Fix do_rfi() for rfi emulation

2015-11-19 Thread Benjamin Herrenschmidt
On Thu, 2015-11-19 at 21:23 +1100, Benjamin Herrenschmidt wrote: >  > I only just discovered that rfi is actually gone from arch 2.07 :-) > > I'll dig a bit more tomorrow. Ok, so I had a closer look and tore that stuff appart even more :-) If you are curious, feel free to check out github. I've

[Qemu-devel] [RFC PATCH 8/9] nvme-vhost: add vhost memory helpers

2015-11-19 Thread Ming Lin
From: Ming Lin This borrows code from Hannes Reinecke's rts-megasas. Cc: Hannes Reinecke Signed-off-by: Ming Lin --- drivers/nvme/target/vhost.c | 108 1 file changed, 108 insertions(+) diff --git a/drivers/nvme/target/vhost.c b/drivers/nvme/targe

[Qemu-devel] [RFC PATCH 6/9] nvmet: add a "parse_extra_admin_cmd" hook

2015-11-19 Thread Ming Lin
From: Ming Lin This is used to execute controller specific cmd parse code Signed-off-by: Ming Lin --- drivers/nvme/target/admin-cmd.c | 7 +++ drivers/nvme/target/nvmet.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admi

[Qemu-devel] [RFC PATCH 9/9] nvme-vhost: add nvme queue handlers

2015-11-19 Thread Ming Lin
From: Ming Lin This adds nvme submission/completion queue handlers, which are ported from qemu-nvme. And hooks into nvme-target to do the real job. Cc: Keith Busch Signed-off-by: Ming Lin --- drivers/nvme/target/vhost.c | 420 +++- 1 file changed, 416

[Qemu-devel] [RFC PATCH 3/9] nvme-vhost: add basic nvme bar read/write

2015-11-19 Thread Ming Lin
From: Ming Lin Signed-off-by: Ming Lin --- drivers/nvme/target/vhost.c | 102 include/uapi/linux/vhost.h | 17 ++-- 2 files changed, 116 insertions(+), 3 deletions(-) diff --git a/drivers/nvme/target/vhost.c b/drivers/nvme/target/vhost.c index

[Qemu-devel] [RFC PATCH 4/9] nvmet: add a controller "start" hook

2015-11-19 Thread Ming Lin
From: Ming Lin This is used to execute controller specific start code Signed-off-by: Ming Lin --- drivers/nvme/target/core.c | 3 +++ drivers/nvme/target/nvmet.h | 3 +++ 2 files changed, 6 insertions(+) diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c index 1bfef66..0a0f

[Qemu-devel] [RFC PATCH 7/9] nvme-vhost: add "parse_extra_admin_cmd" callback

2015-11-19 Thread Ming Lin
From: Ming Lin Signed-off-by: Ming Lin --- drivers/nvme/target/vhost.c | 153 1 file changed, 153 insertions(+) diff --git a/drivers/nvme/target/vhost.c b/drivers/nvme/target/vhost.c index 4a147d6..04ed0bc 100644 --- a/drivers/nvme/target/vhost.c ++

[Qemu-devel] [RFC PATCH 5/9] nvme-vhost: add controller "start" callback

2015-11-19 Thread Ming Lin
From: Ming Lin Signed-off-by: Ming Lin --- drivers/nvme/target/vhost.c | 106 1 file changed, 106 insertions(+) diff --git a/drivers/nvme/target/vhost.c b/drivers/nvme/target/vhost.c index 01c44b8..4a147d6 100644 --- a/drivers/nvme/target/vhost.c ++

[Qemu-devel] [RFC PATCH 0/9] vhost-nvme: new qemu nvme backend using nvme target

2015-11-19 Thread Ming Lin
Hi, This is the first attempt to add a new qemu nvme backend using in-kernel nvme target. Most code are ported from qemu-nvme and also borrow code from Hannes Reinecke's rts-megasas. It's similar as vhost-scsi, but doesn't use virtio. The advantage is guest can run unmodified NVMe driver. So gue

[Qemu-devel] [RFC PATCH 2/9] nvme-vhost: add basic ioctl handlers

2015-11-19 Thread Ming Lin
From: Ming Lin Signed-off-by: Ming Lin --- drivers/nvme/target/core.c | 1 + drivers/nvme/target/vhost.c | 264 +++- include/uapi/linux/vhost.h | 15 +++ 3 files changed, 279 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/target/core.c b/dri

[Qemu-devel] [RFC PATCH 1/9] nvme-vhost: add initial commit

2015-11-19 Thread Ming Lin
From: Ming Lin Signed-off-by: Ming Lin --- drivers/nvme/target/Kconfig | 11 +++ drivers/nvme/target/Makefile | 2 ++ drivers/nvme/target/vhost.c | 16 3 files changed, 29 insertions(+) create mode 100644 drivers/nvme/target/vhost.c diff --git a/drivers/nvme/target

Re: [Qemu-devel] [RESEND RFC 0/6] AMD XGBE KVM platform passthrough

2015-11-19 Thread Alex Williamson
On Thu, 2015-11-19 at 15:22 +, Eric Auger wrote: > I am resending this RFC from Oct 12, after kernel 4.4-rc1 and > QEMU 2.5-rc1, hoping things have calmed down a little bit. > > This RFC allows to set up AMD XGBE passthrough. This was tested on AMD > Seattle. > > The first upstreamed device s

Re: [Qemu-devel] [PATCH] vfio: Align iova also to IOMMU page size

2015-11-19 Thread Alex Williamson
On Thu, 2015-11-19 at 13:29 +0300, Pavel Fedin wrote: > Hello! > > > > On some architectures TARGET_PAGE_ALIGN() is not enough to get the right > > > alignment. For example on ARM TARGET_PAGE_BITS is 10 because some old CPUs > > > support 1K page size, while minimum SMMU page size is 4K. > > > >

Re: [Qemu-devel] [PATCH] fixup! qapi: Tighten the regex on valid names

2015-11-19 Thread Eric Blake
On 11/19/2015 01:10 AM, Markus Armbruster wrote: > Eric Blake writes: > >> [Replace the old commit message with this:] > > Fixup patch squashed, commit message replaced. The version of the patch currently on qapi-next (id 22c38fe) missed the addition of the new tests/qapi-schema/reserved-enum-q

Re: [Qemu-devel] [PATCH v2 4/4] json-streamer: Limit number of tokens in addition to total size

2015-11-19 Thread Paolo Bonzini
On 19/11/2015 16:29, Markus Armbruster wrote: > Commit 29c75dd "json-streamer: limit the maximum recursion depth and > maximum token count" attempts to guard against excessive heap usage by > limiting total token size (it says "token count", but that's a lie). > > Total token size is a rather im

Re: [Qemu-devel] [PATCH] typedefs: Put them back into alphabetical order

2015-11-19 Thread Eric Blake
On 11/19/2015 06:10 AM, Daniel P. Berrange wrote: > On Thu, Nov 19, 2015 at 01:03:39PM +, Dr. David Alan Gilbert wrote: >> * Markus Armbruster (arm...@redhat.com) wrote: >>> "Please keep this list in alphabetical order" has been more honoured >>> in the breach than in the observance. Clean up.

Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu

2015-11-19 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > On Thu, Nov 19, 2015 at 03:38:03PM -0500, Bandan Das wrote: >> "Michael S. Tsirkin" writes: >> >> > From: Bandan Das >> > >> > There's no indication of any sort that i440fx doesn't support >> > "iommu=on" >> >> Oh, Markus quite didn't like this approach because

Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu

2015-11-19 Thread Michael S. Tsirkin
On Thu, Nov 19, 2015 at 03:55:35PM -0500, Bandan Das wrote: > "Michael S. Tsirkin" writes: > > > On Thu, Nov 19, 2015 at 03:38:03PM -0500, Bandan Das wrote: > >> "Michael S. Tsirkin" writes: > >> > >> > From: Bandan Das > >> > > >> > There's no indication of any sort that i440fx doesn't suppor

Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu

2015-11-19 Thread Bandan Das
"Michael S. Tsirkin" writes: > On Thu, Nov 19, 2015 at 03:38:03PM -0500, Bandan Das wrote: >> "Michael S. Tsirkin" writes: >> >> > From: Bandan Das >> > >> > There's no indication of any sort that i440fx doesn't support >> > "iommu=on" >> >> Oh, Markus quite didn't like this approach because

Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu

2015-11-19 Thread Michael S. Tsirkin
On Thu, Nov 19, 2015 at 03:38:03PM -0500, Bandan Das wrote: > "Michael S. Tsirkin" writes: > > > From: Bandan Das > > > > There's no indication of any sort that i440fx doesn't support > > "iommu=on" > > Oh, Markus quite didn't like this approach because this is > true for all other machines too

[Qemu-devel] [PATCH v3 3/3] i.MX: Add an i.MX25 specific CCM class/instance.

2015-11-19 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * rework loging to match other i.MX drivers Changes since v2: * We moved to an inheritance QOM scheme hw/arm/fsl-imx25.c | 2 +- hw/misc/Makefile.objs | 1 + hw/misc/imx25_ccm.c | 243 +

[Qemu-devel] [PATCH v3 1/3] i.MX: rename i.MX CCM get_clock() function and CLK ID enum names

2015-11-19 Thread Jean-Christophe Dubois
This is to prepare for CCM code refactoring. This is just a bit of function and enum values renaming. We also remove some useless intermediate variables. Signed-off-by: Jean-Christophe Dubois --- Changes since v1: * Not present Changes since v2: * Not present hw/misc/imx_ccm.c

[Qemu-devel] [PATCH v3 2/3] i.MX: Split the CCM class into an abstact base class and a concrete class.

2015-11-19 Thread Jean-Christophe Dubois
The IMX_CCM class is now the base abstract class that is used by EPIT and GPT timer implementation. IMX31_CCM class is the concrete class implementing CCM for i.MX31 SOC. For now the i.MX25 continues to use the i.MX31 CCM implementation. An i.MX25 specific CCM will be introduced in a later patch

[Qemu-devel] [PATCH v3 0/3] Add an i.MX25 specific CCM driver

2015-11-19 Thread Jean-Christophe Dubois
i.MX25 SOC has a different CCM device than i.MX31. Qemu i.MX25 emulation was built with i.MX31 CCM driver. This allows Linux to work on top of the i.MX25 emultion but this is not correct. Furthermore, other SOC we could emulate like i.MX6 have yet a different implementation of the CCM device. So

Re: [Qemu-devel] [PULL 08/15] i440fx: print an error message if user tries to enable iommu

2015-11-19 Thread Bandan Das
"Michael S. Tsirkin" writes: > From: Bandan Das > > There's no indication of any sort that i440fx doesn't support > "iommu=on" Oh, Markus quite didn't like this approach because this is true for all other machines too. Anyway, I will keep in mind to take care of this when I post a generic patch

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Alex Williamson
Hi Kevin, On Thu, 2015-11-19 at 04:06 +, Tian, Kevin wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Thursday, November 19, 2015 2:12 AM > > > > [cc +qemu-devel, +paolo, +gerd] > > > > On Tue, 2015-10-27 at 17:25 +0800, Jike Song wrote: > > > Hi all, > > > > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.5] mac_dbdma: always initialize channel field in DBDMA_channel

2015-11-19 Thread Thomas Huth
On 13/11/15 13:10, Hervé Poussineau wrote: > Le 13/11/2015 11:40, Thomas Huth a écrit : >> On 13/11/15 10:45, Hervé Poussineau wrote: >>> Le 13/11/2015 05:09, Programmingkid a écrit : On Nov 12, 2015, at 11:04 PM, qemu-ppc-requ...@nongnu.org wrote: > Message: 3 > Date: Thu, 1

Re: [Qemu-devel] [PULL for-2.5 v2 00/10] QOM devices patch queue 2015-11-19

2015-11-19 Thread Peter Maydell
On 19 November 2015 at 14:35, Andreas Färber wrote: > Hello Peter, > > This is my late QOM (devices) patch queue. Please pull. > > v2: GLib version incompatibility addressed, Reviewed-bys added. > > Regards, > Andreas > > Cc: Peter Maydell > Cc: Daniel P. Berrange > Cc: Pavel Fedin > > The foll

Re: [Qemu-devel] [PATCH v12 27/36] qapi: Forbid case-insensitive clashes

2015-11-19 Thread Markus Armbruster
Eric Blake writes: > On 11/19/2015 09:50 AM, Markus Armbruster wrote: >> Let's think through this on a higher level. >> >> I figure the motivation for this patch is twofold: >> >> 1. C identifier clash detection >> > >> >> 2. Dislike for interfaces that differ only in case > > And the related

Re: [Qemu-devel] [PULL 00/15] vhost, pc: fixes for 2.5

2015-11-19 Thread Peter Maydell
On 19 November 2015 at 13:35, Michael S. Tsirkin wrote: > The following changes since commit 8337c6cbc37c6b2184f41bab3eaff47d5e68012a: > > Update version for v2.5.0-rc0 release (2015-11-13 17:10:36 +) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst

Re: [Qemu-devel] [PULL 00/14] Migration pull request

2015-11-19 Thread John Snow
On 11/19/2015 10:03 AM, Peter Maydell wrote: > On 19 November 2015 at 14:44, Peter Maydell wrote: >> On 19 November 2015 at 13:21, Peter Maydell wrote: >>> On 19 November 2015 at 13:12, Peter Maydell >>> wrote: Hi. Unfortunately this failed in 'make check' (x86-64 Linux, debug build): >>

Re: [Qemu-devel] [PATCH v12 27/36] qapi: Forbid case-insensitive clashes

2015-11-19 Thread Eric Blake
On 11/19/2015 09:50 AM, Markus Armbruster wrote: > Let's think through this on a higher level. > > I figure the motivation for this patch is twofold: > > 1. C identifier clash detection > > > 2. Dislike for interfaces that differ only in case And the related dislike for interfaces that differ

[Qemu-devel] [Bug 1297218] Re: guest hangs after live migration due to tsc jump

2015-11-19 Thread Serge Hallyn
Thanks - marked fixed released for development release. We can SRU this into trusty if we know exactly which patch actualy fixed it. ** Changed in: qemu (Ubuntu) Status: Confirmed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is s

Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2015-11-19 Thread Markus Armbruster
Eric Blake writes: > On 11/19/2015 09:12 AM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> The CpuInfo struct is used only by the 'query-cpus' output >>> command, so we are free to modify it by adding fields (clients >>> are already supposed to ignore unknown output fields), or by >>> c

Re: [Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-11-19 Thread Paolo Bonzini
On 19/11/2015 17:00, Grundmann, Christian wrote: > Hi, it seems that using virtio-scsi did the trick, But now the VMs > are pausing without an coredump, so the underlying Problem (no > storage Error) is not fixed, As I am using Snapshots (and so the > disks have to grow very fast) I try if tuning

Re: [Qemu-devel] [PATCH v2 0/4] json-streamer: Fix up code to limit nesting and size

2015-11-19 Thread Markus Armbruster
Eric Blake writes: > On 11/19/2015 08:29 AM, Markus Armbruster wrote: >> Ugh, I almost dropped this on the floor. I think it should go into >> 2.5, and I plan to take it through my tree. If you disagree, please >> speak up. > > It sounds like a bug fix to me (avoiding core dumps due to > user-t

Re: [Qemu-devel] [PATCH v12 27/36] qapi: Forbid case-insensitive clashes

2015-11-19 Thread Markus Armbruster
Let's think through this on a higher level. I figure the motivation for this patch is twofold: 1. C identifier clash detection We generate C identifiers derived from QAPI names. These can clash with (1) each other, (2) C keywords and selected other well-known identifiers, and (3) the u

Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2015-11-19 Thread Eric Blake
On 11/19/2015 09:12 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The CpuInfo struct is used only by the 'query-cpus' output >> command, so we are free to modify it by adding fields (clients >> are already supposed to ignore unknown output fields), or by >> changing optional members to m

[Qemu-devel] [Bug 1494350] Re: QEMU: causes vCPU steal time overflow on live migration

2015-11-19 Thread Dr. David Alan Gilbert
I think that's host. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1494350 Title: QEMU: causes vCPU steal time overflow on live migration Status in QEMU: Fix Committed Bug description: I'm pa

Re: [Qemu-devel] [PULL 0/3] target-arm queue

2015-11-19 Thread Peter Maydell
ging > (2015-11-18 17:07:24 +) > > are available in the git repository at: > > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20151119 > > for you to fetch changes up to ce8a1b5449cd8c4c2831abb581d3208c3a3745a0: > > target-arm: Upda

Re: [Qemu-devel] [PATCH v2 0/4] json-streamer: Fix up code to limit nesting and size

2015-11-19 Thread Eric Blake
On 11/19/2015 08:29 AM, Markus Armbruster wrote: > Ugh, I almost dropped this on the floor. I think it should go into > 2.5, and I plan to take it through my tree. If you disagree, please > speak up. It sounds like a bug fix to me (avoiding core dumps due to user-triggerable input) and on that g

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Stefano Stabellini
On Thu, 19 Nov 2015, Paolo Bonzini wrote: > On 19/11/2015 16:32, Stefano Stabellini wrote: > > > In addition to Kevin's replies, I have a high-level question: can VFIO > > > be used by QEMU for both KVM and Xen? > > > > No. VFIO cannot be used with Xen today. When running on Xen, the IOMMU > > is

Re: [Qemu-devel] [PATCH v12 24/36] cpu: Convert CpuInfo into flat union

2015-11-19 Thread Markus Armbruster
Eric Blake writes: > The CpuInfo struct is used only by the 'query-cpus' output > command, so we are free to modify it by adding fields (clients > are already supposed to ignore unknown output fields), or by > changing optional members to mandatory, while still keeping > QMP wire compatibility wi

Re: [Qemu-devel] [PATCH 4/4] target-ppc: Handle NMI guest exit

2015-11-19 Thread Aravinda Prasad
On Thursday 19 November 2015 07:26 AM, Alexey Kardashevskiy wrote: > On 11/13/2015 05:23 AM, Aravinda Prasad wrote: > + +/* + * Currently KVM only passes on the uncorrected machine + * check memory error to guest. Other machine check errors + * such as SLB multi-hit and

Re: [Qemu-devel] [PATCH] virtio: Implement userspace forwarding for host notifiers

2015-11-19 Thread Pavel Fedin
Hello! > If I read this correctly, memory regions already keep track of > ioeventfds and this patch can simply trigger them manually if that had > not already been done? Yes, exactly, and this is the new idea. > Only that we don't have such a nice tracking structure that memory > regions alrea

Re: [Qemu-devel] WG: [ovirt-users] Segmentation fault in libtcmalloc

2015-11-19 Thread Grundmann, Christian
Hi, it seems that using virtio-scsi did the trick, But now the VMs are pausing without an coredump, so the underlying Problem (no storage Error) is not fixed, As I am using Snapshots (and so the disks have to grow very fast) I try if tuning "volume_utilization_percent" and "volume_utilization_ch

Re: [Qemu-devel] [PULL 00/14] Migration pull request

2015-11-19 Thread Peter Maydell
Apply, please. > > > The following changes since commit 8f280309030331a912fd8924c129d8bd59e1bdc7: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2015-11-18 17:07:24 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Alex Williamson
On Thu, 2015-11-19 at 15:32 +, Stefano Stabellini wrote: > On Thu, 19 Nov 2015, Jike Song wrote: > > Hi Alex, thanks for the discussion. > > > > In addition to Kevin's replies, I have a high-level question: can VFIO > > be used by QEMU for both KVM and Xen? > > No. VFIO cannot be used with Xe

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Paolo Bonzini
On 19/11/2015 16:32, Stefano Stabellini wrote: > > In addition to Kevin's replies, I have a high-level question: can VFIO > > be used by QEMU for both KVM and Xen? > > No. VFIO cannot be used with Xen today. When running on Xen, the IOMMU > is owned by Xen. I don't think QEMU command line compa

Re: [Qemu-devel] [PATCH v2 2/9] cpus: Add a sync version of cpu_remove()

2015-11-19 Thread Matthew Rosato
On 11/19/2015 10:25 AM, Paolo Bonzini wrote: > > > On 19/11/2015 16:10, Matthew Rosato wrote: >> From: Bharata B Rao >> >> This sync API will be used by the CPU hotplug code to wait for the CPU to >> completely get removed before flagging the failure to the device_add >> command. >> >> Sync vers

Re: [Qemu-devel] [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

2015-11-19 Thread Stefano Stabellini
On Thu, 19 Nov 2015, Jike Song wrote: > Hi Alex, thanks for the discussion. > > In addition to Kevin's replies, I have a high-level question: can VFIO > be used by QEMU for both KVM and Xen? No. VFIO cannot be used with Xen today. When running on Xen, the IOMMU is owned by Xen.

[Qemu-devel] [PATCH v2 4/4] json-streamer: Limit number of tokens in addition to total size

2015-11-19 Thread Markus Armbruster
Commit 29c75dd "json-streamer: limit the maximum recursion depth and maximum token count" attempts to guard against excessive heap usage by limiting total token size (it says "token count", but that's a lie). Total token size is a rather imprecise predictor of heap usage: many small tokens use mor

[Qemu-devel] [PATCH v2 2/4] json-streamer: Don't crash when input exceeds nesting limit

2015-11-19 Thread Markus Armbruster
We limit nesting depth and input size to defend against input triggering excessive heap or stack memory use (commit 29c75dd json-streamer: limit the maximum recursion depth and maximum token count). However, when the nesting limit is exceeded, parser_context_peek_token()'s assertion fails. Broken

[Qemu-devel] [PATCH v2 0/4] json-streamer: Fix up code to limit nesting and size

2015-11-19 Thread Markus Armbruster
Ugh, I almost dropped this on the floor. I think it should go into 2.5, and I plan to take it through my tree. If you disagree, please speak up. We limit nesting depth and input size to defend against input triggering excessive heap or stack memory use (commit 29c75dd json-streamer: limit the ma

[Qemu-devel] [PATCH v2 1/4] json-streamer: Apply nesting limit more sanely

2015-11-19 Thread Markus Armbruster
The nesting limit from commit 29c75dd "json-streamer: limit the maximum recursion depth and maximum token count" applies separately to braces and brackets. This makes no sense. Apply it to their sum, because that's actually a measure of recursion depth. Signed-off-by: Markus Armbruster Reviewed

[Qemu-devel] [PATCH v2 3/4] check-qjson: Add test for JSON nesting depth limit

2015-11-19 Thread Markus Armbruster
This would have prevented the regression mentioned in the previous commit. Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake --- tests/check-qjson.c | 25 + 1 file changed, 25 insertions(+) diff --git a/tests/check-qjson.c b/tests/check-qjson.c index 1cfffa5..61e

[Qemu-devel] [PATCH] Assume madvise for (no)hugepage works

2015-11-19 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" madvise() returns EINVAL in the case of many failures, but also returns it in cases where the host kernel doesn't have THP enabled. Postcopy only really cares that THP is off before it detects faults, and turns it back on afterwards; so we're going to have to assume

Re: [Qemu-devel] [PATCH v2 2/9] cpus: Add a sync version of cpu_remove()

2015-11-19 Thread Paolo Bonzini
On 19/11/2015 16:10, Matthew Rosato wrote: > From: Bharata B Rao > > This sync API will be used by the CPU hotplug code to wait for the CPU to > completely get removed before flagging the failure to the device_add > command. > > Sync version of this call is needed to correctly recover from CPU

[Qemu-devel] [RESEND RFC 5/6] hw/arm/sysbus-fdt: helpers for clock node generation

2015-11-19 Thread Eric Auger
Some passthrough'ed devices depend on clock nodes. Those need to be generated in the guest device tree. This patch introduces some helpers to build a clock node from information retrieved from host device tree. - inherit_properties copies properties from a host device tree node to a guest device

Re: [Qemu-devel] [PATCH 0/3] vmw_pvscsi: Fine-tune device capabilities

2015-11-19 Thread Paolo Bonzini
On 19/11/2015 15:21, Shmulik Ladkani wrote: > Various fixes to what the vmw_pvscsi device reports in its PCI > configuration space, to better align with VMware virtual hardware > as exposed by ESXi/Workstation. > > Shmulik Ladkani (3): > vmw_pvscsi: Set device subsystem and revision > vmw_pv

[Qemu-devel] [RESEND RFC 0/6] AMD XGBE KVM platform passthrough

2015-11-19 Thread Eric Auger
I am resending this RFC from Oct 12, after kernel 4.4-rc1 and QEMU 2.5-rc1, hoping things have calmed down a little bit. This RFC allows to set up AMD XGBE passthrough. This was tested on AMD Seattle. The first upstreamed device supporting KVM platform passthrough was the Calxeda Midway XGMAC. Co

[Qemu-devel] [RESEND RFC 1/6] hw/vfio/platform: amd-xgbe device

2015-11-19 Thread Eric Auger
This patch introduces the amd-xgbe VFIO platform device. It allows the guest to do passthrough on a device exposing an "amd,xgbe-seattle-v1a" compat string. Signed-off-by: Eric Auger --- hw/vfio/Makefile.objs | 1 + hw/vfio/amd-xgbe.c | 55

[Qemu-devel] [RESEND RFC 4/6] device_tree: introduce qemu_fdt_getprop_optional

2015-11-19 Thread Eric Auger
Current qemu_fdt_getprop exits if the property is not found. It is sometimes needed to read an optional property, in which case we do not wish to exit but simply returns a null value. This is what this new qemu_fdt_getprop_optional function does. Signed-off-by: Eric Auger --- device_tree.c

[Qemu-devel] [RESEND RFC 6/6] hw/arm/sysbus-fdt: enable amd-xgbe dynamic instantiation

2015-11-19 Thread Eric Auger
This patch allows the instantiation of the vfio-amd-xgbe device from the QEMU command line (-device vfio-amd-xgbe,host=""). The guest is exposed with a device tree node that combines the description of both XGBE and PHY (representation supported from 4.2 onwards kernel): Documentation/devicetree/b

[Qemu-devel] [RESEND RFC 2/6] device_tree: introduce load_device_tree_from_sysfs

2015-11-19 Thread Eric Auger
This function returns the host device tree blob from sysfs (/sys/firmware/devicetree/base). This has a runtime dependency on the dtc binary. This functionality is useful for platform device passthrough where the host device tree needs to be parsed to feed information into the guest device tree. S

Re: [Qemu-devel] [PATCH 1/5] qapi-schema: dump-guest-memory: Improve text

2015-11-19 Thread Eric Blake
On 11/19/2015 07:53 AM, Andrew Jones wrote: > dump-guest-memory is supported by more than just x86, however > the paging option is not. > > (No functional change.) > > Signed-off-by: Andrew Jones > --- > qapi-schema.json | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by:

[Qemu-devel] [RESEND RFC 3/6] device_tree: introduce qemu_fdt_node_path

2015-11-19 Thread Eric Auger
This new helper routine returns the node path of a device referred to by its name and compat string. Signed-off-by: Eric Auger --- device_tree.c| 40 include/sysemu/device_tree.h | 3 +++ 2 files changed, 43 insertions(+) diff --git a/de

[Qemu-devel] [PATCH v2 0/9] s390: Allow hotplug of s390 CPUs

2015-11-19 Thread Matthew Rosato
Changes from v1->v2: * Remove cpu-add support. Instead use 'device_add s390-cpu' * Add unplug support via 'device_del'. * Pull in 2 patches from pseries set. Patch 1 just required some rebasing. Patch 2 required minor changes due to previous upstream review comments. ** The follo

Re: [Qemu-devel] [PATCH] fixup! qapi: Forbid case-insensitive clashes

2015-11-19 Thread Eric Blake
On 11/19/2015 06:32 AM, Markus Armbruster wrote: > Eric Blake writes: > >> [Replace the old commit message with this:] >> >> qapi: Forbid case-insensitive clashes >> >> However, we DO have to care about the fact that we have a >> command 'stop' and an event 'STOP' (currently the only case >> col

[Qemu-devel] [PATCH v2 7/9] s390x/cpu: Extra cleanup during CPU finalize

2015-11-19 Thread Matthew Rosato
In preparation for unplug, do some additional cleanup work to undo work originally done in cpu_exec_init. This patch is based on work done by Bharata B Rao. Signed-off-by: Matthew Rosato --- target-s390x/cpu.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target-s390x/cpu.

[Qemu-devel] [PATCH v2 2/9] cpus: Add a sync version of cpu_remove()

2015-11-19 Thread Matthew Rosato
From: Bharata B Rao This sync API will be used by the CPU hotplug code to wait for the CPU to completely get removed before flagging the failure to the device_add command. Sync version of this call is needed to correctly recover from CPU realization failures when ->plug() handler fails. Signed-

Re: [Qemu-devel] [PULL 00/14] Migration pull request

2015-11-19 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 19 November 2015 at 14:44, Peter Maydell wrote: > > On 19 November 2015 at 13:21, Peter Maydell > > wrote: > >> On 19 November 2015 at 13:12, Peter Maydell > >> wrote: > >>> Hi. Unfortunately this failed in 'make check' (x86-64 Linux, debu

[Qemu-devel] [PATCH v2 6/9] s390x/cpu: Add functions to (un)register CPU state

2015-11-19 Thread Matthew Rosato
Introduce s390_(un)register_cpustate, which will set the machine/cpu[n] link with the current CPU state. Additionally, maintain an array of state pointers indexed by CPU id for fast lookup during interrupt handling. Signed-off-by: Matthew Rosato --- hw/s390x/s390-virtio.c | 54 +

Re: [Qemu-devel] [Bug 1494350] Re: QEMU: causes vCPU steal time overflow on live migration

2015-11-19 Thread lickdragon
To clarify, the 4.4 kernel needs to be running on the VM host, not the guests? Thanks again! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1494350 Title: QEMU: causes vCPU steal time overflow on l

  1   2   3   >