Re: [Qemu-devel] [PULL v4 00/52] Ivshmem patches

2015-10-17 Thread Peter Maydell
On 16 October 2015 at 15:47, Peter Maydell wrote: > On 16 October 2015 at 12:26, Peter Maydell wrote: >> On 14 October 2015 at 15:49, Marc-André Lureau >> wrote: >>> The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10: >>> >>> Merge remote-tracking branch >>> 'remotes/a

Re: [Qemu-devel] [PATCH 2/3] block: Add 'blockdev-del' QMP command

2015-10-17 Thread Alberto Garcia
On Sat 17 Oct 2015 08:23:26 PM CEST, Max Reitz wrote: >> +void qmp_blockdev_del(const char *device, Error **errp) >> +{ >> +AioContext *aio_context; >> +BlockBackend *blk; >> +BlockDriverState *bs; >> + >> +blk = blk_by_name(device); >> +if (blk) { >> +bs = blk_bs(blk);

Re: [Qemu-devel] [PATCH 2/3] block: Add 'blockdev-del' QMP command

2015-10-17 Thread Max Reitz
On 13.10.2015 15:48, Alberto Garcia wrote: > This is the companion to 'blockdev-add'. It allows deleting a > BlockBackend with its associated BlockDriverState tree, or a > BlockDriverState that is not attached to any backend. > > In either case, the command fails if the reference count is greater

Re: [Qemu-devel] [PATCH 2/3] block: Add 'blockdev-del' QMP command

2015-10-17 Thread Max Reitz
On 13.10.2015 15:48, Alberto Garcia wrote: > This is the companion to 'blockdev-add'. It allows deleting a > BlockBackend with its associated BlockDriverState tree, or a > BlockDriverState that is not attached to any backend. > > In either case, the command fails if the reference count is greater

Re: [Qemu-devel] [PATCH 1/3] block: Add blk_get_refcnt()

2015-10-17 Thread Max Reitz
On 13.10.2015 15:48, Alberto Garcia wrote: > This function returns the reference count of a given BlockBackend. > For convenience, it returns 0 if the BlockBackend pointer is NULL. > > Signed-off-by: Alberto Garcia > --- > block/block-backend.c | 5 + > include/sysemu/block-backend.

[Qemu-devel] [PULL v3 03/13] qga: add QGA_CONF environment variable

2015-10-17 Thread Michael Roth
From: Marc-André Lureau Having a environment variable allows to override default configuration path, useful for testing. Note that this can't easily be an argument, since loading config is done before parsing the arguments. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth Signed-off-

[Qemu-devel] [PULL v3 08/13] qga: drop guest_file_init helper and replace it with static initializers

2015-10-17 Thread Michael Roth
From: "Denis V. Lunev" This just makes code shorter and better. Signed-off-by: Denis V. Lunev Signed-off-by: Yuri Pudgorodskiy Reviewed-by: Michael Roth Signed-off-by: Denis V. Lunev Signed-off-by: Michael Roth --- qga/commands-posix.c | 10 +++--- qga/commands-win32.c | 10 +++---

[Qemu-devel] [PULL v3 07/13] tests: add a local test for guest agent

2015-10-17 Thread Michael Roth
From: Marc-André Lureau Add some local guest agent tests, as it is better than nothing, only when CONFIG_POSIX (using unix sockets). With the QGA_TEST_SIDE_EFFECTING environment variable, it will include tests with side effects, such as freezing/thawing the FS or changing the time. (a better te

[Qemu-devel] [PULL v3 04/13] qga: do not override configuration verbosity

2015-10-17 Thread Michael Roth
From: Marc-André Lureau Move the default verbosity settings before loading the configuration file, or it will overwrite it. Found thanks to writing qga tests :) Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/main.c | 4 ++-- 1 file changed, 2 i

[Qemu-devel] [PULL v3 05/13] qtest: add a few fd-level qmp helpers

2015-10-17 Thread Michael Roth
From: Marc-André Lureau Add a few functions to interact with qmp via a simple fd. Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- tests/libqtest.c | 45 + tests/libqtest.h | 7 +++ 2 files changed, 48

[Qemu-devel] [PULL v3 01/13] build: qemu-ga: add 'qemu-ga' build target for w32

2015-10-17 Thread Michael Roth
Currently POSIX builds rely on 'qemu-ga' target to do qga-only distributable build. On w32, as with most standalone binary targets, we rely on 'qemu-ga.exe' target. Unlike with POSIX, qemu-ga for w32 has a number of related targets such as VSS DLL and MSI package. We can do the full distributable

[Qemu-devel] [PULL v3 11/13] qga: handle G_IO_STATUS_AGAIN in ga_channel_write_all()

2015-10-17 Thread Michael Roth
From: Yuri Pudgorodskiy glib may return G_IO_STATUS_AGAIN which is actually not an error. Also fixed a bug when on incomplete write buf pointer was not adjusted. Signed-off-by: Yuri Pudgorodskiy Signed-off-by: Denis V. Lunev Reviewed-by: Michael Roth Signed-off-by: Michael Roth --- qga/chan

[Qemu-devel] [PULL v3 06/13] glib-compat: add 2.38/2.40/2.46 asserts

2015-10-17 Thread Michael Roth
From: Marc-André Lureau Those are mostly useful for writing tests. Signed-off-by: Marc-André Lureau Reviewed-by: Claudio Fontana Signed-off-by: Michael Roth --- include/glib-compat.h | 61 +++ 1 file changed, 61 insertions(+) diff --git a/incl

[Qemu-devel] [PULL v3 12/13] qga: guest-exec simple stdin/stdout/stderr redirection

2015-10-17 Thread Michael Roth
From: Yuri Pudgorodskiy Implemented with base64-encoded strings in qga json protocol. Glib portable GIOChannel is used for data I/O. Optinal stdin parameter of guest-exec command is now used as stdin content for spawned subprocess. If capture-output bool flag is specified, guest-exec redirects

[Qemu-devel] [PULL v3 02/13] qga: Use g_new() & friends where that makes obvious sense

2015-10-17 Thread Michael Roth
From: Markus Armbruster g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type errors. This commit only touches allocations with siz

[Qemu-devel] [PULL v3 09/13] qga: guest exec functionality

2015-10-17 Thread Michael Roth
From: Yuri Pudgorodskiy Guest-exec rewritten in platform-independent style with glib spawn. Child process is spawn asynchronously and exit status can later be picked up by guest-exec-status command. stdin/stdout/stderr of the child now is redirected to /dev/null Later we will add ability to spe

[Qemu-devel] [PULL v3 10/13] qga: handle possible SIGPIPE in guest-file-write

2015-10-17 Thread Michael Roth
From: "Denis V. Lunev" qemu-ga should not exit on guest-file-write to pipe without read end but proper error code should be returned. The behavior of the spawned process should be default thus SIGPIPE processing should be reset to default after fork() but before exec(). Signed-off-by: Denis V. L

[Qemu-devel] [PULL v3 13/13] qga: fix uninitialized value warning for win32

2015-10-17 Thread Michael Roth
Signed-off-by: Michael Roth --- qga/channel-win32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index 215b15a..0452b9f 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -269,7 +269,7 @@ static GIOStatus ga_channel_write

[Qemu-devel] [PULL v3 00/13] qemu-ga patch queue

2015-10-17 Thread Michael Roth
Hi Peter, Please note that 'glib-compat: add 2.38/2.40/2.46 asserts' is also in Marc-André's recent ivshmem PULL. The 2 versions of the patches are identical, but let me know if you'd prefer a re-send/re-base later. The following changes since commit 6d57410a79d51d92673c54f26624b44f27fa6214: M

Re: [Qemu-devel] [PATCH v6 26/39] blockdev: Allow more options for BB-less BDS tree

2015-10-17 Thread Max Reitz
On 15.10.2015 13:29, Kevin Wolf wrote: > Am 12.10.2015 um 22:00 hat Max Reitz geschrieben: >> Most of the options which blockdev_init() parses for both the >> BlockBackend and the root BDS are valid for just the root BDS as well >> (e.g. read-only). This patch allows specifying these options even i

Re: [Qemu-devel] [PULL v2 00/12] qemu-ga patch queue

2015-10-17 Thread Michael Roth
Quoting Peter Maydell (2015-10-16 13:05:28) > On 15 October 2015 at 17:05, Michael Roth wrote: > > Hi Peter, > > > > Please note that 'glib-compat: add 2.38/2.40/2.46 asserts' is also in > > Marc-André's recent ivshmem PULL. The 2 versions of the patches are > > identical, > > but let me know if

Re: [Qemu-devel] [PULL 00/13] target-arm queue

2015-10-17 Thread Peter Maydell
On 16 October 2015 at 14:57, Peter Maydell wrote: > Flushing the target-arm queue for softfreeze. I still have stuff > in my to-review queue but it mostly looked too RFC-ish/otherwise > not really 2.5 material, or just needs a bit more time on list for > review. > > thanks > -- PMM > > > > The fol

[Qemu-devel] [PATCH] temporary-floating-point: Use "0 - val" for the negtive value

2015-10-17 Thread Chen Gang
>From 5bfae9eaa7c6757c83b1b3d958dd24988394fb03 Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Sat, 17 Oct 2015 21:39:25 +0800 Subject: [PATCH] temporary-floating-point: Use "0 - val" for the negtive value It is a bug, original implementation is incorrect. Signed-off-by: Chen Gang ---  target-ti

Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block

2015-10-17 Thread Peter Maydell
On 16 October 2015 at 22:37, Stefan Weil wrote: > Maybe real hardware will run an endless loop? > Or the "endless" loop is terminated because the driver > changes the link while the loop is running? > > The goal of eepro100.c should be emulation of the > real hardware, even of a potential design w

Re: [Qemu-devel] [PULL 0/3] cocoa queue

2015-10-17 Thread Peter Maydell
On 16 October 2015 at 11:10, Peter Maydell wrote: > Nothing major here, just a few patches from John Arbuckle. > > -- PMM > > The following changes since commit c49d3411faae8ffaab8f7e5db47405a008411c10: > > Merge remote-tracking branch 'remotes/armbru/tags/pull-qapi-2015-10-12' > into staging (

Re: [Qemu-devel] [PATCH] eepro100: prevent an infinite loop over same command block

2015-10-17 Thread P J P
Hello, +-- On Fri, 16 Oct 2015, Stefan Weil wrote --+ | is this just a theoretical assumption or did you see problems | with some guest operating system? | | To trigger a potential infinite loop, you'll need buggy device | drivers in the guest. Right; The issue isn't theoretical, it was seen