Re: [Qemu-devel] [PATCH COLO-Frame v9 03/32] COLO: migrate colo related info to slave

2015-10-07 Thread zhanghailiang
On 2015/10/3 2:45, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: We can know if VM in destination should go into COLO mode by refer to the info that been migrated from PVM. We skip this section if colo is not enabled (i.e. migrate_set_capability colo off)

Re: [Qemu-devel] [PATCH COLO-Frame v9 02/32] migration: Introduce capability 'colo' to migration

2015-10-07 Thread zhanghailiang
On 2015/10/3 0:02, Eric Blake wrote: On 09/02/2015 02:22 AM, zhanghailiang wrote: We add helper function colo_supported() to indicate whether colo is supported or not, with which we use to control whether or not showing 'colo' string to users, they can use qmp command 'query-migrate-capabilities

Re: [Qemu-devel] [Qemu-block] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-07 Thread Markus Armbruster
Max Reitz writes: > On 22.09.2015 09:44, Wen Congyang wrote: >> The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del. >> It justs for adding/removing quorum's child now, and don't support all >> kinds of children, > > It does support all kinds of children for quorum, doesn't

Re: [Qemu-devel] [PATCH v3 1/9] target-arm: Add HPFAR_EL2

2015-10-07 Thread Laurent Desnogues
Hello, On Sun, Oct 4, 2015 at 12:38 AM, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h| 1 + > target-arm/helper.c | 12 > 2 files changed, 13 insertions(+) > > diff --git a/target-arm/cpu.h b/target-arm/cpu.

Re: [Qemu-devel] [PULL 12/22] vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE

2015-10-07 Thread Yuanhan Liu
On Sat, Oct 03, 2015 at 07:33:16PM +0300, Michael S. Tsirkin wrote: > On Fri, Oct 02, 2015 at 06:18:51PM +0200, Paolo Bonzini wrote: > > > > > > On 24/09/2015 15:20, Michael S. Tsirkin wrote: > > > From: Yuanhan Liu > > > > > > Quote from Michael: > > > > > > We really should rename VHOST_

Re: [Qemu-devel] [PATCH v5 1/4] Add new block driver interface to add/delete a BDS's child

2015-10-07 Thread Wen Congyang
On 10/08/2015 03:00 AM, Dr. David Alan Gilbert wrote: > * Wen Congyang (we...@cn.fujitsu.com) wrote: >> In some cases, we want to take a quorum child offline, and take >> another child online. > > Hi, > Have you checked the output of 'info block' after adding/deleting a child? > I'm using one of

[Qemu-devel] [PATCH v6 09/15] qapi: Fix alternates that accept 'number' but not 'int'

2015-10-07 Thread Eric Blake
The QMP input visitor allows integral values to be assigned by promotion to a QTYPE_QFLOAT. However, when parsing an alternate, we did not take this into account, such that an alternate that accepts 'number' but not 'int' would reject integral values. With this patch, we now have the following de

[Qemu-devel] [PATCH v6 15/15] qapi: Simplify visits of optional fields

2015-10-07 Thread Eric Blake
None of the visitor callbacks would set an error when testing if an optional field was present; make this part of the interface contract by eliminating the errp argument. Then, for less code, reflect the determined boolean value back to the caller instead of making the caller read the boolean afte

Re: [Qemu-devel] [PATCH v5 1/4] Add new block driver interface to add/delete a BDS's child

2015-10-07 Thread Wen Congyang
On 10/07/2015 09:35 PM, Alberto Garcia wrote: > On Tue 22 Sep 2015 09:44:19 AM CEST, Wen Congyang > wrote: >> In some cases, we want to take a quorum child offline, and take >> another child online. >> >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >>

[Qemu-devel] [PATCH v6 10/15] qapi: Remove dead visitor code

2015-10-07 Thread Eric Blake
Commit cbc95538 removed unused start_handle() and end_handle(), but forgot got remove their declarations. Commit 4e27e819 introduced optional visitor callbacks for all sorts of int types, but except for type_uint64 and type_size, none of them have ever been supplied (the generic implementation bas

Re: [Qemu-devel] [Qemu-block] [PATCH v5 1/4] Add new block driver interface to add/delete a BDS's child

2015-10-07 Thread Wen Congyang
On 10/08/2015 02:33 AM, Max Reitz wrote: > On 22.09.2015 09:44, Wen Congyang wrote: >> In some cases, we want to take a quorum child offline, and take >> another child online. >> >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> Reviewed-by: Eric Blake

[Qemu-devel] [PATCH v6 12/15] qapi: Simplify error testing in test-qmp-*

2015-10-07 Thread Eric Blake
By using &error_abort, we can avoid a local err variable in situations where we expect success. By moving err into data, we can let test teardown take care of cleaning up any collected error (and allowing for fewer lines of code between repeated tests where init runs teardown on our behalf). Sign

Re: [Qemu-devel] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-10-07 Thread Wen Congyang
On 10/07/2015 10:12 PM, Alberto Garcia wrote: > On Tue 22 Sep 2015 09:44:20 AM CEST, Wen Congyang wrote: > >> +++ b/block/quorum.c >> @@ -66,6 +66,9 @@ typedef struct QuorumVotes { >> typedef struct BDRVQuorumState { >> BlockDriverState **bs; /* children BlockDriverStates */ >> int num_

[Qemu-devel] [PATCH v6 14/15] qapi: More tests of input arrays

2015-10-07 Thread Eric Blake
Our testsuite had no coverage of empty arrays, nor of what happens when the input does not match the expected type. Useful to have, especially if we start changing the visitor contracts. Signed-off-by: Eric Blake --- v6: new patch --- tests/test-qmp-input-visitor.c | 51

[Qemu-devel] [PATCH v6 05/15] qapi: Provide nicer array names in introspection

2015-10-07 Thread Eric Blake
For the sake of humans reading introspection output, it is nice to have the name of implicit array types be recognizable as arrays of the underlying type. However, while this patch allows humans to skip from a command with return type "[123]" straight to the definition of type "123" without having

[Qemu-devel] [PATCH v6 01/15] qapi: Move empty-enum to compile-time test

2015-10-07 Thread Eric Blake
Rather than just asserting that we can parse an empty enum, let's also make sure we can compile it, by including it in qapi-schema-test. Signed-off-by: Eric Blake --- v6: new patch; could be hoisted earlier alongside subset B v7 3/14 --- tests/Makefile | 1 - tests/qapi

[Qemu-devel] [PATCH v6 03/15] qapi: Drop redundant flat-union-reverse-define test

2015-10-07 Thread Eric Blake
As of commit 8c3f8e77, we test compilation of forward references for a struct base type (UserDefOne), flat union base type (UserDefUnionBase), and flat union branch type (UserDefFlatUnion2). The only remaining forward reference being tested for parsing in flat-union-reverse-define was a forward enu

[Qemu-devel] [PATCH v6 06/15] qapi-introspect: Guarantee particular sorting

2015-10-07 Thread Eric Blake
Sorting the values of an enum makes it easier to look up whether a particular value is present by binary rather than linear search (probably most visible with QKeyCode, which has grown over several releases). Additionally, QMP clients need not know which C value is associated with an enum name, so

[Qemu-devel] [PATCH v6 08/15] qapi: Simplify visiting of alternate types

2015-10-07 Thread Eric Blake
Previously, working with alternates required two enums, and some indirection: for type Foo, we created Foo_qtypes[] which maps each qtype to a member of FooKind_lookup[], then use FooKind_lookup[] like we do for other union types. This has a subtle bug: since the values of FooKind_lookup start at

[Qemu-devel] [PATCH v6 11/15] qapi: Plug leaks in test-qmp-*

2015-10-07 Thread Eric Blake
Make valgrind happy with the current state of the tests, so that it is easier to see if future patches introduce new memory problems without being drowned in noise. Many of the leaks were due to calling a second init without tearing down the data from an earlier visit. But since teardown is alrea

[Qemu-devel] [PATCH v6 13/15] qapi: Test failure in middle of array parse

2015-10-07 Thread Eric Blake
Our generated list visitors have the same problem as has been mentioned elsewhere (see commit 2f52e20): they allocate data even on failure. An upcoming patch will correct things to provide saner guarantees, but first we need to expose the behavior in the testsuite to ensure we aren't introducing an

[Qemu-devel] [PATCH v6 07/15] qapi: Change alternate layout to use 'type'

2015-10-07 Thread Eric Blake
Prepare to simplify alternate layout by creating a dedicated subclass for the generated tag type. QMP does not transmit the tag name, so we can name it whatever we want in C. But since the tag is closely tied to a qtype_code, this commit renames the tag from 'kind' to 'type', so the next commit c

[Qemu-devel] [PATCH v6 02/15] qapi: Drop redundant returns-int test

2015-10-07 Thread Eric Blake
qapi-schema-test was already testing that we could have a command returning int, but burned a command name in the whitelist. Merge the redundant positive test returns-int, and pick a name that reduces the whitelist size. Signed-off-by: Eric Blake --- v6: new patch; could be hoisted earlier along

[Qemu-devel] [PATCH v6 00/15] post-introspection cleanups, subset C

2015-10-07 Thread Eric Blake
Pending prerequisite: Markus' qapi-next branch (which has my subset A patches): git://repo.or.cz/qemu/armbru.git qapi-next http://thread.gmane.org/gmane.comp.emulators.qemu/365827/focus=366351 as well as my subset B patches (currently at v7): http://article.gmane.org/gmane.comp.emulators.qemu/36681

[Qemu-devel] [PATCH v6 04/15] qapi: Use generated TestStruct machinery in tests

2015-10-07 Thread Eric Blake
Commit d88f5fd and friends first introduced the various test-qmp-* tests in 2011, with duplicated hand-rolled TestStruct machinery, to make sure the qapi visitor interface was tested. Later, commit 4f193e3 in 2013 added a .json file for further testing use by the files, but without consolidating a

Re: [Qemu-devel] [PATCH v2 3/3] exec.c: Collect AddressSpace related fields into a CPUAddressSpace struct

2015-10-07 Thread Richard Henderson
On 10/08/2015 08:13 AM, Peter Maydell wrote: On 7 October 2015 at 10:57, Richard Henderson wrote: On 10/02/2015 12:29 AM, Peter Maydell wrote: +cpu->cpu_ases = g_new0(CPUAddressSpace, 1); +cpu->cpu_ases[0].cpu = cpu; +cpu->cpu_ases[0].as = as; +cpu->cpu_ases[0].tcg_as_listener

Re: [Qemu-devel] [PATCH v2 5/5] xlnx-ep108: Connect the SPI Flash

2015-10-07 Thread Peter Crosthwaite
On Wed, Oct 7, 2015 at 2:34 PM, Alistair Francis wrote: > Connect the sst25wf080 SPI flash to the EP108 board. > > Signed-off-by: Alistair Francis > --- > V2: > - Use sst25wf080 instead of m25p80 > > hw/arm/xlnx-ep108.c | 20 > 1 file changed, 20 insertions(+) > > diff --gi

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 17:32, Nutan Shinde wrote: > Signed-off-by: Nutan Shinde > --- > hw/audio/adlib.c | 9 ++--- > hw/audio/es1370.c | 17 ++--- > hw/audio/gus.c| 9 ++--- > hw/audio/sb16.c | 15 +-- > 4 files changed, 15 insertions(+), 35 deletions(-) >

Re: [Qemu-devel] [PATCH v3 3/9] target-arm: Add support for S2 page-table protection bits

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 17:19, Alex Bennée wrote: > > Edgar E. Iglesias writes: > >> From: "Edgar E. Iglesias" >> >> Signed-off-by: Edgar E. Iglesias >> --- >> target-arm/helper.c | 41 + >> 1 file changed, 37 insertions(+), 4 deletions(-) >> >> diff --git

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 14:31, Andreas Färber wrote: > It is non-technical and called plagiarism. I don't think the text g_strdup_printf("-device ivshmem,shm=%s,size=1M", (yes, even the final argument differs between your version and Marc-André) counts as plagiarism. > The common denominator is that

Re: [Qemu-devel] [PATCH v1 3/3] xlnx-zynqmp: Connect the SPI devices

2015-10-07 Thread Alistair Francis
On Wed, Sep 30, 2015 at 2:15 PM, Peter Crosthwaite wrote: > On Tue, Sep 29, 2015 at 4:03 PM, Alistair Francis > wrote: >> Connect the Xilinx SPI device to the ZynqMP model. >> >> Signed-off-by: Alistair Francis >> --- >> >> hw/arm/xlnx-zynqmp.c | 46 >> +

Re: [Qemu-devel] [PULL 00/48] ivshmem series

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 14:05, Andreas Färber wrote: > my "make test" patch (which Peter keeps refusing to apply for two > releases now) For what it's worth, I am not currently aware of a patch from you that I am refusing to apply. There's a lot of traffic on the list, and it's very easy for things

[Qemu-devel] [PATCH v2 1/5] m25p80.c: Add sst25wf080 SPI flash device

2015-10-07 Thread Alistair Francis
Add the sst25wf080 SPI flash device. Signed-off-by: Alistair Francis --- hw/block/m25p80.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index efc43dd..7b9f97c 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -163,6 +163,7 @@ static const Fla

[Qemu-devel] [PATCH v2 2/5] ssi: Move ssi.h into a separate directory

2015-10-07 Thread Alistair Francis
Move the ssi.h include file into the ssi directory. Signed-off-by: Alistair Francis --- V2: - Change git patch to indicate rename hw/arm/pxa2xx.c | 2 +- hw/arm/spitz.c | 2 +- hw/arm/stellaris.c | 2 +- hw/arm/strongarm.c

[Qemu-devel] [PATCH v2 3/5] xilinx_spips: Seperate the state struct into a header

2015-10-07 Thread Alistair Francis
Seperate out the XilinxSPIPS struct into a seperate header file. Signed-off-by: Alistair Francis --- V2: - Only split out required #defines - Prefix XLNX_SPIPS_ hw/ssi/xilinx_spips.c | 54 --- include/hw/ssi/xilinx_spips.h | 74 +

[Qemu-devel] [PATCH v2 0/5] Connect the SPI devices to ZynqMP

2015-10-07 Thread Alistair Francis
Connect the SPI devices to Xilinx's ZynqMP. I also need to make some changes to the actual SPI device to imporove the fuctionality, but for the time being this works. V2: - Connect the SPI flash in the board code - Update git patches to properly indicate rename - Add sst25wf080 as a SPI flash

[Qemu-devel] [PATCH v2 5/5] xlnx-ep108: Connect the SPI Flash

2015-10-07 Thread Alistair Francis
Connect the sst25wf080 SPI flash to the EP108 board. Signed-off-by: Alistair Francis --- V2: - Use sst25wf080 instead of m25p80 hw/arm/xlnx-ep108.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/arm/xlnx-ep108.c b/hw/arm/xlnx-ep108.c index 2899698..9755c30 100644

Re: [Qemu-devel] [PULL 0/5] s390x: Fixes and features

2015-10-07 Thread Christian Borntraeger
Am 07.10.2015 um 22:55 schrieb Peter Maydell: > On 6 October 2015 at 11:41, Christian Borntraeger > wrote: >> Peter, >> >> here are some fixes (and a small feature) for s390x. >> >> The following changes since commit b2312c680084ea18cd55fa7093397cad2224ec14: >> >> Merge remote-tracking branch 'r

Re: [Qemu-devel] [PATCH v3 1/9] target-arm: Add HPFAR_EL2

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 12:51, Alex Bennée wrote: > > Edgar E. Iglesias writes: > >> From: "Edgar E. Iglesias" >> >> Signed-off-by: Edgar E. Iglesias >> --- >> target-arm/cpu.h| 1 + >> target-arm/helper.c | 12 >> 2 files changed, 13 insertions(+) >> >> diff --git a/target-arm/

Re: [Qemu-devel] [PATCH v8] hw/arm/virt: Add high MMIO PCI region, 512G in size

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 11:50, Pavel Fedin wrote: > Hello! > >> Nudge -- have you reported this as a kernel bug against the >> PCI generic driver yet? > > Sorry, stopped tracking this topic after option upstreaming. Just > sent out patches, cc'ed to you. Yes, just saw those, thanks. (I'm slightly

Re: [Qemu-devel] [PATCH v2 3/3] exec.c: Collect AddressSpace related fields into a CPUAddressSpace struct

2015-10-07 Thread Peter Maydell
On 7 October 2015 at 10:57, Richard Henderson wrote: > On 10/02/2015 12:29 AM, Peter Maydell wrote: >> >> +cpu->cpu_ases = g_new0(CPUAddressSpace, 1); >> +cpu->cpu_ases[0].cpu = cpu; >> +cpu->cpu_ases[0].as = as; >> +cpu->cpu_ases[0].tcg_as_listener.commit = tcg_commit; >> +mem

Re: [Qemu-devel] [PULL 0/5] s390x: Fixes and features

2015-10-07 Thread Peter Maydell
On 6 October 2015 at 11:41, Christian Borntraeger wrote: > Peter, > > here are some fixes (and a small feature) for s390x. > > The following changes since commit b2312c680084ea18cd55fa7093397cad2224ec14: > > Merge remote-tracking branch 'remotes/amit-migration/tags/for-juan-201509' > into stagi

Re: [Qemu-devel] [PATCH v3 6/6] tcg/mips: Support r6 SEL{NE, EQ}Z instead of MOVN/MOVZ

2015-10-07 Thread Richard Henderson
On 10/07/2015 09:34 PM, James Hogan wrote: { INDEX_op_brcond_i32, { "rZ", "rZ" } }, +#if !use_mips32r6_instructions { INDEX_op_movcond_i32, { "r", "rZ", "rZ", "rZ", "0" } }, +#else +{ INDEX_op_movcond_i32, { "r", "rZ", "rZ", "rZ", "rZ" } }, +#endif The only thing I'd change is

Re: [Qemu-devel] [Qemu-block] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-07 Thread Max Reitz
On 22.09.2015 09:44, Wen Congyang wrote: > The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del. > It justs for adding/removing quorum's child now, and don't support all > kinds of children, It does support all kinds of children for quorum, doesn't it? >n

Re: [Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Markus Armbruster
Copying maintainer. Please use scripts/get_maintainer.pl to find them yourself. Nutan Shinde writes: > Signed-off-by: Nutan Shinde > --- > hw/audio/adlib.c | 9 ++--- > hw/audio/es1370.c | 17 ++--- > hw/audio/gus.c| 9 ++--- > hw/audio/sb16.c | 15 +--

Re: [Qemu-devel] [PATCH 03/17] spec: add qcow2-dirty-bitmaps specification

2015-10-07 Thread Denis V. Lunev
On 10/07/2015 07:47 PM, Max Reitz wrote: On 05.09.2015 18:43, Vladimir Sementsov-Ogievskiy wrote: Persistent dirty bitmaps will be saved into qcow2 files. It may be used as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for other drives (there may be qcow2 file with zero disk siz

Re: [Qemu-devel] [PATCH v5 1/4] Add new block driver interface to add/delete a BDS's child

2015-10-07 Thread Dr. David Alan Gilbert
* Wen Congyang (we...@cn.fujitsu.com) wrote: > In some cases, we want to take a quorum child offline, and take > another child online. Hi, Have you checked the output of 'info block' after adding/deleting a child? I'm using one of your older worlds (from a few months ago) and I found I had to ad

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-07 Thread Peter Lieven
Am 07.10.2015 um 18:42 schrieb John Snow: > > On 10/06/2015 04:46 AM, Peter Lieven wrote: >> Am 05.10.2015 um 23:15 schrieb John Snow: >>> On 09/21/2015 08:25 AM, Peter Lieven wrote: PIO read requests on the ATAPI interface used to be sync blk requests. This has to siginificant drawbacks.

Re: [Qemu-devel] [Qemu-block] [PATCH v5 2/4] quorum: implement bdrv_add_child() and bdrv_del_child()

2015-10-07 Thread Max Reitz
On 22.09.2015 09:44, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > block.c | 6 ++--- > block/quorum.c| 72 > +-- > include/block/block.h | 3 +++ > 3 fil

Re: [Qemu-devel] [Qemu-block] [PATCH v5 1/4] Add new block driver interface to add/delete a BDS's child

2015-10-07 Thread Max Reitz
On 22.09.2015 09:44, Wen Congyang wrote: > In some cases, we want to take a quorum child offline, and take > another child online. > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Reviewed-by: Eric Blake > --- > block.c | 50 > ++

[Qemu-devel] Debugging u-boot after relocation on arm machie

2015-10-07 Thread mar.krzeminski
Hello, I am working on u-boot under qemu. Debugging before u-boots relocate itself works just fine. After relocation and reloading elf in gdb, qemu does no stop on breakpoint. Generally I follow this instruction: http://www.denx.de/wiki/view/DULG/DebuggingUBoot I am debuging under eclipse -

Re: [Qemu-devel] [PATCH v2 04/16] quorum: Convert to BdrvChild

2015-10-07 Thread Max Reitz
On 01.10.2015 15:13, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > Reviewed-by: Max Reitz > Reviewed-by: Alberto Garcia > --- > block/quorum.c | 63 > ++ > 1 file changed, 33 insertions(+), 30 deletions(-) > > diff --git a/block/quorum

Re: [Qemu-devel] [PATCH 06/17] qcow2-dirty-bitmap: add qcow2_dirty_bitmap_load()

2015-10-07 Thread Eric Blake
On 10/06/2015 05:01 PM, John Snow wrote: >> +ret = load_bitmap(bs_file, dirty_bitmap_table, >> bmh->dirty_bitmap_table_size, bitmap); >> +if (ret < 0) { >> +error_setg_errno(errp, -ret, "Could not read bitmap from image"); >> +goto finish; >> +} >> + >> +finish: >> +

Re: [Qemu-devel] [PATCH 03/17] spec: add qcow2-dirty-bitmaps specification

2015-10-07 Thread Max Reitz
On 05.09.2015 18:43, Vladimir Sementsov-Ogievskiy wrote: > Persistent dirty bitmaps will be saved into qcow2 files. It may be used > as 'internal' bitmaps (for qcow2 drives) or as 'external' bitmaps for > other drives (there may be qcow2 file with zero disk size but with > several dirty bitmaps for

Re: [Qemu-devel] [PATCH v7 06/14] qapi: Create simple union type member earlier

2015-10-07 Thread Markus Armbruster
Eric Blake writes: > For simple unions, we were creating the implicit 'type' tag > member during the QAPISchemaObjectTypeVariants constructor. > This is different from every other implicit QAPISchemaEntity > object, which get created by QAPISchema methods. Hoist the > creation to the caller (ren

Re: [Qemu-devel] [PATCH 1/5] ide/atapi: make PIO read requests async

2015-10-07 Thread John Snow
On 10/06/2015 04:46 AM, Peter Lieven wrote: > Am 05.10.2015 um 23:15 schrieb John Snow: >> >> On 09/21/2015 08:25 AM, Peter Lieven wrote: >>> PIO read requests on the ATAPI interface used to be sync blk requests. >>> This has to siginificant drawbacks. First the main loop hangs util an >>> I/O re

Re: [Qemu-devel] [PATCH v7 05/14] qapi: Lazy creation of array types

2015-10-07 Thread Markus Armbruster
Eric Blake writes: > Commit ac88219a had several TODO markers about whether we needed > to automatically create the corresponding array type alongside > any other type. It turns out that most of the time, we don't! > > As part of lazy creation of array types, this patch now assigns > an 'info' t

Re: [Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test

2015-10-07 Thread Eric Blake
On 10/07/2015 10:15 AM, Markus Armbruster wrote: > Eric Blake writes: > >> The alternate-good.json test was already covered by >> qapi-schema-test.json. As future commits will be tweaking >> how alternates are laid out, removing the duplicate test now >> reduces churn. > > Do we have more posit

[Qemu-devel] [PATCH v2] Remove macros IO_READ_PROTO and IO_WRITE_PROTO

2015-10-07 Thread Nutan Shinde
Signed-off-by: Nutan Shinde --- hw/audio/adlib.c | 9 ++--- hw/audio/es1370.c | 17 ++--- hw/audio/gus.c| 9 ++--- hw/audio/sb16.c | 15 +-- 4 files changed, 15 insertions(+), 35 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adlib.c index 656eb37.

Re: [Qemu-devel] [PATCH v7 04/14] qapi: Don't use info as witness of implicit object type

2015-10-07 Thread Markus Armbruster
Eric Blake writes: > A future patch will enable error reporting from the various > QAPISchema*.check() methods. But to report an error related > to an implicit type, we'll need to associate a location with > the type (the same location as the top-level entity that is > causing the creation of th

Re: [Qemu-devel] [PATCH v3 5/9] target-arm: Add ARMMMUFaultInfo

2015-10-07 Thread Alex Bennée
Edgar E. Iglesias writes: > From: "Edgar E. Iglesias" > > Introduce ARMMMUFaultInfo to propagate MMU Fault information > across the MMU translation code path. This is in preparation for > adding State-2 translation. s/State/stage/? > > No functional changes. > > Signed-off-by: Edgar E. Iglesi

Re: [Qemu-devel] [PATCH v3 3/9] target-arm: Add support for S2 page-table protection bits

2015-10-07 Thread Alex Bennée
Edgar E. Iglesias writes: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/helper.c | 41 + > 1 file changed, 37 insertions(+), 4 deletions(-) > > diff --git a/target-arm/helper.c b/target-arm/helper.c > index 507324f.

Re: [Qemu-devel] [PATCH v7 03/14] qapi: Drop redundant alternate-good test

2015-10-07 Thread Markus Armbruster
Eric Blake writes: > The alternate-good.json test was already covered by > qapi-schema-test.json. As future commits will be tweaking > how alternates are laid out, removing the duplicate test now > reduces churn. Do we have more positive tests? They should probably all live in qapi-schema-test

[Qemu-devel] [PATCH] fixup to qapi: Move union tag quirks into subclass

2015-10-07 Thread Eric Blake
Signed-off-by: Eric Blake --- I noticed a couple more places that could use the c_name() function; I'll be squashing this into 7/14 if I need to do a v8 spin. scripts/qapi-commands.py | 4 ++-- scripts/qapi.py | 10 +- 2 files changed, 7 insertions(+), 7 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH v7 12/24] vhost: use a function for each call

2015-10-07 Thread Marc-André Lureau
Hi - Original Message - > > > > Hmm, there are no tests for multi-queue? I thought we had some, how did you > > test it then? > > For other reason I have launched a VM with multiqueue with your latest > patch series and I have encountered the bug. (easy to see as QEMU is > blocked for eve

Re: [Qemu-devel] [PATCH v7 12/24] vhost: use a function for each call

2015-10-07 Thread Thibaut Collet
On Wed, Oct 7, 2015 at 5:58 PM, Marc-André Lureau wrote: > Hi Thibaut > > - Original Message - >> On Thu, Oct 1, 2015 at 7:23 PM, wrote: >> > From: Marc-André Lureau >> > >> > Replace the generic vhost_call() by specific functions for each >> > function call to help with type safety and

Re: [Qemu-devel] [PATCH v7 12/24] vhost: use a function for each call

2015-10-07 Thread Marc-André Lureau
Hi Thibaut - Original Message - > On Thu, Oct 1, 2015 at 7:23 PM, wrote: > > From: Marc-André Lureau > > > > Replace the generic vhost_call() by specific functions for each > > function call to help with type safety and changing arguments. > > > > While doing this, I found that "unsigne

[Qemu-devel] [PULL 6/9] vfio: Check guest IOVA ranges against host IOMMU capabilities

2015-10-07 Thread Alex Williamson
From: David Gibson The current vfio core code assumes that the host IOMMU is capable of mapping any IOVA the guest wants to use to where we need. However, real IOMMUs generally only support translating a certain range of IOVAs (the "DMA window") not a full 64-bit address space. The common x86 I

Re: [Qemu-devel] [RFC PATCH 0/8] Towards an Heterogeneous QEMU

2015-10-07 Thread Peter Crosthwaite
On Mon, Oct 5, 2015 at 8:50 AM, Christian Pinto wrote: > Hello Peter, > > thanks for your comments > > On 01/10/2015 18:26, Peter Crosthwaite wrote: >> >> On Tue, Sep 29, 2015 at 6:57 AM, Christian Pinto >> wrote: >>> >>> Hi all, >>> >>> This RFC patch-series introduces the set of changes enabli

[Qemu-devel] [PULL 4/9] vfio: Remove unneeded union from VFIOContainer

2015-10-07 Thread Alex Williamson
From: David Gibson Currently the VFIOContainer iommu_data field contains a union with different information for different host iommu types. However: * It only actually contains information for the x86-like "Type1" iommu * Because we have a common listener the Type1 fields are actually used

Re: [Qemu-devel] [PATCH v7 12/24] vhost: use a function for each call

2015-10-07 Thread Thibaut Collet
On Thu, Oct 1, 2015 at 7:23 PM, wrote: > From: Marc-André Lureau > > Replace the generic vhost_call() by specific functions for each > function call to help with type safety and changing arguments. > > While doing this, I found that "unsigned long long" and "uint64_t" were > used interchangeably

[Qemu-devel] [PULL 3/9] hw/vfio/platform: do not set resamplefd for edge-sensitive IRQS

2015-10-07 Thread Alex Williamson
From: Eric Auger In irqfd mode, current code attempts to set a resamplefd whatever the type of the IRQ. For an edge-sensitive IRQ this attempt fails and as a consequence, the whole irqfd setup fails and we fall back to the slow mode. This patch bypasses the resamplefd setting for non level-sentiv

[Qemu-devel] [PULL 9/9] vfio: Allow hotplug of containers onto existing guest IOMMU mappings

2015-10-07 Thread Alex Williamson
From: David Gibson At present the memory listener used by vfio to keep host IOMMU mappings in sync with the guest memory image assumes that if a guest IOMMU appears, then it has no existing mappings. This may not be true if a VFIO device is hotplugged onto a guest bus which didn't previously inc

[Qemu-devel] [PULL 0/9] VFIO updates for 2015-10-07

2015-10-07 Thread Alex Williamson
Hi Peter, Per David's suggestion I simply dropped the clang problem patch, it's apparently unnecessary at this time. Thanks, Alex The following changes since commit c0b520dfb8890294a9f8879f4759172900585995: Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging (2015-10-0

[Qemu-devel] [PULL 5/9] vfio: Generalize vfio_listener_region_add failure path

2015-10-07 Thread Alex Williamson
From: David Gibson If a DMA mapping operation fails in vfio_listener_region_add() it checks to see if we've already completed initial setup of the container. If so it reports an error so the setup code can fail gracefully, otherwise throws a hw_error(). There are other potential failure cases i

[Qemu-devel] [PULL 7/9] vfio: Record host IOMMU's available IO page sizes

2015-10-07 Thread Alex Williamson
From: David Gibson Depending on the host IOMMU type we determine and record the available page sizes for IOMMU translation. We'll need this for other validation in future patches. Signed-off-by: David Gibson Reviewed-by: Thomas Huth Reviewed-by: Laurent Vivier Signed-off-by: Alex Williamson

[Qemu-devel] [PULL 8/9] memory: Allow replay of IOMMU mapping notifications

2015-10-07 Thread Alex Williamson
From: David Gibson When we have guest visible IOMMUs, we allow notifiers to be registered which will be informed of all changes to IOMMU mappings. This is used by vfio to keep the host IOMMU mappings in sync with guest IOMMU mappings. However, unlike with a memory region listener, an iommu noti

[Qemu-devel] [PULL 1/9] hw/vfio/platform: irqfd setup sequence update

2015-10-07 Thread Alex Williamson
From: Eric Auger With current implementation, eventfd VFIO signaling is first set up and then irqfd is setup, if supported and allowed. This start sequence causes several issues with IRQ forwarding setup which, if supported, is transparently attempted on irqfd setup: IRQ forwarding setup is like

[Qemu-devel] [PULL 2/9] hw/vfio/platform: change interrupt/unmask fields into pointer

2015-10-07 Thread Alex Williamson
From: Eric Auger unmask EventNotifier might not be initialized in case of edge sensitive irq. Using EventNotifier pointers make life simpler to handle the edge-sensitive irqfd setup. Signed-off-by: Eric Auger Signed-off-by: Alex Williamson --- hw/vfio/platform.c | 35 ++

[Qemu-devel] creating vm fails if maxMemory equals to memory, but hotplug same will success

2015-10-07 Thread Yi Wang
Hi, all When I create a vm using virsh, it will fail if maxMemory(2G) equals to memory(2G) in XML: error: Failed to create domain from vm1.xml error: internal error: process exited while connecting to monitor: qemu-kvm: -msg timestamp=on: invalid value of -m option maxmem: memory slots were specifi

Re: [Qemu-devel] [RFC PATCH] qapi: split visit_end_struct() into pieces

2015-10-07 Thread Markus Armbruster
Eric Blake writes: > On 10/07/2015 06:00 AM, Markus Armbruster wrote: > Looks like we're getting drawn into visitor contract territory again. > >>> +++ b/hmp.c >>> @@ -1658,8 +1658,9 @@ void hmp_object_add(Monitor *mon, const QDict *qdict) >>> >>> object_add(type, id, pdict, opts_g

Re: [Qemu-devel] [PATCH] trace: remove malloc tracing

2015-10-07 Thread Alberto Garcia
On Wed, Sep 16, 2015 at 05:38:44PM +0200, Paolo Bonzini wrote: > The malloc vtable is not supported anymore in glib, because it broke > when constructors called g_malloc. Remove tracing of g_malloc, > g_realloc and g_free calls. > > Note that, for systemtap users, glib also provides tracepoints >

Re: [Qemu-devel] [PATCH] doc: document ivshmem & hugepages

2015-10-07 Thread Eric Blake
On 10/07/2015 08:32 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Document and give some examples of hugepages support with ivshmem device > and server. > > Signed-off-by: Marc-André Lureau > --- > qemu-doc.texi | 13 + > 1 file changed, 13 insertions(+) > >

Re: [Qemu-devel] [PATCH 7/8] migration: new migration test mode

2015-10-07 Thread Eric Blake
On 10/07/2015 07:56 AM, Dr. David Alan Gilbert wrote: > * Denis V. Lunev (d...@openvz.org) wrote: >> From: Igor Redko >> >> In this patch the ability to start a migration with test-only >> capability was added. It allows to gather the guest VM’s memory >> usage statistics avoiding time and memory

Re: [Qemu-devel] [PATCH v5 22/38] block: Prepare for NULL BDS

2015-10-07 Thread Max Reitz
On 07.10.2015 12:43, Kevin Wolf wrote: > Am 18.09.2015 um 17:22 hat Max Reitz geschrieben: >> blk_bs() will not necessarily return a non-NULL value any more (unless >> blk_is_available() is true or it can be assumed to otherwise, e.g. >> because it is called immediately after a successful blk_new_w

Re: [Qemu-devel] [PATCH v4 3/3] pcie: Add support for Single Root I/O Virtualization (SR/IOV)

2015-10-07 Thread Marcel Apfelbaum
On 09/12/2015 03:36 PM, Knut Omang wrote: This patch provides the building blocks for creating an SR/IOV PCIe Extended Capability header and register/unregister SR/IOV Virtual Functions. Signed-off-by: Knut Omang --- hw/pci/Makefile.objs| 2 +- hw/pci/pci.c| 99 +++

Re: [Qemu-devel] [PATCH 3/8] migration: add new capability test-only

2015-10-07 Thread Eric Blake
On 10/07/2015 12:20 AM, Denis V. Lunev wrote: > From: Igor Redko > > This patch declares a new migration capability that allows > to distinguish between true migration and the test. > > An alternative is using a custom URI but in this case the > following problems should be solved: > 1/ QEMUFile

Re: [Qemu-devel] [PATCH 4/4] events doubts

2015-10-07 Thread Paolo Bonzini
On 07/10/2015 12:51, Pavel Dovgaluk wrote: > > Why do they need to be separate on startup? Does initialization hang? > > My reasoning was that QEMU_CLOCK_VIRTUAL is zero anyway at both init and > > reset. > > I'm not sure about current (only core functions) version, but full version > requires t

Re: [Qemu-devel] [RFC PATCH] qapi: split visit_end_struct() into pieces

2015-10-07 Thread Eric Blake
On 10/07/2015 06:00 AM, Markus Armbruster wrote: >>> Looks like we're getting drawn into visitor contract territory again. >>> >> +++ b/hmp.c >> @@ -1658,8 +1658,9 @@ void hmp_object_add(Monitor *mon, const QDict *qdict) >> >> object_add(type, id, pdict, opts_get_visitor(ov), &err); >> >> +

Re: [Qemu-devel] [RFC PATCH V7 00/19] Multithread TCG.

2015-10-07 Thread Frederic Konrad
Hi Claudio, I'll rebase soon tomorrow with a bit of luck ;). Thanks, Fred On 07/10/2015 14:46, Claudio Fontana wrote: > Hello Frederic, > > On 11.08.2015 08:27, Frederic Konrad wrote: >> On 11/08/2015 08:15, Benjamin Herrenschmidt wrote: >>> On Mon, 2015-08-10 at 17:26 +0200, fred.kon...@greenso

Re: [Qemu-devel] [PATCH v2 00/18] implement vNVDIMM

2015-10-07 Thread Xiao Guangrong
On 10/07/2015 10:02 PM, Stefan Hajnoczi wrote: On Wed, Aug 26, 2015 at 06:49:35PM +0800, Xiao Guangrong wrote: On 08/26/2015 12:26 AM, Stefan Hajnoczi wrote: On Fri, Aug 14, 2015 at 10:51:53PM +0800, Xiao Guangrong wrote: Have you thought about live migration? Are the contents of the NVDIMM

Re: [Qemu-devel] [PATCH 1/2] qga: drop hand-made guest_file_toggle_flags helper

2015-10-07 Thread Eric Blake
On 10/07/2015 04:59 AM, Denis V. Lunev wrote: > We'd better use generic qemu_set_nonblock directly. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Yuri Pudgorodskiy > CC: Michael Roth > --- > qga/commands-posix.c | 27 ++- > 1 file changed, 2 insertions(+), 25 deletio

Re: [Qemu-devel] [PATCH v5 4/4] hmp: add monitor command to add/remove a child

2015-10-07 Thread Alberto Garcia
On Tue 22 Sep 2015 09:44:22 AM CEST, Wen Congyang wrote: > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -193,6 +193,34 @@ actions (drive options rerror, werror). > ETEXI > > { > +.name = "blockdev_child_add", > +.args_type = "id:B,child:B", > +.params

Re: [Qemu-devel] [PATCH v5 3/4] qmp: add monitor command to add/remove a child

2015-10-07 Thread Alberto Garcia
On Tue 22 Sep 2015 09:44:21 AM CEST, Wen Congyang wrote: > The new QMP command name is x-blockdev-child-add, and x-blockdev-child-del. > It justs for adding/removing quorum's child now, and don't support all > kinds of children, nor all block drivers. So it is experimental now. Better "So it is ex

[Qemu-devel] [PATCH] doc: document ivshmem & hugepages

2015-10-07 Thread marcandre . lureau
From: Marc-André Lureau Document and give some examples of hugepages support with ivshmem device and server. Signed-off-by: Marc-André Lureau --- qemu-doc.texi | 13 + 1 file changed, 13 insertions(+) diff --git a/qemu-doc.texi b/qemu-doc.texi index afa2263..b15c14c 100644 --- a/q

Re: [Qemu-devel] [PATCH] docs: update the usage example of "dtrace" backend in tracing.txt

2015-10-07 Thread Stefan Hajnoczi
On Fri, Sep 11, 2015 at 02:58:50PM +0800, Lin Ma wrote: > The usage example of dtrace is quite ancient, We have tracetool.py with > different parameters instead of the original tracetool shell script for > a long time, So update the old information. > > Signed-off-by: Lin Ma > --- > docs/tracing

Re: [Qemu-devel] [PATCH v4] ivshmem: allow the sharing of hugepages

2015-10-07 Thread Pavel Fedin
Hi! > P.S. Sorry if the question is stupid, i'm not really familiar in hugetlb > details. I only know > that managing huge pages is done via hugetlbfs. Ops, i was double-stupid. :) The question should have actually been: "How to configure ivshmem to use hugetlb with the series?" Kind regard

Re: [Qemu-devel] [PATCH v4] ivshmem: allow the sharing of hugepages

2015-10-07 Thread Marc-André Lureau
Hi On Wed, Oct 7, 2015 at 4:22 PM, Pavel Fedin wrote: > But what will cause memory-backend-ram to use hugetlb instead of just a RAM? > > P.S. Sorry if the question is stupid, i'm not really familiar in hugetlb > details. I only know that managing huge pages is done via hugetlbfs. Ah right, d

Re: [Qemu-devel] [PATCH v4] ivshmem: allow the sharing of hugepages

2015-10-07 Thread Pavel Fedin
Hello! > It is like other memdev properties, and there is an example in the > patch adding a test: > -object memory-backend-ram,size=1M,id=mb1 -device ivshmem,memdev=mb1 But what will cause memory-backend-ram to use hugetlb instead of just a RAM? P.S. Sorry if the question is stupid, i'm not

Re: [Qemu-devel] [RFC 0/8] QEMUFile-way to gather VM's memory statistics

2015-10-07 Thread Dr. David Alan Gilbert
(ccing Juan and Amit in) * Denis V. Lunev (d...@openvz.org) wrote: > This code is not ready to be merged. It is sent in the hope that it could > be useful and we could invent better architectural approach for the > feature if possible. > > +tch set summary: > - we added a feature that allows to g

  1   2   3   >