Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-14 Thread Markus Armbruster
John Snow writes: > We're a little too lenient with what we'll let an ATAPI drive handle. > Clamp down on the IDE command execution table to remove CD_OK permissions > from commands that are not and have never been ATAPI commands. > > For ATAPI command validity, please see: > - ATA4 Section 6.5 (

Re: [Qemu-devel] [PATCH v4 2/4] block: support passing 'backing': '' to 'blockdev-add'

2015-09-14 Thread Alberto Garcia
On Tue 15 Sep 2015 04:27:21 AM CEST, Fam Zheng wrote: >> +backing = qdict_get_try_str(options, "backing"); >> +if (backing && *backing == '\0') { >> +flags |= BDRV_O_NO_BACKING; >> +} >> +qdict_del(options, "backing"); >> + > Specifying a non-empty "backing" will be a sli

Re: [Qemu-devel] [Question] QEMU 2.3 Assertion with `existing->mr->subpage || existing->mr == &io_mem_unassigned' failed

2015-09-14 Thread Gonglei
On 2015/9/15 9:16, Gonglei wrote: > On 2015/9/14 17:28, Paolo Bonzini wrote: >> >> >> On 14/09/2015 10:01, Gonglei (Arei) wrote: >>> [2015-09-11 13:42:44] domain is rebooting >>> qemu-kvm: /home/abuild/rpmbuild/BUILD/qemu-kvm-2.3.0/exec.c:1188: >>> register_subpage: Assertion `existing->mr->subpa

[Qemu-devel] [PATCH v6 12/14] iotests: 124 - transactional failure test

2015-09-14 Thread Fam Zheng
From: John Snow Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure. To support the 'transactional-cancel' QMP argument name it's necessa

Re: [Qemu-devel] virtio-gpu: cursor update not in sync with resource update

2015-09-14 Thread Gerd Hoffmann
Hi, > >> if (!ret) { > >> reservation_object_add_excl_fence(qobj->tbo.resv, > >> &fence->f); > >> virtio_gpu_object_wait(qobj, false); > >> } > >> > >> before moving the cursor, shouldn't that suffi

Re: [Qemu-devel] [PATCH 1/2] PCI-e device multi-function hot-add support

2015-09-14 Thread Cao jin
Hi, Alex, Thanks very much for your quick review and I am sorry for my late response. On 09/10/2015 11:29 PM, Alex Williamson wrote: On Thu, 2015-09-10 at 20:12 +0800, Cao jin wrote: Enable PCI-e device multifunction hot, just ensure the function 0 added last, then driver will got the not

[Qemu-devel] [PATCH v6 11/14] block/backup: support block job transactions

2015-09-14 Thread Fam Zheng
From: Stefan Hajnoczi Join the transaction when the 'transactional-cancel' QMP argument is true. This ensures that the sync bitmap is not thrown away if another block job in the transaction is cancelled or fails. This is critical so incremental backup with multiple disks can be retried in case

[Qemu-devel] [PATCH v6 09/14] block: Add block job transactions

2015-09-14 Thread Fam Zheng
Sometimes block jobs must execute as a transaction group. Finishing jobs wait until all other jobs are ready to complete successfully. Failure or cancellation of one job cancels the other jobs in the group. Signed-off-by: Stefan Hajnoczi [Rewrite the implementation which is now contained in bloc

[Qemu-devel] [PATCH v6 14/14] tests: add BlockJobTxn unit test

2015-09-14 Thread Fam Zheng
From: Stefan Hajnoczi The BlockJobTxn unit test verifies that both single jobs and pairs of jobs behave as a transaction group. Either all jobs complete successfully or the group is cancelled. Signed-off-by: Stefan Hajnoczi Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- tests/Makefile

[Qemu-devel] [PATCH v6 10/14] blockdev: make BlockJobTxn available to qmp 'transaction'

2015-09-14 Thread Fam Zheng
From: Stefan Hajnoczi Provide a BlockJobTxn to actions executed in a qmp 'transaction' command. This allows actions to make their block jobs either complete as a group or fail/cancel together. The next patch adds the first user. Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Reviewed-

[Qemu-devel] [PATCH v6 07/14] blockjob: Add "completed" and "ret" in BlockJob

2015-09-14 Thread Fam Zheng
They are set when block_job_completed is called. Signed-off-by: Fam Zheng Reviewed-by: John Snow Reviewed-by: Max Reitz --- blockjob.c | 3 +++ include/block/blockjob.h | 9 + 2 files changed, 12 insertions(+) diff --git a/blockjob.c b/blockjob.c index ec12887..293b62a 1

[Qemu-devel] [PATCH v6 08/14] blockjob: Simplify block_job_finish_sync

2015-09-14 Thread Fam Zheng
With job->completed and job->ret to replace BlockFinishData. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- blockjob.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/blockjob.c b/blockjob.c index 293b62a..36c18e0 100644 --- a/blockjob.c +++

[Qemu-devel] [PATCH v6 13/14] qmp-commands.hx: Update the supported 'transaction' operations

2015-09-14 Thread Fam Zheng
From: Kashyap Chamarthy Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup blockdev-snapshot-internal-sync

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-09-14 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Sep 14, 2015 at 09:09:12AM -0600, Eric Blake wrote: >> On 09/13/2015 03:28 AM, Michael S. Tsirkin wrote: >> > On Fri, Sep 11, 2015 at 03:44:47PM -0300, Eduardo Habkost wrote: >> >> Ping? >> >> >> >> So, what's the reason we are still keeping those old machines in

[Qemu-devel] [PATCH v6 06/14] blockjob: Add .commit and .abort block job actions

2015-09-14 Thread Fam Zheng
Reviewed-by: Max Reitz Signed-off-by: Fam Zheng --- include/block/blockjob.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/block/blockjob.h b/include/block/blockjob.h index 3e7ad21..a7b497c 100644 --- a/include/block/blockjob.h +++ b/include/block/blockjob.h @@

[Qemu-devel] iotests failure of 128

2015-09-14 Thread Fam Zheng
Since commit 934659c460d46c948cf348822fda1d38556ed9a4 (iotests: Do not suppress segfaults in bash tests), sudo in 128 complains about unknown command "_qemu_io_wrapper", but I don't know how to fix that. Any idea? 128 - output mismatch (see 128.out.bad) --- /home/fam/qemu/tests/qemu-iotest

[Qemu-devel] [PATCH v6 05/14] blockjob: Introduce reference count

2015-09-14 Thread Fam Zheng
So that block_job_complete_sync can be simplified. Reviewed-by: Max Reitz Signed-off-by: Fam Zheng --- block/mirror.c | 2 +- blockjob.c | 22 ++ include/block/blockjob.h | 18 +++--- 3 files changed, 30 insertions(+), 12 deletions(-) di

[Qemu-devel] [PATCH v6 03/14] block: rename BlkTransactionState and BdrvActionOps

2015-09-14 Thread Fam Zheng
From: John Snow These structures are misnomers, somewhat. (1) BlockTransactionState is not state for a transaction, but is rather state for a single transaction action. Rename it "BlkActionState" to be more accurate. (2) The BdrvActionOps describes operations for the BlkActionState,

[Qemu-devel] [PATCH v6 02/14] iotests: add transactional incremental backup test

2015-09-14 Thread Fam Zheng
From: John Snow Test simple usage cases for using transactions to create and synchronize incremental backups. Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng Signed-off-by: Fam Zheng --- tests/qemu-iotests/

Re: [Qemu-devel] [PATCH v8 0/7] sPAPR: Support EEH Error Injection

2015-09-14 Thread Thomas Huth
On 14/09/15 06:14, David Gibson wrote: > On Mon, Sep 14, 2015 at 11:36:08AM +1000, Gavin Shan wrote: >> The patchset depends on below Linux upstream commits: >> >> commit ed3e81f ("powerpc/eeh: Move PE state constants around") >> commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()") >>

[Qemu-devel] [PATCH v6 01/14] qapi: Add transaction support to block-dirty-bitmap operations

2015-09-14 Thread Fam Zheng
From: John Snow This adds two qmp commands to transactions. block-dirty-bitmap-add allows you to create a bitmap simultaneously alongside a new full backup to accomplish a clean synchronization point. block-dirty-bitmap-clear allows you to reset a bitmap back to as-if it were new, which can als

[Qemu-devel] [PATCH v6 04/14] backup: Extract dirty bitmap handling as a separate function

2015-09-14 Thread Fam Zheng
This will be reused by the coming new transactional completion code. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block/backup.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/block/backup.c b/block/backup.c index 965654d..609b199 100644

[Qemu-devel] [PATCH v6 00/14] block: incremental backup transactions using BlockJobTxn

2015-09-14 Thread Fam Zheng
v6: Address comments from Max and Eric (many thanks for reviewing!): Add Max's reviews. Don't leak txn. [Max] Unusual comment ending "**/" -> "*/". [Eric] Fix the stale block_job_txn_prepare_to_complete comment. [Max] Move "block_job_txn_unref" to below FOREACH block. [Max]

[Qemu-devel] [PATCH] ppc/spapr: Allow VIRTIO_VGA

2015-09-14 Thread Benjamin Herrenschmidt
It works fine with the Linux driver out of the box Signed-off-by: Benjamin Herrenschmidt --- default-configs/ppc64-softmmu.mak | 1 + hw/ppc/spapr.c| 1 + 2 files changed, 2 insertions(+) diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak ind

Re: [Qemu-devel] [PATCH v5 11/14] block/backup: support block job transactions

2015-09-14 Thread Fam Zheng
On Fri, 09/11 15:26, Eric Blake wrote: > On 09/07/2015 01:34 AM, Fam Zheng wrote: > > From: Stefan Hajnoczi > > > > Join the transaction when the 'transactional-cancel' QMP argument is > > true. > > > > This ensures that the sync bitmap is not thrown away if another block > > job in the transact

Re: [Qemu-devel] [PATCH v5 09/14] block: Add block job transactions

2015-09-14 Thread Fam Zheng
On Fri, 09/11 20:52, Max Reitz wrote: > On 07.09.2015 09:34, Fam Zheng wrote: > > Sometimes block jobs must execute as a transaction group. Finishing > > jobs wait until all other jobs are ready to complete successfully. > > Failure or cancellation of one job cancels the other jobs in the group. >

Re: [Qemu-devel] [PATCH v5 04/14] backup: Extract dirty bitmap handling as a separate function

2015-09-14 Thread Fam Zheng
On Fri, 09/11 13:35, Eric Blake wrote: > On 09/07/2015 01:34 AM, Fam Zheng wrote: > > This will be reused by the coming new transactional completion code. > > > > Signed-off-by: Fam Zheng > > Reviewed-by: John Snow > > --- > > block/backup.c | 26 -- > > 1 file changed,

Re: [Qemu-devel] [PATCH v3] ppc/spapr: Implement H_RANDOM hypercall in QEMU

2015-09-14 Thread David Gibson
On Mon, Sep 14, 2015 at 08:32:36AM +0200, Thomas Huth wrote: > On 14/09/15 04:15, David Gibson wrote: > > On Fri, Sep 11, 2015 at 11:17:01AM +0200, Thomas Huth wrote: > >> The PAPR interface defines a hypercall to pass high-quality > >> hardware generated random numbers to guests. Recent kernels ca

Re: [Qemu-devel] [PATCH RFC 2/4] arm64: kvm: enable trapping of read access to regs in TID3 group

2015-09-14 Thread Shannon Zhao
On 2015/9/9 16:38, Tushar Jagad wrote: > This patch modifies the HCR_GUEST_FLAGS to enable trapping of > non secure read to registers under the HCR_EL2.TID3 group to EL2. > > We emulate the accesses to capability registers which list the number of > breakpoints, watchpoints, etc. These values ar

Re: [Qemu-devel] [RFCv2 2/2] spapr: Don't use QOM [*] syntax for DR connectors.

2015-09-14 Thread Michael Roth
Quoting Michael Roth (2015-09-14 23:03:00) > Quoting David Gibson (2015-09-13 20:41:53) > > The dynamic reconfiguration (hotplug) code for the pseries machine type > > uses a "DR connector" QOM object for each resource it will be possible > > to hotplug. Each of these is added to its owner using >

Re: [Qemu-devel] [RFCv2 2/2] spapr: Don't use QOM [*] syntax for DR connectors.

2015-09-14 Thread Michael Roth
Quoting David Gibson (2015-09-13 20:41:53) > The dynamic reconfiguration (hotplug) code for the pseries machine type > uses a "DR connector" QOM object for each resource it will be possible > to hotplug. Each of these is added to its owner using > object_property_add_child(owner, "dr-connector

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Wen Congyang
On 09/15/2015 11:46 AM, Eric Blake wrote: > On 09/14/2015 08:27 PM, Wen Congyang wrote: >>> Building fails: >>> GEN qmp-commands.h >>> In file included from /work/src/qemu/qapi-schema.json:9: >>> In file included from /work/src/qemu/qapi/block.json:6: >>> /work/src/qemu/qapi/block-core.json:184

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Eric Blake
On 09/14/2015 08:27 PM, Wen Congyang wrote: >> Building fails: >> GEN qmp-commands.h >> In file included from /work/src/qemu/qapi-schema.json:9: >> In file included from /work/src/qemu/qapi/block.json:6: >> /work/src/qemu/qapi/block-core.json:1844: Flat union 'BlockdevOptionsNBD' >> must have

Re: [Qemu-devel] [PATCH v3 3/3] pc: Introduce pc-*-2.5 machine classes

2015-09-14 Thread Jason Wang
On 09/15/2015 12:27 AM, Igor Mammedov wrote: > On Mon, 14 Sep 2015 11:32:45 -0300 > Eduardo Habkost wrote: > >> Introduce pc-*-2.5 machine classes, and add HW_COMPAT_2_4/PC_COMPAT_2_4 >> macros that will allow pc-*-2.4 compat properties to be added. >> >> Signed-off-by: Eduardo Habkost > Review

[Qemu-devel] [PATCH] linux-user/syscall.c: Fix issue for checking ptr in different address spaces in TARGET_CMSG_NXTHDR

2015-09-14 Thread gang . chen . 5i5j
From: Chen Gang After fix this issue, qemu can run i386 wine notepad.exe successfully. But the initialization performance is not quite well. Signed-off-by: Chen Gang --- linux-user/syscall.c | 30 +- linux-user/syscall_defs.h | 20 +--- 2 files

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-14 Thread Wen Congyang
On 09/14/2015 10:36 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >> blockdev.c | 47 ++ >> qapi/block-core.json | 34 +

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-14 Thread Wen Congyang
On 09/14/2015 11:37 PM, Kevin Wolf wrote: > Am 10.09.2015 um 11:55 hat Wen Congyang geschrieben: >> +## >> +# @x-child-add >> +# >> +# Add a new child to the parent BDS. Currently only the Quorum driver >> +# implements this feature. This is useful to fix a broken quorum child. >> +# >> +# @parent:

Re: [Qemu-devel] [PATCH] block/ssh: remove dead code

2015-09-14 Thread Fam Zheng
On Mon, 09/14 13:12, Paolo Bonzini wrote: > The "err" label cannot be reached with qp != NULL. Remove the free-ing > of qp and avoid future regressions by removing the initializer. > > Signed-off-by: Paolo Bonzini > --- > block/ssh.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) >

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Wen Congyang
On 09/15/2015 10:20 AM, Wen Congyang wrote: > On 09/14/2015 11:47 PM, Eric Blake wrote: >> On 09/14/2015 08:27 AM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> The NBD driver needs: filename, path or (host, port, exportname). It checks which key exists and decides use unix or in

Re: [Qemu-devel] [PATCH v4 2/4] block: support passing 'backing': '' to 'blockdev-add'

2015-09-14 Thread Fam Zheng
On Mon, 09/14 19:01, Alberto Garcia wrote: > Passing an empty string allows opening an image but not its backing > file. This was already described in the API documentation, only the > implementation was missing. > > This is useful for creating snapshots using images opened with > blockdev-add, si

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Wen Congyang
On 09/14/2015 11:47 PM, Eric Blake wrote: > On 09/14/2015 08:27 AM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> The NBD driver needs: filename, path or (host, port, exportname). >>> It checks which key exists and decides use unix or inet socket. >>> It doesn't recognize the key type, s

Re: [Qemu-devel] [RFT PATCH v1 3/3] net: smc91c111: flush packets on RCR register changes

2015-09-14 Thread Fam Zheng
On Thu, 09/10 21:24, Peter Crosthwaite wrote: > The SOFT_RST or RXEN in the control register can be used as a condition > to unblock the net layer via can_receive(). So check for possible > flushes on RCR changes. This will drop all pending packets on soft > reset or disable which is the functional

Re: [Qemu-devel] [PATCH v2 4/5] acpi: arm: add fw_cfg device node to dsdt

2015-09-14 Thread Shannon Zhao
On 2015/9/14 22:57, Gabriel L. Somlo wrote: > Add a fw_cfg device node to the ACPI DSDT. This is mostly > informational, as the authoritative fw_cfg MMIO region(s) > are listed in the Device Tree. However, since we are building > ACPI tables, we might as well be thorough while at it... > > Signe

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-14 Thread Yuanhan Liu
On Mon, Sep 14, 2015 at 06:00:41PM +0800, Jason Wang wrote: > > > On 09/08/2015 03:38 PM, Yuanhan Liu wrote: > > From: Ouyang Changchun > > > > This patch is initially based a patch from Nikolay Nikolaev. > > > > Here is the latest version for adding vhost-user multiple queue support, > > by cre

Re: [Qemu-devel] [RFT PATCH v1 2/3] net: smc91c111: gate can_receive() on rx FIFO having a slot

2015-09-14 Thread Fam Zheng
On Thu, 09/10 21:23, Peter Crosthwaite wrote: > Return false from can_receive() when the FIFO doesn't have a free RX > slot. This fixes a bug in the current code where the allocated buffer > is freed before the fifo pop, triggering a premature flush of queued RX > packets. It also will handle a cor

Re: [Qemu-devel] [RFT PATCH v1 1/3] net: smc91c111: guard flush_queued_packets() on can_rx()

2015-09-14 Thread Fam Zheng
On Thu, 09/10 21:23, Peter Crosthwaite wrote: > Check that the core can once again receive packets before asking the > net layer to do a flush. This will make it more convenient to flush > packets when adding new conditions to can_receive. > > Add missing if braces while moving the can_receive() c

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-14 Thread Wen Congyang
On 09/14/2015 11:47 PM, Eric Blake wrote: > On 09/14/2015 08:27 AM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> The NBD driver needs: filename, path or (host, port, exportname). >>> It checks which key exists and decides use unix or inet socket. >>> It doesn't recognize the key type, s

Re: [Qemu-devel] [PATCH v2 2/2] hw/arm/virt-acpi-build: Add DBG2 table

2015-09-14 Thread Shannon Zhao
On 2015/9/15 0:35, Andrew Jones wrote: > On Sun, Sep 13, 2015 at 04:06:33PM +0100, Leif Lindholm wrote: >> Add a DBG2 table, describing the pl011 UART. >> >> Signed-off-by: Leif Lindholm >> --- >> hw/arm/virt-acpi-build.c | 60 >> +++- >> 1 file chan

Re: [Qemu-devel] [Question] QEMU 2.3 Assertion with `existing->mr->subpage || existing->mr == &io_mem_unassigned' failed

2015-09-14 Thread Gonglei
On 2015/9/14 17:28, Paolo Bonzini wrote: > > > On 14/09/2015 10:01, Gonglei (Arei) wrote: >> [2015-09-11 13:42:44] domain is rebooting >> qemu-kvm: /home/abuild/rpmbuild/BUILD/qemu-kvm-2.3.0/exec.c:1188: >> register_subpage: Assertion `existing->mr->subpage || existing->mr == >> &io_mem_unassi

Re: [Qemu-devel] [PATCH] migration: Use g_new() & friends where that makes obvious sense

2015-09-14 Thread zhanghailiang
Reviewed-by: zhanghailiang On 2015/9/14 19:51, Markus Armbruster wrote: g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer, for two reasons. One, it catches multiplication overflowing size_t. Two, it returns T * rather than void *, which lets the compiler catch more type erro

Re: [Qemu-devel] [PATCH v11 4/5] cpu/apic: drop icc bus/bridge

2015-09-14 Thread Zhu Guihua
On 09/14/2015 09:18 PM, Igor Mammedov wrote: On Wed, 2 Sep 2015 17:36:21 +0800 Zhu Guihua wrote: From: Chen Fan After CPU hotplug has been converted to BUS-less hot-plug infrastructure, the only function ICC bus performs is to propagate reset to LAPICs. However LAPIC could be reset by regis

Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector

2015-09-14 Thread David Gibson
On Mon, Sep 14, 2015 at 02:11:53PM +0200, Paolo Bonzini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA256 > > > > On 14/09/2015 13:45, David Gibson wrote: > >>> > >>> === * There is no way for a child to determine what its parent > >>> is. It is not * a bidirectional relationship. Th

Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector

2015-09-14 Thread David Gibson
On Tue, Sep 15, 2015 at 12:06:49AM +1000, Alexey Kardashevskiy wrote: > On 09/14/2015 10:11 PM, Paolo Bonzini wrote: > >-BEGIN PGP SIGNED MESSAGE- > >Hash: SHA256 > > > > > > > >On 14/09/2015 13:45, David Gibson wrote: > > === * There is no way for a child to determine what its par

Re: [Qemu-devel] [RFC PATCH 1/2] target-ppc: remove hreg_compute_mem_idx() from cpu_post_load

2015-09-14 Thread Alexey Kardashevskiy
On 09/15/2015 05:30 AM, Mark Cave-Ayland wrote: hreg_compute_mem_idx() has already been called previously by ppc_store_msr() via hreg_store_msr() and hreg_compute_hflags(). Drop the duplicate function call as it is no longer needed. Signed-off-by: Mark Cave-Ayland Reviewed-by: Alexey Kardashe

Re: [Qemu-devel] [RFC PATCH 2/2] target-ppc: add CPU IRQ state to PPC VMStateDescription

2015-09-14 Thread Alexey Kardashevskiy
On 09/15/2015 05:30 AM, Mark Cave-Ayland wrote: Commit a90db15 "target-ppc: Convert ppc cpu savevm to VMStateDescription" appears to drop the internal CPU IRQ state from the migration stream. Whilst testing migration on g3beige/mac99 machines, test images would randomly fail to resume unless a ke

[Qemu-devel] [PATCH v16 32/35] target-tilegx: Handle atomic instructions

2015-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/main.c | 166 ++ target-tilegx/cpu.h | 4 +- target-tilegx/translate.c | 80 +- 3 files changed, 248 insertions(+), 2 deletions(-) diff --git a/linux-user/main.c b/lin

[Qemu-devel] [PATCH v16 30/35] target-tilegx: Handle v1cmpeq, v1cmpne

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 51 +++ 1 file changed, 51 insertions(+) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 38f9389..b5ae3f6 100644 --- a/target-tilegx/t

[Qemu-devel] [PATCH v16 33/35] target-tilegx: Handle v4int_l/h

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 8 1 file changed, 8 insertions(+) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 8895d72..2fcb17d 100644 --- a/target-tilegx/translate.c +++ b/target-tilegx/translate.

[Qemu-devel] [PATCH v16 28/35] target-tilegx: Handle scalar multiply instructions

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 112 ++ 1 file changed, 112 insertions(+) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index a9018f0..943b8a2 100644 --- a/target-tilegx/

[Qemu-devel] [PATCH v16 35/35] target-tilegx: Handle v1shl, v1shru, v1shrs

2015-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-tilegx/Makefile.objs | 2 +- target-tilegx/helper.h | 4 target-tilegx/simd_helper.c | 55 + target-tilegx/translate.c | 17 +- 4 files changed, 76 insertions(+), 2 deletions(-) crea

Re: [Qemu-devel] [PATCH v7 00/11] Fix exceptions handling for MIPS, PowerPC, and i386

2015-09-14 Thread Richard Henderson
On 07/10/2015 02:56 AM, Pavel Dovgalyuk wrote: Pavel Dovgalyuk (11): softmmu: add helper function to pass through retaddr softmmu: remove now unused functions cpu-exec: introduce loop exit with restore function These first three have been merged now. target-mips: i

[Qemu-devel] [PATCH v16 34/35] target-tilegx: Handle v1shli, v1shrui

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 2fcb17d..8c25282 100644 --- a/target-tilegx/translate.c +++ b/target-tilegx/tr

[Qemu-devel] [PATCH v16 21/35] target-tilegx: Handle unconditional jump instructions

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 58 +-- 1 file changed, 41 insertions(+), 17 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index bbea252..81033bb 100644 ---

[Qemu-devel] [PATCH v16 31/35] target-tilegx: Handle mtspr, mfspr

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 76 +-- 1 file changed, 73 insertions(+), 3 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index b5ae3f6..1e678ec 100644 --- a

[Qemu-devel] [PATCH v16 25/35] target-tilegx: Handle bitfield instructions

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 74 +++ 1 file changed, 74 insertions(+) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index cb21c14..9604320 100644 --- a/target-tilegx/t

[Qemu-devel] [PATCH v16 23/35] target-tilegx: Handle comparison instructions

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 39 +-- 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 5d7aefa..0fbd11b 100644 --- a/target-

[Qemu-devel] [PATCH v16 24/35] target-tilegx: Implement system and memory management instructions

2015-09-14 Thread Richard Henderson
Most of which are either nops or exceptions. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 77 +-- 1 file changed, 54 insertions(+), 23 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/

[Qemu-devel] [PATCH v16 29/35] target-tilegx: Handle mask instructions

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 943b8a2..38f9389 100644 --- a/target-tilegx/translate.c +++ b/targ

[Qemu-devel] [PATCH v16 19/35] target-tilegx: Handle basic load and store instructions

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 130 -- 1 file changed, 115 insertions(+), 15 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index c2f38f1..d3b4eae 100644 ---

[Qemu-devel] [PATCH v16 11/35] target-tilegx: Framework for decoding bundles

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 1145 + 1 file changed, 1145 insertions(+) create mode 100644 target-tilegx/translate.c diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c new

[Qemu-devel] [PATCH v16 27/35] target-tilegx: Handle conditional move instructions

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index c18e60c..a9018f0 100644 --- a/target-tilegx/translate.c +++ b/target-t

[Qemu-devel] [PATCH v16 17/35] target-arm: Use new revbit functions

2015-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-arm/helper-a64.c | 15 +-- target-arm/helper.c | 12 +--- 2 files changed, 2 insertions(+), 25 deletions(-) diff --git a/target-arm/helper-a64.c b/target-arm/helper-a64.c index 2c7a645..deb8dbe 100644 --- a/target-arm/helper-a64

[Qemu-devel] [PATCH v16 18/35] target-tilegx: Handle most bit manipulation instructions

2015-09-14 Thread Richard Henderson
The crc instructions are omitted from this set. Signed-off-by: Richard Henderson --- target-tilegx/helper.c| 10 +++ target-tilegx/helper.h| 2 ++ target-tilegx/translate.c | 68 ++- 3 files changed, 79 insertions(+), 1 deletion(-) diff -

[Qemu-devel] [PATCH v16 15/35] target-tilegx: Handle arithmetic instructions

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 96 --- 1 file changed, 90 insertions(+), 6 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 68c7db2..6b5de55 100644 --- a

[Qemu-devel] [PATCH v16 16/35] host-utils: Add revbit functions

2015-09-14 Thread Richard Henderson
Signed-off-by: Richard Henderson --- include/qemu/host-utils.h | 77 +++ 1 file changed, 77 insertions(+) diff --git a/include/qemu/host-utils.h b/include/qemu/host-utils.h index 7d36ebf..3ef97d5 100644 --- a/include/qemu/host-utils.h +++ b/include/qem

[Qemu-devel] [PATCH v16 26/35] target-tilegx: Handle shift instructions

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 56 +-- 1 file changed, 54 insertions(+), 2 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 9604320..c18e60c 100644 --- a

[Qemu-devel] [PATCH v16 10/35] target-tilegx: Add several helpers for instructions translation

2015-09-14 Thread Richard Henderson
From: Chen Gang The related instructions are exception, cntlz, cnttz, shufflebytes. Reviewed-by: Peter Maydell Signed-off-by: Chen Gang Message-Id: [rth: Remove incorrect implementation of add_saturate.] Signed-off-by: Richard Henderson --- target-tilegx/helper.c | 70 ++

[Qemu-devel] [PATCH v16 14/35] target-tilegx: Handle simple logical operations

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 99 +-- 1 file changed, 96 insertions(+), 3 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 58289b7..68c7db2 100644 --- a

[Qemu-devel] [PATCH v16 05/35] target-tilegx: Modify opcode_tilegx.h to fit QEMU usage

2015-09-14 Thread Richard Henderson
From: Chen Gang Use 'inline' instead of '__inline', and also use 'uint64_t' instead of "unsigned long long" Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- target-tilegx/opcode_tilegx.h | 220 +- 1

[Qemu-devel] [PATCH v16 22/35] target-tilegx: Handle conditional branch instructions

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 51 +++ 1 file changed, 38 insertions(+), 13 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index 81033bb..5d7aefa 100644 ---

[Qemu-devel] [PATCH v16 20/35] target-tilegx: Handle post-increment load and store instructions

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/translate.c | 94 +++ 1 file changed, 86 insertions(+), 8 deletions(-) diff --git a/target-tilegx/translate.c b/target-tilegx/translate.c index d3b4eae..bbea252 100644 --- a

[Qemu-devel] [PATCH v16 09/35] target-tilegx: Add cpu basic features for linux-user

2015-09-14 Thread Richard Henderson
From: Chen Gang It implements minimized cpu features for linux-user. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- target-tilegx/cpu.c | 170 ++ target-tilegx/cpu.h | 175 +

[Qemu-devel] [PATCH v16 01/35] linux-user: tilegx: Add architecture related features

2015-09-14 Thread Richard Henderson
From: Chen Gang They are based on Linux kernel tilegx architecture for 64 bit binary, and also based on tilegx ABI reference document, and also reference from other targets implementations. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson ---

[Qemu-devel] [PATCH v16 12/35] target-tilegx: Generate SEGV properly

2015-09-14 Thread Richard Henderson
Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- linux-user/main.c | 3 +++ target-tilegx/cpu.c | 5 - target-tilegx/cpu.h | 2 ++ 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/linux-user/main.c b/linux-user/main.c index f3a37a2..57c1942 100644 --- a/linux-us

[Qemu-devel] [PATCH v16 08/35] target-tilegx: Add special register information from Tilera Corporation

2015-09-14 Thread Richard Henderson
From: Chen Gang The related copy is from Linux kernel "arch/tile/include/uapi/arch/ spr_def_64.h". Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- target-tilegx/spr_def_64.h | 216 + 1 file chan

[Qemu-devel] [PATCH v16 06/35] target-tilegx: Modify _SPECIAL_ opcodes

2015-09-14 Thread Richard Henderson
Both ADDX_SPECIAL_0_OPCODE_Y1 and ADD_SPECIAL_0_OPCODE_Y1 do not appear to be "special" in any way, except that they don't follow the normal naming convention using _RRR_. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/opcode_tilegx.h | 4 ++-- 1 file changed, 2 i

[Qemu-devel] [PATCH v16 13/35] target-tilegx: Add TILE-Gx building files

2015-09-14 Thread Richard Henderson
From: Chen Gang Add related configuration and make files for tilegx. The target can now build, though not run anything. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- configure | 2 ++ default-configs/tilegx-l

[Qemu-devel] [PATCH v16 07/35] target-tilegx: Fix LDNA_ADD_IMM8_OPCODE_X1

2015-09-14 Thread Richard Henderson
An obvious typo in the mnemonic here. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target-tilegx/opcode_tilegx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-tilegx/opcode_tilegx.h b/target-tilegx/opcode_tilegx.h index 3b8bf4f..989436d 100644 ---

[Qemu-devel] [PATCH v16 04/35] target-tilegx: Add opcode basic implementation from Tilera Corporation

2015-09-14 Thread Richard Henderson
From: Chen Gang It is copied from Linux kernel "arch/tile/include/uapi/arch/ opcode_tilegx.h". Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- target-tilegx/opcode_tilegx.h | 1406 + 1 file changed,

[Qemu-devel] [PATCH v16 00/35] TileGX basic instructions

2015-09-14 Thread Richard Henderson
Incorporating review from v15, some of which was in v14 but I somehow skipped over. Major changes are: * revbit functions for host-utils.h * implementation of atomic operations not split across two patches * unsigned vector shifts avoid a loop. r~ Chen Gang (9): linux-user: tilegx: Add

[Qemu-devel] [PATCH v16 03/35] linux-user: Conditionalize syscalls which are not defined in tilegx

2015-09-14 Thread Richard Henderson
From: Chen Gang Some of architectures (e.g. tilegx), several syscall macros are not supported, so switch them. Signed-off-by: Chen Gang Reviewed-by: Peter Maydell Message-Id: Signed-off-by: Richard Henderson --- linux-user/syscall.c | 50 +- 1

[Qemu-devel] [PATCH v16 02/35] linux-user: Support tilegx architecture in linux-user

2015-09-14 Thread Richard Henderson
From: Chen Gang Add main working flow feature, system call processing feature, and elf64 tilegx binary loading feature, based on Linux kernel tilegx 64-bit implementation. [rth: Moved all of the implementation of atomic instructions to a later patch.] Signed-off-by: Chen Gang Reviewed-by: Pete

Re: [Qemu-devel] virtio-gpu: cursor update not in sync with resource update

2015-09-14 Thread Dave Airlie
On 15 September 2015 at 07:14, Marc-André Lureau wrote: > Hi > > On Mon, Sep 14, 2015 at 11:08 PM, Dave Airlie wrote: >> Currently the kernel driver does this: >> >> ret = virtio_gpu_cmd_transfer_to_host_2d(vgdev, qobj->hw_res_handle, >> 0, >>

Re: [Qemu-devel] virtio-gpu: cursor update not in sync with resource update

2015-09-14 Thread Marc-André Lureau
Hi On Mon, Sep 14, 2015 at 11:08 PM, Dave Airlie wrote: > Currently the kernel driver does this: > > ret = virtio_gpu_cmd_transfer_to_host_2d(vgdev, qobj->hw_res_handle, > 0, > cpu_to_le32(64), >

Re: [Qemu-devel] [RFT PATCH v1 0/3] net: smc91c111 can_receive fixes

2015-09-14 Thread Richard Purdie
Hi Peter, On Thu, 2015-09-10 at 21:23 -0700, Peter Crosthwaite wrote: > This should hopefully fix your bug, while addressing the extra concern > I raised. > > There was also inconsistent behaviour with corking packets through a > soft reset which I notice and fixed. > > Please let me know if thi

Re: [Qemu-devel] [edk2] Windows does not support DataTableRegion at all [was: docs: describe QEMU's VMGenID design]

2015-09-14 Thread Bill Paul
Of all the gin joints in all the towns in all the world, Laszlo Ersek had to walk into mine at 11:20:28 on Monday 14 September 2015 and say: > On 09/14/15 18:53, Bill Paul wrote: > > Of all the gin joints in all the towns in all the world, Laszlo Ersek had > > to > > > > walk into mine at 03:24:

Re: [Qemu-devel] virtio-gpu: cursor update not in sync with resource update

2015-09-14 Thread Dave Airlie
On 15 September 2015 at 01:17, Marc-André Lureau wrote: > Hi > > On Mon, Sep 14, 2015 at 4:06 PM, Gerd Hoffmann wrote: >> The guest can upload different cursors and then switch between them >> without re-uploading and therefore without ctrl queue updates. Thats >> why they have an id in the firs

Re: [Qemu-devel] [PATCH v2 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-09-14 Thread Gabriel L. Somlo
On Mon, Sep 14, 2015 at 04:34:02PM -0400, Gabriel L. Somlo wrote: > > > So I'll replace the "if (guest_info->fw_cfg)" check with > > > "if machine-type >= (pc-q35-2.5 or pc-i440fx-2.5))", in v3, > > > as soon as the patches for the 2.5 machine type make it into > > > git master (I remember seeing a

Re: [Qemu-devel] [PATCH v2 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-09-14 Thread Gabriel L. Somlo
On Mon, Sep 14, 2015 at 05:16:44PM -0300, Eduardo Habkost wrote: > On Mon, Sep 14, 2015 at 02:16:49PM -0400, Gabriel L. Somlo wrote: > > On Mon, Sep 14, 2015 at 01:09:41PM -0300, Eduardo Habkost wrote: > > > On Mon, Sep 14, 2015 at 10:57:31AM -0400, Gabriel L. Somlo wrote: > > > > Add a fw_cfg devi

Re: [Qemu-devel] [PATCH 2/2] linux-user: remove MAX_ARG_PAGES limit

2015-09-14 Thread Peter Maydell
On 14 September 2015 at 20:37, Stefan Bruens wrote: > On Thursday 03 September 2015 18:27:20 Peter Maydell wrote: >> On 2 September 2015 at 02:38, Stefan Brüns > wrote: >> > Instead of creating a temporary copy for the whole environment and >> > the arguments, directly copy everything to the targ

  1   2   3   4   >