Re: [Qemu-devel] [PATCH 5/7] vhost_net: move vhost_net_set_vq_index ahead at vhost_net_init

2015-09-09 Thread Jason Wang
On 09/10/2015 02:18 PM, Yuanhan Liu wrote: > On Thu, Sep 10, 2015 at 01:52:30PM +0800, Jason Wang wrote: >> >> On 09/10/2015 01:17 PM, Yuanhan Liu wrote: >>> On Thu, Sep 10, 2015 at 12:46:00PM +0800, Jason Wang wrote: > > On 09/10/2015 11:57 AM, Yuanhan Liu wrote: >>> On Thu, Sep 10,

Re: [Qemu-devel] [PATCH 0/3] monitor: throttle VSERPORT_CHANGED by "id"

2015-09-09 Thread Markus Armbruster
Amit Shah writes: > On (Tue) 08 Sep 2015 [12:18:53], Marc-André Lureau wrote: >> ping > > I'd rather the qmp / qapi maintainers chimed in - the changes touch > that part of code rather than the virtio-serial related code. It's in my (overlong) review queue. I apologize for the delay.

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Andrew Fish
> On Sep 9, 2015, at 11:19 PM, Alexander Graf wrote: > > > >> Am 10.09.2015 um 07:32 schrieb Jordan Justen : >> >> On 2015-09-09 20:26:54, Andrew Fish wrote: On Sep 9, 2015, at 5:41 PM, Jordan Justen wrote: > On 2015-09-09 16:05:20, Andrew Fish wrote: > So you have a legal

Re: [Qemu-devel] qemu-devel digest question

2015-09-09 Thread Markus Armbruster
Peter Maydell writes: > On 9 September 2015 at 18:50, Steve Ellcey wrote: >> Sorry if this is off topic or should be discussed somewhere else but >> I am subscribed to the qemu-devel list in digest form and I have already >> gotten 60 digests today (it is not yet noon). While I appriciate that

[Qemu-devel] [RFC PATCH] spapr: Reduce creation of LMB DR connectors from O(n^3) to O(n^2)

2015-09-09 Thread David Gibson
The dynamic reconfiguration (hotplug) code for the pseries machine type uses a "DR connector" QOM object for each resource it will be possible to hotplug. Each of these is added to its owner using object_property_add_child(owner, "dr-connector[*], ...); This works ok for most cases, but gets

[Qemu-devel] [PATCH] Add a few argument filters to the seccomp sandbox

2015-09-09 Thread namnamc
This patch here adds argument filtering for three syscalls: madvise(), shmget(), and shmctl(). The madvise() flags may need a few additions, but I couldn't find any common cases where the extra flags were used. The only additions were ones I found by grepping through the source code for all madvis

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Alexander Graf
> Am 10.09.2015 um 07:32 schrieb Jordan Justen : > > On 2015-09-09 20:26:54, Andrew Fish wrote: >>> On Sep 9, 2015, at 5:41 PM, Jordan Justen wrote: On 2015-09-09 16:05:20, Andrew Fish wrote: So you have a legal degree and are speaking on behalf of your employer on this subject?

Re: [Qemu-devel] [PATCH 5/7] vhost_net: move vhost_net_set_vq_index ahead at vhost_net_init

2015-09-09 Thread Yuanhan Liu
On Thu, Sep 10, 2015 at 01:52:30PM +0800, Jason Wang wrote: > > > On 09/10/2015 01:17 PM, Yuanhan Liu wrote: > > On Thu, Sep 10, 2015 at 12:46:00PM +0800, Jason Wang wrote: > >> > > >> > > >> > On 09/10/2015 11:57 AM, Yuanhan Liu wrote: > >>> > > On Thu, Sep 10, 2015 at 11:14:27AM +0800, Jason

Re: [Qemu-devel] [PATCH] spapr: Reduce advertised max LUNs for spapr_vscsi

2015-09-09 Thread Thomas Huth
On 10/09/15 03:24, David Gibson wrote: > On Wed, Sep 09, 2015 at 09:29:18AM +0200, Thomas Huth wrote: >> On 09/09/15 09:19, David Gibson wrote: >>> On Wed, Sep 09, 2015 at 08:25:34AM +0200, Thomas Huth wrote: On 09/09/15 03:22, David Gibson wrote: > The implementation of the PAPR paravirtu

Re: [Qemu-devel] [RFC 00/20] Do away with TB retranslation

2015-09-09 Thread Dennis Luehring
Am 08.09.2015 um 21:00 schrieb Richard Henderson: Anyway, I've just fixed the sparc problem and re-pushed the tree to git://github.com/rth7680/qemu.git tcg-search-2 for anyone who wants to do any more testing. strangly your branch doesn't changed anything for pure SPARC64 in my tests - i

Re: [Qemu-devel] [PATCH 5/7] vhost_net: move vhost_net_set_vq_index ahead at vhost_net_init

2015-09-09 Thread Jason Wang
On 09/10/2015 01:17 PM, Yuanhan Liu wrote: > On Thu, Sep 10, 2015 at 12:46:00PM +0800, Jason Wang wrote: >> > >> > >> > On 09/10/2015 11:57 AM, Yuanhan Liu wrote: >>> > > On Thu, Sep 10, 2015 at 11:14:27AM +0800, Jason Wang wrote: > >> > >> On 09/08/2015 03:38 PM, Yuanhan Liu wrote: >

Re: [Qemu-devel] [PATCH] linux-user/main.c: Always set QEMU_LD_PREFIX when interp_prefix is changed

2015-09-09 Thread Chen Gang
On 2015年09月10日 13:43, gang.chen.5...@gmail.com wrote: > From: Chen Gang > > If qemu sets interp_prfix via command line '-L' instead of environments > variable QEMU_LD_PREFIX, it will cause syscall execve() failed. Because > the 2nd qemu has no command line '-L'. > Oh, sorry for typo, "the 2nd"

[Qemu-devel] [PATCH] linux-user/main.c: Always set QEMU_LD_PREFIX when interp_prefix is changed

2015-09-09 Thread gang . chen . 5i5j
From: Chen Gang If qemu sets interp_prfix via command line '-L' instead of environments variable QEMU_LD_PREFIX, it will cause syscall execve() failed. Because the 2nd qemu has no command line '-L'. So qemu need always set QEMU_LD_PREFIX when interp_prefix is changed. Signed-off-by: Chen Gang

Re: [Qemu-devel] [PATCH 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-09 Thread Deepak Shetty
[snip] On Wed, Sep 9, 2015 at 10:37 PM, Raghavendra Talur wrote: > > > From QEMU's perspective, it would be better to use separate fields > >> (that have type information) than to encode everything in an opaque >> URI string. Fields can do input validation in common code so that >> block driver

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Jordan Justen
On 2015-09-09 20:26:54, Andrew Fish wrote: > > On Sep 9, 2015, at 5:41 PM, Jordan Justen wrote: > > On 2015-09-09 16:05:20, Andrew Fish wrote: > >> So you have a legal degree and are speaking on behalf of your > >> employer on this subject? > > > > No and no. How about you? :) > > No but I have

Re: [Qemu-devel] [PATCH 5/7] vhost_net: move vhost_net_set_vq_index ahead at vhost_net_init

2015-09-09 Thread Yuanhan Liu
On Thu, Sep 10, 2015 at 12:46:00PM +0800, Jason Wang wrote: > > > On 09/10/2015 11:57 AM, Yuanhan Liu wrote: > > On Thu, Sep 10, 2015 at 11:14:27AM +0800, Jason Wang wrote: > >> > >> On 09/08/2015 03:38 PM, Yuanhan Liu wrote: > >>> So that we could use the `vq_index' as well in the vhost_net_init

Re: [Qemu-devel] [PATCH 5/7] vhost_net: move vhost_net_set_vq_index ahead at vhost_net_init

2015-09-09 Thread Jason Wang
On 09/10/2015 11:57 AM, Yuanhan Liu wrote: > On Thu, Sep 10, 2015 at 11:14:27AM +0800, Jason Wang wrote: >> >> On 09/08/2015 03:38 PM, Yuanhan Liu wrote: >>> So that we could use the `vq_index' as well in the vhost_net_init >>> stage, which is required when adding vhost-user multiple-queue suppor

[Qemu-devel] [PATCH RFC v4 29/29] net: Complete qapi-fication of netdev_add

2015-09-09 Thread Eric Blake
We finally have all the required pieces for doing a type-safe representation of netdev_add as a flat union, where the discriminator 'type' now selects which additional members may appear in the "arguments" JSON object sent over QMP, while making no changes to the set of previously-valid QMP command

[Qemu-devel] [PATCH RFC v4 23/29] qapi: Plumb in 'box' to qapi generator lower levels

2015-09-09 Thread Eric Blake
A future patch will add support for passing a qapi union type as the 'data' of a command. But to do that, the user function for implementing the command, as called by the generated marshal command, must take the corresponding C struct as a single boxed pointer, rather than a breakdown into one par

[Qemu-devel] [PATCH RFC v4 24/29] qapi: Implement boxed structs for commands/events

2015-09-09 Thread Eric Blake
Turn on the ability to pass command and event arguments in a single boxed parameter. This patch merely tests the use of the feature on structs. With this patch, we still reject union types, and crash on { 'command':'foo', 'data': { anonymous...}, 'box':true }; that will be addressed in the next p

[Qemu-devel] [PATCH RFC v4 03/29] qapi: use 'type' in generated C code to match QMP union wire form

2015-09-09 Thread Eric Blake
When dealing with simple qapi unions, the code was generating a discriminator field of 'kind' even though the discriminator is sent as 'type' over QMP. Renaming things to match gets us one step closer to reusing common generator code for both simple and flat unions, without having to special case

[Qemu-devel] [PATCH RFC v4 19/29] qapi: Document visitor interfaces

2015-09-09 Thread Eric Blake
The visitor interface for mapping between QObject and qapi has formerly been documented only by reading source code, making it difficult to propose changes to either scripts/qapi*.py or to clients without knowing whether those changes would be safe. This tries to add documentation, including menti

Re: [Qemu-devel] [PATCH 0/3] monitor: throttle VSERPORT_CHANGED by "id"

2015-09-09 Thread Amit Shah
On (Tue) 08 Sep 2015 [12:18:53], Marc-André Lureau wrote: > ping I'd rather the qmp / qapi maintainers chimed in - the changes touch that part of code rather than the virtio-serial related code. > > On Wed, Sep 2, 2015 at 1:09 PM, wrote: > > From: Marc-André Lureau > > > > QAPI_EVENT_VSERPORT

[Qemu-devel] [PATCH RFC v4 20/29] qapi: Plug leaks in test-qmp-input-visitor

2015-09-09 Thread Eric Blake
Make valgrind happy with the current state of the test, so that the next patch can more easily expose a memory leak without it being drowned by noise. Signed-off-by: Eric Blake --- tests/test-qmp-input-visitor.c | 34 +++--- 1 file changed, 31 insertions(+), 3 deletio

[Qemu-devel] [PATCH RFC v4 27/29] qapi: Change Netdev into a flat union

2015-09-09 Thread Eric Blake
From: Kővágó, Zoltán Except qapi-schema.json, this patch was generated by: find . -name .git -prune -o -type f \! -name '*~' -print0 | \ xargs -0 sed -i \ -e 's/NetClientOptionsKind/NetClientDriver/g' \ -e 's/NET_CLIENT_OPTIONS_KIND_/NET_CLIENT_DRIVER_/g' \ -e 's/netdev->opts/netde

[Qemu-devel] [PATCH RFC v4 18/29] qapi: Remove dead visitor code

2015-09-09 Thread Eric Blake
Commit cbc95538 removed unused start_handle() and end_handle(), but forgot got remove their declarations. Commit 4e27e819 introduced optional visitor callbacks for all sorts of int types, but except for type_uint64 and type_size, none of them have ever been supplied (the generic implementation bas

[Qemu-devel] [PATCH RFC v4 10/29] qapi: Fix alternates that accept 'number' but not 'int'

2015-09-09 Thread Eric Blake
The QMP input visitor allows integral values to be assigned by promotion to a QTYPE_QFLOAT. However, when parsing an alternate, we did not take this into account, such that an alternate that accepts 'number' but not 'int' would reject integral values. With this patch, we now have the following de

[Qemu-devel] [PATCH RFC v4 14/29] qapi: Rework deallocation of partial struct

2015-09-09 Thread Eric Blake
Commit cee2dedb noticed that if you have a partial flat union (such as if an input parse failed due to a missing discriminator), calling the dealloc visitor could result in trying to dereference the NULL pointer. But the fix it proposed requires the use of a 'data' member in the union, which may or

[Qemu-devel] [PATCH RFC v4 28/29] net: Use correct type for bool flag

2015-09-09 Thread Eric Blake
is_netdev is only used as a bool, so make it one. Signed-off-by: Eric Blake --- hw/usb/dev-network.c | 2 +- include/net/net.h| 2 +- net/net.c| 12 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/usb/dev-network.c b/hw/usb/dev-network.c index 97b

[Qemu-devel] [PATCH RFC v4 26/29] qapi: Clean up qapi.py per pep8

2015-09-09 Thread Eric Blake
Silence pep8, and make pylint a bit happier. Just style cleanups; no semantic changes. Signed-off-by: Eric Blake --- scripts/qapi.py | 165 1 file changed, 106 insertions(+), 59 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py

[Qemu-devel] [PATCH RFC v4 11/29] qapi: Don't pass pre-existing error to later call

2015-09-09 Thread Eric Blake
Due to the existing semantics of the error_set() family, generated sequences in the qapi visitors such as: visit_start_implicit_struct(m, (void **)obj, sizeof(FOO), &err); if (!err) { visit_type_FOO_fields(m, obj, errp); visit_end_implicit_struct(m, &err);

[Qemu-devel] [PATCH RFC v4 08/29] qapi: Simplify visiting of alternate types

2015-09-09 Thread Eric Blake
Previously, working with alternates required two enums, and some indirection: for type Foo, we created Foo_qtypes[] which maps each qtype to a member of FooKind_lookup[], then use FooKind_lookup[] like we do for other union types. This has a subtle bug: since the values of FooKind_lookup start at

[Qemu-devel] [PATCH RFC v4 22/29] qapi: Change visit_type_FOO() to no longer return partial objects

2015-09-09 Thread Eric Blake
Returning a partial object on error is an invitation for a careless caller to leak memory. As no one outside the testsuite was actually relying on these semantics, it is cleaner to just document and guarantee that ALL visit_type_FOO() functions do not alter *obj when an error is encountered during

[Qemu-devel] [PATCH RFC v4 25/29] qapi: Support boxed unions

2015-09-09 Thread Eric Blake
This patch completes support for boxed types, by allowing union types to be used when 'box':true is specified. It also avoids a python crash when attempting to use boxing on an anonymous type. While it was possible to support 'box':true on an empty event, it was easier to just reject missing 'dat

[Qemu-devel] [PATCH RFC v4 05/29] qapi: Unbox base members

2015-09-09 Thread Eric Blake
Rather than storing a base class as a pointer to a box, just store the fields of that base class in the same order, so that a child struct can be safely cast to its parent. This gives less malloc overhead, less pointer dereferencing, and even less generated code. Without boxing, the corner case o

[Qemu-devel] [PATCH RFC v4 15/29] qapi: Avoid use of 'data' member of qapi unions

2015-09-09 Thread Eric Blake
qapi code generators currently create a 'void *data' member as part of the anonymous union embedded in the C struct corresponding to a qapi union. However, directly assigning to this member of the union feels a bit fishy, when we can directly use the rest of the struct instead. Signed-off-by: Eri

[Qemu-devel] [PATCH RFC v4 16/29] qapi: Forbid empty unions and useless alternates

2015-09-09 Thread Eric Blake
Empty unions serve no purpose, and while we compile with gcc which permits them, strict C99 forbids them. We could inject a dummy member (and in fact, we do for empty structs), but while empty structs make sense in qapi, empty unions don't add any expressiveness to the QMP language. So prohibit t

[Qemu-devel] [PATCH RFC v4 21/29] qapi: Test failure in middle of array parse

2015-09-09 Thread Eric Blake
Our generated list visitors have the same problem as has been mentioned elsewhere (see commit 2f52e20): they allocate data even on failure. An upcoming patch will correct things to provide saner guarantees, but first we need to expose the behavior in the testsuite to ensure we aren't introducing an

[Qemu-devel] [PATCH RFC v4 02/29] net: use Netdev instead of NetClientOptions in client init

2015-09-09 Thread Eric Blake
From: Kővágó, Zoltán This way we no longer need NetClientOptions and can convert Netdev into a flat union. Signed-off-by: Kővágó, Zoltán Reviewed-by: Eric Blake Message-Id: <93ffdfed7054529635e6acb935150d95dc173a12.1441627176.git.dirty.ice...@gmail.com> [rework net_client_init1() to pass Net

[Qemu-devel] [PATCH RFC v4 13/29] qapi: Add tests for empty unions

2015-09-09 Thread Eric Blake
The documentation claims that alternates are useful for allowing two types, although nothing enforces this. Meanwhile, it is silent on whether empty unions are allowed. In practice, the generated code will compile, in part because we have a 'void *data' branch; but for an empty alternate it alway

[Qemu-devel] [PATCH RFC v4 12/29] qapi: Use consistent generated code patterns

2015-09-09 Thread Eric Blake
We had a pointless difference in label names, and on whether the generated code used: if (*obj) { stuff; ... } vs. if (!*obj) { goto out_obj; } stuff; ... Pick a single style, as it will make it easier for later patches to uniformly apply any updates

[Qemu-devel] [PATCH RFC v4 07/29] qapi: Test use of 'number' within alternates

2015-09-09 Thread Eric Blake
Add some testsuite exposure for use of a 'number' as part of an alternate. The current state of the tree has a few bugs exposed by this: our input parser depends on the ordering of how the qapi schema declared the alternate, and the parser does not accept integers for a 'number' in an alternate ev

[Qemu-devel] [PATCH RFC v4 17/29] qapi: Drop useless 'data' member of unions

2015-09-09 Thread Eric Blake
Now that we no longer have any clients of the 'void *data' member injected into unions, we can drop it. Update the testsuite to prove that we no longer have a name collision. Signed-off-by: Eric Blake --- scripts/qapi-types.py | 9 - tests/qapi-schema/qapi-schema-test.

[Qemu-devel] [PATCH RFC v4 06/29] qapi-visit: Remove redundant functions for flat union base

2015-09-09 Thread Eric Blake
The code for visiting the base class of a child struct created visit_type_Base_fields(); the code for visiting the base class of a flat union created visit_type_Union_fields(). If the same type is shared between a struct and a union, the two functions differed only by whether they visited the discr

[Qemu-devel] [PATCH RFC v4 04/29] vnc: hoist allocation of VncBasicInfo to callers

2015-09-09 Thread Eric Blake
A future qapi patch will rework generated structs with a base class to be unboxed. In preparation for that, change the code that allocates then populates an info struct to instead merely populate the fields of an info field passed in as a parameter. Add rudimentary Error handling for cases where t

[Qemu-devel] [PATCH RFC v4 09/29] qapi: Hide tag_name data member of variants

2015-09-09 Thread Eric Blake
Clean up the only remaining external use of the tag_name field of QAPISchemaObjectTypeVariants, by explicitly listing the generated 'type' tag for simple unions in the testsuite. Since alternate types no longer use the tag_member field, we can now mark the tag_name field as private by adding a lea

[Qemu-devel] [PATCH RFC v4 01/29] qapi: Provide nicer array names in introspection

2015-09-09 Thread Eric Blake
For the sake of humans reading introspection output, it is nice to have the name of implicit array types be recognizable as arrays of the underlying type. However, while this allows humans to skip from a command with return type "[123]" straight to the definition of type "123" without having to fi

[Qemu-devel] [PATCH RFC v4 00/29] qapi-ify netdev_add, and other post-introspection cleanups

2015-09-09 Thread Eric Blake
Still RFC because it depends on Markus' RFC v5 (actually his qapi-introspect branch at commit 87e905b): https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01599.html v1 was here: https://lists.gnu.org/archive/html/qemu-devel/2015-07/msg05266.html https://lists.gnu.org/archive/html/qemu-devel

Re: [Qemu-devel] [PATCH 5/7] vhost_net: move vhost_net_set_vq_index ahead at vhost_net_init

2015-09-09 Thread Yuanhan Liu
On Thu, Sep 10, 2015 at 11:14:27AM +0800, Jason Wang wrote: > > > On 09/08/2015 03:38 PM, Yuanhan Liu wrote: > > So that we could use the `vq_index' as well in the vhost_net_init > > stage, which is required when adding vhost-user multiple-queue support, > > where we need the vq_index to indicate

Re: [Qemu-devel] qmp_device_add() ret_data argument

2015-09-09 Thread Eric Blake
On 09/09/2015 09:08 PM, Programmingkid wrote: > What does the function qmp_device_add() have a ret_data argument if it isn't > used? This function is located in qdev-monitor.c. [meta-comment - can you teach your mailer to wrap long lines? It's a pain to reply to something that scrolls off the scr

[Qemu-devel] Status of auto-generated ID feature

2015-09-09 Thread Programmingkid
I was just wondering if there were any patches accepted for the auto-generated ID feature that was talked about a week ago.

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-09 Thread Programmingkid
Does this look about right? QDict *qdict; Error *errp; QObject **ret_data; static int counter; char *idString, *fileName; // The file variable is objective-c, left that code out fileName = g_strdup_printf("%s", [file cStringUsingEnc

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Andrew Fish
> On Sep 9, 2015, at 5:41 PM, Jordan Justen wrote: > > On 2015-09-09 16:05:20, Andrew Fish wrote: >> >>> On Sep 9, 2015, at 3:24 PM, Jordan Justen wrote: >>> >>> On 2015-09-09 12:11:26, El-Haj-Mahmoud, Samer wrote: The recent expansions beyond BSD where all permissive licenses (BSD

Re: [Qemu-devel] [PATCH v4 29/38] blockdev: Add blockdev-insert-medium

2015-09-09 Thread Wen Congyang
On 09/09/2015 08:59 PM, Max Reitz wrote: > On 09.09.2015 12:01, Wen Congyang wrote: >> On 09/09/2015 05:20 AM, Max Reitz wrote: >>> On 08.09.2015 11:13, Wen Congyang wrote: On 07/21/2015 01:45 AM, Max Reitz wrote: > And a helper function for that, which directly takes a pointer to the

Re: [Qemu-devel] [PATCH 5/7] vhost_net: move vhost_net_set_vq_index ahead at vhost_net_init

2015-09-09 Thread Jason Wang
On 09/08/2015 03:38 PM, Yuanhan Liu wrote: > So that we could use the `vq_index' as well in the vhost_net_init > stage, which is required when adding vhost-user multiple-queue support, > where we need the vq_index to indicate which queue pair we are gonna > initiate. > > vhost-user has no multipl

[Qemu-devel] qmp_device_add() ret_data argument

2015-09-09 Thread Programmingkid
What does the function qmp_device_add() have a ret_data argument if it isn't used? This function is located in qdev-monitor.c.

Re: [Qemu-devel] [PATCH v2] spapr_drc: don't allow 'empty' DRCs to be unisolated

2015-09-09 Thread Michael Roth
Quoting David Gibson (2015-09-09 20:18:01) > On Wed, Sep 09, 2015 at 12:19:22PM -0500, Michael Roth wrote: > > Quoting David Gibson (2015-09-08 23:10:41) > > > On Tue, Sep 08, 2015 at 06:44:55PM -0500, Michael Roth wrote: > > > > Logical resources start with allocation-state:UNUSABLE / > > > > isol

Re: [Qemu-devel] [PATCH qemu v2 2/2] spapr_pci: Remove constraints about VFIO-PCI devices

2015-09-09 Thread Alex Williamson
On Thu, 2015-09-03 at 14:40 +1000, Alexey Kardashevskiy wrote: > So far there were 2 limitations enforced on an emulated PHB > regarding VFIO: > 1) only one IOMMU group per IOMMU container was allowed and > the spapr-pci-vfio-host-bridge device has an IOMMU ID property for this; > 2) only one IOMMU

Re: [Qemu-devel] [PATCH] spapr: Reduce advertised max LUNs for spapr_vscsi

2015-09-09 Thread David Gibson
On Wed, Sep 09, 2015 at 09:29:18AM +0200, Thomas Huth wrote: > On 09/09/15 09:19, David Gibson wrote: > > On Wed, Sep 09, 2015 at 08:25:34AM +0200, Thomas Huth wrote: > >> On 09/09/15 03:22, David Gibson wrote: > >>> The implementation of the PAPR paravirtual SCSI adapter currently > >>> allows up

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-09 Thread Chen, Tiejun
On 9/10/2015 12:10 AM, Stefano Stabellini wrote: On Wed, 9 Sep 2015, Stefano Stabellini wrote: On Tue, 8 Sep 2015, Peter Maydell wrote: > On 8 September 2015 at 18:21, Stefano Stabellini > wrote: > > The following changes since commit 8611280505119e296757a60711a881341603fa5a: > > > > target-m

Re: [Qemu-devel] [PATCH v2] spapr_drc: don't allow 'empty' DRCs to be unisolated

2015-09-09 Thread David Gibson
On Wed, Sep 09, 2015 at 12:19:22PM -0500, Michael Roth wrote: > Quoting David Gibson (2015-09-08 23:10:41) > > On Tue, Sep 08, 2015 at 06:44:55PM -0500, Michael Roth wrote: > > > Logical resources start with allocation-state:UNUSABLE / > > > isolation-state:ISOLATED. During hotplug, guests will tra

Re: [Qemu-devel] [PATCH v4 29/38] blockdev: Add blockdev-insert-medium

2015-09-09 Thread Wen Congyang
On 09/09/2015 08:59 PM, Max Reitz wrote: > On 09.09.2015 12:01, Wen Congyang wrote: >> On 09/09/2015 05:20 AM, Max Reitz wrote: >>> On 08.09.2015 11:13, Wen Congyang wrote: On 07/21/2015 01:45 AM, Max Reitz wrote: > And a helper function for that, which directly takes a pointer to the

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-09 Thread Chen, Tiejun
On 9/9/2015 9:06 PM, Stefano Stabellini wrote: On Tue, 8 Sep 2015, Peter Maydell wrote: On 8 September 2015 at 18:21, Stefano Stabellini wrote: > The following changes since commit 8611280505119e296757a60711a881341603fa5a: > > target-microblaze: Use setcond for pcmp* (2015-09-08 08:49:33 +020

Re: [Qemu-devel] [PATCH] cpu: introduce CpuTopoInfo structure for argument simplification

2015-09-09 Thread Zhu Guihua
On 09/10/2015 12:11 AM, Eduardo Habkost wrote: On Mon, Sep 07, 2015 at 04:22:10PM +0200, Andreas Färber wrote: Am 07.09.2015 um 13:29 schrieb Paolo Bonzini: On 21/08/2015 11:34, Zhu Guihua wrote: @@ -107,14 +111,12 @@ static inline apic_id_t apicid_from_topo_ids(unsigned nr_cores, static i

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Jordan Justen
On 2015-09-09 16:05:20, Andrew Fish wrote: > > > On Sep 9, 2015, at 3:24 PM, Jordan Justen wrote: > > > > On 2015-09-09 12:11:26, El-Haj-Mahmoud, Samer wrote: > >> The recent expansions beyond BSD where all permissive licenses (BSD > >> like) as far as I can tell. > >> > >> I agree with Andrew,

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-09 Thread Programmingkid
On Sep 9, 2015, at 6:31 PM, Eric Blake wrote: > On 09/09/2015 04:25 PM, Eric Blake wrote: > >>> That leaves QMP. I am trying to figure it out. This is my attempt so far: >>> >>> Error **errp; >>> char *commandBuffer; >>> commandBuffer = g_strdup_printf("{ \"execute\": \"quit\" }"); >>> qmp_quer

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-09 Thread Programmingkid
On Sep 9, 2015, at 6:25 PM, Eric Blake wrote: > On 09/09/2015 03:37 PM, Programmingkid wrote: > >> >> Thank you very much for caring. I appreciate all the help I can receive. I >> so like my idea of >> sending a command to QEMU as if the user typed it himself. It is so easy to >> maintain. So

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread El-Haj-Mahmoud, Samer
Adding back edk2-devel that got accidently dropped I am against putting any GPL licensed code in EDK2. Having it live in a separate repo and pulling an additional package from that repo is fine. But the main EDK2 repo needs to stay GPL-free. Thanks, --Samer -Original Message- From: a

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Andrew Fish
> On Sep 9, 2015, at 3:24 PM, Jordan Justen wrote: > > On 2015-09-09 12:11:26, El-Haj-Mahmoud, Samer wrote: >> The recent expansions beyond BSD where all permissive licenses (BSD >> like) as far as I can tell. >> >> I agree with Andrew, opening the door for GPL licensed code in EDK2 >> will hav

Re: [Qemu-devel] [Xen-devel] OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Laszlo Ersek
On 09/09/15 18:34, Ian Campbell wrote: > On Wed, 2015-09-09 at 10:57 +0200, Laszlo Ersek wrote: >> On 08/10/15 18:24, Laszlo Ersek wrote: >>> Hi. >>> >>> Let's do an OVMF BoF at this year's KVM Forum too. >> >> Here's a preliminary task list > > Thanks for including xen-devel in this. Was anyone f

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-09 Thread Eric Blake
On 09/09/2015 04:25 PM, Eric Blake wrote: >> That leaves QMP. I am trying to figure it out. This is my attempt so far: >> >> Error **errp; >> char *commandBuffer; >> commandBuffer = g_strdup_printf("{ \"execute\": \"quit\" }"); >> qmp_query_command_line_options(false, commandBuffer, errp); >> prin

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Andrew Fish
> On Sep 9, 2015, at 10:57 AM, Jordan Justen wrote: > > On 2015-09-09 10:04:50, Andrew Fish wrote: >> >>> On Sep 9, 2015, at 9:17 AM, Jordan Justen wrote: >>> >>> So, related to this, I wonder how the community would feel about a >>> GplDriverPkg. Would the community allow it as a new package

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-09 Thread Eric Blake
On 09/09/2015 03:37 PM, Programmingkid wrote: >> On 2 September 2015 at 01:56, Programmingkid >> wrote: It's okay to trim your reply, to make it easier for others to quickly skip to the relevant part of your emails. > > Thank you very much for caring. I appreciate all the help I can r

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Jordan Justen
On 2015-09-09 12:11:26, El-Haj-Mahmoud, Samer wrote: > The recent expansions beyond BSD where all permissive licenses (BSD > like) as far as I can tell. > > I agree with Andrew, opening the door for GPL licensed code in EDK2 > will have severe consequences for products that are built using > EDK2.

Re: [Qemu-devel] [PATCH 2/2] tests: add a local test for guest agent

2015-09-09 Thread Michael Roth
Quoting marcandre.lur...@redhat.com (2015-08-27 05:52:07) > From: Marc-André Lureau > > Add some local guest agent tests (as it is better than nothing). > > They can be run inside or outside a VM, when run inside a VM, they will > do a bit more side effects, such as freezing/thawing the FS or ch

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Add Mount image file menu item

2015-09-09 Thread Programmingkid
On Sep 9, 2015, at 3:29 AM, Markus Armbruster wrote: > Programmingkid writes: > >> On Sep 8, 2015, at 2:46 PM, Markus Armbruster wrote: >> >>> Programmingkid writes: >>> On Sep 8, 2015, at 12:17 PM, Peter Maydell wrote: > On 2 September 2015 at 01:56, Programmingkid > wro

Re: [Qemu-devel] [PATCH 0/2] ACPI/arm-virt: add DBG2

2015-09-09 Thread Al Stone
On 09/08/2015 11:52 PM, Andrew Jones wrote: > On Wed, Sep 09, 2015 at 12:25:45PM +0800, Shannon Zhao wrote: >> >> >> On 2015/9/8 21:04, Leif Lindholm wrote: >>> On Tue, Sep 08, 2015 at 11:18:27AM +0800, Shannon Zhao wrote: On 2015/9/7 22:23, Leif Lindholm wrote: > The Debug Port Table 2 (D

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] spapr: Add support for hwrng when available

2015-09-09 Thread Thomas Huth
On 08/09/15 07:15, David Gibson wrote: > On Tue, Sep 08, 2015 at 03:03:16PM +1000, Sam Bobroff wrote: >> On Tue, Sep 01, 2015 at 12:53:26PM +0200, Thomas Huth wrote: >>> On 01/09/15 02:38, David Gibson wrote: On Mon, Aug 31, 2015 at 08:46:01PM +0200, Thomas Huth wrote: > From: Michael Elle

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-09 Thread Michael S. Tsirkin
On Tue, Sep 08, 2015 at 03:38:46PM +0800, Yuanhan Liu wrote: > From: Ouyang Changchun > > This patch is initially based a patch from Nikolay Nikolaev. > > Here is the latest version for adding vhost-user multiple queue support, > by creating a nc and vhost_net pair for each queue. > > What diff

Re: [Qemu-devel] [PATCH 7/7] vhost-user: add a new message to disable/enable a specific virt queue.

2015-09-09 Thread Michael S. Tsirkin
On Wed, Sep 09, 2015 at 09:38:12PM +0800, Yuanhan Liu wrote: > On Wed, Sep 09, 2015 at 01:45:50PM +0300, Michael S. Tsirkin wrote: > > On Tue, Sep 08, 2015 at 03:38:47PM +0800, Yuanhan Liu wrote: > > > From: Changchun Ouyang > > > > > > Add a new message, VHOST_USER_SET_VRING_FLAG, to enable and

Re: [Qemu-devel] [PATCH] hw/misc: Add support for ADC controller in Xilinx Zynq 7000

2015-09-09 Thread Peter Crosthwaite
On Wed, Aug 12, 2015 at 2:33 PM, Guenter Roeck wrote: > Add support for the Xilinx XADC core used in Zynq 7000. > > References: > - Zynq-7000 All Programmable SoC Technical Reference Manual > - 7 Series FPGAs and Zynq-7000 All Programmable SoC XADC > Dual 12-Bit 1 MSPS Analog-to-Digital Converte

[Qemu-devel] [PATCH v4 1/3] i.MX: Add GPIO device

2015-09-09 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since V1: * added "has-edge-sel" property . * use extract64() and deposit64() in read/write icr access. * set "number of GPIO pin" as a #define. * reorganize functions in file to group them. * various codi

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread Paolo Bonzini
Well, FatPkg is only superficially permissive and not even open source, so there is a precedent. (A precedent that, I might add, happens to violate SourceForge's the off service). When we import edk2 into Fedora we just remove FatBinPkg. We would think twice before contributing to it, but do no

Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules

2015-09-09 Thread Paolo Bonzini
On 09/09/2015 19:22, Peter Maydell wrote: > On 7 September 2015 at 18:05, Markus Armbruster wrote: >> Paolo Bonzini writes: >>> That said, and even though Thomas obviously hasn't read the previous >>> discussion, :) I do believe that 76 characters is too strict a limit. >> >> It's not a strict

[Qemu-devel] [PATCH v4 0/3] i.MX: Add GPIO devices to i.MX SOC

2015-09-09 Thread Jean-Christophe Dubois
Add GPIO devices to i.MX31 and i.MX25 SOC Jean-Christophe Dubois (3): i.MX: Add GPIO device i.MX: Add GPIO devices to i.MX31 SOC i.MX: Add GPIO devices to i.MX25 SOC hw/arm/fsl-imx25.c | 29 hw/arm/fsl-imx31.c | 30 hw/gpio/Makefile.objs | 1 + hw/gpio/im

Re: [Qemu-devel] [edk2] EDK II & GPL - Re: OVMF BoF @ KVM Forum 2015

2015-09-09 Thread El-Haj-Mahmoud, Samer
The recent expansions beyond BSD where all permissive licenses (BSD like) as far as I can tell. I agree with Andrew, opening the door for GPL licensed code in EDK2 will have severe consequences for products that are built using EDK2. -Original Message- From: edk2-devel [mailto:edk2-d

Re: [Qemu-devel] [PATCH 1/1] block/gluster: add support for multiple gluster backup volfile servers

2015-09-09 Thread Raghavendra Talur
On Wed, Sep 9, 2015 at 5:59 PM, Stefan Hajnoczi wrote: > On Wed, Sep 9, 2015 at 11:19 AM, Deepak C Shetty > wrote: > > On 09/09/2015 03:16 PM, Stefan Hajnoczi wrote: > >> On Tue, Sep 08, 2015 at 08:40:58PM +0530, Deepak Shetty wrote: > >>> On Tue, Sep 8, 2015 at 8:32 PM, Daniel P. Berrange < > b

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-09-09 Thread Jason Dillaman
>> Bumping this... >> >> For now, we are rarely suffering with an unlimited cache growth issue >> which can be observed on all post-1.4 versions of qemu with rbd >> backend in a writeback mode and certain pattern of a guest operations. >> The issue is confirmed for virtio and can be re-triggered by

Re: [Qemu-devel] [PATCH 2/2] pc: memhotplug: keep reserved-memory-end broken on 2.4 and earlier machines

2015-09-09 Thread Eduardo Habkost
On Mon, Sep 07, 2015 at 01:55:32PM +0200, Igor Mammedov wrote: > it will prevent guests on old machines from seeing > inconsistent memory mapping in firmware/ACPI views. > > Signed-off-by: Igor Mammedov > --- > PS: this patch probably clashes with Eduardo's > pc_compat refactoring, so I've sp

[Qemu-devel] [PATCH v4 3/3] i.MX: Add GPIO devices to i.MX25 SOC

2015-09-09 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * various coding style cleanup Changes since v2: * no change. Changes since v3: * no change. hw/arm/fsl-imx25.c | 29 + include/hw/arm/fsl-imx25.h | 15 +

[Qemu-devel] [PATCH v4 2/3] i.MX: Add GPIO devices to i.MX31 SOC

2015-09-09 Thread Jean-Christophe Dubois
Signed-off-by: Jean-Christophe Dubois Reviewed-by: Peter Crosthwaite --- Changes since v1: * Use "has-edge-sel" property for i.MX31 * various coding style cleanup Changes since v2: * failing to set "has-edge-sel" is fatal. Changes since v3: * no change. hw/arm/fsl-imx31.c |

Re: [Qemu-devel] [PATCH 1/2] qtest: add a few fd-level qmp helpers

2015-09-09 Thread Michael Roth
Quoting marcandre.lur...@redhat.com (2015-08-27 05:52:06) > From: Marc-André Lureau > > Add a few functions to interact with qmp via a simple fd. > > Signed-off-by: Marc-André Lureau Reviewed-by: Michael Roth > --- > tests/libqtest.c | 45 + > tes

Re: [Qemu-devel] Mac OS 9 updates

2015-09-09 Thread Programmingkid
On Sep 9, 2015, at 4:03 PM, Mark Cave-Ayland wrote: > On 08/09/15 16:27, Programmingkid wrote: > >> Are we going to see any more GSoC 2015 updates? > > GSoC is now in the "pens down" phase although I believe we're currently > waiting on Cormac to resubmit the patchset with the appropriate SoBs

Re: [Qemu-devel] [PATCH 2/2] tests: add a local test for guest agent

2015-09-09 Thread Michael Roth
Quoting Marc-André Lureau (2015-08-27 06:36:43) > On Thu, Aug 27, 2015 at 12:52 PM, wrote: > > +success = success && status == 0 && g_strcmp0(virt_what, virt); > > this is now: > g_strcmp0(g_strstrip(virt_what), virt) == 0 Just to be sure, is this the change you intended? diff --git a/test

Re: [Qemu-devel] [PATCH v2] spapr_drc: don't allow 'empty' DRCs to be unisolated

2015-09-09 Thread Michael Roth
Quoting David Gibson (2015-09-08 23:10:41) > On Tue, Sep 08, 2015 at 06:44:55PM -0500, Michael Roth wrote: > > Logical resources start with allocation-state:UNUSABLE / > > isolation-state:ISOLATED. During hotplug, guests will transition > > them to allocate-state:USABLE, and then to isolate-state:U

Re: [Qemu-devel] Mac OS 9 updates

2015-09-09 Thread Mark Cave-Ayland
On 08/09/15 16:27, Programmingkid wrote: > Are we going to see any more GSoC 2015 updates? GSoC is now in the "pens down" phase although I believe we're currently waiting on Cormac to resubmit the patchset with the appropriate SoBs... ATB, Mark.

Re: [Qemu-devel] [PATCH 1/2] pc: memhotplug: fix incorrectly set reserved-memory-end

2015-09-09 Thread Eduardo Habkost
On Mon, Sep 07, 2015 at 01:55:31PM +0200, Igor Mammedov wrote: > reserved-memory-end tells firmware address from which > it could start treating memory as PCI address space > and map PCI BARs after it to avoid collisions with > RAM. > Currently it is incorrectly pointing to address where > hotplugg

Re: [Qemu-devel] [PATCH v3 1/3] i.MX: Add GPIO device

2015-09-09 Thread Jean-Christophe DUBOIS
Le 09/09/2015 09:09, Peter Crosthwaite a écrit : On Tue, Sep 8, 2015 at 5:38 PM, Jean-Christophe Dubois wrote: Signed-off-by: Jean-Christophe Dubois --- Changes since V1: * added "has-edge-sel" property * use extract64() and deposit64() in read/write icr access * set "number of GPIO

Re: [Qemu-devel] [PULL 00/43] First batch of misc changes for 2.5 (2015-09-09)

2015-09-09 Thread Paolo Bonzini
I will add a patch to detect the invalid sequences, as the OS X behavior seems preferable. Something like returning -EINVAL if result == 0 && (endptr == p || endptr[-1] != '0'). Nice to have the testcases. And I thought I had tested this pull request really a lot. :-) Paolo -Original Mess

Re: [Qemu-devel] [PATCH 2/4] CODING_STYLE, checkpatch: update line length rules

2015-09-09 Thread Eduardo Habkost
On Wed, Sep 09, 2015 at 06:22:15PM +0100, Peter Maydell wrote: > On 7 September 2015 at 18:05, Markus Armbruster wrote: > > Paolo Bonzini writes: > >> That said, and even though Thomas obviously hasn't read the previous > >> discussion, :) I do believe that 76 characters is too strict a limit. >

  1   2   3   4   >