Re: [Qemu-devel] [PATCH] target-arm: Break the TB after IC invalidation to execute self-modified code correctly

2015-08-27 Thread Sergey Sorokin
27.08.2015, 19:54, "Peter Maydell" : > On 26 August 2015 at 12:36, Sergey Sorokin wrote: >>  If any store instruction writes the code inside the same TB >>  after this store insn, the execution of the TB must be stopped >>  to execute new code correctly. >>  As described in ARMv8 manual D3.4.6 a s

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-27 Thread Pierre Schweitzer
Tested 2.0.0+dfsg-2ubuntu1.18. Cannot reproduce the issue. TEST CASE 1: Attempt several times to copy files on a VDI disk, and couldn't trigger any corruption (nor deadlock - no regression). Given my test scenario, previously, I would already have hit the corruption. TEST CASE 2: Tested with t

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-27 Thread Pierre Schweitzer
** Tags removed: verification-needed ** Tags added: verification-done -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1422307 Title: qemu-nbd corrupts files Status in QEMU: Fix Released Status in

Re: [Qemu-devel] [PATCH v2 0/4] acpi: xsdt support

2015-08-27 Thread Laszlo Ersek
On 08/27/15 19:58, Michael S. Tsirkin wrote: > On Thu, Aug 27, 2015 at 04:27:00PM +0200, Laszlo Ersek wrote: >> On 06/09/15 16:05, Michael S. Tsirkin wrote: >>> On Tue, Jun 09, 2015 at 04:02:08PM +0200, Laszlo Ersek wrote: On 06/09/15 11:49, Michael S. Tsirkin wrote: > On Tue, Jun 09, 2015

Re: [Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-08-27 Thread Richard Henderson
On 08/27/2015 04:47 PM, Andreas Färber wrote: The argument order for the !CONFIG_SOFTMMU case was jumbled up since ffc6372851d8631a9f9fa56ec613b3244dc635b9 ("tcg/aarch64: use 32-bit offset for 32-bit user-mode emulation"), regressing from -rc2 to v2.4.0. Fix their order to avoid segfaults, e.g.,

Re: [Qemu-devel] [PATCH v2 0/9] tcg: signal-free qemu_cpu_kick

2015-08-27 Thread Richard Henderson
On 08/25/2015 05:17 PM, Paolo Bonzini wrote: This version of the signal-free qemu_cpu_kick patches is, ehm, much better. Variable are accessed either with Java-style volatiles or protected by memory barriers, and the cleanups go further by removing qemu/tls.h and C volatiles. The logic is relat

Re: [Qemu-devel] [PATCH 0/8] Disas QOMification, round 2

2015-08-27 Thread Richard Henderson
On 08/27/2015 03:47 PM, Andreas Färber wrote: Am 12.07.2015 um 06:18 schrieb Andreas Färber: Am 12.07.2015 um 03:59 schrieb Peter Crosthwaite: Continue QOMifying target-specific disassembly. Convert all arches except for X86 and PPC. They will be round 3 and are non-trivial. This brings us clo

[Qemu-devel] [PATCH v3] sheepdog: add reopen support

2015-08-27 Thread Liu Yuan
From: Liu Yuan With reopen supported, block-commit (and offline commit) is now supported for image files whose base image uses the Sheepdog protocol driver. Cc: qemu-devel@nongnu.org Cc: Jeff Cody Cc: Kevin Wolf Cc: Stefan Hajnoczi Signed-off-by: Liu Yuan --- v3: - init cache flags in sd_re

Re: [Qemu-devel] [PATCH 1/2] memory: allow zero size for adjust_endianness()

2015-08-27 Thread Jason Wang
On 08/27/2015 09:10 PM, Greg Kurz wrote: > On Thu, 27 Aug 2015 15:30:55 +0300 > "Michael S. Tsirkin" wrote: > >> On Thu, Aug 27, 2015 at 01:27:54PM +0100, Peter Maydell wrote: >>> On 27 August 2015 at 13:25, Michael S. Tsirkin wrote: On Thu, Aug 27, 2015 at 01:20:52PM +0100, Peter Maydell

Re: [Qemu-devel] [PATCH 0/3] pc-*-2.5 machine-types

2015-08-27 Thread Jason Wang
On 08/28/2015 03:48 AM, Eduardo Habkost wrote: > This introduces the pc-q35-2.5 and pc-i440fx-2.5 machine-types. > > Jason Wang, I know you were going to do it as part of the virtio pci work, but > I would like to simplify the existing code before introducing the new machine. > Feel free to inclu

Re: [Qemu-devel] [PATCH 6/9] tcg: synchronize cpu->exit_request and cpu->tcg_exit_req accesses

2015-08-27 Thread Emilio G. Cota
On Wed, Aug 26, 2015 at 02:17:42 +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > cpu-exec.c | 6 +- > qom/cpu.c | 2 ++ > 2 files changed, 7 insertions(+), 1 deletion(-) I like this patch. Are we making sure that other writes to tcg_exit_req are preceded by a write barri

Re: [Qemu-devel] [snabb-devel] Re: [PATCH v6 1/2] vhost-user: add multi queue support

2015-08-27 Thread Ouyang, Changchun
Hi Michael, Thanks for your response! > -Original Message- > From: snabb-de...@googlegroups.com [mailto:snabb- > de...@googlegroups.com] On Behalf Of Michael S. Tsirkin > Sent: Thursday, August 27, 2015 9:05 PM > To: Ouyang, Changchun > Cc: snabb-de...@googlegroups.com; qemu-devel@nongnu.

Re: [Qemu-devel] [PATCH v2] sheepdog: add reopen support

2015-08-27 Thread Liu Yuan
On Thu, Aug 27, 2015 at 03:00:32PM -0400, Jeff Cody wrote: > On Thu, Aug 27, 2015 at 10:54:01AM +0800, Liu Yuan wrote: > > From: Liu Yuan > > > > With reopen supported, block-commit (and offline commit) is now supported > > for > > image files whose base image uses the Sheepdog protocol driver.

Re: [Qemu-devel] add multiple times opening support to a virtserialport

2015-08-27 Thread Asias He
Hello Christoffer, On Fri, Aug 28, 2015 at 2:30 AM, Christoffer Dall wrote: > On Thu, Aug 27, 2015 at 10:23:38AM -0400, Christopher Covington wrote: >> On 07/24/2015 08:00 AM, Matt Ma wrote: >> > Hi all, >> > >> > Linaro has developed the foundation for the new Android Emulator code >> > base bas

Re: [Qemu-devel] [PATCH v2] monitor: allow object_del & device_del to accept QOM paths

2015-08-27 Thread Gonglei
On 2015/8/28 0:13, Daniel P. Berrange wrote: > Currently both object_del and device_del require that the > client provide the object/device short ID. While user > creatable objects require an ID to be provided at time of > creation, qdev devices may be created without giving an > ID. The only uniqu

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-27 Thread Josh Durgin
On 08/27/2015 09:49 AM, Stefan Hajnoczi wrote: On Mon, Aug 25, 2014 at 03:50:02PM -0600, Chris Friesen wrote: The only limit I see in the whole call chain from virtio_blk_handle_request() on down is the call to bdrv_io_limits_intercept() in bdrv_co_do_writev(). However, that doesn't provide any

Re: [Qemu-devel] [PATCH] monitor: allow object_del & device_del to accept QOM paths

2015-08-27 Thread Gonglei
On 2015/8/27 23:37, Daniel P. Berrange wrote: > Currently both object_del and device_del require that the > client provide the object/device short ID. While user > creatable objects require an ID to be provided at time of > creation, qdev devices may be created without giving an > ID. The only uniq

Re: [Qemu-devel] [PATCH v4 2/4] ahci.c: Don't assume AHCIState's parent is AHCIPCIState

2015-08-27 Thread Peter Crosthwaite
On Thu, Aug 27, 2015 at 5:16 PM, Alistair Francis wrote: > The AHCIState struct can either have AHCIPCIState or SysbusAHCIState > as a parent. The ahci_irq_lower() and ahci_irq_raise() functions > assume that it is always AHCIPCIState, which is not always the > case, which causes a seg fault. Veri

[Qemu-devel] [PATCH v4 2/4] ahci.c: Don't assume AHCIState's parent is AHCIPCIState

2015-08-27 Thread Alistair Francis
The AHCIState struct can either have AHCIPCIState or SysbusAHCIState as a parent. The ahci_irq_lower() and ahci_irq_raise() functions assume that it is always AHCIPCIState, which is not always the case, which causes a seg fault. Verify what the container of AHCIState is before setting the PCIDevice

[Qemu-devel] [PATCH v4 3/4] xlnx-zynqmp.c: Convert some of the error_propagate() calls to error_abort

2015-08-27 Thread Alistair Francis
Convert all of the non-realize error_propagate() calls into error_abort calls as they shouldn't be user visible failure cases. Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite --- hw/arm/xlnx-zynqmp.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff

[Qemu-devel] [PATCH v4 1/4] ahci: Separate the AHCI state structure into the header

2015-08-27 Thread Alistair Francis
Pull the AHCI state structure out into the header. This allows other containers to access the struct. This is required to add the device to modern SoC containers. Signed-off-by: Alistair Francis Reviewed-by: Sai Pavan Boddu Reviewed-by: Peter Crosthwaite --- hw/ide/ahci.c | 13 -

[Qemu-devel] [PATCH v4 0/4] xlnx-zynqmp: Connect the AHCI SATA device

2015-08-27 Thread Alistair Francis
This series connects the AHCI SATA device to the ZynqMP machine. It requires a restructure of the AHCI file to make the AHCI state struct visible. It also requires a small change to the ahci_irq_lower() and ahci_irq_raise() functions to avoid assuming that the AHCIState is a child of AHCIPCIState.

[Qemu-devel] [PATCH 3/4] build: qemu-ga: fix VSS dependencies

2015-08-27 Thread Michael Roth
Currently VSS dll/tlb files for use in w32 builds are only built as a result of having been added to the general 'tools' target alongside qemu-ga. This is fine for default make target, but if we build qemu-ga directly via `make qemu-ga.exe`, the VSS files are not created. Fix this by moving the VS

[Qemu-devel] [PATCH 4/4] Makefile: qemu-ga: fix msi target error message

2015-08-27 Thread Michael Roth
'msi' target reports error if we attempt to use it when QEMU hasn't been ./configure'd to enable it. The parenthesis cause an interpreter error if we don't enclose the error in quotes. Reviewed-by: Marc-André Lureau Signed-off-by: Michael Roth --- Makefile | 2 +- 1 file changed, 1 insertion(+)

[Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed

2015-08-27 Thread Michael Roth
Currently, if we don't explicitly disable support for MSI installer via --disable-guest-agent-msi, the configure variable that tracks the flag, 'guest_agent_msi', never gets set unless one of the probes fails. Subsequent code then treats this unset value the same as if it were a "yes" value (via !=

[Qemu-devel] [PATCH v2 0/4] qemu-ga: various w32 build fix-ups for MSI/VSS support

2015-08-27 Thread Michael Roth
These patches are based on the qga tree: https://github.com/mdroth/qemu/commits/qga and are also available from: https://github.com/mdroth/qemu/commits/qga-dev-build-fixes These are minor fixes/refactorings to improve the build process for qemu-ga. v2: * filter $(QGA_VSS_PROVIDER) from qemu-g

[Qemu-devel] [PATCH 1/4] configure: qemu-ga: move MSI installer probe after qga probe

2015-08-27 Thread Michael Roth
MSI probe assumes that qemu-ga support has been probed already, but in cases where --enable-guest-agent/--disable-guest-agent have not been passed to configure, qemu-ga support may end up getting enabled later, as is the case with w32 builds. This leads to MSI probe prematurely reporting error due

Re: [Qemu-devel] [PATCH v4 00/13] qemu-ga: add a configuration file

2015-08-27 Thread Michael Roth
Quoting marcandre.lur...@redhat.com (2015-08-26 18:34:46) > From: Marc-André Lureau > > Hi, > > The following patches for the qemu agent add support for an optionnal > configuration file, and a man page. > > v3->v4: > - some spelling fixes > - add a patch to allocate in split_list() > - add mor

Re: [Qemu-devel] [PATCH] qemu-ga: implement win32 guest-set-user-password

2015-08-27 Thread Michael Roth
Quoting Marc-André Lureau (2015-06-30 09:37:13) > Use NetUserSetInfo() to set the user password. > > This function is notoriously known to be problematic for users with EFS > encrypted files. But the alternative, NetUserChangePassword() requires > the old password. Nevertheless, The EFS file shoul

[Qemu-devel] [PATCH] tcg/aarch64: Fix tcg_out_qemu_{ld, st} for linux-user

2015-08-27 Thread Andreas Färber
The argument order for the !CONFIG_SOFTMMU case was jumbled up since ffc6372851d8631a9f9fa56ec613b3244dc635b9 ("tcg/aarch64: use 32-bit offset for 32-bit user-mode emulation"), regressing from -rc2 to v2.4.0. Fix their order to avoid segfaults, e.g., in openSUSE's GNU coreutils 8.24. Cc: Paolo Bon

Re: [Qemu-devel] [PATCH v3 2/4] ahci.c: Don't assume AHCIState's parent is AHCIPCIState

2015-08-27 Thread Peter Crosthwaite
On Thu, Aug 27, 2015 at 3:58 PM, Alistair Francis wrote: > () > > On Thu, Aug 27, 2015 at 3:36 PM, Peter Crosthwaite > wrote: >> On Thu, Aug 27, 2015 at 3:06 PM, Alistair Francis >> wrote: >>> On Thu, Aug 27, 2015 at 2:28 PM, Peter Crosthwaite >>> wrote: On Thu, Aug 27, 2015 at 1:47 PM, Al

[Qemu-devel] [PATCH v2] qdev-monitor.c: Add device id generation

2015-08-27 Thread Programmingkid
Add device ID generation to each device if an ID isn't given. An auto-generated ID will begin with an underscore character. This will distinguish it from user-made ID's. An user-made ID cannot begin with an underscore, so there is no problem of collisions with auto-generated ID's. A management

Re: [Qemu-devel] [PATCH v3 2/4] ahci.c: Don't assume AHCIState's parent is AHCIPCIState

2015-08-27 Thread Alistair Francis
() On Thu, Aug 27, 2015 at 3:36 PM, Peter Crosthwaite wrote: > On Thu, Aug 27, 2015 at 3:06 PM, Alistair Francis > wrote: >> On Thu, Aug 27, 2015 at 2:28 PM, Peter Crosthwaite >> wrote: >>> On Thu, Aug 27, 2015 at 1:47 PM, Alistair Francis >>> wrote: The AHCIState strucut can either have

[Qemu-devel] [Bug 1422307] Re: qemu-nbd corrupts files

2015-08-27 Thread Brian Murray
Hello Pierre, or anyone else affected, Accepted qemu into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/qemu/2.0.0+dfsg- 2ubuntu1.18 in a few hours, and then in the -proposed repository. Please help us by testing this new package. See https:

Re: [Qemu-devel] [PATCH 0/8] Disas QOMification, round 2

2015-08-27 Thread Andreas Färber
Am 12.07.2015 um 06:18 schrieb Andreas Färber: > Am 12.07.2015 um 03:59 schrieb Peter Crosthwaite: >> Continue QOMifying target-specific disassembly. Convert all arches except for >> X86 and PPC. They will be round 3 and are non-trivial. >> >> This brings us close to no arch-specific code in disas.

Re: [Qemu-devel] [PATCH v3 1/2] Use help sub-sections to create sub-help options

2015-08-27 Thread Eric Blake
On 08/27/2015 04:22 PM, Laurent Vivier wrote: > As '-help' output is 400 lines long it is not easy > to find information, but generally we know from > which area we want the information. > > Signed-off-by: Laurent Vivier > --- > v3: add a 2nd patch to add an help section, -help displays only thi

Re: [Qemu-devel] [PATCH v3 2/4] ahci.c: Don't assume AHCIState's parent is AHCIPCIState

2015-08-27 Thread Peter Crosthwaite
On Thu, Aug 27, 2015 at 3:06 PM, Alistair Francis wrote: > On Thu, Aug 27, 2015 at 2:28 PM, Peter Crosthwaite > wrote: >> On Thu, Aug 27, 2015 at 1:47 PM, Alistair Francis >> wrote: >>> The AHCIState strucut can either have AHCIPCIState or SysbusAHCIState >> >> "struct" > > Good catch, will fix

[Qemu-devel] [PATCH] linux-user: add name_to_handle_at/open_by_handle_at

2015-08-27 Thread Laurent Vivier
This patch allows to run example given by open_by_handle_at(2): The following shell session demonstrates the use of these two programs: $ echo 'Can you please think about it?' > cecilia.txt $ ./t_name_to_handle_at cecilia.txt > fh $ ./t_open_by_handle_at < f

[Qemu-devel] [PATCH v3 1/2] Use help sub-sections to create sub-help options

2015-08-27 Thread Laurent Vivier
As '-help' output is 400 lines long it is not easy to find information, but generally we know from which area we want the information. As subsections already exist in the help description, add some command options to only display the wanted subsection. As more is better, this patch adds 13 lines

[Qemu-devel] [PATCH v3 2/2] -help lists only -help-* commands

2015-08-27 Thread Laurent Vivier
A slight change of behavior: -help-all displays all helps (like -help/-h before) -help/-h lists only the available help commands Signed-off-by: Laurent Vivier --- v3: add this patch to add an help section, -help displays only this section qemu-options.hx | 29 +--

Re: [Qemu-devel] [PATCH v3 2/4] ahci.c: Don't assume AHCIState's parent is AHCIPCIState

2015-08-27 Thread Alistair Francis
On Thu, Aug 27, 2015 at 2:28 PM, Peter Crosthwaite wrote: > On Thu, Aug 27, 2015 at 1:47 PM, Alistair Francis > wrote: >> The AHCIState strucut can either have AHCIPCIState or SysbusAHCIState > > "struct" Good catch, will fix > >> as a parent. The ahci_irq_lower() and ahci_irq_raise() functions

Re: [Qemu-devel] [PATCH v3 3/4] xlnx-zynqmp.c: Convert some of the error_propagate() calls to error_abort

2015-08-27 Thread Alistair Francis
On Thu, Aug 27, 2015 at 2:32 PM, Peter Crosthwaite wrote: > On Thu, Aug 27, 2015 at 1:47 PM, Alistair Francis > wrote: >> Convert all of the non-realize error_propagate() calls into error_abort >> calls as they shouldn't be user visible failure cases. >> >> Signed-off-by: Alistair Francis > > So

Re: [Qemu-devel] [PATCH v1 00/15] data-driven device registers

2015-08-27 Thread Alistair Francis
Ping! On Wed, Jul 29, 2015 at 1:24 PM, Alistair Francis wrote: > From Peter: > Hi All. This is a new scheme I've come up with handling device registers in a > data driven way. My motivation for this is to factor out a lot of the access > checking that seems to be replicated in every device. See P

Re: [Qemu-devel] [PATCH, RFC v2] Use help sub-sections to create sub-help options

2015-08-27 Thread Marc-André Lureau
Hi On Thu, Aug 27, 2015 at 7:07 PM, Laurent Vivier wrote: > As '-help' output is 400 lines long it is not easy > to find information, but generally we know from > which area we want the information. > > As subsections already exist in the help description, > add some command options to only displ

Re: [Qemu-devel] [PATCH v3 3/4] xlnx-zynqmp.c: Convert some of the error_propagate() calls to error_abort

2015-08-27 Thread Peter Crosthwaite
On Thu, Aug 27, 2015 at 1:47 PM, Alistair Francis wrote: > Convert all of the non-realize error_propagate() calls into error_abort > calls as they shouldn't be user visible failure cases. > > Signed-off-by: Alistair Francis So normally these are needed to catch bad usages of -cpu to CPUs that do

Re: [Qemu-devel] [PATCH v3 2/4] ahci.c: Don't assume AHCIState's parent is AHCIPCIState

2015-08-27 Thread Peter Crosthwaite
On Thu, Aug 27, 2015 at 1:47 PM, Alistair Francis wrote: > The AHCIState strucut can either have AHCIPCIState or SysbusAHCIState "struct" > as a parent. The ahci_irq_lower() and ahci_irq_raise() functions > assume that it is always AHCIPCIState, which is not always the > case, which causes a seg

[Qemu-devel] [PATCH v3 3/4] xlnx-zynqmp.c: Convert some of the error_propagate() calls to error_abort

2015-08-27 Thread Alistair Francis
Convert all of the non-realize error_propagate() calls into error_abort calls as they shouldn't be user visible failure cases. Signed-off-by: Alistair Francis --- hw/arm/xlnx-zynqmp.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/hw/arm/xlnx-zynqmp.c b/h

[Qemu-devel] [PATCH v3 0/4] xlnx-zynqmp: Connect the AHCI SATA device

2015-08-27 Thread Alistair Francis
This series connects the AHCI SATA device to the ZynqMP machine. It requires a restructure of the AHCI file to make the AHCI state struct visible. It also requires a small change to the ahci_irq_lower() and ahci_irq_raise() functions to avoid assuming that the AHCIState is a child of AHCIPCIState.

[Qemu-devel] [PATCH v3 2/4] ahci.c: Don't assume AHCIState's parent is AHCIPCIState

2015-08-27 Thread Alistair Francis
The AHCIState strucut can either have AHCIPCIState or SysbusAHCIState as a parent. The ahci_irq_lower() and ahci_irq_raise() functions assume that it is always AHCIPCIState, which is not always the case, which causes a seg fault. Verify what the container of AHCIState is before setting the PCIDevic

[Qemu-devel] [PATCH v3 1/4] ahci: Separate the AHCI state structure into the header

2015-08-27 Thread Alistair Francis
Pull the AHCI state structure out into the header. This allows other containers to access the struct. This is required to add the device to modern SoC containers. Signed-off-by: Alistair Francis Reviewed-by: Sai Pavan Boddu Reviewed-by: Peter Crosthwaite --- hw/ide/ahci.c | 13 -

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Jeff Cody
On Thu, Aug 27, 2015 at 01:27:40PM -0600, Eric Blake wrote: > On 08/27/2015 01:08 PM, Jeff Cody wrote: > > On Thu, Aug 27, 2015 at 05:02:17PM +0100, Daniel P. Berrange wrote: > >> > >> Just to be clear - libvirt will *never* use an auto-generated device > >> IDs feature. It is way more complicated

Re: [Qemu-devel] [PATCH v3 6/9] arm: clarify the use of muldiv64()

2015-08-27 Thread Peter Crosthwaite
On Thu, Aug 27, 2015 at 12:33 PM, Laurent Vivier wrote: > muldiv64() is used to convert microseconds into CPU ticks. > > But it is not clear and not commented. This patch uses macro > to clearly identify what is used: time, CPU frequency and ticks. > For an elapsed time and a given frequency, we c

Re: [Qemu-devel] KVM guest gets aborted if blockcommit is called

2015-08-27 Thread Christian Rößner
> Am 27.08.2015 um 22:15 schrieb Eric Blake : > > On 08/27/2015 02:01 PM, Christian Rößner wrote: > > > I think you may be running into a bug that is fixed by a recent patch > (after v2.4.0): > > commit e424aff5f307227b1c2512bbb8ece891bb895cef > Author: Kevin Wolf >>

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 12:22 PM, Daniel P. Berrange wrote: > On Thu, Aug 27, 2015 at 12:08:25PM -0400, Programmingkid wrote: >> >> On Aug 27, 2015, at 12:02 PM, Daniel P. Berrange wrote: >> >>> On Thu, Aug 27, 2015 at 11:58:22AM -0400, Programmingkid wrote: On Aug 27, 2015, at 11:40 AM,

Re: [Qemu-devel] KVM guest gets aborted if blockcommit is called

2015-08-27 Thread Eric Blake
On 08/27/2015 02:01 PM, Christian Rößner wrote: I think you may be running into a bug that is fixed by a recent patch (after v2.4.0): commit e424aff5f307227b1c2512bbb8ece891bb895cef Author: Kevin Wolf Date: Thu Aug 13 10:41:50 2015 +0200 mirror:

Re: [Qemu-devel] KVM guest gets aborted if blockcommit is called

2015-08-27 Thread Christian Rößner
> Am 27.08.2015 um 14:34 schrieb Jeff Cody : > > On Thu, Aug 27, 2015 at 11:26:13AM +0200, Christian Rößner wrote: >> >>> Am 26.08.2015 um 15:25 schrieb Jeff Cody : >>> >>> On Wed, Aug 26, 2015 at 10:08:26AM +0200, Christian Rößner wrote: > Am 25.08.2015 um 08:02 schrieb Christian Röß

[Qemu-devel] [PATCH 1/3] q35: Move options common to all classes to pc_q35_machine_options()

2015-08-27 Thread Eduardo Habkost
The existing default_machine_opts, default_display, no_floppy, and no_tco settings will still apply to future machine classes. So it makes sense to move them to pc_q35_machine_options() instead of keeping them in a version-specific machine_options function. Signed-off-by: Eduardo Habkost --- hw/

[Qemu-devel] [PATCH 3/3] pc: Introduce pc-*-2.5 machine classes

2015-08-27 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 14 +- hw/i386/pc_q35.c | 12 +++- include/hw/compat.h | 3 +++ include/hw/i386/pc.h | 4 4 files changed, 31 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 7ca3fcf..

[Qemu-devel] [PATCH 0/3] pc-*-2.5 machine-types

2015-08-27 Thread Eduardo Habkost
This introduces the pc-q35-2.5 and pc-i440fx-2.5 machine-types. Jason Wang, I know you were going to do it as part of the virtio pci work, but I would like to simplify the existing code before introducing the new machine. Feel free to include it as part of your series, if necessary. Eduardo Habko

[Qemu-devel] [PATCH 2/3] q35: Move options common to all classes to pc_i440fx_machine_options()

2015-08-27 Thread Eduardo Habkost
The existing default_machine_opts and default_display settings will still apply to future machine classes. So it makes sense to move them to pc_i440fx_machine_options() instead of keeping them in a version-specific machine_options function. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c |

[Qemu-devel] [PATCH v3 8/9] bt: remove muldiv64()

2015-08-27 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds. As get

[Qemu-devel] [PATCH v3 9/9] net: remove muldiv64()

2015-08-27 Thread Laurent Vivier
muldiv64() is used to convert nanoseconds to microseconds. x = muldiv64(qemu_clock_get_ns(..), 100, get_ticks_per_sec()); As get_ticks_per_sec() is 10^9, it can be replaced by: x = qemu_clock_get_us(..); Signed-off-by: Laurent Vivier --- v2: use qemu_clock_get_us() instead of qemu

[Qemu-devel] [PATCH v3 5/9] openrisc: remove muldiv64()

2015-08-27 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by doin

[Qemu-devel] [PATCH] linux-user: remove MAX_ARG_PAGES limit

2015-08-27 Thread Stefan Brüns
Instead of creating a temporary copy for the whole environment and the arguments, directly copy everything to the target stack. For this to work, we have to change the order of stack creation and copying the arguments. v2: fixed scratch pointer type, fixed checkpatch issues. Signed-off-by: Stefa

[Qemu-devel] [PATCH v3 3/9] pcnet: remove muldiv64()

2015-08-27 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by doin

[Qemu-devel] [PATCH v3 7/9] hpet: remove muldiv64()

2015-08-27 Thread Laurent Vivier
hpet defines a clock period in femtoseconds but then converts it to nanoseconds to use the internal timers. We can define the period in nanoseconds and use it directly, this allows to remove muldiv64(). We only need to convert the period to femtoseconds to put it in internal hpet capability regis

[Qemu-devel] [PATCH v3 6/9] arm: clarify the use of muldiv64()

2015-08-27 Thread Laurent Vivier
muldiv64() is used to convert microseconds into CPU ticks. But it is not clear and not commented. This patch uses macro to clearly identify what is used: time, CPU frequency and ticks. For an elapsed time and a given frequency, we compute how many ticks we have. Signed-off-by: Laurent Vivier --

[Qemu-devel] [PATCH v3 4/9] mips: remove muldiv64()

2015-08-27 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by doin

[Qemu-devel] [PATCH v3 0/9] remove useless muldiv64()

2015-08-27 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by doin

[Qemu-devel] [PATCH v3 2/9] rtl8139: remove muldiv64()

2015-08-27 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by doin

[Qemu-devel] [PATCH v3 1/9] i6300esb: remove muldiv64()

2015-08-27 Thread Laurent Vivier
Originally, timers were ticks based, and it made sense to add ticks to current time to know when to trigger an alarm. But since commit: 7447545 change all other clock references to use nanosecond resolution accessors All timers use nanoseconds and we need to convert ticks to nanoseconds, by doin

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Eric Blake
On 08/27/2015 01:08 PM, Jeff Cody wrote: > On Thu, Aug 27, 2015 at 05:02:17PM +0100, Daniel P. Berrange wrote: >> >> Just to be clear - libvirt will *never* use an auto-generated device >> IDs feature. It is way more complicated to let QEMU assign device IDs >> and then auto-detect them from some '

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Eric Blake
On 08/27/2015 12:59 PM, John Snow wrote: >> Dan made the point that if a name is unpredictable, then we have >> to query to learn what name was assigned. But if you add two or >> more devices before querying, then you don't know which device has >> which name. Predictable might actually be bette

Re: [Qemu-devel] [PATCH v2] monitor: allow object_del & device_del to accept QOM paths

2015-08-27 Thread Eric Blake
On 08/27/2015 11:26 AM, Programmingkid wrote: > > On Aug 27, 2015, at 12:13 PM, Daniel P. Berrange wrote: > >> Currently both object_del and device_del require that the >> client provide the object/device short ID. While user >> creatable objects require an ID to be provided at time of >> creatio

Re: [Qemu-devel] [PATCH 2/4] configure: qemu-ga: explicitly enable qemu-ga MSI support when probed

2015-08-27 Thread Michael Roth
Quoting Marc-André Lureau (2015-08-27 09:05:40) > Hi > > On Thu, Aug 27, 2015 at 3:42 PM, Michael Roth > wrote: > > If we keep the $enabled != "no" logic all the way through, $enabled, > > unless explicitly turned off or missing dependencies, will be > > undefined when the configure options are

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread Jeff Cody
On Thu, Aug 27, 2015 at 05:02:17PM +0100, Daniel P. Berrange wrote: > > Just to be clear - libvirt will *never* use an auto-generated device > IDs feature. It is way more complicated to let QEMU assign device IDs > and then auto-detect them from some 'info device-list' output, than > to just speci

Re: [Qemu-devel] [PATCH v2] sheepdog: add reopen support

2015-08-27 Thread Jeff Cody
On Thu, Aug 27, 2015 at 10:54:01AM +0800, Liu Yuan wrote: > From: Liu Yuan > > With reopen supported, block-commit (and offline commit) is now supported for > image files whose base image uses the Sheepdog protocol driver. > > Cc: qemu-devel@nongnu.org > Cc: Jeff Cody > Cc: Kevin Wolf > Cc: St

Re: [Qemu-devel] Should we auto-generate IDs?

2015-08-27 Thread John Snow
On 08/27/2015 09:00 AM, Eric Blake wrote: > On 08/27/2015 06:32 AM, Jeff Cody wrote: >> (Added Eric back in to the CC list. Looks like he got dropped >> somewhere along the way) > > No thanks to mailman's inept behavior that thinks that it is okay > to rewrite cc's to drop anyone that doesn't

Re: [Qemu-devel] [PATCH v1 2/3] object.c: object_class_dynamic_cast return NULL if the class has no type

2015-08-27 Thread Alistair Francis
On Wed, Aug 26, 2015 at 4:11 PM, John Snow wrote: > > > On 08/26/2015 06:15 PM, Peter Crosthwaite wrote: >> On Wed, Aug 26, 2015 at 2:46 PM, John Snow wrote: >>> >>> >>> On 08/26/2015 05:02 PM, Peter Crosthwaite wrote: > > [snip] > So there a few problems in the way of a correct solutio

Re: [Qemu-devel] [PATCH 9/9] target-arm: Wire up HLT 0xf000 as the A64 semihosting instruction

2015-08-27 Thread Peter Maydell
On 13 August 2015 at 17:35, Peter Maydell wrote: > For the A64 instruction set, the semihosting call instruction > is 'HLT 0xf000'. Wire this up to call do_arm_semihosting() > if semihosting is enabled. > > Signed-off-by: Peter Maydell > --- > @@ -1553,8 +1554,17 @@ static void disas_exc(DisasCo

Re: [Qemu-devel] add multiple times opening support to a virtserialport

2015-08-27 Thread Christoffer Dall
On Thu, Aug 27, 2015 at 10:23:38AM -0400, Christopher Covington wrote: > On 07/24/2015 08:00 AM, Matt Ma wrote: > > Hi all, > > > > Linaro has developed the foundation for the new Android Emulator code > > base based on a fairly recent upstream QEMU code base, when we > > re-based the code, we upd

Re: [Qemu-devel] [PATCH v3] i386: keep cpu_model field in MachineState uptodate

2015-08-27 Thread Eduardo Habkost
On Thu, Aug 27, 2015 at 05:27:05PM +0800, Zhu Guihua wrote: > Update cpu_model in MachineState for i386, so that the field can be used > for cpu hotplug, instead of using a static variable. > > Signed-off-by: Zhu Guihua Reviewed-by: Eduardo Habkost -- Eduardo

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-08-27 Thread Eduardo Habkost
On Thu, Aug 27, 2015 at 01:50:10PM +0300, Michael S. Tsirkin wrote: > On Tue, Aug 25, 2015 at 05:21:16PM +0100, Daniel P. Berrange wrote: > > On Mon, Aug 24, 2015 at 11:54:48AM +0200, Markus Armbruster wrote: > > > John Snow writes: > > > > > > > On 08/19/2015 02:55 AM, Dr. David Alan Gilbert wro

Re: [Qemu-devel] [PATCH] linux-user: fix host_to_target_cmsg in case of multiple headers

2015-08-27 Thread Peter Maydell
On 27 August 2015 at 15:50, Jonathan Neuschäfer wrote: > In the current implementation, __target_cmsg_nxthdr compares a pointer > derived from target_cmsg against the msg_control field of target_msgh > (through subtraction). This failed for me when emulating i386 code > under x86_64, because poin

Re: [Qemu-devel] [PATCH v2 0/4] acpi: xsdt support

2015-08-27 Thread Michael S. Tsirkin
On Thu, Aug 27, 2015 at 04:27:00PM +0200, Laszlo Ersek wrote: > On 06/09/15 16:05, Michael S. Tsirkin wrote: > > On Tue, Jun 09, 2015 at 04:02:08PM +0200, Laszlo Ersek wrote: > >> On 06/09/15 11:49, Michael S. Tsirkin wrote: > >>> On Tue, Jun 09, 2015 at 02:02:31AM -0400, Paolo Bonzini wrote: > >>>

Re: [Qemu-devel] [PATCH] linux-user: remove MAX_ARG_PAGES limit

2015-08-27 Thread Peter Maydell
On 23 August 2015 at 00:47, Stefan Brüns wrote: > Instead of creating a temporary copy for the whole environment and > the arguments, directly copy everything to the target stack. > > For this to work, we have to change the order of stack creation and > copying the arguments. > > Signed-off-by: St

Re: [Qemu-devel] [PATCH 1/3] hmp-commands-info: move info_cmds content out of monitor.c

2015-08-27 Thread Peter Maydell
On 12 August 2015 at 12:50, Denis V. Lunev wrote: > From: Pavel Butsykin > > For moving target- and device-specific code from monitor.c, > to beginning we move info_cmds content to hmp-commands-info.hx > > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Luiz Capitulino > C

Re: [Qemu-devel] [PATCH 3/3] monitor: added generation of documentation for hmp-commands-info.hx

2015-08-27 Thread Peter Maydell
On 12 August 2015 at 12:50, Denis V. Lunev wrote: > From: Pavel Butsykin > > It will be easier if you need to add info-commands to edit > only hmp-commands-info.hx, before this had to edit monitor.c and > hmp-commands.hx > > Signed-off-by: Pavel Butsykin > Signed-off-by: Denis V. Lunev > CC: Lu

Re: [Qemu-devel] [PATCH 2/3] monitor: remove target-specific code from monitor.c

2015-08-27 Thread Denis V. Lunev
On 08/27/2015 08:31 PM, Peter Maydell wrote: On 12 August 2015 at 12:50, Denis V. Lunev wrote: From: Pavel Butsykin Move target-specific code out of /monitor.c to /target-*/monitor.c, this will avoid code cluttering and using random ifdeffery. The solution is quite simple, but solves the iss

Re: [Qemu-devel] [PATCH 2/3] monitor: remove target-specific code from monitor.c

2015-08-27 Thread Peter Maydell
On 12 August 2015 at 12:50, Denis V. Lunev wrote: > From: Pavel Butsykin > > Move target-specific code out of /monitor.c to /target-*/monitor.c, > this will avoid code cluttering and using random ifdeffery. The solution > is quite simple, but solves the issue of the separation of target-specific

Re: [Qemu-devel] [PATCH v2] monitor: allow object_del & device_del to accept QOM paths

2015-08-27 Thread Programmingkid
On Aug 27, 2015, at 12:13 PM, Daniel P. Berrange wrote: > Currently both object_del and device_del require that the > client provide the object/device short ID. While user > creatable objects require an ID to be provided at time of > creation, qdev devices may be created without giving an > ID. T

Re: [Qemu-devel] [Qemu-block] [PATCH v2 09/11] block: Introduce bdrv_aio_poll

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:12PM +0800, Fam Zheng wrote: > This call is introduced simply as a wrapper of aio_poll, but it makes it > is easy to change the polled client types. > > Signed-off-by: Fam Zheng > --- > block/io.c| 8 > include/block/aio.h | 2 +- > include/bl

Re: [Qemu-devel] [PATCH v2 07/11] aio-posix: introduce aio_{disable, enable}_clients

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:10PM +0800, Fam Zheng wrote: > +void aio_disable_enable_clients(AioContext *ctx, int clients_mask, > +bool is_disable) > +{ > +AioHandler *node; > +aio_context_acquire(ctx); > + > +QLIST_FOREACH(node, &ctx->aio_handlers, node

Re: [Qemu-devel] [Qemu-block] [PATCH v2 06/11] dataplane: Mark host notifiers' client type as "dataplane"

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:09PM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > hw/block/dataplane/virtio-blk.c | 4 ++-- > hw/scsi/virtio-scsi-dataplane.c | 16 > include/block/aio.h | 1 + > 3 files changed, 11 insertions(+), 10 deletions(-) Reviewe

[Qemu-devel] [PATCH, RFC v2] Use help sub-sections to create sub-help options

2015-08-27 Thread Laurent Vivier
As '-help' output is 400 lines long it is not easy to find information, but generally we know from which area we want the information. As subsections already exist in the help description, add some command options to only display the wanted subsection. As more is better, this patch adds 13 lines

Re: [Qemu-devel] [Qemu-block] [PATCH v2 05/11] aio: Mark ctx->notifier's client type as "context"

2015-08-27 Thread Stefan Hajnoczi
On Wed, Jul 29, 2015 at 12:42:08PM +0800, Fam Zheng wrote: > It is important to include this for any blocking poll, on the other hand it is > also OK to exclude it otherwise. > > Signed-off-by: Fam Zheng > --- > async.c | 4 ++-- > include/block/aio.h | 1 + > 2 files changed, 3 inse

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-27 Thread Stefan Hajnoczi
On Thu, Aug 27, 2015 at 5:48 PM, Stefan Hajnoczi wrote: > On Mon, Aug 25, 2014 at 03:50:02PM -0600, Chris Friesen wrote: >> On 08/23/2014 01:56 AM, Benoît Canet wrote: >> >The Friday 22 Aug 2014 à 18:59:38 (-0600), Chris Friesen wrote : >> >>On 07/21/2014 10:10 AM, Benoît Canet wrote: >> >>>The Mo

Re: [Qemu-devel] [PATCH] target-arm: Break the TB after IC invalidation to execute self-modified code correctly

2015-08-27 Thread Peter Maydell
On 26 August 2015 at 12:36, Sergey Sorokin wrote: > If any store instruction writes the code inside the same TB > after this store insn, the execution of the TB must be stopped > to execute new code correctly. > As described in ARMv8 manual D3.4.6 a self-modified code need to do > IC invalidation

Re: [Qemu-devel] Lockups with 4.2-rc kernels and qemu

2015-08-27 Thread Ken Moffat
On Thu, Aug 27, 2015 at 12:59:14PM +0100, Ken Moffat wrote: > On Tue, Aug 25, 2015 at 12:40:15AM +0100, Ken Moffat wrote: > > (Cc'ing qemu-devel, please keep me in the Cc). > > > > TL;DR - qemu locks up my machine when I use 4.2-rc kernels. > > > Previous mail, or at least the copy to qemu, archi

Re: [Qemu-devel] is there a limit on the number of in-flight I/O operations?

2015-08-27 Thread Stefan Hajnoczi
On Mon, Aug 25, 2014 at 03:50:02PM -0600, Chris Friesen wrote: > The only limit I see in the whole call chain from > virtio_blk_handle_request() on down is the call to > bdrv_io_limits_intercept() in bdrv_co_do_writev(). However, that doesn't > provide any limit on the absolute number of inflight

  1   2   3   >