Re: [Qemu-devel] [PATCH RFC v3 26/32] qapi: Introduce a first class 'any' type

2015-08-07 Thread Markus Armbruster
Eric Blake writes: > On 08/04/2015 09:58 AM, Markus Armbruster wrote: >> It's first class, because unlike '**', it actually works, i.e. doesn't >> require 'gen': false. >> >> '**' will go away next. >> >> Signed-off-by: Markus Armbruster >> Reviewed-by: Eric Blake >> --- > >> @@ -1039,8 +1040

Re: [Qemu-devel] [PATCH RFC v3 11/32] qapi-visit: Convert to QAPISchemaVisitor, fixing bugs

2015-08-07 Thread Markus Armbruster
Eric Blake writes: > On 08/04/2015 09:57 AM, Markus Armbruster wrote: >> Fixes flat unions to visit the base's base members (the previous >> commit merely added them to the struct). Same test case. >> >> Patch's effect on visit_type_UserDefFlatUnion(): >> >> static void visit_type_UserDef

Re: [Qemu-devel] [PATCH v2] qemu-doc.texi: Add usb sound card info

2015-08-07 Thread Markus Armbruster
Copying USB maintainer... Programmingkid writes: > Add info on usb sound card to qemu documentation. > > Signed-off-by: John Arbuckle > > --- > Changed 'thru' to 'through' > > qemu-doc.texi |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/qemu-doc.texi b/qemu-d

Re: [Qemu-devel] [PATCH] qemu-doc.texi: Add information on compiling source code on Mac OS X

2015-08-07 Thread Programmingkid
On Aug 7, 2015, at 7:13 PM, Peter Maydell wrote: > On 7 August 2015 at 21:32, Programmingkid wrote: >> >> On Aug 7, 2015, at 1:00 PM, Peter Maydell wrote: >>> (https://trac.macports.org/wiki/UsingTheRightCompiler >>> suggests that XCode 3.2 for OSX 10.6 provided a non-default >>> 'clang'; I don

Re: [Qemu-devel] [ARM SMBIOS V2 PATCH 0/6] SMBIOS Support for ARM

2015-08-07 Thread Leif Lindholm
Hi Wei, So, I can verify that this works all the way into Linux userland dmidecode on arm64. One question: This set still leaves the -smbios set of options x86 only. Would --- a/qemu-options.hx +++ b/qemu-options.hx @@ -1412,7 +1412,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios, "-smbios

Re: [Qemu-devel] [PATCH] qemu-doc.texi: Add information on compiling source code on Mac OS X

2015-08-07 Thread Peter Maydell
On 7 August 2015 at 21:32, Programmingkid wrote: > > On Aug 7, 2015, at 1:00 PM, Peter Maydell wrote: >> (https://trac.macports.org/wiki/UsingTheRightCompiler >> suggests that XCode 3.2 for OSX 10.6 provided a non-default >> 'clang'; I don't have a 10.6 + 3.2 system to check whether that >> clang

Re: [Qemu-devel] [PATCH 3/5] Implement fw_cfg DMA interface

2015-08-07 Thread Laszlo Ersek
On 08/07/15 22:40, Kevin O'Connor wrote: > On Thu, Aug 06, 2015 at 04:59:15PM +0200, Marc Marí wrote: >> On Thu, 6 Aug 2015 10:47:21 -0400 >> "Kevin O'Connor" wrote: >>> Also, it's very unusual to see 32bit writes to an unaligned IO address >>> - I think two pad bytes should be added so that the o

[Qemu-devel] [RFC PATCH v2 14/12] qapi: Document visitor interfaces

2015-08-07 Thread Eric Blake
The visitor interface for mapping between QObject and qapi has formerly been documented only by reading source code, making it difficult to propose changes to either scripts/qapi*.py or to clients without knowing whether those changes would be safe. This tries to add documentation, including menti

[Qemu-devel] [RFC PATCH v2 13/12] qapi: Remove dead visitor code

2015-08-07 Thread Eric Blake
Commit cbc95538 removed unused start_handle() and end_handle(), but forgot got remove their declarations. Commit 4e27e819 introduced optional visitor callbacks for all sorts of int types, but except for type_uint64 and type_size, none of them have ever been supplied (the generic implementation bas

[Qemu-devel] virtio-9p

2015-08-07 Thread Linda
Hello, I am a summer intern under the Outreachy program (returning to software development after a long hiatus). I am developing a prototype of a xen front/back end for a 9p file transport. Since virtio is the most complete, and used, transport, I am using that as a model. I am enc

[Qemu-devel] [PATCH v2] qemu-doc.texi: Add information on compiling source code on Mac OS X

2015-08-07 Thread Programmingkid
Add information on compiling source code on Mac OS X to the documentation. Signed-off-by: John Arbuckle --- qemu-doc.texi | 44 +--- 1 files changed, 41 insertions(+), 3 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index 0125bc7..c059c49 100

Re: [Qemu-devel] [PATCH 3/5] Implement fw_cfg DMA interface

2015-08-07 Thread Kevin O'Connor
On Thu, Aug 06, 2015 at 04:59:15PM +0200, Marc Marí wrote: > On Thu, 6 Aug 2015 10:47:21 -0400 > "Kevin O'Connor" wrote: > > Also, it's very unusual to see 32bit writes to an unaligned IO address > > - I think two pad bytes should be added so that the offset for the dma > > address is at position

Re: [Qemu-devel] [PATCH] qemu-doc.texi: Add information on compiling source code on Mac OS X

2015-08-07 Thread Programmingkid
On Aug 7, 2015, at 1:00 PM, Peter Maydell wrote: >> -The Mac OS X patches are not fully merged in QEMU, so you should look >> -at the QEMU mailing list archive to have all the necessary >> -information. > > Heh, that's laughably ancient. Thanks for writing a fix for this. Your welcome. > > At

Re: [Qemu-devel] [RFC PATCH qemu 0/4] vfio: SPAPR IOMMU v2 (memory preregistration support)

2015-08-07 Thread Alex Williamson
On Thu, 2015-08-06 at 13:16 +1000, Alexey Kardashevskiy wrote: > On 07/29/2015 10:27 AM, Alexey Kardashevskiy wrote: > > Oh, just noticed, this is missing "v4" in the subject line. > > Anyone, ping? Thanks I think David had some ideas on re-working this, but I'm not sure if he's had any time to i

[Qemu-devel] [PATCH for-2.5 13/18] pc: Remove redundant arguments from pc_cmos_init()

2015-08-07 Thread Eduardo Habkost
Remove arguments that can be found in PCMachineState. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 16 +++- hw/i386/pc_piix.c| 5 + hw/i386/pc_q35.c | 5 + include/hw/i386/pc.h | 2 -- 4 files changed, 9 insertions(+), 19 deletions(-) diff --git a/hw/

[Qemu-devel] [PATCH for-2.5 12/18] pc: Remove redundant arguments from *load_linux()

2015-08-07 Thread Eduardo Habkost
Remove arguments that can be found in PCMachineState. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 28 hw/i386/pc_piix.c| 6 +- include/hw/i386/pc.h | 5 + 3 files changed, 14 insertions(+), 25 deletions(-) diff --git a/hw/i386/pc.c b/hw/i

[Qemu-devel] [PATCH for-2.5 18/18] pc: Move acpi_data_size global to PCMachineClass

2015-08-07 Thread Eduardo Habkost
This way we don't need code in pc_compat_*() functions to set the legacy acpi_data_size value. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 17 ++--- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- include/hw/i386/pc.h | 6 -- 4 files changed, 12 inserti

[Qemu-devel] [PATCH for-2.5 17/18] pc: Move legacy_acpi_table_size global to PCMachineClass

2015-08-07 Thread Eduardo Habkost
This way we can set legacy_acpi_table_size on the machine_options() functions, instead of requirng code in pc_compat_*() functions. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 40 +++- include/hw/i386/pc.h | 1 + 2 files changed, 20 insertions(+

[Qemu-devel] [PATCH for-2.5 10/18] pc: Move {above, below}_4g_mem_size variables to PCMachineState

2015-08-07 Thread Eduardo Habkost
This will make the info readily available for the other initialization functions, and will allow us to simplify their argument list. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 26 ++ hw/i386/pc_q35.c | 24 +--- include/hw/i386/pc.h |

[Qemu-devel] [PATCH for-2.5 14/18] pc: Remove redundant arguments from pc_memory_init()

2015-08-07 Thread Eduardo Habkost
Remove arguments that can be found in PCMachineState. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 18 +- hw/i386/pc_piix.c| 1 - hw/i386/pc_q35.c | 1 - include/hw/i386/pc.h | 2 -- 4 files changed, 9 insertions(+), 13 deletions(-) diff --git a/hw/i386/p

[Qemu-devel] [PATCH for-2.5 08/18] pc: Use PCMachineState for pc_cmos_init() argument

2015-08-07 Thread Eduardo Habkost
pc_cmos_init() already expects a PCMachineState object, there's no point in upcasting it to MachineState before calling the function. While doing it, reorder the arguments so PCMachineState is the first function argument. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 10 +-

[Qemu-devel] [PATCH for-2.5 15/18] pc: Remove redundant arguments from xen_hvm_init()

2015-08-07 Thread Eduardo Habkost
Remove arguments that can be found in PCMachineState. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 4 +--- hw/i386/pc_q35.c | 4 +--- include/hw/xen/xen.h | 4 ++-- xen-hvm.c| 25 - 4 files changed, 16 insertions(+), 21 deletions(-) diff -

[Qemu-devel] [PATCH for-2.5 16/18] pc: Move compat boolean globals to PCMachineClass

2015-08-07 Thread Eduardo Habkost
This way the compat flags can be initialized in the machine_options() function. This will help us to eventually eliminate the pc_compat_*() functions. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 8 + hw/i386/pc_piix.c| 84 +--

[Qemu-devel] [PATCH for-2.5 05/18] pc: Move PCMachineClass, PCMachineState to qemu/typedefs.h

2015-08-07 Thread Eduardo Habkost
They will be used inside hw/xen/xen.h, which doesn't include hw/i386/pc.h. Signed-off-by: Eduardo Habkost --- include/hw/i386/pc.h| 4 +--- include/qemu/typedefs.h | 2 ++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h index 1dca7e7

[Qemu-devel] [PATCH for-2.5 04/18] pc: Rename pc_machine variables to pcms

2015-08-07 Thread Eduardo Habkost
Make the code use the same variable name everywhere. "pcms" is already being used in existing code and it's shorter. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 4 ++-- hw/i386/pc_piix.c | 20 ++-- hw/i386/pc_q35.c | 20 ++-- 3 files changed, 22 inser

[Qemu-devel] [PATCH for-2.5 11/18] pc: Use PCMachineState as pc_guest_info_init() argument

2015-08-07 Thread Eduardo Habkost
Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 7 +++ hw/i386/pc_piix.c| 3 +-- hw/i386/pc_q35.c | 3 +-- include/hw/i386/pc.h | 3 +-- 4 files changed, 6 insertions(+), 10 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index a9a9cf4..081ef83 100644 --- a/hw/i386/pc

[Qemu-devel] [PATCH for-2.5 07/18] pc: Eliminate pc_default_machine_options()

2015-08-07 Thread Eduardo Habkost
The only PC machines that didn't call pc_default_machine_options() were isaps and xenfv. Both were already overwriting max_cpus, and only isapc was not overwriting hot_add_cpu. After making isapc set hot_add_cpu to NULL, we can move the pc_default_machine_options() code the PC common class_init.

[Qemu-devel] [PATCH for-2.5 03/18] pc: Use error_abort when registering properties

2015-08-07 Thread Eduardo Habkost
No errors should happen when registering the properties, but we shouldn't silently ignore them if they happen. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 7661ea9..7c811cd 1

[Qemu-devel] [PATCH for-2.5 01/18] pc: Use PC_COMPAT_* for CPUID feature compatibility

2015-08-07 Thread Eduardo Habkost
Now we can use compat_props to keep CPUID feature compatibility, using the boolean QOM properties for CPUID feature flags. This simplifies the compatibility code, and reduces duplication between pc_piix.c and pc_q35.c. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 22 -- hw

[Qemu-devel] [PATCH for-2.5 00/18] pc: Initialization and compat function cleanup

2015-08-07 Thread Eduardo Habkost
This implements some extras code cleanups in the PC code: * Use PC_COMPAT_* instead of a special compat function for X86 CPUID compatibility * Use error_abort where appropriate * Rename PCMachineState variables consistently * Move some local variables from pc_init1() and pc_q35_init() to PCMac

[Qemu-devel] [PATCH for-2.5 02/18] target-i386: Remove x86_cpu_compat_set_features()

2015-08-07 Thread Eduardo Habkost
The function is not used by PC code anymore and can be removed. Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 26 -- target-i386/cpu.h | 3 --- 2 files changed, 29 deletions(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 7a779b1..cfb8aa7 100644 ---

[Qemu-devel] [PATCH for-2.5 09/18] pc: Use PCMachineState for pc_memory_init() argument

2015-08-07 Thread Eduardo Habkost
pc_memory_init() already expects a PCMachineState object, there's no point in upcasting it to MachineState before calling the function. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 4 ++-- hw/i386/pc_piix.c| 2 +- hw/i386/pc_q35.c | 2 +- include/hw/i386/pc.h | 2 +- 4 files

[Qemu-devel] [PATCH for-2.5 06/18] pc: Eliminate pc_common_machine_options()

2015-08-07 Thread Eduardo Habkost
All TYPE_PC_MACHINE subclasses call pc_common_machine_options(). TYPE_PC_MACHINE can simply initialize the common options on class_init directly. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 1 + hw/i386/pc_piix.c| 2 -- include/hw/i386/pc.h | 6 -- 3 files changed, 1 insert

Re: [Qemu-devel] [PATCH RFC v3 26/32] qapi: Introduce a first class 'any' type

2015-08-07 Thread Eric Blake
On 08/04/2015 09:58 AM, Markus Armbruster wrote: > It's first class, because unlike '**', it actually works, i.e. doesn't > require 'gen': false. > > '**' will go away next. > > Signed-off-by: Markus Armbruster > Reviewed-by: Eric Blake > --- > @@ -1039,8 +1040,7 @@ class QAPISchema(object): >

[Qemu-devel] [PATCH for-2.5] piix: Document coreboot-specific RAM size config register

2015-08-07 Thread Eduardo Habkost
The existing i440fx initialization code sets a PCI config register that isn't documented anywhere in the Intel 440FX datasheet. Register 0x57 is DRAMC (DRAM Control) and has nothing to do with the RAM size. This was implemented in commit ec5f92ce6ac8ec09056be77e03c941be188648fa because old coreboo

Re: [Qemu-devel] [ARM SMBIOS V2 PATCH 6/6] smbios: implement smbios support for mach-virt

2015-08-07 Thread Laszlo Ersek
comments below On 08/06/15 19:15, Wei Huang wrote: > This patch generates smbios tables for ARM mach-virt. Also add > CONFIG_SMBIOS=y for ARM default config. > > Signed-off-by: Wei Huang > --- > default-configs/arm-softmmu.mak | 1 + > hw/arm/virt.c| 27 +++

Re: [Qemu-devel] [ARM SMBIOS V2 PATCH 5/6] smbios: add smbios 3.0 support

2015-08-07 Thread Laszlo Ersek
sorry, another comment: On 08/06/15 19:14, Wei Huang wrote: > This patch adds support for SMBIOS 3.0 entry point. When caller invokes > smbios_set_defaults(), it can specify entry point as 2.1 or 3.0. Then > smbios_get_tables() will return the entry point table in right format. > > Signed-off-by:

Re: [Qemu-devel] [ARM SMBIOS V2 PATCH 5/6] smbios: add smbios 3.0 support

2015-08-07 Thread Laszlo Ersek
comments below On 08/06/15 19:14, Wei Huang wrote: > This patch adds support for SMBIOS 3.0 entry point. When caller invokes > smbios_set_defaults(), it can specify entry point as 2.1 or 3.0. Then > smbios_get_tables() will return the entry point table in right format. > > Signed-off-by: Wei Huan

[Qemu-devel] [RFC v4 8/9] tcg-aarch64: Implement excl variants of qemu_{ld, st}

2015-08-07 Thread Alvise Rigo
Implement the exclusive variants of qemu_{ld,st}_{i32,i64} for tcg-aarch64. The lookup for the proper memory helper has been rewritten to take into account the new exclusive helpers. Suggested-by: Jani Kokkonen Suggested-by: Claudio Fontana Signed-off-by: Alvise Rigo --- tcg/aarch64/tcg-target

[Qemu-devel] [RFC v4 1/9] exec.c: Add new exclusive bitmap to ram_list

2015-08-07 Thread Alvise Rigo
The purpose of this new bitmap is to flag the memory pages that are in the middle of LL/SC operations (after a LL, before a SC) on a per-vCPU basis. For all these pages, the corresponding TLB entries will be generated in such a way to force the slow-path if at least one vCPU has the bit not set. Wh

[Qemu-devel] [RFC v4 3/9] softmmu: Add helpers for a new slowpath

2015-08-07 Thread Alvise Rigo
The new helpers rely on the legacy ones to perform the actual read/write. The LoadLink helper (helper_ldlink_name) prepares the way for the following SC operation. It sets the linked address and the size of the access. These helper also update the TLB entry of the page involved in the LL/SC for th

[Qemu-devel] [RFC v4 6/9] tcg-i386: Implement excl variants of qemu_{ld, st}

2015-08-07 Thread Alvise Rigo
Implement exclusive variants of qemu_{ld,st}_{i32,i64} for tcg-i386. The lookup for the proper memory helper has been rewritten to take into account the new exclusive helpers. Suggested-by: Jani Kokkonen Suggested-by: Claudio Fontana Signed-off-by: Alvise Rigo --- tcg/i386/tcg-target.c | 148 +

[Qemu-devel] [RFC v4 5/9] configure: Enable/disable new qemu_{ld, st} excl insns

2015-08-07 Thread Alvise Rigo
Introduce the new --enable-tcg-ldst-excl configure option to enable the LL/SC operations only for those backends that support them. Suggested-by: Jani Kokkonen Suggested-by: Claudio Fontana Signed-off-by: Alvise Rigo --- configure | 21 + 1 file changed, 21 insertions(+) d

Re: [Qemu-devel] [PATCH] qemu-doc.texi: Add information on compiling source code on Mac OS X

2015-08-07 Thread Peter Maydell
On 6 August 2015 at 16:35, Programmingkid wrote: > Add information on compiling source code on Mac OS X > to the documentation. > > Signed-off-by: John Arbuckle > > --- > This patch may depend on the other patch I sent in for the qemu-doc.texi > file. > > qemu-doc.texi | 41 +++

[Qemu-devel] [RFC v4 7/9] tcg-arm: Implement excl variants of qemu_{ld, st}

2015-08-07 Thread Alvise Rigo
Implement the exclusive variants of qemu_{ld,st}_{i32,i64} for tcg-arm. The lookup for the proper memory helper has been rewritten to take into account the new exclusive helpers. Suggested-by: Jani Kokkonen Suggested-by: Claudio Fontana Signed-off-by: Alvise Rigo --- tcg/arm/tcg-target.c | 152

[Qemu-devel] [RFC v4 0/9] Slow-path for atomic instruction translation

2015-08-07 Thread Alvise Rigo
This is the fourth iteration of the patch series which applies to the upstream branch of QEMU (v2.4.0-rc0). Changes versus previous versions are at the bottom of this cover letter. The code is also available at following repository: https://git.virtualopensystems.com/dev/qemu-mt.git branch: slowp

[Qemu-devel] [RFC v4 9/9] target-arm: translate: Use ld/st excl for atomic insns

2015-08-07 Thread Alvise Rigo
Use the TCG load and store exclusive operataions if QEMU has been configured to do so. Suggested-by: Jani Kokkonen Suggested-by: Claudio Fontana Signed-off-by: Alvise Rigo --- target-arm/translate.c | 191 ++--- 1 file changed, 183 insertions(+), 8 d

[Qemu-devel] [RFC v4 4/9] tcg-op: create new TCG qemu_{ld, st} excl variants

2015-08-07 Thread Alvise Rigo
Introduce the MO_EXCL TCGMemOp flag that marks a load access as LL and a store access as SC. While the LL variant has been implemented without the need of any extra TCG instruction, for the SC case this was not possible since the instruction has a return value which is the return state of the stor

[Qemu-devel] [RFC v4 2/9] softmmu: Add new TLB_EXCL flag

2015-08-07 Thread Alvise Rigo
Add a new TLB flag to force all the accesses made to a page to follow the slow-path. In the case we remove a TLB entry marked as EXCL, we unset the corresponding exclusive bit in the bitmap. Suggested-by: Jani Kokkonen Suggested-by: Claudio Fontana Signed-off-by: Alvise Rigo --- cputlb.c

Re: [Qemu-devel] [ARM SMBIOS V2 PATCH 3/6] smbios: pass ram size as a parameter to build smbios tables

2015-08-07 Thread Wei Huang
On 08/07/2015 11:41 AM, Laszlo Ersek wrote: > On 08/06/15 19:14, Wei Huang wrote: >> This patch adds a new parameter, mem_size, to smbios_get_tables() >> function. This step is required to make smbios code architect-independent. > > (1) "architecture"-independent It was pointed out before; but s

Re: [Qemu-devel] [ARM SMBIOS V2 PATCH 4/6] smbios: move smbios code into a common folder

2015-08-07 Thread Laszlo Ersek
On 08/06/15 19:14, Wei Huang wrote: > To share smbios among different architectures, this patch moves SMBIOS > code (smbios.c and smbios.h) from x86 specific folders into new > hw/smbios directories. Makes sense to me; "acpi" is also under "hw". > As a result, CONFIG_SMBIOS=y is defined in > x86

Re: [Qemu-devel] [ARM SMBIOS V2 PATCH 3/6] smbios: pass ram size as a parameter to build smbios tables

2015-08-07 Thread Laszlo Ersek
On 08/06/15 19:14, Wei Huang wrote: > This patch adds a new parameter, mem_size, to smbios_get_tables() > function. This step is required to make smbios code architect-independent. (1) "architecture"-independent > > Signed-off-by: Wei Huang > --- > hw/i386/pc.c | 2 +- > hw/i386/sm

Re: [Qemu-devel] [ARM SMBIOS V2 PATCH 2/6] smbios: remove dependency on x86 e820 tables

2015-08-07 Thread Laszlo Ersek
On 08/06/15 19:14, Wei Huang wrote: > Current smbios builds type 19 table from e820, which is x86 specific. > This patch removes smbios' dependency on e820 by passing an array > of memory area to smbios_get_tables(). > > Signed-off-by: Wei Huang > --- > hw/i386/pc.c | 18

Re: [Qemu-devel] [ARM SMBIOS V2 PATCH 1/6] smbios: extract x86 smbios building code into a function

2015-08-07 Thread Laszlo Ersek
On 08/06/15 19:14, Wei Huang wrote: > This patch extracts out the procedure of buidling x86 SMBIOS tables > into a dedicated function. > > Signed-off-by: Wei Huang > --- > hw/i386/pc.c | 38 ++ > 1 file changed, 22 insertions(+), 16 deletions(-) > > diff --gi

Re: [Qemu-devel] [PATCH v3 2/3] sPAPR: Support RTAS call ibm, {open, close}-errinjct

2015-08-07 Thread Alexey Kardashevskiy
On 08/07/2015 01:33 PM, Gavin Shan wrote: The patch supports RTAS calls "ibm,{open,close}-errinjct" to manupliate the token, which is passed to RTAS call "ibm,errinjct" to indicate the valid context for error injection. Each VM is permitted to have only one token at once and we simply have one ra

[Qemu-devel] [PATCH v2] target-cris: update CPU state save/load to use VMStateDescription

2015-08-07 Thread Peter Maydell
From: Juan Quintela Update the CRIS CPU state save/load to use a VMStateDescription struct rather than cpu_save/cpu_load functions. Have to define TLBSet struct. Multidimensional arrays in C are a mess, just unroll them. Signed-off-by: Juan Quintela [PMM: * expand commit message a little sinc

Re: [Qemu-devel] [PATCH v2 2/5] block: Avoid BlockDriverState.filename

2015-08-07 Thread Max Reitz
On 06.08.2015 04:27, Wen Congyang wrote: On 08/06/2015 04:52 AM, Max Reitz wrote: In places which directly pass a filename to the OS, we should not use the filename field at all but exact_filename instead (although the former currently equals the latter if that is set). In qemu-img's map comman

Re: [Qemu-devel] [PATCH v2 0/3] hw/arm/gic: Code duplication removal

2015-08-07 Thread Peter Maydell
On 5 August 2015 at 08:05, Pavel Fedin wrote: > I decided to make this small patchset in order to try to push some of my > changes before 2.4 is out. Idea of first patch of this set came during > vGICv3 implementation. In order to be able to upstream it earlier i decided > to make it doing somethi

Re: [Qemu-devel] [PATCH v2 1/5] block: Change bdrv_get_encrypted_filename()

2015-08-07 Thread Max Reitz
On 06.08.2015 04:01, Wen Congyang wrote: On 08/06/2015 04:52 AM, Max Reitz wrote: Instead of returning a pointer to the filename, copy it into a buffer specified by the caller. Signed-off-by: Max Reitz --- block.c | 24 +--- include/block/block.h | 2 +-

Re: [Qemu-devel] [PATCH v13 00/19] i.MX: Add i.MX25 support through the PDK evaluation board

2015-08-07 Thread Peter Maydell
On 16 July 2015 at 22:21, Jean-Christophe Dubois wrote: > This series of patches add the support for the i.MX25 processor through the > Freescale PDK evaluation board. > > For now a limited set of devices is supported. > * GPT timers (from i.MX31) > * EPIT timers (from i.MX31) > * Seri

Re: [Qemu-devel] [PATCH v13 19/19] i.MX: Adding i2C devices to i.MX31 SOC

2015-08-07 Thread Peter Maydell
On 16 July 2015 at 22:21, Jean-Christophe Dubois wrote: > Signed-off-by: Jean-Christophe Dubois The usual commit message verb form is "Add foo", not "Adding foo". Empty commit message bodies are also generally worth avoiding. > @@ -154,6 +159,31 @@ static void fsl_imx31_realize(DeviceState *dev

Re: [Qemu-devel] [PATCH v12 17/19] i.MX: Add the i.MX25 PDK plateform

2015-08-07 Thread Peter Maydell
On 11 July 2015 at 00:31, Jean-Christophe Dubois wrote: > Tested by booting a minimal Linux system on the emulated platform > Tested by booting the Xvisor hyprvisor on the emulated platform Typo in subject: "platform". This commit message could probably use a little elaboration. What is a PDK bo

Re: [Qemu-devel] [PATCH v13 16/19] i.MX: Add SOC support for i.MX25

2015-08-07 Thread Peter Maydell
On 16 July 2015 at 22:21, Jean-Christophe Dubois wrote: > For now we support the following devices: > * CPU: ARM926 > * Interrupt Controller: AVIC > * CCM > * UART x 5 > * EPIT x 2 > * GPT x 4 > * FEC > * I2C x 3 > > Signed-off-by: Jean-Christoph

Re: [Qemu-devel] [PATCH v13 13/19] i.MX: KZM now uses the standalone i.MX31 SOC support

2015-08-07 Thread Peter Maydell
On 16 July 2015 at 22:21, Jean-Christophe Dubois wrote: > Tested by booting a minimal Linux system on the emulated platform > > Signed-off-by: Jean-Christophe Dubois > --- This said: > - * 0x8000-0x87ff RAM EMULATED > - * 0x8800-0x8fff RAM Aliasing

Re: [Qemu-devel] [PATCH for-2.5 5/6] qmp: add monitor command to add/remove a child

2015-08-07 Thread Alberto Garcia
On Fri 31 Jul 2015 11:19:14 AM CEST, Wen Congyang wrote: > +## > +# @child-add > +# > +# Add a new child to quorum. This is useful to fix a broken quorum > child. But the idea is that this can be eventually used by other drivers, isn't it? Berto

Re: [Qemu-devel] [PATCH for-2.5 1/6] QAPI: move InetSocketAddress to qapi/common.json

2015-08-07 Thread Alberto Garcia
On Fri 31 Jul 2015 11:19:10 AM CEST, Wen Congyang wrote: > It will be used by BlockdevOptionsNBD. > > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v13 18/19] i.MX: Add qtest support for I2C device emulator.

2015-08-07 Thread Peter Maydell
On 16 July 2015 at 22:21, Jean-Christophe Dubois wrote: > This is using a ds1338 RTC chip on the I2C bus. This RTC chip is > not present on the real 3DS PDK board. > > Signed-off-by: Jean-Christophe Dubois 'make check' doesn't pass with this patch, because it tries to start an "imx25_3ds" machin

[Qemu-devel] [PATCH 5/6] target-arm: Implement missing EL3 TLB invalidate operations

2015-08-07 Thread Peter Maydell
Implement the remaining stage 1 TLB invalidate operations visible from EL3. Signed-off-by: Peter Maydell --- target-arm/helper.c | 76 + 1 file changed, 76 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index a8d37c6..580

[Qemu-devel] [PATCH 2/6] target-arm: Move TLBI ALLE1/ALLE1IS definitions into numeric order

2015-08-07 Thread Peter Maydell
Move the two regdefs for TLBI ALLE1 and TLBI ALLE1IS down so that the whole set of AArch64 TLBI regdefs is arranged in numeric order. Signed-off-by: Peter Maydell --- target-arm/helper.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/target-arm/helper.c b/ta

Re: [Qemu-devel] [PATCH for-2.5 2/6] support nbd driver in blockdev-add

2015-08-07 Thread Alberto Garcia
On Fri 31 Jul 2015 11:19:11 AM CEST, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > qapi/block-core.json | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) Reviewed-by: Alberto Garcia Berto

[Qemu-devel] [PATCH 6/6] target-arm: Implement AArch64 TLBI operations on IPAs

2015-08-07 Thread Peter Maydell
Implement the AArch64 TLBI operations which take an intermediate physical address and invalidate stage 2 translations. Signed-off-by: Peter Maydell --- target-arm/helper.c | 55 + 1 file changed, 55 insertions(+) diff --git a/target-arm/helper

[Qemu-devel] [PATCH 1/6] cputlb: Add functions for flushing TLB for a single MMU index

2015-08-07 Thread Peter Maydell
Guest CPU TLB maintenance operations may be sufficiently specialized to only need to flush TLB entries corresponding to a particular MMU index. Implement cputlb functions for this, to avoid the inefficiency of flushing TLB entries which we don't need to. Signed-off-by: Peter Maydell --- cputlb.c

[Qemu-devel] [PATCH 4/6] target-arm: Implement missing EL2 TLBI operations

2015-08-07 Thread Peter Maydell
Implement the missing TLBI operations that exist only if EL2 is implemented. Signed-off-by: Peter Maydell --- target-arm/helper.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/target-arm/helper.c b/target-arm/helper.c index c53fecf..a8d37c6 100644 --- a/target-arm/h

[Qemu-devel] [PATCH 3/6] target-arm: Restrict AArch64 TLB flushes to the MMU indexes they must touch

2015-08-07 Thread Peter Maydell
Now we have the ability to flush the TLB only for specific MMU indexes, update the AArch64 TLB maintenance instruction implementations to only flush the parts of the TLB they need to, rather than doing full flushes. We take the opportunity to remove some duplicate functions (the per-asid tlb ops w

[Qemu-devel] [PATCH 0/6] flush TLBs for one MMUidx only, missing AArch64 TLB ops

2015-08-07 Thread Peter Maydell
This series does three things: (1) implement the "flush the TLB only for a specified MMU index" functionality that we talked about when we added all the new MMU index values for ARM for EL2 and EL3 (2) use that to restrict the AArch64 TLB maintenance operations to only the MMU indexes they need t

Re: [Qemu-devel] [PATCH 3/5] Implement fw_cfg DMA interface

2015-08-07 Thread Eric Blake
On 08/06/2015 03:32 PM, Laszlo Ersek wrote: > (If you wanted to poke fun at me, you could say that I just repeated > what Kevin had said, only worse. Thing is, I really don't recall seeing > his message. Let me search my mailbox for a substring from your above > quote... Yep, I don't have that mes

Re: [Qemu-devel] The issue about parameters(uint64) of a device are treated as signed long int.

2015-08-07 Thread Eric Blake
On 08/06/2015 10:54 PM, Lin Ma wrote: > Hi Paolo, > > As mentioned in below email, The type of wwn is reported as uint64, But > in qemu command line, The max valid value for wwn is > 0x7fff. Obviously, it's treated as int64 there. I'd like to > know that does the highest bit of _world

Re: [Qemu-devel] [PATCH for-2.5 4/6] quorum: implement block driver interfaces add/delete a BDS's child

2015-08-07 Thread Alberto Garcia
On Fri 31 Jul 2015 11:19:13 AM CEST, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > Cc: Alberto Garcia > --- > block/quorum.c | 74 > -- > 1 file changed, 72 insertions(+), 2 d

Re: [Qemu-devel] [PATCH for-2.5 3/6] Add new block driver interface to add/delete a BDS's child

2015-08-07 Thread Alberto Garcia
On Fri 07 Aug 2015 03:03:07 AM CEST, Wen Congyang wrote: >>> +void bdrv_add_child(BlockDriverState *bs, QDict *options, Error **errp) >>> +{ >>> + >>> +if (!bs->drv || !bs->drv->bdrv_add_child) { >>> +error_setg(errp, "The BDS %s doesn't support adding a child", >>> +

Re: [Qemu-devel] [RFC PATCH v4 05/11] xics_kvm: Add cpu_destroy method to XICS

2015-08-07 Thread Bharata B Rao
On Thu, Aug 06, 2015 at 10:57:11AM +0530, Bharata B Rao wrote: > XICS is setup for each CPU during initialization. Provide a routine > to undo the same when CPU is unplugged. > > This allows reboot of a VM that has undergone CPU hotplug and unplug > to work correctly. > > Signed-off-by: Bharata B

Re: [Qemu-devel] [ARM SMBIOS V1 PATCH 0/6] SMBIOS Support for ARM

2015-08-07 Thread Ard Biesheuvel
On 5 August 2015 at 20:35, Laszlo Ersek wrote: > On 08/05/15 19:35, Peter Maydell wrote: [...] >> Is support for [SMBIOS 3.0] in the mainline kernel yet? > > Yes, it is. See (minimally) > > $ git log --reverse fc43026278^.. -- drivers/firmware/dmi* > > There are patches for arch/arm64/ and drivers

Re: [Qemu-devel] virtio 1 issues

2015-08-07 Thread Cornelia Huck
On Fri, 07 Aug 2015 13:07:35 +0800 Jason Wang wrote: > > 2. ring resizing is broken - it actually has a comment: > > /* TODO: need a way to put num back on reset. */ > > guest that runs out of memory might down-size the ring. > > Afterwards, ring size won't come back up after reset - not

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2015-08-07 Thread Fam Zheng
On Fri, 08/07 11:19, Stefan Hajnoczi wrote: > It is definitely a reply rather than a top-level post. Here is what > the headers look like here: > > Delivered-To: stefa...@gmail.com > Date: Wed, 29 Jul 2015 11:33:26 +0200 > From: Samuel Thibault > To: qemu-devel > Message-ID: <20150729093326.gg2

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Samuel Thibault as slirp maintainer

2015-08-07 Thread Stefan Hajnoczi
On Thu, Aug 6, 2015 at 1:29 PM, Fam Zheng wrote: > On Thu, 08/06 11:10, Stefan Hajnoczi wrote: >> On Wed, Jul 29, 2015 at 11:33:26AM +0200, Samuel Thibault wrote: >> > Signed-off-by: Samuel Thibault >> > >> > --- >> > Jan Kiszka, le Wed 29 Jul 2015 09:36:15 +0200, a écrit : >> > > On 2015-07-29 0

Re: [Qemu-devel] [PATCH v6 00/12] Dirty bitmaps migration

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
Sorry for 'vsement...@parallels.com' in patches. I've just fixed this locally and I'm ready to roll v7 with all my emails fixed. I'm waiting for other comments. On 07.08.2015 12:32, Vladimir Sementsov-Ogievskiy wrote: From: Vladimir Sementsov-Ogievskiy These patches provide dirty bitmap migr

[Qemu-devel] [PATCH 12/12] iotests: add dirty bitmap migration test

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy The test starts two vms (vm_a, vm_b), create dirty bitmap in the first one, do several writes to corresponding device and then migrate vm_a to vm_b with dirty bitmaps. Reviewed-by: John Snow Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/

[Qemu-devel] [PATCH 11/12] qapi: add md5 checksum of last dirty bitmap level to query-block

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c| 1 + include/qemu/hbitmap.h | 8 qapi/block-core.json | 4 +++- util/hbitmap.c | 8 4 files changed, 20 insertions(+), 1 deletion(-) d

[Qemu-devel] [PATCH 09/12] iotests: maintain several vms in test

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy The only problem with it is the same qmp socket name (which is vm._monitor_path) for all vms. And because of this second vm couldn't be lauched (vm.launch() fails because of socket is already in use). This patch adds a number of vm into vm._monitor_path Reviewe

[Qemu-devel] [PATCH 10/12] iotests: add add_incoming_migration to VM class

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/iotests.py | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index 8ebed31..85c5a99 100644 --- a/te

[Qemu-devel] [PATCH 08/12] migration: add migration/block-dirty-bitmap.c

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Live migration of dirty bitmaps. Only named dirty bitmaps, associated with root nodes and non-root named nodes are migrated. If destination qemu is already containing a dirty bitmap with the same name as a migrated bitmap (for the same node), than, if their gra

[Qemu-devel] [PATCH 07/12] migration/qemu-file: add qemu_put_counted_string()

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
Add function opposite to qemu_get_counted_string. qemu_put_counted_string puts one-byte length of the string (string should not be longer than 255 characters), and then it puts the string, without last zero byte. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/migration/qemu-file.h | 2 +

[Qemu-devel] [PATCH 04/12] block: add meta bitmaps

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Meta bitmap is a 'dirty bitmap' for the BdrvDirtyBitmap. It tracks changes (set/unset) of this BdrvDirtyBitmap. It is needed for live migration of block dirty bitmaps. Reviewed-by: John Snow Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c

[Qemu-devel] [PATCH 03/12] block: tiny refactoring: minimize hbitmap_(set/reset) usage

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 8937296..7a7307c 100644 --- a/block.c +++ b/block.c @@ -3616,7 +3616,7 @@ void bdrv_set_

[Qemu-devel] [PATCH 01/12] hbitmap: serialization

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Functions to serialize / deserialize(restore) HBitmap. HBitmap should be saved to linear sequence of bits independently of endianness and bitmap array element (unsigned long) size. Therefore Little Endian is chosen. These functions are appropriate for dirty bit

[Qemu-devel] [PATCH 06/12] qapi: add dirty-bitmaps migration capability

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/migration/migration.h | 1 + migration/migration.c | 9 + qapi-schema.json | 4 +++- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/inc

[Qemu-devel] [PATCH v6 00/12] Dirty bitmaps migration

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy These patches provide dirty bitmap migration feature. Only named dirty bitmaps are to be migrated. Migration may be enabled using migration capabilities. v6: - rebase on master - function qemu_get_string() deleted, used existed function qemu

[Qemu-devel] [PATCH 05/12] block: add bdrv_next_dirty_bitmap()

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Like bdrv_next() - bdrv_next_dirty_bitmap() is a function to provide access to private dirty bitmaps list. Reviewed-by: John Snow Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 10 ++ include/block/block.h | 2 ++ 2 files c

[Qemu-devel] [PATCH 02/12] block: BdrvDirtyBitmap serialization interface

2015-08-07 Thread Vladimir Sementsov-Ogievskiy
From: Vladimir Sementsov-Ogievskiy Several functions to provide necessary access to BdrvDirtyBitmap for block-migration.c Reviewed-by: John Snow Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 36 include/block/block.h | 13

Re: [Qemu-devel] PO makefile rules touching source

2015-08-07 Thread Fam Zheng
On Fri, 08/07 10:09, Dr. David Alan Gilbert wrote: > * Stefan Weil (s...@weilnetz.de) wrote: > > Am 06.08.2015 um 13:54 schrieb Dr. David Alan Gilbert: > > >Hi Stefan, > > > I don't really understand the way PO stuff is supposed to work, > > >but I often get the problem that my git tree gets chan

Re: [Qemu-devel] PO makefile rules touching source

2015-08-07 Thread Dr. David Alan Gilbert
* Stefan Weil (s...@weilnetz.de) wrote: > Am 06.08.2015 um 13:54 schrieb Dr. David Alan Gilbert: > >Hi Stefan, > > I don't really understand the way PO stuff is supposed to work, > >but I often get the problem that my git tree gets changed during > >an out of tree build, causing the po subdirecto

  1   2   >