Re: [Qemu-devel] [RFC PATCH qemu v2 1/5] vfio: Switch from TARGET_PAGE_MASK to qemu_real_host_page_mask

2015-07-13 Thread Alexey Kardashevskiy
On 07/14/2015 05:13 AM, Alex Williamson wrote: On Tue, 2015-07-14 at 00:56 +1000, Alexey Kardashevskiy wrote: These started switching from TARGET_PAGE_MASK (hardcoded as 4K) to a real host page size: 4e51361d7 "cpu-all: complete "real" host page size API" and f7ceed190 "vfio: cpu: Use "real" pag

Re: [Qemu-devel] vm internal snapshot deletes only delete first disk's snapshots

2015-07-13 Thread Marcus
Ok, this is weird. It looks like it dies on the first disk, which is the only one that actually gets its snapshot removed. Perhaps it is processing the first disk a second time? # virsh qemu-monitor-command i-2-38-VM --hmp 'delvm 1' Error while deleting snapshot on device 'virtio-disk0': Can't fi

Re: [Qemu-devel] [PATCH] ich9: fix skipped vmstate_memhp_state subsection

2015-07-13 Thread Amit Shah
On (Mon) 13 Jul 2015 [17:45:42], Paulo Alcantara wrote: > By declaring another .subsections array for vmstate_tco_io_state made > vmstate_memhp_state not registered anymore. There must be only one > .subsections array for all subsections. > > Cc: Michael S. Tsirkin > Cc: Amit Shah > Reported-by:

[Qemu-devel] vm internal snapshot deletes only delete first disk's snapshots

2015-07-13 Thread Marcus
Hi all, I've recently been toying with VM snapshots, and have ran into an issue. Given a VM with multiple disks, it seems a snapshot-create followed by a snapshot-delete will only remove the qcow2 snapshot for the first disk (or perhaps just the disk that contains the memory), not all of the d

Re: [Qemu-devel] [PATCH] hw/pxb: add chassis_nr property

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 01:35:09PM +0300, Marcel Apfelbaum wrote: > On 06/28/2015 06:17 PM, Marcel Apfelbaum wrote: > >On 06/18/2015 08:49 PM, Marcel Apfelbaum wrote: > >>Add a chassis_nr property Instead of using PXB bus number > >>as internal bridge's chassis nr. > >ping > > > >I think this shoul

Re: [Qemu-devel] [RFC 0/6] vSMMU initialization

2015-07-13 Thread Varun Sethi
Hi Will, > -Original Message- > From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- > boun...@lists.linux-foundation.org] On Behalf Of Will Deacon > Sent: Friday, June 12, 2015 7:53 PM > To: Baptiste Reynal > Cc: io...@lists.linux-foundation.org; t...@virtualopensystems.com; > qe

Re: [Qemu-devel] [PATCH qemu 1/5] vfio: Switch from TARGET_PAGE_MASK to qemu_real_host_page_mask

2015-07-13 Thread David Gibson
On Mon, Jul 13, 2015 at 05:24:17PM +1000, Alexey Kardashevskiy wrote: > On 07/13/2015 04:15 PM, David Gibson wrote: > >On Fri, Jul 10, 2015 at 08:43:44PM +1000, Alexey Kardashevskiy wrote: > >>These started switching from TARGET_PAGE_MASK (hardcoded as 4K) to > >>a real host page size: > >>4e51361d

Re: [Qemu-devel] [PATCH 0/3] rcu: missing thread registration

2015-07-13 Thread Fam Zheng
On Mon, 07/13 13:31, Paolo Bonzini wrote: > Patch 2 fixes the problem, whereby threads were not being registered > but still happily used RCU. Patch 1 simplifies the registration by > making rcu_unregister_thread automatic. Patch 3 avoids having the > same bug in the future. Reviewed-by: Fam Zhe

Re: [Qemu-devel] [PATCH v3 12/15] block/backup: support block job transactions

2015-07-13 Thread Fam Zheng
On Mon, 07/13 19:14, John Snow wrote: > > +static void backup_txn_commit(BlockJob *job) > > +{ > > +BackupBlockJob *s = container_of(job, BackupBlockJob, common); > > +if (s->sync_bitmap) { > > +backup_handle_dirty_bitmap(s, 0); > > +} > > +} > > + > > +static void backup_txn_ab

Re: [Qemu-devel] [PATCH v3 10/15] block: add block job transactions

2015-07-13 Thread Fam Zheng
On Mon, 07/13 19:12, John Snow wrote: > > > On 07/09/2015 11:46 PM, Fam Zheng wrote: > > From: Stefan Hajnoczi > > > > Sometimes block jobs must execute as a transaction group. Finishing > > jobs wait until all other jobs are ready to complete successfully. > > Failure or cancellation of one j

Re: [Qemu-devel] [PATCH v3 05/15] backup: Extract dirty bitmap handling as a separate function

2015-07-13 Thread Fam Zheng
On Mon, 07/13 19:06, John Snow wrote: > > > On 07/09/2015 11:46 PM, Fam Zheng wrote: > > This will be reused by the coming new transactional completion code. > > > > Signed-off-by: Fam Zheng > > --- > > block/backup.c | 26 -- > > 1 file changed, 16 insertions(+), 10 de

[Qemu-devel] [Bug 1384892] Re: RTL8168 NIC VFIO not working anymore since QEMU 2.1

2015-07-13 Thread Alex Williamson
Thorsten, is this the patch you're suggesting then? http://fpaste.org/244037/43684040/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1384892 Title: RTL8168 NIC VFIO not working anymore since QEMU

Re: [Qemu-devel] [PATCH v3 12/15] block/backup: support block job transactions

2015-07-13 Thread John Snow
On 07/09/2015 11:46 PM, Fam Zheng wrote: > From: Stefan Hajnoczi > > Join the transaction when the 'transactional-cancel' QMP argument is > true. > > This ensures that the sync bitmap is not thrown away if another block > job in the transaction is cancelled or fails. This is critical so > inc

Re: [Qemu-devel] [PATCH v3 15/15] tests: add BlockJobTxn unit test

2015-07-13 Thread John Snow
On 07/09/2015 11:46 PM, Fam Zheng wrote: > From: Stefan Hajnoczi > > The BlockJobTxn unit test verifies that both single jobs and pairs of > jobs behave as a transaction group. Either all jobs complete > successfully or the group is cancelled. > > Signed-off-by: Stefan Hajnoczi > Signed-off-

Re: [Qemu-devel] [PATCH v3 10/15] block: add block job transactions

2015-07-13 Thread John Snow
On 07/09/2015 11:46 PM, Fam Zheng wrote: > From: Stefan Hajnoczi > > Sometimes block jobs must execute as a transaction group. Finishing > jobs wait until all other jobs are ready to complete successfully. > Failure or cancellation of one job cancels the other jobs in the group. > > Signed-of

Re: [Qemu-devel] [PATCH v3 07/15] blockjob: Add "completed" and "ret" in BlockJob

2015-07-13 Thread John Snow
On 07/09/2015 11:46 PM, Fam Zheng wrote: > They are set when block_job_completed is called. > > Signed-off-by: Fam Zheng > --- > blockjob.c | 3 +++ > include/block/blockjob.h | 9 + > 2 files changed, 12 insertions(+) > > diff --git a/blockjob.c b/blockjob.c > index 62b

Re: [Qemu-devel] [PATCH v3 08/15] blockjob: Simplify block_job_finish_sync

2015-07-13 Thread John Snow
On 07/09/2015 11:46 PM, Fam Zheng wrote: > With job->completed and job->ret to replace BlockFinishData. > > Signed-off-by: Fam Zheng > --- > blockjob.c | 23 ++- > 1 file changed, 2 insertions(+), 21 deletions(-) > > diff --git a/blockjob.c b/blockjob.c > index fb1d9e7..11

Re: [Qemu-devel] [PATCH v3 06/15] blockjob: Add .txn_commit and .txn_abort transaction actions

2015-07-13 Thread John Snow
On 07/09/2015 11:46 PM, Fam Zheng wrote: > They will be called if the job is part of a transaction, after all jobs in a > transaction are completed or cancelled, before calling job->cb(). > > Signed-off-by: Fam Zheng > --- > include/block/blockjob.h | 12 > 1 file changed, 12 inse

Re: [Qemu-devel] [PATCH v3 05/15] backup: Extract dirty bitmap handling as a separate function

2015-07-13 Thread John Snow
On 07/09/2015 11:46 PM, Fam Zheng wrote: > This will be reused by the coming new transactional completion code. > > Signed-off-by: Fam Zheng > --- > block/backup.c | 26 -- > 1 file changed, 16 insertions(+), 10 deletions(-) > > diff --git a/block/backup.c b/block/back

Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-13 Thread Eric Blake
On 07/13/2015 02:09 PM, Gabriel L. Somlo wrote: > 2. File names are listed in /sys/fs/fw_cfg/... with slashes replaced >exclamation marks, e.g.: Instead of inventing yet another escaping mechanism, can you mimic an already existing convention such as systemd's escaping? http://www.freedesktop

Re: [Qemu-devel] [RFC PATCH V2 3/3] cpus: introduce async_run_safe_work_on_cpu.

2015-07-13 Thread Paolo Bonzini
On 13/07/2015 18:20, Alex Bennée wrote: >> +static void qemu_cpu_kick_thread(CPUState *cpu) >> +{ >> +#ifndef _WIN32 >> +int err; >> + >> +err = pthread_kill(cpu->thread->thread, SIG_IPI); >> +if (err) { >> +fprintf(stderr, "qemu:%s: %s", __func__, strerror(err)); >> +

Re: [Qemu-devel] [PATCH v3 14/16] acpi: Add a way for devices to add ACPI tables

2015-07-13 Thread Corey Minyard
On 07/09/2015 03:25 AM, Igor Mammedov wrote: > On Wed, 8 Jul 2015 22:39:24 +0200 > Paolo Bonzini wrote: > >> >> On 08/07/2015 21:26, Igor Mammedov wrote: This was suggested by Michael, so I think you should read the reviews of earlier versions first. >>> That is basically the same as hoo

Re: [Qemu-devel] [PATCH 2/2] target-arm: Add "anyvfp" CPU

2015-07-13 Thread Peter Crosthwaite
On Mon, Jul 13, 2015 at 1:21 PM, Meador Inge wrote: > On Mon, Jul 06, 2015 at 03:00:20PM -0700, Peter Crosthwaite wrote: > >> So a better way to do this is via QOM properties. You can propertyify >> VFP support on the QOM type ARMCPU then users can use -global to set >> in on the command line. You

Re: [Qemu-devel] [PATCH for-2.4] i.MX: Fix UART driver to work with unitialized "chardev" device

2015-07-13 Thread Jean-Christophe DUBOIS
Do you expect a v2 version of this patch that fix the patch description? JC Le 11/07/2015 11:00, Peter Crosthwaite a écrit : On Thu, Jul 9, 2015 at 2:29 AM, Jean-Christophe Dubois wrote: The "chardev" property initialisation might failed (for example because there is not enough chardev handle

Re: [Qemu-devel] [PATCH] vmstate: remove unused declaration

2015-07-13 Thread Marc-André Lureau
cc-ing qemu trivial On Tue, Jun 23, 2015 at 6:41 PM, Marc-André Lureau wrote: > Since 38e0735e, register_device_unmigratable() has been removed > > Signed-off-by: Marc-André Lureau > --- > include/migration/vmstate.h | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/include/migration/v

Re: [Qemu-devel] [PATCH v2 1/1] xlnx-zynqmp: Connect the four OCM banks

2015-07-13 Thread Alistair Francis
On Mon, Jul 13, 2015 at 12:48 PM, Peter Crosthwaite wrote: > On Mon, Jul 13, 2015 at 11:54 AM, Alistair Francis > wrote: >> The Xilinx EP108 has four separate OCM banks which are located >> adjacent to each other. This patch adds the four banks to >> the ZynqMP SoC. >> >> Signed-off-by: Alistair

[Qemu-devel] [PATCH] ich9: fix skipped vmstate_memhp_state subsection

2015-07-13 Thread Paulo Alcantara
By declaring another .subsections array for vmstate_tco_io_state made vmstate_memhp_state not registered anymore. There must be only one .subsections array for all subsections. Cc: Michael S. Tsirkin Cc: Amit Shah Reported-by: Amit Shah Signed-off-by: Paulo Alcantara --- hw/acpi/ich9.c | 3 --

Re: [Qemu-devel] [PATCH 2/2] target-arm: Add "anyvfp" CPU

2015-07-13 Thread Meador Inge
On Mon, Jul 06, 2015 at 11:31:37PM +0100, Peter Maydell wrote: > I'm not convinced. System mode gives you a bare metal > system -- it's the bare metal app's job to enable > VFP if it wants to use it. If your bare metal app > doesn't do that then it is broken. Fair enough. I knew this patch would

Re: [Qemu-devel] [PATCH 0/2] target-arm: "any" CPUs for system-mode

2015-07-13 Thread Meador Inge
On Mon, Jul 06, 2015 at 04:05:46PM -0700, Peter Crosthwaite wrote: > On Mon, Jul 6, 2015 at 3:49 PM, Peter Maydell > wrote: > > On 6 July 2015 at 23:42, Peter Crosthwaite > > wrote: > >> On Mon, Jul 6, 2015 at 3:29 PM, Peter Maydell > >> wrote: > >>> On 6 July 2015 at 19:53, wrote: >

Re: [Qemu-devel] [PATCH qemu 1/5] vfio: Switch from TARGET_PAGE_MASK to qemu_real_host_page_mask

2015-07-13 Thread Peter Crosthwaite
On Sun, Jul 12, 2015 at 11:15 PM, David Gibson wrote: > On Fri, Jul 10, 2015 at 08:43:44PM +1000, Alexey Kardashevskiy wrote: >> These started switching from TARGET_PAGE_MASK (hardcoded as 4K) to >> a real host page size: >> 4e51361d7 "cpu-all: complete "real" host page size API" and >> f7ceed190

Re: [Qemu-devel] [PATCH 2/2] target-arm: Add "anyvfp" CPU

2015-07-13 Thread Meador Inge
On Mon, Jul 06, 2015 at 03:00:20PM -0700, Peter Crosthwaite wrote: > So a better way to do this is via QOM properties. You can propertyify > VFP support on the QOM type ARMCPU then users can use -global to set > in on the command line. You could do this for any number of ARM CPU > features you car

Re: [Qemu-devel] [PATCH v4 4/7] pc: fix QEMU crashing when more than ~50 memory hotplugged

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 08:55:13PM +0200, Igor Mammedov wrote: > On Mon, 13 Jul 2015 09:55:18 +0300 > "Michael S. Tsirkin" wrote: > > > On Fri, Jul 10, 2015 at 12:12:36PM +0200, Igor Mammedov wrote: > > > On Thu, 9 Jul 2015 16:46:43 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Thu,

[Qemu-devel] RFC: guest-side retrieval of fw_cfg file

2015-07-13 Thread Gabriel L. Somlo
Hi, A while ago I was pondering on the options available for retrieving a fw_cfg blob from the guest-side (now that we can insert fw_cfg files on the host-side command line, see commit 81b2b8106). So over the last couple of weekends I cooked up the sysfs kernel module below, which lists all fw_cf

Re: [Qemu-devel] [PATCH 1/4] linux-user: Exit 0 when -h is used

2015-07-13 Thread Meador Inge
On Mon, Jul 06, 2015 at 09:43:20PM +0200, Laurent Vivier wrote: > Global comment: you should use EXIT_SUCCESS and EXIT_FAILURE from stdlib.h On second thought, I was following an existing pattern in 'main.c'. Really fixing this would require changing around 30 other locations too. I think if we

Re: [Qemu-devel] [PATCH v2 1/1] xlnx-zynqmp: Connect the four OCM banks

2015-07-13 Thread Peter Crosthwaite
On Mon, Jul 13, 2015 at 11:54 AM, Alistair Francis wrote: > The Xilinx EP108 has four separate OCM banks which are located > adjacent to each other. This patch adds the four banks to > the ZynqMP SoC. > > Signed-off-by: Alistair Francis Reviewed-by: Peter Crosthwaite > --- > V2: > - Localise

Re: [Qemu-devel] [PATCH v3 04/15] block: keep bitmap if incremental backup job is cancelled

2015-07-13 Thread John Snow
On 07/09/2015 11:46 PM, Fam Zheng wrote: > From: Stefan Hajnoczi > > Reclaim the dirty bitmap if an incremental backup block job is > cancelled. The ret variable may be 0 when the job is cancelled so it's > not enough to check ret < 0. > > Signed-off-by: Stefan Hajnoczi > Reviewed-by: Fam Zh

[Qemu-devel] [Bug 1384892] Re: RTL8168 NIC VFIO not working anymore since QEMU 2.1

2015-07-13 Thread Florian Wickert
I had too many problems with the Chipset so I decided to sell the System. As a result I cannot test for this bug anymore, sorry. Thanks anyway for your effort on this problem! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bu

Re: [Qemu-devel] [PATCH] ide: coverity touchups

2015-07-13 Thread John Snow
On 07/13/2015 03:40 PM, Peter Maydell wrote: > On 13 July 2015 at 20:26, John Snow wrote: >> Just a handful of casts to quiet coverity up. >> >> s->ports should never exceed 32, but coverity doesn't know that. >> ncq_tfs->sector_count should also never exceed 64K. > > Personally I tend to mark

Re: [Qemu-devel] [PATCH] ide: coverity touchups

2015-07-13 Thread Peter Maydell
On 13 July 2015 at 20:26, John Snow wrote: > Just a handful of casts to quiet coverity up. > > s->ports should never exceed 32, but coverity doesn't know that. > ncq_tfs->sector_count should also never exceed 64K. Personally I tend to mark that kind of thing as a false positive in the coverity UI

Re: [Qemu-devel] [RFC PATCH qemu v2 0/5] vfio: SPAPR IOMMU v2 (memory preregistration support)

2015-07-13 Thread Alex Williamson
On Tue, 2015-07-14 at 00:56 +1000, Alexey Kardashevskiy wrote: > Here are few patches to prepare an existing listener for handling memory > preregistration for SPAPR guests running on POWER8. > > This used to be a part of DDW patchset but now is separated as requested. > I left versions in changel

[Qemu-devel] [PATCH] ide: coverity touchups

2015-07-13 Thread John Snow
Just a handful of casts to quiet coverity up. s->ports should never exceed 32, but coverity doesn't know that. ncq_tfs->sector_count should also never exceed 64K. Why not make Coverity a happy camper, though. Signed-off-by: John Snow --- hw/ide/ahci.c | 8 hw/ide/macio.c | 2 +- 2 fi

Re: [Qemu-devel] [RFC PATCH qemu v2 1/5] vfio: Switch from TARGET_PAGE_MASK to qemu_real_host_page_mask

2015-07-13 Thread Alex Williamson
On Tue, 2015-07-14 at 00:56 +1000, Alexey Kardashevskiy wrote: > These started switching from TARGET_PAGE_MASK (hardcoded as 4K) to > a real host page size: > 4e51361d7 "cpu-all: complete "real" host page size API" and > f7ceed190 "vfio: cpu: Use "real" page size API" > > This finished the transit

[Qemu-devel] [Bug 1384892] Re: RTL8168 NIC VFIO not working anymore since QEMU 2.1

2015-07-13 Thread Thorsten Kohfeldt
After investigating a little more I have the impression, that a) Alex's patch #4 is required and b) 'val' does not need to be initialised Thus remains replacing each of the two instances of 0x1000U with 0x8000U, where it remains open whether the 'xor' operation (now on bit 31 rather than

[Qemu-devel] [Bug 1054558] Re: 1366x768 resolution missing

2015-07-13 Thread edmon
I'm using winXP and win7 as guest with this setup and i have 1366x768, but i run it with virt-manager and this is in ps. qemu-system-x86_64 -enable-kvm -name Windows7 -S -machine pc- i440fx-2.0,accel=kvm,usb=off -cpu Westmere,+invpcid,+erms,+bmi2,+smep,+avx2,+bmi1,+fsgsbase,+abm,+rdtscp,+pdpe1gb,+

Re: [Qemu-devel] [PATCH v4 4/7] pc: fix QEMU crashing when more than ~50 memory hotplugged

2015-07-13 Thread Igor Mammedov
On Mon, 13 Jul 2015 09:55:18 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jul 10, 2015 at 12:12:36PM +0200, Igor Mammedov wrote: > > On Thu, 9 Jul 2015 16:46:43 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jul 09, 2015 at 03:43:01PM +0200, Paolo Bonzini wrote: > > > > > > > > > > >

[Qemu-devel] [PATCH v2 1/1] xlnx-zynqmp: Connect the four OCM banks

2015-07-13 Thread Alistair Francis
The Xilinx EP108 has four separate OCM banks which are located adjacent to each other. This patch adds the four banks to the ZynqMP SoC. Signed-off-by: Alistair Francis --- V2: - Localise ocm_name - Use g_strdup_printf() hw/arm/xlnx-zynqmp.c | 15 +++ include/hw/arm/xlnx

Re: [Qemu-devel] [PATCH v1 1/1] xlnx-zynqmp: Connect the four OCM banks

2015-07-13 Thread Alistair Francis
On Sat, Jul 11, 2015 at 1:40 AM, Peter Crosthwaite wrote: > On Fri, Jul 10, 2015 at 11:11 AM, Alistair Francis > wrote: >> The Xilinx EP108 has four separate OCM banks which are located >> adjacent to each other. This patch adds the four banks to >> the ZynqMP SoC. >> >> Signed-off-by: Alistair F

[Qemu-devel] [Bug 1054558] Re: 1366x768 resolution missing

2015-07-13 Thread Javier Barroso
I tried it , but did not get the correct resolution. It takes 1280x768 (black space on both sides) Thank you! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1054558 Title: 1366x768 resolution missi

Re: [Qemu-devel] [PATCH v7 28/42] Postcopy: Postcopy startup in migration thread

2015-07-13 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: >> > + >> > +/* >> > + * send rest of state - note things that are doing postcopy >> > + * will notice we're in POSTCOPY_ACTIVE and not actually >> > + * wrap their state up here >> > + */ >> > +qemu_file_set_rate_limit(ms->file, INT64_MAX);

Re: [Qemu-devel] [PATCH v7 22/42] migrate_start_postcopy: Command to trigger transition to postcopy

2015-07-13 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > Once postcopy is enabled (with migrate_set_capability), the migration >> > will still start on precopy mode. To cause a transitio

Re: [Qemu-devel] [PATCH v7 23/42] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state

2015-07-13 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert" wrote: >> > * Juan Quintela (quint...@redhat.com) wrote: >> >> "Dr. David Alan Gilbert (git)" wrote: >> >> > From: "Dr. David Alan Gilbert" >> >> > >> >> > 'MIGRATION_STATUS_POSTCOPY_ACTIV

[Qemu-devel] [Bug 1384892] Re: RTL8168 NIC VFIO not working anymore since QEMU 2.1

2015-07-13 Thread Thorsten Kohfeldt
Alex, are you sure about the constant 0x1000U (bit 27) being used in the code below ? Shouldn't it rather be a 0x8000U (bit 31 which you commented about) ? I added a /* NOT REACHED ? */ below, as I feel that might be the problem. Florian, are you willing to test the so modified source wit

Re: [Qemu-devel] [PATCH v7 28/42] Postcopy: Postcopy startup in migration thread

2015-07-13 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Rework the migration thread to setup and start postcopy. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > include/migration/migration.h | 3 + > > migration

Re: [Qemu-devel] [PATCH v7 27/42] postcopy: ram_enable_notify to switch on userfault

2015-07-13 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Mark the area of RAM as 'userfault' > > Start up a fault-thread to handle any userfaults we might receive > > from it (to be filled in later) > > > > Signed-off-by: Dr.

Re: [Qemu-devel] [PATCH v7 22/42] migrate_start_postcopy: Command to trigger transition to postcopy

2015-07-13 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Once postcopy is enabled (with migrate_set_capability), the migration > > will still start on precopy mode. To cause a transition into postcopy > > the: > > > > migra

Re: [Qemu-devel] [PATCH qemu 2/5] vfio: Skip PCI BARs in memory listener

2015-07-13 Thread Alex Williamson
On Fri, 2015-07-10 at 20:43 +1000, Alexey Kardashevskiy wrote: > In some cases PCI BARs are registered as RAM via > memory_region_init_ram_ptr() and the vfio_memory_listener will be called > on them too. However DMA will not be performed to/from these regions so > just skip them. Who says? What

Re: [Qemu-devel] [v9][PATCH 08/10] xen, gfx passthrough: register a isa bridge

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 05:14:08PM +0100, Stefano Stabellini wrote: > On Tue, 7 Jul 2015, Tiejun Chen wrote: > > Currently we just register this isa bridge when we use IGD > > passthrough in Xen side. > > > > Signed-off-by: Tiejun Chen > > Acked-by: Stefano Stabellini > > --- > > v9: > > > > *

[Qemu-devel] [PATCH] hw/arm/boot: Increase fdt alignment

2015-07-13 Thread Alexander Graf
The Linux kernel on aarch64 creates a page table entry at early bootup that spans the 2MB range on memory spanning the fdt start address: [ ALIGN_DOWN(fdt, 2MB) ... ALIGN_DOWN(fdt, 2MB) + 2MB ] This means that when our current 4k alignment happens to fall at the end of the aligned region, Linux

Re: [Qemu-devel] [PATCH v7 23/42] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state

2015-07-13 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> "Dr. David Alan Gilbert (git)" wrote: > >> > From: "Dr. David Alan Gilbert" > >> > > >> > 'MIGRATION_STATUS_POSTCOPY_ACTIVE' is entered after > >> > migrate_start

Re: [Qemu-devel] [PATCH 2.4] hw/arm/boot: Increase fdt alignment

2015-07-13 Thread Peter Maydell
On 13 July 2015 at 17:39, Alexander Graf wrote: > Ugh, we don't know the size yet at this point. And calling load_fdt multiple > times feels like a can of worms I don't want to open. So yeah, I'll just > make it depend on the RAM size - if there are >= 128MB RAM in our VM we > align on 2MB. This

Re: [Qemu-devel] [PATCH 2.4] hw/arm/boot: Increase fdt alignment

2015-07-13 Thread Alexander Graf
On 07/13/15 18:27, Peter Maydell wrote: On 13 July 2015 at 17:20, Alexander Graf wrote: On 07/13/15 18:13, Peter Maydell wrote: On 13 July 2015 at 16:56, Alexander Graf wrote: The Linux kernel on aarch64 creates a page table entry at early bootup that spans the 2MB range on memory spanning t

Re: [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.

2015-07-13 Thread Alex Bennée
Paolo Bonzini writes: > On 13/07/2015 18:10, Peter Maydell wrote: >> (4) a few other things which are suspicious at best: >> hw/intc/apic_common.c:volatile int a_i_d = apic_irq_delivered; > > This one has a comment above: > > /* Copy this into a local variable to encourage gcc to emit

Re: [Qemu-devel] [PATCH 2.4] hw/arm/boot: Increase fdt alignment

2015-07-13 Thread Alexander Graf
On 07/13/15 18:27, Peter Maydell wrote: On 13 July 2015 at 17:20, Alexander Graf wrote: On 07/13/15 18:13, Peter Maydell wrote: On 13 July 2015 at 16:56, Alexander Graf wrote: The Linux kernel on aarch64 creates a page table entry at early bootup that spans the 2MB range on memory spanning t

Re: [Qemu-devel] [PATCH v7 21/42] postcopy: OS support test

2015-07-13 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Provide a check to see if the OS we're running on has all the bits > > needed for postcopy. > > > > Creates postcopy-ram.c which will get most of the other helpers we ne

Re: [Qemu-devel] [PATCH 2.4] hw/arm/boot: Increase fdt alignment

2015-07-13 Thread Peter Maydell
On 13 July 2015 at 17:20, Alexander Graf wrote: > On 07/13/15 18:13, Peter Maydell wrote: >> >> On 13 July 2015 at 16:56, Alexander Graf wrote: >>> >>> The Linux kernel on aarch64 creates a page table entry at early bootup >>> that spans the 2MB range on memory spanning the fdt start address: >>>

Re: [Qemu-devel] [PATCH v7 23/42] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state

2015-07-13 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> "Dr. David Alan Gilbert (git)" wrote: >> > From: "Dr. David Alan Gilbert" >> > >> > 'MIGRATION_STATUS_POSTCOPY_ACTIVE' is entered after migrate_start_postcopy >> > >> > 'migration_postcopy_phase' is provided for ot

Re: [Qemu-devel] [RFC PATCH V2 3/3] cpus: introduce async_run_safe_work_on_cpu.

2015-07-13 Thread Alex Bennée
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > We already had async_run_on_cpu but we need all VCPUs outside their execution > loop to execute some tb_flush/invalidate task: > > async_run_on_cpu_safe schedule a work on a VCPU but the work start when no > more > VCPUs are executin

Re: [Qemu-devel] [PATCH 2.4] hw/arm/boot: Increase fdt alignment

2015-07-13 Thread Alexander Graf
On 07/13/15 18:13, Peter Maydell wrote: On 13 July 2015 at 16:56, Alexander Graf wrote: The Linux kernel on aarch64 creates a page table entry at early bootup that spans the 2MB range on memory spanning the fdt start address: [ ALIGN_DOWN(fdt, 2MB) ... ALIGN_DOWN(fdt, 2MB) + 2MB ] This mea

Re: [Qemu-devel] [v9][PATCH 09/10] xen, gfx passthrough: register host bridge specific to passthrough

2015-07-13 Thread Stefano Stabellini
On Tue, 7 Jul 2015, Tiejun Chen wrote: > Just register that pci host bridge specific to passthrough. > > Signed-off-by: Tiejun Chen > Acked-by: Stefano Stabellini This is good, the Acked-by is appropriate. Cheers, Stefano > v9: > > * Simplify pc_xen_hvm_init_pci() > > hw/i386/pc_piix.c |

Re: [Qemu-devel] [v9][PATCH 08/10] xen, gfx passthrough: register a isa bridge

2015-07-13 Thread Stefano Stabellini
On Tue, 7 Jul 2015, Tiejun Chen wrote: > Currently we just register this isa bridge when we use IGD > passthrough in Xen side. > > Signed-off-by: Tiejun Chen > Acked-by: Stefano Stabellini > --- > v9: > > * Move is_igd_vga_passthrough(dev)) from > xen_igd_passthrough_isa_bridge_create() > in

Re: [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.

2015-07-13 Thread Paolo Bonzini
On 13/07/2015 18:10, Peter Maydell wrote: > (4) a few other things which are suspicious at best: > hw/intc/apic_common.c:volatile int a_i_d = apic_irq_delivered; This one has a comment above: /* Copy this into a local variable to encourage gcc to emit a plain * register for a sy

Re: [Qemu-devel] [PATCH 2.4] hw/arm/boot: Increase fdt alignment

2015-07-13 Thread Peter Maydell
On 13 July 2015 at 16:56, Alexander Graf wrote: > The Linux kernel on aarch64 creates a page table entry at early bootup > that spans the 2MB range on memory spanning the fdt start address: > > [ ALIGN_DOWN(fdt, 2MB) ... ALIGN_DOWN(fdt, 2MB) + 2MB ] > > This means that when our current 4k alignm

Re: [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.

2015-07-13 Thread Peter Maydell
On 13 July 2015 at 16:56, Alex Bennée wrote: >> From: KONRAD Frederic >> @@ -322,6 +323,8 @@ struct CPUState { >> (absolute value) offset as small as possible. This reduces code >> size, especially for hosts without large memory offsets. */ >> volatile sig_atomic_t tcg_exit

Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices

2015-07-13 Thread Andreas Färber
Am 13.07.2015 um 16:37 schrieb Cornelia Huck: > On Mon, 13 Jul 2015 16:20:09 +0200 > Andreas Färber wrote: > >> Am 13.07.2015 um 16:11 schrieb Cornelia Huck: >>> On Mon, 13 Jul 2015 14:22:05 +0200 >>> Christian Borntraeger wrote: >>> >>> Any objections against taking this through s390-next? I'd

Re: [Qemu-devel] [PATCH 7/8] disas: mips: QOMify target specific disas setup

2015-07-13 Thread Leon Alrae
On 12/07/2015 03:00, Peter Crosthwaite wrote: > From: Peter Crosthwaite > > Move the target_disas() mips specifics to the QOM disas_set_info hook > and delete the #ifdef specific code in disas.c. > > Cc: Aurelien Jarno > Cc: Leon Alrae > Signed-off-by: Peter Crosthwaite > --- > Testing: > mip

Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices

2015-07-13 Thread Peter Maydell
On 13 July 2015 at 16:38, Cornelia Huck wrote: > So why does a pure Device have a reset callback then that is not called > by default? This is (as I understand it) basically historical legacy from qdev. The qdev model puts every device on a bus of some kind, and then says that it's the bus that h

Re: [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.

2015-07-13 Thread Alex Bennée
fred.kon...@greensocs.com writes: > From: KONRAD Frederic > > This flag indicates if the VCPU is currently executing TCG code. > > Signed-off-by: KONRAD Frederic > > Changes V1 -> V2: > * do both tcg_executing = 0 or 1 in cpu_exec(). > --- > cpu-exec.c| 2 ++ > include/qom/cpu.h | 3

[Qemu-devel] [PATCH 2.4] hw/arm/boot: Increase fdt alignment

2015-07-13 Thread Alexander Graf
The Linux kernel on aarch64 creates a page table entry at early bootup that spans the 2MB range on memory spanning the fdt start address: [ ALIGN_DOWN(fdt, 2MB) ... ALIGN_DOWN(fdt, 2MB) + 2MB ] This means that when our current 4k alignment happens to fall at the end of the aligned region, Linux

Re: [Qemu-devel] [PATCH v7 23/42] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state

2015-07-13 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > 'MIGRATION_STATUS_POSTCOPY_ACTIVE' is entered after migrate_start_postcopy > > > > 'migration_postcopy_phase' is provided for other sections to know if > > they're in po

Re: [Qemu-devel] [RFC PATCH V2 0/3] Multithread TCG async_safe_work part.

2015-07-13 Thread Alex Bennée
Paolo Bonzini writes: > On 10/07/2015 18:08, fred.kon...@greensocs.com wrote: >> From: KONRAD Frederic >> >> This is the async_safe_work introduction bit of the Multithread TCG work. >> Rebased on current upstream (6169b60285fe1ff730d840a49527e721bfb30899). >> >> It can be cloned here: >> htt

Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices

2015-07-13 Thread Andreas Färber
Am 13.07.2015 um 17:38 schrieb Cornelia Huck: > Really, I think we're moving in circles here. First, the device should > not live on the sysbus as it does not fit the perceived sysbus > semantics. As there is no natural bus for it to live on, it becomes a > pure device. Which is not reset, because

[Qemu-devel] [PATCH] net: vhost-user reconnect

2015-07-13 Thread Matus Fabian -X (matfabia - Pantheon Technologies SRO at Cisco)
If userspace switch restarts it will reconnect to unix socket but QEMU will not send any vhost-user information and that basically means that userspace switch restart requires restart of VM. Fix detects that userspace switch is disconnected and notify VM that link status is down. After user space s

[Qemu-devel] Unable to build PX255 spitz kernel in qemu

2015-07-13 Thread Sumeet Jauhar
Hi All, I would be extremely happy if someone would help me fix my error. *Requirement* : My need is to emulate a arm pxa255 board using qemu. In fact any board that supports the armv5te instruction set will also be ok example tosa Tosa PDA (PXA255) akita Akita PDA (PXA270) spitz

Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices

2015-07-13 Thread Cornelia Huck
On Mon, 13 Jul 2015 17:05:31 +0200 Andreas Färber wrote: > Am 13.07.2015 um 16:30 schrieb Christian Borntraeger: > > Am 13.07.2015 um 16:20 schrieb Andreas Färber: > >> Am 13.07.2015 um 16:11 schrieb Cornelia Huck: > >>> On Mon, 13 Jul 2015 14:22:05 +0200 > >>> Christian Borntraeger wrote: > >>>

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 03:20:59PM +0200, Cornelia Huck wrote: > On Mon, 13 Jul 2015 15:36:00 +0300 > "Michael S. Tsirkin" wrote: > > > On Mon, Jul 13, 2015 at 02:30:24PM +0200, Cornelia Huck wrote: > > > On Mon, 13 Jul 2015 15:22:52 +0300 > > > "Michael S. Tsirkin" wrote: > > > > > > > On Mon,

Re: [Qemu-devel] [PATCH v7 24/42] Add qemu_savevm_state_complete_postcopy

2015-07-13 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Add qemu_savevm_state_complete_postcopy to complement > > qemu_savevm_state_complete_precopy together with a new > > save_live_complete_postcopy method on devices. > > >

[Qemu-devel] [RFC PATCH qemu v2 0/5] vfio: SPAPR IOMMU v2 (memory preregistration support)

2015-07-13 Thread Alexey Kardashevskiy
Here are few patches to prepare an existing listener for handling memory preregistration for SPAPR guests running on POWER8. This used to be a part of DDW patchset but now is separated as requested. I left versions in changelog of 5/5 for convenience. Please comment, specifically about how many m

Re: [Qemu-devel] [PATCH] net: vhost-user reconnect

2015-07-13 Thread Michael S. Tsirkin
On Mon, Jul 13, 2015 at 02:44:37PM +, Matus Fabian -X (matfabia - Pantheon Technologies SRO at Cisco) wrote: > If userspace switch restarts it will reconnect to unix socket but QEMU will > not > send any vhost-user information and that basically means that userspace switch > restart requires

Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface

2015-07-13 Thread Paolo Bonzini
On 13/07/2015 16:43, Jason J. Herne wrote: >>> >>> +CPU_FOREACH(cpu) { >>> +async_run_on_cpu(cpu, cpu_throttle_thread, NULL); >>> +} >>> + >>> +timer_mod(throttle_timer, >>> qemu_clock_get_ms(QEMU_CLOCK_VIRTUAL_RT) + >>> + CPU_THROTTLE_TIMESLI

Re: [Qemu-devel] [PATCH 2/5] virtio-blk: disable scsi passthrough for 1.0 device

2015-07-13 Thread Paolo Bonzini
On 13/07/2015 16:41, Cornelia Huck wrote: > On Mon, 13 Jul 2015 16:34:30 +0200 > Paolo Bonzini wrote: >> On 13/07/2015 15:20, Cornelia Huck wrote: >>> This would imply that any transitional device cannot offer scsi, >>> doesn't it? >>> >>> We have two layers interacting here: virtio-blk which ma

Re: [Qemu-devel] [PATCH 1/2] atapi: abort transfers with 0 byte limits

2015-07-13 Thread John Snow
On 07/13/2015 06:18 AM, Kevin Wolf wrote: > Am 11.07.2015 um 03:05 hat John Snow geschrieben: >> We're supposed to abort on transfers like this, unless we fill >> Word 125 of our IDENTIFY data with a default transfer size, which >> we don't currently do. >> >> This is an ATA error, not a SCSI/ATA

[Qemu-devel] [RFC PATCH qemu v2 3/5] vfio: Store IOMMU type in container

2015-07-13 Thread Alexey Kardashevskiy
So far we were managing not to have an IOMMU type stored anywhere but since we are going to implement different behavior for different IOMMU types in the same memory listener, we need to know IOMMU type after initialization. This adds an IOMMU type into VFIOContainer and initializes it. This adds

[Qemu-devel] [RFC PATCH qemu v2 2/5] vfio: Skip PCI BARs in memory listener

2015-07-13 Thread Alexey Kardashevskiy
In some cases PCI BARs are registered as RAM via memory_region_init_ram_ptr() and the vfio_memory_listener will be called on them too. However DMA will not be performed to/from these regions so just skip them. Signed-off-by: Alexey Kardashevskiy --- hw/vfio/common.c | 3 ++- 1 file changed, 2 in

[Qemu-devel] [RFC PATCH qemu v2 4/5] vfio: Refactor memory listener to accommodate more IOMMU types

2015-07-13 Thread Alexey Kardashevskiy
The vfio_memory_listener is registered for PCI address space. On Type1 IOMMU that falls back to @address_space_memory and the listener is called on RAM blocks. On sPAPR IOMMU is guest visible and the listener is called on DMA windows. Therefore Type1 IOMMU only handled RAM regions and sPAPR IOMMU o

Re: [Qemu-devel] [PATCH for-2.4 1/2] core: reset handler for bus-less devices

2015-07-13 Thread Andreas Färber
Am 13.07.2015 um 16:30 schrieb Christian Borntraeger: > Am 13.07.2015 um 16:20 schrieb Andreas Färber: >> Am 13.07.2015 um 16:11 schrieb Cornelia Huck: >>> On Mon, 13 Jul 2015 14:22:05 +0200 >>> Christian Borntraeger wrote: >>> Am 09.07.2015 um 18:51 schrieb Cornelia Huck: > Devices that

[Qemu-devel] [RFC PATCH qemu v2 5/5] vfio: spapr: Add SPAPR IOMMU v2 support (DMA memory preregistering)

2015-07-13 Thread Alexey Kardashevskiy
This makes use of the new "memory registering" feature. The idea is to provide the userspace ability to notify the host kernel about pages which are going to be used for DMA. Having this information, the host kernel can pin them all once per user process, do locked pages accounting (once) and not s

[Qemu-devel] [RFC PATCH qemu v2 1/5] vfio: Switch from TARGET_PAGE_MASK to qemu_real_host_page_mask

2015-07-13 Thread Alexey Kardashevskiy
These started switching from TARGET_PAGE_MASK (hardcoded as 4K) to a real host page size: 4e51361d7 "cpu-all: complete "real" host page size API" and f7ceed190 "vfio: cpu: Use "real" page size API" This finished the transition by: - %s/TARGET_PAGE_MASK/qemu_real_host_page_mask/ - %s/TARGET_PAGE_AL

Re: [Qemu-devel] [PATCH] target-arm: Add debug check for mismatched cpreg resets

2015-07-13 Thread Edgar E. Iglesias
On Mon, Jul 13, 2015 at 03:25:59PM +0100, Peter Maydell wrote: > It's easy to accidentally define two cpregs which both try > to reset the same underlying state field (for instance a > clash between an AArch64 EL3 definition and an AArch32 > banked register definition). if the two definitions disag

Re: [Qemu-devel] [PATCH v4 1/5] cpu: Provide vcpu throttling interface

2015-07-13 Thread Jason J. Herne
On 07/02/2015 12:43 PM, Paolo Bonzini wrote: On 02/07/2015 18:36, Jason J. Herne wrote: +static void cpu_throttle_thread(void *opaque) +{ +double pct = (double)throttle_percentage/100; +double throttle_ratio = pct / (1 - pct); +long sleeptime_ms = (long)(throttle_ratio * CPU_THROTT

Re: [Qemu-devel] [PATCH for-2.4] target-arm: Fix broken SCTLR_EL3 reset

2015-07-13 Thread Edgar E. Iglesias
On Mon, Jul 13, 2015 at 03:24:25PM +0100, Peter Maydell wrote: > The SCTLR_EL3 cpreg definition was implicitly resetting the > register state to 0, which is both wrong and clashes with > the reset done via the SCTLR definition (since sctlr[3] > is unioned with sctlr_s). This went unnoticed until re

  1   2   3   >