Re: [Qemu-devel] [PATCH v2 04/10] block: keep bitmap if incremental backup job is cancelled

2015-07-06 Thread Fam Zheng
On Mon, 07/06 15:24, Stefan Hajnoczi wrote: > Reclaim the dirty bitmap if an incremental backup block job is > cancelled. The ret variable may be 0 when the job is cancelled so it's > not enough to check ret < 0. > > Signed-off-by: Stefan Hajnoczi > --- > block/backup.c | 2 +- > 1 file changed

[Qemu-devel] [PATCH V3] block/nfs: add support for setting debug level

2015-07-06 Thread Peter Lieven
upcoming libnfs versions will support logging debug messages. Add support for it in qemu through a per-drive option. Examples: qemu -drive if=virtio,file=nfs://...,file.debug=2 qemu-img create -o debug=2 nfs://... 10G Signed-off-by: Peter Lieven --- v2->v3: use a per-drive option instead of a

Re: [Qemu-devel] [PATCH v2 03/10] block: rename BlkTransactionState and BdrvActionOps

2015-07-06 Thread Fam Zheng
On Mon, 07/06 15:24, Stefan Hajnoczi wrote: > From: John Snow > > These structures are misnomers, somewhat. > > (1) BlockTransactionState is not state for a transaction, > but is rather state for a single transaction action. > Rename it "BlkActionState" to be more accurate. > > (2) The

Re: [Qemu-devel] [PATCH v2 02/10] iotests: add transactional incremental backup test

2015-07-06 Thread Fam Zheng
On Mon, 07/06 15:24, Stefan Hajnoczi wrote: > From: John Snow > > Test simple usage cases for using transactions to create > and synchronize incremental backups. > > Signed-off-by: John Snow > Reviewed-by: Max Reitz > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Stefan Hajnoczi > --- > tes

Re: [Qemu-devel] vpc size reporting problem

2015-07-06 Thread Peter Lieven
Am 07.07.2015 um 08:34 schrieb Chun Yan Liu: On 7/7/2015 at 02:19 PM, in message <559B6F79.237 : 102 : 21807>, Chun Yan Liu wrote: On 7/7/2015 at 02:03 PM, in message <559b6bbe.3050...@kamp.de>, Peter Lieven wrote: Am 07.07.2015 um 07:59 schrieb Chun Yan Liu: On 7/7/2015 at 01:50 PM

Re: [Qemu-devel] vpc size reporting problem

2015-07-06 Thread Chun Yan Liu
>>> On 7/7/2015 at 02:19 PM, in message <559B6F79.237 : 102 : 21807>, Chun Yan >>> Liu wrote: > > On 7/7/2015 at 02:03 PM, in message <559b6bbe.3050...@kamp.de>, Peter Lieven > wrote: > > Am 07.07.2015 um 07:59 schrieb Chun Yan Liu: >> > >> On 7/7/2015 at 01:50 PM, in

Re: [Qemu-devel] vpc size reporting problem

2015-07-06 Thread Peter Lieven
Am 07.07.2015 um 08:19 schrieb Chun Yan Liu: On 7/7/2015 at 02:03 PM, in message <559b6bbe.3050...@kamp.de>, Peter Lieven wrote: Am 07.07.2015 um 07:59 schrieb Chun Yan Liu: On 7/7/2015 at 01:50 PM, in message <559b68b2.5060...@kamp.de>, Peter Lieven wrote: Am 07.07.2015 um 03:50 schrieb

[Qemu-devel] [PATCH v2] net-hub: Drop can_receive

2015-07-06 Thread Fam Zheng
This moves the semantics from net_hub_port_can_receive to receive functions, by returning 0 if all receiving ports return 0. Also, remember to flush the source port's queue in that case. Signed-off-by: Fam Zheng --- net/hub.c | 54 +- 1 file ch

Re: [Qemu-devel] vpc size reporting problem

2015-07-06 Thread Chun Yan Liu
>>> On 7/7/2015 at 02:03 PM, in message <559b6bbe.3050...@kamp.de>, Peter Lieven wrote: > Am 07.07.2015 um 07:59 schrieb Chun Yan Liu: > > > On 7/7/2015 at 01:50 PM, in message <559b68b2.5060...@kamp.de>, Peter > Lieven > > wrote: > >> Am 07.07.2015 um 03:50 schrieb Chun Yan Liu

Re: [Qemu-devel] vpc size reporting problem

2015-07-06 Thread Peter Lieven
Am 07.07.2015 um 07:59 schrieb Chun Yan Liu: On 7/7/2015 at 01:50 PM, in message <559b68b2.5060...@kamp.de>, Peter Lieven wrote: Am 07.07.2015 um 03:50 schrieb Chun Yan Liu: On 7/6/2015 at 06:42 PM, in message <559a5b79.4010...@kamp.de>, Peter Lieven wrote: Am 06.07.2015 um 11:44 schrieb

Re: [Qemu-devel] vpc size reporting problem

2015-07-06 Thread Chun Yan Liu
>>> On 7/7/2015 at 01:50 PM, in message <559b68b2.5060...@kamp.de>, Peter Lieven wrote: > Am 07.07.2015 um 03:50 schrieb Chun Yan Liu: > > > On 7/6/2015 at 06:42 PM, in message <559a5b79.4010...@kamp.de>, Peter > Lieven > > wrote: > >> Am 06.07.2015 um 11:44 schrieb Chun Yan Liu

Re: [Qemu-devel] vpc size reporting problem

2015-07-06 Thread Peter Lieven
Am 07.07.2015 um 03:50 schrieb Chun Yan Liu: On 7/6/2015 at 06:42 PM, in message <559a5b79.4010...@kamp.de>, Peter Lieven wrote: Am 06.07.2015 um 11:44 schrieb Chun Yan Liu: While testing with a 1GB VHD file created on win7, found that the VHD file size reported on Windows is different from

[Qemu-devel] [Bug 1472083] [NEW] Qemu 2.1.2 hang when stop command

2015-07-06 Thread changlimin
Public bug reported: Qemu 2.1.2, Linux kernel 3.13.6, this is the stack. #0 in ppoll () from /lib/x86_64-linux-gnu/libc.so.6 #1 in qemu_poll_ns (fds=0x7fa82a8de380, nfds=1, timeout=-1) at qemu-timer.c:314 #2 in aio_poll (ctx=0x7fa82a8b5000, blocking=true) at aio-posix.c:250 #3 in bdrv_drain_a

[Qemu-devel] [v9][PATCH 08/10] xen, gfx passthrough: register a isa bridge

2015-07-06 Thread Tiejun Chen
Currently we just register this isa bridge when we use IGD passthrough in Xen side. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini --- v9: * Move is_igd_vga_passthrough(dev)) from xen_igd_passthrough_isa_bridge_create() into xen_pt_initfn(). hw/xen/xen_pt.c | 21 ++

[Qemu-devel] [v9][PATCH 09/10] xen, gfx passthrough: register host bridge specific to passthrough

2015-07-06 Thread Tiejun Chen
Just register that pci host bridge specific to passthrough. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini --- v9: * Simplify pc_xen_hvm_init_pci() hw/i386/pc_piix.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_pi

[Qemu-devel] [v9][PATCH 04/10] hw/pci-assign: split pci-assign.c

2015-07-06 Thread Tiejun Chen
We will try to reuse assign_dev_load_option_rom in xen side, and especially its a good beginning to unify pci assign codes both on kvm and xen in the future. Signed-off-by: Tiejun Chen Acked-by: Michael S. Tsirkin --- v9: * Just rebase on the latest. hw/i386/Makefile.objs | 1 + hw/

[Qemu-devel] [v9][PATCH 10/10] xen, gfx passthrough: add opregion mapping

2015-07-06 Thread Tiejun Chen
The OpRegion shouldn't be mapped 1:1 because the address in the host can't be used in the guest directly. This patch traps read and write access to the opregion of the Intel GPU config space (offset 0xfc). The original patch is from Jean Guyader Signed-off-by: Tiejun Chen Signed-off-by: Yang Z

[Qemu-devel] [v9][PATCH 01/10] i440fx: make types configurable at run-time

2015-07-06 Thread Tiejun Chen
From: "Michael S. Tsirkin" IGD passthrough wants to supply a different pci and host devices, inheriting i440fx devices. Make types configurable. Signed-off-by: Michael S. Tsirkin Signed-off-by: Tiejun Chen --- v9: * Just rebase on the latest. hw/i386/pc_piix.c| 4 +++- hw/pci-host/piix.

[Qemu-devel] [v9][PATCH 06/10] xen, gfx passthrough: retrieve VGA BIOS to work

2015-07-06 Thread Tiejun Chen
Now we retrieve VGA bios like kvm stuff in qemu but we need to fix Device Identification in case if its not matched with the real IGD device since Seabios is always trying to compare this ID to work out VGA BIOS. Signed-off-by: Tiejun Chen Acked-by: Stefano Stabellini --- v9: * Just rebase on

[Qemu-devel] [v9][PATCH 07/10] igd gfx passthrough: create a isa bridge

2015-07-06 Thread Tiejun Chen
Currently IGD drivers always need to access PCH by 1f.0. But we don't want to poke that directly to get ID, and although in real world different GPU should have different PCH. But actually the different PCH DIDs likely map to different PCH SKUs. We do the same thing for the GPU. For PCH, the differ

[Qemu-devel] [v9][PATCH 03/10] piix: create host bridge to passthrough

2015-07-06 Thread Tiejun Chen
Implement a pci host bridge specific to passthrough. Actually this just inherits the standard one. And we also just expose a minimal real host bridge pci configuration subset. Signed-off-by: Tiejun Chen Acked-by: Michael S. Tsirkin --- v9: * Just rebase on the latest. hw/pci-host/piix.c |

[Qemu-devel] [v9][PATCH 05/10] xen, gfx passthrough: basic graphics passthrough support

2015-07-06 Thread Tiejun Chen
basic gfx passthrough support: - add a vga type for gfx passthrough - register/unregister legacy VGA I/O ports and MMIOs for passthrough GFX Signed-off-by: Tiejun Chen Signed-off-by: Yang Zhang Acked-by: Stefano Stabellini --- v9: * Just rebase on the latest. hw/core/machine.c|

[Qemu-devel] [v9][PATCH 00/10] xen: add Intel IGD passthrough

2015-07-06 Thread Tiejun Chen
v9: * Rebase on the latest * Inside patch #8, move is_igd_vga_passthrough(dev)) from xen_igd_passthrough_isa_bridge_create() into xen_pt_initfn(). * Inside patch #9, simplify pc_xen_hvm_init_pci() * Michael acked them on pc side * Stefano ackes then on xen side v8: * Rebase on the latest qemu

[Qemu-devel] [v9][PATCH 02/10] pc_init1: pass parameters just with types

2015-07-06 Thread Tiejun Chen
Pass types to configure pc_init1(). Signed-off-by: Tiejun Chen Acked-by: Michael S. Tsirkin --- v9: * Just rebase on the latest. hw/i386/pc_piix.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index dda58ad..6810ca2 1

[Qemu-devel] [PATCH 04/10] qga: add win32 library iphlpapi

2015-07-06 Thread Michael Roth
From: Kirk Allan Add the iphlpapi library to use APIs such as GetAdaptersInfo and GetAdaptersAddresses. Signed-off-by: Kirk Allan Signed-off-by: Michael Roth --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 3063739..3bb5e55 100755 -

[Qemu-devel] [PATCH 07/10] qga: added empty qmp_quest_get_fsinfo functionality.

2015-07-06 Thread Michael Roth
From: Olga Krishtal We need qmp_quest_get_fsinfo togather with vss-provider, which works with volumes. The call to this function is implemented via FindFirst/NextVolumes. Moreover, volumes in Windows OS are filesystem unit, so it will be more effective to work with them rather with devices. Sign

[Qemu-devel] [PATCH 01/10] qga/commands-posix: Fix bug in guest-fstrim

2015-07-06 Thread Michael Roth
From: Justin Ossevoort The FITRIM ioctl updates the fstrim_range structure it receives. This way the caller can determine how many bytes were trimmed. The guest-fstrim logic reuses the same fstrim_range for each filesystem, effectively limiting each filesystem to trim at most as much as the previ

Re: [Qemu-devel] [PATCH qemu v10 14/14] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2015-07-06 Thread David Gibson
On Mon, Jul 06, 2015 at 12:11:10PM +1000, Alexey Kardashevskiy wrote: > This adds support for Dynamic DMA Windows (DDW) option defined by > the SPAPR specification which allows to have additional DMA window(s) > > This implements DDW for emulated and VFIO devices. As all TCE root regions > are map

[Qemu-devel] [PATCH 08/10] qga: added mountpoint and filesystem type for single volume

2015-07-06 Thread Michael Roth
From: Olga Krishtal We should use GetVolumeXXX api to work with volumes. This will help us to resolve the situation with volumes without drive letter, i.e. when the volume is mounted as a folder. Such volume is called mounted folder. This volume is a regular mounted volume from all other points o

[Qemu-devel] [PATCH 06/10] qga: fail early for invalid time

2015-07-06 Thread Michael Roth
From: Marc-André Lureau It's possible to set system time with dates after 2070, however, it's not possible to set the RTC. It has limitation to up to year 2070 (1970+100). In order to keep both clock in sync and before the kernel complains on invalid values, bail out early. Signed-off-by: Marc-A

[Qemu-devel] [PATCH 05/10] qga: win32 qmp_guest_network_get_interfaces implementation

2015-07-06 Thread Michael Roth
From: Kirk Allan By default, IPv4 prefixes will be derived by matching the address to those returned by GetAdaptersInfo. IPv6 prefixes can not be matched this way due to the unpredictable order of entries. In Windows Vista/2008 guests and newer, both IPv4 and IPv6 prefixes can be retrieved from

[Qemu-devel] [PATCH 02/10] qga/qmp_guest_fstrim: Return per path fstrim result

2015-07-06 Thread Michael Roth
From: Justin Ossevoort The current guest-fstrim support only returns an error if some mountpoint was unable to be trimmed, skipping any possible additional mountpoints. The result of the TRIM operation itself is also discarded. This change returns a per mountpoint result of the TRIM operation. I

[Qemu-devel] [PATCH 10/10] qga: added GuestPCIAddress information

2015-07-06 Thread Michael Roth
From: Olga Krishtal PCIAddress inforfation is obtained via SetupApi, which provides the information about address, bus, etc. We look throught entire device tree in the system and try to find device object for given volume. For this PDO SetupDiGetDeviceRegistryProperty is called, which reads PCI c

[Qemu-devel] [PATCH 03/10] Revert "guest agent: remove g_strcmp0 usage"

2015-07-06 Thread Michael Roth
From: Markus Armbruster Since we now require GLib 2.22+ (commit f40685c), we don't have to work around lack of g_strcmp0() anymore. This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1. Conflicts: qemu-ga.c Signed-off-by: Markus Armbruster Reviewed-by: John Snow Signed-off-by

[Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path

2015-07-06 Thread Michael Roth
From: Olga Krishtal According to Microsoft disk location path can be obtained via IOCTL_SCSI_GET_ADDRESS. Unfortunately this ioctl can not be used for all devices. There are certain bus types which could be obtained with this API. Please, refer to the following link for more details https://techn

[Qemu-devel] [PULL 00/10] qemu-ga patches for 2.4.0

2015-07-06 Thread Michael Roth
Hi Peter, Sorry for the last minute pull. This is a round-up of all tested/reviewed qemu-ga patches posted prior to soft-freeze, along with 1 bug fix that came in last week. This adds win32 implementations of: guest-get-fsinfo guest-network-get-interfaces and modifies guest-fstrim to return

Re: [Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06

2015-07-06 Thread Peter Crosthwaite
On Mon, Jul 6, 2015 at 8:56 PM, Bharata B Rao wrote: > On Tue, Jul 7, 2015 at 7:55 AM, Peter Crosthwaite > wrote: >> On Mon, Jul 6, 2015 at 5:24 PM, Andreas Färber wrote: >>> Am 07.07.2015 um 01:13 schrieb Andreas Färber: Hello Peter, This is my QOM CPU patch queue. Please pull. >

Re: [Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06

2015-07-06 Thread Peter Crosthwaite
On Mon, Jul 6, 2015 at 7:25 PM, Peter Crosthwaite wrote: > On Mon, Jul 6, 2015 at 5:24 PM, Andreas Färber wrote: >> Am 07.07.2015 um 01:13 schrieb Andreas Färber: >>> Hello Peter, >>> >>> This is my QOM CPU patch queue. Please pull. >>> >>> Note: For time reasons I did not give this queue as much

Re: [Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06

2015-07-06 Thread Bharata B Rao
On Tue, Jul 7, 2015 at 7:55 AM, Peter Crosthwaite wrote: > On Mon, Jul 6, 2015 at 5:24 PM, Andreas Färber wrote: >> Am 07.07.2015 um 01:13 schrieb Andreas Färber: >>> Hello Peter, >>> >>> This is my QOM CPU patch queue. Please pull. >>> >>> Note: For time reasons I did not give this queue as much

Re: [Qemu-devel] [PATCH v6 2/6] spapr: Add LMB DR connectors

2015-07-06 Thread David Gibson
On Mon, Jul 06, 2015 at 05:49:48PM +0200, Thomas Huth wrote: > On Mon, 29 Jun 2015 14:14:28 +0530 > Bharata B Rao wrote: > > > Enable memory hotplug for pseries 2.4 and add LMB DR connectors. > > With memory hotplug, enforce RAM size, NUMA node memory size and maxmem > > to be a multiple of SPAPR

Re: [Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06

2015-07-06 Thread Peter Crosthwaite
On Mon, Jul 6, 2015 at 5:24 PM, Andreas Färber wrote: > Am 07.07.2015 um 01:13 schrieb Andreas Färber: >> Hello Peter, >> >> This is my QOM CPU patch queue. Please pull. >> >> Note: For time reasons I did not give this queue as much testing as usual, >> in particular BSD and non-x86 KVM hosts were

[Qemu-devel] 回复: Re: Can the backing file of qcow2 points to a snapshot of base file?

2015-07-06 Thread vt
On 2015/7/6 20:09, Max Reitz wrote: > On 06.07.2015 10:20, vt wrote: >> Hi. >> If a base qcow2 image snapshot chain like this: >> base.qcow2: [A] -> [B] -> [C] >> [C] is the current image where guest read/write to,usually we create a >> new image base on the base.qcow2 like this >> qemu-img create

Re: [Qemu-devel] vpc size reporting problem

2015-07-06 Thread Chun Yan Liu
>>> On 7/6/2015 at 06:42 PM, in message <559a5b79.4010...@kamp.de>, Peter Lieven wrote: > Am 06.07.2015 um 11:44 schrieb Chun Yan Liu: > > While testing with a 1GB VHD file created on win7, found that the VHD file > > size reported on Windows is different from that is reported by qemu-img >

Re: [Qemu-devel] [PATCH] qga: fail early for invalid time

2015-07-06 Thread Michael Roth
Quoting Marc-André Lureau (2015-07-05 09:28:58) > It's possible to set system time with dates after 2070, however, it's > not possible to set the RTC. It has limitation to up to year > 2070 (1970+100). In order to keep both clock in sync and before the > kernel complains on invalid values, bail out

Re: [Qemu-devel] [PATCH 06/10] qga: guest exec functionality for Windows guests

2015-07-06 Thread Michael Roth
Quoting Denis V. Lunev (2015-06-30 05:25:19) > From: Olga Krishtal > > Child process' stdin/stdout/stderr can be associated > with handles for communication via read/write interfaces. > > The workflow should be something like this: > * Open an anonymous pipe through guest-pipe-open > * Execute a

Re: [Qemu-devel] [PATCH] Revert "guest agent: remove g_strcmp0 usage"

2015-07-06 Thread Michael Roth
Quoting Markus Armbruster (2015-06-16 01:34:57) > Ping? Applied, thanks. > > Markus Armbruster writes: > > > Since we now require GLib 2.22+ (commit f40685c), we don't have to > > work around lack of g_strcmp0() anymore. > > > > This reverts commit 8f4774789947bc4bc4c8d026a289fe980d3d2ee1. > >

Re: [Qemu-devel] [PATCH v4 0/2] Fix guest-fstrim behaviour

2015-07-06 Thread Michael Roth
Quoting Justin Ossevoort (2015-05-11 01:58:43) > The qemu-ga 'guest-fstrim' command is currently not working properly. > > There are 2 issues: > - The current implementation reuses a struct between ioctl() calls without > reinitialising it's fields. This struct however is updated to reflect >

Re: [Qemu-devel] [PATCH v6 0/2] qga: qmp_guest_network_get_interfaces for win32

2015-07-06 Thread Michael Roth
Quoting Kirk Allan (2015-06-02 12:41:05) > Changes from v5: > - Patch 1/2 removed testing for WINVER in QEMU_CFLAGS. > > Changes from v4: > - Fixed up the commit messages to remove the utf-8 characters. > > Changes from v3: > - Patch 1/2 removed setting ARCH_$ARCH > - Patch 2/2 implemented feedba

[Qemu-devel] [PATCH v2] net: Flush queued packets when guest resumes

2015-07-06 Thread Fam Zheng
Since commit 6e99c63 "net/socket: Drop net_socket_can_send" and friends, net queues need to be explicitly flushed after qemu_can_send_packet() returns false, because the netdev side will disable the polling of fd. This fixes the case of "cont" after "stop" (or migration). Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCH COLO-BLOCK v7 00/17] Block replication for continuous checkpoints

2015-07-06 Thread Wen Congyang
On 07/07/2015 08:25 AM, Michael R. Hines wrote: > On 07/04/2015 07:46 AM, Wen Congyang wrote: >> At 2015/7/3 23:30, Dr. David Alan Gilbert Wrote: >>> * Wen Congyang (we...@cn.fujitsu.com) wrote: Block replication is a very important feature which is used for continuous checkpoints(for exa

Re: [Qemu-devel] [PATCH] virtio-net: Drop net_virtio_info.can_receive

2015-07-06 Thread Fam Zheng
On Mon, 07/06 20:09, Michael S. Tsirkin wrote: > On Mon, Jul 06, 2015 at 04:21:16PM +0100, Stefan Hajnoczi wrote: > > On Mon, Jul 06, 2015 at 11:32:25AM +0800, Jason Wang wrote: > > > > > > > > > On 07/02/2015 08:46 PM, Stefan Hajnoczi wrote: > > > > On Tue, Jun 30, 2015 at 04:35:24PM +0800, Jaso

Re: [Qemu-devel] [PATCH qemu v10 13/14] vfio: spapr: Add SPAPR IOMMU v2 support (DMA memory preregistering)

2015-07-06 Thread Alexey Kardashevskiy
On 07/07/2015 10:29 AM, David Gibson wrote: On Mon, Jul 06, 2015 at 10:13:07AM -0600, Alex Williamson wrote: On Tue, 2015-07-07 at 01:34 +1000, Alexey Kardashevskiy wrote: On 07/06/2015 11:42 PM, Alex Williamson wrote: On Mon, 2015-07-06 at 12:11 +1000, Alexey Kardashevskiy wrote: This makes

Re: [Qemu-devel] [PATCH qemu v10 13/14] vfio: spapr: Add SPAPR IOMMU v2 support (DMA memory preregistering)

2015-07-06 Thread David Gibson
On Mon, Jul 06, 2015 at 10:13:07AM -0600, Alex Williamson wrote: > On Tue, 2015-07-07 at 01:34 +1000, Alexey Kardashevskiy wrote: > > On 07/06/2015 11:42 PM, Alex Williamson wrote: > > > On Mon, 2015-07-06 at 12:11 +1000, Alexey Kardashevskiy wrote: > > >> This makes use of the new "memory register

Re: [Qemu-devel] [PATCH qemu v10 03/14] spapr_pci: Convert finish_realize() to dma_capabilities_update()+dma_init_window()

2015-07-06 Thread Alexey Kardashevskiy
On 07/07/2015 02:41 AM, Laurent Vivier wrote: On 06/07/2015 04:10, Alexey Kardashevskiy wrote: This reworks finish_realize() which used to finalize DMA setup with an assumption that it will not change later. New callbacks supports various window parameters such as page and windows sizes. The

Re: [Qemu-devel] [PATCH COLO-BLOCK v7 00/17] Block replication for continuous checkpoints

2015-07-06 Thread Michael R. Hines
On 07/04/2015 07:46 AM, Wen Congyang wrote: At 2015/7/3 23:30, Dr. David Alan Gilbert Wrote: * Wen Congyang (we...@cn.fujitsu.com) wrote: Block replication is a very important feature which is used for continuous checkpoints(for example: COLO). Usage: Please refer to docs/block-replication.txt

Re: [Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06

2015-07-06 Thread Andreas Färber
Am 07.07.2015 um 01:13 schrieb Andreas Färber: > Hello Peter, > > This is my QOM CPU patch queue. Please pull. > > Note: For time reasons I did not give this queue as much testing as usual, > in particular BSD and non-x86 KVM hosts were not covered. > > Regards, > Andreas > > Cc: Peter Maydell

Re: [Qemu-devel] [PATCH 02/10 v11] linux-user: Support tilegx architecture in linux-user

2015-07-06 Thread Chris Metcalf
I will be posting more hardware documents on Wednesday when I'm back in the office. > On Jun 4, 2015, at 5:33 AM, Chen Gang wrote: > >> On 06/03/2015 11:47 PM, Richard Henderson wrote: >>> On 06/03/2015 05:34 AM, Peter Maydell wrote: >>> You must do something. You can't allow guest code (even

[Qemu-devel] [PULL 21/22] disas: cris: Fix 0 buffer length case

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite Cris has the complication of variable length instructions and has a check in place to clamp memory reads in case the disas request doesn't have enough bytes for the instruction being disas'd. This breaks down in the case where disassembling for the monitor where the buffer

[Qemu-devel] [PULL 19/22] disas: arm: QOMify target specific disas setup

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite Move the target_disas() ARM specifics to the QOM disas_set_info hook and delete the ARM specific code in disas.c. This has the extra advantage of the more fully featured target_disas() implementation now applying to monitor_disas(). Currently, target_disas() has multi-en

[Qemu-devel] [PULL 10/22] cpu: Change cpu_exec_init() arg to cpu, not env

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite The callers (most of them in target-foo/cpu.c) to this function all have the cpu pointer handy. Just pass it to avoid an ENV_GET_CPU() from core code (in exec.c). Cc: Paolo Bonzini Cc: Richard Henderson Cc: Peter Maydell Cc: "Edgar E. Iglesias" Cc: Eduardo Habkost Cc

[Qemu-devel] [PULL 14/22] hw/arm/boot: Use cpu_set_pc()

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite Use cpu_set_pc() across the board for setting program counters. This removes instances of system level code having to reach into the CPU env. Reviewed-by: Peter Maydell Reviewed-by: Andreas Färber Signed-off-by: Peter Crosthwaite [AF: Avoid repeated casts with local va

[Qemu-devel] [PULL 22/22] disas: cris: QOMify target specific disas setup

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite Move the target_disas() cris specifics to the QOM disas_set_info() hook and delete the cris specific code in disas.c. This also now adds support for monitor_disas() to cris. E.g. (qemu) xp 0x40004000 40004000: 0x1e6f25f0 And before this patch: (qemu) xp/i 0x4000

[Qemu-devel] [PULL 08/22] gdbstub: Change gdbserver_fork() to accept cpu instead of env

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite All callsites to this function navigate the cpu->env_ptr only for the function to take the env ptr back to the original cpu ptr. Change the function to just pass in the CPU pointer instead. Removes a core code usage of ENV_GET_CPU() (in gdbstub.c). Cc: Riku Voipio Review

[Qemu-devel] [PULL 11/22] cpu-exec: Purge all uses of ENV_GET_CPU()

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite Remove un-needed usages of ENV_GET_CPU() by converting the APIs to use CPUState pointers and retrieving the env_ptr as minimally needed. Scripted conversion for target-* change: for I in target-*/cpu.h; do sed -i \ 's/\(^int cpu_[^_]*_exec(\)[^ ][^ ]* \*s);$/\1CP

[Qemu-devel] [PULL 17/22] disas: QOMify target specific setup

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite Add a QOM function hook for target-specific disassembly setup. This allows removal of the #ifdeffery currently implementing target specific disas setup from disas.c. Reviewed-by: Richard Henderson Signed-off-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- disa

[Qemu-devel] [PULL 09/22] cpu: Change tcg_cpu_exec() arg to cpu, not env

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite The sole caller of this function navigates the cpu->env_ptr only for this function to take it back the cpu pointer straight away. Pass in cpu pointer instead and grab the env pointer locally in the function. Removes a core code usage of ENV_GET_CPU(). Reviewed-by: Andreas

[Qemu-devel] [PULL 16/22] disas: Add print_insn to disassemble info

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite Add the print_insn pointer to the disassemble info structure. This is to prepare for QOMification support, where a QOM CPU hook function will be responsible for setting the print_insn() function. Add this function to the existing struct to consolidate such that only the on

[Qemu-devel] [PULL 20/22] disas: microblaze: QOMify target specific disas setup

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite Move the target_disas() MB specifics to the QOM disas_set_info hook and delete the MB specific code in disas.c. This also now adds support for monitor_disas() to Microblaze. E.g. (qemu) xp 0x9000 9000: 0x94208001 And before this patch: (qemu) xp/i 0x9000

[Qemu-devel] [PULL 06/22] target-ppc: Move cpu_exec_init() call to realize function

2015-07-06 Thread Andreas Färber
From: Bharata B Rao Move cpu_exec_init() call from instance_init to realize. This allows any failures from cpu_exec_init() to be handled appropriately. Also add corresponding cpu_exec_exit() call from unrealize. cpu_dt_id assignment from instance_init is no longer needed since correct assignment

[Qemu-devel] [PULL 18/22] disas: arm-a64: Make printfer and stream variable

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite In a normal disassembly flow, the printf() and stream being used varies from disas job to job. In particular it varies if mixing monitor_disas and target_disas. Make both the printf() function and target stream settable in the QEMUDisassmbler class. Reviewed-by: Claudio

[Qemu-devel] [PULL 15/22] microblaze: boot: Use cpu_set_pc()

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite Use cpu_set_pc() for setting program counters when bootloading. This removes an instance of system level code having to reach into the CPU env. Reviewed-by: Andreas Färber Signed-off-by: Peter Crosthwaite [AF: Avoid duplicated CPU() casts through local variable] Signed-

[Qemu-devel] [PULL 13/22] gdbstub: Use cpu_set_pc() helper

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite Use the cpu_set_pc() helper which will take care of CPUClass retrieval for us. Signed-off-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- gdbstub.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index aa5ba51..92b2

[Qemu-devel] [PULL 04/22] cpu: Add Error argument to cpu_exec_init()

2015-07-06 Thread Andreas Färber
From: Bharata B Rao Add an Error argument to cpu_exec_init() to let users collect the error. This is in preparation to change the CPU enumeration logic in cpu_exec_init(). With the new enumeration logic, cpu_exec_init() can fail if cpu_index values corresponding to max_cpus have already been hand

[Qemu-devel] [PULL 07/22] translate-all: Change tb_flush() env argument to cpu

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite All of the core-code usages of this API have the cpu pointer handy so pass it in. There are only 3 architecture specific usages (2 of which are commented out) which can just use ENV_GET_CPU() locally to get the cpu pointer. The reduces core code usage of the CPU env, which

[Qemu-devel] [PULL 05/22] cpu: Convert cpu_index into a bitmap

2015-07-06 Thread Andreas Färber
From: Bharata B Rao Currently CPUState::cpu_index is monotonically increasing and a newly created CPU always gets the next higher index. The next available index is calculated by counting the existing number of CPUs. This is fine as long as we only add CPUs, but there are architectures which are

[Qemu-devel] [PULL 03/22] cpu: Reorder cpu->as, cpu->thread_id, cpu->memory_dispatch init

2015-07-06 Thread Andreas Färber
From: Eduardo Habkost Instead of initializing cpu->as, cpu->thread_id, and reloading memory map while holding cpu_list_lock(), do it earlier, before locking the CPU list and initializing cpu_index. This allows the code handling cpu_index and global CPU list to be isolated from the rest. Cc: Pao

[Qemu-devel] [PULL 12/22] cpu: Add wrapper for the set_pc() hook

2015-07-06 Thread Andreas Färber
From: Peter Crosthwaite Add a wrapper around the CPUClass::set_pc() hook. Signed-off-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- include/qom/cpu.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 7db310e..5db1ea3 10064

[Qemu-devel] [PULL 01/22] cpu: No need to zero-initialize CPUState::numa_node

2015-07-06 Thread Andreas Färber
From: Eduardo Habkost QOM objects are already zero-filled when instantiated, there's no need to explicitly set numa_node to 0. Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- exec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/exec.c b/exec.c

[Qemu-devel] [PULL 02/22] cpu: Initialize breakpoint/watchpoint lists in cpu_common_initfn()

2015-07-06 Thread Andreas Färber
From: Eduardo Habkost One small step in the simplification of cpu_exec_init(). Reviewed-by: Igor Mammedov Signed-off-by: Eduardo Habkost Signed-off-by: Andreas Färber --- exec.c| 2 -- qom/cpu.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/exec.c b/exec.c index

[Qemu-devel] [PULL 00/22] QOM CPUState patch queue 2015-07-06

2015-07-06 Thread Andreas Färber
Hello Peter, This is my QOM CPU patch queue. Please pull. Note: For time reasons I did not give this queue as much testing as usual, in particular BSD and non-x86 KVM hosts were not covered. Regards, Andreas Cc: Peter Maydell Cc: Eduardo Habkost Cc: Peter Crosthwaite The following changes

Re: [Qemu-devel] [PATCH 0/2] target-arm: "any" CPUs for system-mode

2015-07-06 Thread Peter Crosthwaite
On Mon, Jul 6, 2015 at 3:49 PM, Peter Maydell wrote: > On 6 July 2015 at 23:42, Peter Crosthwaite > wrote: >> On Mon, Jul 6, 2015 at 3:29 PM, Peter Maydell >> wrote: >>> On 6 July 2015 at 19:53, wrote: From: Meador Inge This patch series opens up the "any" CPU for system-mode

Re: [Qemu-devel] [PATCH 0/2] target-arm: "any" CPUs for system-mode

2015-07-06 Thread Peter Maydell
On 6 July 2015 at 23:42, Peter Crosthwaite wrote: > On Mon, Jul 6, 2015 at 3:29 PM, Peter Maydell > wrote: >> On 6 July 2015 at 19:53, wrote: >>> From: Meador Inge >>> >>> This patch series opens up the "any" CPU for system-mode and >>> adds a new "any" variant named "anyvfp" that initializes

Re: [Qemu-devel] [PATCH 0/2] target-arm: "any" CPUs for system-mode

2015-07-06 Thread Peter Crosthwaite
On Mon, Jul 6, 2015 at 3:29 PM, Peter Maydell wrote: > On 6 July 2015 at 19:53, wrote: >> From: Meador Inge >> >> This patch series opens up the "any" CPU for system-mode and >> adds a new "any" variant named "anyvfp" that initializes the >> FP coprocessors as well. > > We deliberately removed

Re: [Qemu-devel] [PATCH 2/2] target-arm: Add "anyvfp" CPU

2015-07-06 Thread Peter Maydell
On 6 July 2015 at 19:53, wrote: > From: Meador Inge > > This patch adds support for `-cpu anyvfp`, which is just > like `-cpu any`, but enables the coprocessors by default. > This is useful for working with a wide range of bare-metal > C/C++ applications that have been compiled in different > wa

Re: [Qemu-devel] [PATCH 0/2] target-arm: "any" CPUs for system-mode

2015-07-06 Thread Peter Maydell
On 6 July 2015 at 19:53, wrote: > From: Meador Inge > > This patch series opens up the "any" CPU for system-mode and > adds a new "any" variant named "anyvfp" that initializes the > FP coprocessors as well. We deliberately removed cpu "any" for system mode in commit f5f6d38b7458b8a back in 2013

Re: [Qemu-devel] [PATCH] arm: Ensure LSB of BLX is set

2015-07-06 Thread Peter Maydell
On 6 July 2015 at 19:09, wrote: > From: Meador Inge > > This small patch adds a sanity check when disassembling > the BLX instruction. The use case came to light when > doing toolchain development and a similar check was > upstreamed for Binutils: > > * https://sourceware.org/ml/binutils/2011

Re: [Qemu-devel] [PATCH 2/2] target-arm: Add "anyvfp" CPU

2015-07-06 Thread Peter Crosthwaite
On Mon, Jul 6, 2015 at 11:53 AM, wrote: > From: Meador Inge > > This patch adds support for `-cpu anyvfp`, which is just > like `-cpu any`, but enables the coprocessors by default. So a better way to do this is via QOM properties. You can propertyify VFP support on the QOM type ARMCPU then user

Re: [Qemu-devel] [PATCH v2 2/3] hw/i386/pc: reflect any FDC @ ioport 0x3f0 in the CMOS

2015-07-06 Thread Laszlo Ersek
On 06/29/15 11:56, Michael S. Tsirkin wrote: > On Mon, Jun 29, 2015 at 11:33:42AM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >>> On Fri, Jun 26, 2015 at 02:50:04PM -0400, John Snow wrote: On 06/26/2015 08:25 AM, Laszlo Ersek wrote: > On 06/26/15 11:31, Markus Armbruster

[Qemu-devel] [PATCH 2/2] ahci: fix signature generation

2015-07-06 Thread John Snow
The initial register device-to-host FIS no longer needs to specially set certain fields, as these can be handled generically by setting those fields explicitly with the signatures we want at port reset time. (1) Signatures are decomposed into their four component registers and set upon (AHCI)

[Qemu-devel] [PATCH 0/2] ahci: Fix CD-ROM signature

2015-07-06 Thread John Snow
As reported by Hannes Reinecke, the signature generation in AHCI is a little goofy. Let's fix it up. Patch 1 should be considered a bugfix for 2.4. Patch 2 is mostly a tidying effort prompted by the first patch. For

[Qemu-devel] [PATCH 1/2] ahci: Fix CD-ROM signature

2015-07-06 Thread John Snow
From: Hannes Reinecke The CD-ROM signature is 0xeb140101, not 0xeb14. Without this change OVMF/Duet runs into a timeout trying to detect a SATA cdrom. Signed-off-by: Hannes Reinecke Signed-off-by: John Snow --- hw/ide/ahci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

Re: [Qemu-devel] [PATCH 1/2] target-arm: Allow CPU "any" for system-mode emulation

2015-07-06 Thread Peter Crosthwaite
On Mon, Jul 6, 2015 at 11:53 AM, wrote: > From: Meador Inge > > The "any" CPU is useful for cases where the system-mode > emulator is being used to work with a wide array of > bare-metal C/C++ applications that have been compiled > in different ways. > What is the system being created in this c

Re: [Qemu-devel] [PATCH] cpu_defs: Simplify CPUTLB padding logic

2015-07-06 Thread Peter Crosthwaite
On Mon, Jul 6, 2015 at 4:52 AM, Paolo Bonzini wrote: > > > On 06/07/2015 13:42, Richard Henderson wrote: >> On 07/06/2015 09:43 AM, Paolo Bonzini wrote: >>> >>> >>> On 05/07/2015 23:08, Peter Crosthwaite wrote: There was a complicated subtractive arithmetic for determining the padding on

Re: [Qemu-devel] [PATCH pic32 v2 5/5] Two new machine platforms: pic32mz7 and pic32mz.

2015-07-06 Thread Peter Crosthwaite
On Mon, Jul 6, 2015 at 11:58 AM, Serge Vakulenko wrote: > On Mon, Jul 6, 2015 at 12:33 AM, Antony Pavlov > wrote: >> On Sun, 5 Jul 2015 21:18:11 -0700 >> Serge Vakulenko wrote: >> >>> On Wed, Jul 1, 2015 at 6:41 AM, Aurelien Jarno wrote: >>> > On 2015-06-30 21:12, Serge Vakulenko wrote: >>> >>

Re: [Qemu-devel] [PATCH qemu v10 10/14] spapr_pci: Enable vfio-pci hotplug

2015-07-06 Thread Thomas Huth
On Mon, 6 Jul 2015 12:11:06 +1000 Alexey Kardashevskiy wrote: > sPAPR IOMMU is managing two copies of an TCE table: > 1) a guest view of the table - this is what emulated devices use and > this is where H_GET_TCE reads from; > 2) a hardware TCE table - only present if there is at least one vfio-

Re: [Qemu-devel] [PATCH qemu v10 09/14] spapr_vfio_pci: Remove redundant spapr-pci-vfio-host-bridge

2015-07-06 Thread Thomas Huth
On Mon, 6 Jul 2015 12:11:05 +1000 Alexey Kardashevskiy wrote: > sPAPRTCETable is handling 2 TCE tables already: > > 1) guest view of the TCE table - emulated devices use only this table; > > 2) hardware IOMMU table - VFIO PCI devices use it for actual work but > it does not replace 1) and it i

Re: [Qemu-devel] [PATCH 0/7] error: On abort, report where the error was created

2015-07-06 Thread Michael S. Tsirkin
On Mon, Jun 22, 2015 at 09:26:33PM +0200, Markus Armbruster wrote: > Applies on top of "[PULL 00/24] Monitor patches". I've no objection to this, though I'd still like to make it abort at the actuall error site too. That one will need a bit more work though. > Markus Armbruster (7): > error: De

Re: [Qemu-devel] [v11 01/15] vfio: extract vfio_get_hot_reset_info as a single function

2015-07-06 Thread Alex Williamson
On Wed, 2015-06-24 at 17:45 +0800, Chen Fan wrote: > the function is used to get affected devices by bus reset. > so here extract it, and can used for aer soon. > > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 66 > +++ > 1 file changed

Re: [Qemu-devel] [PATCH 7/7] error: On abort, report where the error was created

2015-07-06 Thread Laszlo Ersek
On 06/22/15 21:26, Markus Armbruster wrote: > This is particularly useful when we abort in error_propagate(), > because there the stack backtrace doesn't lead to where the error was > created. Looks like this: > > Unexpected error at /work/armbru/qemu/blockdev.c:322: > qemu-system-x86_64:

Re: [Qemu-devel] [v11 08/15] vfio: add check host bus reset is support or not

2015-07-06 Thread Alex Williamson
On Wed, 2015-06-24 at 17:46 +0800, Chen Fan wrote: > when init vfio devices done, we should test all the devices supported > aer whether conflict with others. For each one, get the hot reset > info for the affected device list. For each affected device, all > should attach to the VM and on the sam

  1   2   3   4   >