On 06/13/2015 08:20 AM, Markus Armbruster wrote:
> qerror_report() is a transitional interface to help with converting
> existing monitor commands to QMP. It should not be used elsewhere.
> Replace by error_report() in initial startup helpers parse_sandbox()
> and parse_add_fd().
>
> Signed-off-b
On 06/13/2015 08:20 AM, Markus Armbruster wrote:
> qerror_report_err() is a transitional interface to help with
> converting existing monitor commands to QMP. It should not be used
> elsewhere.
>
> The only remaining user in qemu-option.c is qemu_opts_parse(). Is it
> used in QMP context? If no
On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> Useless, because it can only occur in commands, and we're not dealing
> with commands here.
>
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi-types.py | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Eric Blake
--
Eric Blake ebl
On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi-types.py | 8 ++--
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http
On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi-types.py | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library
On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi-types.py | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization libra
On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi.py | 2 +-
> tests/qapi-schema/flat-union-array-branch.err | 11 +--
> 2 files changed, 2 insertions(+), 11 deletions(-)
>
Reviewed-by: Eric Blake
--
On Sat, Jun 13, 2015 at 5:56 PM, Liviu Ionescu wrote:
>
>> On 14 Jun 2015, at 01:46, Peter Crosthwaite
>> wrote:
>>
>>> not to mention that in real life situations, constructors are used to pass
>>> non-static data, for example the 'machine' structure (for various command
>>> line params) when
> On 14 Jun 2015, at 01:46, Peter Crosthwaite
> wrote:
>
>> not to mention that in real life situations, constructors are used to pass
>> non-static data, for example the 'machine' structure (for various command
>> line params) when constructing MCUs, or the 'mcu' when constructing LEDs.
>>
On Sat, Jun 13, 2015 at 11:57 AM, Liviu Ionescu wrote:
>
>> On 13 Jun 2015, at 21:29, Peter Crosthwaite
>> wrote:
>>
>>
>> ... As all the information
>> you need to construct the object is constant per-concrete class, the
>> information can be added to the class to resolve.
>
> the one-instance-
On Sat, Jun 13, 2015 at 12:52 PM, Liviu Ionescu wrote:
>
>> On 13 Jun 2015, at 21:57, Liviu Ionescu wrote:
>>
>> ... so, no, the class structure is not suitable for multi-instances objects,
>> and even for singletons I think that using it for passing such configuration
>> data is generally abus
On Fri, Jun 12, 2015 at 01:56:37PM +0200, Christian Borntraeger wrote:
> Am 10.06.2015 um 15:13 schrieb Michael S. Tsirkin:
> > On Wed, Jun 10, 2015 at 03:02:21PM +0300, Denis V. Lunev wrote:
> >> On 09/06/15 13:37, Christian Borntraeger wrote:
> >>> Am 09.06.2015 um 12:19 schrieb Denis V. Lunev:
>
> On 13 Jun 2015, at 21:57, Liviu Ionescu wrote:
>
> ... so, no, the class structure is not suitable for multi-instances objects,
> and even for singletons I think that using it for passing such configuration
> data is generally abusive.
not to mention that in real life situations, constructo
> On 13 Jun 2015, at 21:29, Peter Crosthwaite
> wrote:
>
>
> ... As all the information
> you need to construct the object is constant per-concrete class, the
> information can be added to the class to resolve.
the one-instance-per-class might be true for MCUs, but generally it isn't, for
ex
On Sat, Jun 13, 2015 at 4:41 AM, Liviu Ionescu wrote:
>
>> On 13 Jun 2015, at 12:29, Peter Crosthwaite
>> wrote:
>>
>>>
>>> STM32F103RB* mcu = new STM32F103RB(&stm32f103rb_capabilities);
>>>
>>
>> Is the capabilities genuinely variable from instance to instance?
>
> good point.
>
> my example wa
> On 13 Jun 2015, at 14:41, Liviu Ionescu wrote:
>
> ... so I invented another solution:
>
> - do not define any of the instance_init() and instance_post_init()
> - add custom construct(...) callbacks to all my classes
> - make each instance call parent construct(...) at the beginning, as for
On 06/12/2015 08:51 AM, Markus Armbruster wrote:
> The new test demonstrates another generator crash.
What, I missed one?
>
> Signed-off-by: Markus Armbruster
> ---
> tests/Makefile | 3 ++-
> tests/qapi-schema/flat-union-array-branch.err | 10 ++
> te
On 20/05/15 13:10, Peter Maydell wrote:
> On 20 May 2015 at 12:55, Fam Zheng wrote:
>> On Wed, 05/20 11:41, Peter Maydell wrote:
>>> On 20 May 2015 at 10:58, Michael S. Tsirkin wrote:
On Tue, May 19, 2015 at 09:11:26PM +0100, Peter Maydell wrote:
> On 19 May 2015 at 20:16, Michael S. Ts
On 13/06/15 08:53, Aurelien Jarno wrote:
>> As it's freeze coming up, I need to send an OpenBIOS pull request fairly
>> soon. Do you need anything from me to get this done beforehand?
>
> For what I can see on the server, I confirm that the openbios.git
> repository on git.qemu.org is point to a
In particular, don't include it into headers.
Signed-off-by: Markus Armbruster
---
backends/hostmem.c | 1 -
balloon.c| 1 +
block.c | 1 +
block/backup.c | 1 +
block/commit.c | 1 +
block/mirror.c | 1
These macros expand into error class enumeration constant, comma,
string. Unclean. Has been that way since commit 13f59ae.
The error class is always ERROR_CLASS_GENERIC_ERROR since the previous
commit.
Clean up as follows:
* Prepend every use of a QERR_ macro by ERROR_CLASS_GENERIC_ERROR, and
The traditional QMP command handler interface
int qmp_FOO(Monitor *mon, const QDict *params, QObject **ret_data);
doesn't provide for returning an Error object. Instead, the handler
is expected to stash it in the monitor with qerror_report().
When we rebased QMP on top of QAPI, we didn't ch
Signed-off-by: Markus Armbruster
---
audio/spiceaudio.c | 1 +
audio/wavcapture.c | 1 +
block.c | 1 +
block/curl.c| 1 +
block/dmg.c | 1 +
block/io.c | 1 +
block/iscsi.c | 1 +
block/qcow2-sna
In particular, don't include it into headers.
Signed-off-by: Markus Armbruster
---
balloon.c | 2 +-
blockdev-nbd.c| 1 -
hw/core/platform-bus.c| 1 -
hw/display/qxl.c | 1 -
hw/i386/pc.c | 1 -
hw/ide/ahci.c
Remove it except for two things in qerror.h:
* Two #include to be cleaned up separately to avoid cluttering this
patch.
* The QERR_ macros. Mark as obsolete.
Signed-off-by: Markus Armbruster
---
block/qapi.c | 6 --
include/monitor/monitor.h | 1 -
include/qapi/qmp/qerror
qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP. It should not be used
elsewhere.
The only remaining user in qemu-option.c is qemu_opts_parse(). Is it
used in QMP context? If not, we can simply replace
qerror_report_err() by error_report_
After a bit over a year and many patches, QError is finally ripe. All
that's left of qerror.h after this series is a bunch of QERR_ macros.
Killing them is left for another day.
The diffstat looks a bit scary, but that's almost entirely due to
mechanical changes like PATCH 05.
This series applie
Error classes other than ERROR_CLASS_GENERIC_ERROR should not be used
in new code. Hiding them in QERR_ macros makes new uses hard to spot.
Fortunately, there's just one such macro left. Eliminate it with this
coccinelle semantic patch:
@@
expression EP, E;
@@
-error_set(EP, QERR
qerror_report() is a transitional interface to help with converting
existing monitor commands to QMP. It should not be used elsewhere.
Replace by error_report().
Signed-off-by: Markus Armbruster
---
tpm.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/tpm.c b/tpm
Results in nicer error messages. Before this patch:
Invalid GTK option string: gtk,lirum-larum
After:
qemu-system-x86_64: -display gtk,lirum-larum: Invalid GTK option string
Of course, the thing ought to use QemuOpts instead of parsing by hand.
Signed-off-by: Markus Armbruster
---
v
qerror_report() is a transitional interface to help with converting
existing monitor commands to QMP. It should not be used elsewhere.
Replace by error_report() in initial startup helpers parse_sandbox()
and parse_add_fd().
Signed-off-by: Markus Armbruster
---
vl.c | 23 +--
SeaBIOS expects OpenFirmware device paths in the "bootorder" fw_cfg file
to follow the pattern
/pci-root@N/pci@i0cf8/...
for devices that live behind an extra root bus. The extra root bus in
question is the N'th among the extra root bridges. (In other words, N
gives the position of the affected
Cc: Markus Armbruster
Cc: Marcel Apfelbaum
Cc: Michael S. Tsirkin
Signed-off-by: Laszlo Ersek
---
Notes:
v4:
- unchanged
v3:
- new in v3
hw/core/sysbus.c | 16 ++--
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/hw/core/sysbus.c b/hw/core/sysb
The sysbus_get_fw_dev_path() function formats OpenFirmware device path
nodes ("driver-name@unit-address") for sysbus devices. The first choice
for "unit-address" is the base address of the device's first MMIO region.
The second choice is its first IO port.
However, if two sysbus devices with the s
OVMF downloads the ACPI linker/loader script from QEMU when the edk2 PCI
Bus driver globally signals the firmware that PCI enumeration and resource
allocation have completed. At this point QEMU regenerates the ACPI payload
in an fw_cfg read callback, and this is when the PXB's _CRS gets
populated.
Patches 1 and 2 are carried forward from the last (v3) posting without
any changes. Patch 1 is now formatted non-differentially (ie. without
copy detection).
Patches 3 and 4 are new.
Thanks
Laszlo
Cc: Marcel Apfelbaum
Cc: Michael S. Tsirkin
Cc: Markus Armbruster
Cc: Kevin O'Connor
Laszlo Er
Following up on this cross-posted message, I will send two patch sets,
one for QEMU (to qemu-devel) and another for OVMF (to edk2-devel). With
both in place, OVMF supports multiple PCI root buses, and SeaBIOS
recognizes boot options that reference devices behind PXBs.
* Background.
Since the last
Add related configuration, make files for tilegx. Now, qemu tilegx can
pass building, and finish running "Hello world" static/shared elf64
binary.
Signed-off-by: Chen Gang
---
configure | 2 ++
default-configs/tilegx-linux-user.mak | 1 +
target-tilegx/Makefile.objs
Generate related tcg instructions, and qemu tilegx can finish running
"Hello world". The elf64 binary can be static or shared.
Signed-off-by: Chen Gang
---
target-tilegx/translate.c | 2966 +
1 file changed, 2966 insertions(+)
create mode 100644 targe
The related instructions are exception, cntlz, cnttz, shufflebytes, and
add_saturate.
Signed-off-by: Chen Gang
---
target-tilegx/helper.c | 83 ++
target-tilegx/helper.h | 5 +++
2 files changed, 88 insertions(+)
create mode 100644 target-tilegx/
The related copy is from Linux kernel "arch/tile/include/uapi/arch/
spr_def_64.h".
Signed-off-by: Chen Gang
---
target-tilegx/spr_def_64.h | 216 +
1 file changed, 216 insertions(+)
create mode 100644 target-tilegx/spr_def_64.h
diff --git a/target-ti
It implements minimized cpu features for linux-user.
Signed-off-by: Chen Gang
---
target-tilegx/cpu.c | 143 ++
target-tilegx/cpu.h | 175
2 files changed, 318 insertions(+)
create mode 100644 target-ti
Use 'inline' instead of '__inline', and also use 'uint64_t' instead of
"unsigned long long"
Signed-off-by: Chen Gang
---
target-tilegx/opcode_tilegx.h | 220 +-
1 file changed, 110 insertions(+), 110 deletions(-)
diff --git a/target-tilegx/opcode_tilegx.h
It is copied from Linux kernel "arch/tile/include/uapi/arch/
opcode_tilegx.h".
Signed-off-by: Chen Gang
---
target-tilegx/opcode_tilegx.h | 1406 +
1 file changed, 1406 insertions(+)
create mode 100644 target-tilegx/opcode_tilegx.h
diff --git a/target-ti
Some of architectures (e.g. tilegx), several syscall macros are not
supported, so switch them.
Signed-off-by: Chen Gang
---
linux-user/syscall.c | 50 +-
1 file changed, 49 insertions(+), 1 deletion(-)
diff --git a/linux-user/syscall.c b/linux-use
Add main working flow feature, system call processing feature, and elf64
tilegx binary loading feature, based on Linux kernel tilegx 64-bit
implementation.
Signed-off-by: Chen Gang
---
include/elf.h | 2 +
linux-user/elfload.c | 23
linux-user/main.c | 295 ++
They are based on Linux kernel tilegx architecture for 64 bit binary,
and also based on tilegx ABI reference document, and also reference from
other targets implementations.
Signed-off-by: Chen Gang
---
linux-user/tilegx/syscall.h| 40 +
linux-user/tilegx/syscall_nr.h | 324
It can finish running "Hello world" elf64 binary, and the related test
cases:
- with "--enable-debug", enable assertion with "-g":
./tilegx-linux-user/qemu-tilegx -L /upstream/release-tile
/upstream/release-tile/test/test_shared
./tilegx-linux-user/qemu-tilegx -d all -L /upstream/relea
> On 13 Jun 2015, at 12:29, Peter Crosthwaite
> wrote:
>
>>
>> STM32F103RB* mcu = new STM32F103RB(&stm32f103rb_capabilities);
>>
>
> Is the capabilities genuinely variable from instance to instance?
good point.
my example was not very accurate, the capabilities are indeed specific to a
c
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
qdev-monitor.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qdev-monitor.c b/qdev-monitor.c
index b5b9a88..e7e9a50 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -156,8 +156,7 @@ static int set_propert
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
hw/core/qdev.c | 47 ---
include/hw/qdev-core.h | 3 +--
2 files changed, 17 insertions(+), 33 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index b0f0f84..d433675 10064
As usual, the conversion breaks printing explanatory messages after
the error: actual printing of the error gets delayed, so the
explanations precede rather than follow it.
Pity. Disable them for now. See also commit 7216ae3.
While there, eliminate QERR_BUS_NOT_FOUND, and clean up unusual
spell
Also polish an error message while I'm touching the line anyway,
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
include/monitor/qdev.h | 2 +-
qdev-monitor.c | 36 +++-
vl.c | 7 +--
3 files changed, 21 insertions(+),
It's a perfectly sensible helper function.
Signed-off-by: Markus Armbruster
Reviewed-by: Eric Blake
---
include/hw/qdev-core.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index 5789b91..fbfc741 100644
--- a/include/hw/qdev-core.h
+++ b/in
Only the calls in do_device_add() remain, because QMP's command
handler interface requires them. They'll go away when I wean QMP off
QError.
Bonus: a few error reporting improvements.
Casualty: some explanatory messages, see PATCH 5.
Based on "[PULL 0/9] Error reporting patches".
v2:
* Trivial
Property bus has always been too screwed up to be really usable for
values other than plain bus IDs. This just fixes a bug that crept in
in commit 1395af6 "qdev: add a maximum device allowed field for the
bus."
It doesn't always fail when it should:
$ qemu-system-x86_64 -nodefaults -device v
Reproducer:
$ qemu-system-x86_64 -nodefaults -device virtio-rng-pci -device
virtio-rng-pci -device virtio-rng-device,bus=virtio-bus
qemu-system-x86_64: -device virtio-rng-device,bus=virtio-bus: Bus
'virtio-bus' is full
qemu-system-x86_64: -device virtio-rng-device,bus=virtio-bus: Bus
On Fri, Jun 12, 2015 at 4:33 AM, Liviu Ionescu wrote:
> while implementing the cortex-m hierarchical objects I faced several problems
> that required some hack, and I wanted to know your comments on them.
>
> for convenience I'll explain the problem in C++ and then return to the issues
> of the
any object oriented gurus around?
regards,
Liviu
> On 12 Jun 2015, at 14:33, Liviu Ionescu wrote:
>
> while implementing the cortex-m hierarchical objects I faced several problems
> that required some hack, and I wanted to know your comments on them.
>
> for convenience I'll explain the pro
Hi Denis, Andrey, I have a few comments and questions. (re-sending in
plain-text mode, apologies for sending twice.)
On Thu, Jun 11, 2015 at 6:18 AM, Denis V. Lunev wrote:
> From: Andrey Smetanin
>
> Windows 2012 guests can notify hypervisor about occurred guest crash
> (Windows bugcheck(BSOD))
On 2015-06-11 23:34, Mark Cave-Ayland wrote:
> On 09/06/15 11:22, Stefan Hajnoczi wrote:
> > On Tue, May 19, 2015 at 09:55:12PM +0100, Peter Maydell wrote:
> >> On 19 May 2015 at 21:47, Mark Cave-Ayland
> >> wrote:
> >>> On 19/05/15 13:55, Andreas Färber wrote:
> >>>
> Am 19.05.2015 um 12:42
Hi Denis, Andrey, I have a few comments and questions.
On Thu, Jun 11, 2015 at 6:18 AM, Denis V. Lunev wrote:
> From: Andrey Smetanin
>
> Windows 2012 guests can notify hypervisor about occurred guest crash
> (Windows bugcheck(BSOD)) by writing specific Hyper-V msrs. This patch does
> handling
62 matches
Mail list logo
