Re: [Qemu-devel] [PATCH v5 2/4] monitor: cleanup parsing of cmd name and cmd arguments

2015-06-11 Thread Markus Armbruster
Bandan Das writes: > There's too much going on in monitor_parse_command(). > Split up the arguments parsing bits into a separate function > monitor_parse_arguments(). Let the original function check for > command validity and sub-commands if any and return data (*cmd) > that the newly introduced

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Gerd Hoffmann
Hi, > On each boot, coreboot might decide to assign a different bus id to > the extra roots (for example, if a device with a PCI bridge is > inserted and it's bus allocation causes bus ids to shift). > Technically, coreboot could even change the order extra buses are > assigned bus ids, but does

Re: [Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-06-11 Thread Markus Armbruster
Patch looks good to me, but it made me wonder about something. Please find the question inline. Eric Blake writes: > We require a C99 compiler, so let's use 'bool' instead of 'int' > when dealing with boolean values. There are few enough clients > to fix them all in one pass. > > Signed-off-by

[Qemu-devel] [PULL 19/21] Teach analyze-migration.py about section footers

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert Signed-off-by: Juan Quintela --- scripts/analyze-migration.py | 5 + 1 file changed, 5 insertions(+) diff --git a/scripts/analyze-migration.py b/scripts/analyze-migration.py index 0c8b22f..f6894be 100755 --- a/scripts/an

[Qemu-devel] [PULL 16/21] Merge section header writing

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" The header writing for device sections is open coded in a few places, merge it into one. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/savevm.c | 72 +-

[Qemu-devel] [PULL 12/21] qemu_ram_foreach_block: pass up error value, and down the ramblock name

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" check the return value of the function it calls and error if it's non-0 Fixup qemu_rdma_init_one_block that is the only current caller, and rdma_add_block the only function it calls using it. Pass the name of the ramblock to the function; helps in debugging. Sig

[Qemu-devel] [PULL 15/21] Move loadvm_handlers into MigrationIncomingState

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" In postcopy we need the loadvm_handlers to be used in a couple of different instances of the loadvm loop/routine, and thus it can't be local any more. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson Reviewed-by: Juan Quintela Signed-off-by: Juan

[Qemu-devel] [PULL 21/21] Remove unneeded memset

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael R. Hines Signed-off-by: Juan Quintela --- migration/rdma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 6c1e73f..48b3e64 100644 --- a/migration/rdma.c +++

[Qemu-devel] [PULL 14/21] Move copy out of qemu_peek_buffer

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" qemu_peek_buffer currently copies the data it reads into a buffer, however a future patch wants access to the buffer without the copy, hence rework to remove the copy to the layer above. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Reviewed-by: Ju

[Qemu-devel] [PULL 11/21] Split header writing out of qemu_savevm_state_begin

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Split qemu_savevm_state_begin to: qemu_savevm_state_header That writes the initial file header. qemu_savevm_state_beginThat sets up devices and does the first device pass. Used later in postcopy. Signed-off-by: Dr. David Alan

[Qemu-devel] [PULL 17/21] Disable section footers on older machine types

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" The next patch adds section footers; but we don't want to break migration compatibility so disable them on older machine types Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- hw/i386/pc_piix.c | 2 ++

[Qemu-devel] [PULL 13/21] Create MigrationIncomingState

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" There are currently lots of pieces of incoming migration state scattered around, and postcopy is adding more, and it seems better to try and keep it together. allocate MIS in process_incoming_migration_co Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Sh

[Qemu-devel] [PULL 20/21] Rename RDMA structures to make destination clear

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" RDMA has two data types that are named confusingly; RDMALocalBlock (pointed to indirectly by local_ram_blocks) RDMARemoteBlock (pointed to by block in RDMAContext) RDMALocalBlocks, as the name suggests is a data strucuture that represents the RDMAable RAM Blo

[Qemu-devel] [PULL 10/21] Add qemu_get_counted_string to read a string prefixed by a count byte

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" and use it in loadvm_state and ram_load. Where ever it's used, check the return and error if it failed. Minor: ram_load was using a 257 byte array for its string, the maximum length is 255 bytes + 0 terminator, so fix to 256 Signed-off-by: Dr. David Alan G

[Qemu-devel] [PULL 01/21] migration: move ram stuff to migration/ram

2015-06-11 Thread Juan Quintela
For historic reasons, ram migration have been on arch_init.c. Just split it into migration/ram.c, the same that happened with block.c. There is only code movement, no changes altogether. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- MAINTAINERS |1 - Makefile.

[Qemu-devel] [PULL 09/21] migration: Use normal VMStateDescriptions for Subsections

2015-06-11 Thread Juan Quintela
We create optional sections with this patch. But we already have optional subsections. Instead of having two mechanism that do the same, we can just generalize it. For subsections we just change: - Add a needed function to VMStateDescription - Remove VMStateSubsection (after removal of the need

[Qemu-devel] [PULL 07/21] migration: Remove duplicated assignment of SETUP status

2015-06-11 Thread Juan Quintela
We assign the MIGRATION_STATUS_SETUP status in two places. Just in succession. Just remove the second one. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- migration/migration.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index 7

[Qemu-devel] [PULL 18/21] Add a protective section footer

2015-06-11 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Badly formatted migration streams can go undetected or produce misleading errors due to a lock of checking at the end of sections. In particular a section that adds an extra 0x00 at the end causes what looks like a normal end of stream and thus doesn't produce any e

[Qemu-devel] [PULL 06/21] rdma: Fix qemu crash when IPv6 address is used for migration

2015-06-11 Thread Juan Quintela
From: Padmanabh Ratnakar Qemu crashes when IPv6 address is specified for migration and access to any RDMA uverbs device available on the system is blocked using cgroups. Fix the crash by checking the return value of ibv_open_device routine. Signed-off-by: Meghana Cheripady Signed-off-by: Padman

[Qemu-devel] [PULL 04/21] migration: reduce include files

2015-06-11 Thread Juan Quintela
To make changes easier, with the copy, I maintained almost all include files. Now I remove the unnecessary ones on this patch. This compiles on linux x64 with all architectures configured, and cross-compiles for windows 32 and 64 bits. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake ---

[Qemu-devel] [PULL 03/21] migration: Add myself to the copyright list of both files

2015-06-11 Thread Juan Quintela
If anyone feels like adding himself to the list, just sent me a patch. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- migration/ram.c| 4 migration/savevm.c | 4 2 files changed, 8 insertions(+) diff --git a/migration/ram.c b/migration/ram.c index ff889ba..9db72a4 10064

[Qemu-devel] [PULL 02/21] migration: move savevm.c inside migration/

2015-06-11 Thread Juan Quintela
Now, everything is in place. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- MAINTAINERS| 1 - Makefile.target| 4 ++-- savevm.c => migration/savevm.c | 0 trace-events | 2 +- 4 files changed, 3 insertions(+), 4 deletions(-) renam

[Qemu-devel] [PULL 08/21] migration: create savevm_state

2015-06-11 Thread Juan Quintela
This way, we will put savevm global state here, instead of lots of variables. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/savevm.c | 51 --- 1 file changed, 28 insertions(+), 23 deletions(-) diff --git a/migrati

[Qemu-devel] [PULL 05/21] arch_init: Clean up the duplicate variable 'len' defining in ram_load()

2015-06-11 Thread Juan Quintela
From: zhanghailiang There are two places that define 'len' variable, It's OK for compiling, but makes it difficult for reading. Remove the local one which defined in the inside 'while' loop. Signed-off-by: zhanghailiang Signed-off-by: Juan Quintela --- migration/ram.c | 1 - 1 file changed,

[Qemu-devel] [PULL v2 00/21] migration pull request

2015-06-11 Thread Juan Quintela
Hi [v2] Just rebased. [v1] Here are the pull request, it includes: - generic patches form postcopy that are reviewed (dave) - generic patches form RDMA fixes that are reviewed (dave) - patches form optional section reviewed (me) - patches for migration events reviewed (me) - fix RDMA and ipv6

Re: [Qemu-devel] [PULL 20/22] hw/arm/boot: arm_load_kernel implemented as a machine init done notifier

2015-06-11 Thread Peter Crosthwaite
On Tue, Jun 2, 2015 at 9:33 AM, Peter Maydell wrote: > From: Eric Auger > > Device tree nodes for the platform bus and its children dynamic sysbus > devices are added in a machine init done notifier. To load the dtb once, > after those latter nodes are built and before ROM freeze, the actual > ar

Re: [Qemu-devel] [PATCH target-arm v1 8/9] arm: xlnx-zynqmp: Preface CPU variables with "A"

2015-06-11 Thread Alistair Francis
On Thu, Jun 11, 2015 at 9:58 AM, Peter Crosthwaite wrote: > On Tue, Jun 2, 2015 at 4:57 PM, Alistair Francis > wrote: >> On Tue, Jun 2, 2015 at 4:04 AM, Peter Crosthwaite >> wrote: >>> The CPUs currently supported by zynqmp are the APU (application >>> processing unit) CPUs. There are other CPUs

Re: [Qemu-devel] [PATCH] dma/rc4030: do multiple calls to address_space_rw when doing DMA transfers

2015-06-11 Thread Aurelien Jarno
On 2015-06-11 22:30, Hervé Poussineau wrote: > This workarounds a bug in memory management. > > To reproduce the problem, try to start the Windows NT 4.0/MIPS installer. > After loading some files, you should see a screen saying > "To set up Windows NT now, press ENTER." > However, you're welcomed

Re: [Qemu-devel] [PATCH 2/8] qcow2: add dirty-bitmaps feature

2015-06-11 Thread John Snow
On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy > > Adds dirty-bitmaps feature to qcow2 format as specified in > docs/specs/qcow2.txt > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/

Re: [Qemu-devel] [PATCH] MIPS: exceptions handling in icount mode

2015-06-11 Thread Aurelien Jarno
On 2015-06-10 11:33, Pavel Dovgalyuk wrote: > This patch fixes exception handling in MIPS. > MIPS instructions generate several types of exceptions. > When exception is generated, it breaks the execution of the current > translation > block. Implementation of the exceptions handling in MIPS does n

Re: [Qemu-devel] openbios.git mirror on git.qemu.org

2015-06-11 Thread Mark Cave-Ayland
On 09/06/15 11:22, Stefan Hajnoczi wrote: > On Tue, May 19, 2015 at 09:55:12PM +0100, Peter Maydell wrote: >> On 19 May 2015 at 21:47, Mark Cave-Ayland >> wrote: >>> On 19/05/15 13:55, Andreas Färber wrote: >>> Am 19.05.2015 um 12:42 schrieb Stefan Hajnoczi: > Ping. Should we stick with

Re: [Qemu-devel] [PATCH v3 0/7] target-mips: add support for large physical addresses

2015-06-11 Thread Aurelien Jarno
On 2015-06-09 17:42, Leon Alrae wrote: > Hi, > > This patchset adds large physical address support in MIPS, specifically: > * eXtended Physical Addressing (XPA) > * Large Physical Addressing (LPA) > > XPA and LPA are enabled in MIPS32R5-generic and MIPS64R6-generic cores > respectively. > > The

Re: [Qemu-devel] Steal time MSR not set properly during live migration?

2015-06-11 Thread Michael Tokarev
11.06.2015 23:46, Apollon Oikonomopoulos wrote: > On 15:12 Wed 03 Jun , Apollon Oikonomopoulos wrote: >> Any ideas? > > As far as I understand, there is an issue when reading the MSR on the > incoming side: there is a KVM_SET_MSRS vcpu ioctl issued by the main > thread during initialization,

Re: [Qemu-devel] [PATCH 7/8] qemu: command line option for dirty bitmaps

2015-06-11 Thread John Snow
On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: > From: Vladimir Sementsov-Ogievskiy > > The patch adds the following command line option: > > -dirty-bitmap [option1=val1][,option2=val2]... > Available options are: > name The name for the bitmap (necessary). > >

Re: [Qemu-devel] Steal time MSR not set properly during live migration?

2015-06-11 Thread Apollon Oikonomopoulos
On 15:12 Wed 03 Jun , Apollon Oikonomopoulos wrote: > Any ideas? As far as I understand, there is an issue when reading the MSR on the incoming side: there is a KVM_SET_MSRS vcpu ioctl issued by the main thread during initialization, that causes the initial vCPU steal time value to be set u

[Qemu-devel] [PATCH] dma/rc4030: do multiple calls to address_space_rw when doing DMA transfers

2015-06-11 Thread Hervé Poussineau
This workarounds a bug in memory management. To reproduce the problem, try to start the Windows NT 4.0/MIPS installer. After loading some files, you should see a screen saying "To set up Windows NT now, press ENTER." However, you're welcomed with an IRQL_NOT_LESS_OR_EQUAL bugcheck or an Unknown Ha

Re: [Qemu-devel] [PATCH v2 RFC 0/8] block: persistent dirty bitmaps

2015-06-11 Thread Stefan Hajnoczi
The load/store API is not scalable when bitmaps are 1 MB or larger. For example, a 500 GB disk image with 64 KB granularity requires a 1 MB bitmap. If a guest has several disk images of this size, then multiple megabytes must be read to start the guest and written out to shut down the guest. By

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Kevin O'Connor
On Thu, Jun 11, 2015 at 08:34:56PM +0200, Laszlo Ersek wrote: > On 06/11/15 19:46, Marcel Apfelbaum wrote: > > On 06/11/2015 07:54 PM, Kevin O'Connor wrote: > >> On real machines, the firmware assigns the 4 - it's not a physical > >> address; it's a logical address (like all bus numbers in PCI). T

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Kevin O'Connor
On Thu, Jun 11, 2015 at 08:46:01PM +0300, Marcel Apfelbaum wrote: > On 06/11/2015 07:54 PM, Kevin O'Connor wrote: > >On real machines, the firmware assigns the 4 - it's not a physical > >address; it's a logical address (like all bus numbers in PCI). The > >firmware might assign a totally different

Re: [Qemu-devel] [PATCH v2 06/12] Translate offsets to destination address space

2015-06-11 Thread Michael R. Hines
On 06/11/2015 01:58 PM, Dr. David Alan Gilbert wrote: * Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" The 'offset' field in RDMACompress and 'current_addr' field in RDMARegister are commented as

Re: [Qemu-devel] [PATCH 0/4] PPC IBM 40p PReP emulation

2015-06-11 Thread Hervé Poussineau
Hi Artyom, Le 11/06/2015 10:02, Artyom Tarasenko a écrit : Hi Hervé, On Wed, Jun 10, 2015 at 11:18 PM, Hervé Poussineau wrote: Hi, This patchset adds the emulation of the IBM RS/6000 7020 (40p). Well done! Congratulations on a good job! The real machine is able to run AIX (up to 4.3.3),

Re: [Qemu-devel] [PATCH v2 06/12] Translate offsets to destination address space

2015-06-11 Thread Dr. David Alan Gilbert
* Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: > On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: > >From: "Dr. David Alan Gilbert" > > > >The 'offset' field in RDMACompress and 'current_addr' field > >in RDMARegister are commented as being offsets within a particular > >RAMBloc

Re: [Qemu-devel] [PATCH v2 10/12] Sort destination RAMBlocks to be the same as the source

2015-06-11 Thread Michael R. Hines
On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" Use the order of incoming RAMBlocks from the source to record an index number; that then allows us to sort the destination local RAMBlock list to match the source. Now that the RAMBlocks are known to be

Re: [Qemu-devel] [PATCH v2 09/12] Rework ram block hash

2015-06-11 Thread Dr. David Alan Gilbert
* Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: > On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: > >From: "Dr. David Alan Gilbert" > > > >RDMA uses a hash from block offset->RAM Block; this isn't needed > >on the destination, and it becomes harder to maintain after the next > >

Re: [Qemu-devel] [PATCH v2 07/12] Rework ram_control_load_hook to hook during block load

2015-06-11 Thread Dr. David Alan Gilbert
* Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: > On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: > >From: "Dr. David Alan Gilbert" > > > >We need the names of RAMBlocks as they're loaded for RDMA, > >reuse a slightly modified ram_control_load_hook: > > a) Pass a 'data' parame

Re: [Qemu-devel] [PATCH v2 09/12] Rework ram block hash

2015-06-11 Thread Michael R. Hines
On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" RDMA uses a hash from block offset->RAM Block; this isn't needed on the destination, and it becomes harder to maintain after the next patch in the series that sorts the block list. Split the hash so that

Re: [Qemu-devel] [PATCH v2 08/12] Allow rdma_delete_block to work without the hash

2015-06-11 Thread Dr. David Alan Gilbert
* Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: > On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: > >From: "Dr. David Alan Gilbert" > > > >In the next patch we remove the hash on the destination, > >rdma_delete_block does two things with the hash which can be avoided: > > a) T

Re: [Qemu-devel] [SeaBIOS] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Laszlo Ersek
On 06/11/15 18:48, Kevin O'Connor wrote: > On Thu, Jun 11, 2015 at 04:35:33PM +0200, Laszlo Ersek wrote: >> On 06/11/15 15:58, Kevin O'Connor wrote: >>> On Thu, Jun 11, 2015 at 04:37:08PM +0300, Marcel Apfelbaum wrote: The fixes solves the following issue: The PXB device exposes a new pc

Re: [Qemu-devel] [PATCH v2 04/12] rdma typos

2015-06-11 Thread Dr. David Alan Gilbert
* Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote: > On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: > >From: "Dr. David Alan Gilbert" > > > >A couple of typo fixes. > > > >Signed-off-by: Dr. David Alan Gilbert > >--- > > migration/rdma.c | 6 +++--- > > trace-events | 4 ++--

Re: [Qemu-devel] [PATCH v2 08/12] Allow rdma_delete_block to work without the hash

2015-06-11 Thread Michael R. Hines
On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" In the next patch we remove the hash on the destination, rdma_delete_block does two things with the hash which can be avoided: a) The caller passes the offset and rdma_delete_block looks it up in

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Laszlo Ersek
On 06/11/15 19:46, Marcel Apfelbaum wrote: > On 06/11/2015 07:54 PM, Kevin O'Connor wrote: >> On Thu, Jun 11, 2015 at 05:36:06PM +0300, Marcel Apfelbaum wrote: >>> On 06/11/2015 05:24 PM, Kevin O'Connor wrote: On Thu, Jun 11, 2015 at 05:12:33PM +0300, Marcel Apfelbaum wrote: > On 06/11/201

Re: [Qemu-devel] [PATCH v2 07/12] Rework ram_control_load_hook to hook during block load

2015-06-11 Thread Michael R. Hines
On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" We need the names of RAMBlocks as they're loaded for RDMA, reuse a slightly modified ram_control_load_hook: a) Pass a 'data' parameter to use for the name in the block-reg case b) Only some ho

Re: [Qemu-devel] [PATCH v2 06/12] Translate offsets to destination address space

2015-06-11 Thread Michael R. Hines
On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" The 'offset' field in RDMACompress and 'current_addr' field in RDMARegister are commented as being offsets within a particular RAMBlock, however they appear to actually be offsets within the ram_addr_t sp

Re: [Qemu-devel] [PATCH v2 0/2] Makefile: Generate tag files under $SRC_PATH

2015-06-11 Thread John Snow
On 06/11/2015 04:41 AM, Fam Zheng wrote: > On Fri, 05/22 13:35, Fam Zheng wrote: > > Ping :) > > Fam > >> >> >> Fam Zheng (2): >> Makefile: Fix "make cscope TAGS" >> Makefile: Add "make ctags" >> >> Makefile | 20 +++- >> 1 file changed, 15 insertions(+), 5 deletions(-) >>

Re: [Qemu-devel] [RFC v6 0/2] monitor: add memory search commands s, sp

2015-06-11 Thread Luiz Capitulino
On Thu, 28 May 2015 16:18:41 -0400 Luiz Capitulino wrote: > On Mon, 18 May 2015 13:22:16 +0200 > hw.clau...@gmail.com wrote: > > > From: Claudio Fontana > > > > This is the latest iteration of the memory search patch, > > including a trivial replacement for the memmem function for systems > >

Re: [Qemu-devel] [PATCH 0/2] Use bool for QBool

2015-06-11 Thread Luiz Capitulino
On Thu, 28 May 2015 15:54:12 -0400 Luiz Capitulino wrote: > On Fri, 15 May 2015 16:24:58 -0600 > Eric Blake wrote: > > > Passing around an 'int' for a QBool type is weird, when we already > > use a C99 compiler and have a sane 'bool' that does just fine. > > > > I half-debated sending this thr

Re: [Qemu-devel] [PATCH v5 0/4] monitor: suggest running "help" for command errors

2015-06-11 Thread Luiz Capitulino
On Mon, 08 Jun 2015 10:53:23 +0200 Markus Armbruster wrote: > Copying HMP maintainer Luiz. > > Series > Reviewed-by: Markus Armbruster > > Bandan, thanks for your patience. > > Luiz, my monitor/QMP queue is currently empty, but if it fills up before > you get around to doing a monitor/HMP pul

Re: [Qemu-devel] [PATCH v2 0/2] monitor+disas: Remove uses of ENV_GET_CPU

2015-06-11 Thread Luiz Capitulino
On Sun, 24 May 2015 14:20:39 -0700 Peter Crosthwaite wrote: > Neither the monitor or disassembly core has a good reason to navigate from an > env pointer to a cpu pointer. Disas should not need env awarness at all, that > is removed in P2. > > The monitor is trickier, the env is still needed by

Re: [Qemu-devel] [PATCH v2 04/12] rdma typos

2015-06-11 Thread Michael R. Hines
On 06/11/2015 12:17 PM, Dr. David Alan Gilbert (git) wrote: From: "Dr. David Alan Gilbert" A couple of typo fixes. Signed-off-by: Dr. David Alan Gilbert --- migration/rdma.c | 6 +++--- trace-events | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/rdm

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 07:54 PM, Kevin O'Connor wrote: On Thu, Jun 11, 2015 at 05:36:06PM +0300, Marcel Apfelbaum wrote: On 06/11/2015 05:24 PM, Kevin O'Connor wrote: On Thu, Jun 11, 2015 at 05:12:33PM +0300, Marcel Apfelbaum wrote: On 06/11/2015 04:58 PM, Kevin O'Connor wrote: On Thu, Jun 11, 2015 at

[Qemu-devel] [PATCH v2 12/12] Fail more cleanly in mismatched RAM cases

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" If the number of RAMBlocks was different on the source from the destination, QEMU would hang waiting for a disconnect on the source and wouldn't release from that hang until the destination was manually killed. Mark the stream as being in error, this causes the des

[Qemu-devel] [PATCH v2 07/12] Rework ram_control_load_hook to hook during block load

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" We need the names of RAMBlocks as they're loaded for RDMA, reuse a slightly modified ram_control_load_hook: a) Pass a 'data' parameter to use for the name in the block-reg case b) Only some hook types now require the presence of a hook function. Signed-off

[Qemu-devel] [PATCH v2 08/12] Allow rdma_delete_block to work without the hash

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" In the next patch we remove the hash on the destination, rdma_delete_block does two things with the hash which can be avoided: a) The caller passes the offset and rdma_delete_block looks it up in the hash; fixed by getting the caller to pass the block b) Th

[Qemu-devel] [PATCH v2 04/12] rdma typos

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" A couple of typo fixes. Signed-off-by: Dr. David Alan Gilbert --- migration/rdma.c | 6 +++--- trace-events | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/rdma.c b/migration/rdma.c index bc73ff8..44ed996 100644 --- a/migrat

[Qemu-devel] [PATCH v2 06/12] Translate offsets to destination address space

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The 'offset' field in RDMACompress and 'current_addr' field in RDMARegister are commented as being offsets within a particular RAMBlock, however they appear to actually be offsets within the ram_addr_t space. The code currently assumes that the offsets on the sourc

[Qemu-devel] [PATCH v2 10/12] Sort destination RAMBlocks to be the same as the source

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Use the order of incoming RAMBlocks from the source to record an index number; that then allows us to sort the destination local RAMBlock list to match the source. Now that the RAMBlocks are known to be in the same order, this simplifies the RDMA Registration step

[Qemu-devel] [PATCH v2 09/12] Rework ram block hash

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" RDMA uses a hash from block offset->RAM Block; this isn't needed on the destination, and it becomes harder to maintain after the next patch in the series that sorts the block list. Split the hash so that it's only generated on the source. Signed-off-by: Dr. David

[Qemu-devel] [PATCH v2 05/12] Store block name in local blocks structure

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" In a later patch the block name will be used to match up two views of the block list. Keep a copy of the block name with the local block list. (At some point it could be argued that it would be best just to let migration see the innards of RAMBlock and avoid the n

[Qemu-devel] [PATCH v2 03/12] Remove unneeded memset

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael R. Hines --- migration/rdma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 38e5f44..bc73ff8 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -2445,7

[Qemu-devel] [PATCH v2 02/12] qemu_ram_foreach_block: pass up error value, and down the ramblock name

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" check the return value of the function it calls and error if it's non-0 Fixup qemu_rdma_init_one_block that is the only current caller, and rdma_add_block the only function it calls using it. Pass the name of the ramblock to the function; helps in debugging. Sig

[Qemu-devel] [PATCH v2 11/12] Sanity check RDMA remote data

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Perform some basic (but probably not complete) sanity checking on requests from the RDMA source. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael R. Hines --- migration/rdma.c | 30 ++ 1 file changed, 30 insertions(+) diff

[Qemu-devel] [PATCH v2 00/12] Remove RDMA migration dependence on RAMBlock offset

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" RDMA migration currently relies on the source and destination RAMBlocks having the same offsets within ram_addr_t space; unfortunately that's just not true when: a) You hotplug on the source but then create the device on the command line on the destination.

[Qemu-devel] [PATCH v2 01/12] Rename RDMA structures to make destination clear

2015-06-11 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" RDMA has two data types that are named confusingly; RDMALocalBlock (pointed to indirectly by local_ram_blocks) RDMARemoteBlock (pointed to by block in RDMAContext) RDMALocalBlocks, as the name suggests is a data strucuture that represents the RDMAable RAM Blo

[Qemu-devel] Runtime-modified DIMMs and live migration issue

2015-06-11 Thread Andrey Korolyov
Hello Igor, the current hotplug code for dimms effectively prohibiting a successful migration for VM if memory was added after startup: - start a VM with certain amount of empty memory slots, - add some dimms and online them in guest (I am transitioning from 2 to 16G with 512Mb DIMMs), - migrate

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Kevin O'Connor
On Thu, Jun 11, 2015 at 05:36:06PM +0300, Marcel Apfelbaum wrote: > On 06/11/2015 05:24 PM, Kevin O'Connor wrote: > >On Thu, Jun 11, 2015 at 05:12:33PM +0300, Marcel Apfelbaum wrote: > >>On 06/11/2015 04:58 PM, Kevin O'Connor wrote: > >>>On Thu, Jun 11, 2015 at 04:37:08PM +0300, Marcel Apfelbaum wr

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Kevin O'Connor
On Thu, Jun 11, 2015 at 04:35:33PM +0200, Laszlo Ersek wrote: > On 06/11/15 15:58, Kevin O'Connor wrote: > > On Thu, Jun 11, 2015 at 04:37:08PM +0300, Marcel Apfelbaum wrote: > >> The fixes solves the following issue: > >> The PXB device exposes a new pci root bridge with the > >> fw path: /pci-r

[Qemu-devel] [PATCH 5/6] nmi: Implement inject_nmi() for non-monitor context use

2015-06-11 Thread Christian Borntraeger
From: Xu Wang Let's introduce a general "inject_nmi()" function that doesn't rely on the cpu index of the monitor, but uses cpu index 0 as default (except for x86). This function can then later be used from a non-monitor context. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand CC: Alexey

[Qemu-devel] [PATCH 1/6] watchdog: change option wording to allow for more watchdogs

2015-06-11 Thread Christian Borntraeger
From: Xu Wang We will introduce a new watchdog for s390x. Lets adopt qemu-options.hx to allow more watchdog devices. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand Signed-off-by: Christian Borntraeger [split out qemu-option.hx base changes] --- qemu-options.hx | 23 ++-

Re: [Qemu-devel] [PATCH 6/8] qcow2: add autoclear bit for dirty bitmaps

2015-06-11 Thread John Snow
On 06/11/2015 06:49 AM, Vladimir Sementsov-Ogievskiy wrote: > On 11.06.2015 02:42, John Snow wrote: >> >> On 06/08/2015 11:21 AM, Vladimir Sementsov-Ogievskiy wrote: >>> From: Vladimir Sementsov-Ogievskiy >>> >>> Signed-off-by: Vladimir Sementsov-Ogievskiy >>> --- >>> block/qcow2-dirty-bitmap

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread John Snow
On 06/11/2015 06:25 AM, Vladimir Sementsov-Ogievskiy wrote: > On 10.06.2015 18:34, Kevin Wolf wrote: >> Am 08.06.2015 um 17:21 hat Vladimir Sementsov-Ogievskiy geschrieben: >>> From: Vladimir Sementsov-Ogievskiy >>> >>> Persistent dirty bitmaps will be saved into qcow2 files. It may be used >>>

[Qemu-devel] [PATCH 2/6] s390x/watchdog: introduce diag288 watchdog device

2015-06-11 Thread Christian Borntraeger
From: Xu Wang This patch introduces a new diag288 watchdog device that will, just like other watchdogs, monitor a guest and take corresponding actions when it detects that the guest is not responding. diag288 is s390x specific. The wiring to s390x KVM will be done in separate patches. Signed-of

Re: [Qemu-devel] [PATCH 1/8] spec: add qcow2-dirty-bitmaps specification

2015-06-11 Thread John Snow
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 06/11/2015 09:03 AM, Stefan Hajnoczi wrote: > On Thu, Jun 11, 2015 at 01:19:24PM +0300, Vladimir > Sementsov-Ogievskiy wrote: >> On 10.06.2015 16:24, Stefan Hajnoczi wrote: >>> On Wed, Jun 10, 2015 at 11:19:30AM +0300, Vladimir >>> Sementsov-Ogi

[Qemu-devel] [PATCH 3/6] s390x/kvm: diag288 instruction interception and handling

2015-06-11 Thread Christian Borntraeger
From: Xu Wang Intercept the diag288 requests from kvm guests, and hand the requested command to the diag288 watchdog device for further handling. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand Signed-off-by: Christian Borntraeger --- target-s390x/cpu.h | 1 + target-s390x/kvm

[Qemu-devel] [PATCH 0/6] s390x/watchdog: add diag288 based watchdog

2015-06-11 Thread Christian Borntraeger
This is the reworked patch set for the s390 diag288 watchdog. The previous version was posted bny Cornelia in this thread: https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg01950.html This patch set should address all review comments. If there are no blockers, pull request is planned for ne

[Qemu-devel] [PATCH 4/6] s390x/watchdog: diag288 migration support

2015-06-11 Thread Christian Borntraeger
From: Xu Wang Add vmstate structure to keep state and data during migration. Signed-off-by: Xu Wang Reviewed-by: David Hildenbrand Signed-off-by: Christian Borntraeger --- hw/watchdog/wdt_diag288.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/watchdog/wdt_diag288.c b/

[Qemu-devel] [PATCH 6/6] watchdog: Add new Virtual Watchdog action INJECT-NMI

2015-06-11 Thread Christian Borntraeger
From: Mao Chuan Li This patch allows QEMU to inject a NMI into a guest when the watchdog expires. Signed-off-by: Mao Chuan Li Reviewed-by: David Hildenbrand CC: Eric Blake CC: Markus Armbruster Signed-off-by: Christian Borntraeger --- hw/watchdog/watchdog.c | 10 ++ qapi-schema.jso

[Qemu-devel] About usb passthru and speed mismatch

2015-06-11 Thread Lin Ma
Hi Gerd, Based on the current implementation of 'usb_host_open' in hw/usb/host-libusb.c, When user performs usb_add, The usb device will be detached from kernel first, Then be checked for speed mismatch second. If it found speed mismatch, The usb device isn't attached to guest, But the usb d

Re: [Qemu-devel] [PULL 00/42] pc, acpi, virtio

2015-06-11 Thread Peter Maydell
On 11 June 2015 at 12:57, Michael S. Tsirkin wrote: > The following changes since commit 309750fad51f17d1ec6195c5d8ad7d741596ddb6: > > vhost: logs sharing (2015-06-04 12:44:49 +0200) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_ups

Re: [Qemu-devel] [vhost] virtio (guest) interrupt kernel modules

2015-06-11 Thread Catalin Vasile
It seems that the problem is from the code itself. If I call vhost_dev_start() in set_status() (in qemu), when the status changes to VIRTIO_CONFIG_S_DRIVER_OK, only the communication path from guest to vhost works. In another scenario I send a message from guest to qemu, and the vq handler in qemu

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Laszlo Ersek
On 06/11/15 16:36, Marcel Apfelbaum wrote: > On 06/11/2015 05:24 PM, Kevin O'Connor wrote: >> On Thu, Jun 11, 2015 at 05:12:33PM +0300, Marcel Apfelbaum wrote: >>> On 06/11/2015 04:58 PM, Kevin O'Connor wrote: On Thu, Jun 11, 2015 at 04:37:08PM +0300, Marcel Apfelbaum wrote: > The fixes so

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 05:24 PM, Kevin O'Connor wrote: On Thu, Jun 11, 2015 at 05:12:33PM +0300, Marcel Apfelbaum wrote: On 06/11/2015 04:58 PM, Kevin O'Connor wrote: On Thu, Jun 11, 2015 at 04:37:08PM +0300, Marcel Apfelbaum wrote: The fixes solves the following issue: The PXB device exposes a new pc

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Laszlo Ersek
On 06/11/15 15:58, Kevin O'Connor wrote: > On Thu, Jun 11, 2015 at 04:37:08PM +0300, Marcel Apfelbaum wrote: >> The fixes solves the following issue: >> The PXB device exposes a new pci root bridge with the >> fw path: /pci-root@4/..., in which 4 is the root bus number. >> Before this patch the f

Re: [Qemu-devel] [PULL 0/1] sdl patch queue

2015-06-11 Thread Peter Maydell
stream' into > staging (2015-06-08 15:57:41 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu tags/pull-sdl-20150611-1 > > for you to fetch changes up to 08d49df0dbaacc220a099dbfb644e1dc0eda57be: > > sdl2: fix crash in handl

[Qemu-devel] [vhost] virtio (guest) interrupt kernel modules

2015-06-11 Thread Catalin Vasile
Is there something I need to install (kernel module or something like that) so that the virtio guest receives signals from vhost? The communication from and to qemu works (I can send a message from guest to qemu, and I can send a message from qemu to guest), and I can send a message from guest to v

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Kevin O'Connor
On Thu, Jun 11, 2015 at 05:12:33PM +0300, Marcel Apfelbaum wrote: > On 06/11/2015 04:58 PM, Kevin O'Connor wrote: > >On Thu, Jun 11, 2015 at 04:37:08PM +0300, Marcel Apfelbaum wrote: > >>The fixes solves the following issue: > >>The PXB device exposes a new pci root bridge with the > >>fw path: /

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Give laptop users ability to scroll in monitor

2015-06-11 Thread Peter Maydell
On 11 May 2015 at 07:53, Gerd Hoffmann wrote: > On So, 2015-05-10 at 23:51 +0100, Peter Maydell wrote: >> So looking at the code in ui/console.c that implements our >> virtual consoles, the scrolling is hooked up to the keycodes >> QEMU_KEY_CTRL_{UP,DOWN,PAGEUP,PAGEDOWN}. These only seem >> to be

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Marcel Apfelbaum
On 06/11/2015 04:58 PM, Kevin O'Connor wrote: On Thu, Jun 11, 2015 at 04:37:08PM +0300, Marcel Apfelbaum wrote: The fixes solves the following issue: The PXB device exposes a new pci root bridge with the fw path: /pci-root@4/..., in which 4 is the root bus number. Before this patch the fw path

Re: [Qemu-devel] [PATCH v2] hw/vfio/platform: replace g_malloc0_n by g_new0

2015-06-11 Thread Peter Maydell
On 11 June 2015 at 09:44, Eric Auger wrote: > g_malloc0_n() is introduced since glib-2.24 while QEMU currently > requires glib-2.22. This may cause a link error on some distributions. > > Signed-off-by: Eric Auger > > --- > > v1 -> v2: > - replace g_malloc0 by g_new0 > --- > hw/vfio/platform.c |

[Qemu-devel] [PATCH 1/2] Constify some variable

2015-06-11 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- hw/display/qxl-logger.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/hw/display/qxl-logger.c b/hw/display/qxl-logger.c index c900c2c..d944d3f 100644 --- a/hw/display/qxl-logger.c +++ b/hw/display/qxl-logger.c @@ -22,7 +22,

Re: [Qemu-devel] [PATCH V2] pci: fixes to allow booting from extra root pci buses.

2015-06-11 Thread Kevin O'Connor
On Thu, Jun 11, 2015 at 04:37:08PM +0300, Marcel Apfelbaum wrote: > The fixes solves the following issue: > The PXB device exposes a new pci root bridge with the > fw path: /pci-root@4/..., in which 4 is the root bus number. > Before this patch the fw path was wrongly computed: > /pci-root@1/

  1   2   3   >