Re: [Qemu-devel] [PATCH 02/17] ipmi: Add a PC ISA type structure

2015-05-15 Thread Corey Minyard
On 05/13/2015 09:52 AM, Paolo Bonzini wrote: > > On 11/05/2015 21:58, Corey Minyard wrote: >> I've debated this in my mind since I've been learning more about >> qemu. Some of the bmc properties are being passed in to the interface >> and passed on to the bmc. Plus some IPMI systems have multiple >

Re: [Qemu-devel] [PATCH v2 0/7] Unify and QOMify (target|monitor)_disas

2015-05-15 Thread Peter Maydell
On 15 May 2015 at 22:01, Peter Crosthwaite wrote: > I'm guessing I need a signed key for that. Anyone know of someone in > San Francisco bay-area able to sign me? At the moment we're requiring signed tags, but not necessarily that all submaintainers have a web-of-trust path from me to them (thoug

[Qemu-devel] [PATCH 2/2] qobject: Use 'bool' inside qdict

2015-05-15 Thread Eric Blake
Now that qbool is fixed, let's fix getting and setting a bool value to a qdict member to also use C99 bool rather than int. I audited all callers to ensure that the changed return type will not cause any changed semantics. Signed-off-by: Eric Blake --- hmp.c | 40 +

[Qemu-devel] [PATCH 0/2] Use bool for QBool

2015-05-15 Thread Eric Blake
Passing around an 'int' for a QBool type is weird, when we already use a C99 compiler and have a sane 'bool' that does just fine. I half-debated sending this through qemu-trivial, but think it better belongs through the QMP tree. There turned out to be few enough clients that I grouped it into tw

[Qemu-devel] [PATCH 1/2] qobject: Use 'bool' for qbool

2015-05-15 Thread Eric Blake
We require a C99 compiler, so let's use 'bool' instead of 'int' when dealing with boolean values. There are few enough clients to fix them all in one pass. Signed-off-by: Eric Blake --- block/qapi.c| 2 +- block/quorum.c | 4 ++-- block/vvfat.c

Re: [Qemu-devel] [PATCH v2 0/7] Unify and QOMify (target|monitor)_disas

2015-05-15 Thread Peter Crosthwaite
On Fri, May 15, 2015 at 6:33 AM, Richard Henderson wrote: > On 05/14/2015 09:52 PM, Peter Crosthwaite wrote: >> Ping! >> >> Richard has RB'd the core stuff but do we need CPU arch maintainer >> acks on the latter patches? > > Yes, I'd prefer especially the arm patches get another look. > >> What q

Re: [Qemu-devel] [PATCH] microblaze: Remove uses of TCGv and target_ulong

2015-05-15 Thread Peter Crosthwaite
On Fri, May 15, 2015 at 10:17 AM, Richard Henderson wrote: > On 05/15/2015 09:48 AM, Peter Crosthwaite wrote: >> On Fri, May 15, 2015 at 8:41 AM, Richard Henderson wrote: >>> On 05/14/2015 09:49 PM, Peter Crosthwaite wrote: To prepare support for conversion of Microblaze TARGET_LONG to 64 bi

Re: [Qemu-devel] [RFC/RFT PATCH v2 3/3] arm/arm64: KVM: implement 'uncached' mem coherency

2015-05-15 Thread Jérémy Fanguède
On Fri, May 15, 2015 at 7:04 PM, Andrew Jones wrote: > On Fri, May 15, 2015 at 08:02:59AM -0700, Christoffer Dall wrote: >> On Thu, May 14, 2015 at 03:32:13PM +0200, Andrew Jones wrote: >> > On Thu, May 14, 2015 at 12:55:49PM +0200, Christoffer Dall wrote: >> > > On Wed, May 13, 2015 at 01:31:54PM

Re: [Qemu-devel] [PATCH 31/34] block: Move cache options into options QDict

2015-05-15 Thread Eric Blake
On 05/15/2015 12:43 PM, Max Reitz wrote: > On 08.05.2015 19:22, Kevin Wolf wrote: >> This adds the cache mode options to the QDict, so that they can be >> specified for child nodes (e.g. backing.cache.direct=off). >> >> The cache modes are not removed from the flags at this point; instead, >> optio

Re: [Qemu-devel] [PATCH 34/34] qemu-iotests: Test reopen with node-name/driver options

2015-05-15 Thread Max Reitz
On 08.05.2015 19:22, Kevin Wolf wrote: 'node-name' and 'driver' should not be changed during a reopen operation. It is, however, valid to specify them with the same value as they already had. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/133 | 90 +++

Re: [Qemu-devel] [PATCH 33/34] qemu-iotests: Test cache mode option inheritance

2015-05-15 Thread Max Reitz
On 08.05.2015 19:22, Kevin Wolf wrote: This is doing a more complete test on setting cache modes both while opening an image (i.e. in a -drive command line) and in reopen situations. It checks that reopen can specify options for child nodes and that cache modes are correctly inherited from parent

Re: [Qemu-devel] [PATCH v3 3/3] TPM2 ACPI table support

2015-05-15 Thread Stefan Berger
Igor Mammedov wrote on 05/15/2015 12:57:40 PM: > From: Igor Mammedov > To: Stefan Berger > Cc: qemu-devel@nongnu.org, m...@redhat.com, quan...@intel.com, Stefan > Berger/Watson/IBM@IBMUS, Dimitrios Pendarakis/Watson/IBM@IBMUS, > George Wilson/Austin/IBM@IBMUS > Date: 05/15/2015 01:07 PM > Subj

Re: [Qemu-devel] [PATCH 32/34] qemu-iotests: Try setting cache mode for children

2015-05-15 Thread Max Reitz
On 08.05.2015 19:22, Kevin Wolf wrote: This is a basic test for specifying cache modes for child nodes on the command line. It doesn't take much time and works without O_DIRECT support. Signed-off-by: Kevin Wolf --- tests/qemu-iotests/051 | 12 + tests/qemu-iotests/051.out | 63 +

Re: [Qemu-devel] [PATCH 31/34] block: Move cache options into options QDict

2015-05-15 Thread Max Reitz
On 08.05.2015 19:22, Kevin Wolf wrote: This adds the cache mode options to the QDict, so that they can be specified for child nodes (e.g. backing.cache.direct=off). The cache modes are not removed from the flags at this point; instead, options and flags are kept in sync. If the user specifies bo

Re: [Qemu-devel] [PATCH v2 3/6] Support Physical Presence Interface Spec

2015-05-15 Thread Stefan Berger
On 05/15/2015 11:13 AM, Igor Mammedov wrote: On Fri, 8 May 2015 12:15:17 -0400 Stefan Berger wrote: For automated management of a TPM device, implement the TCG Physical Presence Interface Specification that allows a root user on Linux (for example) to set an opcode for a sequence of TPM opera

Re: [Qemu-devel] [PATCH 10/23] userfaultfd: add new syscall to provide memory externalization

2015-05-15 Thread Linus Torvalds
On Fri, May 15, 2015 at 9:04 AM, Andrea Arcangeli wrote: > > To fix it I added this along a comment: Ok, this looks good as a explanation/fix for the races (and also as an example of my worry about waitqueue_active() use in general). However, it now makes me suspect that the optimistic "let's ch

Re: [Qemu-devel] [PATCH 30/34] block: reopen: Extract QemuOpts for generic block layer options

2015-05-15 Thread Max Reitz
On 08.05.2015 19:22, Kevin Wolf wrote: This patch adds a QemuOpts for generic block layer options to bdrv_reopen_prepare(). The only two options that exist currently (node-name and driver) cannot be changed And I don't suppose we want them to be changed at some point. (changing node-name doesn

Re: [Qemu-devel] [PATCH 29/34] qemu-iotests: Remove cache mode test without medium

2015-05-15 Thread Max Reitz
On 08.05.2015 19:22, Kevin Wolf wrote: Specifying the cache mode for a driver without a medium is not a useful thing to do: As long as there is no medium, the cache mode doesn't make a difference, and once the 'change' command is used to insert a medium, it ignores the old cache mode and makes th

Re: [Qemu-devel] [PATCH] qemu-iotests: Make debugging python tests easier

2015-05-15 Thread John Snow
On 05/15/2015 01:26 AM, Fam Zheng wrote: > Adding "-d" option. The output goes to "tee" so it appears in your > console. Also, raise the verbosity of unnitest runner. > > When testing a topic branch, it's possible that a bug introduced by a > code change makes the python test case hang, with deb

Re: [Qemu-devel] [PATCH 28/34] block: Introduce bs->explicit_options

2015-05-15 Thread Max Reitz
On 08.05.2015 19:22, Kevin Wolf wrote: bs->options doesn't only contain options that the user explicitly requested, but also option that were derived from flags, the filename or inherited from the parent node. For reopen, it is important to know the difference because reopening the parent can ch

[Qemu-devel] [PATCH 10/10] pc: Generate init functions with a macro

2015-05-15 Thread Eduardo Habkost
All pc-i440fx and pc-q35 init functions simply call the corresponding compat function and then call the main init function. Use a macro to generate that code. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 154 +- hw/i386/pc_q35.c | 9

[Qemu-devel] [PATCH 07/10] machine: Remove unused fields from QEMUMachine

2015-05-15 Thread Eduardo Habkost
This removes the following fields from QEMUMachine: family, alias, reset, hot_add_cpu, units_per_default_bus, no_serial, no_parallel, use_virtcon, use_sclp, no_floppy, no_cdrom, default_display, compat_props, and hw_version. The only users of those fields were already converted to use QOM and Mach

[Qemu-devel] [PATCH 08/10] piix: Add kvmclock_enabled, pci_enabled globals

2015-05-15 Thread Eduardo Habkost
This looks like a step backwards, but it will allow pc-0.1[0123] and isapc to follow the same compat+init pattern used by the other machine-types, allowing us to generate all init function using the same macro later. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 22 +++--

[Qemu-devel] [PATCH 06/10] pc: Remove qemu_register_pc_machine() function

2015-05-15 Thread Eduardo Habkost
The helper is not needed anymore, as the PC machine classes are registered using QOM directly. Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 45 - include/hw/i386/pc.h | 2 -- 2 files changed, 47 deletions(-) diff --git a/hw/i386/pc.c b/h

[Qemu-devel] [PATCH 05/10] pc: Don't use QEMUMachine anymore

2015-05-15 Thread Eduardo Habkost
Now that we have a DEFINE_PC_MACHINE helper macro that just requires an initialization function, it is trivial to convert them to register a QOM machine class directly, instead of using QEMUMachine. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 44 ++--

[Qemu-devel] [PATCH 04/10] pc: Move compat_props setting inside *_machine_options() functions

2015-05-15 Thread Eduardo Habkost
This will simplify the DEFINE_PC_MACHINE macro, and will help us to implement reuse of PC_COMPAT_* macros through class_init function reuse, in the future. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 60 ++-- hw/i386/pc_q35.c | 26

[Qemu-devel] [PATCH 03/10] pc: Convert *_MACHINE_OPTIONS macros into functions

2015-05-15 Thread Eduardo Habkost
By now the new functions will get QEMUMachine as argument, but they will be later converted to initialize a MachineClass struct directly. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 229 +++ hw/i386/pc_q35.c | 102 ++--

[Qemu-devel] [PATCH 09/10] piix: Eliminate pc_init_pci()

2015-05-15 Thread Eduardo Habkost
The function is not needed anymore, we can simply call pc_init1() directly. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c | 31 +-- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index cdc0443..01f938f 1006

[Qemu-devel] [PATCH 01/10] pc: Define MACHINE_OPTIONS macros consistently for all machines

2015-05-15 Thread Eduardo Habkost
Define a MACHINE_OPTIONS macro for each PC machine, and move every field inside the QEMUMachine structs to the macros, except for name, init, and compat_props. This also ensures that all MACHINE_OPTIONS inherit the fields from the next version, so their definitions carry only the changes that exis

[Qemu-devel] [PATCH 02/10] pc: Define machines using a DEFINE_PC_MACHINE macro

2015-05-15 Thread Eduardo Habkost
This will automatically generate the existing QEMUMachine structs based on the *_MACHINE_OPTIONS macros, and automatically add registration code for them. Signed-off-by: Eduardo Habkost --- hw/i386/pc_piix.c| 270 --- hw/i386/pc_q35.c | 118

[Qemu-devel] [PATCH 00/10] pc: Don't use QEMUMachine, simplify compat+init code

2015-05-15 Thread Eduardo Habkost
This series changes the PC code to not need QEMUMachine anymore, removes ~200 lines of code and simplifies the steps needed to new PC machines in the future. Previously, a new PC machine required: * A new PC_COMPAT_* macro; * A new pc_compat_*() function[1]; * A new pc_init_*() function; * A n

Re: [Qemu-devel] [PATCH] microblaze: Remove uses of TCGv and target_ulong

2015-05-15 Thread Richard Henderson
On 05/15/2015 09:48 AM, Peter Crosthwaite wrote: > On Fri, May 15, 2015 at 8:41 AM, Richard Henderson wrote: >> On 05/14/2015 09:49 PM, Peter Crosthwaite wrote: >>> To prepare support for conversion of Microblaze TARGET_LONG to 64 bits. >>> This in turn will then allow support for multi-arch QEMU

Re: [Qemu-devel] [RFC/RFT PATCH v2 3/3] arm/arm64: KVM: implement 'uncached' mem coherency

2015-05-15 Thread Andrew Jones
On Fri, May 15, 2015 at 08:02:59AM -0700, Christoffer Dall wrote: > On Thu, May 14, 2015 at 03:32:13PM +0200, Andrew Jones wrote: > > On Thu, May 14, 2015 at 12:55:49PM +0200, Christoffer Dall wrote: > > > On Wed, May 13, 2015 at 01:31:54PM +0200, Andrew Jones wrote: > > > > When S1 and S2 memory a

Re: [Qemu-devel] [PATCH v2 0/7] Unify and QOMify (target|monitor)_disas

2015-05-15 Thread Peter Crosthwaite
On Fri, May 15, 2015 at 6:33 AM, Richard Henderson wrote: > On 05/14/2015 09:52 PM, Peter Crosthwaite wrote: >> Ping! >> >> Richard has RB'd the core stuff but do we need CPU arch maintainer >> acks on the latter patches? > > Yes, I'd prefer especially the arm patches get another look. > >> What q

Re: [Qemu-devel] [RFC PATCH 21/34] arm: Rename all exceptions

2015-05-15 Thread Peter Crosthwaite
On Fri, May 15, 2015 at 6:36 AM, Richard Henderson wrote: > On 05/15/2015 03:59 AM, Andreas Färber wrote: >> I would prefer 1. independent of whether we rename them or not. We need >> a better distinction of internal vs. external for targets. > > +1. > Ok, Plan 1 wins. There is some devil in the

Re: [Qemu-devel] [PATCH v3 3/3] TPM2 ACPI table support

2015-05-15 Thread Igor Mammedov
On Fri, 15 May 2015 11:31:30 -0400 Stefan Berger wrote: > On 05/15/2015 10:44 AM, Igor Mammedov wrote: > > On Fri, 8 May 2015 11:52:46 -0400 > > Stefan Berger wrote: > > > >> Add a TPM2 ACPI table if a TPM 2 is used in the backend. > >> Also add an SSDT for the TPM 2. > >> > >> Rename tpm_find(

[Qemu-devel] [PULL v2 00/26] qapi: Fix qapi mangling of downstream names, and more

2015-05-15 Thread Markus Armbruster
The following changes since commit 1eeace9c237a729d11c7acd7c0338ab4562af637: Merge remote-tracking branch 'remotes/agraf/tags/signed-s390-for-upstream' into staging (2015-05-13 16:06:07 +0100) are available in the git repository at: git://repo.or.cz/qemu/armbru.git tags/pull-qapi-2015-05-1

Re: [Qemu-devel] [PATCH] microblaze: Remove uses of TCGv and target_ulong

2015-05-15 Thread Peter Crosthwaite
On Fri, May 15, 2015 at 8:41 AM, Richard Henderson wrote: > On 05/14/2015 09:49 PM, Peter Crosthwaite wrote: >> To prepare support for conversion of Microblaze TARGET_LONG to 64 bits. >> This in turn will then allow support for multi-arch QEMU including both >> Microblaze and 64-bit CPU targets (n

Re: [Qemu-devel] [PULL 00/26] qapi: Fix qapi mangling of downstream names, and more

2015-05-15 Thread Peter Maydell
On 15 May 2015 at 17:44, Markus Armbruster wrote: > Peter Maydell writes: >> This doesn't seem to be a signed tag, and I see from git history >> that previous qapi pulls have been signed; did something go >> wrong with your pull request creation? > > I fat-fingered the name of the tag. I'll rese

Re: [Qemu-devel] [PULL 00/26] qapi: Fix qapi mangling of downstream names, and more

2015-05-15 Thread Markus Armbruster
Peter Maydell writes: > On 15 May 2015 at 09:24, Markus Armbruster wrote: >> The following changes since commit 1eeace9c237a729d11c7acd7c0338ab4562af637: >> >> Merge remote-tracking branch >> remotes/agraf/tags/signed-s390-for-upstream' into staging >> (2015-05-13 16:06:07 +0100) >> >> are ava

[Qemu-devel] [PATCH 7/7] kvm-i386: register SMRAM regions with KVM_MEM_X86_SMRAM

2015-05-15 Thread Paolo Bonzini
This patch adds SMRAM regions to the KVM CPU address space. The /machine/smram container has KVM_MEM_X86_SMRAM set in the memory flags, and this flag is propagated to the memory slot. Signed-off-by: Paolo Bonzini --- target-i386/kvm.c | 27 +++ 1 file changed, 27 inserti

[Qemu-devel] [PATCH 5/7] memory: add kvm_mem_flags to MemoryRegion

2015-05-15 Thread Paolo Bonzini
This patch is ugly; it adds a KVM-specific flag to memory regions that is used to distinguish SMRAM regions from others. This of course is a layering violation, but I have no other good ideas about how to avoid it. If you let KVM use address_space_memory as it did until now, and add separate call

[Qemu-devel] [PATCH 6/7] i386: disable the region in /machine/smram when SMRAM is open

2015-05-15 Thread Paolo Bonzini
This patch provides some help from the chipset in handling SMRAM. SMRAM regions can overlap with e.g. PCI BARs. When this happens, PCI BARs will be hidden behind SMRAM and will cause a userspace MMIO exit. This can be achieved easily with KVM just by giving a higher priority to the SMRAM region.

[Qemu-devel] [PATCH 1/7] kvm-all: put kvm_mem_flags to more work

2015-05-15 Thread Paolo Bonzini
From: Andrew Jones Currently kvm_mem_flags just translates bools to bits, let's make it also determine the bools first. This avoids its parameter list growing each time we add a flag. Signed-off-by: Andrew Jones Signed-off-by: Paolo Bonzini --- kvm-all.c | 25 +++-- 1 file

[Qemu-devel] [PATCH 4/7] kvm-all: add KVM address space

2015-05-15 Thread Paolo Bonzini
Until now, KVM_SET_USER_MEMORY_REGION has been working on address_space_memory. However, KVM's memory slots are the CPU view of the memory, which does not exactly match address_space_memory. Let the architecture-specific code build the CPU view of the memory by combining address_space_memory and

[Qemu-devel] [PATCH 2/7] kvm-all: remove useless typedef

2015-05-15 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- kvm-all.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 6e1a3f8..8205ea1 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -69,8 +69,6 @@ typedef struct KVMSlot int flags; } KVMSlot; -typedef struct kvm_dirty_lo

[Qemu-devel] [PATCH 3/7] kvm-all: move KVMState definitions to kvm_int.h

2015-05-15 Thread Paolo Bonzini
i386 code will have to look inside KVMState in order to modify the address space used for KVM_SET_USER_MEM_REGION. Create an internal header so that KVMState is not exposed outside. Signed-off-by: Paolo Bonzini --- include/sysemu/kvm_int.h | 70

[Qemu-devel] [RFC PATCH 0/7] x86: SMRAM implementation for KVM

2015-05-15 Thread Paolo Bonzini
This is the final piece of x86 SMM implementation, tested with PIIX (low SMRAM) and Q35 (high SMRAM). There is a problem---it has an awful layering violation in patch 5, and an only slightly better one in patch 6. If anyone has ideas, please speak up. Note that it is not possible to call KVM_SET

Re: [Qemu-devel] [PULL 00/26] qapi: Fix qapi mangling of downstream names, and more

2015-05-15 Thread Peter Maydell
On 15 May 2015 at 09:24, Markus Armbruster wrote: > The following changes since commit 1eeace9c237a729d11c7acd7c0338ab4562af637: > > Merge remote-tracking branch 'remotes/agraf/tags/signed-s390-for-upstream' > into staging (2015-05-13 16:06:07 +0100) > > are available in the git repository at:

Re: [Qemu-devel] [PULL] Per-memory-op alignment checks

2015-05-15 Thread Peter Maydell
On 14 May 2015 at 20:20, Richard Henderson wrote: > No changes since the v2 patch set. Thanks for the quick review. > > > r~ > > > The following changes since commit 1eeace9c237a729d11c7acd7c0338ab4562af637: > > Merge remote-tracking branch 'remotes/agraf/tags/signed-s390-for-upstream' > into

Re: [Qemu-devel] [PATCH] pci: Fix compiler warning (MinGW-w64 gcc 4.9)

2015-05-15 Thread Eric Blake
On 05/15/2015 02:00 AM, Markus Armbruster wrote: > Stefan Weil writes: > >> i686-w64-mingw32-gcc 4.9.1 from Debian Jessie complains: >> > > This is obviously a bug in that version of MinGW. Have you reported it? I don't know if Debian has a bug filed against mingw yet, but I mentioned elsewhe

Re: [Qemu-devel] [RESEND PATCH v4] acpi: add acpi_send_gpe_event() to rise sci for hotplug

2015-05-15 Thread Igor Mammedov
On Wed, 13 May 2015 17:21:36 +0800 Zhu Guihua wrote: > Add a new API named acpi_send_gpe_event() to send hotplug SCI. > This API can be used by pci, cpu and memory hotplug. > > This patch is rebased on master. > > Signed-off-by: Zhu Guihua Reviewed-by: Igor Mammedov > --- > v4: > -rename s

Re: [Qemu-devel] [PATCH v5 3/4] cpu/apic: drop icc bus/bridge

2015-05-15 Thread Igor Mammedov
On Wed, 13 May 2015 15:11:16 +0800 Zhu Guihua wrote: > From: Chen Fan > > ICC bus was invented only to provide hotplug capability to > CPU and APIC because at the time being hotplug was available only for > BUS attached devices. > > Now this patch is to drop ICC bus impl, and switch to bus-les

Re: [Qemu-devel] [PATCH 10/23] userfaultfd: add new syscall to provide memory externalization

2015-05-15 Thread Andrea Arcangeli
On Thu, May 14, 2015 at 10:49:06AM -0700, Linus Torvalds wrote: > On Thu, May 14, 2015 at 10:31 AM, Andrea Arcangeli > wrote: > > +static __always_inline void wake_userfault(struct userfaultfd_ctx *ctx, > > + struct userfaultfd_wake_range > > *range) > >

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-15 Thread Eric Blake
On 05/15/2015 09:13 AM, Claudio Fontana wrote: >> Or back to the original question - why are we worrying about the O(n) >> memmem implementation when the naive O(n^2) is MUCH shorter and easier >> to understand, and where the scaling penalty is only apparent on really >> long corner case strings?

Re: [Qemu-devel] [PATCH v5 1/4] apic: move apic mmio register to each apic realizefn

2015-05-15 Thread Igor Mammedov
On Wed, 13 May 2015 15:11:14 +0800 Zhu Guihua wrote: > From: Chen Fan > > Due to local apic address is in view of CPU's address space, > so able to move apic mapping to each apic realizefn. maybe reword commit message like this: apic: map APIC's MMIO region at each CPU's address space Replace

Re: [Qemu-devel] [PATCH] microblaze: Remove uses of TCGv and target_ulong

2015-05-15 Thread Richard Henderson
On 05/14/2015 09:49 PM, Peter Crosthwaite wrote: > To prepare support for conversion of Microblaze TARGET_LONG to 64 bits. > This in turn will then allow support for multi-arch QEMU including both > Microblaze and 64-bit CPU targets (notably AArch64). I don't understand why multi-arch requires all

Re: [Qemu-devel] [PATCH v5 2/4] apic: convert ->busdev.qdev casts to C casts

2015-05-15 Thread Igor Mammedov
On Wed, 13 May 2015 15:11:15 +0800 Zhu Guihua wrote: > Use C casts to avoid accessing ICCDevice's qdev field > directly. > > Signed-off-by: Zhu Guihua > --- > hw/intc/apic.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/hw/intc/apic.c b/hw/intc/apic.c > inde

Re: [Qemu-devel] [PATCH v3 3/3] TPM2 ACPI table support

2015-05-15 Thread Stefan Berger
On 05/15/2015 10:44 AM, Igor Mammedov wrote: On Fri, 8 May 2015 11:52:46 -0400 Stefan Berger wrote: Add a TPM2 ACPI table if a TPM 2 is used in the backend. Also add an SSDT for the TPM 2. Rename tpm_find() to tpm_get_version() and have this function return the version of the TPM found, TPMV

Re: [Qemu-devel] [RFC] ARM/ARM64: KVM: Implement KVM_FLUSH_DCACHE_GPA ioctl

2015-05-15 Thread Paolo Bonzini
On 15/05/2015 17:12, Christoffer Dall wrote: >>> > > Can you find out what memory attributes the guest is using for the >>> > > memory---and if it's uncached, why? >> > >> > For USB, see "drivers/usb/core/hcd-pci.c", function usb_hcd_pci_probe(): >> > it uses ioremap_nocache(). >> > >> > On the

[Qemu-devel] [PATCH 1/1] Add qemu_get_counted_string to read a string prefixed by a count byte

2015-05-15 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" and use it in loadvm_state and ram_load. Where ever it's used, check the return and error if it failed. Minor: ram_load was using a 257 byte array for its string, the maximum length is 255 bytes + 0 terminator, so fix to 256 Signed-off-by: Dr. David Alan G

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-15 Thread Claudio Fontana
Hello Eric, On 15.05.2015 16:56, Eric Blake wrote: > On 05/15/2015 08:12 AM, Paolo Bonzini wrote: >> >> >> On 15/05/2015 15:57, Claudio Fontana wrote: >>> The header here mentions GPLv2+, but the module data for memmem in gnulib >>> mentions LGPLv2+. >>> >>> Very confusing. >>> >>> The COPYING fi

Re: [Qemu-devel] [PATCH v2 3/6] Support Physical Presence Interface Spec

2015-05-15 Thread Igor Mammedov
On Fri, 8 May 2015 12:15:17 -0400 Stefan Berger wrote: > For automated management of a TPM device, implement the TCG Physical Presence > Interface Specification that allows a root user on Linux (for example) to set > an opcode for a sequence of TPM operations that the BIOS is supposed to > exec

Re: [Qemu-devel] [RFC] ARM/ARM64: KVM: Implement KVM_FLUSH_DCACHE_GPA ioctl

2015-05-15 Thread Christoffer Dall
On Fri, May 15, 2015 at 01:43:57PM +0200, Laszlo Ersek wrote: > On 05/07/15 19:01, Paolo Bonzini wrote: > > > > > > On 07/05/2015 18:56, Jérémy Fanguède wrote: > >> USB devices fail with a timeout error, as if the communication between > >> the kernel and the devices fail at a certain point: > >>

Re: [Qemu-devel] [RFC/RFT PATCH v2 0/3] KVM: Introduce KVM_MEM_UNCACHED

2015-05-15 Thread Christoffer Dall
On Thu, May 14, 2015 at 03:36:37PM +0200, Andrew Jones wrote: > On Thu, May 14, 2015 at 02:11:59PM +0100, Peter Maydell wrote: > > On 14 May 2015 at 14:03, Andrew Jones wrote: > > > On Thu, May 14, 2015 at 11:37:46AM +0100, Peter Maydell wrote: > > >> On 14 May 2015 at 11:31, Andrew Jones wrote:

Re: [Qemu-devel] [RFC/RFT PATCH v2 3/3] arm/arm64: KVM: implement 'uncached' mem coherency

2015-05-15 Thread Christoffer Dall
On Thu, May 14, 2015 at 03:32:13PM +0200, Andrew Jones wrote: > On Thu, May 14, 2015 at 12:55:49PM +0200, Christoffer Dall wrote: > > On Wed, May 13, 2015 at 01:31:54PM +0200, Andrew Jones wrote: > > > When S1 and S2 memory attributes combine wrt to caching policy, > > > non-cacheable types take pr

[Qemu-devel] [PATCH v2] net: Change help text to list -netdev instead of -net by default

2015-05-15 Thread Thomas Huth
Looking at the output of "qemu-system-xxx -help", you easily get the impression that "-net" is the preferred way instead of "-netdev" to specify host network interface, since the "-net" option is omnipresent but the "-netdev" option is only listed as a one-liner at the end. This is ugly since "-net

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-15 Thread Eric Blake
On 05/15/2015 08:12 AM, Paolo Bonzini wrote: > > > On 15/05/2015 15:57, Claudio Fontana wrote: >> The header here mentions GPLv2+, but the module data for memmem in gnulib >> mentions LGPLv2+. >> >> Very confusing. >> >> The COPYING file in gnulib mentions: >> >> "The files in here are mostly co

Re: [Qemu-devel] [RFC/RFT PATCH v2 1/3] arm/arm64: pageattr: add set_memory_nc

2015-05-15 Thread Christoffer Dall
On Thu, May 14, 2015 at 03:46:44PM +0200, Andrew Jones wrote: > On Thu, May 14, 2015 at 01:05:09PM +0200, Christoffer Dall wrote: > > On Wed, May 13, 2015 at 01:31:52PM +0200, Andrew Jones wrote: > > > Provide a method to change normal, cacheable memory to non-cacheable. > > > KVM will make use of

Re: [Qemu-devel] [PATCH v3 3/3] TPM2 ACPI table support

2015-05-15 Thread Igor Mammedov
On Fri, 8 May 2015 11:52:46 -0400 Stefan Berger wrote: > Add a TPM2 ACPI table if a TPM 2 is used in the backend. > Also add an SSDT for the TPM 2. > > Rename tpm_find() to tpm_get_version() and have this function > return the version of the TPM found, TPMVersion_Unspec if > no TPM is found. Us

Re: [Qemu-devel] [PATCH v2 15/15] tap: Improve -netdev/netdev_add/-net/... tap error reporting

2015-05-15 Thread Eric Blake
On 05/15/2015 05:59 AM, Markus Armbruster wrote: > When -netdev tap fails, it first reports a specific error, then a > generic one, like this: > > $ qemu-system-x86_64 -netdev tap,id=foo > qemu-system-x86_64: -netdev tap,id=foo: could not configure /dev/net/tun: > Operation not permitted

Re: [Qemu-devel] [PATCH v2 12/15] tap-bsd: Convert tap_open() to Error

2015-05-15 Thread Eric Blake
[series has a typo in my email address, for anyone doing reply-all - but at least I spotted it on list] On 05/15/2015 05:59 AM, Markus Armbruster wrote: > Fixes inappropriate use of stderr in monitor command handler. > > While there, improve some of the messages a bit. > > Signed-off-by: Markus

Re: [Qemu-devel] Kernel Panic on Yum update

2015-05-15 Thread Gerhard Wiesinger
On 15.05.2015 10:10, Paolo Bonzini wrote: On 15/05/2015 09:37, Gerhard Wiesinger wrote: Yes, yum takes memory. But there is ~2.2 GB virt memory available. That should be enough. Therefore I think it is a kernel problem. As in previous crashes on the mailing list there is a lot of swap available

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-15 Thread Markus Armbruster
Jan Kiszka writes: > On 2015-05-15 15:21, Markus Armbruster wrote: >> Jan Kiszka writes: >> >>> On 2015-05-15 14:18, Markus Armbruster wrote: Peter Maydell writes: > On 15 May 2015 at 08:58, Markus Armbruster wrote: >> Since you're touching qemu-gdb.py anyway, could you stic

Re: [Qemu-devel] [PATCH v6 20/22] hw/acpi/aml-build: Add Unicode macro

2015-05-15 Thread Igor Mammedov
On Thu, 7 May 2015 17:29:22 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/acpi/aml-build.c | 18 ++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 19 insertions(+) > > diff --git a/hw

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-15 Thread Paolo Bonzini
On 15/05/2015 15:57, Claudio Fontana wrote: > The header here mentions GPLv2+, but the module data for memmem in gnulib > mentions LGPLv2+. > > Very confusing. > > The COPYING file in gnulib mentions: > > "The files in here are mostly copyright (C) Free Software Foundation, and > are under as

Re: [Qemu-devel] [PATCH v6 04/47] Add qemu_get_counted_string to read a string prefixed by a count byte

2015-05-15 Thread Dr. David Alan Gilbert
* Amit Shah (amit.s...@redhat.com) wrote: > On (Tue) 14 Apr 2015 [18:03:30], Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > and use it in loadvm_state and ram_load. > > This patch is doing several things at once: > > - reducing size of a buffer from 257 to 256 (i

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-15 Thread Leon Alrae
On 15/05/2015 14:43, Richard Henderson wrote: > On 05/15/2015 05:09 AM, Leon Alrae wrote: >> On 14/05/2015 20:12, Richard Henderson wrote: >>> /* We know both pages are present and writable. */ >>> if (eaddr == baddr + 15) { >>> /* Consecutive pages in RAM. */ >>> memcpy(baddr, re

Re: [Qemu-devel] [RFC v5 1/2] util: add memmem replacement function

2015-05-15 Thread Claudio Fontana
Hmm some licensing weirdness: On 15.05.2015 14:25, hw.clau...@gmail.com wrote: > From: Claudio Fontana > > if the memmem function is missing, provide the gnulib replacement. > > Signed-off-by: Claudio Fontana > --- > configure| 15 ++ > include/qemu/osdep.h | 4 + > util/Makefi

Re: [Qemu-devel] [PATCH v6 04/47] Add qemu_get_counted_string to read a string prefixed by a count byte

2015-05-15 Thread Amit Shah
On (Tue) 14 Apr 2015 [18:03:30], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > and use it in loadvm_state and ram_load. This patch is doing several things at once: - reducing size of a buffer from 257 to 256 (it's safe, but not mentioned in the commit log) - adding

Re: [Qemu-devel] [PATCH] macio: Convert to realize()

2015-05-15 Thread Markus Armbruster
Alexander Graf writes: > On 17.03.15 08:46, Markus Armbruster wrote: >> Alexander Graf writes: >> >>> On 09.03.15 19:30, Markus Armbruster wrote: Alexander Graf writes: > On 27.02.15 13:43, Markus Armbruster wrote: >> Convert device models "macio-oldworld" and "macio-newworld

Re: [Qemu-devel] [PATCH v6 19/22] hw/acpi/aml-build: Add aml_dword_io() term

2015-05-15 Thread Igor Mammedov
On Thu, 7 May 2015 17:29:21 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Reviewed-by: Alex Bennée Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 18 ++ > include/hw/acpi/aml-build.h | 5 ++

Re: [Qemu-devel] [PATCH v3 2/2] target-mips: Misaligned memory accesses for MSA

2015-05-15 Thread Richard Henderson
On 05/15/2015 05:09 AM, Leon Alrae wrote: > On 14/05/2015 20:12, Richard Henderson wrote: >> /* We know both pages are present and writable. */ >> if (eaddr == baddr + 15) { >> /* Consecutive pages in RAM. */ >> memcpy(baddr, register, 16); >> } else { >> /* Someone's doin

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-15 Thread Jan Kiszka
On 2015-05-15 15:21, Markus Armbruster wrote: > Jan Kiszka writes: > >> On 2015-05-15 14:18, Markus Armbruster wrote: >>> Peter Maydell writes: >>> On 15 May 2015 at 08:58, Markus Armbruster wrote: > Since you're touching qemu-gdb.py anyway, could you stick in a brief > comment exp

Re: [Qemu-devel] [RFC PATCH 21/34] arm: Rename all exceptions

2015-05-15 Thread Richard Henderson
On 05/15/2015 03:59 AM, Andreas Färber wrote: > I would prefer 1. independent of whether we rename them or not. We need > a better distinction of internal vs. external for targets. +1. r~

Re: [Qemu-devel] [PATCH v2 0/7] Unify and QOMify (target|monitor)_disas

2015-05-15 Thread Richard Henderson
On 05/14/2015 09:52 PM, Peter Crosthwaite wrote: > Ping! > > Richard has RB'd the core stuff but do we need CPU arch maintainer > acks on the latter patches? Yes, I'd prefer especially the arm patches get another look. > What queue should this go via? TCG? QOM via Andreas would be my first pref

Re: [Qemu-devel] [PATCH v6 18/22] hw/acpi/aml-build: Add aml_create_dword_field() term

2015-05-15 Thread Igor Mammedov
On Thu, 7 May 2015 17:29:20 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Reviewed-by: Alex Bennée Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 11 +++ > include/hw/acpi/aml-build.h | 1 + > 2 fi

Re: [Qemu-devel] [PATCH v6 17/22] hw/acpi/aml-build: Add aml_else() term

2015-05-15 Thread Igor Mammedov
On Thu, 7 May 2015 17:29:19 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Reviewed-by: Alex Bennée Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 7 +++ > include/hw/acpi/aml-build.h | 1 + > 2 files ch

Re: [Qemu-devel] [PATCH v6 16/22] hw/acpi/aml-build: Add aml_lnot() term

2015-05-15 Thread Igor Mammedov
On Thu, 7 May 2015 17:29:18 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > Reviewed-by: Alex Bennée Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 8 > include/hw/acpi/aml-build.h | 1 + > 2 files c

Re: [Qemu-devel] [PATCH v6 15/22] hw/acpi/aml-build: Add aml_or() term

2015-05-15 Thread Igor Mammedov
On Thu, 7 May 2015 17:29:17 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 10 ++ > include/hw/acpi/aml-build.h | 1 + > 2 files changed, 11 insertions(+)

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-15 Thread Markus Armbruster
Jan Kiszka writes: > On 2015-05-15 14:18, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 15 May 2015 at 08:58, Markus Armbruster wrote: Since you're touching qemu-gdb.py anyway, could you stick in a brief comment explaining how to put it to use? >>> >>> Good idea. It tur

Re: [Qemu-devel] [PATCH v6 14/22] hw/acpi/aml-build: Add ToUUID macro

2015-05-15 Thread Igor Mammedov
On Thu, 7 May 2015 17:29:16 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add ToUUID macro, this is useful for generating PCIe ACPI table. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao Reviewed-by: Igor Mammedov > --- > hw/acpi/aml-build.c | 46 >

Re: [Qemu-devel] [PATCH v6 13/22] hw/acpi/aml-build: Make aml_buffer() definition consistent with the spec

2015-05-15 Thread Igor Mammedov
On Thu, 7 May 2015 17:29:15 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > According to ACPI spec, DefBuffer can take two parameters: BufferSize > and ByteList. Make it consistent with the spec. If we want to request > uninitialized buffer, pass ByteList as NULL to aml_buffer() to > reserve

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-15 Thread Igor Mammedov
On Thu, 7 May 2015 17:29:07 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add aml_interrupt() for describing device interrupt in resource template. > These can be used to generating DSDT table for ACPI on ARM. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/acp

[Qemu-devel] [PATCH] xen/pass-through: fold host PCI command register writes

2015-05-15 Thread Jan Beulich
The code introduced to address XSA-126 allows simplification of other code in xen_pt_initfn(): All we need to do is update "cmd" suitably, as it'll be written back to the host register near the end of the function anyway. Signed-off-by: Jan Beulich --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@

[Qemu-devel] [PATCH] xen/pass-through: ROM BAR handling adjustments

2015-05-15 Thread Jan Beulich
Expecting the ROM BAR to be written with an all ones value when sizing the region is wrong - the low bit has another meaning (enable/disable) and bits 1..10 are reserved. The PCI spec also mandates writing all ones to just the address portion of the register. Use suitable constants also for initia

Re: [Qemu-devel] [PATCH 0/3] scripts/qemu-gdb: Add event tracing support

2015-05-15 Thread Jan Kiszka
On 2015-05-15 14:18, Markus Armbruster wrote: > Peter Maydell writes: > >> On 15 May 2015 at 08:58, Markus Armbruster wrote: >>> Since you're touching qemu-gdb.py anyway, could you stick in a brief >>> comment explaining how to put it to use? >> >> Good idea. It turns out the answer is just "sou

Re: [Qemu-devel] [PATCH v2] util: socket: Add missing localaddr and localport option for DGRAM socket

2015-05-15 Thread Markus Armbruster
Peter Krempa writes: > The 'socket_optslist' structure does not contain the 'localaddr' and > 'localport' options that are parsed in case you are creating a > 'connect' type UDP character device. > > I've noticed it happening after commit f43e47dbf6de24db20ec9b588bb6cc762 > made qemu abort() afte

[Qemu-devel] [RFC v5 2/2] monitor: add memory search commands s, sp

2015-05-15 Thread hw . claudio
From: Claudio Fontana usage is similar to the commands x, xp. Example with string: looking for "ELF" header in memory: (qemu) s/100cb 0x40001000 "ELF" searching memory area [40001000-400f5240] 40090001 (qemu) x/20b 0x4009 4009: '\x7f' 'E' 'L' 'F' '\x0

[Qemu-devel] [RFC v5 0/2] monitor: add memory search commands s, sp

2015-05-15 Thread hw . claudio
From: Claudio Fontana Hello, I went ahead and tried to build the general solution for replacing memmem on systems which don't provide one (notably Windows), detecting the presence of memmem in configure and setting CONFIG_MEMMEM, and providing an implementation (from gnulib) for the !CONFIG_MEMM

  1   2   3   >