[Qemu-devel] [PATCH qemu] qemu-options: Add documentation about PPC64's "-cpu compat" option

2015-04-01 Thread Alexey Kardashevskiy
Since 8dfa3a5e "target-ppc: Add "compat" CPU option" (which was a part of client-architecture-support patchset) there is a "compat" option of "-cpu". However it was not documented at all and this is what this patch is trying to do. Signed-off-by: Alexey Kardashevskiy --- qemu-options.hx | 11 +++

Re: [Qemu-devel] [PATCH] net: Fix link state inter-dependencies between NIC and backend

2015-04-01 Thread Michael S. Tsirkin
On Wed, Apr 01, 2015 at 07:55:38PM -0400, Vladislav Yasevich wrote: > Commit 02d38fcb2caa4454cf4ed728d5908c3cc9ba47be > net: Update netdev peer on link change > > introduced a link state dependency between the backend > netdev and the nic. If the admin turned off the link > on the backend, th

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/4] target-ppc: Add FWNMI support in qemu for powerKVM guests

2015-04-01 Thread David Gibson
On Thu, Apr 02, 2015 at 03:28:11PM +1100, Alexey Kardashevskiy wrote: > On 11/19/2014 04:48 PM, Aravinda Prasad wrote: > > > > > >On Tuesday 11 November 2014 08:54 AM, David Gibson wrote: > > > >[..] > > > >> > >>So, this may not still be possible depending on whether the KVM side > >>of this is al

[Qemu-devel] target-i386: clear bsp bit when designating bsp

2015-04-01 Thread Nadav Amit
Since the BSP bit is writable on real hardware, during reset all the CPUs which were not chosen to be the BSP should have their BSP bit cleared. This fix is required for KVM to work correctly when it changes the BSP bit. An additional fix is required for QEMU tcg to allow software to change the BS

Re: [Qemu-devel] Help for backport virtio to older kernel 2.6.18

2015-04-01 Thread Halsey Pian
Best Regards Halsey Pian > -Original Message- > From: Halsey Pian [mailto:halsey.p...@gmail.com] > Sent: 2015年3月31日 19:48 > To: 'Stefan Hajnoczi' > Cc: qemu-devel@nongnu.org; halsey.p...@gmail.com > Subject: RE: [Qemu-devel] Help for backport virtio to older kernel 2.6.18 > > > -O

Re: [Qemu-devel] [Qemu-ppc] [PATCH v3 0/4] target-ppc: Add FWNMI support in qemu for powerKVM guests

2015-04-01 Thread Alexey Kardashevskiy
On 11/19/2014 04:48 PM, Aravinda Prasad wrote: On Tuesday 11 November 2014 08:54 AM, David Gibson wrote: [..] So, this may not still be possible depending on whether the KVM side of this is already merged, but it occurs to me that there's a simpler way. Rather than mucking about with havin

Re: [Qemu-devel] [PATCH] vhost: logs sharing

2015-04-01 Thread Jason Wang
On Mon, Mar 30, 2015 at 5:06 PM, Michael S. Tsirkin wrote: On Fri, Mar 20, 2015 at 04:53:24PM +0800, Jason Wang wrote: Currently we allocate one vhost log per vhost device. This is sub optimal when: - Guest has several device with vhost as backend - Guest has multiqueue devices In

Re: [Qemu-devel] [PATCH 4/7] throttle: Add throttle group support

2015-04-01 Thread Fam Zheng
On Wed, 04/01 17:18, Alberto Garcia wrote: > On Wed, Apr 01, 2015 at 10:44:51PM +0800, Fam Zheng wrote: > > > > +# @group: #optional throttle group name (Since 2.3) > > > > We should probably elaborate (here, and at other places of @group > > appearances): @device is used as group name. This is u

Re: [Qemu-devel] [PATCH] Use $(MAKE) for recursive make

2015-04-01 Thread Fam Zheng
On Wed, 04/01 20:45, Stefan Weil wrote: > Am 01.04.2015 um 19:58 schrieb Ed Maste: > >On BSDs "make" is typically BSD make, while "gmake" is GNU make. > > > >Signed-off-by: Ed Maste > >--- > > Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > >diff --git a/Makefile b/Ma

[Qemu-devel] [PATCH] hw/arm/virt: Fix corruption due to double free

2015-04-01 Thread Shannon Zhao
From: Shannon Zhao As 4de9a88(hw/arm/virt: Fix memory leak reported by Coverity) and 6e05a12(arm: fix memory leak) both handle the memory leak reported by Coverity, this cause qemu corruption due to double free. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/arm/virt.c |1

Re: [Qemu-devel] [PATCH v6 0/14] migration: Add a new feature to do live migration

2015-04-01 Thread Li, Liang Z
Hi guys, Any more comments about this patch serials? Especially the last three patches about the qmp and hmp interfaces. Markus & Eric, could you help to take a look? Sorry for missing Markus in the CC lists. Liang > -Original Message- > From: Li, Liang Z > Sent:

Re: [Qemu-devel] [Qemu-block] [PATCH] mirror: hold aio_context before bdrv_drain

2015-04-01 Thread Bin Wu
On 2015/4/1 19:59, Stefan Hajnoczi wrote: > On Wed, Apr 01, 2015 at 04:49:39PM +0800, Bin Wu wrote: >> >> On 2015/4/1 16:19, Fam Zheng wrote: >>> On Wed, 04/01 12:42, Bin Wu wrote: From: Bin Wu >>> >>> What's the issue are you fixing? I think the coroutine already is running in >>> the AioCon

[Qemu-devel] [PATCH] net: Fix link state inter-dependencies between NIC and backend

2015-04-01 Thread Vladislav Yasevich
Commit 02d38fcb2caa4454cf4ed728d5908c3cc9ba47be net: Update netdev peer on link change introduced a link state dependency between the backend netdev and the nic. If the admin turned off the link on the backend, the nic link state was set to down because the link had no access to the network a

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Eduardo Habkost
On Wed, Apr 01, 2015 at 09:05:31PM +0200, Michael Mueller wrote: > On Wed, 1 Apr 2015 13:59:05 -0300 > Eduardo Habkost wrote: > > > > Not directly invalid as "-cpu none" will be the same as omitting the -cpu > > > option. > > > KVM will setup the vcpu properties withou any QEMU control to whatev

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-04-01 Thread Andrey Korolyov
*putting my tinfoil hat on* After thinking a little bit more, the observable behavior is a quite good match for a bios-level hypervisor (hardware trojan in a modern terminology), as it likely is sensitive to timing[1], does not appear more than once per VM during boot cycle and seemingly does not

Re: [Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set

2015-04-01 Thread Peter Maydell
On 1 April 2015 at 22:14, Paolo Bonzini wrote: > > > On 01/04/2015 23:06, John Snow wrote: >> >> if (qemu == NULL) { >> fprintf(stderr, "..."); >> g_assert_not_reached(); >> } >> >> Though that does read a little strangely. ("Here's a nice error message >> for something we are asserting will n

Re: [Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set

2015-04-01 Thread Paolo Bonzini
On 01/04/2015 23:06, John Snow wrote: > > if (qemu == NULL) { > fprintf(stderr, "..."); > g_assert_not_reached(); > } > > Though that does read a little strangely. ("Here's a nice error message > for something we are asserting will never happen.") Just "exit(1);" then. :) Good idea, this

Re: [Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set

2015-04-01 Thread John Snow
On 04/01/2015 02:00 PM, Ed Maste wrote: Signed-off-by: Ed Maste --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 12d65bd..54550a8 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -453,6 +453,7 @@ void qtest_qmp_discard

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 21:05:31 +0200 Michael Mueller wrote: > And cpu model "none" just means that QEMU does not manage the cpu model. > That's also > the reason why I initially returned an empty "[]" model and not "none". This > somewhat > convinces me to go back to this approach... And for quer

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 13:59:05 -0300 Eduardo Habkost wrote: > > Not directly invalid as "-cpu none" will be the same as omitting the -cpu > > option. > > KVM will setup the vcpu properties withou any QEMU control to whatever the > > hosting > > machine and the kvm kernel code offers. That will all

Re: [Qemu-devel] [PATCH] Use $(MAKE) for recursive make

2015-04-01 Thread Stefan Weil
Am 01.04.2015 um 19:58 schrieb Ed Maste: On BSDs "make" is typically BSD make, while "gmake" is GNU make. Signed-off-by: Ed Maste --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 88bce56..ee40397 100644 --- a/Makefile +++ b/Makefi

[Qemu-devel] [PATCH] qtest: Add assertion that required environment variable is set

2015-04-01 Thread Ed Maste
Signed-off-by: Ed Maste --- tests/libqtest.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/libqtest.c b/tests/libqtest.c index 12d65bd..54550a8 100644 --- a/tests/libqtest.c +++ b/tests/libqtest.c @@ -453,6 +453,7 @@ void qtest_qmp_discard_response(QTestState *s, const char *fmt, ...

Re: [Qemu-devel] [PATCH for-2.3] util/qemu-config" fix regression of qmp_query_command_line_options

2015-04-01 Thread Tony Krowiak
On 04/01/2015 10:13 AM, Marcel Apfelbaum wrote: I noticed the typo in subject :) maybe the maintainer that will take it can fix this if no further work is necessary, of course. On 04/01/2015 05:08 PM, Marcel Apfelbaum wrote: Commit 49d2e64 (machine: remove qemu_machine_opts global list) made ma

[Qemu-devel] [PATCH] Use $(MAKE) for recursive make

2015-04-01 Thread Ed Maste
On BSDs "make" is typically BSD make, while "gmake" is GNU make. Signed-off-by: Ed Maste --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 88bce56..ee40397 100644 --- a/Makefile +++ b/Makefile @@ -331,8 +331,8 @@ distclean: clean

Re: [Qemu-devel] [PATCH V2 for-2.3] util/qemu-config: fix regression of qmp_query_command_line_options

2015-04-01 Thread Eric Blake
On 04/01/2015 11:36 AM, Marcel Apfelbaum wrote: > On 04/01/2015 08:29 PM, Eric Blake wrote: >> On 04/01/2015 10:47 AM, Marcel Apfelbaum wrote: >>> Commit 49d2e64 (machine: remove qemu_machine_opts global list) >>> made machine options specific to machine sub-type, leaving >>> the qemu_machine_opts

Re: [Qemu-devel] [PULL 0/8] target-arm queue

2015-04-01 Thread Peter Maydell
to > staging (2015-04-01 11:31:31 +0100) > > are available in the git repository at: > > > git://git.linaro.org/people/pmaydell/qemu-arm.git > tags/pull-target-arm-20150401 > > for you to fetch changes up to 25b9fb107bc1f6735fdb3fce537792f5db95f78d: > > target-

Re: [Qemu-devel] [PATCH V2 for-2.3] util/qemu-config: fix regression of qmp_query_command_line_options

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 08:29 PM, Eric Blake wrote: On 04/01/2015 10:47 AM, Marcel Apfelbaum wrote: Commit 49d2e64 (machine: remove qemu_machine_opts global list) made machine options specific to machine sub-type, leaving the qemu_machine_opts desc array empty. Sadly this is the place qmp_query_command_li

Re: [Qemu-devel] [PATCH V2 for-2.3] util/qemu-config: fix regression of qmp_query_command_line_options

2015-04-01 Thread Eric Blake
On 04/01/2015 10:47 AM, Marcel Apfelbaum wrote: > Commit 49d2e64 (machine: remove qemu_machine_opts global list) > made machine options specific to machine sub-type, leaving > the qemu_machine_opts desc array empty. Sadly this is the place > qmp_query_command_line_options is looking for supported o

Re: [Qemu-devel] [PATCH V2 for-2.3] util/qemu-config: fix regression of qmp_query_command_line_options

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 07:47 PM, Marcel Apfelbaum wrote: Commit 49d2e64 (machine: remove qemu_machine_opts global list) made machine options specific to machine sub-type, leaving the qemu_machine_opts desc array empty. Sadly this is the place qmp_query_command_line_options is looking for supported options

Re: [Qemu-devel] Question about unbind MSI in xen_pt_msi.c

2015-04-01 Thread Julien Grall
Hi, On 01/04/2015 16:32, Stefano Stabellini wrote: On Wed, 1 Apr 2015, Julien Grall wrote: Hi, I'm looking to replace any call to xc_domain_bind_pt_irq and xc_domain_unbind_pt_irq by specific IRQ type helpers. I found one strange call which will always fail in xen_pt_msix_update_remap. The fu

Re: [Qemu-devel] [PULL v2 0/2] vnc: fix websocket security issues (cve-2015-1779).

2015-04-01 Thread Peter Maydell
he following changes since commit b8a86c4ac4d04c106ba38fbd707041cba334a155: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2015-04-01 11:31:31 +0100) > > are available in the git repository at: > > > git://git.kraxel.org/qemu ta

[Qemu-devel] [PULL 1/8] hw/arm/highbank: Fix resource leak and wrong image loading

2015-04-01 Thread Peter Maydell
From: Stefan Weil Coverity reports a resource leak for sysboot_filename which is allocated by qemu_find_file. In addition, that name is used to get the size of the image, but a different image name was used to load it. In addition, instead of passing the maximum allowed image size the actual im

[Qemu-devel] [PULL 0/8] target-arm queue

2015-04-01 Thread Peter Maydell
ository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20150401 for you to fetch changes up to 25b9fb107bc1f6735fdb3fce537792f5db95f78d: target-arm: kvm64 fix save/restore of SPSR regs (2015-04-01 17:5

[Qemu-devel] [PULL 4/8] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc)

2015-04-01 Thread Peter Maydell
The AArch64 SPSR_EL1 register is architecturally mandated to be mapped to the AArch32 SPSR_svc register. This means its state should live in QEMU's env->banked_spsr[1] field. Correct the various places in the code that incorrectly put it in banked_spsr[0]. Signed-off-by: Peter Maydell --- target

[Qemu-devel] [PULL 7/8] target-arm: kvm64 sync FP register state

2015-04-01 Thread Peter Maydell
From: Alex Bennée For migration to work we need to sync all of the register state. This is especially noticeable when GCC starts using FP registers as spill registers even with integer programs. Signed-off-by: Alex Bennée Signed-off-by: Peter Maydell --- target-arm/kvm64.c | 85 ++

[Qemu-devel] [PULL 3/8] hw/arm/virt: Fix memory leak reported by Coverity

2015-04-01 Thread Peter Maydell
From: Stefan Weil As the conditional statement had to be split anyway, we can also add a better error report message. Signed-off-by: Stefan Weil Message-id: 1426877982-3603-1-git-send-email...@weilnetz.de Signed-off-by: Peter Maydell --- hw/arm/virt.c | 9 - 1 file changed, 8 insertio

[Qemu-devel] [PULL 5/8] target-arm: kvm: save/restore mp state

2015-04-01 Thread Peter Maydell
From: Alex Bennée This adds the saving and restore of the current Multi-Processing state of the machine. While the KVM_GET/SET_MP_STATE API exposes a number of potential states for x86 we only use two for ARM. Either the process is running or not. We then save this state into the cpu_powered TCG

[Qemu-devel] [PULL 6/8] hw/intc: arm_gic_kvm.c restore config first

2015-04-01 Thread Peter Maydell
From: Alex Bennée As there is logic to deal with the difference between edge and level triggered interrupts in the kernel we must ensure it knows the configuration of the IRQs before we restore the pending state. Signed-off-by: Alex Bennée Acked-by: Christoffer Dall Signed-off-by: Peter Maydel

[Qemu-devel] [PULL 8/8] target-arm: kvm64 fix save/restore of SPSR regs

2015-04-01 Thread Peter Maydell
From: Alex Bennée The current code was negatively indexing the cpu state array and not synchronizing banked spsr register state with the current mode's spsr state, causing occasional failures with migration. Some munging is done to take care of the aarch64 mapping and also to ensure the most cur

[Qemu-devel] [PULL 2/8] hw/arm/vexpress: Fix memory leak reported by Coverity

2015-04-01 Thread Peter Maydell
From: Stefan Weil As the conditional statement had to be split anyway, we can also add a better error report message. Signed-off-by: Stefan Weil Message-id: 1426877963-3556-1-git-send-email...@weilnetz.de Signed-off-by: Peter Maydell --- hw/arm/vexpress.c | 11 +-- 1 file changed, 9 i

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Eduardo Habkost
(CCing libvir-list and Jiri Denemark for libvirt-related discussion about -cpu host/none, and live-migration safety expectations) On Wed, Apr 01, 2015 at 06:31:23PM +0200, Michael Mueller wrote: > On Wed, 1 Apr 2015 10:01:13 -0300 > Eduardo Habkost wrote: > > > On Tue, Mar 31, 2015 at 10:09:09PM

Re: [Qemu-devel] [PATCH] qga/commands-posix: Fix bug in guest-fstrim

2015-04-01 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 01/04/2015 14:33, Eric Blake wrote: > It's only a minor incompatibility, but a client that hard-codes > itself to parsing "returns":0 (that is, expecting a json-number) > will fail when talking to an older qemu that provided a json-object > inst

Re: [Qemu-devel] [PATCH for-2.3] util/qemu-config" fix regression of qmp_query_command_line_options

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 07:30 PM, Eric Blake wrote: On 04/01/2015 09:17 AM, Eric Blake wrote: On 04/01/2015 08:08 AM, Marcel Apfelbaum wrote: Commit 49d2e64 (machine: remove qemu_machine_opts global list) made machine machine options specific to machine sub-type, leaving At the risk of sounding like a

[Qemu-devel] [PATCH V2 for-2.3] util/qemu-config: fix regression of qmp_query_command_line_options

2015-04-01 Thread Marcel Apfelbaum
Commit 49d2e64 (machine: remove qemu_machine_opts global list) made machine options specific to machine sub-type, leaving the qemu_machine_opts desc array empty. Sadly this is the place qmp_query_command_line_options is looking for supported options. As a fix for for 2.3 the machine_qemu_opts (the

[Qemu-devel] [PATCH v2] qga: fitering out -fstack-protector-strong

2015-04-01 Thread Joseph Hindin
configure script may add -fstack-protector-strong option instead of -fstack-protector-all, depending on availability ( see commit 63678e17c ). Both options have to by filtered out for qga-vss.dll, otherwise MinGW cross-compilation fails at linking stage. Signed-off-by: Joseph Hindin --- qga/vss-

[Qemu-devel] [PATCH v2] fitering out -fstack-protector-strong

2015-04-01 Thread Joseph Hindin
The cross-compilation of VSS DLL from QEMU GA for Windows with MinGW fails because of disreparancy between compiler's and linker's stack protection options. The current qga/vss-win32/Makefile.objs filters out option '-fstack-protector-all' from compiler's option, but commit 63678e17c introduced cha

Re: [Qemu-devel] [PATCH v6 5/5] target-arm: kvm64 fix save/restore of SPSR regs

2015-04-01 Thread Peter Maydell
On 1 April 2015 at 16:39, Alex Bennée wrote: > +el = arm_current_el(env); > +if (el > 0 && !is_a64(env)) { > + i = bank_number(env->uncached_cpsr & CPSR_M); > +env->spsr = env->banked_spsr[i]; > +} Bad indent, spotted by checkpatch. I'll fix as I apply. -- PMM

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 10:01:13 -0300 Eduardo Habkost wrote: > On Tue, Mar 31, 2015 at 10:09:09PM +0200, Michael Mueller wrote: > > On Tue, 31 Mar 2015 15:35:26 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > > > > This patch implements

Re: [Qemu-devel] [PATCH v6 2/5] target-arm: kvm: save/restore mp state

2015-04-01 Thread Peter Maydell
On 1 April 2015 at 16:39, Alex Bennée wrote: > --- a/target-arm/kvm.c > +++ b/target-arm/kvm.c > @@ -28,6 +28,8 @@ const KVMCapabilityInfo kvm_arch_required_capabilities[] = { > KVM_CAP_LAST_INFO > }; > > +static bool cap_has_mp_state = false; This explicit init to false is unnecessary, and

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 07:20 PM, Eric Blake wrote: On 04/01/2015 10:11 AM, Marcel Apfelbaum wrote: On 04/01/2015 06:53 PM, Markus Armbruster wrote: Marcel Apfelbaum writes: [...] I noticed something weird. I cannot actually create an instance of machine or get a reference to current_machine in order

Re: [Qemu-devel] [PATCH for-2.3] util/qemu-config" fix regression of qmp_query_command_line_options

2015-04-01 Thread Eric Blake
On 04/01/2015 09:17 AM, Eric Blake wrote: > On 04/01/2015 08:08 AM, Marcel Apfelbaum wrote: >> Commit 49d2e64 (machine: remove qemu_machine_opts global list) made >> machine machine options specific to machine sub-type, leaving > > At the risk of sounding like a machine: s/machine machine/machine/

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-04-01 Thread Andrey Korolyov
On Wed, Apr 1, 2015 at 6:37 PM, Andrey Korolyov wrote: > On Wed, Apr 1, 2015 at 4:19 PM, Paolo Bonzini wrote: >> >> >> On 01/04/2015 14:26, Andrey Korolyov wrote: >>> Yes, I disabled host watchdog during runtime. Indeed guest-induced NMI >>> would look different and they had no reasons to be fire

Re: [Qemu-devel] qemu-img behavior for locating backing files

2015-04-01 Thread Eric Blake
On 04/01/2015 10:16 AM, John Snow wrote: > Kevin, what's the correct behavior for qemu-img and relative paths when > creating a new qcow2 file? > > Example: > > (in e.g. /home/qemu/build/ or anywhere not /home: ) > qemu-img create -f qcow2 base.qcow2 32G creates /home/qemu/build/base.qcow2 > qe

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-01 Thread Liviu Ionescu
> On 01 Apr 2015, at 18:45, Christopher Covington wrote: > > I think the commit message and help text should include some information on > how this is different from -append and what the result is of specifying both > -append foo=a and -semihosting-config arg=foo=b. if I remember right (did not

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Eric Blake
On 04/01/2015 10:11 AM, Marcel Apfelbaum wrote: > On 04/01/2015 06:53 PM, Markus Armbruster wrote: >> Marcel Apfelbaum writes: > [...] >>> I noticed something weird. I cannot actually create an instance of >>> machine >>> or get a reference to current_machine in order to query its properties! >>>

Re: [Qemu-devel] [PULL 0/5] hw: Contain drive, serial, parallel, net misuse

2015-04-01 Thread Peter Maydell
On 1 April 2015 at 16:03, Markus Armbruster wrote: > The following changes since commit b8a86c4ac4d04c106ba38fbd707041cba334a155: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2015-04-01 11:31:31 +0100) > > are available in the git repository at: > > > g

[Qemu-devel] qemu-img behavior for locating backing files

2015-04-01 Thread John Snow
Kevin, what's the correct behavior for qemu-img and relative paths when creating a new qcow2 file? Example: (in e.g. /home/qemu/build/ or anywhere not /home: ) qemu-img create -f qcow2 base.qcow2 32G qemu-img create -f qcow2 -F qcow2 -b base.qcow2 /home/overlay.qcow2 In 1.7.0., this produces a

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-01 Thread Matthew Fortune
Liviu Ionescu writes: > > On 01 Apr 2015, at 16:18, Leon Alrae wrote: > > > > ... This simple patch adds "arg" sub-argument which in my opinion is > > flexible enough to satisfy semi-hosting interfaces which allocate > > buffers at runtime (so it is possible to pass any number of strings of > > a

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 06:53 PM, Markus Armbruster wrote: Marcel Apfelbaum writes: [...] I noticed something weird. I cannot actually create an instance of machine or get a reference to current_machine in order to query its properties! It seems that util/qemu-config is used by qemu-img which obviously

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-01 Thread Christopher Covington
Hi Leon, On 04/01/2015 09:18 AM, Leon Alrae wrote: > Signed-off-by: Leon Alrae > --- > Hi, > > Continuing the discussion related to extending QEMU's command line with new > argument allowing to pass semi-hosting input arguments to the guest program: > https://lists.gnu.org/archive/html/qemu-deve

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 04/01/2015 11:28 AM, Markus Armbruster wrote: >> Marcel Apfelbaum writes: >> >>> On 03/31/2015 05:21 PM, Tony Krowiak wrote: Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 removed the QemuOptDesc elements from the *desc* field of the *qemu_machine_o

Re: [Qemu-devel] [PATCH v5 5/7] vfio-pci: pass the aer error to guest

2015-04-01 Thread Alex Williamson
On Wed, 2015-04-01 at 12:12 +0800, Chen Fan wrote: > On 03/25/2015 10:41 AM, Alex Williamson wrote: > > On Wed, 2015-03-25 at 09:53 +0800, Chen Fan wrote: > >> On 03/16/2015 10:09 PM, Alex Williamson wrote: > >>> On Mon, 2015-03-16 at 15:35 +0800, Chen Fan wrote: > On 03/16/2015 11:52 AM, Alex

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json

2015-04-01 Thread Eric Blake
On 04/01/2015 06:17 AM, Eric Blake wrote: >> I guess JSON / Python was chosen as QAPI schema language to save us the >> bother of defining a syntax and building the tools to work with it, like >> an Emacs mode. JSON's not exactly my favourite choice, but at least >> it's not XML. >> >> What we ha

[Qemu-devel] [PATCH v2 1/2] qga: add additional win32 cflags and libraries

2015-04-01 Thread Kirk Allan
Use –extra-cflags to set cflags to such as _WIN32_WINVER and WINVER to add additional functionality offered in Windows Visat/2008 and newer. Add the -DARCH_$ARCH cflag. Add the iphlpapi library to use APIs such as GetAdaptersInfo and GetAdaptersAddresses. Signed-off-by: Kirk Allan --- configur

[Qemu-devel] [PATCH v2 0/2] qga: implement qmp_guest_network_get_interfaces for win32

2015-04-01 Thread Kirk Allan
This patch set is to implement qmp_guest_network_get_interfaces for win32. This version splits the previous single patch into two patches: configuration and implementation. The configuration patch utilizes the –extra-cflags rather than introduce a new option for setting _WIN32_WINNT and WINVER.

[Qemu-devel] [PATCH v2 2/2] qga: win32 implementation of qmp_guest_network_get_interfaces

2015-04-01 Thread Kirk Allan
By default, IP addresses and prefixes will be derived from information obtained by various calls and structures. IPv4 prefixes can be found by matching the address to those returned by GetApaptersInfo. IPv6 prefixes can not be matched this way due to the unpredictable order of entries. In Window

[Qemu-devel] [PATCH v6 4/5] target-arm: kvm64 sync FP register state

2015-04-01 Thread Alex Bennée
For migration to work we need to sync all of the register state. This is especially noticeable when GCC starts using FP registers as spill registers even with integer programs. Signed-off-by: Alex Bennée --- v4: - fixed merge conflicts - rm superfluous reg.id++ v5: - use interim float128

[Qemu-devel] [PATCH v6 1/5] target-arm: Store SPSR_EL1 state in banked_spsr[1] (SPSR_svc)

2015-04-01 Thread Alex Bennée
From: Peter Maydell The AArch64 SPSR_EL1 register is architecturally mandated to be mapped to the AArch32 SPSR_svc register. This means its state should live in QEMU's env->banked_spsr[1] field. Correct the various places in the code that incorrectly put it in banked_spsr[0]. Signed-off-by: Pete

[Qemu-devel] [PATCH v6 3/5] hw/intc: arm_gic_kvm.c restore config first

2015-04-01 Thread Alex Bennée
As there is logic to deal with the difference between edge and level triggered interrupts in the kernel we must ensure it knows the configuration of the IRQs before we restore the pending state. Signed-off-by: Alex Bennée Acked-by: Christoffer Dall --- v6 - tweak wording for configuration reg

[Qemu-devel] [PATCH v6 2/5] target-arm: kvm: save/restore mp state

2015-04-01 Thread Alex Bennée
This adds the saving and restore of the current Multi-Processing state of the machine. While the KVM_GET/SET_MP_STATE API exposes a number of potential states for x86 we only use two for ARM. Either the process is running or not. We then save this state into the cpu_powered TCG state to avoid chang

[Qemu-devel] [PATCH v6 0/5] QEMU ARM64 Migration Fixes

2015-04-01 Thread Alex Bennée
Hi, Here is v6 of the migration fixes patch which addresses a bunch of Peter's comments as well as a few of the v4 comments I missed out last time. v6: - Dropped env->spsr doc patch - save/restore mp_state - cache result of KVM_CAP_MP_STATE ioctl - reword commentary - invert errno

[Qemu-devel] [PATCH v6 5/5] target-arm: kvm64 fix save/restore of SPSR regs

2015-04-01 Thread Alex Bennée
The current code was negatively indexing the cpu state array and not synchronizing banked spsr register state with the current mode's spsr state, causing occasional failures with migration. Some munging is done to take care of the aarch64 mapping and also to ensure the most current value of the sp

Re: [Qemu-devel] E5-2620v2 - emulation stop error

2015-04-01 Thread Andrey Korolyov
On Wed, Apr 1, 2015 at 4:19 PM, Paolo Bonzini wrote: > > > On 01/04/2015 14:26, Andrey Korolyov wrote: >> Yes, I disabled host watchdog during runtime. Indeed guest-induced NMI >> would look different and they had no reasons to be fired at this stage >> inside guest. I`d suspect a hypervisor hardw

Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations

2015-04-01 Thread Eric Blake
On 04/01/2015 09:29 AM, Markus Armbruster wrote: > Eric Blake writes: > > [...] >> === Union types === >> >> + >> +A flat union definition specifies a complex type as its base, and >> +avoids nesting on the wire. In this case, the fields of the complex >> +type are included as top-level fields

Re: [Qemu-devel] Question about unbind MSI in xen_pt_msi.c

2015-04-01 Thread Stefano Stabellini
On Wed, 1 Apr 2015, Julien Grall wrote: > Hi, > > I'm looking to replace any call to xc_domain_bind_pt_irq and > xc_domain_unbind_pt_irq by specific IRQ type helpers. > > I found one strange call which will always fail in xen_pt_msix_update_remap. > The function xc_domain_unbind_pt_irq is called

Re: [Qemu-devel] [PATCH 0/1] Get the list of arguments from a QMP command

2015-04-01 Thread Markus Armbruster
I'm up to the ears in a query-schema prototype. I'll reply to this as soon as I can.

Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations

2015-04-01 Thread Markus Armbruster
Eric Blake writes: [...] > === Union types === > > -Union types are used to let the user choose between several different data > -types. A union type is defined using a dictionary as explained in the > -following paragraphs. > +Usage: { 'union': 'str', 'data': 'dict' } > +or:{ 'union': 'str

Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument

2015-04-01 Thread Liviu Ionescu
> On 01 Apr 2015, at 16:18, Leon Alrae wrote: > > ... This simple patch adds "arg" sub-argument which in my opinion is flexible > enough to satisfy semi-hosting interfaces which allocate buffers at runtime > (so it is possible to pass any number of strings of any length) as well as the > ones wh

[Qemu-devel] [PULL v2 1/2] CVE-2015-1779: incrementally decode websocket frames

2015-04-01 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The logic for decoding websocket frames wants to fully decode the frame header and payload, before allowing the VNC server to see any of the payload data. There is no size limit on websocket payloads, so this allows a malicious network client to consume 2^64 bytes in me

Re: [Qemu-devel] [PATCH 4/7] throttle: Add throttle group support

2015-04-01 Thread Alberto Garcia
On Wed, Apr 01, 2015 at 10:44:51PM +0800, Fam Zheng wrote: > > +# @group: #optional throttle group name (Since 2.3) > > We should probably elaborate (here, and at other places of @group > appearances): @device is used as group name. This is useful since > other devices could use this device name

Re: [Qemu-devel] [PATCH for-2.3] util/qemu-config" fix regression of qmp_query_command_line_options

2015-04-01 Thread Eric Blake
On 04/01/2015 08:08 AM, Marcel Apfelbaum wrote: > Commit 49d2e64 (machine: remove qemu_machine_opts global list) made > machine machine options specific to machine sub-type, leaving At the risk of sounding like a machine: s/machine machine/machine/ > the qemu_machine_opts desc array empty. Sadly

[Qemu-devel] [PULL v2 2/2] CVE-2015-1779: limit size of HTTP headers from websockets clients

2015-04-01 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The VNC server websockets decoder will read and buffer data from websockets clients until it sees the end of the HTTP headers, as indicated by \r\n\r\n. In theory this allows a malicious to trick QEMU into consuming an arbitrary amount of RAM. In practice, because QEMU

[Qemu-devel] [PULL v2 0/2] vnc: fix websocket security issues (cve-2015-1779).

2015-04-01 Thread Gerd Hoffmann
nzini/tags/for-upstream' into staging (2015-04-01 11:31:31 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-cve-2015-1779-20150401-2 for you to fetch changes up to 2cdb5e142fb93e875fa53c52864ef5eb8d5d8b41: CVE-2015-1779: limit size of HTTP he

Re: [Qemu-devel] [PATCH v5 12/45] Return path: Source handling of return path

2015-04-01 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Mar 20, 2015 at 06:17:31PM +, Dr. David Alan Gilbert wrote: > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > On Wed, Feb 25, 2015 at 04:51:35PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David A

[Qemu-devel] [PULL 2/5] hw: Mark devices picking up char backends actively FIXME

2015-04-01 Thread Markus Armbruster
Character devices defined with -serial and -parallel are for board initialization to wire up. Board code examines serial_hds[] and parallel_hds[] to find them, and creates devices with their qdev chardev properties set accordingly. Except a few devices go on a fishing expedition for a suitable ba

[Qemu-devel] [PULL 4/5] sdhci: Make device "sdhci-pci" unavailable with -device

2015-04-01 Thread Markus Armbruster
Device models aren't supposed to go on fishing expeditions for backends. They should expose suitable properties for the user to set. For onboard devices, board code sets them. "sdhci-pci" picks up its block backend in its realize() method with drive_get_next() instead. Already marked FIXME. See

[Qemu-devel] [PULL 0/5] hw: Contain drive, serial, parallel, net misuse

2015-04-01 Thread Markus Armbruster
Drives defined with if!=none, character devices defined with -serial and -parallel, network devices defined with -net nic are all for board initialization to wire up. Board code calls drive_get() or similar to find them, and creates devices with their qdev properties set accordingly. Except a few

[Qemu-devel] [PULL 5/5] sysbus: Make devices picking up backends unavailable with -device

2015-04-01 Thread Markus Armbruster
Device models aren't supposed to go on fishing expeditions for backends. They should expose suitable properties for the user to set. For onboard devices, board code sets them. A number of sysbus devices pick up block backends in their init() / instance_init() methods with drive_get_next() instead

[Qemu-devel] [PULL 1/5] hw: Mark devices picking up block backends actively FIXME

2015-04-01 Thread Markus Armbruster
Drives defined with if!=none are for board initialization to wire up. Board code calls drive_get() or similar to find them, and creates devices with their qdev drive properties set accordingly. Except a few devices go on a fishing expedition for a suitable backend instead of exposing a drive prope

[Qemu-devel] [PULL 3/5] hw: Mark device misusing nd_table[] FIXME

2015-04-01 Thread Markus Armbruster
NICs defined with -net nic are for board initialization to wire up. Board code examines nd_table[] to find them, and creates devices with their qdev NIC properties set accordingly. Except "allwinner-a10" goes on a fishing expedition for NIC configuration instead of exposing the usual NIC propertie

Re: [Qemu-devel] [PATCH 0/1] Get the list of arguments from a QMP command

2015-04-01 Thread Alberto Garcia
On Sat, Mar 14, 2015 at 05:12:33PM +0100, Markus Armbruster wrote: [QMP introspection] > Detail. I want us to figure out what information we want to provide > first, how to encode it second, and how to fit it into the existing > introspection interfaces third. Ok, I managed to find some time t

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json

2015-04-01 Thread Markus Armbruster
Eric Blake writes: > On 04/01/2015 03:33 AM, Markus Armbruster wrote: > Longhand: # mandatory 'name': { 'type': 'str' } # optional, with a default 'flag': { 'type': 'bool', 'default': true } # optional, no default 'string': { 'type':

Re: [Qemu-devel] [PATCH v5 17/28] qapi: Allow true, false and null in schema json

2015-04-01 Thread Markus Armbruster
Kevin Wolf writes: > Am 01.04.2015 um 13:03 hat Markus Armbruster geschrieben: >> Kevin Wolf writes: >> >> > Am 01.04.2015 um 11:33 hat Markus Armbruster geschrieben: >> >> Kevin Wolf writes: >> >> >> >> > Am 31.03.2015 um 22:09 hat Markus Armbruster geschrieben: >> >> >> Kevin Wolf writes:

Re: [Qemu-devel] [qemu devel] disable shared memory is not available with this QEMU binary

2015-04-01 Thread Marcel Apfelbaum
On 04/01/2015 11:28 AM, Markus Armbruster wrote: Marcel Apfelbaum writes: On 03/31/2015 05:21 PM, Tony Krowiak wrote: Commit 49d2e648e8087d154d8bf8b91f27c8e05e79d5a6 removed the QemuOptDesc elements from the *desc* field of the *qemu_machine_opts *array defined in vl.c. Since applying that

Re: [Qemu-devel] [PATCH 4/7] throttle: Add throttle group support

2015-04-01 Thread Fam Zheng
On Mon, 03/30 19:19, Alberto Garcia wrote: > diff --git a/qapi/block-core.json b/qapi/block-core.json > index 7873084..d8211b7 100644 > --- a/qapi/block-core.json > +++ b/qapi/block-core.json > @@ -990,6 +990,8 @@ > # > # @iops_size: #optional an I/O size in bytes (Since 1.7) > # > +# @group: #o

Re: [Qemu-devel] [PULL for-2.3 0/2] vnc: fix websocket security issues (cve-2015-1779).

2015-04-01 Thread Peter Maydell
b58d7: > > Update version for v2.3.0-rc1 release (2015-03-24 16:34:16 +) > > are available in the git repository at: > > git://git.kraxel.org/qemu tags/pull-cve-2015-1779-20150401-1 > > for you to fetch changes up to 9cf222fd4fd3f4d1f959685c061279d0673726cd: &

Re: [Qemu-devel] [PATCH for-2.3] util/qemu-config" fix regression of qmp_query_command_line_options

2015-04-01 Thread Marcel Apfelbaum
I noticed the typo in subject :) maybe the maintainer that will take it can fix this if no further work is necessary, of course. On 04/01/2015 05:08 PM, Marcel Apfelbaum wrote: Commit 49d2e64 (machine: remove qemu_machine_opts global list) made machine machine options specific to machine sub-typ

[Qemu-devel] [PULL 2/2] CVE-2015-1779: limit size of HTTP headers from websockets clients

2015-04-01 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The VNC server websockets decoder will read and buffer data from websockets clients until it sees the end of the HTTP headers, as indicated by \r\n\r\n. In theory this allows a malicious to trick QEMU into consuming an arbitrary amount of RAM. In practice, because QEMU

[Qemu-devel] [PULL for-2.3 0/2] vnc: fix websocket security issues (cve-2015-1779).

2015-04-01 Thread Gerd Hoffmann
in the git repository at: git://git.kraxel.org/qemu tags/pull-cve-2015-1779-20150401-1 for you to fetch changes up to 9cf222fd4fd3f4d1f959685c061279d0673726cd: CVE-2015-1779: limit size of HTTP headers from websockets clients (2015-04-01 15:48:52 +0200

[Qemu-devel] [PULL 1/2] CVE-2015-1779: incrementally decode websocket frames

2015-04-01 Thread Gerd Hoffmann
From: "Daniel P. Berrange" The logic for decoding websocket frames wants to fully decode the frame header and payload, before allowing the VNC server to see any of the payload data. There is no size limit on websocket payloads, so this allows a malicious network client to consume 2^64 bytes in me

  1   2   3   >