Re: [Qemu-devel] [RESEND PATCH v4 1/6] acpi, mem-hotplug: Add acpi_memory_slot_status() to get MemStatus

2015-03-18 Thread Michael S. Tsirkin
On Thu, Mar 19, 2015 at 09:52:59AM +0800, Zhu Guihua wrote: > > On 03/16/2015 09:58 PM, Michael S. Tsirkin wrote: > >On Mon, Mar 16, 2015 at 04:58:13PM +0800, Zhu Guihua wrote: > >>From: Tang Chen > >> > >>Add a new API named acpi_memory_slot_status() to obtain a single memory > >>slot status. Do

Re: [Qemu-devel] [PATCH V4 08/19] virtio-net: fix the upper bound when trying to delete queues

2015-03-18 Thread Jason Wang
On Wed, Mar 18, 2015 at 9:06 PM, Michael S. Tsirkin wrote: On Wed, Mar 18, 2015 at 05:34:58PM +0800, Jason Wang wrote: Virtqueue were indexed from zero, so don't delete virtqueue whose index is n->max_queues * 2 + 1. Cc: Michael S. Tsirkin Signed-off-by: Jason Wang Bugfix? needed

Re: [Qemu-devel] [PATCH V4 00/19] Support more virtio queues

2015-03-18 Thread Jason Wang
On Wed, Mar 18, 2015 at 8:58 PM, Michael S. Tsirkin wrote: On Wed, Mar 18, 2015 at 05:34:50PM +0800, Jason Wang wrote: We current limit the max virtio queues to 64. This is not sufficient to support multiqueue devices (e.g recent Linux support up to 256 tap queues). So this series tries t

Re: [Qemu-devel] [PATCH V4 18/19] pci: remove hard-coded bar size in msix_init_exclusive_bar()

2015-03-18 Thread Jason Wang
On Wed, Mar 18, 2015 at 8:52 PM, Michael S. Tsirkin wrote: On Wed, Mar 18, 2015 at 05:35:08PM +0800, Jason Wang wrote: This patch let msix_init_exclusive_bar() can accept bar_size parameter other than a hard-coded limit 4096. Then caller can specify a bar_size depends on msix entries an

Re: [Qemu-devel] [PATCH V4 19/19] virtio-pci: introduce auto_msix_bar_size property

2015-03-18 Thread Jason Wang
On Wed, Mar 18, 2015 at 8:57 PM, Michael S. Tsirkin wrote: On Wed, Mar 18, 2015 at 05:35:09PM +0800, Jason Wang wrote: Currently we don't support more than 128 MSI-X vectors for a pci devices, trying to use vector=129 for a virtio-net-pci device may get: qemu-system-x86_64: -device vir

Re: [Qemu-devel] [PATCH V4 07/19] virtio-net: validate backend queue numbers against bus limitation

2015-03-18 Thread Jason Wang
On Wed, Mar 18, 2015 at 9:05 PM, Michael S. Tsirkin wrote: On Wed, Mar 18, 2015 at 05:34:57PM +0800, Jason Wang wrote: We don't validate the backend queue numbers against bus limitation, this will easily crash qemu if it exceeds the limitation. Fixing this by doing the validation and fa

Re: [Qemu-devel] [PATCH V4 19/19] virtio-pci: introduce auto_msix_bar_size property

2015-03-18 Thread Jason Wang
On Wed, Mar 18, 2015 at 8:57 PM, Michael S. Tsirkin wrote: On Wed, Mar 18, 2015 at 05:35:09PM +0800, Jason Wang wrote: Currently we don't support more than 128 MSI-X vectors for a pci devices, trying to use vector=129 for a virtio-net-pci device may get: qemu-system-x86_64: -device vir

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-18 Thread David Gibson
On Wed, Mar 18, 2015 at 12:04:04PM +0530, Bharata B Rao wrote: > On Wed, Mar 18, 2015 at 11:49:59AM +1100, David Gibson wrote: > > On Fri, Mar 13, 2015 at 05:26:36PM +0530, Bharata B Rao wrote: > > > From: Bharata B Rao > > > > > > Currently CPUState.cpu_index is monotonically increasing and a ne

Re: [Qemu-devel] [PATCH v5 23/45] migrate_start_postcopy: Command to trigger transition to postcopy

2015-03-18 Thread David Gibson
On Wed, Mar 18, 2015 at 05:59:51PM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Fri, Mar 13, 2015 at 11:19:06AM +, Dr. David Alan Gilbert wrote: > > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > > On Wed, Feb 25, 2015 at 04:51:4

[Qemu-devel] [PATCH] spapr_pci: Fix unsafe signed/unsigned comparisons

2015-03-18 Thread David Gibson
spapr_pci.c contains a number of expressions of the form (uval == -1) or (uval != -1), where 'uval' is an unsigned value. This mostly works in practice, because as long as the width of uval is greater or equal than that of (int), the -1 will be promoted to the unsigned type, which is the expected

Re: [Qemu-devel] [v5 12/12] migration: Add commands to set and query parameter

2015-03-18 Thread Li, Liang Z
> > +# > > +# Migration parameter information > > +# > > +# @compress-level: compression level > > +# > > +# @compress-threads: compression thread count # # > > +@decompress-threads: decompression thread count # # Since: 2.3 ## { > > +'union': 'MigrationParameterStatus', > > + 'base': 'MigrationPa

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-18 Thread Chen, Tiejun
This duplicates the code from above. I think this would be best done as: static int libxl__detect_gfx_passthru_kind(libxl__gc *gc, guest_config) { if (b_info->u.hvm.gfx_passthru_kind != LIBXL_GFX_PASSTHRU_KIND_DEFAULT) return 0; if (libxl__is_igd_vga_passthru(gc, guest_config)

Re: [Qemu-devel] [PATCH 1/6 v6] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-18 Thread Chen Gang
On 3/19/15 04:06, Richard Henderson wrote: > On 03/18/2015 09:34 AM, Chen Gang wrote: >> +static void gen_fnop(void) >> +{ >> +qemu_log_mask(CPU_LOG_TB_IN_ASM, "(f)nop\n"); >> +} >> + >> +static void gen_cmpltui(struct DisasContext *dc, >> +uint8_t rdst, uint8_t rsrc, in

[Qemu-devel] 2.3-rc0 ahci-test failure on ppc64

2015-03-18 Thread John Snow
Andreas brought this failure to my attention; it looks like PIO read/writes for nsectors > 1 for IDE or AHCI will fail on ppc64. The failure is in the IDE core layer. In a nutshell, we've never *actually* supported PIO r/w for nsectors > 1, I just started testing it as a spec compliance item (

Re: [Qemu-devel] [RESEND PATCH v4 1/6] acpi, mem-hotplug: Add acpi_memory_slot_status() to get MemStatus

2015-03-18 Thread Zhu Guihua
On 03/16/2015 09:58 PM, Michael S. Tsirkin wrote: On Mon, Mar 16, 2015 at 04:58:13PM +0800, Zhu Guihua wrote: From: Tang Chen Add a new API named acpi_memory_slot_status() to obtain a single memory slot status. Doing this is because this procedure will be used by other functions in the next c

Re: [Qemu-devel] [PATCH v5 4/7] pcie_aer: expose pcie_aer_msg() interface

2015-03-18 Thread Chen Fan
On 03/18/2015 09:29 PM, Michael S. Tsirkin wrote: On Thu, Mar 12, 2015 at 06:23:56PM +0800, Chen Fan wrote: For vfio device, we need to propagate the aer error to Guest OS. we use the pcie_aer_msg() to send aer error to guest. Signed-off-by: Chen Fan Interesting. pcie_aer_inject_error was in

Re: [Qemu-devel] [PATCH v4 4/5] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms backen.

2015-03-18 Thread Xu, Quan
> -Original Message- > From: Stefan Berger [mailto:stef...@linux.vnet.ibm.com] > Sent: Thursday, March 19, 2015 3:17 AM > To: Xu, Quan; stefano.stabell...@eu.citrix.com; qemu-devel@nongnu.org; > arm...@redhat.com; lcapitul...@redhat.com; aligu...@amazon.com; > pbonz...@redhat.com; ebl...@

Re: [Qemu-devel] [v7][PATCH 03/10] piix: create host bridge to passthrough

2015-03-18 Thread Chen, Tiejun
On 2015/3/18 18:21, Gerd Hoffmann wrote: On Mi, 2015-03-18 at 17:06 +0800, Tiejun Chen wrote: Implement a pci host bridge specific to passthrough. Actually this just inherits the standard one. And we also just expose a minimal real host bridge pci configuration subset. +/* Here we just expose

[Qemu-devel] [PATCH v2 1/5] fw_cfg: add documentation file (docs/specs/fw_cfg.txt)

2015-03-18 Thread Gabriel L. Somlo
This document covers guest-side hardware interface, as well as the host-side programming API of QEMU's firmware configuration (fw_cfg) device. Signed-off-by: Jordan Justen Signed-off-by: Gabriel Somlo --- I tried to incorporate most of Laszlo's feedback; I decided to take an example from the ar

[Qemu-devel] [PATCH v2 0/5] fw-cfg: documentation, cleanup, and cmdline blobs

2015-03-18 Thread Gabriel L. Somlo
Document and clean up fw_cfg; additionally, allow user-provided blobs to be inserted into fw_cfg via the qemu command line. Changes since v1: - reworked documentation (1/5) as per Laszlo's feedback (actual changes detailed below the commit blurb in the actual patch) - guest-side wr

[Qemu-devel] [PATCH v2 4/5] fw_cfg: prohibit insertion of duplicate fw_cfg file names

2015-03-18 Thread Gabriel L. Somlo
Exit with an error (instead of simply logging a trace event) whenever the same fw_cfg file name is added multiple times via one of the fw_cfg_add_file[_callback]() host-side API calls. Signed-off-by: Gabriel Somlo --- hw/nvram/fw_cfg.c | 11 ++- trace-events | 1 - 2 files changed,

[Qemu-devel] [PATCH v2 5/5] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-18 Thread Gabriel L. Somlo
Allow user supplied files to be inserted into the fw_cfg device before starting the guest. Since fw_cfg_add_file() already disallows duplicate fw_cfg file names, qemu will exit with an error message if the user supplies multiple blobs with the same fw_cfg file name, or if a blob name collides with

[Qemu-devel] [PATCH v2 3/5] fw_cfg: prevent selector key conflict

2015-03-18 Thread Gabriel L. Somlo
Enforce a single assignment of data for each distinct selector key. Signed-off-by: Gabriel Somlo --- hw/nvram/fw_cfg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c index 2f609b4..659de4c 100644 --- a/hw/nvram/fw_cfg.c +++ b/hw/nvram/fw_cfg.c @@ -423,6

[Qemu-devel] [PATCH v2 2/5] fw_cfg: remove support for guest-side data writes

2015-03-18 Thread Gabriel L. Somlo
>From this point forward, any guest-side writes to the fw_cfg data register will be treated as no-ops. This patch also removes the unused host-side API function fw_cfg_add_callback(), which allowed the registration of a callback to be executed each time the guest completed a full overwrite of a giv

[Qemu-devel] Question about scsi emulation

2015-03-18 Thread Yaoli Zheng
Hi, We have problem using qemu emulated scsi driver(the old lsi). Wonder if any of other device model we can try for emulating scsi, and how we can get and config it in Xen? Having been told virtio-scsi is alternative one, but have no idea how to get it work in Xen. Thanks! Yaoli Zheng

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-18 Thread Shannon Nelson
On Wed, Mar 18, 2015 at 3:01 PM, Shannon Nelson wrote: > > > On Wed, Mar 18, 2015 at 8:40 AM, jacob jacob wrote: > > > > On Wed, Mar 18, 2015 at 11:24 AM, Bandan Das wrote: > > > > > > Actually, Stefan suggests that support for this card is still sketchy > > > and your best bet is to try out net

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-18 Thread Shannon Nelson
On Wed, Mar 18, 2015 at 8:40 AM, jacob jacob wrote: > > On Wed, Mar 18, 2015 at 11:24 AM, Bandan Das wrote: > > > > Actually, Stefan suggests that support for this card is still sketchy > > and your best bet is to try out net-next > > http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git

Re: [Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls

2015-03-18 Thread John Snow
On 03/18/2015 06:51 PM, Peter Maydell wrote: On 18 March 2015 at 22:43, John Snow wrote: Calling abs() on a uint32_t is a no-op, so remove it. clang 3.5.0 will not compile this if -Werror is set, throwing a -Wabsolute-value warning. Signed-off-by: John Snow This is probably the wrong fix

Re: [Qemu-devel] [PATCH v2 3/4] configure: silence glib unknown attribute __alloc_size__

2015-03-18 Thread Peter Maydell
On 18 March 2015 at 22:43, John Snow wrote: > v2: We must test compilation with the right glib flags, > otherwise the test compile will always fail. > In addition, test-compile the warning flag to make > sure we can use it. > > The glib headers use GCC attributes. Unfortunately the __

Re: [Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls

2015-03-18 Thread Peter Maydell
On 18 March 2015 at 22:43, John Snow wrote: > Calling abs() on a uint32_t is a no-op, so remove it. > clang 3.5.0 will not compile this if -Werror is set, > throwing a -Wabsolute-value warning. > > Signed-off-by: John Snow This is probably the wrong fix (ie it silences the warning rather than fi

Re: [Qemu-devel] clang 3.5.0 errors

2015-03-18 Thread Peter Maydell
On 18 March 2015 at 22:22, John Snow wrote: > I just found this particular instance of a ccache-provoked warning > interesting because it does have some validity to it and I wanted to raise > the issue. > > If nobody cares, then, well. Nobody cares. Well, I do sort of care, but on the other hand

[Qemu-devel] [PATCH v2 2/4] configure: handle clang -nopie argument warning

2015-03-18 Thread John Snow
From: Stefan Hajnoczi gcc 4.9.2 treats -nopie as an error: cc: error: unrecognized command line option ‘-nopie’ clang 3.5.0 treats -nopie as a warning: clang: warning: argument unused during compilation: '-nopie' The causes ./configure to fail with clang: ERROR: configure test passed w

[Qemu-devel] [PATCH v2 4/4] configure: Add workaround for ccache and clang

2015-03-18 Thread John Snow
Test if ccache is interfering with our life, and disable its habit of trying to compile already pre-processed versions of code if so. In particular, clang has different semantic warnings based on if the warning arose from a macro or not. By trying to build preprocessed versions of code, we get mor

[Qemu-devel] [PATCH v2 1/4] tricore: remove no-op abs() calls

2015-03-18 Thread John Snow
Calling abs() on a uint32_t is a no-op, so remove it. clang 3.5.0 will not compile this if -Werror is set, throwing a -Wabsolute-value warning. Signed-off-by: John Snow --- target-tricore/op_helper.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/target-tricore/

[Qemu-devel] [PATCH v2 3/4] configure: silence glib unknown attribute __alloc_size__

2015-03-18 Thread John Snow
v2: We must test compilation with the right glib flags, otherwise the test compile will always fail. In addition, test-compile the warning flag to make sure we can use it. The glib headers use GCC attributes. Unfortunately the __GNUC__ and __GNUC_MINOR__ version macros are also define

[Qemu-devel] [PATCH v2 0/4] configure: clang 3.5.0 build fixes

2015-03-18 Thread John Snow
QEMU does not compile cleanly under clang 3.5.0. These patches eliminate the avalanche of warnings and make the build usable. v2: - Stole the series from Stefan - No changes to the -nopie patch, which I think was fine. - Fixed the -Wno-unknown-attributes patch. - Added a tricore fix for -Wabs

Re: [Qemu-devel] clang 3.5.0 errors

2015-03-18 Thread John Snow
On 03/18/2015 04:28 PM, Peter Maydell wrote: On 18 March 2015 at 19:22, John Snow wrote: There's one case of error here that's interesting that ccache unearths: we use a gnu extension to give return values to compound statement blocks, then wrap these blocks into macros as if they were funct

[Qemu-devel] [PATCH v8 10/10] iotests: Extend test 112 for qemu-img amend

2015-03-18 Thread Max Reitz
Add tests for conversion between different refcount widths. Signed-off-by: Max Reitz Reviewed-by: Eric Blake --- tests/qemu-iotests/112 | 109 + tests/qemu-iotests/112.out | 71 + 2 files changed, 180 insertions(+) di

[Qemu-devel] [PATCH v8 07/10] qcow2: Add function for refcount order amendment

2015-03-18 Thread Max Reitz
Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2-refcount.c | 452 + block/qcow2.h | 4

[Qemu-devel] [PATCH v8 05/10] qcow2: Split upgrade/downgrade paths for amend

2015-03-18 Thread Max Reitz
If the image version should be upgraded, that is the first we should do; if it should be downgraded, that is the last we should do. So split the version change block into an upgrade part at the start and a downgrade part at the end. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: S

[Qemu-devel] [PATCH v8 04/10] qcow2: Use abort() instead of assert(false)

2015-03-18 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index d1a0e53..da7795c 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2724,9 +2724,9 @@ stati

[Qemu-devel] [PATCH v8 08/10] qcow2: Invoke refcount order amendment function

2015-03-18 Thread Max Reitz
Make use of qcow2_change_refcount_order() to support changing the refcount order with qemu-img amend. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 44 +++- 1 file changed, 35 insertions(+), 9 deletions

[Qemu-devel] [PATCH v8 06/10] qcow2: Use intermediate helper CB for amend

2015-03-18 Thread Max Reitz
If there is more than one time-consuming operation to be performed for qcow2_amend_options(), we need an intermediate CB which coordinates the progress of the individual operations and passes the result to the original status callback. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by

[Qemu-devel] [PATCH v8 09/10] qcow2: Point to amend function in check

2015-03-18 Thread Max Reitz
If a reference count is not representable with the current refcount order, the image check should point to qemu-img amend for increasing the refcount order. However, qemu-img amend needs write access to the image which cannot be provided if the image is marked corrupt; and the image check will not

[Qemu-devel] [PATCH v8 02/10] block: Add opaque value to the amend CB

2015-03-18 Thread Max Reitz
Add an opaque value which is to be passed to the bdrv_amend_options() status callback. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block.c | 4 ++-- block/qcow2-cluster.c | 14 -- block/qcow2.c | 9 +

[Qemu-devel] [PATCH v8 00/10] qcow2: Allow refcount_bits amendment

2015-03-18 Thread Max Reitz
This series adds support to qemu for changing the refcount_bits option of an existing qcow2 file through the qemu-img amend command. Originally (up until v7), this series was called "qcow2: Support refcount orders != 4", but by now that support has already been merged so all that is left is suppor

[Qemu-devel] [PATCH v8 01/10] progress: Allow regressing progress

2015-03-18 Thread Max Reitz
Progress may regress; this should be displayed correctly by qemu_progress_print(). While touching that area of code, drop the redundant parentheses in the same condition. Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- util/qemu-progress.c | 3 ++- 1 file cha

[Qemu-devel] [PATCH v8 03/10] qcow2: Use error_report() in qcow2_amend_options()

2015-03-18 Thread Max Reitz
Signed-off-by: Max Reitz Reviewed-by: Eric Blake Reviewed-by: Stefan Hajnoczi --- block/qcow2.c | 14 ++ tests/qemu-iotests/061.out | 14 +++--- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index fd66bf2..d1a0e53

Re: [Qemu-devel] [PATCH v3 00/12] qcow2: Add new overlap check functions

2015-03-18 Thread Max Reitz
Pïng On 2015-02-27 at 17:20, Max Reitz wrote: Ping On 2015-02-09 at 14:25, Max Reitz wrote: As has been requested, this series adds new overlap check functions to the qcow2 code. My local branch is called "qcow2-improved-overlap-v1", but I am not so sure whether it is actually an improvement;

Re: [Qemu-devel] clang 3.5.0 errors

2015-03-18 Thread Peter Maydell
On 18 March 2015 at 19:22, John Snow wrote: > There's one case of error here that's interesting that ccache unearths: > > we use a gnu extension to give return values to compound statement blocks, > then wrap these blocks into macros as if they were functions. > > The practical outcome here is tha

Re: [Qemu-devel] [PATCH 5/6] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-18 Thread Gabriel L. Somlo
On Tue, Mar 17, 2015 at 12:28:20PM +0100, Laszlo Ersek wrote: > > + > > +void fw_cfg_option_add(QemuOpts *opts) > > +{ > > +const char *name = qemu_opt_get(opts, "name"); > > +const char *file = qemu_opt_get(opts, "file"); > > + > > +if (name == NULL || *name == '\0' || file == NULL ||

Re: [Qemu-devel] [PATCH 07/11] block: drive_backup transaction callback support

2015-03-18 Thread Max Reitz
On 2015-03-18 at 15:51, John Snow wrote: On 03/18/2015 09:41 AM, Max Reitz wrote: On 2015-03-17 at 19:27, John Snow wrote: On 03/17/2015 03:49 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: This patch actually implements the transactional callback system for the drive_backu

Re: [Qemu-devel] [PATCH 1/6 v6] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-18 Thread Richard Henderson
On 03/18/2015 09:34 AM, Chen Gang wrote: > +static void gen_fnop(void) > +{ > +qemu_log_mask(CPU_LOG_TB_IN_ASM, "(f)nop\n"); > +} > + > +static void gen_cmpltui(struct DisasContext *dc, > +uint8_t rdst, uint8_t rsrc, int8_t imm8) > +{ > +qemu_log_mask(CPU_LOG_TB_IN_A

Re: [Qemu-devel] [PATCH 5/6] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-18 Thread Gabriel L. Somlo
On Tue, Mar 17, 2015 at 12:49:50PM +0100, Gerd Hoffmann wrote: > Hi, > > > Perhaps the suggestion to move the file loading from fw_cfg_init1() -- > > ie. device initialization -- to the earlier option parsing phase will > > appease Gerd too :) But, admittedly, I don't know what the "existing > >

Re: [Qemu-devel] [PATCH 07/11] block: drive_backup transaction callback support

2015-03-18 Thread John Snow
On 03/18/2015 09:41 AM, Max Reitz wrote: On 2015-03-17 at 19:27, John Snow wrote: On 03/17/2015 03:49 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: This patch actually implements the transactional callback system for the drive_backup transaction. (1) We manually pick up a

Re: [Qemu-devel] clang 3.5.0 errors

2015-03-18 Thread John Snow
On 03/17/2015 07:07 PM, Peter Maydell wrote: On 17 March 2015 at 19:59, John Snow wrote: On 03/17/2015 03:34 PM, Peter Maydell wrote: On 17 March 2015 at 19:30, John Snow wrote: -Wunused-command-line-argument currently complains about the many include flags passed to each CC incantation

Re: [Qemu-devel] the arm cache coherency cluster "v2"

2015-03-18 Thread Andrew Jones
On Wed, Mar 18, 2015 at 03:08:20PM -0400, Andrew Jones wrote: > In reply to this message I'll send two series' one for KVM and > one for QEMU. The two series' are their respective component > complements, and attempt to implement cache coherency for arm > guests using emulated devices, where the em

Re: [Qemu-devel] [PATCH v4 4/5] Qemu-Xen-vTPM: Qemu vTPM xenstubdoms backen.

2015-03-18 Thread Stefan Berger
On 03/10/2015 08:14 AM, Quan Xu wrote: This Patch provides the glue for the TPM_TIS(Qemu frontend) to Xen stubdom vTPM domain that provides the actual TPM functionality. It sends data and TPM commends with xen_vtpm_frontend. It is similar as another two vTPM backens: *vTPM passthrough backen S

[Qemu-devel] [RFC PATCH 4/4] vga: flag vram as uncached

2015-03-18 Thread Andrew Jones
Video RAM is typically mapped as uncached by guests. Flag it as such. Signed-off-by: Andrew Jones --- hw/display/vga.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/display/vga.c b/hw/display/vga.c index c0f7b343bbab5..5c8c249a8d780 100644 --- a/hw/display/vga.c +++ b/hw/display/vga.c @

[Qemu-devel] Output of fprintf messages in qemu source

2015-03-18 Thread Toms Varghese
Hi all, I can see some fprintf (stderr, ...) statements in qemu source code. I expect the output to be shown in the terminal window. I use libvirt to manage my VMs and hence have no idea about the exact qemu command line being used. From the comments in the below post http://blog.vmsplice.net/201

[Qemu-devel] [RFC PATCH 2/4] HACK: linux header update

2015-03-18 Thread Andrew Jones
Should do a proper update-linux-headers.sh update. Signed-off-by: Andrew Jones --- linux-headers/linux/kvm.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h index 60a54c82a3b76..34c03cd80aa69 100644 --- a/linux-headers/linux/kvm.h +++ b

[Qemu-devel] [RFC PATCH 0/4] support KVM_MEM_UNCACHED

2015-03-18 Thread Andrew Jones
Add support for the new KVM_MEM_UNCACHED flag, and flag appropriate memory. (Only flags vga/vram for now.) Andrew Jones (4): kvm-all: put kvm_mem_flags to more work HACK: linux header update memory: add uncached flag vga: flag vram as uncached hw/display/vga.c | 1 + include/ex

[Qemu-devel] [RFC PATCH 3/4] memory: add uncached flag

2015-03-18 Thread Andrew Jones
Add an 'uncached' flag, which will result in the KVM_MEM_UNCACHED flag getting set on KVM's corresponding memory slot. Signed-off-by: Andrew Jones --- include/exec/memory.h | 25 + kvm-all.c | 9 + memory.c | 15 +++ 3 files c

[Qemu-devel] [RFC PATCH 1/3] KVM: promote KVM_MEMSLOT_INCOHERENT to uapi

2015-03-18 Thread Andrew Jones
Also rename to KVM_MEM_UNCACHED. Signed-off-by: Andrew Jones --- Documentation/virtual/kvm/api.txt | 16 ++-- arch/arm/include/uapi/asm/kvm.h | 1 + arch/arm/kvm/arm.c| 1 + arch/arm/kvm/mmu.c| 4 ++-- arch/arm64/include/uapi/asm/kvm.h | 1 + inc

[Qemu-devel] [RFC PATCH 1/4] kvm-all: put kvm_mem_flags to more work

2015-03-18 Thread Andrew Jones
Currently kvm_mem_flags just translates bools to bits, let's make it also determine the bools first. This avoids its parameter list growing each time we add a flag. Signed-off-by: Andrew Jones --- kvm-all.c | 25 +++-- 1 file changed, 15 insertions(+), 10 deletions(-) diff -

[Qemu-devel] [RFC PATCH 2/3] arm/arm64: KVM: decouple READONLY and UNCACHED

2015-03-18 Thread Andrew Jones
KVM_MEM_UNCACHED memory will no longer need caches to be flushed for memory as it's faulted in. Just use READONLY directly, in that case, now. Signed-off-by: Andrew Jones --- arch/arm/kvm/mmu.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/arch/arm/kvm/

[Qemu-devel] [RFC PATCH 3/3] arm/arm64: KVM: implement KVM_MEM_UNCACHED

2015-03-18 Thread Andrew Jones
When userspace tells us a memory region is uncached, then we need to pin all its pages and set them all to be uncached. Signed-off-by: Andrew Jones --- arch/arm/include/asm/kvm_mmu.h| 9 + arch/arm/include/uapi/asm/kvm.h | 1 + arch/arm/kvm/mmu.c| 71 +

[Qemu-devel] [RFC PATCH 0/3] KVM: Introduce KVM_MEM_UNCACHED

2015-03-18 Thread Andrew Jones
Introduce a new memory region flag, KVM_MEM_UNCACHED, which is needed by ARM. This flag informs KVM that the given memory region is typically mapped by the guest as uncached. KVM for ARM then maps that region as uncached for userspace as well, in order to keep coherency. Andrew Jones (3): KVM: p

[Qemu-devel] the arm cache coherency cluster "v2"

2015-03-18 Thread Andrew Jones
In reply to this message I'll send two series' one for KVM and one for QEMU. The two series' are their respective component complements, and attempt to implement cache coherency for arm guests using emulated devices, where the emulator (qemu) uses cached memory for the device memory, but the guest

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Alex Williamson
On Wed, 2015-03-18 at 19:56 +0100, Michael S. Tsirkin wrote: > On Wed, Mar 18, 2015 at 12:08:15PM -0600, Alex Williamson wrote: > > On Wed, 2015-03-18 at 18:45 +0100, Michael S. Tsirkin wrote: > > > On Wed, Mar 18, 2015 at 11:11:28AM -0600, Alex Williamson wrote: > > > > On Wed, 2015-03-18 at 17:44

Re: [Qemu-devel] the arm cache coherency cluster

2015-03-18 Thread Andrew Jones
On Fri, Mar 06, 2015 at 01:49:40PM -0500, Andrew Jones wrote: > In reply to this message I'll send two series' one for KVM and > one for QEMU. The two series' are their respective component > complements, and attempt to implement cache coherency for arm > guests using emulated devices, where the em

Re: [Qemu-devel] [PATCH v4 3/5] Qemu-Xen-vTPM: Register Xen stubdom vTPM frontend driver

2015-03-18 Thread Stefan Berger
On 03/10/2015 08:14 AM, Quan Xu wrote: This drvier transfers any request/repond between TPM xenstubdoms driver and Xen vTPM stubdom, and facilitates communications between Xen vTPM stubdom domain and vTPM xenstubdoms driver. It is a glue for the TPM xenstubdoms driver and Xen stubdom vTPM domain

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 12:08:15PM -0600, Alex Williamson wrote: > On Wed, 2015-03-18 at 18:45 +0100, Michael S. Tsirkin wrote: > > On Wed, Mar 18, 2015 at 11:11:28AM -0600, Alex Williamson wrote: > > > On Wed, 2015-03-18 at 17:44 +0100, Michael S. Tsirkin wrote: > > > > On Wed, Mar 18, 2015 at 09:

Re: [Qemu-devel] Emulation failure on booting/rebooting VMs

2015-03-18 Thread Kevin O'Connor
On Wed, Mar 18, 2015 at 06:36:48PM +0100, Mohammed Gamal wrote: > Hi, > I've been sporadically getting my KVM virtual machines crashing with this > message while they're booting > > KVM internal error. Suberror: 1 > emulation failure > EAX= EBX= ECX= EDX=00600f12 > ESI=

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Alex Williamson
On Wed, 2015-03-18 at 18:45 +0100, Michael S. Tsirkin wrote: > On Wed, Mar 18, 2015 at 11:11:28AM -0600, Alex Williamson wrote: > > On Wed, 2015-03-18 at 17:44 +0100, Michael S. Tsirkin wrote: > > > On Wed, Mar 18, 2015 at 09:45:29AM -0600, Alex Williamson wrote: > > > > On Wed, 2015-03-18 at 16:02

Re: [Qemu-devel] [PATCH v5 23/45] migrate_start_postcopy: Command to trigger transition to postcopy

2015-03-18 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Mar 13, 2015 at 11:19:06AM +, Dr. David Alan Gilbert wrote: > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > On Wed, Feb 25, 2015 at 04:51:46PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David A

Re: [Qemu-devel] [PATCH v5 26/45] Postcopy page-map-incoming (PMI) structure

2015-03-18 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Fri, Mar 13, 2015 at 01:47:53PM +, Dr. David Alan Gilbert wrote: > > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > > On Wed, Feb 25, 2015 at 04:51:49PM +, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David A

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 11:11:28AM -0600, Alex Williamson wrote: > On Wed, 2015-03-18 at 17:44 +0100, Michael S. Tsirkin wrote: > > On Wed, Mar 18, 2015 at 09:45:29AM -0600, Alex Williamson wrote: > > > On Wed, 2015-03-18 at 16:02 +0100, Michael S. Tsirkin wrote: > > > > On Wed, Mar 18, 2015 at 08:

Re: [Qemu-devel] Emulation failure on booting/rebooting VMs

2015-03-18 Thread Andrey Korolyov
On Wed, Mar 18, 2015 at 8:36 PM, Mohammed Gamal wrote: > Hi, > I've been sporadically getting my KVM virtual machines crashing with this > message while they're booting > > KVM internal error. Suberror: 1 > emulation failure > EAX= EBX= ECX= EDX=00600f12 > ESI= EDI=

[Qemu-devel] Emulation failure on booting/rebooting VMs

2015-03-18 Thread Mohammed Gamal
Hi, I've been sporadically getting my KVM virtual machines crashing with this message while they're booting KVM internal error. Suberror: 1 emulation failure EAX= EBX= ECX= EDX=00600f12 ESI= EDI= EBP= ESP=fffa EIP=ff53 EFL=0006 [-P-]

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Alex Williamson
On Wed, 2015-03-18 at 17:44 +0100, Michael S. Tsirkin wrote: > On Wed, Mar 18, 2015 at 09:45:29AM -0600, Alex Williamson wrote: > > On Wed, 2015-03-18 at 16:02 +0100, Michael S. Tsirkin wrote: > > > On Wed, Mar 18, 2015 at 08:50:54AM -0600, Alex Williamson wrote: > > > > On Wed, 2015-03-18 at 15:36

Re: [Qemu-devel] [PATCH target-arm v3 04/15] arm: xlnx-zynqmp: Add GIC

2015-03-18 Thread Peter Crosthwaite
On Wed, Mar 18, 2015 at 7:06 PM, Paolo Bonzini wrote: > > > On 18/03/2015 14:11, Peter Crosthwaite wrote: >> So I actually bisected this as a recent regression on: >> >> commit a464982499b2f637f6699e3d03e0a9d2e0b5288b (refs/bisect/bad) >> Author: Paolo Bonzini >> Date: Wed Feb 11 17:15:18 2015

Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 04:31:53PM +0100, Gerd Hoffmann wrote: > On Mi, 2015-03-18 at 15:31 +0100, Michael S. Tsirkin wrote: > > On Wed, Mar 18, 2015 at 03:00:12PM +0100, Gerd Hoffmann wrote: > > > This patch adds virtio-input support to qemu. It brings a abstract > > > base class providing core s

Re: [Qemu-devel] [PATCH] migration: flush the bdrv before stopping VM

2015-03-18 Thread Dr. David Alan Gilbert
* Li, Liang Z (liang.z...@intel.com) wrote: > > > > First explanation, why I think this don't fix the full problem. > > > > Whith this patch, we fix the problem where we have a dirty block > > > > layer but basically nothing dirtying the memory on the guest (we are > > > > moving the 20 seconds fro

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 09:45:29AM -0600, Alex Williamson wrote: > On Wed, 2015-03-18 at 16:02 +0100, Michael S. Tsirkin wrote: > > On Wed, Mar 18, 2015 at 08:50:54AM -0600, Alex Williamson wrote: > > > On Wed, 2015-03-18 at 15:36 +0100, Michael S. Tsirkin wrote: > > > > On Wed, Mar 18, 2015 at 08:

[Qemu-devel] [PATCH 6/6 v6] linux-user/syscall.c: conditionalize syscalls which are not defined in tilegx

2015-03-18 Thread Chen Gang
For tilegx, several syscall macros are not supported, so switch them to avoid building break. Signed-off-by: Chen Gang --- linux-user/syscall.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/linux-user/syscall.c b/linux-user

[Qemu-devel] [PATCH 5/6 v6] linux-user: Support tilegx architecture in linux-user

2015-03-18 Thread Chen Gang
Add main working flow feature, system call processing feature, and elf64 tilegx binary loading feature, based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang --- include/elf.h| 2 ++ linux-user/elfload.c | 23 ++ linux-user/main.c| 86 +

[Qemu-devel] [PATCH 4/6 v6] linux-user: Support tilegx architecture in syscall

2015-03-18 Thread Chen Gang
Add tilegx architecture in "syscall_defs.h", all related features (ioctrl, and stat) are based on Linux kernel tilegx 64-bit implementation. Signed-off-by: Chen Gang --- linux-user/syscall_defs.h | 38 ++ 1 file changed, 34 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH v2 for-2.3] numa: pc: fix default VCPU to node mapping

2015-03-18 Thread Igor Mammedov
since commit dd0247e0 pc: acpi: mark all possible CPUs as enabled in SRAT Linux kernel actually tries to use CPU to Node mapping from QEMU provided SRAT table instead of discarding it, and that in some cases breaks build_sched_domains() which expects sane mapping where cores/threads belonging to

[Qemu-devel] [PATCH 3/6 v6] linux-user: tilegx: Add target features support within qemu

2015-03-18 Thread Chen Gang
They are for target features within qemu which independent from outside. Signed-off-by: Chen Gang --- linux-user/tilegx/target_cpu.h | 35 +++ linux-user/tilegx/target_signal.h | 28 ++ linux-user/tilegx/target_structs.h | 48 +

[Qemu-devel] [PATCH 2/6 v6] linux-user: tilegx: Firstly add architecture related features

2015-03-18 Thread Chen Gang
They are based on Linux kernel tilegx architecture for 64 bit binary, also based on tilegx ABI reference document. Signed-off-by: Chen Gang --- linux-user/tilegx/syscall.h| 80 linux-user/tilegx/syscall_nr.h | 278 linux-user/tilegx/term

[Qemu-devel] [PATCH 1/6 v6] target-tilegx: Firstly add TILE-Gx with minimized features

2015-03-18 Thread Chen Gang
It is the configure and build system support for TILE-Gx (tilegx will be used in configure and real sub-directory name). At present, it is linux-user only, and can finish the first system call (uname) execution in __libc_start_main(). Signed-off-by: Chen Gang --- configure

[Qemu-devel] [PATCH 0/6 v6] tilegx: Firstly add tilegx feature for linux-user

2015-03-18 Thread Chen Gang
After load elf64 binary, qemu tilegx can finish executing the first system call (uname) successfully in _dl_discover_osversion(), and return to __libc_start_main(). Chen Gang (6): target-tilegx: Firstly add TILE-Gx with minimized features linux-user: tilegx: Firstly add architecture related fe

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Alex Williamson
On Wed, 2015-03-18 at 16:02 +0100, Michael S. Tsirkin wrote: > On Wed, Mar 18, 2015 at 08:50:54AM -0600, Alex Williamson wrote: > > On Wed, 2015-03-18 at 15:36 +0100, Michael S. Tsirkin wrote: > > > On Wed, Mar 18, 2015 at 08:15:01AM -0600, Alex Williamson wrote: > > > > On Wed, 2015-03-18 at 15:05

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-18 Thread jacob jacob
On Wed, Mar 18, 2015 at 11:24 AM, Bandan Das wrote: > [Ccing netdev and Stefan] > Bandan Das writes: > >> jacob jacob writes: >> >>> On Mon, Mar 16, 2015 at 2:12 PM, Bandan Das wrote: jacob jacob writes: > I also see the following in dmesg in the VM. > > [0.095758] AC

Re: [Qemu-devel] [PATCH 2/4] virtio-input: core code & base class

2015-03-18 Thread Gerd Hoffmann
On Mi, 2015-03-18 at 15:31 +0100, Michael S. Tsirkin wrote: > On Wed, Mar 18, 2015 at 03:00:12PM +0100, Gerd Hoffmann wrote: > > This patch adds virtio-input support to qemu. It brings a abstract > > base class providing core support, other classes can build on it to > > actually implement input d

Re: [Qemu-devel] PCI passthrough of 40G ethernet interface (Openstack/KVM)

2015-03-18 Thread Bandan Das
[Ccing netdev and Stefan] Bandan Das writes: > jacob jacob writes: > >> On Mon, Mar 16, 2015 at 2:12 PM, Bandan Das wrote: >>> jacob jacob writes: >>> I also see the following in dmesg in the VM. [0.095758] ACPI: PCI Root Bridge [PCI0] (domain [bus 00-ff]) [0.0

Re: [Qemu-devel] [PATCH for-2.4 0/8] memory: enable unlocked PIO/MMIO in KVM

2015-03-18 Thread Jan Kiszka
On 2015-03-18 15:52, Paolo Bonzini wrote: > > > On 18/03/2015 15:33, Jan Kiszka wrote: >> Just in time: I'm planning to rebase our queue soon, specifically to >> benefit from RCU support. Will let you know if it works on top of this >> series. > > Great. FWIW, this is the most similar version t

Re: [Qemu-devel] [PATCH v5 7/7] pc: add PC_I440FX_COMPAT to disable aercap for vifo device

2015-03-18 Thread Michael S. Tsirkin
On Wed, Mar 18, 2015 at 08:50:54AM -0600, Alex Williamson wrote: > On Wed, 2015-03-18 at 15:36 +0100, Michael S. Tsirkin wrote: > > On Wed, Mar 18, 2015 at 08:15:01AM -0600, Alex Williamson wrote: > > > On Wed, 2015-03-18 at 15:05 +0100, Michael S. Tsirkin wrote: > > > > On Wed, Mar 18, 2015 at 08:

Re: [Qemu-devel] [PATCH for-2.4 0/8] memory: enable unlocked PIO/MMIO in KVM

2015-03-18 Thread Jan Kiszka
On 2015-03-18 14:21, Paolo Bonzini wrote: > And here we are... These are the changes required to make the BQL > optional for memory access, and use that support in KVM. For now, > only one device model is changed to do unlocked accesses. > > Please review! > > Jan Kiszka (4): > memory: Add gl

  1   2   3   >