Re: [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse

10.03.2015 09:22, Stefan Weil wrote: > No, that was my mistake. Please excuse also the cris patch which I sent twice. > I did not notice that it already had caused trouble, nor did I notice that I > had already sent it. > In my local patch queue (~ 50 patches) there was even a 2nd cris patch > wh

Re: [Qemu-devel] [PATCH 1/3] pcie_aer: fix typos in pcie_aer_inject_error comment

10.03.2015 04:49, Chen Fan пишет: > Refer to "PCI Express Base Spec3.0", this comments can't > fit the description in spec, so we should fix them. > > Signed-off-by: Chen Fan > --- > hw/pci/pcie_aer.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/hw/pci/pcie_aer

Re: [Qemu-devel] Using tap device for qemu

On 2015/3/10 12:59, Gayathri Nagarajan wrote: > I have a problem with networking in qemu. I want to use the Linux tap device > for qemu network. For that > > *1. I created a bridge -* > > $ sudo brctl addbr br0 > > *2. I used the following qemu-ifup script* > > #!/bin/sh > set -x > > switch=

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

On 03/10/2015 06:21 AM, Marcel Apfelbaum wrote: On 03/09/2015 06:55 PM, Gerd Hoffmann wrote: On Mo, 2015-03-09 at 18:26 +0200, Marcel Apfelbaum wrote: On 03/09/2015 04:19 PM, Gerd Hoffmann wrote: Hi, My series is based on commit 09d219a. Try please on top of this commit. Ok, that works

Re: [Qemu-devel] [PATCH] target-moxie: Fix warnings from Sparse (one-bit signed bitfield)

Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse

Am 10.03.2015 um 07:04 schrieb Michael Tokarev: Applied all 7 to -trivial. Is it intentional that there's no cover letter for the series? Thanks, /mjt No, that was my mistake. Please excuse also the cris patch which I sent twice. I did not notice that it already had caused trouble, nor did

Re: [Qemu-devel] [PATCH v2] error: Replace error_report() & error_free() with error_report_err()

04.03.2015 13:25, zhanghailiang wrote: > This is a continuation of the work started in commit 565f65d27: > "error: Use error_report_err() where appropriate" Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] 9pfs-local: simplify/optimize local_mapped_attr_path()

05.03.2015 04:13, Fam Zheng wrote: > On Thu, 03/05 00:03, Michael Tokarev wrote: >> +const char *name = basename((char*)path); > > checkpatch.pl complained this, s/char*/char */ I've fixed it in git. Thank you for spotting this. /mjt

Re: [Qemu-devel] [PATCH v5 13/45] ram_debug_dump_bitmap: Dump a migration bitmap as text

On Wed, Feb 25, 2015 at 04:51:36PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Misses out lines that are all the expected value so the output > can be quite compact depending on the circumstance. > > Signed-off-by: Dr. David Alan Gilbert > --- > arch_init.c

Re: [Qemu-devel] [PATCH v5 12/45] Return path: Source handling of return path

On Wed, Feb 25, 2015 at 04:51:35PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Open a return path, and handle messages that are received upon it. > > Signed-off-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 8 ++ > migration/migration.

Re: [Qemu-devel] [PATCH v2] arm: fix memory leak

This one appears to work better. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH 5/8] ioport: Remove unused functions

On Mon, 09 Mar 2015 20:23:24 +0100 Paolo Bonzini wrote: > > On 09/03/2015 18:30, Thomas Huth wrote: > > The functions portio_list_destroy() and portio_list_del() > > are not used anywhere, so let's remove them. > > > > Signed-off-by: Thomas Huth > > Cc: Paolo Bonzini > > I think it's better

Re: [Qemu-devel] [PATCH 0/2] monitor: Fix and clean up around .user_print

06.03.2015 12:09, Markus Armbruster wrote: > A more thorough cleanup of the area is in the works, but I want to get > this out quickly, so it makes 2.3. > > I think it can go via -trivial, if Luiz doesn't mind. Applied to -trivial for now, thank you! /mjt

Re: [Qemu-devel] [PATCH] block/qapi: Fix Sparse warning

08.03.2015 01:16, Stefan Weil wrote: > Sparse reports this warning: > > block/qapi.c:417:47: warning: > too long initializer-string for array of char(no space for nul char) > > Replacing the string by an array of characters fixes this warning. > -static const char suffixes[NB_SUFFIXES] = "K

Re: [Qemu-devel] [PATCH v2] error: Replace error_report() & error_free() with error_report_err()

Hi Michael, This patch has been reviewed, Please consider for merging. Thanks, zhanghailiang On 2015/3/5 0:50, Markus Armbruster wrote: zhanghailiang writes: This is a continuation of the work started in commit 565f65d27: "error: Use error_report_err() where appropriate" Signed-off-by: zha

Re: [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse

Applied all 7 to -trivial. Is it intentional that there's no cover letter for the series? Thanks, /mjt

Re: [Qemu-devel] [PATCH v5 10/45] Return path: Control commands

On Wed, Feb 25, 2015 at 04:51:33PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add two src->dest commands: >* OPEN_RETURN_PATH - To request that the destination open the return path >* SEND_PING - Request an acknowledge from the destination > > Signed-

Re: [Qemu-devel] [PATCH v5 09/45] Migration commands

On Wed, Feb 25, 2015 at 04:51:32PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Create QEMU_VM_COMMAND section type for sending commands from > source to destination. These commands are not intended to convey > guest state but to control the migration process.

Re: [Qemu-devel] [PATCH v5 11/45] Return path: Send responses from destination to source

On Wed, Feb 25, 2015 at 04:51:34PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Add migrate_send_rp_message to send a message from destination to source > along the return path. > (It uses a mutex to let it be called from multiple threads) > Add migrate_send_

[Qemu-devel] [PATCH] 9pfs-proxy: tiny cleanups in proxy_pwritev and proxy_preadv

Don't compare syscall return with -1, use "<0" condition. Don't introduce useless local variables when we already have similar variable Rename local variable to be consistent with other usages Signed-off-by: Michael Tokarev --- hw/9pfs/virtio-9p-proxy.c | 12 +--- 1 file changed, 5 inser

Re: [Qemu-devel] [PULL v2 00/46] Trivial patches for 2015-03-04

08.03.2015 15:43, Peter Maydell wrote: [..] > Fails to build on clang, I'm afraid: > > /home/petmay01/linaro/qemu-for-merges/disas/cris.c:1218:33: error: > unused variable 'cris_cond15s' [-Werror,-Wunused-const-variable] > static const struct cris_cond15 cris_cond15s[] = >

Re: [Qemu-devel] Fix for incorrect SYSRET instruction implementation -- anyone looked at this yet?

Please see my comment below. Am 09.03.2015 um 23:46 schrieb Bill Paul: Of all the gin joints in all the towns in all the world, Stefan Weil had to walk into mine at 15:23:36 on Monday 09 March 2015 and say: Hi Bill, sending text only e-mails might help. Usually git send-email is better than u

[Qemu-devel] Ask about patching our MIPS work to Qemu main branch

Hi, there, We are software engineers of Loongson.Inc，a computer company design and produce MIPS-compatible computers located in China。 Currently we use Qemu to run X86-64 network programs such as snort on MIPS platform. During Qemu running on MIPS, we found some Qemu bugs such as pagesize, me

[Qemu-devel] Using tap device for qemu

I have a problem with networking in qemu. I want to use the Linux tap device for qemu network. For that *1. I created a bridge -* $ sudo brctl addbr br0 *2. I used the following qemu-ifup script* #!/bin/sh set -x switch=br0 if [ -n "$1" ];then /usr/bin/sudo /usr/sbin/tunctl -u `whoami

[Qemu-devel] [PATCH] cris: remove unused cris_cond15 declarations

Signed-off-by: Michael Tokarev --- disas/cris.c | 11 --- target-cris/opcode-cris.h | 10 -- 2 files changed, 21 deletions(-) diff --git a/disas/cris.c b/disas/cris.c index 9dfb4e3..0fc7e54 100644 --- a/disas/cris.c +++ b/disas/cris.c @@ -1214,17 +1214,6 @@ cris_cc_s

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

> Am 09.03.2015 um 23:44 schrieb Alexey Kardashevskiy : > >> On 03/10/2015 02:58 PM, David Gibson wrote: >>> On Tue, Mar 10, 2015 at 02:52:48PM +1100, Alexey Kardashevskiy wrote: On 03/10/2015 01:39 AM, Alexey Kardashevskiy wrote: > On 03/09/2015 11:31 PM, Alexander Graf wrote: >

[Qemu-devel] [PULL v4 00/44] Trivial patches for 2015-03-04

This is a v4 (!) pull request for trivial-patches tree which was initially sent Wed, 4 Mar 2015 20:06:17 +0300. The following patches has been dropped: - migration/rdma: clean up qemu_rdma_dest_init a bit -- will go to the migration tree - microblaze: fix memory leak -- wrong change, ca

Re: [Qemu-devel] [PATCH] disas/cris: Fix warning caused by missing 'static' attribute

01.03.2015 16:07, Stefan Weil wrote: > Warning from the Sparse static analysis tool: > > disas/cris.c:1218:26: warning: > symbol 'cris_cond15s' was not declared. Should it be static? > > Signed-off-by: Stefan Weil > --- > disas/cris.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Qemu-devel] [PATCH 1/5] 9pfs-proxy: simplify v9fs_request(), P1

10.03.2015 07:19, Michael Tokarev wrote: > 08.03.2015 19:39, Aneesh Kumar K.V wrote: >> Michael Tokarev writes: >> >>> This simplifies code in v9fs_request() a bit by replacing several >>> ifs with a common variable check and rearranging error/cleanup >>> code a bit. >> >> Is this -V2 of >> http:/

Re: [Qemu-devel] [PATCH v3 0/3] RFC: 9pfs-proxy: simplify/cleanup

Now when I reviewed the whole thing, I'd drop the error handling change too, and fold it into even bigger change. What I'm thinking is to refactor this code to look significantly different, namely: For the proxy code: o each filesystem method first call proxy_send_request(type, fmt, ...), and

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

On 03/10/2015 02:58 PM, David Gibson wrote: On Tue, Mar 10, 2015 at 02:52:48PM +1100, Alexey Kardashevskiy wrote: On 03/10/2015 01:39 AM, Alexey Kardashevskiy wrote: On 03/09/2015 11:31 PM, Alexander Graf wrote: On 02.03.15 00:46, Alexey Kardashevskiy wrote: This removes floppy disks suppor

Re: [Qemu-devel] [PATCH 1/3] 9pfs-proxy: simplify error handling

08.03.2015 19:27, Aneesh Kumar K.V wrote: > Michael Tokarev writes: [] >> Actually, after reading almost whole 9pfs and fsdev code, I can >> say with great confidence this code is nearly hopeless. > > Is that about the 9pfs-proxy code, or the rest of 9pfs. I understand Well. the marshal/unmarsha

Re: [Qemu-devel] [PATCH 1/5] 9pfs-proxy: simplify v9fs_request(), P1

08.03.2015 19:39, Aneesh Kumar K.V wrote: > Michael Tokarev writes: > >> This simplifies code in v9fs_request() a bit by replacing several >> ifs with a common variable check and rearranging error/cleanup >> code a bit. > > Is this -V2 of > http://mid.gmane.org/b98f675750ef0535cab41225240db1657f

[Qemu-devel] qemu-system return value when terminating due to a signal

When qemu is terminated by a signal, such as SIGINT (Ctrl+C), it exits with a zero, successful status. Is it intentional? Sure, from the qemu perspective, pulling the plug from the guest machine is a success. But maybe it's better to indicate that the exit was due to interrupt, not because of `e

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

On Tue, Mar 10, 2015 at 02:52:48PM +1100, Alexey Kardashevskiy wrote: > On 03/10/2015 01:39 AM, Alexey Kardashevskiy wrote: > >On 03/09/2015 11:31 PM, Alexander Graf wrote: > >> > >> > >>On 02.03.15 00:46, Alexey Kardashevskiy wrote: > >>>This removes floppy disks support as it is not supported by

Re: [Qemu-devel] [PATCH 2/3] ppc64-softmmu: Remove unsupported FDC from config

On 03/10/2015 01:39 AM, Alexey Kardashevskiy wrote: On 03/09/2015 11:31 PM, Alexander Graf wrote: On 02.03.15 00:46, Alexey Kardashevskiy wrote: This removes floppy disks support as it is not supported by any PPC64 system anyway as the only way to have floppy disk on such systems would be an

Re: [Qemu-devel] [PATCH 00/10] spapr: Small patches to prepare for Dynamic DMA windows

On 02/23/2015 07:33 PM, Alexey Kardashevskiy wrote: These I have in my DDW working tree for quite a while, while I am polishing others, there could go to some tree already. Please comment. Thanks! Alex, ping. "spapr_pci: Make find_phb()/find_dev() public" won't apply after Gavin's EEH patche

Re: [Qemu-devel] [RFC] introduce bitmap to bdrv_commit totrackdirtysector

On 2015-03-10 10:58:44, Fam Zheng wrote: > > Is it worthy to implement it? > > Maybe, I think once we start to assign node-name to each BDS in the tree, this > will be natural to implement. > Once implemented, to be honest, I really don't see much advantages of incremental backup over aforement

Re: [Qemu-devel] [PATCH v5 08/45] Return path: socket_writev_buffer: Block even on non-blocking fd's

On Wed, Feb 25, 2015 at 04:51:31PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The return path uses a non-blocking fd so as not to block waiting > for the (possibly broken) destination to finish returning a message, > however we still want outbound data to beha

Re: [Qemu-devel] [PATCH v5 07/45] Return path: Open a return path on QEMUFile for sockets

On Wed, Feb 25, 2015 at 04:51:30PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Postcopy needs a method to send messages from the destination back to > the source, this is the 'return path'. > > Wire it up for 'socket' QEMUFile's using a dup'd fd. > > Signed-o

Re: [Qemu-devel] [RFC] introduce bitmap to bdrv_commit to trackdirtysector

> Is it worthy to implement it? Maybe, I think once we start to assign node-name to each BDS in the tree, this will be natural to implement. > And does qemu support commit any external snapshot to its backing file? Yes.

Re: [Qemu-devel] [PATCH v5 06/45] Provide runtime Target page information

On Wed, Feb 25, 2015 at 04:51:29PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The migration code generally is built target-independent, however > there are a few places where knowing the target page size would > avoid artificially moving stuff into arch_init.

Re: [Qemu-devel] [PATCH v5 05/45] Create MigrationIncomingState

On Wed, Feb 25, 2015 at 04:51:28PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > There are currently lots of pieces of incoming migration state scattered > around, and postcopy is adding more, and it seems better to try and keep > it together. > > allocate MIS i

[Qemu-devel] [PATCH] Revert "timer: replace time() with QEMU_CLOCK_HOST"

This reverts commit 2ed1ebcf65edf6757d8904000889ce52cc0a9d1b as it breaks compile when configured with --enable-profiler: /home/alexey/p/qemu/vl.c:710:15: error: 'qemu_time' redeclared as different kind of symbol static time_t qemu_time(void) ^ In file included from /home/alexey/p

Re: [Qemu-devel] [RFC] introduce bitmap to bdrv_commit to trackdirtysector

On 2015-03-10 09:54:47, Fam Zheng wrote: > On Tue, 03/10 09:30, Zhang Haoyu wrote: > > > > On 2015-03-10 08:29:19, Fam Zheng wrote: > > > On Mon, 03/09 16:14, Zhang Haoyu wrote: > > > > Hi John, Vladimir > > > > We can using active block commit to implement incremental backup > > > > without gu

Re: [Qemu-devel] question about live migration with storage

On 2015-01-15 18:08:39, Paolo Bonzini wrote: > > On 15/01/2015 10:56, Zhang Haoyu wrote: > > I see, when waiting the completion of drive_mirror IO, the coroutine will be > > switched back to main-thread to poll and process other events, like qmp > > request, > > then after the IO completed, coro

Re: [Qemu-devel] [PATCH 0/3] fix pci related code typos

Cc: qemu-trivial On 03/10/2015 09:49 AM, Chen Fan wrote: Chen Fan (3): pcie_aer: fix typos in pcie_aer_inject_error comment aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register pci: fix several trivial typos in comment hw/pci/pcie_aer.c | 8 include/hw/pci

[Qemu-devel] [PATCH 3/3] pci: fix several trivial typos in comment

Signed-off-by: Chen Fan --- include/hw/pci/pci.h | 2 +- include/hw/pci/pcie_aer.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index bdee464..b82de15 100644 --- a/include/hw/pci/pci.h +++ b/include/hw/pci/pci.h @@ -137,7

[Qemu-devel] [PATCH 0/3] fix pci related code typos

Chen Fan (3): pcie_aer: fix typos in pcie_aer_inject_error comment aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register pci: fix several trivial typos in comment hw/pci/pcie_aer.c | 8 include/hw/pci/pci.h | 2 +- include/hw/pci/pcie_aer.h | 2 +- 3 files cha

[Qemu-devel] [PATCH 2/3] aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register

>From pcie spec, the bits attributes are RW1CS in Correctable Error Status Register, so this patch fix a wrong definition for PCI_ERR_COR_STATUS register with w1cmask type. Signed-off-by: Chen Fan --- hw/pci/pcie_aer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci/pc

[Qemu-devel] [PATCH 1/3] pcie_aer: fix typos in pcie_aer_inject_error comment

Refer to "PCI Express Base Spec3.0", this comments can't fit the description in spec, so we should fix them. Signed-off-by: Chen Fan --- hw/pci/pcie_aer.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/pci/pcie_aer.c b/hw/pci/pcie_aer.c index 1f4be16..7ca077a 100644

Re: [Qemu-devel] [RFC] introduce bitmap to bdrv_commit to trackdirty sector

On Tue, 03/10 09:30, Zhang Haoyu wrote: > > On 2015-03-10 08:29:19, Fam Zheng wrote: > > On Mon, 03/09 16:14, Zhang Haoyu wrote: > > > Hi John, Vladimir > > > We can using active block commit to implement incremental backup without > > > guest disruption, > > > e.g., > > > origin <= A <= B <= C

Re: [Qemu-devel] [RFC v4 0/9] pass aer error to guest for vfio device

On 03/10/2015 04:34 AM, Alex Williamson wrote: On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: For now, for vfio pci passthough devices when qemu receives an error from host aer report, there just terminate the guest, but usually user want to know what error occurred but stop the guest, so t

Re: [Qemu-devel] [RFC] introduce bitmap to bdrv_commit to trackdirty sector

On 2015-03-10 08:29:19, Fam Zheng wrote: > On Mon, 03/09 16:14, Zhang Haoyu wrote: > > Hi John, Vladimir > > We can using active block commit to implement incremental backup without > > guest disruption, > > e.g., > > origin <= A <= B <= C <= current BDS, > > a new external snapshot will be pro

Re: [Qemu-devel] [PATCH v5 04/45] Add qemu_get_counted_string to read a string prefixed by a count byte

On Wed, Feb 25, 2015 at 04:51:27PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > and use it in loadvm_state and ram_load. > > Signed-off-by: Dr. David Alan Gilbert Pure cleanup, no change to migration stream. Reviewed-by: David Gibson -- David Gibson

Re: [Qemu-devel] [PATCH v5 02/45] Split header writing out of qemu_save_state_begin

On Wed, Feb 25, 2015 at 04:51:25PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Split qemu_save_state_begin to: > qemu_save_state_header That writes the initial file header. > qemu_save_state_beginThat sets up devices and does the first >

Re: [Qemu-devel] [PATCH RFC] Implement GIC-500 from GICv3 family for arm64

On 2015/3/9 22:41, shlomo.pongr...@toganetworks.com wrote: > From: Shlomo Pongratz > > This patch is a first step toward 128 cores support for arm64. > > At first only 64 cores are supported for two reasons: > First the largest integer type has the size of 64 bits and modifying > essential data

Re: [Qemu-devel] [PATCH v5 01/45] Start documenting how postcopy works.

On Thu, Mar 05, 2015 at 09:21:39AM +, Dr. David Alan Gilbert wrote: > * David Gibson (da...@gibson.dropbear.id.au) wrote: > > On Wed, Feb 25, 2015 at 04:51:24PM +, Dr. David Alan Gilbert > (git) wrote: [snip] > > > +=== Enabling postcopy === > > > + > > > +To enable postcopy (prior to the s

[Qemu-devel] OVMF whitepaper released

http://people.redhat.com/~lersek/ovmf-whitepaper-c770f8c.txt (An official Red Hat whitepaper PDF edition, for graphical displays, is in the works. As time and technical hurdles allow, both the plain text and the PDF editions shall appear under too, replacing th

Re: [Qemu-devel] [RFC] introduce bitmap to bdrv_commit to track dirty sector

On Mon, 03/09 16:14, Zhang Haoyu wrote: > Hi John, Vladimir > We can using active block commit to implement incremental backup without > guest disruption, > e.g., > origin <= A <= B <= C <= current BDS, > a new external snapshot will be produced before every time backup, > we can migrate A, B, C

Re: [Qemu-devel] [PATCH 2/2] libxl: introduce gfx_passthru_kind

On 2015/3/9 18:17, Wei Liu wrote: On Mon, Mar 09, 2015 at 02:45:36PM +0800, Chen, Tiejun wrote: [...] +exit (1); +} +} else if (!xlu_cfg_get_string(config, "gfx_passthru", &buf, 0)) { +if (libxl_gfx_passthru_kind_from_string(buf, &b_info->u.hvm.

[Qemu-devel] [PATCH] tpm: Move memory initialization into realize function

From: Stefan Berger Move the memory initialization into the DeviceClass realize function due to isa_address_space crashing if called in the instance init function. A recent change must have changed the order in which structures are initialized so that this move is now necessary. Signed-off-by: S

Re: [Qemu-devel] Crash when using -daemonize

On 03/09/2015 05:34 PM, Christian Borntraeger wrote: Am 09.03.2015 um 22:03 schrieb Stefan Berger: Since an upgrade to Fedora 21, I get crashes with QEMU when using -daemonize. I noticed this since libvirt could not QMP probe QEMU. This is the command line used: x86_64-softmmu/qemu-system-x86

[Qemu-devel] Fix for incorrect SYSRET instruction implementation -- anyone looked at this yet?

I'm certain I'm sending this in plain text mode this time. According to my reading of the Intel documentation, the SYSRET instruction is supposed to force the RPL bits of the %ss register to 3 when returning to user mode. The actual sequence is: SS.Selector <-- (IA32_STAR[63:48]+8) OR 3; (* RPL

Re: [Qemu-devel] Fix for incorrect SYSRET instruction implementation -- anyone looked at this yet?

Of all the gin joints in all the towns in all the world, Stefan Weil had to walk into mine at 15:23:36 on Monday 09 March 2015 and say: > Hi Bill, > > sending text only e-mails might help. Usually git send-email is better > than using KMail or other mail software. You know, I thought I was send

Re: [Qemu-devel] [PATCH] ahci: map memory via device's address space instead of address_space_memory

On 02/26/2015 05:02 PM, Paolo Bonzini wrote: On 26/02/2015 22:31, Jordan Hargrave wrote: My OS initializes DMAR page tables and then enables the IOMMU translation. Then OS initializes AHCI driver. Writes VIRTUAL DMA to FIS registers. eg. FIS DMA address is 0x1 (maps to some hardware ph

[Qemu-devel] [RFC 2/2] macio: move unaligned DMA write code into separate pmac_dma_write() function

Similarly switch the macio IDE routines over to use the new function and tidy-up the remaining code as required. Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c | 267 include/hw/ppc/mac_dbdma.h |4 - 2 files changed, 124 insertion

[Qemu-devel] [RFC 0/2] macio: split out unaligned DMA access into separate functions

This patchset attempts to separate out the IDE/ATAPI logic from the unaligned DMA access logic for macio which provides the following benefits: 1) Reduced code complexity The existing macio IDE/ATAPI functions were becoming extremely difficult to follow through the various callbacks. By splitting

[Qemu-devel] [RFC 1/2] macio: move unaligned DMA read code into separate pmac_dma_read() function

This considerably helps simplify the complexity of the macio read routines and by switching macio CDROM accesses to use the new code, fixes the issue with the CDROM device being detected intermittently by Darwin/OS X. Signed-off-by: Mark Cave-Ayland --- hw/ide/macio.c | 252

Re: [Qemu-devel] Fix for incorrect SYSRET instruction implementation -- anyone looked at this yet?

Hi Bill, sending text only e-mails might help. Usually git send-email is better than using KMail or other mail software. Use tools like git gui to get a correct signature. Any optional personal comments should come directly after the line with ---. Could you please re-send your patch? Check it

[Qemu-devel] Fix for incorrect SYSRET instruction implementation -- anyone looked at this yet?

Nobody has commented on this yet. According to my reading of the Intel documentation, the SYSRET instruction is supposed to force the RPL bits of the %ss register to 3 when returning to user mode. The actual sequence is: SS.Selector <-- (IA32_STAR[63:48]+8) OR 3; (* RPL forced to 3 *) However,

Re: [Qemu-devel] Crash when using -daemonize

Am 09.03.2015 um 22:03 schrieb Stefan Berger: > Since an upgrade to Fedora 21, I get crashes with QEMU when using -daemonize. > I noticed this since libvirt could not QMP probe QEMU. > > This is the command line used: > > x86_64-softmmu/qemu-system-x86_64 -S -no-user-config -nodefaults -nographi

[Qemu-devel] Crash when using -daemonize

Since an upgrade to Fedora 21, I get crashes with QEMU when using -daemonize. I noticed this since libvirt could not QMP probe QEMU. This is the command line used: x86_64-softmmu/qemu-system-x86_64 -S -no-user-config -nodefaults -nographic -M none -pidfile /tmp/foo -daemonize Here's the back

[Qemu-devel] [PULL 5/7] target-i386: Move CPUX86State::cpuid_apic_id to X86CPU::apic_id

The field doesn't need to be inside CPUX86State, and it is not specific for the CPUID instruction, so move and rename it. Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Eduardo Habkost --- target-i386/cpu-qom.h | 1 + target-i386/cpu.c | 15 +++ target-i

[Qemu-devel] [PULL 7/7] target-i386: Require APIC ID to be explicitly set before CPU realize

On softmuu, instead of setting APIC ID automatically when creating a X86CPU, require the property to be set before realizing the object (which is already done by the CPU creation code on PC). Keep apic_id = 0 by default on *-user so it can simply create a new CPU object and realize it without extr

[Qemu-devel] [PULL 4/7] target-i386: Remove unused APIC ID default code

The existing apic_id = cpu_index code has no visible effect: the PC code already initializes the APIC ID according to the topology on pc_new_cpu(), and linux-user memcpy()s the CPU state (including cpuid_apic_id) on cpu_copy(). Remove the dead code and simply let APIC ID to to be 0 by default. Thi

[Qemu-devel] [PULL 3/7] target-i386: Eliminate unnecessary get_cpuid_vendor() function

The function was used in only two places. In one of them, the function made the code less readable by requiring temporary te[bcd]x variables. In the other one we can simply inline the existing code. Reviewed-by: Andreas Färber Signed-off-by: Eduardo Habkost --- target-i386/cpu.c | 20 ++

[Qemu-devel] [PULL 0/7] X86 patches

The following changes since commit 277263e1b320d759a760ba6c5ea75ec268f929e5: Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' into staging (2015-03-09 14:04:14 +) are available in the git repository at: https://github.com/ehabkost/qemu.git tags/x86-pull-request

[Qemu-devel] [PULL 6/7] target-i386: Move APIC ID compatibility code to pc.c

The APIC ID compatibility code is required only for PC, and now that x86_cpu_initfn() doesn't use x86_cpu_apic_id_from_index() anymore, that code can be moved to pc.c. Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Eduardo Habkost --- hw/i386/pc.c | 35 +

[Qemu-devel] [PULL 1/7] target-i386: Move topology.h to include/hw/i386

This will allow the PC code to use the header, and lets us eliminate the QEMU_INCLUDES hack inside tests/Makefile. Reviewed-by: Paolo Bonzini Reviewed-by: Andreas Färber Signed-off-by: Eduardo Habkost --- {target-i386 => include/hw/i386}/topology.h | 6 +++--- target-i386/cpu.c

[Qemu-devel] [PULL 2/7] target-i386: Simplify listflags() function

listflags() had lots of unnecessary complexity. Instead of printing to a buffer that will be immediately printed, simply call the printing function directly. Also, remove the fbits and flags arguments that were always set to the same value. Also, there's no need to list the flags in reverse order.

Re: [Qemu-devel] qemu crash in coroutine bdrv_co_do_rw

Am 06.03.2015 um 18:23 schrieb Stefan Hajnoczi: > On Thu, Feb 26, 2015 at 10:29:57AM +0100, Christian Borntraeger wrote: >> is this some know issue? Under heavy load with lots of dataplane devices I >> sometimes get a segfault in the bdrc_co_do_rw routine: >> >> #0 bdrv_co_do_rw (opaque=0x0) at /

Re: [Qemu-devel] [PATCH v2 7/8] qtest/ahci: add qcow2 support to ahci-test

On 03/09/2015 10:27 AM, Kevin Wolf wrote: Am 26.02.2015 um 00:06 hat John Snow geschrieben: This will enable the testing of high offsets without wasting a lot of disk space, and does not impact the previous tests. mkimg and mkqcow2 are added to libqos for other tests. Signed-off-by: John Sno

Re: [Qemu-devel] [RFC v4 0/9] pass aer error to guest for vfio device

On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: > For now, for vfio pci passthough devices when qemu receives > an error from host aer report, there just terminate the guest, > but usually user want to know what error occurred but stop the > guest, so this patches add aer capability support for

Re: [Qemu-devel] [RFC v4 8/9] vfio-pci: pass the aer error to guest

On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: > when the vfio device encounters an uncorrectable error in host, > the vfio_pci driver will signal the eventfd registered by this > vfio device, the results in the qemu eventfd handler getting > invoked. > > this patch is to pass the error to gue

Re: [Qemu-devel] [RFC v4 4/9] aer: impove pcie_aer_init to support vfio device

On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: > extend pcie_aer_init arguments to adjust vfio device. Some discussion of why vfio wants this would be useful. > Signed-off-by: Chen Fan > --- > hw/pci-bridge/ioh3420.c| 3 ++- > hw/pci-bridge/xio3130_downstream.c | 3 ++- > hw/pc

Re: [Qemu-devel] [RFC v4 6/9] vfio: add 'x-aer' option to disable aer capability

On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: > add 'x-aer' option to disable aer capability if user > want. I'm generally one to favor using the x- flag, but we need to figure out if we need to make this be a supported option or not. We also need to decide whether we should include your pre

Re: [Qemu-devel] [RFC v4 3/9] vfio: add pcie extanded capability support

On Mon, 2015-03-02 at 15:16 +0800, Chen Fan wrote: > For vfio pcie device, we could expose the extanded capability on s/extanded/extended/ > PCIE bus. in order to avoid config space broken, we introduce > a copy config for parsing extended caps. and rebuild the pcie > extended config space. > >

Re: [Qemu-devel] [PATCH 5/6] target-arm/kvm64: fix save/restore of SPSR regs

On Mon, Mar 09, 2015 at 10:31:19PM +0900, Peter Maydell wrote: > On 9 March 2015 at 21:56, Christoffer Dall > wrote: > > this function, however, is not used only when migration, but should > > generally cover the case where you want to synchronize QEMU's state into > > KVM's state, right? So whi

Re: [Qemu-devel] [PATCH 5/8] ioport: Remove unused functions

On 09/03/2015 18:30, Thomas Huth wrote: > The functions portio_list_destroy() and portio_list_del() > are not used anywhere, so let's remove them. > > Signed-off-by: Thomas Huth > Cc: Paolo Bonzini I think it's better to provide a complete API, mimicking memory_region_* as much as possible, s

Re: [Qemu-devel] [PATCH v2 0/4] scsi: Error reporting cleanups, realize()

On 09/03/2015 19:17, Markus Armbruster wrote: > Applies cleanly on master now, and passes make check with my "[PATCH > RFC 1/1] qtest: Add generic PCI device test" applied on top. > > v2: > - Rebase: PATCH 01 loses the spapr_vscsi.c hunk, because commit > 28b07e7 converted it to realize(). Co

Re: [Qemu-devel] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

On 03/09/2015 06:55 PM, Gerd Hoffmann wrote: On Mo, 2015-03-09 at 18:26 +0200, Marcel Apfelbaum wrote: On 03/09/2015 04:19 PM, Gerd Hoffmann wrote: Hi, My series is based on commit 09d219a. Try please on top of this commit. Ok, that works. Going to play with that now ;) Good luck! ...

Re: [Qemu-devel] [PATCH] pci: Convert pci_nic_init() to Error to avoid qdev_init()

Markus Armbruster writes: > qdev_init() is deprecated, and will be removed when its callers have > been weaned off it. > > Signed-off-by: Markus Armbruster > --- > Depends on my "[PATCH 00/10] pci: Partial conversion to realize", > which is in Michael's latest pull request, and on my "[PATCH v2

Re: [Qemu-devel] [PATCH] virtio-pci: Convert to realize()

Markus Armbruster writes: > Signed-off-by: Markus Armbruster > --- > Depends on my "[PATCH 00/10] pci: Partial conversion to realize", > which is in Michael's latest pull request. Applies cleanly to master now (commit 277263e).

Re: [Qemu-devel] [PATCH] macio: Convert to realize()

Alexander Graf writes: > On 27.02.15 13:43, Markus Armbruster wrote: >> Convert device models "macio-oldworld" and "macio-newworld". >> >> Signed-off-by: Markus Armbruster >> --- >> Depends on my "[PATCH 00/10] pci: Partial conversion to realize", >> which is in Michael's latest pull request. >

[Qemu-devel] [PATCH v2 1/4] scsi: Clean up duplicated error in legacy if=scsi code

Commit a818a4b changed scsi_bus_legacy_handle_cmdline() to report errors from scsi_bus_legacy_add_drive() with error_report() in addition to returning them. That's inappropriate. Two kinds of callers: 1. realize methods (devices "esp", "virtio-scsi-device" and "spapr-vscsi") The error obj

[Qemu-devel] [PATCH v2 4/4] scsi: Convert remaining PCI HBAs to realize()

These are "am53c974", "dc390", "lsi53c895a", "lsi53c810", "megasas", "megasas-gen2". Signed-off-by: Markus Armbruster Reviewed-by: Peter Crosthwaite --- hw/scsi/esp-pci.c| 30 +++--- hw/scsi/lsi53c895a.c | 14 +++--- hw/scsi/megasas.c| 14 +++---

[Qemu-devel] [PATCH v2 0/4] scsi: Error reporting cleanups, realize()

Applies cleanly on master now, and passes make check with my "[PATCH RFC 1/1] qtest: Add generic PCI device test" applied on top. v2: - Rebase: PATCH 01 loses the spapr_vscsi.c hunk, because commit 28b07e7 converted it to realize(). Commit message updated. PATCH 03 commit message updated to

[Qemu-devel] [PATCH v2 2/4] hw: Propagate errors through qdev_prop_set_drive()

Three kinds of callers: 1. On failure, report the error and abort Passing &error_abort does the job. No functional change. 2. On failure, report the error and exit() This is qdev_prop_set_drive_nofail(). Error reporting moves from qdev_prop_set_drive() to its caller. Because hiding

[Qemu-devel] [PATCH v2 3/4] scsi: Improve error reporting for invalid drive property

When setting "realized" fails, scsi_bus_legacy_add_drive() passes the error to qerror_report_err(), then returns an unspecific "Setting drive property failed" error, which is reported further up the call chain. Example: $ qemu-system-x86_64 -nodefaults -S -display none \ > -drive if=scsi,

  1   2   3   >