The 9pfs-proxy code is actually terrible: it does the same
things again and again, ignoring function arguments and
re-inventing the same values again, and a lot of code must
be consistent with each other.
In particular, lots of filesystem methods use common v9fs_request()
function and pass all met
Signed-off-by: Michael Tokarev
---
hw/9pfs/virtio-9p-proxy.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c
index aa9659a..1b62e2a 100644
--- a/hw/9pfs/virtio-9p-proxy.c
+++ b/hw/9pfs/virtio-9p-proxy.c
@@ -436,7 +4
From: Radim Krčmář
man gcc:
Warn about logical not used on the left hand side operand of a
comparison. This option does not warn if the RHS operand is of a
boolean type.
By preferring bool over int where sensible, but without modifying any
depending code, make GCC happy in cases like this
From: Gonglei
Coverity spot:
Function xen_pt_bar_offset_to_index() may return a negative
value (-1) which is used as an index to d->io_regions[] down
the line.
Let's pass index directly as an argument to
xen_pt_bar_reg_parse().
Signed-off-by: Gonglei
Acked-by: Stefano Stabellini
Signed-off-by
Signed-off-by: Michael Tokarev
---
hw/9pfs/virtio-9p-proxy.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/9pfs/virtio-9p-proxy.c b/hw/9pfs/virtio-9p-proxy.c
index aa9659a..1b62e2a 100644
--- a/hw/9pfs/virtio-9p-proxy.c
+++ b/hw/9pfs/virtio-9p-proxy.c
@@ -436,7 +4
From: Gonglei
The array length of s->real_device.io_regions[] is
"PCI_NUM_REGIONS - 1".
Signed-off-by: Gonglei
Acked-by: Stefano Stabellini
Signed-off-by: Michael Tokarev
---
hw/xen/xen_pt_config_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen_pt_config_
From: Stefan Berger
Signed-off-by: Stefan Berger
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Michael Tokarev
---
migration/qemu-file-buf.c | 4
1 file changed, 4 insertions(+)
diff --git a/migration/qemu-file-buf.c b/migration/qemu-file-buf.c
index e97e0bd..e56a8ad 100644
--- a/
From: Stefan Weil
* Remove trailing whitespace (fixes 9 errors from checkpatch.pl).
One comment line was longer than 80 characters, so wrap it
and fix a typo, too.
* Replace tabs by blanks (fixes 1 error).
Signed-off-by: Stefan Weil
Reviewed-by: Dr. David Alan Gilbert
Signed-off-by: Michae
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
hw/vfio/common.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 9db7d8d..84dca91 100644
--- a/hw/vfio/common.c
+++ b
This splits existing functions which expects any argument
into pairs, second being one which accepts va_list, to
be used later.
Signed-off-by: Michael Tokarev
---
fsdev/virtio-9p-marshal.c | 38 --
fsdev/virtio-9p-marshal.h | 6 ++
2 files changed, 34 ins
From: Stefan Weil
Warnings from the Sparse static analysis tool:
disas/microblaze.c:289:3: warning:
symbol 'opcodes' was not declared. Should it be static?
disas/microblaze.c:570:6: warning:
symbol 'register_prefix' was not declared. Should it be static?
disas/microblaze.c:571:6: warning:
sym
Public bug reported:
Upon entry to a target signal handler the function
process_pending_signals in linux-user/signal.c block the appropriate
host signals, but signals already received and queued by Qemu are not
blocked. If multiple signals arrive in quick succession this results
incorrect recursio
The 9pfs-proxy code is actually terrible: it does the same
things again and again, ignoring function arguments and
re-inventing the same values again, and a lot of code must
be consistent with each other.
In particular, lots of filesystem methods use common v9fs_request()
function and pass all met
From: Thomas Huth
Remove qemu_console_displaystate(), qemu_remove_kbd_event_handler(),
qemu_different_endianness_pixelformat() and cpkey(), since they are
completely unused.
Signed-off-by: Thomas Huth
Reviewed-by: Gerd Hoffmann
Signed-off-by: Michael Tokarev
---
include/ui/console.h | 3 ---
All functions which deal with v9fs_request() use `retval'
variable to hold result of the request (except some which
use this value for other purposes too), but 3 use different
name (ret or err). Rename these 3 for consistency.
There's no actual code changes.
Signed-off-by: Michael Tokarev
---
h
Signed-off-by: Michael Tokarev
---
hw/9pfs/virtio-9p-local.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c
index a183eee..d05c917 100644
--- a/hw/9pfs/virtio-9p-local.c
+++ b/hw/9pfs/virtio-9p-local.c
@@ -332,7 +332,6 @@ static ssize_t lo
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
hw/xtensa/sim.c| 2 +-
hw/xtensa/xtfpga.c | 10 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/xtensa/sim.c b/hw/xtensa/sim.c
index 37ea9ae..328d209 100644
From: Thomas Huth
This function is not used anymore, let's remove it.
Signed-off-by: Thomas Huth
Reviewed-by: Gerd Hoffmann
Signed-off-by: Michael Tokarev
---
ui/vnc-jobs.c | 13 -
ui/vnc-jobs.h | 1 -
2 files changed, 14 deletions(-)
diff --git a/ui/vnc-jobs.c b/ui/vnc-jobs.c
Consolidate all forward typedef declarations to rocker.h.
Signed-off-by: David Ahern
Acked-by: Scott Feldman
---
hw/net/rocker/rocker.c| 4 ++--
hw/net/rocker/rocker.h| 7 +++
hw/net/rocker/rocker_desc.c | 10 --
hw/net/rocker/rocker_desc.h | 4
hw/net/ro
On Fri, Mar 6, 2015 at 7:57 PM, Bandan Das wrote:
> Andrey Korolyov writes:
>
>> On Fri, Mar 6, 2015 at 1:14 AM, Andrey Korolyov wrote:
>>> Hello,
>>>
>>> recently I`ve got a couple of shiny new Intel 2620v2s for future
>>> replacement of the E5-2620v1, but I experienced relatively many events
>
This splits existing functions which expects any argument
into pairs, second being one which accepts va_list, to
be used later.
Signed-off-by: Michael Tokarev
---
fsdev/virtio-9p-marshal.c | 38 --
fsdev/virtio-9p-marshal.h | 6 ++
2 files changed, 34 ins
Signed-off-by: Michael Tokarev
---
qemu-options.hx | 24 +---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index ee4b223..303d13c 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -3195,12 +3195,30 @@ Set TB size.
ETEXI
From: Wang Xin
numero sign is the number sign key of Russian keyboard layout, we
get this key with 'shift + 3'. It's missing in current Russian keymap file,
this patch fixes it.
As number sign does not exsit in Russian keyboard layout[1][2], this
patch also removes the 'numbersign' from Russian k
This simplifies code in v9fs_request() a bit by replacing several
ifs with a common variable check and rearranging error/cleanup
code a bit.
Signet-off-by: Michael Tokarev
---
hw/9pfs/virtio-9p-proxy.c | 48 ---
1 file changed, 20 insertions(+), 28 del
From: Borislav Petkov
When requesting a size which cannot be read, the error message shows
a different address which is misleading to the user and it looks like
something's wrong with the address parsing. This is because the input
@addr variable is incremented in the memory dumping loop:
(qemu)
From: Gonglei
Signed-off-by: Gonglei
Signed-off-by: Michael Tokarev
---
hw/core/sysbus.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/core/sysbus.c b/hw/core/sysbus.c
index 84af593..b53c351 100644
--- a/hw/core/sysbus.c
+++ b/hw/core/sysbus.c
@@ -91,6 +91,8 @@ bool sysbus_has_irq(S
On 7 March 2015 at 04:06, Stefan Hajnoczi wrote:
> Hi Peter,
> You are rejecting pull requests that produce warnings under clang.
>
> clang 3.5.0 on Fedora 21 produces so much noise that it's extremely
> tedious and error-prone to try finding relevant new warnings.
>
> Are you using a different cl
From: "Gabriel L. Somlo"
Signed-off-by: Gabriel Somlo
Signed-off-by: Michael Tokarev
---
qemu-options.hx | 32 +---
1 file changed, 29 insertions(+), 3 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 85ca3ad..ee4b223 100644
--- a/qemu-options.hx
+
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
hw/tpm/tpm_passthrough.c | 12 ++--
tpm.c| 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/tpm/tpm_passthrough.c b/hw/tpm/tpm_passthrough
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
numa.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/numa.c b/numa.c
index 5634bf0..ffbec68 100644
--- a/numa.c
+++ b/numa.c
@@ -66,7 +66,7 @@ static void numa_no
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
hw/virtio/vhost-backend.c | 2 +-
net/vhost-user.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/vhost-backend.c b/hw/virtio/vhost-backend.c
ind
From: Cole Robinson
The value is called channel-type, not connection-type
Signed-off-by: Cole Robinson
Reviewed-by: Eric Blake
Signed-off-by: Michael Tokarev
---
qapi-schema.json | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qapi-schema.json b/qapi-schema.json
ind
From: Alberto Garcia
Signed-off-by: Alberto Garcia
Reviewed-by: John Snow
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
include/qapi/qmp/qerror.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.
07.03.2015 00:43, Michael Tokarev пишет:
> +retval = v9fs_marshal(&proxy->out_iovec, 1, PROXY_HDR_SZ, 0, fmt, ap);
This should be the new v9fs_vmarshal() ofcourse.
/mjt
This splits existing functions which expects any argument
into pairs, second being one which accepts va_list, to
be used later.
Signed-off-by: Michael Tokarev
---
fsdev/virtio-9p-marshal.c | 38 --
fsdev/virtio-9p-marshal.h | 6 ++
2 files changed, 34 ins
All filesystem methods that call common v9fs_request() function
also convert return value to errno. Move this conversion to the
common function and remove redundand error handling in methods.
I didn't remove local `retval' variable in simple functions to
keep the code consistent.
Also, proxy_tru
The 9pfs-proxy code is actually terrible: it does the same
things again and again, ignoring function arguments and
re-inventing the same values again, and a lot of code must
be consistent with each other.
In particular, lots of filesystem methods use common v9fs_request()
function and pass all met
Try to make the code a bit less ugly. First by moving
errno = -retval to a common place, and second by simplifying
common place a lot. What's left is v9fs_receive_response().
V3: merge several small patches into larger ones,
drop trivial stuff
Michael Tokarev (3):
9pfs-proxy: simplify err
From: Wang Xin
This patch adds missing cyrillic character 'numerosign' to the VNC
keysym table, it's needed by Russian keyboard. And I get the keysym from
'', the current keysym table in Qemu was generated from
it.
Signed-off-by: Wang xin
Signed-off-by: Gonglei
Signed-off-by: Michael Tokarev
From: Stefan Weil
gcc reports this warning with -Wclobbered:
util/oslib-posix.c: In function ‘os_mem_prealloc’:
util/oslib-posix.c:374:49: error: argument ‘memory’ might be clobbered by
‘longjmp’ or ‘vfork’ [-Werror=clobbered]
Fix this and simplify the code by using an existing macro.
Signed-
From: Markus Armbruster
The "fall through" added by the commit is clearly intentional. Mark
it so. Hushes up Coverity.
Signed-off-by: Markus Armbruster
Reviewed-by: Peter Crosthwaite
Signed-off-by: Michael Tokarev
---
hw/net/xilinx_ethlite.c | 1 +
1 file changed, 1 insertion(+)
diff --gi
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
block/archipelago.c | 6 +++---
hw/block/nand.c | 2 +-
qemu-img.c | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/archipelago.c b/block/archipelago
From: Gonglei
Signed-off-by: Gonglei
Signed-off-by: Michael Tokarev
---
hw/sparc/leon3.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/sparc/leon3.c b/hw/sparc/leon3.c
index 751392e..e41ec0b 100644
--- a/hw/sparc/leon3.c
+++ b/hw/sparc/leon3.c
@@ -186,6 +186,7 @@ static void leon3_gen
Signed-off-by: Michael Tokarev
Reviewed-by: Paolo Bonzini
Reviewed-by: Stefan Weil
---
hw/ppc/e500.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index 7e17d18..a8237a3 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -308,6 +308,7 @@ static int ppce500_loa
On Fri, Mar 06, 2015 at 03:08:29PM -0600, Stefan Hajnoczi wrote:
> You don't need to do anything different. Jeff will make sure your acked
> patches get merged instead of Kevin or me once this MAINTAINERS commit
> is in qemu.git/master.
Sounds sensible, thanks Jeff.
Rich.
--
Richard Jones, Vir
Hello All:
I have to leave Sunrus, the mail address (gang.c...@sunrus.com.cn) will
be closed soon (Sunrus will be closed soon because of money, I guess).
I change my new email address (xili_gchen_5...@hotmail.com) to continue
communicating. gang.chen.5...@gmail.com is still have effect, but it is
Hello All:
I have to leave Sunrus, the mail address (gang.c...@sunrus.com.cn) will
be closed soon (Sunrus will be closed soon because of money, I guess).
I change my new email address (xili_gchen_5...@hotmail.com) to continue
communicating. gang.chen.5...@gmail.com is still have effect, but it is
On Fri, Mar 06, 2015 at 03:08:29PM -0600, Stefan Hajnoczi wrote:
> On Fri, Mar 06, 2015 at 12:16:06PM -0500, Jeff Cody wrote:
> > The block layer maintainership is being split up into smaller, more
> > manageable pieces.
> >
> > I propose that I take over / assist with the following areas:
> >
>
On Fri, Mar 06, 2015 at 12:16:06PM -0500, Jeff Cody wrote:
> The block layer maintainership is being split up into smaller, more
> manageable pieces.
>
> I propose that I take over / assist with the following areas:
>
> * blockjobs
> * archipelago
> * curl
> * gluster
> * nfs
From: Paolo Bonzini
Coverity reports that s->chr is checked after put_packet dereferences it.
Move the check earlier, consistent with the code used for user-mode
emulation.
Signed-off-by: Paolo Bonzini
Signed-off-by: Michael Tokarev
---
gdbstub.c | 8 +---
1 file changed, 5 insertions(+),
From: Radim Krčmář
man gcc:
Warn if in a loop with constant number of iterations the compiler
detects undefined behavior in some statement during one or more of
the iterations.
Milkymist pfpu has no jump instructions, so checking for MICROCODE_WORDS
instructions should have kept us in boun
From: Cole Robinson
Signed-off-by: Cole Robinson
Signed-off-by: Michael Tokarev
---
tests/.gitignore | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/.gitignore b/tests/.gitignore
index e2e4957..0dcb618 100644
--- a/tests/.gitignore
+++ b/tests/.gitignore
@@ -5,6 +5,7 @@ check-qjso
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
hw/timer/a9gtimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/timer/a9gtimer.c b/hw/timer/a9gtimer.c
index 435142a..b087bbd 100644
--- a/hw/timer/a9gtimer.c
+++
From: Stefan Weil
This fixes a warning from smatch.
Signed-off-by: Stefan Weil
Signed-off-by: Michael Tokarev
---
hw/net/vhost_net.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index 4e3a061..ebfb6db 100644
--- a/hw/net/vhost_net
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
hw/dma/pl330.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/dma/pl330.c b/hw/dma/pl330.c
index 16cf77e..5be3df5 100644
--- a/hw/dma/pl330.c
+++ b/hw/dma/pl330.c
On Tue, Mar 03, 2015 at 11:50:33PM +0900, Peter Maydell wrote:
> On 28 February 2015 at 02:07, Stefan Hajnoczi wrote:
> > v2:
> > * Squash in Jiri's fix for rocker format string specifiers [Peter]
> > * Squash in Windows build fix [Peter]
> > * Both build fixes are described in "rocker: add new
From: Gonglei
Signed-off-by: Gonglei
Signed-off-by: Michael Tokarev
---
hw/lm32/milkymist.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/lm32/milkymist.c b/hw/lm32/milkymist.c
index 256c102..7f62261 100644
--- a/hw/lm32/milkymist.c
+++ b/hw/lm32/milkymist.c
@@ -155,6 +155,7 @@ milkym
From: Paolo Bonzini
Avoid truncation of a 64-bit long to a 32-bit int, and check for errno
(especially ERANGE).
Signed-off-by: Paolo Bonzini
Reviewed-by: Eric Blake
Signed-off-by: Michael Tokarev
---
util/cutils.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/util/
All filesystem methods that call common v9fs_request() function
also convert return value to errno. Move this conversion to the
common function and remove redundand error handling in methods.
I didn't remove local `retval' variable in simple functions to
keep the code consistent.
Also, proxy_tru
From: Alberto Garcia
Signed-off-by: Alberto Garcia
Reviewed-by: Eric Blake
Signed-off-by: Michael Tokarev
---
qmp-commands.hx | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qmp-commands.hx b/qmp-commands.hx
index a85d847..c12334a 100644
--- a/qmp-commands.hx
+++ b/q
All filesystem methods that call common v9fs_request() function
also convert return value to errno. Move this conversion to the
common function and remove redundand error handling in methods.
I didn't remove local `retval' variable in simple functions to
keep the code consistent.
Also, proxy_tru
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
hw/arm/digic_boards.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c
index 2a4b872..7114c36 100644
--- a/hw/arm/digic
I forgot to clean up the temp dir so the result is a
hmessy mix of 2 patchsets, one from trivial patches and
another this 9pfs code (actually it was me executing
git-format-patch twice in a row, once with a wrong
starting point and next with corrected starting point).
I'm sorry for this. Somehow
On Thu, Mar 05, 2015 at 03:46:13PM -0300, Eduardo Habkost wrote:
> On Thu, Mar 05, 2015 at 07:35:17PM +0100, Andreas Färber wrote:
> > Am 05.03.2015 um 14:43 schrieb Eduardo Habkost:
> > > On Tue, Mar 03, 2015 at 11:13:41PM -0300, Eduardo Habkost wrote:
> > >> The existing apic_id = cpu_index code
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
hw/scsi/vhost-scsi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c
index 618b0af..335f442 100644
--- a/hw/scsi/vhost-s
From: Gonglei
If ret = macio_initfn_ide() is less than 0, the timer_memory
will leak the memory it points to.
Signed-off-by: Gonglei
Signed-off-by: Michael Tokarev
---
hw/misc/macio/macio.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/misc/macio/macio.c b/hw/misc/m
All functions which deal with v9fs_request() use `retval'
variable to hold result of the request (except some which
use this value for other purposes too), but 3 use different
name (ret or err). Rename these 3 for consistency.
There's no actual code changes.
Signed-off-by: Michael Tokarev
---
h
From: Cole Robinson
Rather than track it in the toplevel gitignore
Signed-off-by: Cole Robinson
Signed-off-by: Michael Tokarev
---
.gitignore| 1 -
tests/qemu-iotests/.gitignore | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/.gitignore b/.gitignore
ind
From: Stefan Weil
Warnings from the Sparse static analysis tool:
disas/arm.c:1552:15: warning:
symbol 'last_type' was not declared. Should it be static?
disas/arm.c:1553:5: warning:
symbol 'last_mapping_sym' was not declared. Should it be static?
disas/arm.c:1554:9: warning:
symbol 'last_mapp
From: Gonglei
Signed-off-by: Gonglei
Signed-off-by: Michael Tokarev
---
block/nbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/nbd.c b/block/nbd.c
index 697c021..6634a69 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -274,6 +274,7 @@ static int nbd_open(BlockDriverState *bs, QDic
From: Gonglei
Signed-off-by: Gonglei
Reviewed-by: Markus Armbruster
Signed-off-by: Michael Tokarev
---
exec.c | 2 +-
hw/ide/pci.c | 2 +-
hw/microblaze/boot.c | 2 +-
migration/rdma.c | 2 +-
target-s390x/kvm.c | 2 +-
trace/control.c | 2 +-
6 files changed,
This simplifies code in v9fs_request() a bit by replacing several
ifs with a common variable check and rearranging error/cleanup
code a bit.
Signet-off-by: Michael Tokarev
---
hw/9pfs/virtio-9p-proxy.c | 48 ---
1 file changed, 20 insertions(+), 28 del
From: Stefan Weil
Warning from the Sparse static analysis tool:
disas/cris.c:1218:26: warning:
symbol 'cris_cond15s' was not declared. Should it be static?
Signed-off-by: Stefan Weil
Signed-off-by: Michael Tokarev
---
disas/cris.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
9pfs-proxy code is terrible. Not only it does lots of memory
allocations for every filesystem operation, the code is also
badly written.
For example, all filesystem operation methods call a common
function, v9fs_request(), and passes all info about method
arguments, including argument types, to i
From: Thomas Huth
The function is not used anymore, and thus can be deleted.
Signed-off-by: Thomas Huth
Acked-by: Stefano Stabellini
Signed-off-by: Michael Tokarev
---
include/hw/xen/xen.h | 1 -
xen-hvm-stub.c | 4
2 files changed, 5 deletions(-)
diff --git a/include/hw/xen/xen.
On 03/06/2015 08:04 AM, Alexander Graf wrote:
> Hi Richard,
>
> I've finally managed to check out why my e500v2 automated tests fail to
> run. Apparently they break because autotest wants to execute target code
> and runs into an illegal instruction while doing that:
>
> Program received signal S
Hi Peter,
You are rejecting pull requests that produce warnings under clang.
clang 3.5.0 on Fedora 21 produces so much noise that it's extremely
tedious and error-prone to try finding relevant new warnings.
Are you using a different clang version which produces fewer warnings?
Is anyone working
Signed-off-by: Andrew Jones
---
hw/display/vga.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/display/vga.c b/hw/display/vga.c
index c8c49abc6e8ba..2b74eb8e96462 100644
--- a/hw/display/vga.c
+++ b/hw/display/vga.c
@@ -2135,6 +2135,7 @@ void vga_common_init(VGACommonState *s, Object *ob
Signed-off-by: Andrew Jones
---
kvm-all.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kvm-all.c b/kvm-all.c
index 507fa7204e062..924b4a0bec21c 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -305,6 +305,9 @@ static int kvm_mem_flags(MemoryRegion *mr)
if (readonly && kvm_readonly_mem_all
Add an incoherent cache flag, which indicates the region
needs explicit cache maintenance.
Signed-off-by: Andrew Jones
---
include/exec/memory.h | 23 +++
memory.c | 15 +++
2 files changed, 38 insertions(+)
diff --git a/include/exec/memory.h b/inclu
Add a function that flushes the cache to PoC. We need a new
function because __builtin___clear_cache only flushes to
PoU. Call this function each time an address in a memory
region that has been flagged as having an incoherent cache
is written. For starters we only implement it for ARM. Most
other
On 06-03-2015 14:19, Stefan Hajnoczi wrote:
On Wed, Feb 25, 2015 at 09:32:18PM -0300, Christopher Pereira wrote:
Does qemu reopen files on a 'cont' command?
When working with images on a gluster volume, file descriptors may get into
a bad state because of network timeouts, remounting a share, e
Add support for the new KVM_MEM_INCOHERENT flag, and flag
appropriate memory. (Only flags vram for now.)
Patch 6/6 doesn't appear to be complete. While the VGA output is
99% corruption free, it's not perfect, so it's missing flushes
somewhere...
Andrew Jones (6):
memory: add incoherent cache f
Currently kvm_mem_flags just translates bools to bits, let's
make it also determine the bools first. This avoids its parameter
list growing each time we add a flag.
Signed-off-by: Andrew Jones
---
Posted this, as it makes sense without this series.
http://lists.gnu.org/archive/html/qemu-devel/201
Add the kvm_*_incoherent_memory_regions calls to arm's
kvm_arch_vcpu_ioctl_run and implement the corresponding
arch flush/invalidate functions.
Signed-off-by: Andrew Jones
---
arch/arm/include/uapi/asm/kvm.h | 1 +
arch/arm/kvm/arm.c| 4 +++
arch/arm/kvm/mmu.c
kvm_arch_flush_incoherent makes things too slow, and we don't
need it. Userspace can flush for us, as the necessary cache
maintenance instruction is not (necessarily) privileged.
Signed-off-by: Andrew Jones
---
arch/arm/kvm/mmu.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/arch/arm
Add two new memslot functions to the API
kvm_flush_incoherent_memory_regions
flush all KVM_MEM_INCOHERENT memslot addresses
kvm_invalidate_incoherent_memory_regions
invalidate all KVM_MEM_INCOHERENT memslot addresses
Signed-off-by: Andrew Jones
---
include/linux/kvm_host.h | 14 +++
Should do a proper update-linux-headers.sh update.
Signed-off-by: Andrew Jones
---
linux-headers/linux/kvm.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/linux-headers/linux/kvm.h b/linux-headers/linux/kvm.h
index 12045a11c036b..d04e2d781c43b 100644
--- a/linux-headers/linux/kvm.h
+++ b/l
Userspace flags memory regions as incoherent and kvm flushes/
invalidates those regions on entry/exit from userspace.
Result before patch 6/6: restores coherency, way t sloow
Result with patch 6/6: fast again - well, we removed the code...
Andrew Jones (6):
kvm: promote KVM_MEMSLO
Also support only invalidating, rather than always invalidate+clear.
Signed-off-by: Andrew Jones
---
arch/arm/include/asm/kvm_mmu.h | 7 +--
arch/arm/kvm/mmu.c | 2 +-
arch/arm64/include/asm/kvm_mmu.h | 7 +--
3 files changed, 11 insertions(+), 5 deletions(-)
diff --git
Remove the vcpu parameter. We can do this by doing the same
query in the caller of __coherent_cache_guest_page, and then
folding the result into its ipa_uncached parameter, which we
rename to need_flush.
A later patch will add a new caller for __coherent_cache_guest_page
that does not have a vcpu
Signed-off-by: Andrew Jones
---
arch/arm/kvm/mmu.c | 9 +++--
include/linux/kvm_host.h | 1 -
include/uapi/linux/kvm.h | 1 +
3 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c
index bcc1b3ad2adce..a806e8cecc01b 100644
--- a/arch/arm/k
In reply to this message I'll send two series' one for KVM and
one for QEMU. The two series' are their respective component
complements, and attempt to implement cache coherency for arm
guests using emulated devices, where the emulator (qemu) uses
cached memory for the device memory, but the guest
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
> On 2015/3/5 21:31, Dr. David Alan Gilbert (git) wrote:
> >From: "Dr. David Alan Gilbert"
>
> Hi Dave,
>
> >
> >Hi,
> > I'm getting COLO running on a couple of our machines here
> >and wanted to see what was actually going on, so I merge
On 03/06/2015 12:40 PM, Igor Mammedov wrote:
On Thu, 5 Mar 2015 16:55:02 +0200
Marcel Apfelbaum wrote:
Add encoding for ACPI DefIndex Opcode.
Signed-off-by: Marcel Apfelbaum
---
hw/acpi/aml-build.c | 10 ++
include/hw/acpi/aml-build.h | 1 +
2 files changed, 11 insertio
On Fri, 6 Mar 2015, Alexander Graf wrote:
> >> And lo and behold, I really couldn't find any reference to mfocrf in the
> >> e500v2 spec.
> >
> > Do real e500 processors trap on this operation as well?
>
> The illegal instruction I posted about above was when running qemu
> *on* e500v2, becau
> Am 06.03.2015 um 18:20 schrieb Maciej W. Rozycki :
>
>> On Fri, 6 Mar 2015, Alexander Graf wrote:
>>
>> I've finally managed to check out why my e500v2 automated tests fail to
>> run. Apparently they break because autotest wants to execute target code
>> and runs into an illegal instruction
On Thu, Feb 26, 2015 at 10:29:57AM +0100, Christian Borntraeger wrote:
> is this some know issue? Under heavy load with lots of dataplane devices I
> sometimes get a segfault in the bdrc_co_do_rw routine:
>
> #0 bdrv_co_do_rw (opaque=0x0) at /home/cborntra/REPOS/qemu/block.c:4791
> 4791 if
On Fri, 6 Mar 2015, Alexander Graf wrote:
> I've finally managed to check out why my e500v2 automated tests fail to
> run. Apparently they break because autotest wants to execute target code
> and runs into an illegal instruction while doing that:
>
> Program received signal SIGILL, Illegal instr
On Wed, Feb 25, 2015 at 09:32:18PM -0300, Christopher Pereira wrote:
> Does qemu reopen files on a 'cont' command?
>
> When working with images on a gluster volume, file descriptors may get into
> a bad state because of network timeouts, remounting a share, etc...and
> reinitializing file descript
1 - 100 of 180 matches
Mail list logo
