Fix up comment to match virtio 1.0 logic:
virtio_blk_outhdr isn't the first elements anymore,
the only requirement is that it comes first in
the s/g list.
Signed-off-by: Michael S. Tsirkin
---
include/uapi/linux/virtio_blk.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
Now that QEmu reuses linux virtio headers, we noticed
a typo in the exported virtio block header. Fix it up.
Signed-off-by: Michael S. Tsirkin
---
include/uapi/linux/virtio_blk.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/uapi/linux/virtio_blk.h b/include/uapi/li
Now that QEmu reuses linux virtio headers, we noticed
a typo in the exported virtio block header. Fix it up.
I'd like these merged for 4.0 so that Qemu 2.3 can
alredy get it right.
Michael S. Tsirkin (2):
virtio_blk: typo fix
virtio_blk: fix comment for virtio 1.0
include/uapi/linux/virtio_
This reverts commit 5b79b1cadd3e565b6d1a5ba59764bd47af58b271 to avoid
double-registration of types:
Registering `POWER5+-powerpc64-cpu' which already exists
Taking the textual description of a CPU type as part of a new type name
is plain wrong, and so is unconditionally registering a new type h
On 2/28/15 13:20, Chen Gang S wrote:
>>> diff --git a/target-tilegx/helper.h b/target-tilegx/helper.h
>>> >> new file mode 100644
>>> >> index 000..e69de29
>> >
>> > Is this empty file actually included from somewhere in this patch?
>> >
> Yes, it is for future use, I guess, at present, we ca
On 2/28/15 01:36, Andreas Färber wrote:
>> +static void tilegx_cpu_class_init(ObjectClass *oc, void *data)
>> > +{
>> > +DeviceClass *dc = DEVICE_CLASS(oc);
>> > +CPUClass *cc = CPU_CLASS(oc);
>> > +TilegxCPUClass *mcc = TILEGX_CPU_CLASS(oc);
>> > +
>> > +mcc->parent_realize = dc->r
On Fri, Feb 27, 2015 at 07:40:26PM +0100, Paolo Bonzini wrote:
>
>
> On 19/02/2015 08:48, Michael S. Tsirkin wrote:
> > V=1 should show what's going on, it's not nice
> > to silence things unconditionally.
> >
> > Signed-off-by: Michael S. Tsirkin
> > ---
> > Makefile | 4 ++--
> > 1 file chan
This fixes a warning from smatch.
Signed-off-by: Stefan Weil
---
hw/net/vhost_net.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index 4e3a061..ebfb6db 100644
--- a/hw/net/vhost_net.c
+++ b/hw/net/vhost_net.c
@@ -56,7 +56,7 @@ sta
The current code won't compile on 32 bit hosts because there are lots
of type casts between pointers and 64 bit integers.
Fix some of them.
Signed-off-by: Stefan Weil
---
migration/rdma.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/migration/r
* Remove trailing whitespace (fixes 9 errors from checkpatch.pl).
One comment line was longer than 80 characters, so wrap it
and fix a typo, too.
* Replace tabs by blanks (fixes 1 error).
Signed-off-by: Stefan Weil
---
My editor automatically removes trailing whitespace, so before fixing cod
Obviously that code was never before compiled on 32 bit hosts.
The RDMA API uses lots of uint64_t values and the code casts them
to and from pointers.
I tried to fix the compilation but did not run any runtime tests.
I think the first two patches are trivial, but the third one might
not be trivia
Fix type casts between pointers and 64 bit integers.
Now 32 bit builds are possible again.
Signed-off-by: Stefan Weil
---
migration/rdma.c | 57 +-
1 file changed, 31 insertions(+), 26 deletions(-)
diff --git a/migration/rdma.c b/migration/r
Am 28.02.2015 um 07:47 schrieb Fam Zheng:
Hello, everyone
I'm glad to announce the fresh Patchew server deployment:
http://qemu.patchew.org/
The mission of this project is to help identify obvious defects (coding style,
compiling, etc.) of posted patches.
Follow the green "passed" or red
Am 28.02.2015 um 17:40 schrieb Paolo Bonzini:
On 28/02/2015 11:13, Michael Tokarev wrote:
28.02.2015 13:08, arei.gong...@huawei.com пишет:
From: Gonglei
Signed-off-by: Gonglei
---
v2: fix compilation complaint. (mjt)
---
hw/ppc/e500.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/
On 28/02/2015 11:13, Michael Tokarev wrote:
> 28.02.2015 13:08, arei.gong...@huawei.com пишет:
>> From: Gonglei
>>
>> Signed-off-by: Gonglei
>> ---
>> v2: fix compilation complaint. (mjt)
>> ---
>> hw/ppc/e500.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/ppc/e500.c b/hw/p
Hello Michael,
here are some suggestions / thoughts for the QEMU website.
* http://wiki.qemu.org/Main_Pagedoes not pass the W3C validator, see
http://validator.w3.org/check?uri=http%3A%2F%2Fwiki.qemu.org.
They can be easily fixed, but not by normal wiki users.
* It tracks users (g+ image
htt
Hi,
I think they was already reported some month ago,
and a patch was submitted to the mailing list (but waiting that memory unplug
was merged before apply it)
http://lists.gnu.org/archive/html/qemu-devel/2014-11/msg02362.html
- Mail original -
De: "Luiz Capitulino"
À: "qemu-devel
28.02.2015 13:18, Gonglei wrote:
> On 2015/2/28 18:13, Michael Tokarev wrote:
[]
>> How about this?
>>
> It's ok on function, but seems oddly, isn't it?
I don't see anything odd in it. The `filename' variable is only
used as an argument for load_device_tree() function and is not used
anywhwere el
On 2015/2/28 18:13, Michael Tokarev wrote:
> 28.02.2015 13:08, arei.gong...@huawei.com пишет:
>> From: Gonglei
>>
>> Signed-off-by: Gonglei
>> ---
>> v2: fix compilation complaint. (mjt)
>> ---
>> hw/ppc/e500.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/ppc/e500.c b/hw/ppc/
On 2015/2/28 18:18, Michael Tokarev wrote:
> 28.02.2015 12:59, Gonglei wrote:
>> On 2015/2/28 17:52, Michael Tokarev wrote:
>>> This patch does not apply to current tree.
>>>
>> You meant this one should be accepted by arm tree?
>
> Nope. I mean this patch does not apply to my tree. I found the
>
28.02.2015 12:59, Gonglei wrote:
> On 2015/2/28 17:52, Michael Tokarev wrote:
>> This patch does not apply to current tree.
>>
> You meant this one should be accepted by arm tree?
Nope. I mean this patch does not apply to my tree. I found the
problem -- it is because of "Remove superfluous '\n' a
28.02.2015 13:08, arei.gong...@huawei.com пишет:
> From: Gonglei
>
> Signed-off-by: Gonglei
> ---
> v2: fix compilation complaint. (mjt)
> ---
> hw/ppc/e500.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
> index 7e17d18..c060b50 100644
> --- a/hw/ppc
From: Gonglei
Signed-off-by: Gonglei
---
v2: fix compilation complaint. (mjt)
---
hw/ppc/e500.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
index 7e17d18..c060b50 100644
--- a/hw/ppc/e500.c
+++ b/hw/ppc/e500.c
@@ -309,8 +309,10 @@ static int ppce500_load_
On 2015/2/28 17:54, Michael Tokarev wrote:
> 27.02.2015 10:50, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> All those defects are spotted by Coverity, which
>> classed in high impact outstanding defects.
>> Reports come from scan.coverity.com for Qemu.
>>
>> Cc: Paolo Bonzini
>> Cc: Mark
On 2015/2/28 17:52, Michael Tokarev wrote:
> This patch does not apply to current tree.
>
You meant this one should be accepted by arm tree?
Regards,
-Gonglei
On 2015/2/28 17:41, Michael Tokarev wrote:
> 27.02.2015 10:50, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> Signed-off-by: Gonglei
>> ---
>> hw/ppc/e500.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
>> index 7e17d18..38203a6 100644
>> --- a/
Applied both to -trivial, thank you!
/mjt
27.02.2015 19:33, Eric Blake wrote:
> On 02/27/2015 08:21 AM, Cole Robinson wrote:
>> Rather than track it in the toplevel gitignore
>>
>> Signed-off-by: Cole Robinson
>> ---
>> .gitignore| 1 -
>> tests/qemu-iotests/.gitignore | 1 +
>> 2 files changed, 1 insertion(+), 1 dele
27.02.2015 10:50, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> All those defects are spotted by Coverity, which
> classed in high impact outstanding defects.
> Reports come from scan.coverity.com for Qemu.
>
> Cc: Paolo Bonzini
> Cc: Markus Armbruster
> Cc: qemu-triv...@nongnu.org
>
> G
This patch does not apply to current tree.
Thanks,
/mjt
27.02.2015 10:50, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> Signed-off-by: Gonglei
> ---
> hw/9pfs/virtio-9p-local.c | 10 ++
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/hw/9pfs/virtio-9p-local.c b/hw/9pfs/virtio-9p-local.c
> index a183eee..bcad4e0 10064
27.02.2015 10:50, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> Signed-off-by: Gonglei
> ---
> hw/ppc/e500.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ppc/e500.c b/hw/ppc/e500.c
> index 7e17d18..38203a6 100644
> --- a/hw/ppc/e500.c
> +++ b/hw/ppc/e500.c
> @@ -542,6 +542,
19.02.2015 13:25, Dr. David Alan Gilbert wrote:
> * Michael Tokarev (m...@tls.msk.ru) wrote:
>> Do not check for rdma->host being empty twice. This removes a large
>> "if" block, so code indentation is changed. While at it, remove an
>> ugly goto from the loop, replacing it with a cleaner if logi
28.02.2015 11:33, arei.gong...@huawei.com wrote:
> From: Wang Xin
>
> Add the keysym and keycode of 'numerosign' in Russian keyboard layout
> to VNC keysyms table and keymap.
>
> v2->v1:
> Remove the key 'numbersign' from Russian keymap as it is not exsit
> in Russian keyboard layout.
>
> Wan
Applied to -trivial, thank you!
/mjt
26.02.2015 16:28, Thomas Huth wrote:
> There are quite a lot of completely unused functions scattered
> around in the QEMU sources - here are some patches to remove at
> least some of them.
>
> I've limited the patches now to the ones which have been ack'ed
> by the corresponding subsystem maintai
On Sat, Feb 28, 2015 at 12:00 AM, Michael Roth
wrote:
>
> I just pushed a patch here that I'm hoping will fix the non-PCI cases. Can
> you give it a spin and let me know?
>
> https://github.com/mdroth/qemu/commit/d91b0c6d6f794292e384cf129368aaae90294f5b
I can successfully do CPU hotplug and unplu
19.02.2015 20:12, Thomas Huth wrote:
> There are quite a lot of completely unused functions scattered
> around in the QEMU sources - here are some patches to remove at
> least some of them.
Applied series to -trivial, thank you!
/mjt
25.02.2015 07:22, arei.gong...@huawei.com wrote:
> From: Gonglei
>
> v2 -> v1:
> - remove superfluous "" in patch 3. (Michael Tokarev)
> - move qemu-img.c hunk from patch 5 to patch 1. (Markus)
> - add 'R-by' tag for this patch series.
>
> Yestoday, I found that some files have superflous '\n
qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP. It should not be used
elsewhere. Replace by error_report_err() in serial_pci_init() and
multi_serial_pci_init().
Signed-off-by: zhanghailiang
---
hw/char/serial-pci.c | 7 ++-
1 file c
qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP. It should not be used
elsewhere. Replace by error_report_err() in qemu_pci_hot_add_nic().
Signed-off-by: zhanghailiang
---
hw/pci/pci-hotplug-old.c | 3 +--
1 file changed, 1 insertion(+),
qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP. It should not be used
elsewhere. Replace by error_report_err() in qdev_init() and
device_post_init().
Signed-off-by: zhanghailiang
---
hw/core/qdev.c | 6 ++
1 file changed, 2 insertio
Signed-off-by: zhanghailiang
---
savevm.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index ce2b6a2..c4f8c39 100644
--- a/savevm.c
+++ b/savevm.c
@@ -932,8 +932,7 @@ int qemu_loadvm_state(QEMUFile *f)
int ret;
if (qemu_savevm_state_blocked
Hi,
I have noticed Markus's previous patchset
"Clean up around error_get_pretty(), qerror_report_err()".
This is another patch series trying to do the same thing.
I'm not sure if he has missed this places or these modifies are false.
So, please review...
Thanks.
zhanghailiang (5):
serial-p
qerror_report_err() is a transitional interface to help with
converting existing monitor commands to QMP. It should not be used
elsewhere. Replace by error_report_err() in assigned_initfn().
Signed-off-by: zhanghailiang
---
hw/i386/kvm/pci-assign.c | 3 +--
1 file changed, 1 insertion(+), 2 de
Applied to -trivial, thank you!
/mjt
From: Haifeng Gao
Currently, vhost user nic doesn't support non msi guests(like pxe stage) by
default.
Vhost user nic can't fall back to qemu like normal vhost net nic does. So we
should
enable it for non msi guests.
Signed-off-by: Haifeng Gao
---
net/vhost-user.c | 16 +++-
1 fi
Applied to -trivial, thank you!
Markus, should I add your Reviewed-By (or Acked-By)?
/mjt
Applied to -trivial, thank you!
/mjt
On Sat, Feb 28, 2015 at 3:59 AM, Andreas Färber wrote:
> Am 27.02.2015 um 02:48 schrieb Alistair Francis:
>> Use the DeviceClass realize() and init() instead of
>> the deprecated SysBusDevice init().
>>
>> Signed-off-by: Alistair Francis
>> Reviewed-by: Peter Crosthwaite
>
> Thanks, applied to q
From: Wang Xin
numero sign is the number sign key of Russian keyboard layout, we
get this key with press 'shift + 3'. It's missing in current
Russian keymap file, this patch fix it.
As number sign is not exsit in Russian keyboard layout[1][2], this
patch also remove the 'numbersign' from Russian
From: Wang Xin
This patch adds missing cyrillic characters 'numerosign' to the VNC
keysym table, it's need by Russian keyboard. And I get the keysym from
'', the current keysym table in Qemu was generated from
it.
Signed-off-by: Wang xin
Signed-off-by: Gonglei
---
ui/vnc_keysym.h | 1 +
1 fil
From: Wang Xin
Add the keysym and keycode of 'numerosign' in Russian keyboard layout
to VNC keysyms table and keymap.
v2->v1:
Remove the key 'numbersign' from Russian keymap as it is not exsit
in Russian keyboard layout.
Wang Xin (2):
qemu-char: add cyrillic characters 'numerosign' to VNC k
53 matches
Mail list logo
