Re: [Qemu-devel] [PATCH 6/6 v3] linux-user/syscall.c: Switch all macros which are not defined in tilegx

2015-02-20 Thread Chen Gang S
On 2/21/15 11:55, Chris Metcalf wrote: > On 2/19/2015 7:07 PM, Chen Gang S wrote: >> +#ifdef TARGET_NR_chown /* not on tilegx */ > > I would omit all these comments. The same will be true for arm64, > microblaze, or any other kernel architecture submitted after the tile > architecture went in.

Re: [Qemu-devel] [PATCH] target-tilegx: Finish decoding the first TB block.

2015-02-20 Thread Chen Gang S
On 2/21/15 11:05, Chen Gang S wrote: > At present finish decoding the first TB block: _start. Always let y1 and > x1 pipe at the last which may content jump instructions. > > The related disassembly code is below which is the same as the objdump: > > y0: 500bfdb4 move r52, r54 > y2:

Re: [Qemu-devel] [PATCH 6/6 v3] linux-user/syscall.c: Switch all macros which are not defined in tilegx

2015-02-20 Thread Chris Metcalf
On 2/19/2015 7:07 PM, Chen Gang S wrote: +#ifdef TARGET_NR_chown /* not on tilegx */ I would omit all these comments. The same will be true for arm64, microblaze, or any other kernel architecture submitted after the tile architecture went in. -- Chris Metcalf, EZChip Semiconductor http://www

Re: [Qemu-devel] unable to set SATA serial with a spaces

2015-02-20 Thread Alan Latteri
The left padding is important and necessary to keep for my particular application. This is broken in libvirt, but works fine with direct Qemu invocation. Thank you for the help. Alan > On Feb 20, 2015, at 1:28 AM, Markus Armbruster wrote: > > Alan Latteri mailto:a...@instinctual.tv>> wri

[Qemu-devel] [PATCH] target-tilegx: Finish decoding the first TB block.

2015-02-20 Thread Chen Gang S
At present finish decoding the first TB block: _start. Always let y1 and x1 pipe at the last which may content jump instructions. The related disassembly code is below which is the same as the objdump: y0: 500bfdb4 move r52, r54 y2: 02080760 ld r1, r54 y1: 1c064000

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Peter Maydell
On 21 February 2015 at 02:25, Paolo Bonzini wrote: > I honestly don't know which versions are supported. 10.5 was released > in 2007 and it is enough for Darwin/PPC, so it's probably okay. Yes, I think 10.5 is the earliest we currently claim to care about. (In practice I'm not sure when anybody

Re: [Qemu-devel] [PATCH RFC v3 05/14] block: add meta bitmaps

2015-02-20 Thread John Snow
On 02/19/2015 06:43 AM, Vladimir Sementsov-Ogievskiy wrote: On 19.02.2015 02:45, John Snow wrote: On 02/18/2015 09:00 AM, Vladimir Sementsov-Ogievskiy wrote: Meta bitmap is a 'dirty bitmap' for the BdrvDirtyBitmap. It tracks changes (set/unset) of this BdrvDirtyBitmap. It is needed for live

Re: [Qemu-devel] [PATCH v14 19/19] docs: incremental backup documentation

2015-02-20 Thread John Snow
On 02/20/2015 06:55 PM, Eric Blake wrote: On 02/20/2015 04:07 PM, John Snow wrote: Signed-off-by: John Snow --- docs/bitmaps.md | 253 1 file changed, 253 insertions(+) create mode 100644 docs/bitmaps.md diff --git a/docs/bitmaps.

Re: [Qemu-devel] [PATCH v14 19/19] docs: incremental backup documentation

2015-02-20 Thread Eric Blake
On 02/20/2015 04:07 PM, John Snow wrote: > Signed-off-by: John Snow > --- > docs/bitmaps.md | 253 > > 1 file changed, 253 insertions(+) > create mode 100644 docs/bitmaps.md > > diff --git a/docs/bitmaps.md b/docs/bitmaps.md > new file m

[Qemu-devel] [PATCH v14 19/19] docs: incremental backup documentation

2015-02-20 Thread John Snow
Signed-off-by: John Snow --- docs/bitmaps.md | 253 1 file changed, 253 insertions(+) create mode 100644 docs/bitmaps.md diff --git a/docs/bitmaps.md b/docs/bitmaps.md new file mode 100644 index 000..7cda146 --- /dev/null +++ b/docs/b

[Qemu-devel] [PATCH v14 16/19] iotests: add transactional incremental backup test

2015-02-20 Thread John Snow
Reviewed-by: Max Reitz Signed-off-by: John Snow --- tests/qemu-iotests/112 | 49 ++ tests/qemu-iotests/112.out | 4 ++-- 2 files changed, 51 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/112 b/tests/qemu-iotests/112 index da8f0e0.

[Qemu-devel] [PATCH v14 18/19] block: Resize bitmaps on bdrv_truncate

2015-02-20 Thread John Snow
Signed-off-by: John Snow --- block.c| 20 include/block/block.h | 1 + include/qemu/hbitmap.h | 10 ++ util/hbitmap.c | 47 +++ 4 files changed, 78 insertions(+) diff --git a/block.c b/block.c inde

[Qemu-devel] [PATCH v14 17/19] iotests: add incremental backup failure recovery test

2015-02-20 Thread John Snow
To test the failure case, we modify iotests.py to allow us to specify that we'd like to allow failures when we wait for block job events. Reviewed-by: Max Reitz Signed-off-by: John Snow --- tests/qemu-iotests/112| 57 ++- tests/qemu-iotests/112.ou

[Qemu-devel] [PATCH v14 07/19] block: Add bitmap successors

2015-02-20 Thread John Snow
A bitmap successor is an anonymous BdrvDirtyBitmap that is intended to be created just prior to a sensitive operation (e.g. Incremental Backup) that can either succeed or fail, but during the course of which we still want a bitmap tracking writes. On creating a successor, we "freeze" the parent bi

[Qemu-devel] [PATCH v14 15/19] iotests: add simple incremental backup case

2015-02-20 Thread John Snow
Reviewed-by: Max Reitz Signed-off-by: John Snow --- tests/qemu-iotests/112 | 122 + tests/qemu-iotests/112.out | 4 +- 2 files changed, 124 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/112 b/tests/qemu-iotests/112 index 7985cd1.

[Qemu-devel] [PATCH v14 06/19] qmp: Add block-dirty-bitmap-enable and block-dirty-bitmap-disable

2015-02-20 Thread John Snow
This allows to put the dirty bitmap into a disabled state where it is read only. A disabled bitmap will ignore any attempts to set or reset any of its bits, but can otherwise be renamed, deleted, or re-enabled. It will be used before backup or writing to persistent file. Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v14 10/19] qapi: Add transaction support to block-dirty-bitmap operations

2015-02-20 Thread John Snow
This adds four qmp commands to transactions. Users can stop a dirty bitmap, start backup of it, and start another dirty bitmap atomically, so that the dirty bitmap is tracked incrementally and we don't miss any write. For starting a new incremental backup chain, users can also chain together a bi

[Qemu-devel] [PATCH v14 11/19] qmp: Add dirty bitmap status fields in query-block

2015-02-20 Thread John Snow
Adds the "disabled" and "frozen" status booleans. Signed-off-by: Fam Zheng Signed-off-by: John Snow Reviewed-by: Max Reitz --- block.c | 2 ++ qapi/block-core.json | 7 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index e2da4cb..a7f56f4 1

[Qemu-devel] [PATCH v14 12/19] block: add BdrvDirtyBitmap documentation

2015-02-20 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Max Reitz --- block.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/block.c b/block.c index a7f56f4..c1c11aa 100644 --- a/block.c +++ b/block.c @@ -60,11 +60,11 @@ * or enabled. A frozen bitmap can only abdicate() or re

[Qemu-devel] [PATCH v14 00/19] block: incremental backup series

2015-02-20 Thread John Snow
This series requires: [PATCH v3] blkdebug: fix "once" rule Salutations, weary traveler. Might I interest you in some incremental backups? Only slightly used, just like new! This patchset enables the in-memory part of the incremental backup feature. Bitmap persistence and bitmap migration will be

[Qemu-devel] [PATCH v14 14/19] iotests: add invalid input incremental backup tests

2015-02-20 Thread John Snow
Signed-off-by: John Snow Reviewed-by: Max Reitz --- tests/qemu-iotests/112 | 89 ++ tests/qemu-iotests/112.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 95 insertions(+) create mode 100644 tests/qemu-iotests/112 create mode 10

[Qemu-devel] [PATCH v14 09/19] qmp: add block-dirty-bitmap-clear

2015-02-20 Thread John Snow
Add bdrv_clear_dirty_bitmap and a matching QMP command, qmp_block_dirty_bitmap_clear that enables a user to reset the bitmap attached to a drive. This allows us to reset a bitmap in the event of a full drive backup. Reviewed-by: Max Reitz Signed-off-by: John Snow --- block.c | 8

[Qemu-devel] [PATCH v14 04/19] block: Introduce bdrv_dirty_bitmap_granularity()

2015-02-20 Thread John Snow
This returns the granularity (in bytes) of dirty bitmap, which matches the QMP interface and the existing query interface. Signed-off-by: John Snow Reviewed-by: Max Reitz --- block.c | 8 ++-- include/block/block.h | 1 + 2 files changed, 7 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH v14 13/19] block: Ensure consistent bitmap function prototypes

2015-02-20 Thread John Snow
We often don't need the BlockDriverState for functions that operate on bitmaps. Remove it. Signed-off-by: John Snow Reviewed-by: Max Reitz --- block.c | 13 ++--- block/backup.c| 2 +- block/mirror.c| 26 ++ blockdev.c|

[Qemu-devel] [PATCH v14 08/19] qmp: Add support of "dirty-bitmap" sync mode for drive-backup

2015-02-20 Thread John Snow
For "dirty-bitmap" sync mode, the block job will iterate through the given dirty bitmap to decide if a sector needs backup (backup all the dirty clusters and skip clean ones), just as allocation conditions of "top" sync mode. Signed-off-by: Fam Zheng Signed-off-by: John Snow Reviewed-by: Max Rei

[Qemu-devel] [PATCH v14 01/19] qapi: Add optional field "name" to block dirty bitmap

2015-02-20 Thread John Snow
From: Fam Zheng This field will be set for user created dirty bitmap. Also pass in an error pointer to bdrv_create_dirty_bitmap, so when a name is already taken on this BDS, it can report an error message. This is not global check, two BDSes can have dirty bitmap with a common name. Implemented

[Qemu-devel] [PATCH v14 03/19] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-02-20 Thread John Snow
The new command pair is added to manage a user created dirty bitmap. The dirty bitmap's name is mandatory and must be unique for the same device, but different devices can have bitmaps with the same names. The granularity is an optional field. If it is not specified, we will choose a default granu

[Qemu-devel] [PATCH v14 02/19] qmp: Ensure consistent granularity type

2015-02-20 Thread John Snow
We treat this field with a variety of different types everywhere in the code. Now it's just uint32_t. Reviewed-by: Eric Blake Reviewed-by: Max Reitz Signed-off-by: John Snow --- block.c | 11 ++- block/mirror.c| 4 ++-- include/block/block.h | 2 +-

[Qemu-devel] [PATCH v14 05/19] hbitmap: add hbitmap_merge

2015-02-20 Thread John Snow
We add a bitmap merge operation to assist in error cases where we wish to combine two bitmaps together. This is algorithmically O(bits) provided HBITMAP_LEVELS remains constant. For a full bitmap on a 64bit machine: sum(bits/64^k, k, 0, HBITMAP_LEVELS) ~= 1.01587 * bits We may be able to improve

Re: [Qemu-devel] [PATCH 0/3] Support streaming to an intermediate layer

2015-02-20 Thread Eric Blake
On 02/20/2015 12:05 PM, Alberto Garcia wrote: > On Fri, Feb 20, 2015 at 10:34:58AM -0700, Eric Blake wrote: > >>> I followed the proposed API from the wiki, which simply adds an >>> additional 'top' parameter to block-stream specifying the image >>> that data is written to: >> >> How does one lear

Re: [Qemu-devel] [PATCH 2/3] block: Add QMP support for streaming to an intermediate layer

2015-02-20 Thread Eric Blake
On 02/20/2015 06:53 AM, Alberto Garcia wrote: > This adds the 'top' parameter to the 'block-stream' QMP command and > checks that its value is valid before passing it to stream_start(). > > Signed-off-by: Alberto Garcia > --- > blockdev.c| 19 +++ > hmp.c

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Programmingkid
On Feb 20, 2015, at 12:56 PM, Paolo Bonzini wrote: > > > On 20/02/2015 18:32, Programmingkid wrote: >>> Ok, so I'll apply v3 to my tree as soon as I get a Tested-by. >>> Please take a look into providing a .rsrc file with larger-sized >>> icons (I think you can add more than one to a single .rs

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Alexander Graf
On 20.02.15 20:43, Michael Mueller wrote: > On Fri, 20 Feb 2015 18:50:20 +0100 > Alexander Graf wrote: > >> >> >> >>> Am 20.02.2015 um 18:37 schrieb Michael Mueller : >>> >>> On Fri, 20 Feb 2015 17:57:52 +0100 >>> Alexander Graf wrote: >>> Because all CPUs we have in our list only expose

Re: [Qemu-devel] [PATCH 3/3] target-ppc: use separate indices for various translation modes

2015-02-20 Thread Richard Henderson
On 02/20/2015 09:57 AM, Paolo Bonzini wrote: > PowerPC TCG flushes the TLB on every IR/DR change, which basically > means on every user<->kernel context switch. Encode IR/DR in the > MMU index. > > This brings the number of TLB flushes down from ~90 to ~5 > for starting up the Debian inst

Re: [Qemu-devel] [PATCH 2/3] softmmu: support up to 12 MMU modes

2015-02-20 Thread Richard Henderson
On 02/20/2015 09:57 AM, Paolo Bonzini wrote: > + * TCG will have to generate an operand as large as the distance between > + * tlb_table[0][0] and the tlb_table[NB_MMU_MODES - 1][0].addend. For Nit: the distance is from the start of env, i.e. offsetof(CPUArchState, tlb_table[mem_index][0].adde

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 20:21:45 +0100 Alexander Graf wrote: > > > > > Am 20.02.2015 um 19:59 schrieb Michael Mueller : > > > > On Fri, 20 Feb 2015 10:11:55 -0800 > > Richard Henderson wrote: > > > >>> +static inline uint64_t big_endian_bit(unsigned long nr) > >>> +{ > >>> +return 1ul << (B

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 18:50:20 +0100 Alexander Graf wrote: > > > > > Am 20.02.2015 um 18:37 schrieb Michael Mueller : > > > > On Fri, 20 Feb 2015 17:57:52 +0100 > > Alexander Graf wrote: > > > >> Because all CPUs we have in our list only expose 128 bits? > > > > Here a STFLE result on a EC12

Re: [Qemu-devel] [PATCH 1/3] tcg: add TCG_TARGET_TLB_DISPLACEMENT_BITS

2015-02-20 Thread Richard Henderson
On 02/20/2015 09:57 AM, Paolo Bonzini wrote: > diff --git a/tcg/i386/tcg-target.h b/tcg/i386/tcg-target.h > index 7a9980e..8ba977a 100644 > --- a/tcg/i386/tcg-target.h > +++ b/tcg/i386/tcg-target.h > @@ -25,6 +25,7 @@ > #define TCG_TARGET_I386 1 > > #define TCG_TARGET_INSN_UNIT_SIZE 1 > +#defi

Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 18:00:19 +0100 Alexander Graf wrote: > > So above s390_set/get_processor_props() the code is accelerator > > independent. > > Any particular reason you can't do it like PPC? That seems to be a short question... and when I started one year ago, I oriented myself on the PP

[Qemu-devel] [PATCH 4/4] scsi: Convert remaining PCI HBAs to realize()

2015-02-20 Thread Markus Armbruster
These are "am53c974", "dc390", "lsi53c895a", "lsi53c810", "megasas", "megasas-gen2". Signed-off-by: Markus Armbruster --- hw/scsi/esp-pci.c| 30 +++--- hw/scsi/lsi53c895a.c | 14 +++--- hw/scsi/megasas.c| 14 +++--- 3 files changed, 17 insertions(+

[Qemu-devel] [PATCH 2/4] hw: Propagate errors through qdev_prop_set_drive()

2015-02-20 Thread Markus Armbruster
Three kinds of callers: 1. On failure, report the error and abort Passing &error_abort does the job. No functional change. 2. On failure, report the error and exit() This is qdev_prop_set_drive_nofail(). Error reporting moves from qdev_prop_set_drive() to its caller. Because hiding

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Alexander Graf
> Am 20.02.2015 um 19:59 schrieb Michael Mueller : > > On Fri, 20 Feb 2015 10:11:55 -0800 > Richard Henderson wrote: > >>> +static inline uint64_t big_endian_bit(unsigned long nr) >>> +{ >>> +return 1ul << (BITS_PER_LONG - (nr % BITS_PER_LONG)); >>> +}; >> >> This is buggy. NR=0 shoul

[Qemu-devel] [PATCH 1/4] scsi: Clean up duplicated error in legacy if=scsi code

2015-02-20 Thread Markus Armbruster
Commit a818a4b changed scsi_bus_legacy_handle_cmdline() to report errors from scsi_bus_legacy_add_drive() with error_report() in addition to returning them. That's inappropriate. Two kinds of callers: 1. realize methods (devices "esp" and "virtio-scsi-device") The error object gets passed up

[Qemu-devel] [PATCH] tcg: Complete handling of ALWAYS and NEVER

2015-02-20 Thread Richard Henderson
Missing from movcond, and brcondi_i32 (but not brcondi_i64). Signed-off-by: Richard Henderson --- tcg/tcg-op.c | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) --- On 02/20/2015 05:05 AM, Laurent Desnogues wrote:> Hi Richard, > > this patch results in movcond with

[Qemu-devel] [PATCH 0/4] scsi: Error reporting cleanups, realize()

2015-02-20 Thread Markus Armbruster
This series is based on * [PULL 00/96] pci, pc, virtio fixes and cleanups * [PULL 0/8] usb: error handling fixes from Markus, make sysbus ehci arm-only. * [PULL v2 00/11] Clean up around error_get_pretty(), qerror_report_err() * [PATCH 0/2] pci: Bury dead legacy commands pci_add, pci_del * [PAT

[Qemu-devel] [PATCH 3/4] scsi: Improve error reporting for invalid drive property

2015-02-20 Thread Markus Armbruster
When setting "realized" fails, scsi_bus_legacy_add_drive() passes the error to qerror_report_err(), then returns an unspecific "Setting drive property failed" error, which is reported further up the call chain. Example: $ qemu-system-x86_64 -nodefaults -S -display none \ > -drive if=scsi,

Re: [Qemu-devel] [PATCH 0/3] Support streaming to an intermediate layer

2015-02-20 Thread Alberto Garcia
On Fri, Feb 20, 2015 at 10:34:58AM -0700, Eric Blake wrote: > > I followed the proposed API from the wiki, which simply adds an > > additional 'top' parameter to block-stream specifying the image > > that data is written to: > > How does one learn whether qemu is new enough to support this > mode

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 10:11:55 -0800 Richard Henderson wrote: > > +static inline uint64_t big_endian_bit(unsigned long nr) > > +{ > > +return 1ul << (BITS_PER_LONG - (nr % BITS_PER_LONG)); > > +}; > > This is buggy. NR=0 should map to 63, not 64. I'm sure I was asked to replace my constant

[Qemu-devel] [PATCH] qerror.h: Swap definitions that were not in alphabetical order

2015-02-20 Thread Alberto Garcia
Signed-off-by: Alberto Garcia --- include/qapi/qmp/qerror.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qapi/qmp/qerror.h b/include/qapi/qmp/qerror.h index 986260f..57a62d4 100644 --- a/include/qapi/qmp/qerror.h +++ b/include/qapi/qmp/qerror.h @@ -37,12 +37,1

Re: [Qemu-devel] [RFC PATCH v2 09/15] cpu-model/s390: Add KVM VM attribute interface routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 17:59:14 +0100 Alexander Graf wrote: > But please give a nutshell explanation on what exactly you're patching > at all here. Please don't ask in riddles... :-) S390ProcessorProps are attributes that represent cpu model related properties of the processor. typedef struct S

[Qemu-devel] [PATCH v5 14/16] pc: acpi-build: drop template patching and create PCI bus tree dynamically

2015-02-20 Thread Igor Mammedov
Replace AML template patching with direct composing of PCI device entries in C. It allows to simplify PCI tree generation further and saves us about 400LOC scattered through different files, confining tree generation to one C function which is much easier to deal with. Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH v5 12/16] pc: acpi-build: simplify PCI bus tree generation

2015-02-20 Thread Igor Mammedov
it basicaly does the same as original approach, * just without bus/notify tables tracking (less obscure) which is easier to follow. * drops unnecessary loops and bitmaps, creating devices and notification method in the same loop. * saves us ~100LOC Signed-off-by: Igor Mammedov --- v2: * fixe

[Qemu-devel] [PATCH v5 09/16] tests: ACPI test blobs update due to PCI0._CRS changes

2015-02-20 Thread Igor Mammedov
PCI0._CRS was moved into SSDT and became the same for PIIX4/Q35 machines. Signed-off-by: Igor Mammedov --- tests/acpi-test-data/pc/DSDT | Bin 3415 -> 2970 bytes tests/acpi-test-data/pc/SSDT | Bin 2374 -> 2480 bytes tests/acpi-test-data/q35/DSDT | Bin 8005 -> 7608 bytes tests/acpi-test-data/

[Qemu-devel] [PATCH v5 13/16] tests: ACPI: update pc/SSDT.bridge due to new alg of PCI tree creation

2015-02-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/acpi-test-data/pc/SSDT.bridge | Bin 4352 -> 4351 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/tests/acpi-test-data/pc/SSDT.bridge b/tests/acpi-test-data/pc/SSDT.bridge index b807ac92dde72719fe3861c710b555fe3dd62583..ca7f63cb4e48bd95

[Qemu-devel] [PATCH v5 15/16] pc: acpi: remove not used anymore ssdt-[misc|pcihp].hex.generated blobs

2015-02-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/i386/ssdt-misc.hex.generated | 139 -- hw/i386/ssdt-pcihp.hex.generated | 251 --- 2 files changed, 390 deletions(-) delete mode 100644 hw/i386/ssdt-misc.hex.generated delete mode 100644 hw/i386/ssdt-pc

[Qemu-devel] [PATCH v5 10/16] tests: bios-tables-test: add support for testing bridges

2015-02-20 Thread Igor Mammedov
Adds alternative ACPI table blob selection for testing non default QEMU configurations. If blob file for test variant is not present, fallback to default blob. With this change implement testing with a coldplugged bridge. Signed-off-by: Igor Mammedov --- tests/bios-tables-test.c | 45 ++

[Qemu-devel] [PATCH v5 11/16] tests: add ACPI blobs for qemu with bridge cases

2015-02-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- tests/acpi-test-data/pc/SSDT.bridge | Bin 0 -> 4352 bytes tests/acpi-test-data/q35/SSDT.bridge | Bin 0 -> 702 bytes 2 files changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/acpi-test-data/pc/SSDT.bridge create mode 100644 tests/acpi-test-data

[Qemu-devel] [PATCH v5 16/16] acpi: make build_*() routines static to aml-build.c

2015-02-20 Thread Igor Mammedov
build_*() routines were used for composing AML structures manually in acpi-build.c but after conversion to AML API they are not used outside of aml-build.c anymore, so hide them from external users. Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 20 ++-- include/h

[Qemu-devel] [PATCH v5 03/16] pc: acpi: drop manual hole punching for CPU hotplug resources

2015-02-20 Thread Igor Mammedov
Drops manual hole punching in PCI0._CRS on PIIX4 machine type for CPU hotplug resources. Resources will be consumed by Device(PRES) that is attached to PCI bus. The same way how it currently works for mem hotlpug. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 6 +- 1 file changed,

[Qemu-devel] [PATCH v5 08/16] pc: acpi-build: drop template patching and create Device(SMC) dynamically

2015-02-20 Thread Igor Mammedov
patch moves SMC device into SSDT and creates it only when device is present, which makes ACPI tables smaller in default case when device is not present. Also it fixes wrong IO range in CRS if "iobase" property is set to a non default value. PS: Testing with XP shows that current default "iobase"

[Qemu-devel] [PATCH v5 05/16] pc: acpi-build: drop remaining ssdt_misc template

2015-02-20 Thread Igor Mammedov
It drops empty ssdt_misc templete. It also hides from user almost all pointer arithmetic when building SSDT which makes resulting code a bit cleaner and concentrating only on composing ASL construct /i.e. a task build_ssdt() should be doing/. Also it makes one binary blob less stored in QEMU sourc

[Qemu-devel] [PATCH v5 02/16] pc: acpi: drop manual hole punching for PCI hotplug resources

2015-02-20 Thread Igor Mammedov
Drops manual hole punching in PCI0._CRS for PIIX4 machine type. Resources will be consumed by Device(PHPR) that cwis attached to PCI bus. The same way how it currently works for mem hotlpug. Manual hole in PIIX4 _CRS wasn't correct anyway since it was legacy size 0xF while current PCIHP MMIO regio

[Qemu-devel] [PATCH v5 04/16] pc: acpi: drop manual hole punching for GPE0 resources

2015-02-20 Thread Igor Mammedov
Drops manual hole punching in PCI0._CRS on PIIX4 machine type for GPE0 resources. Resources will be consumed by Device(GPE0) that is attached to PCI namespace. There is GPE device with HID ACPI0006 since ACPI2.0 that should be used for this purpose but none of Windows versions support it and show i

[Qemu-devel] [PATCH v5 07/16] pc: export applesmc IO port/len

2015-02-20 Thread Igor Mammedov
IO port and length will be used in following patch to correctly generate SMC ACPI device in SSDT. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 2 +- hw/misc/applesmc.c | 5 ++--- include/hw/isa/isa.h | 11 +-- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a

[Qemu-devel] [PATCH v5 00/16] ACPI refactoring: replace template patching with C AML API

2015-02-20 Thread Igor Mammedov
NOTE to maintaner: Needs updating DSDT hex.generated and ACPI tests blobs Changes since v4: * split PCI0._CRS patch onto simple ones * move _CRS into SSDT * a series to drop manual hole punching in PIIX4 _CRS * add test case for ACPI table with coldplugged bridge * fixed up current

[Qemu-devel] [PATCH v5 06/16] acpi: add acpi_irq_no_flags() term

2015-02-20 Thread Igor Mammedov
Signed-off-by: Igor Mammedov --- hw/acpi/aml-build.c | 21 + include/hw/acpi/aml-build.h | 1 + 2 files changed, 22 insertions(+) diff --git a/hw/acpi/aml-build.c b/hw/acpi/aml-build.c index d793775..60245e7 100644 --- a/hw/acpi/aml-build.c +++ b/hw/acpi/aml-build.c

[Qemu-devel] [PATCH v5 01/16] pc: acpi-build: create PCI0._CRS dynamically

2015-02-20 Thread Igor Mammedov
Replace template patching and runtime calculation in _CRS() method with static _CRS defined in SSDT. No functional change except of as mentined above and _CRS being moved from DSDT to SSDT. Signed-off-by: Igor Mammedov --- hw/i386/acpi-build.c | 88 --

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Richard Henderson
On 02/17/2015 06:24 AM, Michael Mueller wrote: > +static inline uint64_t big_endian_bit(unsigned long nr) > +{ > +return 1ul << (BITS_PER_LONG - (nr % BITS_PER_LONG)); > +}; This is buggy. NR=0 should map to 63, not 64. > +return !!(*ptr & big_endian_bit(nr)); Personally I dislike !! as

[Qemu-devel] [PATCH v2 for-2.3 0/3] Support more than 8 MMU modes, speedup PPC by 10%

2015-02-20 Thread Paolo Bonzini
Patches 1 and 2 enable support from more than 8 MMU modes in TCG (patch 1 is in the targets, patch 2 is in cpu-defs.h). The TLB size is reduced proportionally on targets where that is necessary. Patch 3 uses the new support in the PPC target. Paolo Paolo Bonzini (3): tcg: add TCG_TARGET_TLB_D

Re: [Qemu-devel] [PATCH 3/3] target-ppc: use separate indices for various translation modes

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 14:00, Alexander Graf wrote: > Also please double-check that 440 still works. That was the target that > gave me the most headaches on DR/IR switching so far. The ppc-virtexml507-linux-2_6_34.tgz image works for me. Paolo > Otherwise looks simple and clean to me :). > > > Alex

[Qemu-devel] [PATCH 2/3] softmmu: support up to 12 MMU modes

2015-02-20 Thread Paolo Bonzini
At 8k per TLB (for 64-bit host or target), 8 or more modes make the TLBs bigger than 64k, and some RISC TCG backends do not like that. On the affected hosts, cut the TLB size in half---there is still a measurable speedup on PPC with the next patch. Signed-off-by: Paolo Bonzini --- include/exec/

[Qemu-devel] [PATCH 3/3] target-ppc: use separate indices for various translation modes

2015-02-20 Thread Paolo Bonzini
PowerPC TCG flushes the TLB on every IR/DR change, which basically means on every user<->kernel context switch. Encode IR/DR in the MMU index. This brings the number of TLB flushes down from ~90 to ~5 for starting up the Debian installer, which is in line with x86 and gives a ~10% perform

[Qemu-devel] [PATCH 1/3] tcg: add TCG_TARGET_TLB_DISPLACEMENT_BITS

2015-02-20 Thread Paolo Bonzini
This will be used to size the TLB when more than 8 MMU modes are used by the target. Limitations come from the limited size of the immediate fields (which sometimes, as in the case of Aarch64, extend to instructions that shift the immediate). Signed-off-by: Paolo Bonzini --- tcg/aarch64/tcg-tar

Re: [Qemu-devel] [PATCH v3 2/3] Add migrate_incoming

2015-02-20 Thread Markus Armbruster
Eric Blake writes: > On 02/20/2015 01:18 AM, Markus Armbruster wrote: >> I'd like Eric's opinion on on encoding configuration tuples as URIs >> rather than JSON in QMP. >> > >>> +{ 'command': 'migrate-incoming', 'data': {'uri': 'str' } } >>> + >>> # @xen-save-devices-state: >>> # >>> # Save t

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 18:32, Programmingkid wrote: >> Ok, so I'll apply v3 to my tree as soon as I get a Tested-by. >> Please take a look into providing a .rsrc file with larger-sized >> icons (I think you can add more than one to a single .rsrc file?) >> and, when you do that, document in pc-bios/README

Re: [Qemu-devel] [PATCH 00/11] target-aarch64 fix and improvments

2015-02-20 Thread Alex Bennée
https://validation.linaro.org/dashboard/streams/anonymous/alex.bennee/bundles/52315b57f77238f924b5528ad16cc549d93a9d31/2a7f8984-0d1c-4268-8249-ba86c56dcbb7/?search=&length=100#table All passing on the current test set. I've got more to add when I get a chance, On 20 February 2015 at 16:50, Alex B

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Alexander Graf
> Am 20.02.2015 um 18:37 schrieb Michael Mueller : > > On Fri, 20 Feb 2015 17:57:52 +0100 > Alexander Graf wrote: > >> Because all CPUs we have in our list only expose 128 bits? > > Here a STFLE result on a EC12 GA2, already more than 128 bits... Is that > model on the list? If that model

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 17:57:52 +0100 Alexander Graf wrote: > Because all CPUs we have in our list only expose 128 bits? Here a STFLE result on a EC12 GA2, already more than 128 bits... Is that model on the list? [mimu@p57lp59 s390xfac]$ ./s390xfac -b fac[0] = 0xfbfbfcfff840 fac[1] = 0xffde00

Re: [Qemu-devel] [PATCH 0/3] Support streaming to an intermediate layer

2015-02-20 Thread Eric Blake
On 02/20/2015 06:53 AM, Alberto Garcia wrote: > Hello, > > I added support to the Block Stream API for streaming to an > intermediate layer. > > I followed the proposed API from the wiki, which simply adds an > additional 'top' parameter to block-stream specifying the image that > data is written

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Programmingkid
On Feb 20, 2015, at 12:05 PM, Paolo Bonzini wrote: > > > On 20/02/2015 17:54, Programmingkid wrote: >>> I suspect the Windows icon is not a great match for Mac OS X which likes >>> to have big sizes (48x48 or 128x128). >> >> Definitely true. >> >>> If you want to generate the .rsrc >>> file a

Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-20 Thread Alexander Graf
On 20.02.15 16:32, Michael Mueller wrote: > On Fri, 20 Feb 2015 15:03:30 +0100 > Alexander Graf wrote: > >>> >>> - s390_get_proceccor_props() >>> - s390_set_proceccor_props() >>> >>> They can be used to request or retrieve processor related information from >>> an accelerator. >>> That informa

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 18:06, Programmingkid wrote: > I did some looking myself and found out that the Rez and SetFile command > are missing on Mac OS 10.4 (and probably below). They are available on > Mac OS 10.5 and Mac OS 10.6. Since this feature isn't important, I can > add conditional code that would

Re: [Qemu-devel] [PATCH v3] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Programmingkid
On Feb 20, 2015, at 6:41 AM, Paolo Bonzini wrote: > > > On 19/02/2015 21:51, Programmingkid wrote: >> This patch sets the icon for the QEMU binary on Mac OS X. >> >> Signed-off-by: John Arbuckle >> >> --- >> Added conditional code to make the icon setting happen only on Mac OS X. > > Appli

Re: [Qemu-devel] [PATCH v13 00/17] block: incremental backup series

2015-02-20 Thread John Snow
On 02/20/2015 06:09 AM, Stefan Hajnoczi wrote: On Fri, Feb 13, 2015 at 05:08:41PM -0500, John Snow wrote: This series requires: [PATCH v3] blkdebug: fix "once" rule Welcome to the "incremental backup" newsletter, where we discuss exciting developments in non-redundant backup technology. This

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Paolo Bonzini
On 20/02/2015 17:54, Programmingkid wrote: >> I suspect the Windows icon is not a great match for Mac OS X which likes >> to have big sizes (48x48 or 128x128). > > Definitely true. > >> If you want to generate the .rsrc >> file automatically, the right source probably would be the .svg file, >

Re: [Qemu-devel] [PATCH 0/2] Fix GCC 5.0.0 build errors

2015-02-20 Thread Radim Krčmář
Cc: qemu-triv...@nongnu.org

Re: [Qemu-devel] [RFC PATCH v2 09/15] cpu-model/s390: Add KVM VM attribute interface routines

2015-02-20 Thread Alexander Graf
On 20.02.15 16:18, Michael Mueller wrote: > On Fri, 20 Feb 2015 14:59:20 +0100 > Alexander Graf wrote: > >>> +typedef struct S390ProcessorProps { >>> +uint64_t cpuid; >>> +uint16_t ibc; >>> +uint8_t pad[6]; >>> +uint64_t fac_list[S390_ARCH_FAC_LIST_SIZE_UINT64]; >>> +} S390Proc

Re: [Qemu-devel] [RFC PATCH v2 04/15] cpu-model/s390: Introduce S390 CPU models

2015-02-20 Thread Alexander Graf
On 20.02.15 16:49, Michael Mueller wrote: > On Fri, 20 Feb 2015 16:22:20 +0100 > Alexander Graf wrote: > Just make this uint64_t fac_list[2]. That way we don't have to track any messy allocations. >>> >>> It will be something like "uint64_t >>> fac_list[S390_CPU_FAC_LIST_SIZE_

Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 17:28:14 +0100 Andreas Färber wrote: Andreas, > Sorry for my ignorance, but what is proc actually needed for? For > initializing the class, there's .class_init (and cc->fac_list apparently > is initialized here). If you need to pass info to KVM, you can do so in yes, it is c

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 17:34:28 +0100 Andreas Färber wrote: > Please note that QEMU uses gtk-doc style, where the description goes > between arguments and Returns:, and the function name gets a ':'. > There's also fancy syntax like #CPUClass, %true, etc. On my TODOs... Thanks, Michael

Re: [Qemu-devel] [PATCH] Makefile.target: set icon for binary file on Mac OS X

2015-02-20 Thread Programmingkid
On Feb 20, 2015, at 7:36 AM, Paolo Bonzini wrote: > > > On 20/02/2015 13:18, Peter Maydell wrote: >> Why not just use the sips --out option to specify a different >> output file? That way we automatically put the current icon >> into the executable, and don't have to update a hand-created >> qe

Re: [Qemu-devel] [PATCH v13 00/17] block: incremental backup series

2015-02-20 Thread Kashyap Chamarthy
On Fri, Feb 20, 2015 at 11:09:20AM +, Stefan Hajnoczi wrote: > On Fri, Feb 13, 2015 at 05:08:41PM -0500, John Snow wrote: > > This series requires: [PATCH v3] blkdebug: fix "once" rule > > > > Welcome to the "incremental backup" newsletter, where we discuss > > exciting developments in non-red

Re: [Qemu-devel] [PATCH 00/11] target-aarch64 fix and improvments

2015-02-20 Thread Alex Bennée
It's running through LAVA now: https://validation.linaro.org/scheduler/job/268253 On 19 February 2015 at 23:52, Peter Maydell wrote: > On 20 February 2015 at 06:14, Richard Henderson wrote: >> While doing the mechanics of a previous patch set converting >> translators to use to TCGLabel pointe

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Andreas Färber
Am 20.02.2015 um 17:12 schrieb Michael Mueller: > On Fri, 20 Feb 2015 08:02:42 -0800 > Richard Henderson wrote: > >>> +/** >>> + * s390_test_facility - test if given facility bit is set facility list >>> + * of given cpu class >>> + * @class: address of cpu class to test >>>

Re: [Qemu-devel] [RFC PATCH v2 10/15] cpu-model/s390: Add cpu class initialization routines

2015-02-20 Thread Michael Mueller
On Fri, 20 Feb 2015 17:12:49 +0100 Michael Mueller wrote: > Good spot, it's not being used yet. It's planned to be used with a patch that > implements zPCI > related instructions on QEMU side. Maybe you have seen the discussion from > Frank Blaschka in > this e-mail list in regard to that. I w

[Qemu-devel] [PATCH RFC 0/3] iothread: release iothread around aio_poll

2015-02-20 Thread Paolo Bonzini
Right now, iothreads are relying on a "contention callback" to release the AioContext (e.g. for block device operations or to do bdrv_drain_all). This is necessary because aio_poll needs to be called within an aio_context_acquire. This series drops this requirement for aio_poll, with two effects:

Re: [Qemu-devel] [RFC PATCH v2 13/15] cpu-model/s390: Add processor property routines

2015-02-20 Thread Andreas Färber
Am 20.02.2015 um 17:04 schrieb Michael Mueller: > On Fri, 20 Feb 2015 16:41:49 +0100 > Andreas Färber wrote: > >> Can't you just implement the class-level name-to-ObjectClass callback >> that other CPUs have grown for the above use case? > > If it fulfills the requirements sure. Please point me

[Qemu-devel] [PATCH 1/3] aio-posix: move pollfds to thread-local storage

2015-02-20 Thread Paolo Bonzini
By using thread-local storage, aio_poll can stop using global data during g_poll_ns. This will make it possible to drop callbacks from rfifolock. Signed-off-by: Paolo Bonzini --- aio-posix.c | 77 ++--- async.c | 2 -- include

[Qemu-devel] [PATCH 2/3] AioContext: acquire/release AioContext during aio_poll

2015-02-20 Thread Paolo Bonzini
This is the first step in pushing down acquire/release, and will let rfifolock drop the contention callback feature. Signed-off-by: Paolo Bonzini --- aio-posix.c | 9 + aio-win32.c | 8 include/block/aio.h | 15 --- 3 files changed, 25 insertions(+)

[Qemu-devel] [PATCH 3/3] iothread: release iothread around aio_poll

2015-02-20 Thread Paolo Bonzini
This is the first step towards having fine-grained critical sections in dataplane threads, which resolves lock ordering problems between address_space_* functions (which need the BQL when doing MMIO, even after we complete RCU-based dispatch) and the AioContext. Because AioContext does not use con

  1   2   >