Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-02-02 Thread Markus Armbruster
Gonglei writes: > On 2015/2/2 17:37, Markus Armbruster wrote: > >> Gonglei writes: >> >>> On 2015/1/30 20:32, Markus Armbruster wrote: >>> Gonglei writes: > On 2015/1/30 20:01, Markus Armbruster wrote: > >> Gonglei writes: >> >>> On 2015/1/30 15:46, Markus Armbru

Re: [Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-02 Thread Denis V. Lunev
On 02/02/15 23:46, Denis V. Lunev wrote: On 02/02/15 23:40, Peter Lieven wrote: Am 02.02.2015 um 21:09 schrieb Denis V. Lunev: qemu_gluster_co_discard calculates size to discard as follows size_t size = nb_sectors * BDRV_SECTOR_SIZE; ret = glfs_discard_async(s->fd, offset, size, &glu

Re: [Qemu-devel] "Program received signal SIGUSR1" while debugging Qemu

2015-02-02 Thread Kaiyuan
> -Origin email- > From: Max Filippov > Sent Time: Tuesday, February 3, 2015 > To: Kaiyuan > Cc: qemu-devel > Subject: Re: [Qemu-devel] "Program received signal SIGUSR1" while debugging > Qemu > > On Tue, Feb 3, 2015 at 8:28 AM, Kaiyuan wrote: > > Hello, guys > > > > I am trying to us

Re: [Qemu-devel] [RFC PATCH v8 00/21] Deterministic replay core

2015-02-02 Thread Pavel Dovgaluk
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > On 22/01/2015 09:51, Pavel Dovgalyuk wrote: > > These patches include only core function of the replay, > > excluding the support for replaying serial, audio, network, and USB devices' > > operations. Reverse deb

Re: [Qemu-devel] "Program received signal SIGUSR1" while debugging Qemu

2015-02-02 Thread Max Filippov
On Tue, Feb 3, 2015 at 8:28 AM, Kaiyuan wrote: > Hello, guys > > I am trying to use gdb to debug qemu-system-ppc to see the details of tcg. > However, after setting breakpoint in > translate.c:gen_intermediate_code_internal and steps over, gdb showed > message: > > Program received signal SIGUSR1,

[Qemu-devel] [RFC] pseries: Enable in-kernel H_LOGICAL_CI_{LOAD, STORE} implementations

2015-02-02 Thread David Gibson
qemu currently implements the hypercalls H_LOGICAL_CI_LOAD and H_LOGICAL_CI_STORE as PAPR extensions. These are used by the SLOF firmware for IO, because performing cache inhibited MMIO accesses with the MMU off (real mode) is very awkward on POWER. This approach breaks when SLOF needs to access

[Qemu-devel] "Program received signal SIGUSR1" while debugging Qemu

2015-02-02 Thread Kaiyuan
Hello, guys I am trying to use gdb to debug qemu-system-ppc to see the details of tcg. However, after setting breakpoint in translate.c:gen_intermediate_code_internal and steps over, gdb showed message: Program received signal SIGUSR1, User defined signal 1. Then gdb jumped to cpus.c:642

Re: [Qemu-devel] [question] the patch which affect performance of virtio-scsi

2015-02-02 Thread Wangting (Kathy)
Sorry, I find that the patch of "virtio-scsi: Optimize virtio_scsi_init_req" can slove this problem. By the way, can you tell me the reason of the change about cdb and sense? On 2015-2-3 10:31, Wangting (Kathy) wrote: > Hi Paolo, > > Recently I test IO performance with virtio-scsi, and find out

[Qemu-devel] [question] the patch which affect performance of virtio-scsi

2015-02-02 Thread Wangting (Kathy)
Hi Paolo, Recently I test IO performance with virtio-scsi, and find out that the patch of "virtio-scsi: add support for the any_layout feature" affects IO performance of model with 4KB 32iodepth sequence read. Why cdb and sense is removed from the struct of VirtIOSCSICmdReq and VirtIOSCSICmdRes

[Qemu-devel] [PULL 2/2] target-openrisc: Add l.lwa/l.swa support

2015-02-02 Thread Jia Liu
From: Christian Svensson This patch adds support for atomic locks and is an adaption from https://github.com/bluecmd/or1k-qemu/commits/or32-optimize Tested via the atomic lock implementation of musl Signed-off-by: Christian Svensson Signed-off-by: Sebastian Macke Reviwed-by: Jia Liu Signed-o

[Qemu-devel] [PULL 1/2] target-openrisc: Separate of load/store instructions

2015-02-02 Thread Jia Liu
From: Sebastian Macke This patch separates the load and store instruction to a separate function. The repetition of the source code can be reduced and further optimizations can be implemented. In this case it checks for a zero offset and optimizes it. Signed-off-by: Sebastian Macke Reviwed-by:

[Qemu-devel] [PULL 0/2] OpenRISC patch queue for 2.3

2015-02-02 Thread Jia Liu
Hi Anthony, This is my OpenRISC patch queue for 2.3, it have been well tested, please pull. Thanks to Christian and Sebastian, they made the LD/ST updated. Regards, Jia The following changes since commit 16017c48547960539fcadb1f91d252124f442482: softfloat: Clarify license status (2015-01-

Re: [Qemu-devel] [PATCH 2/2] bootdevice: add check in restore_boot_order()

2015-02-02 Thread Gonglei
On 2015/2/2 17:37, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 20:32, Markus Armbruster wrote: >> >>> Gonglei writes: >>> On 2015/1/30 20:01, Markus Armbruster wrote: > Gonglei writes: > >> On 2015/1/30 15:46, Markus Armbruster wrote: >> >>> Gongl

Re: [Qemu-devel] [PATCH v4 07/18] spapr_iommu: Implement free_table() helper

2015-02-02 Thread Alexey Kardashevskiy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/02/2015 05:37 PM, David Gibson wrote: > On Thu, Jan 29, 2015 at 08:27:19PM +1100, Alexey Kardashevskiy wrote: >> Every sPAPRTCETable object holds an IOMMU memory region which holds >> a referenced to the sPAPRTCETable instance. So if we want to

Re: [Qemu-devel] [PATCH v2 1/2] configure: Default to enable module build

2015-02-02 Thread Fam Zheng
On Mon, 02/02 20:34, Paolo Bonzini wrote: > > > On 13/01/2015 09:53, Fam Zheng wrote: > > We have module build support around for a while, but also had it bitrot > > several times. It probably makes sense to enable it by default so that > > people can notice and use it. > > > > Counterpart to --

Re: [Qemu-devel] [PATCH 4/6] vmport_rpc: Add QMP access to vmport_rpc object.

2015-02-02 Thread Don Slutz
On 01/30/15 17:32, Eric Blake wrote: > On 01/30/2015 02:06 PM, Don Slutz wrote: >> This adds two new inject commands: >> >> inject-vmport-reboot >> inject-vmport-halt >> >> And three guest info commands: >> >> vmport-guestinfo-set >> vmport-guestinfo-get >> query-vmport-guestinfo >> >> More details

Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-02 Thread Chen, Tiejun
On 2015/2/2 20:54, Ian Jackson wrote: Wei Liu writes ("Re: [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough"): On Mon, Feb 02, 2015 at 09:17:23AM +0800, Tiejun Chen wrote: When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthr

Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-02 Thread Chen, Tiejun
On 2015/2/2 20:19, Wei Liu wrote: On Mon, Feb 02, 2015 at 09:17:23AM +0800, Tiejun Chen wrote: When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,-igd-passthru=on". This need to bring a change o

Re: [Qemu-devel] [v2][PATCH] libxl: add one machine property to support IGD GFX passthrough

2015-02-02 Thread Chen, Tiejun
On 2015/2/2 19:08, Ian Campbell wrote: On Mon, 2015-02-02 at 09:17 +0800, Tiejun Chen wrote: When we're working to support IGD GFX passthrough with qemu upstream, instead of "-gfx_passthru" we'd like to make that a machine option, "-machine xxx,-igd-passthru=on". This need to bring a change on

Re: [Qemu-devel] [PATCH v11 03/13] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove

2015-02-02 Thread John Snow
On 02/02/2015 05:10 AM, Markus Armbruster wrote: Kevin Wolf writes: Am 30.01.2015 um 18:04 hat John Snow geschrieben: On 01/30/2015 09:32 AM, Kevin Wolf wrote: Am 21.01.2015 um 10:34 hat Markus Armbruster geschrieben: I'm afraid I forgot much of the discussion we had before the break, a

[Qemu-devel] [PATCH 2/3] iotests: Add "wait" functionality to _cleanup_qemu

2015-02-02 Thread Max Reitz
The qemu process does not always need to be killed, just waiting for it can be fine, too. This introduces a way to do so. Signed-off-by: Max Reitz --- tests/qemu-iotests/common.qemu | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.qemu b/

[Qemu-devel] [PATCH 3/3] iotests: Add test for drive-mirror with NBD target

2015-02-02 Thread Max Reitz
When the drive-mirror block job is completed, it will call bdrv_swap() on the source and the target BDS; this should obviously not result in a segmentation fault. Signed-off-by: Max Reitz --- tests/qemu-iotests/094 | 81 ++ tests/qemu-iotests/094.o

[Qemu-devel] [PATCH 0/3] nbd: Drop BDS backpointer

2015-02-02 Thread Max Reitz
Right now, bdrv_swap() on NBD BDSs results in a segmentation fault pretty much all of the time. This series fixes this. Note that this is not a common case, as bdrv_swap() is generally only performed on root BDSs (there are exceptions, though) and NBD BDSs normally have a format BDS above them. Ho

[Qemu-devel] [PATCH 1/3] nbd: Drop BDS backpointer

2015-02-02 Thread Max Reitz
Before this patch, the "opaque" pointer in an NBD BDS points to a BDRVNBDState, which contains an NbdClientSession object, which in turn contains a pointer to the BDS. This pointer may become invalid due to bdrv_swap(), so drop it, and instead pass the BDS directly to the nbd-client.c functions whi

Re: [Qemu-devel] [PATCH 1/3] softfloat: Expand out the STATUS_PARAM macro

2015-02-02 Thread Richard Henderson
On 02/02/2015 12:31 PM, Peter Maydell wrote: > -void float_raise( int8 flags STATUS_PARAM ) > +void float_raise(int8 flags , float_status *status) Extra space before comma. r~

Re: [Qemu-devel] [PATCH 0/3] softfloat: Remove STATUS macros

2015-02-02 Thread Richard Henderson
On 02/02/2015 12:31 PM, Peter Maydell wrote: > Peter Maydell (3): > softfloat: Expand out the STATUS_PARAM macro > softfloat: expand out STATUS_VAR > softfloat: expand out STATUS macro > > fpu/softfloat-specialize.h | 124 ++-- > fpu/softfloat.c| 1609 > +++

Re: [Qemu-devel] [PATCH 04/19] libqos/ahci: Add command header helpers

2015-02-02 Thread John Snow
On 02/02/2015 05:25 AM, Paolo Bonzini wrote: On 30/01/2015 19:41, John Snow wrote: +/* Construct our Command Header (set_command_header handles endianness.) */ +memset(&cmd, 0x00, sizeof(cmd)); +cmd.flags = 5; /* reg_h2d_fis is 5 double-words long */ +cmd.flags = 0x400; /

Re: [Qemu-devel] [PATCH 17/19] qtest/ahci: Add a macro bootup routine

2015-02-02 Thread John Snow
On 02/02/2015 05:37 AM, Paolo Bonzini wrote: On 30/01/2015 19:42, John Snow wrote: +/** + * Boot and fully enable the HBA device. + * @see ahci_boot, ahci_pci_enable and ahci_hba_enable. + */ +static AHCIQState *ahci_macro_bootup(void) Ugly name... I would just leave out this patch. Paol

Re: [Qemu-devel] [PATCH 13/19] libqos/ahci: add ahci command size setters

2015-02-02 Thread John Snow
On 02/02/2015 05:35 AM, Paolo Bonzini wrote: On 30/01/2015 19:42, John Snow wrote: +void ahci_command_set_sizes(AHCICommand *cmd, uint64_t xbytes, +unsigned prd_size) +{ +/* Each PRD can describe up to 4MiB, and must not be odd. */ +g_assert_cmphex(prd_siz

Re: [Qemu-devel] [PATCH v2 01/11] cpu_ldst.h: Allow NB_MMU_MODES to be 7

2015-02-02 Thread Richard Henderson
On 01/29/2015 10:55 AM, Peter Maydell wrote: > Support guest CPUs which need 7 MMU index values. > Add a comment about what would be required to raise the limit > further (trivial for 8, TCG backend rework for 9 or more). > > Signed-off-by: Peter Maydell > Reviewed-by: Greg Bellows > --- > incl

Re: [Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-02 Thread Denis V. Lunev
On 02/02/15 23:40, Peter Lieven wrote: Am 02.02.2015 um 21:09 schrieb Denis V. Lunev: qemu_gluster_co_discard calculates size to discard as follows size_t size = nb_sectors * BDRV_SECTOR_SIZE; ret = glfs_discard_async(s->fd, offset, size, &gluster_finish_aiocb, acb); glfs_discard_asyn

Re: [Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-02 Thread Peter Lieven
Am 02.02.2015 um 21:09 schrieb Denis V. Lunev: > qemu_gluster_co_discard calculates size to discard as follows > size_t size = nb_sectors * BDRV_SECTOR_SIZE; > ret = glfs_discard_async(s->fd, offset, size, &gluster_finish_aiocb, acb); > > glfs_discard_async is declared as follows: > int g

Re: [Qemu-devel] [PATCH 04/19] libqos/ahci: Add command header helpers

2015-02-02 Thread John Snow
On 02/02/2015 05:27 AM, Paolo Bonzini wrote: On 30/01/2015 19:41, John Snow wrote: +/* Set the #cx'th command of port #px. */ +void ahci_set_command_header(AHCIQState *ahci, uint8_t px, + uint8_t cx, AHCICommandHeader *cmd) +{ +uint64_t ba = ahci->port[px].clb

Re: [Qemu-devel] [RFC v2 6/8] vfio_pci: fix a wrong check in vfio_pci_reset

2015-02-02 Thread Alex Williamson
On Wed, 2015-01-28 at 16:37 +0800, Chen Fan wrote: > when vfio device support FLR, then when device reset, > we call VFIO_DEVICE_RESET ioctl to reset the device first, > at kernel side, we also can see the order of reset: > 3330 rc = pcie_flr(dev, probe); > 3331 if (rc != -ENOTTY) >

[Qemu-devel] [PATCH 0/3] softfloat: Remove STATUS macros

2015-02-02 Thread Peter Maydell
This patchset expands out all the uses of the softfloat STATUS_VAR, STATUS_PARAM and STATUS macros and removes their definitions. In my opinion these macros are basically just obfuscating the passing around and use of a float_status pointer in the softfloat code, and serve no useful purpose. I use

[Qemu-devel] [PATCH 1/3] softfloat: Expand out the STATUS_PARAM macro

2015-02-02 Thread Peter Maydell
Expand out STATUS_PARAM wherever it is used and delete the definition. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h | 50 +++--- fpu/softfloat.c| 387 - include/fpu/softfloat.h| 332 +++---

[Qemu-devel] [PATCH 2/3] softfloat: expand out STATUS_VAR

2015-02-02 Thread Peter Maydell
Expand out and remove the STATUS_VAR macro. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h | 50 ++- fpu/softfloat.c| 995 + include/fpu/softfloat.h| 9 +- target-mips/msa_helper.c | 56 +-- 4 files changed, 617 inser

[Qemu-devel] [PATCH 3/3] softfloat: expand out STATUS macro

2015-02-02 Thread Peter Maydell
Expand out and remove the STATUS macro. Signed-off-by: Peter Maydell --- fpu/softfloat-specialize.h | 24 ++--- fpu/softfloat.c| 239 ++--- include/fpu/softfloat.h| 30 +++--- 3 files changed, 167 insertions(+), 126 deletions(-) diff --g

[Qemu-devel] This patch hunk will hang scripts/checkpatch.pl...

2015-02-02 Thread Peter Maydell
The following patch file (a cut down lump of an actual change I was making) seems to cause scripts/checkpatch.pl to hang. I find that script too opaque to try to debug, but I post the offending input here in case anybody else wishes to investigate. begin commit 4b3cf48c7fa455eb3b31dc844c95

Re: [Qemu-devel] [RFC v2 8/8] vfio-pci: add VFIO_FEATURE_ENABLE_AER_CAP feature

2015-02-02 Thread Alex Williamson
On Wed, 2015-01-28 at 16:37 +0800, Chen Fan wrote: > for old machine types, we should disable aercap feature. > > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 13 ++--- > include/hw/compat.h | 4 > 2 files changed, 14 insertions(+), 3 deletions(-) > > diff --git a/hw/vfio

Re: [Qemu-devel] [RFC v2 4/8] vfio-pci: pass the aer error to guest

2015-02-02 Thread Alex Williamson
On Wed, 2015-01-28 at 16:37 +0800, Chen Fan wrote: > when the vfio device encounters an uncorrectable error in host, > the vfio_pci driver will signal the eventfd registered by this > vfio device, the results in the qemu eventfd handler getting > invoked. > > this patch is to pass the error to gue

Re: [Qemu-devel] [RFC v2 2/8] vfio-pci: add aer capability support

2015-02-02 Thread Alex Williamson
On Wed, 2015-01-28 at 16:37 +0800, Chen Fan wrote: > if we detect the aer capability in vfio device, then > we should initialize the vfio device aer rigister bits. > so guest OS can set this bits as needed. s/rigister/register/ > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 72 > +++

Re: [Qemu-devel] [RFC v2 7/8] vfio_pci: change vfio device features bit macro to enum definition

2015-02-02 Thread Alex Williamson
On Wed, 2015-01-28 at 16:37 +0800, Chen Fan wrote: The "why" should go here > Signed-off-by: Chen Fan > --- > hw/vfio/pci.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index 54eb6b4..65247ee 100644 > --- a/hw/vfio/pci.c > ++

Re: [Qemu-devel] QEMU and Real Time OS

2015-02-02 Thread Marcelo Tosatti
On Fri, Jan 30, 2015 at 08:37:47AM +0100, Jan Kiszka wrote: > On 2015-01-30 00:06, Paolo Bonzini wrote: > > > > > > On 29/01/2015 20:37, Marc MarĂ­ wrote: > >> Is this an expected behaviour? I can't see why. > >> > >> I'd like to know if there is a certain reason why it doesn't work. Or > >> if it

Re: [Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-02 Thread Denis V. Lunev
On 02/02/15 22:58, Peter Lieven wrote: Am 02.02.2015 um 19:29 schrieb Denis V. Lunev: qemu_gluster_co_discard calculates size to discard as follows size_t size = nb_sectors * BDRV_SECTOR_SIZE; ret = glfs_discard_async(s->fd, offset, size, &gluster_finish_aiocb, acb); glfs_discard_asyn

[Qemu-devel] [PATCH v3 0/2] fix max_discard for NBD/gluster block drivers

2015-02-02 Thread Denis V. Lunev
Changes from v2: - dropped conditional in patch gluster code Changes from v1: - switched to UINT32_MAX for NBD - limited max_discard for gluster to SIZE_MAX on i686 only Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Peter Lieven

[Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-02 Thread Denis V. Lunev
qemu_gluster_co_discard calculates size to discard as follows size_t size = nb_sectors * BDRV_SECTOR_SIZE; ret = glfs_discard_async(s->fd, offset, size, &gluster_finish_aiocb, acb); glfs_discard_async is declared as follows: int glfs_discard_async (glfs_fd_t *fd, off_t length, size_t len

[Qemu-devel] [PATCH 2/2] nbd: fix max_discard

2015-02-02 Thread Denis V. Lunev
nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t as the length in bytes of the data to discard due to the following definition: struct nbd_request { uint32_t magic; uint32_t type; uint64_t handle; uint64_t from; uint32_t len; <-- the length of data to be d

Re: [Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-02 Thread Peter Lieven
Am 02.02.2015 um 19:29 schrieb Denis V. Lunev: > qemu_gluster_co_discard calculates size to discard as follows > size_t size = nb_sectors * BDRV_SECTOR_SIZE; > ret = glfs_discard_async(s->fd, offset, size, &gluster_finish_aiocb, acb); > > glfs_discard_async is declared as follows: > int g

Re: [Qemu-devel] [PATCH 2/2] nbd: fix max_discard

2015-02-02 Thread Peter Lieven
Am 02.02.2015 um 19:29 schrieb Denis V. Lunev: > nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t > as the length in bytes of the data to discard due to the following > definition: > > struct nbd_request { > uint32_t magic; > uint32_t type; > uint64_t handle; >

Re: [Qemu-devel] [PATCH v3 13/14] block: Remove "growable" from BDS

2015-02-02 Thread Max Reitz
On 2015-02-02 at 14:46, Kevin Wolf wrote: Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: Now that request clamping is done in the BlockBackend, the "growable" field can be removed from the BlockDriverState. All BDSs are now treated as being "growable" (that is, they are allowed to grow; they

[Qemu-devel] [PATCH 1/1] Tracify migration/rdma.c

2015-02-02 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Turn all the D/DD/DDDPRINTFs into trace events Turn most of the fprintf(stderr, into error_report Signed-off-by: Dr. David Alan Gilbert --- migration/rdma.c | 333 --- trace-events | 62 +++ 2 files

Re: [Qemu-devel] [PATCH v3 10/14] qemu-io: Remove "growable" option

2015-02-02 Thread Max Reitz
On 2015-02-02 at 14:36, Kevin Wolf wrote: Am 27.01.2015 um 18:11 hat Max Reitz geschrieben: On 2015-01-27 at 12:10, Eric Blake wrote: On 01/27/2015 10:04 AM, Max Reitz wrote: On 2015-01-27 at 11:59, Eric Blake wrote: On 01/26/2015 08:00 AM, Max Reitz wrote: Remove "growable" option from the

Re: [Qemu-devel] [PATCH v3 09/14] qemu-io: Use blk_new_open() in openfile()

2015-02-02 Thread Max Reitz
On 2015-02-02 at 14:34, Kevin Wolf wrote: Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: Signed-off-by: Max Reitz --- qemu-io.c | 31 --- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index 91a445a..81f8f64 100644 --- a/q

Re: [Qemu-devel] [PATCH v3 00/14] block: Remove "growable", add blk_new_open()

2015-02-02 Thread Kevin Wolf
Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: > This series removes the "growable" field from the BlockDriverState > object. Its use was to clamp guest requests against the limits of the > BDS; however, this can now be done more easily by moving those checks > into the BlockBackend functions. >

Re: [Qemu-devel] [PATCH v3 06/14] qemu-img: Use blk_new_open() in img_rebase()

2015-02-02 Thread Max Reitz
On 2015-02-02 at 14:00, Kevin Wolf wrote: Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: Signed-off-by: Max Reitz --- qemu-img.c | 57 - 1 file changed, 24 insertions(+), 33 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index be

Re: [Qemu-devel] [PATCH v3 13/14] block: Remove "growable" from BDS

2015-02-02 Thread Kevin Wolf
Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: > Now that request clamping is done in the BlockBackend, the "growable" > field can be removed from the BlockDriverState. All BDSs are now treated > as being "growable" (that is, they are allowed to grow; they are not > necessarily actually able to)

Re: [Qemu-devel] [PATCH v3 05/14] qemu-img: Use blk_new_open() in img_open()

2015-02-02 Thread Max Reitz
On 2015-02-02 at 13:35, Kevin Wolf wrote: Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: Signed-off-by: Max Reitz --- qemu-img.c | 20 ++-- 1 file changed, 6 insertions(+), 14 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 4e9a7f5..be1953d 100644 --- a/qemu-img.c

Re: [Qemu-devel] [PATCH v3 04/14] block/xen: Use blk_new_open() in blk_connect()

2015-02-02 Thread Max Reitz
On 2015-02-02 at 13:27, Kevin Wolf wrote: Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: Signed-off-by: Max Reitz --- hw/block/xen_disk.c | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c index 2184

Re: [Qemu-devel] [PATCH v3 10/14] qemu-io: Remove "growable" option

2015-02-02 Thread Kevin Wolf
Am 27.01.2015 um 18:11 hat Max Reitz geschrieben: > On 2015-01-27 at 12:10, Eric Blake wrote: > >On 01/27/2015 10:04 AM, Max Reitz wrote: > >>On 2015-01-27 at 11:59, Eric Blake wrote: > >>>On 01/26/2015 08:00 AM, Max Reitz wrote: > Remove "growable" option from the "open" command and from the q

Re: [Qemu-devel] [PATCH v2 1/2] configure: Default to enable module build

2015-02-02 Thread Paolo Bonzini
On 13/01/2015 09:53, Fam Zheng wrote: > We have module build support around for a while, but also had it bitrot > several times. It probably makes sense to enable it by default so that > people can notice and use it. > > Counterpart to --enable-modules, which is turned as default, > --disable-mo

Re: [Qemu-devel] [PATCH v3 09/14] qemu-io: Use blk_new_open() in openfile()

2015-02-02 Thread Kevin Wolf
Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > qemu-io.c | 31 --- > 1 file changed, 12 insertions(+), 19 deletions(-) > > diff --git a/qemu-io.c b/qemu-io.c > index 91a445a..81f8f64 100644 > --- a/qemu-io.c > +++ b/qemu-io.c > @@

[Qemu-devel] [PULL v3 00/11] RCU, scsi, icount changes for 2015-01-30

2015-02-02 Thread Paolo Bonzini
The following changes since commit 83761b9244ad2ed39d3cfabe8a0e901ab906f7bf: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20150127' into staging (2015-01-27 22:25:56 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for y

Re: [Qemu-devel] [PATCH v3 06/14] qemu-img: Use blk_new_open() in img_rebase()

2015-02-02 Thread Kevin Wolf
Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > qemu-img.c | 57 - > 1 file changed, 24 insertions(+), 33 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index be1953d..0b23c87 100644 > --- a/qem

Re: [Qemu-devel] [PATCH v3 05/14] qemu-img: Use blk_new_open() in img_open()

2015-02-02 Thread Kevin Wolf
Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > qemu-img.c | 20 ++-- > 1 file changed, 6 insertions(+), 14 deletions(-) > > diff --git a/qemu-img.c b/qemu-img.c > index 4e9a7f5..be1953d 100644 > --- a/qemu-img.c > +++ b/qemu-img.c > @@ -291,3

[Qemu-devel] [PATCH v2 0/2] fix max_discard for NBD/gluster block drivers

2015-02-02 Thread Denis V. Lunev
Changes from v1: - switched to UINT32_MAX for NBD - limited max_discard for gluster to SIZE_MAX on i686 only Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Peter Lieven

[Qemu-devel] [PATCH 2/2] nbd: fix max_discard

2015-02-02 Thread Denis V. Lunev
nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t as the length in bytes of the data to discard due to the following definition: struct nbd_request { uint32_t magic; uint32_t type; uint64_t handle; uint64_t from; uint32_t len; <-- the length of data to be d

[Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-02 Thread Denis V. Lunev
qemu_gluster_co_discard calculates size to discard as follows size_t size = nb_sectors * BDRV_SECTOR_SIZE; ret = glfs_discard_async(s->fd, offset, size, &gluster_finish_aiocb, acb); glfs_discard_async is declared as follows: int glfs_discard_async (glfs_fd_t *fd, off_t length, size_t len

Re: [Qemu-devel] [PATCH v3 04/14] block/xen: Use blk_new_open() in blk_connect()

2015-02-02 Thread Kevin Wolf
Am 26.01.2015 um 16:00 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > hw/block/xen_disk.c | 28 > 1 file changed, 12 insertions(+), 16 deletions(-) > > diff --git a/hw/block/xen_disk.c b/hw/block/xen_disk.c > index 21842a0..1b0257c 100644 > --- a/hw/bl

Re: [Qemu-devel] [PULL v2 00/12] RCU, scsi, modules, icount changes for 2015-01-30

2015-02-02 Thread Peter Maydell
On 2 February 2015 at 18:16, Paolo Bonzini wrote: > Can you merge up to commit 2aeba9d8a1b6121b98948fcd42fd2aa32f68b750 only > or should I respin without the final patch? My pullreq-application script doesn't like merging things which aren't branches or tags, I'm afraid. Can you respin? -- PMM

Re: [Qemu-devel] [PULL v2 00/12] RCU, scsi, modules, icount changes for 2015-01-30

2015-02-02 Thread Paolo Bonzini
On 02/02/2015 18:54, Peter Maydell wrote: > On 2 February 2015 at 16:29, Paolo Bonzini wrote: >> The important bits here are the first part of RCU and enabling >> modules by default. They have been tested with Travis for a few >> days now, and things seem okay. >> >> v1->v2 changes are the new

Re: [Qemu-devel] [PATCH] target-mips: fix detection of the end of the page during translation

2015-02-02 Thread Richard Henderson
On 01/26/2015 07:53 AM, Leon Alrae wrote: > The test is supposed to terminate TB if the end of the page is reached. > However, with current implementation it may never succeed for microMIPS or > mips16. > > Reported-by: Richard Henderson > Signed-off-by: Leon Alrae > --- > target-mips/translate

Re: [Qemu-devel] [PULL v2 00/12] RCU, scsi, modules, icount changes for 2015-01-30

2015-02-02 Thread Peter Maydell
On 2 February 2015 at 16:29, Paolo Bonzini wrote: > The important bits here are the first part of RCU and enabling > modules by default. They have been tested with Travis for a few > days now, and things seem okay. > > v1->v2 changes are the new qemu-thread patch to fix Mac OS X, > and cleaning u

Re: [Qemu-devel] [PATCH v2 0/4] block: Cleanups around error reporting

2015-02-02 Thread Max Reitz
On 2015-01-29 at 04:36, Markus Armbruster wrote: v2: * PATCH 4: Use error_setg() [Kevin] * R-bys retained Markus Armbruster (4): blockdev: Give find_block_job() an Error ** parameter blockdev: Eliminate silly QERR_BLOCK_JOB_NOT_ACTIVE macro block: New bdrv_add_key(), convert monitor to

Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Denis V. Lunev
On 02/02/15 20:34, Paolo Bonzini wrote: On 02/02/2015 18:00, Denis V. Lunev wrote: You are absolutely correct for NBD case but I do not get the point about SIZE_MAX for gluster. There is no such definition in their git at git://github.com/gluster/glusterfs nor in public API headers in Ubuntu

Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Paolo Bonzini
On 02/02/2015 18:00, Denis V. Lunev wrote: >> > You are absolutely correct for NBD case but I do not get the > point about SIZE_MAX for gluster. There is no such definition > in their git at git://github.com/gluster/glusterfs nor in > public API headers in Ubuntu :( SIZE_MAX is defined in stdint

[Qemu-devel] [PATCH 2/2] iotests: Add tests for overriding BDRV_O_PROTOCOL

2015-02-02 Thread Max Reitz
This adds tests for overriding the qemu-internal BDRV_O_PROTOCOL flag by explicitly specifying a block driver. As one test must be run over the NBD protocol while the other must not, this patch adds two separate iotests. Signed-off-by: Max Reitz --- tests/qemu-iotests/119 | 60 ++

[Qemu-devel] [PATCH 1/2] block: driver should override flags in bdrv_open()

2015-02-02 Thread Max Reitz
The BDRV_O_PROTOCOL flag should have an impact only if no driver is specified explicitly. Therefore, if bdrv_open() is called with an explicit block driver argument (either through the options QDict or through the drv parameter) and that block driver is a protocol block driver, BDRV_O_PROTOCOL shou

[Qemu-devel] [PATCH 0/2] block: driver should override flags in bdrv_open()

2015-02-02 Thread Max Reitz
BDRV_O_PROTOCOL is an internal qemu flag which a user should be able to override by explicitly specifying a block driver. This series implements this and adds two iotests (one for NBD, one for file) to test it. For the NBD test to succeed, this series relies on "iotests: Specify format for qemu-nb

Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Denis V. Lunev
On 02/02/15 19:45, Kevin Wolf wrote: Am 02.02.2015 um 17:25 hat Denis V. Lunev geschrieben: On 02/02/15 19:13, Kevin Wolf wrote: Am 02.02.2015 um 15:48 hat Peter Lieven geschrieben: do not trim requests if the driver does not supply a limit through BlockLimits. For write zeroes we still keep a

Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Kevin Wolf
Am 02.02.2015 um 17:25 hat Denis V. Lunev geschrieben: > On 02/02/15 19:13, Kevin Wolf wrote: > >Am 02.02.2015 um 15:48 hat Peter Lieven geschrieben: > >>do not trim requests if the driver does not supply a limit > >>through BlockLimits. For write zeroes we still keep a limit > >>for the unsupporte

[Qemu-devel] [PATCH 1/1] block: align bounce buffers to page

2015-02-02 Thread Denis V. Lunev
The following sequence int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644); for (i = 0; i < 10; i++) write(fd, buf, 4096); performs 5% better if buf is aligned to 4096 bytes. The difference is quite reliable. On the other hand we do not want at the moment to enforce

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-02 Thread Phil Sutter
Hi, On Mon, Feb 02, 2015 at 07:27:10AM +, David Woodhouse wrote: > On Sun, 2015-02-01 at 21:07 -0800, David Miller wrote: > > From: David Woodhouse > > Date: Sun, 01 Feb 2015 21:29:43 + > > > > > I really was looking for some way to push down something like an XFRM > > > state into the t

Re: [Qemu-devel] [PATCH 1/1] block: align bounce buffers to page

2015-02-02 Thread Denis V. Lunev
On 02/02/15 19:47, Paolo Bonzini wrote: On 02/02/2015 17:44, Denis V. Lunev wrote: +++ b/block/raw-posix.c @@ -667,7 +667,8 @@ static void raw_refresh_limits(BlockDriverState *bs, Error **errp) BDRVRawState *s = bs->opaque; raw_probe_alignment(bs, s->fd, errp); -bs->bl.opt_

Re: [Qemu-devel] [PATCH 1/1] block: align bounce buffers to page

2015-02-02 Thread Paolo Bonzini
On 02/02/2015 17:44, Denis V. Lunev wrote: > +++ b/block/raw-posix.c > @@ -667,7 +667,8 @@ static void raw_refresh_limits(BlockDriverState *bs, > Error **errp) > BDRVRawState *s = bs->opaque; > > raw_probe_alignment(bs, s->fd, errp); > -bs->bl.opt_mem_alignment = s->buf_align; >

[Qemu-devel] [PATCH v3 0/1] block: enforce minimal 4096 alignment in qemu_blockalign

2015-02-02 Thread Denis V. Lunev
The following sequence int fd = open(argv[1], O_RDWR | O_CREAT | O_DIRECT, 0644); for (i = 0; i < 10; i++) write(fd, buf, 4096); iperforms 5% better if buf is aligned to 4096 bytes rather then to 512 bytes. I have used the following program to test #define _GNU_SOURCE #inc

[Qemu-devel] [PATCH 1/2] glusterfs: fix max_discard

2015-02-02 Thread Denis V. Lunev
qemu_gluster_co_discard calculates size to discard as follows size_t size = nb_sectors * BDRV_SECTOR_SIZE; ret = glfs_discard_async(s->fd, offset, size, &gluster_finish_aiocb, acb); glfs_discard_async is declared as follows: int glfs_discard_async (glfs_fd_t *fd, off_t length, size_t len

[Qemu-devel] [PATCH 2/2] nbd: fix max_discard

2015-02-02 Thread Denis V. Lunev
nbd_co_discard calls nbd_client_session_co_discard which uses uint32_t as the length in bytes of the data to discard due to the following definition: struct nbd_request { uint32_t magic; uint32_t type; uint64_t handle; uint64_t from; uint32_t len; <-- the length of data to be d

Re: [Qemu-devel] [PULL 00/11] RCU, scsi, modules, icount changes for 2015-01-30

2015-02-02 Thread Paolo Bonzini
On 02/02/2015 16:03, Peter Maydell wrote: > On 2 February 2015 at 14:55, Paolo Bonzini wrote: >> and if it still fails, catch a backtrace of all threads? Whoa, this has been broken for a long, long time. Paolo > (gdb) thread apply all backtrace > > Thread 9 (process 42110): > #0 0x7fff9

[Qemu-devel] [PULL v2 00/12] RCU, scsi, modules, icount changes for 2015-01-30

2015-02-02 Thread Paolo Bonzini
The following changes since commit 83761b9244ad2ed39d3cfabe8a0e901ab906f7bf: Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20150127' into staging (2015-01-27 22:25:56 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for y

Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Denis V. Lunev
On 02/02/15 19:13, Kevin Wolf wrote: Am 02.02.2015 um 15:48 hat Peter Lieven geschrieben: do not trim requests if the driver does not supply a limit through BlockLimits. For write zeroes we still keep a limit for the unsupported path to avoid allocating a big bounce buffer. Suggested-by: Kevin

Re: [Qemu-devel] [PATCH] block: change default for discard and write zeroes to INT_MAX

2015-02-02 Thread Kevin Wolf
Am 02.02.2015 um 15:48 hat Peter Lieven geschrieben: > do not trim requests if the driver does not supply a limit > through BlockLimits. For write zeroes we still keep a limit > for the unsupported path to avoid allocating a big bounce buffer. > > Suggested-by: Kevin Wolf > Suggested-by: Denis V.

Re: [Qemu-devel] [PATCH v4 0/5] this series adds the long missing multiread support to virtio-blk.

2015-02-02 Thread Kevin Wolf
Am 02.02.2015 um 14:52 hat Peter Lieven geschrieben: > some remarks: > - i introduced rd_merged and wr_merged block accounting stats to >blockstats as a generic interface which can be set from any >driver that will introduce multirequest merging in the future. > - the old multiwrite inter

Re: [Qemu-devel] [PATCH v2 06/47] acpi: add acpi_name() & acpi_name_decl() term

2015-02-02 Thread Igor Mammedov
On Fri, 23 Jan 2015 15:42:30 +0200 "Michael S. Tsirkin" wrote: > On Fri, Jan 23, 2015 at 02:32:45PM +0100, Igor Mammedov wrote: > > On Fri, 23 Jan 2015 10:59:48 +0200 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jan 22, 2015 at 02:49:50PM +, Igor Mammedov wrote: > > > > Signed-off-by:

[Qemu-devel] [PATCH] qemu-thread: fix qemu_event without futexes

2015-02-02 Thread Paolo Bonzini
This had a possible deadlock that was visible with rcutorture. qemu_event_setqemu_event_wait cmpxchg reads FREE, writes BUSY fute

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-02 Thread David Woodhouse
On Mon, 2015-02-02 at 16:23 +0100, Phil Sutter wrote: > Since you want to provide connectivity over HTTPS which is not possible > in kernel space, you are stuck with keeping the tun device. So the > packet flow in that case is identical to how e.g. OpenVPN does it: > > - tunX holds default route >

Re: [Qemu-devel] [PATCH v2] qga: add guest-set-admin-password command

2015-02-02 Thread Daniel P. Berrange
Ping On Mon, Jan 12, 2015 at 03:58:14PM +, Daniel P. Berrange wrote: > Add a new 'guest-set-admin-password' command for changing the > root/administrator password. This command is needed to allow > OpenStack to support its API for changing the admin password > on a running guest. > > Accepts

Re: [Qemu-devel] [PATCH 7/7] block/raw-posix: set max_write_zeroes to INT_MAX for regular files

2015-02-02 Thread Denis V. Lunev
On 02/02/15 17:49, Kevin Wolf wrote: Am 02.02.2015 um 15:20 hat Peter Lieven geschrieben: Am 02.02.2015 um 15:16 schrieb Kevin Wolf: Am 02.02.2015 um 15:12 hat Peter Lieven geschrieben: Am 02.02.2015 um 15:04 schrieb Kevin Wolf: Am 02.02.2015 um 14:55 hat Peter Lieven geschrieben: Am 02.02.2

Re: [Qemu-devel] [PATCH] tun: orphan an skb on tx

2015-02-02 Thread David Woodhouse
On Mon, 2015-02-02 at 09:24 +0100, Steffen Klassert wrote: > > Maybe you want to use a virtual tunnel interface (vti) what we have > already. Everything that is routed through such an interface is > guaranteed to be either encrypted if a matching xfrm state is present > or dropped. Same on the rce

[Qemu-devel] [PATCH] ui/vnc: optimize full scanline updates

2015-02-02 Thread Peter Lieven
in case we send and update for a complete scanline increment the y offset to avoid running to find_next_bit for that lines twice. Signed-off-by: Peter Lieven --- ui/vnc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index a742c90..6fa2ee7 100644 --- a/ui/vnc.c ++

  1   2   >