On Thu, Jan 29, 2015 at 12:07:42PM +1100, David Gibson wrote:
> On Thu, Jan 08, 2015 at 11:40:11AM +0530, Bharata B Rao wrote:
> > Move some CPU initialization code from machine init function to
> > CPU realizefn so that it can be used from CPU hotplug path too.
> >
> > With the inclusion of ppc.h
On Thu, Jan 29, 2015 at 12:16:09PM +1100, David Gibson wrote:
> On Thu, Jan 08, 2015 at 11:40:12AM +0530, Bharata B Rao wrote:
> > -int spapr_rtas_device_tree_setup(void *fdt, hwaddr rtas_addr,
> > - hwaddr rtas_size)
> > +int spapr_rtas_device_tree_setup(sPAPREnviro
Gonglei writes:
> On 2015/1/30 0:03, Alexander Graf wrote:
>
>>
>>
>> On 29.01.15 14:29, arei.gong...@huawei.com wrote:
>>> From: Gonglei
>>>
>>> If boot order is invaild or is set failed,
>>> exit qemu.
>>>
>>> Signed-off-by: Gonglei
>>
>> Do we really want to kill the machine only because
Adding Knut to CC as he particularly looked into and fixed the bridging
issues or the vtd emulation. I will have to refresh my memories first.
Jan
On 2015-01-30 06:45, Benjamin Herrenschmidt wrote:
> Hi folks !
>
>
> I've looked at the intel iommu code to try to figure out how to properly
> imp
On 2015-01-30 00:06, Paolo Bonzini wrote:
>
>
> On 29/01/2015 20:37, Marc Marí wrote:
>> Is this an expected behaviour? I can't see why.
>>
>> I'd like to know if there is a certain reason why it doesn't work. Or
>> if it should work and the problem is too much I/O overhead. Or any
>> other hint
On Fri, Jan 23, 2015 at 01:41:38PM +0100, Igor Mammedov wrote:
> On Thu, 8 Jan 2015 11:40:13 +0530
> Bharata B Rao wrote:
>
> > Support CPU hotplug via device-add command. Use the exising EPOW event
> > infrastructure to send CPU hotplug notification to the guest.
> >
> > Signed-off-by: Bharata
Public bug reported:
Environment:
Host OS (ia32/ia32e/IA64):ia32e
Guest OS (ia32/ia32e/IA64):ia32e
Guest OS Type (Linux/Windows):Linux
kvm.git Commit:8fff5e374a2f6047d1bb52288af7da119bc75765
qemu.kvm Commit:16017c48547960539fcadb1f91d252124f442482
Host Kernel Version:3.19.0-rc3
Hardwa
Set initial MAC address to the one specified by the command line.
Signed-off-by: Sebastian Huber
Reviewed-by: Jason Wang
v2: Remove superfluous whitespace change.
---
hw/net/cadence_gem.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_gem.c
inde
Hi folks !
I've looked at the intel iommu code to try to figure out how to properly
implement a Power8 "native" iommu model and encountered some issues.
Today "pseries" ppc machine is paravirtualized and so uses a pretty
simplistic iommu model that essentially has one address space per host
brid
On 01/29/2015 08:59 PM, Sebastian Huber wrote:
> Set initial MAC address to the one specified by the command line.
>
> Signed-off-by: Sebastian Huber
> ---
> hw/net/cadence_gem.c | 7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/hw/net/cadence_gem.c b/hw/net/cadence_
On 30/01/15 01:50, Max Reitz wrote:
On 2015-01-28 at 13:38, Denis V. Lunev wrote:
There is a possibility that we are extending our image and thus writing
zeroes beyond the end of the file. In this case we do not need to care
about the hole to make sure that there is no data in the file under
thi
Peter,
On 01/30/15 05:31, Laszlo Ersek wrote:
> Signed-off-by: Laszlo Ersek
> ---
> hw/arm/virt.c | 32
> 1 file changed, 28 insertions(+), 4 deletions(-)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 2353440..091e5ee 100644
> --- a/hw/arm/virt.c
> +++
Signed-off-by: Laszlo Ersek
---
hw/arm/virt.c | 32
1 file changed, 28 insertions(+), 4 deletions(-)
diff --git a/hw/arm/virt.c b/hw/arm/virt.c
index 2353440..091e5ee 100644
--- a/hw/arm/virt.c
+++ b/hw/arm/virt.c
@@ -441,10 +441,27 @@ static void create_virtio_d
Hi!
Forgot to mention - this is RFC only as 1) it depends on the host kernel
changes 2) does not support migration for emulated PHB + DDW, I think I
have to give David's idea with TCE table stub object a go.
Thanks
On 01/29/2015 08:27 PM, Alexey Kardashevskiy wrote:
> At the moment sPAPR PHB s
QMP command "block_set_io_throttle" expects underscores in parameters
instead of dashes: {iops,bps}_{rd,wr,max}.
Add optional argument conv_keys (defaults to True, backward compatible),
it will be used in IO throttling test case.
Reviewed-by: Benoit Canet
Signed-off-by: Fam Zheng
Reviewed-by: M
This will enable accounting of aio requests issued from qemu-io aio
read/write commands.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
qemu-io-cmds.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c
index e708552..29377cd 100644
--- a/qemu-i
This case utilizes qemu-io command "aio_{read,write} -q" to verify the
effectiveness of IO throttling options.
It's implemented by driving the vm timer from qtest protocol, so the
throttling timers are signaled with determinied time duration. Then we
verify the completed IO requests are within 10%
This adds scripts/qtest.py as a python library for qtest protocol.
This is a skeleton with a basic "cmd" method to execute a command,
reading and parsing of qtest output could be added later on demand.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
scripts/qtest.py | 71 ++
This will allow test cases to run command in qtest protocol. It's
write-only for now.
Signed-off-by: Fam Zheng
Reviewed-by: Max Reitz
---
tests/qemu-iotests/iotests.py | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qem
v7: Remove any "{iops,bps}_max" in 093 completely. (Max)
v6: Less resource demanding patch 5. (Max)
Add rev-by of Max to other patches.
v5: Rebase and improve the test. Please review again.
Patch dependencies:
This test depends on the qtest timer fix to run correctly.
http://lis
On Thu, 01/29 09:29, Max Reitz wrote:
> Would it be possible to just remove {b,io}ps_max completely from this test?
> I'd be fine with that.
Sure, will resend.
Fam
>
> Max
On 01/29/15 14:14, Don Slutz wrote:
> On 01/29/15 07:09, Paul Durrant wrote:
>>> -Original Message-
>>> From: Don Slutz [mailto:dsl...@verizon.com]
>>> Sent: 29 January 2015 00:58
>>> To: Don Slutz; Paul Durrant; qemu-devel@nongnu.org; Stefano Stabellini
>>> Cc: Peter Maydell; Olaf Hering;
On Thu, Jan 29, 2015 at 06:55:13PM +, Peter Maydell wrote:
> Instead of simply reusing ats_write() as the handler for both AArch32
> and AArch64 address translation operations, use a different function
> for each with the common code in a third function. This is necessary
> because the semantic
to Dr. David Alan Gilbert (dgilbert-h):
qemu 1.5.3-60 or 82 in rhel 7.0 has the problem,
qemu 0.12.1-x in rhel 6.5 has not the problem.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1397157
Title:
From: Gonglei
Reproducer:
$ x86_64-softmmu/qemu-system-x86_64
qemu-system-x86_64: Invalid parameter 'to'
Segmentation fault (core dumped)
Fix:
https://bugs.launchpad.net/qemu/+bug/1414222
Patch 1~2 is bugfix, patch 3 is trivial.
v2 -> v1:
- change commit message of patch 1. (Don Slutz)
Gongl
From: Gonglei
Signed-off-by: Gonglei
---
ui/vnc.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 23f413e..4bae970 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -3322,8 +3322,8 @@ void vnc_display_open(const char *id, Error **errp)
QemuOpt
From: Gonglei
Missing three property for vnc socket connection,
revalue display variable with correct way.
Signed-off-by: Gonglei
---
ui/vnc.c | 26 +++---
1 file changed, 23 insertions(+), 3 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 08b8b24..23f413e 100644
--- a
From: Gonglei
Add missing vnc options: to, ipv4, ipv6 and fix
qemu crash.
Reproducer:
$ x86_64-softmmu/qemu-system-x86_64
qemu-system-x86_64: Invalid parameter 'to'
Segmentation fault (core dumped)
BTW the patch fix the below bug:
https://bugs.launchpad.net/qemu/+bug/1414222
Signed-off-by: Gon
On Thu, Jan 29, 2015 at 06:55:14PM +, Peter Maydell wrote:
> Make all the callers of get_phys_addr() pass it the correct
> mmu_idx rather than just a simple "is_user" flag. This includes
> properly decoding the AT/ATS system instructions; we include the
> logic for handling all the opc1/opc2 ca
On Thu, Jan 29, 2015 at 06:55:15PM +, Peter Maydell wrote:
> Now we have the mmu_idx in get_phys_addr(), use it correctly to
> determine the behaviour of virtual to physical address translations,
> rather than using just an is_user flag and the current CPU state.
>
> Some TODO comments have be
The next patch will make MMIO space bigger and keep the old value for
older pseries machines.
Signed-off-by: Alexey Kardashevskiy
---
hw/ppc/spapr.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index b560459..65433fd 100
At the moment sPAPR only supports 512MB window for MMIO BARs. However
modern devices might want bigger 64bit BARs.
This extends MMIO window from 512MB to 62GB (aligned to
SPAPR_PCI_WINDOW_SPACING) and advertises it in 2 records in
the PHB "ranges" property. 32bit gets the space from
SPAPR_PCI_MEM_
On Thu, Jan 29, 2015 at 06:55:12PM +, Peter Maydell wrote:
> target-arm doesn't use any of the MMU-mode specific cpu ldst
> accessor functions. Suppress their generation by not defining
> any of the MMU_MODE*_SUFFIX macros. ("user" and "kernel" are
> too simplistic as descriptions of indexes 0
This defines a new pseries machine and adds huge bars support which is
disabled by default on older pseries machines.
Please comment. Thanks!
Changes:
v4:
* added pseries-2.3
* now it is 2 patches instead of one :)
Alexey Kardashevskiy (2):
spapr: Add pseries-2.3 machine
spapr-pci: Enable h
On Thu, Jan 29, 2015 at 06:55:17PM +, Peter Maydell wrote:
> This patch fixes the brace style in the code reindented in the
> previous commit.
>
> Signed-off-by: Peter Maydell
> Reviewed-by: Greg Bellows
Reviewed-by: Edgar E. Iglesias
> ---
> target-arm/helper.c | 36
> > > I think that the xenstore_update function should be moved to a new file:
> > > we don't want xen_backend.c to be handling any frontend updates.
> > > Maybe you could create a new file, hw/xen/xen_pvdev.c?
> > >
> >
> > Stefano,
> > I'd like to create hw/xen/xen_pvdev.c , include/hw/xen/
On Thu, Jan 29, 2015 at 06:55:16PM +, Peter Maydell wrote:
> A few of the oldest parts of the page-table-walk code have broken indent
> (either hardcoded tabs or two-spaces). Reindent these sections.
>
> For ease of review, this patch does not touch the brace style and
> so is a whitespace-onl
Would anyone know what the *run_in() function is expected to do when it is
implemented? It is located in audio/audio_int.h.
On Thu, Jan 29, 2015 at 06:55:06PM +, Peter Maydell wrote:
> This patchseries fixes up our somewhat broken handling of mmu_idx values:
> * implement the full set of 7 mmu_idxes we need for supporting EL2 and EL3
> * pass the mmu_idx in the TB flags rather than EL or a priv flag,
>so we ca
On 01/26/2015 12:27 PM, Max Reitz wrote:
> Replace bdrv_drain_all(), bdrv_commmit_all(), bdrv_flush_all(),
> bdrv_invalidate_cache_all(), bdrv_next() and occurrences of bdrv_states
> by their BlockBackend equivalents.
>
> Signed-off-by: Max Reitz
> ---
> block.c | 22 --
On 2015/1/29 18:50, Wei Liu wrote:
On Thu, Jan 29, 2015 at 08:41:24AM +0800, Chen, Tiejun wrote:
On 2015/1/28 19:12, Wei Liu wrote:
On Wed, Jan 28, 2015 at 08:42:56AM +0800, Chen, Tiejun wrote:
On 2015/1/27 22:40, Ian Jackson wrote:
Chen, Tiejun writes ("Re: [Qemu-devel] [RFC][PATCH 1/1] libx
On 2015/1/30 0:03, Alexander Graf wrote:
>
>
> On 29.01.15 14:29, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> If boot order is invaild or is set failed,
>> exit qemu.
>>
>> Signed-off-by: Gonglei
>
> Do we really want to kill the machine only because the boot device
> string doesn't
Post-holiday bump that this is sitting out there, awaiting love.
If this gets merged, we should be able to enable Q35 migration soon,
which would be nice.
--js
On 12/16/2014 08:35 PM, John Snow wrote:
This series was written mostly by Paolo Bonzini to do two things:
1. Unify the restart call
On 2015/1/30 0:14, Don Slutz wrote:
> On 01/29/15 07:52, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> Reproducer:
>> $ x86_64-softmmu/qemu-system-x86_64
>> qemu-system-x86_64: Invalid parameter 'to'
>> Segmentation fault (core dumped)
>>
>> Signed-off-by: Gonglei
>> ---
>> ui/vnc.c | 9
On 2015/1/30 0:10, Don Slutz wrote:
> On 01/29/15 07:52, arei.gong...@huawei.com wrote:
>> From: Gonglei
>>
>> Reproducer:
>> $ x86_64-softmmu/qemu-system-x86_64
>> qemu-system-x86_64: Invalid parameter 'to'
>> Segmentation fault (core dumped)
>>
>
> This looks to be a fix for
>
> Subject: [Qem
On 01/26/2015 12:27 PM, Max Reitz wrote:
> These functions will be changed to iterate through the BDS trees as
> defined by the BlockBackends instead of the list of root BDS, therefore
> prepare moving their code to the BlockBackend level.
>
> Signed-off-by: Max Reitz
> ---
> block/block-backend
On Thu, Jan 29, 2015 at 06:55:09PM +, Peter Maydell wrote:
> The LDT/STT (load/store unprivileged) instruction decode was using
> the wrong MMU index value. This meant that instead of these insns
> being "always access as if user-mode regardless of current privilege"
> they were "always access
On 01/26/2015 12:27 PM, Max Reitz wrote:
> This function skips to the next BlockBackend for which blk_is_inserted()
> is true.
>
> Signed-off-by: Max Reitz
> ---
> block/block-backend.c | 15 +++
> include/sysemu/block-backend.h | 1 +
> 2 files changed, 16 insertions(+)
>
On 01/26/2015 12:27 PM, Max Reitz wrote:
> There may be BlockBackends which are not returned by blk_by_name(), but
> do exist and have a name. blk_name_taken() allows testing whether a
> specific name is in use already, independent of whether the BlockBackend
> with that name is accessible through
On 01/26/2015 12:27 PM, Max Reitz wrote:
> There are no users of bdrv_close() left, except for one of bdrv_open()'s
> failure paths, bdrv_close_all() and bdrv_delete(), and that is good.
> Make bdrv_close() static so nobody makes the mistake of directly using
> bdrv_close() again.
>
> Signed-off-b
On 01/26/2015 12:27 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> blockdev.c | 6 +-
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.as
On 01/26/2015 12:27 PM, Max Reitz wrote:
> Signed-off-by: Max Reitz
> ---
> block/block-backend.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
Reviewed-by: Eric Blake
--
Eric Blake eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org
On 01/26/2015 12:27 PM, Max Reitz wrote:
> They are unused, and bdrv_close_all() is a perfectly valid replacement.
>
> Signed-off-by: Max Reitz
> ---
> block.c| 7 ---
> block/block-backend.c | 7 ---
> include/block/block.h | 1 -
> include/bloc
On Thu, Jan 29, 2015 at 06:22:22PM +0100, Kashyap Chamarthy wrote:
> On Thu, Jan 29, 2015 at 04:47:23PM +, Richard W.M. Jones wrote:
> > On Thu, Jan 29, 2015 at 05:25:09PM +0100, Kashyap Chamarthy wrote:
[. . .]
> > > On the shell where `qemu-nbd` is running, I notice this
> > >
> > > nbd.
On 01/22/2015 01:51 AM, Pavel Dovgalyuk wrote:
> This patch adds global variables, defines, functions declarations,
> and function stubs for deterministic VM replay used by external modules.
>
> Signed-off-by: Pavel Dovgalyuk
> ---
> Makefile.target |1 +
> qapi-schema.json | 18 +
On 29/01/2015 16:06, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> The attached patch allows you to execute QMP commands from the command
> line prior to -incoming or loadvm.
What about doing the opposite: if you specify -S, and thus the runstate
is PRELAUNCH, allow
On 29/01/2015 20:37, Marc Marí wrote:
> Is this an expected behaviour? I can't see why.
>
> I'd like to know if there is a certain reason why it doesn't work. Or
> if it should work and the problem is too much I/O overhead. Or any
> other hint to understand it.
It is due to latencies in the hos
On 2015-01-28 at 13:38, Denis V. Lunev wrote:
fallocate() works fine and could handle properly with arbitrary size
requests. There is no sense to reduce the amount of space to fallocate.
The bigger is the size, the better is the performance as the amount of
journal updates is reduced.
The patch
On 2015-01-28 at 13:38, Denis V. Lunev wrote:
There is a possibility that we are extending our image and thus writing
zeroes beyond the end of the file. In this case we do not need to care
about the hole to make sure that there is no data in the file under
this offset (pre-condition to fallocate(
On 2015-01-28 at 13:38, Denis V. Lunev wrote:
This sequence works efficiently if FALLOC_FL_ZERO_RANGE is not supported.
Unfortunately, FALLOC_FL_ZERO_RANGE is supported on really modern systems
and only for a couple of filesystems. FALLOC_FL_PUNCH_HOLE is much more
mature.
The sequence of 2 oper
On 2015-01-28 at 13:38, Denis V. Lunev wrote:
This efficiently writes zeroes on Linux if the kernel is capable enough.
FALLOC_FL_ZERO_RANGE correctly handles all cases, including and not
including file expansion.
Signed-off-by: Denis V. Lunev
CC: Max Reitz
CC: Kevin Wolf
CC: Stefan Hajnoczi
Just a ping.
There has been some feedback here, but I am hesitant to roll out a v12
until there is a little more consensus from Eric Blake and Markus
Armbruster on the parameter naming issue, as well as a cursory overview
by Stefan or Kevin of the "successor" methodology.
--js
On 01/12/2015
On 01/07/2015 10:10 PM, Bharata B Rao wrote:
> This patchset enables CPU and memory hotplug support for PowerPC guests.
I missed seeing this as the qemu-ppc list was not included. Can you
please add myself and Nathan on Cc in the future as well.
Tyrel
>
> Changes in this patchset (v1):
>
> - B
On 01/29/2015 01:21 PM, Dr. David Alan Gilbert wrote:
> * Eric Blake (ebl...@redhat.com) wrote:
>> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote:
>>>
>>> So what would the .args_type look like in qmp-commands.hx; something like
>>> this?
>>>
>>> .args-type = "type:s,port:-i,host:-s,comman
Hi - could you all specify the exact qemu versions you are using please
(If it's a packaged version please give the package version).
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1397157
Title:
cp
* Eric Blake (ebl...@redhat.com) wrote:
> On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote:
> >
> > So what would the .args_type look like in qmp-commands.hx; something like
> > this?
> >
> > .args-type = "type:s,port:-i,host:-s,command:-s"
>
> No, it would be more like the blockdev-add i
On 29 January 2015 at 19:47, Laszlo Ersek wrote:
> On 01/29/15 20:12, Laszlo Ersek wrote:
>> If the guest kernel changed its "assignment strategy" at some point, but
>> earlier it used to match the comment (and the code), then whichever way
>> we shape the comment will be wrong for the other kerne
On 01/29/15 20:12, Laszlo Ersek wrote:
> On 01/29/15 20:01, Peter Maydell wrote:
>> On 29 January 2015 at 18:29, Laszlo Ersek wrote:
>>> Yes. The DTB is 100% fine. However, we're talking two independent
>>> mappings here. The lower level mapping is the DTB, and that's completely
>>> fine. It's han
On 01/29/2015 09:58 AM, Markus Armbruster wrote:
The test uses QMP introspection to find PCI devices, then tries to
cold-plug each of them. Could be extended to hot-plug and unplug.
The tests' QMP introspection part is patterned after Andreas's
qom-test, which uses QMP to find machine types.
>> On 01/29/15 07:09, Paul Durrant wrote:
...
>> Given that IIRC you are using a new dedicated IOREQ type, I
>> think there needs to be something that allows an emulator to
>> register for this IOREQ type. How about adding a new type to
>> those defined for HVMOP_map_io_range_to_ioreq_server for yo
Hi
I tried to run a Linux Kernel with Preempt RT patch on a QEMU emulated
machine using TCG (ARM guest, x86_64 guest).
I expected the guest to have high latencies, but more or less constant.
But I found, using cyclictest, a lot of randomness and a lot of
difference between the average and the max
On 01/29/15 20:09, Richard W.M. Jones wrote:
> On Thu, Jan 29, 2015 at 07:29:09PM +0100, Laszlo Ersek wrote:
>> On 01/29/15 19:15, Peter Maydell wrote:
>>> On 29 January 2015 at 17:25, Laszlo Ersek wrote:
I find that virtio-mmio devices are assigned highest-to-lowest addresses
as they ar
The helper functions for FRECPS and FRSQRTS have special case
handling that includes checks for zero inputs, so squash input
denormals if necessary before those checks. This fixes incorrect
output when the FPCR DZ bit is set to enable squashing of input
denormals.
Signed-off-by: Peter Maydell
---
On 29 January 2015 at 19:09, Richard W.M. Jones wrote:
> On Thu, Jan 29, 2015 at 07:29:09PM +0100, Laszlo Ersek wrote:
>> On 01/29/15 19:15, Peter Maydell wrote:
>> > Note that you can't rely on device ordering anyway. Guests
>> > should be using UUIDs or similar to ensure they mount the
>> > righ
On 28 January 2015 at 15:57, Peter Maydell wrote:
> On 28 January 2015 at 15:54, Alex Bennée wrote:
>> Do we have test cases that trip up here? It would be nice to include
>> them in our testing as the random nature of RISU has obviously failed to
>> trip up on this instruction.
>
> Risu would pr
The MMU index to use for unprivileged loads and stores is more
complicated than we currently implement:
* for A64, it should be "if at EL1, access as if EL0; otherwise
access at current EL"
* for A32/T32, it should be "if EL2, UNPREDICTABLE; otherwise
access as if at EL0".
In both cases, i
We currently claim that for ARM the mmu_idx should simply be the current
exception level. However this isn't actually correct -- secure EL0 and EL1
should have separate indexes from non-secure EL0 and EL1 since their
VA->PA mappings may differ. We also will want an index for stage 2
translations wh
This patchseries fixes up our somewhat broken handling of mmu_idx values:
* implement the full set of 7 mmu_idxes we need for supporting EL2 and EL3
* pass the mmu_idx in the TB flags rather than EL or a priv flag,
so we can generate code with the correct kind of access
* identify the correct
Instead of simply reusing ats_write() as the handler for both AArch32
and AArch64 address translation operations, use a different function
for each with the common code in a third function. This is necessary
because the semantics for selecting the right translation regime are
different; we are only
On 28 January 2015 at 15:40, Xiangyu Hu wrote:
> While FMULX returns a 2.0f float when two operators are infinity and
> zero, those operators should be unpacked from raw inputs first. Inconsistent
> cases would occur when operators are denormalized floats in flush-to-zero
> mode. A wrong codepath
On 01/29/15 07:09, Paul Durrant wrote:
>> -Original Message-
>> From: Don Slutz [mailto:dsl...@verizon.com]
>> Sent: 29 January 2015 00:58
>> To: Don Slutz; Paul Durrant; qemu-devel@nongnu.org; Stefano Stabellini
>> Cc: Peter Maydell; Olaf Hering; Alexey Kardashevskiy; Stefan Weil; Michael
On 01/29/15 20:01, Peter Maydell wrote:
> On 29 January 2015 at 18:29, Laszlo Ersek wrote:
>> Yes. The DTB is 100% fine. However, we're talking two independent
>> mappings here. The lower level mapping is the DTB, and that's completely
>> fine. It's handled by the second loop in create_virtio_devi
On Thu, Jan 29, 2015 at 07:29:09PM +0100, Laszlo Ersek wrote:
> On 01/29/15 19:15, Peter Maydell wrote:
> > On 29 January 2015 at 17:25, Laszlo Ersek wrote:
> >> I find that virtio-mmio devices are assigned highest-to-lowest addresses
> >> as they are found on the command line. IOW, this code (fro
Make all the callers of get_phys_addr() pass it the correct
mmu_idx rather than just a simple "is_user" flag. This includes
properly decoding the AT/ATS system instructions; we include the
logic for handling all the opc1/opc2 cases because we'll need
them later for supporting EL2/EL3, even if we do
On 29 January 2015 at 18:29, Laszlo Ersek wrote:
> Yes. The DTB is 100% fine. However, we're talking two independent
> mappings here. The lower level mapping is the DTB, and that's completely
> fine. It's handled by the second loop in create_virtio_devices(). But,
> that mapping in the DTB doesn't
Now we have the mmu_idx in get_phys_addr(), use it correctly to
determine the behaviour of virtual to physical address translations,
rather than using just an is_user flag and the current CPU state.
Some TODO comments have been added to indicate where changes will
need to be made to add EL2 and 64
This patch fixes the brace style in the code reindented in the
previous commit.
Signed-off-by: Peter Maydell
Reviewed-by: Greg Bellows
---
target-arm/helper.c | 36 +++-
1 file changed, 23 insertions(+), 13 deletions(-)
diff --git a/target-arm/helper.c b/target-
The LDT/STT (load/store unprivileged) instruction decode was using
the wrong MMU index value. This meant that instead of these insns
being "always access as if user-mode regardless of current privilege"
they were "always access as if kernel-mode regardless of current
privilege". This went unnoticed
A few of the oldest parts of the page-table-walk code have broken indent
(either hardcoded tabs or two-spaces). Reindent these sections.
For ease of review, this patch does not touch the brace style and
so is a whitespace-only change.
Signed-off-by: Peter Maydell
Reviewed-by: Greg Bellows
---
Although M profile doesn't have the same concept of exception level
as A profile, it does have a notion of privileged versus not, which
we currently track in the privmode TB flag. Support returning this
information if arm_current_el() is called on an M profile core, so
that we can identify the corr
target-arm doesn't use any of the MMU-mode specific cpu ldst
accessor functions. Suppress their generation by not defining
any of the MMU_MODE*_SUFFIX macros. ("user" and "kernel" are
too simplistic as descriptions of indexes 0 and 1 anyway.)
Signed-off-by: Peter Maydell
Reviewed-by: Greg Bellows
Support guest CPUs which need 7 MMU index values.
Add a comment about what would be required to raise the limit
further (trivial for 8, TCG backend rework for 9 or more).
Signed-off-by: Peter Maydell
Reviewed-by: Greg Bellows
---
include/exec/cpu_ldst.h | 28 +---
1 file
On 01/29/15 19:15, Peter Maydell wrote:
> On 29 January 2015 at 17:25, Laszlo Ersek wrote:
>> I find that virtio-mmio devices are assigned highest-to-lowest addresses
>> as they are found on the command line. IOW, this code (from commit
>> f5fdcd6e):
>>
>> /* Note that we have to create the tr
On 26 January 2015 at 11:21, Paolo Bonzini wrote:
> On 26/01/2015 11:44, Peter Maydell wrote:
>> Ping for review of this v2 (for code, if you like, but primarily
>> for methodology and sanity of the relicensing; we can always fix
>> code bugs later).
>
> For the method and sanity:
>
> Reviewed-by:
On 29 January 2015 at 17:25, Laszlo Ersek wrote:
> I find that virtio-mmio devices are assigned highest-to-lowest addresses
> as they are found on the command line. IOW, this code (from commit
> f5fdcd6e):
>
> /* Note that we have to create the transports in forwards order
> * so that com
On 29/01/2015 18:25, Laszlo Ersek wrote:
> Another possibility would be to replace QLIST_INSERT_HEAD() with
> QTAILQ_INSERT_TAIL() in qbus_realize(), but compared to the virt board
> code, that could very easily regress stuff.
Yes, this would be an ABI change.
Paolo
Hi,
Am 08.01.2015 um 07:10 schrieb Bharata B Rao:
> This patchset enables CPU and memory hotplug support for PowerPC guests.
>
> Changes in this patchset (v1):
>
> - Based on top of Michael Roth's tree
> (https://github.com/mdroth/qemu/commits/spapr-hotplug-core) which serves
> as base for h
On 01/29/2015 09:28 AM, Dr. David Alan Gilbert wrote:
>
> So what would the .args_type look like in qmp-commands.hx; something like
> this?
>
> .args-type = "type:s,port:-i,host:-s,command:-s"
No, it would be more like the blockdev-add interface, where one command
accepts a dictionary object
On Thu, 29 Jan 2015, Markus Armbruster wrote:
> Stefano Stabellini writes:
>
> > On Thu, 29 Jan 2015, Markus Armbruster wrote:
> >> Reproducer: qemu -nodefaults -S -display none -device xen-platform
> >>
> >> Yes, xen-platform makes no sense without Xen, but it shouldn't crash.
> >
> > Is it jus
On Thu, 29 Jan 2015, Xu, Quan wrote:
> > -Original Message-
> > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com]
> > Sent: Tuesday, January 20, 2015 1:15 AM
> > To: Xu, Quan
> > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org;
> > stefano.stabell...@eu.citrix.com
> > Su
1 - 100 of 295 matches
Mail list logo
