Re: [Qemu-devel] [PATCH v3 0/13] migration: Add a new feature to do live migration

2014-12-23 Thread Li, Liang Z
> -Original Message- > From: Li, Liang Z > Sent: Friday, December 12, 2014 9:29 AM > To: qemu-devel@nongnu.org > Cc: quint...@redhat.com; lcapitul...@redhat.com; ebl...@redhat.com; > arm...@redhat.com; Zhang, Yang Z; dgilb...@redhat.com; Li, Liang Z > Subject: [PATCH v3 0/13] migration: Add

Re: [Qemu-devel] [PATCH 1/2] target-arm : update reference manual chapter number

2014-12-23 Thread Chih-Min Chao
On Wed, Dec 24, 2014 at 1:50 AM, Peter Maydell wrote: > On 23 December 2014 at 16:25, Chih-Min Chao wrote: > > Update the reference manual version to DDI0487A_c > > > > Instruction set encoding is moved from C3 to C4 > > Instruction set Description is moved from C5/C6 to C6/C7 > > I

Re: [Qemu-devel] [PATCH] target-arm: add dump-guest-memory support

2014-12-23 Thread Peter Maydell
On 23 December 2014 at 23:29, Rabin Vincent wrote: > Enable support for the dump-guest-memory command on ARM and AArch64. > The dumped files can be analyzed with crash or similar tools. > > Signed-off-by: Rabin Vincent Thanks -- looks pretty good. One nit and some annoying corner cases you may n

[Qemu-devel] [PATCH] target-arm: add dump-guest-memory support

2014-12-23 Thread Rabin Vincent
Enable support for the dump-guest-memory command on ARM and AArch64. The dumped files can be analyzed with crash or similar tools. Signed-off-by: Rabin Vincent --- target-arm/Makefile.objs | 2 +- target-arm/arch_dump.c | 148 +++ target-arm/cpu-qo

Re: [Qemu-devel] [PATCH 0/2] target-ppc: Fix clang and w32 warnings

2014-12-23 Thread Alexander Graf
On 23.12.14 23:22, Peter Maydell wrote: > These patches fix compiler warnings from clang and the mingw32 > compiler; the aim is to get to a point where we can make the > warnings into errors for both these builds. Thanks, applied both to ppc-next. Alex

[Qemu-devel] clang -fsanitize=undefined warnings in the string visitors

2014-12-23 Thread Peter Maydell
If you do a clang build with -fsanitize=undefined, then you get some sanitizer errors in make check: TEST: tests/test-string-output-visitor... (pid=31713) /string-visitor/output/int: OK /string-visitor/output/int:

Re: [Qemu-devel] [PATCH 2/2] target-ppc: Cast ssize_t to size_t before printing with %zx

2014-12-23 Thread Peter Maydell
On 23 December 2014 at 22:50, Eric Blake wrote: > What's the actual compiler warning you got? This feels like it won't > work if the real problem is the compiler telling you that %z is unknown; > conversely, if it is a mismatch between 'size_t' vs. 'ssize_t', we > probably ought to report it to th

Re: [Qemu-devel] [PATCH] target-tricore: Add missing ULL suffix on 64 bit constant

2014-12-23 Thread Bastian Koppelmann
On 12/23/2014 10:24 PM, Peter Maydell wrote: Add a missing ULL suffix to a 64 bit constant: this suppresses a compiler warning from mingw32 gcc. Signed-off-by: Peter Maydell --- target-tricore/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied it to my trico

Re: [Qemu-devel] [PATCH 2/2] target-ppc: Cast ssize_t to size_t before printing with %zx

2014-12-23 Thread Eric Blake
On 12/23/2014 03:22 PM, Peter Maydell wrote: > The mingw32 compiler complains about trying to print variables of type > ssize_t with the %z format string specifier. Since we're printing it > as unsigned hex anyway, cast to size_t to silence the warning. Hmm. I wonder if mingw headers are mixing '

Re: [Qemu-devel] [PATCH 2/2] target-ppc: Cast ssize_t to size_t before printing with %zx

2014-12-23 Thread Peter Maydell
On 23 December 2014 at 22:36, Stefan Weil wrote: > Am 23.12.2014 um 23:22 schrieb Peter Maydell: >> --- a/hw/ppc/spapr.c >> +++ b/hw/ppc/spapr.c >> @@ -1438,7 +1438,7 @@ static void ppc_spapr_init(MachineState *machine) >> } >> if (spapr->rtas_size > RTAS_MAX_SIZE) { >> hw_er

[Qemu-devel] [PATCH 1/2] target-s390x: Mark op_csp() as !CONFIG_USER_ONLY

2014-12-23 Thread Peter Maydell
The function op_csp() is only used in the softmmu configs; wrap it in an #ifndef CONFIG_USER_ONLY to avoid clang warnings on the linux-user builds. Signed-off-by: Peter Maydell --- target-s390x/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-s390x/translate.c b/target-s3

Re: [Qemu-devel] [PATCH 2/2] target-ppc: Cast ssize_t to size_t before printing with %zx

2014-12-23 Thread Stefan Weil
Am 23.12.2014 um 23:22 schrieb Peter Maydell: The mingw32 compiler complains about trying to print variables of type ssize_t with the %z format string specifier. Since we're printing it as unsigned hex anyway, cast to size_t to silence the warning. Signed-off-by: Peter Maydell --- I suspect tha

[Qemu-devel] [PATCH 1/3] tests/hd-geo-test.c: Remove unused test_image variable

2014-12-23 Thread Peter Maydell
Remove unused variable test_image; this silences a clang warning. Signed-off-by: Peter Maydell --- tests/hd-geo-test.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index 7cc8dff..00afc20 100644 --- a/tests/hd-geo-test.c +++ b/tests/hd-geo-test.c

[Qemu-devel] [PATCH 2/3] translate-all: Mark map_exec() with the 'unused' attribute

2014-12-23 Thread Peter Maydell
From: SeokYeon Hwang Mark map_exec() with the 'unused' attribute to avoid '-Wunused-function' warnings on clang 3.4 or later. This means we don't need to mark it 'inline', which is what we were previously using to suppress the warning (a trick which only works with gcc, not clang). Signed-off-by

[Qemu-devel] [PATCH 3/3] migration/qemu-file.c: Don't shift left into sign bit

2014-12-23 Thread Peter Maydell
Add a cast in qemu_get_be32() to avoid shifting left into the sign bit of a signed integer (which is undefined behaviour in C). Signed-off-by: Peter Maydell --- migration/qemu-file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/qemu-file.c b/migration/qemu-file.c

[Qemu-devel] [PATCH 0/3] miscellaneous minor clang fixes

2014-12-23 Thread Peter Maydell
This is a collection of three miscellaneous minor fixes for clang compile warnings, which I think could reasonably go via the -trivial tree. The map_exec patch has been on list and reviewed before; the other two are new. Peter Maydell (2): tests/hd-geo-test.c: Remove unused test_image variable

[Qemu-devel] [PATCH] target-tricore: Add missing ULL suffix on 64 bit constant

2014-12-23 Thread Peter Maydell
Add a missing ULL suffix to a 64 bit constant: this suppresses a compiler warning from mingw32 gcc. Signed-off-by: Peter Maydell --- target-tricore/op_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-tricore/op_helper.c b/target-tricore/op_helper.c index 13e272

[Qemu-devel] [PATCH 1/2] target-ppc: Mark SR() and gen_sync_exception() as !CONFIG_USER_ONLY

2014-12-23 Thread Peter Maydell
The functions SR() and gen_sync_exception() are only used in softmmu configs; wrap them in #ifndef CONFIG_USER_ONLY to suppress clang warnings on the linux-user builds. Signed-off-by: Peter Maydell --- target-ppc/translate.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target-ppc/tra

[Qemu-devel] [PATCH 0/2] s390: fix clang warnings

2014-12-23 Thread Peter Maydell
These two patches fix warnings generated by clang; I'm hoping we can clear up the handful of remaining clang warnings so I can turn on warnings-as-errors for my builds I do before applying pullreqs, and then we can keep the clang builds warning-free. For the disassembler code, I opted to simply de

[Qemu-devel] [PATCH 2/2] target-ppc: Cast ssize_t to size_t before printing with %zx

2014-12-23 Thread Peter Maydell
The mingw32 compiler complains about trying to print variables of type ssize_t with the %z format string specifier. Since we're printing it as unsigned hex anyway, cast to size_t to silence the warning. Signed-off-by: Peter Maydell --- I suspect that this is a compiler bug, but this is the only i

[Qemu-devel] [PATCH 0/2] target-ppc: Fix clang and w32 warnings

2014-12-23 Thread Peter Maydell
These patches fix compiler warnings from clang and the mingw32 compiler; the aim is to get to a point where we can make the warnings into errors for both these builds. Peter Maydell (2): target-ppc: Mark SR() and gen_sync_exception() as !CONFIG_USER_ONLY target-ppc: Cast ssize_t to size_t befo

[Qemu-devel] [PATCH 2/2] disas/s390.c: Remove unused variables

2014-12-23 Thread Peter Maydell
The variables s390_opformats and s390_num_opformats are unused and provoke clang warnings: disas/s390.c:849:33: warning: variable 's390_opformats' is not needed and will not be emitted [-Wunneeded-internal-declaration] static const struct s390_opcode s390_opformats[] =

Re: [Qemu-devel] [PATCH v6 00/11] fw_cfg, bootorder, and UEFI+'-kernel' on arm/virt

2014-12-23 Thread Laszlo Ersek
On 12/22/14 13:11, Paolo Bonzini wrote: > The only change from v5 to v6 is that sysbus_mmio_map is moved to > fw_cfg_init_mem. (And fw_cfg_init1 returns void because it's now > simpler that way). > > This causes changes in patches 1, 5 and 6. > > I did not have the ARM firmware built, so I teste

[Qemu-devel] [PATCH 3/5] target-sparc: is_translating_asi() is TARGET_SPARC64 only

2014-12-23 Thread Peter Maydell
Move the is_translating_asi() inside the TARGET_SPARC64 ifdef (and remove the unimplemented 32-bit codepath), as it is only called from TARGET_SPARC64 code. This fixes a clang 3.4 unused-function warning. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-sparc/ldst_helper.c

[Qemu-devel] '-usb' regressed by 49d2e648 ("machine: remove qemu_machine_opts global list")

2014-12-23 Thread Laszlo Ersek
Apologies if this problem is known. After building qemu at ab0302ee: $ qemu-system-x86_64 -usb qemu-system-x86_64: util/qemu-option.c:387: qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed. The stack is #0 0x71e945c9 in raise () from /lib64/lib

[Qemu-devel] [PATCH 1/5] target-sparc: Remove unused gen_op_subi_cc and gen_op_addi_cc

2014-12-23 Thread Peter Maydell
The functions gen_op_addi_cc() and gen_op_subi_cc() are unused; remove them. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-sparc/translate.c | 24 1 file changed, 24 deletions(-) diff --git a/target-sparc/translate.c b/target-sparc/translate.c

[Qemu-devel] [PATCH 4/5] target-sparc: Mark gen_load_trap_state_at_tl() as !CONFIG_USER_ONLY

2014-12-23 Thread Peter Maydell
The function gen_load_trap_state_at_tl() is only used in the softmmu configs; wrap it in #ifndef CONFIG_USER_ONLY to avoid clang compiler warnings in linux-user builds. Signed-off-by: Peter Maydell --- target-sparc/translate.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target-sparc/tr

[Qemu-devel] [PATCH 2/5] target-sparc: address_mask(), asi_address_mask() are TARGET_SPARC64 only

2014-12-23 Thread Peter Maydell
The address_mask() and asi_address_mask() functions are only used in TARGET_SPARC64 configs, so guard with ifdefs to avoid warnings about unused functions in 32-bit builds. Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson --- target-sparc/ldst_helper.c | 4 1 file changed, 4 ins

[Qemu-devel] [PATCH 5/5] disas/sparc: Remove unused data sparc_opcode_archs[]

2014-12-23 Thread Peter Maydell
Remove sparc_opcode_archs and the macros which use it, because we don't use them in QEMU and they provoke clang warnings: disas/sparc.c:307:39: warning: unused variable 'sparc_opcode_archs' [-Wunused-const-variable] static const struct sparc_opcode_arch sparc_opcode_archs[] =

[Qemu-devel] [PATCH 0/5] SPARC: fix clang warnings

2014-12-23 Thread Peter Maydell
These patches fix warnings generated by clang. Patches 1-3 have been onlist before (and reviewed by RTH) but didn't get applied I think because of a mixup between me and Mark about which tree they should go in by. 4 and 5 are new. Peter Maydell (5): target-sparc: Remove unused gen_op_subi_cc and

Re: [Qemu-devel] [PATCH 04/12] spapr_pci: add set-indicator RTAS interface

2014-12-23 Thread Michael Roth
Quoting Bharata B Rao (2014-11-30 22:57:48) > On Wed, Nov 26, 2014 at 11:57 AM, Michael Roth > wrote: > > https://github.com/mdroth/qemu/commits/spapr-pci-hotplug-ppc-next-cleanup4.2 > > > > The sPAPRDREntry stuff is now modeled by the sPAPRDRConnector QOM object in > > hw/ppc/spapr_drc.c, which m

Re: [Qemu-devel] [PATCH] scripts/qapi-types.py: Add dummy member to empty structs

2014-12-23 Thread Eric Blake
On 12/23/2014 11:24 AM, Peter Maydell wrote: > Make sure that all generated C structs have at least one field; this > avoids potential issues with attempting to malloc space for > zero-length structs in C (g_malloc(sizeof struct) would return NULL). > It also avoids an incompatibility with C++ (whe

[Qemu-devel] [PATCH] pci: allow 0 address for PCI IO/MEM regions

2014-12-23 Thread Michael Roth
Some kernels program a 0 address for io regions. PCI 3.0 spec section 6.2.5.1 doesn't seem to disallow this. Signed-off-by: Michael Roth --- hw/pci/pci.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 371699c..8dda27d 100644 --- a/hw/pc

[Qemu-devel] [PATCH 0/1] pci: allow 0 address for PCI IO/MEM regions

2014-12-23 Thread Michael Roth
This patch enables the programming of address 0 for IO/MMIO BARs for PCI devices. It was originally included as part of a series implementing PCI hotplug for pseries guests, where it is needed due to the fact that pseries guests access IO space via MMIO, and that IO space is dedicated to PCI devic

[Qemu-devel] [PATCH] scripts/qapi-types.py: Add dummy member to empty structs

2014-12-23 Thread Peter Maydell
Make sure that all generated C structs have at least one field; this avoids potential issues with attempting to malloc space for zero-length structs in C (g_malloc(sizeof struct) would return NULL). It also avoids an incompatibility with C++ (where an empty struct is size 1); that isn't important t

Re: [Qemu-devel] [PATCH 1/2] target-arm : update reference manual chapter number

2014-12-23 Thread Peter Maydell
On 23 December 2014 at 16:25, Chih-Min Chao wrote: > Update the reference manual version to DDI0487A_c > > Instruction set encoding is moved from C3 to C4 > Instruction set Description is moved from C5/C6 to C6/C7 I appreciate the idea, but the trouble is that we could find ourselves

Re: [Qemu-devel] [PULL 00/31] target-arm queue

2014-12-23 Thread Peter Maydell
On 23 December 2014 at 13:53, Peter Maydell wrote: > Two major things in this pull: > * finally getting to the point when we can actually enable TrustZone >(for 32 bit CPUs); there's more to come next year, notably GIC support, >but this is now something people can actually use > * suppo

[Qemu-devel] "Bite-sized tasks"

2014-12-23 Thread Paolo Bonzini
I got this name from Google Code-In. QEMU is not participating, but the idea of providing small tasks to get familiar with the code base is a good one. I started a page at http://wiki.qemu.org/BiteSizedTasks and you are welcome to contribute! Paolo

[Qemu-devel] [PATCH] net: remove all cleanup methods from NIC NetClientInfos

2014-12-23 Thread Paolo Bonzini
All NICs have a cleanup function that, in most cases, zeroes the pointer to the NICState. In some cases, it frees data belonging to the NIC. However, this function is never called except when exiting from QEMU. It is not necessary to NULL pointers and free data here; the right place to do that wo

[Qemu-devel] [PATCH] net: synchronize net_host_device_remove with host_net_remove_completion

2014-12-23 Thread Paolo Bonzini
Using net_host_check_device is unnecessary. qemu_del_net_client asserts for the non-peer case that it can only process NIC type NetClientStates, and that assertion is valid for the peered case as well, so move it and use the same check in net_host_device_remove. host_net_remove_completion is alre

Re: [Qemu-devel] [PATCH] block/iscsi: fix uninitialized variable

2014-12-23 Thread Paolo Bonzini
On 23/12/2014 16:30, Peter Wu wrote: > 'ret' was never initialized in the success path. > > Signed-off-by: Peter Wu > --- > Hi, > > Found this warning when compiling with --enable-debug. This issue was > previously > fixed as part of Peter Lieven's patch series[1] but it never seemed to get >

[Qemu-devel] [PATCH 2/2] target-arm : update section number of decoder reference manual

2014-12-23 Thread Chih-Min Chao
The changes are based on reference manual version, DDI0487A_c, and most of them are SIMD related sub-chapter Signed-off-by: Chih-Min Chao --- target-arm/translate-a64.c | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/target-arm/t

[Qemu-devel] [PATCH 1/2] target-arm : update reference manual chapter number

2014-12-23 Thread Chih-Min Chao
Update the reference manual version to DDI0487A_c Instruction set encoding is moved from C3 to C4 Instruction set Description is moved from C5/C6 to C6/C7 Signed-off-by: Chih-Min Chao --- target-arm/helper-a64.c| 2 +- target-arm/translate-a64.c | 228 +++--

Re: [Qemu-devel] [PATCH v10 00/13] block: Incremental backup series (RFC)

2014-12-23 Thread John Snow
On 12/23/2014 06:48 AM, Vladimir Sementsov-Ogievskiy wrote: On 23.12.2014 04:12, John Snow wrote: For convenience, this patchset is available on github: https://github.com/jnsnow/qemu/commits/dbm-backup - old version here. My apologies. I've corrected it now. Thank you, --

Re: [Qemu-devel] QAPI and empty structs

2014-12-23 Thread Eric Blake
On 12/23/2014 08:50 AM, Peter Maydell wrote: > In qapi-schema.json we have a couple of entries that define > empty structures, like this: > > { 'type': 'ChardevDummy', 'data': { } } > > In the generated qapi-types.h these are turned into empty C structs: > > Although you could argue that we don

[Qemu-devel] QAPI and empty structs

2014-12-23 Thread Peter Maydell
In qapi-schema.json we have a couple of entries that define empty structures, like this: { 'type': 'ChardevDummy', 'data': { } } In the generated qapi-types.h these are turned into empty C structs: struct ChardevDummy { }; and clang warns about them: ./qapi-types.h:3752:1: warning: empty struct

[Qemu-devel] [PATCH] block/iscsi: fix uninitialized variable

2014-12-23 Thread Peter Wu
'ret' was never initialized in the success path. Signed-off-by: Peter Wu --- Hi, Found this warning when compiling with --enable-debug. This issue was previously fixed as part of Peter Lieven's patch series[1] but it never seemed to get merged. Kinds regards, Peter [1]: https://lists.gnu.org/

[Qemu-devel] [Bug 1405176] [NEW] ctrl+alt+2 not work on gtk display

2014-12-23 Thread Lingyu Zhu
Public bug reported: I download 2.2.0 release on http://wiki.qemu.org/Download the monitor console does not appear in gtk display but works for sdl and vnc. my gtk is 3.12.2 ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a

Re: [Qemu-devel] [PULL 00/14] QEMU: VFIO updates

2014-12-23 Thread Peter Maydell
On 22 December 2014 at 20:43, Alex Williamson wrote: > The following changes since commit b574f602680d41c4cf4a9c106e3e2244bed01cdd: > > Merge remote-tracking branch 'remotes/kraxel/tags/pull-vga-20141216-1' into > staging (2014-12-17 19:22:42 +) > > are available in the git repository at: >

Re: [Qemu-devel] [PATCH for 2.3 v2 1/1] xen-hvm: increase maxmem before calling xc_domain_populate_physmap

2014-12-23 Thread Don Slutz
Ping. On 12/03/14 08:15, Don Slutz wrote: From: Stefano Stabellini Increase maxmem before calling xc_domain_populate_physmap_exact to avoid the risk of running out of guest memory. This way we can also avoid complex memory calculations in libxl at domain construction time. This patch fixes an

[Qemu-devel] [PULL 21/31] fw_cfg: hard separation between the MMIO and I/O port mappings

2014-12-23 Thread Peter Maydell
From: Laszlo Ersek We are going to introduce a wide data register for fw_cfg, but only for the MMIO mapped device. The wide data register will also require the tightening of endiannesses. However we don't want to touch the I/O port mapped fw_cfg device at all. Currently QEMU provides a single f

[Qemu-devel] [PULL 04/31] vl.c: simplified machine_set_property

2014-12-23 Thread Peter Maydell
From: Marcel Apfelbaum Refactored the code to re-use object_property_parse. Signed-off-by: Marcel Apfelbaum Reviewed-by: Alexander Graf Reviewed-by: Greg Bellows Message-id: 1418217570-15517-3-git-send-email-marce...@redhat.com Signed-off-by: Peter Maydell --- vl.c | 5 + 1 file changed

[Qemu-devel] [PULL 19/31] target-arm: Disable EL3 on unsupported machines

2014-12-23 Thread Peter Maydell
From: Greg Bellows Disables the CPU ARM_FEATURE_EL3 featuere on machine models that can be configured to use Cortex-A9, Cortex-A15, and ARM1176 but don't officially support EL3. This preserves backwards compatibility. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell Message-id: 14186849

[Qemu-devel] [PULL 11/31] target-arm: Add virt class and machine types

2014-12-23 Thread Peter Maydell
From: Greg Bellows Switch virt qemu machine support to use the newer object type, class, and instance model. Added virt TypeInfo with static registration along with virt specific class and machine structs. Also added virt class initialization method. Signed-off-by: Greg Bellows Reviewed-by: P

[Qemu-devel] [PULL 07/31] target-arm: Add vexpress a9 & a15 machine objects

2014-12-23 Thread Peter Maydell
From: Greg Bellows Add Vexpress machine objects for the the Cortex A9 & A15 variants. The older style QEMUMachine types were replaced with dedicated TypeInfo objects. The new objects include dedicated class init functions that currently ustilze dedicated machine init methods. The previous qemu_

[Qemu-devel] [PULL 18/31] target-arm: Breakout integratorcp and versatilepb cpu init

2014-12-23 Thread Peter Maydell
From: Greg Bellows This commit changes the integratorcp and versatilepb CPU initialization from using the generic ARM cpu_arm_init function to doing it inline. This is necessary in order to allow CPU configuration changes to occur between CPU instance initialization and realization. Specificall

[Qemu-devel] [PULL 16/31] target-arm: Enable CPU has_el3 prop during VE init

2014-12-23 Thread Peter Maydell
From: Greg Bellows Adds setting of the CPU has_el3 property based on the vexpress machine secure state property during initialization. This enables/disables EL3 state during start-up. Changes include adding an additional secure state boolean during vexpress CPU initialization. Also enables the

[Qemu-devel] [PULL 27/31] fw_cfg_mem: expose the "data_width" property with fw_cfg_init_mem_wide()

2014-12-23 Thread Peter Maydell
From: Laszlo Ersek We rebase fw_cfg_init_mem() to the new function for compatibility with current callers. The behavior of the (big endian) multi-byte data reads is best shown with a qtest session. Here, we are reading the first six bytes of the UUID $ arm-softmmu/qemu-system-arm -M virt -

[Qemu-devel] [PULL 22/31] fw_cfg: move boards to fw_cfg_init_io() / fw_cfg_init_mem()

2014-12-23 Thread Peter Maydell
From: Laszlo Ersek This allows us to drop the fw_cfg_init() shim and to enforce the possible mappings at compile time. Signed-off-by: Laszlo Ersek Signed-off-by: Paolo Bonzini Message-id: 1419250305-31062-3-git-send-email-pbonz...@redhat.com Signed-off-by: Peter Maydell --- hw/i386/pc.c

[Qemu-devel] [PULL 29/31] hw/loader: split out load_image_gzipped_buffer()

2014-12-23 Thread Peter Maydell
From: Laszlo Ersek In the next patch we'd like to reuse the image decompression facility without installing the output as a ROM at a specific guest-phys address. In addition, expose LOAD_IMAGE_MAX_GUNZIP_BYTES, because that's a straightforward "max_sz" argument for the new load_image_gzipped_buf

[Qemu-devel] [PULL 02/31] target-arm: Merge EL3 CP15 register lists

2014-12-23 Thread Peter Maydell
From: Greg Bellows Merge of the v8_el2_cp_reginfo and el3_cp_reginfo ARMCPRegInfo lists. Previously, some EL3 registers were restricted to the ARMv8 list under the impression that they were not needed on ARMv7. However, this is not the case as the ARMv7/32-bit variants rely on the ARMv8/64-bit v

[Qemu-devel] [PULL 17/31] target-arm: Set CPU has_el3 prop during virt init

2014-12-23 Thread Peter Maydell
From: Greg Bellows Adds setting of the CPU has_el3 property based on the virt machine secure state property during initialization. This enables/disables EL3 state during start-up. Changes include adding an additional secure state boolean during virt CPU initialization. Also disables the ARM se

[Qemu-devel] [PULL 12/31] target-arm: Add virt machine secure property

2014-12-23 Thread Peter Maydell
From: Greg Bellows Add "secure" virt machine specific property to allow override of the default secure state configuration. By default, when using the QEMU -kernel command line argument, virt machines boot into NS/SVC. When using the QEMU -bios command line argument, virt machines boot into S/S

[Qemu-devel] [PULL 05/31] vl.c: add HMP help to machine

2014-12-23 Thread Peter Maydell
From: Marcel Apfelbaum The help is based on the actual machine properties exposing only the relevant options. Signed-off-by: Marcel Apfelbaum Reviewed-by: Alexander Graf Reviewed-by: Greg Bellows Message-id: 1418217570-15517-4-git-send-email-marce...@redhat.com Signed-off-by: Peter Maydell -

Re: [Qemu-devel] [PATCH 4/4] block: vhdx - set .bdrv_has_zero_init to bdrv_has_zero_init_1

2014-12-23 Thread Jeff Cody
On Tue, Dec 23, 2014 at 05:07:16AM -0500, Lokesha, Amulya wrote: > > -Original Message- > From: Jeff Cody [mailto:jc...@redhat.com] > Sent: Wednesday, December 17, 2014 5:44 PM > To: Lokesha, Amulya > Cc: Max Reitz; qemu-devel@nongnu.org; kw...@redhat.com; stefa...@redhat.com > Subject: R

[Qemu-devel] [PULL 30/31] hw/arm: pass pristine kernel image to guest firmware over fw_cfg

2014-12-23 Thread Peter Maydell
From: Laszlo Ersek Introduce the new boolean field "arm_boot_info.firmware_loaded". When this field is set, it means that the portion of guest DRAM that the VCPU normally starts to execute, or the pflash chip that the VCPU normally starts to execute, has been populated by board-specific code with

[Qemu-devel] [PULL 15/31] target-arm: Add arm_boot_info secure_boot control

2014-12-23 Thread Peter Maydell
From: Greg Bellows Adds the secure_boot boolean field to the arm_boot_info descriptor. This fields is used to indicate whether Linux should boot into secure or non-secure state if the ARM EL3 feature is enabled. The default is to leave the CPU in an unaltered reset state. On EL3 enabled system

[Qemu-devel] [PULL 01/31] audio: Don't free hw resources until after hw backend is stopped

2014-12-23 Thread Peter Maydell
When stopping an audio voice, call the audio backend's fini method before calling audio_pcm_hw_free_resources_ rather than afterwards. This allows backends which use helper threads (like pulseaudio) to terminate those threads before the conv_buf or mix_buf are freed and avoids race conditions where

[Qemu-devel] [PULL 06/31] target-arm: Add vexpress class and machine types

2014-12-23 Thread Peter Maydell
From: Greg Bellows Adds base Vexpress class and machine objects and infrastructure. This is in preparation for switching to the full QEMU object model. The base vexpress infrastructure is intended to handle common vexpress details. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell Messa

[Qemu-devel] [PULL 03/31] machine: remove qemu_machine_opts global list

2014-12-23 Thread Peter Maydell
From: Marcel Apfelbaum QEMU has support for options per machine, keeping a global list of options is no longer necessary. Signed-off-by: Marcel Apfelbaum Reviewed-by: Alexander Graf Reviewed-by: Greg Bellows Message-id: 1418217570-15517-2-git-send-email-marce...@redhat.com Signed-off-by: Pete

[Qemu-devel] [PULL 26/31] fw_cfg_mem: introduce the "data_width" property

2014-12-23 Thread Peter Maydell
From: Laszlo Ersek The "data_width" property is capable of changing the maximum valid access size to the MMIO data register, and resizes the memory region similarly, at device realization time. The default value of "data_memwidth" is set so that we don't yet diverge from "fw_cfg_data_mem_ops".

[Qemu-devel] [PULL 14/31] target-arm: Add ARMCPU secure property

2014-12-23 Thread Peter Maydell
From: Greg Bellows Added a "has_el3" state property to the ARMCPU descriptor. This property indicates whether the ARMCPU has security extensions enabled (EL3) or not. By default it is disabled at this time. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell Message-id: 1418684992-8996-10-

[Qemu-devel] [PULL 24/31] fw_cfg_mem: flip ctl_mem_ops and data_mem_ops to DEVICE_BIG_ENDIAN

2014-12-23 Thread Peter Maydell
From: Laszlo Ersek The standalone selector port (fw_cfg_ctl_mem_ops) is only used by big endian guests to date (*), hence this change doesn't regress them. Paolo and Alex have suggested / requested an explicit DEVICE_BIG_ENDIAN setting here, for clarity. (*) git grep -l fw_cfg_init_mem hw/n

[Qemu-devel] [PULL 23/31] fw_cfg_mem: max access size and region size are the same for data register

2014-12-23 Thread Peter Maydell
From: Laszlo Ersek Make it clear that the maximum access size to the MMIO data register determines the full size of the memory region. Currently the max access size is 1. This patch doesn't change behavior. Signed-off-by: Laszlo Ersek Signed-off-by: Paolo Bonzini Message-id: 1419250305-31062

[Qemu-devel] [PULL 13/31] target-arm: Add feature unset function

2014-12-23 Thread Peter Maydell
From: Greg Bellows Add an unset_feature() function to compliment the set_feature() function. This will be used to disable functions after they have been enabled during initialization. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell Message-id: 1418684992-8996-9-git-send-email-greg.bell

[Qemu-devel] [PULL 20/31] target-arm: add cpu feature EL3 to CPUs with Security Extensions

2014-12-23 Thread Peter Maydell
From: Fabian Aggeler Set ARM_FEATURE_EL3 feature for CPUs that implement Security Extensions. Signed-off-by: Fabian Aggeler Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell Message-id: 1418684992-8996-16-git-send-email-greg.bell...@linaro.org Signed-off-by: Peter Maydell --- target-ar

[Qemu-devel] [PULL 09/31] target-arm: Add vexpress machine secure property

2014-12-23 Thread Peter Maydell
From: Greg Bellows Add "secure" Vexpress machine specific property to allow override of the default secure state configuration. By default, when using the QEMU -kernel command line argument, Vexpress machines boot into NS/SVC. When using the QEMU -bios command line argument, Vexpress machines b

[Qemu-devel] [PULL 10/31] target-arm: Change vexpress daughterboard init arg

2014-12-23 Thread Peter Maydell
From: Greg Bellows Change the Vexpress daughterboard initialization method to take a vexpress machine state pointer instead of the daughterboard struct pointer. The machine state now contains the daughterboard pointer. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell Message-id: 1418684

[Qemu-devel] [PULL 00/31] target-arm queue

2014-12-23 Thread Peter Maydell
ory at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20141223 for you to fetch changes up to aa351061dbb0e3054db11c00a69395785c4186c8: hw/arm/virt: enable passing of EFI-stubbed kernel to guest UEFI firmware (2014-12-22

[Qemu-devel] [PULL 08/31] target-arm: Switch to common vexpress machine init

2014-12-23 Thread Peter Maydell
From: Greg Bellows Switched the Vexpress machine initialization to use the common function with the machine pointer to board info. Signed-off-by: Greg Bellows Reviewed-by: Peter Maydell Message-id: 1418684992-8996-4-git-send-email-greg.bell...@linaro.org Signed-off-by: Peter Maydell --- hw/a

[Qemu-devel] [PULL 28/31] arm: add fw_cfg to "virt" board

2014-12-23 Thread Peter Maydell
From: Laszlo Ersek fw_cfg already supports exposure over MMIO (used in ppc/mac_newworld.c, ppc/mac_oldworld.c, sparc/sun4m.c); we can easily add it to the "virt" board. Because MMIO access is slow on ARM KVM, we enable the guest, with fw_cfg_init_mem_wide(), to transfer up to 8 bytes with a sing

[Qemu-devel] [PULL 31/31] hw/arm/virt: enable passing of EFI-stubbed kernel to guest UEFI firmware

2014-12-23 Thread Peter Maydell
From: Laszlo Ersek The virt board already ensures mutual exclusion between -bios and -pflash unit#0; we only need to set "bootinfo.firmware_loaded", introduced in the previous patch, if either of those options was used to load the guest firmware. Signed-off-by: Laszlo Ersek Reviewed-by: Peter M

[Qemu-devel] [PULL 25/31] exec: allows 8-byte accesses in subpage_ops

2014-12-23 Thread Peter Maydell
From: Paolo Bonzini Otherwise fw_cfg accesses are split into 4-byte ones before they reach the fw_cfg ops / handlers. Signed-off-by: Paolo Bonzini Signed-off-by: Laszlo Ersek Signed-off-by: Paolo Bonzini Message-id: 1419250305-31062-6-git-send-email-pbonz...@redhat.com Signed-off-by: Peter Ma

[Qemu-devel] [PATCH v4 13/17] spapr_pci: create DRConnectors for each PCI slot during PHB realize

2014-12-23 Thread Michael Roth
These will be used to support hotplug/unplug of PCI devices to the PCI bus associated with a particular PHB. Signed-off-by: Michael Roth --- hw/ppc/spapr_pci.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c index 4850f9a..73e86a4 100644 -

[Qemu-devel] [PATCH v4 12/17] spapr_pci: add dynamic-reconfiguration option for spapr-pci-host-bridge

2014-12-23 Thread Michael Roth
This option enables/disables PCI hotplug for a particular PHB. Also add machine compatibility code to disable it by default for machine types prior to pseries-2.3. Signed-off-by: Michael Roth --- hw/ppc/spapr.c | 21 + hw/ppc/spapr_pci.c | 2 ++ includ

[Qemu-devel] [PATCH v4 15/17] pci: make pci_bar useable outside pci.c

2014-12-23 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/pci/pci.c | 2 +- include/hw/pci/pci.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index 371699c..bf16fc8 100644 --- a/hw/pci/pci.c +++ b/hw/pci/pci.c @@ -122,7 +122,7 @@ static uint16_t pci_default_su

[Qemu-devel] [PATCH v4 11/17] spapr: introduce pseries-2.3 machine type

2014-12-23 Thread Michael Roth
And make it the default. This is identical to pseries-2.2 for now, but subsequent commits will use it to enable pseries-2.3+ features. Signed-off-by: Michael Roth --- hw/ppc/spapr.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/s

[Qemu-devel] [PATCH v4 10/17] spapr_drc: add spapr_drc_populate_dt()

2014-12-23 Thread Michael Roth
This function handles generation of ibm,drc-* array device tree properties to describe DRC topology to guests. This will by used by the guest to direct RTAS calls to manage any dynamic resources we associate with a particular DR Connector as part of hotplug/unplug. Since general management of boot

[Qemu-devel] [PATCH v4 08/17] spapr_events: re-use EPOW event infrastructure for hotplug events

2014-12-23 Thread Michael Roth
From: Nathan Fontenot This extends the data structures currently used to report EPOW events to gets via the check-exception RTAS interfaces to also include event types for hotplug/unplug events. This is currently undocumented and being finalized for inclusion in PAPR specification, but we implem

[Qemu-devel] [PATCH v4 17/17] spapr_pci: emit hotplug add/remove events during hotplug

2014-12-23 Thread Michael Roth
From: Tyrel Datwyler This uses extension of existing EPOW interrupt/event mechanism to notify userspace tools like librtas/drmgr to handle in-guest configuration/cleanup operations in response to device_add/device_del. Userspace tools that don't implement this extension will need to be run manua

[Qemu-devel] [PATCH v4 06/17] spapr: add rtas_st_buffer_direct() helper

2014-12-23 Thread Michael Roth
This is similar to the existing rtas_st_buffer(), but for case where the guest is not expecting a length-encoded byte array. Namely, for calls where an "work area" buffer is used to pass around arbitrary fields/data. Signed-off-by: Michael Roth --- include/hw/ppc/spapr.h | 10 -- 1 file

[Qemu-devel] [PATCH v4 09/17] spapr_events: event-scan RTAS interface

2014-12-23 Thread Michael Roth
From: Tyrel Datwyler We don't actually rely on this interface to surface hotplug events, and instead rely on the similar-but-interrupt-driven check-exception RTAS interface used for EPOW events. However, the existence of this interface is needed to ensure guest kernels initialize the event-report

[Qemu-devel] [PATCH v4 07/17] spapr_rtas: add ibm, configure-connector RTAS interface

2014-12-23 Thread Michael Roth
Signed-off-by: Michael Roth --- hw/ppc/spapr_rtas.c | 81 + 1 file changed, 81 insertions(+) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index 13e6e55..d847f45 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spapr_rtas.c @@ -422,6 +422

[Qemu-devel] [PATCH v4 16/17] spapr_pci: enable basic hotplug operations

2014-12-23 Thread Michael Roth
This enables hotplug for PHB bridges. Upon hotplug we generate the OF-nodes required by PAPR specification and IEEE 1275-1994 "PCI Bus Binding to Open Firmware" for the device. We associate the corresponding FDT for these nodes with the DrcEntry corresponding to the slot, which will be fetched via

[Qemu-devel] [PATCH v4 01/17] docs: add sPAPR hotplug/dynamic-reconfiguration documentation

2014-12-23 Thread Michael Roth
This adds a general overview of hotplug/dynamic-reconfiguration for sPAPR/pSeries guest. As specified in PAPR+ v2.7. Signed-off-by: Michael Roth --- docs/specs/ppc-spapr-hotplug.txt | 287 +++ 1 file changed, 287 insertions(+) create mode 100644 docs/specs/p

[Qemu-devel] [PATCH v4 03/17] spapr_rtas: add get/set-power-level RTAS interfaces

2014-12-23 Thread Michael Roth
From: Nathan Fontenot Signed-off-by: Nathan Fontenot Signed-off-by: Michael Roth --- hw/ppc/spapr_rtas.c | 25 + 1 file changed, 25 insertions(+) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index 2ec2a8e..a2fb533 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc

[Qemu-devel] [PATCH v4 05/17] spapr_rtas: add get-sensor-state RTAS interface

2014-12-23 Thread Michael Roth
From: Mike Day Signed-off-by: Mike Day Signed-off-by: Michael Roth --- hw/ppc/spapr_rtas.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c index 6aa325f..13e6e55 100644 --- a/hw/ppc/spapr_rtas.c +++ b/hw/ppc/spa

[Qemu-devel] [PATCH v4 02/17] spapr_drc: initial implementation of sPAPRDRConnector device

2014-12-23 Thread Michael Roth
This device emulates a firmware abstraction used by pSeries guests to manage hotplug/dynamic-reconfiguration of host-bridges, PCI devices, memory, and CPUs. It is conceptually similar to an SHPC device, complete with LED indicators to identify individual slots to physical physical users and indicat

[Qemu-devel] [PATCH v4 14/17] spapr_pci: populate DRC dt entries for PHBs

2014-12-23 Thread Michael Roth
Reserve 32 entries of type PCI in each PHB's initial FDT. This advertises to guests that each PHB is DR-capable device with physical hotpluggable slots. This is necessary for allowing hotplugging of devices to it later via bus rescan or guest rpaphp hotplug module. Signed-off-by: Michael Roth ---

[Qemu-devel] [PATCH v4 00/17] spapr: add support for pci hotplug

2014-12-23 Thread Michael Roth
These patches are based on ppc-next, and can also be obtained from: https://github.com/mdroth/qemu/commits/spapr-hotplug-pci-v4 v4: * added documentation for sPAPR-based hotplug (Alexey) * reworked DR Connectors to be QOM devices, where sensor/indicator states are accessed via RTAS via objec

  1   2   >